Просмотр исходного кода

* Leaked socket on failed address bind.

svn: 1604
Bryan Drewery 21 лет назад
Родитель
Сommit
d92380ef77
2 измененных файлов с 4 добавлено и 1 удалено
  1. 1 0
      doc/UPDATES
  2. 3 1
      src/net.c

+ 1 - 0
doc/UPDATES

@@ -11,6 +11,7 @@ This is a summary of ChangeLog basically.
 * Fixed cmd_comment bug with changing comment on lower level users.
 * Bots now unban bans that match *linked* bots, +m bans besides this will not be unset auto.
 * Fixed typo in help file (botconfig)
+* Fixed a leaked socket on failed address bind.
 
 1.2
 * No longer displaying SALTS on ./bin -v

+ 3 - 1
src/net.c

@@ -620,8 +620,10 @@ int open_telnet_raw(int sock, char *server, port_t sport)
   if ((is_resolved = is_dotted_ip(server))) {	/* already resolved */
     initialize_sockaddr(is_resolved, NULL, 0, &so);
 
-    if (bind(sock, &so.sa, SIZEOF_SOCKADDR(so)) < 0)
+    if (bind(sock, &so.sa, SIZEOF_SOCKADDR(so)) < 0) {
+      killsock(sock);
       return -1;
+    }
 
     initialize_sockaddr(is_resolved, host, port, &so);