No need to static_cast<String> anymore for Array.join()

src/cmds.cc

@@ -937,7 +937,7 @@ static void cmd_groups(int idx, char *par)
 
   if (botnick.length()) {
     dprintf(idx, "%s is in groups: %s\n", botnick.c_str(),
-        static_cast<bd::String>(botGroups[botnick].join(" ")).c_str());
+        botGroups[botnick].join(" ").c_str());
     dprintf(idx, "Total groups: %zu/%zu\n", botGroups[botnick].length(),
         groupBots.size());
   } else {
@@ -2130,7 +2130,7 @@ static void cmd_debug(int idx, char *par)
           }
         }
         dprintf(idx, "Role: %-8s: %s\n", chan->dname,
-            static_cast<bd::String>(roles.join(" ")).c_str());
+            roles.join(" ").c_str());
       }
     }
   }

src/mod/channels.mod/cmdschan.cc

@@ -1190,7 +1190,7 @@ static void cmd_chaninfo(int idx, char *par)
 /* FIXME: SHOW_CHAR() here */
     get_mode_protect(chan, work, sizeof(work));
     dprintf(idx, "Protect modes (chanmode): %s\n", work[0] ? work : "None");
-    dprintf(idx, "Groups: %s\n", chan->groups && chan->groups->length() ? static_cast<bd::String>(chan->groups->join(" ")).c_str() : "None");
+    dprintf(idx, "Groups: %s\n", chan->groups && chan->groups->length() ? chan->groups->join(" ").c_str() : "None");
     dprintf(idx, "FiSH Key: %s\n", chan->fish_key[0] ? chan->fish_key : "not set");
 //    dprintf(idx, "Protect topic (topic)   : %s\n", chan->topic[0] ? chan->topic : "");
 /* Chanchar template

src/mod/channels.mod/userchan.cc

@@ -735,7 +735,7 @@ flood-exempt %d flood-lock-time %d knock %d fish-key { %s } \
  *      temp,
  * also include temp %s in dprintf.
  */
-        chan->groups && chan->groups->length() ? static_cast<bd::String>(chan->groups->join(" ")).c_str() : "",
+        chan->groups && chan->groups->length() ? chan->groups->join(" ").c_str() : "",
 	chan->bad_cookie,
 	chan->manop,
 	chan->mdop,

src/mod/irc.mod/cmdsirc.cc

@@ -1450,7 +1450,7 @@ static void cmd_roles(int idx, char *par)
   for (roleidx = 0; role_counts[roleidx].name; roleidx++) {
     role = role_counts[roleidx].role;
     dprintf(idx, "  %-8s: %s\n", role_counts[roleidx].name,
-        static_cast<bd::String>((*chan->role_bots)[role].join(" ")).c_str());
+        (*chan->role_bots)[role].join(" ").c_str());
   }
 }