浏览代码

Fix handling of olddata for set: string.

var->mem is guaranteed to not be NULL by this point. Only
consider olddata valid if it has a length.

Spotted by:	scan-build false-positive a few lines below.
Bryan Drewery 11 年之前
父节点
当前提交
804bb6ca24
共有 1 个文件被更改,包括 1 次插入1 次删除
  1. 1 1
      src/set.cc

+ 1 - 1
src/set.cc

@@ -317,7 +317,7 @@ sdprintf("var (mem): %s -> %s", var->name, datain ? datain : "(NULL)");
       }
     }
   } else if (var->flags & (VAR_STRING|VAR_WORD)) {
-    char *olddata = ((char*) var->mem) ? strdup((char*) var->mem) : NULL;
+    char *olddata = ((char*) var->mem)[0] ? strdup((char*) var->mem) : NULL;
 
     if (data)
       strlcpy((char *) var->mem, data, var->size);