Procházet zdrojové kódy

No need to call irc_log as it does nothing.

Not sure if this is optimized out but the parameters
have function calls which are relatively expensive.
No need to call them all anyhow.
Bryan Drewery před 7 roky
rodič
revize
72c4102650
3 změnil soubory, kde provedl 7 přidání a 0 odebrání
  1. 1 0
      doc/UPDATES.md
  2. 2 0
      src/log.cc
  3. 4 0
      src/log.h

+ 1 - 0
doc/UPDATES.md

@@ -2,6 +2,7 @@
   * Clear FiSH keys when a client quits.
   * Clear FiSH keys when a client quits.
   * Fix crash when clearing last botset entry for a bot.
   * Fix crash when clearing last botset entry for a bot.
   * Bots now share channel key to other bots even if not opped.
   * Bots now share channel key to other bots even if not opped.
+  * Some small performance improvements
 
 
 # 1.4.9
 # 1.4.9
   * Fix various compile warnings and spam
   * Fix various compile warnings and spam

+ 2 - 0
src/log.cc

@@ -335,6 +335,7 @@ void putlog(int type, const char *chname, const char *format, ...)
   }
   }
 }
 }
 
 
+#if 0
 void
 void
 irc_log(struct chanset_t *chan, const char *format, ...)
 irc_log(struct chanset_t *chan, const char *format, ...)
 {
 {
@@ -362,4 +363,5 @@ irc_log(struct chanset_t *chan, const char *format, ...)
 */
 */
 #endif 
 #endif 
 }
 }
+#endif
 /* vim: set sts=2 sw=2 ts=8 et: */
 /* vim: set sts=2 sw=2 ts=8 et: */

+ 4 - 0
src/log.h

@@ -33,7 +33,11 @@ void putlog (int, const char *, const char *, ...) __attribute__((format(printf,
 int logmodes(const char *);
 int logmodes(const char *);
 char *masktype(int);
 char *masktype(int);
 char *maskname(int);
 char *maskname(int);
+#if 0
 void irc_log(struct chanset_t *, const char *, ...) __attribute__((format(printf, 2, 3)));
 void irc_log(struct chanset_t *, const char *, ...) __attribute__((format(printf, 2, 3)));
+#else
+#define irc_log(...)
+#endif
 void logfile(int type, const char *msg);
 void logfile(int type, const char *msg);
 
 
 extern int		conmask;
 extern int		conmask;