فهرست منبع

Fix potential fd leak in transer.mod dcc sending

Reported by:	cppcheck
Bryan Drewery 12 سال پیش
والد
کامیت
56861a9147
1فایلهای تغییر یافته به همراه2 افزوده شده و 2 حذف شده
  1. 2 2
      src/mod/transfer.mod/transfer.c

+ 2 - 2
src/mod/transfer.mod/transfer.c

@@ -851,11 +851,11 @@ static int raw_dcc_resend_send(char *filename, char *nick, char *from, int resen
   if (zz == (-1))
     return DCCSEND_NOSOCK;
   
+  if ((i = new_dcc(&DCC_GET_PENDING, sizeof(struct xfer_info))) == -1)
+     return DCCSEND_FULL;
   f = fopen(filename, "rb");
   if (!f)
     return DCCSEND_BADFN;
-  if ((i = new_dcc(&DCC_GET_PENDING, sizeof(struct xfer_info))) == -1)
-     return DCCSEND_FULL;
   dcc[i].sock = zz;
   dcc[i].addr = (in_addr_t) (-559026163);
   dcc[i].port = port;