Răsfoiți Sursa

Add new variant of Eurom 600 heater.

There seems to be a variant that uses dps 7 in place of 6.  Possibly the function is different too.

- for Eurom 600/601 revise the range to 0-37 as per the manual.  15-35 seems to have been copy and paste from another heater when the Eurom 600 was initially added.

Issue #96
Jason Rumney 4 ani în urmă
părinte
comite
ec61c9999a

+ 2 - 2
custom_components/tuya_local/devices/eurom_600_heater.yaml

@@ -18,8 +18,8 @@ primary_entity:
     - id: 2
     - id: 2
       type: integer
       type: integer
       range:
       range:
-        min: 15
-        max: 35
+        min: 0
+        max: 37
       name: temperature
       name: temperature
     - id: 5
     - id: 5
       type: integer
       type: integer

+ 46 - 0
custom_components/tuya_local/devices/eurom_600_heater_v2.yaml

@@ -0,0 +1,46 @@
+name: Eurom Mon Soleil 600 Heater
+primary_entity:
+  entity: climate
+  dps:
+    - id: 1
+      type: boolean
+      mapping:
+        - dps_val: false
+          value: "off"
+          icon: "mdi:radiator-disabled"
+          icon_priority: 1
+        - dps_val: true
+          value: "heat"
+          icon: "mdi:radiator"
+          icon_priority: 3
+      name: hvac_mode
+    - id: 2
+      type: integer
+      range:
+        min: 0
+        max: 37
+      name: temperature
+    - id: 5
+      type: integer
+      readonly: true
+      name: current_temperature
+    - id: 7
+      type: bitfield
+      mapping:
+        - dps_val: 0
+          value: "OK"
+      readonly: true
+      name: error
+secondary_entities:
+  - entity: binary_sensor
+    name: Error
+    category: diagnostic
+    class: problem
+    dps:
+      - id: 7
+        type: bitfield
+        name: sensor
+        mapping:
+          - dps_val: 0
+            value: false
+          - value: true

+ 2 - 2
custom_components/tuya_local/devices/eurom_601_heater.yaml

@@ -15,8 +15,8 @@ primary_entity:
     - id: 2
     - id: 2
       type: integer
       type: integer
       range:
       range:
-        min: 15
-        max: 35
+        min: 0
+        max: 37
       name: temperature
       name: temperature
     - id: 3
     - id: 3
       type: integer
       type: integer

+ 1 - 0
tests/const.py

@@ -24,6 +24,7 @@ GPCV_HEATER_PAYLOAD = {
 }
 }
 
 
 EUROM_600_HEATER_PAYLOAD = {"1": True, "2": 15, "5": 18, "6": 0}
 EUROM_600_HEATER_PAYLOAD = {"1": True, "2": 15, "5": 18, "6": 0}
+EUROM_600v2_HEATER_PAYLOAD = {"1": True, "2": 15, "5": 18, "7": 0}
 
 
 EUROM_601_HEATER_PAYLOAD = {"1": True, "2": 21, "3": 20, "6": False, "13": 0}
 EUROM_601_HEATER_PAYLOAD = {"1": True, "2": 21, "3": 20, "6": False, "13": 0}
 
 

+ 2 - 2
tests/devices/test_eurom_600_heater.py

@@ -29,8 +29,8 @@ class TestEurom600Heater(
         self.setUpTargetTemperature(
         self.setUpTargetTemperature(
             TEMPERATURE_DPS,
             TEMPERATURE_DPS,
             self.subject,
             self.subject,
-            min=15,
-            max=35,
+            min=0,
+            max=37,
         )
         )
         self.setUpBasicBinarySensor(
         self.setUpBasicBinarySensor(
             ERROR_DPS,
             ERROR_DPS,

+ 96 - 0
tests/devices/test_eurom_600v2_heater.py

@@ -0,0 +1,96 @@
+from homeassistant.components.binary_sensor import DEVICE_CLASS_PROBLEM
+from homeassistant.components.climate.const import (
+    HVAC_MODE_HEAT,
+    HVAC_MODE_OFF,
+    SUPPORT_TARGET_TEMPERATURE,
+)
+from homeassistant.const import STATE_UNAVAILABLE
+
+from ..const import EUROM_600v2_HEATER_PAYLOAD
+from ..helpers import assert_device_properties_set
+from ..mixins.binary_sensor import BasicBinarySensorTests
+from ..mixins.climate import TargetTemperatureTests
+from .base_device_tests import TuyaDeviceTestCase
+
+HVACMODE_DPS = "1"
+TEMPERATURE_DPS = "2"
+CURRENTTEMP_DPS = "5"
+ERROR_DPS = "7"
+
+
+class TestEurom600Heater(
+    BasicBinarySensorTests, TargetTemperatureTests, TuyaDeviceTestCase
+):
+    __test__ = True
+
+    def setUp(self):
+        self.setUpForConfig("eurom_600_heater_v2.yaml", EUROM_600v2_HEATER_PAYLOAD)
+        self.subject = self.entities.get("climate")
+        self.setUpTargetTemperature(
+            TEMPERATURE_DPS,
+            self.subject,
+            min=0,
+            max=37,
+        )
+        self.setUpBasicBinarySensor(
+            ERROR_DPS,
+            self.entities.get("binary_sensor_error"),
+            device_class=DEVICE_CLASS_PROBLEM,
+            testdata=(1, 0),
+        )
+        self.mark_secondary(["binary_sensor_error"])
+
+    def test_supported_features(self):
+        self.assertEqual(
+            self.subject.supported_features,
+            SUPPORT_TARGET_TEMPERATURE,
+        )
+
+    def test_icon(self):
+        self.dps[HVACMODE_DPS] = True
+        self.assertEqual(self.subject.icon, "mdi:radiator")
+
+        self.dps[HVACMODE_DPS] = False
+        self.assertEqual(self.subject.icon, "mdi:radiator-disabled")
+
+    def test_temperature_unit_returns_device_temperature_unit(self):
+        self.assertEqual(
+            self.subject.temperature_unit, self.subject._device.temperature_unit
+        )
+
+    def test_current_temperature(self):
+        self.dps[CURRENTTEMP_DPS] = 25
+        self.assertEqual(self.subject.current_temperature, 25)
+
+    def test_hvac_mode(self):
+        self.dps[HVACMODE_DPS] = True
+        self.assertEqual(self.subject.hvac_mode, HVAC_MODE_HEAT)
+
+        self.dps[HVACMODE_DPS] = False
+        self.assertEqual(self.subject.hvac_mode, HVAC_MODE_OFF)
+
+        self.dps[HVACMODE_DPS] = None
+        self.assertEqual(self.subject.hvac_mode, STATE_UNAVAILABLE)
+
+    def test_hvac_modes(self):
+        self.assertCountEqual(self.subject.hvac_modes, [HVAC_MODE_OFF, HVAC_MODE_HEAT])
+
+    async def test_turn_on(self):
+        async with assert_device_properties_set(
+            self.subject._device, {HVACMODE_DPS: True}
+        ):
+            await self.subject.async_set_hvac_mode(HVAC_MODE_HEAT)
+
+    async def test_turn_off(self):
+        async with assert_device_properties_set(
+            self.subject._device, {HVACMODE_DPS: False}
+        ):
+            await self.subject.async_set_hvac_mode(HVAC_MODE_OFF)
+
+    def test_error_state(self):
+        # There are currently no known error states; update this as
+        # they are discovered
+        self.dps[ERROR_DPS] = "something"
+        self.assertEqual(self.subject.extra_state_attributes, {"error": "something"})
+        self.dps[ERROR_DPS] = "0"
+        self.assertEqual(self.subject.extra_state_attributes, {"error": "OK"})

+ 2 - 2
tests/devices/test_eurom_601_heater.py

@@ -33,8 +33,8 @@ class TestEurom601Heater(
         self.setUpTargetTemperature(
         self.setUpTargetTemperature(
             TEMPERATURE_DPS,
             TEMPERATURE_DPS,
             self.subject,
             self.subject,
-            min=15,
-            max=35,
+            min=0,
+            max=37,
         )
         )
         self.setUpBasicBinarySensor(
         self.setUpBasicBinarySensor(
             ERROR_DPS,
             ERROR_DPS,