Changes mentioned in code review

custom_components/tuya_local/devices/alecoair_d12_home_dehumidifier.yaml

@@ -1,7 +1,7 @@
 name: AlecoAir D12 Home dehumidifier
 products:
   - id: hp1sjssyokokbrsg
-#    name: AlecoAir D12 Home
+   name: AlecoAir D12 Home
 primary_entity:
   entity: humidifier
   class: dehumidifier
@@ -11,21 +11,21 @@ primary_entity:
       type: boolean
       mapping:
         - dps_val: false
-          icon: "mdi:power"
+          icon: "mdi:air-humidifier-off"
           icon_priority: 1
         - dps_val: true
-          icon: "mdi:power"
+          icon: "mdi:air-humidifier"
           icon_priority: 4
     - id: 2
       name: mode
-      type: integer
+      type: string
       mapping:
         - dps_val: Continuous
-          value: 1
+          value: "1"
           icon: mdi:fan
           icon_priority: 3
         - dps_val: Auto
-          value: 0
+          value: "0"
           icon: "mdi:fan-auto"
           icon_priority: 3
     - id: 4
@@ -39,12 +39,10 @@ primary_entity:
     - id: 11
       name: error
       type: bitfield
-      # Docs mention E1 and E2, it isn't clear which is tank full, so for now
-      # treat both as that.
       mapping:
         - dps_val: 0
           value: OK
-        - dps_val: 1
+        - dps_val: 8
           value: E1
           icon: "mdi:cup-water"
           icon_priority: 2
@@ -53,20 +51,57 @@ primary_entity:
           icon: "mdi:cup-water"
           icon_priority: 2
 secondary_entities:
-  - entity: switch
-    name: Inside Drying
-    icon: "mdi:air-humidifier"
+  - entity: sensor
+    name: Current humidity
+    class: humidity
     dps:
-      - id: 101
+      - id: 3
+        type: integer
+        name: sensor
+        unit: "%"
+        class: measurement
+  - entity: select
+    name: Wind speed
+    icon: "mdi:fan"
+    category: config
+    dps:
+      - id: 6
+        name: option
+        type: string
+        mapping:
+          - dps_val: "0"
+            icon: "mdi:fan-speed-2"
+            icon_priority: 1
+          - dps_val: "1"
+            icon: "mdi:fan-speed-1"
+            icon_priority: 4
+  - entity: fan
+    dps:
+      - id: 6
+        type: boolean
         name: switch
+      - id: 5
+        type: string
+        name: speed
+        mapping:
+          - dps_val: "0"
+            icon: "mdi:fan-speed-2"
+            icon_priority: 1
+          - dps_val: "1"
+            icon: "mdi:fan-speed-1"
+            icon_priority: 4
+  - entity: lock
+    name: Child lock
+    category: config
+    dps:
+      - id: 7
         type: boolean
+        name: lock
         mapping:
           - dps_val: false
-            icon: "mdi:air-humidifier-off"
-            icon_priority: 1
+            icon: "mdi:hand-back-right"
           - dps_val: true
-            icon: "mdi:air-humidifier"
-            icon_priority: 4
+            icon: "mdi:hand-back-right-off"
   - entity: select
     name: Countdown
     icon: "mdi:timer"
@@ -74,153 +109,67 @@ secondary_entities:
     dps:
       - id: 12
         name: option
-        type: integer
+        type: string
         mapping:
           - dps_val: Cancel
-            value: 0
-            icon: mdi:cancel
-            icon_priority: 3
+            value: "0"
           - dps_val: 1 hour
-            value: 1
-            icon: "mdi:store-clock"
-            icon_priority: 3
+            value: "1"
           - dps_val: 2 hours
-            value: 2
-            icon: "mdi:store-clock"
-            icon_priority: 3
+            value: "2"
           - dps_val: 3 hours
-            value: 3
-            icon: "mdi:store-clock"
-            icon_priority: 3
+            value: "3"
           - dps_val: 4 hours
-            value: 4
-            icon: "mdi:store-clock"
-            icon_priority: 3
+            value: "4"
           - dps_val: 5 hours
-            value: 5
-            icon: "mdi:store-clock"
-            icon_priority: 3
+            value: "5"
           - dps_val: 6 hours
-            value: 6
-            icon: "mdi:store-clock"
-            icon_priority: 3
+            value: "6"
           - dps_val: 7 hours
-            value: 7
-            icon: "mdi:store-clock"
-            icon_priority: 3
+            value: "7"
           - dps_val: 8 hours
-            value: 8
-            icon: "mdi:store-clock"
-            icon_priority: 3
+            value: "8"
           - dps_val: 9 hours
-            value: 9
-            icon: "mdi:store-clock"
-            icon_priority: 3
+            value: "9"
           - dps_val: 10 hours
-            value: 10
-            icon: "mdi:store-clock"
-            icon_priority: 3
+            value: "10"
           - dps_val: 11 hours
-            value: 11
-            icon: "mdi:store-clock"
-            icon_priority: 3
+            value: "11"
           - dps_val: 12 hours
-            value: 12
-            icon: "mdi:store-clock"
-            icon_priority: 3
+            value: "12"
           - dps_val: 13 hours
-            value: 13
-            icon: "mdi:store-clock"
-            icon_priority: 3
+            value: "13"
           - dps_val: 14 hours
-            value: 14
-            icon: "mdi:store-clock"
-            icon_priority: 3
+            value: "14"
           - dps_val: 15 hours
-            value: 15
-            icon: "mdi:store-clock"
-            icon_priority: 3
+            value: "15"
           - dps_val: 16 hours
-            value: 16
-            icon: "mdi:store-clock"
-            icon_priority: 3
+            value: "16"
           - dps_val: 17 hours
-            value: 17
-            icon: "mdi:store-clock"
-            icon_priority: 3
+            value: "17"
           - dps_val: 18 hours
-            value: 18
-            icon: "mdi:store-clock"
-            icon_priority: 3
+            value: "18"
           - dps_val: 19 hours
-            value: 19
-            icon: "mdi:store-clock"
-            icon_priority: 3
+            value: "19"
           - dps_val: 20 hours
-            value: 20
-            icon: "mdi:store-clock"
-            icon_priority: 3
+            value: "20"
           - dps_val: 21 hours
-            value: 21
-            icon: "mdi:store-clock"
-            icon_priority: 3
+            value: "21"
           - dps_val: 22 hours
-            value: 22
-            icon: "mdi:store-clock"
-            icon_priority: 3
+            value: "22"
           - dps_val: 23 hours
-            value: 23
-            icon: "mdi:store-clock"
-            icon_priority: 3
+            value: "23"
           - dps_val: 24 hours
-            value: 24
-            icon: "mdi:store-clock"
-            icon_priority: 3
-  - entity: select
-    name: Wind speed
-    icon: "mdi:fan"
-    category: config
-    dps:
-      - id: 6
-        name: option
-        type: integer
-        mapping:
-          - dps_val: 0
-            icon: "mdi:fan-speed-2"
-            icon_priority: 1
-          - dps_val: 1
-            icon: "mdi:fan-speed-1"
-            icon_priority: 4
-  - entity: sensor
-    name: Current humidity
-    class: humidity
-    dps:
-      - id: 3
-        type: integer
-        name: sensor
-        unit: "%"
-        class: measurement
+            value: "24"
   - entity: sensor
     name: Remaining Time
     class: duration
     dps:
-      - id: 3
+      - id: 13
         type: integer
         name: sensor
         unit: "minutes"
         class: measurement
-  - entity: lock
-    name: Child lock
-    category: config
-    dps:
-      - id: 7
-        type: boolean
-        name: lock
-        mapping:
-          - dps_val: false
-            icon: "mdi:hand-back-right"
-          - dps_val: true
-            icon: "mdi:hand-back-right-off"
   - entity: binary_sensor
     name: Tank
     class: problem
@@ -233,3 +182,17 @@ secondary_entities:
           - dps_val: 0
             value: false
           - value: true
+  - entity: switch
+    name: Inside Drying
+    icon: "mdi:air-humidifier"
+    dps:
+      - id: 101
+        name: switch
+        type: boolean
+        mapping:
+          - dps_val: false
+            icon: "mdi:air-humidifier-off"
+            icon_priority: 1
+          - dps_val: true
+            icon: "mdi:air-humidifier"
+            icon_priority: 4