Explorar el Código

fix(smartdgm_portable_air_conditioner): clean up attributes

- remove duplicated attributes
- fix naming
- use new time entity for timers

PR #3492
Jason Rumney hace 6 meses
padre
commit
a0f6d6bd91

+ 32 - 38
custom_components/tuya_local/devices/smartdgm_portable_air_conditioner.yaml

@@ -1,7 +1,6 @@
-name: SmartDGM Portable air conditioner
+name: Portable air conditioner
 products:
   - id: keyj38wgshgk7jcn
-    name: SmartDGM Portable Air Conditioner PAC-W11C01
     manufacturer: SmartDGM
     model: PAC-W11C01
 entities:
@@ -25,12 +24,10 @@ entities:
                 value: cool
               - dps_val: "4"
                 value: fan_only
-      - id: 4
-        type: integer
-        name: timer
       - id: 5
         type: string
         name: mode
+        hidden: true
       - id: 6
         type: integer
         name: temperature
@@ -65,15 +62,6 @@ entities:
             value: C
           - dps_val: true
             value: F
-      - id: 13
-        type: integer
-        name: timer_off_mins
-      - id: 14
-        type: integer
-        name: timer_on_mins
-      - id: 15
-        type: integer
-        name: fault
       - id: 16
         type: boolean
         name: swing_mode
@@ -81,10 +69,7 @@ entities:
           - dps_val: false
             value: "off"
           - dps_val: true
-            value: vertical
-      - id: 17
-        type: boolean
-        name: sleep_mode
+            value: "on"
       - id: 18
         name: temp_set_f
         type: integer
@@ -108,51 +93,60 @@ entities:
             value: fahrenheit
           - dps_val: false
             value: celsius
-  - entity: select
+  - entity: binary_sensor
+    class: problem
+    category: diagnostic
+    dps:
+      - id: 15
+        type: bitfield
+        name: sensor
+        mapping:
+          - dps_val: 0
+            value: false
+          - value: true
+      - id: 15
+        type: bitfield
+        name: fault_code
+  - entity: switch
     category: config
-    name: sleep_mode
+    translation_key: sleep
     dps:
       - id: 17
         type: boolean
-        name: option
-        mapping:
-          - dps_val: true
-            value: "on"
-          - dps_val: false
-            value: "off"
+        name: switch
   - entity: select
     category: config
-    name: set_timer
+    name: Timer mode
     dps:
       - id: 4
         type: integer
         name: option
         mapping:
           - dps_val: 0
-            value: "off"
+            value: "None"
           - dps_val: 1
-            value: "turn off in"
+            value: "Off timer"
           - dps_val: 2
-            value: "turn on in"
-  - entity: number
+            value: "On timer"
+  - entity: time
     category: config
-    name: timer_on
+    name: "On timer"
+    translation_key: timer
     dps:
       - id: 14
         type: integer
-        name: value
-        unit: min
+        name: minute
         range:
           min: 0
           max: 1440
-  - entity: number
+  - entity: time
     category: config
-    name: timer_off
+    name: "Off timer"
+    translation_key: timer
     dps:
       - id: 13
         type: integer
-        name: value
-        unit: min
+        name: minute
         range:
           min: 0
           max: 1440