Full tests for GECO Heater

Also fixes all entity test class names

custom_components/goldair_climate/fan/climate.py

@@ -15,7 +15,7 @@ from homeassistant.components.climate.const import (
     SUPPORT_PRESET_MODE,
     SUPPORT_SWING_MODE,
 )
-from homeassistant.const import ATTR_TEMPERATURE, STATE_UNAVAILABLE, TEMP_CELSIUS
+from homeassistant.const import ATTR_TEMPERATURE, STATE_UNAVAILABLE
 
 from ..device import GoldairTuyaDevice
 from .const import (
@@ -74,7 +74,7 @@ class GoldairFan(ClimateEntity):
     @property
     def temperature_unit(self):
         """This is not used but required by Home Assistant."""
-        return TEMP_CELSIUS
+        return self._device.temperature_unit
 
     @property
     def hvac_mode(self):

tests/dehumidifier/test_light.py

@@ -14,7 +14,7 @@ from ..const import DEHUMIDIFIER_PAYLOAD
 from ..helpers import assert_device_properties_set
 
 
-class TestLight(IsolatedAsyncioTestCase):
+class TestGoldairDehumidifierLedDisplayLight(IsolatedAsyncioTestCase):
     def setUp(self):
         device_patcher = patch(
             "custom_components.goldair_climate.device.GoldairTuyaDevice"

tests/dehumidifier/test_lock.py

@@ -14,7 +14,7 @@ from ..const import DEHUMIDIFIER_PAYLOAD
 from ..helpers import assert_device_properties_set
 
 
-class TestLock(IsolatedAsyncioTestCase):
+class TestGoldairDehumidifierChildLock(IsolatedAsyncioTestCase):
     def setUp(self):
         device_patcher = patch(
             "custom_components.goldair_climate.device.GoldairTuyaDevice"

tests/fan/test_climate.py

@@ -16,7 +16,7 @@ from homeassistant.components.climate.const import (
     SWING_HORIZONTAL,
     SWING_OFF,
 )
-from homeassistant.const import ATTR_TEMPERATURE, STATE_UNAVAILABLE, TEMP_CELSIUS
+from homeassistant.const import ATTR_TEMPERATURE, STATE_UNAVAILABLE
 
 from custom_components.goldair_climate.fan.climate import GoldairFan
 from custom_components.goldair_climate.fan.const import (
@@ -32,7 +32,7 @@ from ..const import FAN_PAYLOAD
 from ..helpers import assert_device_properties_set
 
 
-class TestLight(IsolatedAsyncioTestCase):
+class TestGoldairFan(IsolatedAsyncioTestCase):
     def setUp(self):
         device_patcher = patch(
             "custom_components.goldair_climate.device.GoldairTuyaDevice"
@@ -66,8 +66,10 @@ class TestLight(IsolatedAsyncioTestCase):
     def test_icon_is_fan(self):
         self.assertEqual(self.subject.icon, "mdi:fan")
 
-    def test_temperature_unit_is_celsius(self):
-        self.assertEqual(self.subject.temperature_unit, TEMP_CELSIUS)
+    def test_temperature_unit_returns_device_temperature_unit(self):
+        self.assertEqual(
+            self.subject.temperature_unit, self.subject._device.temperature_unit
+        )
 
     def test_hvac_mode(self):
         self.dps[PROPERTY_TO_DPS_ID[ATTR_HVAC_MODE]] = True

tests/fan/test_light.py

@@ -12,7 +12,7 @@ from ..const import FAN_PAYLOAD
 from ..helpers import assert_device_properties_set
 
 
-class TestLight(IsolatedAsyncioTestCase):
+class TestGoldairFanLedDisplayLight(IsolatedAsyncioTestCase):
     def setUp(self):
         device_patcher = patch(
             "custom_components.goldair_climate.device.GoldairTuyaDevice"

tests/geco_heater/test_climate.py

@@ -0,0 +1,146 @@
+from unittest import IsolatedAsyncioTestCase
+from unittest.mock import AsyncMock, patch
+
+from homeassistant.components.climate.const import (
+    ATTR_HVAC_MODE,
+    ATTR_PRESET_MODE,
+    HVAC_MODE_HEAT,
+    HVAC_MODE_OFF,
+    SUPPORT_TARGET_TEMPERATURE,
+)
+from homeassistant.const import ATTR_TEMPERATURE, STATE_UNAVAILABLE
+
+from custom_components.goldair_climate.geco_heater.climate import GoldairGECOHeater
+from custom_components.goldair_climate.geco_heater.const import (
+    ATTR_ERROR,
+    ATTR_TARGET_TEMPERATURE,
+    HVAC_MODE_TO_DPS_MODE,
+    PROPERTY_TO_DPS_ID,
+)
+
+from ..const import GECO_HEATER_PAYLOAD
+from ..helpers import assert_device_properties_set
+
+
+class TestGoldairGECOHeater(IsolatedAsyncioTestCase):
+    def setUp(self):
+        device_patcher = patch(
+            "custom_components.goldair_climate.device.GoldairTuyaDevice"
+        )
+        self.addCleanup(device_patcher.stop)
+        self.mock_device = device_patcher.start()
+
+        self.subject = GoldairGECOHeater(self.mock_device())
+
+        self.dps = GECO_HEATER_PAYLOAD.copy()
+        self.subject._device.get_property.side_effect = lambda id: self.dps[id]
+
+    def test_supported_features(self):
+        self.assertEqual(
+            self.subject.supported_features, SUPPORT_TARGET_TEMPERATURE,
+        )
+
+    def test_should_poll(self):
+        self.assertTrue(self.subject.should_poll)
+
+    def test_name_returns_device_name(self):
+        self.assertEqual(self.subject.name, self.subject._device.name)
+
+    def test_unique_id_returns_device_unique_id(self):
+        self.assertEqual(self.subject.unique_id, self.subject._device.unique_id)
+
+    def test_device_info_returns_device_info_from_device(self):
+        self.assertEqual(self.subject.device_info, self.subject._device.device_info)
+
+    def test_icon(self):
+        self.dps[PROPERTY_TO_DPS_ID[ATTR_HVAC_MODE]] = True
+        self.assertEqual(self.subject.icon, "mdi:radiator")
+
+        self.dps[PROPERTY_TO_DPS_ID[ATTR_HVAC_MODE]] = False
+        self.assertEqual(self.subject.icon, "mdi:radiator-disabled")
+
+    def test_temperature_unit_returns_device_temperature_unit(self):
+        self.assertEqual(
+            self.subject.temperature_unit, self.subject._device.temperature_unit
+        )
+
+    def test_target_temperature(self):
+        self.dps[PROPERTY_TO_DPS_ID[ATTR_TARGET_TEMPERATURE]] = 25
+        self.assertEqual(self.subject.target_temperature, 25)
+
+    def test_target_temperature_step(self):
+        self.assertEqual(self.subject.target_temperature_step, 1)
+
+    def test_minimum_target_temperature(self):
+        self.assertEqual(self.subject.min_temp, 15)
+
+    def test_maximum_target_temperature(self):
+        self.assertEqual(self.subject.max_temp, 35)
+
+    async def test_legacy_set_temperature_method(self):
+        async with assert_device_properties_set(
+            self.subject._device, {PROPERTY_TO_DPS_ID[ATTR_TARGET_TEMPERATURE]: 25}
+        ):
+            await self.subject.async_set_temperature(temperature=25)
+
+    async def test_set_target_temperature_succeeds_within_valid_range(self):
+        async with assert_device_properties_set(
+            self.subject._device, {PROPERTY_TO_DPS_ID[ATTR_TARGET_TEMPERATURE]: 25}
+        ):
+            await self.subject.async_set_target_temperature(25)
+
+    async def test_set_target_temperature_fails_outside_valid_range(self):
+        with self.assertRaises(
+            ValueError, msg="Target temperature 14 must be between 15 and 35"
+        ):
+            await self.subject.async_set_target_temperature(14)
+
+        with self.assertRaises(
+            ValueError, msg="Target temperature 36 must be between 15 and 35"
+        ):
+            await self.subject.async_set_target_temperature(36)
+
+    async def test_current_temperature(self):
+        self.dps[PROPERTY_TO_DPS_ID[ATTR_TEMPERATURE]] = 25
+        self.assertEqual(self.subject.current_temperature, 25)
+
+    def test_hvac_mode(self):
+        self.dps[PROPERTY_TO_DPS_ID[ATTR_HVAC_MODE]] = True
+        self.assertEqual(self.subject.hvac_mode, HVAC_MODE_HEAT)
+
+        self.dps[PROPERTY_TO_DPS_ID[ATTR_HVAC_MODE]] = False
+        self.assertEqual(self.subject.hvac_mode, HVAC_MODE_OFF)
+
+        self.dps[PROPERTY_TO_DPS_ID[ATTR_HVAC_MODE]] = None
+        self.assertEqual(self.subject.hvac_mode, STATE_UNAVAILABLE)
+
+    def test_hvac_modes(self):
+        self.assertEqual(self.subject.hvac_modes, [HVAC_MODE_OFF, HVAC_MODE_HEAT])
+
+    async def test_turn_on(self):
+        async with assert_device_properties_set(
+            self.subject._device, {PROPERTY_TO_DPS_ID[ATTR_HVAC_MODE]: True}
+        ):
+            await self.subject.async_set_hvac_mode(HVAC_MODE_HEAT)
+
+    async def test_turn_off(self):
+        async with assert_device_properties_set(
+            self.subject._device, {PROPERTY_TO_DPS_ID[ATTR_HVAC_MODE]: False}
+        ):
+            await self.subject.async_set_hvac_mode(HVAC_MODE_OFF)
+
+    async def test_error_state(self):
+        # There are currently no known error states; update this as they're discovered
+        self.dps[PROPERTY_TO_DPS_ID[ATTR_ERROR]] = "something"
+        self.assertEqual(
+            self.subject.device_state_attributes, {ATTR_ERROR: "something"}
+        )
+
+    async def test_update(self):
+        result = AsyncMock()
+        self.subject._device.async_refresh.return_value = result()
+
+        await self.subject.async_update()
+
+        self.subject._device.async_refresh.assert_called_once()
+        result.assert_awaited()

tests/geco_heater/test_lock.py

@@ -1,20 +1,20 @@
 from unittest import IsolatedAsyncioTestCase
 from unittest.mock import AsyncMock, patch
 
-from custom_components.goldair_climate.gpcv_heater.const import (
+from custom_components.goldair_climate.geco_heater.const import (
     ATTR_CHILD_LOCK,
     ATTR_HVAC_MODE,
     PROPERTY_TO_DPS_ID,
 )
-from custom_components.goldair_climate.gpcv_heater.lock import (
-    GoldairGPCVHeaterChildLock,
+from custom_components.goldair_climate.geco_heater.lock import (
+    GoldairGECOHeaterChildLock,
 )
 
-from ..const import GPCV_HEATER_PAYLOAD
+from ..const import GECO_HEATER_PAYLOAD
 from ..helpers import assert_device_properties_set
 
 
-class TestLock(IsolatedAsyncioTestCase):
+class TestGoldairGECOHeaterChildLock(IsolatedAsyncioTestCase):
     def setUp(self):
         device_patcher = patch(
             "custom_components.goldair_climate.device.GoldairTuyaDevice"
@@ -22,9 +22,9 @@ class TestLock(IsolatedAsyncioTestCase):
         self.addCleanup(device_patcher.stop)
         self.mock_device = device_patcher.start()
 
-        self.subject = GoldairGPCVHeaterChildLock(self.mock_device())
+        self.subject = GoldairGECOHeaterChildLock(self.mock_device())
 
-        self.dps = GPCV_HEATER_PAYLOAD.copy()
+        self.dps = GECO_HEATER_PAYLOAD.copy()
         self.subject._device.get_property.side_effect = lambda id: self.dps[id]
 
     def test_should_poll(self):

tests/gpcv_heater/test_lock.py

@@ -1,20 +1,20 @@
 from unittest import IsolatedAsyncioTestCase
 from unittest.mock import AsyncMock, patch
 
-from custom_components.goldair_climate.geco_heater.const import (
+from custom_components.goldair_climate.gpcv_heater.const import (
     ATTR_CHILD_LOCK,
     ATTR_HVAC_MODE,
     PROPERTY_TO_DPS_ID,
 )
-from custom_components.goldair_climate.geco_heater.lock import (
-    GoldairGECOHeaterChildLock,
+from custom_components.goldair_climate.gpcv_heater.lock import (
+    GoldairGPCVHeaterChildLock,
 )
 
-from ..const import GECO_HEATER_PAYLOAD
+from ..const import GPCV_HEATER_PAYLOAD
 from ..helpers import assert_device_properties_set
 
 
-class TestLock(IsolatedAsyncioTestCase):
+class TestGoldairGPCVHeaterChildLock(IsolatedAsyncioTestCase):
     def setUp(self):
         device_patcher = patch(
             "custom_components.goldair_climate.device.GoldairTuyaDevice"
@@ -22,9 +22,9 @@ class TestLock(IsolatedAsyncioTestCase):
         self.addCleanup(device_patcher.stop)
         self.mock_device = device_patcher.start()
 
-        self.subject = GoldairGECOHeaterChildLock(self.mock_device())
+        self.subject = GoldairGPCVHeaterChildLock(self.mock_device())
 
-        self.dps = GECO_HEATER_PAYLOAD.copy()
+        self.dps = GPCV_HEATER_PAYLOAD.copy()
         self.subject._device.get_property.side_effect = lambda id: self.dps[id]
 
     def test_should_poll(self):

tests/heater/test_light.py

@@ -12,7 +12,7 @@ from ..const import GPPH_HEATER_PAYLOAD
 from ..helpers import assert_device_properties_set
 
 
-class TestLight(IsolatedAsyncioTestCase):
+class TestGoldairHeaterLedDisplayLight(IsolatedAsyncioTestCase):
     def setUp(self):
         device_patcher = patch(
             "custom_components.goldair_climate.device.GoldairTuyaDevice"

tests/heater/test_lock.py

@@ -12,7 +12,7 @@ from ..const import GPPH_HEATER_PAYLOAD
 from ..helpers import assert_device_properties_set
 
 
-class TestLock(IsolatedAsyncioTestCase):
+class TestGoldairHeaterChildLock(IsolatedAsyncioTestCase):
     def setUp(self):
         device_patcher = patch(
             "custom_components.goldair_climate.device.GoldairTuyaDevice"