Просмотр исходного кода

feat (kaisai_proheat_airconditioner): changes from review

- use name case consistent with HA standard
- remove unnecessary entity names
- abbreviate filter blockage binary sensor name
- don't quote strings unnecessarily
 - add optional tag for dp missing from log message on #3695

PR #3696
Jason Rumney 5 месяцев назад
Родитель
Сommit
7d05bbda66
1 измененных файлов с 37 добавлено и 50 удалено
  1. 37 50
      custom_components/tuya_local/devices/kaisai_proheat_airconditioner.yaml

+ 37 - 50
custom_components/tuya_local/devices/kaisai_proheat_airconditioner.yaml

@@ -1,12 +1,10 @@
-name: "Air conditioner"
+name: Air conditioner
 products:
 products:
   - id: nn2ooaacswz6uyi0
   - id: nn2ooaacswz6uyi0
     manufacturer: Kaisai
     manufacturer: Kaisai
     model: Pro Heat+ AC
     model: Pro Heat+ AC
-
 entities:
 entities:
   - entity: climate
   - entity: climate
-    name: "HVAC"
     dps:
     dps:
       - id: 1
       - id: 1
         name: hvac_mode
         name: hvac_mode
@@ -27,12 +25,10 @@ entities:
                 value: fan_only
                 value: fan_only
               - dps_val: "4"
               - dps_val: "4"
                 value: heat
                 value: heat
-
       - id: 4
       - id: 4
         name: mode
         name: mode
         type: string
         type: string
         hidden: true
         hidden: true
-
       - id: 2
       - id: 2
         name: temperature
         name: temperature
         type: integer
         type: integer
@@ -43,15 +39,12 @@ entities:
         mapping:
         mapping:
           - scale: 100
           - scale: 100
             step: 50
             step: 50
-
       - id: 3
       - id: 3
         name: current_temperature
         name: current_temperature
         type: integer
         type: integer
         unit: C
         unit: C
-        readonly: true
         mapping:
         mapping:
           - scale: 100
           - scale: 100
-
       - id: 5
       - id: 5
         name: fan_mode
         name: fan_mode
         type: string
         type: string
@@ -59,48 +52,46 @@ entities:
           - constraint: auto_fan
           - constraint: auto_fan
             conditions:
             conditions:
               - dps_val: true
               - dps_val: true
-                value: "auto"
+                value: auto
           - dps_val: "1"
           - dps_val: "1"
             constraint: auto_fan
             constraint: auto_fan
             conditions:
             conditions:
               - dps_val: false
               - dps_val: false
-                value: "quiet"
+                value: quiet
           - dps_val: "2"
           - dps_val: "2"
             constraint: auto_fan
             constraint: auto_fan
             conditions:
             conditions:
               - dps_val: false
               - dps_val: false
-                value: "low"
+                value: low
           - dps_val: "3"
           - dps_val: "3"
             constraint: auto_fan
             constraint: auto_fan
             conditions:
             conditions:
               - dps_val: false
               - dps_val: false
-                value: "medium_low"
+                value: medium_low
           - dps_val: "4"
           - dps_val: "4"
             constraint: auto_fan
             constraint: auto_fan
             conditions:
             conditions:
               - dps_val: false
               - dps_val: false
-                value: "medium"
+                value: medium
           - dps_val: "5"
           - dps_val: "5"
             constraint: auto_fan
             constraint: auto_fan
             conditions:
             conditions:
               - dps_val: false
               - dps_val: false
-                value: "medium_high"
+                value: medium_high
           - dps_val: "6"
           - dps_val: "6"
             constraint: auto_fan
             constraint: auto_fan
             conditions:
             conditions:
               - dps_val: false
               - dps_val: false
-                value: "high"
+                value: high
           - dps_val: "7"
           - dps_val: "7"
             constraint: auto_fan
             constraint: auto_fan
             conditions:
             conditions:
               - dps_val: false
               - dps_val: false
-                value: "turbo"
-
+                value: turbo
       - id: 7
       - id: 7
         name: auto_fan
         name: auto_fan
         type: boolean
         type: boolean
         hidden: true
         hidden: true
-
       - id: 31
       - id: 31
         name: swing_mode
         name: swing_mode
         type: string
         type: string
@@ -108,22 +99,21 @@ entities:
           - dps_val: "0"
           - dps_val: "0"
             value: "off"
             value: "off"
           - dps_val: "1"
           - dps_val: "1"
-            value: "vertical"
+            value: vertical
           - dps_val: "2"
           - dps_val: "2"
-            value: "up"
+            value: up
           - dps_val: "3"
           - dps_val: "3"
-            value: "down"
+            value: down
           - dps_val: "9"
           - dps_val: "9"
-            value: "up_fixed"
+            value: up_fixed
           - dps_val: "10"
           - dps_val: "10"
-            value: "up_offset_fixed"
+            value: up_offset_fixed
           - dps_val: "11"
           - dps_val: "11"
-            value: "middle_fixed"
+            value: middle_fixed
           - dps_val: "12"
           - dps_val: "12"
-            value: "down_offset_fixed"
+            value: down_offset_fixed
           - dps_val: "13"
           - dps_val: "13"
-            value: "down_fixed"
-
+            value: down_fixed
       - id: 34
       - id: 34
         name: swing_horizontal_mode
         name: swing_horizontal_mode
         type: string
         type: string
@@ -131,48 +121,48 @@ entities:
           - dps_val: "0"
           - dps_val: "0"
             value: "off"
             value: "off"
           - dps_val: "1"
           - dps_val: "1"
-            value: "horizontal"
+            value: horizontal
           - dps_val: "2"
           - dps_val: "2"
-            value: "left"
+            value: left
           - dps_val: "3"
           - dps_val: "3"
-            value: "center"
+            value: center
           - dps_val: "4"
           - dps_val: "4"
-            value: "right"
+            value: right
           - dps_val: "9"
           - dps_val: "9"
-            value: "left_fixed"
+            value: left_fixed
           - dps_val: "10"
           - dps_val: "10"
-            value: "left_offset_fixed"
+            value: left_offset_fixed
           - dps_val: "11"
           - dps_val: "11"
-            value: "center_fixed"
+            value: center_fixed
           - dps_val: "12"
           - dps_val: "12"
-            value: "right_offset_fixed"
+            value: right_offset_fixed
           - dps_val: "13"
           - dps_val: "13"
-            value: "right_fixed"
-
+            value: right_fixed
       - id: 8
       - id: 8
         name: preset_mode
         name: preset_mode
         type: boolean
         type: boolean
+        optional: true
         mapping:
         mapping:
           - dps_val: false
           - dps_val: false
-            value: "none"
+            value: none
           - dps_val: true
           - dps_val: true
-            value: "eco"
-
+            value: eco
+          - dps_value: null
+            value: none
+            hidden: true
   - entity: sensor
   - entity: sensor
-    name: "Outdoor Temperature"
+    name: Outdoor temperature
     class: temperature
     class: temperature
     dps:
     dps:
       - id: 116
       - id: 116
         name: sensor
         name: sensor
         type: integer
         type: integer
         unit: C
         unit: C
-        readonly: true
         optional: true
         optional: true
         mapping:
         mapping:
           - scale: 100
           - scale: 100
 
 
   - entity: sensor
   - entity: sensor
-    name: "Electricity Usage"
     class: energy
     class: energy
     dps:
     dps:
       - id: 127
       - id: 127
@@ -180,37 +170,34 @@ entities:
         type: integer
         type: integer
         unit: kWh
         unit: kWh
         class: total_increasing
         class: total_increasing
-        readonly: true
         optional: true
         optional: true
         mapping:
         mapping:
           - scale: 100
           - scale: 100
 
 
   - entity: sensor
   - entity: sensor
-    name: "External Fan Speed"
+    name: External fan speed
     dps:
     dps:
       - id: 117
       - id: 117
         name: sensor
         name: sensor
         type: integer
         type: integer
         unit: rpm
         unit: rpm
-        readonly: true
         optional: true
         optional: true
 
 
   - entity: sensor
   - entity: sensor
-    name: "Compressor Frequency"
+    name: Compressor frequency
+    class: frequency
     dps:
     dps:
       - id: 119
       - id: 119
         name: sensor
         name: sensor
         type: integer
         type: integer
         unit: Hz
         unit: Hz
-        readonly: true
         optional: true
         optional: true
 
 
   - entity: binary_sensor
   - entity: binary_sensor
-    name: "Filter Block Status"
+    name: Filter blockage
     class: problem
     class: problem
     dps:
     dps:
       - id: 110
       - id: 110
         name: sensor
         name: sensor
         type: boolean
         type: boolean
-        readonly: true
         optional: true
         optional: true