Просмотр исходного кода

Improve test for Kogan Switch is_on method

Need to cover the switch being unavailable.
Rather than assertTrue, assertFalse, assert that those values are Equal to True and False.
This may avoid a false positive when the switch is STATE_UNAVAILABLE.
Jason Rumney 5 лет назад
Родитель
Сommit
6525aadc4d
1 измененных файлов с 6 добавлено и 2 удалено
  1. 6 2
      tests/kogan_socket/test_switch.py

+ 6 - 2
tests/kogan_socket/test_switch.py

@@ -45,10 +45,14 @@ class TestKoganSocket(IsolatedAsyncioTestCase):
 
     def test_is_on(self):
         self.dps[PROPERTY_TO_DPS_ID[ATTR_SWITCH]] = True
-        self.assertTrue(self.subject.is_on)
+        self.assertEqual(self.subject.is_on, True)
 
         self.dps[PROPERTY_TO_DPS_ID[ATTR_SWITCH]] = False
-        self.assertFalse(self.subject.is_on)
+        self.assertEqual(self.subject.is_on, False)
+
+    def test_is_on_when_unavailable(self):
+        self.dps[PROPERTY_TO_DPS_ID[ATTR_SWITCH]] = None
+        self.assertEqual(self.subject.is_on, STATE_UNAVAILABLE)
 
     async def test_turn_on(self):
         async with assert_device_properties_set(