address review comments

custom_components/tuya_local/devices/friedrich_uct08b10a_airconditioner

@@ -42,7 +42,6 @@ primary_entity:
       name: current_temperature
       type: integer
       optional: true
-      hidden: true
       range:
         min: -20
         max: 100
@@ -87,32 +86,31 @@ primary_entity:
           value: high
         # the below are all duplicates of some of the above and don't change air speed
         - dps_val: mute
-          value: quiet
-          optional: true
+          value: low
           hidden: true
         - dps_val: mid_low
-          value: medlow
-          optional: true
+          value: low
           hidden: true
         - dps_val: mid_high
-          value: medhigh
-          optional: true
+          value: medium
           hidden: true
         - dps_val: strong
-          value: strong
-          optional: true
+          value: high
           hidden: true
     - id: 123
       name: preset_mode
-      # Tuya IOT dev says this is "bool" but the values aren't boolean
-      type: string
+      type: hex
       mapping:
-        - dps_val: "0018"
+        - mask: "0001"
+        - dps_val: 0
+          mask: "0001"
           value: comfort
-        - dps_val: "0019"
+        - dps_val: 1
           value: eco
+          mask: "0001"
         - dps_val: null
           value: comfort
+          mask: "0001"
           hidden: true
     - id: 128
       name: style
@@ -129,18 +127,7 @@ primary_entity:
     - id: 8
       name: legacy_preset_mode
       type: boolean
-      # the unit's actual hardware doesn't support this functionality even though the firmware / DP is exposed
-      # we are forced to add it so that Tuya Local gets to 100% DP match and allows us to pick this YAML for this unit
-      hidden: true
       optional: true
-      mapping:
-        - dps_val: true
-          value: eco
-        - dps_val: false
-          value: comfort
-        - dps_val: null
-          value: comfort
-          hidden: true
     - id: 18
       name: unsupported_current_humidity
       type: integer
@@ -227,6 +214,17 @@ primary_entity:
       # we are forced to add it so that Tuya Local gets to 100% DP match and allows us to pick this YAML for this unit
       hidden: true
       optional: true
+    - id: 116
+      name: totalp
+      type: integer
+      # unclear what this is, seems like intended to be total power but it's unitless per IOT and doesn't exactly track
+      # what the unit is doing so leaving as a diagnostic-only sensor that should probably be disabled by the user
+      hidden: true
+      optional: true
+      # from tuya iot dev
+      range:
+        min: 0
+        max: 1000000
     - id: 119
       name: psaving
       type: string
@@ -319,7 +317,6 @@ primary_entity:
     - id: 129
       type: string
       name: power_picker
-      read_only: true
       mapping:
         - dps_val: 1
           value: 1 kWh
@@ -472,17 +469,6 @@ secondary_entities:
     class: problem
     category: diagnostic
     dps:
-      - id: 20
-        type: bitfield
-        name: sensor
-        mapping:
-          - dps_val: 0
-            value: false
-          - dps_val: E1
-            value: false
-          - dps_val: E2
-            value: false
-          - value: true
       - id: 20
         type: bitfield
         name: fault_code
@@ -490,21 +476,6 @@ secondary_entities:
         name: fault2
         type: bitfield
         optional: true
-  - entity: sensor
-    # unclear what this is, seems like intended to be total power but it's unitless per IOT and doesn't exactly track
-    # what the unit is doing so leaving as a diagnostic-only sensor that should probably be disabled by the user
-    name: totalp
-    category: diagnostic
-    #class: measurement
-    dps:
-      - id: 116
-        name: sensor
-        type: integer
-        optional: true
-        # from tuya iot dev
-        range:
-          min: 0
-          max: 1000000
   - entity: number
     name: Eco Mode Temperature Setting
     category: config

custom_components/tuya_local/devices/richelieu_undercabinet_lighting_pucks.yaml

@@ -16,11 +16,11 @@ primary_entity:
       name: switch
     - id: 2
       type: string
-      name: work_mode
+      name: effect
       # "current" is default or can set "scene_[1-18]" to use that scene
       mapping:
         - dps_val: current
-          value: current
+          value: "off"
         - dps_val: "scene_1"
           value: Scene 1
         - dps_val: "scene_2"
@@ -74,143 +74,85 @@ primary_entity:
         max: 100
       mapping:
         - target_range:
-            min: 2700
-            max: 6500
-
-secondary_entities:
-  - entity: select
-    name: Mode Selection
-    category: config
-    dps:
-      - id: 2
-        name: option
-        type: string
-        mapping:
-          - dps_val: current
-            value: current
-          - dps_val: "scene_1"
-            value: Scene 1
-          - dps_val: "scene_2"
-            value: Scene 2
-          - dps_val: "scene_3"
-            value: Scene 3
-          - dps_val: "scene_4"
-            value: Scene 4
-          - dps_val: "scene_5"
-            value: Scene 5
-          - dps_val: "scene_6"
-            value: Scene 6
-          - dps_val: "scene_7"
-            value: Scene 7
-          - dps_val: "scene_8"
-            value: Scene 8
-          - dps_val: "scene_9"
-            value: Scene 9
-          - dps_val: "scene_10"
-            value: Scene 10
-          - dps_val: "scene_11"
-            value: Scene 11
-          - dps_val: "scene_12"
-            value: Scene 12
-          - dps_val: "scene_13"
-            value: Scene 13
-          - dps_val: "scene_14"
-            value: Scene 14
-          - dps_val: "scene_15"
-            value: Scene 15
-          - dps_val: "scene_16"
-            value: Scene 16
-          - dps_val: "scene_17"
-            value: Scene 17
-          - dps_val: "scene_18"
-            value: Scene 18
-
-  - entity: select
-    name: Delete Scene
-    category: config
-    dps:
-      - id: 101
-        name: option
-        type: string
-        mapping:
-          - dps_val: "scene_1"
-            value: Scene 1
-          - dps_val: "scene_2"
-            value: Scene 2
-          - dps_val: "scene_3"
-            value: Scene 3
-          - dps_val: "scene_4"
-            value: Scene 4
-          - dps_val: "scene_5"
-            value: Scene 5
-          - dps_val: "scene_6"
-            value: Scene 6
-          - dps_val: "scene_7"
-            value: Scene 7
-          - dps_val: "scene_8"
-            value: Scene 8
-          - dps_val: "scene_9"
-            value: Scene 9
-          - dps_val: "scene_10"
-            value: Scene 10
-          - dps_val: "scene_11"
-            value: Scene 11
-          - dps_val: "scene_12"
-            value: Scene 12
-          - dps_val: "scene_13"
-            value: Scene 13
-          - dps_val: "scene_14"
-            value: Scene 14
-          - dps_val: "scene_15"
-            value: Scene 15
-          - dps_val: "scene_16"
-            value: Scene 16
-          - dps_val: "scene_17"
-            value: Scene 17
-          - dps_val: "scene_18"
-            value: Scene 18
-
-  - entity: select
-    name: Add Scene
-    category: config
-    dps:
-      - id: 102
-        name: option
-        type: string
-        mapping:
-          - dps_val: "scene_1"
-            value: Scene 1
-          - dps_val: "scene_2"
-            value: Scene 2
-          - dps_val: "scene_3"
-            value: Scene 3
-          - dps_val: "scene_4"
-            value: Scene 4
-          - dps_val: "scene_5"
-            value: Scene 5
-          - dps_val: "scene_6"
-            value: Scene 6
-          - dps_val: "scene_7"
-            value: Scene 7
-          - dps_val: "scene_8"
-            value: Scene 8
-          - dps_val: "scene_9"
-            value: Scene 9
-          - dps_val: "scene_10"
-            value: Scene 10
-          - dps_val: "scene_11"
-            value: Scene 11
-          - dps_val: "scene_12"
-            value: Scene 12
-          - dps_val: "scene_13"
-            value: Scene 13
-          - dps_val: "scene_14"
-            value: Scene 14
-          - dps_val: "scene_15"
-            value: Scene 15
-          - dps_val: "scene_16"
-            value: Scene 16
-          - dps_val: "scene_17"
-            value: Scene 17
-          - dps_val: "scene_18"
-            value: Scene 18
+            min: 3000
+            max: 5000
+    - id: 101
+      name: selected_scene_to_delete
+      type: string
+      mapping:
+        - dps_val: "scene_1"
+          value: Scene 1
+        - dps_val: "scene_2"
+          value: Scene 2
+        - dps_val: "scene_3"
+          value: Scene 3
+        - dps_val: "scene_4"
+          value: Scene 4
+        - dps_val: "scene_5"
+          value: Scene 5
+        - dps_val: "scene_6"
+          value: Scene 6
+        - dps_val: "scene_7"
+          value: Scene 7
+        - dps_val: "scene_8"
+          value: Scene 8
+        - dps_val: "scene_9"
+          value: Scene 9
+        - dps_val: "scene_10"
+          value: Scene 10
+        - dps_val: "scene_11"
+          value: Scene 11
+        - dps_val: "scene_12"
+          value: Scene 12
+        - dps_val: "scene_13"
+          value: Scene 13
+        - dps_val: "scene_14"
+          value: Scene 14
+        - dps_val: "scene_15"
+          value: Scene 15
+        - dps_val: "scene_16"
+          value: Scene 16
+        - dps_val: "scene_17"
+          value: Scene 17
+        - dps_val: "scene_18"
+          value: Scene 18
+    - id: 102
+      name: selected_scene_to_add
+      type: string
+      mapping:
+        - dps_val: "scene_1"
+          value: Scene 1
+        - dps_val: "scene_2"
+          value: Scene 2
+        - dps_val: "scene_3"
+          value: Scene 3
+        - dps_val: "scene_4"
+          value: Scene 4
+        - dps_val: "scene_5"
+          value: Scene 5
+        - dps_val: "scene_6"
+          value: Scene 6
+        - dps_val: "scene_7"
+          value: Scene 7
+        - dps_val: "scene_8"
+          value: Scene 8
+        - dps_val: "scene_9"
+          value: Scene 9
+        - dps_val: "scene_10"
+          value: Scene 10
+        - dps_val: "scene_11"
+          value: Scene 11
+        - dps_val: "scene_12"
+          value: Scene 12
+        - dps_val: "scene_13"
+          value: Scene 13
+        - dps_val: "scene_14"
+          value: Scene 14
+        - dps_val: "scene_15"
+          value: Scene 15
+        - dps_val: "scene_16"
+          value: Scene 16
+        - dps_val: "scene_17"
+          value: Scene 17
+        - dps_val: "scene_18"
+          value: Scene 18