test_forms.py 85 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154115511561157115811591160116111621163116411651166116711681169117011711172117311741175117611771178117911801181118211831184118511861187118811891190119111921193119411951196119711981199120012011202120312041205120612071208120912101211121212131214121512161217121812191220122112221223122412251226122712281229123012311232123312341235123612371238123912401241124212431244124512461247124812491250125112521253125412551256125712581259126012611262126312641265126612671268126912701271127212731274127512761277127812791280128112821283128412851286128712881289129012911292129312941295129612971298129913001301130213031304130513061307130813091310131113121313131413151316131713181319132013211322132313241325132613271328132913301331133213331334133513361337133813391340134113421343134413451346134713481349135013511352135313541355135613571358135913601361136213631364136513661367136813691370137113721373137413751376137713781379138013811382138313841385138613871388138913901391139213931394139513961397139813991400140114021403140414051406140714081409141014111412141314141415141614171418141914201421142214231424142514261427142814291430143114321433143414351436143714381439144014411442144314441445144614471448144914501451145214531454145514561457145814591460146114621463146414651466146714681469147014711472147314741475147614771478147914801481148214831484148514861487148814891490149114921493149414951496149714981499150015011502150315041505150615071508150915101511151215131514151515161517151815191520152115221523152415251526152715281529153015311532153315341535153615371538153915401541154215431544154515461547154815491550155115521553155415551556155715581559156015611562156315641565156615671568156915701571157215731574157515761577157815791580158115821583158415851586158715881589159015911592159315941595159615971598159916001601160216031604160516061607160816091610161116121613161416151616161716181619162016211622162316241625162616271628162916301631163216331634163516361637163816391640164116421643164416451646164716481649165016511652165316541655165616571658165916601661166216631664166516661667166816691670167116721673167416751676167716781679168016811682168316841685168616871688168916901691169216931694169516961697169816991700170117021703170417051706170717081709171017111712171317141715171617171718171917201721172217231724172517261727172817291730173117321733173417351736173717381739174017411742174317441745174617471748174917501751175217531754175517561757175817591760176117621763176417651766176717681769177017711772177317741775177617771778177917801781178217831784178517861787178817891790179117921793179417951796179717981799180018011802180318041805180618071808180918101811181218131814181518161817181818191820182118221823182418251826182718281829183018311832183318341835183618371838183918401841184218431844184518461847184818491850185118521853185418551856185718581859186018611862186318641865186618671868186918701871187218731874187518761877187818791880188118821883188418851886188718881889189018911892189318941895189618971898189919001901190219031904190519061907190819091910191119121913191419151916191719181919192019211922192319241925192619271928192919301931193219331934193519361937193819391940194119421943194419451946194719481949195019511952195319541955195619571958195919601961196219631964196519661967196819691970197119721973197419751976197719781979198019811982
  1. import tempfile
  2. from unittest.mock import patch
  3. from django import forms
  4. from django.template.loader import render_to_string
  5. from django.test import TestCase, override_settings
  6. from circuits.models import CircuitTermination
  7. from dcim.choices import (
  8. CableEndChoices,
  9. CableProfileChoices,
  10. DeviceFaceChoices,
  11. DeviceStatusChoices,
  12. InterfaceLAGHashPolicyChoices,
  13. InterfaceLAGModeChoices,
  14. InterfaceModeChoices,
  15. InterfaceTypeChoices,
  16. LinkStatusChoices,
  17. PortTypeChoices,
  18. PowerOutletStatusChoices,
  19. VirtualDeviceContextStatusChoices,
  20. )
  21. from dcim.forms import *
  22. from dcim.models import *
  23. from dcim.tests.test_module_moves import fail_after
  24. from ipam.models import ASN, RIR, VLAN
  25. from utilities.exceptions import AbortRequest
  26. from utilities.forms.rendering import M2MAddRemoveFields
  27. from utilities.testing import create_test_device, create_test_image
  28. from virtualization.models import Cluster, ClusterGroup, ClusterType
  29. def get_id(model, slug):
  30. return model.objects.get(slug=slug).id
  31. class PowerOutletFormTestCase(TestCase):
  32. @classmethod
  33. def setUpTestData(cls):
  34. cls.site = site = Site.objects.create(name='Site 1', slug='site-1')
  35. cls.manufacturer = manufacturer = Manufacturer.objects.create(name='Manufacturer 1', slug='manufacturer-1')
  36. cls.role = role = DeviceRole.objects.create(
  37. name='Device Role 1', slug='device-role-1', color='ff0000'
  38. )
  39. cls.device_type = device_type = DeviceType.objects.create(
  40. manufacturer=manufacturer, model='Device Type 1', slug='device-type-1', u_height=1
  41. )
  42. cls.rack = rack = Rack.objects.create(name='Rack 1', site=site)
  43. cls.device = Device.objects.create(
  44. name='Device 1', device_type=device_type, role=role, site=site, rack=rack, position=1
  45. )
  46. def test_status_is_required(self):
  47. form = PowerOutletForm(data={
  48. 'device': self.device,
  49. 'module': None,
  50. 'name': 'New Enabled Outlet',
  51. })
  52. self.assertFalse(form.is_valid())
  53. self.assertIn('status', form.errors)
  54. def test_status_must_be_defined_choice(self):
  55. form = PowerOutletForm(data={
  56. 'device': self.device,
  57. 'module': None,
  58. 'name': 'New Enabled Outlet',
  59. 'status': 'this isn\'t a defined choice',
  60. })
  61. self.assertFalse(form.is_valid())
  62. self.assertIn('status', form.errors)
  63. self.assertTrue(form.errors['status'][-1].startswith('Select a valid choice.'))
  64. def test_status_recognizes_choices(self):
  65. for index, choice in enumerate(PowerOutletStatusChoices.CHOICES):
  66. form = PowerOutletForm(data={
  67. 'device': self.device,
  68. 'module': None,
  69. 'name': f'New Enabled Outlet {index + 1}',
  70. 'status': choice[0],
  71. })
  72. self.assertEqual({}, form.errors)
  73. self.assertTrue(form.is_valid())
  74. instance = form.save()
  75. self.assertEqual(instance.status, choice[0])
  76. class DeviceTestCase(TestCase):
  77. @classmethod
  78. def setUpTestData(cls):
  79. site = Site.objects.create(name='Site 1', slug='site-1')
  80. rack = Rack.objects.create(name='Rack 1', site=site)
  81. manufacturer = Manufacturer.objects.create(name='Manufacturer 1', slug='manufacturer-1')
  82. device_type = DeviceType.objects.create(
  83. manufacturer=manufacturer, model='Device Type 1', slug='device-type-1', u_height=1
  84. )
  85. role = DeviceRole.objects.create(
  86. name='Device Role 1', slug='device-role-1', color='ff0000'
  87. )
  88. Platform.objects.create(name='Platform 1', slug='platform-1')
  89. Device.objects.create(
  90. name='Device 1', device_type=device_type, role=role, site=site, rack=rack, position=1
  91. )
  92. cluster_type = ClusterType.objects.create(name='Cluster Type 1', slug='cluster-type-1')
  93. cluster_group = ClusterGroup.objects.create(name='Cluster Group 1', slug='cluster-group-1')
  94. Cluster.objects.create(name='Cluster 1', type=cluster_type, group=cluster_group)
  95. def test_racked_device(self):
  96. form = DeviceForm(data={
  97. 'name': 'New Device',
  98. 'role': DeviceRole.objects.first().pk,
  99. 'tenant': None,
  100. 'manufacturer': Manufacturer.objects.first().pk,
  101. 'device_type': DeviceType.objects.first().pk,
  102. 'site': Site.objects.first().pk,
  103. 'rack': Rack.objects.first().pk,
  104. 'face': DeviceFaceChoices.FACE_FRONT,
  105. 'position': 2,
  106. 'platform': Platform.objects.first().pk,
  107. 'status': DeviceStatusChoices.STATUS_ACTIVE,
  108. })
  109. self.assertTrue(form.is_valid())
  110. self.assertTrue(form.save())
  111. def test_replicate_components(self):
  112. device_type = DeviceType.objects.first()
  113. InterfaceTemplate.objects.create(device_type=device_type, name='eth0', type='1000base-t')
  114. data = {
  115. 'role': DeviceRole.objects.first().pk,
  116. 'device_type': device_type.pk,
  117. 'site': Site.objects.first().pk,
  118. 'status': DeviceStatusChoices.STATUS_ACTIVE,
  119. }
  120. form = DeviceForm(data={**data, 'name': 'Device 2', 'replicate_components': True})
  121. self.assertTrue(form.is_valid(), form.errors)
  122. self.assertTrue(form.save().interfaces.filter(name='eth0').exists())
  123. form = DeviceForm(data={**data, 'name': 'Device 3', 'replicate_components': False})
  124. self.assertTrue(form.is_valid(), form.errors)
  125. self.assertFalse(form.save().interfaces.exists())
  126. # The replicate_components field is not available when editing an existing device
  127. form = DeviceForm(instance=Device.objects.get(name='Device 1'))
  128. self.assertNotIn('replicate_components', form.fields)
  129. def test_import_replicate_components(self):
  130. device_type = DeviceType.objects.first()
  131. InterfaceTemplate.objects.create(device_type=device_type, name='eth0', type='1000base-t')
  132. data = {
  133. 'role': DeviceRole.objects.first().name,
  134. 'manufacturer': device_type.manufacturer.name,
  135. 'device_type': device_type.model,
  136. 'site': Site.objects.first().name,
  137. 'status': DeviceStatusChoices.STATUS_ACTIVE,
  138. }
  139. # Components are replicated by default
  140. form = DeviceImportForm(data={**data, 'name': 'Device 2'})
  141. self.assertTrue(form.is_valid(), form.errors)
  142. self.assertTrue(form.save().interfaces.filter(name='eth0').exists())
  143. # A blank value (e.g. an empty CSV cell) is treated as omitted
  144. for i, value in enumerate(('', None), start=4):
  145. form = DeviceImportForm(data={**data, 'name': f'Device {i}', 'replicate_components': value})
  146. self.assertTrue(form.is_valid(), form.errors)
  147. self.assertTrue(form.save().interfaces.filter(name='eth0').exists())
  148. form = DeviceImportForm(data={**data, 'name': 'Device 3', 'replicate_components': 'false'})
  149. self.assertTrue(form.is_valid(), form.errors)
  150. self.assertFalse(form.save().interfaces.exists())
  151. def test_racked_device_occupied(self):
  152. form = DeviceForm(data={
  153. 'name': 'test',
  154. 'role': DeviceRole.objects.first().pk,
  155. 'tenant': None,
  156. 'manufacturer': Manufacturer.objects.first().pk,
  157. 'device_type': DeviceType.objects.first().pk,
  158. 'site': Site.objects.first().pk,
  159. 'rack': Rack.objects.first().pk,
  160. 'face': DeviceFaceChoices.FACE_FRONT,
  161. 'position': 1,
  162. 'platform': Platform.objects.first().pk,
  163. 'status': DeviceStatusChoices.STATUS_ACTIVE,
  164. })
  165. self.assertFalse(form.is_valid())
  166. self.assertIn('position', form.errors)
  167. def test_non_racked_device(self):
  168. form = DeviceForm(data={
  169. 'name': 'New Device',
  170. 'role': DeviceRole.objects.first().pk,
  171. 'tenant': None,
  172. 'manufacturer': Manufacturer.objects.first().pk,
  173. 'device_type': DeviceType.objects.first().pk,
  174. 'site': Site.objects.first().pk,
  175. 'rack': None,
  176. 'face': None,
  177. 'position': None,
  178. 'platform': Platform.objects.first().pk,
  179. 'status': DeviceStatusChoices.STATUS_ACTIVE,
  180. })
  181. self.assertTrue(form.is_valid())
  182. self.assertTrue(form.save())
  183. def test_vc_member_removal_blocked_by_cross_chassis_lag(self):
  184. device1 = Device.objects.get(name='Device 1')
  185. device2 = Device.objects.create(
  186. name='Device 2', device_type=device1.device_type, role=device1.role, site=device1.site
  187. )
  188. vc = VirtualChassis.objects.create(name='VC 1', master=device1)
  189. Device.objects.filter(pk=device1.pk).update(virtual_chassis=vc, vc_position=1)
  190. Device.objects.filter(pk=device2.pk).update(virtual_chassis=vc, vc_position=2)
  191. lag = Interface.objects.create(device=device1, name='lag0', type=InterfaceTypeChoices.TYPE_LAG)
  192. Interface.objects.create(device=device2, name='eth0', type=InterfaceTypeChoices.TYPE_1GE_FIXED, lag=lag)
  193. device2.refresh_from_db()
  194. form = DeviceForm(instance=device2, data={
  195. 'name': device2.name,
  196. 'role': device2.role.pk,
  197. 'device_type': device2.device_type.pk,
  198. 'site': device2.site.pk,
  199. 'status': DeviceStatusChoices.STATUS_ACTIVE,
  200. 'virtual_chassis': None,
  201. 'vc_position': None,
  202. })
  203. self.assertFalse(form.is_valid())
  204. self.assertIn('virtual_chassis', form.errors)
  205. def test_non_racked_device_with_face(self):
  206. form = DeviceForm(data={
  207. 'name': 'New Device',
  208. 'role': DeviceRole.objects.first().pk,
  209. 'tenant': None,
  210. 'manufacturer': Manufacturer.objects.first().pk,
  211. 'device_type': DeviceType.objects.first().pk,
  212. 'site': Site.objects.first().pk,
  213. 'rack': None,
  214. 'face': DeviceFaceChoices.FACE_REAR,
  215. 'platform': None,
  216. 'status': DeviceStatusChoices.STATUS_ACTIVE,
  217. })
  218. self.assertFalse(form.is_valid())
  219. self.assertIn('face', form.errors)
  220. def test_non_racked_device_with_position(self):
  221. form = DeviceForm(data={
  222. 'name': 'New Device',
  223. 'role': DeviceRole.objects.first().pk,
  224. 'tenant': None,
  225. 'manufacturer': Manufacturer.objects.first().pk,
  226. 'device_type': DeviceType.objects.first().pk,
  227. 'site': Site.objects.first().pk,
  228. 'rack': None,
  229. 'position': 10,
  230. 'platform': None,
  231. 'status': DeviceStatusChoices.STATUS_ACTIVE,
  232. })
  233. self.assertFalse(form.is_valid())
  234. self.assertIn('position', form.errors)
  235. class ModuleTypeFormTestCase(TestCase):
  236. @classmethod
  237. def setUpTestData(cls):
  238. cls.manufacturer = Manufacturer.objects.create(name='Manufacturer 1', slug='manufacturer-1')
  239. cls.profile = ModuleTypeProfile.objects.create(
  240. name='Module Type Profile 1',
  241. schema={
  242. 'properties': {
  243. 'media': {
  244. 'title': 'Media',
  245. 'type': 'array',
  246. 'items': {
  247. 'type': 'string',
  248. 'enum': ['copper', 'sfp', 'qsfp28'],
  249. },
  250. },
  251. },
  252. },
  253. )
  254. def test_upload_and_clear_images(self):
  255. """
  256. Upload images through the form, then clear the front image, which should delete only its file.
  257. """
  258. data = {
  259. 'manufacturer': self.manufacturer.pk,
  260. 'model': 'Module Type 1',
  261. 'profile': self.profile.pk,
  262. 'attr_media': ['copper', 'qsfp28'],
  263. }
  264. form = ModuleTypeForm(data=data, files={
  265. 'front_image': create_test_image('front.png'),
  266. 'rear_image': create_test_image('rear.png'),
  267. })
  268. # A profile change re-renders only the profile-attributes fieldset, which must not hold a picked file
  269. profile_fieldset = next(fieldset for fieldset in form.fieldsets if fieldset.html_id == 'profile-attributes')
  270. self.assertNotIn('front_image', profile_fieldset.items)
  271. self.assertNotIn('rear_image', profile_fieldset.items)
  272. self.assertTrue(form.is_multipart())
  273. with (
  274. tempfile.TemporaryDirectory() as media_root,
  275. override_settings(MEDIA_ROOT=media_root),
  276. patch('utilities.forms.fields.dynamic.get_action_url', return_value='/'),
  277. ):
  278. self.assertTrue(form.is_valid(), form.errors)
  279. module_type = form.save()
  280. front_image_name = module_type.front_image.name
  281. rear_image_name = module_type.rear_image.name
  282. storage = module_type.front_image.storage
  283. self.assertTrue(storage.exists(front_image_name))
  284. self.assertTrue(storage.exists(rear_image_name))
  285. self.assertEqual(module_type.attribute_data, {'media': ['copper', 'qsfp28']})
  286. form = ModuleTypeForm(data={**data, 'front_image-clear': True}, instance=module_type)
  287. self.assertTrue(form.is_valid(), form.errors)
  288. with self.captureOnCommitCallbacks(execute=True):
  289. form.save()
  290. module_type.refresh_from_db()
  291. self.assertFalse(module_type.front_image)
  292. self.assertEqual(module_type.rear_image.name, rear_image_name)
  293. self.assertFalse(storage.exists(front_image_name))
  294. self.assertTrue(storage.exists(rear_image_name))
  295. self.assertEqual(module_type.attribute_data, {'media': ['copper', 'qsfp28']})
  296. def test_enum_array_attribute_uses_multiselect_field(self):
  297. form = ModuleTypeForm(data={
  298. 'manufacturer': self.manufacturer.pk,
  299. 'model': 'Module Type 1',
  300. 'profile': self.profile.pk,
  301. 'attr_media': ['copper', 'qsfp28'],
  302. })
  303. self.assertIsInstance(form.fields['attr_media'], forms.MultipleChoiceField)
  304. self.assertEqual(
  305. list(form.fields['attr_media'].choices),
  306. [
  307. ('copper', 'copper'),
  308. ('sfp', 'sfp'),
  309. ('qsfp28', 'qsfp28'),
  310. ],
  311. )
  312. with patch('utilities.forms.fields.dynamic.get_action_url', return_value='/'):
  313. self.assertTrue(form.is_valid(), form.errors)
  314. module_type = form.save()
  315. self.assertEqual(module_type.attribute_data, {'media': ['copper', 'qsfp28']})
  316. def test_zero_bound_attribute_is_enforced_by_the_form(self):
  317. profile = ModuleTypeProfile.objects.create(
  318. name='Module Type Profile 2',
  319. schema={
  320. 'properties': {
  321. 'offset': {
  322. 'title': 'Offset',
  323. 'type': 'number',
  324. 'minimum': 0,
  325. 'maximum': 0,
  326. },
  327. },
  328. },
  329. )
  330. form = ModuleTypeForm(data={
  331. 'manufacturer': self.manufacturer.pk,
  332. 'model': 'Module Type 2',
  333. 'profile': profile.pk,
  334. 'attr_offset': -5,
  335. })
  336. self.assertEqual(form.fields['attr_offset'].min_value, 0)
  337. self.assertEqual(form.fields['attr_offset'].max_value, 0)
  338. with patch('utilities.forms.fields.dynamic.get_action_url', return_value='/'):
  339. self.assertFalse(form.is_valid())
  340. self.assertIn('attr_offset', form.errors)
  341. def test_numeric_enum_attribute_is_saved_as_a_number(self):
  342. profile = ModuleTypeProfile.objects.create(
  343. name='Module Type Profile 3',
  344. schema={
  345. 'properties': {
  346. 'slots': {
  347. 'title': 'Slots',
  348. 'type': 'integer',
  349. 'enum': [0, 1, 2],
  350. },
  351. },
  352. },
  353. )
  354. for value in (0, 1):
  355. with self.subTest(value=value):
  356. form = ModuleTypeForm(data={
  357. 'manufacturer': self.manufacturer.pk,
  358. 'model': f'Module Type {value}',
  359. 'profile': profile.pk,
  360. 'attr_slots': str(value),
  361. })
  362. with patch('utilities.forms.fields.dynamic.get_action_url', return_value='/'):
  363. self.assertTrue(form.is_valid(), form.errors)
  364. module_type = form.save()
  365. self.assertEqual(module_type.attribute_data, {'slots': value})
  366. class ModuleTypeProfileDescriptionRenderingTestCase(TestCase):
  367. """
  368. A profile schema property's description is rendered as the attribute field's help text via the
  369. `safe` filter, so markup outside HTML_ALLOWED_TAGS must not reach the DOM as a live element.
  370. Verified end to end because the sanitization and the `safe` filter that makes it necessary sit
  371. in different layers.
  372. """
  373. @classmethod
  374. def setUpTestData(cls):
  375. cls.manufacturer = Manufacturer.objects.create(name='Manufacturer 1', slug='manufacturer-1')
  376. cls.profile = ModuleTypeProfile.objects.create(
  377. name='Disk',
  378. schema={
  379. 'properties': {
  380. 'capacity': {
  381. 'type': 'integer',
  382. 'title': 'Capacity (GB)',
  383. 'description': 'Gross disk size <iframe src="https://example.com"></iframe>',
  384. },
  385. },
  386. },
  387. )
  388. def test_help_text_is_rendered_without_disallowed_markup(self):
  389. form = ModuleTypeForm(data={
  390. 'manufacturer': self.manufacturer.pk,
  391. 'model': 'Module Type 1',
  392. 'profile': self.profile.pk,
  393. 'attr_capacity': 500,
  394. })
  395. rendered = render_to_string('form_helpers/render_field.html', {'field': form['attr_capacity']})
  396. self.assertInHTML(
  397. '<span class="form-text" id="id_attr_capacity_helptext">'
  398. '<div class="rendered-markdown"><p>Gross disk size</p></div></span>',
  399. rendered,
  400. )
  401. class ModuleBayTemplateImportFormTestCase(TestCase):
  402. def test_module_bay_types_prefers_manufacturer_specific_match_over_global(self):
  403. """A name shared by a global and a manufacturer-scoped type resolves to the scoped one."""
  404. manufacturer = Manufacturer.objects.create(name='Manufacturer 1', slug='manufacturer-1')
  405. global_type = ModuleBayType.objects.create(name='SFP28', slug='sfp28-global')
  406. scoped_type = ModuleBayType.objects.create(
  407. name='SFP28', slug='sfp28-scoped', manufacturer=manufacturer,
  408. )
  409. device_type = DeviceType.objects.create(
  410. manufacturer=manufacturer, model='Device Type 1', slug='device-type-1',
  411. )
  412. form = ModuleBayTemplateImportForm({
  413. 'device_type': device_type.pk,
  414. 'name': 'Module Bay 1',
  415. 'module_bay_types': ['SFP28'],
  416. })
  417. self.assertTrue(form.is_valid(), form.errors)
  418. module_bay_template = form.save()
  419. self.assertEqual(
  420. list(module_bay_template.module_bay_types.all()), [scoped_type],
  421. )
  422. self.assertNotIn(global_type, module_bay_template.module_bay_types.all())
  423. def test_module_bay_types_unknown_name_raises_error(self):
  424. device_type = DeviceType.objects.create(
  425. manufacturer=Manufacturer.objects.create(name='Manufacturer 1', slug='manufacturer-1'),
  426. model='Device Type 1',
  427. slug='device-type-1',
  428. )
  429. form = ModuleBayTemplateImportForm({
  430. 'device_type': device_type.pk,
  431. 'name': 'Module Bay 1',
  432. 'module_bay_types': ['Nonexistent'],
  433. })
  434. self.assertFalse(form.is_valid())
  435. self.assertEqual(
  436. form.errors.as_data()['module_bay_types'][0].code, 'invalid_choice',
  437. )
  438. def test_module_bay_types_prefers_manufacturer_specific_match_over_global_for_module_type(self):
  439. """Same disambiguation, but for a module bay template nested under a ModuleType."""
  440. manufacturer = Manufacturer.objects.create(name='Manufacturer 1', slug='manufacturer-1')
  441. global_type = ModuleBayType.objects.create(name='SFP28', slug='sfp28-global')
  442. scoped_type = ModuleBayType.objects.create(
  443. name='SFP28', slug='sfp28-scoped', manufacturer=manufacturer,
  444. )
  445. module_type = ModuleType.objects.create(manufacturer=manufacturer, model='Module Type 1')
  446. form = ModuleBayTemplateImportForm({
  447. 'module_type': module_type.pk,
  448. 'name': 'Module Bay 1',
  449. 'module_bay_types': ['SFP28'],
  450. })
  451. self.assertTrue(form.is_valid(), form.errors)
  452. module_bay_template = form.save()
  453. self.assertEqual(
  454. list(module_bay_template.module_bay_types.all()), [scoped_type],
  455. )
  456. self.assertNotIn(global_type, module_bay_template.module_bay_types.all())
  457. def test_enabled_honors_explicit_false(self):
  458. device_type = DeviceType.objects.create(
  459. manufacturer=Manufacturer.objects.create(name='Manufacturer 1', slug='manufacturer-1'),
  460. model='Device Type 1',
  461. slug='device-type-1',
  462. )
  463. form = ModuleBayTemplateImportForm({
  464. 'device_type': device_type.pk,
  465. 'name': 'Module Bay 1',
  466. 'enabled': False,
  467. })
  468. self.assertTrue(form.is_valid(), form.errors)
  469. self.assertFalse(form.save().enabled)
  470. def test_import_export_round_trip_preserves_module_bay_types(self):
  471. """to_yaml() then re-import through this form preserves module bay types."""
  472. manufacturer = Manufacturer.objects.create(name='Manufacturer 1', slug='manufacturer-1')
  473. bay_type_a = ModuleBayType.objects.create(name='SFP28', slug='sfp28')
  474. bay_type_b = ModuleBayType.objects.create(name='QSFP28', slug='qsfp28')
  475. device_type = DeviceType.objects.create(
  476. manufacturer=manufacturer, model='Device Type 1', slug='device-type-1',
  477. )
  478. original = ModuleBayTemplate.objects.create(device_type=device_type, name='Module Bay 1')
  479. original.module_bay_types.set([bay_type_a, bay_type_b])
  480. exported = original.to_yaml()
  481. form = ModuleBayTemplateImportForm({
  482. 'device_type': device_type.pk,
  483. 'name': 'Module Bay 2',
  484. 'module_bay_types': exported['module_bay_types'],
  485. })
  486. self.assertTrue(form.is_valid(), form.errors)
  487. reimported = form.save()
  488. self.assertEqual(
  489. set(reimported.module_bay_types.values_list('name', flat=True)),
  490. set(original.module_bay_types.values_list('name', flat=True)),
  491. )
  492. def test_module_bay_types_name_belonging_only_to_other_manufacturers_is_unresolvable(self):
  493. """
  494. A name that exists only for manufacturers other than the device type's own (and isn't
  495. global) must not resolve at all -- module_bay_types is scoped to the device type's own
  496. manufacturer plus global types, with no cross-manufacturer fallback.
  497. """
  498. juniper = Manufacturer.objects.create(name='Juniper', slug='juniper')
  499. cisco = Manufacturer.objects.create(name='Cisco', slug='cisco')
  500. ModuleBayType.objects.create(name='SFP28', slug='sfp28-cisco', manufacturer=cisco)
  501. device_type = DeviceType.objects.create(
  502. manufacturer=juniper, model='Juniper Device Type', slug='juniper-device-type',
  503. )
  504. form = ModuleBayTemplateImportForm({
  505. 'device_type': device_type.pk,
  506. 'name': 'Module Bay 1',
  507. 'module_bay_types': ['SFP28'],
  508. })
  509. self.assertFalse(form.is_valid())
  510. self.assertEqual(
  511. form.errors.as_data()['module_bay_types'][0].code, 'invalid_choice',
  512. )
  513. def test_module_bay_types_resolution_is_independent_of_field_order(self):
  514. """
  515. Resolution must not depend on the parent type having been cleaned first, so declaring
  516. module_bay_types ahead of device_type/module_type must not change the outcome.
  517. """
  518. class ReorderedImportForm(ModuleBayTemplateImportForm):
  519. class Meta(ModuleBayTemplateImportForm.Meta):
  520. fields = [
  521. 'module_bay_types', 'device_type', 'module_type', 'name', 'label', 'position',
  522. 'enabled', 'description',
  523. ]
  524. self.assertEqual(list(ReorderedImportForm().fields)[0], 'module_bay_types')
  525. juniper = Manufacturer.objects.create(name='Juniper', slug='juniper')
  526. cisco = Manufacturer.objects.create(name='Cisco', slug='cisco')
  527. global_type = ModuleBayType.objects.create(name='SFP28', slug='sfp28-global')
  528. juniper_type = ModuleBayType.objects.create(name='SFP28', slug='sfp28-juniper', manufacturer=juniper)
  529. cisco_type = ModuleBayType.objects.create(name='QSFP28', slug='qsfp28-cisco', manufacturer=cisco)
  530. device_type = DeviceType.objects.create(
  531. manufacturer=juniper, model='Juniper Device Type', slug='juniper-device-type',
  532. )
  533. # The device type's own manufacturer still wins over the global type of the same name
  534. form = ReorderedImportForm({
  535. 'device_type': device_type.pk,
  536. 'name': 'Module Bay 1',
  537. 'module_bay_types': ['SFP28'],
  538. })
  539. self.assertTrue(form.is_valid(), form.errors)
  540. module_bay_template = form.save()
  541. self.assertEqual(list(module_bay_template.module_bay_types.all()), [juniper_type])
  542. self.assertNotIn(global_type, module_bay_template.module_bay_types.all())
  543. # ...and another manufacturer's bay type is still rejected rather than resolved to
  544. form = ReorderedImportForm({
  545. 'device_type': device_type.pk,
  546. 'name': 'Module Bay 2',
  547. 'module_bay_types': [cisco_type.name],
  548. })
  549. self.assertFalse(form.is_valid())
  550. self.assertEqual(
  551. form.errors.as_data()['module_bay_types'][0].code, 'invalid_choice',
  552. )
  553. class ModuleFormTestCase(TestCase):
  554. @classmethod
  555. def setUpTestData(cls):
  556. cls.device = create_test_device('Module Form Device A')
  557. cls.device_b = create_test_device('Module Form Device B')
  558. cls.bay_a = ModuleBay.objects.create(device=cls.device, name='Bay A')
  559. cls.bay_b = ModuleBay.objects.create(device=cls.device, name='Bay B')
  560. cls.bay_c = ModuleBay.objects.create(device=cls.device_b, name='Bay C')
  561. manufacturer = Manufacturer.objects.create(
  562. name='Module Form Manufacturer', slug='module-form-manufacturer'
  563. )
  564. cls.module_type = ModuleType.objects.create(manufacturer=manufacturer, model='Module Form Type')
  565. cls.module = Module.objects.create(
  566. device=cls.device, module_bay=cls.bay_a, module_type=cls.module_type
  567. )
  568. def test_module_device_is_editable_on_edit(self):
  569. form = ModuleForm(instance=self.module)
  570. self.assertFalse(form.fields['device'].disabled)
  571. self.assertTrue(form.fields['replicate_components'].disabled)
  572. self.assertTrue(form.fields['adopt_components'].disabled)
  573. def test_module_form_moves_module_to_empty_bay(self):
  574. form = ModuleForm(
  575. data={
  576. 'device': self.device.pk,
  577. 'module_bay': self.bay_b.pk,
  578. 'module_type': self.module_type.pk,
  579. 'status': 'active',
  580. },
  581. instance=self.module,
  582. )
  583. self.assertTrue(form.is_valid(), form.errors)
  584. form.save()
  585. self.module.refresh_from_db()
  586. self.assertEqual(self.module.module_bay, self.bay_b)
  587. def test_module_form_rejects_occupied_bay(self):
  588. Module.objects.create(device=self.device, module_bay=self.bay_b, module_type=self.module_type)
  589. form = ModuleForm(
  590. data={
  591. 'device': self.device.pk,
  592. 'module_bay': self.bay_b.pk,
  593. 'module_type': self.module_type.pk,
  594. 'status': 'active',
  595. },
  596. instance=self.module,
  597. )
  598. self.assertFalse(form.is_valid())
  599. self.assertIn('module_bay', form.errors)
  600. def test_module_form_moves_module_to_different_device(self):
  601. interface = Interface.objects.create(
  602. device=self.device, module=self.module, name='eth0', type=InterfaceTypeChoices.TYPE_1GE_FIXED
  603. )
  604. form = ModuleForm(
  605. data={
  606. 'device': self.device_b.pk,
  607. 'module_bay': self.bay_c.pk,
  608. 'module_type': self.module_type.pk,
  609. 'status': 'active',
  610. },
  611. instance=self.module,
  612. )
  613. self.assertTrue(form.is_valid(), form.errors)
  614. form.save()
  615. self.module.refresh_from_db()
  616. self.assertEqual(self.module.device, self.device_b)
  617. self.assertEqual(self.module.module_bay, self.bay_c)
  618. interface.refresh_from_db()
  619. self.assertEqual(interface.device, self.device_b)
  620. def test_module_create_into_cyclic_hierarchy_is_rejected(self):
  621. # CREATE into a cyclic hierarchy (bypassing clean() via .update()) must be a form error.
  622. other_module = Module.objects.create(
  623. device=self.device, module_bay=self.bay_b, module_type=self.module_type
  624. )
  625. child_bay_1 = ModuleBay.objects.create(device=self.device, module=self.module, name='Child Bay 1')
  626. child_bay_2 = ModuleBay.objects.create(device=self.device, module=other_module, name='Child Bay 2')
  627. Module.objects.filter(pk=self.module.pk).update(module_bay=child_bay_2)
  628. Module.objects.filter(pk=other_module.pk).update(module_bay=child_bay_1)
  629. form = ModuleForm(
  630. data={
  631. 'device': self.device.pk,
  632. 'module_bay': child_bay_1.pk,
  633. 'module_type': self.module_type.pk,
  634. 'status': 'active',
  635. 'replicate_components': True,
  636. },
  637. )
  638. with fail_after(15):
  639. self.assertFalse(form.is_valid())
  640. self.assertIn('contains a cycle', str(form.errors))
  641. def test_module_form_reports_conflicting_cooling_component(self):
  642. """
  643. A cooling component name collision must surface as a form error rather than an
  644. IntegrityError raised from the replication insert. See netbox#15289.
  645. """
  646. cooled_type = ModuleType.objects.create(
  647. manufacturer=self.module_type.manufacturer, model='Cooled Form Type'
  648. )
  649. CoolingIntakeTemplate.objects.create(module_type=cooled_type, name='Intake 1')
  650. CoolingOutflowTemplate.objects.create(module_type=cooled_type, name='Outflow 1')
  651. CoolingIntake.objects.create(device=self.device, name='Intake 1')
  652. form = ModuleForm(
  653. data={
  654. 'device': self.device.pk,
  655. 'module_bay': self.bay_b.pk,
  656. 'module_type': cooled_type.pk,
  657. 'status': 'active',
  658. 'replicate_components': True,
  659. },
  660. )
  661. self.assertFalse(form.is_valid())
  662. self.assertIn('Intake 1', str(form.errors))
  663. def test_module_form_adopts_existing_cooling_component(self):
  664. cooled_type = ModuleType.objects.create(
  665. manufacturer=self.module_type.manufacturer, model='Adoptable Cooled Type'
  666. )
  667. CoolingIntakeTemplate.objects.create(module_type=cooled_type, name='Intake 1')
  668. intake = CoolingIntake.objects.create(device=self.device, name='Intake 1')
  669. form = ModuleForm(
  670. data={
  671. 'device': self.device.pk,
  672. 'module_bay': self.bay_b.pk,
  673. 'module_type': cooled_type.pk,
  674. 'status': 'active',
  675. 'replicate_components': True,
  676. 'adopt_components': True,
  677. },
  678. )
  679. self.assertTrue(form.is_valid(), form.errors)
  680. module = form.save()
  681. intake.refresh_from_db()
  682. self.assertEqual(intake.module, module)
  683. def test_module_form_rejects_module_token_without_bay_position(self):
  684. """Replication and adoption reject a {module} token in any resolved field when the bay has no position."""
  685. interface_type = InterfaceTypeChoices.TYPE_1GE_FIXED
  686. templates = (
  687. (InterfaceTemplate, {'name': 'eth{module}', 'type': interface_type}),
  688. (InterfaceTemplate, {'name': 'eth0', 'label': 'Port {module}', 'type': interface_type}),
  689. (ModuleBayTemplate, {'name': 'Bay {module}'}),
  690. (ModuleBayTemplate, {'name': 'Bay', 'label': 'Bay {module}'}),
  691. (ModuleBayTemplate, {'name': 'Bay', 'position': '{module}'}),
  692. )
  693. for i, (template_model, attrs) in enumerate(templates, start=1):
  694. module_type = ModuleType.objects.create(
  695. manufacturer=self.module_type.manufacturer, model=f'Token No-Position Form Type {i}'
  696. )
  697. template_model.objects.create(module_type=module_type, **attrs)
  698. for flags in ({'replicate_components': True}, {'adopt_components': True}):
  699. with self.subTest(template=template_model.__name__, attrs=attrs, flags=flags):
  700. form = ModuleForm(data={
  701. 'device': self.device.pk,
  702. 'module_bay': self.bay_b.pk,
  703. 'module_type': module_type.pk,
  704. 'status': 'active',
  705. **flags,
  706. })
  707. self.assertFalse(form.is_valid())
  708. self.assertIn('no position defined', str(form.errors))
  709. def test_module_form_rejects_module_token_depth_mismatch(self):
  710. """Replication and adoption reject more {module} tokens in a resolved field than the bay depth."""
  711. module_bay = ModuleBay.objects.create(device=self.device, name='Bay D', position='1')
  712. interface_type = InterfaceTypeChoices.TYPE_1GE_FIXED
  713. tokens = '{module}/{module}'
  714. templates = (
  715. (InterfaceTemplate, {'name': f'eth{tokens}', 'type': interface_type}),
  716. (InterfaceTemplate, {'name': 'eth0', 'label': tokens, 'type': interface_type}),
  717. (ModuleBayTemplate, {'name': tokens}),
  718. (ModuleBayTemplate, {'name': 'Bay', 'label': tokens}),
  719. (ModuleBayTemplate, {'name': 'Bay', 'position': tokens}),
  720. )
  721. for i, (template_model, attrs) in enumerate(templates, start=1):
  722. module_type = ModuleType.objects.create(
  723. manufacturer=self.module_type.manufacturer, model=f'Token Depth Form Type {i}'
  724. )
  725. template_model.objects.create(module_type=module_type, **attrs)
  726. for flags in ({'replicate_components': True}, {'adopt_components': True}):
  727. with self.subTest(template=template_model.__name__, attrs=attrs, flags=flags):
  728. form = ModuleForm(data={
  729. 'device': self.device.pk,
  730. 'module_bay': module_bay.pk,
  731. 'module_type': module_type.pk,
  732. 'status': 'active',
  733. **flags,
  734. })
  735. self.assertFalse(form.is_valid())
  736. self.assertIn('2 placeholders given', str(form.errors))
  737. def test_module_form_adopt_only_creates_no_components(self):
  738. """Adoption without replication adopts matching components and creates no others."""
  739. adopt_type = ModuleType.objects.create(
  740. manufacturer=self.module_type.manufacturer, model='Adopt Only Form Type'
  741. )
  742. InterfaceTemplate.objects.create(module_type=adopt_type, name='eth0', type=InterfaceTypeChoices.TYPE_1GE_FIXED)
  743. InterfaceTemplate.objects.create(module_type=adopt_type, name='eth1', type=InterfaceTypeChoices.TYPE_1GE_FIXED)
  744. interface = Interface.objects.create(
  745. device=self.device, name='eth0', type=InterfaceTypeChoices.TYPE_1GE_FIXED
  746. )
  747. form = ModuleForm(data={
  748. 'device': self.device.pk,
  749. 'module_bay': self.bay_b.pk,
  750. 'module_type': adopt_type.pk,
  751. 'status': 'active',
  752. 'adopt_components': True,
  753. })
  754. self.assertTrue(form.is_valid(), form.errors)
  755. module = form.save()
  756. interface.refresh_from_db()
  757. self.assertEqual(interface.module, module)
  758. self.assertFalse(self.device.interfaces.filter(name='eth1').exists())
  759. def test_module_form_adopt_only_rejects_component_of_another_module(self):
  760. """Adoption without replication refuses a component that already belongs to another module."""
  761. adopt_type = ModuleType.objects.create(
  762. manufacturer=self.module_type.manufacturer, model='Owned Adopt Form Type'
  763. )
  764. InterfaceTemplate.objects.create(module_type=adopt_type, name='eth0', type=InterfaceTypeChoices.TYPE_1GE_FIXED)
  765. Interface.objects.create(
  766. device=self.device, module=self.module, name='eth0', type=InterfaceTypeChoices.TYPE_1GE_FIXED
  767. )
  768. form = ModuleForm(data={
  769. 'device': self.device.pk,
  770. 'module_bay': self.bay_b.pk,
  771. 'module_type': adopt_type.pk,
  772. 'status': 'active',
  773. 'adopt_components': True,
  774. })
  775. self.assertFalse(form.is_valid())
  776. self.assertIn('already belongs to a module', str(form.errors))
  777. def test_module_form_skips_template_checks_without_component_operations(self):
  778. """Without replication or adoption, templates are neither checked nor instantiated."""
  779. token_type = ModuleType.objects.create(
  780. manufacturer=self.module_type.manufacturer, model='No Operations Form Type'
  781. )
  782. InterfaceTemplate.objects.create(
  783. module_type=token_type, name='eth0', label='Port {module}', type=InterfaceTypeChoices.TYPE_1GE_FIXED
  784. )
  785. form = ModuleForm(data={
  786. 'device': self.device.pk,
  787. 'module_bay': self.bay_b.pk,
  788. 'module_type': token_type.pk,
  789. 'status': 'active',
  790. })
  791. self.assertTrue(form.is_valid(), form.errors)
  792. module = form.save()
  793. self.assertFalse(module.interfaces.exists())
  794. def test_module_import_form_rejects_module_token_without_bay_position(self):
  795. """Bulk import applies the module form's placeholder checks."""
  796. token_type = ModuleType.objects.create(
  797. manufacturer=self.module_type.manufacturer, model='Token Import Type'
  798. )
  799. InterfaceTemplate.objects.create(
  800. module_type=token_type, name='eth0', label='Port {module}', type=InterfaceTypeChoices.TYPE_1GE_FIXED
  801. )
  802. form = ModuleImportForm(data={
  803. 'device': self.device.name,
  804. 'module_bay': self.bay_b.name,
  805. 'module_type': token_type.model,
  806. 'status': 'active',
  807. })
  808. self.assertFalse(form.is_valid())
  809. self.assertIn('no position defined', str(form.errors))
  810. class VCPositionTokenFormTestCase(TestCase):
  811. @classmethod
  812. def setUpTestData(cls):
  813. Site.objects.create(name='Site VC 1', slug='site-vc-1')
  814. manufacturer = Manufacturer.objects.create(name='Manufacturer VC 1', slug='manufacturer-vc-1')
  815. device_type = DeviceType.objects.create(
  816. manufacturer=manufacturer, model='Device Type VC 1', slug='device-type-vc-1'
  817. )
  818. DeviceRole.objects.create(name='Device Role VC 1', slug='device-role-vc-1', color='ff0000')
  819. InterfaceTemplate.objects.create(
  820. device_type=device_type,
  821. name='ge-{vc_position:0}/0/0',
  822. type='1000base-t',
  823. )
  824. VirtualChassis.objects.create(name='VC 1')
  825. def test_device_creation_in_vc_resolves_vc_position(self):
  826. form = DeviceForm(data={
  827. 'name': 'Device VC Form 1',
  828. 'role': DeviceRole.objects.first().pk,
  829. 'tenant': None,
  830. 'manufacturer': Manufacturer.objects.first().pk,
  831. 'device_type': DeviceType.objects.first().pk,
  832. 'site': Site.objects.first().pk,
  833. 'rack': None,
  834. 'face': None,
  835. 'position': None,
  836. 'platform': None,
  837. 'status': DeviceStatusChoices.STATUS_ACTIVE,
  838. 'replicate_components': True,
  839. 'virtual_chassis': VirtualChassis.objects.first().pk,
  840. 'vc_position': 2,
  841. })
  842. self.assertTrue(form.is_valid())
  843. device = form.save()
  844. self.assertTrue(device.interfaces.filter(name='ge-2/0/0').exists())
  845. def test_device_creation_not_in_vc_uses_fallback(self):
  846. form = DeviceForm(data={
  847. 'name': 'Device VC Form 2',
  848. 'role': DeviceRole.objects.first().pk,
  849. 'tenant': None,
  850. 'manufacturer': Manufacturer.objects.first().pk,
  851. 'device_type': DeviceType.objects.first().pk,
  852. 'site': Site.objects.first().pk,
  853. 'rack': None,
  854. 'face': None,
  855. 'position': None,
  856. 'platform': None,
  857. 'status': DeviceStatusChoices.STATUS_ACTIVE,
  858. 'replicate_components': True,
  859. })
  860. self.assertTrue(form.is_valid())
  861. device = form.save()
  862. self.assertTrue(device.interfaces.filter(name='ge-0/0/0').exists())
  863. def test_device_creation_duplicate_name_conflict(self):
  864. # With conflict
  865. device_type = DeviceType.objects.first()
  866. # to generate conflicts create an interface that will exist
  867. InterfaceTemplate.objects.create(
  868. device_type=device_type,
  869. name='ge-0/0/0',
  870. type='1000base-t',
  871. )
  872. form = DeviceForm(data={
  873. 'name': 'Device VC Form 3',
  874. 'role': DeviceRole.objects.first().pk,
  875. 'tenant': None,
  876. 'manufacturer': Manufacturer.objects.first().pk,
  877. 'device_type': device_type.pk,
  878. 'site': Site.objects.first().pk,
  879. 'rack': None,
  880. 'face': None,
  881. 'position': None,
  882. 'platform': None,
  883. 'status': DeviceStatusChoices.STATUS_ACTIVE,
  884. 'replicate_components': True,
  885. })
  886. self.assertTrue(form.is_valid())
  887. with self.assertRaises(AbortRequest):
  888. form.save()
  889. class FrontPortTestCase(TestCase):
  890. @classmethod
  891. def setUpTestData(cls):
  892. cls.device = create_test_device('Panel Device 1')
  893. cls.rear_ports = (
  894. RearPort(name='RearPort1', device=cls.device, type=PortTypeChoices.TYPE_8P8C),
  895. RearPort(name='RearPort2', device=cls.device, type=PortTypeChoices.TYPE_8P8C),
  896. RearPort(name='RearPort3', device=cls.device, type=PortTypeChoices.TYPE_8P8C),
  897. RearPort(name='RearPort4', device=cls.device, type=PortTypeChoices.TYPE_8P8C),
  898. )
  899. RearPort.objects.bulk_create(cls.rear_ports)
  900. cls.rear_port_templates = (
  901. RearPortTemplate(name='RearPort1', device_type=cls.device.device_type, type=PortTypeChoices.TYPE_8P8C),
  902. RearPortTemplate(name='RearPort2', device_type=cls.device.device_type, type=PortTypeChoices.TYPE_8P8C),
  903. RearPortTemplate(name='RearPort3', device_type=cls.device.device_type, type=PortTypeChoices.TYPE_8P8C),
  904. RearPortTemplate(name='RearPort4', device_type=cls.device.device_type, type=PortTypeChoices.TYPE_8P8C),
  905. )
  906. RearPortTemplate.objects.bulk_create(cls.rear_port_templates)
  907. def test_front_port_label_count_valid(self):
  908. """
  909. Test that generating an equal number of names and labels passes form validation.
  910. """
  911. front_port_data = {
  912. 'device': self.device.pk,
  913. 'name': 'FrontPort[1-4]',
  914. 'label': 'Port[1-4]',
  915. 'type': PortTypeChoices.TYPE_8P8C,
  916. 'positions': 1,
  917. 'rear_ports': [f'{rear_port.pk}:1' for rear_port in self.rear_ports],
  918. }
  919. form = FrontPortCreateForm(front_port_data)
  920. self.assertTrue(form.is_valid())
  921. def test_front_port_label_count_mismatch(self):
  922. """
  923. Check that attempting to generate a differing number of names and labels results in a validation error.
  924. """
  925. bad_front_port_data = {
  926. 'device': self.device.pk,
  927. 'name': 'FrontPort[1-4]',
  928. 'label': 'Port[1-2]',
  929. 'type': PortTypeChoices.TYPE_8P8C,
  930. 'positions': 1,
  931. 'rear_ports': [f'{rear_port.pk}:1' for rear_port in self.rear_ports],
  932. }
  933. form = FrontPortCreateForm(bad_front_port_data)
  934. self.assertFalse(form.is_valid())
  935. self.assertIn('label', form.errors)
  936. def test_front_port_position_count_valid(self):
  937. """
  938. Test that generating front ports with multiple positions each passes form validation.
  939. """
  940. front_port_data = {
  941. 'device': self.device.pk,
  942. 'name': 'FrontPort[1-2]',
  943. 'type': PortTypeChoices.TYPE_8P8C,
  944. 'positions': 2,
  945. 'rear_ports': [f'{rear_port.pk}:1' for rear_port in self.rear_ports],
  946. }
  947. form = FrontPortCreateForm(front_port_data)
  948. self.assertTrue(form.is_valid(), form.errors)
  949. def test_front_port_position_count_mismatch(self):
  950. """
  951. Check that the mismatch error reports the total number of front port positions, not the port count.
  952. """
  953. bad_front_port_data = {
  954. 'device': self.device.pk,
  955. 'name': 'FrontPort[1-2]',
  956. 'type': PortTypeChoices.TYPE_8P8C,
  957. 'positions': 2,
  958. 'rear_ports': [f'{rear_port.pk}:1' for rear_port in self.rear_ports[:2]],
  959. }
  960. form = FrontPortCreateForm(bad_front_port_data)
  961. self.assertFalse(form.is_valid())
  962. self.assertIn(
  963. 'The total number of front port positions (4) must match the selected number of rear port '
  964. 'positions (2).',
  965. form.errors['rear_ports']
  966. )
  967. def test_front_port_template_position_count_mismatch(self):
  968. """
  969. Check that the front port template form reports the same corrected position total.
  970. """
  971. bad_front_port_template_data = {
  972. 'device_type': self.device.device_type.pk,
  973. 'name': 'FrontPort[1-2]',
  974. 'type': PortTypeChoices.TYPE_8P8C,
  975. 'positions': 2,
  976. 'rear_ports': [f'{rear_port_template.pk}:1' for rear_port_template in self.rear_port_templates[:2]],
  977. }
  978. form = FrontPortTemplateCreateForm(bad_front_port_template_data)
  979. self.assertFalse(form.is_valid())
  980. self.assertIn(
  981. 'The total number of front port positions (4) must match the selected number of rear port '
  982. 'positions (2).',
  983. form.errors['rear_ports']
  984. )
  985. def test_front_port_missing_rear_ports(self):
  986. """
  987. Check that omitting the rear port selection reports a field error rather than raising an exception.
  988. """
  989. bad_front_port_data = {
  990. 'device': self.device.pk,
  991. 'name': 'FrontPort[1-2]',
  992. 'type': PortTypeChoices.TYPE_8P8C,
  993. 'positions': 1,
  994. }
  995. form = FrontPortCreateForm(bad_front_port_data)
  996. self.assertFalse(form.is_valid())
  997. self.assertIn('rear_ports', form.errors)
  998. def test_front_port_invalid_positions(self):
  999. """
  1000. Check that a non-numeric position count reports a field error rather than raising an exception.
  1001. """
  1002. bad_front_port_data = {
  1003. 'device': self.device.pk,
  1004. 'name': 'FrontPort[1-2]',
  1005. 'type': PortTypeChoices.TYPE_8P8C,
  1006. 'positions': 'two',
  1007. 'rear_ports': [f'{rear_port.pk}:1' for rear_port in self.rear_ports[:2]],
  1008. }
  1009. form = FrontPortCreateForm(bad_front_port_data)
  1010. self.assertFalse(form.is_valid())
  1011. self.assertIn('positions', form.errors)
  1012. def test_front_port_template_missing_rear_ports(self):
  1013. """
  1014. Check that the front port template form also reports a field error rather than raising an exception.
  1015. """
  1016. bad_front_port_template_data = {
  1017. 'device_type': self.device.device_type.pk,
  1018. 'name': 'FrontPort[1-2]',
  1019. 'type': PortTypeChoices.TYPE_8P8C,
  1020. 'positions': 1,
  1021. }
  1022. form = FrontPortTemplateCreateForm(bad_front_port_template_data)
  1023. self.assertFalse(form.is_valid())
  1024. self.assertIn('rear_ports', form.errors)
  1025. def test_front_port_invalid_label_range(self):
  1026. """
  1027. Check that an inverted label range reports a field error rather than raising an exception.
  1028. """
  1029. bad_front_port_data = {
  1030. 'device': self.device.pk,
  1031. 'name': 'FrontPort[1-2]',
  1032. 'label': 'Port[2-1]',
  1033. 'type': PortTypeChoices.TYPE_8P8C,
  1034. 'positions': 1,
  1035. 'rear_ports': [f'{rear_port.pk}:1' for rear_port in self.rear_ports[:2]],
  1036. }
  1037. form = FrontPortCreateForm(bad_front_port_data)
  1038. self.assertFalse(form.is_valid())
  1039. self.assertIn('label', form.errors)
  1040. class InterfaceTestCase(TestCase):
  1041. @classmethod
  1042. def setUpTestData(cls):
  1043. cls.device = create_test_device('Device 1')
  1044. cls.vlans = (
  1045. VLAN(name='VLAN 1', vid=1),
  1046. VLAN(name='VLAN 2', vid=2),
  1047. VLAN(name='VLAN 3', vid=3),
  1048. )
  1049. VLAN.objects.bulk_create(cls.vlans)
  1050. cls.interface = Interface.objects.create(
  1051. device=cls.device,
  1052. name='Interface 1',
  1053. type=InterfaceTypeChoices.TYPE_1GE_GBIC,
  1054. mode=InterfaceModeChoices.MODE_TAGGED,
  1055. )
  1056. def test_interface_label_count_valid(self):
  1057. """
  1058. Test that generating an equal number of names and labels passes form validation.
  1059. """
  1060. interface_data = {
  1061. 'device': self.device.pk,
  1062. 'name': 'eth[0-9]',
  1063. 'label': 'Interface[0-9]',
  1064. 'type': InterfaceTypeChoices.TYPE_1GE_GBIC,
  1065. }
  1066. form = InterfaceCreateForm(interface_data)
  1067. self.assertTrue(form.is_valid())
  1068. def test_interface_label_count_mismatch(self):
  1069. """
  1070. Check that attempting to generate a differing number of names and labels results in a validation error.
  1071. """
  1072. bad_interface_data = {
  1073. 'device': self.device.pk,
  1074. 'name': 'eth[0-9]',
  1075. 'label': 'Interface[0-1]',
  1076. 'type': InterfaceTypeChoices.TYPE_1GE_GBIC,
  1077. }
  1078. form = InterfaceCreateForm(bad_interface_data)
  1079. self.assertFalse(form.is_valid())
  1080. self.assertIn('label', form.errors)
  1081. def test_create_interface_mode_valid_data(self):
  1082. """
  1083. Test that saving valid interface mode and tagged/untagged vlans works properly
  1084. """
  1085. # Validate access mode
  1086. data = {
  1087. 'device': self.device.pk,
  1088. 'name': 'ethernet1/1',
  1089. 'type': InterfaceTypeChoices.TYPE_1GE_GBIC,
  1090. 'mode': InterfaceModeChoices.MODE_ACCESS,
  1091. 'untagged_vlan': self.vlans[0].pk
  1092. }
  1093. form = InterfaceCreateForm(data)
  1094. self.assertTrue(form.is_valid())
  1095. # Validate tagged vlans
  1096. data = {
  1097. 'device': self.device.pk,
  1098. 'name': 'ethernet1/2',
  1099. 'type': InterfaceTypeChoices.TYPE_1GE_GBIC,
  1100. 'mode': InterfaceModeChoices.MODE_TAGGED,
  1101. 'untagged_vlan': self.vlans[0].pk,
  1102. 'tagged_vlans': [self.vlans[1].pk, self.vlans[2].pk]
  1103. }
  1104. form = InterfaceCreateForm(data)
  1105. self.assertTrue(form.is_valid())
  1106. # Validate tagged vlans
  1107. data = {
  1108. 'device': self.device.pk,
  1109. 'name': 'ethernet1/3',
  1110. 'type': InterfaceTypeChoices.TYPE_1GE_GBIC,
  1111. 'mode': InterfaceModeChoices.MODE_TAGGED_ALL,
  1112. 'untagged_vlan': self.vlans[0].pk,
  1113. }
  1114. form = InterfaceCreateForm(data)
  1115. self.assertTrue(form.is_valid())
  1116. def test_create_interface_mode_access_invalid_data(self):
  1117. """
  1118. Test that saving invalid interface mode and tagged/untagged vlans works properly
  1119. """
  1120. data = {
  1121. 'device': self.device.pk,
  1122. 'name': 'ethernet1/4',
  1123. 'type': InterfaceTypeChoices.TYPE_1GE_GBIC,
  1124. 'mode': InterfaceModeChoices.MODE_ACCESS,
  1125. 'untagged_vlan': self.vlans[0].pk,
  1126. 'tagged_vlans': [self.vlans[1].pk, self.vlans[2].pk]
  1127. }
  1128. form = InterfaceCreateForm(data)
  1129. self.assertTrue(form.is_valid())
  1130. self.assertIn('untagged_vlan', form.cleaned_data.keys())
  1131. self.assertNotIn('tagged_vlans', form.cleaned_data.keys())
  1132. self.assertNotIn('qinq_svlan', form.cleaned_data.keys())
  1133. def test_edit_interface_mode_access_invalid_data(self):
  1134. """
  1135. Test that saving invalid interface mode and tagged/untagged vlans works properly
  1136. """
  1137. data = {
  1138. 'device': self.device.pk,
  1139. 'name': 'Ethernet 1/5',
  1140. 'type': InterfaceTypeChoices.TYPE_1GE_GBIC,
  1141. 'mode': InterfaceModeChoices.MODE_ACCESS,
  1142. 'tagged_vlans': [self.vlans[0].pk, self.vlans[1].pk, self.vlans[2].pk]
  1143. }
  1144. form = InterfaceForm(data, instance=self.interface)
  1145. self.assertTrue(form.is_valid())
  1146. self.assertIn('untagged_vlan', form.cleaned_data.keys())
  1147. self.assertNotIn('tagged_vlans', form.cleaned_data.keys())
  1148. self.assertNotIn('qinq_svlan', form.cleaned_data.keys())
  1149. def test_create_interface_mode_tagged_all_invalid_data(self):
  1150. """
  1151. Test that saving invalid interface mode and tagged/untagged vlans works properly
  1152. """
  1153. data = {
  1154. 'device': self.device.pk,
  1155. 'name': 'ethernet1/6',
  1156. 'type': InterfaceTypeChoices.TYPE_1GE_GBIC,
  1157. 'mode': InterfaceModeChoices.MODE_TAGGED_ALL,
  1158. 'tagged_vlans': [self.vlans[0].pk, self.vlans[1].pk, self.vlans[2].pk]
  1159. }
  1160. form = InterfaceCreateForm(data)
  1161. self.assertTrue(form.is_valid())
  1162. self.assertIn('untagged_vlan', form.cleaned_data.keys())
  1163. self.assertNotIn('tagged_vlans', form.cleaned_data.keys())
  1164. self.assertNotIn('qinq_svlan', form.cleaned_data.keys())
  1165. def test_edit_interface_mode_tagged_all_invalid_data(self):
  1166. """
  1167. Test that saving invalid interface mode and tagged/untagged vlans works properly
  1168. """
  1169. data = {
  1170. 'device': self.device.pk,
  1171. 'name': 'Ethernet 1/7',
  1172. 'type': InterfaceTypeChoices.TYPE_1GE_GBIC,
  1173. 'mode': InterfaceModeChoices.MODE_TAGGED_ALL,
  1174. 'tagged_vlans': [self.vlans[0].pk, self.vlans[1].pk, self.vlans[2].pk]
  1175. }
  1176. form = InterfaceForm(data)
  1177. self.assertTrue(form.is_valid())
  1178. self.assertIn('untagged_vlan', form.cleaned_data.keys())
  1179. self.assertNotIn('tagged_vlans', form.cleaned_data.keys())
  1180. self.assertNotIn('qinq_svlan', form.cleaned_data.keys())
  1181. def test_create_interface_mode_routed_invalid_data(self):
  1182. """
  1183. Test that saving invalid interface mode (routed) and tagged/untagged vlans works properly
  1184. """
  1185. data = {
  1186. 'device': self.device.pk,
  1187. 'name': 'ethernet1/6',
  1188. 'type': InterfaceTypeChoices.TYPE_1GE_GBIC,
  1189. 'mode': None,
  1190. 'untagged_vlan': self.vlans[0].pk,
  1191. 'tagged_vlans': [self.vlans[0].pk, self.vlans[1].pk, self.vlans[2].pk]
  1192. }
  1193. form = InterfaceCreateForm(data)
  1194. self.assertTrue(form.is_valid())
  1195. self.assertNotIn('untagged_vlan', form.cleaned_data.keys())
  1196. self.assertNotIn('tagged_vlans', form.cleaned_data.keys())
  1197. self.assertNotIn('qinq_svlan', form.cleaned_data.keys())
  1198. def test_edit_interface_mode_routed_invalid_data(self):
  1199. """
  1200. Test that saving invalid interface mode (routed) and tagged/untagged vlans works properly
  1201. """
  1202. data = {
  1203. 'device': self.device.pk,
  1204. 'name': 'Ethernet 1/7',
  1205. 'type': InterfaceTypeChoices.TYPE_1GE_GBIC,
  1206. 'mode': None,
  1207. 'untagged_vlan': self.vlans[0].pk,
  1208. 'tagged_vlans': [self.vlans[0].pk, self.vlans[1].pk, self.vlans[2].pk]
  1209. }
  1210. form = InterfaceForm(data)
  1211. self.assertTrue(form.is_valid())
  1212. self.assertNotIn('untagged_vlan', form.cleaned_data.keys())
  1213. self.assertNotIn('tagged_vlans', form.cleaned_data.keys())
  1214. self.assertNotIn('qinq_svlan', form.cleaned_data.keys())
  1215. def test_lag_hash_policy_hidden_for_non_hash_mode(self):
  1216. """A LAG hash policy is offered only for hashing LAG modes, and is cleared when switching away from one."""
  1217. lag = Interface.objects.create(
  1218. device=self.device,
  1219. name='bond0',
  1220. type=InterfaceTypeChoices.TYPE_LAG,
  1221. lag_mode=InterfaceLAGModeChoices.MODE_LACP,
  1222. lag_hash_policy=InterfaceLAGHashPolicyChoices.POLICY_LAYER3_4,
  1223. )
  1224. self.assertIn('lag_hash_policy', InterfaceForm(instance=lag).fields)
  1225. data = {
  1226. 'device': self.device.pk,
  1227. 'name': 'bond0',
  1228. 'type': InterfaceTypeChoices.TYPE_LAG,
  1229. 'lag_mode': InterfaceLAGModeChoices.MODE_ACTIVE_BACKUP,
  1230. 'lag_hash_policy': InterfaceLAGHashPolicyChoices.POLICY_LAYER3_4,
  1231. }
  1232. form = InterfaceForm(data, instance=lag)
  1233. self.assertNotIn('lag_hash_policy', form.fields)
  1234. self.assertTrue(form.is_valid(), form.errors)
  1235. form.save()
  1236. lag.refresh_from_db()
  1237. self.assertEqual(lag.lag_mode, InterfaceLAGModeChoices.MODE_ACTIVE_BACKUP)
  1238. self.assertIsNone(lag.lag_hash_policy)
  1239. def test_lag_attributes_cleared_when_changing_from_lag_type(self):
  1240. """Changing a LAG interface to another type clears its LAG mode and hash policy."""
  1241. lag = Interface.objects.create(
  1242. device=self.device,
  1243. name='bond0',
  1244. type=InterfaceTypeChoices.TYPE_LAG,
  1245. lag_mode=InterfaceLAGModeChoices.MODE_LACP,
  1246. lag_hash_policy=InterfaceLAGHashPolicyChoices.POLICY_LAYER3_4,
  1247. )
  1248. data = {
  1249. 'device': self.device.pk,
  1250. 'name': 'bond0',
  1251. 'type': InterfaceTypeChoices.TYPE_1GE_FIXED,
  1252. 'lag_mode': InterfaceLAGModeChoices.MODE_LACP,
  1253. 'lag_hash_policy': InterfaceLAGHashPolicyChoices.POLICY_LAYER3_4,
  1254. }
  1255. form = InterfaceForm(data, instance=lag)
  1256. self.assertTrue(form.is_valid(), form.errors)
  1257. form.save()
  1258. lag.refresh_from_db()
  1259. self.assertEqual(lag.type, InterfaceTypeChoices.TYPE_1GE_FIXED)
  1260. self.assertIsNone(lag.lag_mode)
  1261. self.assertIsNone(lag.lag_hash_policy)
  1262. def test_lag_attributes_only_for_lag_interfaces(self):
  1263. """LAG attributes are offered only for LAG interfaces, and are not saved for any other type."""
  1264. self.assertIn('lag_mode', InterfaceForm(initial={'type': InterfaceTypeChoices.TYPE_LAG}).fields)
  1265. data = {
  1266. 'device': self.device.pk,
  1267. 'name': 'eth9',
  1268. 'type': InterfaceTypeChoices.TYPE_1GE_FIXED,
  1269. 'lag_mode': InterfaceLAGModeChoices.MODE_LACP,
  1270. }
  1271. form = InterfaceForm(data)
  1272. self.assertNotIn('lag_mode', form.fields)
  1273. self.assertNotIn('lag_hash_policy', form.fields)
  1274. self.assertTrue(form.is_valid(), form.errors)
  1275. self.assertIsNone(form.save().lag_mode)
  1276. def test_child_interface_preselects_every_parent_vdc(self):
  1277. """A child interface's form pre-selects every virtual device context of its parent."""
  1278. vdcs = (
  1279. VirtualDeviceContext(
  1280. device=self.device,
  1281. name='VDC 1',
  1282. identifier=1,
  1283. status=VirtualDeviceContextStatusChoices.STATUS_ACTIVE
  1284. ),
  1285. VirtualDeviceContext(
  1286. device=self.device,
  1287. name='VDC 2',
  1288. identifier=2,
  1289. status=VirtualDeviceContextStatusChoices.STATUS_ACTIVE
  1290. ),
  1291. )
  1292. VirtualDeviceContext.objects.bulk_create(vdcs)
  1293. self.interface.vdcs.set(vdcs)
  1294. form = InterfaceForm(initial={'device': self.device.pk, 'parent': self.interface.pk})
  1295. self.assertCountEqual([vdc.pk for vdc in form['vdcs'].field.queryset], [vdc.pk for vdc in vdcs])
  1296. class CableTestCase(TestCase):
  1297. @classmethod
  1298. def setUpTestData(cls):
  1299. cls.site = Site.objects.create(name='Site 1', slug='site-1')
  1300. cls.device_a = create_test_device('Device A', site=cls.site)
  1301. cls.device_b = create_test_device('Device B', site=cls.site)
  1302. cls.device_c = create_test_device('Device C', site=cls.site)
  1303. cls.interfaces_a = (
  1304. Interface(device=cls.device_a, name='et-0/0/0', type=InterfaceTypeChoices.TYPE_1GE_FIXED),
  1305. Interface(device=cls.device_a, name='et-0/0/1', type=InterfaceTypeChoices.TYPE_1GE_FIXED),
  1306. )
  1307. cls.interfaces_b = (
  1308. Interface(device=cls.device_b, name='et-0/0/0', type=InterfaceTypeChoices.TYPE_1GE_FIXED),
  1309. Interface(device=cls.device_b, name='et-0/0/1', type=InterfaceTypeChoices.TYPE_1GE_FIXED),
  1310. Interface(device=cls.device_b, name='et-0/0/2', type=InterfaceTypeChoices.TYPE_1GE_FIXED),
  1311. )
  1312. cls.interface_c = Interface(device=cls.device_c, name='et-0/0/1', type=InterfaceTypeChoices.TYPE_1GE_FIXED)
  1313. Interface.objects.bulk_create([*cls.interfaces_a, *cls.interfaces_b, cls.interface_c])
  1314. cls.power_panel = PowerPanel.objects.create(site=cls.site, name='Power Panel 1')
  1315. cls.power_feeds = (
  1316. PowerFeed(power_panel=cls.power_panel, name='Power Feed 1'),
  1317. PowerFeed(power_panel=cls.power_panel, name='Power Feed 2'),
  1318. )
  1319. PowerFeed.objects.bulk_create(cls.power_feeds)
  1320. cls.power_ports = (
  1321. PowerPort(device=cls.device_b, name='Power Port 1'),
  1322. PowerPort(device=cls.device_b, name='Power Port 2'),
  1323. )
  1324. PowerPort.objects.bulk_create(cls.power_ports)
  1325. def _make_edit_form(self):
  1326. cable = Cable(
  1327. a_terminations=[self.interfaces_a[0]],
  1328. b_terminations=[self.interfaces_b[1], self.interface_c],
  1329. )
  1330. cable.save()
  1331. return get_cable_form(Interface, Interface)(instance=Cable.objects.get(pk=cable.pk))
  1332. def test_invalid_side_designation_raises_value_error(self):
  1333. """_clean_side rejects a side other than 'a' or 'b' with ValueError."""
  1334. form = CableImportForm.__new__(CableImportForm)
  1335. with self.assertRaisesMessage(ValueError, "Invalid side designation: c"):
  1336. form._clean_side('c')
  1337. def test_import_single_termination_cable(self):
  1338. """A single-value cell per side resolves one termination per side."""
  1339. form = CableImportForm(data={
  1340. 'side_a_site': 'Site 1',
  1341. 'side_a_device': 'Device A',
  1342. 'side_a_type': 'dcim.interface',
  1343. 'side_a_name': 'et-0/0/0',
  1344. 'side_b_site': 'Site 1',
  1345. 'side_b_device': 'Device B',
  1346. 'side_b_type': 'dcim.interface',
  1347. 'side_b_name': 'et-0/0/0',
  1348. 'status': LinkStatusChoices.STATUS_CONNECTED,
  1349. })
  1350. self.assertTrue(form.is_valid(), form.errors)
  1351. cable = form.save()
  1352. self.assertEqual(cable.a_terminations, [self.interfaces_a[0]])
  1353. self.assertEqual(cable.b_terminations, [self.interfaces_b[0]])
  1354. def test_import_multiple_terminations_single_parent(self):
  1355. """A single parent value is reused for all comma-separated termination names."""
  1356. form = CableImportForm(data={
  1357. 'side_a_device': 'Device A',
  1358. 'side_a_type': 'dcim.interface',
  1359. 'side_a_name': 'et-0/0/0',
  1360. 'side_b_device': 'Device B',
  1361. 'side_b_type': 'dcim.interface',
  1362. 'side_b_name': 'et-0/0/1, et-0/0/2',
  1363. 'status': LinkStatusChoices.STATUS_CONNECTED,
  1364. 'profile': CableProfileChoices.BREAKOUT_1C2P_2C1P,
  1365. })
  1366. self.assertTrue(form.is_valid(), form.errors)
  1367. cable = form.save()
  1368. self.assertEqual(cable.a_terminations, [self.interfaces_a[0]])
  1369. self.assertEqual(cable.b_terminations, [self.interfaces_b[1], self.interfaces_b[2]])
  1370. def test_import_multiple_terminations_multiple_parents_preserves_order(self):
  1371. """Pairwise parent/name lists resolve in submitted order, driving connector assignment."""
  1372. form = CableImportForm(data={
  1373. 'side_a_device': 'Device A',
  1374. 'side_a_type': 'dcim.interface',
  1375. 'side_a_name': 'et-0/0/0',
  1376. 'side_b_device': 'Device C,Device B',
  1377. 'side_b_type': 'dcim.interface',
  1378. 'side_b_name': 'et-0/0/1,et-0/0/1',
  1379. 'status': LinkStatusChoices.STATUS_CONNECTED,
  1380. 'profile': CableProfileChoices.BREAKOUT_1C2P_2C1P,
  1381. })
  1382. self.assertTrue(form.is_valid(), form.errors)
  1383. cable = form.save()
  1384. self.assertEqual(cable.b_terminations, [self.interface_c, self.interfaces_b[1]])
  1385. cable_terminations = CableTermination.objects.filter(
  1386. cable=cable, cable_end=CableEndChoices.SIDE_B
  1387. ).order_by('connector')
  1388. self.assertEqual([ct.termination for ct in cable_terminations], [self.interface_c, self.interfaces_b[1]])
  1389. self.assertEqual([ct.connector for ct in cable_terminations], [1, 2])
  1390. def test_import_multiple_terminations_parent_count_mismatch(self):
  1391. """A parent list that is neither one value nor one per termination name is rejected."""
  1392. form = CableImportForm(data={
  1393. 'side_a_device': 'Device A',
  1394. 'side_a_type': 'dcim.interface',
  1395. 'side_a_name': 'et-0/0/0',
  1396. 'side_b_device': 'Device B,Device C',
  1397. 'side_b_type': 'dcim.interface',
  1398. 'side_b_name': 'et-0/0/1,et-0/0/1,et-0/0/2',
  1399. 'status': LinkStatusChoices.STATUS_CONNECTED,
  1400. })
  1401. self.assertFalse(form.is_valid())
  1402. self.assertIn('Must specify either one device', str(form.errors.get('side_b_name')))
  1403. def test_import_multiple_terminations_duplicate_termination(self):
  1404. """The same termination cannot be listed twice on one cable end."""
  1405. form = CableImportForm(data={
  1406. 'side_a_device': 'Device A',
  1407. 'side_a_type': 'dcim.interface',
  1408. 'side_a_name': 'et-0/0/0',
  1409. 'side_b_device': 'Device B',
  1410. 'side_b_type': 'dcim.interface',
  1411. 'side_b_name': 'et-0/0/1,et-0/0/1',
  1412. 'status': LinkStatusChoices.STATUS_CONNECTED,
  1413. })
  1414. self.assertFalse(form.is_valid())
  1415. self.assertIn('Duplicate termination', str(form.errors.get('side_b_name')))
  1416. def test_import_terminations_exceeding_profile_capacity(self):
  1417. """A side carrying more terminations than its profile permits reports against that side's column."""
  1418. form = CableImportForm(data={
  1419. 'side_a_device': 'Device A',
  1420. 'side_a_type': 'dcim.interface',
  1421. 'side_a_name': 'et-0/0/0',
  1422. 'side_b_device': 'Device B',
  1423. 'side_b_type': 'dcim.interface',
  1424. 'side_b_name': 'et-0/0/0,et-0/0/1,et-0/0/2',
  1425. 'status': LinkStatusChoices.STATUS_CONNECTED,
  1426. 'profile': CableProfileChoices.BREAKOUT_1C2P_2C1P,
  1427. })
  1428. self.assertFalse(form.is_valid())
  1429. self.assertIn('only 2 are permitted', str(form.errors.get('side_b_name')))
  1430. def test_import_terminations_exceeding_profile_capacity_side_a(self):
  1431. """The same applies to side A, whose profile capacity is often lower than side B's."""
  1432. form = CableImportForm(data={
  1433. 'side_a_device': 'Device A',
  1434. 'side_a_type': 'dcim.interface',
  1435. 'side_a_name': 'et-0/0/0,et-0/0/1',
  1436. 'side_b_device': 'Device B',
  1437. 'side_b_type': 'dcim.interface',
  1438. 'side_b_name': 'et-0/0/0',
  1439. 'status': LinkStatusChoices.STATUS_CONNECTED,
  1440. 'profile': CableProfileChoices.BREAKOUT_1C2P_2C1P,
  1441. })
  1442. self.assertFalse(form.is_valid())
  1443. self.assertIn('only 1 are permitted', str(form.errors.get('side_a_name')))
  1444. def test_import_multiple_terminations_empty_name(self):
  1445. """A trailing comma produces an empty termination name and is rejected."""
  1446. form = CableImportForm(data={
  1447. 'side_a_device': 'Device A',
  1448. 'side_a_type': 'dcim.interface',
  1449. 'side_a_name': 'et-0/0/0',
  1450. 'side_b_device': 'Device B',
  1451. 'side_b_type': 'dcim.interface',
  1452. 'side_b_name': 'et-0/0/1,',
  1453. 'status': LinkStatusChoices.STATUS_CONNECTED,
  1454. })
  1455. self.assertFalse(form.is_valid())
  1456. self.assertIn('Empty termination names', str(form.errors.get('side_b_name')))
  1457. def test_import_multiple_terminations_connected_termination(self):
  1458. """An already-cabled termination in a multi-value list is rejected."""
  1459. cable = Cable(a_terminations=[self.interfaces_a[1]], b_terminations=[self.interfaces_b[1]])
  1460. cable.save()
  1461. form = CableImportForm(data={
  1462. 'side_a_device': 'Device A',
  1463. 'side_a_type': 'dcim.interface',
  1464. 'side_a_name': 'et-0/0/0',
  1465. 'side_b_device': 'Device B',
  1466. 'side_b_type': 'dcim.interface',
  1467. 'side_b_name': 'et-0/0/1,et-0/0/2',
  1468. 'status': LinkStatusChoices.STATUS_CONNECTED,
  1469. })
  1470. self.assertFalse(form.is_valid())
  1471. self.assertIn('already connected', str(form.errors.get('side_b_name')))
  1472. def test_import_multiple_terminations_power_feeds(self):
  1473. """Multiple power feeds import from a single broadcast power panel."""
  1474. form = CableImportForm(data={
  1475. 'side_a_power_panel': 'Power Panel 1',
  1476. 'side_a_type': 'dcim.powerfeed',
  1477. 'side_a_name': 'Power Feed 1,Power Feed 2',
  1478. 'side_b_device': 'Device B',
  1479. 'side_b_type': 'dcim.powerport',
  1480. 'side_b_name': 'Power Port 1,Power Port 2',
  1481. 'status': LinkStatusChoices.STATUS_CONNECTED,
  1482. })
  1483. self.assertTrue(form.is_valid(), form.errors)
  1484. cable = form.save()
  1485. self.assertEqual(cable.a_terminations, list(self.power_feeds))
  1486. self.assertEqual(cable.b_terminations, list(self.power_ports))
  1487. def test_import_multiple_terminations_repeated_parent_values(self):
  1488. """A repeated parent in a pairwise list resolves per position, not deduplicated."""
  1489. form = CableImportForm(data={
  1490. 'side_a_device': 'Device A',
  1491. 'side_a_type': 'dcim.interface',
  1492. 'side_a_name': 'et-0/0/0',
  1493. 'side_b_device': 'Device B,Device C,Device B',
  1494. 'side_b_type': 'dcim.interface',
  1495. 'side_b_name': 'et-0/0/1,et-0/0/1,et-0/0/2',
  1496. 'status': LinkStatusChoices.STATUS_CONNECTED,
  1497. })
  1498. self.assertTrue(form.is_valid(), form.errors)
  1499. cable = form.save()
  1500. self.assertEqual(
  1501. cable.b_terminations,
  1502. [self.interfaces_b[1], self.interface_c, self.interfaces_b[2]]
  1503. )
  1504. def test_import_multiple_terminations_native_lists(self):
  1505. """Native list values (JSON/YAML import) resolve like comma-separated cells."""
  1506. form = CableImportForm(data={
  1507. 'side_a_device': 'Device A',
  1508. 'side_a_type': 'dcim.interface',
  1509. 'side_a_name': 'et-0/0/0',
  1510. 'side_b_device': ['Device C', 'Device B'],
  1511. 'side_b_type': 'dcim.interface',
  1512. 'side_b_name': ['et-0/0/1', 'et-0/0/1'],
  1513. 'status': LinkStatusChoices.STATUS_CONNECTED,
  1514. 'profile': CableProfileChoices.BREAKOUT_1C2P_2C1P,
  1515. })
  1516. self.assertTrue(form.is_valid(), form.errors)
  1517. cable = form.save()
  1518. self.assertEqual(cable.b_terminations, [self.interface_c, self.interfaces_b[1]])
  1519. def test_import_multiple_terminations_unknown_parent(self):
  1520. """An unknown parent in a multi-value cell errors on the parent field only."""
  1521. form = CableImportForm(data={
  1522. 'side_a_device': 'Device A',
  1523. 'side_a_type': 'dcim.interface',
  1524. 'side_a_name': 'et-0/0/0',
  1525. 'side_b_device': 'Device B,Device X',
  1526. 'side_b_type': 'dcim.interface',
  1527. 'side_b_name': 'et-0/0/1,et-0/0/2',
  1528. 'status': LinkStatusChoices.STATUS_CONNECTED,
  1529. })
  1530. self.assertFalse(form.is_valid())
  1531. self.assertIn('Object not found: Device X', str(form.errors.get('side_b_device')))
  1532. self.assertNotIn('side_b_name', form.errors)
  1533. def test_import_multiple_terminations_missing_parent(self):
  1534. """A device component termination type without a device value is rejected."""
  1535. form = CableImportForm(data={
  1536. 'side_a_device': 'Device A',
  1537. 'side_a_type': 'dcim.interface',
  1538. 'side_a_name': 'et-0/0/0',
  1539. 'side_b_type': 'dcim.interface',
  1540. 'side_b_name': 'et-0/0/1,et-0/0/2',
  1541. 'status': LinkStatusChoices.STATUS_CONNECTED,
  1542. })
  1543. self.assertFalse(form.is_valid())
  1544. self.assertIn('Must specify a device', str(form.errors.get('side_b_name')))
  1545. def test_import_unsupported_termination_type(self):
  1546. """Termination types without a supported parent field are rejected."""
  1547. form = CableImportForm(data={
  1548. 'side_a_device': 'Device A',
  1549. 'side_a_type': 'dcim.interface',
  1550. 'side_a_name': 'et-0/0/0',
  1551. 'side_b_device': 'Device B',
  1552. 'side_b_type': 'circuits.circuittermination',
  1553. 'side_b_name': 'Termination X',
  1554. 'status': LinkStatusChoices.STATUS_CONNECTED,
  1555. })
  1556. self.assertFalse(form.is_valid())
  1557. self.assertIn('Bulk import does not support', str(form.errors.get('side_b_name')))
  1558. def test_import_unknown_termination_type(self):
  1559. """An unresolvable termination type errors on the type field only."""
  1560. form = CableImportForm(data={
  1561. 'side_a_device': 'Device A',
  1562. 'side_a_type': 'dcim.interface',
  1563. 'side_a_name': 'et-0/0/0',
  1564. 'side_b_device': 'Device B',
  1565. 'side_b_type': 'dcim.nosuchmodel',
  1566. 'side_b_name': 'et-0/0/1',
  1567. 'status': LinkStatusChoices.STATUS_CONNECTED,
  1568. })
  1569. self.assertFalse(form.is_valid())
  1570. self.assertIn('side_b_type', form.errors)
  1571. self.assertNotIn('side_b_name', form.errors)
  1572. def test_import_multiple_terminations_unknown_name(self):
  1573. """An unknown termination name in a multi-value list is rejected."""
  1574. form = CableImportForm(data={
  1575. 'side_a_device': 'Device A',
  1576. 'side_a_type': 'dcim.interface',
  1577. 'side_a_name': 'et-0/0/0',
  1578. 'side_b_device': 'Device B',
  1579. 'side_b_type': 'dcim.interface',
  1580. 'side_b_name': 'et-0/0/1,et-0/0/9',
  1581. 'status': LinkStatusChoices.STATUS_CONNECTED,
  1582. })
  1583. self.assertFalse(form.is_valid())
  1584. self.assertIn('side termination not found', str(form.errors.get('side_b_name')))
  1585. def test_import_multiple_terminations_ambiguous_parent(self):
  1586. """A parent name matching multiple objects errors on the parent field."""
  1587. site_2 = Site.objects.create(name='Site 2', slug='site-2')
  1588. create_test_device('Device D', site=self.site)
  1589. create_test_device('Device D', site=site_2)
  1590. form = CableImportForm(data={
  1591. 'side_a_device': 'Device A',
  1592. 'side_a_type': 'dcim.interface',
  1593. 'side_a_name': 'et-0/0/0',
  1594. 'side_b_device': 'Device D',
  1595. 'side_b_type': 'dcim.interface',
  1596. 'side_b_name': 'et-0/0/1',
  1597. 'status': LinkStatusChoices.STATUS_CONNECTED,
  1598. })
  1599. self.assertFalse(form.is_valid())
  1600. self.assertIn('is not a unique value', str(form.errors.get('side_b_device')))
  1601. self.assertNotIn('side_b_name', form.errors)
  1602. def test_import_multiple_terminations_site_filtered_parent_queryset(self):
  1603. """Parent resolution honors side_x_site queryset filtering for multi-value parents."""
  1604. site_2 = Site.objects.create(name='Site 2', slug='site-2')
  1605. device_x = create_test_device('Device X', site=site_2)
  1606. Interface.objects.create(device=device_x, name='et-0/0/1', type=InterfaceTypeChoices.TYPE_1GE_FIXED)
  1607. form = CableImportForm(data={
  1608. 'side_a_site': 'Site 1',
  1609. 'side_a_device': 'Device A',
  1610. 'side_a_type': 'dcim.interface',
  1611. 'side_a_name': 'et-0/0/0',
  1612. 'side_b_site': 'Site 1',
  1613. 'side_b_device': 'Device B,Device X',
  1614. 'side_b_type': 'dcim.interface',
  1615. 'side_b_name': 'et-0/0/1,et-0/0/1',
  1616. 'status': LinkStatusChoices.STATUS_CONNECTED,
  1617. })
  1618. self.assertFalse(form.is_valid())
  1619. self.assertIn('Object not found: Device X', str(form.errors.get('side_b_device')))
  1620. self.assertNotIn('side_b_name', form.errors)
  1621. def test_import_ambiguous_vc_component(self):
  1622. """A component name found on multiple VC members produces a form error."""
  1623. vc = VirtualChassis.objects.create(name='Virtual Chassis 1')
  1624. master = create_test_device('VC Master', site=self.site, virtual_chassis=vc, vc_position=1)
  1625. member_2 = create_test_device('VC Member 2', site=self.site, virtual_chassis=vc, vc_position=2)
  1626. member_3 = create_test_device('VC Member 3', site=self.site, virtual_chassis=vc, vc_position=3)
  1627. vc.master = master
  1628. vc.save()
  1629. Interface.objects.create(device=member_2, name='vc-eth0', type=InterfaceTypeChoices.TYPE_1GE_FIXED)
  1630. Interface.objects.create(device=member_3, name='vc-eth0', type=InterfaceTypeChoices.TYPE_1GE_FIXED)
  1631. form = CableImportForm(data={
  1632. 'side_a_device': 'Device A',
  1633. 'side_a_type': 'dcim.interface',
  1634. 'side_a_name': 'et-0/0/0',
  1635. 'side_b_device': 'VC Master',
  1636. 'side_b_type': 'dcim.interface',
  1637. 'side_b_name': 'vc-eth0',
  1638. 'status': LinkStatusChoices.STATUS_CONNECTED,
  1639. })
  1640. self.assertFalse(form.is_valid())
  1641. self.assertIn('side termination not unique', str(form.errors.get('side_b_name')))
  1642. def test_edit_form_selects_every_device_terminating_an_end(self):
  1643. """The edit form selects every device terminating an end of the cable."""
  1644. form = self._make_edit_form()
  1645. self.assertCountEqual(
  1646. [device.pk for device in form['termination_b_device'].field.queryset],
  1647. [self.device_b.pk, self.device_c.pk]
  1648. )
  1649. def test_edit_form_names_the_device_of_each_termination(self):
  1650. """Each termination option names its device, so identically named interfaces stay distinct."""
  1651. html = str(self._make_edit_form()['b_terminations'])
  1652. for interface in (self.interfaces_b[1], self.interface_c):
  1653. self.assertInHTML(
  1654. f'<option value="{interface.pk}" data-parent="{interface.device}" selected>et-0/0/1</option>', html
  1655. )
  1656. def test_termination_fields_preserve_their_selection(self):
  1657. """Only the termination fields keep their selection when a parent selector changes."""
  1658. for termination_type, parent in (
  1659. (Interface, 'device'),
  1660. (PowerFeed, 'powerpanel'),
  1661. (CircuitTermination, 'circuit'),
  1662. ):
  1663. fields = get_cable_form(termination_type, termination_type)().fields
  1664. with self.subTest(termination_type=termination_type.__name__):
  1665. self.assertIn('data-preserve-selection', fields['b_terminations'].widget.attrs)
  1666. self.assertNotIn('data-preserve-selection', fields[f'termination_b_{parent}'].widget.attrs)
  1667. def test_edit_form_saves_terminations_outside_the_device_filter(self):
  1668. """Saving keeps every selected termination and its row, even when its device is not in the Device filter."""
  1669. cable = self._make_edit_form().instance
  1670. rows = CableTermination.objects.filter(cable=cable, cable_end=CableEndChoices.SIDE_B)
  1671. existing_rows = set(rows.values_list('pk', flat=True))
  1672. device_d = create_test_device('Device D', site=self.site)
  1673. interface_d = Interface.objects.create(
  1674. device=device_d, name='et-0/0/1', type=InterfaceTypeChoices.TYPE_1GE_FIXED
  1675. )
  1676. b_terminations = [self.interfaces_b[1], self.interface_c, interface_d]
  1677. form = get_cable_form(Interface, Interface)(instance=Cable.objects.get(pk=cable.pk), data={
  1678. 'a_terminations_type': 'dcim.interface',
  1679. 'b_terminations_type': 'dcim.interface',
  1680. 'termination_a_device': [self.device_a.pk],
  1681. 'termination_b_device': [device_d.pk],
  1682. 'a_terminations': [self.interfaces_a[0].pk],
  1683. 'b_terminations': [interface.pk for interface in b_terminations],
  1684. 'status': LinkStatusChoices.STATUS_CONNECTED,
  1685. })
  1686. self.assertTrue(form.is_valid(), form.errors)
  1687. form.save()
  1688. self.assertCountEqual(Cable.objects.get(pk=cable.pk).b_terminations, b_terminations)
  1689. self.assertTrue(existing_rows.issubset(rows.values_list('pk', flat=True)))
  1690. class SiteFormTestCase(TestCase):
  1691. """
  1692. Tests for M2MAddRemoveFields using Site ASN assignments as the test case.
  1693. Covers both simple mode (single multi-select field) and add/remove mode (dual fields).
  1694. """
  1695. @classmethod
  1696. def setUpTestData(cls):
  1697. cls.rir = RIR.objects.create(name='RIR 1', slug='rir-1')
  1698. # Create 110 ASNs: 100 to pre-assign (triggering add/remove mode) plus 10 extras
  1699. ASN.objects.bulk_create([ASN(asn=i, rir=cls.rir) for i in range(1, 111)])
  1700. cls.asns = list(ASN.objects.order_by('asn'))
  1701. def _site_data(self, **kwargs):
  1702. data = {'name': 'Test Site', 'slug': 'test-site', 'status': 'active'}
  1703. data.update(kwargs)
  1704. return data
  1705. def test_new_site_uses_simple_mode(self):
  1706. """A form for a new site uses the single 'asns' field (simple mode)."""
  1707. form = SiteForm(data=self._site_data())
  1708. self.assertIn('asns', form.fields)
  1709. self.assertNotIn('add_asns', form.fields)
  1710. self.assertNotIn('remove_asns', form.fields)
  1711. def test_existing_site_below_threshold_uses_simple_mode(self):
  1712. """A form for an existing site with fewer than THRESHOLD ASNs uses simple mode."""
  1713. site = Site.objects.create(name='Site 1', slug='site-1')
  1714. site.asns.set(self.asns[:5])
  1715. form = SiteForm(instance=site)
  1716. self.assertIn('asns', form.fields)
  1717. self.assertNotIn('add_asns', form.fields)
  1718. self.assertNotIn('remove_asns', form.fields)
  1719. def test_existing_site_at_threshold_uses_add_remove_mode(self):
  1720. """A form for an existing site with THRESHOLD or more ASNs uses add/remove mode."""
  1721. site = Site.objects.create(name='Site 2', slug='site-2')
  1722. site.asns.set(self.asns[:M2MAddRemoveFields.THRESHOLD])
  1723. form = SiteForm(instance=site)
  1724. self.assertNotIn('asns', form.fields)
  1725. self.assertIn('add_asns', form.fields)
  1726. self.assertIn('remove_asns', form.fields)
  1727. def test_simple_mode_assigns_asns_on_create(self):
  1728. """Saving a new site via simple mode assigns the selected ASNs."""
  1729. asn_pks = [asn.pk for asn in self.asns[:3]]
  1730. form = SiteForm(data=self._site_data(asns=asn_pks))
  1731. self.assertTrue(form.is_valid(), form.errors)
  1732. site = form.save()
  1733. self.assertEqual(set(site.asns.values_list('pk', flat=True)), set(asn_pks))
  1734. def test_simple_mode_replaces_asns_on_edit(self):
  1735. """Saving an existing site via simple mode replaces the current ASN assignments."""
  1736. site = Site.objects.create(name='Site 3', slug='site-3')
  1737. site.asns.set(self.asns[:3])
  1738. new_asn_pks = [asn.pk for asn in self.asns[3:6]]
  1739. form = SiteForm(
  1740. data=self._site_data(name='Site 3', slug='site-3', asns=new_asn_pks),
  1741. instance=site
  1742. )
  1743. self.assertTrue(form.is_valid(), form.errors)
  1744. site = form.save()
  1745. self.assertEqual(set(site.asns.values_list('pk', flat=True)), set(new_asn_pks))
  1746. def test_add_remove_mode_adds_asns(self):
  1747. """In add/remove mode, specifying 'add_asns' appends to current assignments."""
  1748. site = Site.objects.create(name='Site 4', slug='site-4')
  1749. site.asns.set(self.asns[:M2MAddRemoveFields.THRESHOLD])
  1750. new_asn_pks = [asn.pk for asn in self.asns[M2MAddRemoveFields.THRESHOLD:]]
  1751. form = SiteForm(
  1752. data=self._site_data(name='Site 4', slug='site-4', add_asns=new_asn_pks),
  1753. instance=site
  1754. )
  1755. self.assertTrue(form.is_valid(), form.errors)
  1756. site = form.save()
  1757. self.assertEqual(site.asns.count(), len(self.asns))
  1758. def test_add_remove_mode_removes_asns(self):
  1759. """In add/remove mode, specifying 'remove_asns' drops those assignments."""
  1760. site = Site.objects.create(name='Site 5', slug='site-5')
  1761. site.asns.set(self.asns[:M2MAddRemoveFields.THRESHOLD])
  1762. remove_pks = [asn.pk for asn in self.asns[:5]]
  1763. form = SiteForm(
  1764. data=self._site_data(name='Site 5', slug='site-5', remove_asns=remove_pks),
  1765. instance=site
  1766. )
  1767. self.assertTrue(form.is_valid(), form.errors)
  1768. site = form.save()
  1769. self.assertEqual(site.asns.count(), M2MAddRemoveFields.THRESHOLD - 5)
  1770. self.assertFalse(site.asns.filter(pk__in=remove_pks).exists())
  1771. def test_add_remove_mode_simultaneous_add_and_remove(self):
  1772. """In add/remove mode, add and remove operations are applied together."""
  1773. site = Site.objects.create(name='Site 6', slug='site-6')
  1774. site.asns.set(self.asns[:M2MAddRemoveFields.THRESHOLD])
  1775. add_pks = [asn.pk for asn in self.asns[M2MAddRemoveFields.THRESHOLD:M2MAddRemoveFields.THRESHOLD + 3]]
  1776. remove_pks = [asn.pk for asn in self.asns[:3]]
  1777. form = SiteForm(
  1778. data=self._site_data(name='Site 6', slug='site-6', add_asns=add_pks, remove_asns=remove_pks),
  1779. instance=site
  1780. )
  1781. self.assertTrue(form.is_valid(), form.errors)
  1782. site = form.save()
  1783. self.assertEqual(site.asns.count(), M2MAddRemoveFields.THRESHOLD)
  1784. self.assertTrue(site.asns.filter(pk__in=add_pks).count() == 3)
  1785. self.assertFalse(site.asns.filter(pk__in=remove_pks).exists())