Просмотр исходного кода

Fixes #4067: Correct permission checked when creating a rack (vs. editing)

Jeremy Stretch 6 лет назад
Родитель
Сommit
f632b5bc29
3 измененных файлов с 2 добавлено и 4 удалено
  1. 1 0
      docs/release-notes/version-2.7.md
  2. 0 3
      netbox/dcim/tests/test_views.py
  3. 1 1
      netbox/dcim/urls.py

+ 1 - 0
docs/release-notes/version-2.7.md

@@ -12,6 +12,7 @@
 * [#4049](https://github.com/netbox-community/netbox/issues/4049) - Restore missing `tags` field in IPAM service serializer
 * [#4049](https://github.com/netbox-community/netbox/issues/4049) - Restore missing `tags` field in IPAM service serializer
 * [#4052](https://github.com/netbox-community/netbox/issues/4052) - Fix error when bulk importing interfaces to virtual machines
 * [#4052](https://github.com/netbox-community/netbox/issues/4052) - Fix error when bulk importing interfaces to virtual machines
 * [#4056](https://github.com/netbox-community/netbox/issues/4056) - Repair schema migration for Rack.outer_unit (from #3569)
 * [#4056](https://github.com/netbox-community/netbox/issues/4056) - Repair schema migration for Rack.outer_unit (from #3569)
+* [#4067](https://github.com/netbox-community/netbox/issues/4067) - Correct permission checked when creating a rack (vs. editing)
 * [#4071](https://github.com/netbox-community/netbox/issues/4071) - Enforce "view tag" permission on individual tag view
 * [#4071](https://github.com/netbox-community/netbox/issues/4071) - Enforce "view tag" permission on individual tag view
 
 
 ---
 ---

+ 0 - 3
netbox/dcim/tests/test_views.py

@@ -191,9 +191,6 @@ class RackReservationTestCase(StandardTestCases.Views):
 class RackTestCase(StandardTestCases.Views):
 class RackTestCase(StandardTestCases.Views):
     model = Rack
     model = Rack
 
 
-    # TODO: Remove this when #4067 is fixed
-    test_create_object = None
-
     @classmethod
     @classmethod
     def setUpTestData(cls):
     def setUpTestData(cls):
 
 

+ 1 - 1
netbox/dcim/urls.py

@@ -60,7 +60,7 @@ urlpatterns = [
     # Racks
     # Racks
     path(r'racks/', views.RackListView.as_view(), name='rack_list'),
     path(r'racks/', views.RackListView.as_view(), name='rack_list'),
     path(r'rack-elevations/', views.RackElevationListView.as_view(), name='rack_elevation_list'),
     path(r'rack-elevations/', views.RackElevationListView.as_view(), name='rack_elevation_list'),
-    path(r'racks/add/', views.RackEditView.as_view(), name='rack_add'),
+    path(r'racks/add/', views.RackCreateView.as_view(), name='rack_add'),
     path(r'racks/import/', views.RackBulkImportView.as_view(), name='rack_import'),
     path(r'racks/import/', views.RackBulkImportView.as_view(), name='rack_import'),
     path(r'racks/edit/', views.RackBulkEditView.as_view(), name='rack_bulk_edit'),
     path(r'racks/edit/', views.RackBulkEditView.as_view(), name='rack_bulk_edit'),
     path(r'racks/delete/', views.RackBulkDeleteView.as_view(), name='rack_bulk_delete'),
     path(r'racks/delete/', views.RackBulkDeleteView.as_view(), name='rack_bulk_delete'),