Bläddra i källkod

Fixes #18619: shift-select selects hidden items

This also fixes the inverse, when a range is unselected via shift-click,
previously checked checkboxes that are hidden are not changed.
Jason Novinger 1 år sedan
förälder
incheckning
ed79e3bbf4

Filskillnaden har hållts tillbaka eftersom den är för stor
+ 0 - 0
netbox/project-static/dist/netbox.js


Filskillnaden har hållts tillbaka eftersom den är för stor
+ 0 - 0
netbox/project-static/dist/netbox.js.map


+ 6 - 2
netbox/project-static/src/buttons/selectMultiple.ts

@@ -43,7 +43,9 @@ function toggleCheckboxRange(
     const typedElement = element as HTMLInputElement;
     const typedElement = element as HTMLInputElement;
     //Change loop's current checkbox state to eventTargetElement checkbox state
     //Change loop's current checkbox state to eventTargetElement checkbox state
     if (changePkCheckboxState === true) {
     if (changePkCheckboxState === true) {
-      typedElement.checked = eventTargetElement.checked;
+      if (!typedElement.closest('tr')?.classList.contains('d-none')) {
+        typedElement.checked = eventTargetElement.checked;
+      }
     }
     }
     //The previously clicked checkbox was above the shift clicked checkbox
     //The previously clicked checkbox was above the shift clicked checkbox
     if (element === previousStateElement) {
     if (element === previousStateElement) {
@@ -52,7 +54,9 @@ function toggleCheckboxRange(
         return;
         return;
       }
       }
       changePkCheckboxState = true;
       changePkCheckboxState = true;
-      typedElement.checked = eventTargetElement.checked;
+      if (!typedElement.closest('tr')?.classList.contains('d-none')) {
+        typedElement.checked = eventTargetElement.checked;
+      }
     }
     }
     //The previously clicked checkbox was below the shift clicked checkbox
     //The previously clicked checkbox was below the shift clicked checkbox
     if (element === eventTargetElement) {
     if (element === eventTargetElement) {

Vissa filer visades inte eftersom för många filer har ändrats