Fix test user permissions for API pagination tests

netbox/utilities/testing/api.py

@@ -39,13 +39,13 @@ class APITestCase(ModelTestCase):
 
     def setUp(self):
         """
-        Create a superuser and token for API calls.
+        Create a user and token for API calls.
         """
         # Create the test user and assign permissions
         self.user = User.objects.create_user(username='testuser')
         self.add_permissions(*self.user_permissions)
         self.token = Token.objects.create(user=self.user)
-        self.header = {'HTTP_AUTHORIZATION': 'Token {}'.format(self.token.key)}
+        self.header = {'HTTP_AUTHORIZATION': f'Token {self.token.key}'}
 
     def _get_view_namespace(self):
         return f'{self.view_namespace or self.model._meta.app_label}-api'

netbox/utilities/tests/test_api.py

@@ -124,6 +124,7 @@ class WritableNestedSerializerTest(APITestCase):
 
 
 class APIPaginationTestCase(APITestCase):
+    user_permissions = ('dcim.view_site',)
 
     @classmethod
     def setUpTestData(cls):
@@ -139,6 +140,7 @@ class APIPaginationTestCase(APITestCase):
         page_size = settings.PAGINATE_COUNT
         self.assertLess(page_size, 100, "Default page size not sufficient for data set")
 
+        self.assertHttpStatus(response, status.HTTP_200_OK)
         self.assertEqual(response.data['count'], 100)
         self.assertTrue(response.data['next'].endswith(f'?limit={page_size}&offset={page_size}'))
         self.assertIsNone(response.data['previous'])
@@ -147,6 +149,7 @@ class APIPaginationTestCase(APITestCase):
     def test_custom_page_size(self):
         response = self.client.get(f'{self.url}?limit=10', format='json', **self.header)
 
+        self.assertHttpStatus(response, status.HTTP_200_OK)
         self.assertEqual(response.data['count'], 100)
         self.assertTrue(response.data['next'].endswith(f'?limit=10&offset=10'))
         self.assertIsNone(response.data['previous'])
@@ -156,6 +159,7 @@ class APIPaginationTestCase(APITestCase):
     def test_max_page_size(self):
         response = self.client.get(f'{self.url}?limit=0', format='json', **self.header)
 
+        self.assertHttpStatus(response, status.HTTP_200_OK)
         self.assertEqual(response.data['count'], 100)
         self.assertTrue(response.data['next'].endswith(f'?limit=20&offset=20'))
         self.assertIsNone(response.data['previous'])
@@ -165,6 +169,7 @@ class APIPaginationTestCase(APITestCase):
     def test_max_page_size_disabled(self):
         response = self.client.get(f'{self.url}?limit=0', format='json', **self.header)
 
+        self.assertHttpStatus(response, status.HTTP_200_OK)
         self.assertEqual(response.data['count'], 100)
         self.assertIsNone(response.data['next'])
         self.assertIsNone(response.data['previous'])