Browse Source

review feedback

Arthur 13 hours ago
parent
commit
ac99c4f32c
2 changed files with 8 additions and 8 deletions
  1. 2 2
      netbox/core/views.py
  2. 6 6
      netbox/templates/core/system.html

+ 2 - 2
netbox/core/views.py

@@ -700,7 +700,7 @@ class SystemView(UserPassesTestMixin, View):
                 cursor.execute("""
                 cursor.execute("""
                     SELECT table_name, column_name, data_type, is_nullable, column_default
                     SELECT table_name, column_name, data_type, is_nullable, column_default
                     FROM information_schema.columns
                     FROM information_schema.columns
-                    WHERE table_schema = 'public'
+                    WHERE table_schema = current_schema()
                     ORDER BY table_name, ordinal_position
                     ORDER BY table_name, ordinal_position
                 """)
                 """)
                 columns_by_table = {}
                 columns_by_table = {}
@@ -715,7 +715,7 @@ class SystemView(UserPassesTestMixin, View):
                 cursor.execute("""
                 cursor.execute("""
                     SELECT tablename, indexname, indexdef
                     SELECT tablename, indexname, indexdef
                     FROM pg_indexes
                     FROM pg_indexes
-                    WHERE schemaname = 'public'
+                    WHERE schemaname = current_schema()
                     ORDER BY tablename, indexname
                     ORDER BY tablename, indexname
                 """)
                 """)
                 indexes_by_table = {}
                 indexes_by_table = {}

+ 6 - 6
netbox/templates/core/system.html

@@ -217,9 +217,9 @@
                     data-bs-toggle="collapse" data-bs-target="#db-group-body-{{ group.name }}"
                     data-bs-toggle="collapse" data-bs-target="#db-group-body-{{ group.name }}"
                     aria-expanded="false" aria-controls="db-group-body-{{ group.name }}">
                     aria-expanded="false" aria-controls="db-group-body-{{ group.name }}">
               {{ group.name }}
               {{ group.name }}
-              {% if group.is_plugin %}<span class="badge bg-purple text-white ms-1">{% trans "plugin" %}</span>{% endif %}
-              <span class="badge bg-secondary text-white ms-1">{{ group.tables|length }} {% trans "tables" %}</span>
-              <span class="badge bg-secondary text-white ms-1">{{ group.index_count }} {% trans "indexes" %}</span>
+              {% if group.is_plugin %}<span class="badge text-bg-purple ms-1">{% trans "plugin" %}</span>{% endif %}
+              <span class="badge bg-secondary text-bg-gray ms-1">{{ group.tables|length }} {% trans "tables" %}</span>
+              <span class="badge bg-secondary text-bg-gray ms-1">{{ group.index_count }} {% trans "indexes" %}</span>
               <span class="accordion-button-toggle"><i class="mdi mdi-chevron-down"></i></span>
               <span class="accordion-button-toggle"><i class="mdi mdi-chevron-down"></i></span>
             </button>
             </button>
           </h2>
           </h2>
@@ -227,8 +227,8 @@
             <div class="accordion accordion-flush" id="db-group-{{ group.name }}">
             <div class="accordion accordion-flush" id="db-group-{{ group.name }}">
               {% for table in group.tables %}
               {% for table in group.tables %}
                 <div class="accordion-item">
                 <div class="accordion-item">
-                  <h3 class="accordion-header" id="table-heading-{{ group.name }}-{{ forloop.counter }}">
-                    <button class="accordion-button collapsed font-monospace" type="button"
+                  <h5 class="accordion-header" id="table-heading-{{ group.name }}-{{ forloop.counter }}">
+                    <button class="accordion-button border-bottom collapsed font-monospace" type="button"
                             data-bs-toggle="collapse" data-bs-target="#table-collapse-{{ group.name }}-{{ forloop.counter }}"
                             data-bs-toggle="collapse" data-bs-target="#table-collapse-{{ group.name }}-{{ forloop.counter }}"
                             aria-expanded="false" aria-controls="table-collapse-{{ group.name }}-{{ forloop.counter }}">
                             aria-expanded="false" aria-controls="table-collapse-{{ group.name }}-{{ forloop.counter }}">
                       {{ table.name }}
                       {{ table.name }}
@@ -238,7 +238,7 @@
                       {% endif %}
                       {% endif %}
                       <span class="accordion-button-toggle"><i class="mdi mdi-chevron-down"></i></span>
                       <span class="accordion-button-toggle"><i class="mdi mdi-chevron-down"></i></span>
                     </button>
                     </button>
-                  </h3>
+                  </h5>
                   <div id="table-collapse-{{ group.name }}-{{ forloop.counter }}" class="accordion-collapse collapse"
                   <div id="table-collapse-{{ group.name }}-{{ forloop.counter }}" class="accordion-collapse collapse"
                        aria-labelledby="table-heading-{{ group.name }}-{{ forloop.counter }}">
                        aria-labelledby="table-heading-{{ group.name }}-{{ forloop.counter }}">
                     <div class="accordion-body p-0">
                     <div class="accordion-body p-0">