Преглед изворни кода

Address review feedback: remove orphaned attrs, delete empty file, fix quote style

- Remove `data-virtual` row attribute from DeviceInterfaceTable (orphaned
  after interfaceTable.ts was deleted; no remaining JS consumer)
- Delete empty `src/tables/index.ts` (only export was removed with the
  interfaceTable.ts deletion)
- Normalise template string quotes to single throughout
  interface_table_controls.html

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Brian Tiemann пре 1 дан
родитељ
комит
a9480a50fe

+ 0 - 1
netbox/dcim/tables/devices.py

@@ -785,7 +785,6 @@ class DeviceInterfaceTable(InterfaceTable):
         )
         row_attrs = {
             'data-name': lambda record: record.name,
-            'data-virtual': lambda record: "true" if record.is_virtual else "false",
             'data-mark-connected': lambda record: "true" if record.mark_connected else "false",
             'data-cable-status': lambda record: record.cable.status if record.cable else "",
         }

+ 0 - 0
netbox/project-static/src/tables/index.ts


+ 4 - 4
netbox/templates/dcim/device/inc/interface_table_controls.html

@@ -10,27 +10,27 @@
     <li>
       <a class="dropdown-item{% if request.GET.enabled == 'True' %} active{% endif %}"
          href="{{ request.path }}{% if request.GET.enabled == 'True' %}{% querystring enabled=None %}{% else %}{% querystring enabled='True' %}{% endif %}">
-        {% if request.GET.enabled == "True" %}<i class="mdi mdi-check" aria-hidden="true"></i> {% endif %}{% trans "Hide Disabled" %}
+        {% if request.GET.enabled == 'True' %}<i class="mdi mdi-check" aria-hidden="true"></i> {% endif %}{% trans "Hide Disabled" %}
       </a>
     </li>
     <li>
       <a class="dropdown-item{% if request.GET.enabled == 'False' %} active{% endif %}"
          href="{{ request.path }}{% if request.GET.enabled == 'False' %}{% querystring enabled=None %}{% else %}{% querystring enabled='False' %}{% endif %}">
-        {% if request.GET.enabled == "False" %}<i class="mdi mdi-check" aria-hidden="true"></i> {% endif %}{% trans "Hide Enabled" %}
+        {% if request.GET.enabled == 'False' %}<i class="mdi mdi-check" aria-hidden="true"></i> {% endif %}{% trans "Hide Enabled" %}
       </a>
     </li>
     {# kind filter: physical = show only physical (hide virtual/wireless) #}
     <li>
       <a class="dropdown-item{% if request.GET.kind == 'physical' %} active{% endif %}"
          href="{{ request.path }}{% if request.GET.kind == 'physical' %}{% querystring kind=None %}{% else %}{% querystring kind='physical' %}{% endif %}">
-        {% if request.GET.kind == "physical" %}<i class="mdi mdi-check" aria-hidden="true"></i> {% endif %}{% trans "Hide Virtual" %}
+        {% if request.GET.kind == 'physical' %}<i class="mdi mdi-check" aria-hidden="true"></i> {% endif %}{% trans "Hide Virtual" %}
       </a>
     </li>
     {# connected filter: True = show only connected (hide disconnected) #}
     <li>
       <a class="dropdown-item{% if request.GET.connected == 'True' %} active{% endif %}"
          href="{{ request.path }}{% if request.GET.connected == 'True' %}{% querystring connected=None %}{% else %}{% querystring connected='True' %}{% endif %}">
-        {% if request.GET.connected == "True" %}<i class="mdi mdi-check" aria-hidden="true"></i> {% endif %}{% trans "Hide Disconnected" %}
+        {% if request.GET.connected == 'True' %}<i class="mdi mdi-check" aria-hidden="true"></i> {% endif %}{% trans "Hide Disconnected" %}
       </a>
     </li>
   </ul>