فهرست منبع

Closes #3753: Remove rack units endpoint (replaced with elevation)

Jeremy Stretch 6 سال پیش
والد
کامیت
8cb6aed8fa
3فایلهای تغییر یافته به همراه5 افزوده شده و 34 حذف شده
  1. 5 0
      docs/release-notes/version-2.8.md
  2. 0 27
      netbox/dcim/api/views.py
  3. 0 7
      netbox/dcim/tests/test_api.py

+ 5 - 0
docs/release-notes/version-2.8.md

@@ -0,0 +1,5 @@
+# v2.8.0 (FUTURE)
+
+## API Changes
+
+* dcim.Rack: The `/api/dcim/racks/<pk>/units/` endpoint has been replaced with `/api/dcim/racks/<pk>/elevation/`.

+ 0 - 27
netbox/dcim/api/views.py

@@ -176,33 +176,6 @@ class RackViewSet(CustomFieldModelViewSet):
     serializer_class = serializers.RackSerializer
     serializer_class = serializers.RackSerializer
     filterset_class = filters.RackFilterSet
     filterset_class = filters.RackFilterSet
 
 
-    @swagger_auto_schema(deprecated=True)
-    @action(detail=True)
-    def units(self, request, pk=None):
-        """
-        List rack units (by rack)
-        """
-        # TODO: Remove this action detail route in v2.8
-        rack = get_object_or_404(Rack, pk=pk)
-        face = request.GET.get('face', 'front')
-        exclude_pk = request.GET.get('exclude', None)
-        if exclude_pk is not None:
-            try:
-                exclude_pk = int(exclude_pk)
-            except ValueError:
-                exclude_pk = None
-        elevation = rack.get_rack_units(face, exclude_pk)
-
-        # Enable filtering rack units by ID
-        q = request.GET.get('q', None)
-        if q:
-            elevation = [u for u in elevation if q in str(u['id'])]
-
-        page = self.paginate_queryset(elevation)
-        if page is not None:
-            rack_units = serializers.RackUnitSerializer(page, many=True, context={'request': request})
-            return self.get_paginated_response(rack_units.data)
-
     @swagger_auto_schema(
     @swagger_auto_schema(
         responses={200: serializers.RackUnitSerializer(many=True)},
         responses={200: serializers.RackUnitSerializer(many=True)},
         query_serializer=serializers.RackElevationDetailFilterSerializer
         query_serializer=serializers.RackElevationDetailFilterSerializer

+ 0 - 7
netbox/dcim/tests/test_api.py

@@ -589,13 +589,6 @@ class RackTest(APITestCase):
 
 
         self.assertEqual(response.data['name'], self.rack1.name)
         self.assertEqual(response.data['name'], self.rack1.name)
 
 
-    def test_get_rack_units(self):
-
-        url = reverse('dcim-api:rack-units', kwargs={'pk': self.rack1.pk})
-        response = self.client.get(url, **self.header)
-
-        self.assertEqual(response.data['count'], 42)
-
     def test_get_rack_elevation(self):
     def test_get_rack_elevation(self):
 
 
         url = reverse('dcim-api:rack-elevation', kwargs={'pk': self.rack1.pk})
         url = reverse('dcim-api:rack-elevation', kwargs={'pk': self.rack1.pk})