فهرست منبع

Drop the pk tie-breaker from NonUniqueModelMultipleChoiceFilter ordering

Ordering by pk in addition to to_field_name kept PostgreSQL from using an index for rare or unknown values, and nothing depends on which object represents each value. Thanks to @Etibru for catching this.
Jeremy Stretch 4 روز پیش
والد
کامیت
7a9e158ef2
1فایلهای تغییر یافته به همراه1 افزوده شده و 1 حذف شده
  1. 1 1
      netbox/utilities/filters.py

+ 1 - 1
netbox/utilities/filters.py

@@ -189,7 +189,7 @@ class NonUniqueModelMultipleChoiceFilter(django_filters.ModelMultipleChoiceFilte
 
     def get_queryset(self, request):
         to_field_name = self.extra['to_field_name']
-        return super().get_queryset(request).order_by(to_field_name, 'pk').distinct(to_field_name)
+        return super().get_queryset(request).order_by(to_field_name).distinct(to_field_name)
 
 
 class NullableCharFieldFilter(django_filters.CharFilter):