Browse Source

Fixes #4306: Fix toggling of device images for all racks in elevations view

Jeremy Stretch 6 years ago
parent
commit
78a1aad6c0

+ 1 - 0
docs/release-notes/version-2.7.md

@@ -16,6 +16,7 @@
 * [#4295](https://github.com/netbox-community/netbox/issues/4295) - Fix assignment of parent LAG during interface bulk edit
 * [#4300](https://github.com/netbox-community/netbox/issues/4300) - Pass "commit" argument when executing scripts via REST API
 * [#4301](https://github.com/netbox-community/netbox/issues/4301) - Fix exception when deleting device type with components
+* [#4306](https://github.com/netbox-community/netbox/issues/4306) - Fix toggling of device images for all racks in elevations view
 
 ---
 

+ 3 - 6
netbox/project-static/js/rack_elevations.js

@@ -1,14 +1,11 @@
 // Toggle the display of device images within an SVG rack elevation
 $('button.toggle-images').click(function() {
     var selected = $(this).attr('selected');
-    var rack_front = $("#rack_front");
-    var rack_rear = $("#rack_rear");
+    var rack_elevation = $(".rack_elevation");
     if (selected) {
-        $('.device-image', rack_front.contents()).addClass('hidden');
-        $('.device-image', rack_rear.contents()).addClass('hidden');
+        $('.device-image', rack_elevation.contents()).addClass('hidden');
     } else {
-        $('.device-image', rack_front.contents()).removeClass('hidden');
-        $('.device-image', rack_rear.contents()).removeClass('hidden');
+        $('.device-image', rack_elevation.contents()).removeClass('hidden');
     }
     $(this).attr('selected', !selected);
     $(this).children('span').toggleClass('glyphicon-check glyphicon-unchecked');

+ 2 - 2
netbox/templates/dcim/inc/rack_elevation.html

@@ -1,6 +1,6 @@
-<object data="{% url 'dcim-api:rack-elevation' pk=rack.pk %}?face={{face}}&render=svg" id="rack_{{ face }}"></object>
+<object data="{% url 'dcim-api:rack-elevation' pk=rack.pk %}?face={{face}}&render=svg" class="rack_elevation"></object>
 <div class="text-center text-small">
-    <a href="{% url 'dcim-api:rack-elevation' pk=rack.pk %}?face={{face}}&render=svg" id="rack_{{ face }}">
+    <a href="{% url 'dcim-api:rack-elevation' pk=rack.pk %}?face={{face}}&render=svg">
         <i class="fa fa-download"></i> Save SVG
     </a>
 </div>