Browse Source

Fixes #5273: Fix exception when validating a new permission with no models selected

Jeremy Stretch 5 years ago
parent
commit
2f3557c18f
2 changed files with 2 additions and 1 deletions
  1. 1 0
      docs/release-notes/version-2.9.md
  2. 1 1
      netbox/users/admin.py

+ 1 - 0
docs/release-notes/version-2.9.md

@@ -6,6 +6,7 @@
 * [#3672](https://github.com/netbox-community/netbox/issues/3672) - Fix a caching issue causing incorrect related object counts in API responses
 * [#3672](https://github.com/netbox-community/netbox/issues/3672) - Fix a caching issue causing incorrect related object counts in API responses
 * [#5113](https://github.com/netbox-community/netbox/issues/5113) - Fix incorrect caching of permission object assignments to user groups in the admin panel
 * [#5113](https://github.com/netbox-community/netbox/issues/5113) - Fix incorrect caching of permission object assignments to user groups in the admin panel
 * [#5243](https://github.com/netbox-community/netbox/issues/5243) - Redirect user to appropriate tab after modifying device components
 * [#5243](https://github.com/netbox-community/netbox/issues/5243) - Redirect user to appropriate tab after modifying device components
+* [#5273](https://github.com/netbox-community/netbox/issues/5273) - Fix exception when validating a new permission with no models selected
 
 
 ---
 ---
 
 

+ 1 - 1
netbox/users/admin.py

@@ -185,7 +185,7 @@ class ObjectPermissionForm(forms.ModelForm):
 
 
         # Validate the specified model constraints by attempting to execute a query. We don't care whether the query
         # Validate the specified model constraints by attempting to execute a query. We don't care whether the query
         # returns anything; we just want to make sure the specified constraints are valid.
         # returns anything; we just want to make sure the specified constraints are valid.
-        if constraints:
+        if object_types and constraints:
             # Normalize the constraints to a list of dicts
             # Normalize the constraints to a list of dicts
             if type(constraints) is not list:
             if type(constraints) is not list:
                 constraints = [constraints]
                 constraints = [constraints]