Kaynağa Gözat

Raises validation error if file path and root are not unique (#14232)

* raises validation error if file path and root are not unique #14187

* review changes #14187
Abhimanyu Saharan 2 yıl önce
ebeveyn
işleme
290aae592d
1 değiştirilmiş dosya ile 9 ekleme ve 0 silme
  1. 9 0
      netbox/core/models/files.py

+ 9 - 0
netbox/core/models/files.py

@@ -2,6 +2,7 @@ import logging
 import os
 import os
 
 
 from django.conf import settings
 from django.conf import settings
+from django.core.exceptions import ValidationError
 from django.db import models
 from django.db import models
 from django.urls import reverse
 from django.urls import reverse
 from django.utils.translation import gettext as _
 from django.utils.translation import gettext as _
@@ -84,6 +85,14 @@ class ManagedFile(SyncedDataMixin, models.Model):
             self.file_path = os.path.basename(self.data_path)
             self.file_path = os.path.basename(self.data_path)
             self.data_file.write_to_disk(self.full_path, overwrite=True)
             self.data_file.write_to_disk(self.full_path, overwrite=True)
 
 
+    def clean(self):
+        super().clean()
+
+        # Ensure that the file root and path make a unique pair
+        if self._meta.model.objects.filter(file_root=self.file_root, file_path=self.file_path).exclude(pk=self.pk).exists():
+            raise ValidationError(
+                f"A {self._meta.verbose_name.lower()} with this file path already exists ({self.file_root}/{self.file_path}).")
+
     def delete(self, *args, **kwargs):
     def delete(self, *args, **kwargs):
         # Delete file from disk
         # Delete file from disk
         try:
         try: