Просмотр исходного кода

Explicitly use the value of the choice, instead of relying on __str__

Saria Hajjar 6 лет назад
Родитель
Сommit
0a5eecd0e3
2 измененных файлов с 1 добавлено и 4 удалено
  1. 1 1
      netbox/extras/forms.py
  2. 0 3
      netbox/utilities/templatetags/helpers.py

+ 1 - 1
netbox/extras/forms.py

@@ -61,7 +61,7 @@ def get_custom_fields_for_model(content_type, filterable_only=False, bulk_edit=F
 
 
         # Select
         # Select
         elif cf.type == CustomFieldTypeChoices.TYPE_SELECT:
         elif cf.type == CustomFieldTypeChoices.TYPE_SELECT:
-            choices = [(cfc.pk, cfc) for cfc in cf.choices.all()]
+            choices = [(cfc.pk, cfc.value) for cfc in cf.choices.all()]
             if not cf.required or bulk_edit or filterable_only:
             if not cf.required or bulk_edit or filterable_only:
                 choices = [(None, '---------')] + choices
                 choices = [(None, '---------')] + choices
             # Check for a default choice
             # Check for a default choice

+ 0 - 3
netbox/utilities/templatetags/helpers.py

@@ -149,9 +149,6 @@ def example_choices(field, arg=3):
             break
             break
         if not value or not label:
         if not value or not label:
             continue
             continue
-        # Handling for custom fields
-        if hasattr(label, 'value'):
-            label = label.value
         examples.append(label)
         examples.append(label)
     return ', '.join(examples) or 'None'
     return ', '.join(examples) or 'None'