Просмотр исходного кода

Fixes #23702: Tighten label translation test comments

Jason Novinger 11 часов назад
Родитель
Сommit
0338c37b35
2 измененных файлов с 3 добавлено и 4 удалено
  1. 1 2
      netbox/core/tests/test_models.py
  2. 2 2
      netbox/netbox/tests/test_forms.py

+ 1 - 2
netbox/core/tests/test_models.py

@@ -667,12 +667,11 @@ class JobTestCase(TestCase):
 
 class LabelTranslationTestCase(TestCase):
     """
-    Labels defined at import render in the active language (#23702).
+    Model Meta labels are set at import, so eager gettext keeps them in DEFAULT_LANGUAGE (#23702).
     """
 
     @tag('regression')  # Ref: #23702
     def test_model_verbose_name(self):
-        # Set in the model's Meta class body
         with translation.override('nl'):
             self.assertEqual(str(Job._meta.verbose_name), 'taak')
         with translation.override('en'):

+ 2 - 2
netbox/netbox/tests/test_forms.py

@@ -581,7 +581,7 @@ class MetaShadowingTestCase(TestCase):
 
 class FormMixinLabelTranslationTestCase(TestCase):
     """
-    Labels declared on the shared form mixins render in the active language (#23702).
+    Mixin labels are set at import, so eager gettext keeps them in DEFAULT_LANGUAGE (#23702).
     """
 
     def assertLabels(self, form_class, expected):
@@ -614,7 +614,7 @@ class FormMixinLabelTranslationTestCase(TestCase):
                 'owner_id': 'Eigenaar',
                 'filter_id': 'Opgeslagen filter',
             })
-            # Set in __init__, so it renders as a lazy string in the widget attrs
+            # Set in __init__, so it also passes with eager gettext. It pins that a lazy value renders in widget attrs.
             self.assertIn('aria-label="Opgeslagen filter"', str(SiteFilterForm()['filter_id']))
         with translation.override('en'):
             self.assertLabels(SiteFilterForm, {