Fixes #9728: Fix validation when assigning a virtual machine to a device

docs/release-notes/version-3.3.md

@@ -1,6 +1,6 @@
 # NetBox v3.3
 
-## v3.3-beta1 (2022-07-14)
+## v3.3.0 (FUTURE)
 
 ### Breaking Changes
 
@@ -96,6 +96,10 @@ Custom field UI visibility has no impact on API operation.
 * [#9536](https://github.com/netbox-community/netbox/issues/9536) - Track API token usage times
 * [#9582](https://github.com/netbox-community/netbox/issues/9582) - Enable assigning config contexts based on device location
 
+### Bug Fixes
+
+* [#9728](https://github.com/netbox-community/netbox/issues/9728) - Fix validation when assigning a virtual machine to a device
+
 ### Plugins API
 
 * [#9075](https://github.com/netbox-community/netbox/issues/9075) - Introduce `AbortRequest` exception for cleanly interrupting object mutations

netbox/virtualization/forms/models.py

@@ -189,7 +189,8 @@ class VirtualMachineForm(TenancyForm, NetBoxModelForm):
         queryset=Device.objects.all(),
         required=False,
         query_params={
-            'cluster_id': '$cluster'
+            'cluster_id': '$cluster',
+            'site_id': '$site',
         },
         help_text="Optionally pin this VM to a specific host device within the cluster"
     )

netbox/virtualization/models.py

@@ -349,6 +349,10 @@ class VirtualMachine(NetBoxModel, ConfigContextModel):
             })
 
         # Validate assigned cluster device
+        if self.device and not self.cluster:
+            raise ValidationError({
+                'device': f'Must specify a cluster when assigning a host device.'
+            })
         if self.device and self.device not in self.cluster.devices.all():
             raise ValidationError({
                 'device': f'The selected device ({self.device} is not assigned to this cluster ({self.cluster}).'