Merge pull request #287 from tsadpbb/update-error-logging

Update from printing error about packet version to logging

CHANGELOG.md

@@ -1,5 +1,13 @@
 NRPE Changelog
 ==============
+[4.1.2](https://github.com/NagiosEnterprises/nrpe/releases/tag/nrpe-4.1.2) - 2024-XX-XX
+------------------
+**FIXES**
+- Fixed printing of incorrect packet version to just logging the error
+
+
+
+
 [4.1.1](https://github.com/NagiosEnterprises/nrpe/releases/tag/nrpe-4.1.1) - 2024-08-01
 ------------------
 **FIXES**

src/check_nrpe.c

@@ -1431,7 +1431,8 @@ int read_packet(int sock, void *ssl_ptr, v2_packet ** v2_pkt, v3_packet ** v3_pk
 		}
 
 		if (packet_ver != ntohs(packet.packet_version)) {
-			printf("CHECK_NRPE: Invalid packet version received from server.\n");
+			// Log this error instead of printing because we will check for other versions, it's not a total failure
+			logit(LOG_ERR, "Error: Invalid packet version received from server.\n");
 			return -1;
 		}
 
@@ -1522,7 +1523,8 @@ int read_packet(int sock, void *ssl_ptr, v2_packet ** v2_pkt, v3_packet ** v3_pk
 		}
 
 		if (packet_ver != ntohs(packet.packet_version)) {
-			printf("CHECK_NRPE: Invalid packet version received from server.\n");
+			// Log this error instead of printing because we will check for other versions, it's not a total failure
+			logit(LOG_ERR, "Error: Invalid packet version received from server.\n");
 			return -1;
 		}