Explorar o código

check_ssh: change warning to critical for protocal/version errors

It makes more sense to exit critical if a explicit version/protocol is requested. This
would also be more consistent with other plugins. Other string matching plugins like
check_snmp or check_http exit critical if the result does not match.

Signed-off-by: Sven Nierlein <sven@nierlein.de>

Closes #1268
Sven Nierlein %!s(int64=11) %!d(string=hai) anos
pai
achega
e4e167394e
Modificáronse 1 ficheiros con 6 adicións e 6 borrados
  1. 6 6
      plugins/check_ssh.c

+ 6 - 6
plugins/check_ssh.c

@@ -253,18 +253,18 @@ ssh_connect (char *haddr, int hport, char *remote_version, char *remote_protocol
 
 
 		if (remote_version && strcmp(remote_version, ssh_server)) {
 		if (remote_version && strcmp(remote_version, ssh_server)) {
 			printf
 			printf
-				(_("SSH WARNING - %s (protocol %s) version mismatch, expected '%s'\n"),
+				(_("SSH CRITICAL - %s (protocol %s) version mismatch, expected '%s'\n"),
 				 ssh_server, ssh_proto, remote_version);
 				 ssh_server, ssh_proto, remote_version);
 			close(sd);
 			close(sd);
-			exit (STATE_WARNING);
+			exit (STATE_CRITICAL);
 		}
 		}
 
 
 		if (remote_protocol && strcmp(remote_protocol, ssh_proto)) {
 		if (remote_protocol && strcmp(remote_protocol, ssh_proto)) {
 			printf
 			printf
-				(_("SSH WARNING - %s (protocol %s) protocol version mismatch, expected '%s'\n"),
+				(_("SSH CRITICAL - %s (protocol %s) protocol version mismatch, expected '%s'\n"),
 				 ssh_server, ssh_proto, remote_protocol);
 				 ssh_server, ssh_proto, remote_protocol);
 			close(sd);
 			close(sd);
-			exit (STATE_WARNING);
+			exit (STATE_CRITICAL);
 		}
 		}
 
 
 		elapsed_time = (double)deltime(tv) / 1.0e6;
 		elapsed_time = (double)deltime(tv) / 1.0e6;
@@ -307,10 +307,10 @@ print_help (void)
 	printf (UT_CONN_TIMEOUT, DEFAULT_SOCKET_TIMEOUT);
 	printf (UT_CONN_TIMEOUT, DEFAULT_SOCKET_TIMEOUT);
 
 
 	printf (" %s\n", "-r, --remote-version=STRING");
 	printf (" %s\n", "-r, --remote-version=STRING");
-  printf ("    %s\n", _("Warn if string doesn't match expected server version (ex: OpenSSH_3.9p1)"));
+  printf ("    %s\n", _("Alert if string doesn't match expected server version (ex: OpenSSH_3.9p1)"));
 
 
 	printf (" %s\n", "-P, --remote-protocol=STRING");
 	printf (" %s\n", "-P, --remote-protocol=STRING");
-  printf ("    %s\n", _("Warn if protocol doesn't match expected protocol version (ex: 2.0)"));
+  printf ("    %s\n", _("Alert if protocol doesn't match expected protocol version (ex: 2.0)"));
 
 
 	printf (UT_VERBOSE);
 	printf (UT_VERBOSE);