瀏覽代碼

Fix Debian bug #425129: SMB guest mode won't work

| The check_disk_smb plugin purports to support guest users, but it
| doesn't work out, because it doesn't specify the -N command line
| option to smbclient when no password is specified, making smbclient
| stop and ask.

[ http://bugs.debian.org/425129 ]

(Fixed by Josip Rodin, forwarded by Jan Wagner.)
Holger Weiss 16 年之前
父節點
當前提交
e461341003
共有 3 個文件被更改,包括 3 次插入0 次删除
  1. 1 0
      NEWS
  2. 1 0
      THANKS.in
  3. 1 0
      plugins-scripts/check_disk_smb.pl

+ 1 - 0
NEWS

@@ -14,6 +14,7 @@ This file documents the major additions and syntax changes between releases.
 	Fix compilation with GCC 2.96 (Konstantin Khomoutov - #2977105)
 	Fix compilation with GCC 2.96 (Konstantin Khomoutov - #2977105)
 	Fix regression introduced in #1867716 where partially valid performance strings would not be printed anymore
 	Fix regression introduced in #1867716 where partially valid performance strings would not be printed anymore
 	Fix regression in check_http ssl checks on some servers - make SNI an option
 	Fix regression in check_http ssl checks on some servers - make SNI an option
+	Fix guest mode support in check_disk_smb
 	WARNINGS
 	WARNINGS
 	Updated developer documentation to say that performance labels should not have an equals sign or
 	Updated developer documentation to say that performance labels should not have an equals sign or
 	single quote in the label
 	single quote in the label

+ 1 - 0
THANKS.in

@@ -260,3 +260,4 @@ Marcel Kuiper
 Bryan Irvine
 Bryan Irvine
 Jimmy Bergman
 Jimmy Bergman
 Konstantin Khomoutov
 Konstantin Khomoutov
+Josip Rodin

+ 1 - 0
plugins-scripts/check_disk_smb.pl

@@ -78,6 +78,7 @@ my $user = $1 if ($opt_u =~ /^([-_.A-Za-z0-9\\]+)$/);
 
 
 ($opt_p) || ($opt_p = shift) || ($opt_p = "");
 ($opt_p) || ($opt_p = shift) || ($opt_p = "");
 my $pass = $1 if ($opt_p =~ /(.*)/);
 my $pass = $1 if ($opt_p =~ /(.*)/);
+$pass = "-N" if ($opt_p eq "");
 
 
 ($opt_w) || ($opt_w = shift) || ($opt_w = 85);
 ($opt_w) || ($opt_w = shift) || ($opt_w = 85);
 my $warn = $1 if ($opt_w =~ /^([0-9]{1,2}\%?|100\%?|[0-9]+[kMG])$/);
 my $warn = $1 if ($opt_w =~ /^([0-9]{1,2}\%?|100\%?|[0-9]+[kMG])$/);