|
@@ -517,14 +517,13 @@ setup_control_request(ntp_control_message *p, uint8_t opcode, uint16_t seq){
|
|
|
double jitter_request(const char *host, int *status){
|
|
double jitter_request(const char *host, int *status){
|
|
|
int conn=-1, i, npeers=0, num_candidates=0, syncsource_found=0;
|
|
int conn=-1, i, npeers=0, num_candidates=0, syncsource_found=0;
|
|
|
int run=0, min_peer_sel=PEER_INCLUDED, num_selected=0, num_valid=0;
|
|
int run=0, min_peer_sel=PEER_INCLUDED, num_selected=0, num_valid=0;
|
|
|
- int peers_size=0, peer_offset=0, bytes_read=0;
|
|
|
|
|
|
|
+ int peers_size=0, peer_offset=0;
|
|
|
ntp_assoc_status_pair *peers=NULL;
|
|
ntp_assoc_status_pair *peers=NULL;
|
|
|
ntp_control_message req;
|
|
ntp_control_message req;
|
|
|
const char *getvar = "jitter";
|
|
const char *getvar = "jitter";
|
|
|
double rval = 0.0, jitter = -1.0;
|
|
double rval = 0.0, jitter = -1.0;
|
|
|
char *startofvalue=NULL, *nptr=NULL;
|
|
char *startofvalue=NULL, *nptr=NULL;
|
|
|
void *tmp;
|
|
void *tmp;
|
|
|
- int ntp_cm_ints = sizeof(uint16_t) * 5 + sizeof(uint8_t) * 2;
|
|
|
|
|
|
|
|
|
|
/* Long-winded explanation:
|
|
/* Long-winded explanation:
|
|
|
* Getting the jitter requires a number of steps:
|
|
* Getting the jitter requires a number of steps:
|
|
@@ -609,15 +608,7 @@ double jitter_request(const char *host, int *status){
|
|
|
|
|
|
|
|
req.count = htons(MAX_CM_SIZE);
|
|
req.count = htons(MAX_CM_SIZE);
|
|
|
DBG(printf("recieving READVAR response...\n"));
|
|
DBG(printf("recieving READVAR response...\n"));
|
|
|
-
|
|
|
|
|
- /* cov-66524 - req.data not null terminated before usage. Also covers verifying struct was returned correctly*/
|
|
|
|
|
- if ((bytes_read = read(conn, &req, SIZEOF_NTPCM(req))) == -1)
|
|
|
|
|
- die(STATE_UNKNOWN, _("Cannot read from socket: %s"), strerror(errno));
|
|
|
|
|
- if (bytes_read != ntp_cm_ints + req.count)
|
|
|
|
|
- die(STATE_UNKNOWN, _("Invalid NTP response: %d bytes read does not equal %d plus %d data segment"), bytes_read, ntp_cm_ints, req.count);
|
|
|
|
|
- /* else null terminate */
|
|
|
|
|
- req.data[req.count] = '\0';
|
|
|
|
|
-
|
|
|
|
|
|
|
+ read(conn, &req, SIZEOF_NTPCM(req));
|
|
|
DBG(print_ntp_control_message(&req));
|
|
DBG(print_ntp_control_message(&req));
|
|
|
|
|
|
|
|
if(req.op&REM_ERROR && strstr(getvar, "jitter")) {
|
|
if(req.op&REM_ERROR && strstr(getvar, "jitter")) {
|