4
0
Эх сурвалжийг харах

Fix smart attribute comparation

This is a patch for github issue #1040
Jan Wagner 12 жил өмнө
parent
commit
8f5a798b73

+ 3 - 3
plugins/check_ide_smart.c

@@ -369,7 +369,7 @@ values_not_passed (values_t * p, thresholds_t * t)
 	int i;
 	int i;
 	for (i = 0; i < NR_ATTRIBUTES; i++) {
 	for (i = 0; i < NR_ATTRIBUTES; i++) {
 		if (value->id && threshold->id && value->id == threshold->id) {
 		if (value->id && threshold->id && value->id == threshold->id) {
-			if (value->value <= threshold->threshold) {
+			if (value->value < threshold->threshold) {
 				++failed;
 				++failed;
 			}
 			}
 			else {
 			else {
@@ -398,7 +398,7 @@ nagios (values_t * p, thresholds_t * t)
 	int i;
 	int i;
 	for (i = 0; i < NR_ATTRIBUTES; i++) {
 	for (i = 0; i < NR_ATTRIBUTES; i++) {
 		if (value->id && threshold->id && value->id == threshold->id) {
 		if (value->id && threshold->id && value->id == threshold->id) {
-			if (value->value <= threshold->threshold) {
+			if (value->value < threshold->threshold) {
 				++failed;
 				++failed;
 				if (value->status & 1) {
 				if (value->status & 1) {
 					status = PREFAILURE;
 					status = PREFAILURE;
@@ -455,7 +455,7 @@ print_value (value_t * p, threshold_t * t)
 	printf ("Id=%3d, Status=%2d {%s , %s}, Value=%3d, Threshold=%3d, %s\n",
 	printf ("Id=%3d, Status=%2d {%s , %s}, Value=%3d, Threshold=%3d, %s\n",
 					p->id, p->status, p->status & 1 ? "PreFailure" : "Advisory   ",
 					p->id, p->status, p->status & 1 ? "PreFailure" : "Advisory   ",
 					p->status & 2 ? "OnLine " : "OffLine", p->value, t->threshold,
 					p->status & 2 ? "OnLine " : "OffLine", p->value, t->threshold,
-					p->value > t->threshold ? "Passed" : "Failed");
+					p->value >= t->threshold ? "Passed" : "Failed");
 }
 }