Fix _np_state_calculate_location_prefix() so that it doesn't return random stack data when running under suid

NEWS

@@ -1,6 +1,7 @@
 This file documents the major additions and syntax changes between releases.
 
 2.3.4 ????-??-??
+	lib: _np_state_calculate_location_prefix() should return non-void when running under suid (Kris Shannon)
 	pst3.c: Fix build issue on Solaris (#537)
 	check_by_ssh: Fix return code when ssh or the shell itself fails (#618) (Guillaume Rousse)
 	check_disk: Fix false DISK CRITICAL alerts on btrfs systems (#569) (George Hansper)

THANKS.in

@@ -220,6 +220,7 @@ Koen Wilde
 Kondoros Attila
 Konstantin Khomoutov
 Konstantin Shalygin (k0ste)
+Kris Shannon
 Kyle Tucker
 Lance Albertson
 Larry Low

lib/utils_base.c

@@ -450,8 +450,8 @@ char* _np_state_calculate_location_prefix(){
 		env_dir = getenv("NAGIOS_PLUGIN_STATE_DIRECTORY");
 		if(env_dir && env_dir[0] != '\0')
 			return env_dir;
-		return NP_STATE_DIR_PREFIX;
 	}
+	return NP_STATE_DIR_PREFIX;
 }
 
 /*