Przeglądaj źródła

git-notify: Fix "global" notifications

If the number of commits included with a single push exceeds the maximum
specified via "-n", a single notification will be generated instead of
individual e-mails.  For listing the commits within such a notification,
git-rev-list(1)'s "--pretty" option is used.  This yields output which
the git_rev_list() subroutine didn't accept.  That's now fixed.
Holger Weiss 16 lat temu
rodzic
commit
73141bfd92
1 zmienionych plików z 4 dodań i 1 usunięć
  1. 4 1
      tools/git-notify

+ 4 - 1
tools/git-notify

@@ -145,7 +145,10 @@ sub git_rev_list(@)
     while (<REVLIST>)
     while (<REVLIST>)
     {
     {
         chomp;
         chomp;
-        die "Invalid commit: $_" if not /^[0-9a-f]{40}$/;
+        unless (grep {$_ eq "--pretty"} @args)
+        {
+            die "Invalid commit: $_" if not /^[0-9a-f]{40}$/;
+        }
         push @$revlist, $_;
         push @$revlist, $_;
     }
     }
     close REVLIST or die $! ? "Cannot execute rev-list: $!" : "rev-list exited with status: $?";
     close REVLIST or die $! ? "Cannot execute rev-list: $!" : "rev-list exited with status: $?";