Explorar o código

lib/utils_cmd.c - Free file descriptor

Coverity 66502 - File descriptor fd in cmd_file_read is never closed, and thus file is left open after usage throughout runtime. - SR
Spenser Reinhardt %!s(int64=11) %!d(string=hai) anos
pai
achega
606afa8327
Modificáronse 1 ficheiros con 3 adicións e 0 borrados
  1. 3 0
      lib/utils_cmd.c

+ 3 - 0
lib/utils_cmd.c

@@ -390,6 +390,9 @@ cmd_file_read ( char *filename, output *out, int flags)
 	
 	if(out)
 		out->lines = _cmd_fetch_output (fd, out, flags);
+	
+	if (close(fd) == -1)
+		die( STATE_UNKNOWN, _("Error closing %s: %s"), filename, strerror(errno) );
 
 	return 0;
 }