Explorar o código

check_dns.c - conditional assignment

Conditionally set result, only if error_scan() returns a worse state than currently set. This way we will no longer blindly reset result if in an non-OK state.

coverity 103721
Spenser Reinhardt %!s(int64=11) %!d(string=hai) anos
pai
achega
55a263ae6d
Modificáronse 1 ficheiros con 1 adicións e 1 borrados
  1. 1 1
      plugins/check_dns.c

+ 1 - 1
plugins/check_dns.c

@@ -215,7 +215,7 @@ main (int argc, char **argv)
     if (strstr (chld_out.line[i], _("Non-authoritative answer:")))
       non_authoritative = TRUE;
 
-    result = error_scan (chld_out.line[i]);
+    result = (result < error_scan(chld_out.line[i])) ? error_scan(chld_out.line[i]) : result;
     if (result != STATE_OK) {
       msg = strchr (chld_out.line[i], ':');
       if(msg) msg++;