mgmt_api_test.go 130 KB

1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495969798991001011021031041051061071081091101111121131141151161171181191201211221231241251261271281291301311321331341351361371381391401411421431441451461471481491501511521531541551561571581591601611621631641651661671681691701711721731741751761771781791801811821831841851861871881891901911921931941951961971981992002012022032042052062072082092102112122132142152162172182192202212222232242252262272282292302312322332342352362372382392402412422432442452462472482492502512522532542552562572582592602612622632642652662672682692702712722732742752762772782792802812822832842852862872882892902912922932942952962972982993003013023033043053063073083093103113123133143153163173183193203213223233243253263273283293303313323333343353363373383393403413423433443453463473483493503513523533543553563573583593603613623633643653663673683693703713723733743753763773783793803813823833843853863873883893903913923933943953963973983994004014024034044054064074084094104114124134144154164174184194204214224234244254264274284294304314324334344354364374384394404414424434444454464474484494504514524534544554564574584594604614624634644654664674684694704714724734744754764774784794804814824834844854864874884894904914924934944954964974984995005015025035045055065075085095105115125135145155165175185195205215225235245255265275285295305315325335345355365375385395405415425435445455465475485495505515525535545555565575585595605615625635645655665675685695705715725735745755765775785795805815825835845855865875885895905915925935945955965975985996006016026036046056066076086096106116126136146156166176186196206216226236246256266276286296306316326336346356366376386396406416426436446456466476486496506516526536546556566576586596606616626636646656666676686696706716726736746756766776786796806816826836846856866876886896906916926936946956966976986997007017027037047057067077087097107117127137147157167177187197207217227237247257267277287297307317327337347357367377387397407417427437447457467477487497507517527537547557567577587597607617627637647657667677687697707717727737747757767777787797807817827837847857867877887897907917927937947957967977987998008018028038048058068078088098108118128138148158168178188198208218228238248258268278288298308318328338348358368378388398408418428438448458468478488498508518528538548558568578588598608618628638648658668678688698708718728738748758768778788798808818828838848858868878888898908918928938948958968978988999009019029039049059069079089099109119129139149159169179189199209219229239249259269279289299309319329339349359369379389399409419429439449459469479489499509519529539549559569579589599609619629639649659669679689699709719729739749759769779789799809819829839849859869879889899909919929939949959969979989991000100110021003100410051006100710081009101010111012101310141015101610171018101910201021102210231024102510261027102810291030103110321033103410351036103710381039104010411042104310441045104610471048104910501051105210531054105510561057105810591060106110621063106410651066106710681069107010711072107310741075107610771078107910801081108210831084108510861087108810891090109110921093109410951096109710981099110011011102110311041105110611071108110911101111111211131114111511161117111811191120112111221123112411251126112711281129113011311132113311341135113611371138113911401141114211431144114511461147114811491150115111521153115411551156115711581159116011611162116311641165116611671168116911701171117211731174117511761177117811791180118111821183118411851186118711881189119011911192119311941195119611971198119912001201120212031204120512061207120812091210121112121213121412151216121712181219122012211222122312241225122612271228122912301231123212331234123512361237123812391240124112421243124412451246124712481249125012511252125312541255125612571258125912601261126212631264126512661267126812691270127112721273127412751276127712781279128012811282128312841285128612871288128912901291129212931294129512961297129812991300130113021303130413051306130713081309131013111312131313141315131613171318131913201321132213231324132513261327132813291330133113321333133413351336133713381339134013411342134313441345134613471348134913501351135213531354135513561357135813591360136113621363136413651366136713681369137013711372137313741375137613771378137913801381138213831384138513861387138813891390139113921393139413951396139713981399140014011402140314041405140614071408140914101411141214131414141514161417141814191420142114221423142414251426142714281429143014311432143314341435143614371438143914401441144214431444144514461447144814491450145114521453145414551456145714581459146014611462146314641465146614671468146914701471147214731474147514761477147814791480148114821483148414851486148714881489149014911492149314941495149614971498149915001501150215031504150515061507150815091510151115121513151415151516151715181519152015211522152315241525152615271528152915301531153215331534153515361537153815391540154115421543154415451546154715481549155015511552155315541555155615571558155915601561156215631564156515661567156815691570157115721573157415751576157715781579158015811582158315841585158615871588158915901591159215931594159515961597159815991600160116021603160416051606160716081609161016111612161316141615161616171618161916201621162216231624162516261627162816291630163116321633163416351636163716381639164016411642164316441645164616471648164916501651165216531654165516561657165816591660166116621663166416651666166716681669167016711672167316741675167616771678167916801681168216831684168516861687168816891690169116921693169416951696169716981699170017011702170317041705170617071708170917101711171217131714171517161717171817191720172117221723172417251726172717281729173017311732173317341735173617371738173917401741174217431744174517461747174817491750175117521753175417551756175717581759176017611762176317641765176617671768176917701771177217731774177517761777177817791780178117821783178417851786178717881789179017911792179317941795179617971798179918001801180218031804180518061807180818091810181118121813181418151816181718181819182018211822182318241825182618271828182918301831183218331834183518361837183818391840184118421843184418451846184718481849185018511852185318541855185618571858185918601861186218631864186518661867186818691870187118721873187418751876187718781879188018811882188318841885188618871888188918901891189218931894189518961897189818991900190119021903190419051906190719081909191019111912191319141915191619171918191919201921192219231924192519261927192819291930193119321933193419351936193719381939194019411942194319441945194619471948194919501951195219531954195519561957195819591960196119621963196419651966196719681969197019711972197319741975197619771978197919801981198219831984198519861987198819891990199119921993199419951996199719981999200020012002200320042005200620072008200920102011201220132014201520162017201820192020202120222023202420252026202720282029203020312032203320342035203620372038203920402041204220432044204520462047204820492050205120522053205420552056205720582059206020612062206320642065206620672068206920702071207220732074207520762077207820792080208120822083208420852086208720882089209020912092209320942095209620972098209921002101210221032104210521062107210821092110211121122113211421152116211721182119212021212122212321242125212621272128212921302131213221332134213521362137213821392140214121422143214421452146214721482149215021512152215321542155215621572158215921602161216221632164216521662167216821692170217121722173217421752176217721782179218021812182218321842185218621872188218921902191219221932194219521962197219821992200220122022203220422052206220722082209221022112212221322142215221622172218221922202221222222232224222522262227222822292230223122322233223422352236223722382239224022412242224322442245224622472248224922502251225222532254225522562257225822592260226122622263226422652266226722682269227022712272227322742275227622772278227922802281228222832284228522862287228822892290229122922293229422952296229722982299230023012302230323042305230623072308230923102311231223132314231523162317231823192320232123222323232423252326232723282329233023312332233323342335233623372338233923402341234223432344234523462347234823492350235123522353235423552356235723582359236023612362236323642365236623672368236923702371237223732374237523762377237823792380238123822383238423852386238723882389239023912392239323942395239623972398239924002401240224032404240524062407240824092410241124122413241424152416241724182419242024212422242324242425242624272428242924302431243224332434243524362437243824392440244124422443244424452446244724482449245024512452245324542455245624572458245924602461246224632464246524662467246824692470247124722473247424752476247724782479248024812482248324842485248624872488248924902491249224932494249524962497249824992500250125022503250425052506250725082509251025112512251325142515251625172518251925202521252225232524252525262527252825292530253125322533253425352536253725382539254025412542254325442545254625472548254925502551255225532554255525562557255825592560256125622563256425652566256725682569257025712572257325742575257625772578257925802581258225832584258525862587258825892590259125922593259425952596259725982599260026012602260326042605260626072608260926102611261226132614261526162617261826192620262126222623262426252626262726282629263026312632263326342635263626372638263926402641264226432644264526462647264826492650265126522653265426552656265726582659266026612662266326642665266626672668266926702671267226732674267526762677267826792680268126822683268426852686268726882689269026912692269326942695269626972698269927002701270227032704270527062707270827092710271127122713271427152716271727182719272027212722272327242725272627272728272927302731273227332734273527362737273827392740274127422743274427452746274727482749275027512752275327542755275627572758275927602761276227632764276527662767276827692770277127722773277427752776277727782779278027812782278327842785278627872788278927902791279227932794279527962797279827992800280128022803280428052806280728082809281028112812281328142815281628172818281928202821282228232824282528262827282828292830283128322833283428352836283728382839284028412842284328442845284628472848284928502851285228532854285528562857285828592860286128622863286428652866286728682869287028712872287328742875287628772878287928802881288228832884288528862887288828892890289128922893289428952896289728982899290029012902290329042905290629072908290929102911291229132914291529162917291829192920292129222923292429252926292729282929293029312932293329342935293629372938293929402941294229432944294529462947294829492950295129522953295429552956295729582959296029612962296329642965296629672968296929702971297229732974297529762977297829792980298129822983298429852986298729882989299029912992299329942995299629972998299930003001300230033004300530063007300830093010301130123013301430153016301730183019302030213022302330243025302630273028302930303031303230333034303530363037303830393040304130423043304430453046304730483049305030513052305330543055305630573058305930603061306230633064306530663067306830693070307130723073307430753076307730783079308030813082308330843085308630873088308930903091309230933094309530963097309830993100310131023103310431053106310731083109311031113112311331143115311631173118311931203121312231233124312531263127312831293130313131323133313431353136313731383139314031413142314331443145314631473148314931503151315231533154315531563157315831593160316131623163316431653166316731683169317031713172317331743175317631773178317931803181318231833184318531863187318831893190319131923193319431953196319731983199320032013202320332043205320632073208320932103211321232133214321532163217321832193220322132223223322432253226322732283229323032313232323332343235323632373238323932403241324232433244324532463247324832493250325132523253325432553256325732583259326032613262326332643265326632673268326932703271327232733274327532763277327832793280328132823283328432853286328732883289329032913292329332943295329632973298329933003301330233033304330533063307330833093310331133123313331433153316331733183319332033213322332333243325332633273328332933303331333233333334333533363337333833393340334133423343334433453346334733483349335033513352335333543355335633573358335933603361336233633364336533663367336833693370337133723373337433753376337733783379338033813382338333843385338633873388338933903391339233933394339533963397339833993400340134023403340434053406340734083409341034113412341334143415341634173418341934203421342234233424342534263427342834293430343134323433343434353436343734383439344034413442344334443445344634473448344934503451345234533454345534563457345834593460346134623463346434653466346734683469347034713472347334743475347634773478347934803481348234833484348534863487348834893490349134923493349434953496349734983499350035013502350335043505350635073508350935103511351235133514351535163517351835193520352135223523352435253526352735283529353035313532353335343535353635373538353935403541354235433544354535463547354835493550355135523553355435553556355735583559356035613562356335643565356635673568356935703571357235733574357535763577357835793580358135823583358435853586358735883589359035913592359335943595359635973598359936003601360236033604360536063607360836093610361136123613361436153616361736183619362036213622362336243625362636273628362936303631363236333634363536363637363836393640364136423643364436453646364736483649365036513652365336543655365636573658365936603661366236633664366536663667366836693670367136723673367436753676367736783679368036813682368336843685368636873688368936903691369236933694369536963697369836993700370137023703370437053706370737083709371037113712371337143715371637173718371937203721372237233724372537263727372837293730373137323733373437353736373737383739374037413742374337443745374637473748374937503751375237533754375537563757375837593760376137623763376437653766376737683769377037713772377337743775377637773778377937803781378237833784378537863787378837893790379137923793379437953796379737983799380038013802380338043805380638073808380938103811381238133814381538163817381838193820382138223823382438253826382738283829383038313832383338343835383638373838383938403841384238433844384538463847384838493850385138523853385438553856385738583859386038613862386338643865386638673868386938703871387238733874387538763877387838793880388138823883388438853886388738883889389038913892389338943895389638973898389939003901390239033904390539063907390839093910391139123913391439153916391739183919392039213922392339243925392639273928392939303931393239333934393539363937393839393940394139423943394439453946394739483949395039513952395339543955395639573958395939603961396239633964396539663967396839693970397139723973397439753976397739783979398039813982398339843985398639873988398939903991399239933994399539963997399839994000400140024003400440054006400740084009401040114012401340144015401640174018401940204021402240234024402540264027402840294030403140324033403440354036403740384039404040414042404340444045404640474048404940504051405240534054405540564057405840594060406140624063406440654066406740684069407040714072407340744075407640774078407940804081408240834084408540864087408840894090409140924093409440954096409740984099410041014102410341044105410641074108410941104111411241134114411541164117411841194120412141224123412441254126412741284129413041314132413341344135413641374138413941404141414241434144414541464147414841494150415141524153415441554156415741584159416041614162416341644165416641674168416941704171417241734174417541764177417841794180418141824183418441854186418741884189419041914192419341944195419641974198419942004201420242034204420542064207420842094210421142124213421442154216421742184219422042214222422342244225422642274228422942304231423242334234423542364237423842394240424142424243424442454246424742484249425042514252425342544255425642574258425942604261426242634264426542664267426842694270427142724273427442754276427742784279428042814282428342844285428642874288428942904291429242934294429542964297429842994300430143024303430443054306430743084309431043114312431343144315431643174318431943204321432243234324432543264327432843294330433143324333433443354336433743384339434043414342434343444345434643474348434943504351435243534354435543564357435843594360436143624363436443654366436743684369437043714372437343744375437643774378437943804381438243834384438543864387438843894390439143924393439443954396439743984399440044014402440344044405440644074408440944104411441244134414441544164417441844194420442144224423442444254426442744284429443044314432443344344435443644374438443944404441444244434444444544464447444844494450445144524453445444554456445744584459446044614462446344644465446644674468446944704471447244734474447544764477447844794480448144824483448444854486448744884489449044914492449344944495449644974498449945004501450245034504450545064507450845094510451145124513451445154516451745184519452045214522452345244525452645274528452945304531
  1. package http
  2. import (
  3. "encoding/json"
  4. "errors"
  5. "fmt"
  6. "io"
  7. "log/slog"
  8. "math"
  9. "net/http"
  10. "net/http/httptest"
  11. "net/mail"
  12. "net/netip"
  13. "strings"
  14. "testing"
  15. "time"
  16. "github.com/google/uuid"
  17. "github.com/stretchr/testify/assert"
  18. "github.com/stretchr/testify/mock"
  19. "github.com/mk6i/open-oscar-server/config"
  20. "github.com/mk6i/open-oscar-server/state"
  21. "github.com/mk6i/open-oscar-server/wire"
  22. )
  23. func TestSessionHandler_GET(t *testing.T) {
  24. // Fixed time for testing: 2024-01-01 12:00:00 UTC
  25. fixedNow := time.Date(2024, 1, 1, 12, 0, 0, 0, time.UTC)
  26. nowFn := func() time.Time { return fixedNow }
  27. tt := []struct {
  28. name string
  29. want string
  30. statusCode int
  31. createSessions func() []*state.Session
  32. }{
  33. {
  34. name: "without sessions",
  35. want: `{"count":0,"sessions":[]}`,
  36. statusCode: http.StatusOK,
  37. createSessions: func() []*state.Session {
  38. return []*state.Session{}
  39. },
  40. },
  41. {
  42. name: "with sessions",
  43. want: `{"count":3,"sessions":[{"id":"usera","screen_name":"userA","online_seconds":100,"is_away":false,"away_message":"","idle_seconds":0,"is_invisible":false,"is_icq":false,"instance_count":2,"instances":[{"num":1,"idle_seconds":30,"is_away":false,"away_message":"","is_invisible":false,"remote_addr":"1.2.3.4","remote_port":1234},{"num":2,"idle_seconds":0,"is_away":false,"away_message":"","is_invisible":true,"remote_addr":"5.6.7.8","remote_port":5678}]},{"id":"userb","screen_name":"userB","online_seconds":200,"is_away":false,"away_message":"","idle_seconds":0,"is_invisible":true,"is_icq":false,"instance_count":2,"instances":[{"num":1,"idle_seconds":0,"is_away":false,"away_message":"","is_invisible":true,"remote_addr":"9.10.11.12","remote_port":9012},{"num":2,"idle_seconds":0,"is_away":false,"away_message":"","is_invisible":true,"remote_addr":"13.14.15.16","remote_port":1314}]},{"id":"100003","screen_name":"100003","online_seconds":300,"is_away":false,"away_message":"","idle_seconds":0,"is_invisible":false,"is_icq":true,"instance_count":1,"instances":[{"num":1,"idle_seconds":0,"is_away":false,"away_message":"","is_invisible":false,"remote_addr":"1.2.3.4","remote_port":1234}]}]}`,
  44. statusCode: http.StatusOK,
  45. createSessions: func() []*state.Session {
  46. // userA: 2 instances - one idle (30s), one invisible
  47. userA := state.NewSession()
  48. userA.SetIdentScreenName(state.NewIdentScreenName("userA"))
  49. userA.SetDisplayScreenName(state.DisplayScreenName("userA"))
  50. userA.SetUIN(0)
  51. userA.SetNowFn(nowFn)
  52. userA.SetSignonTime(fixedNow.Add(-100 * time.Second))
  53. inst1 := userA.AddInstance()
  54. inst1.SetSignonComplete()
  55. inst1.SetIdle(30 * time.Second)
  56. ip1, _ := netip.ParseAddrPort("1.2.3.4:1234")
  57. inst1.SetRemoteAddr(&ip1)
  58. inst2 := userA.AddInstance()
  59. inst2.SetSignonComplete()
  60. inst2.SetUserStatusBitmask(wire.OServiceUserStatusInvisible)
  61. ip2, _ := netip.ParseAddrPort("5.6.7.8:5678")
  62. inst2.SetRemoteAddr(&ip2)
  63. // userB: 2 instances - both invisible
  64. userB := state.NewSession()
  65. userB.SetIdentScreenName(state.NewIdentScreenName("userB"))
  66. userB.SetDisplayScreenName(state.DisplayScreenName("userB"))
  67. userB.SetUIN(0)
  68. userB.SetNowFn(nowFn)
  69. userB.SetSignonTime(fixedNow.Add(-200 * time.Second))
  70. inst3 := userB.AddInstance()
  71. inst3.SetSignonComplete()
  72. inst3.SetUserStatusBitmask(wire.OServiceUserStatusInvisible)
  73. ip3, _ := netip.ParseAddrPort("9.10.11.12:9012")
  74. inst3.SetRemoteAddr(&ip3)
  75. inst4 := userB.AddInstance()
  76. inst4.SetSignonComplete()
  77. inst4.SetUserStatusBitmask(wire.OServiceUserStatusInvisible)
  78. ip4, _ := netip.ParseAddrPort("13.14.15.16:1314")
  79. inst4.SetRemoteAddr(&ip4)
  80. // 100003: 1 instance - normal
  81. icqUser := state.NewSession()
  82. icqUser.SetIdentScreenName(state.NewIdentScreenName("100003"))
  83. icqUser.SetDisplayScreenName(state.DisplayScreenName("100003"))
  84. icqUser.SetUIN(100003)
  85. icqUser.SetNowFn(nowFn)
  86. icqUser.SetSignonTime(fixedNow.Add(-300 * time.Second))
  87. inst5 := icqUser.AddInstance()
  88. inst5.SetSignonComplete()
  89. ip5, _ := netip.ParseAddrPort("1.2.3.4:1234")
  90. inst5.SetRemoteAddr(&ip5)
  91. return []*state.Session{userA, userB, icqUser}
  92. },
  93. },
  94. {
  95. name: "with away sessions",
  96. want: `{"count":2,"sessions":[{"id":"usera","screen_name":"userA","online_seconds":100,"is_away":false,"away_message":"","idle_seconds":0,"is_invisible":false,"is_icq":false,"instance_count":2,"instances":[{"num":1,"idle_seconds":0,"is_away":true,"away_message":"Away message 1","is_invisible":false,"remote_addr":"1.2.3.4","remote_port":1234},{"num":2,"idle_seconds":0,"is_away":false,"away_message":"","is_invisible":false,"remote_addr":"5.6.7.8","remote_port":5678}]},{"id":"userb","screen_name":"userB","online_seconds":200,"is_away":true,"away_message":"Away message 2","idle_seconds":0,"is_invisible":false,"is_icq":false,"instance_count":2,"instances":[{"num":1,"idle_seconds":0,"is_away":true,"away_message":"Away message 2","is_invisible":false,"remote_addr":"9.10.11.12","remote_port":9012},{"num":2,"idle_seconds":0,"is_away":true,"away_message":"Away message 2","is_invisible":false,"remote_addr":"13.14.15.16","remote_port":1314}]}]}`,
  97. statusCode: http.StatusOK,
  98. createSessions: func() []*state.Session {
  99. // userA: 2 instances - one away, one not away (away_message should be "")
  100. userA := state.NewSession()
  101. userA.SetIdentScreenName(state.NewIdentScreenName("userA"))
  102. userA.SetDisplayScreenName(state.DisplayScreenName("userA"))
  103. userA.SetUIN(0)
  104. userA.SetNowFn(nowFn)
  105. userA.SetSignonTime(fixedNow.Add(-100 * time.Second))
  106. inst1 := userA.AddInstance()
  107. inst1.SetSignonComplete()
  108. inst1.SetUserStatusBitmask(wire.OServiceUserStatusAway)
  109. inst1.SetAwayMessage("Away message 1")
  110. ip1, _ := netip.ParseAddrPort("1.2.3.4:1234")
  111. inst1.SetRemoteAddr(&ip1)
  112. inst2 := userA.AddInstance()
  113. inst2.SetSignonComplete()
  114. ip2, _ := netip.ParseAddrPort("5.6.7.8:5678")
  115. inst2.SetRemoteAddr(&ip2)
  116. // userB: 2 instances - both away (away_message should be populated)
  117. userB := state.NewSession()
  118. userB.SetIdentScreenName(state.NewIdentScreenName("userB"))
  119. userB.SetDisplayScreenName(state.DisplayScreenName("userB"))
  120. userB.SetUIN(0)
  121. userB.SetNowFn(nowFn)
  122. userB.SetSignonTime(fixedNow.Add(-200 * time.Second))
  123. inst3 := userB.AddInstance()
  124. inst3.SetSignonComplete()
  125. inst3.SetUserStatusBitmask(wire.OServiceUserStatusAway)
  126. inst3.SetAwayMessage("Away message 2")
  127. ip3, _ := netip.ParseAddrPort("9.10.11.12:9012")
  128. inst3.SetRemoteAddr(&ip3)
  129. inst4 := userB.AddInstance()
  130. inst4.SetSignonComplete()
  131. inst4.SetUserStatusBitmask(wire.OServiceUserStatusAway)
  132. inst4.SetAwayMessage("Away message 2")
  133. ip4, _ := netip.ParseAddrPort("13.14.15.16:1314")
  134. inst4.SetRemoteAddr(&ip4)
  135. return []*state.Session{userA, userB}
  136. },
  137. },
  138. }
  139. for _, tc := range tt {
  140. t.Run(tc.name, func(t *testing.T) {
  141. request := httptest.NewRequest(http.MethodGet, "/session", nil)
  142. responseRecorder := httptest.NewRecorder()
  143. sessionRetriever := newMockSessionRetriever(t)
  144. sessions := tc.createSessions()
  145. sessionRetriever.EXPECT().
  146. AllSessions().
  147. Return(sessions)
  148. getSessionHandler(responseRecorder, request, sessionRetriever, nowFn)
  149. if responseRecorder.Code != tc.statusCode {
  150. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  151. }
  152. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  153. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  154. }
  155. })
  156. }
  157. }
  158. func TestSessionHandlerScreenname_GET(t *testing.T) {
  159. // Fixed time for testing: 2024-01-01 12:00:00 UTC
  160. fixedNow := time.Date(2024, 1, 1, 12, 0, 0, 0, time.UTC)
  161. nowFn := func() time.Time { return fixedNow }
  162. tt := []struct {
  163. name string
  164. requestScreenName state.IdentScreenName
  165. want string
  166. statusCode int
  167. createSession func() *state.Session
  168. }{
  169. {
  170. name: "no session for screenname",
  171. requestScreenName: state.NewIdentScreenName("userA"),
  172. want: `session not found`,
  173. statusCode: http.StatusNotFound,
  174. createSession: func() *state.Session {
  175. return nil
  176. },
  177. },
  178. {
  179. name: "active session found for screenname",
  180. requestScreenName: state.NewIdentScreenName("userA"),
  181. want: `{"count":1,"sessions":[{"id":"usera","screen_name":"userA","online_seconds":150,"is_away":false,"away_message":"","idle_seconds":0,"is_invisible":false,"is_icq":false,"instance_count":1,"instances":[{"num":1,"idle_seconds":0,"is_away":false,"away_message":"","is_invisible":false,"remote_addr":"1.2.3.4","remote_port":1234}]}]}`,
  182. statusCode: http.StatusOK,
  183. createSession: func() *state.Session {
  184. sess := state.NewSession()
  185. sess.SetIdentScreenName(state.NewIdentScreenName("userA"))
  186. sess.SetDisplayScreenName(state.DisplayScreenName("userA"))
  187. sess.SetUIN(0)
  188. sess.SetNowFn(nowFn)
  189. sess.SetSignonTime(fixedNow.Add(-150 * time.Second))
  190. instance := sess.AddInstance()
  191. instance.SetSignonComplete()
  192. ip, _ := netip.ParseAddrPort("1.2.3.4:1234")
  193. instance.SetRemoteAddr(&ip)
  194. return sess
  195. },
  196. },
  197. }
  198. for _, tc := range tt {
  199. t.Run(tc.name, func(t *testing.T) {
  200. request := httptest.NewRequest(http.MethodGet, "/session/"+tc.requestScreenName.String(), nil)
  201. request.SetPathValue("screenname", tc.requestScreenName.String())
  202. responseRecorder := httptest.NewRecorder()
  203. sessionRetriever := newMockSessionRetriever(t)
  204. session := tc.createSession()
  205. sessionRetriever.EXPECT().
  206. RetrieveSession(tc.requestScreenName).
  207. Return(session)
  208. getSessionHandler(responseRecorder, request, sessionRetriever, nowFn)
  209. if responseRecorder.Code != tc.statusCode {
  210. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  211. }
  212. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  213. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  214. }
  215. })
  216. }
  217. }
  218. func TestSessionHandlerScreenname_DELETE(t *testing.T) {
  219. fnNewSess := func(screenName string) *state.Session {
  220. sess := state.NewSession()
  221. sess.SetIdentScreenName(state.NewIdentScreenName(screenName))
  222. sess.SetDisplayScreenName(state.DisplayScreenName(screenName))
  223. instance := sess.AddInstance()
  224. instance.SetSignonComplete()
  225. ip, _ := netip.ParseAddrPort("1.2.3.4:1234")
  226. instance.SetRemoteAddr(&ip)
  227. return sess
  228. }
  229. tt := []struct {
  230. name string
  231. session *state.SessionInstance
  232. requestScreenName state.IdentScreenName
  233. statusCode int
  234. mockParams mockParams
  235. }{
  236. {
  237. name: "delete an active session",
  238. requestScreenName: state.NewIdentScreenName("userA"),
  239. statusCode: http.StatusNoContent,
  240. mockParams: mockParams{
  241. sessionRetrieverParams: sessionRetrieverParams{
  242. retrieveSessionByNameParams: retrieveSessionByNameParams{
  243. {
  244. screenName: state.NewIdentScreenName("userA"),
  245. result: fnNewSess("userA"),
  246. },
  247. },
  248. },
  249. },
  250. },
  251. {
  252. name: "delete a non-existent session",
  253. requestScreenName: state.NewIdentScreenName("userA"),
  254. statusCode: http.StatusNotFound,
  255. mockParams: mockParams{
  256. sessionRetrieverParams: sessionRetrieverParams{
  257. retrieveSessionByNameParams: retrieveSessionByNameParams{
  258. {
  259. screenName: state.NewIdentScreenName("userA"),
  260. result: nil,
  261. },
  262. },
  263. },
  264. },
  265. },
  266. }
  267. for _, tc := range tt {
  268. t.Run(tc.name, func(t *testing.T) {
  269. request := httptest.NewRequest(http.MethodDelete, "/session/"+tc.requestScreenName.String(), nil)
  270. request.SetPathValue("screenname", tc.requestScreenName.String())
  271. responseRecorder := httptest.NewRecorder()
  272. sessionRetriever := newMockSessionRetriever(t)
  273. for _, params := range tc.mockParams.sessionRetrieverParams.retrieveSessionByNameParams {
  274. sessionRetriever.EXPECT().
  275. RetrieveSession(params.screenName).
  276. Return(params.result)
  277. }
  278. deleteSessionHandler(responseRecorder, request, sessionRetriever)
  279. if responseRecorder.Code != tc.statusCode {
  280. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  281. }
  282. })
  283. }
  284. }
  285. func TestUserAccountHandler_GET(t *testing.T) {
  286. tt := []struct {
  287. name string
  288. requestScreenName state.IdentScreenName
  289. want string
  290. statusCode int
  291. mockParams mockParams
  292. }{
  293. {
  294. name: "invalid account",
  295. requestScreenName: state.NewIdentScreenName("userA"),
  296. want: `user not found`,
  297. statusCode: http.StatusNotFound,
  298. mockParams: mockParams{
  299. userManagerParams: userManagerParams{
  300. getUserParams: getUserParams{
  301. {
  302. screenName: state.NewIdentScreenName("userA"),
  303. result: nil,
  304. },
  305. },
  306. },
  307. },
  308. },
  309. {
  310. name: "valid aim account",
  311. requestScreenName: state.NewIdentScreenName("userA"),
  312. want: `{"id":"usera","screen_name":"userA","profile":"My Profile Text","email_address":"\u003cuserA@aol.com\u003e","reg_status":2,"confirmed":true,"is_icq":false,"suspended_status":"","is_bot":false}`,
  313. statusCode: http.StatusOK,
  314. mockParams: mockParams{
  315. userManagerParams: userManagerParams{
  316. getUserParams: getUserParams{
  317. {
  318. screenName: state.NewIdentScreenName("userA"),
  319. result: &state.User{
  320. DisplayScreenName: "userA",
  321. IdentScreenName: state.NewIdentScreenName("userA"),
  322. SuspendedStatus: 0x0,
  323. },
  324. },
  325. },
  326. },
  327. accountManagerParams: accountManagerParams{
  328. EmailAddressParams: EmailAddressParams{
  329. {
  330. screenName: state.NewIdentScreenName("userA"),
  331. result: &mail.Address{
  332. Address: "userA@aol.com",
  333. },
  334. },
  335. },
  336. RegStatusParams: RegStatusParams{
  337. {
  338. screenName: state.NewIdentScreenName("userA"),
  339. result: uint16(0x02),
  340. },
  341. },
  342. ConfirmStatusParams: ConfirmStatusParams{
  343. {
  344. screenName: state.NewIdentScreenName("userA"),
  345. result: true,
  346. },
  347. },
  348. },
  349. profileRetrieverParams: profileRetrieverParams{
  350. retrieveProfileParams: retrieveProfileParams{
  351. {
  352. screenName: state.NewIdentScreenName("userA"),
  353. result: state.UserProfile{ProfileText: "My Profile Text"},
  354. },
  355. },
  356. },
  357. },
  358. },
  359. {
  360. name: "valid aim bot account",
  361. requestScreenName: state.NewIdentScreenName("userA"),
  362. want: `{"id":"usera","screen_name":"userA","profile":"My Profile Text","email_address":"\u003cuserA@aol.com\u003e","reg_status":2,"confirmed":true,"is_icq":false,"suspended_status":"","is_bot":true}`,
  363. statusCode: http.StatusOK,
  364. mockParams: mockParams{
  365. userManagerParams: userManagerParams{
  366. getUserParams: getUserParams{
  367. {
  368. screenName: state.NewIdentScreenName("userA"),
  369. result: &state.User{
  370. DisplayScreenName: "userA",
  371. IdentScreenName: state.NewIdentScreenName("userA"),
  372. SuspendedStatus: 0x0,
  373. IsBot: true,
  374. },
  375. },
  376. },
  377. },
  378. accountManagerParams: accountManagerParams{
  379. EmailAddressParams: EmailAddressParams{
  380. {
  381. screenName: state.NewIdentScreenName("userA"),
  382. result: &mail.Address{
  383. Address: "userA@aol.com",
  384. },
  385. },
  386. },
  387. RegStatusParams: RegStatusParams{
  388. {
  389. screenName: state.NewIdentScreenName("userA"),
  390. result: uint16(0x02),
  391. },
  392. },
  393. ConfirmStatusParams: ConfirmStatusParams{
  394. {
  395. screenName: state.NewIdentScreenName("userA"),
  396. result: true,
  397. },
  398. },
  399. },
  400. profileRetrieverParams: profileRetrieverParams{
  401. retrieveProfileParams: retrieveProfileParams{
  402. {
  403. screenName: state.NewIdentScreenName("userA"),
  404. result: state.UserProfile{ProfileText: "My Profile Text"},
  405. },
  406. },
  407. },
  408. },
  409. },
  410. {
  411. name: "suspended aim account",
  412. requestScreenName: state.NewIdentScreenName("userB"),
  413. want: `{"id":"userb","screen_name":"userB","profile":"My Profile Text","email_address":"\u003cuserB@aol.com\u003e","reg_status":2,"confirmed":true,"is_icq":false,"suspended_status":"suspended","is_bot":false}`,
  414. statusCode: http.StatusOK,
  415. mockParams: mockParams{
  416. userManagerParams: userManagerParams{
  417. getUserParams: getUserParams{
  418. {
  419. screenName: state.NewIdentScreenName("userB"),
  420. result: &state.User{
  421. DisplayScreenName: "userB",
  422. IdentScreenName: state.NewIdentScreenName("userB"),
  423. SuspendedStatus: wire.LoginErrSuspendedAccount,
  424. },
  425. },
  426. },
  427. },
  428. accountManagerParams: accountManagerParams{
  429. EmailAddressParams: EmailAddressParams{
  430. {
  431. screenName: state.NewIdentScreenName("userB"),
  432. result: &mail.Address{
  433. Address: "userB@aol.com",
  434. },
  435. },
  436. },
  437. RegStatusParams: RegStatusParams{
  438. {
  439. screenName: state.NewIdentScreenName("userB"),
  440. result: uint16(0x02),
  441. },
  442. },
  443. ConfirmStatusParams: ConfirmStatusParams{
  444. {
  445. screenName: state.NewIdentScreenName("userB"),
  446. result: true,
  447. },
  448. },
  449. },
  450. profileRetrieverParams: profileRetrieverParams{
  451. retrieveProfileParams: retrieveProfileParams{
  452. {
  453. screenName: state.NewIdentScreenName("userB"),
  454. result: state.UserProfile{ProfileText: "My Profile Text"},
  455. },
  456. },
  457. },
  458. },
  459. },
  460. }
  461. for _, tc := range tt {
  462. t.Run(tc.name, func(t *testing.T) {
  463. request := httptest.NewRequest(http.MethodGet, "/user/"+tc.requestScreenName.String()+"/account", nil)
  464. request.SetPathValue("screenname", tc.requestScreenName.String())
  465. responseRecorder := httptest.NewRecorder()
  466. userManager := newMockUserManager(t)
  467. for _, params := range tc.mockParams.userManagerParams.getUserParams {
  468. userManager.EXPECT().
  469. User(matchContext(), params.screenName).
  470. Return(params.result, params.err)
  471. }
  472. accountManager := newMockAccountManager(t)
  473. for _, params := range tc.mockParams.accountManagerParams.EmailAddressParams {
  474. accountManager.EXPECT().
  475. EmailAddress(matchContext(), params.screenName).
  476. Return(params.result, params.err)
  477. }
  478. for _, params := range tc.mockParams.accountManagerParams.RegStatusParams {
  479. accountManager.EXPECT().
  480. RegStatus(matchContext(), params.screenName).
  481. Return(params.result, params.err)
  482. }
  483. for _, params := range tc.mockParams.accountManagerParams.ConfirmStatusParams {
  484. accountManager.EXPECT().
  485. ConfirmStatus(matchContext(), params.screenName).
  486. Return(params.result, params.err)
  487. }
  488. profileRetriever := newMockProfileRetriever(t)
  489. for _, params := range tc.mockParams.profileRetrieverParams.retrieveProfileParams {
  490. profileRetriever.EXPECT().
  491. Profile(matchContext(), params.screenName).
  492. Return(params.result, params.err)
  493. }
  494. getUserAccountHandler(responseRecorder, request, userManager, accountManager, profileRetriever, slog.Default())
  495. if responseRecorder.Code != tc.statusCode {
  496. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  497. }
  498. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  499. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  500. }
  501. })
  502. }
  503. }
  504. func TestUserAccountHandler_PATCH(t *testing.T) {
  505. tt := []struct {
  506. name string
  507. requestScreenName state.IdentScreenName
  508. want string
  509. body string
  510. statusCode int
  511. mockParams mockParams
  512. }{
  513. {
  514. name: "suspending a non-existent account",
  515. requestScreenName: state.NewIdentScreenName("userA"),
  516. body: `{"suspended_status":"suspended"}`,
  517. want: `user not found`,
  518. statusCode: http.StatusNotFound,
  519. mockParams: mockParams{
  520. userManagerParams: userManagerParams{
  521. getUserParams: getUserParams{
  522. {
  523. screenName: state.NewIdentScreenName("userA"),
  524. result: nil,
  525. },
  526. },
  527. },
  528. },
  529. },
  530. {
  531. name: "patching with invalid suspended_status value",
  532. requestScreenName: state.NewIdentScreenName("userA"),
  533. body: `{"suspended_status":"thisisinvalid"}`,
  534. want: `{"message":"suspended_status must be empty str or one of deleted,expired,suspended,suspended_age"}`,
  535. statusCode: http.StatusBadRequest,
  536. mockParams: mockParams{
  537. userManagerParams: userManagerParams{
  538. getUserParams: getUserParams{
  539. {
  540. screenName: state.NewIdentScreenName("userA"),
  541. result: &state.User{},
  542. },
  543. },
  544. },
  545. },
  546. },
  547. {
  548. name: "suspending an active aim account",
  549. requestScreenName: state.NewIdentScreenName("userA"),
  550. statusCode: http.StatusNoContent,
  551. body: `{"suspended_status":"suspended"}`,
  552. mockParams: mockParams{
  553. userManagerParams: userManagerParams{
  554. getUserParams: getUserParams{
  555. {
  556. screenName: state.NewIdentScreenName("userA"),
  557. result: &state.User{
  558. DisplayScreenName: "userA",
  559. IdentScreenName: state.NewIdentScreenName("userA"),
  560. SuspendedStatus: 0x0,
  561. },
  562. },
  563. },
  564. },
  565. accountManagerParams: accountManagerParams{
  566. updateSuspendedStatusParams: updateSuspendedStatusParams{
  567. {
  568. suspendedStatus: wire.LoginErrSuspendedAccount,
  569. screenName: state.NewIdentScreenName("userA"),
  570. err: nil,
  571. },
  572. },
  573. },
  574. },
  575. },
  576. {
  577. name: "unsuspending a suspended aim account",
  578. requestScreenName: state.NewIdentScreenName("userA"),
  579. statusCode: http.StatusNoContent,
  580. body: `{"suspended_status":""}`,
  581. mockParams: mockParams{
  582. userManagerParams: userManagerParams{
  583. getUserParams: getUserParams{
  584. {
  585. screenName: state.NewIdentScreenName("userA"),
  586. result: &state.User{
  587. DisplayScreenName: "userA",
  588. IdentScreenName: state.NewIdentScreenName("userA"),
  589. SuspendedStatus: wire.LoginErrSuspendedAccount,
  590. },
  591. },
  592. },
  593. },
  594. accountManagerParams: accountManagerParams{
  595. updateSuspendedStatusParams: updateSuspendedStatusParams{
  596. {
  597. suspendedStatus: 0x0,
  598. screenName: state.NewIdentScreenName("userA"),
  599. err: nil,
  600. },
  601. },
  602. },
  603. },
  604. },
  605. {
  606. name: "suspending an already suspended aim account",
  607. requestScreenName: state.NewIdentScreenName("userA"),
  608. statusCode: http.StatusNotModified,
  609. body: `{"suspended_status":"suspended"}`,
  610. mockParams: mockParams{
  611. userManagerParams: userManagerParams{
  612. getUserParams: getUserParams{
  613. {
  614. screenName: state.NewIdentScreenName("userA"),
  615. result: &state.User{
  616. DisplayScreenName: "userA",
  617. IdentScreenName: state.NewIdentScreenName("userA"),
  618. SuspendedStatus: wire.LoginErrSuspendedAccount,
  619. },
  620. },
  621. },
  622. },
  623. },
  624. },
  625. {
  626. name: "setting bot flag (before: false, after: true)",
  627. requestScreenName: state.NewIdentScreenName("userA"),
  628. statusCode: http.StatusNoContent,
  629. body: `{"is_bot":true}`,
  630. mockParams: mockParams{
  631. userManagerParams: userManagerParams{
  632. getUserParams: getUserParams{
  633. {
  634. screenName: state.NewIdentScreenName("userA"),
  635. result: &state.User{
  636. DisplayScreenName: "userA",
  637. IdentScreenName: state.NewIdentScreenName("userA"),
  638. SuspendedStatus: 0x0,
  639. IsBot: false,
  640. },
  641. },
  642. },
  643. },
  644. accountManagerParams: accountManagerParams{
  645. setBotStatusParams: setBotStatusParams{
  646. {
  647. isBot: true,
  648. screenName: state.NewIdentScreenName("userA"),
  649. err: nil,
  650. },
  651. },
  652. },
  653. },
  654. },
  655. {
  656. name: "setting bot flag (before: true, after: false)",
  657. requestScreenName: state.NewIdentScreenName("userA"),
  658. statusCode: http.StatusNoContent,
  659. body: `{"is_bot":false}`,
  660. mockParams: mockParams{
  661. userManagerParams: userManagerParams{
  662. getUserParams: getUserParams{
  663. {
  664. screenName: state.NewIdentScreenName("userA"),
  665. result: &state.User{
  666. DisplayScreenName: "userA",
  667. IdentScreenName: state.NewIdentScreenName("userA"),
  668. SuspendedStatus: 0x0,
  669. IsBot: true,
  670. },
  671. },
  672. },
  673. },
  674. accountManagerParams: accountManagerParams{
  675. setBotStatusParams: setBotStatusParams{
  676. {
  677. isBot: false,
  678. screenName: state.NewIdentScreenName("userA"),
  679. err: nil,
  680. },
  681. },
  682. },
  683. },
  684. },
  685. {
  686. name: "setting bot flag (before: true, after: true)",
  687. requestScreenName: state.NewIdentScreenName("userA"),
  688. statusCode: http.StatusNotModified,
  689. body: `{"is_bot":true}`,
  690. mockParams: mockParams{
  691. userManagerParams: userManagerParams{
  692. getUserParams: getUserParams{
  693. {
  694. screenName: state.NewIdentScreenName("userA"),
  695. result: &state.User{
  696. DisplayScreenName: "userA",
  697. IdentScreenName: state.NewIdentScreenName("userA"),
  698. SuspendedStatus: 0x0,
  699. IsBot: true,
  700. },
  701. },
  702. },
  703. },
  704. },
  705. },
  706. }
  707. for _, tc := range tt {
  708. t.Run(tc.name, func(t *testing.T) {
  709. request := httptest.NewRequest(http.MethodPatch, "/user/"+tc.requestScreenName.String()+"/account", strings.NewReader(tc.body))
  710. request.SetPathValue("screenname", tc.requestScreenName.String())
  711. responseRecorder := httptest.NewRecorder()
  712. userManager := newMockUserManager(t)
  713. for _, params := range tc.mockParams.userManagerParams.getUserParams {
  714. userManager.EXPECT().
  715. User(matchContext(), params.screenName).
  716. Return(params.result, params.err)
  717. }
  718. accountManager := newMockAccountManager(t)
  719. for _, params := range tc.mockParams.accountManagerParams.updateSuspendedStatusParams {
  720. accountManager.EXPECT().
  721. UpdateSuspendedStatus(matchContext(), params.suspendedStatus, params.screenName).
  722. Return(params.err)
  723. }
  724. for _, params := range tc.mockParams.accountManagerParams.setBotStatusParams {
  725. accountManager.EXPECT().
  726. SetBotStatus(matchContext(), params.isBot, params.screenName).
  727. Return(params.err)
  728. }
  729. patchUserAccountHandler(responseRecorder, request, userManager, accountManager, slog.Default())
  730. if responseRecorder.Code != tc.statusCode {
  731. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  732. }
  733. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  734. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  735. }
  736. })
  737. }
  738. }
  739. func TestUserBuddyIconHandler_GET(t *testing.T) {
  740. sampleGIF := []byte{
  741. 0x47, 0x49, 0x46, 0x38, 0x39, 0x61, 0x32, 0x00, 0x32, 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
  742. 0x00, 0x00, 0x00, 0x21, 0xf9, 0x04, 0x01, 0x00, 0x00, 0x00, 0x00, 0x2c, 0x00, 0x00, 0x00, 0x00,
  743. 0x32, 0x00, 0x32, 0x00, 0x00, 0x02, 0x02, 0x44, 0x01, 0x00, 0x3b}
  744. sampleJPG := []byte{0xFF, 0xD8, 0xFF, 0x43, 0x13, 0x37}
  745. tt := []struct {
  746. name string
  747. requestScreenName state.IdentScreenName
  748. want string
  749. statusCode int
  750. contentType string
  751. mockParams mockParams
  752. }{
  753. {
  754. name: "invalid account",
  755. requestScreenName: state.NewIdentScreenName("userA"),
  756. want: `user not found`,
  757. statusCode: http.StatusNotFound,
  758. contentType: "text/plain; charset=utf-8",
  759. mockParams: mockParams{
  760. userManagerParams: userManagerParams{
  761. getUserParams: getUserParams{
  762. {
  763. screenName: state.NewIdentScreenName("userA"),
  764. result: nil,
  765. },
  766. },
  767. },
  768. },
  769. },
  770. {
  771. name: "account with gif buddy icon",
  772. requestScreenName: state.NewIdentScreenName("userA"),
  773. want: string(sampleGIF),
  774. statusCode: http.StatusOK,
  775. contentType: "image/gif",
  776. mockParams: mockParams{
  777. userManagerParams: userManagerParams{
  778. getUserParams: getUserParams{
  779. {
  780. screenName: state.NewIdentScreenName("userA"),
  781. result: &state.User{
  782. DisplayScreenName: "userA",
  783. IdentScreenName: state.NewIdentScreenName("userA"),
  784. },
  785. },
  786. },
  787. },
  788. feedBagRetrieverParams: feedBagRetrieverParams{
  789. buddyIconMetadataParams: buddyIconMetadataParams{
  790. {
  791. screenName: state.NewIdentScreenName("userA"),
  792. result: &wire.BARTID{
  793. Type: wire.BARTTypesBuddyIcon,
  794. BARTInfo: wire.BARTInfo{
  795. Flags: 0x00,
  796. Hash: []byte{'t', 'h', 'e', 'h', 'a', 's', 'h'},
  797. },
  798. },
  799. },
  800. },
  801. },
  802. bartAssetManagerParams: bartAssetManagerParams{
  803. bartItemParams: bartItemParams{
  804. {
  805. hash: []byte{'t', 'h', 'e', 'h', 'a', 's', 'h'},
  806. result: sampleGIF,
  807. },
  808. },
  809. },
  810. },
  811. },
  812. {
  813. name: "account with jpg buddy icon",
  814. requestScreenName: state.NewIdentScreenName("userA"),
  815. want: string(sampleJPG),
  816. statusCode: http.StatusOK,
  817. contentType: "image/jpeg",
  818. mockParams: mockParams{
  819. userManagerParams: userManagerParams{
  820. getUserParams: getUserParams{
  821. {
  822. screenName: state.NewIdentScreenName("userA"),
  823. result: &state.User{
  824. DisplayScreenName: "userA",
  825. IdentScreenName: state.NewIdentScreenName("userA"),
  826. },
  827. },
  828. },
  829. },
  830. feedBagRetrieverParams: feedBagRetrieverParams{
  831. buddyIconMetadataParams: buddyIconMetadataParams{
  832. {
  833. screenName: state.NewIdentScreenName("userA"),
  834. result: &wire.BARTID{
  835. Type: wire.BARTTypesBuddyIcon,
  836. BARTInfo: wire.BARTInfo{
  837. Flags: 0x00,
  838. Hash: []byte{'t', 'h', 'e', 'h', 'a', 's', 'h'},
  839. },
  840. },
  841. },
  842. },
  843. },
  844. bartAssetManagerParams: bartAssetManagerParams{
  845. bartItemParams: bartItemParams{
  846. {
  847. hash: []byte{'t', 'h', 'e', 'h', 'a', 's', 'h'},
  848. result: sampleJPG,
  849. },
  850. },
  851. },
  852. },
  853. },
  854. {
  855. name: "account with unknown format buddy icon",
  856. requestScreenName: state.NewIdentScreenName("userA"),
  857. want: string([]byte{0x13, 0x37, 0x13, 0x37, 0x13, 0x37}),
  858. statusCode: http.StatusOK,
  859. contentType: "application/octet-stream",
  860. mockParams: mockParams{
  861. userManagerParams: userManagerParams{
  862. getUserParams: getUserParams{
  863. {
  864. screenName: state.NewIdentScreenName("userA"),
  865. result: &state.User{
  866. DisplayScreenName: "userA",
  867. IdentScreenName: state.NewIdentScreenName("userA"),
  868. },
  869. },
  870. },
  871. },
  872. feedBagRetrieverParams: feedBagRetrieverParams{
  873. buddyIconMetadataParams: buddyIconMetadataParams{
  874. {
  875. screenName: state.NewIdentScreenName("userA"),
  876. result: &wire.BARTID{
  877. Type: wire.BARTTypesBuddyIcon,
  878. BARTInfo: wire.BARTInfo{
  879. Flags: 0x00,
  880. Hash: []byte{'t', 'h', 'e', 'h', 'a', 's', 'h'},
  881. },
  882. },
  883. },
  884. },
  885. },
  886. bartAssetManagerParams: bartAssetManagerParams{
  887. bartItemParams: bartItemParams{
  888. {
  889. hash: []byte{'t', 'h', 'e', 'h', 'a', 's', 'h'},
  890. result: []byte{0x13, 0x37, 0x13, 0x37, 0x13, 0x37},
  891. },
  892. },
  893. },
  894. },
  895. },
  896. {
  897. name: "account with cleared buddy icon",
  898. requestScreenName: state.NewIdentScreenName("userA"),
  899. want: "icon not found",
  900. statusCode: http.StatusNotFound,
  901. contentType: "text/plain; charset=utf-8",
  902. mockParams: mockParams{
  903. userManagerParams: userManagerParams{
  904. getUserParams: getUserParams{
  905. {
  906. screenName: state.NewIdentScreenName("userA"),
  907. result: &state.User{
  908. DisplayScreenName: "userA",
  909. IdentScreenName: state.NewIdentScreenName("userA"),
  910. },
  911. },
  912. },
  913. },
  914. feedBagRetrieverParams: feedBagRetrieverParams{
  915. buddyIconMetadataParams: buddyIconMetadataParams{
  916. {
  917. screenName: state.NewIdentScreenName("userA"),
  918. result: &wire.BARTID{
  919. Type: wire.BARTTypesBuddyIcon,
  920. BARTInfo: wire.BARTInfo{
  921. Flags: 0x00,
  922. Hash: wire.GetClearIconHash(),
  923. },
  924. },
  925. },
  926. },
  927. },
  928. },
  929. },
  930. {
  931. name: "account with no buddy icon",
  932. requestScreenName: state.NewIdentScreenName("userA"),
  933. want: "icon not found",
  934. statusCode: http.StatusNotFound,
  935. contentType: "text/plain; charset=utf-8",
  936. mockParams: mockParams{
  937. userManagerParams: userManagerParams{
  938. getUserParams: getUserParams{
  939. {
  940. screenName: state.NewIdentScreenName("userA"),
  941. result: &state.User{
  942. DisplayScreenName: "userA",
  943. IdentScreenName: state.NewIdentScreenName("userA"),
  944. },
  945. },
  946. },
  947. },
  948. feedBagRetrieverParams: feedBagRetrieverParams{
  949. buddyIconMetadataParams: buddyIconMetadataParams{
  950. {
  951. screenName: state.NewIdentScreenName("userA"),
  952. result: nil,
  953. },
  954. },
  955. },
  956. },
  957. },
  958. }
  959. for _, tc := range tt {
  960. t.Run(tc.name, func(t *testing.T) {
  961. request := httptest.NewRequest(http.MethodGet, "/user/"+tc.requestScreenName.String()+"/icon", nil)
  962. request.SetPathValue("screenname", tc.requestScreenName.String())
  963. responseRecorder := httptest.NewRecorder()
  964. userManager := newMockUserManager(t)
  965. for _, params := range tc.mockParams.userManagerParams.getUserParams {
  966. userManager.EXPECT().
  967. User(matchContext(), params.screenName).
  968. Return(params.result, params.err)
  969. }
  970. feedbagRetriever := newMockFeedBagRetriever(t)
  971. for _, params := range tc.mockParams.feedBagRetrieverParams.buddyIconMetadataParams {
  972. feedbagRetriever.EXPECT().
  973. BuddyIconMetadata(matchContext(), params.screenName).
  974. Return(params.result, params.err)
  975. }
  976. bartRetriever := newMockBARTAssetManager(t)
  977. for _, params := range tc.mockParams.bartAssetManagerParams.bartItemParams {
  978. bartRetriever.EXPECT().
  979. BARTItem(matchContext(), params.hash).
  980. Return(params.result, params.err)
  981. }
  982. getUserBuddyIconHandler(responseRecorder, request, userManager, feedbagRetriever, bartRetriever, slog.Default())
  983. if responseRecorder.Code != tc.statusCode {
  984. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  985. }
  986. contentType := responseRecorder.Header().Get("Content-Type")
  987. if contentType != tc.contentType {
  988. t.Errorf("Want content type '%s', got '%s'", tc.contentType, contentType)
  989. }
  990. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  991. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  992. }
  993. })
  994. }
  995. }
  996. func TestUserHandler_GET(t *testing.T) {
  997. tt := []struct {
  998. name string
  999. want string
  1000. statusCode int
  1001. mockParams mockParams
  1002. }{
  1003. {
  1004. name: "empty user store",
  1005. want: `[]`,
  1006. statusCode: http.StatusOK,
  1007. mockParams: mockParams{
  1008. userManagerParams: userManagerParams{
  1009. allUsersParams: allUsersParams{
  1010. {
  1011. result: []state.User{},
  1012. },
  1013. },
  1014. },
  1015. },
  1016. },
  1017. {
  1018. name: "user store containing 3 users",
  1019. want: `[{"id":"usera","screen_name":"userA","is_icq":false,"suspended_status":"","is_bot":false},{"id":"userb","screen_name":"userB","is_icq":false,"suspended_status":"","is_bot":true},{"id":"100003","screen_name":"100003","is_icq":true,"suspended_status":"","is_bot":false}]`,
  1020. statusCode: http.StatusOK,
  1021. mockParams: mockParams{
  1022. userManagerParams: userManagerParams{
  1023. allUsersParams: allUsersParams{
  1024. {
  1025. result: []state.User{
  1026. {
  1027. DisplayScreenName: "userA",
  1028. IdentScreenName: state.NewIdentScreenName("userA"),
  1029. },
  1030. {
  1031. DisplayScreenName: "userB",
  1032. IdentScreenName: state.NewIdentScreenName("userB"),
  1033. IsBot: true,
  1034. },
  1035. {
  1036. DisplayScreenName: "100003",
  1037. IdentScreenName: state.NewIdentScreenName("100003"),
  1038. IsICQ: true,
  1039. },
  1040. },
  1041. },
  1042. },
  1043. },
  1044. },
  1045. },
  1046. {
  1047. name: "user handler error",
  1048. want: `internal server error`,
  1049. statusCode: http.StatusInternalServerError,
  1050. mockParams: mockParams{
  1051. userManagerParams: userManagerParams{
  1052. allUsersParams: allUsersParams{
  1053. {
  1054. result: []state.User{},
  1055. err: io.EOF,
  1056. },
  1057. },
  1058. },
  1059. },
  1060. },
  1061. }
  1062. for _, tc := range tt {
  1063. t.Run(tc.name, func(t *testing.T) {
  1064. request := httptest.NewRequest(http.MethodGet, "/user", nil)
  1065. responseRecorder := httptest.NewRecorder()
  1066. userManager := newMockUserManager(t)
  1067. for _, params := range tc.mockParams.userManagerParams.allUsersParams {
  1068. userManager.EXPECT().
  1069. AllUsers(matchContext()).
  1070. Return(params.result, params.err)
  1071. }
  1072. getUserHandler(responseRecorder, request, userManager, slog.Default())
  1073. if responseRecorder.Code != tc.statusCode {
  1074. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1075. }
  1076. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1077. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  1078. }
  1079. })
  1080. }
  1081. }
  1082. func TestUserHandler_POST(t *testing.T) {
  1083. tt := []struct {
  1084. name string
  1085. body string
  1086. UUID uuid.UUID
  1087. want string
  1088. password string
  1089. statusCode int
  1090. mockParams mockParams
  1091. }{
  1092. {
  1093. name: "with valid AIM user",
  1094. body: `{"screen_name":"userA", "password":"thepassword"}`,
  1095. UUID: uuid.MustParse("07c70701-ba68-49a9-9f9b-67a53816e37b"),
  1096. want: `User account created successfully.`,
  1097. password: "thepassword",
  1098. statusCode: http.StatusCreated,
  1099. mockParams: mockParams{
  1100. userManagerParams: userManagerParams{
  1101. insertUserParams: insertUserParams{
  1102. {
  1103. u: state.User{
  1104. AuthKey: uuid.MustParse("07c70701-ba68-49a9-9f9b-67a53816e37b").String(),
  1105. DisplayScreenName: "userA",
  1106. IdentScreenName: state.NewIdentScreenName("userA"),
  1107. },
  1108. err: nil,
  1109. },
  1110. },
  1111. },
  1112. },
  1113. },
  1114. {
  1115. name: "with valid ICQ user",
  1116. body: `{"screen_name":"100003", "password":"thepass"}`,
  1117. UUID: uuid.MustParse("07c70701-ba68-49a9-9f9b-67a53816e37b"),
  1118. want: `User account created successfully.`,
  1119. password: "thepass",
  1120. statusCode: http.StatusCreated,
  1121. mockParams: mockParams{
  1122. userManagerParams: userManagerParams{
  1123. insertUserParams: insertUserParams{
  1124. {
  1125. u: state.User{
  1126. AuthKey: uuid.MustParse("07c70701-ba68-49a9-9f9b-67a53816e37b").String(),
  1127. DisplayScreenName: "100003",
  1128. IdentScreenName: state.NewIdentScreenName("100003"),
  1129. IsICQ: true,
  1130. },
  1131. err: nil,
  1132. },
  1133. },
  1134. },
  1135. },
  1136. },
  1137. {
  1138. name: "with malformed body",
  1139. body: `{"screen_name":"userA", "password":"thepassword"`, // missing closing }
  1140. want: `malformed input`,
  1141. statusCode: http.StatusBadRequest,
  1142. },
  1143. {
  1144. name: "user handler error",
  1145. body: `{"screen_name":"userA", "password":"thepassword"}`,
  1146. UUID: uuid.MustParse("07c70701-ba68-49a9-9f9b-67a53816e37b"),
  1147. want: `internal server error`,
  1148. password: "thepassword",
  1149. statusCode: http.StatusInternalServerError,
  1150. mockParams: mockParams{
  1151. userManagerParams: userManagerParams{
  1152. insertUserParams: insertUserParams{
  1153. {
  1154. u: state.User{
  1155. AuthKey: uuid.MustParse("07c70701-ba68-49a9-9f9b-67a53816e37b").String(),
  1156. DisplayScreenName: "userA",
  1157. IdentScreenName: state.NewIdentScreenName("userA"),
  1158. },
  1159. err: io.EOF,
  1160. },
  1161. },
  1162. },
  1163. },
  1164. },
  1165. {
  1166. name: "duplicate user",
  1167. body: `{"screen_name":"userA", "password":"thepassword"}`,
  1168. UUID: uuid.MustParse("07c70701-ba68-49a9-9f9b-67a53816e37b"),
  1169. want: `user already exists`,
  1170. password: "thepassword",
  1171. statusCode: http.StatusConflict,
  1172. mockParams: mockParams{
  1173. userManagerParams: userManagerParams{
  1174. insertUserParams: insertUserParams{
  1175. {
  1176. u: state.User{
  1177. AuthKey: uuid.MustParse("07c70701-ba68-49a9-9f9b-67a53816e37b").String(),
  1178. DisplayScreenName: "userA",
  1179. IdentScreenName: state.NewIdentScreenName("userA"),
  1180. },
  1181. err: state.ErrDupUser,
  1182. },
  1183. },
  1184. },
  1185. },
  1186. },
  1187. {
  1188. name: "invalid AIM screen name",
  1189. body: `{"screen_name":"a", "password":"thepassword"}`,
  1190. UUID: uuid.MustParse("07c70701-ba68-49a9-9f9b-67a53816e37b"),
  1191. want: `invalid screen name: screen name must be between 3 and 16 characters`,
  1192. statusCode: http.StatusBadRequest,
  1193. },
  1194. {
  1195. name: "invalid AIM password",
  1196. body: `{"screen_name":"userA", "password":"1"}`,
  1197. UUID: uuid.MustParse("07c70701-ba68-49a9-9f9b-67a53816e37b"),
  1198. want: `invalid password: invalid password length: password length must be between 4-16 characters`,
  1199. statusCode: http.StatusBadRequest,
  1200. },
  1201. {
  1202. name: "invalid ICQ UIN",
  1203. body: `{"screen_name":"1000", "password":"thepass"}`,
  1204. UUID: uuid.MustParse("07c70701-ba68-49a9-9f9b-67a53816e37b"),
  1205. want: `invalid uin: uin must be a number in the range 10000-2147483646`,
  1206. statusCode: http.StatusBadRequest,
  1207. },
  1208. {
  1209. name: "invalid ICQ password",
  1210. body: `{"screen_name":"100003", "password":"thelongpassword"}`,
  1211. UUID: uuid.MustParse("07c70701-ba68-49a9-9f9b-67a53816e37b"),
  1212. want: `invalid password: invalid password length: password must be between 6-8 characters`,
  1213. statusCode: http.StatusBadRequest,
  1214. },
  1215. }
  1216. for _, tc := range tt {
  1217. t.Run(tc.name, func(t *testing.T) {
  1218. request := httptest.NewRequest(http.MethodPost, "/user", strings.NewReader(tc.body))
  1219. responseRecorder := httptest.NewRecorder()
  1220. userManager := newMockUserManager(t)
  1221. for _, params := range tc.mockParams.userManagerParams.insertUserParams {
  1222. assert.NoError(t, params.u.HashPassword(tc.password))
  1223. userManager.EXPECT().
  1224. InsertUser(matchContext(), params.u).
  1225. Return(params.err)
  1226. }
  1227. newUUID := func() uuid.UUID { return tc.UUID }
  1228. postUserHandler(responseRecorder, request, userManager, newUUID, slog.Default())
  1229. if responseRecorder.Code != tc.statusCode {
  1230. t.Errorf("want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1231. }
  1232. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1233. t.Errorf("want '%s', got '%s'", tc.want, responseRecorder.Body)
  1234. }
  1235. })
  1236. }
  1237. }
  1238. func TestUserHandler_DELETE(t *testing.T) {
  1239. tt := []struct {
  1240. name string
  1241. body string
  1242. want string
  1243. statusCode int
  1244. mockParams mockParams
  1245. }{
  1246. {
  1247. name: "with valid user",
  1248. body: `{"screen_name":"userA"}`,
  1249. want: `User account successfully deleted.`,
  1250. statusCode: http.StatusNoContent,
  1251. mockParams: mockParams{
  1252. userManagerParams: userManagerParams{
  1253. deleteUserParams: deleteUserParams{
  1254. {
  1255. screenName: state.NewIdentScreenName("userA"),
  1256. },
  1257. },
  1258. },
  1259. },
  1260. },
  1261. {
  1262. name: "with non-existent user",
  1263. body: `{"screen_name":"userA"}`,
  1264. want: `user does not exist`,
  1265. statusCode: http.StatusNotFound,
  1266. mockParams: mockParams{
  1267. userManagerParams: userManagerParams{
  1268. deleteUserParams: deleteUserParams{
  1269. {
  1270. screenName: state.NewIdentScreenName("userA"),
  1271. err: state.ErrNoUser,
  1272. },
  1273. },
  1274. },
  1275. },
  1276. },
  1277. {
  1278. name: "with malformed body",
  1279. body: `{"screen_name":"userA"`, // missing closing }
  1280. want: `malformed input`,
  1281. statusCode: http.StatusBadRequest,
  1282. },
  1283. {
  1284. name: "user handler error",
  1285. body: `{"screen_name":"userA"}`,
  1286. want: `internal server error`,
  1287. statusCode: http.StatusInternalServerError,
  1288. mockParams: mockParams{
  1289. userManagerParams: userManagerParams{
  1290. deleteUserParams: deleteUserParams{
  1291. {
  1292. screenName: state.NewIdentScreenName("userA"),
  1293. err: io.EOF,
  1294. },
  1295. },
  1296. },
  1297. },
  1298. },
  1299. }
  1300. for _, tc := range tt {
  1301. t.Run(tc.name, func(t *testing.T) {
  1302. request := httptest.NewRequest(http.MethodDelete, "/user", strings.NewReader(tc.body))
  1303. responseRecorder := httptest.NewRecorder()
  1304. userManager := newMockUserManager(t)
  1305. for _, params := range tc.mockParams.userManagerParams.deleteUserParams {
  1306. userManager.EXPECT().
  1307. DeleteUser(matchContext(), params.screenName).
  1308. Return(params.err)
  1309. }
  1310. deleteUserHandler(responseRecorder, request, userManager, slog.Default())
  1311. if responseRecorder.Code != tc.statusCode {
  1312. t.Errorf("want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1313. }
  1314. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1315. t.Errorf("want '%s', got '%s'", tc.want, responseRecorder.Body)
  1316. }
  1317. })
  1318. }
  1319. }
  1320. func TestUserPasswordHandler_PUT(t *testing.T) {
  1321. tt := []struct {
  1322. name string
  1323. body string
  1324. want string
  1325. statusCode int
  1326. mockParams mockParams
  1327. }{
  1328. {
  1329. name: "user with valid password",
  1330. body: `{"screen_name":"userA", "password":"thenewpassword"}`,
  1331. want: `Password successfully reset.`,
  1332. statusCode: http.StatusNoContent,
  1333. mockParams: mockParams{
  1334. userManagerParams: userManagerParams{
  1335. setUserPasswordParams: setUserPasswordParams{
  1336. {
  1337. screenName: state.NewIdentScreenName("userA"),
  1338. newPassword: "thenewpassword",
  1339. },
  1340. },
  1341. },
  1342. },
  1343. },
  1344. {
  1345. name: "user with invalid password",
  1346. body: `{"screen_name":"userA", "password":"a"}`,
  1347. want: `invalid password length`,
  1348. statusCode: http.StatusBadRequest,
  1349. mockParams: mockParams{
  1350. userManagerParams: userManagerParams{
  1351. setUserPasswordParams: setUserPasswordParams{
  1352. {
  1353. screenName: state.NewIdentScreenName("userA"),
  1354. newPassword: "a",
  1355. err: state.ErrPasswordInvalid,
  1356. },
  1357. },
  1358. },
  1359. },
  1360. },
  1361. {
  1362. name: "with malformed body",
  1363. body: `{"screen_name":"userA", "password":"thepassword"`, // missing closing }
  1364. want: `malformed input`,
  1365. statusCode: http.StatusBadRequest,
  1366. },
  1367. {
  1368. name: "password updater returns runtime error",
  1369. body: `{"screen_name":"userA", "password":"thepassword"}`,
  1370. want: `internal server error`,
  1371. statusCode: http.StatusInternalServerError,
  1372. mockParams: mockParams{
  1373. userManagerParams: userManagerParams{
  1374. setUserPasswordParams: setUserPasswordParams{
  1375. {
  1376. screenName: state.NewIdentScreenName("userA"),
  1377. newPassword: "thepassword",
  1378. err: io.EOF,
  1379. },
  1380. },
  1381. },
  1382. },
  1383. },
  1384. {
  1385. name: "user doesn't exist",
  1386. body: `{"screen_name":"userA", "password":"thepassword"}`,
  1387. want: `user does not exist`,
  1388. statusCode: http.StatusNotFound,
  1389. mockParams: mockParams{
  1390. userManagerParams: userManagerParams{
  1391. setUserPasswordParams: setUserPasswordParams{
  1392. {
  1393. screenName: state.NewIdentScreenName("userA"),
  1394. newPassword: "thepassword",
  1395. err: state.ErrNoUser,
  1396. },
  1397. },
  1398. },
  1399. },
  1400. },
  1401. }
  1402. for _, tc := range tt {
  1403. t.Run(tc.name, func(t *testing.T) {
  1404. request := httptest.NewRequest(http.MethodPut, "/user", strings.NewReader(tc.body))
  1405. responseRecorder := httptest.NewRecorder()
  1406. userManager := newMockUserManager(t)
  1407. for _, params := range tc.mockParams.userManagerParams.setUserPasswordParams {
  1408. userManager.EXPECT().
  1409. SetUserPassword(matchContext(), params.screenName, params.newPassword).
  1410. Return(params.err)
  1411. }
  1412. putUserPasswordHandler(responseRecorder, request, userManager, slog.Default())
  1413. if responseRecorder.Code != tc.statusCode {
  1414. t.Errorf("want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1415. }
  1416. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1417. t.Errorf("want '%s', got '%s'", tc.want, responseRecorder.Body)
  1418. }
  1419. })
  1420. }
  1421. }
  1422. func TestPublicChatHandler_GET(t *testing.T) {
  1423. fnNewSess := func(screenName string) *state.Session {
  1424. sess := state.NewSession()
  1425. sess.SetIdentScreenName(state.NewIdentScreenName(screenName))
  1426. sess.SetDisplayScreenName(state.DisplayScreenName(screenName))
  1427. instance := sess.AddInstance()
  1428. instance.SetSignonComplete()
  1429. return sess
  1430. }
  1431. chatRoom1 := state.NewChatRoom("chat-room-1-name", state.NewIdentScreenName("chat-room-1-creator"), state.PublicExchange)
  1432. chatRoom2 := state.NewChatRoom("chat-room-2-name", state.NewIdentScreenName("chat-room-1-creator"), state.PublicExchange)
  1433. tt := []struct {
  1434. name string
  1435. want string
  1436. statusCode int
  1437. mockParams mockParams
  1438. }{
  1439. {
  1440. name: "multiple chat rooms with participants",
  1441. want: `[{"name":"chat-room-1-name","create_time":"0001-01-01T00:00:00Z","url":"aim:gochat?roomname=chat-room-1-name&exchange=5","participants":[{"id":"usera","screen_name":"userA"},{"id":"userb","screen_name":"userB"}]},{"name":"chat-room-2-name","create_time":"0001-01-01T00:00:00Z","url":"aim:gochat?roomname=chat-room-2-name&exchange=5","participants":[{"id":"userc","screen_name":"userC"},{"id":"userd","screen_name":"userD"}]}]`,
  1442. statusCode: http.StatusOK,
  1443. mockParams: mockParams{
  1444. chatRoomRetrieverParams: chatRoomRetrieverParams{
  1445. allChatRoomsParams: allChatRoomsParams{
  1446. {
  1447. exchange: state.PublicExchange,
  1448. result: []state.ChatRoom{
  1449. chatRoom1,
  1450. chatRoom2,
  1451. },
  1452. },
  1453. },
  1454. },
  1455. chatSessionRetrieverParams: chatSessionRetrieverParams{
  1456. chatSessionRetrieverAllSessionsParams: chatSessionRetrieverAllSessionsParams{
  1457. {
  1458. cookie: chatRoom1.Cookie(),
  1459. result: []*state.Session{
  1460. fnNewSess("userA"),
  1461. fnNewSess("userB"),
  1462. },
  1463. },
  1464. {
  1465. cookie: chatRoom2.Cookie(),
  1466. result: []*state.Session{
  1467. fnNewSess("userC"),
  1468. fnNewSess("userD"),
  1469. },
  1470. },
  1471. },
  1472. },
  1473. },
  1474. },
  1475. {
  1476. name: "chat room without participants",
  1477. want: `[{"name":"chat-room-1-name","create_time":"0001-01-01T00:00:00Z","url":"aim:gochat?roomname=chat-room-1-name&exchange=5","participants":[]}]`,
  1478. statusCode: http.StatusOK,
  1479. mockParams: mockParams{
  1480. chatRoomRetrieverParams: chatRoomRetrieverParams{
  1481. allChatRoomsParams: allChatRoomsParams{
  1482. {
  1483. exchange: state.PublicExchange,
  1484. result: []state.ChatRoom{
  1485. chatRoom1,
  1486. },
  1487. },
  1488. },
  1489. },
  1490. chatSessionRetrieverParams: chatSessionRetrieverParams{
  1491. chatSessionRetrieverAllSessionsParams: chatSessionRetrieverAllSessionsParams{
  1492. {
  1493. cookie: chatRoom1.Cookie(),
  1494. result: []*state.Session{},
  1495. },
  1496. },
  1497. },
  1498. },
  1499. },
  1500. {
  1501. name: "no chat rooms",
  1502. want: `[]`,
  1503. statusCode: http.StatusOK,
  1504. mockParams: mockParams{
  1505. chatRoomRetrieverParams: chatRoomRetrieverParams{
  1506. allChatRoomsParams: allChatRoomsParams{
  1507. {
  1508. exchange: state.PublicExchange,
  1509. result: []state.ChatRoom{},
  1510. },
  1511. },
  1512. },
  1513. },
  1514. },
  1515. }
  1516. for _, tc := range tt {
  1517. t.Run(tc.name, func(t *testing.T) {
  1518. request := httptest.NewRequest(http.MethodGet, "/chat/room/public", nil)
  1519. responseRecorder := httptest.NewRecorder()
  1520. chatRoomRetriever := newMockChatRoomRetriever(t)
  1521. for _, params := range tc.mockParams.chatRoomRetrieverParams.allChatRoomsParams {
  1522. chatRoomRetriever.EXPECT().
  1523. AllChatRooms(matchContext(), params.exchange).
  1524. Return(params.result, params.err)
  1525. }
  1526. chatSessionRetriever := newMockChatSessionRetriever(t)
  1527. for _, params := range tc.mockParams.chatSessionRetrieverParams.chatSessionRetrieverAllSessionsParams {
  1528. chatSessionRetriever.EXPECT().
  1529. AllSessions(params.cookie).
  1530. Return(params.result)
  1531. }
  1532. getPublicChatHandler(responseRecorder, request, chatRoomRetriever, chatSessionRetriever, slog.Default())
  1533. if responseRecorder.Code != tc.statusCode {
  1534. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1535. }
  1536. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1537. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  1538. }
  1539. })
  1540. }
  1541. }
  1542. func TestDeletePublicChatHandler(t *testing.T) {
  1543. tt := []struct {
  1544. name string
  1545. body string
  1546. want string
  1547. statusCode int
  1548. mockParams mockParams
  1549. }{
  1550. {
  1551. name: "successful deletion of single chat room",
  1552. body: `{"names":["TestRoom"]}`,
  1553. want: `Chat rooms deleted successfully.`,
  1554. statusCode: http.StatusNoContent,
  1555. mockParams: mockParams{
  1556. chatRoomDeleterParams: chatRoomDeleterParams{
  1557. deleteChatRoomsParams: deleteChatRoomsParams{
  1558. {
  1559. exchange: state.PublicExchange,
  1560. names: []string{"TestRoom"},
  1561. },
  1562. },
  1563. },
  1564. },
  1565. },
  1566. {
  1567. name: "successful deletion of multiple chat rooms",
  1568. body: `{"names":["Room1", "Room2", "Room3"]}`,
  1569. want: `Chat rooms deleted successfully.`,
  1570. statusCode: http.StatusNoContent,
  1571. mockParams: mockParams{
  1572. chatRoomDeleterParams: chatRoomDeleterParams{
  1573. deleteChatRoomsParams: deleteChatRoomsParams{
  1574. {
  1575. exchange: state.PublicExchange,
  1576. names: []string{"Room1", "Room2", "Room3"},
  1577. },
  1578. },
  1579. },
  1580. },
  1581. },
  1582. {
  1583. name: "empty names array",
  1584. body: `{"names":[]}`,
  1585. want: `no chat room names provided`,
  1586. statusCode: http.StatusBadRequest,
  1587. },
  1588. {
  1589. name: "malformed JSON",
  1590. body: `{"names":["Room1"`, // missing closing brackets
  1591. want: `malformed input`,
  1592. statusCode: http.StatusBadRequest,
  1593. },
  1594. {
  1595. name: "deletion error",
  1596. body: `{"names":["TestRoom"]}`,
  1597. want: `internal server error`,
  1598. statusCode: http.StatusInternalServerError,
  1599. mockParams: mockParams{
  1600. chatRoomDeleterParams: chatRoomDeleterParams{
  1601. deleteChatRoomsParams: deleteChatRoomsParams{
  1602. {
  1603. exchange: state.PublicExchange,
  1604. names: []string{"TestRoom"},
  1605. err: errors.New("database error"),
  1606. },
  1607. },
  1608. },
  1609. },
  1610. },
  1611. }
  1612. for _, tc := range tt {
  1613. t.Run(tc.name, func(t *testing.T) {
  1614. request := httptest.NewRequest(http.MethodDelete, "/chat/room/public", strings.NewReader(tc.body))
  1615. responseRecorder := httptest.NewRecorder()
  1616. chatRoomDeleter := newMockChatRoomDeleter(t)
  1617. for _, params := range tc.mockParams.chatRoomDeleterParams.deleteChatRoomsParams {
  1618. chatRoomDeleter.EXPECT().
  1619. DeleteChatRooms(matchContext(), params.exchange, params.names).
  1620. Return(params.err)
  1621. }
  1622. deletePublicChatHandler(responseRecorder, request, chatRoomDeleter, slog.Default())
  1623. if responseRecorder.Code != tc.statusCode {
  1624. t.Errorf("want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1625. }
  1626. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1627. t.Errorf("want '%s', got '%s'", tc.want, responseRecorder.Body)
  1628. }
  1629. })
  1630. }
  1631. }
  1632. func TestPrivateChatHandler_GET(t *testing.T) {
  1633. fnNewSess := func(screenName string) *state.Session {
  1634. sess := state.NewSession()
  1635. sess.SetIdentScreenName(state.NewIdentScreenName(screenName))
  1636. sess.SetDisplayScreenName(state.DisplayScreenName(screenName))
  1637. instance := sess.AddInstance()
  1638. instance.SetSignonComplete()
  1639. return sess
  1640. }
  1641. chatRoom1 := state.NewChatRoom("chat-room-1-name", state.NewIdentScreenName("chat-room-1-creator"), state.PrivateExchange)
  1642. chatRoom2 := state.NewChatRoom("chat-room-2-name", state.NewIdentScreenName("chat-room-2-creator"), state.PrivateExchange)
  1643. tt := []struct {
  1644. name string
  1645. want string
  1646. statusCode int
  1647. mockParams mockParams
  1648. }{
  1649. {
  1650. name: "multiple chat rooms with participants",
  1651. want: `[{"name":"chat-room-1-name","create_time":"0001-01-01T00:00:00Z","creator_id":"chat-room-1-creator","url":"aim:gochat?roomname=chat-room-1-name&exchange=4","participants":[{"id":"usera","screen_name":"userA"},{"id":"userb","screen_name":"userB"}]},{"name":"chat-room-2-name","create_time":"0001-01-01T00:00:00Z","creator_id":"chat-room-2-creator","url":"aim:gochat?roomname=chat-room-2-name&exchange=4","participants":[{"id":"userc","screen_name":"userC"},{"id":"userd","screen_name":"userD"}]}]`,
  1652. statusCode: http.StatusOK,
  1653. mockParams: mockParams{
  1654. chatRoomRetrieverParams: chatRoomRetrieverParams{
  1655. allChatRoomsParams: allChatRoomsParams{
  1656. {
  1657. exchange: state.PrivateExchange,
  1658. result: []state.ChatRoom{
  1659. chatRoom1,
  1660. chatRoom2,
  1661. },
  1662. },
  1663. },
  1664. },
  1665. chatSessionRetrieverParams: chatSessionRetrieverParams{
  1666. chatSessionRetrieverAllSessionsParams: chatSessionRetrieverAllSessionsParams{
  1667. {
  1668. cookie: chatRoom1.Cookie(),
  1669. result: []*state.Session{
  1670. fnNewSess("userA"),
  1671. fnNewSess("userB"),
  1672. },
  1673. },
  1674. {
  1675. cookie: chatRoom2.Cookie(),
  1676. result: []*state.Session{
  1677. fnNewSess("userC"),
  1678. fnNewSess("userD"),
  1679. },
  1680. },
  1681. },
  1682. },
  1683. },
  1684. },
  1685. {
  1686. name: "chat room without participants",
  1687. want: `[{"name":"chat-room-1-name","create_time":"0001-01-01T00:00:00Z","creator_id":"chat-room-1-creator","url":"aim:gochat?roomname=chat-room-1-name&exchange=4","participants":[]}]`,
  1688. statusCode: http.StatusOK,
  1689. mockParams: mockParams{
  1690. chatRoomRetrieverParams: chatRoomRetrieverParams{
  1691. allChatRoomsParams: allChatRoomsParams{
  1692. {
  1693. exchange: state.PrivateExchange,
  1694. result: []state.ChatRoom{
  1695. chatRoom1,
  1696. },
  1697. },
  1698. },
  1699. },
  1700. chatSessionRetrieverParams: chatSessionRetrieverParams{
  1701. chatSessionRetrieverAllSessionsParams: chatSessionRetrieverAllSessionsParams{
  1702. {
  1703. cookie: chatRoom1.Cookie(),
  1704. result: []*state.Session{},
  1705. },
  1706. },
  1707. },
  1708. },
  1709. },
  1710. {
  1711. name: "no chat rooms",
  1712. want: `[]`,
  1713. statusCode: http.StatusOK,
  1714. mockParams: mockParams{
  1715. chatRoomRetrieverParams: chatRoomRetrieverParams{
  1716. allChatRoomsParams: allChatRoomsParams{
  1717. {
  1718. exchange: state.PrivateExchange,
  1719. result: []state.ChatRoom{},
  1720. },
  1721. },
  1722. },
  1723. },
  1724. },
  1725. }
  1726. for _, tc := range tt {
  1727. t.Run(tc.name, func(t *testing.T) {
  1728. request := httptest.NewRequest(http.MethodGet, "/chat/room/private", nil)
  1729. responseRecorder := httptest.NewRecorder()
  1730. chatRoomRetriever := newMockChatRoomRetriever(t)
  1731. for _, params := range tc.mockParams.chatRoomRetrieverParams.allChatRoomsParams {
  1732. chatRoomRetriever.EXPECT().
  1733. AllChatRooms(matchContext(), params.exchange).
  1734. Return(params.result, params.err)
  1735. }
  1736. chatSessionRetriever := newMockChatSessionRetriever(t)
  1737. for _, params := range tc.mockParams.chatSessionRetrieverParams.chatSessionRetrieverAllSessionsParams {
  1738. chatSessionRetriever.EXPECT().
  1739. AllSessions(params.cookie).
  1740. Return(params.result)
  1741. }
  1742. getPrivateChatHandler(responseRecorder, request, chatRoomRetriever, chatSessionRetriever, slog.Default())
  1743. if responseRecorder.Code != tc.statusCode {
  1744. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1745. }
  1746. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1747. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  1748. }
  1749. })
  1750. }
  1751. }
  1752. func TestInstantMessageHandler_POST(t *testing.T) {
  1753. type relayToScreenNameInputs struct {
  1754. sender state.IdentScreenName
  1755. recipient state.IdentScreenName
  1756. msg string
  1757. }
  1758. tt := []struct {
  1759. name string
  1760. relayToScreenNameInputs []relayToScreenNameInputs
  1761. body string
  1762. want string
  1763. statusCode int
  1764. }{
  1765. {
  1766. name: "send an instant message",
  1767. relayToScreenNameInputs: []relayToScreenNameInputs{
  1768. {
  1769. sender: state.NewIdentScreenName("sender_sn"),
  1770. recipient: state.NewIdentScreenName("recip_sn"),
  1771. msg: "hello world!",
  1772. },
  1773. },
  1774. body: `{"from":"sender_sn","to":"recip_sn","text":"hello world!"}`,
  1775. want: `Message sent successfully.`,
  1776. statusCode: http.StatusOK,
  1777. },
  1778. {
  1779. name: "with malformed body",
  1780. body: `{"screen_name":"userA", "password":"thepassword"`,
  1781. want: `malformed input`,
  1782. statusCode: http.StatusBadRequest,
  1783. },
  1784. }
  1785. for _, tc := range tt {
  1786. t.Run(tc.name, func(t *testing.T) {
  1787. request := httptest.NewRequest(http.MethodPost, "/user", strings.NewReader(tc.body))
  1788. responseRecorder := httptest.NewRecorder()
  1789. messageRelayer := newMockMessageRelayer(t)
  1790. for _, params := range tc.relayToScreenNameInputs {
  1791. validateSNAC := func(msg wire.SNACMessage) bool {
  1792. body := msg.Body.(wire.SNAC_0x04_0x07_ICBMChannelMsgToClient)
  1793. assert.Equal(t, params.sender.String(), body.TLVUserInfo.ScreenName)
  1794. b, ok := body.Bytes(wire.ICBMTLVAOLIMData)
  1795. assert.True(t, ok)
  1796. txt, err := wire.UnmarshalICBMMessageText(b)
  1797. assert.NoError(t, err)
  1798. assert.Equal(t, params.msg, txt)
  1799. return true
  1800. }
  1801. messageRelayer.EXPECT().
  1802. RelayToScreenName(mock.Anything, params.recipient, mock.MatchedBy(validateSNAC))
  1803. }
  1804. postInstantMessageHandler(responseRecorder, request, messageRelayer, slog.Default())
  1805. if responseRecorder.Code != tc.statusCode {
  1806. t.Errorf("want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1807. }
  1808. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1809. t.Errorf("want '%s', got '%s'", tc.want, responseRecorder.Body)
  1810. }
  1811. })
  1812. }
  1813. }
  1814. func TestVersionHandler_GET(t *testing.T) {
  1815. tt := []struct {
  1816. name string
  1817. want string
  1818. statusCode int
  1819. buildInfo config.Build
  1820. }{
  1821. {
  1822. name: "get ras version",
  1823. want: `{"version":"13.3.7","commit":"asdfASDF12345678","date":"2024-03-01"}`,
  1824. statusCode: http.StatusOK,
  1825. buildInfo: config.Build{
  1826. Version: "13.3.7",
  1827. Commit: "asdfASDF12345678",
  1828. Date: "2024-03-01",
  1829. },
  1830. },
  1831. }
  1832. for _, tc := range tt {
  1833. t.Run(tc.name, func(t *testing.T) {
  1834. responseRecorder := httptest.NewRecorder()
  1835. getVersionHandler(responseRecorder, tc.buildInfo)
  1836. if responseRecorder.Code != tc.statusCode {
  1837. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1838. }
  1839. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1840. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  1841. }
  1842. })
  1843. }
  1844. }
  1845. func TestDirectoryCategoryHandler_GET(t *testing.T) {
  1846. tt := []struct {
  1847. name string
  1848. want string
  1849. statusCode int
  1850. mockParams mockParams
  1851. }{
  1852. {
  1853. name: "no categories",
  1854. want: `[]`,
  1855. statusCode: http.StatusOK,
  1856. mockParams: mockParams{
  1857. directoryManagerParams: directoryManagerParams{
  1858. categoriesParams: categoriesParams{
  1859. {
  1860. result: nil,
  1861. },
  1862. },
  1863. },
  1864. },
  1865. },
  1866. {
  1867. name: "error fetching categories",
  1868. want: `{"message":"internal server error"}`,
  1869. statusCode: http.StatusInternalServerError,
  1870. mockParams: mockParams{
  1871. directoryManagerParams: directoryManagerParams{
  1872. categoriesParams: categoriesParams{
  1873. {
  1874. result: nil,
  1875. err: errors.New("error fetching categories"),
  1876. },
  1877. },
  1878. },
  1879. },
  1880. },
  1881. {
  1882. name: "fetch some categories",
  1883. want: `[{"id":1,"name":"category-1"},{"id":2,"name":"category-2"}]`,
  1884. statusCode: http.StatusOK,
  1885. mockParams: mockParams{
  1886. directoryManagerParams: directoryManagerParams{
  1887. categoriesParams: categoriesParams{
  1888. {
  1889. result: []state.Category{
  1890. {
  1891. ID: 1,
  1892. Name: "category-1",
  1893. },
  1894. {
  1895. ID: 2,
  1896. Name: "category-2",
  1897. },
  1898. },
  1899. },
  1900. },
  1901. },
  1902. },
  1903. },
  1904. }
  1905. for _, tc := range tt {
  1906. t.Run(tc.name, func(t *testing.T) {
  1907. responseRecorder := httptest.NewRecorder()
  1908. request := httptest.NewRequest(http.MethodGet, "/directory/category", nil)
  1909. directoryManager := newMockDirectoryManager(t)
  1910. for _, params := range tc.mockParams.categoriesParams {
  1911. directoryManager.EXPECT().
  1912. Categories(matchContext()).
  1913. Return(params.result, params.err)
  1914. }
  1915. getDirectoryCategoryHandler(responseRecorder, request, directoryManager, slog.Default())
  1916. if responseRecorder.Code != tc.statusCode {
  1917. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1918. }
  1919. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1920. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  1921. }
  1922. })
  1923. }
  1924. }
  1925. func TestDirectoryCategoryKeywordHandler_GET(t *testing.T) {
  1926. tt := []struct {
  1927. name string
  1928. categoryID int
  1929. want string
  1930. statusCode int
  1931. mockParams mockParams
  1932. }{
  1933. {
  1934. name: "category not found",
  1935. categoryID: 1,
  1936. want: `{"message":"category not found"}`,
  1937. statusCode: http.StatusNotFound,
  1938. mockParams: mockParams{
  1939. directoryManagerParams: directoryManagerParams{
  1940. keywordsByCategoryParams: keywordsByCategoryParams{
  1941. {
  1942. categoryID: 1,
  1943. result: nil,
  1944. err: state.ErrKeywordCategoryNotFound,
  1945. },
  1946. },
  1947. },
  1948. },
  1949. },
  1950. {
  1951. name: "error fetching keywords by category",
  1952. categoryID: 1,
  1953. want: `{"message":"internal server error"}`,
  1954. statusCode: http.StatusInternalServerError,
  1955. mockParams: mockParams{
  1956. directoryManagerParams: directoryManagerParams{
  1957. keywordsByCategoryParams: keywordsByCategoryParams{
  1958. {
  1959. categoryID: 1,
  1960. result: nil,
  1961. err: errors.New("error fetching keywords by category"),
  1962. },
  1963. },
  1964. },
  1965. },
  1966. },
  1967. {
  1968. name: "invalid category ID",
  1969. categoryID: -1,
  1970. want: `{"message":"invalid category ID"}`,
  1971. statusCode: http.StatusBadRequest,
  1972. mockParams: mockParams{
  1973. directoryManagerParams: directoryManagerParams{
  1974. keywordsByCategoryParams: keywordsByCategoryParams{},
  1975. },
  1976. },
  1977. },
  1978. {
  1979. name: "no keywords",
  1980. categoryID: 1,
  1981. want: `[]`,
  1982. statusCode: http.StatusOK,
  1983. mockParams: mockParams{
  1984. directoryManagerParams: directoryManagerParams{
  1985. keywordsByCategoryParams: keywordsByCategoryParams{
  1986. {
  1987. categoryID: 1,
  1988. result: nil,
  1989. },
  1990. },
  1991. },
  1992. },
  1993. },
  1994. {
  1995. name: "fetch some keywords by category",
  1996. categoryID: 1,
  1997. want: `[{"id":1,"name":"keyword-1"},{"id":2,"name":"keyword-2"}]`,
  1998. statusCode: http.StatusOK,
  1999. mockParams: mockParams{
  2000. directoryManagerParams: directoryManagerParams{
  2001. keywordsByCategoryParams: keywordsByCategoryParams{
  2002. {
  2003. categoryID: 1,
  2004. result: []state.Keyword{
  2005. {
  2006. ID: 1,
  2007. Name: "keyword-1",
  2008. },
  2009. {
  2010. ID: 2,
  2011. Name: "keyword-2",
  2012. },
  2013. },
  2014. },
  2015. },
  2016. },
  2017. },
  2018. },
  2019. }
  2020. for _, tc := range tt {
  2021. t.Run(tc.name, func(t *testing.T) {
  2022. request := httptest.NewRequest(http.MethodGet, fmt.Sprintf("/directory/category/%d/keyword", tc.categoryID), nil)
  2023. request.SetPathValue("id", fmt.Sprintf("%d", tc.categoryID))
  2024. responseRecorder := httptest.NewRecorder()
  2025. directoryManager := newMockDirectoryManager(t)
  2026. for _, params := range tc.mockParams.keywordsByCategoryParams {
  2027. directoryManager.EXPECT().
  2028. KeywordsByCategory(matchContext(), params.categoryID).
  2029. Return(params.result, params.err)
  2030. }
  2031. getDirectoryCategoryKeywordHandler(responseRecorder, request, directoryManager, slog.Default())
  2032. if responseRecorder.Code != tc.statusCode {
  2033. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  2034. }
  2035. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  2036. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  2037. }
  2038. })
  2039. }
  2040. }
  2041. func TestDirectoryCategoryHandler_DELETE(t *testing.T) {
  2042. tt := []struct {
  2043. name string
  2044. categoryID int
  2045. want string
  2046. statusCode int
  2047. mockParams mockParams
  2048. }{
  2049. {
  2050. name: "category not found",
  2051. categoryID: 1,
  2052. want: `{"message":"category not found"}`,
  2053. statusCode: http.StatusNotFound,
  2054. mockParams: mockParams{
  2055. directoryManagerParams: directoryManagerParams{
  2056. deleteCategoryParams: deleteCategoryParams{
  2057. {
  2058. categoryID: 1,
  2059. err: state.ErrKeywordCategoryNotFound,
  2060. },
  2061. },
  2062. },
  2063. },
  2064. },
  2065. {
  2066. name: "keyword in use by user",
  2067. categoryID: 1,
  2068. want: `{"message":"can't delete because category in use by a user"}`,
  2069. statusCode: http.StatusConflict,
  2070. mockParams: mockParams{
  2071. directoryManagerParams: directoryManagerParams{
  2072. deleteCategoryParams: deleteCategoryParams{
  2073. {
  2074. categoryID: 1,
  2075. err: state.ErrKeywordInUse,
  2076. },
  2077. },
  2078. },
  2079. },
  2080. },
  2081. {
  2082. name: "runtime error",
  2083. categoryID: 1,
  2084. want: `{"message":"internal server error"}`,
  2085. statusCode: http.StatusInternalServerError,
  2086. mockParams: mockParams{
  2087. directoryManagerParams: directoryManagerParams{
  2088. deleteCategoryParams: deleteCategoryParams{
  2089. {
  2090. categoryID: 1,
  2091. err: errors.New("error deleting keyword"),
  2092. },
  2093. },
  2094. },
  2095. },
  2096. },
  2097. {
  2098. name: "successful deletion",
  2099. categoryID: 1,
  2100. want: ``,
  2101. statusCode: http.StatusNoContent,
  2102. mockParams: mockParams{
  2103. directoryManagerParams: directoryManagerParams{
  2104. deleteCategoryParams: deleteCategoryParams{
  2105. {
  2106. categoryID: 1,
  2107. },
  2108. },
  2109. },
  2110. },
  2111. },
  2112. {
  2113. name: "invalid category ID",
  2114. categoryID: -1,
  2115. want: `invalid category ID`,
  2116. statusCode: http.StatusBadRequest,
  2117. mockParams: mockParams{
  2118. directoryManagerParams: directoryManagerParams{
  2119. deleteCategoryParams: deleteCategoryParams{},
  2120. },
  2121. },
  2122. },
  2123. }
  2124. for _, tc := range tt {
  2125. t.Run(tc.name, func(t *testing.T) {
  2126. request := httptest.NewRequest(http.MethodDelete, fmt.Sprintf("/directory/category/%d/keyword", tc.categoryID), nil)
  2127. request.SetPathValue("id", fmt.Sprintf("%d", tc.categoryID))
  2128. responseRecorder := httptest.NewRecorder()
  2129. directoryManager := newMockDirectoryManager(t)
  2130. for _, params := range tc.mockParams.deleteCategoryParams {
  2131. directoryManager.EXPECT().
  2132. DeleteCategory(matchContext(), params.categoryID).
  2133. Return(params.err)
  2134. }
  2135. deleteDirectoryCategoryHandler(responseRecorder, request, directoryManager, slog.Default())
  2136. if responseRecorder.Code != tc.statusCode {
  2137. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  2138. }
  2139. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  2140. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  2141. }
  2142. })
  2143. }
  2144. }
  2145. func TestDirectoryCategoryHandler_POST(t *testing.T) {
  2146. tt := []struct {
  2147. name string
  2148. body string
  2149. want string
  2150. statusCode int
  2151. mockParams mockParams
  2152. }{
  2153. {
  2154. name: "category already exists",
  2155. body: `{"name":"the_category"}`,
  2156. want: `{"message":"category already exists"}`,
  2157. statusCode: http.StatusConflict,
  2158. mockParams: mockParams{
  2159. directoryManagerParams: directoryManagerParams{
  2160. createCategoryParams: createCategoryParams{
  2161. {
  2162. name: "the_category",
  2163. err: state.ErrKeywordCategoryExists,
  2164. },
  2165. },
  2166. },
  2167. },
  2168. },
  2169. {
  2170. name: "runtime error",
  2171. body: `{"name":"the_category"}`,
  2172. want: `{"message":"internal server error"}`,
  2173. statusCode: http.StatusInternalServerError,
  2174. mockParams: mockParams{
  2175. directoryManagerParams: directoryManagerParams{
  2176. createCategoryParams: createCategoryParams{
  2177. {
  2178. name: "the_category",
  2179. err: errors.New("error creating category"),
  2180. },
  2181. },
  2182. },
  2183. },
  2184. },
  2185. {
  2186. name: "bad input",
  2187. body: `{"name":"the_category"`,
  2188. want: `{"message":"malformed input"}`,
  2189. statusCode: http.StatusBadRequest,
  2190. mockParams: mockParams{
  2191. directoryManagerParams: directoryManagerParams{
  2192. createCategoryParams: createCategoryParams{},
  2193. },
  2194. },
  2195. },
  2196. {
  2197. name: "successful creation",
  2198. body: `{"name":"the_category"}`,
  2199. want: `{"id":1,"name":"the_category"}`,
  2200. statusCode: http.StatusCreated,
  2201. mockParams: mockParams{
  2202. directoryManagerParams: directoryManagerParams{
  2203. createCategoryParams: createCategoryParams{
  2204. {
  2205. name: "the_category",
  2206. result: state.Category{
  2207. ID: 1,
  2208. Name: "the_category",
  2209. },
  2210. },
  2211. },
  2212. },
  2213. },
  2214. },
  2215. }
  2216. for _, tc := range tt {
  2217. t.Run(tc.name, func(t *testing.T) {
  2218. request := httptest.NewRequest(http.MethodPost, "/directory/category", strings.NewReader(tc.body))
  2219. responseRecorder := httptest.NewRecorder()
  2220. directoryManager := newMockDirectoryManager(t)
  2221. for _, params := range tc.mockParams.createCategoryParams {
  2222. directoryManager.EXPECT().
  2223. CreateCategory(matchContext(), params.name).
  2224. Return(params.result, params.err)
  2225. }
  2226. postDirectoryCategoryHandler(responseRecorder, request, directoryManager, slog.Default())
  2227. if responseRecorder.Code != tc.statusCode {
  2228. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  2229. }
  2230. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  2231. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  2232. }
  2233. })
  2234. }
  2235. }
  2236. func TestDirectoryKeywordHandler_POST(t *testing.T) {
  2237. tt := []struct {
  2238. name string
  2239. body string
  2240. want string
  2241. statusCode int
  2242. mockParams mockParams
  2243. }{
  2244. {
  2245. name: "keyword already exists",
  2246. body: `{"category_id":1,"name":"the_keyword"}`,
  2247. want: `{"message":"keyword already exists"}`,
  2248. statusCode: http.StatusConflict,
  2249. mockParams: mockParams{
  2250. directoryManagerParams: directoryManagerParams{
  2251. createKeywordParams: createKeywordParams{
  2252. {
  2253. name: "the_keyword",
  2254. categoryID: 1,
  2255. err: state.ErrKeywordExists,
  2256. },
  2257. },
  2258. },
  2259. },
  2260. },
  2261. {
  2262. name: "category not found",
  2263. body: `{"category_id":1,"name":"the_keyword"}`,
  2264. want: `{"message":"category not found"}`,
  2265. statusCode: http.StatusNotFound,
  2266. mockParams: mockParams{
  2267. directoryManagerParams: directoryManagerParams{
  2268. createKeywordParams: createKeywordParams{
  2269. {
  2270. name: "the_keyword",
  2271. categoryID: 1,
  2272. err: state.ErrKeywordCategoryNotFound,
  2273. },
  2274. },
  2275. },
  2276. },
  2277. },
  2278. {
  2279. name: "runtime error",
  2280. body: `{"category_id":1,"name":"the_keyword"}`,
  2281. want: `{"message":"internal server error"}`,
  2282. statusCode: http.StatusInternalServerError,
  2283. mockParams: mockParams{
  2284. directoryManagerParams: directoryManagerParams{
  2285. createKeywordParams: createKeywordParams{
  2286. {
  2287. name: "the_keyword",
  2288. categoryID: 1,
  2289. err: errors.New("error creating keyword"),
  2290. },
  2291. },
  2292. },
  2293. },
  2294. },
  2295. {
  2296. name: "bad input",
  2297. body: `{"category_id":1,"name":"the_keyword"`,
  2298. want: `{"message":"malformed input"}`,
  2299. statusCode: http.StatusBadRequest,
  2300. mockParams: mockParams{
  2301. directoryManagerParams: directoryManagerParams{
  2302. createKeywordParams: createKeywordParams{},
  2303. },
  2304. },
  2305. },
  2306. {
  2307. name: "successful creation",
  2308. body: `{"category_id":1,"name":"the_keyword"}`,
  2309. want: `{"id":1,"name":"the_keyword"}`,
  2310. statusCode: http.StatusCreated,
  2311. mockParams: mockParams{
  2312. directoryManagerParams: directoryManagerParams{
  2313. createKeywordParams: createKeywordParams{
  2314. {
  2315. name: "the_keyword",
  2316. categoryID: 1,
  2317. result: state.Keyword{
  2318. ID: 1,
  2319. Name: "the_keyword",
  2320. },
  2321. },
  2322. },
  2323. },
  2324. },
  2325. },
  2326. }
  2327. for _, tc := range tt {
  2328. t.Run(tc.name, func(t *testing.T) {
  2329. request := httptest.NewRequest(http.MethodPost, "/directory/keyword", strings.NewReader(tc.body))
  2330. responseRecorder := httptest.NewRecorder()
  2331. directoryManager := newMockDirectoryManager(t)
  2332. for _, params := range tc.mockParams.createKeywordParams {
  2333. directoryManager.EXPECT().
  2334. CreateKeyword(matchContext(), params.name, params.categoryID).
  2335. Return(params.result, params.err)
  2336. }
  2337. postDirectoryKeywordHandler(responseRecorder, request, directoryManager, slog.Default())
  2338. if responseRecorder.Code != tc.statusCode {
  2339. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  2340. }
  2341. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  2342. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  2343. }
  2344. })
  2345. }
  2346. }
  2347. func TestDirectoryKeywordHandler_DELETE(t *testing.T) {
  2348. tt := []struct {
  2349. name string
  2350. categoryID int
  2351. want string
  2352. statusCode int
  2353. mockParams mockParams
  2354. }{
  2355. {
  2356. name: "keyword not found",
  2357. categoryID: 1,
  2358. want: `{"message":"keyword not found"}`,
  2359. statusCode: http.StatusNotFound,
  2360. mockParams: mockParams{
  2361. directoryManagerParams: directoryManagerParams{
  2362. deleteKeywordParams: deleteKeywordParams{
  2363. {
  2364. id: 1,
  2365. err: state.ErrKeywordNotFound,
  2366. },
  2367. },
  2368. },
  2369. },
  2370. },
  2371. {
  2372. name: "keyword in use by user",
  2373. categoryID: 1,
  2374. want: `{"message":"can't delete because category in use by a user"}`,
  2375. statusCode: http.StatusConflict,
  2376. mockParams: mockParams{
  2377. directoryManagerParams: directoryManagerParams{
  2378. deleteKeywordParams: deleteKeywordParams{
  2379. {
  2380. id: 1,
  2381. err: state.ErrKeywordInUse,
  2382. },
  2383. },
  2384. },
  2385. },
  2386. },
  2387. {
  2388. name: "runtime error",
  2389. categoryID: 1,
  2390. want: `{"message":"internal server error"}`,
  2391. statusCode: http.StatusInternalServerError,
  2392. mockParams: mockParams{
  2393. directoryManagerParams: directoryManagerParams{
  2394. deleteKeywordParams: deleteKeywordParams{
  2395. {
  2396. id: 1,
  2397. err: errors.New("error deleting keyword"),
  2398. },
  2399. },
  2400. },
  2401. },
  2402. },
  2403. {
  2404. name: "successful deletion",
  2405. categoryID: 1,
  2406. want: ``,
  2407. statusCode: http.StatusNoContent,
  2408. mockParams: mockParams{
  2409. directoryManagerParams: directoryManagerParams{
  2410. deleteKeywordParams: deleteKeywordParams{
  2411. {
  2412. id: 1,
  2413. },
  2414. },
  2415. },
  2416. },
  2417. },
  2418. {
  2419. name: "invalid keyword ID",
  2420. categoryID: -1,
  2421. want: `{"message":"invalid keyword ID"}`,
  2422. statusCode: http.StatusBadRequest,
  2423. mockParams: mockParams{
  2424. directoryManagerParams: directoryManagerParams{
  2425. deleteKeywordParams: deleteKeywordParams{},
  2426. },
  2427. },
  2428. },
  2429. }
  2430. for _, tc := range tt {
  2431. t.Run(tc.name, func(t *testing.T) {
  2432. request := httptest.NewRequest(http.MethodDelete, fmt.Sprintf("/directory/keyword/%d", tc.categoryID), nil)
  2433. request.SetPathValue("id", fmt.Sprintf("%d", tc.categoryID))
  2434. responseRecorder := httptest.NewRecorder()
  2435. directoryManager := newMockDirectoryManager(t)
  2436. for _, params := range tc.mockParams.deleteKeywordParams {
  2437. directoryManager.EXPECT().
  2438. DeleteKeyword(matchContext(), params.id).
  2439. Return(params.err)
  2440. }
  2441. deleteDirectoryKeywordHandler(responseRecorder, request, directoryManager, slog.Default())
  2442. if responseRecorder.Code != tc.statusCode {
  2443. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  2444. }
  2445. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  2446. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  2447. }
  2448. })
  2449. }
  2450. }
  2451. func TestBARTByTypeHandler_GET(t *testing.T) {
  2452. tt := []struct {
  2453. name string
  2454. queryParams string
  2455. wantStatusCode int
  2456. wantResponse string
  2457. mockParams mockParams
  2458. }{
  2459. {
  2460. name: "success with items",
  2461. queryParams: "?type=1",
  2462. wantStatusCode: http.StatusOK,
  2463. wantResponse: `[{"hash":"2B000001E4","type":1},{"hash":"2B000001B7","type":1}]`,
  2464. mockParams: mockParams{
  2465. bartAssetManagerParams: bartAssetManagerParams{
  2466. listBARTItemsParams: listBARTItemsParams{
  2467. {
  2468. itemType: 1,
  2469. result: []state.BARTItem{
  2470. {Hash: "2B000001E4", Type: 1},
  2471. {Hash: "2B000001B7", Type: 1},
  2472. },
  2473. err: nil,
  2474. },
  2475. },
  2476. },
  2477. },
  2478. },
  2479. {
  2480. name: "success with empty list",
  2481. queryParams: "?type=2",
  2482. wantStatusCode: http.StatusOK,
  2483. wantResponse: `[]`,
  2484. mockParams: mockParams{
  2485. bartAssetManagerParams: bartAssetManagerParams{
  2486. listBARTItemsParams: listBARTItemsParams{
  2487. {
  2488. itemType: 2,
  2489. result: []state.BARTItem{},
  2490. err: nil,
  2491. },
  2492. },
  2493. },
  2494. },
  2495. },
  2496. {
  2497. name: "missing type parameter",
  2498. queryParams: "",
  2499. wantStatusCode: http.StatusBadRequest,
  2500. wantResponse: `{"message":"type query parameter is required"}`,
  2501. },
  2502. {
  2503. name: "invalid type parameter",
  2504. queryParams: "?type=invalid",
  2505. wantStatusCode: http.StatusBadRequest,
  2506. wantResponse: `{"message":"invalid type ID"}`,
  2507. },
  2508. {
  2509. name: "internal server error",
  2510. queryParams: "?type=1",
  2511. wantStatusCode: http.StatusInternalServerError,
  2512. wantResponse: `{"message":"internal server error"}`,
  2513. mockParams: mockParams{
  2514. bartAssetManagerParams: bartAssetManagerParams{
  2515. listBARTItemsParams: listBARTItemsParams{
  2516. {
  2517. itemType: 1,
  2518. result: nil,
  2519. err: errors.New("database error"),
  2520. },
  2521. },
  2522. },
  2523. },
  2524. },
  2525. }
  2526. for _, tc := range tt {
  2527. t.Run(tc.name, func(t *testing.T) {
  2528. request := httptest.NewRequest(http.MethodGet, "/bart"+tc.queryParams, nil)
  2529. responseRecorder := httptest.NewRecorder()
  2530. mockBARTManager := newMockBARTAssetManager(t)
  2531. for _, params := range tc.mockParams.bartAssetManagerParams.listBARTItemsParams {
  2532. mockBARTManager.EXPECT().
  2533. ListBARTItems(matchContext(), params.itemType).
  2534. Return(params.result, params.err)
  2535. }
  2536. getBARTByTypeHandler(responseRecorder, request, mockBARTManager, slog.Default())
  2537. assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
  2538. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  2539. })
  2540. }
  2541. }
  2542. func TestBARTHandler_GET(t *testing.T) {
  2543. tt := []struct {
  2544. name string
  2545. hash string
  2546. wantStatusCode int
  2547. wantResponse string
  2548. wantHeaders map[string]string
  2549. mockParams mockParams
  2550. }{
  2551. {
  2552. name: "success with valid hash",
  2553. hash: "2B000001E4",
  2554. wantStatusCode: http.StatusOK,
  2555. wantResponse: "binary data",
  2556. wantHeaders: map[string]string{"Content-Type": "application/octet-stream"},
  2557. mockParams: mockParams{
  2558. bartAssetManagerParams: bartAssetManagerParams{
  2559. bartItemParams: bartItemParams{
  2560. {
  2561. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2562. result: []byte("binary data"),
  2563. err: nil,
  2564. },
  2565. },
  2566. },
  2567. },
  2568. },
  2569. {
  2570. name: "missing hash parameter",
  2571. hash: "",
  2572. wantStatusCode: http.StatusBadRequest,
  2573. wantResponse: `{"message":"hash is required"}`,
  2574. },
  2575. {
  2576. name: "invalid hash format",
  2577. hash: "invalid-hex",
  2578. wantStatusCode: http.StatusBadRequest,
  2579. wantResponse: `{"message":"invalid hash format"}`,
  2580. },
  2581. {
  2582. name: "asset not found",
  2583. hash: "2B000001E4",
  2584. wantStatusCode: http.StatusNotFound,
  2585. wantResponse: `{"message":"BART asset not found"}`,
  2586. mockParams: mockParams{
  2587. bartAssetManagerParams: bartAssetManagerParams{
  2588. bartItemParams: bartItemParams{
  2589. {
  2590. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2591. result: []byte{},
  2592. err: nil,
  2593. },
  2594. },
  2595. },
  2596. },
  2597. },
  2598. {
  2599. name: "internal server error",
  2600. hash: "2B000001E4",
  2601. wantStatusCode: http.StatusInternalServerError,
  2602. wantResponse: `{"message":"internal server error"}`,
  2603. mockParams: mockParams{
  2604. bartAssetManagerParams: bartAssetManagerParams{
  2605. bartItemParams: bartItemParams{
  2606. {
  2607. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2608. result: nil,
  2609. err: errors.New("database error"),
  2610. },
  2611. },
  2612. },
  2613. },
  2614. },
  2615. }
  2616. for _, tc := range tt {
  2617. t.Run(tc.name, func(t *testing.T) {
  2618. request := httptest.NewRequest(http.MethodGet, "/bart/"+tc.hash, nil)
  2619. // Set the path value manually for testing
  2620. if tc.hash != "" {
  2621. request.SetPathValue("hash", tc.hash)
  2622. }
  2623. responseRecorder := httptest.NewRecorder()
  2624. mockBARTManager := newMockBARTAssetManager(t)
  2625. for _, params := range tc.mockParams.bartAssetManagerParams.bartItemParams {
  2626. mockBARTManager.EXPECT().
  2627. BARTItem(matchContext(), params.hash).
  2628. Return(params.result, params.err)
  2629. }
  2630. getBARTHandler(responseRecorder, request, mockBARTManager, slog.Default())
  2631. assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
  2632. if tc.wantHeaders != nil {
  2633. for key, value := range tc.wantHeaders {
  2634. assert.Equal(t, value, responseRecorder.Header().Get(key))
  2635. }
  2636. }
  2637. if tc.wantStatusCode == http.StatusOK {
  2638. assert.Equal(t, tc.wantResponse, responseRecorder.Body.String())
  2639. } else {
  2640. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  2641. }
  2642. })
  2643. }
  2644. }
  2645. func TestBARTHandler_POST(t *testing.T) {
  2646. tt := []struct {
  2647. name string
  2648. hash string
  2649. queryParams string
  2650. requestBody string
  2651. wantStatusCode int
  2652. wantResponse string
  2653. mockParams mockParams
  2654. }{
  2655. {
  2656. name: "success with valid data",
  2657. hash: "2B000001E4",
  2658. queryParams: "?type=1",
  2659. requestBody: "binary data",
  2660. wantStatusCode: http.StatusCreated,
  2661. wantResponse: `{"hash":"2b000001e4","type":1}`,
  2662. mockParams: mockParams{
  2663. bartAssetManagerParams: bartAssetManagerParams{
  2664. insertBARTItemParams: insertBARTItemParams{
  2665. {
  2666. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2667. blob: []byte("binary data"),
  2668. itemType: 1,
  2669. err: nil,
  2670. },
  2671. },
  2672. },
  2673. },
  2674. },
  2675. {
  2676. name: "missing hash parameter",
  2677. hash: "",
  2678. queryParams: "?type=1",
  2679. requestBody: "binary data",
  2680. wantStatusCode: http.StatusBadRequest,
  2681. wantResponse: `{"message":"hash path parameter is required"}`,
  2682. },
  2683. {
  2684. name: "invalid hash format",
  2685. hash: "invalid-hex",
  2686. queryParams: "?type=1",
  2687. requestBody: "binary data",
  2688. wantStatusCode: http.StatusBadRequest,
  2689. wantResponse: `{"message":"invalid hash format"}`,
  2690. },
  2691. {
  2692. name: "missing type parameter",
  2693. hash: "2B000001E4",
  2694. queryParams: "",
  2695. requestBody: "binary data",
  2696. wantStatusCode: http.StatusBadRequest,
  2697. wantResponse: `{"message":"type query parameter is required"}`,
  2698. },
  2699. {
  2700. name: "invalid type parameter",
  2701. hash: "2B000001E4",
  2702. queryParams: "?type=invalid",
  2703. requestBody: "binary data",
  2704. wantStatusCode: http.StatusBadRequest,
  2705. wantResponse: `{"message":"invalid type ID"}`,
  2706. },
  2707. {
  2708. name: "failed to read request body",
  2709. hash: "2B000001E4",
  2710. queryParams: "?type=1",
  2711. requestBody: "", // This will cause an error when reading
  2712. wantStatusCode: http.StatusBadRequest,
  2713. wantResponse: `{"message":"failed to read request body"}`,
  2714. },
  2715. {
  2716. name: "asset already exists",
  2717. hash: "2B000001E4",
  2718. queryParams: "?type=1",
  2719. requestBody: "binary data",
  2720. wantStatusCode: http.StatusConflict,
  2721. wantResponse: `{"message":"BART asset already exists"}`,
  2722. mockParams: mockParams{
  2723. bartAssetManagerParams: bartAssetManagerParams{
  2724. insertBARTItemParams: insertBARTItemParams{
  2725. {
  2726. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2727. blob: []byte("binary data"),
  2728. itemType: 1,
  2729. err: state.ErrBARTItemExists,
  2730. },
  2731. },
  2732. },
  2733. },
  2734. },
  2735. {
  2736. name: "internal server error",
  2737. hash: "2B000001E4",
  2738. queryParams: "?type=1",
  2739. requestBody: "binary data",
  2740. wantStatusCode: http.StatusInternalServerError,
  2741. wantResponse: `{"message":"internal server error"}`,
  2742. mockParams: mockParams{
  2743. bartAssetManagerParams: bartAssetManagerParams{
  2744. insertBARTItemParams: insertBARTItemParams{
  2745. {
  2746. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2747. blob: []byte("binary data"),
  2748. itemType: 1,
  2749. err: errors.New("database error"),
  2750. },
  2751. },
  2752. },
  2753. },
  2754. },
  2755. }
  2756. for _, tc := range tt {
  2757. t.Run(tc.name, func(t *testing.T) {
  2758. var requestBody io.Reader
  2759. if tc.requestBody != "" {
  2760. requestBody = strings.NewReader(tc.requestBody)
  2761. } else {
  2762. requestBody = &errorReader{}
  2763. }
  2764. request := httptest.NewRequest(http.MethodPost, "/bart/"+tc.hash+tc.queryParams, requestBody)
  2765. // Set the path value manually for testing
  2766. if tc.hash != "" {
  2767. request.SetPathValue("hash", tc.hash)
  2768. }
  2769. responseRecorder := httptest.NewRecorder()
  2770. mockBARTManager := newMockBARTAssetManager(t)
  2771. for _, params := range tc.mockParams.bartAssetManagerParams.insertBARTItemParams {
  2772. mockBARTManager.EXPECT().
  2773. InsertBARTItem(matchContext(), params.hash, params.blob, params.itemType).
  2774. Return(params.err)
  2775. }
  2776. postBARTHandler(responseRecorder, request, mockBARTManager, slog.Default())
  2777. assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
  2778. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  2779. })
  2780. }
  2781. }
  2782. func TestBARTHandler_DELETE(t *testing.T) {
  2783. tt := []struct {
  2784. name string
  2785. hash string
  2786. wantStatusCode int
  2787. wantResponse string
  2788. mockParams mockParams
  2789. }{
  2790. {
  2791. name: "success with valid hash",
  2792. hash: "2B000001E4",
  2793. wantStatusCode: http.StatusOK,
  2794. wantResponse: `{"message":"BART asset deleted successfully."}`,
  2795. mockParams: mockParams{
  2796. bartAssetManagerParams: bartAssetManagerParams{
  2797. deleteBARTItemParams: deleteBARTItemParams{
  2798. {
  2799. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2800. err: nil,
  2801. },
  2802. },
  2803. },
  2804. },
  2805. },
  2806. {
  2807. name: "missing hash parameter",
  2808. hash: "",
  2809. wantStatusCode: http.StatusBadRequest,
  2810. wantResponse: `{"message":"hash path parameter is required"}`,
  2811. },
  2812. {
  2813. name: "invalid hash format",
  2814. hash: "invalid-hex",
  2815. wantStatusCode: http.StatusBadRequest,
  2816. wantResponse: `{"message":"invalid hash format"}`,
  2817. },
  2818. {
  2819. name: "asset not found",
  2820. hash: "2B000001E4",
  2821. wantStatusCode: http.StatusNotFound,
  2822. wantResponse: `{"message":"BART asset not found"}`,
  2823. mockParams: mockParams{
  2824. bartAssetManagerParams: bartAssetManagerParams{
  2825. deleteBARTItemParams: deleteBARTItemParams{
  2826. {
  2827. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2828. err: state.ErrBARTItemNotFound,
  2829. },
  2830. },
  2831. },
  2832. },
  2833. },
  2834. {
  2835. name: "internal server error",
  2836. hash: "2B000001E4",
  2837. wantStatusCode: http.StatusInternalServerError,
  2838. wantResponse: `{"message":"internal server error"}`,
  2839. mockParams: mockParams{
  2840. bartAssetManagerParams: bartAssetManagerParams{
  2841. deleteBARTItemParams: deleteBARTItemParams{
  2842. {
  2843. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2844. err: errors.New("database error"),
  2845. },
  2846. },
  2847. },
  2848. },
  2849. },
  2850. }
  2851. for _, tc := range tt {
  2852. t.Run(tc.name, func(t *testing.T) {
  2853. request := httptest.NewRequest(http.MethodDelete, "/bart/"+tc.hash, nil)
  2854. // Set the path value manually for testing
  2855. if tc.hash != "" {
  2856. request.SetPathValue("hash", tc.hash)
  2857. }
  2858. responseRecorder := httptest.NewRecorder()
  2859. mockBARTManager := newMockBARTAssetManager(t)
  2860. for _, params := range tc.mockParams.bartAssetManagerParams.deleteBARTItemParams {
  2861. mockBARTManager.EXPECT().
  2862. DeleteBARTItem(matchContext(), params.hash).
  2863. Return(params.err)
  2864. }
  2865. deleteBARTHandler(responseRecorder, request, mockBARTManager, slog.Default())
  2866. assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
  2867. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  2868. })
  2869. }
  2870. }
  2871. // errorReader is a helper type that always returns an error when reading
  2872. type errorReader struct{}
  2873. func (er *errorReader) Read(p []byte) (n int, err error) {
  2874. return 0, errors.New("read error")
  2875. }
  2876. func TestFeedbagBuddyHandler_GET(t *testing.T) {
  2877. tt := []struct {
  2878. name string
  2879. screenName string
  2880. wantStatusCode int
  2881. wantResponse string
  2882. mockParams mockParams
  2883. }{
  2884. {
  2885. name: "empty feedbag",
  2886. screenName: "userA",
  2887. wantStatusCode: http.StatusNotFound,
  2888. wantResponse: `{"message":"feedbag not found"}`,
  2889. mockParams: mockParams{
  2890. feedbagManagerParams: feedbagManagerParams{
  2891. feedbagParams: feedbagParams{
  2892. {
  2893. screenName: state.NewIdentScreenName("userA"),
  2894. result: []wire.FeedbagItem{},
  2895. err: nil,
  2896. },
  2897. },
  2898. },
  2899. },
  2900. },
  2901. {
  2902. name: "feedbag with buddies in groups",
  2903. screenName: "userA",
  2904. wantStatusCode: http.StatusOK,
  2905. wantResponse: `[{"group_id":1,"group_name":"Friends","buddies":[{"name":"buddy1","item_id":10},{"name":"buddy2","item_id":11}]},{"group_id":2,"group_name":"Work","buddies":[{"name":"buddy3","item_id":20}]}]`,
  2906. mockParams: mockParams{
  2907. feedbagManagerParams: feedbagManagerParams{
  2908. feedbagParams: feedbagParams{
  2909. {
  2910. screenName: state.NewIdentScreenName("userA"),
  2911. result: []wire.FeedbagItem{
  2912. {
  2913. ItemID: 0,
  2914. ClassID: wire.FeedbagClassIdGroup,
  2915. Name: "",
  2916. GroupID: 0,
  2917. },
  2918. {
  2919. ItemID: 1,
  2920. ClassID: wire.FeedbagClassIdGroup,
  2921. Name: "Friends",
  2922. GroupID: 1,
  2923. },
  2924. {
  2925. ItemID: 2,
  2926. ClassID: wire.FeedbagClassIdGroup,
  2927. Name: "Work",
  2928. GroupID: 2,
  2929. },
  2930. {
  2931. ItemID: 10,
  2932. ClassID: wire.FeedbagClassIdBuddy,
  2933. Name: "buddy1",
  2934. GroupID: 1,
  2935. },
  2936. {
  2937. ItemID: 11,
  2938. ClassID: wire.FeedbagClassIdBuddy,
  2939. Name: "buddy2",
  2940. GroupID: 1,
  2941. },
  2942. {
  2943. ItemID: 20,
  2944. ClassID: wire.FeedbagClassIdBuddy,
  2945. Name: "buddy3",
  2946. GroupID: 2,
  2947. },
  2948. },
  2949. err: nil,
  2950. },
  2951. },
  2952. },
  2953. },
  2954. },
  2955. {
  2956. name: "feedbag with no groups (besides root)",
  2957. screenName: "userA",
  2958. wantStatusCode: http.StatusOK,
  2959. wantResponse: `[]`,
  2960. mockParams: mockParams{
  2961. feedbagManagerParams: feedbagManagerParams{
  2962. feedbagParams: feedbagParams{
  2963. {
  2964. screenName: state.NewIdentScreenName("userA"),
  2965. result: []wire.FeedbagItem{
  2966. {
  2967. ItemID: 0,
  2968. ClassID: wire.FeedbagClassIdGroup,
  2969. Name: "",
  2970. GroupID: 0,
  2971. },
  2972. },
  2973. err: nil,
  2974. },
  2975. },
  2976. },
  2977. },
  2978. // Note: Root groups (GroupID == 0) are skipped by the implementation,
  2979. // so the response will be an empty array []
  2980. },
  2981. {
  2982. name: "missing screen_name",
  2983. screenName: "",
  2984. wantStatusCode: http.StatusBadRequest,
  2985. wantResponse: `{"message":"screen_name is required"}`,
  2986. },
  2987. {
  2988. name: "internal server error",
  2989. screenName: "userA",
  2990. wantStatusCode: http.StatusInternalServerError,
  2991. wantResponse: `{"message":"internal server error"}`,
  2992. mockParams: mockParams{
  2993. feedbagManagerParams: feedbagManagerParams{
  2994. feedbagParams: feedbagParams{
  2995. {
  2996. screenName: state.NewIdentScreenName("userA"),
  2997. result: nil,
  2998. err: errors.New("database error"),
  2999. },
  3000. },
  3001. },
  3002. },
  3003. },
  3004. }
  3005. for _, tc := range tt {
  3006. t.Run(tc.name, func(t *testing.T) {
  3007. request := httptest.NewRequest(http.MethodGet, "/feedbag/"+tc.screenName+"/group", nil)
  3008. if tc.screenName != "" {
  3009. request.SetPathValue("screen_name", tc.screenName)
  3010. }
  3011. responseRecorder := httptest.NewRecorder()
  3012. feedbagManager := newMockFeedbagManager(t)
  3013. for _, params := range tc.mockParams.feedbagManagerParams.feedbagParams {
  3014. feedbagManager.EXPECT().
  3015. Feedbag(matchContext(), params.screenName).
  3016. Return(params.result, params.err)
  3017. }
  3018. getFeedbagBuddyHandler(responseRecorder, request, feedbagManager, slog.Default())
  3019. assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
  3020. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  3021. })
  3022. }
  3023. }
  3024. func TestFeedbagBuddyHandler_PUT(t *testing.T) {
  3025. tt := []struct {
  3026. name string
  3027. screenName string
  3028. groupID string
  3029. requestBody string
  3030. wantStatusCode int
  3031. wantResponse string
  3032. mockParams mockParams
  3033. }{
  3034. {
  3035. name: "add a buddy to an empty group, user not signed in",
  3036. screenName: "userA",
  3037. groupID: "1",
  3038. requestBody: `{"name":"newbuddy"}`,
  3039. wantStatusCode: http.StatusOK,
  3040. wantResponse: `{"name":"newbuddy","group_id":1,"item_id":1000}`,
  3041. mockParams: mockParams{
  3042. feedbagManagerParams: feedbagManagerParams{
  3043. feedbagParams: feedbagParams{
  3044. {
  3045. screenName: state.NewIdentScreenName("userA"),
  3046. result: []wire.FeedbagItem{
  3047. {
  3048. ClassID: wire.FeedbagClassIdGroup,
  3049. Name: "Friends",
  3050. GroupID: 1,
  3051. },
  3052. },
  3053. err: nil,
  3054. },
  3055. },
  3056. feedbagUpsertParams: feedbagUpsertParams{
  3057. {
  3058. screenName: state.NewIdentScreenName("userA"),
  3059. items: []wire.FeedbagItem{
  3060. {
  3061. Name: "newbuddy",
  3062. GroupID: 1,
  3063. ItemID: 1000,
  3064. ClassID: wire.FeedbagClassIdBuddy,
  3065. },
  3066. {
  3067. ClassID: wire.FeedbagClassIdGroup,
  3068. Name: "Friends",
  3069. GroupID: 1,
  3070. TLVLBlock: wire.TLVLBlock{
  3071. TLVList: wire.TLVList{
  3072. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1000}),
  3073. },
  3074. },
  3075. },
  3076. },
  3077. err: nil,
  3078. },
  3079. },
  3080. },
  3081. sessionRetrieverParams: sessionRetrieverParams{
  3082. retrieveSessionByNameParams: retrieveSessionByNameParams{
  3083. {
  3084. screenName: state.NewIdentScreenName("userA"),
  3085. result: state.NewSession(),
  3086. },
  3087. },
  3088. },
  3089. messageRelayerParams: messageRelayerParams{
  3090. relayToScreenNameParams: relayToScreenNameParams{
  3091. {
  3092. screenName: state.NewIdentScreenName("userA"),
  3093. msg: wire.SNACMessage{
  3094. Frame: wire.SNACFrame{
  3095. FoodGroup: wire.Feedbag,
  3096. SubGroup: wire.FeedbagInsertItem,
  3097. RequestID: wire.ReqIDFromServer,
  3098. },
  3099. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  3100. Items: []wire.FeedbagItem{
  3101. {
  3102. Name: "newbuddy",
  3103. GroupID: 1,
  3104. ItemID: 1000,
  3105. ClassID: wire.FeedbagClassIdBuddy,
  3106. },
  3107. },
  3108. },
  3109. },
  3110. },
  3111. {
  3112. screenName: state.NewIdentScreenName("userA"),
  3113. msg: wire.SNACMessage{
  3114. Frame: wire.SNACFrame{
  3115. FoodGroup: wire.Feedbag,
  3116. SubGroup: wire.FeedbagUpdateItem,
  3117. RequestID: wire.ReqIDFromServer,
  3118. },
  3119. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  3120. Items: []wire.FeedbagItem{
  3121. {
  3122. ClassID: wire.FeedbagClassIdGroup,
  3123. Name: "Friends",
  3124. GroupID: 1,
  3125. TLVLBlock: wire.TLVLBlock{
  3126. TLVList: wire.TLVList{
  3127. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1000}),
  3128. },
  3129. },
  3130. },
  3131. },
  3132. },
  3133. },
  3134. },
  3135. },
  3136. },
  3137. },
  3138. },
  3139. {
  3140. name: "add a buddy to a non-empty group, user not signed in",
  3141. screenName: "userA",
  3142. groupID: "1",
  3143. requestBody: `{"name":"newbuddy2"}`,
  3144. wantStatusCode: http.StatusOK,
  3145. wantResponse: `{"name":"newbuddy2","group_id":1,"item_id":1000}`,
  3146. mockParams: mockParams{
  3147. feedbagManagerParams: feedbagManagerParams{
  3148. feedbagParams: feedbagParams{
  3149. {
  3150. screenName: state.NewIdentScreenName("userA"),
  3151. result: []wire.FeedbagItem{
  3152. {
  3153. ClassID: wire.FeedbagClassIdGroup,
  3154. Name: "Friends",
  3155. GroupID: 1,
  3156. TLVLBlock: wire.TLVLBlock{
  3157. TLVList: wire.TLVList{
  3158. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{12345}),
  3159. },
  3160. },
  3161. },
  3162. {
  3163. ItemID: 12345,
  3164. ClassID: wire.FeedbagClassIdBuddy,
  3165. Name: "existingbuddy",
  3166. GroupID: 1,
  3167. },
  3168. },
  3169. err: nil,
  3170. },
  3171. },
  3172. feedbagUpsertParams: feedbagUpsertParams{
  3173. {
  3174. screenName: state.NewIdentScreenName("userA"),
  3175. items: []wire.FeedbagItem{
  3176. {
  3177. Name: "newbuddy2",
  3178. GroupID: 1,
  3179. ItemID: 1000,
  3180. ClassID: wire.FeedbagClassIdBuddy,
  3181. },
  3182. {
  3183. ClassID: wire.FeedbagClassIdGroup,
  3184. Name: "Friends",
  3185. GroupID: 1,
  3186. TLVLBlock: wire.TLVLBlock{
  3187. TLVList: wire.TLVList{
  3188. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{12345, 1000}),
  3189. },
  3190. },
  3191. },
  3192. },
  3193. err: nil,
  3194. },
  3195. },
  3196. },
  3197. sessionRetrieverParams: sessionRetrieverParams{
  3198. retrieveSessionByNameParams: retrieveSessionByNameParams{
  3199. {
  3200. screenName: state.NewIdentScreenName("userA"),
  3201. result: state.NewSession(),
  3202. },
  3203. },
  3204. },
  3205. messageRelayerParams: messageRelayerParams{
  3206. relayToScreenNameParams: relayToScreenNameParams{
  3207. {
  3208. screenName: state.NewIdentScreenName("userA"),
  3209. msg: wire.SNACMessage{
  3210. Frame: wire.SNACFrame{
  3211. FoodGroup: wire.Feedbag,
  3212. SubGroup: wire.FeedbagInsertItem,
  3213. RequestID: wire.ReqIDFromServer,
  3214. },
  3215. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  3216. Items: []wire.FeedbagItem{
  3217. {
  3218. Name: "newbuddy2",
  3219. GroupID: 1,
  3220. ItemID: 1000,
  3221. ClassID: wire.FeedbagClassIdBuddy,
  3222. },
  3223. },
  3224. },
  3225. },
  3226. },
  3227. {
  3228. screenName: state.NewIdentScreenName("userA"),
  3229. msg: wire.SNACMessage{
  3230. Frame: wire.SNACFrame{
  3231. FoodGroup: wire.Feedbag,
  3232. SubGroup: wire.FeedbagUpdateItem,
  3233. RequestID: wire.ReqIDFromServer,
  3234. },
  3235. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  3236. Items: []wire.FeedbagItem{
  3237. {
  3238. ClassID: wire.FeedbagClassIdGroup,
  3239. Name: "Friends",
  3240. GroupID: 1,
  3241. TLVLBlock: wire.TLVLBlock{
  3242. TLVList: wire.TLVList{
  3243. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{12345, 1000}),
  3244. },
  3245. },
  3246. },
  3247. },
  3248. },
  3249. },
  3250. },
  3251. },
  3252. },
  3253. },
  3254. },
  3255. {
  3256. name: "add a buddy that already exists in a group",
  3257. screenName: "userA",
  3258. groupID: "1",
  3259. requestBody: `{"name":"ExistingBuddy"}`,
  3260. wantStatusCode: http.StatusOK,
  3261. wantResponse: `{"name":"ExistingBuddy","group_id":1,"item_id":12345}`,
  3262. mockParams: mockParams{
  3263. feedbagManagerParams: feedbagManagerParams{
  3264. feedbagParams: feedbagParams{
  3265. {
  3266. screenName: state.NewIdentScreenName("userA"),
  3267. result: []wire.FeedbagItem{
  3268. {
  3269. ClassID: wire.FeedbagClassIdGroup,
  3270. Name: "Friends",
  3271. GroupID: 1,
  3272. TLVLBlock: wire.TLVLBlock{
  3273. TLVList: wire.TLVList{
  3274. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{12345}),
  3275. },
  3276. },
  3277. },
  3278. {
  3279. ItemID: 12345,
  3280. ClassID: wire.FeedbagClassIdBuddy,
  3281. Name: "existingbuddy",
  3282. GroupID: 1,
  3283. },
  3284. },
  3285. err: nil,
  3286. },
  3287. },
  3288. // No FeedbagUpsert should be called when buddy already exists
  3289. },
  3290. // No session retrieval or message relaying should occur
  3291. },
  3292. },
  3293. {
  3294. name: "add a buddy to an empty group, user signed in",
  3295. screenName: "userA",
  3296. groupID: "1",
  3297. requestBody: `{"name":"newbuddy"}`,
  3298. wantStatusCode: http.StatusOK,
  3299. wantResponse: `{"name":"newbuddy","group_id":1,"item_id":1000}`,
  3300. mockParams: mockParams{
  3301. feedbagManagerParams: feedbagManagerParams{
  3302. feedbagParams: feedbagParams{
  3303. {
  3304. screenName: state.NewIdentScreenName("userA"),
  3305. result: []wire.FeedbagItem{
  3306. {
  3307. ClassID: wire.FeedbagClassIdGroup,
  3308. Name: "Friends",
  3309. GroupID: 1,
  3310. },
  3311. },
  3312. err: nil,
  3313. },
  3314. },
  3315. feedbagUpsertParams: feedbagUpsertParams{
  3316. {
  3317. screenName: state.NewIdentScreenName("userA"),
  3318. items: []wire.FeedbagItem{
  3319. {
  3320. Name: "newbuddy",
  3321. GroupID: 1,
  3322. ItemID: 1000,
  3323. ClassID: wire.FeedbagClassIdBuddy,
  3324. },
  3325. {
  3326. ClassID: wire.FeedbagClassIdGroup,
  3327. Name: "Friends",
  3328. GroupID: 1,
  3329. TLVLBlock: wire.TLVLBlock{
  3330. TLVList: wire.TLVList{
  3331. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1000}),
  3332. },
  3333. },
  3334. },
  3335. },
  3336. err: nil,
  3337. },
  3338. },
  3339. },
  3340. sessionRetrieverParams: sessionRetrieverParams{
  3341. retrieveSessionByNameParams: retrieveSessionByNameParams{
  3342. {
  3343. screenName: state.NewIdentScreenName("userA"),
  3344. result: func() *state.Session {
  3345. sess := state.NewSession()
  3346. sess.SetIdentScreenName(state.NewIdentScreenName("userA"))
  3347. inst := sess.AddInstance()
  3348. inst.SetSignonComplete()
  3349. return sess
  3350. }(),
  3351. },
  3352. },
  3353. },
  3354. messageRelayerParams: messageRelayerParams{
  3355. relayToScreenNameParams: relayToScreenNameParams{
  3356. {
  3357. screenName: state.NewIdentScreenName("userA"),
  3358. msg: wire.SNACMessage{
  3359. Frame: wire.SNACFrame{
  3360. FoodGroup: wire.Feedbag,
  3361. SubGroup: wire.FeedbagInsertItem,
  3362. RequestID: wire.ReqIDFromServer,
  3363. },
  3364. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  3365. Items: []wire.FeedbagItem{
  3366. {
  3367. Name: "newbuddy",
  3368. GroupID: 1,
  3369. ItemID: 1000,
  3370. ClassID: wire.FeedbagClassIdBuddy,
  3371. },
  3372. },
  3373. },
  3374. },
  3375. },
  3376. {
  3377. screenName: state.NewIdentScreenName("userA"),
  3378. msg: wire.SNACMessage{
  3379. Frame: wire.SNACFrame{
  3380. FoodGroup: wire.Feedbag,
  3381. SubGroup: wire.FeedbagUpdateItem,
  3382. RequestID: wire.ReqIDFromServer,
  3383. },
  3384. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  3385. Items: []wire.FeedbagItem{
  3386. {
  3387. ClassID: wire.FeedbagClassIdGroup,
  3388. Name: "Friends",
  3389. GroupID: 1,
  3390. TLVLBlock: wire.TLVLBlock{
  3391. TLVList: wire.TLVList{
  3392. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1000}),
  3393. },
  3394. },
  3395. },
  3396. },
  3397. },
  3398. },
  3399. },
  3400. },
  3401. },
  3402. buddyBroadcasterParams: buddyBroadcasterParams{
  3403. broadcastVisibilityParams: broadcastVisibilityParams{
  3404. {
  3405. you: nil, // Not used in expectation, matched with mock.AnythingOfType
  3406. filter: []state.IdentScreenName{state.NewIdentScreenName("newbuddy")},
  3407. sendDepartures: false,
  3408. err: nil,
  3409. },
  3410. },
  3411. },
  3412. },
  3413. },
  3414. {
  3415. name: "invalid group_id - non-numeric",
  3416. screenName: "userA",
  3417. groupID: "invalid",
  3418. requestBody: `{"name":"buddy"}`,
  3419. wantStatusCode: http.StatusBadRequest,
  3420. wantResponse: `{"message":"invalid group_id"}`,
  3421. },
  3422. {
  3423. name: "invalid group_id - out of range",
  3424. screenName: "userA",
  3425. groupID: "99999",
  3426. requestBody: `{"name":"buddy"}`,
  3427. wantStatusCode: http.StatusBadRequest,
  3428. wantResponse: `{"message":"invalid group_id"}`,
  3429. },
  3430. {
  3431. name: "can't add buddies to root group",
  3432. screenName: "userA",
  3433. groupID: "0",
  3434. requestBody: `{"name":"buddy"}`,
  3435. wantStatusCode: http.StatusBadRequest,
  3436. wantResponse: `{"message":"can't add buddies to root group"}`,
  3437. },
  3438. {
  3439. name: "empty screen_name",
  3440. screenName: "",
  3441. groupID: "1",
  3442. requestBody: `{"name":"buddy"}`,
  3443. wantStatusCode: http.StatusBadRequest,
  3444. wantResponse: `{"message":"screen_name is required"}`,
  3445. },
  3446. {
  3447. name: "malformed JSON input",
  3448. screenName: "userA",
  3449. groupID: "1",
  3450. requestBody: `invalid json`,
  3451. wantStatusCode: http.StatusBadRequest,
  3452. wantResponse: `{"message":"buddy_screen_name is required"}`,
  3453. },
  3454. {
  3455. name: "empty name in request body",
  3456. screenName: "userA",
  3457. groupID: "1",
  3458. requestBody: `{"name":""}`,
  3459. wantStatusCode: http.StatusBadRequest,
  3460. wantResponse: `{"message":"buddy_screen_name is required"}`,
  3461. },
  3462. {
  3463. name: "missing name in request body",
  3464. screenName: "userA",
  3465. groupID: "1",
  3466. requestBody: `{}`,
  3467. wantStatusCode: http.StatusBadRequest,
  3468. wantResponse: `{"message":"buddy_screen_name is required"}`,
  3469. },
  3470. {
  3471. name: "invalid UIN - too low",
  3472. screenName: "userA",
  3473. groupID: "1",
  3474. requestBody: `{"name":"9999"}`,
  3475. wantStatusCode: http.StatusBadRequest,
  3476. wantResponse: `{"message":"invalid uin: uin must be a number in the range 10000-2147483646"}`,
  3477. },
  3478. {
  3479. name: "invalid UIN - too high",
  3480. screenName: "userA",
  3481. groupID: "1",
  3482. requestBody: `{"name":"2147483647"}`,
  3483. wantStatusCode: http.StatusBadRequest,
  3484. wantResponse: `{"message":"invalid uin: uin must be a number in the range 10000-2147483646"}`,
  3485. },
  3486. {
  3487. name: "invalid AIM handle - too short",
  3488. screenName: "userA",
  3489. groupID: "1",
  3490. requestBody: `{"name":"Us"}`,
  3491. wantStatusCode: http.StatusBadRequest,
  3492. wantResponse: `{"message":"invalid screen name: screen name must be between 3 and 16 characters"}`,
  3493. },
  3494. {
  3495. name: "invalid AIM handle - too long",
  3496. screenName: "userA",
  3497. groupID: "1",
  3498. requestBody: `{"name":"ThisIsAReallyLongScreenName"}`,
  3499. wantStatusCode: http.StatusBadRequest,
  3500. wantResponse: `{"message":"invalid screen name: screen name must be between 3 and 16 characters"}`,
  3501. },
  3502. {
  3503. name: "error retrieving feedbag",
  3504. screenName: "userA",
  3505. groupID: "1",
  3506. requestBody: `{"name":"buddy"}`,
  3507. wantStatusCode: http.StatusInternalServerError,
  3508. wantResponse: `{"message":"internal server error"}`,
  3509. mockParams: mockParams{
  3510. feedbagManagerParams: feedbagManagerParams{
  3511. feedbagParams: feedbagParams{
  3512. {
  3513. screenName: state.NewIdentScreenName("userA"),
  3514. result: nil,
  3515. err: errors.New("database error"),
  3516. },
  3517. },
  3518. },
  3519. },
  3520. },
  3521. {
  3522. name: "too many buddies in group - max 30",
  3523. screenName: "userA",
  3524. groupID: "1",
  3525. requestBody: `{"name":"newbuddy"}`,
  3526. wantStatusCode: http.StatusBadRequest,
  3527. wantResponse: `{"message":"too many buddies in group. max: 30"}`,
  3528. mockParams: mockParams{
  3529. feedbagManagerParams: feedbagManagerParams{
  3530. feedbagParams: feedbagParams{
  3531. {
  3532. screenName: state.NewIdentScreenName("userA"),
  3533. result: func() []wire.FeedbagItem {
  3534. items := []wire.FeedbagItem{
  3535. {
  3536. ClassID: wire.FeedbagClassIdGroup,
  3537. Name: "Friends",
  3538. GroupID: 1,
  3539. },
  3540. }
  3541. // Add 30 buddies to the group
  3542. for i := 1; i <= 30; i++ {
  3543. items = append(items, wire.FeedbagItem{
  3544. ItemID: uint16(i),
  3545. ClassID: wire.FeedbagClassIdBuddy,
  3546. Name: fmt.Sprintf("buddy%d", i),
  3547. GroupID: 1,
  3548. })
  3549. }
  3550. return items
  3551. }(),
  3552. err: nil,
  3553. },
  3554. },
  3555. },
  3556. },
  3557. },
  3558. {
  3559. name: "group not found",
  3560. screenName: "userA",
  3561. groupID: "999",
  3562. requestBody: `{"name":"buddy"}`,
  3563. wantStatusCode: http.StatusNotFound,
  3564. wantResponse: `{"message":"group not found"}`,
  3565. mockParams: mockParams{
  3566. feedbagManagerParams: feedbagManagerParams{
  3567. feedbagParams: feedbagParams{
  3568. {
  3569. screenName: state.NewIdentScreenName("userA"),
  3570. result: []wire.FeedbagItem{
  3571. {
  3572. ClassID: wire.FeedbagClassIdGroup,
  3573. Name: "Friends",
  3574. GroupID: 1,
  3575. },
  3576. },
  3577. err: nil,
  3578. },
  3579. },
  3580. },
  3581. },
  3582. },
  3583. {
  3584. name: "error inserting feedbag item",
  3585. screenName: "userA",
  3586. groupID: "1",
  3587. requestBody: `{"name":"buddy"}`,
  3588. wantStatusCode: http.StatusInternalServerError,
  3589. wantResponse: `{"message":"internal server error"}`,
  3590. mockParams: mockParams{
  3591. feedbagManagerParams: feedbagManagerParams{
  3592. feedbagParams: feedbagParams{
  3593. {
  3594. screenName: state.NewIdentScreenName("userA"),
  3595. result: []wire.FeedbagItem{
  3596. {
  3597. ClassID: wire.FeedbagClassIdGroup,
  3598. Name: "Friends",
  3599. GroupID: 1,
  3600. },
  3601. },
  3602. err: nil,
  3603. },
  3604. },
  3605. feedbagUpsertParams: feedbagUpsertParams{
  3606. {
  3607. screenName: state.NewIdentScreenName("userA"),
  3608. items: []wire.FeedbagItem{
  3609. {
  3610. Name: "buddy",
  3611. GroupID: 1,
  3612. ItemID: 1000,
  3613. ClassID: wire.FeedbagClassIdBuddy,
  3614. },
  3615. {
  3616. ClassID: wire.FeedbagClassIdGroup,
  3617. Name: "Friends",
  3618. GroupID: 1,
  3619. TLVLBlock: wire.TLVLBlock{
  3620. TLVList: wire.TLVList{
  3621. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1000}),
  3622. },
  3623. },
  3624. },
  3625. },
  3626. err: errors.New("database error"),
  3627. },
  3628. },
  3629. },
  3630. },
  3631. },
  3632. }
  3633. for _, tc := range tt {
  3634. t.Run(tc.name, func(t *testing.T) {
  3635. // Extract buddy name from requestBody JSON
  3636. var buddyName string
  3637. if tc.requestBody != "" {
  3638. var input struct {
  3639. Name string `json:"name"`
  3640. }
  3641. if err := json.Unmarshal([]byte(tc.requestBody), &input); err == nil {
  3642. buddyName = input.Name
  3643. }
  3644. }
  3645. request := httptest.NewRequest(http.MethodPut, "/feedbag/"+tc.screenName+"/group/"+tc.groupID+"/buddy/"+buddyName, nil)
  3646. if tc.screenName != "" {
  3647. request.SetPathValue("screen_name", tc.screenName)
  3648. }
  3649. if tc.groupID != "" {
  3650. request.SetPathValue("group_id", tc.groupID)
  3651. }
  3652. request.SetPathValue("buddy_screen_name", buddyName)
  3653. responseRecorder := httptest.NewRecorder()
  3654. feedbagManager := newMockFeedbagManager(t)
  3655. sessionRetriever := newMockSessionRetriever(t)
  3656. messageRelayer := newMockMessageRelayer(t)
  3657. buddyBroadcaster := newMockBuddyBroadcaster(t)
  3658. for _, params := range tc.mockParams.feedbagManagerParams.feedbagParams {
  3659. feedbagManager.EXPECT().
  3660. Feedbag(matchContext(), params.screenName).
  3661. Return(params.result, params.err)
  3662. }
  3663. for _, params := range tc.mockParams.feedbagManagerParams.feedbagUpsertParams {
  3664. feedbagManager.EXPECT().
  3665. FeedbagUpsert(matchContext(), params.screenName, params.items).
  3666. Return(params.err)
  3667. }
  3668. for _, params := range tc.mockParams.sessionRetrieverParams.retrieveSessionByNameParams {
  3669. sessionRetriever.EXPECT().
  3670. RetrieveSession(params.screenName).
  3671. Return(params.result)
  3672. }
  3673. for _, params := range tc.mockParams.messageRelayerParams.relayToScreenNameParams {
  3674. messageRelayer.EXPECT().
  3675. RelayToScreenName(matchContext(), params.screenName, params.msg)
  3676. }
  3677. for _, params := range tc.mockParams.buddyBroadcasterParams.broadcastVisibilityParams {
  3678. // Use mock.MatchedBy to match any SessionInstance, since we're mainly verifying filter and sendDepartures
  3679. buddyBroadcaster.EXPECT().
  3680. BroadcastVisibility(
  3681. matchContext(),
  3682. mock.AnythingOfType("*state.SessionInstance"),
  3683. params.filter,
  3684. params.sendDepartures,
  3685. ).
  3686. Return(params.err)
  3687. }
  3688. deterministicItemID := func(n int) int {
  3689. return 1000
  3690. }
  3691. putFeedbagBuddyHandler(responseRecorder, request, buddyBroadcaster, feedbagManager, sessionRetriever, messageRelayer, slog.Default(), deterministicItemID)
  3692. assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
  3693. if tc.wantStatusCode == http.StatusOK {
  3694. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  3695. } else {
  3696. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  3697. }
  3698. })
  3699. }
  3700. }
  3701. func TestFeedbagBuddyHandler_DELETE(t *testing.T) {
  3702. tt := []struct {
  3703. name string
  3704. screenName string
  3705. groupID string
  3706. requestBody string
  3707. wantStatusCode int
  3708. wantResponse string
  3709. mockParams mockParams
  3710. }{
  3711. {
  3712. name: "delete existing buddy, user not signed in",
  3713. screenName: "userA",
  3714. groupID: "1",
  3715. requestBody: `{"name":"buddy1"}`,
  3716. wantStatusCode: http.StatusNoContent,
  3717. mockParams: mockParams{
  3718. feedbagManagerParams: feedbagManagerParams{
  3719. feedbagParams: feedbagParams{
  3720. {
  3721. screenName: state.NewIdentScreenName("userA"),
  3722. result: []wire.FeedbagItem{
  3723. {
  3724. ItemID: 1,
  3725. ClassID: wire.FeedbagClassIdGroup,
  3726. Name: "Friends",
  3727. GroupID: 1,
  3728. },
  3729. {
  3730. ItemID: 10,
  3731. ClassID: wire.FeedbagClassIdBuddy,
  3732. Name: "buddy1",
  3733. GroupID: 1,
  3734. },
  3735. },
  3736. err: nil,
  3737. },
  3738. },
  3739. feedbagDeleteParams: feedbagDeleteParams{
  3740. {
  3741. screenName: state.NewIdentScreenName("userA"),
  3742. items: []wire.FeedbagItem{
  3743. {
  3744. ItemID: 10,
  3745. ClassID: wire.FeedbagClassIdBuddy,
  3746. Name: "buddy1",
  3747. GroupID: 1,
  3748. },
  3749. },
  3750. err: nil,
  3751. },
  3752. },
  3753. },
  3754. sessionRetrieverParams: sessionRetrieverParams{
  3755. retrieveSessionByNameParams: retrieveSessionByNameParams{
  3756. {
  3757. screenName: state.NewIdentScreenName("userA"),
  3758. result: state.NewSession(),
  3759. },
  3760. },
  3761. },
  3762. messageRelayerParams: messageRelayerParams{
  3763. relayToScreenNameParams: relayToScreenNameParams{
  3764. {
  3765. screenName: state.NewIdentScreenName("userA"),
  3766. msg: wire.SNACMessage{
  3767. Frame: wire.SNACFrame{
  3768. FoodGroup: wire.Feedbag,
  3769. SubGroup: wire.FeedbagDeleteItem,
  3770. RequestID: wire.ReqIDFromServer,
  3771. },
  3772. Body: wire.SNAC_0x13_0x0A_FeedbagDeleteItem{
  3773. Items: []wire.FeedbagItem{
  3774. {
  3775. ItemID: 10,
  3776. ClassID: wire.FeedbagClassIdBuddy,
  3777. Name: "buddy1",
  3778. GroupID: 1,
  3779. },
  3780. },
  3781. },
  3782. },
  3783. },
  3784. },
  3785. },
  3786. },
  3787. },
  3788. {
  3789. name: "delete existing buddy, user signed in",
  3790. screenName: "userA",
  3791. groupID: "1",
  3792. requestBody: `{"name":"buddy1"}`,
  3793. wantStatusCode: http.StatusNoContent,
  3794. mockParams: mockParams{
  3795. feedbagManagerParams: feedbagManagerParams{
  3796. feedbagParams: feedbagParams{
  3797. {
  3798. screenName: state.NewIdentScreenName("userA"),
  3799. result: []wire.FeedbagItem{
  3800. {
  3801. ItemID: 1,
  3802. ClassID: wire.FeedbagClassIdGroup,
  3803. Name: "Friends",
  3804. GroupID: 1,
  3805. },
  3806. {
  3807. ItemID: 10,
  3808. ClassID: wire.FeedbagClassIdBuddy,
  3809. Name: "buddy1",
  3810. GroupID: 1,
  3811. },
  3812. },
  3813. err: nil,
  3814. },
  3815. },
  3816. feedbagDeleteParams: feedbagDeleteParams{
  3817. {
  3818. screenName: state.NewIdentScreenName("userA"),
  3819. items: []wire.FeedbagItem{
  3820. {
  3821. ItemID: 10,
  3822. ClassID: wire.FeedbagClassIdBuddy,
  3823. Name: "buddy1",
  3824. GroupID: 1,
  3825. },
  3826. },
  3827. err: nil,
  3828. },
  3829. },
  3830. },
  3831. sessionRetrieverParams: sessionRetrieverParams{
  3832. retrieveSessionByNameParams: retrieveSessionByNameParams{
  3833. {
  3834. screenName: state.NewIdentScreenName("userA"),
  3835. result: func() *state.Session {
  3836. sess := state.NewSession()
  3837. sess.SetIdentScreenName(state.NewIdentScreenName("userA"))
  3838. inst := sess.AddInstance()
  3839. inst.SetSignonComplete()
  3840. return sess
  3841. }(),
  3842. },
  3843. },
  3844. },
  3845. messageRelayerParams: messageRelayerParams{
  3846. relayToScreenNameParams: relayToScreenNameParams{
  3847. {
  3848. screenName: state.NewIdentScreenName("userA"),
  3849. msg: wire.SNACMessage{
  3850. Frame: wire.SNACFrame{
  3851. FoodGroup: wire.Feedbag,
  3852. SubGroup: wire.FeedbagDeleteItem,
  3853. RequestID: wire.ReqIDFromServer,
  3854. },
  3855. Body: wire.SNAC_0x13_0x0A_FeedbagDeleteItem{
  3856. Items: []wire.FeedbagItem{
  3857. {
  3858. ItemID: 10,
  3859. ClassID: wire.FeedbagClassIdBuddy,
  3860. Name: "buddy1",
  3861. GroupID: 1,
  3862. },
  3863. },
  3864. },
  3865. },
  3866. },
  3867. },
  3868. },
  3869. buddyBroadcasterParams: buddyBroadcasterParams{
  3870. broadcastVisibilityParams: broadcastVisibilityParams{
  3871. {
  3872. you: nil, // Not used in expectation, matched with mock.AnythingOfType
  3873. filter: []state.IdentScreenName{state.NewIdentScreenName("buddy1")},
  3874. sendDepartures: true,
  3875. err: nil,
  3876. },
  3877. },
  3878. },
  3879. },
  3880. },
  3881. {
  3882. name: "delete buddy from a group with multiple buddies, user not signed in",
  3883. screenName: "userA",
  3884. groupID: "1",
  3885. requestBody: `{"name":"buddy1"}`,
  3886. wantStatusCode: http.StatusNoContent,
  3887. mockParams: mockParams{
  3888. feedbagManagerParams: feedbagManagerParams{
  3889. feedbagParams: feedbagParams{
  3890. {
  3891. screenName: state.NewIdentScreenName("userA"),
  3892. result: []wire.FeedbagItem{
  3893. {
  3894. ItemID: 1,
  3895. ClassID: wire.FeedbagClassIdGroup,
  3896. Name: "Friends",
  3897. GroupID: 1,
  3898. TLVLBlock: wire.TLVLBlock{
  3899. TLVList: wire.TLVList{
  3900. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{10, 20}),
  3901. },
  3902. },
  3903. },
  3904. {
  3905. ItemID: 10,
  3906. ClassID: wire.FeedbagClassIdBuddy,
  3907. Name: "buddy1",
  3908. GroupID: 1,
  3909. },
  3910. {
  3911. ItemID: 20,
  3912. ClassID: wire.FeedbagClassIdBuddy,
  3913. Name: "buddy2",
  3914. GroupID: 1,
  3915. },
  3916. },
  3917. err: nil,
  3918. },
  3919. },
  3920. feedbagDeleteParams: feedbagDeleteParams{
  3921. {
  3922. screenName: state.NewIdentScreenName("userA"),
  3923. items: []wire.FeedbagItem{
  3924. {
  3925. ItemID: 10,
  3926. ClassID: wire.FeedbagClassIdBuddy,
  3927. Name: "buddy1",
  3928. GroupID: 1,
  3929. },
  3930. },
  3931. err: nil,
  3932. },
  3933. },
  3934. },
  3935. sessionRetrieverParams: sessionRetrieverParams{
  3936. retrieveSessionByNameParams: retrieveSessionByNameParams{
  3937. {
  3938. screenName: state.NewIdentScreenName("userA"),
  3939. result: state.NewSession(),
  3940. },
  3941. },
  3942. },
  3943. messageRelayerParams: messageRelayerParams{
  3944. relayToScreenNameParams: relayToScreenNameParams{
  3945. {
  3946. screenName: state.NewIdentScreenName("userA"),
  3947. msg: wire.SNACMessage{
  3948. Frame: wire.SNACFrame{
  3949. FoodGroup: wire.Feedbag,
  3950. SubGroup: wire.FeedbagDeleteItem,
  3951. RequestID: wire.ReqIDFromServer,
  3952. },
  3953. Body: wire.SNAC_0x13_0x0A_FeedbagDeleteItem{
  3954. Items: []wire.FeedbagItem{
  3955. {
  3956. ItemID: 10,
  3957. ClassID: wire.FeedbagClassIdBuddy,
  3958. Name: "buddy1",
  3959. GroupID: 1,
  3960. },
  3961. },
  3962. },
  3963. },
  3964. },
  3965. },
  3966. },
  3967. },
  3968. },
  3969. {
  3970. name: "can't delete buddy from root group",
  3971. screenName: "userA",
  3972. groupID: "0",
  3973. requestBody: `{"name":"rootbuddy"}`,
  3974. wantStatusCode: http.StatusBadRequest,
  3975. wantResponse: `{"message":"can't add buddies to root group"}`,
  3976. },
  3977. {
  3978. name: "missing screen_name",
  3979. screenName: "",
  3980. groupID: "1",
  3981. requestBody: `{"name":"buddy"}`,
  3982. wantStatusCode: http.StatusBadRequest,
  3983. wantResponse: `{"message":"screen_name is required"}`,
  3984. },
  3985. {
  3986. name: "group not found",
  3987. screenName: "userA",
  3988. groupID: "999",
  3989. requestBody: `{"name":"buddy"}`,
  3990. wantStatusCode: http.StatusNotFound,
  3991. wantResponse: `{"message":"group not found"}`,
  3992. mockParams: mockParams{
  3993. feedbagManagerParams: feedbagManagerParams{
  3994. feedbagParams: feedbagParams{
  3995. {
  3996. screenName: state.NewIdentScreenName("userA"),
  3997. result: []wire.FeedbagItem{
  3998. {
  3999. ItemID: 1,
  4000. ClassID: wire.FeedbagClassIdGroup,
  4001. Name: "Friends",
  4002. GroupID: 0,
  4003. },
  4004. },
  4005. err: nil,
  4006. },
  4007. },
  4008. },
  4009. },
  4010. },
  4011. {
  4012. name: "invalid group_id",
  4013. screenName: "userA",
  4014. groupID: "invalid",
  4015. requestBody: `{"name":"buddy"}`,
  4016. wantStatusCode: http.StatusBadRequest,
  4017. wantResponse: `{"message":"invalid group_id"}`,
  4018. },
  4019. {
  4020. name: "malformed request body",
  4021. screenName: "userA",
  4022. groupID: "1",
  4023. requestBody: `invalid json`,
  4024. wantStatusCode: http.StatusBadRequest,
  4025. wantResponse: `{"message":"buddy_screen_name is required"}`,
  4026. },
  4027. {
  4028. name: "missing name in request body",
  4029. screenName: "userA",
  4030. groupID: "1",
  4031. requestBody: `{}`,
  4032. wantStatusCode: http.StatusBadRequest,
  4033. wantResponse: `{"message":"buddy_screen_name is required"}`,
  4034. },
  4035. {
  4036. name: "buddy not found",
  4037. screenName: "userA",
  4038. groupID: "1",
  4039. requestBody: `{"name":"nonexistent"}`,
  4040. wantStatusCode: http.StatusNotFound,
  4041. wantResponse: `{"message":"buddy not found"}`,
  4042. mockParams: mockParams{
  4043. feedbagManagerParams: feedbagManagerParams{
  4044. feedbagParams: feedbagParams{
  4045. {
  4046. screenName: state.NewIdentScreenName("userA"),
  4047. result: []wire.FeedbagItem{
  4048. {
  4049. ItemID: 1,
  4050. ClassID: wire.FeedbagClassIdGroup,
  4051. Name: "Friends",
  4052. GroupID: 1,
  4053. },
  4054. {
  4055. ItemID: 10,
  4056. ClassID: wire.FeedbagClassIdBuddy,
  4057. Name: "otherbuddy",
  4058. GroupID: 1,
  4059. },
  4060. },
  4061. err: nil,
  4062. },
  4063. },
  4064. },
  4065. },
  4066. },
  4067. {
  4068. name: "internal server error on feedbag retrieval",
  4069. screenName: "userA",
  4070. groupID: "1",
  4071. requestBody: `{"name":"buddy"}`,
  4072. wantStatusCode: http.StatusInternalServerError,
  4073. wantResponse: `{"message":"internal server error"}`,
  4074. mockParams: mockParams{
  4075. feedbagManagerParams: feedbagManagerParams{
  4076. feedbagParams: feedbagParams{
  4077. {
  4078. screenName: state.NewIdentScreenName("userA"),
  4079. result: nil,
  4080. err: errors.New("database error"),
  4081. },
  4082. },
  4083. },
  4084. },
  4085. },
  4086. {
  4087. name: "internal server error on delete",
  4088. screenName: "userA",
  4089. groupID: "1",
  4090. requestBody: `{"name":"buddy1"}`,
  4091. wantStatusCode: http.StatusInternalServerError,
  4092. wantResponse: `{"message":"internal server error"}`,
  4093. mockParams: mockParams{
  4094. feedbagManagerParams: feedbagManagerParams{
  4095. feedbagParams: feedbagParams{
  4096. {
  4097. screenName: state.NewIdentScreenName("userA"),
  4098. result: []wire.FeedbagItem{
  4099. {
  4100. ItemID: 1,
  4101. ClassID: wire.FeedbagClassIdGroup,
  4102. Name: "Friends",
  4103. GroupID: 1,
  4104. },
  4105. {
  4106. ItemID: 10,
  4107. ClassID: wire.FeedbagClassIdBuddy,
  4108. Name: "buddy1",
  4109. GroupID: 1,
  4110. },
  4111. },
  4112. err: nil,
  4113. },
  4114. },
  4115. feedbagDeleteParams: feedbagDeleteParams{
  4116. {
  4117. screenName: state.NewIdentScreenName("userA"),
  4118. items: []wire.FeedbagItem{
  4119. {
  4120. ItemID: 10,
  4121. ClassID: wire.FeedbagClassIdBuddy,
  4122. Name: "buddy1",
  4123. GroupID: 1,
  4124. },
  4125. },
  4126. err: errors.New("database error"),
  4127. },
  4128. },
  4129. },
  4130. },
  4131. },
  4132. }
  4133. for _, tc := range tt {
  4134. t.Run(tc.name, func(t *testing.T) {
  4135. // Extract buddy name from requestBody JSON
  4136. var buddyName string
  4137. if tc.requestBody != "" {
  4138. var input struct {
  4139. Name string `json:"name"`
  4140. }
  4141. if err := json.Unmarshal([]byte(tc.requestBody), &input); err == nil {
  4142. buddyName = input.Name
  4143. }
  4144. }
  4145. request := httptest.NewRequest(http.MethodDelete, "/feedbag/"+tc.screenName+"/group/"+tc.groupID+"/buddy/"+buddyName, nil)
  4146. if tc.screenName != "" {
  4147. request.SetPathValue("screen_name", tc.screenName)
  4148. }
  4149. if tc.groupID != "" {
  4150. request.SetPathValue("group_id", tc.groupID)
  4151. }
  4152. request.SetPathValue("buddy_screen_name", buddyName)
  4153. responseRecorder := httptest.NewRecorder()
  4154. feedbagManager := newMockFeedbagManager(t)
  4155. sessionRetriever := newMockSessionRetriever(t)
  4156. messageRelayer := newMockMessageRelayer(t)
  4157. buddyBroadcaster := newMockBuddyBroadcaster(t)
  4158. for _, params := range tc.mockParams.feedbagManagerParams.feedbagParams {
  4159. feedbagManager.EXPECT().
  4160. Feedbag(matchContext(), params.screenName).
  4161. Return(params.result, params.err)
  4162. }
  4163. for _, params := range tc.mockParams.feedbagManagerParams.feedbagDeleteParams {
  4164. feedbagManager.EXPECT().
  4165. FeedbagDelete(matchContext(), params.screenName, params.items).
  4166. Return(params.err)
  4167. }
  4168. for _, params := range tc.mockParams.sessionRetrieverParams.retrieveSessionByNameParams {
  4169. sessionRetriever.EXPECT().
  4170. RetrieveSession(params.screenName).
  4171. Return(params.result)
  4172. }
  4173. for _, params := range tc.mockParams.messageRelayerParams.relayToScreenNameParams {
  4174. messageRelayer.EXPECT().
  4175. RelayToScreenName(matchContext(), params.screenName, params.msg)
  4176. }
  4177. for _, params := range tc.mockParams.buddyBroadcasterParams.broadcastVisibilityParams {
  4178. buddyBroadcaster.EXPECT().
  4179. BroadcastVisibility(
  4180. matchContext(),
  4181. mock.AnythingOfType("*state.SessionInstance"),
  4182. params.filter,
  4183. params.sendDepartures,
  4184. ).
  4185. Return(params.err)
  4186. }
  4187. deleteFeedbagBuddyHandler(responseRecorder, request, buddyBroadcaster, feedbagManager, sessionRetriever, messageRelayer, slog.Default())
  4188. assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
  4189. if tc.wantResponse != "" {
  4190. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  4191. }
  4192. })
  4193. }
  4194. }
  4195. func TestRandItemID(t *testing.T) {
  4196. tt := []struct {
  4197. name string
  4198. randInt func(n int) int
  4199. items []wire.FeedbagItem
  4200. want uint16
  4201. description string
  4202. }{
  4203. {
  4204. name: "empty items list returns random ID",
  4205. randInt: func(n int) int {
  4206. return 1000
  4207. },
  4208. items: []wire.FeedbagItem{},
  4209. want: 1000,
  4210. description: "When no items exist, should return the random number generated",
  4211. },
  4212. {
  4213. name: "finds next available ID when starting ID conflicts with ItemID",
  4214. randInt: func(n int) int {
  4215. return 100
  4216. },
  4217. items: []wire.FeedbagItem{
  4218. {ItemID: 100, GroupID: 1},
  4219. {ItemID: 101, GroupID: 1},
  4220. },
  4221. want: 102,
  4222. description: "Should skip 100 and 101, return 102",
  4223. },
  4224. {
  4225. name: "finds next available ID when starting ID conflicts with GroupID",
  4226. randInt: func(n int) int {
  4227. return 50
  4228. },
  4229. items: []wire.FeedbagItem{
  4230. {ItemID: 1, GroupID: 50},
  4231. {ItemID: 2, GroupID: 51},
  4232. },
  4233. want: 52,
  4234. description: "Should skip 50 (GroupID) and 51 (GroupID), return 52",
  4235. },
  4236. {
  4237. name: "wraps around and skips 0 to find next available ID",
  4238. randInt: func(n int) int {
  4239. return math.MaxUint16 - 2
  4240. },
  4241. items: []wire.FeedbagItem{
  4242. {ItemID: math.MaxUint16 - 2, GroupID: 1},
  4243. {ItemID: math.MaxUint16 - 1, GroupID: 1},
  4244. {ItemID: math.MaxUint16, GroupID: 1},
  4245. },
  4246. want: 2,
  4247. description: "When wrapping around, skips 0 (always skipped) and 1 (if conflicts), returns 2",
  4248. },
  4249. {
  4250. name: "skips 0 when starting from 0 and finds next available",
  4251. randInt: func(n int) int {
  4252. return 0
  4253. },
  4254. items: []wire.FeedbagItem{},
  4255. want: 1,
  4256. description: "When starting from 0, skips 0 (always skipped) and returns 1",
  4257. },
  4258. {
  4259. name: "returns 0 when all IDs are taken",
  4260. randInt: func(n int) int {
  4261. return 100
  4262. },
  4263. items: func() []wire.FeedbagItem {
  4264. // Create items that cover all possible IDs
  4265. items := make([]wire.FeedbagItem, 0, math.MaxUint16+1)
  4266. for i := 0; i <= math.MaxUint16; i++ {
  4267. items = append(items, wire.FeedbagItem{
  4268. ItemID: uint16(i),
  4269. GroupID: uint16(i),
  4270. })
  4271. }
  4272. return items
  4273. }(),
  4274. want: 0,
  4275. description: "When all IDs are taken, should return 0",
  4276. },
  4277. {
  4278. name: "finds ID that conflicts with both ItemID and GroupID",
  4279. randInt: func(n int) int {
  4280. return 200
  4281. },
  4282. items: []wire.FeedbagItem{
  4283. {ItemID: 200, GroupID: 201},
  4284. {ItemID: 201, GroupID: 200},
  4285. },
  4286. want: 202,
  4287. description: "Should skip 200 (ItemID) and 201 (both ItemID and GroupID), return 202",
  4288. },
  4289. {
  4290. name: "finds available ID immediately when no conflicts",
  4291. randInt: func(n int) int {
  4292. return 500
  4293. },
  4294. items: []wire.FeedbagItem{
  4295. {ItemID: 100, GroupID: 1},
  4296. {ItemID: 200, GroupID: 2},
  4297. {ItemID: 300, GroupID: 3},
  4298. },
  4299. want: 500,
  4300. description: "When random ID has no conflicts, should return it immediately",
  4301. },
  4302. {
  4303. name: "handles single conflict and finds next",
  4304. randInt: func(n int) int {
  4305. return 42
  4306. },
  4307. items: []wire.FeedbagItem{
  4308. {ItemID: 42, GroupID: 1},
  4309. },
  4310. want: 43,
  4311. description: "Should skip 42 and return 43",
  4312. },
  4313. {
  4314. name: "finds ID before starting point when wrapping",
  4315. randInt: func(n int) int {
  4316. return 5
  4317. },
  4318. items: []wire.FeedbagItem{
  4319. {ItemID: 5, GroupID: 1},
  4320. {ItemID: 6, GroupID: 1},
  4321. {ItemID: 7, GroupID: 1},
  4322. },
  4323. want: 8,
  4324. description: "Should skip 5, 6, 7 and return 8",
  4325. },
  4326. }
  4327. for _, tc := range tt {
  4328. t.Run(tc.name, func(t *testing.T) {
  4329. got := randItemID(tc.randInt, tc.items)
  4330. if got != tc.want {
  4331. t.Errorf("randItemID() = %d, want %d. %s", got, tc.want, tc.description)
  4332. }
  4333. })
  4334. }
  4335. }