mgmt_api_test.go 170 KB

1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495969798991001011021031041051061071081091101111121131141151161171181191201211221231241251261271281291301311321331341351361371381391401411421431441451461471481491501511521531541551561571581591601611621631641651661671681691701711721731741751761771781791801811821831841851861871881891901911921931941951961971981992002012022032042052062072082092102112122132142152162172182192202212222232242252262272282292302312322332342352362372382392402412422432442452462472482492502512522532542552562572582592602612622632642652662672682692702712722732742752762772782792802812822832842852862872882892902912922932942952962972982993003013023033043053063073083093103113123133143153163173183193203213223233243253263273283293303313323333343353363373383393403413423433443453463473483493503513523533543553563573583593603613623633643653663673683693703713723733743753763773783793803813823833843853863873883893903913923933943953963973983994004014024034044054064074084094104114124134144154164174184194204214224234244254264274284294304314324334344354364374384394404414424434444454464474484494504514524534544554564574584594604614624634644654664674684694704714724734744754764774784794804814824834844854864874884894904914924934944954964974984995005015025035045055065075085095105115125135145155165175185195205215225235245255265275285295305315325335345355365375385395405415425435445455465475485495505515525535545555565575585595605615625635645655665675685695705715725735745755765775785795805815825835845855865875885895905915925935945955965975985996006016026036046056066076086096106116126136146156166176186196206216226236246256266276286296306316326336346356366376386396406416426436446456466476486496506516526536546556566576586596606616626636646656666676686696706716726736746756766776786796806816826836846856866876886896906916926936946956966976986997007017027037047057067077087097107117127137147157167177187197207217227237247257267277287297307317327337347357367377387397407417427437447457467477487497507517527537547557567577587597607617627637647657667677687697707717727737747757767777787797807817827837847857867877887897907917927937947957967977987998008018028038048058068078088098108118128138148158168178188198208218228238248258268278288298308318328338348358368378388398408418428438448458468478488498508518528538548558568578588598608618628638648658668678688698708718728738748758768778788798808818828838848858868878888898908918928938948958968978988999009019029039049059069079089099109119129139149159169179189199209219229239249259269279289299309319329339349359369379389399409419429439449459469479489499509519529539549559569579589599609619629639649659669679689699709719729739749759769779789799809819829839849859869879889899909919929939949959969979989991000100110021003100410051006100710081009101010111012101310141015101610171018101910201021102210231024102510261027102810291030103110321033103410351036103710381039104010411042104310441045104610471048104910501051105210531054105510561057105810591060106110621063106410651066106710681069107010711072107310741075107610771078107910801081108210831084108510861087108810891090109110921093109410951096109710981099110011011102110311041105110611071108110911101111111211131114111511161117111811191120112111221123112411251126112711281129113011311132113311341135113611371138113911401141114211431144114511461147114811491150115111521153115411551156115711581159116011611162116311641165116611671168116911701171117211731174117511761177117811791180118111821183118411851186118711881189119011911192119311941195119611971198119912001201120212031204120512061207120812091210121112121213121412151216121712181219122012211222122312241225122612271228122912301231123212331234123512361237123812391240124112421243124412451246124712481249125012511252125312541255125612571258125912601261126212631264126512661267126812691270127112721273127412751276127712781279128012811282128312841285128612871288128912901291129212931294129512961297129812991300130113021303130413051306130713081309131013111312131313141315131613171318131913201321132213231324132513261327132813291330133113321333133413351336133713381339134013411342134313441345134613471348134913501351135213531354135513561357135813591360136113621363136413651366136713681369137013711372137313741375137613771378137913801381138213831384138513861387138813891390139113921393139413951396139713981399140014011402140314041405140614071408140914101411141214131414141514161417141814191420142114221423142414251426142714281429143014311432143314341435143614371438143914401441144214431444144514461447144814491450145114521453145414551456145714581459146014611462146314641465146614671468146914701471147214731474147514761477147814791480148114821483148414851486148714881489149014911492149314941495149614971498149915001501150215031504150515061507150815091510151115121513151415151516151715181519152015211522152315241525152615271528152915301531153215331534153515361537153815391540154115421543154415451546154715481549155015511552155315541555155615571558155915601561156215631564156515661567156815691570157115721573157415751576157715781579158015811582158315841585158615871588158915901591159215931594159515961597159815991600160116021603160416051606160716081609161016111612161316141615161616171618161916201621162216231624162516261627162816291630163116321633163416351636163716381639164016411642164316441645164616471648164916501651165216531654165516561657165816591660166116621663166416651666166716681669167016711672167316741675167616771678167916801681168216831684168516861687168816891690169116921693169416951696169716981699170017011702170317041705170617071708170917101711171217131714171517161717171817191720172117221723172417251726172717281729173017311732173317341735173617371738173917401741174217431744174517461747174817491750175117521753175417551756175717581759176017611762176317641765176617671768176917701771177217731774177517761777177817791780178117821783178417851786178717881789179017911792179317941795179617971798179918001801180218031804180518061807180818091810181118121813181418151816181718181819182018211822182318241825182618271828182918301831183218331834183518361837183818391840184118421843184418451846184718481849185018511852185318541855185618571858185918601861186218631864186518661867186818691870187118721873187418751876187718781879188018811882188318841885188618871888188918901891189218931894189518961897189818991900190119021903190419051906190719081909191019111912191319141915191619171918191919201921192219231924192519261927192819291930193119321933193419351936193719381939194019411942194319441945194619471948194919501951195219531954195519561957195819591960196119621963196419651966196719681969197019711972197319741975197619771978197919801981198219831984198519861987198819891990199119921993199419951996199719981999200020012002200320042005200620072008200920102011201220132014201520162017201820192020202120222023202420252026202720282029203020312032203320342035203620372038203920402041204220432044204520462047204820492050205120522053205420552056205720582059206020612062206320642065206620672068206920702071207220732074207520762077207820792080208120822083208420852086208720882089209020912092209320942095209620972098209921002101210221032104210521062107210821092110211121122113211421152116211721182119212021212122212321242125212621272128212921302131213221332134213521362137213821392140214121422143214421452146214721482149215021512152215321542155215621572158215921602161216221632164216521662167216821692170217121722173217421752176217721782179218021812182218321842185218621872188218921902191219221932194219521962197219821992200220122022203220422052206220722082209221022112212221322142215221622172218221922202221222222232224222522262227222822292230223122322233223422352236223722382239224022412242224322442245224622472248224922502251225222532254225522562257225822592260226122622263226422652266226722682269227022712272227322742275227622772278227922802281228222832284228522862287228822892290229122922293229422952296229722982299230023012302230323042305230623072308230923102311231223132314231523162317231823192320232123222323232423252326232723282329233023312332233323342335233623372338233923402341234223432344234523462347234823492350235123522353235423552356235723582359236023612362236323642365236623672368236923702371237223732374237523762377237823792380238123822383238423852386238723882389239023912392239323942395239623972398239924002401240224032404240524062407240824092410241124122413241424152416241724182419242024212422242324242425242624272428242924302431243224332434243524362437243824392440244124422443244424452446244724482449245024512452245324542455245624572458245924602461246224632464246524662467246824692470247124722473247424752476247724782479248024812482248324842485248624872488248924902491249224932494249524962497249824992500250125022503250425052506250725082509251025112512251325142515251625172518251925202521252225232524252525262527252825292530253125322533253425352536253725382539254025412542254325442545254625472548254925502551255225532554255525562557255825592560256125622563256425652566256725682569257025712572257325742575257625772578257925802581258225832584258525862587258825892590259125922593259425952596259725982599260026012602260326042605260626072608260926102611261226132614261526162617261826192620262126222623262426252626262726282629263026312632263326342635263626372638263926402641264226432644264526462647264826492650265126522653265426552656265726582659266026612662266326642665266626672668266926702671267226732674267526762677267826792680268126822683268426852686268726882689269026912692269326942695269626972698269927002701270227032704270527062707270827092710271127122713271427152716271727182719272027212722272327242725272627272728272927302731273227332734273527362737273827392740274127422743274427452746274727482749275027512752275327542755275627572758275927602761276227632764276527662767276827692770277127722773277427752776277727782779278027812782278327842785278627872788278927902791279227932794279527962797279827992800280128022803280428052806280728082809281028112812281328142815281628172818281928202821282228232824282528262827282828292830283128322833283428352836283728382839284028412842284328442845284628472848284928502851285228532854285528562857285828592860286128622863286428652866286728682869287028712872287328742875287628772878287928802881288228832884288528862887288828892890289128922893289428952896289728982899290029012902290329042905290629072908290929102911291229132914291529162917291829192920292129222923292429252926292729282929293029312932293329342935293629372938293929402941294229432944294529462947294829492950295129522953295429552956295729582959296029612962296329642965296629672968296929702971297229732974297529762977297829792980298129822983298429852986298729882989299029912992299329942995299629972998299930003001300230033004300530063007300830093010301130123013301430153016301730183019302030213022302330243025302630273028302930303031303230333034303530363037303830393040304130423043304430453046304730483049305030513052305330543055305630573058305930603061306230633064306530663067306830693070307130723073307430753076307730783079308030813082308330843085308630873088308930903091309230933094309530963097309830993100310131023103310431053106310731083109311031113112311331143115311631173118311931203121312231233124312531263127312831293130313131323133313431353136313731383139314031413142314331443145314631473148314931503151315231533154315531563157315831593160316131623163316431653166316731683169317031713172317331743175317631773178317931803181318231833184318531863187318831893190319131923193319431953196319731983199320032013202320332043205320632073208320932103211321232133214321532163217321832193220322132223223322432253226322732283229323032313232323332343235323632373238323932403241324232433244324532463247324832493250325132523253325432553256325732583259326032613262326332643265326632673268326932703271327232733274327532763277327832793280328132823283328432853286328732883289329032913292329332943295329632973298329933003301330233033304330533063307330833093310331133123313331433153316331733183319332033213322332333243325332633273328332933303331333233333334333533363337333833393340334133423343334433453346334733483349335033513352335333543355335633573358335933603361336233633364336533663367336833693370337133723373337433753376337733783379338033813382338333843385338633873388338933903391339233933394339533963397339833993400340134023403340434053406340734083409341034113412341334143415341634173418341934203421342234233424342534263427342834293430343134323433343434353436343734383439344034413442344334443445344634473448344934503451345234533454345534563457345834593460346134623463346434653466346734683469347034713472347334743475347634773478347934803481348234833484348534863487348834893490349134923493349434953496349734983499350035013502350335043505350635073508350935103511351235133514351535163517351835193520352135223523352435253526352735283529353035313532353335343535353635373538353935403541354235433544354535463547354835493550355135523553355435553556355735583559356035613562356335643565356635673568356935703571357235733574357535763577357835793580358135823583358435853586358735883589359035913592359335943595359635973598359936003601360236033604360536063607360836093610361136123613361436153616361736183619362036213622362336243625362636273628362936303631363236333634363536363637363836393640364136423643364436453646364736483649365036513652365336543655365636573658365936603661366236633664366536663667366836693670367136723673367436753676367736783679368036813682368336843685368636873688368936903691369236933694369536963697369836993700370137023703370437053706370737083709371037113712371337143715371637173718371937203721372237233724372537263727372837293730373137323733373437353736373737383739374037413742374337443745374637473748374937503751375237533754375537563757375837593760376137623763376437653766376737683769377037713772377337743775377637773778377937803781378237833784378537863787378837893790379137923793379437953796379737983799380038013802380338043805380638073808380938103811381238133814381538163817381838193820382138223823382438253826382738283829383038313832383338343835383638373838383938403841384238433844384538463847384838493850385138523853385438553856385738583859386038613862386338643865386638673868386938703871387238733874387538763877387838793880388138823883388438853886388738883889389038913892389338943895389638973898389939003901390239033904390539063907390839093910391139123913391439153916391739183919392039213922392339243925392639273928392939303931393239333934393539363937393839393940394139423943394439453946394739483949395039513952395339543955395639573958395939603961396239633964396539663967396839693970397139723973397439753976397739783979398039813982398339843985398639873988398939903991399239933994399539963997399839994000400140024003400440054006400740084009401040114012401340144015401640174018401940204021402240234024402540264027402840294030403140324033403440354036403740384039404040414042404340444045404640474048404940504051405240534054405540564057405840594060406140624063406440654066406740684069407040714072407340744075407640774078407940804081408240834084408540864087408840894090409140924093409440954096409740984099410041014102410341044105410641074108410941104111411241134114411541164117411841194120412141224123412441254126412741284129413041314132413341344135413641374138413941404141414241434144414541464147414841494150415141524153415441554156415741584159416041614162416341644165416641674168416941704171417241734174417541764177417841794180418141824183418441854186418741884189419041914192419341944195419641974198419942004201420242034204420542064207420842094210421142124213421442154216421742184219422042214222422342244225422642274228422942304231423242334234423542364237423842394240424142424243424442454246424742484249425042514252425342544255425642574258425942604261426242634264426542664267426842694270427142724273427442754276427742784279428042814282428342844285428642874288428942904291429242934294429542964297429842994300430143024303430443054306430743084309431043114312431343144315431643174318431943204321432243234324432543264327432843294330433143324333433443354336433743384339434043414342434343444345434643474348434943504351435243534354435543564357435843594360436143624363436443654366436743684369437043714372437343744375437643774378437943804381438243834384438543864387438843894390439143924393439443954396439743984399440044014402440344044405440644074408440944104411441244134414441544164417441844194420442144224423442444254426442744284429443044314432443344344435443644374438443944404441444244434444444544464447444844494450445144524453445444554456445744584459446044614462446344644465446644674468446944704471447244734474447544764477447844794480448144824483448444854486448744884489449044914492449344944495449644974498449945004501450245034504450545064507450845094510451145124513451445154516451745184519452045214522452345244525452645274528452945304531453245334534453545364537453845394540454145424543454445454546454745484549455045514552455345544555455645574558455945604561456245634564456545664567456845694570457145724573457445754576457745784579458045814582458345844585458645874588458945904591459245934594459545964597459845994600460146024603460446054606460746084609461046114612461346144615461646174618461946204621462246234624462546264627462846294630463146324633463446354636463746384639464046414642464346444645464646474648464946504651465246534654465546564657465846594660466146624663466446654666466746684669467046714672467346744675467646774678467946804681468246834684468546864687468846894690469146924693469446954696469746984699470047014702470347044705470647074708470947104711471247134714471547164717471847194720472147224723472447254726472747284729473047314732473347344735473647374738473947404741474247434744474547464747474847494750475147524753475447554756475747584759476047614762476347644765476647674768476947704771477247734774477547764777477847794780478147824783478447854786478747884789479047914792479347944795479647974798479948004801480248034804480548064807480848094810481148124813481448154816481748184819482048214822482348244825482648274828482948304831483248334834483548364837483848394840484148424843484448454846484748484849485048514852485348544855485648574858485948604861486248634864486548664867486848694870487148724873487448754876487748784879488048814882488348844885488648874888488948904891489248934894489548964897489848994900490149024903490449054906490749084909491049114912491349144915491649174918491949204921492249234924492549264927492849294930493149324933493449354936493749384939494049414942494349444945494649474948494949504951495249534954495549564957495849594960496149624963496449654966496749684969497049714972497349744975497649774978497949804981498249834984498549864987498849894990499149924993499449954996499749984999500050015002500350045005500650075008500950105011501250135014501550165017501850195020502150225023502450255026502750285029503050315032503350345035503650375038503950405041504250435044504550465047504850495050505150525053505450555056505750585059506050615062506350645065506650675068506950705071507250735074507550765077507850795080508150825083508450855086508750885089509050915092509350945095509650975098509951005101510251035104510551065107510851095110511151125113511451155116511751185119512051215122512351245125512651275128512951305131513251335134513551365137513851395140514151425143514451455146514751485149515051515152515351545155515651575158515951605161516251635164516551665167516851695170517151725173517451755176517751785179518051815182518351845185518651875188518951905191519251935194519551965197519851995200520152025203520452055206520752085209521052115212521352145215521652175218521952205221522252235224522552265227522852295230523152325233523452355236523752385239524052415242524352445245524652475248524952505251525252535254525552565257525852595260526152625263526452655266526752685269527052715272527352745275527652775278527952805281528252835284528552865287528852895290529152925293529452955296529752985299530053015302530353045305530653075308530953105311531253135314531553165317531853195320532153225323532453255326532753285329533053315332533353345335533653375338533953405341534253435344534553465347534853495350535153525353535453555356535753585359536053615362536353645365536653675368536953705371537253735374537553765377537853795380538153825383538453855386538753885389539053915392539353945395539653975398539954005401540254035404540554065407540854095410541154125413541454155416541754185419542054215422542354245425542654275428542954305431543254335434543554365437543854395440544154425443544454455446544754485449545054515452545354545455545654575458545954605461546254635464546554665467546854695470547154725473547454755476547754785479548054815482548354845485548654875488548954905491549254935494549554965497549854995500550155025503550455055506550755085509551055115512551355145515551655175518551955205521552255235524552555265527552855295530553155325533553455355536553755385539554055415542554355445545554655475548554955505551555255535554555555565557555855595560556155625563556455655566556755685569557055715572557355745575557655775578557955805581558255835584558555865587558855895590559155925593559455955596559755985599560056015602560356045605560656075608560956105611561256135614561556165617561856195620562156225623562456255626562756285629563056315632563356345635563656375638563956405641564256435644564556465647564856495650565156525653565456555656565756585659566056615662566356645665566656675668566956705671567256735674567556765677567856795680568156825683568456855686568756885689569056915692569356945695569656975698569957005701570257035704570557065707570857095710571157125713571457155716571757185719572057215722572357245725572657275728572957305731573257335734573557365737573857395740574157425743574457455746574757485749575057515752575357545755575657575758575957605761576257635764576557665767576857695770577157725773577457755776577757785779578057815782578357845785578657875788578957905791579257935794579557965797579857995800580158025803580458055806580758085809581058115812581358145815581658175818581958205821582258235824582558265827582858295830583158325833583458355836583758385839584058415842584358445845584658475848584958505851585258535854585558565857585858595860586158625863586458655866586758685869587058715872587358745875587658775878587958805881588258835884588558865887588858895890589158925893589458955896589758985899590059015902590359045905590659075908590959105911591259135914
  1. package http
  2. import (
  3. "bytes"
  4. "context"
  5. "encoding/json"
  6. "errors"
  7. "fmt"
  8. "io"
  9. "log/slog"
  10. "math"
  11. "net/http"
  12. "net/http/httptest"
  13. "net/mail"
  14. "net/netip"
  15. "strings"
  16. "testing"
  17. "time"
  18. "github.com/stretchr/testify/assert"
  19. "github.com/stretchr/testify/mock"
  20. "github.com/mk6i/open-oscar-server/config"
  21. "github.com/mk6i/open-oscar-server/state"
  22. "github.com/mk6i/open-oscar-server/wire"
  23. )
  24. func TestSessionHandler_GET(t *testing.T) {
  25. // Fixed time for testing: 2024-01-01 12:00:00 UTC
  26. fixedNow := time.Date(2024, 1, 1, 12, 0, 0, 0, time.UTC)
  27. nowFn := func() time.Time { return fixedNow }
  28. tt := []struct {
  29. name string
  30. want string
  31. statusCode int
  32. createSessions func() []*state.Session
  33. }{
  34. {
  35. name: "without sessions",
  36. want: `{"count":0,"sessions":[]}`,
  37. statusCode: http.StatusOK,
  38. createSessions: func() []*state.Session {
  39. return []*state.Session{}
  40. },
  41. },
  42. {
  43. name: "with sessions",
  44. want: `{"count":3,"sessions":[{"id":"usera","screen_name":"userA","online_seconds":100,"is_away":false,"away_message":"","idle_seconds":0,"is_invisible":false,"is_icq":false,"instance_count":2,"instances":[{"num":1,"idle_seconds":30,"is_away":false,"away_message":"","is_invisible":false,"remote_addr":"1.2.3.4","remote_port":1234,"client_id":"AOL Instant Messenger, version 5.9.3702/WIN32"},{"num":2,"idle_seconds":0,"is_away":false,"away_message":"","is_invisible":true,"remote_addr":"5.6.7.8","remote_port":5678,"client_id":""}]},{"id":"userb","screen_name":"userB","online_seconds":200,"is_away":false,"away_message":"","idle_seconds":0,"is_invisible":true,"is_icq":false,"instance_count":2,"instances":[{"num":1,"idle_seconds":0,"is_away":false,"away_message":"","is_invisible":true,"remote_addr":"9.10.11.12","remote_port":9012,"client_id":"AOL Instant Messenger (SM), version 4.8.2790/WIN32"},{"num":2,"idle_seconds":0,"is_away":false,"away_message":"","is_invisible":true,"remote_addr":"13.14.15.16","remote_port":1314,"client_id":"WebAIM"}]},{"id":"100003","screen_name":"100003","online_seconds":300,"is_away":false,"away_message":"","idle_seconds":0,"is_invisible":false,"is_icq":true,"instance_count":1,"instances":[{"num":1,"idle_seconds":0,"is_away":false,"away_message":"","is_invisible":false,"remote_addr":"1.2.3.4","remote_port":1234,"client_id":"ICQBasic"}]}]}`,
  45. statusCode: http.StatusOK,
  46. createSessions: func() []*state.Session {
  47. // userA: 2 instances - one idle (30s), one invisible
  48. userA := state.NewSession()
  49. userA.SetIdentScreenName(state.NewIdentScreenName("userA"))
  50. userA.SetDisplayScreenName(state.DisplayScreenName("userA"))
  51. userA.SetUIN(0)
  52. userA.SetNowFn(nowFn)
  53. userA.SetSignonTime(fixedNow.Add(-100 * time.Second))
  54. inst1 := userA.AddInstance()
  55. inst1.SetSignonComplete()
  56. inst1.SetIdle(30 * time.Second)
  57. inst1.SetClientID("AOL Instant Messenger, version 5.9.3702/WIN32")
  58. ip1, _ := netip.ParseAddrPort("1.2.3.4:1234")
  59. inst1.SetRemoteAddr(&ip1)
  60. inst2 := userA.AddInstance()
  61. inst2.SetSignonComplete()
  62. inst2.SetUserStatusBitmask(wire.OServiceUserStatusInvisible)
  63. ip2, _ := netip.ParseAddrPort("5.6.7.8:5678")
  64. inst2.SetRemoteAddr(&ip2)
  65. // userB: 2 instances - both invisible
  66. userB := state.NewSession()
  67. userB.SetIdentScreenName(state.NewIdentScreenName("userB"))
  68. userB.SetDisplayScreenName(state.DisplayScreenName("userB"))
  69. userB.SetUIN(0)
  70. userB.SetNowFn(nowFn)
  71. userB.SetSignonTime(fixedNow.Add(-200 * time.Second))
  72. inst3 := userB.AddInstance()
  73. inst3.SetSignonComplete()
  74. inst3.SetUserStatusBitmask(wire.OServiceUserStatusInvisible)
  75. inst3.SetClientID("AOL Instant Messenger (SM), version 4.8.2790/WIN32")
  76. ip3, _ := netip.ParseAddrPort("9.10.11.12:9012")
  77. inst3.SetRemoteAddr(&ip3)
  78. inst4 := userB.AddInstance()
  79. inst4.SetSignonComplete()
  80. inst4.SetUserStatusBitmask(wire.OServiceUserStatusInvisible)
  81. inst4.SetClientID("WebAIM")
  82. ip4, _ := netip.ParseAddrPort("13.14.15.16:1314")
  83. inst4.SetRemoteAddr(&ip4)
  84. // 100003: 1 instance - normal
  85. icqUser := state.NewSession()
  86. icqUser.SetIdentScreenName(state.NewIdentScreenName("100003"))
  87. icqUser.SetDisplayScreenName(state.DisplayScreenName("100003"))
  88. icqUser.SetUIN(100003)
  89. icqUser.SetNowFn(nowFn)
  90. icqUser.SetSignonTime(fixedNow.Add(-300 * time.Second))
  91. inst5 := icqUser.AddInstance()
  92. inst5.SetSignonComplete()
  93. inst5.SetClientID("ICQBasic")
  94. ip5, _ := netip.ParseAddrPort("1.2.3.4:1234")
  95. inst5.SetRemoteAddr(&ip5)
  96. return []*state.Session{userA, userB, icqUser}
  97. },
  98. },
  99. {
  100. name: "with away sessions",
  101. want: `{"count":2,"sessions":[{"id":"usera","screen_name":"userA","online_seconds":100,"is_away":false,"away_message":"","idle_seconds":0,"is_invisible":false,"is_icq":false,"instance_count":2,"instances":[{"num":1,"idle_seconds":0,"is_away":true,"away_message":"Away message 1","is_invisible":false,"remote_addr":"1.2.3.4","remote_port":1234,"client_id":""},{"num":2,"idle_seconds":0,"is_away":false,"away_message":"","is_invisible":false,"remote_addr":"5.6.7.8","remote_port":5678,"client_id":""}]},{"id":"userb","screen_name":"userB","online_seconds":200,"is_away":true,"away_message":"Away message 2","idle_seconds":0,"is_invisible":false,"is_icq":false,"instance_count":2,"instances":[{"num":1,"idle_seconds":0,"is_away":true,"away_message":"Away message 2","is_invisible":false,"remote_addr":"9.10.11.12","remote_port":9012,"client_id":""},{"num":2,"idle_seconds":0,"is_away":true,"away_message":"Away message 2","is_invisible":false,"remote_addr":"13.14.15.16","remote_port":1314,"client_id":""}]}]}`,
  102. statusCode: http.StatusOK,
  103. createSessions: func() []*state.Session {
  104. // userA: 2 instances - one away, one not away (away_message should be "")
  105. userA := state.NewSession()
  106. userA.SetIdentScreenName(state.NewIdentScreenName("userA"))
  107. userA.SetDisplayScreenName(state.DisplayScreenName("userA"))
  108. userA.SetUIN(0)
  109. userA.SetNowFn(nowFn)
  110. userA.SetSignonTime(fixedNow.Add(-100 * time.Second))
  111. inst1 := userA.AddInstance()
  112. inst1.SetSignonComplete()
  113. inst1.SetUserStatusBitmask(wire.OServiceUserStatusAway)
  114. inst1.SetAwayMessage("Away message 1")
  115. ip1, _ := netip.ParseAddrPort("1.2.3.4:1234")
  116. inst1.SetRemoteAddr(&ip1)
  117. inst2 := userA.AddInstance()
  118. inst2.SetSignonComplete()
  119. ip2, _ := netip.ParseAddrPort("5.6.7.8:5678")
  120. inst2.SetRemoteAddr(&ip2)
  121. // userB: 2 instances - both away (away_message should be populated)
  122. userB := state.NewSession()
  123. userB.SetIdentScreenName(state.NewIdentScreenName("userB"))
  124. userB.SetDisplayScreenName(state.DisplayScreenName("userB"))
  125. userB.SetUIN(0)
  126. userB.SetNowFn(nowFn)
  127. userB.SetSignonTime(fixedNow.Add(-200 * time.Second))
  128. inst3 := userB.AddInstance()
  129. inst3.SetSignonComplete()
  130. inst3.SetUserStatusBitmask(wire.OServiceUserStatusAway)
  131. inst3.SetAwayMessage("Away message 2")
  132. ip3, _ := netip.ParseAddrPort("9.10.11.12:9012")
  133. inst3.SetRemoteAddr(&ip3)
  134. inst4 := userB.AddInstance()
  135. inst4.SetSignonComplete()
  136. inst4.SetUserStatusBitmask(wire.OServiceUserStatusAway)
  137. inst4.SetAwayMessage("Away message 2")
  138. ip4, _ := netip.ParseAddrPort("13.14.15.16:1314")
  139. inst4.SetRemoteAddr(&ip4)
  140. return []*state.Session{userA, userB}
  141. },
  142. },
  143. }
  144. for _, tc := range tt {
  145. t.Run(tc.name, func(t *testing.T) {
  146. request := httptest.NewRequest(http.MethodGet, "/session", nil)
  147. responseRecorder := httptest.NewRecorder()
  148. sessionRetriever := newMockSessionRetriever(t)
  149. sessions := tc.createSessions()
  150. sessionRetriever.EXPECT().
  151. AllSessions().
  152. Return(sessions)
  153. getSessionHandler(responseRecorder, request, sessionRetriever, nowFn)
  154. if responseRecorder.Code != tc.statusCode {
  155. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  156. }
  157. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  158. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  159. }
  160. })
  161. }
  162. }
  163. func TestSessionHandlerScreenname_GET(t *testing.T) {
  164. // Fixed time for testing: 2024-01-01 12:00:00 UTC
  165. fixedNow := time.Date(2024, 1, 1, 12, 0, 0, 0, time.UTC)
  166. nowFn := func() time.Time { return fixedNow }
  167. tt := []struct {
  168. name string
  169. requestScreenName state.IdentScreenName
  170. want string
  171. statusCode int
  172. createSession func() *state.Session
  173. }{
  174. {
  175. name: "no session for screenname",
  176. requestScreenName: state.NewIdentScreenName("userA"),
  177. want: `session not found`,
  178. statusCode: http.StatusNotFound,
  179. createSession: func() *state.Session {
  180. return nil
  181. },
  182. },
  183. {
  184. name: "active session found for screenname",
  185. requestScreenName: state.NewIdentScreenName("userA"),
  186. want: `{"count":1,"sessions":[{"id":"usera","screen_name":"userA","online_seconds":150,"is_away":false,"away_message":"","idle_seconds":0,"is_invisible":false,"is_icq":false,"instance_count":1,"instances":[{"num":1,"idle_seconds":0,"is_away":false,"away_message":"","is_invisible":false,"remote_addr":"1.2.3.4","remote_port":1234,"client_id":"AOL Instant Messenger, version 5.9.3702/WIN32"}]}]}`,
  187. statusCode: http.StatusOK,
  188. createSession: func() *state.Session {
  189. sess := state.NewSession()
  190. sess.SetIdentScreenName(state.NewIdentScreenName("userA"))
  191. sess.SetDisplayScreenName(state.DisplayScreenName("userA"))
  192. sess.SetUIN(0)
  193. sess.SetNowFn(nowFn)
  194. sess.SetSignonTime(fixedNow.Add(-150 * time.Second))
  195. instance := sess.AddInstance()
  196. instance.SetSignonComplete()
  197. instance.SetClientID("AOL Instant Messenger, version 5.9.3702/WIN32")
  198. ip, _ := netip.ParseAddrPort("1.2.3.4:1234")
  199. instance.SetRemoteAddr(&ip)
  200. return sess
  201. },
  202. },
  203. }
  204. for _, tc := range tt {
  205. t.Run(tc.name, func(t *testing.T) {
  206. request := httptest.NewRequest(http.MethodGet, "/session/"+tc.requestScreenName.String(), nil)
  207. request.SetPathValue("screenname", tc.requestScreenName.String())
  208. responseRecorder := httptest.NewRecorder()
  209. sessionRetriever := newMockSessionRetriever(t)
  210. session := tc.createSession()
  211. sessionRetriever.EXPECT().
  212. RetrieveSession(tc.requestScreenName).
  213. Return(session)
  214. getSessionHandler(responseRecorder, request, sessionRetriever, nowFn)
  215. if responseRecorder.Code != tc.statusCode {
  216. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  217. }
  218. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  219. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  220. }
  221. })
  222. }
  223. }
  224. func TestSessionHandlerScreenname_DELETE(t *testing.T) {
  225. fnNewSess := func(screenName string) *state.Session {
  226. sess := state.NewSession()
  227. sess.SetIdentScreenName(state.NewIdentScreenName(screenName))
  228. sess.SetDisplayScreenName(state.DisplayScreenName(screenName))
  229. instance := sess.AddInstance()
  230. instance.SetSignonComplete()
  231. ip, _ := netip.ParseAddrPort("1.2.3.4:1234")
  232. instance.SetRemoteAddr(&ip)
  233. return sess
  234. }
  235. tt := []struct {
  236. name string
  237. session *state.SessionInstance
  238. requestScreenName state.IdentScreenName
  239. statusCode int
  240. mockParams mockParams
  241. }{
  242. {
  243. name: "delete an active session",
  244. requestScreenName: state.NewIdentScreenName("userA"),
  245. statusCode: http.StatusNoContent,
  246. mockParams: mockParams{
  247. sessionRetrieverParams: sessionRetrieverParams{
  248. retrieveSessionByNameParams: retrieveSessionByNameParams{
  249. {
  250. screenName: state.NewIdentScreenName("userA"),
  251. result: fnNewSess("userA"),
  252. },
  253. },
  254. },
  255. },
  256. },
  257. {
  258. name: "delete a non-existent session",
  259. requestScreenName: state.NewIdentScreenName("userA"),
  260. statusCode: http.StatusNotFound,
  261. mockParams: mockParams{
  262. sessionRetrieverParams: sessionRetrieverParams{
  263. retrieveSessionByNameParams: retrieveSessionByNameParams{
  264. {
  265. screenName: state.NewIdentScreenName("userA"),
  266. result: nil,
  267. },
  268. },
  269. },
  270. },
  271. },
  272. }
  273. for _, tc := range tt {
  274. t.Run(tc.name, func(t *testing.T) {
  275. request := httptest.NewRequest(http.MethodDelete, "/session/"+tc.requestScreenName.String(), nil)
  276. request.SetPathValue("screenname", tc.requestScreenName.String())
  277. responseRecorder := httptest.NewRecorder()
  278. sessionRetriever := newMockSessionRetriever(t)
  279. for _, params := range tc.mockParams.retrieveSessionByNameParams {
  280. sessionRetriever.EXPECT().
  281. RetrieveSession(params.screenName).
  282. Return(params.result)
  283. }
  284. deleteSessionHandler(responseRecorder, request, sessionRetriever)
  285. if responseRecorder.Code != tc.statusCode {
  286. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  287. }
  288. })
  289. }
  290. }
  291. func TestUserAccountHandler_GET(t *testing.T) {
  292. tt := []struct {
  293. name string
  294. requestScreenName state.IdentScreenName
  295. want string
  296. statusCode int
  297. mockParams mockParams
  298. }{
  299. {
  300. name: "invalid account",
  301. requestScreenName: state.NewIdentScreenName("userA"),
  302. want: `user not found`,
  303. statusCode: http.StatusNotFound,
  304. mockParams: mockParams{
  305. userManagerParams: userManagerParams{
  306. getUserParams: getUserParams{
  307. {
  308. screenName: state.NewIdentScreenName("userA"),
  309. result: nil,
  310. },
  311. },
  312. },
  313. },
  314. },
  315. {
  316. name: "valid aim account",
  317. requestScreenName: state.NewIdentScreenName("userA"),
  318. want: `{"id":"usera","screen_name":"userA","profile":"My Profile Text","email_address":"\u003cuserA@aol.com\u003e","reg_status":2,"confirmed":true,"is_icq":false,"suspended_status":"","is_bot":false}`,
  319. statusCode: http.StatusOK,
  320. mockParams: mockParams{
  321. userManagerParams: userManagerParams{
  322. getUserParams: getUserParams{
  323. {
  324. screenName: state.NewIdentScreenName("userA"),
  325. result: &state.User{
  326. DisplayScreenName: "userA",
  327. IdentScreenName: state.NewIdentScreenName("userA"),
  328. SuspendedStatus: 0x0,
  329. },
  330. },
  331. },
  332. },
  333. accountManagerParams: accountManagerParams{
  334. EmailAddressParams: EmailAddressParams{
  335. {
  336. screenName: state.NewIdentScreenName("userA"),
  337. result: &mail.Address{
  338. Address: "userA@aol.com",
  339. },
  340. },
  341. },
  342. RegStatusParams: RegStatusParams{
  343. {
  344. screenName: state.NewIdentScreenName("userA"),
  345. result: uint16(0x02),
  346. },
  347. },
  348. ConfirmStatusParams: ConfirmStatusParams{
  349. {
  350. screenName: state.NewIdentScreenName("userA"),
  351. result: true,
  352. },
  353. },
  354. },
  355. profileRetrieverParams: profileRetrieverParams{
  356. retrieveProfileParams: retrieveProfileParams{
  357. {
  358. screenName: state.NewIdentScreenName("userA"),
  359. result: state.UserProfile{ProfileText: "My Profile Text"},
  360. },
  361. },
  362. },
  363. },
  364. },
  365. {
  366. name: "valid aim bot account",
  367. requestScreenName: state.NewIdentScreenName("userA"),
  368. want: `{"id":"usera","screen_name":"userA","profile":"My Profile Text","email_address":"\u003cuserA@aol.com\u003e","reg_status":2,"confirmed":true,"is_icq":false,"suspended_status":"","is_bot":true}`,
  369. statusCode: http.StatusOK,
  370. mockParams: mockParams{
  371. userManagerParams: userManagerParams{
  372. getUserParams: getUserParams{
  373. {
  374. screenName: state.NewIdentScreenName("userA"),
  375. result: &state.User{
  376. DisplayScreenName: "userA",
  377. IdentScreenName: state.NewIdentScreenName("userA"),
  378. SuspendedStatus: 0x0,
  379. IsBot: true,
  380. },
  381. },
  382. },
  383. },
  384. accountManagerParams: accountManagerParams{
  385. EmailAddressParams: EmailAddressParams{
  386. {
  387. screenName: state.NewIdentScreenName("userA"),
  388. result: &mail.Address{
  389. Address: "userA@aol.com",
  390. },
  391. },
  392. },
  393. RegStatusParams: RegStatusParams{
  394. {
  395. screenName: state.NewIdentScreenName("userA"),
  396. result: uint16(0x02),
  397. },
  398. },
  399. ConfirmStatusParams: ConfirmStatusParams{
  400. {
  401. screenName: state.NewIdentScreenName("userA"),
  402. result: true,
  403. },
  404. },
  405. },
  406. profileRetrieverParams: profileRetrieverParams{
  407. retrieveProfileParams: retrieveProfileParams{
  408. {
  409. screenName: state.NewIdentScreenName("userA"),
  410. result: state.UserProfile{ProfileText: "My Profile Text"},
  411. },
  412. },
  413. },
  414. },
  415. },
  416. {
  417. name: "suspended aim account",
  418. requestScreenName: state.NewIdentScreenName("userB"),
  419. want: `{"id":"userb","screen_name":"userB","profile":"My Profile Text","email_address":"\u003cuserB@aol.com\u003e","reg_status":2,"confirmed":true,"is_icq":false,"suspended_status":"suspended","is_bot":false}`,
  420. statusCode: http.StatusOK,
  421. mockParams: mockParams{
  422. userManagerParams: userManagerParams{
  423. getUserParams: getUserParams{
  424. {
  425. screenName: state.NewIdentScreenName("userB"),
  426. result: &state.User{
  427. DisplayScreenName: "userB",
  428. IdentScreenName: state.NewIdentScreenName("userB"),
  429. SuspendedStatus: wire.LoginErrSuspendedAccount,
  430. },
  431. },
  432. },
  433. },
  434. accountManagerParams: accountManagerParams{
  435. EmailAddressParams: EmailAddressParams{
  436. {
  437. screenName: state.NewIdentScreenName("userB"),
  438. result: &mail.Address{
  439. Address: "userB@aol.com",
  440. },
  441. },
  442. },
  443. RegStatusParams: RegStatusParams{
  444. {
  445. screenName: state.NewIdentScreenName("userB"),
  446. result: uint16(0x02),
  447. },
  448. },
  449. ConfirmStatusParams: ConfirmStatusParams{
  450. {
  451. screenName: state.NewIdentScreenName("userB"),
  452. result: true,
  453. },
  454. },
  455. },
  456. profileRetrieverParams: profileRetrieverParams{
  457. retrieveProfileParams: retrieveProfileParams{
  458. {
  459. screenName: state.NewIdentScreenName("userB"),
  460. result: state.UserProfile{ProfileText: "My Profile Text"},
  461. },
  462. },
  463. },
  464. },
  465. },
  466. }
  467. for _, tc := range tt {
  468. t.Run(tc.name, func(t *testing.T) {
  469. request := httptest.NewRequest(http.MethodGet, "/user/"+tc.requestScreenName.String()+"/account", nil)
  470. request.SetPathValue("screenname", tc.requestScreenName.String())
  471. responseRecorder := httptest.NewRecorder()
  472. userManager := newMockUserManager(t)
  473. for _, params := range tc.mockParams.getUserParams {
  474. userManager.EXPECT().
  475. User(matchContext(), params.screenName).
  476. Return(params.result, params.err)
  477. }
  478. accountManager := newMockAccountManager(t)
  479. for _, params := range tc.mockParams.EmailAddressParams {
  480. accountManager.EXPECT().
  481. EmailAddress(matchContext(), params.screenName).
  482. Return(params.result, params.err)
  483. }
  484. for _, params := range tc.mockParams.RegStatusParams {
  485. accountManager.EXPECT().
  486. RegStatus(matchContext(), params.screenName).
  487. Return(params.result, params.err)
  488. }
  489. for _, params := range tc.mockParams.ConfirmStatusParams {
  490. accountManager.EXPECT().
  491. ConfirmStatus(matchContext(), params.screenName).
  492. Return(params.result, params.err)
  493. }
  494. profileRetriever := newMockProfileRetriever(t)
  495. for _, params := range tc.mockParams.retrieveProfileParams {
  496. profileRetriever.EXPECT().
  497. Profile(matchContext(), params.screenName).
  498. Return(params.result, params.err)
  499. }
  500. getUserAccountHandler(responseRecorder, request, userManager, accountManager, profileRetriever, slog.Default())
  501. if responseRecorder.Code != tc.statusCode {
  502. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  503. }
  504. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  505. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  506. }
  507. })
  508. }
  509. }
  510. func TestUserAccountHandler_PATCH(t *testing.T) {
  511. tt := []struct {
  512. name string
  513. requestScreenName state.IdentScreenName
  514. want string
  515. body string
  516. statusCode int
  517. mockParams mockParams
  518. }{
  519. {
  520. name: "suspending a non-existent account",
  521. requestScreenName: state.NewIdentScreenName("userA"),
  522. body: `{"suspended_status":"suspended"}`,
  523. want: `user not found`,
  524. statusCode: http.StatusNotFound,
  525. mockParams: mockParams{
  526. userManagerParams: userManagerParams{
  527. getUserParams: getUserParams{
  528. {
  529. screenName: state.NewIdentScreenName("userA"),
  530. result: nil,
  531. },
  532. },
  533. },
  534. },
  535. },
  536. {
  537. name: "patching with invalid suspended_status value",
  538. requestScreenName: state.NewIdentScreenName("userA"),
  539. body: `{"suspended_status":"thisisinvalid"}`,
  540. want: `{"message":"suspended_status must be empty str or one of deleted,expired,suspended,suspended_age"}`,
  541. statusCode: http.StatusBadRequest,
  542. mockParams: mockParams{
  543. userManagerParams: userManagerParams{
  544. getUserParams: getUserParams{
  545. {
  546. screenName: state.NewIdentScreenName("userA"),
  547. result: &state.User{},
  548. },
  549. },
  550. },
  551. },
  552. },
  553. {
  554. name: "suspending an active aim account",
  555. requestScreenName: state.NewIdentScreenName("userA"),
  556. statusCode: http.StatusNoContent,
  557. body: `{"suspended_status":"suspended"}`,
  558. mockParams: mockParams{
  559. userManagerParams: userManagerParams{
  560. getUserParams: getUserParams{
  561. {
  562. screenName: state.NewIdentScreenName("userA"),
  563. result: &state.User{
  564. DisplayScreenName: "userA",
  565. IdentScreenName: state.NewIdentScreenName("userA"),
  566. SuspendedStatus: 0x0,
  567. },
  568. },
  569. },
  570. },
  571. accountManagerParams: accountManagerParams{
  572. updateSuspendedStatusParams: updateSuspendedStatusParams{
  573. {
  574. suspendedStatus: wire.LoginErrSuspendedAccount,
  575. screenName: state.NewIdentScreenName("userA"),
  576. err: nil,
  577. },
  578. },
  579. },
  580. },
  581. },
  582. {
  583. name: "unsuspending a suspended aim account",
  584. requestScreenName: state.NewIdentScreenName("userA"),
  585. statusCode: http.StatusNoContent,
  586. body: `{"suspended_status":""}`,
  587. mockParams: mockParams{
  588. userManagerParams: userManagerParams{
  589. getUserParams: getUserParams{
  590. {
  591. screenName: state.NewIdentScreenName("userA"),
  592. result: &state.User{
  593. DisplayScreenName: "userA",
  594. IdentScreenName: state.NewIdentScreenName("userA"),
  595. SuspendedStatus: wire.LoginErrSuspendedAccount,
  596. },
  597. },
  598. },
  599. },
  600. accountManagerParams: accountManagerParams{
  601. updateSuspendedStatusParams: updateSuspendedStatusParams{
  602. {
  603. suspendedStatus: 0x0,
  604. screenName: state.NewIdentScreenName("userA"),
  605. err: nil,
  606. },
  607. },
  608. },
  609. },
  610. },
  611. {
  612. name: "suspending an already suspended aim account",
  613. requestScreenName: state.NewIdentScreenName("userA"),
  614. statusCode: http.StatusNotModified,
  615. body: `{"suspended_status":"suspended"}`,
  616. mockParams: mockParams{
  617. userManagerParams: userManagerParams{
  618. getUserParams: getUserParams{
  619. {
  620. screenName: state.NewIdentScreenName("userA"),
  621. result: &state.User{
  622. DisplayScreenName: "userA",
  623. IdentScreenName: state.NewIdentScreenName("userA"),
  624. SuspendedStatus: wire.LoginErrSuspendedAccount,
  625. },
  626. },
  627. },
  628. },
  629. },
  630. },
  631. {
  632. name: "setting bot flag (before: false, after: true)",
  633. requestScreenName: state.NewIdentScreenName("userA"),
  634. statusCode: http.StatusNoContent,
  635. body: `{"is_bot":true}`,
  636. mockParams: mockParams{
  637. userManagerParams: userManagerParams{
  638. getUserParams: getUserParams{
  639. {
  640. screenName: state.NewIdentScreenName("userA"),
  641. result: &state.User{
  642. DisplayScreenName: "userA",
  643. IdentScreenName: state.NewIdentScreenName("userA"),
  644. SuspendedStatus: 0x0,
  645. IsBot: false,
  646. },
  647. },
  648. },
  649. },
  650. accountManagerParams: accountManagerParams{
  651. setBotStatusParams: setBotStatusParams{
  652. {
  653. isBot: true,
  654. screenName: state.NewIdentScreenName("userA"),
  655. err: nil,
  656. },
  657. },
  658. },
  659. },
  660. },
  661. {
  662. name: "setting bot flag (before: true, after: false)",
  663. requestScreenName: state.NewIdentScreenName("userA"),
  664. statusCode: http.StatusNoContent,
  665. body: `{"is_bot":false}`,
  666. mockParams: mockParams{
  667. userManagerParams: userManagerParams{
  668. getUserParams: getUserParams{
  669. {
  670. screenName: state.NewIdentScreenName("userA"),
  671. result: &state.User{
  672. DisplayScreenName: "userA",
  673. IdentScreenName: state.NewIdentScreenName("userA"),
  674. SuspendedStatus: 0x0,
  675. IsBot: true,
  676. },
  677. },
  678. },
  679. },
  680. accountManagerParams: accountManagerParams{
  681. setBotStatusParams: setBotStatusParams{
  682. {
  683. isBot: false,
  684. screenName: state.NewIdentScreenName("userA"),
  685. err: nil,
  686. },
  687. },
  688. },
  689. },
  690. },
  691. {
  692. name: "setting bot flag (before: true, after: true)",
  693. requestScreenName: state.NewIdentScreenName("userA"),
  694. statusCode: http.StatusNotModified,
  695. body: `{"is_bot":true}`,
  696. mockParams: mockParams{
  697. userManagerParams: userManagerParams{
  698. getUserParams: getUserParams{
  699. {
  700. screenName: state.NewIdentScreenName("userA"),
  701. result: &state.User{
  702. DisplayScreenName: "userA",
  703. IdentScreenName: state.NewIdentScreenName("userA"),
  704. SuspendedStatus: 0x0,
  705. IsBot: true,
  706. },
  707. },
  708. },
  709. },
  710. },
  711. },
  712. }
  713. for _, tc := range tt {
  714. t.Run(tc.name, func(t *testing.T) {
  715. request := httptest.NewRequest(http.MethodPatch, "/user/"+tc.requestScreenName.String()+"/account", strings.NewReader(tc.body))
  716. request.SetPathValue("screenname", tc.requestScreenName.String())
  717. responseRecorder := httptest.NewRecorder()
  718. userManager := newMockUserManager(t)
  719. for _, params := range tc.mockParams.getUserParams {
  720. userManager.EXPECT().
  721. User(matchContext(), params.screenName).
  722. Return(params.result, params.err)
  723. }
  724. accountManager := newMockAccountManager(t)
  725. for _, params := range tc.mockParams.updateSuspendedStatusParams {
  726. accountManager.EXPECT().
  727. UpdateSuspendedStatus(matchContext(), params.suspendedStatus, params.screenName).
  728. Return(params.err)
  729. }
  730. for _, params := range tc.mockParams.setBotStatusParams {
  731. accountManager.EXPECT().
  732. SetBotStatus(matchContext(), params.isBot, params.screenName).
  733. Return(params.err)
  734. }
  735. patchUserAccountHandler(responseRecorder, request, userManager, accountManager, slog.Default())
  736. if responseRecorder.Code != tc.statusCode {
  737. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  738. }
  739. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  740. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  741. }
  742. })
  743. }
  744. }
  745. func TestUserBuddyIconHandler_GET(t *testing.T) {
  746. sampleGIF := []byte{
  747. 0x47, 0x49, 0x46, 0x38, 0x39, 0x61, 0x32, 0x00, 0x32, 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
  748. 0x00, 0x00, 0x00, 0x21, 0xf9, 0x04, 0x01, 0x00, 0x00, 0x00, 0x00, 0x2c, 0x00, 0x00, 0x00, 0x00,
  749. 0x32, 0x00, 0x32, 0x00, 0x00, 0x02, 0x02, 0x44, 0x01, 0x00, 0x3b}
  750. sampleJPG := []byte{0xFF, 0xD8, 0xFF, 0x43, 0x13, 0x37}
  751. tt := []struct {
  752. name string
  753. requestScreenName state.IdentScreenName
  754. want string
  755. statusCode int
  756. contentType string
  757. mockParams mockParams
  758. }{
  759. {
  760. name: "invalid account",
  761. requestScreenName: state.NewIdentScreenName("userA"),
  762. want: `user not found`,
  763. statusCode: http.StatusNotFound,
  764. contentType: "text/plain; charset=utf-8",
  765. mockParams: mockParams{
  766. userManagerParams: userManagerParams{
  767. getUserParams: getUserParams{
  768. {
  769. screenName: state.NewIdentScreenName("userA"),
  770. result: nil,
  771. },
  772. },
  773. },
  774. },
  775. },
  776. {
  777. name: "account with gif buddy icon",
  778. requestScreenName: state.NewIdentScreenName("userA"),
  779. want: string(sampleGIF),
  780. statusCode: http.StatusOK,
  781. contentType: "image/gif",
  782. mockParams: mockParams{
  783. userManagerParams: userManagerParams{
  784. getUserParams: getUserParams{
  785. {
  786. screenName: state.NewIdentScreenName("userA"),
  787. result: &state.User{
  788. DisplayScreenName: "userA",
  789. IdentScreenName: state.NewIdentScreenName("userA"),
  790. },
  791. },
  792. },
  793. },
  794. feedBagRetrieverParams: feedBagRetrieverParams{
  795. buddyIconMetadataParams: buddyIconMetadataParams{
  796. {
  797. screenName: state.NewIdentScreenName("userA"),
  798. result: &wire.BARTID{
  799. Type: wire.BARTTypesBuddyIcon,
  800. BARTInfo: wire.BARTInfo{
  801. Flags: 0x00,
  802. Hash: []byte{'t', 'h', 'e', 'h', 'a', 's', 'h'},
  803. },
  804. },
  805. },
  806. },
  807. },
  808. bartAssetManagerParams: bartAssetManagerParams{
  809. bartItemParams: bartItemParams{
  810. {
  811. hash: []byte{'t', 'h', 'e', 'h', 'a', 's', 'h'},
  812. result: sampleGIF,
  813. },
  814. },
  815. },
  816. },
  817. },
  818. {
  819. name: "account with jpg buddy icon",
  820. requestScreenName: state.NewIdentScreenName("userA"),
  821. want: string(sampleJPG),
  822. statusCode: http.StatusOK,
  823. contentType: "image/jpeg",
  824. mockParams: mockParams{
  825. userManagerParams: userManagerParams{
  826. getUserParams: getUserParams{
  827. {
  828. screenName: state.NewIdentScreenName("userA"),
  829. result: &state.User{
  830. DisplayScreenName: "userA",
  831. IdentScreenName: state.NewIdentScreenName("userA"),
  832. },
  833. },
  834. },
  835. },
  836. feedBagRetrieverParams: feedBagRetrieverParams{
  837. buddyIconMetadataParams: buddyIconMetadataParams{
  838. {
  839. screenName: state.NewIdentScreenName("userA"),
  840. result: &wire.BARTID{
  841. Type: wire.BARTTypesBuddyIcon,
  842. BARTInfo: wire.BARTInfo{
  843. Flags: 0x00,
  844. Hash: []byte{'t', 'h', 'e', 'h', 'a', 's', 'h'},
  845. },
  846. },
  847. },
  848. },
  849. },
  850. bartAssetManagerParams: bartAssetManagerParams{
  851. bartItemParams: bartItemParams{
  852. {
  853. hash: []byte{'t', 'h', 'e', 'h', 'a', 's', 'h'},
  854. result: sampleJPG,
  855. },
  856. },
  857. },
  858. },
  859. },
  860. {
  861. name: "account with unknown format buddy icon",
  862. requestScreenName: state.NewIdentScreenName("userA"),
  863. want: string([]byte{0x13, 0x37, 0x13, 0x37, 0x13, 0x37}),
  864. statusCode: http.StatusOK,
  865. contentType: "application/octet-stream",
  866. mockParams: mockParams{
  867. userManagerParams: userManagerParams{
  868. getUserParams: getUserParams{
  869. {
  870. screenName: state.NewIdentScreenName("userA"),
  871. result: &state.User{
  872. DisplayScreenName: "userA",
  873. IdentScreenName: state.NewIdentScreenName("userA"),
  874. },
  875. },
  876. },
  877. },
  878. feedBagRetrieverParams: feedBagRetrieverParams{
  879. buddyIconMetadataParams: buddyIconMetadataParams{
  880. {
  881. screenName: state.NewIdentScreenName("userA"),
  882. result: &wire.BARTID{
  883. Type: wire.BARTTypesBuddyIcon,
  884. BARTInfo: wire.BARTInfo{
  885. Flags: 0x00,
  886. Hash: []byte{'t', 'h', 'e', 'h', 'a', 's', 'h'},
  887. },
  888. },
  889. },
  890. },
  891. },
  892. bartAssetManagerParams: bartAssetManagerParams{
  893. bartItemParams: bartItemParams{
  894. {
  895. hash: []byte{'t', 'h', 'e', 'h', 'a', 's', 'h'},
  896. result: []byte{0x13, 0x37, 0x13, 0x37, 0x13, 0x37},
  897. },
  898. },
  899. },
  900. },
  901. },
  902. {
  903. name: "account with cleared buddy icon",
  904. requestScreenName: state.NewIdentScreenName("userA"),
  905. want: "icon not found",
  906. statusCode: http.StatusNotFound,
  907. contentType: "text/plain; charset=utf-8",
  908. mockParams: mockParams{
  909. userManagerParams: userManagerParams{
  910. getUserParams: getUserParams{
  911. {
  912. screenName: state.NewIdentScreenName("userA"),
  913. result: &state.User{
  914. DisplayScreenName: "userA",
  915. IdentScreenName: state.NewIdentScreenName("userA"),
  916. },
  917. },
  918. },
  919. },
  920. feedBagRetrieverParams: feedBagRetrieverParams{
  921. buddyIconMetadataParams: buddyIconMetadataParams{
  922. {
  923. screenName: state.NewIdentScreenName("userA"),
  924. result: &wire.BARTID{
  925. Type: wire.BARTTypesBuddyIcon,
  926. BARTInfo: wire.BARTInfo{
  927. Flags: 0x00,
  928. Hash: wire.GetClearIconHash(),
  929. },
  930. },
  931. },
  932. },
  933. },
  934. },
  935. },
  936. {
  937. name: "account with no buddy icon",
  938. requestScreenName: state.NewIdentScreenName("userA"),
  939. want: "icon not found",
  940. statusCode: http.StatusNotFound,
  941. contentType: "text/plain; charset=utf-8",
  942. mockParams: mockParams{
  943. userManagerParams: userManagerParams{
  944. getUserParams: getUserParams{
  945. {
  946. screenName: state.NewIdentScreenName("userA"),
  947. result: &state.User{
  948. DisplayScreenName: "userA",
  949. IdentScreenName: state.NewIdentScreenName("userA"),
  950. },
  951. },
  952. },
  953. },
  954. feedBagRetrieverParams: feedBagRetrieverParams{
  955. buddyIconMetadataParams: buddyIconMetadataParams{
  956. {
  957. screenName: state.NewIdentScreenName("userA"),
  958. result: nil,
  959. },
  960. },
  961. },
  962. },
  963. },
  964. }
  965. for _, tc := range tt {
  966. t.Run(tc.name, func(t *testing.T) {
  967. request := httptest.NewRequest(http.MethodGet, "/user/"+tc.requestScreenName.String()+"/icon", nil)
  968. request.SetPathValue("screenname", tc.requestScreenName.String())
  969. responseRecorder := httptest.NewRecorder()
  970. userManager := newMockUserManager(t)
  971. for _, params := range tc.mockParams.getUserParams {
  972. userManager.EXPECT().
  973. User(matchContext(), params.screenName).
  974. Return(params.result, params.err)
  975. }
  976. feedbagRetriever := newMockFeedBagRetriever(t)
  977. for _, params := range tc.mockParams.buddyIconMetadataParams {
  978. feedbagRetriever.EXPECT().
  979. BuddyIconMetadata(matchContext(), params.screenName).
  980. Return(params.result, params.err)
  981. }
  982. bartRetriever := newMockBARTAssetManager(t)
  983. for _, params := range tc.mockParams.bartItemParams {
  984. bartRetriever.EXPECT().
  985. BARTItem(matchContext(), params.hash).
  986. Return(params.result, params.err)
  987. }
  988. getUserBuddyIconHandler(responseRecorder, request, userManager, feedbagRetriever, bartRetriever, slog.Default())
  989. if responseRecorder.Code != tc.statusCode {
  990. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  991. }
  992. contentType := responseRecorder.Header().Get("Content-Type")
  993. if contentType != tc.contentType {
  994. t.Errorf("Want content type '%s', got '%s'", tc.contentType, contentType)
  995. }
  996. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  997. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  998. }
  999. })
  1000. }
  1001. }
  1002. func TestUserHandler_GET(t *testing.T) {
  1003. tt := []struct {
  1004. name string
  1005. want string
  1006. statusCode int
  1007. mockParams mockParams
  1008. }{
  1009. {
  1010. name: "empty user store",
  1011. want: `[]`,
  1012. statusCode: http.StatusOK,
  1013. mockParams: mockParams{
  1014. userManagerParams: userManagerParams{
  1015. allUsersParams: allUsersParams{
  1016. {
  1017. result: []state.User{},
  1018. },
  1019. },
  1020. },
  1021. },
  1022. },
  1023. {
  1024. name: "user store containing 3 users",
  1025. want: `[{"id":"usera","screen_name":"userA","is_icq":false,"suspended_status":"","is_bot":false},{"id":"userb","screen_name":"userB","is_icq":false,"suspended_status":"","is_bot":true},{"id":"100003","screen_name":"100003","is_icq":true,"suspended_status":"","is_bot":false}]`,
  1026. statusCode: http.StatusOK,
  1027. mockParams: mockParams{
  1028. userManagerParams: userManagerParams{
  1029. allUsersParams: allUsersParams{
  1030. {
  1031. result: []state.User{
  1032. {
  1033. DisplayScreenName: "userA",
  1034. IdentScreenName: state.NewIdentScreenName("userA"),
  1035. },
  1036. {
  1037. DisplayScreenName: "userB",
  1038. IdentScreenName: state.NewIdentScreenName("userB"),
  1039. IsBot: true,
  1040. },
  1041. {
  1042. DisplayScreenName: "100003",
  1043. IdentScreenName: state.NewIdentScreenName("100003"),
  1044. IsICQ: true,
  1045. },
  1046. },
  1047. },
  1048. },
  1049. },
  1050. },
  1051. },
  1052. {
  1053. name: "user handler error",
  1054. want: `internal server error`,
  1055. statusCode: http.StatusInternalServerError,
  1056. mockParams: mockParams{
  1057. userManagerParams: userManagerParams{
  1058. allUsersParams: allUsersParams{
  1059. {
  1060. result: []state.User{},
  1061. err: io.EOF,
  1062. },
  1063. },
  1064. },
  1065. },
  1066. },
  1067. }
  1068. for _, tc := range tt {
  1069. t.Run(tc.name, func(t *testing.T) {
  1070. request := httptest.NewRequest(http.MethodGet, "/user", nil)
  1071. responseRecorder := httptest.NewRecorder()
  1072. userManager := newMockUserManager(t)
  1073. for _, params := range tc.mockParams.allUsersParams {
  1074. userManager.EXPECT().
  1075. AllUsers(matchContext()).
  1076. Return(params.result, params.err)
  1077. }
  1078. getUserHandler(responseRecorder, request, userManager, slog.Default())
  1079. if responseRecorder.Code != tc.statusCode {
  1080. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1081. }
  1082. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1083. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  1084. }
  1085. })
  1086. }
  1087. }
  1088. func TestUserHandler_POST(t *testing.T) {
  1089. tt := []struct {
  1090. name string
  1091. body string
  1092. want string
  1093. statusCode int
  1094. createAccount state.CreateAccountFunc
  1095. }{
  1096. {
  1097. name: "with valid AIM user",
  1098. body: `{"screen_name":"userA", "password":"thepassword"}`,
  1099. want: `User account created successfully.`,
  1100. statusCode: http.StatusCreated,
  1101. createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
  1102. assert.Equal(t, state.DisplayScreenName("userA"), screenName)
  1103. assert.Equal(t, "thepassword", password)
  1104. return nil
  1105. },
  1106. },
  1107. {
  1108. name: "with valid ICQ user",
  1109. body: `{"screen_name":"100003", "password":"thepass"}`,
  1110. want: `User account created successfully.`,
  1111. statusCode: http.StatusCreated,
  1112. createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
  1113. assert.Equal(t, state.DisplayScreenName("100003"), screenName)
  1114. assert.Equal(t, "thepass", password)
  1115. return nil
  1116. },
  1117. },
  1118. {
  1119. name: "with malformed body",
  1120. body: `{"screen_name":"userA", "password":"thepassword"`, // missing closing }
  1121. want: `malformed input`,
  1122. statusCode: http.StatusBadRequest,
  1123. },
  1124. {
  1125. name: "user handler error",
  1126. body: `{"screen_name":"userA", "password":"thepassword"}`,
  1127. want: `internal server error`,
  1128. statusCode: http.StatusInternalServerError,
  1129. createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
  1130. assert.Equal(t, state.DisplayScreenName("userA"), screenName)
  1131. assert.Equal(t, "thepassword", password)
  1132. return io.EOF
  1133. },
  1134. },
  1135. {
  1136. name: "duplicate user",
  1137. body: `{"screen_name":"userA", "password":"thepassword"}`,
  1138. want: `user already exists`,
  1139. statusCode: http.StatusConflict,
  1140. createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
  1141. assert.Equal(t, state.DisplayScreenName("userA"), screenName)
  1142. assert.Equal(t, "thepassword", password)
  1143. return state.ErrDupUser
  1144. },
  1145. },
  1146. {
  1147. name: "invalid AIM screen name",
  1148. body: `{"screen_name":"a", "password":"thepassword"}`,
  1149. want: `invalid screen name: screen name must be between 3 and 16 characters`,
  1150. statusCode: http.StatusBadRequest,
  1151. createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
  1152. assert.Equal(t, state.DisplayScreenName("a"), screenName)
  1153. assert.Equal(t, "thepassword", password)
  1154. return state.ErrAIMHandleLength
  1155. },
  1156. },
  1157. {
  1158. name: "invalid AIM password",
  1159. body: `{"screen_name":"userA", "password":"1"}`,
  1160. want: `invalid password: invalid password length: password length must be between 4-16 characters`,
  1161. statusCode: http.StatusBadRequest,
  1162. createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
  1163. assert.Equal(t, state.DisplayScreenName("userA"), screenName)
  1164. assert.Equal(t, "1", password)
  1165. return fmt.Errorf("%w: password length must be between 4-16 characters", state.ErrPasswordInvalid)
  1166. },
  1167. },
  1168. {
  1169. name: "invalid ICQ UIN",
  1170. body: `{"screen_name":"1000", "password":"thepass"}`,
  1171. want: `invalid uin: uin must be a number in the range 10000-2147483646`,
  1172. statusCode: http.StatusBadRequest,
  1173. createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
  1174. assert.Equal(t, state.DisplayScreenName("1000"), screenName)
  1175. assert.Equal(t, "thepass", password)
  1176. return state.ErrICQUINInvalidFormat
  1177. },
  1178. },
  1179. {
  1180. name: "invalid ICQ password",
  1181. body: `{"screen_name":"100003", "password":"thelongpassword"}`,
  1182. want: `invalid password: invalid password length: password must be between 6-8 characters`,
  1183. statusCode: http.StatusBadRequest,
  1184. createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
  1185. assert.Equal(t, state.DisplayScreenName("100003"), screenName)
  1186. assert.Equal(t, "thelongpassword", password)
  1187. return fmt.Errorf("%w: password must be between 6-8 characters", state.ErrPasswordInvalid)
  1188. },
  1189. },
  1190. }
  1191. for _, tc := range tt {
  1192. t.Run(tc.name, func(t *testing.T) {
  1193. request := httptest.NewRequest(http.MethodPost, "/user", strings.NewReader(tc.body))
  1194. responseRecorder := httptest.NewRecorder()
  1195. postUserHandler(responseRecorder, request, tc.createAccount, slog.Default())
  1196. if responseRecorder.Code != tc.statusCode {
  1197. t.Errorf("want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1198. }
  1199. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1200. t.Errorf("want '%s', got '%s'", tc.want, responseRecorder.Body)
  1201. }
  1202. })
  1203. }
  1204. }
  1205. func TestUserHandler_DELETE(t *testing.T) {
  1206. tt := []struct {
  1207. name string
  1208. body string
  1209. want string
  1210. statusCode int
  1211. mockParams mockParams
  1212. }{
  1213. {
  1214. name: "with valid user",
  1215. body: `{"screen_name":"userA"}`,
  1216. want: `User account successfully deleted.`,
  1217. statusCode: http.StatusNoContent,
  1218. mockParams: mockParams{
  1219. userManagerParams: userManagerParams{
  1220. deleteUserParams: deleteUserParams{
  1221. {
  1222. screenName: state.NewIdentScreenName("userA"),
  1223. },
  1224. },
  1225. },
  1226. },
  1227. },
  1228. {
  1229. name: "with non-existent user",
  1230. body: `{"screen_name":"userA"}`,
  1231. want: `user does not exist`,
  1232. statusCode: http.StatusNotFound,
  1233. mockParams: mockParams{
  1234. userManagerParams: userManagerParams{
  1235. deleteUserParams: deleteUserParams{
  1236. {
  1237. screenName: state.NewIdentScreenName("userA"),
  1238. err: state.ErrNoUser,
  1239. },
  1240. },
  1241. },
  1242. },
  1243. },
  1244. {
  1245. name: "with malformed body",
  1246. body: `{"screen_name":"userA"`, // missing closing }
  1247. want: `malformed input`,
  1248. statusCode: http.StatusBadRequest,
  1249. },
  1250. {
  1251. name: "user handler error",
  1252. body: `{"screen_name":"userA"}`,
  1253. want: `internal server error`,
  1254. statusCode: http.StatusInternalServerError,
  1255. mockParams: mockParams{
  1256. userManagerParams: userManagerParams{
  1257. deleteUserParams: deleteUserParams{
  1258. {
  1259. screenName: state.NewIdentScreenName("userA"),
  1260. err: io.EOF,
  1261. },
  1262. },
  1263. },
  1264. },
  1265. },
  1266. }
  1267. for _, tc := range tt {
  1268. t.Run(tc.name, func(t *testing.T) {
  1269. request := httptest.NewRequest(http.MethodDelete, "/user", strings.NewReader(tc.body))
  1270. responseRecorder := httptest.NewRecorder()
  1271. userManager := newMockUserManager(t)
  1272. for _, params := range tc.mockParams.deleteUserParams {
  1273. userManager.EXPECT().
  1274. DeleteUser(matchContext(), params.screenName).
  1275. Return(params.err)
  1276. }
  1277. deleteUserHandler(responseRecorder, request, userManager, slog.Default())
  1278. if responseRecorder.Code != tc.statusCode {
  1279. t.Errorf("want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1280. }
  1281. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1282. t.Errorf("want '%s', got '%s'", tc.want, responseRecorder.Body)
  1283. }
  1284. })
  1285. }
  1286. }
  1287. func TestUserPasswordHandler_PUT(t *testing.T) {
  1288. tt := []struct {
  1289. name string
  1290. body string
  1291. want string
  1292. statusCode int
  1293. mockParams mockParams
  1294. }{
  1295. {
  1296. name: "user with valid password",
  1297. body: `{"screen_name":"userA", "password":"thenewpassword"}`,
  1298. want: `Password successfully reset.`,
  1299. statusCode: http.StatusNoContent,
  1300. mockParams: mockParams{
  1301. userManagerParams: userManagerParams{
  1302. setUserPasswordParams: setUserPasswordParams{
  1303. {
  1304. screenName: state.NewIdentScreenName("userA"),
  1305. newPassword: "thenewpassword",
  1306. },
  1307. },
  1308. },
  1309. },
  1310. },
  1311. {
  1312. name: "user with invalid password",
  1313. body: `{"screen_name":"userA", "password":"a"}`,
  1314. want: `invalid password length`,
  1315. statusCode: http.StatusBadRequest,
  1316. mockParams: mockParams{
  1317. userManagerParams: userManagerParams{
  1318. setUserPasswordParams: setUserPasswordParams{
  1319. {
  1320. screenName: state.NewIdentScreenName("userA"),
  1321. newPassword: "a",
  1322. err: state.ErrPasswordInvalid,
  1323. },
  1324. },
  1325. },
  1326. },
  1327. },
  1328. {
  1329. name: "with malformed body",
  1330. body: `{"screen_name":"userA", "password":"thepassword"`, // missing closing }
  1331. want: `malformed input`,
  1332. statusCode: http.StatusBadRequest,
  1333. },
  1334. {
  1335. name: "password updater returns runtime error",
  1336. body: `{"screen_name":"userA", "password":"thepassword"}`,
  1337. want: `internal server error`,
  1338. statusCode: http.StatusInternalServerError,
  1339. mockParams: mockParams{
  1340. userManagerParams: userManagerParams{
  1341. setUserPasswordParams: setUserPasswordParams{
  1342. {
  1343. screenName: state.NewIdentScreenName("userA"),
  1344. newPassword: "thepassword",
  1345. err: io.EOF,
  1346. },
  1347. },
  1348. },
  1349. },
  1350. },
  1351. {
  1352. name: "user doesn't exist",
  1353. body: `{"screen_name":"userA", "password":"thepassword"}`,
  1354. want: `user does not exist`,
  1355. statusCode: http.StatusNotFound,
  1356. mockParams: mockParams{
  1357. userManagerParams: userManagerParams{
  1358. setUserPasswordParams: setUserPasswordParams{
  1359. {
  1360. screenName: state.NewIdentScreenName("userA"),
  1361. newPassword: "thepassword",
  1362. err: state.ErrNoUser,
  1363. },
  1364. },
  1365. },
  1366. },
  1367. },
  1368. }
  1369. for _, tc := range tt {
  1370. t.Run(tc.name, func(t *testing.T) {
  1371. request := httptest.NewRequest(http.MethodPut, "/user", strings.NewReader(tc.body))
  1372. responseRecorder := httptest.NewRecorder()
  1373. userManager := newMockUserManager(t)
  1374. for _, params := range tc.mockParams.setUserPasswordParams {
  1375. userManager.EXPECT().
  1376. SetUserPassword(matchContext(), params.screenName, params.newPassword).
  1377. Return(params.err)
  1378. }
  1379. putUserPasswordHandler(responseRecorder, request, userManager, slog.Default())
  1380. if responseRecorder.Code != tc.statusCode {
  1381. t.Errorf("want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1382. }
  1383. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1384. t.Errorf("want '%s', got '%s'", tc.want, responseRecorder.Body)
  1385. }
  1386. })
  1387. }
  1388. }
  1389. func TestPublicChatHandler_GET(t *testing.T) {
  1390. fnNewSess := func(screenName string) *state.Session {
  1391. sess := state.NewSession()
  1392. sess.SetIdentScreenName(state.NewIdentScreenName(screenName))
  1393. sess.SetDisplayScreenName(state.DisplayScreenName(screenName))
  1394. instance := sess.AddInstance()
  1395. instance.SetSignonComplete()
  1396. return sess
  1397. }
  1398. chatRoom1 := state.NewChatRoom("chat-room-1-name", state.NewIdentScreenName("chat-room-1-creator"), state.PublicExchange)
  1399. chatRoom2 := state.NewChatRoom("chat-room-2-name", state.NewIdentScreenName("chat-room-1-creator"), state.PublicExchange)
  1400. tt := []struct {
  1401. name string
  1402. want string
  1403. statusCode int
  1404. mockParams mockParams
  1405. }{
  1406. {
  1407. name: "multiple chat rooms with participants",
  1408. want: `[{"name":"chat-room-1-name","create_time":"0001-01-01T00:00:00Z","url":"aim:gochat?roomname=chat-room-1-name&exchange=5","participants":[{"id":"usera","screen_name":"userA"},{"id":"userb","screen_name":"userB"}]},{"name":"chat-room-2-name","create_time":"0001-01-01T00:00:00Z","url":"aim:gochat?roomname=chat-room-2-name&exchange=5","participants":[{"id":"userc","screen_name":"userC"},{"id":"userd","screen_name":"userD"}]}]`,
  1409. statusCode: http.StatusOK,
  1410. mockParams: mockParams{
  1411. chatRoomRetrieverParams: chatRoomRetrieverParams{
  1412. allChatRoomsParams: allChatRoomsParams{
  1413. {
  1414. exchange: state.PublicExchange,
  1415. result: []state.ChatRoom{
  1416. chatRoom1,
  1417. chatRoom2,
  1418. },
  1419. },
  1420. },
  1421. },
  1422. chatSessionRetrieverParams: chatSessionRetrieverParams{
  1423. chatSessionRetrieverAllSessionsParams: chatSessionRetrieverAllSessionsParams{
  1424. {
  1425. cookie: chatRoom1.Cookie(),
  1426. result: []*state.Session{
  1427. fnNewSess("userA"),
  1428. fnNewSess("userB"),
  1429. },
  1430. },
  1431. {
  1432. cookie: chatRoom2.Cookie(),
  1433. result: []*state.Session{
  1434. fnNewSess("userC"),
  1435. fnNewSess("userD"),
  1436. },
  1437. },
  1438. },
  1439. },
  1440. },
  1441. },
  1442. {
  1443. name: "chat room without participants",
  1444. want: `[{"name":"chat-room-1-name","create_time":"0001-01-01T00:00:00Z","url":"aim:gochat?roomname=chat-room-1-name&exchange=5","participants":[]}]`,
  1445. statusCode: http.StatusOK,
  1446. mockParams: mockParams{
  1447. chatRoomRetrieverParams: chatRoomRetrieverParams{
  1448. allChatRoomsParams: allChatRoomsParams{
  1449. {
  1450. exchange: state.PublicExchange,
  1451. result: []state.ChatRoom{
  1452. chatRoom1,
  1453. },
  1454. },
  1455. },
  1456. },
  1457. chatSessionRetrieverParams: chatSessionRetrieverParams{
  1458. chatSessionRetrieverAllSessionsParams: chatSessionRetrieverAllSessionsParams{
  1459. {
  1460. cookie: chatRoom1.Cookie(),
  1461. result: []*state.Session{},
  1462. },
  1463. },
  1464. },
  1465. },
  1466. },
  1467. {
  1468. name: "no chat rooms",
  1469. want: `[]`,
  1470. statusCode: http.StatusOK,
  1471. mockParams: mockParams{
  1472. chatRoomRetrieverParams: chatRoomRetrieverParams{
  1473. allChatRoomsParams: allChatRoomsParams{
  1474. {
  1475. exchange: state.PublicExchange,
  1476. result: []state.ChatRoom{},
  1477. },
  1478. },
  1479. },
  1480. },
  1481. },
  1482. }
  1483. for _, tc := range tt {
  1484. t.Run(tc.name, func(t *testing.T) {
  1485. request := httptest.NewRequest(http.MethodGet, "/chat/room/public", nil)
  1486. responseRecorder := httptest.NewRecorder()
  1487. chatRoomRetriever := newMockChatRoomRetriever(t)
  1488. for _, params := range tc.mockParams.allChatRoomsParams {
  1489. chatRoomRetriever.EXPECT().
  1490. AllChatRooms(matchContext(), params.exchange).
  1491. Return(params.result, params.err)
  1492. }
  1493. chatSessionRetriever := newMockChatSessionRetriever(t)
  1494. for _, params := range tc.mockParams.chatSessionRetrieverAllSessionsParams {
  1495. chatSessionRetriever.EXPECT().
  1496. AllSessions(params.cookie).
  1497. Return(params.result)
  1498. }
  1499. getPublicChatHandler(responseRecorder, request, chatRoomRetriever, chatSessionRetriever, slog.Default())
  1500. if responseRecorder.Code != tc.statusCode {
  1501. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1502. }
  1503. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1504. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  1505. }
  1506. })
  1507. }
  1508. }
  1509. func TestDeletePublicChatHandler(t *testing.T) {
  1510. tt := []struct {
  1511. name string
  1512. body string
  1513. want string
  1514. statusCode int
  1515. mockParams mockParams
  1516. }{
  1517. {
  1518. name: "successful deletion of single chat room",
  1519. body: `{"names":["TestRoom"]}`,
  1520. want: `Chat rooms deleted successfully.`,
  1521. statusCode: http.StatusNoContent,
  1522. mockParams: mockParams{
  1523. chatRoomDeleterParams: chatRoomDeleterParams{
  1524. deleteChatRoomsParams: deleteChatRoomsParams{
  1525. {
  1526. exchange: state.PublicExchange,
  1527. names: []string{"TestRoom"},
  1528. },
  1529. },
  1530. },
  1531. },
  1532. },
  1533. {
  1534. name: "successful deletion of multiple chat rooms",
  1535. body: `{"names":["Room1", "Room2", "Room3"]}`,
  1536. want: `Chat rooms deleted successfully.`,
  1537. statusCode: http.StatusNoContent,
  1538. mockParams: mockParams{
  1539. chatRoomDeleterParams: chatRoomDeleterParams{
  1540. deleteChatRoomsParams: deleteChatRoomsParams{
  1541. {
  1542. exchange: state.PublicExchange,
  1543. names: []string{"Room1", "Room2", "Room3"},
  1544. },
  1545. },
  1546. },
  1547. },
  1548. },
  1549. {
  1550. name: "empty names array",
  1551. body: `{"names":[]}`,
  1552. want: `no chat room names provided`,
  1553. statusCode: http.StatusBadRequest,
  1554. },
  1555. {
  1556. name: "malformed JSON",
  1557. body: `{"names":["Room1"`, // missing closing brackets
  1558. want: `malformed input`,
  1559. statusCode: http.StatusBadRequest,
  1560. },
  1561. {
  1562. name: "deletion error",
  1563. body: `{"names":["TestRoom"]}`,
  1564. want: `internal server error`,
  1565. statusCode: http.StatusInternalServerError,
  1566. mockParams: mockParams{
  1567. chatRoomDeleterParams: chatRoomDeleterParams{
  1568. deleteChatRoomsParams: deleteChatRoomsParams{
  1569. {
  1570. exchange: state.PublicExchange,
  1571. names: []string{"TestRoom"},
  1572. err: errors.New("database error"),
  1573. },
  1574. },
  1575. },
  1576. },
  1577. },
  1578. }
  1579. for _, tc := range tt {
  1580. t.Run(tc.name, func(t *testing.T) {
  1581. request := httptest.NewRequest(http.MethodDelete, "/chat/room/public", strings.NewReader(tc.body))
  1582. responseRecorder := httptest.NewRecorder()
  1583. chatRoomDeleter := newMockChatRoomDeleter(t)
  1584. for _, params := range tc.mockParams.deleteChatRoomsParams {
  1585. chatRoomDeleter.EXPECT().
  1586. DeleteChatRooms(matchContext(), params.exchange, params.names).
  1587. Return(params.err)
  1588. }
  1589. deletePublicChatHandler(responseRecorder, request, chatRoomDeleter, slog.Default())
  1590. if responseRecorder.Code != tc.statusCode {
  1591. t.Errorf("want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1592. }
  1593. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1594. t.Errorf("want '%s', got '%s'", tc.want, responseRecorder.Body)
  1595. }
  1596. })
  1597. }
  1598. }
  1599. func TestPrivateChatHandler_GET(t *testing.T) {
  1600. fnNewSess := func(screenName string) *state.Session {
  1601. sess := state.NewSession()
  1602. sess.SetIdentScreenName(state.NewIdentScreenName(screenName))
  1603. sess.SetDisplayScreenName(state.DisplayScreenName(screenName))
  1604. instance := sess.AddInstance()
  1605. instance.SetSignonComplete()
  1606. return sess
  1607. }
  1608. chatRoom1 := state.NewChatRoom("chat-room-1-name", state.NewIdentScreenName("chat-room-1-creator"), state.PrivateExchange)
  1609. chatRoom2 := state.NewChatRoom("chat-room-2-name", state.NewIdentScreenName("chat-room-2-creator"), state.PrivateExchange)
  1610. tt := []struct {
  1611. name string
  1612. want string
  1613. statusCode int
  1614. mockParams mockParams
  1615. }{
  1616. {
  1617. name: "multiple chat rooms with participants",
  1618. want: `[{"name":"chat-room-1-name","create_time":"0001-01-01T00:00:00Z","creator_id":"chat-room-1-creator","url":"aim:gochat?roomname=chat-room-1-name&exchange=4","participants":[{"id":"usera","screen_name":"userA"},{"id":"userb","screen_name":"userB"}]},{"name":"chat-room-2-name","create_time":"0001-01-01T00:00:00Z","creator_id":"chat-room-2-creator","url":"aim:gochat?roomname=chat-room-2-name&exchange=4","participants":[{"id":"userc","screen_name":"userC"},{"id":"userd","screen_name":"userD"}]}]`,
  1619. statusCode: http.StatusOK,
  1620. mockParams: mockParams{
  1621. chatRoomRetrieverParams: chatRoomRetrieverParams{
  1622. allChatRoomsParams: allChatRoomsParams{
  1623. {
  1624. exchange: state.PrivateExchange,
  1625. result: []state.ChatRoom{
  1626. chatRoom1,
  1627. chatRoom2,
  1628. },
  1629. },
  1630. },
  1631. },
  1632. chatSessionRetrieverParams: chatSessionRetrieverParams{
  1633. chatSessionRetrieverAllSessionsParams: chatSessionRetrieverAllSessionsParams{
  1634. {
  1635. cookie: chatRoom1.Cookie(),
  1636. result: []*state.Session{
  1637. fnNewSess("userA"),
  1638. fnNewSess("userB"),
  1639. },
  1640. },
  1641. {
  1642. cookie: chatRoom2.Cookie(),
  1643. result: []*state.Session{
  1644. fnNewSess("userC"),
  1645. fnNewSess("userD"),
  1646. },
  1647. },
  1648. },
  1649. },
  1650. },
  1651. },
  1652. {
  1653. name: "chat room without participants",
  1654. want: `[{"name":"chat-room-1-name","create_time":"0001-01-01T00:00:00Z","creator_id":"chat-room-1-creator","url":"aim:gochat?roomname=chat-room-1-name&exchange=4","participants":[]}]`,
  1655. statusCode: http.StatusOK,
  1656. mockParams: mockParams{
  1657. chatRoomRetrieverParams: chatRoomRetrieverParams{
  1658. allChatRoomsParams: allChatRoomsParams{
  1659. {
  1660. exchange: state.PrivateExchange,
  1661. result: []state.ChatRoom{
  1662. chatRoom1,
  1663. },
  1664. },
  1665. },
  1666. },
  1667. chatSessionRetrieverParams: chatSessionRetrieverParams{
  1668. chatSessionRetrieverAllSessionsParams: chatSessionRetrieverAllSessionsParams{
  1669. {
  1670. cookie: chatRoom1.Cookie(),
  1671. result: []*state.Session{},
  1672. },
  1673. },
  1674. },
  1675. },
  1676. },
  1677. {
  1678. name: "no chat rooms",
  1679. want: `[]`,
  1680. statusCode: http.StatusOK,
  1681. mockParams: mockParams{
  1682. chatRoomRetrieverParams: chatRoomRetrieverParams{
  1683. allChatRoomsParams: allChatRoomsParams{
  1684. {
  1685. exchange: state.PrivateExchange,
  1686. result: []state.ChatRoom{},
  1687. },
  1688. },
  1689. },
  1690. },
  1691. },
  1692. }
  1693. for _, tc := range tt {
  1694. t.Run(tc.name, func(t *testing.T) {
  1695. request := httptest.NewRequest(http.MethodGet, "/chat/room/private", nil)
  1696. responseRecorder := httptest.NewRecorder()
  1697. chatRoomRetriever := newMockChatRoomRetriever(t)
  1698. for _, params := range tc.mockParams.allChatRoomsParams {
  1699. chatRoomRetriever.EXPECT().
  1700. AllChatRooms(matchContext(), params.exchange).
  1701. Return(params.result, params.err)
  1702. }
  1703. chatSessionRetriever := newMockChatSessionRetriever(t)
  1704. for _, params := range tc.mockParams.chatSessionRetrieverAllSessionsParams {
  1705. chatSessionRetriever.EXPECT().
  1706. AllSessions(params.cookie).
  1707. Return(params.result)
  1708. }
  1709. getPrivateChatHandler(responseRecorder, request, chatRoomRetriever, chatSessionRetriever, slog.Default())
  1710. if responseRecorder.Code != tc.statusCode {
  1711. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1712. }
  1713. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1714. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  1715. }
  1716. })
  1717. }
  1718. }
  1719. func TestInstantMessageHandler_POST(t *testing.T) {
  1720. senderExists := getUserParams{
  1721. {
  1722. screenName: state.NewIdentScreenName("sender_sn"),
  1723. result: &state.User{IdentScreenName: state.NewIdentScreenName("sender_sn")},
  1724. },
  1725. }
  1726. tt := []struct {
  1727. name string
  1728. body string
  1729. getUserParams getUserParams
  1730. wantText string
  1731. wantStore bool
  1732. sendCalled bool
  1733. reply *wire.SNACMessage
  1734. sendErr error
  1735. want string
  1736. statusCode int
  1737. }{
  1738. {
  1739. name: "send an instant message",
  1740. body: `{"from":"sender_sn","to":"recip_sn","text":"hello world!"}`,
  1741. getUserParams: senderExists,
  1742. sendCalled: true,
  1743. want: `Message sent successfully.`,
  1744. statusCode: http.StatusOK,
  1745. },
  1746. {
  1747. name: "send an instant message with non-ASCII text",
  1748. body: `{"from":"sender_sn","to":"recip_sn","text":"héllo wörld 日本 😀"}`,
  1749. wantText: "héllo wörld 日本 \uFFFD",
  1750. getUserParams: senderExists,
  1751. sendCalled: true,
  1752. want: `Message sent successfully.`,
  1753. statusCode: http.StatusOK,
  1754. },
  1755. {
  1756. name: "recipient is offline",
  1757. body: `{"from":"sender_sn","to":"recip_sn","text":"hello world!"}`,
  1758. getUserParams: senderExists,
  1759. sendCalled: true,
  1760. reply: &wire.SNACMessage{
  1761. Frame: wire.SNACFrame{FoodGroup: wire.ICBM, SubGroup: wire.ICBMErr},
  1762. Body: wire.SNACError{Code: wire.ErrorCodeNotLoggedOn},
  1763. },
  1764. want: `recipient is not online`,
  1765. statusCode: http.StatusNotFound,
  1766. },
  1767. {
  1768. name: "store message for offline recipient",
  1769. body: `{"from":"sender_sn","to":"recip_sn","text":"hello world!","storeOffline":true}`,
  1770. wantStore: true,
  1771. getUserParams: senderExists,
  1772. sendCalled: true,
  1773. want: `Message sent successfully.`,
  1774. statusCode: http.StatusOK,
  1775. },
  1776. {
  1777. name: "offline recipient does not accept stored message",
  1778. body: `{"from":"sender_sn","to":"recip_sn","text":"hello world!","storeOffline":true}`,
  1779. wantStore: true,
  1780. getUserParams: senderExists,
  1781. sendCalled: true,
  1782. reply: &wire.SNACMessage{
  1783. Frame: wire.SNACFrame{FoodGroup: wire.ICBM, SubGroup: wire.ICBMErr},
  1784. Body: wire.SNACError{Code: wire.ErrorCodeNotLoggedOn},
  1785. },
  1786. want: `recipient is not online`,
  1787. statusCode: http.StatusNotFound,
  1788. },
  1789. {
  1790. name: "do not store message for offline recipient",
  1791. body: `{"from":"sender_sn","to":"recip_sn","text":"hello world!","storeOffline":false}`,
  1792. getUserParams: senderExists,
  1793. sendCalled: true,
  1794. reply: &wire.SNACMessage{
  1795. Frame: wire.SNACFrame{FoodGroup: wire.ICBM, SubGroup: wire.ICBMErr},
  1796. Body: wire.SNACError{Code: wire.ErrorCodeNotLoggedOn},
  1797. },
  1798. want: `recipient is not online`,
  1799. statusCode: http.StatusNotFound,
  1800. },
  1801. {
  1802. name: "sender is blocked",
  1803. body: `{"from":"sender_sn","to":"recip_sn","text":"hello world!"}`,
  1804. getUserParams: senderExists,
  1805. sendCalled: true,
  1806. reply: &wire.SNACMessage{
  1807. Frame: wire.SNACFrame{FoodGroup: wire.ICBM, SubGroup: wire.ICBMErr},
  1808. Body: wire.SNACError{Code: wire.ErrorCodeInLocalPermitDeny},
  1809. },
  1810. want: `message blocked`,
  1811. statusCode: http.StatusForbidden,
  1812. },
  1813. {
  1814. name: "send fails",
  1815. body: `{"from":"sender_sn","to":"recip_sn","text":"hello world!"}`,
  1816. getUserParams: senderExists,
  1817. sendCalled: true,
  1818. sendErr: io.EOF,
  1819. want: `internal server error`,
  1820. statusCode: http.StatusInternalServerError,
  1821. },
  1822. {
  1823. name: "sender does not exist",
  1824. body: `{"from":"sender_sn","to":"recip_sn","text":"hello world!","storeOffline":true}`,
  1825. getUserParams: getUserParams{
  1826. {
  1827. screenName: state.NewIdentScreenName("sender_sn"),
  1828. result: nil,
  1829. },
  1830. },
  1831. want: `sender does not exist`,
  1832. statusCode: http.StatusBadRequest,
  1833. },
  1834. {
  1835. name: "sender lookup fails",
  1836. body: `{"from":"sender_sn","to":"recip_sn","text":"hello world!"}`,
  1837. getUserParams: getUserParams{
  1838. {
  1839. screenName: state.NewIdentScreenName("sender_sn"),
  1840. err: io.EOF,
  1841. },
  1842. },
  1843. want: `internal server error`,
  1844. statusCode: http.StatusInternalServerError,
  1845. },
  1846. {
  1847. name: "with malformed body",
  1848. body: `{"screen_name":"userA", "password":"thepassword"`,
  1849. want: `malformed input`,
  1850. statusCode: http.StatusBadRequest,
  1851. },
  1852. }
  1853. for _, tc := range tt {
  1854. t.Run(tc.name, func(t *testing.T) {
  1855. request := httptest.NewRequest(http.MethodPost, "/instant-message", strings.NewReader(tc.body))
  1856. responseRecorder := httptest.NewRecorder()
  1857. userManager := newMockUserManager(t)
  1858. for _, params := range tc.getUserParams {
  1859. userManager.EXPECT().
  1860. User(matchContext(), params.screenName).
  1861. Return(params.result, params.err)
  1862. }
  1863. sendCalled := false
  1864. icbmSender := func(ctx context.Context, instance *state.SessionInstance, inFrame wire.SNACFrame, inBody wire.SNAC_0x04_0x06_ICBMChannelMsgToHost) (*wire.SNACMessage, error) {
  1865. sendCalled = true
  1866. assert.Equal(t, state.NewIdentScreenName("sender_sn"), instance.IdentScreenName())
  1867. assert.Equal(t, wire.ICBM, inFrame.FoodGroup)
  1868. assert.Equal(t, wire.ICBMChannelMsgToHost, inFrame.SubGroup)
  1869. assert.Equal(t, "recip_sn", inBody.ScreenName)
  1870. assert.Equal(t, wire.ICBMChannelIM, inBody.ChannelID)
  1871. assert.Equal(t, [][16]byte{wire.CapUTF8Messages}, instance.Caps())
  1872. _, hasStore := inBody.Bytes(wire.ICBMTLVStore)
  1873. assert.Equal(t, tc.wantStore, hasStore)
  1874. wantText := tc.wantText
  1875. if wantText == "" {
  1876. wantText = "hello world!"
  1877. }
  1878. wantCharset := wire.ICBMMessageEncodingUnicode
  1879. if wire.AllASCII(wantText) {
  1880. wantCharset = wire.ICBMMessageEncodingASCII
  1881. }
  1882. b, ok := inBody.Bytes(wire.ICBMTLVAOLIMData)
  1883. assert.True(t, ok)
  1884. var frags []wire.ICBMCh1Fragment
  1885. assert.NoError(t, wire.UnmarshalBE(&frags, bytes.NewBuffer(b)))
  1886. for _, frag := range frags {
  1887. if frag.ID == 1 {
  1888. msg := wire.ICBMCh1Message{}
  1889. assert.NoError(t, wire.UnmarshalBE(&msg, bytes.NewBuffer(frag.Payload)))
  1890. assert.Equal(t, wantCharset, msg.Charset)
  1891. }
  1892. }
  1893. txt, err := wire.UnmarshalICBMMessageText(b)
  1894. assert.NoError(t, err)
  1895. assert.Equal(t, wantText, txt)
  1896. return tc.reply, tc.sendErr
  1897. }
  1898. postInstantMessageHandler(responseRecorder, request, userManager, icbmSender, slog.Default())
  1899. assert.Equal(t, tc.sendCalled, sendCalled)
  1900. assert.Equal(t, tc.statusCode, responseRecorder.Code)
  1901. assert.Equal(t, tc.want, strings.TrimSpace(responseRecorder.Body.String()))
  1902. })
  1903. }
  1904. }
  1905. func TestVersionHandler_GET(t *testing.T) {
  1906. tt := []struct {
  1907. name string
  1908. want string
  1909. statusCode int
  1910. buildInfo config.Build
  1911. }{
  1912. {
  1913. name: "get ras version",
  1914. want: `{"version":"13.3.7","commit":"asdfASDF12345678","date":"2024-03-01"}`,
  1915. statusCode: http.StatusOK,
  1916. buildInfo: config.Build{
  1917. Version: "13.3.7",
  1918. Commit: "asdfASDF12345678",
  1919. Date: "2024-03-01",
  1920. },
  1921. },
  1922. }
  1923. for _, tc := range tt {
  1924. t.Run(tc.name, func(t *testing.T) {
  1925. responseRecorder := httptest.NewRecorder()
  1926. getVersionHandler(responseRecorder, tc.buildInfo)
  1927. if responseRecorder.Code != tc.statusCode {
  1928. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1929. }
  1930. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1931. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  1932. }
  1933. })
  1934. }
  1935. }
  1936. func TestDirectoryCategoryHandler_GET(t *testing.T) {
  1937. tt := []struct {
  1938. name string
  1939. want string
  1940. statusCode int
  1941. mockParams mockParams
  1942. }{
  1943. {
  1944. name: "no categories",
  1945. want: `[]`,
  1946. statusCode: http.StatusOK,
  1947. mockParams: mockParams{
  1948. directoryManagerParams: directoryManagerParams{
  1949. categoriesParams: categoriesParams{
  1950. {
  1951. result: nil,
  1952. },
  1953. },
  1954. },
  1955. },
  1956. },
  1957. {
  1958. name: "error fetching categories",
  1959. want: `{"message":"internal server error"}`,
  1960. statusCode: http.StatusInternalServerError,
  1961. mockParams: mockParams{
  1962. directoryManagerParams: directoryManagerParams{
  1963. categoriesParams: categoriesParams{
  1964. {
  1965. result: nil,
  1966. err: errors.New("error fetching categories"),
  1967. },
  1968. },
  1969. },
  1970. },
  1971. },
  1972. {
  1973. name: "fetch some categories",
  1974. want: `[{"id":1,"name":"category-1"},{"id":2,"name":"category-2"}]`,
  1975. statusCode: http.StatusOK,
  1976. mockParams: mockParams{
  1977. directoryManagerParams: directoryManagerParams{
  1978. categoriesParams: categoriesParams{
  1979. {
  1980. result: []state.Category{
  1981. {
  1982. ID: 1,
  1983. Name: "category-1",
  1984. },
  1985. {
  1986. ID: 2,
  1987. Name: "category-2",
  1988. },
  1989. },
  1990. },
  1991. },
  1992. },
  1993. },
  1994. },
  1995. }
  1996. for _, tc := range tt {
  1997. t.Run(tc.name, func(t *testing.T) {
  1998. responseRecorder := httptest.NewRecorder()
  1999. request := httptest.NewRequest(http.MethodGet, "/directory/category", nil)
  2000. directoryManager := newMockDirectoryManager(t)
  2001. for _, params := range tc.mockParams.categoriesParams {
  2002. directoryManager.EXPECT().
  2003. Categories(matchContext()).
  2004. Return(params.result, params.err)
  2005. }
  2006. getDirectoryCategoryHandler(responseRecorder, request, directoryManager, slog.Default())
  2007. if responseRecorder.Code != tc.statusCode {
  2008. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  2009. }
  2010. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  2011. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  2012. }
  2013. })
  2014. }
  2015. }
  2016. func TestDirectoryCategoryKeywordHandler_GET(t *testing.T) {
  2017. tt := []struct {
  2018. name string
  2019. categoryID int
  2020. want string
  2021. statusCode int
  2022. mockParams mockParams
  2023. }{
  2024. {
  2025. name: "category not found",
  2026. categoryID: 1,
  2027. want: `{"message":"category not found"}`,
  2028. statusCode: http.StatusNotFound,
  2029. mockParams: mockParams{
  2030. directoryManagerParams: directoryManagerParams{
  2031. keywordsByCategoryParams: keywordsByCategoryParams{
  2032. {
  2033. categoryID: 1,
  2034. result: nil,
  2035. err: state.ErrKeywordCategoryNotFound,
  2036. },
  2037. },
  2038. },
  2039. },
  2040. },
  2041. {
  2042. name: "error fetching keywords by category",
  2043. categoryID: 1,
  2044. want: `{"message":"internal server error"}`,
  2045. statusCode: http.StatusInternalServerError,
  2046. mockParams: mockParams{
  2047. directoryManagerParams: directoryManagerParams{
  2048. keywordsByCategoryParams: keywordsByCategoryParams{
  2049. {
  2050. categoryID: 1,
  2051. result: nil,
  2052. err: errors.New("error fetching keywords by category"),
  2053. },
  2054. },
  2055. },
  2056. },
  2057. },
  2058. {
  2059. name: "invalid category ID",
  2060. categoryID: -1,
  2061. want: `{"message":"invalid category ID"}`,
  2062. statusCode: http.StatusBadRequest,
  2063. mockParams: mockParams{
  2064. directoryManagerParams: directoryManagerParams{
  2065. keywordsByCategoryParams: keywordsByCategoryParams{},
  2066. },
  2067. },
  2068. },
  2069. {
  2070. name: "no keywords",
  2071. categoryID: 1,
  2072. want: `[]`,
  2073. statusCode: http.StatusOK,
  2074. mockParams: mockParams{
  2075. directoryManagerParams: directoryManagerParams{
  2076. keywordsByCategoryParams: keywordsByCategoryParams{
  2077. {
  2078. categoryID: 1,
  2079. result: nil,
  2080. },
  2081. },
  2082. },
  2083. },
  2084. },
  2085. {
  2086. name: "fetch some keywords by category",
  2087. categoryID: 1,
  2088. want: `[{"id":1,"name":"keyword-1"},{"id":2,"name":"keyword-2"}]`,
  2089. statusCode: http.StatusOK,
  2090. mockParams: mockParams{
  2091. directoryManagerParams: directoryManagerParams{
  2092. keywordsByCategoryParams: keywordsByCategoryParams{
  2093. {
  2094. categoryID: 1,
  2095. result: []state.Keyword{
  2096. {
  2097. ID: 1,
  2098. Name: "keyword-1",
  2099. },
  2100. {
  2101. ID: 2,
  2102. Name: "keyword-2",
  2103. },
  2104. },
  2105. },
  2106. },
  2107. },
  2108. },
  2109. },
  2110. }
  2111. for _, tc := range tt {
  2112. t.Run(tc.name, func(t *testing.T) {
  2113. request := httptest.NewRequest(http.MethodGet, fmt.Sprintf("/directory/category/%d/keyword", tc.categoryID), nil)
  2114. request.SetPathValue("id", fmt.Sprintf("%d", tc.categoryID))
  2115. responseRecorder := httptest.NewRecorder()
  2116. directoryManager := newMockDirectoryManager(t)
  2117. for _, params := range tc.mockParams.keywordsByCategoryParams {
  2118. directoryManager.EXPECT().
  2119. KeywordsByCategory(matchContext(), params.categoryID).
  2120. Return(params.result, params.err)
  2121. }
  2122. getDirectoryCategoryKeywordHandler(responseRecorder, request, directoryManager, slog.Default())
  2123. if responseRecorder.Code != tc.statusCode {
  2124. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  2125. }
  2126. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  2127. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  2128. }
  2129. })
  2130. }
  2131. }
  2132. func TestDirectoryCategoryHandler_DELETE(t *testing.T) {
  2133. tt := []struct {
  2134. name string
  2135. categoryID int
  2136. want string
  2137. statusCode int
  2138. mockParams mockParams
  2139. }{
  2140. {
  2141. name: "category not found",
  2142. categoryID: 1,
  2143. want: `{"message":"category not found"}`,
  2144. statusCode: http.StatusNotFound,
  2145. mockParams: mockParams{
  2146. directoryManagerParams: directoryManagerParams{
  2147. deleteCategoryParams: deleteCategoryParams{
  2148. {
  2149. categoryID: 1,
  2150. err: state.ErrKeywordCategoryNotFound,
  2151. },
  2152. },
  2153. },
  2154. },
  2155. },
  2156. {
  2157. name: "keyword in use by user",
  2158. categoryID: 1,
  2159. want: `{"message":"can't delete because category in use by a user"}`,
  2160. statusCode: http.StatusConflict,
  2161. mockParams: mockParams{
  2162. directoryManagerParams: directoryManagerParams{
  2163. deleteCategoryParams: deleteCategoryParams{
  2164. {
  2165. categoryID: 1,
  2166. err: state.ErrKeywordInUse,
  2167. },
  2168. },
  2169. },
  2170. },
  2171. },
  2172. {
  2173. name: "runtime error",
  2174. categoryID: 1,
  2175. want: `{"message":"internal server error"}`,
  2176. statusCode: http.StatusInternalServerError,
  2177. mockParams: mockParams{
  2178. directoryManagerParams: directoryManagerParams{
  2179. deleteCategoryParams: deleteCategoryParams{
  2180. {
  2181. categoryID: 1,
  2182. err: errors.New("error deleting keyword"),
  2183. },
  2184. },
  2185. },
  2186. },
  2187. },
  2188. {
  2189. name: "successful deletion",
  2190. categoryID: 1,
  2191. want: ``,
  2192. statusCode: http.StatusNoContent,
  2193. mockParams: mockParams{
  2194. directoryManagerParams: directoryManagerParams{
  2195. deleteCategoryParams: deleteCategoryParams{
  2196. {
  2197. categoryID: 1,
  2198. },
  2199. },
  2200. },
  2201. },
  2202. },
  2203. {
  2204. name: "invalid category ID",
  2205. categoryID: -1,
  2206. want: `invalid category ID`,
  2207. statusCode: http.StatusBadRequest,
  2208. mockParams: mockParams{
  2209. directoryManagerParams: directoryManagerParams{
  2210. deleteCategoryParams: deleteCategoryParams{},
  2211. },
  2212. },
  2213. },
  2214. }
  2215. for _, tc := range tt {
  2216. t.Run(tc.name, func(t *testing.T) {
  2217. request := httptest.NewRequest(http.MethodDelete, fmt.Sprintf("/directory/category/%d/keyword", tc.categoryID), nil)
  2218. request.SetPathValue("id", fmt.Sprintf("%d", tc.categoryID))
  2219. responseRecorder := httptest.NewRecorder()
  2220. directoryManager := newMockDirectoryManager(t)
  2221. for _, params := range tc.mockParams.deleteCategoryParams {
  2222. directoryManager.EXPECT().
  2223. DeleteCategory(matchContext(), params.categoryID).
  2224. Return(params.err)
  2225. }
  2226. deleteDirectoryCategoryHandler(responseRecorder, request, directoryManager, slog.Default())
  2227. if responseRecorder.Code != tc.statusCode {
  2228. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  2229. }
  2230. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  2231. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  2232. }
  2233. })
  2234. }
  2235. }
  2236. func TestDirectoryCategoryHandler_POST(t *testing.T) {
  2237. tt := []struct {
  2238. name string
  2239. body string
  2240. want string
  2241. statusCode int
  2242. mockParams mockParams
  2243. }{
  2244. {
  2245. name: "category already exists",
  2246. body: `{"name":"the_category"}`,
  2247. want: `{"message":"category already exists"}`,
  2248. statusCode: http.StatusConflict,
  2249. mockParams: mockParams{
  2250. directoryManagerParams: directoryManagerParams{
  2251. createCategoryParams: createCategoryParams{
  2252. {
  2253. name: "the_category",
  2254. err: state.ErrKeywordCategoryExists,
  2255. },
  2256. },
  2257. },
  2258. },
  2259. },
  2260. {
  2261. name: "runtime error",
  2262. body: `{"name":"the_category"}`,
  2263. want: `{"message":"internal server error"}`,
  2264. statusCode: http.StatusInternalServerError,
  2265. mockParams: mockParams{
  2266. directoryManagerParams: directoryManagerParams{
  2267. createCategoryParams: createCategoryParams{
  2268. {
  2269. name: "the_category",
  2270. err: errors.New("error creating category"),
  2271. },
  2272. },
  2273. },
  2274. },
  2275. },
  2276. {
  2277. name: "bad input",
  2278. body: `{"name":"the_category"`,
  2279. want: `{"message":"malformed input"}`,
  2280. statusCode: http.StatusBadRequest,
  2281. mockParams: mockParams{
  2282. directoryManagerParams: directoryManagerParams{
  2283. createCategoryParams: createCategoryParams{},
  2284. },
  2285. },
  2286. },
  2287. {
  2288. name: "successful creation",
  2289. body: `{"name":"the_category"}`,
  2290. want: `{"id":1,"name":"the_category"}`,
  2291. statusCode: http.StatusCreated,
  2292. mockParams: mockParams{
  2293. directoryManagerParams: directoryManagerParams{
  2294. createCategoryParams: createCategoryParams{
  2295. {
  2296. name: "the_category",
  2297. result: state.Category{
  2298. ID: 1,
  2299. Name: "the_category",
  2300. },
  2301. },
  2302. },
  2303. },
  2304. },
  2305. },
  2306. }
  2307. for _, tc := range tt {
  2308. t.Run(tc.name, func(t *testing.T) {
  2309. request := httptest.NewRequest(http.MethodPost, "/directory/category", strings.NewReader(tc.body))
  2310. responseRecorder := httptest.NewRecorder()
  2311. directoryManager := newMockDirectoryManager(t)
  2312. for _, params := range tc.mockParams.createCategoryParams {
  2313. directoryManager.EXPECT().
  2314. CreateCategory(matchContext(), params.name).
  2315. Return(params.result, params.err)
  2316. }
  2317. postDirectoryCategoryHandler(responseRecorder, request, directoryManager, slog.Default())
  2318. if responseRecorder.Code != tc.statusCode {
  2319. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  2320. }
  2321. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  2322. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  2323. }
  2324. })
  2325. }
  2326. }
  2327. func TestDirectoryKeywordHandler_POST(t *testing.T) {
  2328. tt := []struct {
  2329. name string
  2330. body string
  2331. want string
  2332. statusCode int
  2333. mockParams mockParams
  2334. }{
  2335. {
  2336. name: "keyword already exists",
  2337. body: `{"category_id":1,"name":"the_keyword"}`,
  2338. want: `{"message":"keyword already exists"}`,
  2339. statusCode: http.StatusConflict,
  2340. mockParams: mockParams{
  2341. directoryManagerParams: directoryManagerParams{
  2342. createKeywordParams: createKeywordParams{
  2343. {
  2344. name: "the_keyword",
  2345. categoryID: 1,
  2346. err: state.ErrKeywordExists,
  2347. },
  2348. },
  2349. },
  2350. },
  2351. },
  2352. {
  2353. name: "category not found",
  2354. body: `{"category_id":1,"name":"the_keyword"}`,
  2355. want: `{"message":"category not found"}`,
  2356. statusCode: http.StatusNotFound,
  2357. mockParams: mockParams{
  2358. directoryManagerParams: directoryManagerParams{
  2359. createKeywordParams: createKeywordParams{
  2360. {
  2361. name: "the_keyword",
  2362. categoryID: 1,
  2363. err: state.ErrKeywordCategoryNotFound,
  2364. },
  2365. },
  2366. },
  2367. },
  2368. },
  2369. {
  2370. name: "runtime error",
  2371. body: `{"category_id":1,"name":"the_keyword"}`,
  2372. want: `{"message":"internal server error"}`,
  2373. statusCode: http.StatusInternalServerError,
  2374. mockParams: mockParams{
  2375. directoryManagerParams: directoryManagerParams{
  2376. createKeywordParams: createKeywordParams{
  2377. {
  2378. name: "the_keyword",
  2379. categoryID: 1,
  2380. err: errors.New("error creating keyword"),
  2381. },
  2382. },
  2383. },
  2384. },
  2385. },
  2386. {
  2387. name: "bad input",
  2388. body: `{"category_id":1,"name":"the_keyword"`,
  2389. want: `{"message":"malformed input"}`,
  2390. statusCode: http.StatusBadRequest,
  2391. mockParams: mockParams{
  2392. directoryManagerParams: directoryManagerParams{
  2393. createKeywordParams: createKeywordParams{},
  2394. },
  2395. },
  2396. },
  2397. {
  2398. name: "successful creation",
  2399. body: `{"category_id":1,"name":"the_keyword"}`,
  2400. want: `{"id":1,"name":"the_keyword"}`,
  2401. statusCode: http.StatusCreated,
  2402. mockParams: mockParams{
  2403. directoryManagerParams: directoryManagerParams{
  2404. createKeywordParams: createKeywordParams{
  2405. {
  2406. name: "the_keyword",
  2407. categoryID: 1,
  2408. result: state.Keyword{
  2409. ID: 1,
  2410. Name: "the_keyword",
  2411. },
  2412. },
  2413. },
  2414. },
  2415. },
  2416. },
  2417. }
  2418. for _, tc := range tt {
  2419. t.Run(tc.name, func(t *testing.T) {
  2420. request := httptest.NewRequest(http.MethodPost, "/directory/keyword", strings.NewReader(tc.body))
  2421. responseRecorder := httptest.NewRecorder()
  2422. directoryManager := newMockDirectoryManager(t)
  2423. for _, params := range tc.mockParams.createKeywordParams {
  2424. directoryManager.EXPECT().
  2425. CreateKeyword(matchContext(), params.name, params.categoryID).
  2426. Return(params.result, params.err)
  2427. }
  2428. postDirectoryKeywordHandler(responseRecorder, request, directoryManager, slog.Default())
  2429. if responseRecorder.Code != tc.statusCode {
  2430. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  2431. }
  2432. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  2433. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  2434. }
  2435. })
  2436. }
  2437. }
  2438. func TestDirectoryKeywordHandler_DELETE(t *testing.T) {
  2439. tt := []struct {
  2440. name string
  2441. categoryID int
  2442. want string
  2443. statusCode int
  2444. mockParams mockParams
  2445. }{
  2446. {
  2447. name: "keyword not found",
  2448. categoryID: 1,
  2449. want: `{"message":"keyword not found"}`,
  2450. statusCode: http.StatusNotFound,
  2451. mockParams: mockParams{
  2452. directoryManagerParams: directoryManagerParams{
  2453. deleteKeywordParams: deleteKeywordParams{
  2454. {
  2455. id: 1,
  2456. err: state.ErrKeywordNotFound,
  2457. },
  2458. },
  2459. },
  2460. },
  2461. },
  2462. {
  2463. name: "keyword in use by user",
  2464. categoryID: 1,
  2465. want: `{"message":"can't delete because category in use by a user"}`,
  2466. statusCode: http.StatusConflict,
  2467. mockParams: mockParams{
  2468. directoryManagerParams: directoryManagerParams{
  2469. deleteKeywordParams: deleteKeywordParams{
  2470. {
  2471. id: 1,
  2472. err: state.ErrKeywordInUse,
  2473. },
  2474. },
  2475. },
  2476. },
  2477. },
  2478. {
  2479. name: "runtime error",
  2480. categoryID: 1,
  2481. want: `{"message":"internal server error"}`,
  2482. statusCode: http.StatusInternalServerError,
  2483. mockParams: mockParams{
  2484. directoryManagerParams: directoryManagerParams{
  2485. deleteKeywordParams: deleteKeywordParams{
  2486. {
  2487. id: 1,
  2488. err: errors.New("error deleting keyword"),
  2489. },
  2490. },
  2491. },
  2492. },
  2493. },
  2494. {
  2495. name: "successful deletion",
  2496. categoryID: 1,
  2497. want: ``,
  2498. statusCode: http.StatusNoContent,
  2499. mockParams: mockParams{
  2500. directoryManagerParams: directoryManagerParams{
  2501. deleteKeywordParams: deleteKeywordParams{
  2502. {
  2503. id: 1,
  2504. },
  2505. },
  2506. },
  2507. },
  2508. },
  2509. {
  2510. name: "invalid keyword ID",
  2511. categoryID: -1,
  2512. want: `{"message":"invalid keyword ID"}`,
  2513. statusCode: http.StatusBadRequest,
  2514. mockParams: mockParams{
  2515. directoryManagerParams: directoryManagerParams{
  2516. deleteKeywordParams: deleteKeywordParams{},
  2517. },
  2518. },
  2519. },
  2520. }
  2521. for _, tc := range tt {
  2522. t.Run(tc.name, func(t *testing.T) {
  2523. request := httptest.NewRequest(http.MethodDelete, fmt.Sprintf("/directory/keyword/%d", tc.categoryID), nil)
  2524. request.SetPathValue("id", fmt.Sprintf("%d", tc.categoryID))
  2525. responseRecorder := httptest.NewRecorder()
  2526. directoryManager := newMockDirectoryManager(t)
  2527. for _, params := range tc.mockParams.deleteKeywordParams {
  2528. directoryManager.EXPECT().
  2529. DeleteKeyword(matchContext(), params.id).
  2530. Return(params.err)
  2531. }
  2532. deleteDirectoryKeywordHandler(responseRecorder, request, directoryManager, slog.Default())
  2533. if responseRecorder.Code != tc.statusCode {
  2534. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  2535. }
  2536. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  2537. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  2538. }
  2539. })
  2540. }
  2541. }
  2542. func TestBARTByTypeHandler_GET(t *testing.T) {
  2543. tt := []struct {
  2544. name string
  2545. queryParams string
  2546. wantStatusCode int
  2547. wantResponse string
  2548. mockParams mockParams
  2549. }{
  2550. {
  2551. name: "success with items",
  2552. queryParams: "?type=1",
  2553. wantStatusCode: http.StatusOK,
  2554. wantResponse: `[{"hash":"2B000001E4","type":1},{"hash":"2B000001B7","type":1}]`,
  2555. mockParams: mockParams{
  2556. bartAssetManagerParams: bartAssetManagerParams{
  2557. listBARTItemsParams: listBARTItemsParams{
  2558. {
  2559. itemType: 1,
  2560. result: []state.BARTItem{
  2561. {Hash: "2B000001E4", Type: 1},
  2562. {Hash: "2B000001B7", Type: 1},
  2563. },
  2564. err: nil,
  2565. },
  2566. },
  2567. },
  2568. },
  2569. },
  2570. {
  2571. name: "success with empty list",
  2572. queryParams: "?type=2",
  2573. wantStatusCode: http.StatusOK,
  2574. wantResponse: `[]`,
  2575. mockParams: mockParams{
  2576. bartAssetManagerParams: bartAssetManagerParams{
  2577. listBARTItemsParams: listBARTItemsParams{
  2578. {
  2579. itemType: 2,
  2580. result: []state.BARTItem{},
  2581. err: nil,
  2582. },
  2583. },
  2584. },
  2585. },
  2586. },
  2587. {
  2588. name: "missing type parameter",
  2589. queryParams: "",
  2590. wantStatusCode: http.StatusBadRequest,
  2591. wantResponse: `{"message":"type query parameter is required"}`,
  2592. },
  2593. {
  2594. name: "invalid type parameter",
  2595. queryParams: "?type=invalid",
  2596. wantStatusCode: http.StatusBadRequest,
  2597. wantResponse: `{"message":"invalid type ID"}`,
  2598. },
  2599. {
  2600. name: "internal server error",
  2601. queryParams: "?type=1",
  2602. wantStatusCode: http.StatusInternalServerError,
  2603. wantResponse: `{"message":"internal server error"}`,
  2604. mockParams: mockParams{
  2605. bartAssetManagerParams: bartAssetManagerParams{
  2606. listBARTItemsParams: listBARTItemsParams{
  2607. {
  2608. itemType: 1,
  2609. result: nil,
  2610. err: errors.New("database error"),
  2611. },
  2612. },
  2613. },
  2614. },
  2615. },
  2616. }
  2617. for _, tc := range tt {
  2618. t.Run(tc.name, func(t *testing.T) {
  2619. request := httptest.NewRequest(http.MethodGet, "/bart"+tc.queryParams, nil)
  2620. responseRecorder := httptest.NewRecorder()
  2621. mockBARTManager := newMockBARTAssetManager(t)
  2622. for _, params := range tc.mockParams.listBARTItemsParams {
  2623. mockBARTManager.EXPECT().
  2624. ListBARTItems(matchContext(), params.itemType).
  2625. Return(params.result, params.err)
  2626. }
  2627. getBARTByTypeHandler(responseRecorder, request, mockBARTManager, slog.Default())
  2628. assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
  2629. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  2630. })
  2631. }
  2632. }
  2633. func TestBARTHandler_GET(t *testing.T) {
  2634. tt := []struct {
  2635. name string
  2636. hash string
  2637. wantStatusCode int
  2638. wantResponse string
  2639. wantHeaders map[string]string
  2640. mockParams mockParams
  2641. }{
  2642. {
  2643. name: "success with valid hash",
  2644. hash: "2B000001E4",
  2645. wantStatusCode: http.StatusOK,
  2646. wantResponse: "binary data",
  2647. wantHeaders: map[string]string{"Content-Type": "application/octet-stream"},
  2648. mockParams: mockParams{
  2649. bartAssetManagerParams: bartAssetManagerParams{
  2650. bartItemParams: bartItemParams{
  2651. {
  2652. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2653. result: []byte("binary data"),
  2654. err: nil,
  2655. },
  2656. },
  2657. },
  2658. },
  2659. },
  2660. {
  2661. name: "missing hash parameter",
  2662. hash: "",
  2663. wantStatusCode: http.StatusBadRequest,
  2664. wantResponse: `{"message":"hash is required"}`,
  2665. },
  2666. {
  2667. name: "invalid hash format",
  2668. hash: "invalid-hex",
  2669. wantStatusCode: http.StatusBadRequest,
  2670. wantResponse: `{"message":"invalid hash format"}`,
  2671. },
  2672. {
  2673. name: "asset not found",
  2674. hash: "2B000001E4",
  2675. wantStatusCode: http.StatusNotFound,
  2676. wantResponse: `{"message":"BART asset not found"}`,
  2677. mockParams: mockParams{
  2678. bartAssetManagerParams: bartAssetManagerParams{
  2679. bartItemParams: bartItemParams{
  2680. {
  2681. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2682. result: []byte{},
  2683. err: nil,
  2684. },
  2685. },
  2686. },
  2687. },
  2688. },
  2689. {
  2690. name: "internal server error",
  2691. hash: "2B000001E4",
  2692. wantStatusCode: http.StatusInternalServerError,
  2693. wantResponse: `{"message":"internal server error"}`,
  2694. mockParams: mockParams{
  2695. bartAssetManagerParams: bartAssetManagerParams{
  2696. bartItemParams: bartItemParams{
  2697. {
  2698. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2699. result: nil,
  2700. err: errors.New("database error"),
  2701. },
  2702. },
  2703. },
  2704. },
  2705. },
  2706. }
  2707. for _, tc := range tt {
  2708. t.Run(tc.name, func(t *testing.T) {
  2709. request := httptest.NewRequest(http.MethodGet, "/bart/"+tc.hash, nil)
  2710. // Set the path value manually for testing
  2711. if tc.hash != "" {
  2712. request.SetPathValue("hash", tc.hash)
  2713. }
  2714. responseRecorder := httptest.NewRecorder()
  2715. mockBARTManager := newMockBARTAssetManager(t)
  2716. for _, params := range tc.mockParams.bartItemParams {
  2717. mockBARTManager.EXPECT().
  2718. BARTItem(matchContext(), params.hash).
  2719. Return(params.result, params.err)
  2720. }
  2721. getBARTHandler(responseRecorder, request, mockBARTManager, slog.Default())
  2722. assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
  2723. if tc.wantHeaders != nil {
  2724. for key, value := range tc.wantHeaders {
  2725. assert.Equal(t, value, responseRecorder.Header().Get(key))
  2726. }
  2727. }
  2728. if tc.wantStatusCode == http.StatusOK {
  2729. assert.Equal(t, tc.wantResponse, responseRecorder.Body.String())
  2730. } else {
  2731. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  2732. }
  2733. })
  2734. }
  2735. }
  2736. func TestBARTHandler_POST(t *testing.T) {
  2737. tt := []struct {
  2738. name string
  2739. hash string
  2740. queryParams string
  2741. requestBody string
  2742. wantStatusCode int
  2743. wantResponse string
  2744. mockParams mockParams
  2745. }{
  2746. {
  2747. name: "success with valid data",
  2748. hash: "2B000001E4",
  2749. queryParams: "?type=1",
  2750. requestBody: "binary data",
  2751. wantStatusCode: http.StatusCreated,
  2752. wantResponse: `{"hash":"2b000001e4","type":1}`,
  2753. mockParams: mockParams{
  2754. bartAssetManagerParams: bartAssetManagerParams{
  2755. insertBARTItemParams: insertBARTItemParams{
  2756. {
  2757. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2758. blob: []byte("binary data"),
  2759. itemType: 1,
  2760. err: nil,
  2761. },
  2762. },
  2763. },
  2764. },
  2765. },
  2766. {
  2767. name: "missing hash parameter",
  2768. hash: "",
  2769. queryParams: "?type=1",
  2770. requestBody: "binary data",
  2771. wantStatusCode: http.StatusBadRequest,
  2772. wantResponse: `{"message":"hash path parameter is required"}`,
  2773. },
  2774. {
  2775. name: "invalid hash format",
  2776. hash: "invalid-hex",
  2777. queryParams: "?type=1",
  2778. requestBody: "binary data",
  2779. wantStatusCode: http.StatusBadRequest,
  2780. wantResponse: `{"message":"invalid hash format"}`,
  2781. },
  2782. {
  2783. name: "missing type parameter",
  2784. hash: "2B000001E4",
  2785. queryParams: "",
  2786. requestBody: "binary data",
  2787. wantStatusCode: http.StatusBadRequest,
  2788. wantResponse: `{"message":"type query parameter is required"}`,
  2789. },
  2790. {
  2791. name: "invalid type parameter",
  2792. hash: "2B000001E4",
  2793. queryParams: "?type=invalid",
  2794. requestBody: "binary data",
  2795. wantStatusCode: http.StatusBadRequest,
  2796. wantResponse: `{"message":"invalid type ID"}`,
  2797. },
  2798. {
  2799. name: "failed to read request body",
  2800. hash: "2B000001E4",
  2801. queryParams: "?type=1",
  2802. requestBody: "", // This will cause an error when reading
  2803. wantStatusCode: http.StatusBadRequest,
  2804. wantResponse: `{"message":"failed to read request body"}`,
  2805. },
  2806. {
  2807. name: "asset already exists",
  2808. hash: "2B000001E4",
  2809. queryParams: "?type=1",
  2810. requestBody: "binary data",
  2811. wantStatusCode: http.StatusConflict,
  2812. wantResponse: `{"message":"BART asset already exists"}`,
  2813. mockParams: mockParams{
  2814. bartAssetManagerParams: bartAssetManagerParams{
  2815. insertBARTItemParams: insertBARTItemParams{
  2816. {
  2817. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2818. blob: []byte("binary data"),
  2819. itemType: 1,
  2820. err: state.ErrBARTItemExists,
  2821. },
  2822. },
  2823. },
  2824. },
  2825. },
  2826. {
  2827. name: "internal server error",
  2828. hash: "2B000001E4",
  2829. queryParams: "?type=1",
  2830. requestBody: "binary data",
  2831. wantStatusCode: http.StatusInternalServerError,
  2832. wantResponse: `{"message":"internal server error"}`,
  2833. mockParams: mockParams{
  2834. bartAssetManagerParams: bartAssetManagerParams{
  2835. insertBARTItemParams: insertBARTItemParams{
  2836. {
  2837. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2838. blob: []byte("binary data"),
  2839. itemType: 1,
  2840. err: errors.New("database error"),
  2841. },
  2842. },
  2843. },
  2844. },
  2845. },
  2846. }
  2847. for _, tc := range tt {
  2848. t.Run(tc.name, func(t *testing.T) {
  2849. var requestBody io.Reader
  2850. if tc.requestBody != "" {
  2851. requestBody = strings.NewReader(tc.requestBody)
  2852. } else {
  2853. requestBody = &errorReader{}
  2854. }
  2855. request := httptest.NewRequest(http.MethodPost, "/bart/"+tc.hash+tc.queryParams, requestBody)
  2856. // Set the path value manually for testing
  2857. if tc.hash != "" {
  2858. request.SetPathValue("hash", tc.hash)
  2859. }
  2860. responseRecorder := httptest.NewRecorder()
  2861. mockBARTManager := newMockBARTAssetManager(t)
  2862. for _, params := range tc.mockParams.insertBARTItemParams {
  2863. mockBARTManager.EXPECT().
  2864. InsertBARTItem(matchContext(), params.hash, params.blob, params.itemType).
  2865. Return(params.err)
  2866. }
  2867. postBARTHandler(responseRecorder, request, mockBARTManager, slog.Default())
  2868. assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
  2869. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  2870. })
  2871. }
  2872. }
  2873. func TestBARTHandler_DELETE(t *testing.T) {
  2874. tt := []struct {
  2875. name string
  2876. hash string
  2877. wantStatusCode int
  2878. wantResponse string
  2879. mockParams mockParams
  2880. }{
  2881. {
  2882. name: "success with valid hash",
  2883. hash: "2B000001E4",
  2884. wantStatusCode: http.StatusOK,
  2885. wantResponse: `{"message":"BART asset deleted successfully."}`,
  2886. mockParams: mockParams{
  2887. bartAssetManagerParams: bartAssetManagerParams{
  2888. deleteBARTItemParams: deleteBARTItemParams{
  2889. {
  2890. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2891. err: nil,
  2892. },
  2893. },
  2894. },
  2895. },
  2896. },
  2897. {
  2898. name: "missing hash parameter",
  2899. hash: "",
  2900. wantStatusCode: http.StatusBadRequest,
  2901. wantResponse: `{"message":"hash path parameter is required"}`,
  2902. },
  2903. {
  2904. name: "invalid hash format",
  2905. hash: "invalid-hex",
  2906. wantStatusCode: http.StatusBadRequest,
  2907. wantResponse: `{"message":"invalid hash format"}`,
  2908. },
  2909. {
  2910. name: "asset not found",
  2911. hash: "2B000001E4",
  2912. wantStatusCode: http.StatusNotFound,
  2913. wantResponse: `{"message":"BART asset not found"}`,
  2914. mockParams: mockParams{
  2915. bartAssetManagerParams: bartAssetManagerParams{
  2916. deleteBARTItemParams: deleteBARTItemParams{
  2917. {
  2918. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2919. err: state.ErrBARTItemNotFound,
  2920. },
  2921. },
  2922. },
  2923. },
  2924. },
  2925. {
  2926. name: "internal server error",
  2927. hash: "2B000001E4",
  2928. wantStatusCode: http.StatusInternalServerError,
  2929. wantResponse: `{"message":"internal server error"}`,
  2930. mockParams: mockParams{
  2931. bartAssetManagerParams: bartAssetManagerParams{
  2932. deleteBARTItemParams: deleteBARTItemParams{
  2933. {
  2934. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2935. err: errors.New("database error"),
  2936. },
  2937. },
  2938. },
  2939. },
  2940. },
  2941. }
  2942. for _, tc := range tt {
  2943. t.Run(tc.name, func(t *testing.T) {
  2944. request := httptest.NewRequest(http.MethodDelete, "/bart/"+tc.hash, nil)
  2945. // Set the path value manually for testing
  2946. if tc.hash != "" {
  2947. request.SetPathValue("hash", tc.hash)
  2948. }
  2949. responseRecorder := httptest.NewRecorder()
  2950. mockBARTManager := newMockBARTAssetManager(t)
  2951. for _, params := range tc.mockParams.deleteBARTItemParams {
  2952. mockBARTManager.EXPECT().
  2953. DeleteBARTItem(matchContext(), params.hash).
  2954. Return(params.err)
  2955. }
  2956. deleteBARTHandler(responseRecorder, request, mockBARTManager, slog.Default())
  2957. assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
  2958. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  2959. })
  2960. }
  2961. }
  2962. // errorReader is a helper type that always returns an error when reading
  2963. type errorReader struct{}
  2964. func (er *errorReader) Read(p []byte) (n int, err error) {
  2965. return 0, errors.New("read error")
  2966. }
  2967. func TestFeedbagBuddyHandler_GET(t *testing.T) {
  2968. tt := []struct {
  2969. name string
  2970. screenName string
  2971. wantStatusCode int
  2972. wantResponse string
  2973. mockParams mockParams
  2974. }{
  2975. {
  2976. name: "empty feedbag",
  2977. screenName: "userA",
  2978. wantStatusCode: http.StatusNotFound,
  2979. wantResponse: `{"message":"feedbag not found"}`,
  2980. mockParams: mockParams{
  2981. feedbagManagerParams: feedbagManagerParams{
  2982. feedbagParams: feedbagParams{
  2983. {
  2984. screenName: state.NewIdentScreenName("userA"),
  2985. result: []wire.FeedbagItem{},
  2986. err: nil,
  2987. },
  2988. },
  2989. },
  2990. },
  2991. },
  2992. {
  2993. name: "feedbag with buddies in groups",
  2994. screenName: "userA",
  2995. wantStatusCode: http.StatusOK,
  2996. wantResponse: `[{"group_id":1,"group_name":"Friends","buddies":[{"name":"buddy1","item_id":10},{"name":"buddy2","item_id":11}]},{"group_id":2,"group_name":"Work","buddies":[{"name":"buddy3","item_id":20}]}]`,
  2997. mockParams: mockParams{
  2998. feedbagManagerParams: feedbagManagerParams{
  2999. feedbagParams: feedbagParams{
  3000. {
  3001. screenName: state.NewIdentScreenName("userA"),
  3002. result: []wire.FeedbagItem{
  3003. {
  3004. ItemID: 0,
  3005. ClassID: wire.FeedbagClassIdGroup,
  3006. Name: "",
  3007. GroupID: 0,
  3008. },
  3009. {
  3010. ItemID: 1,
  3011. ClassID: wire.FeedbagClassIdGroup,
  3012. Name: "Friends",
  3013. GroupID: 1,
  3014. TLVLBlock: wire.TLVLBlock{
  3015. TLVList: wire.TLVList{
  3016. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{10, 11}),
  3017. },
  3018. },
  3019. },
  3020. {
  3021. ItemID: 2,
  3022. ClassID: wire.FeedbagClassIdGroup,
  3023. Name: "Work",
  3024. GroupID: 2,
  3025. TLVLBlock: wire.TLVLBlock{
  3026. TLVList: wire.TLVList{
  3027. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{20}),
  3028. },
  3029. },
  3030. },
  3031. {
  3032. ItemID: 10,
  3033. ClassID: wire.FeedbagClassIdBuddy,
  3034. Name: "buddy1",
  3035. GroupID: 1,
  3036. },
  3037. {
  3038. ItemID: 11,
  3039. ClassID: wire.FeedbagClassIdBuddy,
  3040. Name: "buddy2",
  3041. GroupID: 1,
  3042. },
  3043. {
  3044. ItemID: 20,
  3045. ClassID: wire.FeedbagClassIdBuddy,
  3046. Name: "buddy3",
  3047. GroupID: 2,
  3048. },
  3049. },
  3050. err: nil,
  3051. },
  3052. },
  3053. },
  3054. },
  3055. },
  3056. {
  3057. name: "feedbag with no groups (besides root)",
  3058. screenName: "userA",
  3059. wantStatusCode: http.StatusOK,
  3060. wantResponse: `[]`,
  3061. mockParams: mockParams{
  3062. feedbagManagerParams: feedbagManagerParams{
  3063. feedbagParams: feedbagParams{
  3064. {
  3065. screenName: state.NewIdentScreenName("userA"),
  3066. result: []wire.FeedbagItem{
  3067. {
  3068. ItemID: 0,
  3069. ClassID: wire.FeedbagClassIdGroup,
  3070. Name: "",
  3071. GroupID: 0,
  3072. },
  3073. },
  3074. err: nil,
  3075. },
  3076. },
  3077. },
  3078. },
  3079. // Note: Root groups (GroupID == 0) are skipped by the implementation,
  3080. // so the response will be an empty array []
  3081. },
  3082. {
  3083. name: "missing screen_name",
  3084. screenName: "",
  3085. wantStatusCode: http.StatusBadRequest,
  3086. wantResponse: `{"message":"screen_name is required"}`,
  3087. },
  3088. {
  3089. name: "internal server error",
  3090. screenName: "userA",
  3091. wantStatusCode: http.StatusInternalServerError,
  3092. wantResponse: `{"message":"internal server error"}`,
  3093. mockParams: mockParams{
  3094. feedbagManagerParams: feedbagManagerParams{
  3095. feedbagParams: feedbagParams{
  3096. {
  3097. screenName: state.NewIdentScreenName("userA"),
  3098. result: nil,
  3099. err: errors.New("database error"),
  3100. },
  3101. },
  3102. },
  3103. },
  3104. },
  3105. }
  3106. for _, tc := range tt {
  3107. t.Run(tc.name, func(t *testing.T) {
  3108. request := httptest.NewRequest(http.MethodGet, "/feedbag/"+tc.screenName+"/group", nil)
  3109. if tc.screenName != "" {
  3110. request.SetPathValue("screen_name", tc.screenName)
  3111. }
  3112. responseRecorder := httptest.NewRecorder()
  3113. feedbagManager := newMockFeedbagManager(t)
  3114. for _, params := range tc.mockParams.feedbagParams {
  3115. feedbagManager.EXPECT().
  3116. Feedbag(matchContext(), params.screenName).
  3117. Return(params.result, params.err)
  3118. }
  3119. getFeedbagBuddyHandler(responseRecorder, request, feedbagManager, slog.Default())
  3120. assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
  3121. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  3122. })
  3123. }
  3124. }
  3125. func TestFeedbagGroupHandler_PUT(t *testing.T) {
  3126. tt := []struct {
  3127. name string
  3128. screenName string
  3129. groupName string
  3130. groupIDGen func(n int) int
  3131. wantStatusCode int
  3132. wantResponse string
  3133. mockParams mockParams
  3134. }{
  3135. {
  3136. name: "add group to empty feedbag",
  3137. screenName: "userA",
  3138. groupName: "Friends",
  3139. groupIDGen: func(n int) int { return 5 },
  3140. wantStatusCode: http.StatusCreated,
  3141. wantResponse: `{"group_id":5,"group_name":"Friends"}`,
  3142. mockParams: mockParams{
  3143. userManagerParams: userManagerParams{
  3144. getUserParams: getUserParams{
  3145. {
  3146. screenName: state.NewIdentScreenName("userA"),
  3147. result: &state.User{IdentScreenName: state.NewIdentScreenName("userA")},
  3148. },
  3149. },
  3150. },
  3151. feedbagManagerParams: feedbagManagerParams{
  3152. feedbagParams: feedbagParams{
  3153. {
  3154. screenName: state.NewIdentScreenName("userA"),
  3155. result: []wire.FeedbagItem{},
  3156. err: nil,
  3157. },
  3158. },
  3159. feedbagUpsertParams: feedbagUpsertParams{
  3160. {
  3161. screenName: state.NewIdentScreenName("userA"),
  3162. items: []wire.FeedbagItem{
  3163. {
  3164. ClassID: wire.FeedbagClassIdGroup,
  3165. GroupID: 0,
  3166. TLVLBlock: wire.TLVLBlock{
  3167. TLVList: wire.TLVList{
  3168. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{5}),
  3169. },
  3170. },
  3171. },
  3172. {
  3173. ClassID: wire.FeedbagClassIdGroup,
  3174. Name: "Friends",
  3175. GroupID: 5,
  3176. },
  3177. },
  3178. err: nil,
  3179. },
  3180. },
  3181. },
  3182. messageRelayerParams: messageRelayerParams{
  3183. relayToScreenNameParams: relayToScreenNameParams{
  3184. {
  3185. screenName: state.NewIdentScreenName("userA"),
  3186. msg: wire.SNACMessage{
  3187. Frame: wire.SNACFrame{
  3188. FoodGroup: wire.Feedbag,
  3189. SubGroup: wire.FeedbagInsertItem,
  3190. RequestID: wire.ReqIDFromServer,
  3191. },
  3192. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  3193. Items: []wire.FeedbagItem{
  3194. {
  3195. ClassID: wire.FeedbagClassIdGroup,
  3196. GroupID: 0,
  3197. TLVLBlock: wire.TLVLBlock{
  3198. TLVList: wire.TLVList{
  3199. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{5}),
  3200. },
  3201. },
  3202. },
  3203. {
  3204. ClassID: wire.FeedbagClassIdGroup,
  3205. Name: "Friends",
  3206. GroupID: 5,
  3207. },
  3208. },
  3209. },
  3210. },
  3211. },
  3212. },
  3213. },
  3214. },
  3215. },
  3216. {
  3217. name: "add group to feedbag with existing root",
  3218. screenName: "userA",
  3219. groupName: "Coworkers",
  3220. groupIDGen: func(n int) int { return 2 },
  3221. wantStatusCode: http.StatusCreated,
  3222. wantResponse: `{"group_id":2,"group_name":"Coworkers"}`,
  3223. mockParams: mockParams{
  3224. userManagerParams: userManagerParams{
  3225. getUserParams: getUserParams{
  3226. {
  3227. screenName: state.NewIdentScreenName("userA"),
  3228. result: &state.User{IdentScreenName: state.NewIdentScreenName("userA")},
  3229. },
  3230. },
  3231. },
  3232. feedbagManagerParams: feedbagManagerParams{
  3233. feedbagParams: feedbagParams{
  3234. {
  3235. screenName: state.NewIdentScreenName("userA"),
  3236. result: []wire.FeedbagItem{
  3237. {
  3238. ClassID: wire.FeedbagClassIdGroup,
  3239. GroupID: 0,
  3240. TLVLBlock: wire.TLVLBlock{
  3241. TLVList: wire.TLVList{
  3242. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1}),
  3243. },
  3244. },
  3245. },
  3246. {
  3247. ClassID: wire.FeedbagClassIdGroup,
  3248. Name: "Buddies",
  3249. GroupID: 1,
  3250. },
  3251. },
  3252. err: nil,
  3253. },
  3254. },
  3255. feedbagUpsertParams: feedbagUpsertParams{
  3256. {
  3257. screenName: state.NewIdentScreenName("userA"),
  3258. items: []wire.FeedbagItem{
  3259. {
  3260. ClassID: wire.FeedbagClassIdGroup,
  3261. GroupID: 0,
  3262. TLVLBlock: wire.TLVLBlock{
  3263. TLVList: wire.TLVList{
  3264. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1, 2}),
  3265. },
  3266. },
  3267. },
  3268. {
  3269. ClassID: wire.FeedbagClassIdGroup,
  3270. Name: "Coworkers",
  3271. GroupID: 2,
  3272. },
  3273. },
  3274. err: nil,
  3275. },
  3276. },
  3277. },
  3278. messageRelayerParams: messageRelayerParams{
  3279. relayToScreenNameParams: relayToScreenNameParams{
  3280. {
  3281. screenName: state.NewIdentScreenName("userA"),
  3282. msg: wire.SNACMessage{
  3283. Frame: wire.SNACFrame{
  3284. FoodGroup: wire.Feedbag,
  3285. SubGroup: wire.FeedbagInsertItem,
  3286. RequestID: wire.ReqIDFromServer,
  3287. },
  3288. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  3289. Items: []wire.FeedbagItem{
  3290. {
  3291. ClassID: wire.FeedbagClassIdGroup,
  3292. GroupID: 0,
  3293. TLVLBlock: wire.TLVLBlock{
  3294. TLVList: wire.TLVList{
  3295. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1, 2}),
  3296. },
  3297. },
  3298. },
  3299. {
  3300. ClassID: wire.FeedbagClassIdGroup,
  3301. Name: "Coworkers",
  3302. GroupID: 2,
  3303. },
  3304. },
  3305. },
  3306. },
  3307. },
  3308. },
  3309. },
  3310. },
  3311. },
  3312. {
  3313. name: "group already exists",
  3314. screenName: "userA",
  3315. groupName: "Friends",
  3316. groupIDGen: func(n int) int { return 99 },
  3317. wantStatusCode: http.StatusOK,
  3318. wantResponse: `{"group_id":1,"group_name":"Friends"}`,
  3319. mockParams: mockParams{
  3320. userManagerParams: userManagerParams{
  3321. getUserParams: getUserParams{
  3322. {
  3323. screenName: state.NewIdentScreenName("userA"),
  3324. result: &state.User{IdentScreenName: state.NewIdentScreenName("userA")},
  3325. },
  3326. },
  3327. },
  3328. feedbagManagerParams: feedbagManagerParams{
  3329. feedbagParams: feedbagParams{
  3330. {
  3331. screenName: state.NewIdentScreenName("userA"),
  3332. result: []wire.FeedbagItem{
  3333. {
  3334. ClassID: wire.FeedbagClassIdGroup,
  3335. GroupID: 0,
  3336. },
  3337. {
  3338. ClassID: wire.FeedbagClassIdGroup,
  3339. Name: "Friends",
  3340. GroupID: 1,
  3341. },
  3342. },
  3343. err: nil,
  3344. },
  3345. },
  3346. },
  3347. },
  3348. },
  3349. {
  3350. name: "missing screen_name",
  3351. screenName: "",
  3352. groupName: "Friends",
  3353. groupIDGen: func(n int) int { return 5 },
  3354. wantStatusCode: http.StatusBadRequest,
  3355. wantResponse: `{"message":"screen_name is required"}`,
  3356. },
  3357. {
  3358. name: "missing group_name",
  3359. screenName: "userA",
  3360. groupName: "",
  3361. groupIDGen: func(n int) int { return 5 },
  3362. wantStatusCode: http.StatusBadRequest,
  3363. wantResponse: `{"message":"group_name is required"}`,
  3364. },
  3365. {
  3366. name: "user not found",
  3367. screenName: "userA",
  3368. groupName: "Friends",
  3369. groupIDGen: func(n int) int { return 5 },
  3370. wantStatusCode: http.StatusNotFound,
  3371. wantResponse: `{"message":"user not found"}`,
  3372. mockParams: mockParams{
  3373. userManagerParams: userManagerParams{
  3374. getUserParams: getUserParams{
  3375. {
  3376. screenName: state.NewIdentScreenName("userA"),
  3377. result: nil,
  3378. },
  3379. },
  3380. },
  3381. },
  3382. },
  3383. {
  3384. name: "error retrieving user",
  3385. screenName: "userA",
  3386. groupName: "Friends",
  3387. groupIDGen: func(n int) int { return 5 },
  3388. wantStatusCode: http.StatusInternalServerError,
  3389. wantResponse: `{"message":"internal server error"}`,
  3390. mockParams: mockParams{
  3391. userManagerParams: userManagerParams{
  3392. getUserParams: getUserParams{
  3393. {
  3394. screenName: state.NewIdentScreenName("userA"),
  3395. err: errors.New("database error"),
  3396. },
  3397. },
  3398. },
  3399. },
  3400. },
  3401. {
  3402. name: "error retrieving feedbag",
  3403. screenName: "userA",
  3404. groupName: "Friends",
  3405. groupIDGen: func(n int) int { return 5 },
  3406. wantStatusCode: http.StatusInternalServerError,
  3407. wantResponse: `{"message":"internal server error"}`,
  3408. mockParams: mockParams{
  3409. userManagerParams: userManagerParams{
  3410. getUserParams: getUserParams{
  3411. {
  3412. screenName: state.NewIdentScreenName("userA"),
  3413. result: &state.User{IdentScreenName: state.NewIdentScreenName("userA")},
  3414. },
  3415. },
  3416. },
  3417. feedbagManagerParams: feedbagManagerParams{
  3418. feedbagParams: feedbagParams{
  3419. {
  3420. screenName: state.NewIdentScreenName("userA"),
  3421. result: nil,
  3422. err: errors.New("database error"),
  3423. },
  3424. },
  3425. },
  3426. },
  3427. },
  3428. {
  3429. name: "error upserting feedbag",
  3430. screenName: "userA",
  3431. groupName: "Friends",
  3432. groupIDGen: func(n int) int { return 5 },
  3433. wantStatusCode: http.StatusInternalServerError,
  3434. wantResponse: `{"message":"internal server error"}`,
  3435. mockParams: mockParams{
  3436. userManagerParams: userManagerParams{
  3437. getUserParams: getUserParams{
  3438. {
  3439. screenName: state.NewIdentScreenName("userA"),
  3440. result: &state.User{IdentScreenName: state.NewIdentScreenName("userA")},
  3441. },
  3442. },
  3443. },
  3444. feedbagManagerParams: feedbagManagerParams{
  3445. feedbagParams: feedbagParams{
  3446. {
  3447. screenName: state.NewIdentScreenName("userA"),
  3448. result: []wire.FeedbagItem{},
  3449. err: nil,
  3450. },
  3451. },
  3452. feedbagUpsertParams: feedbagUpsertParams{
  3453. {
  3454. screenName: state.NewIdentScreenName("userA"),
  3455. items: []wire.FeedbagItem{
  3456. {
  3457. ClassID: wire.FeedbagClassIdGroup,
  3458. GroupID: 0,
  3459. TLVLBlock: wire.TLVLBlock{
  3460. TLVList: wire.TLVList{
  3461. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{5}),
  3462. },
  3463. },
  3464. },
  3465. {
  3466. ClassID: wire.FeedbagClassIdGroup,
  3467. Name: "Friends",
  3468. GroupID: 5,
  3469. },
  3470. },
  3471. err: errors.New("database error"),
  3472. },
  3473. },
  3474. },
  3475. },
  3476. },
  3477. }
  3478. for _, tc := range tt {
  3479. t.Run(tc.name, func(t *testing.T) {
  3480. request := httptest.NewRequest(http.MethodPut, "/feedbag/"+tc.screenName+"/group/"+tc.groupName, nil)
  3481. if tc.screenName != "" {
  3482. request.SetPathValue("screen_name", tc.screenName)
  3483. }
  3484. if tc.groupName != "" {
  3485. request.SetPathValue("group_name", tc.groupName)
  3486. }
  3487. responseRecorder := httptest.NewRecorder()
  3488. userManager := newMockUserManager(t)
  3489. for _, params := range tc.mockParams.getUserParams {
  3490. userManager.EXPECT().
  3491. User(matchContext(), params.screenName).
  3492. Return(params.result, params.err)
  3493. }
  3494. feedbagManager := newMockFeedbagManager(t)
  3495. messageRelayer := newMockMessageRelayer(t)
  3496. for _, params := range tc.mockParams.feedbagParams {
  3497. feedbagManager.EXPECT().
  3498. Feedbag(matchContext(), params.screenName).
  3499. Return(params.result, params.err)
  3500. }
  3501. for _, params := range tc.mockParams.feedbagUpsertParams {
  3502. feedbagManager.EXPECT().
  3503. FeedbagUpsert(matchContext(), params.screenName, params.items).
  3504. Return(params.err)
  3505. }
  3506. for _, params := range tc.mockParams.relayToScreenNameParams {
  3507. messageRelayer.EXPECT().
  3508. RelayToScreenName(matchContext(), params.screenName, params.msg)
  3509. }
  3510. putFeedbagGroupHandler(responseRecorder, request, userManager, feedbagManager, messageRelayer, slog.Default(), tc.groupIDGen)
  3511. assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
  3512. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  3513. })
  3514. }
  3515. }
  3516. func TestFeedbagBuddyHandler_PUT(t *testing.T) {
  3517. tt := []struct {
  3518. name string
  3519. screenName string
  3520. groupID string
  3521. requestBody string
  3522. wantStatusCode int
  3523. wantResponse string
  3524. mockParams mockParams
  3525. }{
  3526. {
  3527. name: "add a buddy to an empty group, user not signed in",
  3528. screenName: "userA",
  3529. groupID: "1",
  3530. requestBody: `{"name":"newbuddy"}`,
  3531. wantStatusCode: http.StatusOK,
  3532. wantResponse: `{"name":"newbuddy","group_id":1,"item_id":1000}`,
  3533. mockParams: mockParams{
  3534. feedbagManagerParams: feedbagManagerParams{
  3535. feedbagParams: feedbagParams{
  3536. {
  3537. screenName: state.NewIdentScreenName("userA"),
  3538. result: []wire.FeedbagItem{
  3539. {
  3540. ClassID: wire.FeedbagClassIdGroup,
  3541. Name: "Friends",
  3542. GroupID: 1,
  3543. },
  3544. },
  3545. err: nil,
  3546. },
  3547. },
  3548. feedbagUpsertParams: feedbagUpsertParams{
  3549. {
  3550. screenName: state.NewIdentScreenName("userA"),
  3551. items: []wire.FeedbagItem{
  3552. {
  3553. Name: "newbuddy",
  3554. GroupID: 1,
  3555. ItemID: 1000,
  3556. ClassID: wire.FeedbagClassIdBuddy,
  3557. },
  3558. {
  3559. ClassID: wire.FeedbagClassIdGroup,
  3560. Name: "Friends",
  3561. GroupID: 1,
  3562. TLVLBlock: wire.TLVLBlock{
  3563. TLVList: wire.TLVList{
  3564. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1000}),
  3565. },
  3566. },
  3567. },
  3568. },
  3569. err: nil,
  3570. },
  3571. },
  3572. },
  3573. sessionRetrieverParams: sessionRetrieverParams{
  3574. retrieveSessionByNameParams: retrieveSessionByNameParams{
  3575. {
  3576. screenName: state.NewIdentScreenName("userA"),
  3577. result: state.NewSession(),
  3578. },
  3579. },
  3580. },
  3581. messageRelayerParams: messageRelayerParams{
  3582. relayToScreenNameParams: relayToScreenNameParams{
  3583. {
  3584. screenName: state.NewIdentScreenName("userA"),
  3585. msg: wire.SNACMessage{
  3586. Frame: wire.SNACFrame{
  3587. FoodGroup: wire.Feedbag,
  3588. SubGroup: wire.FeedbagInsertItem,
  3589. RequestID: wire.ReqIDFromServer,
  3590. },
  3591. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  3592. Items: []wire.FeedbagItem{
  3593. {
  3594. Name: "newbuddy",
  3595. GroupID: 1,
  3596. ItemID: 1000,
  3597. ClassID: wire.FeedbagClassIdBuddy,
  3598. },
  3599. },
  3600. },
  3601. },
  3602. },
  3603. {
  3604. screenName: state.NewIdentScreenName("userA"),
  3605. msg: wire.SNACMessage{
  3606. Frame: wire.SNACFrame{
  3607. FoodGroup: wire.Feedbag,
  3608. SubGroup: wire.FeedbagUpdateItem,
  3609. RequestID: wire.ReqIDFromServer,
  3610. },
  3611. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  3612. Items: []wire.FeedbagItem{
  3613. {
  3614. ClassID: wire.FeedbagClassIdGroup,
  3615. Name: "Friends",
  3616. GroupID: 1,
  3617. TLVLBlock: wire.TLVLBlock{
  3618. TLVList: wire.TLVList{
  3619. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1000}),
  3620. },
  3621. },
  3622. },
  3623. },
  3624. },
  3625. },
  3626. },
  3627. },
  3628. },
  3629. },
  3630. },
  3631. {
  3632. name: "add a buddy to a non-empty group, user not signed in",
  3633. screenName: "userA",
  3634. groupID: "1",
  3635. requestBody: `{"name":"newbuddy2"}`,
  3636. wantStatusCode: http.StatusOK,
  3637. wantResponse: `{"name":"newbuddy2","group_id":1,"item_id":1000}`,
  3638. mockParams: mockParams{
  3639. feedbagManagerParams: feedbagManagerParams{
  3640. feedbagParams: feedbagParams{
  3641. {
  3642. screenName: state.NewIdentScreenName("userA"),
  3643. result: []wire.FeedbagItem{
  3644. {
  3645. ClassID: wire.FeedbagClassIdGroup,
  3646. Name: "Friends",
  3647. GroupID: 1,
  3648. TLVLBlock: wire.TLVLBlock{
  3649. TLVList: wire.TLVList{
  3650. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{12345}),
  3651. },
  3652. },
  3653. },
  3654. {
  3655. ItemID: 12345,
  3656. ClassID: wire.FeedbagClassIdBuddy,
  3657. Name: "existingbuddy",
  3658. GroupID: 1,
  3659. },
  3660. },
  3661. err: nil,
  3662. },
  3663. },
  3664. feedbagUpsertParams: feedbagUpsertParams{
  3665. {
  3666. screenName: state.NewIdentScreenName("userA"),
  3667. items: []wire.FeedbagItem{
  3668. {
  3669. Name: "newbuddy2",
  3670. GroupID: 1,
  3671. ItemID: 1000,
  3672. ClassID: wire.FeedbagClassIdBuddy,
  3673. },
  3674. {
  3675. ClassID: wire.FeedbagClassIdGroup,
  3676. Name: "Friends",
  3677. GroupID: 1,
  3678. TLVLBlock: wire.TLVLBlock{
  3679. TLVList: wire.TLVList{
  3680. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{12345, 1000}),
  3681. },
  3682. },
  3683. },
  3684. },
  3685. err: nil,
  3686. },
  3687. },
  3688. },
  3689. sessionRetrieverParams: sessionRetrieverParams{
  3690. retrieveSessionByNameParams: retrieveSessionByNameParams{
  3691. {
  3692. screenName: state.NewIdentScreenName("userA"),
  3693. result: state.NewSession(),
  3694. },
  3695. },
  3696. },
  3697. messageRelayerParams: messageRelayerParams{
  3698. relayToScreenNameParams: relayToScreenNameParams{
  3699. {
  3700. screenName: state.NewIdentScreenName("userA"),
  3701. msg: wire.SNACMessage{
  3702. Frame: wire.SNACFrame{
  3703. FoodGroup: wire.Feedbag,
  3704. SubGroup: wire.FeedbagInsertItem,
  3705. RequestID: wire.ReqIDFromServer,
  3706. },
  3707. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  3708. Items: []wire.FeedbagItem{
  3709. {
  3710. Name: "newbuddy2",
  3711. GroupID: 1,
  3712. ItemID: 1000,
  3713. ClassID: wire.FeedbagClassIdBuddy,
  3714. },
  3715. },
  3716. },
  3717. },
  3718. },
  3719. {
  3720. screenName: state.NewIdentScreenName("userA"),
  3721. msg: wire.SNACMessage{
  3722. Frame: wire.SNACFrame{
  3723. FoodGroup: wire.Feedbag,
  3724. SubGroup: wire.FeedbagUpdateItem,
  3725. RequestID: wire.ReqIDFromServer,
  3726. },
  3727. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  3728. Items: []wire.FeedbagItem{
  3729. {
  3730. ClassID: wire.FeedbagClassIdGroup,
  3731. Name: "Friends",
  3732. GroupID: 1,
  3733. TLVLBlock: wire.TLVLBlock{
  3734. TLVList: wire.TLVList{
  3735. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{12345, 1000}),
  3736. },
  3737. },
  3738. },
  3739. },
  3740. },
  3741. },
  3742. },
  3743. },
  3744. },
  3745. },
  3746. },
  3747. {
  3748. name: "add a buddy that already exists in a group",
  3749. screenName: "userA",
  3750. groupID: "1",
  3751. requestBody: `{"name":"ExistingBuddy"}`,
  3752. wantStatusCode: http.StatusOK,
  3753. wantResponse: `{"name":"ExistingBuddy","group_id":1,"item_id":12345}`,
  3754. mockParams: mockParams{
  3755. feedbagManagerParams: feedbagManagerParams{
  3756. feedbagParams: feedbagParams{
  3757. {
  3758. screenName: state.NewIdentScreenName("userA"),
  3759. result: []wire.FeedbagItem{
  3760. {
  3761. ClassID: wire.FeedbagClassIdGroup,
  3762. Name: "Friends",
  3763. GroupID: 1,
  3764. TLVLBlock: wire.TLVLBlock{
  3765. TLVList: wire.TLVList{
  3766. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{12345}),
  3767. },
  3768. },
  3769. },
  3770. {
  3771. ItemID: 12345,
  3772. ClassID: wire.FeedbagClassIdBuddy,
  3773. Name: "existingbuddy",
  3774. GroupID: 1,
  3775. },
  3776. },
  3777. err: nil,
  3778. },
  3779. },
  3780. // No FeedbagUpsert should be called when buddy already exists
  3781. },
  3782. // No session retrieval or message relaying should occur
  3783. },
  3784. },
  3785. {
  3786. name: "add a buddy to an empty group, user signed in",
  3787. screenName: "userA",
  3788. groupID: "1",
  3789. requestBody: `{"name":"newbuddy"}`,
  3790. wantStatusCode: http.StatusOK,
  3791. wantResponse: `{"name":"newbuddy","group_id":1,"item_id":1000}`,
  3792. mockParams: mockParams{
  3793. feedbagManagerParams: feedbagManagerParams{
  3794. feedbagParams: feedbagParams{
  3795. {
  3796. screenName: state.NewIdentScreenName("userA"),
  3797. result: []wire.FeedbagItem{
  3798. {
  3799. ClassID: wire.FeedbagClassIdGroup,
  3800. Name: "Friends",
  3801. GroupID: 1,
  3802. },
  3803. },
  3804. err: nil,
  3805. },
  3806. },
  3807. feedbagUpsertParams: feedbagUpsertParams{
  3808. {
  3809. screenName: state.NewIdentScreenName("userA"),
  3810. items: []wire.FeedbagItem{
  3811. {
  3812. Name: "newbuddy",
  3813. GroupID: 1,
  3814. ItemID: 1000,
  3815. ClassID: wire.FeedbagClassIdBuddy,
  3816. },
  3817. {
  3818. ClassID: wire.FeedbagClassIdGroup,
  3819. Name: "Friends",
  3820. GroupID: 1,
  3821. TLVLBlock: wire.TLVLBlock{
  3822. TLVList: wire.TLVList{
  3823. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1000}),
  3824. },
  3825. },
  3826. },
  3827. },
  3828. err: nil,
  3829. },
  3830. },
  3831. },
  3832. sessionRetrieverParams: sessionRetrieverParams{
  3833. retrieveSessionByNameParams: retrieveSessionByNameParams{
  3834. {
  3835. screenName: state.NewIdentScreenName("userA"),
  3836. result: func() *state.Session {
  3837. sess := state.NewSession()
  3838. sess.SetIdentScreenName(state.NewIdentScreenName("userA"))
  3839. inst := sess.AddInstance()
  3840. inst.SetSignonComplete()
  3841. return sess
  3842. }(),
  3843. },
  3844. },
  3845. },
  3846. messageRelayerParams: messageRelayerParams{
  3847. relayToScreenNameParams: relayToScreenNameParams{
  3848. {
  3849. screenName: state.NewIdentScreenName("userA"),
  3850. msg: wire.SNACMessage{
  3851. Frame: wire.SNACFrame{
  3852. FoodGroup: wire.Feedbag,
  3853. SubGroup: wire.FeedbagInsertItem,
  3854. RequestID: wire.ReqIDFromServer,
  3855. },
  3856. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  3857. Items: []wire.FeedbagItem{
  3858. {
  3859. Name: "newbuddy",
  3860. GroupID: 1,
  3861. ItemID: 1000,
  3862. ClassID: wire.FeedbagClassIdBuddy,
  3863. },
  3864. },
  3865. },
  3866. },
  3867. },
  3868. {
  3869. screenName: state.NewIdentScreenName("userA"),
  3870. msg: wire.SNACMessage{
  3871. Frame: wire.SNACFrame{
  3872. FoodGroup: wire.Feedbag,
  3873. SubGroup: wire.FeedbagUpdateItem,
  3874. RequestID: wire.ReqIDFromServer,
  3875. },
  3876. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  3877. Items: []wire.FeedbagItem{
  3878. {
  3879. ClassID: wire.FeedbagClassIdGroup,
  3880. Name: "Friends",
  3881. GroupID: 1,
  3882. TLVLBlock: wire.TLVLBlock{
  3883. TLVList: wire.TLVList{
  3884. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1000}),
  3885. },
  3886. },
  3887. },
  3888. },
  3889. },
  3890. },
  3891. },
  3892. },
  3893. },
  3894. buddyBroadcasterParams: buddyBroadcasterParams{
  3895. broadcastVisibilityParams: broadcastVisibilityParams{
  3896. {
  3897. you: nil, // Not used in expectation, matched with mock.AnythingOfType
  3898. filter: []state.IdentScreenName{state.NewIdentScreenName("newbuddy")},
  3899. sendDepartures: false,
  3900. err: nil,
  3901. },
  3902. },
  3903. },
  3904. },
  3905. },
  3906. {
  3907. name: "invalid group_id - non-numeric",
  3908. screenName: "userA",
  3909. groupID: "invalid",
  3910. requestBody: `{"name":"buddy"}`,
  3911. wantStatusCode: http.StatusBadRequest,
  3912. wantResponse: `{"message":"invalid group_id"}`,
  3913. },
  3914. {
  3915. name: "invalid group_id - out of range",
  3916. screenName: "userA",
  3917. groupID: "99999",
  3918. requestBody: `{"name":"buddy"}`,
  3919. wantStatusCode: http.StatusBadRequest,
  3920. wantResponse: `{"message":"invalid group_id"}`,
  3921. },
  3922. {
  3923. name: "can't add buddies to root group",
  3924. screenName: "userA",
  3925. groupID: "0",
  3926. requestBody: `{"name":"buddy"}`,
  3927. wantStatusCode: http.StatusBadRequest,
  3928. wantResponse: `{"message":"can't add buddies to root group"}`,
  3929. },
  3930. {
  3931. name: "empty screen_name",
  3932. screenName: "",
  3933. groupID: "1",
  3934. requestBody: `{"name":"buddy"}`,
  3935. wantStatusCode: http.StatusBadRequest,
  3936. wantResponse: `{"message":"screen_name is required"}`,
  3937. },
  3938. {
  3939. name: "malformed JSON input",
  3940. screenName: "userA",
  3941. groupID: "1",
  3942. requestBody: `invalid json`,
  3943. wantStatusCode: http.StatusBadRequest,
  3944. wantResponse: `{"message":"buddy_screen_name is required"}`,
  3945. },
  3946. {
  3947. name: "empty name in request body",
  3948. screenName: "userA",
  3949. groupID: "1",
  3950. requestBody: `{"name":""}`,
  3951. wantStatusCode: http.StatusBadRequest,
  3952. wantResponse: `{"message":"buddy_screen_name is required"}`,
  3953. },
  3954. {
  3955. name: "missing name in request body",
  3956. screenName: "userA",
  3957. groupID: "1",
  3958. requestBody: `{}`,
  3959. wantStatusCode: http.StatusBadRequest,
  3960. wantResponse: `{"message":"buddy_screen_name is required"}`,
  3961. },
  3962. {
  3963. name: "invalid UIN - too low",
  3964. screenName: "userA",
  3965. groupID: "1",
  3966. requestBody: `{"name":"9999"}`,
  3967. wantStatusCode: http.StatusBadRequest,
  3968. wantResponse: `{"message":"invalid uin: uin must be a number in the range 10000-2147483646"}`,
  3969. },
  3970. {
  3971. name: "invalid UIN - too high",
  3972. screenName: "userA",
  3973. groupID: "1",
  3974. requestBody: `{"name":"2147483647"}`,
  3975. wantStatusCode: http.StatusBadRequest,
  3976. wantResponse: `{"message":"invalid uin: uin must be a number in the range 10000-2147483646"}`,
  3977. },
  3978. {
  3979. name: "invalid AIM handle - too short",
  3980. screenName: "userA",
  3981. groupID: "1",
  3982. requestBody: `{"name":"Us"}`,
  3983. wantStatusCode: http.StatusBadRequest,
  3984. wantResponse: `{"message":"invalid screen name: screen name must be between 3 and 16 characters"}`,
  3985. },
  3986. {
  3987. name: "invalid AIM handle - too long",
  3988. screenName: "userA",
  3989. groupID: "1",
  3990. requestBody: `{"name":"ThisIsAReallyLongScreenName"}`,
  3991. wantStatusCode: http.StatusBadRequest,
  3992. wantResponse: `{"message":"invalid screen name: screen name must be between 3 and 16 characters"}`,
  3993. },
  3994. {
  3995. name: "error retrieving feedbag",
  3996. screenName: "userA",
  3997. groupID: "1",
  3998. requestBody: `{"name":"buddy"}`,
  3999. wantStatusCode: http.StatusInternalServerError,
  4000. wantResponse: `{"message":"internal server error"}`,
  4001. mockParams: mockParams{
  4002. feedbagManagerParams: feedbagManagerParams{
  4003. feedbagParams: feedbagParams{
  4004. {
  4005. screenName: state.NewIdentScreenName("userA"),
  4006. result: nil,
  4007. err: errors.New("database error"),
  4008. },
  4009. },
  4010. },
  4011. },
  4012. },
  4013. {
  4014. name: "too many buddies in group - max 30",
  4015. screenName: "userA",
  4016. groupID: "1",
  4017. requestBody: `{"name":"newbuddy"}`,
  4018. wantStatusCode: http.StatusBadRequest,
  4019. wantResponse: `{"message":"too many buddies in group. max: 30"}`,
  4020. mockParams: mockParams{
  4021. feedbagManagerParams: feedbagManagerParams{
  4022. feedbagParams: feedbagParams{
  4023. {
  4024. screenName: state.NewIdentScreenName("userA"),
  4025. result: func() []wire.FeedbagItem {
  4026. order := make([]uint16, 30)
  4027. for i := 1; i <= 30; i++ {
  4028. order[i-1] = uint16(i)
  4029. }
  4030. items := []wire.FeedbagItem{
  4031. {
  4032. ClassID: wire.FeedbagClassIdGroup,
  4033. Name: "Friends",
  4034. GroupID: 1,
  4035. TLVLBlock: wire.TLVLBlock{
  4036. TLVList: wire.TLVList{
  4037. wire.NewTLVBE(wire.FeedbagAttributesOrder, order),
  4038. },
  4039. },
  4040. },
  4041. }
  4042. // Add 30 buddies to the group
  4043. for i := 1; i <= 30; i++ {
  4044. items = append(items, wire.FeedbagItem{
  4045. ItemID: uint16(i),
  4046. ClassID: wire.FeedbagClassIdBuddy,
  4047. Name: fmt.Sprintf("buddy%d", i),
  4048. GroupID: 1,
  4049. })
  4050. }
  4051. return items
  4052. }(),
  4053. err: nil,
  4054. },
  4055. },
  4056. },
  4057. },
  4058. },
  4059. {
  4060. name: "group not found",
  4061. screenName: "userA",
  4062. groupID: "999",
  4063. requestBody: `{"name":"buddy"}`,
  4064. wantStatusCode: http.StatusNotFound,
  4065. wantResponse: `{"message":"group not found"}`,
  4066. mockParams: mockParams{
  4067. feedbagManagerParams: feedbagManagerParams{
  4068. feedbagParams: feedbagParams{
  4069. {
  4070. screenName: state.NewIdentScreenName("userA"),
  4071. result: []wire.FeedbagItem{
  4072. {
  4073. ClassID: wire.FeedbagClassIdGroup,
  4074. Name: "Friends",
  4075. GroupID: 1,
  4076. },
  4077. },
  4078. err: nil,
  4079. },
  4080. },
  4081. },
  4082. },
  4083. },
  4084. {
  4085. name: "error inserting feedbag item",
  4086. screenName: "userA",
  4087. groupID: "1",
  4088. requestBody: `{"name":"buddy"}`,
  4089. wantStatusCode: http.StatusInternalServerError,
  4090. wantResponse: `{"message":"internal server error"}`,
  4091. mockParams: mockParams{
  4092. feedbagManagerParams: feedbagManagerParams{
  4093. feedbagParams: feedbagParams{
  4094. {
  4095. screenName: state.NewIdentScreenName("userA"),
  4096. result: []wire.FeedbagItem{
  4097. {
  4098. ClassID: wire.FeedbagClassIdGroup,
  4099. Name: "Friends",
  4100. GroupID: 1,
  4101. },
  4102. },
  4103. err: nil,
  4104. },
  4105. },
  4106. feedbagUpsertParams: feedbagUpsertParams{
  4107. {
  4108. screenName: state.NewIdentScreenName("userA"),
  4109. items: []wire.FeedbagItem{
  4110. {
  4111. Name: "buddy",
  4112. GroupID: 1,
  4113. ItemID: 1000,
  4114. ClassID: wire.FeedbagClassIdBuddy,
  4115. },
  4116. {
  4117. ClassID: wire.FeedbagClassIdGroup,
  4118. Name: "Friends",
  4119. GroupID: 1,
  4120. TLVLBlock: wire.TLVLBlock{
  4121. TLVList: wire.TLVList{
  4122. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1000}),
  4123. },
  4124. },
  4125. },
  4126. },
  4127. err: errors.New("database error"),
  4128. },
  4129. },
  4130. },
  4131. },
  4132. },
  4133. }
  4134. for _, tc := range tt {
  4135. t.Run(tc.name, func(t *testing.T) {
  4136. // Extract buddy name from requestBody JSON
  4137. var buddyName string
  4138. if tc.requestBody != "" {
  4139. var input struct {
  4140. Name string `json:"name"`
  4141. }
  4142. if err := json.Unmarshal([]byte(tc.requestBody), &input); err == nil {
  4143. buddyName = input.Name
  4144. }
  4145. }
  4146. request := httptest.NewRequest(http.MethodPut, "/feedbag/"+tc.screenName+"/group/"+tc.groupID+"/buddy/"+buddyName, nil)
  4147. if tc.screenName != "" {
  4148. request.SetPathValue("screen_name", tc.screenName)
  4149. }
  4150. if tc.groupID != "" {
  4151. request.SetPathValue("group_id", tc.groupID)
  4152. }
  4153. request.SetPathValue("buddy_screen_name", buddyName)
  4154. responseRecorder := httptest.NewRecorder()
  4155. feedbagManager := newMockFeedbagManager(t)
  4156. sessionRetriever := newMockSessionRetriever(t)
  4157. messageRelayer := newMockMessageRelayer(t)
  4158. buddyBroadcaster := newMockBuddyBroadcaster(t)
  4159. for _, params := range tc.mockParams.feedbagParams {
  4160. feedbagManager.EXPECT().
  4161. Feedbag(matchContext(), params.screenName).
  4162. Return(params.result, params.err)
  4163. }
  4164. for _, params := range tc.mockParams.feedbagUpsertParams {
  4165. feedbagManager.EXPECT().
  4166. FeedbagUpsert(matchContext(), params.screenName, params.items).
  4167. Return(params.err)
  4168. }
  4169. for _, params := range tc.mockParams.retrieveSessionByNameParams {
  4170. sessionRetriever.EXPECT().
  4171. RetrieveSession(params.screenName).
  4172. Return(params.result)
  4173. }
  4174. for _, params := range tc.mockParams.relayToScreenNameParams {
  4175. messageRelayer.EXPECT().
  4176. RelayToScreenName(matchContext(), params.screenName, params.msg)
  4177. }
  4178. for _, params := range tc.mockParams.broadcastVisibilityParams {
  4179. // Use mock.MatchedBy to match any SessionInstance, since we're mainly verifying filter and sendDepartures
  4180. buddyBroadcaster.EXPECT().
  4181. BroadcastVisibility(
  4182. matchContext(),
  4183. mock.AnythingOfType("*state.SessionInstance"),
  4184. params.filter,
  4185. params.sendDepartures,
  4186. ).
  4187. Return(params.err)
  4188. }
  4189. deterministicItemID := func(n int) int {
  4190. return 1000
  4191. }
  4192. putFeedbagBuddyHandler(responseRecorder, request, buddyBroadcaster, feedbagManager, sessionRetriever, messageRelayer, slog.Default(), deterministicItemID)
  4193. assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
  4194. if tc.wantStatusCode == http.StatusOK {
  4195. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  4196. } else {
  4197. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  4198. }
  4199. })
  4200. }
  4201. }
  4202. func TestFeedbagBuddyHandler_DELETE(t *testing.T) {
  4203. tt := []struct {
  4204. name string
  4205. screenName string
  4206. groupID string
  4207. requestBody string
  4208. wantStatusCode int
  4209. wantResponse string
  4210. mockParams mockParams
  4211. }{
  4212. {
  4213. name: "delete existing buddy, user not signed in",
  4214. screenName: "userA",
  4215. groupID: "1",
  4216. requestBody: `{"name":"buddy1"}`,
  4217. wantStatusCode: http.StatusNoContent,
  4218. mockParams: mockParams{
  4219. feedbagManagerParams: feedbagManagerParams{
  4220. feedbagParams: feedbagParams{
  4221. {
  4222. screenName: state.NewIdentScreenName("userA"),
  4223. result: []wire.FeedbagItem{
  4224. {
  4225. ItemID: 1,
  4226. ClassID: wire.FeedbagClassIdGroup,
  4227. Name: "Friends",
  4228. GroupID: 1,
  4229. TLVLBlock: wire.TLVLBlock{
  4230. TLVList: wire.TLVList{
  4231. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{10}),
  4232. },
  4233. },
  4234. },
  4235. {
  4236. ItemID: 10,
  4237. ClassID: wire.FeedbagClassIdBuddy,
  4238. Name: "buddy1",
  4239. GroupID: 1,
  4240. },
  4241. },
  4242. err: nil,
  4243. },
  4244. },
  4245. feedbagUpsertParams: feedbagUpsertParams{
  4246. {
  4247. screenName: state.NewIdentScreenName("userA"),
  4248. items: []wire.FeedbagItem{
  4249. {
  4250. ItemID: 1,
  4251. ClassID: wire.FeedbagClassIdGroup,
  4252. Name: "Friends",
  4253. GroupID: 1,
  4254. TLVLBlock: wire.TLVLBlock{
  4255. TLVList: wire.TLVList{
  4256. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{}),
  4257. },
  4258. },
  4259. },
  4260. },
  4261. err: nil,
  4262. },
  4263. },
  4264. feedbagDeleteParams: feedbagDeleteParams{
  4265. {
  4266. screenName: state.NewIdentScreenName("userA"),
  4267. items: []wire.FeedbagItem{
  4268. {
  4269. ItemID: 10,
  4270. ClassID: wire.FeedbagClassIdBuddy,
  4271. Name: "buddy1",
  4272. GroupID: 1,
  4273. },
  4274. },
  4275. err: nil,
  4276. },
  4277. },
  4278. },
  4279. sessionRetrieverParams: sessionRetrieverParams{
  4280. retrieveSessionByNameParams: retrieveSessionByNameParams{
  4281. {
  4282. screenName: state.NewIdentScreenName("userA"),
  4283. result: state.NewSession(),
  4284. },
  4285. },
  4286. },
  4287. messageRelayerParams: messageRelayerParams{
  4288. relayToScreenNameParams: relayToScreenNameParams{
  4289. {
  4290. screenName: state.NewIdentScreenName("userA"),
  4291. msg: wire.SNACMessage{
  4292. Frame: wire.SNACFrame{
  4293. FoodGroup: wire.Feedbag,
  4294. SubGroup: wire.FeedbagUpdateItem,
  4295. RequestID: wire.ReqIDFromServer,
  4296. },
  4297. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  4298. Items: []wire.FeedbagItem{
  4299. {
  4300. ItemID: 1,
  4301. ClassID: wire.FeedbagClassIdGroup,
  4302. Name: "Friends",
  4303. GroupID: 1,
  4304. TLVLBlock: wire.TLVLBlock{
  4305. TLVList: wire.TLVList{
  4306. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{}),
  4307. },
  4308. },
  4309. },
  4310. },
  4311. },
  4312. },
  4313. },
  4314. {
  4315. screenName: state.NewIdentScreenName("userA"),
  4316. msg: wire.SNACMessage{
  4317. Frame: wire.SNACFrame{
  4318. FoodGroup: wire.Feedbag,
  4319. SubGroup: wire.FeedbagDeleteItem,
  4320. RequestID: wire.ReqIDFromServer,
  4321. },
  4322. Body: wire.SNAC_0x13_0x0A_FeedbagDeleteItem{
  4323. Items: []wire.FeedbagItem{
  4324. {
  4325. ItemID: 10,
  4326. ClassID: wire.FeedbagClassIdBuddy,
  4327. Name: "buddy1",
  4328. GroupID: 1,
  4329. },
  4330. },
  4331. },
  4332. },
  4333. },
  4334. },
  4335. },
  4336. },
  4337. },
  4338. {
  4339. name: "delete existing buddy, user signed in",
  4340. screenName: "userA",
  4341. groupID: "1",
  4342. requestBody: `{"name":"buddy1"}`,
  4343. wantStatusCode: http.StatusNoContent,
  4344. mockParams: mockParams{
  4345. feedbagManagerParams: feedbagManagerParams{
  4346. feedbagParams: feedbagParams{
  4347. {
  4348. screenName: state.NewIdentScreenName("userA"),
  4349. result: []wire.FeedbagItem{
  4350. {
  4351. ItemID: 1,
  4352. ClassID: wire.FeedbagClassIdGroup,
  4353. Name: "Friends",
  4354. GroupID: 1,
  4355. TLVLBlock: wire.TLVLBlock{
  4356. TLVList: wire.TLVList{
  4357. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{10}),
  4358. },
  4359. },
  4360. },
  4361. {
  4362. ItemID: 10,
  4363. ClassID: wire.FeedbagClassIdBuddy,
  4364. Name: "buddy1",
  4365. GroupID: 1,
  4366. },
  4367. },
  4368. err: nil,
  4369. },
  4370. },
  4371. feedbagUpsertParams: feedbagUpsertParams{
  4372. {
  4373. screenName: state.NewIdentScreenName("userA"),
  4374. items: []wire.FeedbagItem{
  4375. {
  4376. ItemID: 1,
  4377. ClassID: wire.FeedbagClassIdGroup,
  4378. Name: "Friends",
  4379. GroupID: 1,
  4380. TLVLBlock: wire.TLVLBlock{
  4381. TLVList: wire.TLVList{
  4382. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{}),
  4383. },
  4384. },
  4385. },
  4386. },
  4387. err: nil,
  4388. },
  4389. },
  4390. feedbagDeleteParams: feedbagDeleteParams{
  4391. {
  4392. screenName: state.NewIdentScreenName("userA"),
  4393. items: []wire.FeedbagItem{
  4394. {
  4395. ItemID: 10,
  4396. ClassID: wire.FeedbagClassIdBuddy,
  4397. Name: "buddy1",
  4398. GroupID: 1,
  4399. },
  4400. },
  4401. err: nil,
  4402. },
  4403. },
  4404. },
  4405. sessionRetrieverParams: sessionRetrieverParams{
  4406. retrieveSessionByNameParams: retrieveSessionByNameParams{
  4407. {
  4408. screenName: state.NewIdentScreenName("userA"),
  4409. result: func() *state.Session {
  4410. sess := state.NewSession()
  4411. sess.SetIdentScreenName(state.NewIdentScreenName("userA"))
  4412. inst := sess.AddInstance()
  4413. inst.SetSignonComplete()
  4414. return sess
  4415. }(),
  4416. },
  4417. },
  4418. },
  4419. messageRelayerParams: messageRelayerParams{
  4420. relayToScreenNameParams: relayToScreenNameParams{
  4421. {
  4422. screenName: state.NewIdentScreenName("userA"),
  4423. msg: wire.SNACMessage{
  4424. Frame: wire.SNACFrame{
  4425. FoodGroup: wire.Feedbag,
  4426. SubGroup: wire.FeedbagUpdateItem,
  4427. RequestID: wire.ReqIDFromServer,
  4428. },
  4429. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  4430. Items: []wire.FeedbagItem{
  4431. {
  4432. ItemID: 1,
  4433. ClassID: wire.FeedbagClassIdGroup,
  4434. Name: "Friends",
  4435. GroupID: 1,
  4436. TLVLBlock: wire.TLVLBlock{
  4437. TLVList: wire.TLVList{
  4438. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{}),
  4439. },
  4440. },
  4441. },
  4442. },
  4443. },
  4444. },
  4445. },
  4446. {
  4447. screenName: state.NewIdentScreenName("userA"),
  4448. msg: wire.SNACMessage{
  4449. Frame: wire.SNACFrame{
  4450. FoodGroup: wire.Feedbag,
  4451. SubGroup: wire.FeedbagDeleteItem,
  4452. RequestID: wire.ReqIDFromServer,
  4453. },
  4454. Body: wire.SNAC_0x13_0x0A_FeedbagDeleteItem{
  4455. Items: []wire.FeedbagItem{
  4456. {
  4457. ItemID: 10,
  4458. ClassID: wire.FeedbagClassIdBuddy,
  4459. Name: "buddy1",
  4460. GroupID: 1,
  4461. },
  4462. },
  4463. },
  4464. },
  4465. },
  4466. },
  4467. },
  4468. buddyBroadcasterParams: buddyBroadcasterParams{
  4469. broadcastVisibilityParams: broadcastVisibilityParams{
  4470. {
  4471. you: nil, // Not used in expectation, matched with mock.AnythingOfType
  4472. filter: []state.IdentScreenName{state.NewIdentScreenName("buddy1")},
  4473. sendDepartures: true,
  4474. err: nil,
  4475. },
  4476. },
  4477. },
  4478. },
  4479. },
  4480. {
  4481. name: "delete buddy from a group with multiple buddies, user not signed in",
  4482. screenName: "userA",
  4483. groupID: "1",
  4484. requestBody: `{"name":"buddy1"}`,
  4485. wantStatusCode: http.StatusNoContent,
  4486. mockParams: mockParams{
  4487. feedbagManagerParams: feedbagManagerParams{
  4488. feedbagParams: feedbagParams{
  4489. {
  4490. screenName: state.NewIdentScreenName("userA"),
  4491. result: []wire.FeedbagItem{
  4492. {
  4493. ItemID: 1,
  4494. ClassID: wire.FeedbagClassIdGroup,
  4495. Name: "Friends",
  4496. GroupID: 1,
  4497. TLVLBlock: wire.TLVLBlock{
  4498. TLVList: wire.TLVList{
  4499. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{10, 20}),
  4500. },
  4501. },
  4502. },
  4503. {
  4504. ItemID: 10,
  4505. ClassID: wire.FeedbagClassIdBuddy,
  4506. Name: "buddy1",
  4507. GroupID: 1,
  4508. },
  4509. {
  4510. ItemID: 20,
  4511. ClassID: wire.FeedbagClassIdBuddy,
  4512. Name: "buddy2",
  4513. GroupID: 1,
  4514. },
  4515. },
  4516. err: nil,
  4517. },
  4518. },
  4519. feedbagUpsertParams: feedbagUpsertParams{
  4520. {
  4521. screenName: state.NewIdentScreenName("userA"),
  4522. items: []wire.FeedbagItem{
  4523. {
  4524. ItemID: 1,
  4525. ClassID: wire.FeedbagClassIdGroup,
  4526. Name: "Friends",
  4527. GroupID: 1,
  4528. TLVLBlock: wire.TLVLBlock{
  4529. TLVList: wire.TLVList{
  4530. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{20}),
  4531. },
  4532. },
  4533. },
  4534. },
  4535. err: nil,
  4536. },
  4537. },
  4538. feedbagDeleteParams: feedbagDeleteParams{
  4539. {
  4540. screenName: state.NewIdentScreenName("userA"),
  4541. items: []wire.FeedbagItem{
  4542. {
  4543. ItemID: 10,
  4544. ClassID: wire.FeedbagClassIdBuddy,
  4545. Name: "buddy1",
  4546. GroupID: 1,
  4547. },
  4548. },
  4549. err: nil,
  4550. },
  4551. },
  4552. },
  4553. sessionRetrieverParams: sessionRetrieverParams{
  4554. retrieveSessionByNameParams: retrieveSessionByNameParams{
  4555. {
  4556. screenName: state.NewIdentScreenName("userA"),
  4557. result: state.NewSession(),
  4558. },
  4559. },
  4560. },
  4561. messageRelayerParams: messageRelayerParams{
  4562. relayToScreenNameParams: relayToScreenNameParams{
  4563. {
  4564. screenName: state.NewIdentScreenName("userA"),
  4565. msg: wire.SNACMessage{
  4566. Frame: wire.SNACFrame{
  4567. FoodGroup: wire.Feedbag,
  4568. SubGroup: wire.FeedbagUpdateItem,
  4569. RequestID: wire.ReqIDFromServer,
  4570. },
  4571. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  4572. Items: []wire.FeedbagItem{
  4573. {
  4574. ItemID: 1,
  4575. ClassID: wire.FeedbagClassIdGroup,
  4576. Name: "Friends",
  4577. GroupID: 1,
  4578. TLVLBlock: wire.TLVLBlock{
  4579. TLVList: wire.TLVList{
  4580. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{20}),
  4581. },
  4582. },
  4583. },
  4584. },
  4585. },
  4586. },
  4587. },
  4588. {
  4589. screenName: state.NewIdentScreenName("userA"),
  4590. msg: wire.SNACMessage{
  4591. Frame: wire.SNACFrame{
  4592. FoodGroup: wire.Feedbag,
  4593. SubGroup: wire.FeedbagDeleteItem,
  4594. RequestID: wire.ReqIDFromServer,
  4595. },
  4596. Body: wire.SNAC_0x13_0x0A_FeedbagDeleteItem{
  4597. Items: []wire.FeedbagItem{
  4598. {
  4599. ItemID: 10,
  4600. ClassID: wire.FeedbagClassIdBuddy,
  4601. Name: "buddy1",
  4602. GroupID: 1,
  4603. },
  4604. },
  4605. },
  4606. },
  4607. },
  4608. },
  4609. },
  4610. },
  4611. },
  4612. {
  4613. name: "can't delete buddy from root group",
  4614. screenName: "userA",
  4615. groupID: "0",
  4616. requestBody: `{"name":"rootbuddy"}`,
  4617. wantStatusCode: http.StatusBadRequest,
  4618. wantResponse: `{"message":"can't add buddies to root group"}`,
  4619. },
  4620. {
  4621. name: "missing screen_name",
  4622. screenName: "",
  4623. groupID: "1",
  4624. requestBody: `{"name":"buddy"}`,
  4625. wantStatusCode: http.StatusBadRequest,
  4626. wantResponse: `{"message":"screen_name is required"}`,
  4627. },
  4628. {
  4629. name: "group not found",
  4630. screenName: "userA",
  4631. groupID: "999",
  4632. requestBody: `{"name":"buddy"}`,
  4633. wantStatusCode: http.StatusNotFound,
  4634. wantResponse: `{"message":"group not found"}`,
  4635. mockParams: mockParams{
  4636. feedbagManagerParams: feedbagManagerParams{
  4637. feedbagParams: feedbagParams{
  4638. {
  4639. screenName: state.NewIdentScreenName("userA"),
  4640. result: []wire.FeedbagItem{
  4641. {
  4642. ItemID: 1,
  4643. ClassID: wire.FeedbagClassIdGroup,
  4644. Name: "Friends",
  4645. GroupID: 0,
  4646. },
  4647. },
  4648. err: nil,
  4649. },
  4650. },
  4651. },
  4652. },
  4653. },
  4654. {
  4655. name: "invalid group_id",
  4656. screenName: "userA",
  4657. groupID: "invalid",
  4658. requestBody: `{"name":"buddy"}`,
  4659. wantStatusCode: http.StatusBadRequest,
  4660. wantResponse: `{"message":"invalid group_id"}`,
  4661. },
  4662. {
  4663. name: "malformed request body",
  4664. screenName: "userA",
  4665. groupID: "1",
  4666. requestBody: `invalid json`,
  4667. wantStatusCode: http.StatusBadRequest,
  4668. wantResponse: `{"message":"buddy_screen_name is required"}`,
  4669. },
  4670. {
  4671. name: "missing name in request body",
  4672. screenName: "userA",
  4673. groupID: "1",
  4674. requestBody: `{}`,
  4675. wantStatusCode: http.StatusBadRequest,
  4676. wantResponse: `{"message":"buddy_screen_name is required"}`,
  4677. },
  4678. {
  4679. name: "buddy not found",
  4680. screenName: "userA",
  4681. groupID: "1",
  4682. requestBody: `{"name":"nonexistent"}`,
  4683. wantStatusCode: http.StatusNotFound,
  4684. wantResponse: `{"message":"buddy not found"}`,
  4685. mockParams: mockParams{
  4686. feedbagManagerParams: feedbagManagerParams{
  4687. feedbagParams: feedbagParams{
  4688. {
  4689. screenName: state.NewIdentScreenName("userA"),
  4690. result: []wire.FeedbagItem{
  4691. {
  4692. ItemID: 1,
  4693. ClassID: wire.FeedbagClassIdGroup,
  4694. Name: "Friends",
  4695. GroupID: 1,
  4696. },
  4697. {
  4698. ItemID: 10,
  4699. ClassID: wire.FeedbagClassIdBuddy,
  4700. Name: "otherbuddy",
  4701. GroupID: 1,
  4702. },
  4703. },
  4704. err: nil,
  4705. },
  4706. },
  4707. },
  4708. },
  4709. },
  4710. {
  4711. name: "internal server error on feedbag retrieval",
  4712. screenName: "userA",
  4713. groupID: "1",
  4714. requestBody: `{"name":"buddy"}`,
  4715. wantStatusCode: http.StatusInternalServerError,
  4716. wantResponse: `{"message":"internal server error"}`,
  4717. mockParams: mockParams{
  4718. feedbagManagerParams: feedbagManagerParams{
  4719. feedbagParams: feedbagParams{
  4720. {
  4721. screenName: state.NewIdentScreenName("userA"),
  4722. result: nil,
  4723. err: errors.New("database error"),
  4724. },
  4725. },
  4726. },
  4727. },
  4728. },
  4729. {
  4730. name: "internal server error on group order upsert",
  4731. screenName: "userA",
  4732. groupID: "1",
  4733. requestBody: `{"name":"buddy1"}`,
  4734. wantStatusCode: http.StatusInternalServerError,
  4735. wantResponse: `{"message":"internal server error"}`,
  4736. mockParams: mockParams{
  4737. feedbagManagerParams: feedbagManagerParams{
  4738. feedbagParams: feedbagParams{
  4739. {
  4740. screenName: state.NewIdentScreenName("userA"),
  4741. result: []wire.FeedbagItem{
  4742. {
  4743. ItemID: 1,
  4744. ClassID: wire.FeedbagClassIdGroup,
  4745. Name: "Friends",
  4746. GroupID: 1,
  4747. TLVLBlock: wire.TLVLBlock{
  4748. TLVList: wire.TLVList{
  4749. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{10}),
  4750. },
  4751. },
  4752. },
  4753. {
  4754. ItemID: 10,
  4755. ClassID: wire.FeedbagClassIdBuddy,
  4756. Name: "buddy1",
  4757. GroupID: 1,
  4758. },
  4759. },
  4760. err: nil,
  4761. },
  4762. },
  4763. feedbagUpsertParams: feedbagUpsertParams{
  4764. {
  4765. screenName: state.NewIdentScreenName("userA"),
  4766. items: []wire.FeedbagItem{
  4767. {
  4768. ItemID: 1,
  4769. ClassID: wire.FeedbagClassIdGroup,
  4770. Name: "Friends",
  4771. GroupID: 1,
  4772. TLVLBlock: wire.TLVLBlock{
  4773. TLVList: wire.TLVList{
  4774. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{}),
  4775. },
  4776. },
  4777. },
  4778. },
  4779. err: errors.New("database error"),
  4780. },
  4781. },
  4782. },
  4783. },
  4784. },
  4785. {
  4786. name: "internal server error on delete",
  4787. screenName: "userA",
  4788. groupID: "1",
  4789. requestBody: `{"name":"buddy1"}`,
  4790. wantStatusCode: http.StatusInternalServerError,
  4791. wantResponse: `{"message":"internal server error"}`,
  4792. mockParams: mockParams{
  4793. feedbagManagerParams: feedbagManagerParams{
  4794. feedbagParams: feedbagParams{
  4795. {
  4796. screenName: state.NewIdentScreenName("userA"),
  4797. result: []wire.FeedbagItem{
  4798. {
  4799. ItemID: 1,
  4800. ClassID: wire.FeedbagClassIdGroup,
  4801. Name: "Friends",
  4802. GroupID: 1,
  4803. TLVLBlock: wire.TLVLBlock{
  4804. TLVList: wire.TLVList{
  4805. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{10}),
  4806. },
  4807. },
  4808. },
  4809. {
  4810. ItemID: 10,
  4811. ClassID: wire.FeedbagClassIdBuddy,
  4812. Name: "buddy1",
  4813. GroupID: 1,
  4814. },
  4815. },
  4816. err: nil,
  4817. },
  4818. },
  4819. feedbagUpsertParams: feedbagUpsertParams{
  4820. {
  4821. screenName: state.NewIdentScreenName("userA"),
  4822. items: []wire.FeedbagItem{
  4823. {
  4824. ItemID: 1,
  4825. ClassID: wire.FeedbagClassIdGroup,
  4826. Name: "Friends",
  4827. GroupID: 1,
  4828. TLVLBlock: wire.TLVLBlock{
  4829. TLVList: wire.TLVList{
  4830. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{}),
  4831. },
  4832. },
  4833. },
  4834. },
  4835. err: nil,
  4836. },
  4837. },
  4838. feedbagDeleteParams: feedbagDeleteParams{
  4839. {
  4840. screenName: state.NewIdentScreenName("userA"),
  4841. items: []wire.FeedbagItem{
  4842. {
  4843. ItemID: 10,
  4844. ClassID: wire.FeedbagClassIdBuddy,
  4845. Name: "buddy1",
  4846. GroupID: 1,
  4847. },
  4848. },
  4849. err: errors.New("database error"),
  4850. },
  4851. },
  4852. },
  4853. },
  4854. },
  4855. }
  4856. for _, tc := range tt {
  4857. t.Run(tc.name, func(t *testing.T) {
  4858. // Extract buddy name from requestBody JSON
  4859. var buddyName string
  4860. if tc.requestBody != "" {
  4861. var input struct {
  4862. Name string `json:"name"`
  4863. }
  4864. if err := json.Unmarshal([]byte(tc.requestBody), &input); err == nil {
  4865. buddyName = input.Name
  4866. }
  4867. }
  4868. request := httptest.NewRequest(http.MethodDelete, "/feedbag/"+tc.screenName+"/group/"+tc.groupID+"/buddy/"+buddyName, nil)
  4869. if tc.screenName != "" {
  4870. request.SetPathValue("screen_name", tc.screenName)
  4871. }
  4872. if tc.groupID != "" {
  4873. request.SetPathValue("group_id", tc.groupID)
  4874. }
  4875. request.SetPathValue("buddy_screen_name", buddyName)
  4876. responseRecorder := httptest.NewRecorder()
  4877. feedbagManager := newMockFeedbagManager(t)
  4878. sessionRetriever := newMockSessionRetriever(t)
  4879. messageRelayer := newMockMessageRelayer(t)
  4880. buddyBroadcaster := newMockBuddyBroadcaster(t)
  4881. for _, params := range tc.mockParams.feedbagParams {
  4882. feedbagManager.EXPECT().
  4883. Feedbag(matchContext(), params.screenName).
  4884. Return(params.result, params.err)
  4885. }
  4886. for _, params := range tc.mockParams.feedbagUpsertParams {
  4887. feedbagManager.EXPECT().
  4888. FeedbagUpsert(matchContext(), params.screenName, params.items).
  4889. Return(params.err)
  4890. }
  4891. for _, params := range tc.mockParams.feedbagDeleteParams {
  4892. feedbagManager.EXPECT().
  4893. FeedbagDelete(matchContext(), params.screenName, params.items).
  4894. Return(params.err)
  4895. }
  4896. for _, params := range tc.mockParams.retrieveSessionByNameParams {
  4897. sessionRetriever.EXPECT().
  4898. RetrieveSession(params.screenName).
  4899. Return(params.result)
  4900. }
  4901. for _, params := range tc.mockParams.relayToScreenNameParams {
  4902. messageRelayer.EXPECT().
  4903. RelayToScreenName(matchContext(), params.screenName, params.msg)
  4904. }
  4905. for _, params := range tc.mockParams.broadcastVisibilityParams {
  4906. buddyBroadcaster.EXPECT().
  4907. BroadcastVisibility(
  4908. matchContext(),
  4909. mock.AnythingOfType("*state.SessionInstance"),
  4910. params.filter,
  4911. params.sendDepartures,
  4912. ).
  4913. Return(params.err)
  4914. }
  4915. deleteFeedbagBuddyHandler(responseRecorder, request, buddyBroadcaster, feedbagManager, sessionRetriever, messageRelayer, slog.Default())
  4916. assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
  4917. if tc.wantResponse != "" {
  4918. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  4919. }
  4920. })
  4921. }
  4922. }
  4923. func TestRandItemID(t *testing.T) {
  4924. tt := []struct {
  4925. name string
  4926. randInt func(n int) int
  4927. items []wire.FeedbagItem
  4928. want uint16
  4929. description string
  4930. }{
  4931. {
  4932. name: "empty items list returns random ID",
  4933. randInt: func(n int) int {
  4934. return 1000
  4935. },
  4936. items: []wire.FeedbagItem{},
  4937. want: 1000,
  4938. description: "When no items exist, should return the random number generated",
  4939. },
  4940. {
  4941. name: "finds next available ID when starting ID conflicts with ItemID",
  4942. randInt: func(n int) int {
  4943. return 100
  4944. },
  4945. items: []wire.FeedbagItem{
  4946. {ItemID: 100, GroupID: 1},
  4947. {ItemID: 101, GroupID: 1},
  4948. },
  4949. want: 102,
  4950. description: "Should skip 100 and 101, return 102",
  4951. },
  4952. {
  4953. name: "finds next available ID when starting ID conflicts with GroupID",
  4954. randInt: func(n int) int {
  4955. return 50
  4956. },
  4957. items: []wire.FeedbagItem{
  4958. {ItemID: 1, GroupID: 50},
  4959. {ItemID: 2, GroupID: 51},
  4960. },
  4961. want: 52,
  4962. description: "Should skip 50 (GroupID) and 51 (GroupID), return 52",
  4963. },
  4964. {
  4965. name: "wraps around and skips 0 to find next available ID",
  4966. randInt: func(n int) int {
  4967. return math.MaxUint16 - 2
  4968. },
  4969. items: []wire.FeedbagItem{
  4970. {ItemID: math.MaxUint16 - 2, GroupID: 1},
  4971. {ItemID: math.MaxUint16 - 1, GroupID: 1},
  4972. {ItemID: math.MaxUint16, GroupID: 1},
  4973. },
  4974. want: 2,
  4975. description: "When wrapping around, skips 0 (always skipped) and 1 (if conflicts), returns 2",
  4976. },
  4977. {
  4978. name: "skips 0 when starting from 0 and finds next available",
  4979. randInt: func(n int) int {
  4980. return 0
  4981. },
  4982. items: []wire.FeedbagItem{},
  4983. want: 1,
  4984. description: "When starting from 0, skips 0 (always skipped) and returns 1",
  4985. },
  4986. {
  4987. name: "returns 0 when all IDs are taken",
  4988. randInt: func(n int) int {
  4989. return 100
  4990. },
  4991. items: func() []wire.FeedbagItem {
  4992. // Create items that cover all possible IDs
  4993. items := make([]wire.FeedbagItem, 0, math.MaxUint16+1)
  4994. for i := 0; i <= math.MaxUint16; i++ {
  4995. items = append(items, wire.FeedbagItem{
  4996. ItemID: uint16(i),
  4997. GroupID: uint16(i),
  4998. })
  4999. }
  5000. return items
  5001. }(),
  5002. want: 0,
  5003. description: "When all IDs are taken, should return 0",
  5004. },
  5005. {
  5006. name: "finds ID that conflicts with both ItemID and GroupID",
  5007. randInt: func(n int) int {
  5008. return 200
  5009. },
  5010. items: []wire.FeedbagItem{
  5011. {ItemID: 200, GroupID: 201},
  5012. {ItemID: 201, GroupID: 200},
  5013. },
  5014. want: 202,
  5015. description: "Should skip 200 (ItemID) and 201 (both ItemID and GroupID), return 202",
  5016. },
  5017. {
  5018. name: "finds available ID immediately when no conflicts",
  5019. randInt: func(n int) int {
  5020. return 500
  5021. },
  5022. items: []wire.FeedbagItem{
  5023. {ItemID: 100, GroupID: 1},
  5024. {ItemID: 200, GroupID: 2},
  5025. {ItemID: 300, GroupID: 3},
  5026. },
  5027. want: 500,
  5028. description: "When random ID has no conflicts, should return it immediately",
  5029. },
  5030. {
  5031. name: "handles single conflict and finds next",
  5032. randInt: func(n int) int {
  5033. return 42
  5034. },
  5035. items: []wire.FeedbagItem{
  5036. {ItemID: 42, GroupID: 1},
  5037. },
  5038. want: 43,
  5039. description: "Should skip 42 and return 43",
  5040. },
  5041. {
  5042. name: "finds ID before starting point when wrapping",
  5043. randInt: func(n int) int {
  5044. return 5
  5045. },
  5046. items: []wire.FeedbagItem{
  5047. {ItemID: 5, GroupID: 1},
  5048. {ItemID: 6, GroupID: 1},
  5049. {ItemID: 7, GroupID: 1},
  5050. },
  5051. want: 8,
  5052. description: "Should skip 5, 6, 7 and return 8",
  5053. },
  5054. }
  5055. for _, tc := range tt {
  5056. t.Run(tc.name, func(t *testing.T) {
  5057. got := randItemID(tc.randInt, tc.items)
  5058. if got != tc.want {
  5059. t.Errorf("randItemID() = %d, want %d. %s", got, tc.want, tc.description)
  5060. }
  5061. })
  5062. }
  5063. }
  5064. func TestGetLinkedAccountsHandler(t *testing.T) {
  5065. tt := []struct {
  5066. name string
  5067. screenname string
  5068. statusCode int
  5069. want string
  5070. mockParams mockParams
  5071. }{
  5072. {
  5073. name: "user not found returns 404",
  5074. screenname: "nobody",
  5075. statusCode: http.StatusNotFound,
  5076. want: `{"message":"user not found"}`,
  5077. mockParams: mockParams{
  5078. userManagerParams: userManagerParams{
  5079. getUserParams: getUserParams{
  5080. {
  5081. screenName: state.NewIdentScreenName("nobody"),
  5082. result: nil,
  5083. },
  5084. },
  5085. },
  5086. },
  5087. },
  5088. {
  5089. name: "returns empty linked accounts list",
  5090. screenname: "test1",
  5091. statusCode: http.StatusOK,
  5092. want: `{"linked_accounts":[]}`,
  5093. mockParams: mockParams{
  5094. userManagerParams: userManagerParams{
  5095. getUserParams: getUserParams{
  5096. {
  5097. screenName: state.NewIdentScreenName("test1"),
  5098. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5099. },
  5100. },
  5101. },
  5102. feedbagManagerParams: feedbagManagerParams{
  5103. feedbagParams: feedbagParams{
  5104. {
  5105. screenName: state.NewIdentScreenName("test1"),
  5106. result: []wire.FeedbagItem{},
  5107. },
  5108. },
  5109. },
  5110. },
  5111. },
  5112. {
  5113. name: "returns linked accounts",
  5114. screenname: "test1",
  5115. statusCode: http.StatusOK,
  5116. want: `{"linked_accounts":["test2","test3"]}`,
  5117. mockParams: mockParams{
  5118. userManagerParams: userManagerParams{
  5119. getUserParams: getUserParams{
  5120. {
  5121. screenName: state.NewIdentScreenName("test1"),
  5122. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5123. },
  5124. },
  5125. },
  5126. feedbagManagerParams: feedbagManagerParams{
  5127. feedbagParams: feedbagParams{
  5128. {
  5129. screenName: state.NewIdentScreenName("test1"),
  5130. result: []wire.FeedbagItem{
  5131. {ClassID: wire.FeedbagClassIdAlInfo, Name: "test2"},
  5132. {ClassID: wire.FeedbagClassIdAlInfo, Name: "test3"},
  5133. },
  5134. },
  5135. },
  5136. },
  5137. },
  5138. },
  5139. {
  5140. name: "feedbag error returns 500",
  5141. screenname: "test1",
  5142. statusCode: http.StatusInternalServerError,
  5143. want: `{"message":"internal server error"}`,
  5144. mockParams: mockParams{
  5145. userManagerParams: userManagerParams{
  5146. getUserParams: getUserParams{
  5147. {
  5148. screenName: state.NewIdentScreenName("test1"),
  5149. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5150. },
  5151. },
  5152. },
  5153. feedbagManagerParams: feedbagManagerParams{
  5154. feedbagParams: feedbagParams{
  5155. {
  5156. screenName: state.NewIdentScreenName("test1"),
  5157. err: io.EOF,
  5158. },
  5159. },
  5160. },
  5161. },
  5162. },
  5163. }
  5164. for _, tc := range tt {
  5165. t.Run(tc.name, func(t *testing.T) {
  5166. request := httptest.NewRequest(http.MethodGet, "/user/"+tc.screenname+"/linked-account", nil)
  5167. request.SetPathValue("screenname", tc.screenname)
  5168. responseRecorder := httptest.NewRecorder()
  5169. userManager := newMockUserManager(t)
  5170. for _, params := range tc.mockParams.getUserParams {
  5171. userManager.EXPECT().
  5172. User(matchContext(), params.screenName).
  5173. Return(params.result, params.err)
  5174. }
  5175. feedbagManager := newMockFeedbagManager(t)
  5176. for _, params := range tc.mockParams.feedbagParams {
  5177. feedbagManager.EXPECT().
  5178. Feedbag(matchContext(), params.screenName).
  5179. Return(params.result, params.err)
  5180. }
  5181. getLinkedAccountsHandler(responseRecorder, request, userManager, feedbagManager)
  5182. assert.Equal(t, tc.statusCode, responseRecorder.Code)
  5183. assert.Equal(t, tc.want, strings.TrimSpace(responseRecorder.Body.String()))
  5184. })
  5185. }
  5186. }
  5187. func TestPostLinkedAccountHandler(t *testing.T) {
  5188. tt := []struct {
  5189. name string
  5190. screenname string
  5191. body string
  5192. statusCode int
  5193. want string
  5194. mockParams mockParams
  5195. }{
  5196. {
  5197. name: "primary user not found returns 404",
  5198. screenname: "nobody",
  5199. body: `{"linked_screen_name":"test2"}`,
  5200. statusCode: http.StatusNotFound,
  5201. want: `{"message":"user not found"}`,
  5202. mockParams: mockParams{
  5203. userManagerParams: userManagerParams{
  5204. getUserParams: getUserParams{
  5205. {
  5206. screenName: state.NewIdentScreenName("nobody"),
  5207. result: nil,
  5208. },
  5209. },
  5210. },
  5211. },
  5212. },
  5213. {
  5214. name: "invalid request body returns 400",
  5215. screenname: "test1",
  5216. body: `not json`,
  5217. statusCode: http.StatusBadRequest,
  5218. want: `{"message":"invalid request body"}`,
  5219. mockParams: mockParams{
  5220. userManagerParams: userManagerParams{
  5221. getUserParams: getUserParams{
  5222. {
  5223. screenName: state.NewIdentScreenName("test1"),
  5224. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5225. },
  5226. },
  5227. },
  5228. },
  5229. },
  5230. {
  5231. name: "missing linked_screen_name returns 400",
  5232. screenname: "test1",
  5233. body: `{}`,
  5234. statusCode: http.StatusBadRequest,
  5235. want: `{"message":"invalid request body"}`,
  5236. mockParams: mockParams{
  5237. userManagerParams: userManagerParams{
  5238. getUserParams: getUserParams{
  5239. {
  5240. screenName: state.NewIdentScreenName("test1"),
  5241. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5242. },
  5243. },
  5244. },
  5245. },
  5246. },
  5247. {
  5248. name: "self-link returns 400",
  5249. screenname: "test1",
  5250. body: `{"linked_screen_name":"test1"}`,
  5251. statusCode: http.StatusBadRequest,
  5252. want: `{"message":"cannot link an account to itself"}`,
  5253. mockParams: mockParams{
  5254. userManagerParams: userManagerParams{
  5255. getUserParams: getUserParams{
  5256. {
  5257. screenName: state.NewIdentScreenName("test1"),
  5258. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5259. },
  5260. },
  5261. },
  5262. },
  5263. },
  5264. {
  5265. name: "linked user not found returns 404",
  5266. screenname: "test1",
  5267. body: `{"linked_screen_name":"nobody"}`,
  5268. statusCode: http.StatusNotFound,
  5269. want: `{"message":"linked user not found"}`,
  5270. mockParams: mockParams{
  5271. userManagerParams: userManagerParams{
  5272. getUserParams: getUserParams{
  5273. {
  5274. screenName: state.NewIdentScreenName("test1"),
  5275. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5276. },
  5277. {
  5278. screenName: state.NewIdentScreenName("nobody"),
  5279. result: nil,
  5280. },
  5281. },
  5282. },
  5283. },
  5284. },
  5285. {
  5286. name: "duplicate link returns 409",
  5287. screenname: "test1",
  5288. body: `{"linked_screen_name":"test2"}`,
  5289. statusCode: http.StatusConflict,
  5290. want: `{"message":"linked account already exists"}`,
  5291. mockParams: mockParams{
  5292. userManagerParams: userManagerParams{
  5293. getUserParams: getUserParams{
  5294. {
  5295. screenName: state.NewIdentScreenName("test1"),
  5296. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5297. },
  5298. {
  5299. screenName: state.NewIdentScreenName("test2"),
  5300. result: &state.User{IdentScreenName: state.NewIdentScreenName("test2")},
  5301. },
  5302. },
  5303. },
  5304. feedbagManagerParams: feedbagManagerParams{
  5305. feedbagParams: feedbagParams{
  5306. {
  5307. screenName: state.NewIdentScreenName("test1"),
  5308. result: []wire.FeedbagItem{
  5309. {ClassID: wire.FeedbagClassIdAlInfo, Name: "test2"},
  5310. },
  5311. },
  5312. },
  5313. },
  5314. },
  5315. },
  5316. {
  5317. name: "link below cap returns 201",
  5318. screenname: "test1",
  5319. body: `{"linked_screen_name":"test2"}`,
  5320. statusCode: http.StatusCreated,
  5321. want: ``,
  5322. mockParams: mockParams{
  5323. userManagerParams: userManagerParams{
  5324. getUserParams: getUserParams{
  5325. {
  5326. screenName: state.NewIdentScreenName("test1"),
  5327. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5328. },
  5329. {
  5330. screenName: state.NewIdentScreenName("test2"),
  5331. result: &state.User{IdentScreenName: state.NewIdentScreenName("test2")},
  5332. },
  5333. },
  5334. },
  5335. feedbagManagerParams: feedbagManagerParams{
  5336. feedbagParams: feedbagParams{
  5337. {
  5338. screenName: state.NewIdentScreenName("test1"),
  5339. result: []wire.FeedbagItem{
  5340. {ClassID: wire.FeedbagClassIdAlInfo, Name: "link1", ItemID: 1},
  5341. {ClassID: wire.FeedbagClassIdAlInfo, Name: "link2", ItemID: 2},
  5342. {ClassID: wire.FeedbagClassIdAlInfo, Name: "link3", ItemID: 3},
  5343. },
  5344. },
  5345. },
  5346. feedbagUpsertParams: feedbagUpsertParams{
  5347. {
  5348. screenName: state.NewIdentScreenName("test1"),
  5349. items: []wire.FeedbagItem{
  5350. {ItemID: 4, ClassID: wire.FeedbagClassIdAlInfo, Name: "test2"},
  5351. },
  5352. },
  5353. },
  5354. },
  5355. },
  5356. },
  5357. {
  5358. name: "link cap reached returns 409",
  5359. screenname: "test1",
  5360. body: `{"linked_screen_name":"test2"}`,
  5361. statusCode: http.StatusConflict,
  5362. want: `{"message":"user already has the maximum of 4 linked accounts"}`,
  5363. mockParams: mockParams{
  5364. userManagerParams: userManagerParams{
  5365. getUserParams: getUserParams{
  5366. {
  5367. screenName: state.NewIdentScreenName("test1"),
  5368. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5369. },
  5370. {
  5371. screenName: state.NewIdentScreenName("test2"),
  5372. result: &state.User{IdentScreenName: state.NewIdentScreenName("test2")},
  5373. },
  5374. },
  5375. },
  5376. feedbagManagerParams: feedbagManagerParams{
  5377. feedbagParams: feedbagParams{
  5378. {
  5379. screenName: state.NewIdentScreenName("test1"),
  5380. result: []wire.FeedbagItem{
  5381. {ClassID: wire.FeedbagClassIdAlInfo, Name: "link1", ItemID: 1},
  5382. {ClassID: wire.FeedbagClassIdAlInfo, Name: "link2", ItemID: 2},
  5383. {ClassID: wire.FeedbagClassIdAlInfo, Name: "link3", ItemID: 3},
  5384. {ClassID: wire.FeedbagClassIdAlInfo, Name: "link4", ItemID: 4},
  5385. },
  5386. },
  5387. },
  5388. },
  5389. },
  5390. },
  5391. {
  5392. name: "insert error returns 500",
  5393. screenname: "test1",
  5394. body: `{"linked_screen_name":"test2"}`,
  5395. statusCode: http.StatusInternalServerError,
  5396. want: `{"message":"internal server error"}`,
  5397. mockParams: mockParams{
  5398. userManagerParams: userManagerParams{
  5399. getUserParams: getUserParams{
  5400. {
  5401. screenName: state.NewIdentScreenName("test1"),
  5402. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5403. },
  5404. {
  5405. screenName: state.NewIdentScreenName("test2"),
  5406. result: &state.User{IdentScreenName: state.NewIdentScreenName("test2")},
  5407. },
  5408. },
  5409. },
  5410. feedbagManagerParams: feedbagManagerParams{
  5411. feedbagParams: feedbagParams{
  5412. {
  5413. screenName: state.NewIdentScreenName("test1"),
  5414. result: []wire.FeedbagItem{},
  5415. },
  5416. },
  5417. feedbagUpsertParams: feedbagUpsertParams{
  5418. {
  5419. screenName: state.NewIdentScreenName("test1"),
  5420. items: []wire.FeedbagItem{
  5421. {ItemID: 1, ClassID: wire.FeedbagClassIdAlInfo, Name: "test2"},
  5422. },
  5423. err: io.EOF,
  5424. },
  5425. },
  5426. },
  5427. },
  5428. },
  5429. {
  5430. name: "link created returns 201",
  5431. screenname: "test1",
  5432. body: `{"linked_screen_name":"test2"}`,
  5433. statusCode: http.StatusCreated,
  5434. want: ``,
  5435. mockParams: mockParams{
  5436. userManagerParams: userManagerParams{
  5437. getUserParams: getUserParams{
  5438. {
  5439. screenName: state.NewIdentScreenName("test1"),
  5440. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5441. },
  5442. {
  5443. screenName: state.NewIdentScreenName("test2"),
  5444. result: &state.User{IdentScreenName: state.NewIdentScreenName("test2")},
  5445. },
  5446. },
  5447. },
  5448. feedbagManagerParams: feedbagManagerParams{
  5449. feedbagParams: feedbagParams{
  5450. {
  5451. screenName: state.NewIdentScreenName("test1"),
  5452. result: []wire.FeedbagItem{},
  5453. },
  5454. },
  5455. feedbagUpsertParams: feedbagUpsertParams{
  5456. {
  5457. screenName: state.NewIdentScreenName("test1"),
  5458. items: []wire.FeedbagItem{
  5459. {ItemID: 1, ClassID: wire.FeedbagClassIdAlInfo, Name: "test2"},
  5460. },
  5461. },
  5462. },
  5463. },
  5464. },
  5465. },
  5466. }
  5467. for _, tc := range tt {
  5468. t.Run(tc.name, func(t *testing.T) {
  5469. request := httptest.NewRequest(http.MethodPost, "/user/"+tc.screenname+"/linked-account", strings.NewReader(tc.body))
  5470. request.SetPathValue("screenname", tc.screenname)
  5471. responseRecorder := httptest.NewRecorder()
  5472. userManager := newMockUserManager(t)
  5473. for _, params := range tc.mockParams.getUserParams {
  5474. userManager.EXPECT().
  5475. User(matchContext(), params.screenName).
  5476. Return(params.result, params.err)
  5477. }
  5478. feedbagManager := newMockFeedbagManager(t)
  5479. for _, params := range tc.mockParams.feedbagParams {
  5480. feedbagManager.EXPECT().
  5481. Feedbag(matchContext(), params.screenName).
  5482. Return(params.result, params.err)
  5483. }
  5484. for _, params := range tc.mockParams.feedbagUpsertParams {
  5485. feedbagManager.EXPECT().
  5486. FeedbagUpsert(matchContext(), params.screenName, params.items).
  5487. Return(params.err)
  5488. }
  5489. postLinkedAccountHandler(responseRecorder, request, userManager, feedbagManager, slog.Default(), func(n int) int { return 0 })
  5490. assert.Equal(t, tc.statusCode, responseRecorder.Code)
  5491. assert.Equal(t, tc.want, strings.TrimSpace(responseRecorder.Body.String()))
  5492. })
  5493. }
  5494. }
  5495. func TestDeleteLinkedAccountHandler(t *testing.T) {
  5496. linkedFeedbagItem := wire.FeedbagItem{
  5497. ItemID: 1,
  5498. ClassID: wire.FeedbagClassIdAlInfo,
  5499. Name: "test2",
  5500. }
  5501. tt := []struct {
  5502. name string
  5503. screenname string
  5504. linkedScreenname string
  5505. statusCode int
  5506. want string
  5507. mockParams mockParams
  5508. }{
  5509. {
  5510. name: "primary user not found returns 404",
  5511. screenname: "nobody",
  5512. linkedScreenname: "test2",
  5513. statusCode: http.StatusNotFound,
  5514. want: `{"message":"user not found"}`,
  5515. mockParams: mockParams{
  5516. userManagerParams: userManagerParams{
  5517. getUserParams: getUserParams{
  5518. {
  5519. screenName: state.NewIdentScreenName("nobody"),
  5520. result: nil,
  5521. },
  5522. },
  5523. },
  5524. },
  5525. },
  5526. {
  5527. name: "linked account not found returns 404",
  5528. screenname: "test1",
  5529. linkedScreenname: "ghost",
  5530. statusCode: http.StatusNotFound,
  5531. want: `{"message":"linked account not found"}`,
  5532. mockParams: mockParams{
  5533. userManagerParams: userManagerParams{
  5534. getUserParams: getUserParams{
  5535. {
  5536. screenName: state.NewIdentScreenName("test1"),
  5537. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5538. },
  5539. },
  5540. },
  5541. feedbagManagerParams: feedbagManagerParams{
  5542. feedbagParams: feedbagParams{
  5543. {
  5544. screenName: state.NewIdentScreenName("test1"),
  5545. result: []wire.FeedbagItem{},
  5546. },
  5547. },
  5548. },
  5549. },
  5550. },
  5551. {
  5552. name: "delete error returns 500",
  5553. screenname: "test1",
  5554. linkedScreenname: "test2",
  5555. statusCode: http.StatusInternalServerError,
  5556. want: `{"message":"internal server error"}`,
  5557. mockParams: mockParams{
  5558. userManagerParams: userManagerParams{
  5559. getUserParams: getUserParams{
  5560. {
  5561. screenName: state.NewIdentScreenName("test1"),
  5562. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5563. },
  5564. },
  5565. },
  5566. feedbagManagerParams: feedbagManagerParams{
  5567. feedbagParams: feedbagParams{
  5568. {
  5569. screenName: state.NewIdentScreenName("test1"),
  5570. result: []wire.FeedbagItem{linkedFeedbagItem},
  5571. },
  5572. },
  5573. feedbagDeleteParams: feedbagDeleteParams{
  5574. {
  5575. screenName: state.NewIdentScreenName("test1"),
  5576. items: []wire.FeedbagItem{linkedFeedbagItem},
  5577. err: io.EOF,
  5578. },
  5579. },
  5580. },
  5581. },
  5582. },
  5583. {
  5584. name: "upsert error after delete returns 500",
  5585. screenname: "test1",
  5586. linkedScreenname: "test2",
  5587. statusCode: http.StatusInternalServerError,
  5588. want: `{"message":"internal server error"}`,
  5589. mockParams: mockParams{
  5590. userManagerParams: userManagerParams{
  5591. getUserParams: getUserParams{
  5592. {
  5593. screenName: state.NewIdentScreenName("test1"),
  5594. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5595. },
  5596. },
  5597. },
  5598. feedbagManagerParams: feedbagManagerParams{
  5599. feedbagParams: feedbagParams{
  5600. {
  5601. screenName: state.NewIdentScreenName("test1"),
  5602. result: []wire.FeedbagItem{linkedFeedbagItem},
  5603. },
  5604. },
  5605. feedbagDeleteParams: feedbagDeleteParams{
  5606. {
  5607. screenName: state.NewIdentScreenName("test1"),
  5608. items: []wire.FeedbagItem{linkedFeedbagItem},
  5609. },
  5610. },
  5611. feedbagUpsertParams: feedbagUpsertParams{
  5612. {
  5613. screenName: state.NewIdentScreenName("test1"),
  5614. items: []wire.FeedbagItem{{ClassID: wire.FeedbagClassIdGroup}},
  5615. err: io.EOF,
  5616. },
  5617. },
  5618. },
  5619. },
  5620. },
  5621. {
  5622. name: "link deleted returns 204",
  5623. screenname: "test1",
  5624. linkedScreenname: "test2",
  5625. statusCode: http.StatusNoContent,
  5626. want: ``,
  5627. mockParams: mockParams{
  5628. userManagerParams: userManagerParams{
  5629. getUserParams: getUserParams{
  5630. {
  5631. screenName: state.NewIdentScreenName("test1"),
  5632. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5633. },
  5634. },
  5635. },
  5636. feedbagManagerParams: feedbagManagerParams{
  5637. feedbagParams: feedbagParams{
  5638. {
  5639. screenName: state.NewIdentScreenName("test1"),
  5640. result: []wire.FeedbagItem{linkedFeedbagItem},
  5641. },
  5642. },
  5643. feedbagDeleteParams: feedbagDeleteParams{
  5644. {
  5645. screenName: state.NewIdentScreenName("test1"),
  5646. items: []wire.FeedbagItem{linkedFeedbagItem},
  5647. },
  5648. },
  5649. feedbagUpsertParams: feedbagUpsertParams{
  5650. {
  5651. screenName: state.NewIdentScreenName("test1"),
  5652. items: []wire.FeedbagItem{{ClassID: wire.FeedbagClassIdGroup}},
  5653. },
  5654. },
  5655. },
  5656. },
  5657. },
  5658. }
  5659. for _, tc := range tt {
  5660. t.Run(tc.name, func(t *testing.T) {
  5661. request := httptest.NewRequest(http.MethodDelete, "/user/"+tc.screenname+"/linked-account/"+tc.linkedScreenname, nil)
  5662. request.SetPathValue("screenname", tc.screenname)
  5663. request.SetPathValue("linked_screenname", tc.linkedScreenname)
  5664. responseRecorder := httptest.NewRecorder()
  5665. userManager := newMockUserManager(t)
  5666. for _, params := range tc.mockParams.getUserParams {
  5667. userManager.EXPECT().
  5668. User(matchContext(), params.screenName).
  5669. Return(params.result, params.err)
  5670. }
  5671. feedbagManager := newMockFeedbagManager(t)
  5672. for _, params := range tc.mockParams.feedbagParams {
  5673. feedbagManager.EXPECT().
  5674. Feedbag(matchContext(), params.screenName).
  5675. Return(params.result, params.err)
  5676. }
  5677. for _, params := range tc.mockParams.feedbagDeleteParams {
  5678. feedbagManager.EXPECT().
  5679. FeedbagDelete(matchContext(), params.screenName, params.items).
  5680. Return(params.err)
  5681. }
  5682. for _, params := range tc.mockParams.feedbagUpsertParams {
  5683. feedbagManager.EXPECT().
  5684. FeedbagUpsert(matchContext(), params.screenName, params.items).
  5685. Return(params.err)
  5686. }
  5687. deleteLinkedAccountHandler(responseRecorder, request, userManager, feedbagManager, slog.Default(), nil)
  5688. assert.Equal(t, tc.statusCode, responseRecorder.Code)
  5689. assert.Equal(t, tc.want, strings.TrimSpace(responseRecorder.Body.String()))
  5690. })
  5691. }
  5692. }