| 1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495969798991001011021031041051061071081091101111121131141151161171181191201211221231241251261271281291301311321331341351361371381391401411421431441451461471481491501511521531541551561571581591601611621631641651661671681691701711721731741751761771781791801811821831841851861871881891901911921931941951961971981992002012022032042052062072082092102112122132142152162172182192202212222232242252262272282292302312322332342352362372382392402412422432442452462472482492502512522532542552562572582592602612622632642652662672682692702712722732742752762772782792802812822832842852862872882892902912922932942952962972982993003013023033043053063073083093103113123133143153163173183193203213223233243253263273283293303313323333343353363373383393403413423433443453463473483493503513523533543553563573583593603613623633643653663673683693703713723733743753763773783793803813823833843853863873883893903913923933943953963973983994004014024034044054064074084094104114124134144154164174184194204214224234244254264274284294304314324334344354364374384394404414424434444454464474484494504514524534544554564574584594604614624634644654664674684694704714724734744754764774784794804814824834844854864874884894904914924934944954964974984995005015025035045055065075085095105115125135145155165175185195205215225235245255265275285295305315325335345355365375385395405415425435445455465475485495505515525535545555565575585595605615625635645655665675685695705715725735745755765775785795805815825835845855865875885895905915925935945955965975985996006016026036046056066076086096106116126136146156166176186196206216226236246256266276286296306316326336346356366376386396406416426436446456466476486496506516526536546556566576586596606616626636646656666676686696706716726736746756766776786796806816826836846856866876886896906916926936946956966976986997007017027037047057067077087097107117127137147157167177187197207217227237247257267277287297307317327337347357367377387397407417427437447457467477487497507517527537547557567577587597607617627637647657667677687697707717727737747757767777787797807817827837847857867877887897907917927937947957967977987998008018028038048058068078088098108118128138148158168178188198208218228238248258268278288298308318328338348358368378388398408418428438448458468478488498508518528538548558568578588598608618628638648658668678688698708718728738748758768778788798808818828838848858868878888898908918928938948958968978988999009019029039049059069079089099109119129139149159169179189199209219229239249259269279289299309319329339349359369379389399409419429439449459469479489499509519529539549559569579589599609619629639649659669679689699709719729739749759769779789799809819829839849859869879889899909919929939949959969979989991000100110021003100410051006100710081009101010111012101310141015101610171018101910201021102210231024102510261027102810291030103110321033103410351036103710381039104010411042104310441045104610471048104910501051105210531054105510561057105810591060106110621063106410651066106710681069107010711072107310741075107610771078107910801081108210831084108510861087108810891090109110921093109410951096109710981099110011011102110311041105110611071108110911101111111211131114111511161117111811191120112111221123112411251126112711281129113011311132113311341135113611371138113911401141114211431144114511461147114811491150115111521153115411551156115711581159116011611162116311641165116611671168116911701171117211731174117511761177117811791180118111821183118411851186118711881189119011911192119311941195119611971198119912001201120212031204120512061207120812091210121112121213121412151216121712181219122012211222122312241225122612271228122912301231123212331234123512361237123812391240124112421243124412451246124712481249125012511252125312541255125612571258125912601261126212631264126512661267126812691270127112721273127412751276127712781279128012811282128312841285128612871288128912901291129212931294129512961297129812991300130113021303130413051306130713081309131013111312131313141315131613171318131913201321132213231324132513261327132813291330133113321333133413351336133713381339134013411342134313441345134613471348134913501351135213531354135513561357135813591360136113621363136413651366136713681369137013711372137313741375137613771378137913801381138213831384138513861387138813891390139113921393139413951396139713981399140014011402140314041405140614071408140914101411141214131414141514161417141814191420142114221423142414251426142714281429143014311432143314341435143614371438143914401441144214431444144514461447144814491450145114521453145414551456145714581459146014611462146314641465146614671468146914701471147214731474147514761477147814791480148114821483148414851486148714881489149014911492149314941495149614971498149915001501150215031504150515061507150815091510151115121513151415151516151715181519152015211522152315241525152615271528152915301531153215331534153515361537153815391540154115421543154415451546154715481549155015511552155315541555155615571558155915601561156215631564156515661567156815691570157115721573157415751576157715781579158015811582158315841585158615871588158915901591159215931594159515961597159815991600160116021603160416051606160716081609161016111612161316141615161616171618161916201621162216231624162516261627162816291630163116321633163416351636163716381639164016411642164316441645164616471648164916501651165216531654165516561657165816591660166116621663166416651666166716681669167016711672167316741675167616771678167916801681168216831684168516861687168816891690169116921693169416951696169716981699170017011702170317041705170617071708170917101711171217131714171517161717171817191720172117221723172417251726172717281729173017311732173317341735173617371738173917401741174217431744174517461747174817491750175117521753175417551756175717581759176017611762176317641765176617671768176917701771177217731774177517761777177817791780178117821783178417851786178717881789179017911792179317941795179617971798179918001801180218031804180518061807180818091810181118121813181418151816181718181819182018211822182318241825182618271828182918301831183218331834183518361837183818391840184118421843184418451846184718481849185018511852185318541855185618571858185918601861186218631864186518661867186818691870187118721873187418751876187718781879188018811882188318841885188618871888188918901891189218931894189518961897189818991900190119021903190419051906190719081909191019111912191319141915191619171918191919201921192219231924192519261927192819291930193119321933193419351936193719381939194019411942194319441945194619471948194919501951195219531954195519561957195819591960196119621963196419651966196719681969197019711972197319741975197619771978197919801981198219831984198519861987198819891990199119921993199419951996199719981999200020012002200320042005200620072008200920102011201220132014201520162017201820192020202120222023202420252026202720282029203020312032203320342035203620372038203920402041204220432044204520462047204820492050205120522053205420552056205720582059206020612062206320642065206620672068206920702071207220732074207520762077207820792080208120822083208420852086208720882089209020912092209320942095209620972098209921002101210221032104210521062107210821092110211121122113211421152116211721182119212021212122212321242125212621272128212921302131213221332134213521362137213821392140214121422143214421452146214721482149215021512152215321542155215621572158215921602161216221632164216521662167216821692170217121722173217421752176217721782179218021812182218321842185218621872188218921902191219221932194219521962197219821992200220122022203220422052206220722082209221022112212221322142215221622172218221922202221222222232224222522262227222822292230223122322233223422352236223722382239224022412242224322442245224622472248224922502251225222532254225522562257225822592260226122622263226422652266226722682269227022712272227322742275227622772278227922802281228222832284228522862287228822892290229122922293229422952296229722982299230023012302230323042305230623072308230923102311231223132314231523162317231823192320232123222323232423252326232723282329233023312332233323342335233623372338233923402341234223432344234523462347234823492350235123522353235423552356235723582359236023612362236323642365236623672368236923702371237223732374237523762377237823792380238123822383238423852386238723882389239023912392239323942395239623972398239924002401240224032404240524062407240824092410241124122413241424152416241724182419242024212422242324242425242624272428242924302431243224332434243524362437243824392440244124422443244424452446244724482449245024512452245324542455245624572458245924602461246224632464246524662467246824692470247124722473247424752476247724782479248024812482248324842485248624872488248924902491249224932494249524962497249824992500250125022503250425052506250725082509251025112512251325142515251625172518251925202521252225232524252525262527252825292530253125322533253425352536253725382539254025412542254325442545254625472548254925502551255225532554255525562557255825592560256125622563256425652566256725682569257025712572257325742575257625772578257925802581258225832584258525862587258825892590259125922593259425952596259725982599260026012602260326042605260626072608260926102611261226132614261526162617261826192620262126222623262426252626262726282629263026312632263326342635263626372638263926402641264226432644264526462647264826492650265126522653265426552656265726582659266026612662266326642665266626672668266926702671267226732674267526762677267826792680268126822683268426852686268726882689269026912692269326942695269626972698269927002701270227032704270527062707270827092710271127122713271427152716271727182719272027212722272327242725272627272728272927302731273227332734273527362737273827392740274127422743274427452746274727482749275027512752275327542755275627572758275927602761276227632764276527662767276827692770277127722773277427752776277727782779278027812782278327842785278627872788278927902791279227932794279527962797279827992800280128022803280428052806280728082809281028112812281328142815281628172818281928202821282228232824282528262827282828292830283128322833283428352836283728382839284028412842284328442845284628472848284928502851285228532854285528562857285828592860286128622863286428652866286728682869287028712872287328742875287628772878287928802881288228832884288528862887288828892890289128922893289428952896289728982899290029012902290329042905290629072908290929102911291229132914291529162917291829192920292129222923292429252926292729282929293029312932293329342935293629372938293929402941294229432944294529462947294829492950295129522953295429552956295729582959296029612962296329642965296629672968296929702971297229732974297529762977297829792980298129822983298429852986298729882989299029912992299329942995299629972998299930003001300230033004300530063007300830093010301130123013301430153016301730183019302030213022302330243025302630273028302930303031303230333034303530363037303830393040304130423043304430453046304730483049305030513052305330543055305630573058305930603061306230633064306530663067306830693070307130723073307430753076307730783079308030813082308330843085308630873088308930903091309230933094309530963097309830993100310131023103310431053106310731083109311031113112311331143115311631173118311931203121312231233124312531263127312831293130313131323133313431353136313731383139314031413142314331443145314631473148314931503151315231533154315531563157315831593160316131623163316431653166316731683169317031713172317331743175317631773178317931803181318231833184318531863187318831893190319131923193319431953196319731983199320032013202320332043205320632073208320932103211321232133214321532163217321832193220322132223223322432253226322732283229323032313232323332343235323632373238323932403241324232433244324532463247324832493250325132523253325432553256325732583259326032613262326332643265326632673268326932703271327232733274327532763277327832793280328132823283328432853286328732883289329032913292329332943295329632973298329933003301330233033304330533063307330833093310331133123313331433153316331733183319332033213322332333243325332633273328332933303331333233333334333533363337333833393340334133423343334433453346334733483349335033513352335333543355335633573358335933603361336233633364336533663367336833693370337133723373337433753376337733783379338033813382338333843385338633873388338933903391339233933394339533963397339833993400340134023403340434053406340734083409341034113412341334143415341634173418341934203421342234233424342534263427342834293430343134323433343434353436343734383439344034413442344334443445344634473448344934503451345234533454345534563457345834593460346134623463346434653466346734683469347034713472347334743475347634773478347934803481348234833484348534863487348834893490349134923493349434953496349734983499350035013502350335043505350635073508350935103511351235133514351535163517351835193520352135223523352435253526352735283529353035313532353335343535353635373538353935403541354235433544354535463547354835493550355135523553355435553556355735583559356035613562356335643565356635673568356935703571357235733574357535763577357835793580358135823583358435853586358735883589359035913592359335943595359635973598359936003601360236033604360536063607360836093610361136123613361436153616361736183619362036213622362336243625362636273628362936303631363236333634363536363637363836393640364136423643364436453646364736483649365036513652365336543655365636573658365936603661366236633664366536663667366836693670367136723673367436753676367736783679368036813682368336843685368636873688368936903691369236933694369536963697369836993700370137023703370437053706370737083709371037113712371337143715371637173718371937203721372237233724372537263727372837293730373137323733373437353736373737383739374037413742374337443745374637473748374937503751375237533754375537563757375837593760376137623763376437653766376737683769377037713772377337743775377637773778377937803781378237833784378537863787378837893790379137923793379437953796379737983799380038013802380338043805380638073808380938103811381238133814381538163817381838193820382138223823382438253826382738283829383038313832383338343835383638373838383938403841384238433844384538463847384838493850385138523853385438553856385738583859386038613862386338643865386638673868386938703871387238733874387538763877387838793880388138823883388438853886388738883889389038913892389338943895389638973898389939003901390239033904390539063907390839093910391139123913391439153916391739183919392039213922392339243925392639273928392939303931393239333934393539363937393839393940394139423943394439453946394739483949395039513952395339543955395639573958395939603961396239633964396539663967396839693970397139723973397439753976397739783979398039813982398339843985398639873988398939903991399239933994399539963997399839994000400140024003400440054006400740084009401040114012401340144015401640174018401940204021402240234024402540264027402840294030403140324033403440354036403740384039404040414042404340444045404640474048404940504051405240534054405540564057405840594060406140624063406440654066406740684069407040714072407340744075407640774078407940804081408240834084408540864087408840894090409140924093409440954096409740984099410041014102410341044105410641074108410941104111411241134114411541164117411841194120412141224123412441254126412741284129413041314132413341344135413641374138413941404141414241434144414541464147414841494150415141524153415441554156415741584159416041614162416341644165416641674168416941704171417241734174417541764177417841794180418141824183418441854186418741884189419041914192419341944195419641974198419942004201420242034204420542064207420842094210421142124213421442154216421742184219422042214222422342244225422642274228422942304231423242334234423542364237423842394240424142424243424442454246424742484249425042514252425342544255425642574258425942604261426242634264426542664267426842694270427142724273427442754276427742784279428042814282428342844285428642874288428942904291429242934294429542964297429842994300430143024303430443054306430743084309431043114312431343144315431643174318431943204321432243234324432543264327432843294330433143324333433443354336433743384339434043414342434343444345434643474348434943504351435243534354435543564357435843594360436143624363436443654366436743684369437043714372437343744375437643774378437943804381438243834384438543864387438843894390439143924393439443954396439743984399440044014402440344044405440644074408440944104411441244134414441544164417441844194420442144224423442444254426442744284429443044314432443344344435443644374438443944404441444244434444444544464447444844494450445144524453445444554456445744584459446044614462446344644465446644674468446944704471447244734474447544764477447844794480448144824483448444854486448744884489449044914492449344944495449644974498449945004501450245034504450545064507450845094510451145124513451445154516451745184519452045214522452345244525452645274528452945304531453245334534453545364537453845394540454145424543454445454546454745484549455045514552455345544555455645574558455945604561456245634564456545664567456845694570457145724573457445754576457745784579458045814582458345844585458645874588458945904591459245934594459545964597459845994600460146024603460446054606460746084609461046114612461346144615461646174618461946204621462246234624462546264627462846294630463146324633463446354636463746384639464046414642464346444645464646474648464946504651465246534654465546564657465846594660466146624663466446654666466746684669467046714672467346744675467646774678467946804681468246834684468546864687468846894690469146924693469446954696469746984699470047014702470347044705470647074708470947104711471247134714471547164717471847194720472147224723472447254726472747284729473047314732473347344735473647374738473947404741474247434744474547464747474847494750475147524753475447554756475747584759476047614762476347644765476647674768476947704771477247734774477547764777477847794780478147824783478447854786478747884789479047914792479347944795479647974798479948004801480248034804480548064807480848094810481148124813481448154816481748184819482048214822482348244825482648274828482948304831483248334834483548364837483848394840484148424843484448454846484748484849485048514852485348544855485648574858485948604861486248634864486548664867486848694870487148724873487448754876487748784879488048814882488348844885488648874888488948904891489248934894489548964897489848994900490149024903490449054906490749084909491049114912491349144915491649174918491949204921492249234924492549264927492849294930493149324933493449354936493749384939494049414942494349444945494649474948494949504951495249534954495549564957495849594960496149624963496449654966496749684969497049714972497349744975497649774978497949804981498249834984498549864987498849894990499149924993499449954996499749984999500050015002500350045005500650075008500950105011501250135014501550165017501850195020502150225023502450255026502750285029503050315032503350345035503650375038503950405041504250435044504550465047504850495050505150525053505450555056505750585059506050615062506350645065506650675068506950705071507250735074507550765077507850795080508150825083508450855086508750885089509050915092509350945095509650975098509951005101510251035104510551065107510851095110511151125113511451155116511751185119512051215122512351245125512651275128512951305131513251335134513551365137513851395140514151425143514451455146514751485149515051515152515351545155515651575158515951605161516251635164516551665167516851695170517151725173517451755176517751785179518051815182518351845185518651875188518951905191519251935194519551965197519851995200520152025203520452055206520752085209521052115212521352145215521652175218521952205221522252235224522552265227522852295230523152325233523452355236523752385239524052415242524352445245524652475248524952505251525252535254525552565257525852595260526152625263526452655266526752685269527052715272527352745275527652775278527952805281528252835284528552865287528852895290529152925293529452955296529752985299530053015302530353045305530653075308530953105311531253135314531553165317531853195320532153225323532453255326532753285329533053315332533353345335533653375338533953405341534253435344534553465347534853495350535153525353535453555356535753585359536053615362536353645365536653675368536953705371537253735374537553765377537853795380538153825383538453855386538753885389539053915392539353945395539653975398539954005401540254035404540554065407540854095410541154125413541454155416541754185419542054215422542354245425542654275428542954305431543254335434543554365437543854395440544154425443544454455446544754485449545054515452545354545455545654575458545954605461546254635464546554665467546854695470547154725473547454755476547754785479548054815482548354845485548654875488548954905491549254935494549554965497549854995500550155025503550455055506550755085509551055115512551355145515551655175518551955205521552255235524552555265527552855295530553155325533553455355536553755385539554055415542554355445545554655475548554955505551555255535554555555565557555855595560556155625563556455655566556755685569557055715572557355745575557655775578557955805581558255835584558555865587558855895590559155925593559455955596559755985599560056015602560356045605560656075608560956105611561256135614561556165617561856195620562156225623 |
- package http
- import (
- "context"
- "encoding/json"
- "errors"
- "fmt"
- "io"
- "log/slog"
- "math"
- "net/http"
- "net/http/httptest"
- "net/mail"
- "net/netip"
- "strings"
- "testing"
- "time"
- "github.com/stretchr/testify/assert"
- "github.com/stretchr/testify/mock"
- "github.com/mk6i/open-oscar-server/config"
- "github.com/mk6i/open-oscar-server/state"
- "github.com/mk6i/open-oscar-server/wire"
- )
- func TestSessionHandler_GET(t *testing.T) {
- // Fixed time for testing: 2024-01-01 12:00:00 UTC
- fixedNow := time.Date(2024, 1, 1, 12, 0, 0, 0, time.UTC)
- nowFn := func() time.Time { return fixedNow }
- tt := []struct {
- name string
- want string
- statusCode int
- createSessions func() []*state.Session
- }{
- {
- name: "without sessions",
- want: `{"count":0,"sessions":[]}`,
- statusCode: http.StatusOK,
- createSessions: func() []*state.Session {
- return []*state.Session{}
- },
- },
- {
- name: "with sessions",
- want: `{"count":3,"sessions":[{"id":"usera","screen_name":"userA","online_seconds":100,"is_away":false,"away_message":"","idle_seconds":0,"is_invisible":false,"is_icq":false,"instance_count":2,"instances":[{"num":1,"idle_seconds":30,"is_away":false,"away_message":"","is_invisible":false,"remote_addr":"1.2.3.4","remote_port":1234},{"num":2,"idle_seconds":0,"is_away":false,"away_message":"","is_invisible":true,"remote_addr":"5.6.7.8","remote_port":5678}]},{"id":"userb","screen_name":"userB","online_seconds":200,"is_away":false,"away_message":"","idle_seconds":0,"is_invisible":true,"is_icq":false,"instance_count":2,"instances":[{"num":1,"idle_seconds":0,"is_away":false,"away_message":"","is_invisible":true,"remote_addr":"9.10.11.12","remote_port":9012},{"num":2,"idle_seconds":0,"is_away":false,"away_message":"","is_invisible":true,"remote_addr":"13.14.15.16","remote_port":1314}]},{"id":"100003","screen_name":"100003","online_seconds":300,"is_away":false,"away_message":"","idle_seconds":0,"is_invisible":false,"is_icq":true,"instance_count":1,"instances":[{"num":1,"idle_seconds":0,"is_away":false,"away_message":"","is_invisible":false,"remote_addr":"1.2.3.4","remote_port":1234}]}]}`,
- statusCode: http.StatusOK,
- createSessions: func() []*state.Session {
- // userA: 2 instances - one idle (30s), one invisible
- userA := state.NewSession()
- userA.SetIdentScreenName(state.NewIdentScreenName("userA"))
- userA.SetDisplayScreenName(state.DisplayScreenName("userA"))
- userA.SetUIN(0)
- userA.SetNowFn(nowFn)
- userA.SetSignonTime(fixedNow.Add(-100 * time.Second))
- inst1 := userA.AddInstance()
- inst1.SetSignonComplete()
- inst1.SetIdle(30 * time.Second)
- ip1, _ := netip.ParseAddrPort("1.2.3.4:1234")
- inst1.SetRemoteAddr(&ip1)
- inst2 := userA.AddInstance()
- inst2.SetSignonComplete()
- inst2.SetUserStatusBitmask(wire.OServiceUserStatusInvisible)
- ip2, _ := netip.ParseAddrPort("5.6.7.8:5678")
- inst2.SetRemoteAddr(&ip2)
- // userB: 2 instances - both invisible
- userB := state.NewSession()
- userB.SetIdentScreenName(state.NewIdentScreenName("userB"))
- userB.SetDisplayScreenName(state.DisplayScreenName("userB"))
- userB.SetUIN(0)
- userB.SetNowFn(nowFn)
- userB.SetSignonTime(fixedNow.Add(-200 * time.Second))
- inst3 := userB.AddInstance()
- inst3.SetSignonComplete()
- inst3.SetUserStatusBitmask(wire.OServiceUserStatusInvisible)
- ip3, _ := netip.ParseAddrPort("9.10.11.12:9012")
- inst3.SetRemoteAddr(&ip3)
- inst4 := userB.AddInstance()
- inst4.SetSignonComplete()
- inst4.SetUserStatusBitmask(wire.OServiceUserStatusInvisible)
- ip4, _ := netip.ParseAddrPort("13.14.15.16:1314")
- inst4.SetRemoteAddr(&ip4)
- // 100003: 1 instance - normal
- icqUser := state.NewSession()
- icqUser.SetIdentScreenName(state.NewIdentScreenName("100003"))
- icqUser.SetDisplayScreenName(state.DisplayScreenName("100003"))
- icqUser.SetUIN(100003)
- icqUser.SetNowFn(nowFn)
- icqUser.SetSignonTime(fixedNow.Add(-300 * time.Second))
- inst5 := icqUser.AddInstance()
- inst5.SetSignonComplete()
- ip5, _ := netip.ParseAddrPort("1.2.3.4:1234")
- inst5.SetRemoteAddr(&ip5)
- return []*state.Session{userA, userB, icqUser}
- },
- },
- {
- name: "with away sessions",
- want: `{"count":2,"sessions":[{"id":"usera","screen_name":"userA","online_seconds":100,"is_away":false,"away_message":"","idle_seconds":0,"is_invisible":false,"is_icq":false,"instance_count":2,"instances":[{"num":1,"idle_seconds":0,"is_away":true,"away_message":"Away message 1","is_invisible":false,"remote_addr":"1.2.3.4","remote_port":1234},{"num":2,"idle_seconds":0,"is_away":false,"away_message":"","is_invisible":false,"remote_addr":"5.6.7.8","remote_port":5678}]},{"id":"userb","screen_name":"userB","online_seconds":200,"is_away":true,"away_message":"Away message 2","idle_seconds":0,"is_invisible":false,"is_icq":false,"instance_count":2,"instances":[{"num":1,"idle_seconds":0,"is_away":true,"away_message":"Away message 2","is_invisible":false,"remote_addr":"9.10.11.12","remote_port":9012},{"num":2,"idle_seconds":0,"is_away":true,"away_message":"Away message 2","is_invisible":false,"remote_addr":"13.14.15.16","remote_port":1314}]}]}`,
- statusCode: http.StatusOK,
- createSessions: func() []*state.Session {
- // userA: 2 instances - one away, one not away (away_message should be "")
- userA := state.NewSession()
- userA.SetIdentScreenName(state.NewIdentScreenName("userA"))
- userA.SetDisplayScreenName(state.DisplayScreenName("userA"))
- userA.SetUIN(0)
- userA.SetNowFn(nowFn)
- userA.SetSignonTime(fixedNow.Add(-100 * time.Second))
- inst1 := userA.AddInstance()
- inst1.SetSignonComplete()
- inst1.SetUserStatusBitmask(wire.OServiceUserStatusAway)
- inst1.SetAwayMessage("Away message 1")
- ip1, _ := netip.ParseAddrPort("1.2.3.4:1234")
- inst1.SetRemoteAddr(&ip1)
- inst2 := userA.AddInstance()
- inst2.SetSignonComplete()
- ip2, _ := netip.ParseAddrPort("5.6.7.8:5678")
- inst2.SetRemoteAddr(&ip2)
- // userB: 2 instances - both away (away_message should be populated)
- userB := state.NewSession()
- userB.SetIdentScreenName(state.NewIdentScreenName("userB"))
- userB.SetDisplayScreenName(state.DisplayScreenName("userB"))
- userB.SetUIN(0)
- userB.SetNowFn(nowFn)
- userB.SetSignonTime(fixedNow.Add(-200 * time.Second))
- inst3 := userB.AddInstance()
- inst3.SetSignonComplete()
- inst3.SetUserStatusBitmask(wire.OServiceUserStatusAway)
- inst3.SetAwayMessage("Away message 2")
- ip3, _ := netip.ParseAddrPort("9.10.11.12:9012")
- inst3.SetRemoteAddr(&ip3)
- inst4 := userB.AddInstance()
- inst4.SetSignonComplete()
- inst4.SetUserStatusBitmask(wire.OServiceUserStatusAway)
- inst4.SetAwayMessage("Away message 2")
- ip4, _ := netip.ParseAddrPort("13.14.15.16:1314")
- inst4.SetRemoteAddr(&ip4)
- return []*state.Session{userA, userB}
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- request := httptest.NewRequest(http.MethodGet, "/session", nil)
- responseRecorder := httptest.NewRecorder()
- sessionRetriever := newMockSessionRetriever(t)
- sessions := tc.createSessions()
- sessionRetriever.EXPECT().
- AllSessions().
- Return(sessions)
- getSessionHandler(responseRecorder, request, sessionRetriever, nowFn)
- if responseRecorder.Code != tc.statusCode {
- t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
- }
- if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
- t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
- }
- })
- }
- }
- func TestSessionHandlerScreenname_GET(t *testing.T) {
- // Fixed time for testing: 2024-01-01 12:00:00 UTC
- fixedNow := time.Date(2024, 1, 1, 12, 0, 0, 0, time.UTC)
- nowFn := func() time.Time { return fixedNow }
- tt := []struct {
- name string
- requestScreenName state.IdentScreenName
- want string
- statusCode int
- createSession func() *state.Session
- }{
- {
- name: "no session for screenname",
- requestScreenName: state.NewIdentScreenName("userA"),
- want: `session not found`,
- statusCode: http.StatusNotFound,
- createSession: func() *state.Session {
- return nil
- },
- },
- {
- name: "active session found for screenname",
- requestScreenName: state.NewIdentScreenName("userA"),
- want: `{"count":1,"sessions":[{"id":"usera","screen_name":"userA","online_seconds":150,"is_away":false,"away_message":"","idle_seconds":0,"is_invisible":false,"is_icq":false,"instance_count":1,"instances":[{"num":1,"idle_seconds":0,"is_away":false,"away_message":"","is_invisible":false,"remote_addr":"1.2.3.4","remote_port":1234}]}]}`,
- statusCode: http.StatusOK,
- createSession: func() *state.Session {
- sess := state.NewSession()
- sess.SetIdentScreenName(state.NewIdentScreenName("userA"))
- sess.SetDisplayScreenName(state.DisplayScreenName("userA"))
- sess.SetUIN(0)
- sess.SetNowFn(nowFn)
- sess.SetSignonTime(fixedNow.Add(-150 * time.Second))
- instance := sess.AddInstance()
- instance.SetSignonComplete()
- ip, _ := netip.ParseAddrPort("1.2.3.4:1234")
- instance.SetRemoteAddr(&ip)
- return sess
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- request := httptest.NewRequest(http.MethodGet, "/session/"+tc.requestScreenName.String(), nil)
- request.SetPathValue("screenname", tc.requestScreenName.String())
- responseRecorder := httptest.NewRecorder()
- sessionRetriever := newMockSessionRetriever(t)
- session := tc.createSession()
- sessionRetriever.EXPECT().
- RetrieveSession(tc.requestScreenName).
- Return(session)
- getSessionHandler(responseRecorder, request, sessionRetriever, nowFn)
- if responseRecorder.Code != tc.statusCode {
- t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
- }
- if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
- t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
- }
- })
- }
- }
- func TestSessionHandlerScreenname_DELETE(t *testing.T) {
- fnNewSess := func(screenName string) *state.Session {
- sess := state.NewSession()
- sess.SetIdentScreenName(state.NewIdentScreenName(screenName))
- sess.SetDisplayScreenName(state.DisplayScreenName(screenName))
- instance := sess.AddInstance()
- instance.SetSignonComplete()
- ip, _ := netip.ParseAddrPort("1.2.3.4:1234")
- instance.SetRemoteAddr(&ip)
- return sess
- }
- tt := []struct {
- name string
- session *state.SessionInstance
- requestScreenName state.IdentScreenName
- statusCode int
- mockParams mockParams
- }{
- {
- name: "delete an active session",
- requestScreenName: state.NewIdentScreenName("userA"),
- statusCode: http.StatusNoContent,
- mockParams: mockParams{
- sessionRetrieverParams: sessionRetrieverParams{
- retrieveSessionByNameParams: retrieveSessionByNameParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: fnNewSess("userA"),
- },
- },
- },
- },
- },
- {
- name: "delete a non-existent session",
- requestScreenName: state.NewIdentScreenName("userA"),
- statusCode: http.StatusNotFound,
- mockParams: mockParams{
- sessionRetrieverParams: sessionRetrieverParams{
- retrieveSessionByNameParams: retrieveSessionByNameParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: nil,
- },
- },
- },
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- request := httptest.NewRequest(http.MethodDelete, "/session/"+tc.requestScreenName.String(), nil)
- request.SetPathValue("screenname", tc.requestScreenName.String())
- responseRecorder := httptest.NewRecorder()
- sessionRetriever := newMockSessionRetriever(t)
- for _, params := range tc.mockParams.retrieveSessionByNameParams {
- sessionRetriever.EXPECT().
- RetrieveSession(params.screenName).
- Return(params.result)
- }
- deleteSessionHandler(responseRecorder, request, sessionRetriever)
- if responseRecorder.Code != tc.statusCode {
- t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
- }
- })
- }
- }
- func TestUserAccountHandler_GET(t *testing.T) {
- tt := []struct {
- name string
- requestScreenName state.IdentScreenName
- want string
- statusCode int
- mockParams mockParams
- }{
- {
- name: "invalid account",
- requestScreenName: state.NewIdentScreenName("userA"),
- want: `user not found`,
- statusCode: http.StatusNotFound,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: nil,
- },
- },
- },
- },
- },
- {
- name: "valid aim account",
- requestScreenName: state.NewIdentScreenName("userA"),
- want: `{"id":"usera","screen_name":"userA","profile":"My Profile Text","email_address":"\u003cuserA@aol.com\u003e","reg_status":2,"confirmed":true,"is_icq":false,"suspended_status":"","is_bot":false}`,
- statusCode: http.StatusOK,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: &state.User{
- DisplayScreenName: "userA",
- IdentScreenName: state.NewIdentScreenName("userA"),
- SuspendedStatus: 0x0,
- },
- },
- },
- },
- accountManagerParams: accountManagerParams{
- EmailAddressParams: EmailAddressParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: &mail.Address{
- Address: "userA@aol.com",
- },
- },
- },
- RegStatusParams: RegStatusParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: uint16(0x02),
- },
- },
- ConfirmStatusParams: ConfirmStatusParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: true,
- },
- },
- },
- profileRetrieverParams: profileRetrieverParams{
- retrieveProfileParams: retrieveProfileParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: state.UserProfile{ProfileText: "My Profile Text"},
- },
- },
- },
- },
- },
- {
- name: "valid aim bot account",
- requestScreenName: state.NewIdentScreenName("userA"),
- want: `{"id":"usera","screen_name":"userA","profile":"My Profile Text","email_address":"\u003cuserA@aol.com\u003e","reg_status":2,"confirmed":true,"is_icq":false,"suspended_status":"","is_bot":true}`,
- statusCode: http.StatusOK,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: &state.User{
- DisplayScreenName: "userA",
- IdentScreenName: state.NewIdentScreenName("userA"),
- SuspendedStatus: 0x0,
- IsBot: true,
- },
- },
- },
- },
- accountManagerParams: accountManagerParams{
- EmailAddressParams: EmailAddressParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: &mail.Address{
- Address: "userA@aol.com",
- },
- },
- },
- RegStatusParams: RegStatusParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: uint16(0x02),
- },
- },
- ConfirmStatusParams: ConfirmStatusParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: true,
- },
- },
- },
- profileRetrieverParams: profileRetrieverParams{
- retrieveProfileParams: retrieveProfileParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: state.UserProfile{ProfileText: "My Profile Text"},
- },
- },
- },
- },
- },
- {
- name: "suspended aim account",
- requestScreenName: state.NewIdentScreenName("userB"),
- want: `{"id":"userb","screen_name":"userB","profile":"My Profile Text","email_address":"\u003cuserB@aol.com\u003e","reg_status":2,"confirmed":true,"is_icq":false,"suspended_status":"suspended","is_bot":false}`,
- statusCode: http.StatusOK,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("userB"),
- result: &state.User{
- DisplayScreenName: "userB",
- IdentScreenName: state.NewIdentScreenName("userB"),
- SuspendedStatus: wire.LoginErrSuspendedAccount,
- },
- },
- },
- },
- accountManagerParams: accountManagerParams{
- EmailAddressParams: EmailAddressParams{
- {
- screenName: state.NewIdentScreenName("userB"),
- result: &mail.Address{
- Address: "userB@aol.com",
- },
- },
- },
- RegStatusParams: RegStatusParams{
- {
- screenName: state.NewIdentScreenName("userB"),
- result: uint16(0x02),
- },
- },
- ConfirmStatusParams: ConfirmStatusParams{
- {
- screenName: state.NewIdentScreenName("userB"),
- result: true,
- },
- },
- },
- profileRetrieverParams: profileRetrieverParams{
- retrieveProfileParams: retrieveProfileParams{
- {
- screenName: state.NewIdentScreenName("userB"),
- result: state.UserProfile{ProfileText: "My Profile Text"},
- },
- },
- },
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- request := httptest.NewRequest(http.MethodGet, "/user/"+tc.requestScreenName.String()+"/account", nil)
- request.SetPathValue("screenname", tc.requestScreenName.String())
- responseRecorder := httptest.NewRecorder()
- userManager := newMockUserManager(t)
- for _, params := range tc.mockParams.getUserParams {
- userManager.EXPECT().
- User(matchContext(), params.screenName).
- Return(params.result, params.err)
- }
- accountManager := newMockAccountManager(t)
- for _, params := range tc.mockParams.EmailAddressParams {
- accountManager.EXPECT().
- EmailAddress(matchContext(), params.screenName).
- Return(params.result, params.err)
- }
- for _, params := range tc.mockParams.RegStatusParams {
- accountManager.EXPECT().
- RegStatus(matchContext(), params.screenName).
- Return(params.result, params.err)
- }
- for _, params := range tc.mockParams.ConfirmStatusParams {
- accountManager.EXPECT().
- ConfirmStatus(matchContext(), params.screenName).
- Return(params.result, params.err)
- }
- profileRetriever := newMockProfileRetriever(t)
- for _, params := range tc.mockParams.retrieveProfileParams {
- profileRetriever.EXPECT().
- Profile(matchContext(), params.screenName).
- Return(params.result, params.err)
- }
- getUserAccountHandler(responseRecorder, request, userManager, accountManager, profileRetriever, slog.Default())
- if responseRecorder.Code != tc.statusCode {
- t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
- }
- if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
- t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
- }
- })
- }
- }
- func TestUserAccountHandler_PATCH(t *testing.T) {
- tt := []struct {
- name string
- requestScreenName state.IdentScreenName
- want string
- body string
- statusCode int
- mockParams mockParams
- }{
- {
- name: "suspending a non-existent account",
- requestScreenName: state.NewIdentScreenName("userA"),
- body: `{"suspended_status":"suspended"}`,
- want: `user not found`,
- statusCode: http.StatusNotFound,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: nil,
- },
- },
- },
- },
- },
- {
- name: "patching with invalid suspended_status value",
- requestScreenName: state.NewIdentScreenName("userA"),
- body: `{"suspended_status":"thisisinvalid"}`,
- want: `{"message":"suspended_status must be empty str or one of deleted,expired,suspended,suspended_age"}`,
- statusCode: http.StatusBadRequest,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: &state.User{},
- },
- },
- },
- },
- },
- {
- name: "suspending an active aim account",
- requestScreenName: state.NewIdentScreenName("userA"),
- statusCode: http.StatusNoContent,
- body: `{"suspended_status":"suspended"}`,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: &state.User{
- DisplayScreenName: "userA",
- IdentScreenName: state.NewIdentScreenName("userA"),
- SuspendedStatus: 0x0,
- },
- },
- },
- },
- accountManagerParams: accountManagerParams{
- updateSuspendedStatusParams: updateSuspendedStatusParams{
- {
- suspendedStatus: wire.LoginErrSuspendedAccount,
- screenName: state.NewIdentScreenName("userA"),
- err: nil,
- },
- },
- },
- },
- },
- {
- name: "unsuspending a suspended aim account",
- requestScreenName: state.NewIdentScreenName("userA"),
- statusCode: http.StatusNoContent,
- body: `{"suspended_status":""}`,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: &state.User{
- DisplayScreenName: "userA",
- IdentScreenName: state.NewIdentScreenName("userA"),
- SuspendedStatus: wire.LoginErrSuspendedAccount,
- },
- },
- },
- },
- accountManagerParams: accountManagerParams{
- updateSuspendedStatusParams: updateSuspendedStatusParams{
- {
- suspendedStatus: 0x0,
- screenName: state.NewIdentScreenName("userA"),
- err: nil,
- },
- },
- },
- },
- },
- {
- name: "suspending an already suspended aim account",
- requestScreenName: state.NewIdentScreenName("userA"),
- statusCode: http.StatusNotModified,
- body: `{"suspended_status":"suspended"}`,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: &state.User{
- DisplayScreenName: "userA",
- IdentScreenName: state.NewIdentScreenName("userA"),
- SuspendedStatus: wire.LoginErrSuspendedAccount,
- },
- },
- },
- },
- },
- },
- {
- name: "setting bot flag (before: false, after: true)",
- requestScreenName: state.NewIdentScreenName("userA"),
- statusCode: http.StatusNoContent,
- body: `{"is_bot":true}`,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: &state.User{
- DisplayScreenName: "userA",
- IdentScreenName: state.NewIdentScreenName("userA"),
- SuspendedStatus: 0x0,
- IsBot: false,
- },
- },
- },
- },
- accountManagerParams: accountManagerParams{
- setBotStatusParams: setBotStatusParams{
- {
- isBot: true,
- screenName: state.NewIdentScreenName("userA"),
- err: nil,
- },
- },
- },
- },
- },
- {
- name: "setting bot flag (before: true, after: false)",
- requestScreenName: state.NewIdentScreenName("userA"),
- statusCode: http.StatusNoContent,
- body: `{"is_bot":false}`,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: &state.User{
- DisplayScreenName: "userA",
- IdentScreenName: state.NewIdentScreenName("userA"),
- SuspendedStatus: 0x0,
- IsBot: true,
- },
- },
- },
- },
- accountManagerParams: accountManagerParams{
- setBotStatusParams: setBotStatusParams{
- {
- isBot: false,
- screenName: state.NewIdentScreenName("userA"),
- err: nil,
- },
- },
- },
- },
- },
- {
- name: "setting bot flag (before: true, after: true)",
- requestScreenName: state.NewIdentScreenName("userA"),
- statusCode: http.StatusNotModified,
- body: `{"is_bot":true}`,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: &state.User{
- DisplayScreenName: "userA",
- IdentScreenName: state.NewIdentScreenName("userA"),
- SuspendedStatus: 0x0,
- IsBot: true,
- },
- },
- },
- },
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- request := httptest.NewRequest(http.MethodPatch, "/user/"+tc.requestScreenName.String()+"/account", strings.NewReader(tc.body))
- request.SetPathValue("screenname", tc.requestScreenName.String())
- responseRecorder := httptest.NewRecorder()
- userManager := newMockUserManager(t)
- for _, params := range tc.mockParams.getUserParams {
- userManager.EXPECT().
- User(matchContext(), params.screenName).
- Return(params.result, params.err)
- }
- accountManager := newMockAccountManager(t)
- for _, params := range tc.mockParams.updateSuspendedStatusParams {
- accountManager.EXPECT().
- UpdateSuspendedStatus(matchContext(), params.suspendedStatus, params.screenName).
- Return(params.err)
- }
- for _, params := range tc.mockParams.setBotStatusParams {
- accountManager.EXPECT().
- SetBotStatus(matchContext(), params.isBot, params.screenName).
- Return(params.err)
- }
- patchUserAccountHandler(responseRecorder, request, userManager, accountManager, slog.Default())
- if responseRecorder.Code != tc.statusCode {
- t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
- }
- if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
- t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
- }
- })
- }
- }
- func TestUserBuddyIconHandler_GET(t *testing.T) {
- sampleGIF := []byte{
- 0x47, 0x49, 0x46, 0x38, 0x39, 0x61, 0x32, 0x00, 0x32, 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
- 0x00, 0x00, 0x00, 0x21, 0xf9, 0x04, 0x01, 0x00, 0x00, 0x00, 0x00, 0x2c, 0x00, 0x00, 0x00, 0x00,
- 0x32, 0x00, 0x32, 0x00, 0x00, 0x02, 0x02, 0x44, 0x01, 0x00, 0x3b}
- sampleJPG := []byte{0xFF, 0xD8, 0xFF, 0x43, 0x13, 0x37}
- tt := []struct {
- name string
- requestScreenName state.IdentScreenName
- want string
- statusCode int
- contentType string
- mockParams mockParams
- }{
- {
- name: "invalid account",
- requestScreenName: state.NewIdentScreenName("userA"),
- want: `user not found`,
- statusCode: http.StatusNotFound,
- contentType: "text/plain; charset=utf-8",
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: nil,
- },
- },
- },
- },
- },
- {
- name: "account with gif buddy icon",
- requestScreenName: state.NewIdentScreenName("userA"),
- want: string(sampleGIF),
- statusCode: http.StatusOK,
- contentType: "image/gif",
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: &state.User{
- DisplayScreenName: "userA",
- IdentScreenName: state.NewIdentScreenName("userA"),
- },
- },
- },
- },
- feedBagRetrieverParams: feedBagRetrieverParams{
- buddyIconMetadataParams: buddyIconMetadataParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: &wire.BARTID{
- Type: wire.BARTTypesBuddyIcon,
- BARTInfo: wire.BARTInfo{
- Flags: 0x00,
- Hash: []byte{'t', 'h', 'e', 'h', 'a', 's', 'h'},
- },
- },
- },
- },
- },
- bartAssetManagerParams: bartAssetManagerParams{
- bartItemParams: bartItemParams{
- {
- hash: []byte{'t', 'h', 'e', 'h', 'a', 's', 'h'},
- result: sampleGIF,
- },
- },
- },
- },
- },
- {
- name: "account with jpg buddy icon",
- requestScreenName: state.NewIdentScreenName("userA"),
- want: string(sampleJPG),
- statusCode: http.StatusOK,
- contentType: "image/jpeg",
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: &state.User{
- DisplayScreenName: "userA",
- IdentScreenName: state.NewIdentScreenName("userA"),
- },
- },
- },
- },
- feedBagRetrieverParams: feedBagRetrieverParams{
- buddyIconMetadataParams: buddyIconMetadataParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: &wire.BARTID{
- Type: wire.BARTTypesBuddyIcon,
- BARTInfo: wire.BARTInfo{
- Flags: 0x00,
- Hash: []byte{'t', 'h', 'e', 'h', 'a', 's', 'h'},
- },
- },
- },
- },
- },
- bartAssetManagerParams: bartAssetManagerParams{
- bartItemParams: bartItemParams{
- {
- hash: []byte{'t', 'h', 'e', 'h', 'a', 's', 'h'},
- result: sampleJPG,
- },
- },
- },
- },
- },
- {
- name: "account with unknown format buddy icon",
- requestScreenName: state.NewIdentScreenName("userA"),
- want: string([]byte{0x13, 0x37, 0x13, 0x37, 0x13, 0x37}),
- statusCode: http.StatusOK,
- contentType: "application/octet-stream",
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: &state.User{
- DisplayScreenName: "userA",
- IdentScreenName: state.NewIdentScreenName("userA"),
- },
- },
- },
- },
- feedBagRetrieverParams: feedBagRetrieverParams{
- buddyIconMetadataParams: buddyIconMetadataParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: &wire.BARTID{
- Type: wire.BARTTypesBuddyIcon,
- BARTInfo: wire.BARTInfo{
- Flags: 0x00,
- Hash: []byte{'t', 'h', 'e', 'h', 'a', 's', 'h'},
- },
- },
- },
- },
- },
- bartAssetManagerParams: bartAssetManagerParams{
- bartItemParams: bartItemParams{
- {
- hash: []byte{'t', 'h', 'e', 'h', 'a', 's', 'h'},
- result: []byte{0x13, 0x37, 0x13, 0x37, 0x13, 0x37},
- },
- },
- },
- },
- },
- {
- name: "account with cleared buddy icon",
- requestScreenName: state.NewIdentScreenName("userA"),
- want: "icon not found",
- statusCode: http.StatusNotFound,
- contentType: "text/plain; charset=utf-8",
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: &state.User{
- DisplayScreenName: "userA",
- IdentScreenName: state.NewIdentScreenName("userA"),
- },
- },
- },
- },
- feedBagRetrieverParams: feedBagRetrieverParams{
- buddyIconMetadataParams: buddyIconMetadataParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: &wire.BARTID{
- Type: wire.BARTTypesBuddyIcon,
- BARTInfo: wire.BARTInfo{
- Flags: 0x00,
- Hash: wire.GetClearIconHash(),
- },
- },
- },
- },
- },
- },
- },
- {
- name: "account with no buddy icon",
- requestScreenName: state.NewIdentScreenName("userA"),
- want: "icon not found",
- statusCode: http.StatusNotFound,
- contentType: "text/plain; charset=utf-8",
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: &state.User{
- DisplayScreenName: "userA",
- IdentScreenName: state.NewIdentScreenName("userA"),
- },
- },
- },
- },
- feedBagRetrieverParams: feedBagRetrieverParams{
- buddyIconMetadataParams: buddyIconMetadataParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: nil,
- },
- },
- },
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- request := httptest.NewRequest(http.MethodGet, "/user/"+tc.requestScreenName.String()+"/icon", nil)
- request.SetPathValue("screenname", tc.requestScreenName.String())
- responseRecorder := httptest.NewRecorder()
- userManager := newMockUserManager(t)
- for _, params := range tc.mockParams.getUserParams {
- userManager.EXPECT().
- User(matchContext(), params.screenName).
- Return(params.result, params.err)
- }
- feedbagRetriever := newMockFeedBagRetriever(t)
- for _, params := range tc.mockParams.buddyIconMetadataParams {
- feedbagRetriever.EXPECT().
- BuddyIconMetadata(matchContext(), params.screenName).
- Return(params.result, params.err)
- }
- bartRetriever := newMockBARTAssetManager(t)
- for _, params := range tc.mockParams.bartItemParams {
- bartRetriever.EXPECT().
- BARTItem(matchContext(), params.hash).
- Return(params.result, params.err)
- }
- getUserBuddyIconHandler(responseRecorder, request, userManager, feedbagRetriever, bartRetriever, slog.Default())
- if responseRecorder.Code != tc.statusCode {
- t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
- }
- contentType := responseRecorder.Header().Get("Content-Type")
- if contentType != tc.contentType {
- t.Errorf("Want content type '%s', got '%s'", tc.contentType, contentType)
- }
- if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
- t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
- }
- })
- }
- }
- func TestUserHandler_GET(t *testing.T) {
- tt := []struct {
- name string
- want string
- statusCode int
- mockParams mockParams
- }{
- {
- name: "empty user store",
- want: `[]`,
- statusCode: http.StatusOK,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- allUsersParams: allUsersParams{
- {
- result: []state.User{},
- },
- },
- },
- },
- },
- {
- name: "user store containing 3 users",
- want: `[{"id":"usera","screen_name":"userA","is_icq":false,"suspended_status":"","is_bot":false},{"id":"userb","screen_name":"userB","is_icq":false,"suspended_status":"","is_bot":true},{"id":"100003","screen_name":"100003","is_icq":true,"suspended_status":"","is_bot":false}]`,
- statusCode: http.StatusOK,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- allUsersParams: allUsersParams{
- {
- result: []state.User{
- {
- DisplayScreenName: "userA",
- IdentScreenName: state.NewIdentScreenName("userA"),
- },
- {
- DisplayScreenName: "userB",
- IdentScreenName: state.NewIdentScreenName("userB"),
- IsBot: true,
- },
- {
- DisplayScreenName: "100003",
- IdentScreenName: state.NewIdentScreenName("100003"),
- IsICQ: true,
- },
- },
- },
- },
- },
- },
- },
- {
- name: "user handler error",
- want: `internal server error`,
- statusCode: http.StatusInternalServerError,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- allUsersParams: allUsersParams{
- {
- result: []state.User{},
- err: io.EOF,
- },
- },
- },
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- request := httptest.NewRequest(http.MethodGet, "/user", nil)
- responseRecorder := httptest.NewRecorder()
- userManager := newMockUserManager(t)
- for _, params := range tc.mockParams.allUsersParams {
- userManager.EXPECT().
- AllUsers(matchContext()).
- Return(params.result, params.err)
- }
- getUserHandler(responseRecorder, request, userManager, slog.Default())
- if responseRecorder.Code != tc.statusCode {
- t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
- }
- if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
- t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
- }
- })
- }
- }
- func TestUserHandler_POST(t *testing.T) {
- tt := []struct {
- name string
- body string
- want string
- statusCode int
- createAccount state.CreateAccountFunc
- }{
- {
- name: "with valid AIM user",
- body: `{"screen_name":"userA", "password":"thepassword"}`,
- want: `User account created successfully.`,
- statusCode: http.StatusCreated,
- createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
- assert.Equal(t, state.DisplayScreenName("userA"), screenName)
- assert.Equal(t, "thepassword", password)
- return nil
- },
- },
- {
- name: "with valid ICQ user",
- body: `{"screen_name":"100003", "password":"thepass"}`,
- want: `User account created successfully.`,
- statusCode: http.StatusCreated,
- createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
- assert.Equal(t, state.DisplayScreenName("100003"), screenName)
- assert.Equal(t, "thepass", password)
- return nil
- },
- },
- {
- name: "with malformed body",
- body: `{"screen_name":"userA", "password":"thepassword"`, // missing closing }
- want: `malformed input`,
- statusCode: http.StatusBadRequest,
- },
- {
- name: "user handler error",
- body: `{"screen_name":"userA", "password":"thepassword"}`,
- want: `internal server error`,
- statusCode: http.StatusInternalServerError,
- createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
- assert.Equal(t, state.DisplayScreenName("userA"), screenName)
- assert.Equal(t, "thepassword", password)
- return io.EOF
- },
- },
- {
- name: "duplicate user",
- body: `{"screen_name":"userA", "password":"thepassword"}`,
- want: `user already exists`,
- statusCode: http.StatusConflict,
- createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
- assert.Equal(t, state.DisplayScreenName("userA"), screenName)
- assert.Equal(t, "thepassword", password)
- return state.ErrDupUser
- },
- },
- {
- name: "invalid AIM screen name",
- body: `{"screen_name":"a", "password":"thepassword"}`,
- want: `invalid screen name: screen name must be between 3 and 16 characters`,
- statusCode: http.StatusBadRequest,
- createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
- assert.Equal(t, state.DisplayScreenName("a"), screenName)
- assert.Equal(t, "thepassword", password)
- return state.ErrAIMHandleLength
- },
- },
- {
- name: "invalid AIM password",
- body: `{"screen_name":"userA", "password":"1"}`,
- want: `invalid password: invalid password length: password length must be between 4-16 characters`,
- statusCode: http.StatusBadRequest,
- createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
- assert.Equal(t, state.DisplayScreenName("userA"), screenName)
- assert.Equal(t, "1", password)
- return fmt.Errorf("%w: password length must be between 4-16 characters", state.ErrPasswordInvalid)
- },
- },
- {
- name: "invalid ICQ UIN",
- body: `{"screen_name":"1000", "password":"thepass"}`,
- want: `invalid uin: uin must be a number in the range 10000-2147483646`,
- statusCode: http.StatusBadRequest,
- createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
- assert.Equal(t, state.DisplayScreenName("1000"), screenName)
- assert.Equal(t, "thepass", password)
- return state.ErrICQUINInvalidFormat
- },
- },
- {
- name: "invalid ICQ password",
- body: `{"screen_name":"100003", "password":"thelongpassword"}`,
- want: `invalid password: invalid password length: password must be between 6-8 characters`,
- statusCode: http.StatusBadRequest,
- createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
- assert.Equal(t, state.DisplayScreenName("100003"), screenName)
- assert.Equal(t, "thelongpassword", password)
- return fmt.Errorf("%w: password must be between 6-8 characters", state.ErrPasswordInvalid)
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- request := httptest.NewRequest(http.MethodPost, "/user", strings.NewReader(tc.body))
- responseRecorder := httptest.NewRecorder()
- postUserHandler(responseRecorder, request, tc.createAccount, slog.Default())
- if responseRecorder.Code != tc.statusCode {
- t.Errorf("want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
- }
- if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
- t.Errorf("want '%s', got '%s'", tc.want, responseRecorder.Body)
- }
- })
- }
- }
- func TestUserHandler_DELETE(t *testing.T) {
- tt := []struct {
- name string
- body string
- want string
- statusCode int
- mockParams mockParams
- }{
- {
- name: "with valid user",
- body: `{"screen_name":"userA"}`,
- want: `User account successfully deleted.`,
- statusCode: http.StatusNoContent,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- deleteUserParams: deleteUserParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- },
- },
- },
- },
- },
- {
- name: "with non-existent user",
- body: `{"screen_name":"userA"}`,
- want: `user does not exist`,
- statusCode: http.StatusNotFound,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- deleteUserParams: deleteUserParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- err: state.ErrNoUser,
- },
- },
- },
- },
- },
- {
- name: "with malformed body",
- body: `{"screen_name":"userA"`, // missing closing }
- want: `malformed input`,
- statusCode: http.StatusBadRequest,
- },
- {
- name: "user handler error",
- body: `{"screen_name":"userA"}`,
- want: `internal server error`,
- statusCode: http.StatusInternalServerError,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- deleteUserParams: deleteUserParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- err: io.EOF,
- },
- },
- },
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- request := httptest.NewRequest(http.MethodDelete, "/user", strings.NewReader(tc.body))
- responseRecorder := httptest.NewRecorder()
- userManager := newMockUserManager(t)
- for _, params := range tc.mockParams.deleteUserParams {
- userManager.EXPECT().
- DeleteUser(matchContext(), params.screenName).
- Return(params.err)
- }
- deleteUserHandler(responseRecorder, request, userManager, slog.Default())
- if responseRecorder.Code != tc.statusCode {
- t.Errorf("want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
- }
- if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
- t.Errorf("want '%s', got '%s'", tc.want, responseRecorder.Body)
- }
- })
- }
- }
- func TestUserPasswordHandler_PUT(t *testing.T) {
- tt := []struct {
- name string
- body string
- want string
- statusCode int
- mockParams mockParams
- }{
- {
- name: "user with valid password",
- body: `{"screen_name":"userA", "password":"thenewpassword"}`,
- want: `Password successfully reset.`,
- statusCode: http.StatusNoContent,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- setUserPasswordParams: setUserPasswordParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- newPassword: "thenewpassword",
- },
- },
- },
- },
- },
- {
- name: "user with invalid password",
- body: `{"screen_name":"userA", "password":"a"}`,
- want: `invalid password length`,
- statusCode: http.StatusBadRequest,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- setUserPasswordParams: setUserPasswordParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- newPassword: "a",
- err: state.ErrPasswordInvalid,
- },
- },
- },
- },
- },
- {
- name: "with malformed body",
- body: `{"screen_name":"userA", "password":"thepassword"`, // missing closing }
- want: `malformed input`,
- statusCode: http.StatusBadRequest,
- },
- {
- name: "password updater returns runtime error",
- body: `{"screen_name":"userA", "password":"thepassword"}`,
- want: `internal server error`,
- statusCode: http.StatusInternalServerError,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- setUserPasswordParams: setUserPasswordParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- newPassword: "thepassword",
- err: io.EOF,
- },
- },
- },
- },
- },
- {
- name: "user doesn't exist",
- body: `{"screen_name":"userA", "password":"thepassword"}`,
- want: `user does not exist`,
- statusCode: http.StatusNotFound,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- setUserPasswordParams: setUserPasswordParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- newPassword: "thepassword",
- err: state.ErrNoUser,
- },
- },
- },
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- request := httptest.NewRequest(http.MethodPut, "/user", strings.NewReader(tc.body))
- responseRecorder := httptest.NewRecorder()
- userManager := newMockUserManager(t)
- for _, params := range tc.mockParams.setUserPasswordParams {
- userManager.EXPECT().
- SetUserPassword(matchContext(), params.screenName, params.newPassword).
- Return(params.err)
- }
- putUserPasswordHandler(responseRecorder, request, userManager, slog.Default())
- if responseRecorder.Code != tc.statusCode {
- t.Errorf("want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
- }
- if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
- t.Errorf("want '%s', got '%s'", tc.want, responseRecorder.Body)
- }
- })
- }
- }
- func TestPublicChatHandler_GET(t *testing.T) {
- fnNewSess := func(screenName string) *state.Session {
- sess := state.NewSession()
- sess.SetIdentScreenName(state.NewIdentScreenName(screenName))
- sess.SetDisplayScreenName(state.DisplayScreenName(screenName))
- instance := sess.AddInstance()
- instance.SetSignonComplete()
- return sess
- }
- chatRoom1 := state.NewChatRoom("chat-room-1-name", state.NewIdentScreenName("chat-room-1-creator"), state.PublicExchange)
- chatRoom2 := state.NewChatRoom("chat-room-2-name", state.NewIdentScreenName("chat-room-1-creator"), state.PublicExchange)
- tt := []struct {
- name string
- want string
- statusCode int
- mockParams mockParams
- }{
- {
- name: "multiple chat rooms with participants",
- want: `[{"name":"chat-room-1-name","create_time":"0001-01-01T00:00:00Z","url":"aim:gochat?roomname=chat-room-1-name&exchange=5","participants":[{"id":"usera","screen_name":"userA"},{"id":"userb","screen_name":"userB"}]},{"name":"chat-room-2-name","create_time":"0001-01-01T00:00:00Z","url":"aim:gochat?roomname=chat-room-2-name&exchange=5","participants":[{"id":"userc","screen_name":"userC"},{"id":"userd","screen_name":"userD"}]}]`,
- statusCode: http.StatusOK,
- mockParams: mockParams{
- chatRoomRetrieverParams: chatRoomRetrieverParams{
- allChatRoomsParams: allChatRoomsParams{
- {
- exchange: state.PublicExchange,
- result: []state.ChatRoom{
- chatRoom1,
- chatRoom2,
- },
- },
- },
- },
- chatSessionRetrieverParams: chatSessionRetrieverParams{
- chatSessionRetrieverAllSessionsParams: chatSessionRetrieverAllSessionsParams{
- {
- cookie: chatRoom1.Cookie(),
- result: []*state.Session{
- fnNewSess("userA"),
- fnNewSess("userB"),
- },
- },
- {
- cookie: chatRoom2.Cookie(),
- result: []*state.Session{
- fnNewSess("userC"),
- fnNewSess("userD"),
- },
- },
- },
- },
- },
- },
- {
- name: "chat room without participants",
- want: `[{"name":"chat-room-1-name","create_time":"0001-01-01T00:00:00Z","url":"aim:gochat?roomname=chat-room-1-name&exchange=5","participants":[]}]`,
- statusCode: http.StatusOK,
- mockParams: mockParams{
- chatRoomRetrieverParams: chatRoomRetrieverParams{
- allChatRoomsParams: allChatRoomsParams{
- {
- exchange: state.PublicExchange,
- result: []state.ChatRoom{
- chatRoom1,
- },
- },
- },
- },
- chatSessionRetrieverParams: chatSessionRetrieverParams{
- chatSessionRetrieverAllSessionsParams: chatSessionRetrieverAllSessionsParams{
- {
- cookie: chatRoom1.Cookie(),
- result: []*state.Session{},
- },
- },
- },
- },
- },
- {
- name: "no chat rooms",
- want: `[]`,
- statusCode: http.StatusOK,
- mockParams: mockParams{
- chatRoomRetrieverParams: chatRoomRetrieverParams{
- allChatRoomsParams: allChatRoomsParams{
- {
- exchange: state.PublicExchange,
- result: []state.ChatRoom{},
- },
- },
- },
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- request := httptest.NewRequest(http.MethodGet, "/chat/room/public", nil)
- responseRecorder := httptest.NewRecorder()
- chatRoomRetriever := newMockChatRoomRetriever(t)
- for _, params := range tc.mockParams.allChatRoomsParams {
- chatRoomRetriever.EXPECT().
- AllChatRooms(matchContext(), params.exchange).
- Return(params.result, params.err)
- }
- chatSessionRetriever := newMockChatSessionRetriever(t)
- for _, params := range tc.mockParams.chatSessionRetrieverAllSessionsParams {
- chatSessionRetriever.EXPECT().
- AllSessions(params.cookie).
- Return(params.result)
- }
- getPublicChatHandler(responseRecorder, request, chatRoomRetriever, chatSessionRetriever, slog.Default())
- if responseRecorder.Code != tc.statusCode {
- t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
- }
- if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
- t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
- }
- })
- }
- }
- func TestDeletePublicChatHandler(t *testing.T) {
- tt := []struct {
- name string
- body string
- want string
- statusCode int
- mockParams mockParams
- }{
- {
- name: "successful deletion of single chat room",
- body: `{"names":["TestRoom"]}`,
- want: `Chat rooms deleted successfully.`,
- statusCode: http.StatusNoContent,
- mockParams: mockParams{
- chatRoomDeleterParams: chatRoomDeleterParams{
- deleteChatRoomsParams: deleteChatRoomsParams{
- {
- exchange: state.PublicExchange,
- names: []string{"TestRoom"},
- },
- },
- },
- },
- },
- {
- name: "successful deletion of multiple chat rooms",
- body: `{"names":["Room1", "Room2", "Room3"]}`,
- want: `Chat rooms deleted successfully.`,
- statusCode: http.StatusNoContent,
- mockParams: mockParams{
- chatRoomDeleterParams: chatRoomDeleterParams{
- deleteChatRoomsParams: deleteChatRoomsParams{
- {
- exchange: state.PublicExchange,
- names: []string{"Room1", "Room2", "Room3"},
- },
- },
- },
- },
- },
- {
- name: "empty names array",
- body: `{"names":[]}`,
- want: `no chat room names provided`,
- statusCode: http.StatusBadRequest,
- },
- {
- name: "malformed JSON",
- body: `{"names":["Room1"`, // missing closing brackets
- want: `malformed input`,
- statusCode: http.StatusBadRequest,
- },
- {
- name: "deletion error",
- body: `{"names":["TestRoom"]}`,
- want: `internal server error`,
- statusCode: http.StatusInternalServerError,
- mockParams: mockParams{
- chatRoomDeleterParams: chatRoomDeleterParams{
- deleteChatRoomsParams: deleteChatRoomsParams{
- {
- exchange: state.PublicExchange,
- names: []string{"TestRoom"},
- err: errors.New("database error"),
- },
- },
- },
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- request := httptest.NewRequest(http.MethodDelete, "/chat/room/public", strings.NewReader(tc.body))
- responseRecorder := httptest.NewRecorder()
- chatRoomDeleter := newMockChatRoomDeleter(t)
- for _, params := range tc.mockParams.deleteChatRoomsParams {
- chatRoomDeleter.EXPECT().
- DeleteChatRooms(matchContext(), params.exchange, params.names).
- Return(params.err)
- }
- deletePublicChatHandler(responseRecorder, request, chatRoomDeleter, slog.Default())
- if responseRecorder.Code != tc.statusCode {
- t.Errorf("want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
- }
- if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
- t.Errorf("want '%s', got '%s'", tc.want, responseRecorder.Body)
- }
- })
- }
- }
- func TestPrivateChatHandler_GET(t *testing.T) {
- fnNewSess := func(screenName string) *state.Session {
- sess := state.NewSession()
- sess.SetIdentScreenName(state.NewIdentScreenName(screenName))
- sess.SetDisplayScreenName(state.DisplayScreenName(screenName))
- instance := sess.AddInstance()
- instance.SetSignonComplete()
- return sess
- }
- chatRoom1 := state.NewChatRoom("chat-room-1-name", state.NewIdentScreenName("chat-room-1-creator"), state.PrivateExchange)
- chatRoom2 := state.NewChatRoom("chat-room-2-name", state.NewIdentScreenName("chat-room-2-creator"), state.PrivateExchange)
- tt := []struct {
- name string
- want string
- statusCode int
- mockParams mockParams
- }{
- {
- name: "multiple chat rooms with participants",
- want: `[{"name":"chat-room-1-name","create_time":"0001-01-01T00:00:00Z","creator_id":"chat-room-1-creator","url":"aim:gochat?roomname=chat-room-1-name&exchange=4","participants":[{"id":"usera","screen_name":"userA"},{"id":"userb","screen_name":"userB"}]},{"name":"chat-room-2-name","create_time":"0001-01-01T00:00:00Z","creator_id":"chat-room-2-creator","url":"aim:gochat?roomname=chat-room-2-name&exchange=4","participants":[{"id":"userc","screen_name":"userC"},{"id":"userd","screen_name":"userD"}]}]`,
- statusCode: http.StatusOK,
- mockParams: mockParams{
- chatRoomRetrieverParams: chatRoomRetrieverParams{
- allChatRoomsParams: allChatRoomsParams{
- {
- exchange: state.PrivateExchange,
- result: []state.ChatRoom{
- chatRoom1,
- chatRoom2,
- },
- },
- },
- },
- chatSessionRetrieverParams: chatSessionRetrieverParams{
- chatSessionRetrieverAllSessionsParams: chatSessionRetrieverAllSessionsParams{
- {
- cookie: chatRoom1.Cookie(),
- result: []*state.Session{
- fnNewSess("userA"),
- fnNewSess("userB"),
- },
- },
- {
- cookie: chatRoom2.Cookie(),
- result: []*state.Session{
- fnNewSess("userC"),
- fnNewSess("userD"),
- },
- },
- },
- },
- },
- },
- {
- name: "chat room without participants",
- want: `[{"name":"chat-room-1-name","create_time":"0001-01-01T00:00:00Z","creator_id":"chat-room-1-creator","url":"aim:gochat?roomname=chat-room-1-name&exchange=4","participants":[]}]`,
- statusCode: http.StatusOK,
- mockParams: mockParams{
- chatRoomRetrieverParams: chatRoomRetrieverParams{
- allChatRoomsParams: allChatRoomsParams{
- {
- exchange: state.PrivateExchange,
- result: []state.ChatRoom{
- chatRoom1,
- },
- },
- },
- },
- chatSessionRetrieverParams: chatSessionRetrieverParams{
- chatSessionRetrieverAllSessionsParams: chatSessionRetrieverAllSessionsParams{
- {
- cookie: chatRoom1.Cookie(),
- result: []*state.Session{},
- },
- },
- },
- },
- },
- {
- name: "no chat rooms",
- want: `[]`,
- statusCode: http.StatusOK,
- mockParams: mockParams{
- chatRoomRetrieverParams: chatRoomRetrieverParams{
- allChatRoomsParams: allChatRoomsParams{
- {
- exchange: state.PrivateExchange,
- result: []state.ChatRoom{},
- },
- },
- },
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- request := httptest.NewRequest(http.MethodGet, "/chat/room/private", nil)
- responseRecorder := httptest.NewRecorder()
- chatRoomRetriever := newMockChatRoomRetriever(t)
- for _, params := range tc.mockParams.allChatRoomsParams {
- chatRoomRetriever.EXPECT().
- AllChatRooms(matchContext(), params.exchange).
- Return(params.result, params.err)
- }
- chatSessionRetriever := newMockChatSessionRetriever(t)
- for _, params := range tc.mockParams.chatSessionRetrieverAllSessionsParams {
- chatSessionRetriever.EXPECT().
- AllSessions(params.cookie).
- Return(params.result)
- }
- getPrivateChatHandler(responseRecorder, request, chatRoomRetriever, chatSessionRetriever, slog.Default())
- if responseRecorder.Code != tc.statusCode {
- t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
- }
- if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
- t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
- }
- })
- }
- }
- func TestInstantMessageHandler_POST(t *testing.T) {
- type relayToScreenNameInputs struct {
- sender state.IdentScreenName
- recipient state.IdentScreenName
- msg string
- }
- tt := []struct {
- name string
- relayToScreenNameInputs []relayToScreenNameInputs
- body string
- want string
- statusCode int
- }{
- {
- name: "send an instant message",
- relayToScreenNameInputs: []relayToScreenNameInputs{
- {
- sender: state.NewIdentScreenName("sender_sn"),
- recipient: state.NewIdentScreenName("recip_sn"),
- msg: "hello world!",
- },
- },
- body: `{"from":"sender_sn","to":"recip_sn","text":"hello world!"}`,
- want: `Message sent successfully.`,
- statusCode: http.StatusOK,
- },
- {
- name: "with malformed body",
- body: `{"screen_name":"userA", "password":"thepassword"`,
- want: `malformed input`,
- statusCode: http.StatusBadRequest,
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- request := httptest.NewRequest(http.MethodPost, "/user", strings.NewReader(tc.body))
- responseRecorder := httptest.NewRecorder()
- messageRelayer := newMockMessageRelayer(t)
- for _, params := range tc.relayToScreenNameInputs {
- validateSNAC := func(msg wire.SNACMessage) bool {
- body := msg.Body.(wire.SNAC_0x04_0x07_ICBMChannelMsgToClient)
- assert.Equal(t, params.sender.String(), body.ScreenName)
- b, ok := body.Bytes(wire.ICBMTLVAOLIMData)
- assert.True(t, ok)
- txt, err := wire.UnmarshalICBMMessageText(b)
- assert.NoError(t, err)
- assert.Equal(t, params.msg, txt)
- return true
- }
- messageRelayer.EXPECT().
- RelayToScreenName(mock.Anything, params.recipient, mock.MatchedBy(validateSNAC))
- }
- postInstantMessageHandler(responseRecorder, request, messageRelayer, slog.Default())
- if responseRecorder.Code != tc.statusCode {
- t.Errorf("want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
- }
- if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
- t.Errorf("want '%s', got '%s'", tc.want, responseRecorder.Body)
- }
- })
- }
- }
- func TestVersionHandler_GET(t *testing.T) {
- tt := []struct {
- name string
- want string
- statusCode int
- buildInfo config.Build
- }{
- {
- name: "get ras version",
- want: `{"version":"13.3.7","commit":"asdfASDF12345678","date":"2024-03-01"}`,
- statusCode: http.StatusOK,
- buildInfo: config.Build{
- Version: "13.3.7",
- Commit: "asdfASDF12345678",
- Date: "2024-03-01",
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- responseRecorder := httptest.NewRecorder()
- getVersionHandler(responseRecorder, tc.buildInfo)
- if responseRecorder.Code != tc.statusCode {
- t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
- }
- if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
- t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
- }
- })
- }
- }
- func TestDirectoryCategoryHandler_GET(t *testing.T) {
- tt := []struct {
- name string
- want string
- statusCode int
- mockParams mockParams
- }{
- {
- name: "no categories",
- want: `[]`,
- statusCode: http.StatusOK,
- mockParams: mockParams{
- directoryManagerParams: directoryManagerParams{
- categoriesParams: categoriesParams{
- {
- result: nil,
- },
- },
- },
- },
- },
- {
- name: "error fetching categories",
- want: `{"message":"internal server error"}`,
- statusCode: http.StatusInternalServerError,
- mockParams: mockParams{
- directoryManagerParams: directoryManagerParams{
- categoriesParams: categoriesParams{
- {
- result: nil,
- err: errors.New("error fetching categories"),
- },
- },
- },
- },
- },
- {
- name: "fetch some categories",
- want: `[{"id":1,"name":"category-1"},{"id":2,"name":"category-2"}]`,
- statusCode: http.StatusOK,
- mockParams: mockParams{
- directoryManagerParams: directoryManagerParams{
- categoriesParams: categoriesParams{
- {
- result: []state.Category{
- {
- ID: 1,
- Name: "category-1",
- },
- {
- ID: 2,
- Name: "category-2",
- },
- },
- },
- },
- },
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- responseRecorder := httptest.NewRecorder()
- request := httptest.NewRequest(http.MethodGet, "/directory/category", nil)
- directoryManager := newMockDirectoryManager(t)
- for _, params := range tc.mockParams.categoriesParams {
- directoryManager.EXPECT().
- Categories(matchContext()).
- Return(params.result, params.err)
- }
- getDirectoryCategoryHandler(responseRecorder, request, directoryManager, slog.Default())
- if responseRecorder.Code != tc.statusCode {
- t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
- }
- if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
- t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
- }
- })
- }
- }
- func TestDirectoryCategoryKeywordHandler_GET(t *testing.T) {
- tt := []struct {
- name string
- categoryID int
- want string
- statusCode int
- mockParams mockParams
- }{
- {
- name: "category not found",
- categoryID: 1,
- want: `{"message":"category not found"}`,
- statusCode: http.StatusNotFound,
- mockParams: mockParams{
- directoryManagerParams: directoryManagerParams{
- keywordsByCategoryParams: keywordsByCategoryParams{
- {
- categoryID: 1,
- result: nil,
- err: state.ErrKeywordCategoryNotFound,
- },
- },
- },
- },
- },
- {
- name: "error fetching keywords by category",
- categoryID: 1,
- want: `{"message":"internal server error"}`,
- statusCode: http.StatusInternalServerError,
- mockParams: mockParams{
- directoryManagerParams: directoryManagerParams{
- keywordsByCategoryParams: keywordsByCategoryParams{
- {
- categoryID: 1,
- result: nil,
- err: errors.New("error fetching keywords by category"),
- },
- },
- },
- },
- },
- {
- name: "invalid category ID",
- categoryID: -1,
- want: `{"message":"invalid category ID"}`,
- statusCode: http.StatusBadRequest,
- mockParams: mockParams{
- directoryManagerParams: directoryManagerParams{
- keywordsByCategoryParams: keywordsByCategoryParams{},
- },
- },
- },
- {
- name: "no keywords",
- categoryID: 1,
- want: `[]`,
- statusCode: http.StatusOK,
- mockParams: mockParams{
- directoryManagerParams: directoryManagerParams{
- keywordsByCategoryParams: keywordsByCategoryParams{
- {
- categoryID: 1,
- result: nil,
- },
- },
- },
- },
- },
- {
- name: "fetch some keywords by category",
- categoryID: 1,
- want: `[{"id":1,"name":"keyword-1"},{"id":2,"name":"keyword-2"}]`,
- statusCode: http.StatusOK,
- mockParams: mockParams{
- directoryManagerParams: directoryManagerParams{
- keywordsByCategoryParams: keywordsByCategoryParams{
- {
- categoryID: 1,
- result: []state.Keyword{
- {
- ID: 1,
- Name: "keyword-1",
- },
- {
- ID: 2,
- Name: "keyword-2",
- },
- },
- },
- },
- },
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- request := httptest.NewRequest(http.MethodGet, fmt.Sprintf("/directory/category/%d/keyword", tc.categoryID), nil)
- request.SetPathValue("id", fmt.Sprintf("%d", tc.categoryID))
- responseRecorder := httptest.NewRecorder()
- directoryManager := newMockDirectoryManager(t)
- for _, params := range tc.mockParams.keywordsByCategoryParams {
- directoryManager.EXPECT().
- KeywordsByCategory(matchContext(), params.categoryID).
- Return(params.result, params.err)
- }
- getDirectoryCategoryKeywordHandler(responseRecorder, request, directoryManager, slog.Default())
- if responseRecorder.Code != tc.statusCode {
- t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
- }
- if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
- t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
- }
- })
- }
- }
- func TestDirectoryCategoryHandler_DELETE(t *testing.T) {
- tt := []struct {
- name string
- categoryID int
- want string
- statusCode int
- mockParams mockParams
- }{
- {
- name: "category not found",
- categoryID: 1,
- want: `{"message":"category not found"}`,
- statusCode: http.StatusNotFound,
- mockParams: mockParams{
- directoryManagerParams: directoryManagerParams{
- deleteCategoryParams: deleteCategoryParams{
- {
- categoryID: 1,
- err: state.ErrKeywordCategoryNotFound,
- },
- },
- },
- },
- },
- {
- name: "keyword in use by user",
- categoryID: 1,
- want: `{"message":"can't delete because category in use by a user"}`,
- statusCode: http.StatusConflict,
- mockParams: mockParams{
- directoryManagerParams: directoryManagerParams{
- deleteCategoryParams: deleteCategoryParams{
- {
- categoryID: 1,
- err: state.ErrKeywordInUse,
- },
- },
- },
- },
- },
- {
- name: "runtime error",
- categoryID: 1,
- want: `{"message":"internal server error"}`,
- statusCode: http.StatusInternalServerError,
- mockParams: mockParams{
- directoryManagerParams: directoryManagerParams{
- deleteCategoryParams: deleteCategoryParams{
- {
- categoryID: 1,
- err: errors.New("error deleting keyword"),
- },
- },
- },
- },
- },
- {
- name: "successful deletion",
- categoryID: 1,
- want: ``,
- statusCode: http.StatusNoContent,
- mockParams: mockParams{
- directoryManagerParams: directoryManagerParams{
- deleteCategoryParams: deleteCategoryParams{
- {
- categoryID: 1,
- },
- },
- },
- },
- },
- {
- name: "invalid category ID",
- categoryID: -1,
- want: `invalid category ID`,
- statusCode: http.StatusBadRequest,
- mockParams: mockParams{
- directoryManagerParams: directoryManagerParams{
- deleteCategoryParams: deleteCategoryParams{},
- },
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- request := httptest.NewRequest(http.MethodDelete, fmt.Sprintf("/directory/category/%d/keyword", tc.categoryID), nil)
- request.SetPathValue("id", fmt.Sprintf("%d", tc.categoryID))
- responseRecorder := httptest.NewRecorder()
- directoryManager := newMockDirectoryManager(t)
- for _, params := range tc.mockParams.deleteCategoryParams {
- directoryManager.EXPECT().
- DeleteCategory(matchContext(), params.categoryID).
- Return(params.err)
- }
- deleteDirectoryCategoryHandler(responseRecorder, request, directoryManager, slog.Default())
- if responseRecorder.Code != tc.statusCode {
- t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
- }
- if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
- t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
- }
- })
- }
- }
- func TestDirectoryCategoryHandler_POST(t *testing.T) {
- tt := []struct {
- name string
- body string
- want string
- statusCode int
- mockParams mockParams
- }{
- {
- name: "category already exists",
- body: `{"name":"the_category"}`,
- want: `{"message":"category already exists"}`,
- statusCode: http.StatusConflict,
- mockParams: mockParams{
- directoryManagerParams: directoryManagerParams{
- createCategoryParams: createCategoryParams{
- {
- name: "the_category",
- err: state.ErrKeywordCategoryExists,
- },
- },
- },
- },
- },
- {
- name: "runtime error",
- body: `{"name":"the_category"}`,
- want: `{"message":"internal server error"}`,
- statusCode: http.StatusInternalServerError,
- mockParams: mockParams{
- directoryManagerParams: directoryManagerParams{
- createCategoryParams: createCategoryParams{
- {
- name: "the_category",
- err: errors.New("error creating category"),
- },
- },
- },
- },
- },
- {
- name: "bad input",
- body: `{"name":"the_category"`,
- want: `{"message":"malformed input"}`,
- statusCode: http.StatusBadRequest,
- mockParams: mockParams{
- directoryManagerParams: directoryManagerParams{
- createCategoryParams: createCategoryParams{},
- },
- },
- },
- {
- name: "successful creation",
- body: `{"name":"the_category"}`,
- want: `{"id":1,"name":"the_category"}`,
- statusCode: http.StatusCreated,
- mockParams: mockParams{
- directoryManagerParams: directoryManagerParams{
- createCategoryParams: createCategoryParams{
- {
- name: "the_category",
- result: state.Category{
- ID: 1,
- Name: "the_category",
- },
- },
- },
- },
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- request := httptest.NewRequest(http.MethodPost, "/directory/category", strings.NewReader(tc.body))
- responseRecorder := httptest.NewRecorder()
- directoryManager := newMockDirectoryManager(t)
- for _, params := range tc.mockParams.createCategoryParams {
- directoryManager.EXPECT().
- CreateCategory(matchContext(), params.name).
- Return(params.result, params.err)
- }
- postDirectoryCategoryHandler(responseRecorder, request, directoryManager, slog.Default())
- if responseRecorder.Code != tc.statusCode {
- t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
- }
- if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
- t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
- }
- })
- }
- }
- func TestDirectoryKeywordHandler_POST(t *testing.T) {
- tt := []struct {
- name string
- body string
- want string
- statusCode int
- mockParams mockParams
- }{
- {
- name: "keyword already exists",
- body: `{"category_id":1,"name":"the_keyword"}`,
- want: `{"message":"keyword already exists"}`,
- statusCode: http.StatusConflict,
- mockParams: mockParams{
- directoryManagerParams: directoryManagerParams{
- createKeywordParams: createKeywordParams{
- {
- name: "the_keyword",
- categoryID: 1,
- err: state.ErrKeywordExists,
- },
- },
- },
- },
- },
- {
- name: "category not found",
- body: `{"category_id":1,"name":"the_keyword"}`,
- want: `{"message":"category not found"}`,
- statusCode: http.StatusNotFound,
- mockParams: mockParams{
- directoryManagerParams: directoryManagerParams{
- createKeywordParams: createKeywordParams{
- {
- name: "the_keyword",
- categoryID: 1,
- err: state.ErrKeywordCategoryNotFound,
- },
- },
- },
- },
- },
- {
- name: "runtime error",
- body: `{"category_id":1,"name":"the_keyword"}`,
- want: `{"message":"internal server error"}`,
- statusCode: http.StatusInternalServerError,
- mockParams: mockParams{
- directoryManagerParams: directoryManagerParams{
- createKeywordParams: createKeywordParams{
- {
- name: "the_keyword",
- categoryID: 1,
- err: errors.New("error creating keyword"),
- },
- },
- },
- },
- },
- {
- name: "bad input",
- body: `{"category_id":1,"name":"the_keyword"`,
- want: `{"message":"malformed input"}`,
- statusCode: http.StatusBadRequest,
- mockParams: mockParams{
- directoryManagerParams: directoryManagerParams{
- createKeywordParams: createKeywordParams{},
- },
- },
- },
- {
- name: "successful creation",
- body: `{"category_id":1,"name":"the_keyword"}`,
- want: `{"id":1,"name":"the_keyword"}`,
- statusCode: http.StatusCreated,
- mockParams: mockParams{
- directoryManagerParams: directoryManagerParams{
- createKeywordParams: createKeywordParams{
- {
- name: "the_keyword",
- categoryID: 1,
- result: state.Keyword{
- ID: 1,
- Name: "the_keyword",
- },
- },
- },
- },
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- request := httptest.NewRequest(http.MethodPost, "/directory/keyword", strings.NewReader(tc.body))
- responseRecorder := httptest.NewRecorder()
- directoryManager := newMockDirectoryManager(t)
- for _, params := range tc.mockParams.createKeywordParams {
- directoryManager.EXPECT().
- CreateKeyword(matchContext(), params.name, params.categoryID).
- Return(params.result, params.err)
- }
- postDirectoryKeywordHandler(responseRecorder, request, directoryManager, slog.Default())
- if responseRecorder.Code != tc.statusCode {
- t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
- }
- if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
- t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
- }
- })
- }
- }
- func TestDirectoryKeywordHandler_DELETE(t *testing.T) {
- tt := []struct {
- name string
- categoryID int
- want string
- statusCode int
- mockParams mockParams
- }{
- {
- name: "keyword not found",
- categoryID: 1,
- want: `{"message":"keyword not found"}`,
- statusCode: http.StatusNotFound,
- mockParams: mockParams{
- directoryManagerParams: directoryManagerParams{
- deleteKeywordParams: deleteKeywordParams{
- {
- id: 1,
- err: state.ErrKeywordNotFound,
- },
- },
- },
- },
- },
- {
- name: "keyword in use by user",
- categoryID: 1,
- want: `{"message":"can't delete because category in use by a user"}`,
- statusCode: http.StatusConflict,
- mockParams: mockParams{
- directoryManagerParams: directoryManagerParams{
- deleteKeywordParams: deleteKeywordParams{
- {
- id: 1,
- err: state.ErrKeywordInUse,
- },
- },
- },
- },
- },
- {
- name: "runtime error",
- categoryID: 1,
- want: `{"message":"internal server error"}`,
- statusCode: http.StatusInternalServerError,
- mockParams: mockParams{
- directoryManagerParams: directoryManagerParams{
- deleteKeywordParams: deleteKeywordParams{
- {
- id: 1,
- err: errors.New("error deleting keyword"),
- },
- },
- },
- },
- },
- {
- name: "successful deletion",
- categoryID: 1,
- want: ``,
- statusCode: http.StatusNoContent,
- mockParams: mockParams{
- directoryManagerParams: directoryManagerParams{
- deleteKeywordParams: deleteKeywordParams{
- {
- id: 1,
- },
- },
- },
- },
- },
- {
- name: "invalid keyword ID",
- categoryID: -1,
- want: `{"message":"invalid keyword ID"}`,
- statusCode: http.StatusBadRequest,
- mockParams: mockParams{
- directoryManagerParams: directoryManagerParams{
- deleteKeywordParams: deleteKeywordParams{},
- },
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- request := httptest.NewRequest(http.MethodDelete, fmt.Sprintf("/directory/keyword/%d", tc.categoryID), nil)
- request.SetPathValue("id", fmt.Sprintf("%d", tc.categoryID))
- responseRecorder := httptest.NewRecorder()
- directoryManager := newMockDirectoryManager(t)
- for _, params := range tc.mockParams.deleteKeywordParams {
- directoryManager.EXPECT().
- DeleteKeyword(matchContext(), params.id).
- Return(params.err)
- }
- deleteDirectoryKeywordHandler(responseRecorder, request, directoryManager, slog.Default())
- if responseRecorder.Code != tc.statusCode {
- t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
- }
- if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
- t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
- }
- })
- }
- }
- func TestBARTByTypeHandler_GET(t *testing.T) {
- tt := []struct {
- name string
- queryParams string
- wantStatusCode int
- wantResponse string
- mockParams mockParams
- }{
- {
- name: "success with items",
- queryParams: "?type=1",
- wantStatusCode: http.StatusOK,
- wantResponse: `[{"hash":"2B000001E4","type":1},{"hash":"2B000001B7","type":1}]`,
- mockParams: mockParams{
- bartAssetManagerParams: bartAssetManagerParams{
- listBARTItemsParams: listBARTItemsParams{
- {
- itemType: 1,
- result: []state.BARTItem{
- {Hash: "2B000001E4", Type: 1},
- {Hash: "2B000001B7", Type: 1},
- },
- err: nil,
- },
- },
- },
- },
- },
- {
- name: "success with empty list",
- queryParams: "?type=2",
- wantStatusCode: http.StatusOK,
- wantResponse: `[]`,
- mockParams: mockParams{
- bartAssetManagerParams: bartAssetManagerParams{
- listBARTItemsParams: listBARTItemsParams{
- {
- itemType: 2,
- result: []state.BARTItem{},
- err: nil,
- },
- },
- },
- },
- },
- {
- name: "missing type parameter",
- queryParams: "",
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"type query parameter is required"}`,
- },
- {
- name: "invalid type parameter",
- queryParams: "?type=invalid",
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"invalid type ID"}`,
- },
- {
- name: "internal server error",
- queryParams: "?type=1",
- wantStatusCode: http.StatusInternalServerError,
- wantResponse: `{"message":"internal server error"}`,
- mockParams: mockParams{
- bartAssetManagerParams: bartAssetManagerParams{
- listBARTItemsParams: listBARTItemsParams{
- {
- itemType: 1,
- result: nil,
- err: errors.New("database error"),
- },
- },
- },
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- request := httptest.NewRequest(http.MethodGet, "/bart"+tc.queryParams, nil)
- responseRecorder := httptest.NewRecorder()
- mockBARTManager := newMockBARTAssetManager(t)
- for _, params := range tc.mockParams.listBARTItemsParams {
- mockBARTManager.EXPECT().
- ListBARTItems(matchContext(), params.itemType).
- Return(params.result, params.err)
- }
- getBARTByTypeHandler(responseRecorder, request, mockBARTManager, slog.Default())
- assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
- assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
- })
- }
- }
- func TestBARTHandler_GET(t *testing.T) {
- tt := []struct {
- name string
- hash string
- wantStatusCode int
- wantResponse string
- wantHeaders map[string]string
- mockParams mockParams
- }{
- {
- name: "success with valid hash",
- hash: "2B000001E4",
- wantStatusCode: http.StatusOK,
- wantResponse: "binary data",
- wantHeaders: map[string]string{"Content-Type": "application/octet-stream"},
- mockParams: mockParams{
- bartAssetManagerParams: bartAssetManagerParams{
- bartItemParams: bartItemParams{
- {
- hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
- result: []byte("binary data"),
- err: nil,
- },
- },
- },
- },
- },
- {
- name: "missing hash parameter",
- hash: "",
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"hash is required"}`,
- },
- {
- name: "invalid hash format",
- hash: "invalid-hex",
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"invalid hash format"}`,
- },
- {
- name: "asset not found",
- hash: "2B000001E4",
- wantStatusCode: http.StatusNotFound,
- wantResponse: `{"message":"BART asset not found"}`,
- mockParams: mockParams{
- bartAssetManagerParams: bartAssetManagerParams{
- bartItemParams: bartItemParams{
- {
- hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
- result: []byte{},
- err: nil,
- },
- },
- },
- },
- },
- {
- name: "internal server error",
- hash: "2B000001E4",
- wantStatusCode: http.StatusInternalServerError,
- wantResponse: `{"message":"internal server error"}`,
- mockParams: mockParams{
- bartAssetManagerParams: bartAssetManagerParams{
- bartItemParams: bartItemParams{
- {
- hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
- result: nil,
- err: errors.New("database error"),
- },
- },
- },
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- request := httptest.NewRequest(http.MethodGet, "/bart/"+tc.hash, nil)
- // Set the path value manually for testing
- if tc.hash != "" {
- request.SetPathValue("hash", tc.hash)
- }
- responseRecorder := httptest.NewRecorder()
- mockBARTManager := newMockBARTAssetManager(t)
- for _, params := range tc.mockParams.bartItemParams {
- mockBARTManager.EXPECT().
- BARTItem(matchContext(), params.hash).
- Return(params.result, params.err)
- }
- getBARTHandler(responseRecorder, request, mockBARTManager, slog.Default())
- assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
- if tc.wantHeaders != nil {
- for key, value := range tc.wantHeaders {
- assert.Equal(t, value, responseRecorder.Header().Get(key))
- }
- }
- if tc.wantStatusCode == http.StatusOK {
- assert.Equal(t, tc.wantResponse, responseRecorder.Body.String())
- } else {
- assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
- }
- })
- }
- }
- func TestBARTHandler_POST(t *testing.T) {
- tt := []struct {
- name string
- hash string
- queryParams string
- requestBody string
- wantStatusCode int
- wantResponse string
- mockParams mockParams
- }{
- {
- name: "success with valid data",
- hash: "2B000001E4",
- queryParams: "?type=1",
- requestBody: "binary data",
- wantStatusCode: http.StatusCreated,
- wantResponse: `{"hash":"2b000001e4","type":1}`,
- mockParams: mockParams{
- bartAssetManagerParams: bartAssetManagerParams{
- insertBARTItemParams: insertBARTItemParams{
- {
- hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
- blob: []byte("binary data"),
- itemType: 1,
- err: nil,
- },
- },
- },
- },
- },
- {
- name: "missing hash parameter",
- hash: "",
- queryParams: "?type=1",
- requestBody: "binary data",
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"hash path parameter is required"}`,
- },
- {
- name: "invalid hash format",
- hash: "invalid-hex",
- queryParams: "?type=1",
- requestBody: "binary data",
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"invalid hash format"}`,
- },
- {
- name: "missing type parameter",
- hash: "2B000001E4",
- queryParams: "",
- requestBody: "binary data",
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"type query parameter is required"}`,
- },
- {
- name: "invalid type parameter",
- hash: "2B000001E4",
- queryParams: "?type=invalid",
- requestBody: "binary data",
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"invalid type ID"}`,
- },
- {
- name: "failed to read request body",
- hash: "2B000001E4",
- queryParams: "?type=1",
- requestBody: "", // This will cause an error when reading
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"failed to read request body"}`,
- },
- {
- name: "asset already exists",
- hash: "2B000001E4",
- queryParams: "?type=1",
- requestBody: "binary data",
- wantStatusCode: http.StatusConflict,
- wantResponse: `{"message":"BART asset already exists"}`,
- mockParams: mockParams{
- bartAssetManagerParams: bartAssetManagerParams{
- insertBARTItemParams: insertBARTItemParams{
- {
- hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
- blob: []byte("binary data"),
- itemType: 1,
- err: state.ErrBARTItemExists,
- },
- },
- },
- },
- },
- {
- name: "internal server error",
- hash: "2B000001E4",
- queryParams: "?type=1",
- requestBody: "binary data",
- wantStatusCode: http.StatusInternalServerError,
- wantResponse: `{"message":"internal server error"}`,
- mockParams: mockParams{
- bartAssetManagerParams: bartAssetManagerParams{
- insertBARTItemParams: insertBARTItemParams{
- {
- hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
- blob: []byte("binary data"),
- itemType: 1,
- err: errors.New("database error"),
- },
- },
- },
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- var requestBody io.Reader
- if tc.requestBody != "" {
- requestBody = strings.NewReader(tc.requestBody)
- } else {
- requestBody = &errorReader{}
- }
- request := httptest.NewRequest(http.MethodPost, "/bart/"+tc.hash+tc.queryParams, requestBody)
- // Set the path value manually for testing
- if tc.hash != "" {
- request.SetPathValue("hash", tc.hash)
- }
- responseRecorder := httptest.NewRecorder()
- mockBARTManager := newMockBARTAssetManager(t)
- for _, params := range tc.mockParams.insertBARTItemParams {
- mockBARTManager.EXPECT().
- InsertBARTItem(matchContext(), params.hash, params.blob, params.itemType).
- Return(params.err)
- }
- postBARTHandler(responseRecorder, request, mockBARTManager, slog.Default())
- assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
- assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
- })
- }
- }
- func TestBARTHandler_DELETE(t *testing.T) {
- tt := []struct {
- name string
- hash string
- wantStatusCode int
- wantResponse string
- mockParams mockParams
- }{
- {
- name: "success with valid hash",
- hash: "2B000001E4",
- wantStatusCode: http.StatusOK,
- wantResponse: `{"message":"BART asset deleted successfully."}`,
- mockParams: mockParams{
- bartAssetManagerParams: bartAssetManagerParams{
- deleteBARTItemParams: deleteBARTItemParams{
- {
- hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
- err: nil,
- },
- },
- },
- },
- },
- {
- name: "missing hash parameter",
- hash: "",
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"hash path parameter is required"}`,
- },
- {
- name: "invalid hash format",
- hash: "invalid-hex",
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"invalid hash format"}`,
- },
- {
- name: "asset not found",
- hash: "2B000001E4",
- wantStatusCode: http.StatusNotFound,
- wantResponse: `{"message":"BART asset not found"}`,
- mockParams: mockParams{
- bartAssetManagerParams: bartAssetManagerParams{
- deleteBARTItemParams: deleteBARTItemParams{
- {
- hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
- err: state.ErrBARTItemNotFound,
- },
- },
- },
- },
- },
- {
- name: "internal server error",
- hash: "2B000001E4",
- wantStatusCode: http.StatusInternalServerError,
- wantResponse: `{"message":"internal server error"}`,
- mockParams: mockParams{
- bartAssetManagerParams: bartAssetManagerParams{
- deleteBARTItemParams: deleteBARTItemParams{
- {
- hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
- err: errors.New("database error"),
- },
- },
- },
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- request := httptest.NewRequest(http.MethodDelete, "/bart/"+tc.hash, nil)
- // Set the path value manually for testing
- if tc.hash != "" {
- request.SetPathValue("hash", tc.hash)
- }
- responseRecorder := httptest.NewRecorder()
- mockBARTManager := newMockBARTAssetManager(t)
- for _, params := range tc.mockParams.deleteBARTItemParams {
- mockBARTManager.EXPECT().
- DeleteBARTItem(matchContext(), params.hash).
- Return(params.err)
- }
- deleteBARTHandler(responseRecorder, request, mockBARTManager, slog.Default())
- assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
- assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
- })
- }
- }
- // errorReader is a helper type that always returns an error when reading
- type errorReader struct{}
- func (er *errorReader) Read(p []byte) (n int, err error) {
- return 0, errors.New("read error")
- }
- func TestFeedbagBuddyHandler_GET(t *testing.T) {
- tt := []struct {
- name string
- screenName string
- wantStatusCode int
- wantResponse string
- mockParams mockParams
- }{
- {
- name: "empty feedbag",
- screenName: "userA",
- wantStatusCode: http.StatusNotFound,
- wantResponse: `{"message":"feedbag not found"}`,
- mockParams: mockParams{
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: []wire.FeedbagItem{},
- err: nil,
- },
- },
- },
- },
- },
- {
- name: "feedbag with buddies in groups",
- screenName: "userA",
- wantStatusCode: http.StatusOK,
- wantResponse: `[{"group_id":1,"group_name":"Friends","buddies":[{"name":"buddy1","item_id":10},{"name":"buddy2","item_id":11}]},{"group_id":2,"group_name":"Work","buddies":[{"name":"buddy3","item_id":20}]}]`,
- mockParams: mockParams{
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: []wire.FeedbagItem{
- {
- ItemID: 0,
- ClassID: wire.FeedbagClassIdGroup,
- Name: "",
- GroupID: 0,
- },
- {
- ItemID: 1,
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{10, 11}),
- },
- },
- },
- {
- ItemID: 2,
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Work",
- GroupID: 2,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{20}),
- },
- },
- },
- {
- ItemID: 10,
- ClassID: wire.FeedbagClassIdBuddy,
- Name: "buddy1",
- GroupID: 1,
- },
- {
- ItemID: 11,
- ClassID: wire.FeedbagClassIdBuddy,
- Name: "buddy2",
- GroupID: 1,
- },
- {
- ItemID: 20,
- ClassID: wire.FeedbagClassIdBuddy,
- Name: "buddy3",
- GroupID: 2,
- },
- },
- err: nil,
- },
- },
- },
- },
- },
- {
- name: "feedbag with no groups (besides root)",
- screenName: "userA",
- wantStatusCode: http.StatusOK,
- wantResponse: `[]`,
- mockParams: mockParams{
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: []wire.FeedbagItem{
- {
- ItemID: 0,
- ClassID: wire.FeedbagClassIdGroup,
- Name: "",
- GroupID: 0,
- },
- },
- err: nil,
- },
- },
- },
- },
- // Note: Root groups (GroupID == 0) are skipped by the implementation,
- // so the response will be an empty array []
- },
- {
- name: "missing screen_name",
- screenName: "",
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"screen_name is required"}`,
- },
- {
- name: "internal server error",
- screenName: "userA",
- wantStatusCode: http.StatusInternalServerError,
- wantResponse: `{"message":"internal server error"}`,
- mockParams: mockParams{
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: nil,
- err: errors.New("database error"),
- },
- },
- },
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- request := httptest.NewRequest(http.MethodGet, "/feedbag/"+tc.screenName+"/group", nil)
- if tc.screenName != "" {
- request.SetPathValue("screen_name", tc.screenName)
- }
- responseRecorder := httptest.NewRecorder()
- feedbagManager := newMockFeedbagManager(t)
- for _, params := range tc.mockParams.feedbagParams {
- feedbagManager.EXPECT().
- Feedbag(matchContext(), params.screenName).
- Return(params.result, params.err)
- }
- getFeedbagBuddyHandler(responseRecorder, request, feedbagManager, slog.Default())
- assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
- assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
- })
- }
- }
- func TestFeedbagGroupHandler_PUT(t *testing.T) {
- tt := []struct {
- name string
- screenName string
- groupName string
- groupIDGen func(n int) int
- wantStatusCode int
- wantResponse string
- mockParams mockParams
- }{
- {
- name: "add group to empty feedbag",
- screenName: "userA",
- groupName: "Friends",
- groupIDGen: func(n int) int { return 5 },
- wantStatusCode: http.StatusCreated,
- wantResponse: `{"group_id":5,"group_name":"Friends"}`,
- mockParams: mockParams{
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: []wire.FeedbagItem{},
- err: nil,
- },
- },
- feedbagUpsertParams: feedbagUpsertParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- items: []wire.FeedbagItem{
- {
- ClassID: wire.FeedbagClassIdGroup,
- GroupID: 0,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{5}),
- },
- },
- },
- {
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 5,
- },
- },
- err: nil,
- },
- },
- },
- messageRelayerParams: messageRelayerParams{
- relayToScreenNameParams: relayToScreenNameParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- msg: wire.SNACMessage{
- Frame: wire.SNACFrame{
- FoodGroup: wire.Feedbag,
- SubGroup: wire.FeedbagInsertItem,
- RequestID: wire.ReqIDFromServer,
- },
- Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
- Items: []wire.FeedbagItem{
- {
- ClassID: wire.FeedbagClassIdGroup,
- GroupID: 0,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{5}),
- },
- },
- },
- {
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 5,
- },
- },
- },
- },
- },
- },
- },
- },
- },
- {
- name: "add group to feedbag with existing root",
- screenName: "userA",
- groupName: "Coworkers",
- groupIDGen: func(n int) int { return 2 },
- wantStatusCode: http.StatusCreated,
- wantResponse: `{"group_id":2,"group_name":"Coworkers"}`,
- mockParams: mockParams{
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: []wire.FeedbagItem{
- {
- ClassID: wire.FeedbagClassIdGroup,
- GroupID: 0,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1}),
- },
- },
- },
- {
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Buddies",
- GroupID: 1,
- },
- },
- err: nil,
- },
- },
- feedbagUpsertParams: feedbagUpsertParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- items: []wire.FeedbagItem{
- {
- ClassID: wire.FeedbagClassIdGroup,
- GroupID: 0,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1, 2}),
- },
- },
- },
- {
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Coworkers",
- GroupID: 2,
- },
- },
- err: nil,
- },
- },
- },
- messageRelayerParams: messageRelayerParams{
- relayToScreenNameParams: relayToScreenNameParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- msg: wire.SNACMessage{
- Frame: wire.SNACFrame{
- FoodGroup: wire.Feedbag,
- SubGroup: wire.FeedbagInsertItem,
- RequestID: wire.ReqIDFromServer,
- },
- Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
- Items: []wire.FeedbagItem{
- {
- ClassID: wire.FeedbagClassIdGroup,
- GroupID: 0,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1, 2}),
- },
- },
- },
- {
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Coworkers",
- GroupID: 2,
- },
- },
- },
- },
- },
- },
- },
- },
- },
- {
- name: "group already exists",
- screenName: "userA",
- groupName: "Friends",
- groupIDGen: func(n int) int { return 99 },
- wantStatusCode: http.StatusOK,
- wantResponse: `{"group_id":1,"group_name":"Friends"}`,
- mockParams: mockParams{
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: []wire.FeedbagItem{
- {
- ClassID: wire.FeedbagClassIdGroup,
- GroupID: 0,
- },
- {
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- },
- },
- err: nil,
- },
- },
- },
- },
- },
- {
- name: "missing screen_name",
- screenName: "",
- groupName: "Friends",
- groupIDGen: func(n int) int { return 5 },
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"screen_name is required"}`,
- },
- {
- name: "missing group_name",
- screenName: "userA",
- groupName: "",
- groupIDGen: func(n int) int { return 5 },
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"group_name is required"}`,
- },
- {
- name: "error retrieving feedbag",
- screenName: "userA",
- groupName: "Friends",
- groupIDGen: func(n int) int { return 5 },
- wantStatusCode: http.StatusInternalServerError,
- wantResponse: `{"message":"internal server error"}`,
- mockParams: mockParams{
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: nil,
- err: errors.New("database error"),
- },
- },
- },
- },
- },
- {
- name: "error upserting feedbag",
- screenName: "userA",
- groupName: "Friends",
- groupIDGen: func(n int) int { return 5 },
- wantStatusCode: http.StatusInternalServerError,
- wantResponse: `{"message":"internal server error"}`,
- mockParams: mockParams{
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: []wire.FeedbagItem{},
- err: nil,
- },
- },
- feedbagUpsertParams: feedbagUpsertParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- items: []wire.FeedbagItem{
- {
- ClassID: wire.FeedbagClassIdGroup,
- GroupID: 0,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{5}),
- },
- },
- },
- {
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 5,
- },
- },
- err: errors.New("database error"),
- },
- },
- },
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- request := httptest.NewRequest(http.MethodPut, "/feedbag/"+tc.screenName+"/group/"+tc.groupName, nil)
- if tc.screenName != "" {
- request.SetPathValue("screen_name", tc.screenName)
- }
- if tc.groupName != "" {
- request.SetPathValue("group_name", tc.groupName)
- }
- responseRecorder := httptest.NewRecorder()
- feedbagManager := newMockFeedbagManager(t)
- messageRelayer := newMockMessageRelayer(t)
- for _, params := range tc.mockParams.feedbagParams {
- feedbagManager.EXPECT().
- Feedbag(matchContext(), params.screenName).
- Return(params.result, params.err)
- }
- for _, params := range tc.mockParams.feedbagUpsertParams {
- feedbagManager.EXPECT().
- FeedbagUpsert(matchContext(), params.screenName, params.items).
- Return(params.err)
- }
- for _, params := range tc.mockParams.relayToScreenNameParams {
- messageRelayer.EXPECT().
- RelayToScreenName(matchContext(), params.screenName, params.msg)
- }
- putFeedbagGroupHandler(responseRecorder, request, feedbagManager, messageRelayer, slog.Default(), tc.groupIDGen)
- assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
- assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
- })
- }
- }
- func TestFeedbagBuddyHandler_PUT(t *testing.T) {
- tt := []struct {
- name string
- screenName string
- groupID string
- requestBody string
- wantStatusCode int
- wantResponse string
- mockParams mockParams
- }{
- {
- name: "add a buddy to an empty group, user not signed in",
- screenName: "userA",
- groupID: "1",
- requestBody: `{"name":"newbuddy"}`,
- wantStatusCode: http.StatusOK,
- wantResponse: `{"name":"newbuddy","group_id":1,"item_id":1000}`,
- mockParams: mockParams{
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: []wire.FeedbagItem{
- {
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- },
- },
- err: nil,
- },
- },
- feedbagUpsertParams: feedbagUpsertParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- items: []wire.FeedbagItem{
- {
- Name: "newbuddy",
- GroupID: 1,
- ItemID: 1000,
- ClassID: wire.FeedbagClassIdBuddy,
- },
- {
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1000}),
- },
- },
- },
- },
- err: nil,
- },
- },
- },
- sessionRetrieverParams: sessionRetrieverParams{
- retrieveSessionByNameParams: retrieveSessionByNameParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: state.NewSession(),
- },
- },
- },
- messageRelayerParams: messageRelayerParams{
- relayToScreenNameParams: relayToScreenNameParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- msg: wire.SNACMessage{
- Frame: wire.SNACFrame{
- FoodGroup: wire.Feedbag,
- SubGroup: wire.FeedbagInsertItem,
- RequestID: wire.ReqIDFromServer,
- },
- Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
- Items: []wire.FeedbagItem{
- {
- Name: "newbuddy",
- GroupID: 1,
- ItemID: 1000,
- ClassID: wire.FeedbagClassIdBuddy,
- },
- },
- },
- },
- },
- {
- screenName: state.NewIdentScreenName("userA"),
- msg: wire.SNACMessage{
- Frame: wire.SNACFrame{
- FoodGroup: wire.Feedbag,
- SubGroup: wire.FeedbagUpdateItem,
- RequestID: wire.ReqIDFromServer,
- },
- Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
- Items: []wire.FeedbagItem{
- {
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1000}),
- },
- },
- },
- },
- },
- },
- },
- },
- },
- },
- },
- {
- name: "add a buddy to a non-empty group, user not signed in",
- screenName: "userA",
- groupID: "1",
- requestBody: `{"name":"newbuddy2"}`,
- wantStatusCode: http.StatusOK,
- wantResponse: `{"name":"newbuddy2","group_id":1,"item_id":1000}`,
- mockParams: mockParams{
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: []wire.FeedbagItem{
- {
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{12345}),
- },
- },
- },
- {
- ItemID: 12345,
- ClassID: wire.FeedbagClassIdBuddy,
- Name: "existingbuddy",
- GroupID: 1,
- },
- },
- err: nil,
- },
- },
- feedbagUpsertParams: feedbagUpsertParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- items: []wire.FeedbagItem{
- {
- Name: "newbuddy2",
- GroupID: 1,
- ItemID: 1000,
- ClassID: wire.FeedbagClassIdBuddy,
- },
- {
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{12345, 1000}),
- },
- },
- },
- },
- err: nil,
- },
- },
- },
- sessionRetrieverParams: sessionRetrieverParams{
- retrieveSessionByNameParams: retrieveSessionByNameParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: state.NewSession(),
- },
- },
- },
- messageRelayerParams: messageRelayerParams{
- relayToScreenNameParams: relayToScreenNameParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- msg: wire.SNACMessage{
- Frame: wire.SNACFrame{
- FoodGroup: wire.Feedbag,
- SubGroup: wire.FeedbagInsertItem,
- RequestID: wire.ReqIDFromServer,
- },
- Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
- Items: []wire.FeedbagItem{
- {
- Name: "newbuddy2",
- GroupID: 1,
- ItemID: 1000,
- ClassID: wire.FeedbagClassIdBuddy,
- },
- },
- },
- },
- },
- {
- screenName: state.NewIdentScreenName("userA"),
- msg: wire.SNACMessage{
- Frame: wire.SNACFrame{
- FoodGroup: wire.Feedbag,
- SubGroup: wire.FeedbagUpdateItem,
- RequestID: wire.ReqIDFromServer,
- },
- Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
- Items: []wire.FeedbagItem{
- {
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{12345, 1000}),
- },
- },
- },
- },
- },
- },
- },
- },
- },
- },
- },
- {
- name: "add a buddy that already exists in a group",
- screenName: "userA",
- groupID: "1",
- requestBody: `{"name":"ExistingBuddy"}`,
- wantStatusCode: http.StatusOK,
- wantResponse: `{"name":"ExistingBuddy","group_id":1,"item_id":12345}`,
- mockParams: mockParams{
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: []wire.FeedbagItem{
- {
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{12345}),
- },
- },
- },
- {
- ItemID: 12345,
- ClassID: wire.FeedbagClassIdBuddy,
- Name: "existingbuddy",
- GroupID: 1,
- },
- },
- err: nil,
- },
- },
- // No FeedbagUpsert should be called when buddy already exists
- },
- // No session retrieval or message relaying should occur
- },
- },
- {
- name: "add a buddy to an empty group, user signed in",
- screenName: "userA",
- groupID: "1",
- requestBody: `{"name":"newbuddy"}`,
- wantStatusCode: http.StatusOK,
- wantResponse: `{"name":"newbuddy","group_id":1,"item_id":1000}`,
- mockParams: mockParams{
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: []wire.FeedbagItem{
- {
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- },
- },
- err: nil,
- },
- },
- feedbagUpsertParams: feedbagUpsertParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- items: []wire.FeedbagItem{
- {
- Name: "newbuddy",
- GroupID: 1,
- ItemID: 1000,
- ClassID: wire.FeedbagClassIdBuddy,
- },
- {
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1000}),
- },
- },
- },
- },
- err: nil,
- },
- },
- },
- sessionRetrieverParams: sessionRetrieverParams{
- retrieveSessionByNameParams: retrieveSessionByNameParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: func() *state.Session {
- sess := state.NewSession()
- sess.SetIdentScreenName(state.NewIdentScreenName("userA"))
- inst := sess.AddInstance()
- inst.SetSignonComplete()
- return sess
- }(),
- },
- },
- },
- messageRelayerParams: messageRelayerParams{
- relayToScreenNameParams: relayToScreenNameParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- msg: wire.SNACMessage{
- Frame: wire.SNACFrame{
- FoodGroup: wire.Feedbag,
- SubGroup: wire.FeedbagInsertItem,
- RequestID: wire.ReqIDFromServer,
- },
- Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
- Items: []wire.FeedbagItem{
- {
- Name: "newbuddy",
- GroupID: 1,
- ItemID: 1000,
- ClassID: wire.FeedbagClassIdBuddy,
- },
- },
- },
- },
- },
- {
- screenName: state.NewIdentScreenName("userA"),
- msg: wire.SNACMessage{
- Frame: wire.SNACFrame{
- FoodGroup: wire.Feedbag,
- SubGroup: wire.FeedbagUpdateItem,
- RequestID: wire.ReqIDFromServer,
- },
- Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
- Items: []wire.FeedbagItem{
- {
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1000}),
- },
- },
- },
- },
- },
- },
- },
- },
- },
- buddyBroadcasterParams: buddyBroadcasterParams{
- broadcastVisibilityParams: broadcastVisibilityParams{
- {
- you: nil, // Not used in expectation, matched with mock.AnythingOfType
- filter: []state.IdentScreenName{state.NewIdentScreenName("newbuddy")},
- sendDepartures: false,
- err: nil,
- },
- },
- },
- },
- },
- {
- name: "invalid group_id - non-numeric",
- screenName: "userA",
- groupID: "invalid",
- requestBody: `{"name":"buddy"}`,
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"invalid group_id"}`,
- },
- {
- name: "invalid group_id - out of range",
- screenName: "userA",
- groupID: "99999",
- requestBody: `{"name":"buddy"}`,
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"invalid group_id"}`,
- },
- {
- name: "can't add buddies to root group",
- screenName: "userA",
- groupID: "0",
- requestBody: `{"name":"buddy"}`,
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"can't add buddies to root group"}`,
- },
- {
- name: "empty screen_name",
- screenName: "",
- groupID: "1",
- requestBody: `{"name":"buddy"}`,
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"screen_name is required"}`,
- },
- {
- name: "malformed JSON input",
- screenName: "userA",
- groupID: "1",
- requestBody: `invalid json`,
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"buddy_screen_name is required"}`,
- },
- {
- name: "empty name in request body",
- screenName: "userA",
- groupID: "1",
- requestBody: `{"name":""}`,
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"buddy_screen_name is required"}`,
- },
- {
- name: "missing name in request body",
- screenName: "userA",
- groupID: "1",
- requestBody: `{}`,
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"buddy_screen_name is required"}`,
- },
- {
- name: "invalid UIN - too low",
- screenName: "userA",
- groupID: "1",
- requestBody: `{"name":"9999"}`,
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"invalid uin: uin must be a number in the range 10000-2147483646"}`,
- },
- {
- name: "invalid UIN - too high",
- screenName: "userA",
- groupID: "1",
- requestBody: `{"name":"2147483647"}`,
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"invalid uin: uin must be a number in the range 10000-2147483646"}`,
- },
- {
- name: "invalid AIM handle - too short",
- screenName: "userA",
- groupID: "1",
- requestBody: `{"name":"Us"}`,
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"invalid screen name: screen name must be between 3 and 16 characters"}`,
- },
- {
- name: "invalid AIM handle - too long",
- screenName: "userA",
- groupID: "1",
- requestBody: `{"name":"ThisIsAReallyLongScreenName"}`,
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"invalid screen name: screen name must be between 3 and 16 characters"}`,
- },
- {
- name: "error retrieving feedbag",
- screenName: "userA",
- groupID: "1",
- requestBody: `{"name":"buddy"}`,
- wantStatusCode: http.StatusInternalServerError,
- wantResponse: `{"message":"internal server error"}`,
- mockParams: mockParams{
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: nil,
- err: errors.New("database error"),
- },
- },
- },
- },
- },
- {
- name: "too many buddies in group - max 30",
- screenName: "userA",
- groupID: "1",
- requestBody: `{"name":"newbuddy"}`,
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"too many buddies in group. max: 30"}`,
- mockParams: mockParams{
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: func() []wire.FeedbagItem {
- order := make([]uint16, 30)
- for i := 1; i <= 30; i++ {
- order[i-1] = uint16(i)
- }
- items := []wire.FeedbagItem{
- {
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, order),
- },
- },
- },
- }
- // Add 30 buddies to the group
- for i := 1; i <= 30; i++ {
- items = append(items, wire.FeedbagItem{
- ItemID: uint16(i),
- ClassID: wire.FeedbagClassIdBuddy,
- Name: fmt.Sprintf("buddy%d", i),
- GroupID: 1,
- })
- }
- return items
- }(),
- err: nil,
- },
- },
- },
- },
- },
- {
- name: "group not found",
- screenName: "userA",
- groupID: "999",
- requestBody: `{"name":"buddy"}`,
- wantStatusCode: http.StatusNotFound,
- wantResponse: `{"message":"group not found"}`,
- mockParams: mockParams{
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: []wire.FeedbagItem{
- {
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- },
- },
- err: nil,
- },
- },
- },
- },
- },
- {
- name: "error inserting feedbag item",
- screenName: "userA",
- groupID: "1",
- requestBody: `{"name":"buddy"}`,
- wantStatusCode: http.StatusInternalServerError,
- wantResponse: `{"message":"internal server error"}`,
- mockParams: mockParams{
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: []wire.FeedbagItem{
- {
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- },
- },
- err: nil,
- },
- },
- feedbagUpsertParams: feedbagUpsertParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- items: []wire.FeedbagItem{
- {
- Name: "buddy",
- GroupID: 1,
- ItemID: 1000,
- ClassID: wire.FeedbagClassIdBuddy,
- },
- {
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1000}),
- },
- },
- },
- },
- err: errors.New("database error"),
- },
- },
- },
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- // Extract buddy name from requestBody JSON
- var buddyName string
- if tc.requestBody != "" {
- var input struct {
- Name string `json:"name"`
- }
- if err := json.Unmarshal([]byte(tc.requestBody), &input); err == nil {
- buddyName = input.Name
- }
- }
- request := httptest.NewRequest(http.MethodPut, "/feedbag/"+tc.screenName+"/group/"+tc.groupID+"/buddy/"+buddyName, nil)
- if tc.screenName != "" {
- request.SetPathValue("screen_name", tc.screenName)
- }
- if tc.groupID != "" {
- request.SetPathValue("group_id", tc.groupID)
- }
- request.SetPathValue("buddy_screen_name", buddyName)
- responseRecorder := httptest.NewRecorder()
- feedbagManager := newMockFeedbagManager(t)
- sessionRetriever := newMockSessionRetriever(t)
- messageRelayer := newMockMessageRelayer(t)
- buddyBroadcaster := newMockBuddyBroadcaster(t)
- for _, params := range tc.mockParams.feedbagParams {
- feedbagManager.EXPECT().
- Feedbag(matchContext(), params.screenName).
- Return(params.result, params.err)
- }
- for _, params := range tc.mockParams.feedbagUpsertParams {
- feedbagManager.EXPECT().
- FeedbagUpsert(matchContext(), params.screenName, params.items).
- Return(params.err)
- }
- for _, params := range tc.mockParams.retrieveSessionByNameParams {
- sessionRetriever.EXPECT().
- RetrieveSession(params.screenName).
- Return(params.result)
- }
- for _, params := range tc.mockParams.relayToScreenNameParams {
- messageRelayer.EXPECT().
- RelayToScreenName(matchContext(), params.screenName, params.msg)
- }
- for _, params := range tc.mockParams.broadcastVisibilityParams {
- // Use mock.MatchedBy to match any SessionInstance, since we're mainly verifying filter and sendDepartures
- buddyBroadcaster.EXPECT().
- BroadcastVisibility(
- matchContext(),
- mock.AnythingOfType("*state.SessionInstance"),
- params.filter,
- params.sendDepartures,
- ).
- Return(params.err)
- }
- deterministicItemID := func(n int) int {
- return 1000
- }
- putFeedbagBuddyHandler(responseRecorder, request, buddyBroadcaster, feedbagManager, sessionRetriever, messageRelayer, slog.Default(), deterministicItemID)
- assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
- if tc.wantStatusCode == http.StatusOK {
- assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
- } else {
- assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
- }
- })
- }
- }
- func TestFeedbagBuddyHandler_DELETE(t *testing.T) {
- tt := []struct {
- name string
- screenName string
- groupID string
- requestBody string
- wantStatusCode int
- wantResponse string
- mockParams mockParams
- }{
- {
- name: "delete existing buddy, user not signed in",
- screenName: "userA",
- groupID: "1",
- requestBody: `{"name":"buddy1"}`,
- wantStatusCode: http.StatusNoContent,
- mockParams: mockParams{
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: []wire.FeedbagItem{
- {
- ItemID: 1,
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{10}),
- },
- },
- },
- {
- ItemID: 10,
- ClassID: wire.FeedbagClassIdBuddy,
- Name: "buddy1",
- GroupID: 1,
- },
- },
- err: nil,
- },
- },
- feedbagUpsertParams: feedbagUpsertParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- items: []wire.FeedbagItem{
- {
- ItemID: 1,
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{}),
- },
- },
- },
- },
- err: nil,
- },
- },
- feedbagDeleteParams: feedbagDeleteParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- items: []wire.FeedbagItem{
- {
- ItemID: 10,
- ClassID: wire.FeedbagClassIdBuddy,
- Name: "buddy1",
- GroupID: 1,
- },
- },
- err: nil,
- },
- },
- },
- sessionRetrieverParams: sessionRetrieverParams{
- retrieveSessionByNameParams: retrieveSessionByNameParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: state.NewSession(),
- },
- },
- },
- messageRelayerParams: messageRelayerParams{
- relayToScreenNameParams: relayToScreenNameParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- msg: wire.SNACMessage{
- Frame: wire.SNACFrame{
- FoodGroup: wire.Feedbag,
- SubGroup: wire.FeedbagUpdateItem,
- RequestID: wire.ReqIDFromServer,
- },
- Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
- Items: []wire.FeedbagItem{
- {
- ItemID: 1,
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{}),
- },
- },
- },
- },
- },
- },
- },
- {
- screenName: state.NewIdentScreenName("userA"),
- msg: wire.SNACMessage{
- Frame: wire.SNACFrame{
- FoodGroup: wire.Feedbag,
- SubGroup: wire.FeedbagDeleteItem,
- RequestID: wire.ReqIDFromServer,
- },
- Body: wire.SNAC_0x13_0x0A_FeedbagDeleteItem{
- Items: []wire.FeedbagItem{
- {
- ItemID: 10,
- ClassID: wire.FeedbagClassIdBuddy,
- Name: "buddy1",
- GroupID: 1,
- },
- },
- },
- },
- },
- },
- },
- },
- },
- {
- name: "delete existing buddy, user signed in",
- screenName: "userA",
- groupID: "1",
- requestBody: `{"name":"buddy1"}`,
- wantStatusCode: http.StatusNoContent,
- mockParams: mockParams{
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: []wire.FeedbagItem{
- {
- ItemID: 1,
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{10}),
- },
- },
- },
- {
- ItemID: 10,
- ClassID: wire.FeedbagClassIdBuddy,
- Name: "buddy1",
- GroupID: 1,
- },
- },
- err: nil,
- },
- },
- feedbagUpsertParams: feedbagUpsertParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- items: []wire.FeedbagItem{
- {
- ItemID: 1,
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{}),
- },
- },
- },
- },
- err: nil,
- },
- },
- feedbagDeleteParams: feedbagDeleteParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- items: []wire.FeedbagItem{
- {
- ItemID: 10,
- ClassID: wire.FeedbagClassIdBuddy,
- Name: "buddy1",
- GroupID: 1,
- },
- },
- err: nil,
- },
- },
- },
- sessionRetrieverParams: sessionRetrieverParams{
- retrieveSessionByNameParams: retrieveSessionByNameParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: func() *state.Session {
- sess := state.NewSession()
- sess.SetIdentScreenName(state.NewIdentScreenName("userA"))
- inst := sess.AddInstance()
- inst.SetSignonComplete()
- return sess
- }(),
- },
- },
- },
- messageRelayerParams: messageRelayerParams{
- relayToScreenNameParams: relayToScreenNameParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- msg: wire.SNACMessage{
- Frame: wire.SNACFrame{
- FoodGroup: wire.Feedbag,
- SubGroup: wire.FeedbagUpdateItem,
- RequestID: wire.ReqIDFromServer,
- },
- Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
- Items: []wire.FeedbagItem{
- {
- ItemID: 1,
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{}),
- },
- },
- },
- },
- },
- },
- },
- {
- screenName: state.NewIdentScreenName("userA"),
- msg: wire.SNACMessage{
- Frame: wire.SNACFrame{
- FoodGroup: wire.Feedbag,
- SubGroup: wire.FeedbagDeleteItem,
- RequestID: wire.ReqIDFromServer,
- },
- Body: wire.SNAC_0x13_0x0A_FeedbagDeleteItem{
- Items: []wire.FeedbagItem{
- {
- ItemID: 10,
- ClassID: wire.FeedbagClassIdBuddy,
- Name: "buddy1",
- GroupID: 1,
- },
- },
- },
- },
- },
- },
- },
- buddyBroadcasterParams: buddyBroadcasterParams{
- broadcastVisibilityParams: broadcastVisibilityParams{
- {
- you: nil, // Not used in expectation, matched with mock.AnythingOfType
- filter: []state.IdentScreenName{state.NewIdentScreenName("buddy1")},
- sendDepartures: true,
- err: nil,
- },
- },
- },
- },
- },
- {
- name: "delete buddy from a group with multiple buddies, user not signed in",
- screenName: "userA",
- groupID: "1",
- requestBody: `{"name":"buddy1"}`,
- wantStatusCode: http.StatusNoContent,
- mockParams: mockParams{
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: []wire.FeedbagItem{
- {
- ItemID: 1,
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{10, 20}),
- },
- },
- },
- {
- ItemID: 10,
- ClassID: wire.FeedbagClassIdBuddy,
- Name: "buddy1",
- GroupID: 1,
- },
- {
- ItemID: 20,
- ClassID: wire.FeedbagClassIdBuddy,
- Name: "buddy2",
- GroupID: 1,
- },
- },
- err: nil,
- },
- },
- feedbagUpsertParams: feedbagUpsertParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- items: []wire.FeedbagItem{
- {
- ItemID: 1,
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{20}),
- },
- },
- },
- },
- err: nil,
- },
- },
- feedbagDeleteParams: feedbagDeleteParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- items: []wire.FeedbagItem{
- {
- ItemID: 10,
- ClassID: wire.FeedbagClassIdBuddy,
- Name: "buddy1",
- GroupID: 1,
- },
- },
- err: nil,
- },
- },
- },
- sessionRetrieverParams: sessionRetrieverParams{
- retrieveSessionByNameParams: retrieveSessionByNameParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: state.NewSession(),
- },
- },
- },
- messageRelayerParams: messageRelayerParams{
- relayToScreenNameParams: relayToScreenNameParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- msg: wire.SNACMessage{
- Frame: wire.SNACFrame{
- FoodGroup: wire.Feedbag,
- SubGroup: wire.FeedbagUpdateItem,
- RequestID: wire.ReqIDFromServer,
- },
- Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
- Items: []wire.FeedbagItem{
- {
- ItemID: 1,
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{20}),
- },
- },
- },
- },
- },
- },
- },
- {
- screenName: state.NewIdentScreenName("userA"),
- msg: wire.SNACMessage{
- Frame: wire.SNACFrame{
- FoodGroup: wire.Feedbag,
- SubGroup: wire.FeedbagDeleteItem,
- RequestID: wire.ReqIDFromServer,
- },
- Body: wire.SNAC_0x13_0x0A_FeedbagDeleteItem{
- Items: []wire.FeedbagItem{
- {
- ItemID: 10,
- ClassID: wire.FeedbagClassIdBuddy,
- Name: "buddy1",
- GroupID: 1,
- },
- },
- },
- },
- },
- },
- },
- },
- },
- {
- name: "can't delete buddy from root group",
- screenName: "userA",
- groupID: "0",
- requestBody: `{"name":"rootbuddy"}`,
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"can't add buddies to root group"}`,
- },
- {
- name: "missing screen_name",
- screenName: "",
- groupID: "1",
- requestBody: `{"name":"buddy"}`,
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"screen_name is required"}`,
- },
- {
- name: "group not found",
- screenName: "userA",
- groupID: "999",
- requestBody: `{"name":"buddy"}`,
- wantStatusCode: http.StatusNotFound,
- wantResponse: `{"message":"group not found"}`,
- mockParams: mockParams{
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: []wire.FeedbagItem{
- {
- ItemID: 1,
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 0,
- },
- },
- err: nil,
- },
- },
- },
- },
- },
- {
- name: "invalid group_id",
- screenName: "userA",
- groupID: "invalid",
- requestBody: `{"name":"buddy"}`,
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"invalid group_id"}`,
- },
- {
- name: "malformed request body",
- screenName: "userA",
- groupID: "1",
- requestBody: `invalid json`,
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"buddy_screen_name is required"}`,
- },
- {
- name: "missing name in request body",
- screenName: "userA",
- groupID: "1",
- requestBody: `{}`,
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"buddy_screen_name is required"}`,
- },
- {
- name: "buddy not found",
- screenName: "userA",
- groupID: "1",
- requestBody: `{"name":"nonexistent"}`,
- wantStatusCode: http.StatusNotFound,
- wantResponse: `{"message":"buddy not found"}`,
- mockParams: mockParams{
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: []wire.FeedbagItem{
- {
- ItemID: 1,
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- },
- {
- ItemID: 10,
- ClassID: wire.FeedbagClassIdBuddy,
- Name: "otherbuddy",
- GroupID: 1,
- },
- },
- err: nil,
- },
- },
- },
- },
- },
- {
- name: "internal server error on feedbag retrieval",
- screenName: "userA",
- groupID: "1",
- requestBody: `{"name":"buddy"}`,
- wantStatusCode: http.StatusInternalServerError,
- wantResponse: `{"message":"internal server error"}`,
- mockParams: mockParams{
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: nil,
- err: errors.New("database error"),
- },
- },
- },
- },
- },
- {
- name: "internal server error on group order upsert",
- screenName: "userA",
- groupID: "1",
- requestBody: `{"name":"buddy1"}`,
- wantStatusCode: http.StatusInternalServerError,
- wantResponse: `{"message":"internal server error"}`,
- mockParams: mockParams{
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: []wire.FeedbagItem{
- {
- ItemID: 1,
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{10}),
- },
- },
- },
- {
- ItemID: 10,
- ClassID: wire.FeedbagClassIdBuddy,
- Name: "buddy1",
- GroupID: 1,
- },
- },
- err: nil,
- },
- },
- feedbagUpsertParams: feedbagUpsertParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- items: []wire.FeedbagItem{
- {
- ItemID: 1,
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{}),
- },
- },
- },
- },
- err: errors.New("database error"),
- },
- },
- },
- },
- },
- {
- name: "internal server error on delete",
- screenName: "userA",
- groupID: "1",
- requestBody: `{"name":"buddy1"}`,
- wantStatusCode: http.StatusInternalServerError,
- wantResponse: `{"message":"internal server error"}`,
- mockParams: mockParams{
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: []wire.FeedbagItem{
- {
- ItemID: 1,
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{10}),
- },
- },
- },
- {
- ItemID: 10,
- ClassID: wire.FeedbagClassIdBuddy,
- Name: "buddy1",
- GroupID: 1,
- },
- },
- err: nil,
- },
- },
- feedbagUpsertParams: feedbagUpsertParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- items: []wire.FeedbagItem{
- {
- ItemID: 1,
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{}),
- },
- },
- },
- },
- err: nil,
- },
- },
- feedbagDeleteParams: feedbagDeleteParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- items: []wire.FeedbagItem{
- {
- ItemID: 10,
- ClassID: wire.FeedbagClassIdBuddy,
- Name: "buddy1",
- GroupID: 1,
- },
- },
- err: errors.New("database error"),
- },
- },
- },
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- // Extract buddy name from requestBody JSON
- var buddyName string
- if tc.requestBody != "" {
- var input struct {
- Name string `json:"name"`
- }
- if err := json.Unmarshal([]byte(tc.requestBody), &input); err == nil {
- buddyName = input.Name
- }
- }
- request := httptest.NewRequest(http.MethodDelete, "/feedbag/"+tc.screenName+"/group/"+tc.groupID+"/buddy/"+buddyName, nil)
- if tc.screenName != "" {
- request.SetPathValue("screen_name", tc.screenName)
- }
- if tc.groupID != "" {
- request.SetPathValue("group_id", tc.groupID)
- }
- request.SetPathValue("buddy_screen_name", buddyName)
- responseRecorder := httptest.NewRecorder()
- feedbagManager := newMockFeedbagManager(t)
- sessionRetriever := newMockSessionRetriever(t)
- messageRelayer := newMockMessageRelayer(t)
- buddyBroadcaster := newMockBuddyBroadcaster(t)
- for _, params := range tc.mockParams.feedbagParams {
- feedbagManager.EXPECT().
- Feedbag(matchContext(), params.screenName).
- Return(params.result, params.err)
- }
- for _, params := range tc.mockParams.feedbagUpsertParams {
- feedbagManager.EXPECT().
- FeedbagUpsert(matchContext(), params.screenName, params.items).
- Return(params.err)
- }
- for _, params := range tc.mockParams.feedbagDeleteParams {
- feedbagManager.EXPECT().
- FeedbagDelete(matchContext(), params.screenName, params.items).
- Return(params.err)
- }
- for _, params := range tc.mockParams.retrieveSessionByNameParams {
- sessionRetriever.EXPECT().
- RetrieveSession(params.screenName).
- Return(params.result)
- }
- for _, params := range tc.mockParams.relayToScreenNameParams {
- messageRelayer.EXPECT().
- RelayToScreenName(matchContext(), params.screenName, params.msg)
- }
- for _, params := range tc.mockParams.broadcastVisibilityParams {
- buddyBroadcaster.EXPECT().
- BroadcastVisibility(
- matchContext(),
- mock.AnythingOfType("*state.SessionInstance"),
- params.filter,
- params.sendDepartures,
- ).
- Return(params.err)
- }
- deleteFeedbagBuddyHandler(responseRecorder, request, buddyBroadcaster, feedbagManager, sessionRetriever, messageRelayer, slog.Default())
- assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
- if tc.wantResponse != "" {
- assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
- }
- })
- }
- }
- func TestRandItemID(t *testing.T) {
- tt := []struct {
- name string
- randInt func(n int) int
- items []wire.FeedbagItem
- want uint16
- description string
- }{
- {
- name: "empty items list returns random ID",
- randInt: func(n int) int {
- return 1000
- },
- items: []wire.FeedbagItem{},
- want: 1000,
- description: "When no items exist, should return the random number generated",
- },
- {
- name: "finds next available ID when starting ID conflicts with ItemID",
- randInt: func(n int) int {
- return 100
- },
- items: []wire.FeedbagItem{
- {ItemID: 100, GroupID: 1},
- {ItemID: 101, GroupID: 1},
- },
- want: 102,
- description: "Should skip 100 and 101, return 102",
- },
- {
- name: "finds next available ID when starting ID conflicts with GroupID",
- randInt: func(n int) int {
- return 50
- },
- items: []wire.FeedbagItem{
- {ItemID: 1, GroupID: 50},
- {ItemID: 2, GroupID: 51},
- },
- want: 52,
- description: "Should skip 50 (GroupID) and 51 (GroupID), return 52",
- },
- {
- name: "wraps around and skips 0 to find next available ID",
- randInt: func(n int) int {
- return math.MaxUint16 - 2
- },
- items: []wire.FeedbagItem{
- {ItemID: math.MaxUint16 - 2, GroupID: 1},
- {ItemID: math.MaxUint16 - 1, GroupID: 1},
- {ItemID: math.MaxUint16, GroupID: 1},
- },
- want: 2,
- description: "When wrapping around, skips 0 (always skipped) and 1 (if conflicts), returns 2",
- },
- {
- name: "skips 0 when starting from 0 and finds next available",
- randInt: func(n int) int {
- return 0
- },
- items: []wire.FeedbagItem{},
- want: 1,
- description: "When starting from 0, skips 0 (always skipped) and returns 1",
- },
- {
- name: "returns 0 when all IDs are taken",
- randInt: func(n int) int {
- return 100
- },
- items: func() []wire.FeedbagItem {
- // Create items that cover all possible IDs
- items := make([]wire.FeedbagItem, 0, math.MaxUint16+1)
- for i := 0; i <= math.MaxUint16; i++ {
- items = append(items, wire.FeedbagItem{
- ItemID: uint16(i),
- GroupID: uint16(i),
- })
- }
- return items
- }(),
- want: 0,
- description: "When all IDs are taken, should return 0",
- },
- {
- name: "finds ID that conflicts with both ItemID and GroupID",
- randInt: func(n int) int {
- return 200
- },
- items: []wire.FeedbagItem{
- {ItemID: 200, GroupID: 201},
- {ItemID: 201, GroupID: 200},
- },
- want: 202,
- description: "Should skip 200 (ItemID) and 201 (both ItemID and GroupID), return 202",
- },
- {
- name: "finds available ID immediately when no conflicts",
- randInt: func(n int) int {
- return 500
- },
- items: []wire.FeedbagItem{
- {ItemID: 100, GroupID: 1},
- {ItemID: 200, GroupID: 2},
- {ItemID: 300, GroupID: 3},
- },
- want: 500,
- description: "When random ID has no conflicts, should return it immediately",
- },
- {
- name: "handles single conflict and finds next",
- randInt: func(n int) int {
- return 42
- },
- items: []wire.FeedbagItem{
- {ItemID: 42, GroupID: 1},
- },
- want: 43,
- description: "Should skip 42 and return 43",
- },
- {
- name: "finds ID before starting point when wrapping",
- randInt: func(n int) int {
- return 5
- },
- items: []wire.FeedbagItem{
- {ItemID: 5, GroupID: 1},
- {ItemID: 6, GroupID: 1},
- {ItemID: 7, GroupID: 1},
- },
- want: 8,
- description: "Should skip 5, 6, 7 and return 8",
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- got := randItemID(tc.randInt, tc.items)
- if got != tc.want {
- t.Errorf("randItemID() = %d, want %d. %s", got, tc.want, tc.description)
- }
- })
- }
- }
- func TestGetLinkedAccountsHandler(t *testing.T) {
- tt := []struct {
- name string
- screenname string
- statusCode int
- want string
- mockParams mockParams
- }{
- {
- name: "user not found returns 404",
- screenname: "nobody",
- statusCode: http.StatusNotFound,
- want: `{"message":"user not found"}`,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("nobody"),
- result: nil,
- },
- },
- },
- },
- },
- {
- name: "returns empty linked accounts list",
- screenname: "test1",
- statusCode: http.StatusOK,
- want: `{"linked_accounts":[]}`,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("test1"),
- result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
- },
- },
- },
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("test1"),
- result: []wire.FeedbagItem{},
- },
- },
- },
- },
- },
- {
- name: "returns linked accounts",
- screenname: "test1",
- statusCode: http.StatusOK,
- want: `{"linked_accounts":["test2","test3"]}`,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("test1"),
- result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
- },
- },
- },
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("test1"),
- result: []wire.FeedbagItem{
- {ClassID: wire.FeedbagClassIdAlInfo, Name: "test2"},
- {ClassID: wire.FeedbagClassIdAlInfo, Name: "test3"},
- },
- },
- },
- },
- },
- },
- {
- name: "feedbag error returns 500",
- screenname: "test1",
- statusCode: http.StatusInternalServerError,
- want: `{"message":"internal server error"}`,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("test1"),
- result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
- },
- },
- },
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("test1"),
- err: io.EOF,
- },
- },
- },
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- request := httptest.NewRequest(http.MethodGet, "/user/"+tc.screenname+"/linked-account", nil)
- request.SetPathValue("screenname", tc.screenname)
- responseRecorder := httptest.NewRecorder()
- userManager := newMockUserManager(t)
- for _, params := range tc.mockParams.getUserParams {
- userManager.EXPECT().
- User(matchContext(), params.screenName).
- Return(params.result, params.err)
- }
- feedbagManager := newMockFeedbagManager(t)
- for _, params := range tc.mockParams.feedbagParams {
- feedbagManager.EXPECT().
- Feedbag(matchContext(), params.screenName).
- Return(params.result, params.err)
- }
- getLinkedAccountsHandler(responseRecorder, request, userManager, feedbagManager)
- assert.Equal(t, tc.statusCode, responseRecorder.Code)
- assert.Equal(t, tc.want, strings.TrimSpace(responseRecorder.Body.String()))
- })
- }
- }
- func TestPostLinkedAccountHandler(t *testing.T) {
- tt := []struct {
- name string
- screenname string
- body string
- statusCode int
- want string
- mockParams mockParams
- }{
- {
- name: "primary user not found returns 404",
- screenname: "nobody",
- body: `{"linked_screen_name":"test2"}`,
- statusCode: http.StatusNotFound,
- want: `{"message":"user not found"}`,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("nobody"),
- result: nil,
- },
- },
- },
- },
- },
- {
- name: "invalid request body returns 400",
- screenname: "test1",
- body: `not json`,
- statusCode: http.StatusBadRequest,
- want: `{"message":"invalid request body"}`,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("test1"),
- result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
- },
- },
- },
- },
- },
- {
- name: "missing linked_screen_name returns 400",
- screenname: "test1",
- body: `{}`,
- statusCode: http.StatusBadRequest,
- want: `{"message":"invalid request body"}`,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("test1"),
- result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
- },
- },
- },
- },
- },
- {
- name: "self-link returns 400",
- screenname: "test1",
- body: `{"linked_screen_name":"test1"}`,
- statusCode: http.StatusBadRequest,
- want: `{"message":"cannot link an account to itself"}`,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("test1"),
- result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
- },
- },
- },
- },
- },
- {
- name: "linked user not found returns 404",
- screenname: "test1",
- body: `{"linked_screen_name":"nobody"}`,
- statusCode: http.StatusNotFound,
- want: `{"message":"linked user not found"}`,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("test1"),
- result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
- },
- {
- screenName: state.NewIdentScreenName("nobody"),
- result: nil,
- },
- },
- },
- },
- },
- {
- name: "duplicate link returns 409",
- screenname: "test1",
- body: `{"linked_screen_name":"test2"}`,
- statusCode: http.StatusConflict,
- want: `{"message":"linked account already exists"}`,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("test1"),
- result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
- },
- {
- screenName: state.NewIdentScreenName("test2"),
- result: &state.User{IdentScreenName: state.NewIdentScreenName("test2")},
- },
- },
- },
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("test1"),
- result: []wire.FeedbagItem{
- {ClassID: wire.FeedbagClassIdAlInfo, Name: "test2"},
- },
- },
- },
- },
- },
- },
- {
- name: "insert error returns 500",
- screenname: "test1",
- body: `{"linked_screen_name":"test2"}`,
- statusCode: http.StatusInternalServerError,
- want: `{"message":"internal server error"}`,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("test1"),
- result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
- },
- {
- screenName: state.NewIdentScreenName("test2"),
- result: &state.User{IdentScreenName: state.NewIdentScreenName("test2")},
- },
- },
- },
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("test1"),
- result: []wire.FeedbagItem{},
- },
- },
- feedbagUpsertParams: feedbagUpsertParams{
- {
- screenName: state.NewIdentScreenName("test1"),
- items: []wire.FeedbagItem{
- {ItemID: 1, ClassID: wire.FeedbagClassIdAlInfo, Name: "test2"},
- },
- err: io.EOF,
- },
- },
- },
- },
- },
- {
- name: "link created returns 201",
- screenname: "test1",
- body: `{"linked_screen_name":"test2"}`,
- statusCode: http.StatusCreated,
- want: ``,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("test1"),
- result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
- },
- {
- screenName: state.NewIdentScreenName("test2"),
- result: &state.User{IdentScreenName: state.NewIdentScreenName("test2")},
- },
- },
- },
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("test1"),
- result: []wire.FeedbagItem{},
- },
- },
- feedbagUpsertParams: feedbagUpsertParams{
- {
- screenName: state.NewIdentScreenName("test1"),
- items: []wire.FeedbagItem{
- {ItemID: 1, ClassID: wire.FeedbagClassIdAlInfo, Name: "test2"},
- },
- },
- },
- },
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- request := httptest.NewRequest(http.MethodPost, "/user/"+tc.screenname+"/linked-account", strings.NewReader(tc.body))
- request.SetPathValue("screenname", tc.screenname)
- responseRecorder := httptest.NewRecorder()
- userManager := newMockUserManager(t)
- for _, params := range tc.mockParams.getUserParams {
- userManager.EXPECT().
- User(matchContext(), params.screenName).
- Return(params.result, params.err)
- }
- feedbagManager := newMockFeedbagManager(t)
- for _, params := range tc.mockParams.feedbagParams {
- feedbagManager.EXPECT().
- Feedbag(matchContext(), params.screenName).
- Return(params.result, params.err)
- }
- for _, params := range tc.mockParams.feedbagUpsertParams {
- feedbagManager.EXPECT().
- FeedbagUpsert(matchContext(), params.screenName, params.items).
- Return(params.err)
- }
- postLinkedAccountHandler(responseRecorder, request, userManager, feedbagManager, slog.Default(), func(n int) int { return 0 })
- assert.Equal(t, tc.statusCode, responseRecorder.Code)
- assert.Equal(t, tc.want, strings.TrimSpace(responseRecorder.Body.String()))
- })
- }
- }
- func TestDeleteLinkedAccountHandler(t *testing.T) {
- linkedFeedbagItem := wire.FeedbagItem{
- ItemID: 1,
- ClassID: wire.FeedbagClassIdAlInfo,
- Name: "test2",
- }
- tt := []struct {
- name string
- screenname string
- linkedScreenname string
- statusCode int
- want string
- mockParams mockParams
- }{
- {
- name: "primary user not found returns 404",
- screenname: "nobody",
- linkedScreenname: "test2",
- statusCode: http.StatusNotFound,
- want: `{"message":"user not found"}`,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("nobody"),
- result: nil,
- },
- },
- },
- },
- },
- {
- name: "linked account not found returns 404",
- screenname: "test1",
- linkedScreenname: "ghost",
- statusCode: http.StatusNotFound,
- want: `{"message":"linked account not found"}`,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("test1"),
- result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
- },
- },
- },
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("test1"),
- result: []wire.FeedbagItem{},
- },
- },
- },
- },
- },
- {
- name: "delete error returns 500",
- screenname: "test1",
- linkedScreenname: "test2",
- statusCode: http.StatusInternalServerError,
- want: `{"message":"internal server error"}`,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("test1"),
- result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
- },
- },
- },
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("test1"),
- result: []wire.FeedbagItem{linkedFeedbagItem},
- },
- },
- feedbagDeleteParams: feedbagDeleteParams{
- {
- screenName: state.NewIdentScreenName("test1"),
- items: []wire.FeedbagItem{linkedFeedbagItem},
- err: io.EOF,
- },
- },
- },
- },
- },
- {
- name: "upsert error after delete returns 500",
- screenname: "test1",
- linkedScreenname: "test2",
- statusCode: http.StatusInternalServerError,
- want: `{"message":"internal server error"}`,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("test1"),
- result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
- },
- },
- },
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("test1"),
- result: []wire.FeedbagItem{linkedFeedbagItem},
- },
- },
- feedbagDeleteParams: feedbagDeleteParams{
- {
- screenName: state.NewIdentScreenName("test1"),
- items: []wire.FeedbagItem{linkedFeedbagItem},
- },
- },
- feedbagUpsertParams: feedbagUpsertParams{
- {
- screenName: state.NewIdentScreenName("test1"),
- items: []wire.FeedbagItem{{ClassID: wire.FeedbagClassIdGroup}},
- err: io.EOF,
- },
- },
- },
- },
- },
- {
- name: "link deleted returns 204",
- screenname: "test1",
- linkedScreenname: "test2",
- statusCode: http.StatusNoContent,
- want: ``,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("test1"),
- result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
- },
- },
- },
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("test1"),
- result: []wire.FeedbagItem{linkedFeedbagItem},
- },
- },
- feedbagDeleteParams: feedbagDeleteParams{
- {
- screenName: state.NewIdentScreenName("test1"),
- items: []wire.FeedbagItem{linkedFeedbagItem},
- },
- },
- feedbagUpsertParams: feedbagUpsertParams{
- {
- screenName: state.NewIdentScreenName("test1"),
- items: []wire.FeedbagItem{{ClassID: wire.FeedbagClassIdGroup}},
- },
- },
- },
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- request := httptest.NewRequest(http.MethodDelete, "/user/"+tc.screenname+"/linked-account/"+tc.linkedScreenname, nil)
- request.SetPathValue("screenname", tc.screenname)
- request.SetPathValue("linked_screenname", tc.linkedScreenname)
- responseRecorder := httptest.NewRecorder()
- userManager := newMockUserManager(t)
- for _, params := range tc.mockParams.getUserParams {
- userManager.EXPECT().
- User(matchContext(), params.screenName).
- Return(params.result, params.err)
- }
- feedbagManager := newMockFeedbagManager(t)
- for _, params := range tc.mockParams.feedbagParams {
- feedbagManager.EXPECT().
- Feedbag(matchContext(), params.screenName).
- Return(params.result, params.err)
- }
- for _, params := range tc.mockParams.feedbagDeleteParams {
- feedbagManager.EXPECT().
- FeedbagDelete(matchContext(), params.screenName, params.items).
- Return(params.err)
- }
- for _, params := range tc.mockParams.feedbagUpsertParams {
- feedbagManager.EXPECT().
- FeedbagUpsert(matchContext(), params.screenName, params.items).
- Return(params.err)
- }
- deleteLinkedAccountHandler(responseRecorder, request, userManager, feedbagManager, slog.Default(), nil)
- assert.Equal(t, tc.statusCode, responseRecorder.Code)
- assert.Equal(t, tc.want, strings.TrimSpace(responseRecorder.Body.String()))
- })
- }
- }
|