mgmt_api_test.go 166 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083108410851086108710881089109010911092109310941095109610971098109911001101110211031104110511061107110811091110111111121113111411151116111711181119112011211122112311241125112611271128112911301131113211331134113511361137113811391140114111421143114411451146114711481149115011511152115311541155115611571158115911601161116211631164116511661167116811691170117111721173117411751176117711781179118011811182118311841185118611871188118911901191119211931194119511961197119811991200120112021203120412051206120712081209121012111212121312141215121612171218121912201221122212231224122512261227122812291230123112321233123412351236123712381239124012411242124312441245124612471248124912501251125212531254125512561257125812591260126112621263126412651266126712681269127012711272127312741275127612771278127912801281128212831284128512861287128812891290129112921293129412951296129712981299130013011302130313041305130613071308130913101311131213131314131513161317131813191320132113221323132413251326132713281329133013311332133313341335133613371338133913401341134213431344134513461347134813491350135113521353135413551356135713581359136013611362136313641365136613671368136913701371137213731374137513761377137813791380138113821383138413851386138713881389139013911392139313941395139613971398139914001401140214031404140514061407140814091410141114121413141414151416141714181419142014211422142314241425142614271428142914301431143214331434143514361437143814391440144114421443144414451446144714481449145014511452145314541455145614571458145914601461146214631464146514661467146814691470147114721473147414751476147714781479148014811482148314841485148614871488148914901491149214931494149514961497149814991500150115021503150415051506150715081509151015111512151315141515151615171518151915201521152215231524152515261527152815291530153115321533153415351536153715381539154015411542154315441545154615471548154915501551155215531554155515561557155815591560156115621563156415651566156715681569157015711572157315741575157615771578157915801581158215831584158515861587158815891590159115921593159415951596159715981599160016011602160316041605160616071608160916101611161216131614161516161617161816191620162116221623162416251626162716281629163016311632163316341635163616371638163916401641164216431644164516461647164816491650165116521653165416551656165716581659166016611662166316641665166616671668166916701671167216731674167516761677167816791680168116821683168416851686168716881689169016911692169316941695169616971698169917001701170217031704170517061707170817091710171117121713171417151716171717181719172017211722172317241725172617271728172917301731173217331734173517361737173817391740174117421743174417451746174717481749175017511752175317541755175617571758175917601761176217631764176517661767176817691770177117721773177417751776177717781779178017811782178317841785178617871788178917901791179217931794179517961797179817991800180118021803180418051806180718081809181018111812181318141815181618171818181918201821182218231824182518261827182818291830183118321833183418351836183718381839184018411842184318441845184618471848184918501851185218531854185518561857185818591860186118621863186418651866186718681869187018711872187318741875187618771878187918801881188218831884188518861887188818891890189118921893189418951896189718981899190019011902190319041905190619071908190919101911191219131914191519161917191819191920192119221923192419251926192719281929193019311932193319341935193619371938193919401941194219431944194519461947194819491950195119521953195419551956195719581959196019611962196319641965196619671968196919701971197219731974197519761977197819791980198119821983198419851986198719881989199019911992199319941995199619971998199920002001200220032004200520062007200820092010201120122013201420152016201720182019202020212022202320242025202620272028202920302031203220332034203520362037203820392040204120422043204420452046204720482049205020512052205320542055205620572058205920602061206220632064206520662067206820692070207120722073207420752076207720782079208020812082208320842085208620872088208920902091209220932094209520962097209820992100210121022103210421052106210721082109211021112112211321142115211621172118211921202121212221232124212521262127212821292130213121322133213421352136213721382139214021412142214321442145214621472148214921502151215221532154215521562157215821592160216121622163216421652166216721682169217021712172217321742175217621772178217921802181218221832184218521862187218821892190219121922193219421952196219721982199220022012202220322042205220622072208220922102211221222132214221522162217221822192220222122222223222422252226222722282229223022312232223322342235223622372238223922402241224222432244224522462247224822492250225122522253225422552256225722582259226022612262226322642265226622672268226922702271227222732274227522762277227822792280228122822283228422852286228722882289229022912292229322942295229622972298229923002301230223032304230523062307230823092310231123122313231423152316231723182319232023212322232323242325232623272328232923302331233223332334233523362337233823392340234123422343234423452346234723482349235023512352235323542355235623572358235923602361236223632364236523662367236823692370237123722373237423752376237723782379238023812382238323842385238623872388238923902391239223932394239523962397239823992400240124022403240424052406240724082409241024112412241324142415241624172418241924202421242224232424242524262427242824292430243124322433243424352436243724382439244024412442244324442445244624472448244924502451245224532454245524562457245824592460246124622463246424652466246724682469247024712472247324742475247624772478247924802481248224832484248524862487248824892490249124922493249424952496249724982499250025012502250325042505250625072508250925102511251225132514251525162517251825192520252125222523252425252526252725282529253025312532253325342535253625372538253925402541254225432544254525462547254825492550255125522553255425552556255725582559256025612562256325642565256625672568256925702571257225732574257525762577257825792580258125822583258425852586258725882589259025912592259325942595259625972598259926002601260226032604260526062607260826092610261126122613261426152616261726182619262026212622262326242625262626272628262926302631263226332634263526362637263826392640264126422643264426452646264726482649265026512652265326542655265626572658265926602661266226632664266526662667266826692670267126722673267426752676267726782679268026812682268326842685268626872688268926902691269226932694269526962697269826992700270127022703270427052706270727082709271027112712271327142715271627172718271927202721272227232724272527262727272827292730273127322733273427352736273727382739274027412742274327442745274627472748274927502751275227532754275527562757275827592760276127622763276427652766276727682769277027712772277327742775277627772778277927802781278227832784278527862787278827892790279127922793279427952796279727982799280028012802280328042805280628072808280928102811281228132814281528162817281828192820282128222823282428252826282728282829283028312832283328342835283628372838283928402841284228432844284528462847284828492850285128522853285428552856285728582859286028612862286328642865286628672868286928702871287228732874287528762877287828792880288128822883288428852886288728882889289028912892289328942895289628972898289929002901290229032904290529062907290829092910291129122913291429152916291729182919292029212922292329242925292629272928292929302931293229332934293529362937293829392940294129422943294429452946294729482949295029512952295329542955295629572958295929602961296229632964296529662967296829692970297129722973297429752976297729782979298029812982298329842985298629872988298929902991299229932994299529962997299829993000300130023003300430053006300730083009301030113012301330143015301630173018301930203021302230233024302530263027302830293030303130323033303430353036303730383039304030413042304330443045304630473048304930503051305230533054305530563057305830593060306130623063306430653066306730683069307030713072307330743075307630773078307930803081308230833084308530863087308830893090309130923093309430953096309730983099310031013102310331043105310631073108310931103111311231133114311531163117311831193120312131223123312431253126312731283129313031313132313331343135313631373138313931403141314231433144314531463147314831493150315131523153315431553156315731583159316031613162316331643165316631673168316931703171317231733174317531763177317831793180318131823183318431853186318731883189319031913192319331943195319631973198319932003201320232033204320532063207320832093210321132123213321432153216321732183219322032213222322332243225322632273228322932303231323232333234323532363237323832393240324132423243324432453246324732483249325032513252325332543255325632573258325932603261326232633264326532663267326832693270327132723273327432753276327732783279328032813282328332843285328632873288328932903291329232933294329532963297329832993300330133023303330433053306330733083309331033113312331333143315331633173318331933203321332233233324332533263327332833293330333133323333333433353336333733383339334033413342334333443345334633473348334933503351335233533354335533563357335833593360336133623363336433653366336733683369337033713372337333743375337633773378337933803381338233833384338533863387338833893390339133923393339433953396339733983399340034013402340334043405340634073408340934103411341234133414341534163417341834193420342134223423342434253426342734283429343034313432343334343435343634373438343934403441344234433444344534463447344834493450345134523453345434553456345734583459346034613462346334643465346634673468346934703471347234733474347534763477347834793480348134823483348434853486348734883489349034913492349334943495349634973498349935003501350235033504350535063507350835093510351135123513351435153516351735183519352035213522352335243525352635273528352935303531353235333534353535363537353835393540354135423543354435453546354735483549355035513552355335543555355635573558355935603561356235633564356535663567356835693570357135723573357435753576357735783579358035813582358335843585358635873588358935903591359235933594359535963597359835993600360136023603360436053606360736083609361036113612361336143615361636173618361936203621362236233624362536263627362836293630363136323633363436353636363736383639364036413642364336443645364636473648364936503651365236533654365536563657365836593660366136623663366436653666366736683669367036713672367336743675367636773678367936803681368236833684368536863687368836893690369136923693369436953696369736983699370037013702370337043705370637073708370937103711371237133714371537163717371837193720372137223723372437253726372737283729373037313732373337343735373637373738373937403741374237433744374537463747374837493750375137523753375437553756375737583759376037613762376337643765376637673768376937703771377237733774377537763777377837793780378137823783378437853786378737883789379037913792379337943795379637973798379938003801380238033804380538063807380838093810381138123813381438153816381738183819382038213822382338243825382638273828382938303831383238333834383538363837383838393840384138423843384438453846384738483849385038513852385338543855385638573858385938603861386238633864386538663867386838693870387138723873387438753876387738783879388038813882388338843885388638873888388938903891389238933894389538963897389838993900390139023903390439053906390739083909391039113912391339143915391639173918391939203921392239233924392539263927392839293930393139323933393439353936393739383939394039413942394339443945394639473948394939503951395239533954395539563957395839593960396139623963396439653966396739683969397039713972397339743975397639773978397939803981398239833984398539863987398839893990399139923993399439953996399739983999400040014002400340044005400640074008400940104011401240134014401540164017401840194020402140224023402440254026402740284029403040314032403340344035403640374038403940404041404240434044404540464047404840494050405140524053405440554056405740584059406040614062406340644065406640674068406940704071407240734074407540764077407840794080408140824083408440854086408740884089409040914092409340944095409640974098409941004101410241034104410541064107410841094110411141124113411441154116411741184119412041214122412341244125412641274128412941304131413241334134413541364137413841394140414141424143414441454146414741484149415041514152415341544155415641574158415941604161416241634164416541664167416841694170417141724173417441754176417741784179418041814182418341844185418641874188418941904191419241934194419541964197419841994200420142024203420442054206420742084209421042114212421342144215421642174218421942204221422242234224422542264227422842294230423142324233423442354236423742384239424042414242424342444245424642474248424942504251425242534254425542564257425842594260426142624263426442654266426742684269427042714272427342744275427642774278427942804281428242834284428542864287428842894290429142924293429442954296429742984299430043014302430343044305430643074308430943104311431243134314431543164317431843194320432143224323432443254326432743284329433043314332433343344335433643374338433943404341434243434344434543464347434843494350435143524353435443554356435743584359436043614362436343644365436643674368436943704371437243734374437543764377437843794380438143824383438443854386438743884389439043914392439343944395439643974398439944004401440244034404440544064407440844094410441144124413441444154416441744184419442044214422442344244425442644274428442944304431443244334434443544364437443844394440444144424443444444454446444744484449445044514452445344544455445644574458445944604461446244634464446544664467446844694470447144724473447444754476447744784479448044814482448344844485448644874488448944904491449244934494449544964497449844994500450145024503450445054506450745084509451045114512451345144515451645174518451945204521452245234524452545264527452845294530453145324533453445354536453745384539454045414542454345444545454645474548454945504551455245534554455545564557455845594560456145624563456445654566456745684569457045714572457345744575457645774578457945804581458245834584458545864587458845894590459145924593459445954596459745984599460046014602460346044605460646074608460946104611461246134614461546164617461846194620462146224623462446254626462746284629463046314632463346344635463646374638463946404641464246434644464546464647464846494650465146524653465446554656465746584659466046614662466346644665466646674668466946704671467246734674467546764677467846794680468146824683468446854686468746884689469046914692469346944695469646974698469947004701470247034704470547064707470847094710471147124713471447154716471747184719472047214722472347244725472647274728472947304731473247334734473547364737473847394740474147424743474447454746474747484749475047514752475347544755475647574758475947604761476247634764476547664767476847694770477147724773477447754776477747784779478047814782478347844785478647874788478947904791479247934794479547964797479847994800480148024803480448054806480748084809481048114812481348144815481648174818481948204821482248234824482548264827482848294830483148324833483448354836483748384839484048414842484348444845484648474848484948504851485248534854485548564857485848594860486148624863486448654866486748684869487048714872487348744875487648774878487948804881488248834884488548864887488848894890489148924893489448954896489748984899490049014902490349044905490649074908490949104911491249134914491549164917491849194920492149224923492449254926492749284929493049314932493349344935493649374938493949404941494249434944494549464947494849494950495149524953495449554956495749584959496049614962496349644965496649674968496949704971497249734974497549764977497849794980498149824983498449854986498749884989499049914992499349944995499649974998499950005001500250035004500550065007500850095010501150125013501450155016501750185019502050215022502350245025502650275028502950305031503250335034503550365037503850395040504150425043504450455046504750485049505050515052505350545055505650575058505950605061506250635064506550665067506850695070507150725073507450755076507750785079508050815082508350845085508650875088508950905091509250935094509550965097509850995100510151025103510451055106510751085109511051115112511351145115511651175118511951205121512251235124512551265127512851295130513151325133513451355136513751385139514051415142514351445145514651475148514951505151515251535154515551565157515851595160516151625163516451655166516751685169517051715172517351745175517651775178517951805181518251835184518551865187518851895190519151925193519451955196519751985199520052015202520352045205520652075208520952105211521252135214521552165217521852195220522152225223522452255226522752285229523052315232523352345235523652375238523952405241524252435244524552465247524852495250525152525253525452555256525752585259526052615262526352645265526652675268526952705271527252735274527552765277527852795280528152825283528452855286528752885289529052915292529352945295529652975298529953005301530253035304530553065307530853095310531153125313531453155316531753185319532053215322532353245325532653275328532953305331533253335334533553365337533853395340534153425343534453455346534753485349535053515352535353545355535653575358535953605361536253635364536553665367536853695370537153725373537453755376537753785379538053815382538353845385538653875388538953905391539253935394539553965397539853995400540154025403540454055406540754085409541054115412541354145415541654175418541954205421542254235424542554265427542854295430543154325433543454355436543754385439544054415442544354445445544654475448544954505451545254535454545554565457545854595460546154625463546454655466546754685469547054715472547354745475547654775478547954805481548254835484548554865487548854895490549154925493549454955496549754985499550055015502550355045505550655075508550955105511551255135514551555165517551855195520552155225523552455255526552755285529553055315532553355345535553655375538553955405541554255435544554555465547554855495550555155525553555455555556555755585559556055615562556355645565556655675568556955705571557255735574557555765577557855795580558155825583558455855586558755885589559055915592559355945595559655975598559956005601560256035604560556065607560856095610561156125613561456155616561756185619562056215622562356245625562656275628562956305631563256335634563556365637563856395640564156425643564456455646564756485649565056515652565356545655565656575658565956605661566256635664566556665667566856695670567156725673567456755676567756785679568056815682568356845685568656875688568956905691569256935694569556965697569856995700570157025703570457055706570757085709571057115712571357145715571657175718571957205721572257235724572557265727572857295730573157325733573457355736573757385739574057415742574357445745574657475748574957505751575257535754575557565757575857595760576157625763576457655766576757685769577057715772577357745775577657775778577957805781578257835784578557865787
  1. package http
  2. import (
  3. "bytes"
  4. "context"
  5. "encoding/json"
  6. "errors"
  7. "fmt"
  8. "io"
  9. "log/slog"
  10. "math"
  11. "net/http"
  12. "net/http/httptest"
  13. "net/mail"
  14. "net/netip"
  15. "strings"
  16. "testing"
  17. "time"
  18. "github.com/stretchr/testify/assert"
  19. "github.com/stretchr/testify/mock"
  20. "github.com/mk6i/open-oscar-server/config"
  21. "github.com/mk6i/open-oscar-server/state"
  22. "github.com/mk6i/open-oscar-server/wire"
  23. )
  24. func TestSessionHandler_GET(t *testing.T) {
  25. // Fixed time for testing: 2024-01-01 12:00:00 UTC
  26. fixedNow := time.Date(2024, 1, 1, 12, 0, 0, 0, time.UTC)
  27. nowFn := func() time.Time { return fixedNow }
  28. tt := []struct {
  29. name string
  30. want string
  31. statusCode int
  32. createSessions func() []*state.Session
  33. }{
  34. {
  35. name: "without sessions",
  36. want: `{"count":0,"sessions":[]}`,
  37. statusCode: http.StatusOK,
  38. createSessions: func() []*state.Session {
  39. return []*state.Session{}
  40. },
  41. },
  42. {
  43. name: "with sessions",
  44. want: `{"count":3,"sessions":[{"id":"usera","screen_name":"userA","online_seconds":100,"is_away":false,"away_message":"","idle_seconds":0,"is_invisible":false,"is_icq":false,"instance_count":2,"instances":[{"num":1,"idle_seconds":30,"is_away":false,"away_message":"","is_invisible":false,"remote_addr":"1.2.3.4","remote_port":1234},{"num":2,"idle_seconds":0,"is_away":false,"away_message":"","is_invisible":true,"remote_addr":"5.6.7.8","remote_port":5678}]},{"id":"userb","screen_name":"userB","online_seconds":200,"is_away":false,"away_message":"","idle_seconds":0,"is_invisible":true,"is_icq":false,"instance_count":2,"instances":[{"num":1,"idle_seconds":0,"is_away":false,"away_message":"","is_invisible":true,"remote_addr":"9.10.11.12","remote_port":9012},{"num":2,"idle_seconds":0,"is_away":false,"away_message":"","is_invisible":true,"remote_addr":"13.14.15.16","remote_port":1314}]},{"id":"100003","screen_name":"100003","online_seconds":300,"is_away":false,"away_message":"","idle_seconds":0,"is_invisible":false,"is_icq":true,"instance_count":1,"instances":[{"num":1,"idle_seconds":0,"is_away":false,"away_message":"","is_invisible":false,"remote_addr":"1.2.3.4","remote_port":1234}]}]}`,
  45. statusCode: http.StatusOK,
  46. createSessions: func() []*state.Session {
  47. // userA: 2 instances - one idle (30s), one invisible
  48. userA := state.NewSession()
  49. userA.SetIdentScreenName(state.NewIdentScreenName("userA"))
  50. userA.SetDisplayScreenName(state.DisplayScreenName("userA"))
  51. userA.SetUIN(0)
  52. userA.SetNowFn(nowFn)
  53. userA.SetSignonTime(fixedNow.Add(-100 * time.Second))
  54. inst1 := userA.AddInstance()
  55. inst1.SetSignonComplete()
  56. inst1.SetIdle(30 * time.Second)
  57. ip1, _ := netip.ParseAddrPort("1.2.3.4:1234")
  58. inst1.SetRemoteAddr(&ip1)
  59. inst2 := userA.AddInstance()
  60. inst2.SetSignonComplete()
  61. inst2.SetUserStatusBitmask(wire.OServiceUserStatusInvisible)
  62. ip2, _ := netip.ParseAddrPort("5.6.7.8:5678")
  63. inst2.SetRemoteAddr(&ip2)
  64. // userB: 2 instances - both invisible
  65. userB := state.NewSession()
  66. userB.SetIdentScreenName(state.NewIdentScreenName("userB"))
  67. userB.SetDisplayScreenName(state.DisplayScreenName("userB"))
  68. userB.SetUIN(0)
  69. userB.SetNowFn(nowFn)
  70. userB.SetSignonTime(fixedNow.Add(-200 * time.Second))
  71. inst3 := userB.AddInstance()
  72. inst3.SetSignonComplete()
  73. inst3.SetUserStatusBitmask(wire.OServiceUserStatusInvisible)
  74. ip3, _ := netip.ParseAddrPort("9.10.11.12:9012")
  75. inst3.SetRemoteAddr(&ip3)
  76. inst4 := userB.AddInstance()
  77. inst4.SetSignonComplete()
  78. inst4.SetUserStatusBitmask(wire.OServiceUserStatusInvisible)
  79. ip4, _ := netip.ParseAddrPort("13.14.15.16:1314")
  80. inst4.SetRemoteAddr(&ip4)
  81. // 100003: 1 instance - normal
  82. icqUser := state.NewSession()
  83. icqUser.SetIdentScreenName(state.NewIdentScreenName("100003"))
  84. icqUser.SetDisplayScreenName(state.DisplayScreenName("100003"))
  85. icqUser.SetUIN(100003)
  86. icqUser.SetNowFn(nowFn)
  87. icqUser.SetSignonTime(fixedNow.Add(-300 * time.Second))
  88. inst5 := icqUser.AddInstance()
  89. inst5.SetSignonComplete()
  90. ip5, _ := netip.ParseAddrPort("1.2.3.4:1234")
  91. inst5.SetRemoteAddr(&ip5)
  92. return []*state.Session{userA, userB, icqUser}
  93. },
  94. },
  95. {
  96. name: "with away sessions",
  97. want: `{"count":2,"sessions":[{"id":"usera","screen_name":"userA","online_seconds":100,"is_away":false,"away_message":"","idle_seconds":0,"is_invisible":false,"is_icq":false,"instance_count":2,"instances":[{"num":1,"idle_seconds":0,"is_away":true,"away_message":"Away message 1","is_invisible":false,"remote_addr":"1.2.3.4","remote_port":1234},{"num":2,"idle_seconds":0,"is_away":false,"away_message":"","is_invisible":false,"remote_addr":"5.6.7.8","remote_port":5678}]},{"id":"userb","screen_name":"userB","online_seconds":200,"is_away":true,"away_message":"Away message 2","idle_seconds":0,"is_invisible":false,"is_icq":false,"instance_count":2,"instances":[{"num":1,"idle_seconds":0,"is_away":true,"away_message":"Away message 2","is_invisible":false,"remote_addr":"9.10.11.12","remote_port":9012},{"num":2,"idle_seconds":0,"is_away":true,"away_message":"Away message 2","is_invisible":false,"remote_addr":"13.14.15.16","remote_port":1314}]}]}`,
  98. statusCode: http.StatusOK,
  99. createSessions: func() []*state.Session {
  100. // userA: 2 instances - one away, one not away (away_message should be "")
  101. userA := state.NewSession()
  102. userA.SetIdentScreenName(state.NewIdentScreenName("userA"))
  103. userA.SetDisplayScreenName(state.DisplayScreenName("userA"))
  104. userA.SetUIN(0)
  105. userA.SetNowFn(nowFn)
  106. userA.SetSignonTime(fixedNow.Add(-100 * time.Second))
  107. inst1 := userA.AddInstance()
  108. inst1.SetSignonComplete()
  109. inst1.SetUserStatusBitmask(wire.OServiceUserStatusAway)
  110. inst1.SetAwayMessage("Away message 1")
  111. ip1, _ := netip.ParseAddrPort("1.2.3.4:1234")
  112. inst1.SetRemoteAddr(&ip1)
  113. inst2 := userA.AddInstance()
  114. inst2.SetSignonComplete()
  115. ip2, _ := netip.ParseAddrPort("5.6.7.8:5678")
  116. inst2.SetRemoteAddr(&ip2)
  117. // userB: 2 instances - both away (away_message should be populated)
  118. userB := state.NewSession()
  119. userB.SetIdentScreenName(state.NewIdentScreenName("userB"))
  120. userB.SetDisplayScreenName(state.DisplayScreenName("userB"))
  121. userB.SetUIN(0)
  122. userB.SetNowFn(nowFn)
  123. userB.SetSignonTime(fixedNow.Add(-200 * time.Second))
  124. inst3 := userB.AddInstance()
  125. inst3.SetSignonComplete()
  126. inst3.SetUserStatusBitmask(wire.OServiceUserStatusAway)
  127. inst3.SetAwayMessage("Away message 2")
  128. ip3, _ := netip.ParseAddrPort("9.10.11.12:9012")
  129. inst3.SetRemoteAddr(&ip3)
  130. inst4 := userB.AddInstance()
  131. inst4.SetSignonComplete()
  132. inst4.SetUserStatusBitmask(wire.OServiceUserStatusAway)
  133. inst4.SetAwayMessage("Away message 2")
  134. ip4, _ := netip.ParseAddrPort("13.14.15.16:1314")
  135. inst4.SetRemoteAddr(&ip4)
  136. return []*state.Session{userA, userB}
  137. },
  138. },
  139. }
  140. for _, tc := range tt {
  141. t.Run(tc.name, func(t *testing.T) {
  142. request := httptest.NewRequest(http.MethodGet, "/session", nil)
  143. responseRecorder := httptest.NewRecorder()
  144. sessionRetriever := newMockSessionRetriever(t)
  145. sessions := tc.createSessions()
  146. sessionRetriever.EXPECT().
  147. AllSessions().
  148. Return(sessions)
  149. getSessionHandler(responseRecorder, request, sessionRetriever, nowFn)
  150. if responseRecorder.Code != tc.statusCode {
  151. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  152. }
  153. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  154. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  155. }
  156. })
  157. }
  158. }
  159. func TestSessionHandlerScreenname_GET(t *testing.T) {
  160. // Fixed time for testing: 2024-01-01 12:00:00 UTC
  161. fixedNow := time.Date(2024, 1, 1, 12, 0, 0, 0, time.UTC)
  162. nowFn := func() time.Time { return fixedNow }
  163. tt := []struct {
  164. name string
  165. requestScreenName state.IdentScreenName
  166. want string
  167. statusCode int
  168. createSession func() *state.Session
  169. }{
  170. {
  171. name: "no session for screenname",
  172. requestScreenName: state.NewIdentScreenName("userA"),
  173. want: `session not found`,
  174. statusCode: http.StatusNotFound,
  175. createSession: func() *state.Session {
  176. return nil
  177. },
  178. },
  179. {
  180. name: "active session found for screenname",
  181. requestScreenName: state.NewIdentScreenName("userA"),
  182. want: `{"count":1,"sessions":[{"id":"usera","screen_name":"userA","online_seconds":150,"is_away":false,"away_message":"","idle_seconds":0,"is_invisible":false,"is_icq":false,"instance_count":1,"instances":[{"num":1,"idle_seconds":0,"is_away":false,"away_message":"","is_invisible":false,"remote_addr":"1.2.3.4","remote_port":1234}]}]}`,
  183. statusCode: http.StatusOK,
  184. createSession: func() *state.Session {
  185. sess := state.NewSession()
  186. sess.SetIdentScreenName(state.NewIdentScreenName("userA"))
  187. sess.SetDisplayScreenName(state.DisplayScreenName("userA"))
  188. sess.SetUIN(0)
  189. sess.SetNowFn(nowFn)
  190. sess.SetSignonTime(fixedNow.Add(-150 * time.Second))
  191. instance := sess.AddInstance()
  192. instance.SetSignonComplete()
  193. ip, _ := netip.ParseAddrPort("1.2.3.4:1234")
  194. instance.SetRemoteAddr(&ip)
  195. return sess
  196. },
  197. },
  198. }
  199. for _, tc := range tt {
  200. t.Run(tc.name, func(t *testing.T) {
  201. request := httptest.NewRequest(http.MethodGet, "/session/"+tc.requestScreenName.String(), nil)
  202. request.SetPathValue("screenname", tc.requestScreenName.String())
  203. responseRecorder := httptest.NewRecorder()
  204. sessionRetriever := newMockSessionRetriever(t)
  205. session := tc.createSession()
  206. sessionRetriever.EXPECT().
  207. RetrieveSession(tc.requestScreenName).
  208. Return(session)
  209. getSessionHandler(responseRecorder, request, sessionRetriever, nowFn)
  210. if responseRecorder.Code != tc.statusCode {
  211. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  212. }
  213. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  214. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  215. }
  216. })
  217. }
  218. }
  219. func TestSessionHandlerScreenname_DELETE(t *testing.T) {
  220. fnNewSess := func(screenName string) *state.Session {
  221. sess := state.NewSession()
  222. sess.SetIdentScreenName(state.NewIdentScreenName(screenName))
  223. sess.SetDisplayScreenName(state.DisplayScreenName(screenName))
  224. instance := sess.AddInstance()
  225. instance.SetSignonComplete()
  226. ip, _ := netip.ParseAddrPort("1.2.3.4:1234")
  227. instance.SetRemoteAddr(&ip)
  228. return sess
  229. }
  230. tt := []struct {
  231. name string
  232. session *state.SessionInstance
  233. requestScreenName state.IdentScreenName
  234. statusCode int
  235. mockParams mockParams
  236. }{
  237. {
  238. name: "delete an active session",
  239. requestScreenName: state.NewIdentScreenName("userA"),
  240. statusCode: http.StatusNoContent,
  241. mockParams: mockParams{
  242. sessionRetrieverParams: sessionRetrieverParams{
  243. retrieveSessionByNameParams: retrieveSessionByNameParams{
  244. {
  245. screenName: state.NewIdentScreenName("userA"),
  246. result: fnNewSess("userA"),
  247. },
  248. },
  249. },
  250. },
  251. },
  252. {
  253. name: "delete a non-existent session",
  254. requestScreenName: state.NewIdentScreenName("userA"),
  255. statusCode: http.StatusNotFound,
  256. mockParams: mockParams{
  257. sessionRetrieverParams: sessionRetrieverParams{
  258. retrieveSessionByNameParams: retrieveSessionByNameParams{
  259. {
  260. screenName: state.NewIdentScreenName("userA"),
  261. result: nil,
  262. },
  263. },
  264. },
  265. },
  266. },
  267. }
  268. for _, tc := range tt {
  269. t.Run(tc.name, func(t *testing.T) {
  270. request := httptest.NewRequest(http.MethodDelete, "/session/"+tc.requestScreenName.String(), nil)
  271. request.SetPathValue("screenname", tc.requestScreenName.String())
  272. responseRecorder := httptest.NewRecorder()
  273. sessionRetriever := newMockSessionRetriever(t)
  274. for _, params := range tc.mockParams.retrieveSessionByNameParams {
  275. sessionRetriever.EXPECT().
  276. RetrieveSession(params.screenName).
  277. Return(params.result)
  278. }
  279. deleteSessionHandler(responseRecorder, request, sessionRetriever)
  280. if responseRecorder.Code != tc.statusCode {
  281. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  282. }
  283. })
  284. }
  285. }
  286. func TestUserAccountHandler_GET(t *testing.T) {
  287. tt := []struct {
  288. name string
  289. requestScreenName state.IdentScreenName
  290. want string
  291. statusCode int
  292. mockParams mockParams
  293. }{
  294. {
  295. name: "invalid account",
  296. requestScreenName: state.NewIdentScreenName("userA"),
  297. want: `user not found`,
  298. statusCode: http.StatusNotFound,
  299. mockParams: mockParams{
  300. userManagerParams: userManagerParams{
  301. getUserParams: getUserParams{
  302. {
  303. screenName: state.NewIdentScreenName("userA"),
  304. result: nil,
  305. },
  306. },
  307. },
  308. },
  309. },
  310. {
  311. name: "valid aim account",
  312. requestScreenName: state.NewIdentScreenName("userA"),
  313. want: `{"id":"usera","screen_name":"userA","profile":"My Profile Text","email_address":"\u003cuserA@aol.com\u003e","reg_status":2,"confirmed":true,"is_icq":false,"suspended_status":"","is_bot":false}`,
  314. statusCode: http.StatusOK,
  315. mockParams: mockParams{
  316. userManagerParams: userManagerParams{
  317. getUserParams: getUserParams{
  318. {
  319. screenName: state.NewIdentScreenName("userA"),
  320. result: &state.User{
  321. DisplayScreenName: "userA",
  322. IdentScreenName: state.NewIdentScreenName("userA"),
  323. SuspendedStatus: 0x0,
  324. },
  325. },
  326. },
  327. },
  328. accountManagerParams: accountManagerParams{
  329. EmailAddressParams: EmailAddressParams{
  330. {
  331. screenName: state.NewIdentScreenName("userA"),
  332. result: &mail.Address{
  333. Address: "userA@aol.com",
  334. },
  335. },
  336. },
  337. RegStatusParams: RegStatusParams{
  338. {
  339. screenName: state.NewIdentScreenName("userA"),
  340. result: uint16(0x02),
  341. },
  342. },
  343. ConfirmStatusParams: ConfirmStatusParams{
  344. {
  345. screenName: state.NewIdentScreenName("userA"),
  346. result: true,
  347. },
  348. },
  349. },
  350. profileRetrieverParams: profileRetrieverParams{
  351. retrieveProfileParams: retrieveProfileParams{
  352. {
  353. screenName: state.NewIdentScreenName("userA"),
  354. result: state.UserProfile{ProfileText: "My Profile Text"},
  355. },
  356. },
  357. },
  358. },
  359. },
  360. {
  361. name: "valid aim bot account",
  362. requestScreenName: state.NewIdentScreenName("userA"),
  363. want: `{"id":"usera","screen_name":"userA","profile":"My Profile Text","email_address":"\u003cuserA@aol.com\u003e","reg_status":2,"confirmed":true,"is_icq":false,"suspended_status":"","is_bot":true}`,
  364. statusCode: http.StatusOK,
  365. mockParams: mockParams{
  366. userManagerParams: userManagerParams{
  367. getUserParams: getUserParams{
  368. {
  369. screenName: state.NewIdentScreenName("userA"),
  370. result: &state.User{
  371. DisplayScreenName: "userA",
  372. IdentScreenName: state.NewIdentScreenName("userA"),
  373. SuspendedStatus: 0x0,
  374. IsBot: true,
  375. },
  376. },
  377. },
  378. },
  379. accountManagerParams: accountManagerParams{
  380. EmailAddressParams: EmailAddressParams{
  381. {
  382. screenName: state.NewIdentScreenName("userA"),
  383. result: &mail.Address{
  384. Address: "userA@aol.com",
  385. },
  386. },
  387. },
  388. RegStatusParams: RegStatusParams{
  389. {
  390. screenName: state.NewIdentScreenName("userA"),
  391. result: uint16(0x02),
  392. },
  393. },
  394. ConfirmStatusParams: ConfirmStatusParams{
  395. {
  396. screenName: state.NewIdentScreenName("userA"),
  397. result: true,
  398. },
  399. },
  400. },
  401. profileRetrieverParams: profileRetrieverParams{
  402. retrieveProfileParams: retrieveProfileParams{
  403. {
  404. screenName: state.NewIdentScreenName("userA"),
  405. result: state.UserProfile{ProfileText: "My Profile Text"},
  406. },
  407. },
  408. },
  409. },
  410. },
  411. {
  412. name: "suspended aim account",
  413. requestScreenName: state.NewIdentScreenName("userB"),
  414. want: `{"id":"userb","screen_name":"userB","profile":"My Profile Text","email_address":"\u003cuserB@aol.com\u003e","reg_status":2,"confirmed":true,"is_icq":false,"suspended_status":"suspended","is_bot":false}`,
  415. statusCode: http.StatusOK,
  416. mockParams: mockParams{
  417. userManagerParams: userManagerParams{
  418. getUserParams: getUserParams{
  419. {
  420. screenName: state.NewIdentScreenName("userB"),
  421. result: &state.User{
  422. DisplayScreenName: "userB",
  423. IdentScreenName: state.NewIdentScreenName("userB"),
  424. SuspendedStatus: wire.LoginErrSuspendedAccount,
  425. },
  426. },
  427. },
  428. },
  429. accountManagerParams: accountManagerParams{
  430. EmailAddressParams: EmailAddressParams{
  431. {
  432. screenName: state.NewIdentScreenName("userB"),
  433. result: &mail.Address{
  434. Address: "userB@aol.com",
  435. },
  436. },
  437. },
  438. RegStatusParams: RegStatusParams{
  439. {
  440. screenName: state.NewIdentScreenName("userB"),
  441. result: uint16(0x02),
  442. },
  443. },
  444. ConfirmStatusParams: ConfirmStatusParams{
  445. {
  446. screenName: state.NewIdentScreenName("userB"),
  447. result: true,
  448. },
  449. },
  450. },
  451. profileRetrieverParams: profileRetrieverParams{
  452. retrieveProfileParams: retrieveProfileParams{
  453. {
  454. screenName: state.NewIdentScreenName("userB"),
  455. result: state.UserProfile{ProfileText: "My Profile Text"},
  456. },
  457. },
  458. },
  459. },
  460. },
  461. }
  462. for _, tc := range tt {
  463. t.Run(tc.name, func(t *testing.T) {
  464. request := httptest.NewRequest(http.MethodGet, "/user/"+tc.requestScreenName.String()+"/account", nil)
  465. request.SetPathValue("screenname", tc.requestScreenName.String())
  466. responseRecorder := httptest.NewRecorder()
  467. userManager := newMockUserManager(t)
  468. for _, params := range tc.mockParams.getUserParams {
  469. userManager.EXPECT().
  470. User(matchContext(), params.screenName).
  471. Return(params.result, params.err)
  472. }
  473. accountManager := newMockAccountManager(t)
  474. for _, params := range tc.mockParams.EmailAddressParams {
  475. accountManager.EXPECT().
  476. EmailAddress(matchContext(), params.screenName).
  477. Return(params.result, params.err)
  478. }
  479. for _, params := range tc.mockParams.RegStatusParams {
  480. accountManager.EXPECT().
  481. RegStatus(matchContext(), params.screenName).
  482. Return(params.result, params.err)
  483. }
  484. for _, params := range tc.mockParams.ConfirmStatusParams {
  485. accountManager.EXPECT().
  486. ConfirmStatus(matchContext(), params.screenName).
  487. Return(params.result, params.err)
  488. }
  489. profileRetriever := newMockProfileRetriever(t)
  490. for _, params := range tc.mockParams.retrieveProfileParams {
  491. profileRetriever.EXPECT().
  492. Profile(matchContext(), params.screenName).
  493. Return(params.result, params.err)
  494. }
  495. getUserAccountHandler(responseRecorder, request, userManager, accountManager, profileRetriever, slog.Default())
  496. if responseRecorder.Code != tc.statusCode {
  497. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  498. }
  499. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  500. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  501. }
  502. })
  503. }
  504. }
  505. func TestUserAccountHandler_PATCH(t *testing.T) {
  506. tt := []struct {
  507. name string
  508. requestScreenName state.IdentScreenName
  509. want string
  510. body string
  511. statusCode int
  512. mockParams mockParams
  513. }{
  514. {
  515. name: "suspending a non-existent account",
  516. requestScreenName: state.NewIdentScreenName("userA"),
  517. body: `{"suspended_status":"suspended"}`,
  518. want: `user not found`,
  519. statusCode: http.StatusNotFound,
  520. mockParams: mockParams{
  521. userManagerParams: userManagerParams{
  522. getUserParams: getUserParams{
  523. {
  524. screenName: state.NewIdentScreenName("userA"),
  525. result: nil,
  526. },
  527. },
  528. },
  529. },
  530. },
  531. {
  532. name: "patching with invalid suspended_status value",
  533. requestScreenName: state.NewIdentScreenName("userA"),
  534. body: `{"suspended_status":"thisisinvalid"}`,
  535. want: `{"message":"suspended_status must be empty str or one of deleted,expired,suspended,suspended_age"}`,
  536. statusCode: http.StatusBadRequest,
  537. mockParams: mockParams{
  538. userManagerParams: userManagerParams{
  539. getUserParams: getUserParams{
  540. {
  541. screenName: state.NewIdentScreenName("userA"),
  542. result: &state.User{},
  543. },
  544. },
  545. },
  546. },
  547. },
  548. {
  549. name: "suspending an active aim account",
  550. requestScreenName: state.NewIdentScreenName("userA"),
  551. statusCode: http.StatusNoContent,
  552. body: `{"suspended_status":"suspended"}`,
  553. mockParams: mockParams{
  554. userManagerParams: userManagerParams{
  555. getUserParams: getUserParams{
  556. {
  557. screenName: state.NewIdentScreenName("userA"),
  558. result: &state.User{
  559. DisplayScreenName: "userA",
  560. IdentScreenName: state.NewIdentScreenName("userA"),
  561. SuspendedStatus: 0x0,
  562. },
  563. },
  564. },
  565. },
  566. accountManagerParams: accountManagerParams{
  567. updateSuspendedStatusParams: updateSuspendedStatusParams{
  568. {
  569. suspendedStatus: wire.LoginErrSuspendedAccount,
  570. screenName: state.NewIdentScreenName("userA"),
  571. err: nil,
  572. },
  573. },
  574. },
  575. },
  576. },
  577. {
  578. name: "unsuspending a suspended aim account",
  579. requestScreenName: state.NewIdentScreenName("userA"),
  580. statusCode: http.StatusNoContent,
  581. body: `{"suspended_status":""}`,
  582. mockParams: mockParams{
  583. userManagerParams: userManagerParams{
  584. getUserParams: getUserParams{
  585. {
  586. screenName: state.NewIdentScreenName("userA"),
  587. result: &state.User{
  588. DisplayScreenName: "userA",
  589. IdentScreenName: state.NewIdentScreenName("userA"),
  590. SuspendedStatus: wire.LoginErrSuspendedAccount,
  591. },
  592. },
  593. },
  594. },
  595. accountManagerParams: accountManagerParams{
  596. updateSuspendedStatusParams: updateSuspendedStatusParams{
  597. {
  598. suspendedStatus: 0x0,
  599. screenName: state.NewIdentScreenName("userA"),
  600. err: nil,
  601. },
  602. },
  603. },
  604. },
  605. },
  606. {
  607. name: "suspending an already suspended aim account",
  608. requestScreenName: state.NewIdentScreenName("userA"),
  609. statusCode: http.StatusNotModified,
  610. body: `{"suspended_status":"suspended"}`,
  611. mockParams: mockParams{
  612. userManagerParams: userManagerParams{
  613. getUserParams: getUserParams{
  614. {
  615. screenName: state.NewIdentScreenName("userA"),
  616. result: &state.User{
  617. DisplayScreenName: "userA",
  618. IdentScreenName: state.NewIdentScreenName("userA"),
  619. SuspendedStatus: wire.LoginErrSuspendedAccount,
  620. },
  621. },
  622. },
  623. },
  624. },
  625. },
  626. {
  627. name: "setting bot flag (before: false, after: true)",
  628. requestScreenName: state.NewIdentScreenName("userA"),
  629. statusCode: http.StatusNoContent,
  630. body: `{"is_bot":true}`,
  631. mockParams: mockParams{
  632. userManagerParams: userManagerParams{
  633. getUserParams: getUserParams{
  634. {
  635. screenName: state.NewIdentScreenName("userA"),
  636. result: &state.User{
  637. DisplayScreenName: "userA",
  638. IdentScreenName: state.NewIdentScreenName("userA"),
  639. SuspendedStatus: 0x0,
  640. IsBot: false,
  641. },
  642. },
  643. },
  644. },
  645. accountManagerParams: accountManagerParams{
  646. setBotStatusParams: setBotStatusParams{
  647. {
  648. isBot: true,
  649. screenName: state.NewIdentScreenName("userA"),
  650. err: nil,
  651. },
  652. },
  653. },
  654. },
  655. },
  656. {
  657. name: "setting bot flag (before: true, after: false)",
  658. requestScreenName: state.NewIdentScreenName("userA"),
  659. statusCode: http.StatusNoContent,
  660. body: `{"is_bot":false}`,
  661. mockParams: mockParams{
  662. userManagerParams: userManagerParams{
  663. getUserParams: getUserParams{
  664. {
  665. screenName: state.NewIdentScreenName("userA"),
  666. result: &state.User{
  667. DisplayScreenName: "userA",
  668. IdentScreenName: state.NewIdentScreenName("userA"),
  669. SuspendedStatus: 0x0,
  670. IsBot: true,
  671. },
  672. },
  673. },
  674. },
  675. accountManagerParams: accountManagerParams{
  676. setBotStatusParams: setBotStatusParams{
  677. {
  678. isBot: false,
  679. screenName: state.NewIdentScreenName("userA"),
  680. err: nil,
  681. },
  682. },
  683. },
  684. },
  685. },
  686. {
  687. name: "setting bot flag (before: true, after: true)",
  688. requestScreenName: state.NewIdentScreenName("userA"),
  689. statusCode: http.StatusNotModified,
  690. body: `{"is_bot":true}`,
  691. mockParams: mockParams{
  692. userManagerParams: userManagerParams{
  693. getUserParams: getUserParams{
  694. {
  695. screenName: state.NewIdentScreenName("userA"),
  696. result: &state.User{
  697. DisplayScreenName: "userA",
  698. IdentScreenName: state.NewIdentScreenName("userA"),
  699. SuspendedStatus: 0x0,
  700. IsBot: true,
  701. },
  702. },
  703. },
  704. },
  705. },
  706. },
  707. }
  708. for _, tc := range tt {
  709. t.Run(tc.name, func(t *testing.T) {
  710. request := httptest.NewRequest(http.MethodPatch, "/user/"+tc.requestScreenName.String()+"/account", strings.NewReader(tc.body))
  711. request.SetPathValue("screenname", tc.requestScreenName.String())
  712. responseRecorder := httptest.NewRecorder()
  713. userManager := newMockUserManager(t)
  714. for _, params := range tc.mockParams.getUserParams {
  715. userManager.EXPECT().
  716. User(matchContext(), params.screenName).
  717. Return(params.result, params.err)
  718. }
  719. accountManager := newMockAccountManager(t)
  720. for _, params := range tc.mockParams.updateSuspendedStatusParams {
  721. accountManager.EXPECT().
  722. UpdateSuspendedStatus(matchContext(), params.suspendedStatus, params.screenName).
  723. Return(params.err)
  724. }
  725. for _, params := range tc.mockParams.setBotStatusParams {
  726. accountManager.EXPECT().
  727. SetBotStatus(matchContext(), params.isBot, params.screenName).
  728. Return(params.err)
  729. }
  730. patchUserAccountHandler(responseRecorder, request, userManager, accountManager, slog.Default())
  731. if responseRecorder.Code != tc.statusCode {
  732. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  733. }
  734. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  735. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  736. }
  737. })
  738. }
  739. }
  740. func TestUserBuddyIconHandler_GET(t *testing.T) {
  741. sampleGIF := []byte{
  742. 0x47, 0x49, 0x46, 0x38, 0x39, 0x61, 0x32, 0x00, 0x32, 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
  743. 0x00, 0x00, 0x00, 0x21, 0xf9, 0x04, 0x01, 0x00, 0x00, 0x00, 0x00, 0x2c, 0x00, 0x00, 0x00, 0x00,
  744. 0x32, 0x00, 0x32, 0x00, 0x00, 0x02, 0x02, 0x44, 0x01, 0x00, 0x3b}
  745. sampleJPG := []byte{0xFF, 0xD8, 0xFF, 0x43, 0x13, 0x37}
  746. tt := []struct {
  747. name string
  748. requestScreenName state.IdentScreenName
  749. want string
  750. statusCode int
  751. contentType string
  752. mockParams mockParams
  753. }{
  754. {
  755. name: "invalid account",
  756. requestScreenName: state.NewIdentScreenName("userA"),
  757. want: `user not found`,
  758. statusCode: http.StatusNotFound,
  759. contentType: "text/plain; charset=utf-8",
  760. mockParams: mockParams{
  761. userManagerParams: userManagerParams{
  762. getUserParams: getUserParams{
  763. {
  764. screenName: state.NewIdentScreenName("userA"),
  765. result: nil,
  766. },
  767. },
  768. },
  769. },
  770. },
  771. {
  772. name: "account with gif buddy icon",
  773. requestScreenName: state.NewIdentScreenName("userA"),
  774. want: string(sampleGIF),
  775. statusCode: http.StatusOK,
  776. contentType: "image/gif",
  777. mockParams: mockParams{
  778. userManagerParams: userManagerParams{
  779. getUserParams: getUserParams{
  780. {
  781. screenName: state.NewIdentScreenName("userA"),
  782. result: &state.User{
  783. DisplayScreenName: "userA",
  784. IdentScreenName: state.NewIdentScreenName("userA"),
  785. },
  786. },
  787. },
  788. },
  789. feedBagRetrieverParams: feedBagRetrieverParams{
  790. buddyIconMetadataParams: buddyIconMetadataParams{
  791. {
  792. screenName: state.NewIdentScreenName("userA"),
  793. result: &wire.BARTID{
  794. Type: wire.BARTTypesBuddyIcon,
  795. BARTInfo: wire.BARTInfo{
  796. Flags: 0x00,
  797. Hash: []byte{'t', 'h', 'e', 'h', 'a', 's', 'h'},
  798. },
  799. },
  800. },
  801. },
  802. },
  803. bartAssetManagerParams: bartAssetManagerParams{
  804. bartItemParams: bartItemParams{
  805. {
  806. hash: []byte{'t', 'h', 'e', 'h', 'a', 's', 'h'},
  807. result: sampleGIF,
  808. },
  809. },
  810. },
  811. },
  812. },
  813. {
  814. name: "account with jpg buddy icon",
  815. requestScreenName: state.NewIdentScreenName("userA"),
  816. want: string(sampleJPG),
  817. statusCode: http.StatusOK,
  818. contentType: "image/jpeg",
  819. mockParams: mockParams{
  820. userManagerParams: userManagerParams{
  821. getUserParams: getUserParams{
  822. {
  823. screenName: state.NewIdentScreenName("userA"),
  824. result: &state.User{
  825. DisplayScreenName: "userA",
  826. IdentScreenName: state.NewIdentScreenName("userA"),
  827. },
  828. },
  829. },
  830. },
  831. feedBagRetrieverParams: feedBagRetrieverParams{
  832. buddyIconMetadataParams: buddyIconMetadataParams{
  833. {
  834. screenName: state.NewIdentScreenName("userA"),
  835. result: &wire.BARTID{
  836. Type: wire.BARTTypesBuddyIcon,
  837. BARTInfo: wire.BARTInfo{
  838. Flags: 0x00,
  839. Hash: []byte{'t', 'h', 'e', 'h', 'a', 's', 'h'},
  840. },
  841. },
  842. },
  843. },
  844. },
  845. bartAssetManagerParams: bartAssetManagerParams{
  846. bartItemParams: bartItemParams{
  847. {
  848. hash: []byte{'t', 'h', 'e', 'h', 'a', 's', 'h'},
  849. result: sampleJPG,
  850. },
  851. },
  852. },
  853. },
  854. },
  855. {
  856. name: "account with unknown format buddy icon",
  857. requestScreenName: state.NewIdentScreenName("userA"),
  858. want: string([]byte{0x13, 0x37, 0x13, 0x37, 0x13, 0x37}),
  859. statusCode: http.StatusOK,
  860. contentType: "application/octet-stream",
  861. mockParams: mockParams{
  862. userManagerParams: userManagerParams{
  863. getUserParams: getUserParams{
  864. {
  865. screenName: state.NewIdentScreenName("userA"),
  866. result: &state.User{
  867. DisplayScreenName: "userA",
  868. IdentScreenName: state.NewIdentScreenName("userA"),
  869. },
  870. },
  871. },
  872. },
  873. feedBagRetrieverParams: feedBagRetrieverParams{
  874. buddyIconMetadataParams: buddyIconMetadataParams{
  875. {
  876. screenName: state.NewIdentScreenName("userA"),
  877. result: &wire.BARTID{
  878. Type: wire.BARTTypesBuddyIcon,
  879. BARTInfo: wire.BARTInfo{
  880. Flags: 0x00,
  881. Hash: []byte{'t', 'h', 'e', 'h', 'a', 's', 'h'},
  882. },
  883. },
  884. },
  885. },
  886. },
  887. bartAssetManagerParams: bartAssetManagerParams{
  888. bartItemParams: bartItemParams{
  889. {
  890. hash: []byte{'t', 'h', 'e', 'h', 'a', 's', 'h'},
  891. result: []byte{0x13, 0x37, 0x13, 0x37, 0x13, 0x37},
  892. },
  893. },
  894. },
  895. },
  896. },
  897. {
  898. name: "account with cleared buddy icon",
  899. requestScreenName: state.NewIdentScreenName("userA"),
  900. want: "icon not found",
  901. statusCode: http.StatusNotFound,
  902. contentType: "text/plain; charset=utf-8",
  903. mockParams: mockParams{
  904. userManagerParams: userManagerParams{
  905. getUserParams: getUserParams{
  906. {
  907. screenName: state.NewIdentScreenName("userA"),
  908. result: &state.User{
  909. DisplayScreenName: "userA",
  910. IdentScreenName: state.NewIdentScreenName("userA"),
  911. },
  912. },
  913. },
  914. },
  915. feedBagRetrieverParams: feedBagRetrieverParams{
  916. buddyIconMetadataParams: buddyIconMetadataParams{
  917. {
  918. screenName: state.NewIdentScreenName("userA"),
  919. result: &wire.BARTID{
  920. Type: wire.BARTTypesBuddyIcon,
  921. BARTInfo: wire.BARTInfo{
  922. Flags: 0x00,
  923. Hash: wire.GetClearIconHash(),
  924. },
  925. },
  926. },
  927. },
  928. },
  929. },
  930. },
  931. {
  932. name: "account with no buddy icon",
  933. requestScreenName: state.NewIdentScreenName("userA"),
  934. want: "icon not found",
  935. statusCode: http.StatusNotFound,
  936. contentType: "text/plain; charset=utf-8",
  937. mockParams: mockParams{
  938. userManagerParams: userManagerParams{
  939. getUserParams: getUserParams{
  940. {
  941. screenName: state.NewIdentScreenName("userA"),
  942. result: &state.User{
  943. DisplayScreenName: "userA",
  944. IdentScreenName: state.NewIdentScreenName("userA"),
  945. },
  946. },
  947. },
  948. },
  949. feedBagRetrieverParams: feedBagRetrieverParams{
  950. buddyIconMetadataParams: buddyIconMetadataParams{
  951. {
  952. screenName: state.NewIdentScreenName("userA"),
  953. result: nil,
  954. },
  955. },
  956. },
  957. },
  958. },
  959. }
  960. for _, tc := range tt {
  961. t.Run(tc.name, func(t *testing.T) {
  962. request := httptest.NewRequest(http.MethodGet, "/user/"+tc.requestScreenName.String()+"/icon", nil)
  963. request.SetPathValue("screenname", tc.requestScreenName.String())
  964. responseRecorder := httptest.NewRecorder()
  965. userManager := newMockUserManager(t)
  966. for _, params := range tc.mockParams.getUserParams {
  967. userManager.EXPECT().
  968. User(matchContext(), params.screenName).
  969. Return(params.result, params.err)
  970. }
  971. feedbagRetriever := newMockFeedBagRetriever(t)
  972. for _, params := range tc.mockParams.buddyIconMetadataParams {
  973. feedbagRetriever.EXPECT().
  974. BuddyIconMetadata(matchContext(), params.screenName).
  975. Return(params.result, params.err)
  976. }
  977. bartRetriever := newMockBARTAssetManager(t)
  978. for _, params := range tc.mockParams.bartItemParams {
  979. bartRetriever.EXPECT().
  980. BARTItem(matchContext(), params.hash).
  981. Return(params.result, params.err)
  982. }
  983. getUserBuddyIconHandler(responseRecorder, request, userManager, feedbagRetriever, bartRetriever, slog.Default())
  984. if responseRecorder.Code != tc.statusCode {
  985. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  986. }
  987. contentType := responseRecorder.Header().Get("Content-Type")
  988. if contentType != tc.contentType {
  989. t.Errorf("Want content type '%s', got '%s'", tc.contentType, contentType)
  990. }
  991. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  992. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  993. }
  994. })
  995. }
  996. }
  997. func TestUserHandler_GET(t *testing.T) {
  998. tt := []struct {
  999. name string
  1000. want string
  1001. statusCode int
  1002. mockParams mockParams
  1003. }{
  1004. {
  1005. name: "empty user store",
  1006. want: `[]`,
  1007. statusCode: http.StatusOK,
  1008. mockParams: mockParams{
  1009. userManagerParams: userManagerParams{
  1010. allUsersParams: allUsersParams{
  1011. {
  1012. result: []state.User{},
  1013. },
  1014. },
  1015. },
  1016. },
  1017. },
  1018. {
  1019. name: "user store containing 3 users",
  1020. want: `[{"id":"usera","screen_name":"userA","is_icq":false,"suspended_status":"","is_bot":false},{"id":"userb","screen_name":"userB","is_icq":false,"suspended_status":"","is_bot":true},{"id":"100003","screen_name":"100003","is_icq":true,"suspended_status":"","is_bot":false}]`,
  1021. statusCode: http.StatusOK,
  1022. mockParams: mockParams{
  1023. userManagerParams: userManagerParams{
  1024. allUsersParams: allUsersParams{
  1025. {
  1026. result: []state.User{
  1027. {
  1028. DisplayScreenName: "userA",
  1029. IdentScreenName: state.NewIdentScreenName("userA"),
  1030. },
  1031. {
  1032. DisplayScreenName: "userB",
  1033. IdentScreenName: state.NewIdentScreenName("userB"),
  1034. IsBot: true,
  1035. },
  1036. {
  1037. DisplayScreenName: "100003",
  1038. IdentScreenName: state.NewIdentScreenName("100003"),
  1039. IsICQ: true,
  1040. },
  1041. },
  1042. },
  1043. },
  1044. },
  1045. },
  1046. },
  1047. {
  1048. name: "user handler error",
  1049. want: `internal server error`,
  1050. statusCode: http.StatusInternalServerError,
  1051. mockParams: mockParams{
  1052. userManagerParams: userManagerParams{
  1053. allUsersParams: allUsersParams{
  1054. {
  1055. result: []state.User{},
  1056. err: io.EOF,
  1057. },
  1058. },
  1059. },
  1060. },
  1061. },
  1062. }
  1063. for _, tc := range tt {
  1064. t.Run(tc.name, func(t *testing.T) {
  1065. request := httptest.NewRequest(http.MethodGet, "/user", nil)
  1066. responseRecorder := httptest.NewRecorder()
  1067. userManager := newMockUserManager(t)
  1068. for _, params := range tc.mockParams.allUsersParams {
  1069. userManager.EXPECT().
  1070. AllUsers(matchContext()).
  1071. Return(params.result, params.err)
  1072. }
  1073. getUserHandler(responseRecorder, request, userManager, slog.Default())
  1074. if responseRecorder.Code != tc.statusCode {
  1075. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1076. }
  1077. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1078. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  1079. }
  1080. })
  1081. }
  1082. }
  1083. func TestUserHandler_POST(t *testing.T) {
  1084. tt := []struct {
  1085. name string
  1086. body string
  1087. want string
  1088. statusCode int
  1089. createAccount state.CreateAccountFunc
  1090. }{
  1091. {
  1092. name: "with valid AIM user",
  1093. body: `{"screen_name":"userA", "password":"thepassword"}`,
  1094. want: `User account created successfully.`,
  1095. statusCode: http.StatusCreated,
  1096. createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
  1097. assert.Equal(t, state.DisplayScreenName("userA"), screenName)
  1098. assert.Equal(t, "thepassword", password)
  1099. return nil
  1100. },
  1101. },
  1102. {
  1103. name: "with valid ICQ user",
  1104. body: `{"screen_name":"100003", "password":"thepass"}`,
  1105. want: `User account created successfully.`,
  1106. statusCode: http.StatusCreated,
  1107. createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
  1108. assert.Equal(t, state.DisplayScreenName("100003"), screenName)
  1109. assert.Equal(t, "thepass", password)
  1110. return nil
  1111. },
  1112. },
  1113. {
  1114. name: "with malformed body",
  1115. body: `{"screen_name":"userA", "password":"thepassword"`, // missing closing }
  1116. want: `malformed input`,
  1117. statusCode: http.StatusBadRequest,
  1118. },
  1119. {
  1120. name: "user handler error",
  1121. body: `{"screen_name":"userA", "password":"thepassword"}`,
  1122. want: `internal server error`,
  1123. statusCode: http.StatusInternalServerError,
  1124. createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
  1125. assert.Equal(t, state.DisplayScreenName("userA"), screenName)
  1126. assert.Equal(t, "thepassword", password)
  1127. return io.EOF
  1128. },
  1129. },
  1130. {
  1131. name: "duplicate user",
  1132. body: `{"screen_name":"userA", "password":"thepassword"}`,
  1133. want: `user already exists`,
  1134. statusCode: http.StatusConflict,
  1135. createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
  1136. assert.Equal(t, state.DisplayScreenName("userA"), screenName)
  1137. assert.Equal(t, "thepassword", password)
  1138. return state.ErrDupUser
  1139. },
  1140. },
  1141. {
  1142. name: "invalid AIM screen name",
  1143. body: `{"screen_name":"a", "password":"thepassword"}`,
  1144. want: `invalid screen name: screen name must be between 3 and 16 characters`,
  1145. statusCode: http.StatusBadRequest,
  1146. createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
  1147. assert.Equal(t, state.DisplayScreenName("a"), screenName)
  1148. assert.Equal(t, "thepassword", password)
  1149. return state.ErrAIMHandleLength
  1150. },
  1151. },
  1152. {
  1153. name: "invalid AIM password",
  1154. body: `{"screen_name":"userA", "password":"1"}`,
  1155. want: `invalid password: invalid password length: password length must be between 4-16 characters`,
  1156. statusCode: http.StatusBadRequest,
  1157. createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
  1158. assert.Equal(t, state.DisplayScreenName("userA"), screenName)
  1159. assert.Equal(t, "1", password)
  1160. return fmt.Errorf("%w: password length must be between 4-16 characters", state.ErrPasswordInvalid)
  1161. },
  1162. },
  1163. {
  1164. name: "invalid ICQ UIN",
  1165. body: `{"screen_name":"1000", "password":"thepass"}`,
  1166. want: `invalid uin: uin must be a number in the range 10000-2147483646`,
  1167. statusCode: http.StatusBadRequest,
  1168. createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
  1169. assert.Equal(t, state.DisplayScreenName("1000"), screenName)
  1170. assert.Equal(t, "thepass", password)
  1171. return state.ErrICQUINInvalidFormat
  1172. },
  1173. },
  1174. {
  1175. name: "invalid ICQ password",
  1176. body: `{"screen_name":"100003", "password":"thelongpassword"}`,
  1177. want: `invalid password: invalid password length: password must be between 6-8 characters`,
  1178. statusCode: http.StatusBadRequest,
  1179. createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
  1180. assert.Equal(t, state.DisplayScreenName("100003"), screenName)
  1181. assert.Equal(t, "thelongpassword", password)
  1182. return fmt.Errorf("%w: password must be between 6-8 characters", state.ErrPasswordInvalid)
  1183. },
  1184. },
  1185. }
  1186. for _, tc := range tt {
  1187. t.Run(tc.name, func(t *testing.T) {
  1188. request := httptest.NewRequest(http.MethodPost, "/user", strings.NewReader(tc.body))
  1189. responseRecorder := httptest.NewRecorder()
  1190. postUserHandler(responseRecorder, request, tc.createAccount, slog.Default())
  1191. if responseRecorder.Code != tc.statusCode {
  1192. t.Errorf("want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1193. }
  1194. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1195. t.Errorf("want '%s', got '%s'", tc.want, responseRecorder.Body)
  1196. }
  1197. })
  1198. }
  1199. }
  1200. func TestUserHandler_DELETE(t *testing.T) {
  1201. tt := []struct {
  1202. name string
  1203. body string
  1204. want string
  1205. statusCode int
  1206. mockParams mockParams
  1207. }{
  1208. {
  1209. name: "with valid user",
  1210. body: `{"screen_name":"userA"}`,
  1211. want: `User account successfully deleted.`,
  1212. statusCode: http.StatusNoContent,
  1213. mockParams: mockParams{
  1214. userManagerParams: userManagerParams{
  1215. deleteUserParams: deleteUserParams{
  1216. {
  1217. screenName: state.NewIdentScreenName("userA"),
  1218. },
  1219. },
  1220. },
  1221. },
  1222. },
  1223. {
  1224. name: "with non-existent user",
  1225. body: `{"screen_name":"userA"}`,
  1226. want: `user does not exist`,
  1227. statusCode: http.StatusNotFound,
  1228. mockParams: mockParams{
  1229. userManagerParams: userManagerParams{
  1230. deleteUserParams: deleteUserParams{
  1231. {
  1232. screenName: state.NewIdentScreenName("userA"),
  1233. err: state.ErrNoUser,
  1234. },
  1235. },
  1236. },
  1237. },
  1238. },
  1239. {
  1240. name: "with malformed body",
  1241. body: `{"screen_name":"userA"`, // missing closing }
  1242. want: `malformed input`,
  1243. statusCode: http.StatusBadRequest,
  1244. },
  1245. {
  1246. name: "user handler error",
  1247. body: `{"screen_name":"userA"}`,
  1248. want: `internal server error`,
  1249. statusCode: http.StatusInternalServerError,
  1250. mockParams: mockParams{
  1251. userManagerParams: userManagerParams{
  1252. deleteUserParams: deleteUserParams{
  1253. {
  1254. screenName: state.NewIdentScreenName("userA"),
  1255. err: io.EOF,
  1256. },
  1257. },
  1258. },
  1259. },
  1260. },
  1261. }
  1262. for _, tc := range tt {
  1263. t.Run(tc.name, func(t *testing.T) {
  1264. request := httptest.NewRequest(http.MethodDelete, "/user", strings.NewReader(tc.body))
  1265. responseRecorder := httptest.NewRecorder()
  1266. userManager := newMockUserManager(t)
  1267. for _, params := range tc.mockParams.deleteUserParams {
  1268. userManager.EXPECT().
  1269. DeleteUser(matchContext(), params.screenName).
  1270. Return(params.err)
  1271. }
  1272. deleteUserHandler(responseRecorder, request, userManager, slog.Default())
  1273. if responseRecorder.Code != tc.statusCode {
  1274. t.Errorf("want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1275. }
  1276. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1277. t.Errorf("want '%s', got '%s'", tc.want, responseRecorder.Body)
  1278. }
  1279. })
  1280. }
  1281. }
  1282. func TestUserPasswordHandler_PUT(t *testing.T) {
  1283. tt := []struct {
  1284. name string
  1285. body string
  1286. want string
  1287. statusCode int
  1288. mockParams mockParams
  1289. }{
  1290. {
  1291. name: "user with valid password",
  1292. body: `{"screen_name":"userA", "password":"thenewpassword"}`,
  1293. want: `Password successfully reset.`,
  1294. statusCode: http.StatusNoContent,
  1295. mockParams: mockParams{
  1296. userManagerParams: userManagerParams{
  1297. setUserPasswordParams: setUserPasswordParams{
  1298. {
  1299. screenName: state.NewIdentScreenName("userA"),
  1300. newPassword: "thenewpassword",
  1301. },
  1302. },
  1303. },
  1304. },
  1305. },
  1306. {
  1307. name: "user with invalid password",
  1308. body: `{"screen_name":"userA", "password":"a"}`,
  1309. want: `invalid password length`,
  1310. statusCode: http.StatusBadRequest,
  1311. mockParams: mockParams{
  1312. userManagerParams: userManagerParams{
  1313. setUserPasswordParams: setUserPasswordParams{
  1314. {
  1315. screenName: state.NewIdentScreenName("userA"),
  1316. newPassword: "a",
  1317. err: state.ErrPasswordInvalid,
  1318. },
  1319. },
  1320. },
  1321. },
  1322. },
  1323. {
  1324. name: "with malformed body",
  1325. body: `{"screen_name":"userA", "password":"thepassword"`, // missing closing }
  1326. want: `malformed input`,
  1327. statusCode: http.StatusBadRequest,
  1328. },
  1329. {
  1330. name: "password updater returns runtime error",
  1331. body: `{"screen_name":"userA", "password":"thepassword"}`,
  1332. want: `internal server error`,
  1333. statusCode: http.StatusInternalServerError,
  1334. mockParams: mockParams{
  1335. userManagerParams: userManagerParams{
  1336. setUserPasswordParams: setUserPasswordParams{
  1337. {
  1338. screenName: state.NewIdentScreenName("userA"),
  1339. newPassword: "thepassword",
  1340. err: io.EOF,
  1341. },
  1342. },
  1343. },
  1344. },
  1345. },
  1346. {
  1347. name: "user doesn't exist",
  1348. body: `{"screen_name":"userA", "password":"thepassword"}`,
  1349. want: `user does not exist`,
  1350. statusCode: http.StatusNotFound,
  1351. mockParams: mockParams{
  1352. userManagerParams: userManagerParams{
  1353. setUserPasswordParams: setUserPasswordParams{
  1354. {
  1355. screenName: state.NewIdentScreenName("userA"),
  1356. newPassword: "thepassword",
  1357. err: state.ErrNoUser,
  1358. },
  1359. },
  1360. },
  1361. },
  1362. },
  1363. }
  1364. for _, tc := range tt {
  1365. t.Run(tc.name, func(t *testing.T) {
  1366. request := httptest.NewRequest(http.MethodPut, "/user", strings.NewReader(tc.body))
  1367. responseRecorder := httptest.NewRecorder()
  1368. userManager := newMockUserManager(t)
  1369. for _, params := range tc.mockParams.setUserPasswordParams {
  1370. userManager.EXPECT().
  1371. SetUserPassword(matchContext(), params.screenName, params.newPassword).
  1372. Return(params.err)
  1373. }
  1374. putUserPasswordHandler(responseRecorder, request, userManager, slog.Default())
  1375. if responseRecorder.Code != tc.statusCode {
  1376. t.Errorf("want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1377. }
  1378. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1379. t.Errorf("want '%s', got '%s'", tc.want, responseRecorder.Body)
  1380. }
  1381. })
  1382. }
  1383. }
  1384. func TestPublicChatHandler_GET(t *testing.T) {
  1385. fnNewSess := func(screenName string) *state.Session {
  1386. sess := state.NewSession()
  1387. sess.SetIdentScreenName(state.NewIdentScreenName(screenName))
  1388. sess.SetDisplayScreenName(state.DisplayScreenName(screenName))
  1389. instance := sess.AddInstance()
  1390. instance.SetSignonComplete()
  1391. return sess
  1392. }
  1393. chatRoom1 := state.NewChatRoom("chat-room-1-name", state.NewIdentScreenName("chat-room-1-creator"), state.PublicExchange)
  1394. chatRoom2 := state.NewChatRoom("chat-room-2-name", state.NewIdentScreenName("chat-room-1-creator"), state.PublicExchange)
  1395. tt := []struct {
  1396. name string
  1397. want string
  1398. statusCode int
  1399. mockParams mockParams
  1400. }{
  1401. {
  1402. name: "multiple chat rooms with participants",
  1403. want: `[{"name":"chat-room-1-name","create_time":"0001-01-01T00:00:00Z","url":"aim:gochat?roomname=chat-room-1-name&exchange=5","participants":[{"id":"usera","screen_name":"userA"},{"id":"userb","screen_name":"userB"}]},{"name":"chat-room-2-name","create_time":"0001-01-01T00:00:00Z","url":"aim:gochat?roomname=chat-room-2-name&exchange=5","participants":[{"id":"userc","screen_name":"userC"},{"id":"userd","screen_name":"userD"}]}]`,
  1404. statusCode: http.StatusOK,
  1405. mockParams: mockParams{
  1406. chatRoomRetrieverParams: chatRoomRetrieverParams{
  1407. allChatRoomsParams: allChatRoomsParams{
  1408. {
  1409. exchange: state.PublicExchange,
  1410. result: []state.ChatRoom{
  1411. chatRoom1,
  1412. chatRoom2,
  1413. },
  1414. },
  1415. },
  1416. },
  1417. chatSessionRetrieverParams: chatSessionRetrieverParams{
  1418. chatSessionRetrieverAllSessionsParams: chatSessionRetrieverAllSessionsParams{
  1419. {
  1420. cookie: chatRoom1.Cookie(),
  1421. result: []*state.Session{
  1422. fnNewSess("userA"),
  1423. fnNewSess("userB"),
  1424. },
  1425. },
  1426. {
  1427. cookie: chatRoom2.Cookie(),
  1428. result: []*state.Session{
  1429. fnNewSess("userC"),
  1430. fnNewSess("userD"),
  1431. },
  1432. },
  1433. },
  1434. },
  1435. },
  1436. },
  1437. {
  1438. name: "chat room without participants",
  1439. want: `[{"name":"chat-room-1-name","create_time":"0001-01-01T00:00:00Z","url":"aim:gochat?roomname=chat-room-1-name&exchange=5","participants":[]}]`,
  1440. statusCode: http.StatusOK,
  1441. mockParams: mockParams{
  1442. chatRoomRetrieverParams: chatRoomRetrieverParams{
  1443. allChatRoomsParams: allChatRoomsParams{
  1444. {
  1445. exchange: state.PublicExchange,
  1446. result: []state.ChatRoom{
  1447. chatRoom1,
  1448. },
  1449. },
  1450. },
  1451. },
  1452. chatSessionRetrieverParams: chatSessionRetrieverParams{
  1453. chatSessionRetrieverAllSessionsParams: chatSessionRetrieverAllSessionsParams{
  1454. {
  1455. cookie: chatRoom1.Cookie(),
  1456. result: []*state.Session{},
  1457. },
  1458. },
  1459. },
  1460. },
  1461. },
  1462. {
  1463. name: "no chat rooms",
  1464. want: `[]`,
  1465. statusCode: http.StatusOK,
  1466. mockParams: mockParams{
  1467. chatRoomRetrieverParams: chatRoomRetrieverParams{
  1468. allChatRoomsParams: allChatRoomsParams{
  1469. {
  1470. exchange: state.PublicExchange,
  1471. result: []state.ChatRoom{},
  1472. },
  1473. },
  1474. },
  1475. },
  1476. },
  1477. }
  1478. for _, tc := range tt {
  1479. t.Run(tc.name, func(t *testing.T) {
  1480. request := httptest.NewRequest(http.MethodGet, "/chat/room/public", nil)
  1481. responseRecorder := httptest.NewRecorder()
  1482. chatRoomRetriever := newMockChatRoomRetriever(t)
  1483. for _, params := range tc.mockParams.allChatRoomsParams {
  1484. chatRoomRetriever.EXPECT().
  1485. AllChatRooms(matchContext(), params.exchange).
  1486. Return(params.result, params.err)
  1487. }
  1488. chatSessionRetriever := newMockChatSessionRetriever(t)
  1489. for _, params := range tc.mockParams.chatSessionRetrieverAllSessionsParams {
  1490. chatSessionRetriever.EXPECT().
  1491. AllSessions(params.cookie).
  1492. Return(params.result)
  1493. }
  1494. getPublicChatHandler(responseRecorder, request, chatRoomRetriever, chatSessionRetriever, slog.Default())
  1495. if responseRecorder.Code != tc.statusCode {
  1496. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1497. }
  1498. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1499. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  1500. }
  1501. })
  1502. }
  1503. }
  1504. func TestDeletePublicChatHandler(t *testing.T) {
  1505. tt := []struct {
  1506. name string
  1507. body string
  1508. want string
  1509. statusCode int
  1510. mockParams mockParams
  1511. }{
  1512. {
  1513. name: "successful deletion of single chat room",
  1514. body: `{"names":["TestRoom"]}`,
  1515. want: `Chat rooms deleted successfully.`,
  1516. statusCode: http.StatusNoContent,
  1517. mockParams: mockParams{
  1518. chatRoomDeleterParams: chatRoomDeleterParams{
  1519. deleteChatRoomsParams: deleteChatRoomsParams{
  1520. {
  1521. exchange: state.PublicExchange,
  1522. names: []string{"TestRoom"},
  1523. },
  1524. },
  1525. },
  1526. },
  1527. },
  1528. {
  1529. name: "successful deletion of multiple chat rooms",
  1530. body: `{"names":["Room1", "Room2", "Room3"]}`,
  1531. want: `Chat rooms deleted successfully.`,
  1532. statusCode: http.StatusNoContent,
  1533. mockParams: mockParams{
  1534. chatRoomDeleterParams: chatRoomDeleterParams{
  1535. deleteChatRoomsParams: deleteChatRoomsParams{
  1536. {
  1537. exchange: state.PublicExchange,
  1538. names: []string{"Room1", "Room2", "Room3"},
  1539. },
  1540. },
  1541. },
  1542. },
  1543. },
  1544. {
  1545. name: "empty names array",
  1546. body: `{"names":[]}`,
  1547. want: `no chat room names provided`,
  1548. statusCode: http.StatusBadRequest,
  1549. },
  1550. {
  1551. name: "malformed JSON",
  1552. body: `{"names":["Room1"`, // missing closing brackets
  1553. want: `malformed input`,
  1554. statusCode: http.StatusBadRequest,
  1555. },
  1556. {
  1557. name: "deletion error",
  1558. body: `{"names":["TestRoom"]}`,
  1559. want: `internal server error`,
  1560. statusCode: http.StatusInternalServerError,
  1561. mockParams: mockParams{
  1562. chatRoomDeleterParams: chatRoomDeleterParams{
  1563. deleteChatRoomsParams: deleteChatRoomsParams{
  1564. {
  1565. exchange: state.PublicExchange,
  1566. names: []string{"TestRoom"},
  1567. err: errors.New("database error"),
  1568. },
  1569. },
  1570. },
  1571. },
  1572. },
  1573. }
  1574. for _, tc := range tt {
  1575. t.Run(tc.name, func(t *testing.T) {
  1576. request := httptest.NewRequest(http.MethodDelete, "/chat/room/public", strings.NewReader(tc.body))
  1577. responseRecorder := httptest.NewRecorder()
  1578. chatRoomDeleter := newMockChatRoomDeleter(t)
  1579. for _, params := range tc.mockParams.deleteChatRoomsParams {
  1580. chatRoomDeleter.EXPECT().
  1581. DeleteChatRooms(matchContext(), params.exchange, params.names).
  1582. Return(params.err)
  1583. }
  1584. deletePublicChatHandler(responseRecorder, request, chatRoomDeleter, slog.Default())
  1585. if responseRecorder.Code != tc.statusCode {
  1586. t.Errorf("want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1587. }
  1588. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1589. t.Errorf("want '%s', got '%s'", tc.want, responseRecorder.Body)
  1590. }
  1591. })
  1592. }
  1593. }
  1594. func TestPrivateChatHandler_GET(t *testing.T) {
  1595. fnNewSess := func(screenName string) *state.Session {
  1596. sess := state.NewSession()
  1597. sess.SetIdentScreenName(state.NewIdentScreenName(screenName))
  1598. sess.SetDisplayScreenName(state.DisplayScreenName(screenName))
  1599. instance := sess.AddInstance()
  1600. instance.SetSignonComplete()
  1601. return sess
  1602. }
  1603. chatRoom1 := state.NewChatRoom("chat-room-1-name", state.NewIdentScreenName("chat-room-1-creator"), state.PrivateExchange)
  1604. chatRoom2 := state.NewChatRoom("chat-room-2-name", state.NewIdentScreenName("chat-room-2-creator"), state.PrivateExchange)
  1605. tt := []struct {
  1606. name string
  1607. want string
  1608. statusCode int
  1609. mockParams mockParams
  1610. }{
  1611. {
  1612. name: "multiple chat rooms with participants",
  1613. want: `[{"name":"chat-room-1-name","create_time":"0001-01-01T00:00:00Z","creator_id":"chat-room-1-creator","url":"aim:gochat?roomname=chat-room-1-name&exchange=4","participants":[{"id":"usera","screen_name":"userA"},{"id":"userb","screen_name":"userB"}]},{"name":"chat-room-2-name","create_time":"0001-01-01T00:00:00Z","creator_id":"chat-room-2-creator","url":"aim:gochat?roomname=chat-room-2-name&exchange=4","participants":[{"id":"userc","screen_name":"userC"},{"id":"userd","screen_name":"userD"}]}]`,
  1614. statusCode: http.StatusOK,
  1615. mockParams: mockParams{
  1616. chatRoomRetrieverParams: chatRoomRetrieverParams{
  1617. allChatRoomsParams: allChatRoomsParams{
  1618. {
  1619. exchange: state.PrivateExchange,
  1620. result: []state.ChatRoom{
  1621. chatRoom1,
  1622. chatRoom2,
  1623. },
  1624. },
  1625. },
  1626. },
  1627. chatSessionRetrieverParams: chatSessionRetrieverParams{
  1628. chatSessionRetrieverAllSessionsParams: chatSessionRetrieverAllSessionsParams{
  1629. {
  1630. cookie: chatRoom1.Cookie(),
  1631. result: []*state.Session{
  1632. fnNewSess("userA"),
  1633. fnNewSess("userB"),
  1634. },
  1635. },
  1636. {
  1637. cookie: chatRoom2.Cookie(),
  1638. result: []*state.Session{
  1639. fnNewSess("userC"),
  1640. fnNewSess("userD"),
  1641. },
  1642. },
  1643. },
  1644. },
  1645. },
  1646. },
  1647. {
  1648. name: "chat room without participants",
  1649. want: `[{"name":"chat-room-1-name","create_time":"0001-01-01T00:00:00Z","creator_id":"chat-room-1-creator","url":"aim:gochat?roomname=chat-room-1-name&exchange=4","participants":[]}]`,
  1650. statusCode: http.StatusOK,
  1651. mockParams: mockParams{
  1652. chatRoomRetrieverParams: chatRoomRetrieverParams{
  1653. allChatRoomsParams: allChatRoomsParams{
  1654. {
  1655. exchange: state.PrivateExchange,
  1656. result: []state.ChatRoom{
  1657. chatRoom1,
  1658. },
  1659. },
  1660. },
  1661. },
  1662. chatSessionRetrieverParams: chatSessionRetrieverParams{
  1663. chatSessionRetrieverAllSessionsParams: chatSessionRetrieverAllSessionsParams{
  1664. {
  1665. cookie: chatRoom1.Cookie(),
  1666. result: []*state.Session{},
  1667. },
  1668. },
  1669. },
  1670. },
  1671. },
  1672. {
  1673. name: "no chat rooms",
  1674. want: `[]`,
  1675. statusCode: http.StatusOK,
  1676. mockParams: mockParams{
  1677. chatRoomRetrieverParams: chatRoomRetrieverParams{
  1678. allChatRoomsParams: allChatRoomsParams{
  1679. {
  1680. exchange: state.PrivateExchange,
  1681. result: []state.ChatRoom{},
  1682. },
  1683. },
  1684. },
  1685. },
  1686. },
  1687. }
  1688. for _, tc := range tt {
  1689. t.Run(tc.name, func(t *testing.T) {
  1690. request := httptest.NewRequest(http.MethodGet, "/chat/room/private", nil)
  1691. responseRecorder := httptest.NewRecorder()
  1692. chatRoomRetriever := newMockChatRoomRetriever(t)
  1693. for _, params := range tc.mockParams.allChatRoomsParams {
  1694. chatRoomRetriever.EXPECT().
  1695. AllChatRooms(matchContext(), params.exchange).
  1696. Return(params.result, params.err)
  1697. }
  1698. chatSessionRetriever := newMockChatSessionRetriever(t)
  1699. for _, params := range tc.mockParams.chatSessionRetrieverAllSessionsParams {
  1700. chatSessionRetriever.EXPECT().
  1701. AllSessions(params.cookie).
  1702. Return(params.result)
  1703. }
  1704. getPrivateChatHandler(responseRecorder, request, chatRoomRetriever, chatSessionRetriever, slog.Default())
  1705. if responseRecorder.Code != tc.statusCode {
  1706. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1707. }
  1708. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1709. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  1710. }
  1711. })
  1712. }
  1713. }
  1714. func TestInstantMessageHandler_POST(t *testing.T) {
  1715. tt := []struct {
  1716. name string
  1717. body string
  1718. wantText string
  1719. wantStore bool
  1720. sendCalled bool
  1721. reply *wire.SNACMessage
  1722. sendErr error
  1723. want string
  1724. statusCode int
  1725. }{
  1726. {
  1727. name: "send an instant message",
  1728. body: `{"from":"sender_sn","to":"recip_sn","text":"hello world!"}`,
  1729. sendCalled: true,
  1730. want: `Message sent successfully.`,
  1731. statusCode: http.StatusOK,
  1732. },
  1733. {
  1734. name: "send an instant message with non-ASCII text",
  1735. body: `{"from":"sender_sn","to":"recip_sn","text":"héllo wörld 日本 😀"}`,
  1736. wantText: "héllo wörld 日本 \uFFFD",
  1737. sendCalled: true,
  1738. want: `Message sent successfully.`,
  1739. statusCode: http.StatusOK,
  1740. },
  1741. {
  1742. name: "recipient is offline",
  1743. body: `{"from":"sender_sn","to":"recip_sn","text":"hello world!"}`,
  1744. sendCalled: true,
  1745. reply: &wire.SNACMessage{
  1746. Frame: wire.SNACFrame{FoodGroup: wire.ICBM, SubGroup: wire.ICBMErr},
  1747. Body: wire.SNACError{Code: wire.ErrorCodeNotLoggedOn},
  1748. },
  1749. want: `recipient is not online`,
  1750. statusCode: http.StatusNotFound,
  1751. },
  1752. {
  1753. name: "store message for offline recipient",
  1754. body: `{"from":"sender_sn","to":"recip_sn","text":"hello world!","storeOffline":true}`,
  1755. wantStore: true,
  1756. sendCalled: true,
  1757. want: `Message sent successfully.`,
  1758. statusCode: http.StatusOK,
  1759. },
  1760. {
  1761. name: "offline recipient does not accept stored message",
  1762. body: `{"from":"sender_sn","to":"recip_sn","text":"hello world!","storeOffline":true}`,
  1763. wantStore: true,
  1764. sendCalled: true,
  1765. reply: &wire.SNACMessage{
  1766. Frame: wire.SNACFrame{FoodGroup: wire.ICBM, SubGroup: wire.ICBMErr},
  1767. Body: wire.SNACError{Code: wire.ErrorCodeNotLoggedOn},
  1768. },
  1769. want: `recipient is not online`,
  1770. statusCode: http.StatusNotFound,
  1771. },
  1772. {
  1773. name: "do not store message for offline recipient",
  1774. body: `{"from":"sender_sn","to":"recip_sn","text":"hello world!","storeOffline":false}`,
  1775. sendCalled: true,
  1776. reply: &wire.SNACMessage{
  1777. Frame: wire.SNACFrame{FoodGroup: wire.ICBM, SubGroup: wire.ICBMErr},
  1778. Body: wire.SNACError{Code: wire.ErrorCodeNotLoggedOn},
  1779. },
  1780. want: `recipient is not online`,
  1781. statusCode: http.StatusNotFound,
  1782. },
  1783. {
  1784. name: "sender is blocked",
  1785. body: `{"from":"sender_sn","to":"recip_sn","text":"hello world!"}`,
  1786. sendCalled: true,
  1787. reply: &wire.SNACMessage{
  1788. Frame: wire.SNACFrame{FoodGroup: wire.ICBM, SubGroup: wire.ICBMErr},
  1789. Body: wire.SNACError{Code: wire.ErrorCodeInLocalPermitDeny},
  1790. },
  1791. want: `message blocked`,
  1792. statusCode: http.StatusForbidden,
  1793. },
  1794. {
  1795. name: "send fails",
  1796. body: `{"from":"sender_sn","to":"recip_sn","text":"hello world!"}`,
  1797. sendCalled: true,
  1798. sendErr: io.EOF,
  1799. want: `internal server error`,
  1800. statusCode: http.StatusInternalServerError,
  1801. },
  1802. {
  1803. name: "with malformed body",
  1804. body: `{"screen_name":"userA", "password":"thepassword"`,
  1805. want: `malformed input`,
  1806. statusCode: http.StatusBadRequest,
  1807. },
  1808. }
  1809. for _, tc := range tt {
  1810. t.Run(tc.name, func(t *testing.T) {
  1811. request := httptest.NewRequest(http.MethodPost, "/instant-message", strings.NewReader(tc.body))
  1812. responseRecorder := httptest.NewRecorder()
  1813. sendCalled := false
  1814. icbmSender := func(ctx context.Context, instance *state.SessionInstance, inFrame wire.SNACFrame, inBody wire.SNAC_0x04_0x06_ICBMChannelMsgToHost) (*wire.SNACMessage, error) {
  1815. sendCalled = true
  1816. assert.Equal(t, state.NewIdentScreenName("sender_sn"), instance.IdentScreenName())
  1817. assert.Equal(t, wire.ICBM, inFrame.FoodGroup)
  1818. assert.Equal(t, wire.ICBMChannelMsgToHost, inFrame.SubGroup)
  1819. assert.Equal(t, "recip_sn", inBody.ScreenName)
  1820. assert.Equal(t, wire.ICBMChannelIM, inBody.ChannelID)
  1821. assert.Equal(t, [][16]byte{wire.CapUTF8Messages}, instance.Caps())
  1822. _, hasStore := inBody.Bytes(wire.ICBMTLVStore)
  1823. assert.Equal(t, tc.wantStore, hasStore)
  1824. wantText := tc.wantText
  1825. if wantText == "" {
  1826. wantText = "hello world!"
  1827. }
  1828. wantCharset := wire.ICBMMessageEncodingUnicode
  1829. if wire.AllASCII(wantText) {
  1830. wantCharset = wire.ICBMMessageEncodingASCII
  1831. }
  1832. b, ok := inBody.Bytes(wire.ICBMTLVAOLIMData)
  1833. assert.True(t, ok)
  1834. var frags []wire.ICBMCh1Fragment
  1835. assert.NoError(t, wire.UnmarshalBE(&frags, bytes.NewBuffer(b)))
  1836. for _, frag := range frags {
  1837. if frag.ID == 1 {
  1838. msg := wire.ICBMCh1Message{}
  1839. assert.NoError(t, wire.UnmarshalBE(&msg, bytes.NewBuffer(frag.Payload)))
  1840. assert.Equal(t, wantCharset, msg.Charset)
  1841. }
  1842. }
  1843. txt, err := wire.UnmarshalICBMMessageText(b)
  1844. assert.NoError(t, err)
  1845. assert.Equal(t, wantText, txt)
  1846. return tc.reply, tc.sendErr
  1847. }
  1848. postInstantMessageHandler(responseRecorder, request, icbmSender, slog.Default())
  1849. assert.Equal(t, tc.sendCalled, sendCalled)
  1850. assert.Equal(t, tc.statusCode, responseRecorder.Code)
  1851. assert.Equal(t, tc.want, strings.TrimSpace(responseRecorder.Body.String()))
  1852. })
  1853. }
  1854. }
  1855. func TestVersionHandler_GET(t *testing.T) {
  1856. tt := []struct {
  1857. name string
  1858. want string
  1859. statusCode int
  1860. buildInfo config.Build
  1861. }{
  1862. {
  1863. name: "get ras version",
  1864. want: `{"version":"13.3.7","commit":"asdfASDF12345678","date":"2024-03-01"}`,
  1865. statusCode: http.StatusOK,
  1866. buildInfo: config.Build{
  1867. Version: "13.3.7",
  1868. Commit: "asdfASDF12345678",
  1869. Date: "2024-03-01",
  1870. },
  1871. },
  1872. }
  1873. for _, tc := range tt {
  1874. t.Run(tc.name, func(t *testing.T) {
  1875. responseRecorder := httptest.NewRecorder()
  1876. getVersionHandler(responseRecorder, tc.buildInfo)
  1877. if responseRecorder.Code != tc.statusCode {
  1878. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1879. }
  1880. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1881. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  1882. }
  1883. })
  1884. }
  1885. }
  1886. func TestDirectoryCategoryHandler_GET(t *testing.T) {
  1887. tt := []struct {
  1888. name string
  1889. want string
  1890. statusCode int
  1891. mockParams mockParams
  1892. }{
  1893. {
  1894. name: "no categories",
  1895. want: `[]`,
  1896. statusCode: http.StatusOK,
  1897. mockParams: mockParams{
  1898. directoryManagerParams: directoryManagerParams{
  1899. categoriesParams: categoriesParams{
  1900. {
  1901. result: nil,
  1902. },
  1903. },
  1904. },
  1905. },
  1906. },
  1907. {
  1908. name: "error fetching categories",
  1909. want: `{"message":"internal server error"}`,
  1910. statusCode: http.StatusInternalServerError,
  1911. mockParams: mockParams{
  1912. directoryManagerParams: directoryManagerParams{
  1913. categoriesParams: categoriesParams{
  1914. {
  1915. result: nil,
  1916. err: errors.New("error fetching categories"),
  1917. },
  1918. },
  1919. },
  1920. },
  1921. },
  1922. {
  1923. name: "fetch some categories",
  1924. want: `[{"id":1,"name":"category-1"},{"id":2,"name":"category-2"}]`,
  1925. statusCode: http.StatusOK,
  1926. mockParams: mockParams{
  1927. directoryManagerParams: directoryManagerParams{
  1928. categoriesParams: categoriesParams{
  1929. {
  1930. result: []state.Category{
  1931. {
  1932. ID: 1,
  1933. Name: "category-1",
  1934. },
  1935. {
  1936. ID: 2,
  1937. Name: "category-2",
  1938. },
  1939. },
  1940. },
  1941. },
  1942. },
  1943. },
  1944. },
  1945. }
  1946. for _, tc := range tt {
  1947. t.Run(tc.name, func(t *testing.T) {
  1948. responseRecorder := httptest.NewRecorder()
  1949. request := httptest.NewRequest(http.MethodGet, "/directory/category", nil)
  1950. directoryManager := newMockDirectoryManager(t)
  1951. for _, params := range tc.mockParams.categoriesParams {
  1952. directoryManager.EXPECT().
  1953. Categories(matchContext()).
  1954. Return(params.result, params.err)
  1955. }
  1956. getDirectoryCategoryHandler(responseRecorder, request, directoryManager, slog.Default())
  1957. if responseRecorder.Code != tc.statusCode {
  1958. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1959. }
  1960. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1961. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  1962. }
  1963. })
  1964. }
  1965. }
  1966. func TestDirectoryCategoryKeywordHandler_GET(t *testing.T) {
  1967. tt := []struct {
  1968. name string
  1969. categoryID int
  1970. want string
  1971. statusCode int
  1972. mockParams mockParams
  1973. }{
  1974. {
  1975. name: "category not found",
  1976. categoryID: 1,
  1977. want: `{"message":"category not found"}`,
  1978. statusCode: http.StatusNotFound,
  1979. mockParams: mockParams{
  1980. directoryManagerParams: directoryManagerParams{
  1981. keywordsByCategoryParams: keywordsByCategoryParams{
  1982. {
  1983. categoryID: 1,
  1984. result: nil,
  1985. err: state.ErrKeywordCategoryNotFound,
  1986. },
  1987. },
  1988. },
  1989. },
  1990. },
  1991. {
  1992. name: "error fetching keywords by category",
  1993. categoryID: 1,
  1994. want: `{"message":"internal server error"}`,
  1995. statusCode: http.StatusInternalServerError,
  1996. mockParams: mockParams{
  1997. directoryManagerParams: directoryManagerParams{
  1998. keywordsByCategoryParams: keywordsByCategoryParams{
  1999. {
  2000. categoryID: 1,
  2001. result: nil,
  2002. err: errors.New("error fetching keywords by category"),
  2003. },
  2004. },
  2005. },
  2006. },
  2007. },
  2008. {
  2009. name: "invalid category ID",
  2010. categoryID: -1,
  2011. want: `{"message":"invalid category ID"}`,
  2012. statusCode: http.StatusBadRequest,
  2013. mockParams: mockParams{
  2014. directoryManagerParams: directoryManagerParams{
  2015. keywordsByCategoryParams: keywordsByCategoryParams{},
  2016. },
  2017. },
  2018. },
  2019. {
  2020. name: "no keywords",
  2021. categoryID: 1,
  2022. want: `[]`,
  2023. statusCode: http.StatusOK,
  2024. mockParams: mockParams{
  2025. directoryManagerParams: directoryManagerParams{
  2026. keywordsByCategoryParams: keywordsByCategoryParams{
  2027. {
  2028. categoryID: 1,
  2029. result: nil,
  2030. },
  2031. },
  2032. },
  2033. },
  2034. },
  2035. {
  2036. name: "fetch some keywords by category",
  2037. categoryID: 1,
  2038. want: `[{"id":1,"name":"keyword-1"},{"id":2,"name":"keyword-2"}]`,
  2039. statusCode: http.StatusOK,
  2040. mockParams: mockParams{
  2041. directoryManagerParams: directoryManagerParams{
  2042. keywordsByCategoryParams: keywordsByCategoryParams{
  2043. {
  2044. categoryID: 1,
  2045. result: []state.Keyword{
  2046. {
  2047. ID: 1,
  2048. Name: "keyword-1",
  2049. },
  2050. {
  2051. ID: 2,
  2052. Name: "keyword-2",
  2053. },
  2054. },
  2055. },
  2056. },
  2057. },
  2058. },
  2059. },
  2060. }
  2061. for _, tc := range tt {
  2062. t.Run(tc.name, func(t *testing.T) {
  2063. request := httptest.NewRequest(http.MethodGet, fmt.Sprintf("/directory/category/%d/keyword", tc.categoryID), nil)
  2064. request.SetPathValue("id", fmt.Sprintf("%d", tc.categoryID))
  2065. responseRecorder := httptest.NewRecorder()
  2066. directoryManager := newMockDirectoryManager(t)
  2067. for _, params := range tc.mockParams.keywordsByCategoryParams {
  2068. directoryManager.EXPECT().
  2069. KeywordsByCategory(matchContext(), params.categoryID).
  2070. Return(params.result, params.err)
  2071. }
  2072. getDirectoryCategoryKeywordHandler(responseRecorder, request, directoryManager, slog.Default())
  2073. if responseRecorder.Code != tc.statusCode {
  2074. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  2075. }
  2076. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  2077. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  2078. }
  2079. })
  2080. }
  2081. }
  2082. func TestDirectoryCategoryHandler_DELETE(t *testing.T) {
  2083. tt := []struct {
  2084. name string
  2085. categoryID int
  2086. want string
  2087. statusCode int
  2088. mockParams mockParams
  2089. }{
  2090. {
  2091. name: "category not found",
  2092. categoryID: 1,
  2093. want: `{"message":"category not found"}`,
  2094. statusCode: http.StatusNotFound,
  2095. mockParams: mockParams{
  2096. directoryManagerParams: directoryManagerParams{
  2097. deleteCategoryParams: deleteCategoryParams{
  2098. {
  2099. categoryID: 1,
  2100. err: state.ErrKeywordCategoryNotFound,
  2101. },
  2102. },
  2103. },
  2104. },
  2105. },
  2106. {
  2107. name: "keyword in use by user",
  2108. categoryID: 1,
  2109. want: `{"message":"can't delete because category in use by a user"}`,
  2110. statusCode: http.StatusConflict,
  2111. mockParams: mockParams{
  2112. directoryManagerParams: directoryManagerParams{
  2113. deleteCategoryParams: deleteCategoryParams{
  2114. {
  2115. categoryID: 1,
  2116. err: state.ErrKeywordInUse,
  2117. },
  2118. },
  2119. },
  2120. },
  2121. },
  2122. {
  2123. name: "runtime error",
  2124. categoryID: 1,
  2125. want: `{"message":"internal server error"}`,
  2126. statusCode: http.StatusInternalServerError,
  2127. mockParams: mockParams{
  2128. directoryManagerParams: directoryManagerParams{
  2129. deleteCategoryParams: deleteCategoryParams{
  2130. {
  2131. categoryID: 1,
  2132. err: errors.New("error deleting keyword"),
  2133. },
  2134. },
  2135. },
  2136. },
  2137. },
  2138. {
  2139. name: "successful deletion",
  2140. categoryID: 1,
  2141. want: ``,
  2142. statusCode: http.StatusNoContent,
  2143. mockParams: mockParams{
  2144. directoryManagerParams: directoryManagerParams{
  2145. deleteCategoryParams: deleteCategoryParams{
  2146. {
  2147. categoryID: 1,
  2148. },
  2149. },
  2150. },
  2151. },
  2152. },
  2153. {
  2154. name: "invalid category ID",
  2155. categoryID: -1,
  2156. want: `invalid category ID`,
  2157. statusCode: http.StatusBadRequest,
  2158. mockParams: mockParams{
  2159. directoryManagerParams: directoryManagerParams{
  2160. deleteCategoryParams: deleteCategoryParams{},
  2161. },
  2162. },
  2163. },
  2164. }
  2165. for _, tc := range tt {
  2166. t.Run(tc.name, func(t *testing.T) {
  2167. request := httptest.NewRequest(http.MethodDelete, fmt.Sprintf("/directory/category/%d/keyword", tc.categoryID), nil)
  2168. request.SetPathValue("id", fmt.Sprintf("%d", tc.categoryID))
  2169. responseRecorder := httptest.NewRecorder()
  2170. directoryManager := newMockDirectoryManager(t)
  2171. for _, params := range tc.mockParams.deleteCategoryParams {
  2172. directoryManager.EXPECT().
  2173. DeleteCategory(matchContext(), params.categoryID).
  2174. Return(params.err)
  2175. }
  2176. deleteDirectoryCategoryHandler(responseRecorder, request, directoryManager, slog.Default())
  2177. if responseRecorder.Code != tc.statusCode {
  2178. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  2179. }
  2180. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  2181. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  2182. }
  2183. })
  2184. }
  2185. }
  2186. func TestDirectoryCategoryHandler_POST(t *testing.T) {
  2187. tt := []struct {
  2188. name string
  2189. body string
  2190. want string
  2191. statusCode int
  2192. mockParams mockParams
  2193. }{
  2194. {
  2195. name: "category already exists",
  2196. body: `{"name":"the_category"}`,
  2197. want: `{"message":"category already exists"}`,
  2198. statusCode: http.StatusConflict,
  2199. mockParams: mockParams{
  2200. directoryManagerParams: directoryManagerParams{
  2201. createCategoryParams: createCategoryParams{
  2202. {
  2203. name: "the_category",
  2204. err: state.ErrKeywordCategoryExists,
  2205. },
  2206. },
  2207. },
  2208. },
  2209. },
  2210. {
  2211. name: "runtime error",
  2212. body: `{"name":"the_category"}`,
  2213. want: `{"message":"internal server error"}`,
  2214. statusCode: http.StatusInternalServerError,
  2215. mockParams: mockParams{
  2216. directoryManagerParams: directoryManagerParams{
  2217. createCategoryParams: createCategoryParams{
  2218. {
  2219. name: "the_category",
  2220. err: errors.New("error creating category"),
  2221. },
  2222. },
  2223. },
  2224. },
  2225. },
  2226. {
  2227. name: "bad input",
  2228. body: `{"name":"the_category"`,
  2229. want: `{"message":"malformed input"}`,
  2230. statusCode: http.StatusBadRequest,
  2231. mockParams: mockParams{
  2232. directoryManagerParams: directoryManagerParams{
  2233. createCategoryParams: createCategoryParams{},
  2234. },
  2235. },
  2236. },
  2237. {
  2238. name: "successful creation",
  2239. body: `{"name":"the_category"}`,
  2240. want: `{"id":1,"name":"the_category"}`,
  2241. statusCode: http.StatusCreated,
  2242. mockParams: mockParams{
  2243. directoryManagerParams: directoryManagerParams{
  2244. createCategoryParams: createCategoryParams{
  2245. {
  2246. name: "the_category",
  2247. result: state.Category{
  2248. ID: 1,
  2249. Name: "the_category",
  2250. },
  2251. },
  2252. },
  2253. },
  2254. },
  2255. },
  2256. }
  2257. for _, tc := range tt {
  2258. t.Run(tc.name, func(t *testing.T) {
  2259. request := httptest.NewRequest(http.MethodPost, "/directory/category", strings.NewReader(tc.body))
  2260. responseRecorder := httptest.NewRecorder()
  2261. directoryManager := newMockDirectoryManager(t)
  2262. for _, params := range tc.mockParams.createCategoryParams {
  2263. directoryManager.EXPECT().
  2264. CreateCategory(matchContext(), params.name).
  2265. Return(params.result, params.err)
  2266. }
  2267. postDirectoryCategoryHandler(responseRecorder, request, directoryManager, slog.Default())
  2268. if responseRecorder.Code != tc.statusCode {
  2269. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  2270. }
  2271. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  2272. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  2273. }
  2274. })
  2275. }
  2276. }
  2277. func TestDirectoryKeywordHandler_POST(t *testing.T) {
  2278. tt := []struct {
  2279. name string
  2280. body string
  2281. want string
  2282. statusCode int
  2283. mockParams mockParams
  2284. }{
  2285. {
  2286. name: "keyword already exists",
  2287. body: `{"category_id":1,"name":"the_keyword"}`,
  2288. want: `{"message":"keyword already exists"}`,
  2289. statusCode: http.StatusConflict,
  2290. mockParams: mockParams{
  2291. directoryManagerParams: directoryManagerParams{
  2292. createKeywordParams: createKeywordParams{
  2293. {
  2294. name: "the_keyword",
  2295. categoryID: 1,
  2296. err: state.ErrKeywordExists,
  2297. },
  2298. },
  2299. },
  2300. },
  2301. },
  2302. {
  2303. name: "category not found",
  2304. body: `{"category_id":1,"name":"the_keyword"}`,
  2305. want: `{"message":"category not found"}`,
  2306. statusCode: http.StatusNotFound,
  2307. mockParams: mockParams{
  2308. directoryManagerParams: directoryManagerParams{
  2309. createKeywordParams: createKeywordParams{
  2310. {
  2311. name: "the_keyword",
  2312. categoryID: 1,
  2313. err: state.ErrKeywordCategoryNotFound,
  2314. },
  2315. },
  2316. },
  2317. },
  2318. },
  2319. {
  2320. name: "runtime error",
  2321. body: `{"category_id":1,"name":"the_keyword"}`,
  2322. want: `{"message":"internal server error"}`,
  2323. statusCode: http.StatusInternalServerError,
  2324. mockParams: mockParams{
  2325. directoryManagerParams: directoryManagerParams{
  2326. createKeywordParams: createKeywordParams{
  2327. {
  2328. name: "the_keyword",
  2329. categoryID: 1,
  2330. err: errors.New("error creating keyword"),
  2331. },
  2332. },
  2333. },
  2334. },
  2335. },
  2336. {
  2337. name: "bad input",
  2338. body: `{"category_id":1,"name":"the_keyword"`,
  2339. want: `{"message":"malformed input"}`,
  2340. statusCode: http.StatusBadRequest,
  2341. mockParams: mockParams{
  2342. directoryManagerParams: directoryManagerParams{
  2343. createKeywordParams: createKeywordParams{},
  2344. },
  2345. },
  2346. },
  2347. {
  2348. name: "successful creation",
  2349. body: `{"category_id":1,"name":"the_keyword"}`,
  2350. want: `{"id":1,"name":"the_keyword"}`,
  2351. statusCode: http.StatusCreated,
  2352. mockParams: mockParams{
  2353. directoryManagerParams: directoryManagerParams{
  2354. createKeywordParams: createKeywordParams{
  2355. {
  2356. name: "the_keyword",
  2357. categoryID: 1,
  2358. result: state.Keyword{
  2359. ID: 1,
  2360. Name: "the_keyword",
  2361. },
  2362. },
  2363. },
  2364. },
  2365. },
  2366. },
  2367. }
  2368. for _, tc := range tt {
  2369. t.Run(tc.name, func(t *testing.T) {
  2370. request := httptest.NewRequest(http.MethodPost, "/directory/keyword", strings.NewReader(tc.body))
  2371. responseRecorder := httptest.NewRecorder()
  2372. directoryManager := newMockDirectoryManager(t)
  2373. for _, params := range tc.mockParams.createKeywordParams {
  2374. directoryManager.EXPECT().
  2375. CreateKeyword(matchContext(), params.name, params.categoryID).
  2376. Return(params.result, params.err)
  2377. }
  2378. postDirectoryKeywordHandler(responseRecorder, request, directoryManager, slog.Default())
  2379. if responseRecorder.Code != tc.statusCode {
  2380. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  2381. }
  2382. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  2383. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  2384. }
  2385. })
  2386. }
  2387. }
  2388. func TestDirectoryKeywordHandler_DELETE(t *testing.T) {
  2389. tt := []struct {
  2390. name string
  2391. categoryID int
  2392. want string
  2393. statusCode int
  2394. mockParams mockParams
  2395. }{
  2396. {
  2397. name: "keyword not found",
  2398. categoryID: 1,
  2399. want: `{"message":"keyword not found"}`,
  2400. statusCode: http.StatusNotFound,
  2401. mockParams: mockParams{
  2402. directoryManagerParams: directoryManagerParams{
  2403. deleteKeywordParams: deleteKeywordParams{
  2404. {
  2405. id: 1,
  2406. err: state.ErrKeywordNotFound,
  2407. },
  2408. },
  2409. },
  2410. },
  2411. },
  2412. {
  2413. name: "keyword in use by user",
  2414. categoryID: 1,
  2415. want: `{"message":"can't delete because category in use by a user"}`,
  2416. statusCode: http.StatusConflict,
  2417. mockParams: mockParams{
  2418. directoryManagerParams: directoryManagerParams{
  2419. deleteKeywordParams: deleteKeywordParams{
  2420. {
  2421. id: 1,
  2422. err: state.ErrKeywordInUse,
  2423. },
  2424. },
  2425. },
  2426. },
  2427. },
  2428. {
  2429. name: "runtime error",
  2430. categoryID: 1,
  2431. want: `{"message":"internal server error"}`,
  2432. statusCode: http.StatusInternalServerError,
  2433. mockParams: mockParams{
  2434. directoryManagerParams: directoryManagerParams{
  2435. deleteKeywordParams: deleteKeywordParams{
  2436. {
  2437. id: 1,
  2438. err: errors.New("error deleting keyword"),
  2439. },
  2440. },
  2441. },
  2442. },
  2443. },
  2444. {
  2445. name: "successful deletion",
  2446. categoryID: 1,
  2447. want: ``,
  2448. statusCode: http.StatusNoContent,
  2449. mockParams: mockParams{
  2450. directoryManagerParams: directoryManagerParams{
  2451. deleteKeywordParams: deleteKeywordParams{
  2452. {
  2453. id: 1,
  2454. },
  2455. },
  2456. },
  2457. },
  2458. },
  2459. {
  2460. name: "invalid keyword ID",
  2461. categoryID: -1,
  2462. want: `{"message":"invalid keyword ID"}`,
  2463. statusCode: http.StatusBadRequest,
  2464. mockParams: mockParams{
  2465. directoryManagerParams: directoryManagerParams{
  2466. deleteKeywordParams: deleteKeywordParams{},
  2467. },
  2468. },
  2469. },
  2470. }
  2471. for _, tc := range tt {
  2472. t.Run(tc.name, func(t *testing.T) {
  2473. request := httptest.NewRequest(http.MethodDelete, fmt.Sprintf("/directory/keyword/%d", tc.categoryID), nil)
  2474. request.SetPathValue("id", fmt.Sprintf("%d", tc.categoryID))
  2475. responseRecorder := httptest.NewRecorder()
  2476. directoryManager := newMockDirectoryManager(t)
  2477. for _, params := range tc.mockParams.deleteKeywordParams {
  2478. directoryManager.EXPECT().
  2479. DeleteKeyword(matchContext(), params.id).
  2480. Return(params.err)
  2481. }
  2482. deleteDirectoryKeywordHandler(responseRecorder, request, directoryManager, slog.Default())
  2483. if responseRecorder.Code != tc.statusCode {
  2484. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  2485. }
  2486. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  2487. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  2488. }
  2489. })
  2490. }
  2491. }
  2492. func TestBARTByTypeHandler_GET(t *testing.T) {
  2493. tt := []struct {
  2494. name string
  2495. queryParams string
  2496. wantStatusCode int
  2497. wantResponse string
  2498. mockParams mockParams
  2499. }{
  2500. {
  2501. name: "success with items",
  2502. queryParams: "?type=1",
  2503. wantStatusCode: http.StatusOK,
  2504. wantResponse: `[{"hash":"2B000001E4","type":1},{"hash":"2B000001B7","type":1}]`,
  2505. mockParams: mockParams{
  2506. bartAssetManagerParams: bartAssetManagerParams{
  2507. listBARTItemsParams: listBARTItemsParams{
  2508. {
  2509. itemType: 1,
  2510. result: []state.BARTItem{
  2511. {Hash: "2B000001E4", Type: 1},
  2512. {Hash: "2B000001B7", Type: 1},
  2513. },
  2514. err: nil,
  2515. },
  2516. },
  2517. },
  2518. },
  2519. },
  2520. {
  2521. name: "success with empty list",
  2522. queryParams: "?type=2",
  2523. wantStatusCode: http.StatusOK,
  2524. wantResponse: `[]`,
  2525. mockParams: mockParams{
  2526. bartAssetManagerParams: bartAssetManagerParams{
  2527. listBARTItemsParams: listBARTItemsParams{
  2528. {
  2529. itemType: 2,
  2530. result: []state.BARTItem{},
  2531. err: nil,
  2532. },
  2533. },
  2534. },
  2535. },
  2536. },
  2537. {
  2538. name: "missing type parameter",
  2539. queryParams: "",
  2540. wantStatusCode: http.StatusBadRequest,
  2541. wantResponse: `{"message":"type query parameter is required"}`,
  2542. },
  2543. {
  2544. name: "invalid type parameter",
  2545. queryParams: "?type=invalid",
  2546. wantStatusCode: http.StatusBadRequest,
  2547. wantResponse: `{"message":"invalid type ID"}`,
  2548. },
  2549. {
  2550. name: "internal server error",
  2551. queryParams: "?type=1",
  2552. wantStatusCode: http.StatusInternalServerError,
  2553. wantResponse: `{"message":"internal server error"}`,
  2554. mockParams: mockParams{
  2555. bartAssetManagerParams: bartAssetManagerParams{
  2556. listBARTItemsParams: listBARTItemsParams{
  2557. {
  2558. itemType: 1,
  2559. result: nil,
  2560. err: errors.New("database error"),
  2561. },
  2562. },
  2563. },
  2564. },
  2565. },
  2566. }
  2567. for _, tc := range tt {
  2568. t.Run(tc.name, func(t *testing.T) {
  2569. request := httptest.NewRequest(http.MethodGet, "/bart"+tc.queryParams, nil)
  2570. responseRecorder := httptest.NewRecorder()
  2571. mockBARTManager := newMockBARTAssetManager(t)
  2572. for _, params := range tc.mockParams.listBARTItemsParams {
  2573. mockBARTManager.EXPECT().
  2574. ListBARTItems(matchContext(), params.itemType).
  2575. Return(params.result, params.err)
  2576. }
  2577. getBARTByTypeHandler(responseRecorder, request, mockBARTManager, slog.Default())
  2578. assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
  2579. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  2580. })
  2581. }
  2582. }
  2583. func TestBARTHandler_GET(t *testing.T) {
  2584. tt := []struct {
  2585. name string
  2586. hash string
  2587. wantStatusCode int
  2588. wantResponse string
  2589. wantHeaders map[string]string
  2590. mockParams mockParams
  2591. }{
  2592. {
  2593. name: "success with valid hash",
  2594. hash: "2B000001E4",
  2595. wantStatusCode: http.StatusOK,
  2596. wantResponse: "binary data",
  2597. wantHeaders: map[string]string{"Content-Type": "application/octet-stream"},
  2598. mockParams: mockParams{
  2599. bartAssetManagerParams: bartAssetManagerParams{
  2600. bartItemParams: bartItemParams{
  2601. {
  2602. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2603. result: []byte("binary data"),
  2604. err: nil,
  2605. },
  2606. },
  2607. },
  2608. },
  2609. },
  2610. {
  2611. name: "missing hash parameter",
  2612. hash: "",
  2613. wantStatusCode: http.StatusBadRequest,
  2614. wantResponse: `{"message":"hash is required"}`,
  2615. },
  2616. {
  2617. name: "invalid hash format",
  2618. hash: "invalid-hex",
  2619. wantStatusCode: http.StatusBadRequest,
  2620. wantResponse: `{"message":"invalid hash format"}`,
  2621. },
  2622. {
  2623. name: "asset not found",
  2624. hash: "2B000001E4",
  2625. wantStatusCode: http.StatusNotFound,
  2626. wantResponse: `{"message":"BART asset not found"}`,
  2627. mockParams: mockParams{
  2628. bartAssetManagerParams: bartAssetManagerParams{
  2629. bartItemParams: bartItemParams{
  2630. {
  2631. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2632. result: []byte{},
  2633. err: nil,
  2634. },
  2635. },
  2636. },
  2637. },
  2638. },
  2639. {
  2640. name: "internal server error",
  2641. hash: "2B000001E4",
  2642. wantStatusCode: http.StatusInternalServerError,
  2643. wantResponse: `{"message":"internal server error"}`,
  2644. mockParams: mockParams{
  2645. bartAssetManagerParams: bartAssetManagerParams{
  2646. bartItemParams: bartItemParams{
  2647. {
  2648. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2649. result: nil,
  2650. err: errors.New("database error"),
  2651. },
  2652. },
  2653. },
  2654. },
  2655. },
  2656. }
  2657. for _, tc := range tt {
  2658. t.Run(tc.name, func(t *testing.T) {
  2659. request := httptest.NewRequest(http.MethodGet, "/bart/"+tc.hash, nil)
  2660. // Set the path value manually for testing
  2661. if tc.hash != "" {
  2662. request.SetPathValue("hash", tc.hash)
  2663. }
  2664. responseRecorder := httptest.NewRecorder()
  2665. mockBARTManager := newMockBARTAssetManager(t)
  2666. for _, params := range tc.mockParams.bartItemParams {
  2667. mockBARTManager.EXPECT().
  2668. BARTItem(matchContext(), params.hash).
  2669. Return(params.result, params.err)
  2670. }
  2671. getBARTHandler(responseRecorder, request, mockBARTManager, slog.Default())
  2672. assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
  2673. if tc.wantHeaders != nil {
  2674. for key, value := range tc.wantHeaders {
  2675. assert.Equal(t, value, responseRecorder.Header().Get(key))
  2676. }
  2677. }
  2678. if tc.wantStatusCode == http.StatusOK {
  2679. assert.Equal(t, tc.wantResponse, responseRecorder.Body.String())
  2680. } else {
  2681. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  2682. }
  2683. })
  2684. }
  2685. }
  2686. func TestBARTHandler_POST(t *testing.T) {
  2687. tt := []struct {
  2688. name string
  2689. hash string
  2690. queryParams string
  2691. requestBody string
  2692. wantStatusCode int
  2693. wantResponse string
  2694. mockParams mockParams
  2695. }{
  2696. {
  2697. name: "success with valid data",
  2698. hash: "2B000001E4",
  2699. queryParams: "?type=1",
  2700. requestBody: "binary data",
  2701. wantStatusCode: http.StatusCreated,
  2702. wantResponse: `{"hash":"2b000001e4","type":1}`,
  2703. mockParams: mockParams{
  2704. bartAssetManagerParams: bartAssetManagerParams{
  2705. insertBARTItemParams: insertBARTItemParams{
  2706. {
  2707. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2708. blob: []byte("binary data"),
  2709. itemType: 1,
  2710. err: nil,
  2711. },
  2712. },
  2713. },
  2714. },
  2715. },
  2716. {
  2717. name: "missing hash parameter",
  2718. hash: "",
  2719. queryParams: "?type=1",
  2720. requestBody: "binary data",
  2721. wantStatusCode: http.StatusBadRequest,
  2722. wantResponse: `{"message":"hash path parameter is required"}`,
  2723. },
  2724. {
  2725. name: "invalid hash format",
  2726. hash: "invalid-hex",
  2727. queryParams: "?type=1",
  2728. requestBody: "binary data",
  2729. wantStatusCode: http.StatusBadRequest,
  2730. wantResponse: `{"message":"invalid hash format"}`,
  2731. },
  2732. {
  2733. name: "missing type parameter",
  2734. hash: "2B000001E4",
  2735. queryParams: "",
  2736. requestBody: "binary data",
  2737. wantStatusCode: http.StatusBadRequest,
  2738. wantResponse: `{"message":"type query parameter is required"}`,
  2739. },
  2740. {
  2741. name: "invalid type parameter",
  2742. hash: "2B000001E4",
  2743. queryParams: "?type=invalid",
  2744. requestBody: "binary data",
  2745. wantStatusCode: http.StatusBadRequest,
  2746. wantResponse: `{"message":"invalid type ID"}`,
  2747. },
  2748. {
  2749. name: "failed to read request body",
  2750. hash: "2B000001E4",
  2751. queryParams: "?type=1",
  2752. requestBody: "", // This will cause an error when reading
  2753. wantStatusCode: http.StatusBadRequest,
  2754. wantResponse: `{"message":"failed to read request body"}`,
  2755. },
  2756. {
  2757. name: "asset already exists",
  2758. hash: "2B000001E4",
  2759. queryParams: "?type=1",
  2760. requestBody: "binary data",
  2761. wantStatusCode: http.StatusConflict,
  2762. wantResponse: `{"message":"BART asset already exists"}`,
  2763. mockParams: mockParams{
  2764. bartAssetManagerParams: bartAssetManagerParams{
  2765. insertBARTItemParams: insertBARTItemParams{
  2766. {
  2767. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2768. blob: []byte("binary data"),
  2769. itemType: 1,
  2770. err: state.ErrBARTItemExists,
  2771. },
  2772. },
  2773. },
  2774. },
  2775. },
  2776. {
  2777. name: "internal server error",
  2778. hash: "2B000001E4",
  2779. queryParams: "?type=1",
  2780. requestBody: "binary data",
  2781. wantStatusCode: http.StatusInternalServerError,
  2782. wantResponse: `{"message":"internal server error"}`,
  2783. mockParams: mockParams{
  2784. bartAssetManagerParams: bartAssetManagerParams{
  2785. insertBARTItemParams: insertBARTItemParams{
  2786. {
  2787. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2788. blob: []byte("binary data"),
  2789. itemType: 1,
  2790. err: errors.New("database error"),
  2791. },
  2792. },
  2793. },
  2794. },
  2795. },
  2796. }
  2797. for _, tc := range tt {
  2798. t.Run(tc.name, func(t *testing.T) {
  2799. var requestBody io.Reader
  2800. if tc.requestBody != "" {
  2801. requestBody = strings.NewReader(tc.requestBody)
  2802. } else {
  2803. requestBody = &errorReader{}
  2804. }
  2805. request := httptest.NewRequest(http.MethodPost, "/bart/"+tc.hash+tc.queryParams, requestBody)
  2806. // Set the path value manually for testing
  2807. if tc.hash != "" {
  2808. request.SetPathValue("hash", tc.hash)
  2809. }
  2810. responseRecorder := httptest.NewRecorder()
  2811. mockBARTManager := newMockBARTAssetManager(t)
  2812. for _, params := range tc.mockParams.insertBARTItemParams {
  2813. mockBARTManager.EXPECT().
  2814. InsertBARTItem(matchContext(), params.hash, params.blob, params.itemType).
  2815. Return(params.err)
  2816. }
  2817. postBARTHandler(responseRecorder, request, mockBARTManager, slog.Default())
  2818. assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
  2819. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  2820. })
  2821. }
  2822. }
  2823. func TestBARTHandler_DELETE(t *testing.T) {
  2824. tt := []struct {
  2825. name string
  2826. hash string
  2827. wantStatusCode int
  2828. wantResponse string
  2829. mockParams mockParams
  2830. }{
  2831. {
  2832. name: "success with valid hash",
  2833. hash: "2B000001E4",
  2834. wantStatusCode: http.StatusOK,
  2835. wantResponse: `{"message":"BART asset deleted successfully."}`,
  2836. mockParams: mockParams{
  2837. bartAssetManagerParams: bartAssetManagerParams{
  2838. deleteBARTItemParams: deleteBARTItemParams{
  2839. {
  2840. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2841. err: nil,
  2842. },
  2843. },
  2844. },
  2845. },
  2846. },
  2847. {
  2848. name: "missing hash parameter",
  2849. hash: "",
  2850. wantStatusCode: http.StatusBadRequest,
  2851. wantResponse: `{"message":"hash path parameter is required"}`,
  2852. },
  2853. {
  2854. name: "invalid hash format",
  2855. hash: "invalid-hex",
  2856. wantStatusCode: http.StatusBadRequest,
  2857. wantResponse: `{"message":"invalid hash format"}`,
  2858. },
  2859. {
  2860. name: "asset not found",
  2861. hash: "2B000001E4",
  2862. wantStatusCode: http.StatusNotFound,
  2863. wantResponse: `{"message":"BART asset not found"}`,
  2864. mockParams: mockParams{
  2865. bartAssetManagerParams: bartAssetManagerParams{
  2866. deleteBARTItemParams: deleteBARTItemParams{
  2867. {
  2868. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2869. err: state.ErrBARTItemNotFound,
  2870. },
  2871. },
  2872. },
  2873. },
  2874. },
  2875. {
  2876. name: "internal server error",
  2877. hash: "2B000001E4",
  2878. wantStatusCode: http.StatusInternalServerError,
  2879. wantResponse: `{"message":"internal server error"}`,
  2880. mockParams: mockParams{
  2881. bartAssetManagerParams: bartAssetManagerParams{
  2882. deleteBARTItemParams: deleteBARTItemParams{
  2883. {
  2884. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2885. err: errors.New("database error"),
  2886. },
  2887. },
  2888. },
  2889. },
  2890. },
  2891. }
  2892. for _, tc := range tt {
  2893. t.Run(tc.name, func(t *testing.T) {
  2894. request := httptest.NewRequest(http.MethodDelete, "/bart/"+tc.hash, nil)
  2895. // Set the path value manually for testing
  2896. if tc.hash != "" {
  2897. request.SetPathValue("hash", tc.hash)
  2898. }
  2899. responseRecorder := httptest.NewRecorder()
  2900. mockBARTManager := newMockBARTAssetManager(t)
  2901. for _, params := range tc.mockParams.deleteBARTItemParams {
  2902. mockBARTManager.EXPECT().
  2903. DeleteBARTItem(matchContext(), params.hash).
  2904. Return(params.err)
  2905. }
  2906. deleteBARTHandler(responseRecorder, request, mockBARTManager, slog.Default())
  2907. assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
  2908. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  2909. })
  2910. }
  2911. }
  2912. // errorReader is a helper type that always returns an error when reading
  2913. type errorReader struct{}
  2914. func (er *errorReader) Read(p []byte) (n int, err error) {
  2915. return 0, errors.New("read error")
  2916. }
  2917. func TestFeedbagBuddyHandler_GET(t *testing.T) {
  2918. tt := []struct {
  2919. name string
  2920. screenName string
  2921. wantStatusCode int
  2922. wantResponse string
  2923. mockParams mockParams
  2924. }{
  2925. {
  2926. name: "empty feedbag",
  2927. screenName: "userA",
  2928. wantStatusCode: http.StatusNotFound,
  2929. wantResponse: `{"message":"feedbag not found"}`,
  2930. mockParams: mockParams{
  2931. feedbagManagerParams: feedbagManagerParams{
  2932. feedbagParams: feedbagParams{
  2933. {
  2934. screenName: state.NewIdentScreenName("userA"),
  2935. result: []wire.FeedbagItem{},
  2936. err: nil,
  2937. },
  2938. },
  2939. },
  2940. },
  2941. },
  2942. {
  2943. name: "feedbag with buddies in groups",
  2944. screenName: "userA",
  2945. wantStatusCode: http.StatusOK,
  2946. wantResponse: `[{"group_id":1,"group_name":"Friends","buddies":[{"name":"buddy1","item_id":10},{"name":"buddy2","item_id":11}]},{"group_id":2,"group_name":"Work","buddies":[{"name":"buddy3","item_id":20}]}]`,
  2947. mockParams: mockParams{
  2948. feedbagManagerParams: feedbagManagerParams{
  2949. feedbagParams: feedbagParams{
  2950. {
  2951. screenName: state.NewIdentScreenName("userA"),
  2952. result: []wire.FeedbagItem{
  2953. {
  2954. ItemID: 0,
  2955. ClassID: wire.FeedbagClassIdGroup,
  2956. Name: "",
  2957. GroupID: 0,
  2958. },
  2959. {
  2960. ItemID: 1,
  2961. ClassID: wire.FeedbagClassIdGroup,
  2962. Name: "Friends",
  2963. GroupID: 1,
  2964. TLVLBlock: wire.TLVLBlock{
  2965. TLVList: wire.TLVList{
  2966. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{10, 11}),
  2967. },
  2968. },
  2969. },
  2970. {
  2971. ItemID: 2,
  2972. ClassID: wire.FeedbagClassIdGroup,
  2973. Name: "Work",
  2974. GroupID: 2,
  2975. TLVLBlock: wire.TLVLBlock{
  2976. TLVList: wire.TLVList{
  2977. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{20}),
  2978. },
  2979. },
  2980. },
  2981. {
  2982. ItemID: 10,
  2983. ClassID: wire.FeedbagClassIdBuddy,
  2984. Name: "buddy1",
  2985. GroupID: 1,
  2986. },
  2987. {
  2988. ItemID: 11,
  2989. ClassID: wire.FeedbagClassIdBuddy,
  2990. Name: "buddy2",
  2991. GroupID: 1,
  2992. },
  2993. {
  2994. ItemID: 20,
  2995. ClassID: wire.FeedbagClassIdBuddy,
  2996. Name: "buddy3",
  2997. GroupID: 2,
  2998. },
  2999. },
  3000. err: nil,
  3001. },
  3002. },
  3003. },
  3004. },
  3005. },
  3006. {
  3007. name: "feedbag with no groups (besides root)",
  3008. screenName: "userA",
  3009. wantStatusCode: http.StatusOK,
  3010. wantResponse: `[]`,
  3011. mockParams: mockParams{
  3012. feedbagManagerParams: feedbagManagerParams{
  3013. feedbagParams: feedbagParams{
  3014. {
  3015. screenName: state.NewIdentScreenName("userA"),
  3016. result: []wire.FeedbagItem{
  3017. {
  3018. ItemID: 0,
  3019. ClassID: wire.FeedbagClassIdGroup,
  3020. Name: "",
  3021. GroupID: 0,
  3022. },
  3023. },
  3024. err: nil,
  3025. },
  3026. },
  3027. },
  3028. },
  3029. // Note: Root groups (GroupID == 0) are skipped by the implementation,
  3030. // so the response will be an empty array []
  3031. },
  3032. {
  3033. name: "missing screen_name",
  3034. screenName: "",
  3035. wantStatusCode: http.StatusBadRequest,
  3036. wantResponse: `{"message":"screen_name is required"}`,
  3037. },
  3038. {
  3039. name: "internal server error",
  3040. screenName: "userA",
  3041. wantStatusCode: http.StatusInternalServerError,
  3042. wantResponse: `{"message":"internal server error"}`,
  3043. mockParams: mockParams{
  3044. feedbagManagerParams: feedbagManagerParams{
  3045. feedbagParams: feedbagParams{
  3046. {
  3047. screenName: state.NewIdentScreenName("userA"),
  3048. result: nil,
  3049. err: errors.New("database error"),
  3050. },
  3051. },
  3052. },
  3053. },
  3054. },
  3055. }
  3056. for _, tc := range tt {
  3057. t.Run(tc.name, func(t *testing.T) {
  3058. request := httptest.NewRequest(http.MethodGet, "/feedbag/"+tc.screenName+"/group", nil)
  3059. if tc.screenName != "" {
  3060. request.SetPathValue("screen_name", tc.screenName)
  3061. }
  3062. responseRecorder := httptest.NewRecorder()
  3063. feedbagManager := newMockFeedbagManager(t)
  3064. for _, params := range tc.mockParams.feedbagParams {
  3065. feedbagManager.EXPECT().
  3066. Feedbag(matchContext(), params.screenName).
  3067. Return(params.result, params.err)
  3068. }
  3069. getFeedbagBuddyHandler(responseRecorder, request, feedbagManager, slog.Default())
  3070. assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
  3071. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  3072. })
  3073. }
  3074. }
  3075. func TestFeedbagGroupHandler_PUT(t *testing.T) {
  3076. tt := []struct {
  3077. name string
  3078. screenName string
  3079. groupName string
  3080. groupIDGen func(n int) int
  3081. wantStatusCode int
  3082. wantResponse string
  3083. mockParams mockParams
  3084. }{
  3085. {
  3086. name: "add group to empty feedbag",
  3087. screenName: "userA",
  3088. groupName: "Friends",
  3089. groupIDGen: func(n int) int { return 5 },
  3090. wantStatusCode: http.StatusCreated,
  3091. wantResponse: `{"group_id":5,"group_name":"Friends"}`,
  3092. mockParams: mockParams{
  3093. userManagerParams: userManagerParams{
  3094. getUserParams: getUserParams{
  3095. {
  3096. screenName: state.NewIdentScreenName("userA"),
  3097. result: &state.User{IdentScreenName: state.NewIdentScreenName("userA")},
  3098. },
  3099. },
  3100. },
  3101. feedbagManagerParams: feedbagManagerParams{
  3102. feedbagParams: feedbagParams{
  3103. {
  3104. screenName: state.NewIdentScreenName("userA"),
  3105. result: []wire.FeedbagItem{},
  3106. err: nil,
  3107. },
  3108. },
  3109. feedbagUpsertParams: feedbagUpsertParams{
  3110. {
  3111. screenName: state.NewIdentScreenName("userA"),
  3112. items: []wire.FeedbagItem{
  3113. {
  3114. ClassID: wire.FeedbagClassIdGroup,
  3115. GroupID: 0,
  3116. TLVLBlock: wire.TLVLBlock{
  3117. TLVList: wire.TLVList{
  3118. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{5}),
  3119. },
  3120. },
  3121. },
  3122. {
  3123. ClassID: wire.FeedbagClassIdGroup,
  3124. Name: "Friends",
  3125. GroupID: 5,
  3126. },
  3127. },
  3128. err: nil,
  3129. },
  3130. },
  3131. },
  3132. messageRelayerParams: messageRelayerParams{
  3133. relayToScreenNameParams: relayToScreenNameParams{
  3134. {
  3135. screenName: state.NewIdentScreenName("userA"),
  3136. msg: wire.SNACMessage{
  3137. Frame: wire.SNACFrame{
  3138. FoodGroup: wire.Feedbag,
  3139. SubGroup: wire.FeedbagInsertItem,
  3140. RequestID: wire.ReqIDFromServer,
  3141. },
  3142. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  3143. Items: []wire.FeedbagItem{
  3144. {
  3145. ClassID: wire.FeedbagClassIdGroup,
  3146. GroupID: 0,
  3147. TLVLBlock: wire.TLVLBlock{
  3148. TLVList: wire.TLVList{
  3149. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{5}),
  3150. },
  3151. },
  3152. },
  3153. {
  3154. ClassID: wire.FeedbagClassIdGroup,
  3155. Name: "Friends",
  3156. GroupID: 5,
  3157. },
  3158. },
  3159. },
  3160. },
  3161. },
  3162. },
  3163. },
  3164. },
  3165. },
  3166. {
  3167. name: "add group to feedbag with existing root",
  3168. screenName: "userA",
  3169. groupName: "Coworkers",
  3170. groupIDGen: func(n int) int { return 2 },
  3171. wantStatusCode: http.StatusCreated,
  3172. wantResponse: `{"group_id":2,"group_name":"Coworkers"}`,
  3173. mockParams: mockParams{
  3174. userManagerParams: userManagerParams{
  3175. getUserParams: getUserParams{
  3176. {
  3177. screenName: state.NewIdentScreenName("userA"),
  3178. result: &state.User{IdentScreenName: state.NewIdentScreenName("userA")},
  3179. },
  3180. },
  3181. },
  3182. feedbagManagerParams: feedbagManagerParams{
  3183. feedbagParams: feedbagParams{
  3184. {
  3185. screenName: state.NewIdentScreenName("userA"),
  3186. result: []wire.FeedbagItem{
  3187. {
  3188. ClassID: wire.FeedbagClassIdGroup,
  3189. GroupID: 0,
  3190. TLVLBlock: wire.TLVLBlock{
  3191. TLVList: wire.TLVList{
  3192. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1}),
  3193. },
  3194. },
  3195. },
  3196. {
  3197. ClassID: wire.FeedbagClassIdGroup,
  3198. Name: "Buddies",
  3199. GroupID: 1,
  3200. },
  3201. },
  3202. err: nil,
  3203. },
  3204. },
  3205. feedbagUpsertParams: feedbagUpsertParams{
  3206. {
  3207. screenName: state.NewIdentScreenName("userA"),
  3208. items: []wire.FeedbagItem{
  3209. {
  3210. ClassID: wire.FeedbagClassIdGroup,
  3211. GroupID: 0,
  3212. TLVLBlock: wire.TLVLBlock{
  3213. TLVList: wire.TLVList{
  3214. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1, 2}),
  3215. },
  3216. },
  3217. },
  3218. {
  3219. ClassID: wire.FeedbagClassIdGroup,
  3220. Name: "Coworkers",
  3221. GroupID: 2,
  3222. },
  3223. },
  3224. err: nil,
  3225. },
  3226. },
  3227. },
  3228. messageRelayerParams: messageRelayerParams{
  3229. relayToScreenNameParams: relayToScreenNameParams{
  3230. {
  3231. screenName: state.NewIdentScreenName("userA"),
  3232. msg: wire.SNACMessage{
  3233. Frame: wire.SNACFrame{
  3234. FoodGroup: wire.Feedbag,
  3235. SubGroup: wire.FeedbagInsertItem,
  3236. RequestID: wire.ReqIDFromServer,
  3237. },
  3238. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  3239. Items: []wire.FeedbagItem{
  3240. {
  3241. ClassID: wire.FeedbagClassIdGroup,
  3242. GroupID: 0,
  3243. TLVLBlock: wire.TLVLBlock{
  3244. TLVList: wire.TLVList{
  3245. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1, 2}),
  3246. },
  3247. },
  3248. },
  3249. {
  3250. ClassID: wire.FeedbagClassIdGroup,
  3251. Name: "Coworkers",
  3252. GroupID: 2,
  3253. },
  3254. },
  3255. },
  3256. },
  3257. },
  3258. },
  3259. },
  3260. },
  3261. },
  3262. {
  3263. name: "group already exists",
  3264. screenName: "userA",
  3265. groupName: "Friends",
  3266. groupIDGen: func(n int) int { return 99 },
  3267. wantStatusCode: http.StatusOK,
  3268. wantResponse: `{"group_id":1,"group_name":"Friends"}`,
  3269. mockParams: mockParams{
  3270. userManagerParams: userManagerParams{
  3271. getUserParams: getUserParams{
  3272. {
  3273. screenName: state.NewIdentScreenName("userA"),
  3274. result: &state.User{IdentScreenName: state.NewIdentScreenName("userA")},
  3275. },
  3276. },
  3277. },
  3278. feedbagManagerParams: feedbagManagerParams{
  3279. feedbagParams: feedbagParams{
  3280. {
  3281. screenName: state.NewIdentScreenName("userA"),
  3282. result: []wire.FeedbagItem{
  3283. {
  3284. ClassID: wire.FeedbagClassIdGroup,
  3285. GroupID: 0,
  3286. },
  3287. {
  3288. ClassID: wire.FeedbagClassIdGroup,
  3289. Name: "Friends",
  3290. GroupID: 1,
  3291. },
  3292. },
  3293. err: nil,
  3294. },
  3295. },
  3296. },
  3297. },
  3298. },
  3299. {
  3300. name: "missing screen_name",
  3301. screenName: "",
  3302. groupName: "Friends",
  3303. groupIDGen: func(n int) int { return 5 },
  3304. wantStatusCode: http.StatusBadRequest,
  3305. wantResponse: `{"message":"screen_name is required"}`,
  3306. },
  3307. {
  3308. name: "missing group_name",
  3309. screenName: "userA",
  3310. groupName: "",
  3311. groupIDGen: func(n int) int { return 5 },
  3312. wantStatusCode: http.StatusBadRequest,
  3313. wantResponse: `{"message":"group_name is required"}`,
  3314. },
  3315. {
  3316. name: "user not found",
  3317. screenName: "userA",
  3318. groupName: "Friends",
  3319. groupIDGen: func(n int) int { return 5 },
  3320. wantStatusCode: http.StatusNotFound,
  3321. wantResponse: `{"message":"user not found"}`,
  3322. mockParams: mockParams{
  3323. userManagerParams: userManagerParams{
  3324. getUserParams: getUserParams{
  3325. {
  3326. screenName: state.NewIdentScreenName("userA"),
  3327. result: nil,
  3328. },
  3329. },
  3330. },
  3331. },
  3332. },
  3333. {
  3334. name: "error retrieving user",
  3335. screenName: "userA",
  3336. groupName: "Friends",
  3337. groupIDGen: func(n int) int { return 5 },
  3338. wantStatusCode: http.StatusInternalServerError,
  3339. wantResponse: `{"message":"internal server error"}`,
  3340. mockParams: mockParams{
  3341. userManagerParams: userManagerParams{
  3342. getUserParams: getUserParams{
  3343. {
  3344. screenName: state.NewIdentScreenName("userA"),
  3345. err: errors.New("database error"),
  3346. },
  3347. },
  3348. },
  3349. },
  3350. },
  3351. {
  3352. name: "error retrieving feedbag",
  3353. screenName: "userA",
  3354. groupName: "Friends",
  3355. groupIDGen: func(n int) int { return 5 },
  3356. wantStatusCode: http.StatusInternalServerError,
  3357. wantResponse: `{"message":"internal server error"}`,
  3358. mockParams: mockParams{
  3359. userManagerParams: userManagerParams{
  3360. getUserParams: getUserParams{
  3361. {
  3362. screenName: state.NewIdentScreenName("userA"),
  3363. result: &state.User{IdentScreenName: state.NewIdentScreenName("userA")},
  3364. },
  3365. },
  3366. },
  3367. feedbagManagerParams: feedbagManagerParams{
  3368. feedbagParams: feedbagParams{
  3369. {
  3370. screenName: state.NewIdentScreenName("userA"),
  3371. result: nil,
  3372. err: errors.New("database error"),
  3373. },
  3374. },
  3375. },
  3376. },
  3377. },
  3378. {
  3379. name: "error upserting feedbag",
  3380. screenName: "userA",
  3381. groupName: "Friends",
  3382. groupIDGen: func(n int) int { return 5 },
  3383. wantStatusCode: http.StatusInternalServerError,
  3384. wantResponse: `{"message":"internal server error"}`,
  3385. mockParams: mockParams{
  3386. userManagerParams: userManagerParams{
  3387. getUserParams: getUserParams{
  3388. {
  3389. screenName: state.NewIdentScreenName("userA"),
  3390. result: &state.User{IdentScreenName: state.NewIdentScreenName("userA")},
  3391. },
  3392. },
  3393. },
  3394. feedbagManagerParams: feedbagManagerParams{
  3395. feedbagParams: feedbagParams{
  3396. {
  3397. screenName: state.NewIdentScreenName("userA"),
  3398. result: []wire.FeedbagItem{},
  3399. err: nil,
  3400. },
  3401. },
  3402. feedbagUpsertParams: feedbagUpsertParams{
  3403. {
  3404. screenName: state.NewIdentScreenName("userA"),
  3405. items: []wire.FeedbagItem{
  3406. {
  3407. ClassID: wire.FeedbagClassIdGroup,
  3408. GroupID: 0,
  3409. TLVLBlock: wire.TLVLBlock{
  3410. TLVList: wire.TLVList{
  3411. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{5}),
  3412. },
  3413. },
  3414. },
  3415. {
  3416. ClassID: wire.FeedbagClassIdGroup,
  3417. Name: "Friends",
  3418. GroupID: 5,
  3419. },
  3420. },
  3421. err: errors.New("database error"),
  3422. },
  3423. },
  3424. },
  3425. },
  3426. },
  3427. }
  3428. for _, tc := range tt {
  3429. t.Run(tc.name, func(t *testing.T) {
  3430. request := httptest.NewRequest(http.MethodPut, "/feedbag/"+tc.screenName+"/group/"+tc.groupName, nil)
  3431. if tc.screenName != "" {
  3432. request.SetPathValue("screen_name", tc.screenName)
  3433. }
  3434. if tc.groupName != "" {
  3435. request.SetPathValue("group_name", tc.groupName)
  3436. }
  3437. responseRecorder := httptest.NewRecorder()
  3438. userManager := newMockUserManager(t)
  3439. for _, params := range tc.mockParams.getUserParams {
  3440. userManager.EXPECT().
  3441. User(matchContext(), params.screenName).
  3442. Return(params.result, params.err)
  3443. }
  3444. feedbagManager := newMockFeedbagManager(t)
  3445. messageRelayer := newMockMessageRelayer(t)
  3446. for _, params := range tc.mockParams.feedbagParams {
  3447. feedbagManager.EXPECT().
  3448. Feedbag(matchContext(), params.screenName).
  3449. Return(params.result, params.err)
  3450. }
  3451. for _, params := range tc.mockParams.feedbagUpsertParams {
  3452. feedbagManager.EXPECT().
  3453. FeedbagUpsert(matchContext(), params.screenName, params.items).
  3454. Return(params.err)
  3455. }
  3456. for _, params := range tc.mockParams.relayToScreenNameParams {
  3457. messageRelayer.EXPECT().
  3458. RelayToScreenName(matchContext(), params.screenName, params.msg)
  3459. }
  3460. putFeedbagGroupHandler(responseRecorder, request, userManager, feedbagManager, messageRelayer, slog.Default(), tc.groupIDGen)
  3461. assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
  3462. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  3463. })
  3464. }
  3465. }
  3466. func TestFeedbagBuddyHandler_PUT(t *testing.T) {
  3467. tt := []struct {
  3468. name string
  3469. screenName string
  3470. groupID string
  3471. requestBody string
  3472. wantStatusCode int
  3473. wantResponse string
  3474. mockParams mockParams
  3475. }{
  3476. {
  3477. name: "add a buddy to an empty group, user not signed in",
  3478. screenName: "userA",
  3479. groupID: "1",
  3480. requestBody: `{"name":"newbuddy"}`,
  3481. wantStatusCode: http.StatusOK,
  3482. wantResponse: `{"name":"newbuddy","group_id":1,"item_id":1000}`,
  3483. mockParams: mockParams{
  3484. feedbagManagerParams: feedbagManagerParams{
  3485. feedbagParams: feedbagParams{
  3486. {
  3487. screenName: state.NewIdentScreenName("userA"),
  3488. result: []wire.FeedbagItem{
  3489. {
  3490. ClassID: wire.FeedbagClassIdGroup,
  3491. Name: "Friends",
  3492. GroupID: 1,
  3493. },
  3494. },
  3495. err: nil,
  3496. },
  3497. },
  3498. feedbagUpsertParams: feedbagUpsertParams{
  3499. {
  3500. screenName: state.NewIdentScreenName("userA"),
  3501. items: []wire.FeedbagItem{
  3502. {
  3503. Name: "newbuddy",
  3504. GroupID: 1,
  3505. ItemID: 1000,
  3506. ClassID: wire.FeedbagClassIdBuddy,
  3507. },
  3508. {
  3509. ClassID: wire.FeedbagClassIdGroup,
  3510. Name: "Friends",
  3511. GroupID: 1,
  3512. TLVLBlock: wire.TLVLBlock{
  3513. TLVList: wire.TLVList{
  3514. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1000}),
  3515. },
  3516. },
  3517. },
  3518. },
  3519. err: nil,
  3520. },
  3521. },
  3522. },
  3523. sessionRetrieverParams: sessionRetrieverParams{
  3524. retrieveSessionByNameParams: retrieveSessionByNameParams{
  3525. {
  3526. screenName: state.NewIdentScreenName("userA"),
  3527. result: state.NewSession(),
  3528. },
  3529. },
  3530. },
  3531. messageRelayerParams: messageRelayerParams{
  3532. relayToScreenNameParams: relayToScreenNameParams{
  3533. {
  3534. screenName: state.NewIdentScreenName("userA"),
  3535. msg: wire.SNACMessage{
  3536. Frame: wire.SNACFrame{
  3537. FoodGroup: wire.Feedbag,
  3538. SubGroup: wire.FeedbagInsertItem,
  3539. RequestID: wire.ReqIDFromServer,
  3540. },
  3541. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  3542. Items: []wire.FeedbagItem{
  3543. {
  3544. Name: "newbuddy",
  3545. GroupID: 1,
  3546. ItemID: 1000,
  3547. ClassID: wire.FeedbagClassIdBuddy,
  3548. },
  3549. },
  3550. },
  3551. },
  3552. },
  3553. {
  3554. screenName: state.NewIdentScreenName("userA"),
  3555. msg: wire.SNACMessage{
  3556. Frame: wire.SNACFrame{
  3557. FoodGroup: wire.Feedbag,
  3558. SubGroup: wire.FeedbagUpdateItem,
  3559. RequestID: wire.ReqIDFromServer,
  3560. },
  3561. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  3562. Items: []wire.FeedbagItem{
  3563. {
  3564. ClassID: wire.FeedbagClassIdGroup,
  3565. Name: "Friends",
  3566. GroupID: 1,
  3567. TLVLBlock: wire.TLVLBlock{
  3568. TLVList: wire.TLVList{
  3569. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1000}),
  3570. },
  3571. },
  3572. },
  3573. },
  3574. },
  3575. },
  3576. },
  3577. },
  3578. },
  3579. },
  3580. },
  3581. {
  3582. name: "add a buddy to a non-empty group, user not signed in",
  3583. screenName: "userA",
  3584. groupID: "1",
  3585. requestBody: `{"name":"newbuddy2"}`,
  3586. wantStatusCode: http.StatusOK,
  3587. wantResponse: `{"name":"newbuddy2","group_id":1,"item_id":1000}`,
  3588. mockParams: mockParams{
  3589. feedbagManagerParams: feedbagManagerParams{
  3590. feedbagParams: feedbagParams{
  3591. {
  3592. screenName: state.NewIdentScreenName("userA"),
  3593. result: []wire.FeedbagItem{
  3594. {
  3595. ClassID: wire.FeedbagClassIdGroup,
  3596. Name: "Friends",
  3597. GroupID: 1,
  3598. TLVLBlock: wire.TLVLBlock{
  3599. TLVList: wire.TLVList{
  3600. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{12345}),
  3601. },
  3602. },
  3603. },
  3604. {
  3605. ItemID: 12345,
  3606. ClassID: wire.FeedbagClassIdBuddy,
  3607. Name: "existingbuddy",
  3608. GroupID: 1,
  3609. },
  3610. },
  3611. err: nil,
  3612. },
  3613. },
  3614. feedbagUpsertParams: feedbagUpsertParams{
  3615. {
  3616. screenName: state.NewIdentScreenName("userA"),
  3617. items: []wire.FeedbagItem{
  3618. {
  3619. Name: "newbuddy2",
  3620. GroupID: 1,
  3621. ItemID: 1000,
  3622. ClassID: wire.FeedbagClassIdBuddy,
  3623. },
  3624. {
  3625. ClassID: wire.FeedbagClassIdGroup,
  3626. Name: "Friends",
  3627. GroupID: 1,
  3628. TLVLBlock: wire.TLVLBlock{
  3629. TLVList: wire.TLVList{
  3630. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{12345, 1000}),
  3631. },
  3632. },
  3633. },
  3634. },
  3635. err: nil,
  3636. },
  3637. },
  3638. },
  3639. sessionRetrieverParams: sessionRetrieverParams{
  3640. retrieveSessionByNameParams: retrieveSessionByNameParams{
  3641. {
  3642. screenName: state.NewIdentScreenName("userA"),
  3643. result: state.NewSession(),
  3644. },
  3645. },
  3646. },
  3647. messageRelayerParams: messageRelayerParams{
  3648. relayToScreenNameParams: relayToScreenNameParams{
  3649. {
  3650. screenName: state.NewIdentScreenName("userA"),
  3651. msg: wire.SNACMessage{
  3652. Frame: wire.SNACFrame{
  3653. FoodGroup: wire.Feedbag,
  3654. SubGroup: wire.FeedbagInsertItem,
  3655. RequestID: wire.ReqIDFromServer,
  3656. },
  3657. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  3658. Items: []wire.FeedbagItem{
  3659. {
  3660. Name: "newbuddy2",
  3661. GroupID: 1,
  3662. ItemID: 1000,
  3663. ClassID: wire.FeedbagClassIdBuddy,
  3664. },
  3665. },
  3666. },
  3667. },
  3668. },
  3669. {
  3670. screenName: state.NewIdentScreenName("userA"),
  3671. msg: wire.SNACMessage{
  3672. Frame: wire.SNACFrame{
  3673. FoodGroup: wire.Feedbag,
  3674. SubGroup: wire.FeedbagUpdateItem,
  3675. RequestID: wire.ReqIDFromServer,
  3676. },
  3677. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  3678. Items: []wire.FeedbagItem{
  3679. {
  3680. ClassID: wire.FeedbagClassIdGroup,
  3681. Name: "Friends",
  3682. GroupID: 1,
  3683. TLVLBlock: wire.TLVLBlock{
  3684. TLVList: wire.TLVList{
  3685. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{12345, 1000}),
  3686. },
  3687. },
  3688. },
  3689. },
  3690. },
  3691. },
  3692. },
  3693. },
  3694. },
  3695. },
  3696. },
  3697. {
  3698. name: "add a buddy that already exists in a group",
  3699. screenName: "userA",
  3700. groupID: "1",
  3701. requestBody: `{"name":"ExistingBuddy"}`,
  3702. wantStatusCode: http.StatusOK,
  3703. wantResponse: `{"name":"ExistingBuddy","group_id":1,"item_id":12345}`,
  3704. mockParams: mockParams{
  3705. feedbagManagerParams: feedbagManagerParams{
  3706. feedbagParams: feedbagParams{
  3707. {
  3708. screenName: state.NewIdentScreenName("userA"),
  3709. result: []wire.FeedbagItem{
  3710. {
  3711. ClassID: wire.FeedbagClassIdGroup,
  3712. Name: "Friends",
  3713. GroupID: 1,
  3714. TLVLBlock: wire.TLVLBlock{
  3715. TLVList: wire.TLVList{
  3716. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{12345}),
  3717. },
  3718. },
  3719. },
  3720. {
  3721. ItemID: 12345,
  3722. ClassID: wire.FeedbagClassIdBuddy,
  3723. Name: "existingbuddy",
  3724. GroupID: 1,
  3725. },
  3726. },
  3727. err: nil,
  3728. },
  3729. },
  3730. // No FeedbagUpsert should be called when buddy already exists
  3731. },
  3732. // No session retrieval or message relaying should occur
  3733. },
  3734. },
  3735. {
  3736. name: "add a buddy to an empty group, user signed in",
  3737. screenName: "userA",
  3738. groupID: "1",
  3739. requestBody: `{"name":"newbuddy"}`,
  3740. wantStatusCode: http.StatusOK,
  3741. wantResponse: `{"name":"newbuddy","group_id":1,"item_id":1000}`,
  3742. mockParams: mockParams{
  3743. feedbagManagerParams: feedbagManagerParams{
  3744. feedbagParams: feedbagParams{
  3745. {
  3746. screenName: state.NewIdentScreenName("userA"),
  3747. result: []wire.FeedbagItem{
  3748. {
  3749. ClassID: wire.FeedbagClassIdGroup,
  3750. Name: "Friends",
  3751. GroupID: 1,
  3752. },
  3753. },
  3754. err: nil,
  3755. },
  3756. },
  3757. feedbagUpsertParams: feedbagUpsertParams{
  3758. {
  3759. screenName: state.NewIdentScreenName("userA"),
  3760. items: []wire.FeedbagItem{
  3761. {
  3762. Name: "newbuddy",
  3763. GroupID: 1,
  3764. ItemID: 1000,
  3765. ClassID: wire.FeedbagClassIdBuddy,
  3766. },
  3767. {
  3768. ClassID: wire.FeedbagClassIdGroup,
  3769. Name: "Friends",
  3770. GroupID: 1,
  3771. TLVLBlock: wire.TLVLBlock{
  3772. TLVList: wire.TLVList{
  3773. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1000}),
  3774. },
  3775. },
  3776. },
  3777. },
  3778. err: nil,
  3779. },
  3780. },
  3781. },
  3782. sessionRetrieverParams: sessionRetrieverParams{
  3783. retrieveSessionByNameParams: retrieveSessionByNameParams{
  3784. {
  3785. screenName: state.NewIdentScreenName("userA"),
  3786. result: func() *state.Session {
  3787. sess := state.NewSession()
  3788. sess.SetIdentScreenName(state.NewIdentScreenName("userA"))
  3789. inst := sess.AddInstance()
  3790. inst.SetSignonComplete()
  3791. return sess
  3792. }(),
  3793. },
  3794. },
  3795. },
  3796. messageRelayerParams: messageRelayerParams{
  3797. relayToScreenNameParams: relayToScreenNameParams{
  3798. {
  3799. screenName: state.NewIdentScreenName("userA"),
  3800. msg: wire.SNACMessage{
  3801. Frame: wire.SNACFrame{
  3802. FoodGroup: wire.Feedbag,
  3803. SubGroup: wire.FeedbagInsertItem,
  3804. RequestID: wire.ReqIDFromServer,
  3805. },
  3806. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  3807. Items: []wire.FeedbagItem{
  3808. {
  3809. Name: "newbuddy",
  3810. GroupID: 1,
  3811. ItemID: 1000,
  3812. ClassID: wire.FeedbagClassIdBuddy,
  3813. },
  3814. },
  3815. },
  3816. },
  3817. },
  3818. {
  3819. screenName: state.NewIdentScreenName("userA"),
  3820. msg: wire.SNACMessage{
  3821. Frame: wire.SNACFrame{
  3822. FoodGroup: wire.Feedbag,
  3823. SubGroup: wire.FeedbagUpdateItem,
  3824. RequestID: wire.ReqIDFromServer,
  3825. },
  3826. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  3827. Items: []wire.FeedbagItem{
  3828. {
  3829. ClassID: wire.FeedbagClassIdGroup,
  3830. Name: "Friends",
  3831. GroupID: 1,
  3832. TLVLBlock: wire.TLVLBlock{
  3833. TLVList: wire.TLVList{
  3834. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1000}),
  3835. },
  3836. },
  3837. },
  3838. },
  3839. },
  3840. },
  3841. },
  3842. },
  3843. },
  3844. buddyBroadcasterParams: buddyBroadcasterParams{
  3845. broadcastVisibilityParams: broadcastVisibilityParams{
  3846. {
  3847. you: nil, // Not used in expectation, matched with mock.AnythingOfType
  3848. filter: []state.IdentScreenName{state.NewIdentScreenName("newbuddy")},
  3849. sendDepartures: false,
  3850. err: nil,
  3851. },
  3852. },
  3853. },
  3854. },
  3855. },
  3856. {
  3857. name: "invalid group_id - non-numeric",
  3858. screenName: "userA",
  3859. groupID: "invalid",
  3860. requestBody: `{"name":"buddy"}`,
  3861. wantStatusCode: http.StatusBadRequest,
  3862. wantResponse: `{"message":"invalid group_id"}`,
  3863. },
  3864. {
  3865. name: "invalid group_id - out of range",
  3866. screenName: "userA",
  3867. groupID: "99999",
  3868. requestBody: `{"name":"buddy"}`,
  3869. wantStatusCode: http.StatusBadRequest,
  3870. wantResponse: `{"message":"invalid group_id"}`,
  3871. },
  3872. {
  3873. name: "can't add buddies to root group",
  3874. screenName: "userA",
  3875. groupID: "0",
  3876. requestBody: `{"name":"buddy"}`,
  3877. wantStatusCode: http.StatusBadRequest,
  3878. wantResponse: `{"message":"can't add buddies to root group"}`,
  3879. },
  3880. {
  3881. name: "empty screen_name",
  3882. screenName: "",
  3883. groupID: "1",
  3884. requestBody: `{"name":"buddy"}`,
  3885. wantStatusCode: http.StatusBadRequest,
  3886. wantResponse: `{"message":"screen_name is required"}`,
  3887. },
  3888. {
  3889. name: "malformed JSON input",
  3890. screenName: "userA",
  3891. groupID: "1",
  3892. requestBody: `invalid json`,
  3893. wantStatusCode: http.StatusBadRequest,
  3894. wantResponse: `{"message":"buddy_screen_name is required"}`,
  3895. },
  3896. {
  3897. name: "empty name in request body",
  3898. screenName: "userA",
  3899. groupID: "1",
  3900. requestBody: `{"name":""}`,
  3901. wantStatusCode: http.StatusBadRequest,
  3902. wantResponse: `{"message":"buddy_screen_name is required"}`,
  3903. },
  3904. {
  3905. name: "missing name in request body",
  3906. screenName: "userA",
  3907. groupID: "1",
  3908. requestBody: `{}`,
  3909. wantStatusCode: http.StatusBadRequest,
  3910. wantResponse: `{"message":"buddy_screen_name is required"}`,
  3911. },
  3912. {
  3913. name: "invalid UIN - too low",
  3914. screenName: "userA",
  3915. groupID: "1",
  3916. requestBody: `{"name":"9999"}`,
  3917. wantStatusCode: http.StatusBadRequest,
  3918. wantResponse: `{"message":"invalid uin: uin must be a number in the range 10000-2147483646"}`,
  3919. },
  3920. {
  3921. name: "invalid UIN - too high",
  3922. screenName: "userA",
  3923. groupID: "1",
  3924. requestBody: `{"name":"2147483647"}`,
  3925. wantStatusCode: http.StatusBadRequest,
  3926. wantResponse: `{"message":"invalid uin: uin must be a number in the range 10000-2147483646"}`,
  3927. },
  3928. {
  3929. name: "invalid AIM handle - too short",
  3930. screenName: "userA",
  3931. groupID: "1",
  3932. requestBody: `{"name":"Us"}`,
  3933. wantStatusCode: http.StatusBadRequest,
  3934. wantResponse: `{"message":"invalid screen name: screen name must be between 3 and 16 characters"}`,
  3935. },
  3936. {
  3937. name: "invalid AIM handle - too long",
  3938. screenName: "userA",
  3939. groupID: "1",
  3940. requestBody: `{"name":"ThisIsAReallyLongScreenName"}`,
  3941. wantStatusCode: http.StatusBadRequest,
  3942. wantResponse: `{"message":"invalid screen name: screen name must be between 3 and 16 characters"}`,
  3943. },
  3944. {
  3945. name: "error retrieving feedbag",
  3946. screenName: "userA",
  3947. groupID: "1",
  3948. requestBody: `{"name":"buddy"}`,
  3949. wantStatusCode: http.StatusInternalServerError,
  3950. wantResponse: `{"message":"internal server error"}`,
  3951. mockParams: mockParams{
  3952. feedbagManagerParams: feedbagManagerParams{
  3953. feedbagParams: feedbagParams{
  3954. {
  3955. screenName: state.NewIdentScreenName("userA"),
  3956. result: nil,
  3957. err: errors.New("database error"),
  3958. },
  3959. },
  3960. },
  3961. },
  3962. },
  3963. {
  3964. name: "too many buddies in group - max 30",
  3965. screenName: "userA",
  3966. groupID: "1",
  3967. requestBody: `{"name":"newbuddy"}`,
  3968. wantStatusCode: http.StatusBadRequest,
  3969. wantResponse: `{"message":"too many buddies in group. max: 30"}`,
  3970. mockParams: mockParams{
  3971. feedbagManagerParams: feedbagManagerParams{
  3972. feedbagParams: feedbagParams{
  3973. {
  3974. screenName: state.NewIdentScreenName("userA"),
  3975. result: func() []wire.FeedbagItem {
  3976. order := make([]uint16, 30)
  3977. for i := 1; i <= 30; i++ {
  3978. order[i-1] = uint16(i)
  3979. }
  3980. items := []wire.FeedbagItem{
  3981. {
  3982. ClassID: wire.FeedbagClassIdGroup,
  3983. Name: "Friends",
  3984. GroupID: 1,
  3985. TLVLBlock: wire.TLVLBlock{
  3986. TLVList: wire.TLVList{
  3987. wire.NewTLVBE(wire.FeedbagAttributesOrder, order),
  3988. },
  3989. },
  3990. },
  3991. }
  3992. // Add 30 buddies to the group
  3993. for i := 1; i <= 30; i++ {
  3994. items = append(items, wire.FeedbagItem{
  3995. ItemID: uint16(i),
  3996. ClassID: wire.FeedbagClassIdBuddy,
  3997. Name: fmt.Sprintf("buddy%d", i),
  3998. GroupID: 1,
  3999. })
  4000. }
  4001. return items
  4002. }(),
  4003. err: nil,
  4004. },
  4005. },
  4006. },
  4007. },
  4008. },
  4009. {
  4010. name: "group not found",
  4011. screenName: "userA",
  4012. groupID: "999",
  4013. requestBody: `{"name":"buddy"}`,
  4014. wantStatusCode: http.StatusNotFound,
  4015. wantResponse: `{"message":"group not found"}`,
  4016. mockParams: mockParams{
  4017. feedbagManagerParams: feedbagManagerParams{
  4018. feedbagParams: feedbagParams{
  4019. {
  4020. screenName: state.NewIdentScreenName("userA"),
  4021. result: []wire.FeedbagItem{
  4022. {
  4023. ClassID: wire.FeedbagClassIdGroup,
  4024. Name: "Friends",
  4025. GroupID: 1,
  4026. },
  4027. },
  4028. err: nil,
  4029. },
  4030. },
  4031. },
  4032. },
  4033. },
  4034. {
  4035. name: "error inserting feedbag item",
  4036. screenName: "userA",
  4037. groupID: "1",
  4038. requestBody: `{"name":"buddy"}`,
  4039. wantStatusCode: http.StatusInternalServerError,
  4040. wantResponse: `{"message":"internal server error"}`,
  4041. mockParams: mockParams{
  4042. feedbagManagerParams: feedbagManagerParams{
  4043. feedbagParams: feedbagParams{
  4044. {
  4045. screenName: state.NewIdentScreenName("userA"),
  4046. result: []wire.FeedbagItem{
  4047. {
  4048. ClassID: wire.FeedbagClassIdGroup,
  4049. Name: "Friends",
  4050. GroupID: 1,
  4051. },
  4052. },
  4053. err: nil,
  4054. },
  4055. },
  4056. feedbagUpsertParams: feedbagUpsertParams{
  4057. {
  4058. screenName: state.NewIdentScreenName("userA"),
  4059. items: []wire.FeedbagItem{
  4060. {
  4061. Name: "buddy",
  4062. GroupID: 1,
  4063. ItemID: 1000,
  4064. ClassID: wire.FeedbagClassIdBuddy,
  4065. },
  4066. {
  4067. ClassID: wire.FeedbagClassIdGroup,
  4068. Name: "Friends",
  4069. GroupID: 1,
  4070. TLVLBlock: wire.TLVLBlock{
  4071. TLVList: wire.TLVList{
  4072. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1000}),
  4073. },
  4074. },
  4075. },
  4076. },
  4077. err: errors.New("database error"),
  4078. },
  4079. },
  4080. },
  4081. },
  4082. },
  4083. }
  4084. for _, tc := range tt {
  4085. t.Run(tc.name, func(t *testing.T) {
  4086. // Extract buddy name from requestBody JSON
  4087. var buddyName string
  4088. if tc.requestBody != "" {
  4089. var input struct {
  4090. Name string `json:"name"`
  4091. }
  4092. if err := json.Unmarshal([]byte(tc.requestBody), &input); err == nil {
  4093. buddyName = input.Name
  4094. }
  4095. }
  4096. request := httptest.NewRequest(http.MethodPut, "/feedbag/"+tc.screenName+"/group/"+tc.groupID+"/buddy/"+buddyName, nil)
  4097. if tc.screenName != "" {
  4098. request.SetPathValue("screen_name", tc.screenName)
  4099. }
  4100. if tc.groupID != "" {
  4101. request.SetPathValue("group_id", tc.groupID)
  4102. }
  4103. request.SetPathValue("buddy_screen_name", buddyName)
  4104. responseRecorder := httptest.NewRecorder()
  4105. feedbagManager := newMockFeedbagManager(t)
  4106. sessionRetriever := newMockSessionRetriever(t)
  4107. messageRelayer := newMockMessageRelayer(t)
  4108. buddyBroadcaster := newMockBuddyBroadcaster(t)
  4109. for _, params := range tc.mockParams.feedbagParams {
  4110. feedbagManager.EXPECT().
  4111. Feedbag(matchContext(), params.screenName).
  4112. Return(params.result, params.err)
  4113. }
  4114. for _, params := range tc.mockParams.feedbagUpsertParams {
  4115. feedbagManager.EXPECT().
  4116. FeedbagUpsert(matchContext(), params.screenName, params.items).
  4117. Return(params.err)
  4118. }
  4119. for _, params := range tc.mockParams.retrieveSessionByNameParams {
  4120. sessionRetriever.EXPECT().
  4121. RetrieveSession(params.screenName).
  4122. Return(params.result)
  4123. }
  4124. for _, params := range tc.mockParams.relayToScreenNameParams {
  4125. messageRelayer.EXPECT().
  4126. RelayToScreenName(matchContext(), params.screenName, params.msg)
  4127. }
  4128. for _, params := range tc.mockParams.broadcastVisibilityParams {
  4129. // Use mock.MatchedBy to match any SessionInstance, since we're mainly verifying filter and sendDepartures
  4130. buddyBroadcaster.EXPECT().
  4131. BroadcastVisibility(
  4132. matchContext(),
  4133. mock.AnythingOfType("*state.SessionInstance"),
  4134. params.filter,
  4135. params.sendDepartures,
  4136. ).
  4137. Return(params.err)
  4138. }
  4139. deterministicItemID := func(n int) int {
  4140. return 1000
  4141. }
  4142. putFeedbagBuddyHandler(responseRecorder, request, buddyBroadcaster, feedbagManager, sessionRetriever, messageRelayer, slog.Default(), deterministicItemID)
  4143. assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
  4144. if tc.wantStatusCode == http.StatusOK {
  4145. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  4146. } else {
  4147. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  4148. }
  4149. })
  4150. }
  4151. }
  4152. func TestFeedbagBuddyHandler_DELETE(t *testing.T) {
  4153. tt := []struct {
  4154. name string
  4155. screenName string
  4156. groupID string
  4157. requestBody string
  4158. wantStatusCode int
  4159. wantResponse string
  4160. mockParams mockParams
  4161. }{
  4162. {
  4163. name: "delete existing buddy, user not signed in",
  4164. screenName: "userA",
  4165. groupID: "1",
  4166. requestBody: `{"name":"buddy1"}`,
  4167. wantStatusCode: http.StatusNoContent,
  4168. mockParams: mockParams{
  4169. feedbagManagerParams: feedbagManagerParams{
  4170. feedbagParams: feedbagParams{
  4171. {
  4172. screenName: state.NewIdentScreenName("userA"),
  4173. result: []wire.FeedbagItem{
  4174. {
  4175. ItemID: 1,
  4176. ClassID: wire.FeedbagClassIdGroup,
  4177. Name: "Friends",
  4178. GroupID: 1,
  4179. TLVLBlock: wire.TLVLBlock{
  4180. TLVList: wire.TLVList{
  4181. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{10}),
  4182. },
  4183. },
  4184. },
  4185. {
  4186. ItemID: 10,
  4187. ClassID: wire.FeedbagClassIdBuddy,
  4188. Name: "buddy1",
  4189. GroupID: 1,
  4190. },
  4191. },
  4192. err: nil,
  4193. },
  4194. },
  4195. feedbagUpsertParams: feedbagUpsertParams{
  4196. {
  4197. screenName: state.NewIdentScreenName("userA"),
  4198. items: []wire.FeedbagItem{
  4199. {
  4200. ItemID: 1,
  4201. ClassID: wire.FeedbagClassIdGroup,
  4202. Name: "Friends",
  4203. GroupID: 1,
  4204. TLVLBlock: wire.TLVLBlock{
  4205. TLVList: wire.TLVList{
  4206. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{}),
  4207. },
  4208. },
  4209. },
  4210. },
  4211. err: nil,
  4212. },
  4213. },
  4214. feedbagDeleteParams: feedbagDeleteParams{
  4215. {
  4216. screenName: state.NewIdentScreenName("userA"),
  4217. items: []wire.FeedbagItem{
  4218. {
  4219. ItemID: 10,
  4220. ClassID: wire.FeedbagClassIdBuddy,
  4221. Name: "buddy1",
  4222. GroupID: 1,
  4223. },
  4224. },
  4225. err: nil,
  4226. },
  4227. },
  4228. },
  4229. sessionRetrieverParams: sessionRetrieverParams{
  4230. retrieveSessionByNameParams: retrieveSessionByNameParams{
  4231. {
  4232. screenName: state.NewIdentScreenName("userA"),
  4233. result: state.NewSession(),
  4234. },
  4235. },
  4236. },
  4237. messageRelayerParams: messageRelayerParams{
  4238. relayToScreenNameParams: relayToScreenNameParams{
  4239. {
  4240. screenName: state.NewIdentScreenName("userA"),
  4241. msg: wire.SNACMessage{
  4242. Frame: wire.SNACFrame{
  4243. FoodGroup: wire.Feedbag,
  4244. SubGroup: wire.FeedbagUpdateItem,
  4245. RequestID: wire.ReqIDFromServer,
  4246. },
  4247. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  4248. Items: []wire.FeedbagItem{
  4249. {
  4250. ItemID: 1,
  4251. ClassID: wire.FeedbagClassIdGroup,
  4252. Name: "Friends",
  4253. GroupID: 1,
  4254. TLVLBlock: wire.TLVLBlock{
  4255. TLVList: wire.TLVList{
  4256. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{}),
  4257. },
  4258. },
  4259. },
  4260. },
  4261. },
  4262. },
  4263. },
  4264. {
  4265. screenName: state.NewIdentScreenName("userA"),
  4266. msg: wire.SNACMessage{
  4267. Frame: wire.SNACFrame{
  4268. FoodGroup: wire.Feedbag,
  4269. SubGroup: wire.FeedbagDeleteItem,
  4270. RequestID: wire.ReqIDFromServer,
  4271. },
  4272. Body: wire.SNAC_0x13_0x0A_FeedbagDeleteItem{
  4273. Items: []wire.FeedbagItem{
  4274. {
  4275. ItemID: 10,
  4276. ClassID: wire.FeedbagClassIdBuddy,
  4277. Name: "buddy1",
  4278. GroupID: 1,
  4279. },
  4280. },
  4281. },
  4282. },
  4283. },
  4284. },
  4285. },
  4286. },
  4287. },
  4288. {
  4289. name: "delete existing buddy, user signed in",
  4290. screenName: "userA",
  4291. groupID: "1",
  4292. requestBody: `{"name":"buddy1"}`,
  4293. wantStatusCode: http.StatusNoContent,
  4294. mockParams: mockParams{
  4295. feedbagManagerParams: feedbagManagerParams{
  4296. feedbagParams: feedbagParams{
  4297. {
  4298. screenName: state.NewIdentScreenName("userA"),
  4299. result: []wire.FeedbagItem{
  4300. {
  4301. ItemID: 1,
  4302. ClassID: wire.FeedbagClassIdGroup,
  4303. Name: "Friends",
  4304. GroupID: 1,
  4305. TLVLBlock: wire.TLVLBlock{
  4306. TLVList: wire.TLVList{
  4307. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{10}),
  4308. },
  4309. },
  4310. },
  4311. {
  4312. ItemID: 10,
  4313. ClassID: wire.FeedbagClassIdBuddy,
  4314. Name: "buddy1",
  4315. GroupID: 1,
  4316. },
  4317. },
  4318. err: nil,
  4319. },
  4320. },
  4321. feedbagUpsertParams: feedbagUpsertParams{
  4322. {
  4323. screenName: state.NewIdentScreenName("userA"),
  4324. items: []wire.FeedbagItem{
  4325. {
  4326. ItemID: 1,
  4327. ClassID: wire.FeedbagClassIdGroup,
  4328. Name: "Friends",
  4329. GroupID: 1,
  4330. TLVLBlock: wire.TLVLBlock{
  4331. TLVList: wire.TLVList{
  4332. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{}),
  4333. },
  4334. },
  4335. },
  4336. },
  4337. err: nil,
  4338. },
  4339. },
  4340. feedbagDeleteParams: feedbagDeleteParams{
  4341. {
  4342. screenName: state.NewIdentScreenName("userA"),
  4343. items: []wire.FeedbagItem{
  4344. {
  4345. ItemID: 10,
  4346. ClassID: wire.FeedbagClassIdBuddy,
  4347. Name: "buddy1",
  4348. GroupID: 1,
  4349. },
  4350. },
  4351. err: nil,
  4352. },
  4353. },
  4354. },
  4355. sessionRetrieverParams: sessionRetrieverParams{
  4356. retrieveSessionByNameParams: retrieveSessionByNameParams{
  4357. {
  4358. screenName: state.NewIdentScreenName("userA"),
  4359. result: func() *state.Session {
  4360. sess := state.NewSession()
  4361. sess.SetIdentScreenName(state.NewIdentScreenName("userA"))
  4362. inst := sess.AddInstance()
  4363. inst.SetSignonComplete()
  4364. return sess
  4365. }(),
  4366. },
  4367. },
  4368. },
  4369. messageRelayerParams: messageRelayerParams{
  4370. relayToScreenNameParams: relayToScreenNameParams{
  4371. {
  4372. screenName: state.NewIdentScreenName("userA"),
  4373. msg: wire.SNACMessage{
  4374. Frame: wire.SNACFrame{
  4375. FoodGroup: wire.Feedbag,
  4376. SubGroup: wire.FeedbagUpdateItem,
  4377. RequestID: wire.ReqIDFromServer,
  4378. },
  4379. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  4380. Items: []wire.FeedbagItem{
  4381. {
  4382. ItemID: 1,
  4383. ClassID: wire.FeedbagClassIdGroup,
  4384. Name: "Friends",
  4385. GroupID: 1,
  4386. TLVLBlock: wire.TLVLBlock{
  4387. TLVList: wire.TLVList{
  4388. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{}),
  4389. },
  4390. },
  4391. },
  4392. },
  4393. },
  4394. },
  4395. },
  4396. {
  4397. screenName: state.NewIdentScreenName("userA"),
  4398. msg: wire.SNACMessage{
  4399. Frame: wire.SNACFrame{
  4400. FoodGroup: wire.Feedbag,
  4401. SubGroup: wire.FeedbagDeleteItem,
  4402. RequestID: wire.ReqIDFromServer,
  4403. },
  4404. Body: wire.SNAC_0x13_0x0A_FeedbagDeleteItem{
  4405. Items: []wire.FeedbagItem{
  4406. {
  4407. ItemID: 10,
  4408. ClassID: wire.FeedbagClassIdBuddy,
  4409. Name: "buddy1",
  4410. GroupID: 1,
  4411. },
  4412. },
  4413. },
  4414. },
  4415. },
  4416. },
  4417. },
  4418. buddyBroadcasterParams: buddyBroadcasterParams{
  4419. broadcastVisibilityParams: broadcastVisibilityParams{
  4420. {
  4421. you: nil, // Not used in expectation, matched with mock.AnythingOfType
  4422. filter: []state.IdentScreenName{state.NewIdentScreenName("buddy1")},
  4423. sendDepartures: true,
  4424. err: nil,
  4425. },
  4426. },
  4427. },
  4428. },
  4429. },
  4430. {
  4431. name: "delete buddy from a group with multiple buddies, user not signed in",
  4432. screenName: "userA",
  4433. groupID: "1",
  4434. requestBody: `{"name":"buddy1"}`,
  4435. wantStatusCode: http.StatusNoContent,
  4436. mockParams: mockParams{
  4437. feedbagManagerParams: feedbagManagerParams{
  4438. feedbagParams: feedbagParams{
  4439. {
  4440. screenName: state.NewIdentScreenName("userA"),
  4441. result: []wire.FeedbagItem{
  4442. {
  4443. ItemID: 1,
  4444. ClassID: wire.FeedbagClassIdGroup,
  4445. Name: "Friends",
  4446. GroupID: 1,
  4447. TLVLBlock: wire.TLVLBlock{
  4448. TLVList: wire.TLVList{
  4449. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{10, 20}),
  4450. },
  4451. },
  4452. },
  4453. {
  4454. ItemID: 10,
  4455. ClassID: wire.FeedbagClassIdBuddy,
  4456. Name: "buddy1",
  4457. GroupID: 1,
  4458. },
  4459. {
  4460. ItemID: 20,
  4461. ClassID: wire.FeedbagClassIdBuddy,
  4462. Name: "buddy2",
  4463. GroupID: 1,
  4464. },
  4465. },
  4466. err: nil,
  4467. },
  4468. },
  4469. feedbagUpsertParams: feedbagUpsertParams{
  4470. {
  4471. screenName: state.NewIdentScreenName("userA"),
  4472. items: []wire.FeedbagItem{
  4473. {
  4474. ItemID: 1,
  4475. ClassID: wire.FeedbagClassIdGroup,
  4476. Name: "Friends",
  4477. GroupID: 1,
  4478. TLVLBlock: wire.TLVLBlock{
  4479. TLVList: wire.TLVList{
  4480. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{20}),
  4481. },
  4482. },
  4483. },
  4484. },
  4485. err: nil,
  4486. },
  4487. },
  4488. feedbagDeleteParams: feedbagDeleteParams{
  4489. {
  4490. screenName: state.NewIdentScreenName("userA"),
  4491. items: []wire.FeedbagItem{
  4492. {
  4493. ItemID: 10,
  4494. ClassID: wire.FeedbagClassIdBuddy,
  4495. Name: "buddy1",
  4496. GroupID: 1,
  4497. },
  4498. },
  4499. err: nil,
  4500. },
  4501. },
  4502. },
  4503. sessionRetrieverParams: sessionRetrieverParams{
  4504. retrieveSessionByNameParams: retrieveSessionByNameParams{
  4505. {
  4506. screenName: state.NewIdentScreenName("userA"),
  4507. result: state.NewSession(),
  4508. },
  4509. },
  4510. },
  4511. messageRelayerParams: messageRelayerParams{
  4512. relayToScreenNameParams: relayToScreenNameParams{
  4513. {
  4514. screenName: state.NewIdentScreenName("userA"),
  4515. msg: wire.SNACMessage{
  4516. Frame: wire.SNACFrame{
  4517. FoodGroup: wire.Feedbag,
  4518. SubGroup: wire.FeedbagUpdateItem,
  4519. RequestID: wire.ReqIDFromServer,
  4520. },
  4521. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  4522. Items: []wire.FeedbagItem{
  4523. {
  4524. ItemID: 1,
  4525. ClassID: wire.FeedbagClassIdGroup,
  4526. Name: "Friends",
  4527. GroupID: 1,
  4528. TLVLBlock: wire.TLVLBlock{
  4529. TLVList: wire.TLVList{
  4530. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{20}),
  4531. },
  4532. },
  4533. },
  4534. },
  4535. },
  4536. },
  4537. },
  4538. {
  4539. screenName: state.NewIdentScreenName("userA"),
  4540. msg: wire.SNACMessage{
  4541. Frame: wire.SNACFrame{
  4542. FoodGroup: wire.Feedbag,
  4543. SubGroup: wire.FeedbagDeleteItem,
  4544. RequestID: wire.ReqIDFromServer,
  4545. },
  4546. Body: wire.SNAC_0x13_0x0A_FeedbagDeleteItem{
  4547. Items: []wire.FeedbagItem{
  4548. {
  4549. ItemID: 10,
  4550. ClassID: wire.FeedbagClassIdBuddy,
  4551. Name: "buddy1",
  4552. GroupID: 1,
  4553. },
  4554. },
  4555. },
  4556. },
  4557. },
  4558. },
  4559. },
  4560. },
  4561. },
  4562. {
  4563. name: "can't delete buddy from root group",
  4564. screenName: "userA",
  4565. groupID: "0",
  4566. requestBody: `{"name":"rootbuddy"}`,
  4567. wantStatusCode: http.StatusBadRequest,
  4568. wantResponse: `{"message":"can't add buddies to root group"}`,
  4569. },
  4570. {
  4571. name: "missing screen_name",
  4572. screenName: "",
  4573. groupID: "1",
  4574. requestBody: `{"name":"buddy"}`,
  4575. wantStatusCode: http.StatusBadRequest,
  4576. wantResponse: `{"message":"screen_name is required"}`,
  4577. },
  4578. {
  4579. name: "group not found",
  4580. screenName: "userA",
  4581. groupID: "999",
  4582. requestBody: `{"name":"buddy"}`,
  4583. wantStatusCode: http.StatusNotFound,
  4584. wantResponse: `{"message":"group not found"}`,
  4585. mockParams: mockParams{
  4586. feedbagManagerParams: feedbagManagerParams{
  4587. feedbagParams: feedbagParams{
  4588. {
  4589. screenName: state.NewIdentScreenName("userA"),
  4590. result: []wire.FeedbagItem{
  4591. {
  4592. ItemID: 1,
  4593. ClassID: wire.FeedbagClassIdGroup,
  4594. Name: "Friends",
  4595. GroupID: 0,
  4596. },
  4597. },
  4598. err: nil,
  4599. },
  4600. },
  4601. },
  4602. },
  4603. },
  4604. {
  4605. name: "invalid group_id",
  4606. screenName: "userA",
  4607. groupID: "invalid",
  4608. requestBody: `{"name":"buddy"}`,
  4609. wantStatusCode: http.StatusBadRequest,
  4610. wantResponse: `{"message":"invalid group_id"}`,
  4611. },
  4612. {
  4613. name: "malformed request body",
  4614. screenName: "userA",
  4615. groupID: "1",
  4616. requestBody: `invalid json`,
  4617. wantStatusCode: http.StatusBadRequest,
  4618. wantResponse: `{"message":"buddy_screen_name is required"}`,
  4619. },
  4620. {
  4621. name: "missing name in request body",
  4622. screenName: "userA",
  4623. groupID: "1",
  4624. requestBody: `{}`,
  4625. wantStatusCode: http.StatusBadRequest,
  4626. wantResponse: `{"message":"buddy_screen_name is required"}`,
  4627. },
  4628. {
  4629. name: "buddy not found",
  4630. screenName: "userA",
  4631. groupID: "1",
  4632. requestBody: `{"name":"nonexistent"}`,
  4633. wantStatusCode: http.StatusNotFound,
  4634. wantResponse: `{"message":"buddy not found"}`,
  4635. mockParams: mockParams{
  4636. feedbagManagerParams: feedbagManagerParams{
  4637. feedbagParams: feedbagParams{
  4638. {
  4639. screenName: state.NewIdentScreenName("userA"),
  4640. result: []wire.FeedbagItem{
  4641. {
  4642. ItemID: 1,
  4643. ClassID: wire.FeedbagClassIdGroup,
  4644. Name: "Friends",
  4645. GroupID: 1,
  4646. },
  4647. {
  4648. ItemID: 10,
  4649. ClassID: wire.FeedbagClassIdBuddy,
  4650. Name: "otherbuddy",
  4651. GroupID: 1,
  4652. },
  4653. },
  4654. err: nil,
  4655. },
  4656. },
  4657. },
  4658. },
  4659. },
  4660. {
  4661. name: "internal server error on feedbag retrieval",
  4662. screenName: "userA",
  4663. groupID: "1",
  4664. requestBody: `{"name":"buddy"}`,
  4665. wantStatusCode: http.StatusInternalServerError,
  4666. wantResponse: `{"message":"internal server error"}`,
  4667. mockParams: mockParams{
  4668. feedbagManagerParams: feedbagManagerParams{
  4669. feedbagParams: feedbagParams{
  4670. {
  4671. screenName: state.NewIdentScreenName("userA"),
  4672. result: nil,
  4673. err: errors.New("database error"),
  4674. },
  4675. },
  4676. },
  4677. },
  4678. },
  4679. {
  4680. name: "internal server error on group order upsert",
  4681. screenName: "userA",
  4682. groupID: "1",
  4683. requestBody: `{"name":"buddy1"}`,
  4684. wantStatusCode: http.StatusInternalServerError,
  4685. wantResponse: `{"message":"internal server error"}`,
  4686. mockParams: mockParams{
  4687. feedbagManagerParams: feedbagManagerParams{
  4688. feedbagParams: feedbagParams{
  4689. {
  4690. screenName: state.NewIdentScreenName("userA"),
  4691. result: []wire.FeedbagItem{
  4692. {
  4693. ItemID: 1,
  4694. ClassID: wire.FeedbagClassIdGroup,
  4695. Name: "Friends",
  4696. GroupID: 1,
  4697. TLVLBlock: wire.TLVLBlock{
  4698. TLVList: wire.TLVList{
  4699. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{10}),
  4700. },
  4701. },
  4702. },
  4703. {
  4704. ItemID: 10,
  4705. ClassID: wire.FeedbagClassIdBuddy,
  4706. Name: "buddy1",
  4707. GroupID: 1,
  4708. },
  4709. },
  4710. err: nil,
  4711. },
  4712. },
  4713. feedbagUpsertParams: feedbagUpsertParams{
  4714. {
  4715. screenName: state.NewIdentScreenName("userA"),
  4716. items: []wire.FeedbagItem{
  4717. {
  4718. ItemID: 1,
  4719. ClassID: wire.FeedbagClassIdGroup,
  4720. Name: "Friends",
  4721. GroupID: 1,
  4722. TLVLBlock: wire.TLVLBlock{
  4723. TLVList: wire.TLVList{
  4724. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{}),
  4725. },
  4726. },
  4727. },
  4728. },
  4729. err: errors.New("database error"),
  4730. },
  4731. },
  4732. },
  4733. },
  4734. },
  4735. {
  4736. name: "internal server error on delete",
  4737. screenName: "userA",
  4738. groupID: "1",
  4739. requestBody: `{"name":"buddy1"}`,
  4740. wantStatusCode: http.StatusInternalServerError,
  4741. wantResponse: `{"message":"internal server error"}`,
  4742. mockParams: mockParams{
  4743. feedbagManagerParams: feedbagManagerParams{
  4744. feedbagParams: feedbagParams{
  4745. {
  4746. screenName: state.NewIdentScreenName("userA"),
  4747. result: []wire.FeedbagItem{
  4748. {
  4749. ItemID: 1,
  4750. ClassID: wire.FeedbagClassIdGroup,
  4751. Name: "Friends",
  4752. GroupID: 1,
  4753. TLVLBlock: wire.TLVLBlock{
  4754. TLVList: wire.TLVList{
  4755. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{10}),
  4756. },
  4757. },
  4758. },
  4759. {
  4760. ItemID: 10,
  4761. ClassID: wire.FeedbagClassIdBuddy,
  4762. Name: "buddy1",
  4763. GroupID: 1,
  4764. },
  4765. },
  4766. err: nil,
  4767. },
  4768. },
  4769. feedbagUpsertParams: feedbagUpsertParams{
  4770. {
  4771. screenName: state.NewIdentScreenName("userA"),
  4772. items: []wire.FeedbagItem{
  4773. {
  4774. ItemID: 1,
  4775. ClassID: wire.FeedbagClassIdGroup,
  4776. Name: "Friends",
  4777. GroupID: 1,
  4778. TLVLBlock: wire.TLVLBlock{
  4779. TLVList: wire.TLVList{
  4780. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{}),
  4781. },
  4782. },
  4783. },
  4784. },
  4785. err: nil,
  4786. },
  4787. },
  4788. feedbagDeleteParams: feedbagDeleteParams{
  4789. {
  4790. screenName: state.NewIdentScreenName("userA"),
  4791. items: []wire.FeedbagItem{
  4792. {
  4793. ItemID: 10,
  4794. ClassID: wire.FeedbagClassIdBuddy,
  4795. Name: "buddy1",
  4796. GroupID: 1,
  4797. },
  4798. },
  4799. err: errors.New("database error"),
  4800. },
  4801. },
  4802. },
  4803. },
  4804. },
  4805. }
  4806. for _, tc := range tt {
  4807. t.Run(tc.name, func(t *testing.T) {
  4808. // Extract buddy name from requestBody JSON
  4809. var buddyName string
  4810. if tc.requestBody != "" {
  4811. var input struct {
  4812. Name string `json:"name"`
  4813. }
  4814. if err := json.Unmarshal([]byte(tc.requestBody), &input); err == nil {
  4815. buddyName = input.Name
  4816. }
  4817. }
  4818. request := httptest.NewRequest(http.MethodDelete, "/feedbag/"+tc.screenName+"/group/"+tc.groupID+"/buddy/"+buddyName, nil)
  4819. if tc.screenName != "" {
  4820. request.SetPathValue("screen_name", tc.screenName)
  4821. }
  4822. if tc.groupID != "" {
  4823. request.SetPathValue("group_id", tc.groupID)
  4824. }
  4825. request.SetPathValue("buddy_screen_name", buddyName)
  4826. responseRecorder := httptest.NewRecorder()
  4827. feedbagManager := newMockFeedbagManager(t)
  4828. sessionRetriever := newMockSessionRetriever(t)
  4829. messageRelayer := newMockMessageRelayer(t)
  4830. buddyBroadcaster := newMockBuddyBroadcaster(t)
  4831. for _, params := range tc.mockParams.feedbagParams {
  4832. feedbagManager.EXPECT().
  4833. Feedbag(matchContext(), params.screenName).
  4834. Return(params.result, params.err)
  4835. }
  4836. for _, params := range tc.mockParams.feedbagUpsertParams {
  4837. feedbagManager.EXPECT().
  4838. FeedbagUpsert(matchContext(), params.screenName, params.items).
  4839. Return(params.err)
  4840. }
  4841. for _, params := range tc.mockParams.feedbagDeleteParams {
  4842. feedbagManager.EXPECT().
  4843. FeedbagDelete(matchContext(), params.screenName, params.items).
  4844. Return(params.err)
  4845. }
  4846. for _, params := range tc.mockParams.retrieveSessionByNameParams {
  4847. sessionRetriever.EXPECT().
  4848. RetrieveSession(params.screenName).
  4849. Return(params.result)
  4850. }
  4851. for _, params := range tc.mockParams.relayToScreenNameParams {
  4852. messageRelayer.EXPECT().
  4853. RelayToScreenName(matchContext(), params.screenName, params.msg)
  4854. }
  4855. for _, params := range tc.mockParams.broadcastVisibilityParams {
  4856. buddyBroadcaster.EXPECT().
  4857. BroadcastVisibility(
  4858. matchContext(),
  4859. mock.AnythingOfType("*state.SessionInstance"),
  4860. params.filter,
  4861. params.sendDepartures,
  4862. ).
  4863. Return(params.err)
  4864. }
  4865. deleteFeedbagBuddyHandler(responseRecorder, request, buddyBroadcaster, feedbagManager, sessionRetriever, messageRelayer, slog.Default())
  4866. assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
  4867. if tc.wantResponse != "" {
  4868. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  4869. }
  4870. })
  4871. }
  4872. }
  4873. func TestRandItemID(t *testing.T) {
  4874. tt := []struct {
  4875. name string
  4876. randInt func(n int) int
  4877. items []wire.FeedbagItem
  4878. want uint16
  4879. description string
  4880. }{
  4881. {
  4882. name: "empty items list returns random ID",
  4883. randInt: func(n int) int {
  4884. return 1000
  4885. },
  4886. items: []wire.FeedbagItem{},
  4887. want: 1000,
  4888. description: "When no items exist, should return the random number generated",
  4889. },
  4890. {
  4891. name: "finds next available ID when starting ID conflicts with ItemID",
  4892. randInt: func(n int) int {
  4893. return 100
  4894. },
  4895. items: []wire.FeedbagItem{
  4896. {ItemID: 100, GroupID: 1},
  4897. {ItemID: 101, GroupID: 1},
  4898. },
  4899. want: 102,
  4900. description: "Should skip 100 and 101, return 102",
  4901. },
  4902. {
  4903. name: "finds next available ID when starting ID conflicts with GroupID",
  4904. randInt: func(n int) int {
  4905. return 50
  4906. },
  4907. items: []wire.FeedbagItem{
  4908. {ItemID: 1, GroupID: 50},
  4909. {ItemID: 2, GroupID: 51},
  4910. },
  4911. want: 52,
  4912. description: "Should skip 50 (GroupID) and 51 (GroupID), return 52",
  4913. },
  4914. {
  4915. name: "wraps around and skips 0 to find next available ID",
  4916. randInt: func(n int) int {
  4917. return math.MaxUint16 - 2
  4918. },
  4919. items: []wire.FeedbagItem{
  4920. {ItemID: math.MaxUint16 - 2, GroupID: 1},
  4921. {ItemID: math.MaxUint16 - 1, GroupID: 1},
  4922. {ItemID: math.MaxUint16, GroupID: 1},
  4923. },
  4924. want: 2,
  4925. description: "When wrapping around, skips 0 (always skipped) and 1 (if conflicts), returns 2",
  4926. },
  4927. {
  4928. name: "skips 0 when starting from 0 and finds next available",
  4929. randInt: func(n int) int {
  4930. return 0
  4931. },
  4932. items: []wire.FeedbagItem{},
  4933. want: 1,
  4934. description: "When starting from 0, skips 0 (always skipped) and returns 1",
  4935. },
  4936. {
  4937. name: "returns 0 when all IDs are taken",
  4938. randInt: func(n int) int {
  4939. return 100
  4940. },
  4941. items: func() []wire.FeedbagItem {
  4942. // Create items that cover all possible IDs
  4943. items := make([]wire.FeedbagItem, 0, math.MaxUint16+1)
  4944. for i := 0; i <= math.MaxUint16; i++ {
  4945. items = append(items, wire.FeedbagItem{
  4946. ItemID: uint16(i),
  4947. GroupID: uint16(i),
  4948. })
  4949. }
  4950. return items
  4951. }(),
  4952. want: 0,
  4953. description: "When all IDs are taken, should return 0",
  4954. },
  4955. {
  4956. name: "finds ID that conflicts with both ItemID and GroupID",
  4957. randInt: func(n int) int {
  4958. return 200
  4959. },
  4960. items: []wire.FeedbagItem{
  4961. {ItemID: 200, GroupID: 201},
  4962. {ItemID: 201, GroupID: 200},
  4963. },
  4964. want: 202,
  4965. description: "Should skip 200 (ItemID) and 201 (both ItemID and GroupID), return 202",
  4966. },
  4967. {
  4968. name: "finds available ID immediately when no conflicts",
  4969. randInt: func(n int) int {
  4970. return 500
  4971. },
  4972. items: []wire.FeedbagItem{
  4973. {ItemID: 100, GroupID: 1},
  4974. {ItemID: 200, GroupID: 2},
  4975. {ItemID: 300, GroupID: 3},
  4976. },
  4977. want: 500,
  4978. description: "When random ID has no conflicts, should return it immediately",
  4979. },
  4980. {
  4981. name: "handles single conflict and finds next",
  4982. randInt: func(n int) int {
  4983. return 42
  4984. },
  4985. items: []wire.FeedbagItem{
  4986. {ItemID: 42, GroupID: 1},
  4987. },
  4988. want: 43,
  4989. description: "Should skip 42 and return 43",
  4990. },
  4991. {
  4992. name: "finds ID before starting point when wrapping",
  4993. randInt: func(n int) int {
  4994. return 5
  4995. },
  4996. items: []wire.FeedbagItem{
  4997. {ItemID: 5, GroupID: 1},
  4998. {ItemID: 6, GroupID: 1},
  4999. {ItemID: 7, GroupID: 1},
  5000. },
  5001. want: 8,
  5002. description: "Should skip 5, 6, 7 and return 8",
  5003. },
  5004. }
  5005. for _, tc := range tt {
  5006. t.Run(tc.name, func(t *testing.T) {
  5007. got := randItemID(tc.randInt, tc.items)
  5008. if got != tc.want {
  5009. t.Errorf("randItemID() = %d, want %d. %s", got, tc.want, tc.description)
  5010. }
  5011. })
  5012. }
  5013. }
  5014. func TestGetLinkedAccountsHandler(t *testing.T) {
  5015. tt := []struct {
  5016. name string
  5017. screenname string
  5018. statusCode int
  5019. want string
  5020. mockParams mockParams
  5021. }{
  5022. {
  5023. name: "user not found returns 404",
  5024. screenname: "nobody",
  5025. statusCode: http.StatusNotFound,
  5026. want: `{"message":"user not found"}`,
  5027. mockParams: mockParams{
  5028. userManagerParams: userManagerParams{
  5029. getUserParams: getUserParams{
  5030. {
  5031. screenName: state.NewIdentScreenName("nobody"),
  5032. result: nil,
  5033. },
  5034. },
  5035. },
  5036. },
  5037. },
  5038. {
  5039. name: "returns empty linked accounts list",
  5040. screenname: "test1",
  5041. statusCode: http.StatusOK,
  5042. want: `{"linked_accounts":[]}`,
  5043. mockParams: mockParams{
  5044. userManagerParams: userManagerParams{
  5045. getUserParams: getUserParams{
  5046. {
  5047. screenName: state.NewIdentScreenName("test1"),
  5048. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5049. },
  5050. },
  5051. },
  5052. feedbagManagerParams: feedbagManagerParams{
  5053. feedbagParams: feedbagParams{
  5054. {
  5055. screenName: state.NewIdentScreenName("test1"),
  5056. result: []wire.FeedbagItem{},
  5057. },
  5058. },
  5059. },
  5060. },
  5061. },
  5062. {
  5063. name: "returns linked accounts",
  5064. screenname: "test1",
  5065. statusCode: http.StatusOK,
  5066. want: `{"linked_accounts":["test2","test3"]}`,
  5067. mockParams: mockParams{
  5068. userManagerParams: userManagerParams{
  5069. getUserParams: getUserParams{
  5070. {
  5071. screenName: state.NewIdentScreenName("test1"),
  5072. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5073. },
  5074. },
  5075. },
  5076. feedbagManagerParams: feedbagManagerParams{
  5077. feedbagParams: feedbagParams{
  5078. {
  5079. screenName: state.NewIdentScreenName("test1"),
  5080. result: []wire.FeedbagItem{
  5081. {ClassID: wire.FeedbagClassIdAlInfo, Name: "test2"},
  5082. {ClassID: wire.FeedbagClassIdAlInfo, Name: "test3"},
  5083. },
  5084. },
  5085. },
  5086. },
  5087. },
  5088. },
  5089. {
  5090. name: "feedbag error returns 500",
  5091. screenname: "test1",
  5092. statusCode: http.StatusInternalServerError,
  5093. want: `{"message":"internal server error"}`,
  5094. mockParams: mockParams{
  5095. userManagerParams: userManagerParams{
  5096. getUserParams: getUserParams{
  5097. {
  5098. screenName: state.NewIdentScreenName("test1"),
  5099. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5100. },
  5101. },
  5102. },
  5103. feedbagManagerParams: feedbagManagerParams{
  5104. feedbagParams: feedbagParams{
  5105. {
  5106. screenName: state.NewIdentScreenName("test1"),
  5107. err: io.EOF,
  5108. },
  5109. },
  5110. },
  5111. },
  5112. },
  5113. }
  5114. for _, tc := range tt {
  5115. t.Run(tc.name, func(t *testing.T) {
  5116. request := httptest.NewRequest(http.MethodGet, "/user/"+tc.screenname+"/linked-account", nil)
  5117. request.SetPathValue("screenname", tc.screenname)
  5118. responseRecorder := httptest.NewRecorder()
  5119. userManager := newMockUserManager(t)
  5120. for _, params := range tc.mockParams.getUserParams {
  5121. userManager.EXPECT().
  5122. User(matchContext(), params.screenName).
  5123. Return(params.result, params.err)
  5124. }
  5125. feedbagManager := newMockFeedbagManager(t)
  5126. for _, params := range tc.mockParams.feedbagParams {
  5127. feedbagManager.EXPECT().
  5128. Feedbag(matchContext(), params.screenName).
  5129. Return(params.result, params.err)
  5130. }
  5131. getLinkedAccountsHandler(responseRecorder, request, userManager, feedbagManager)
  5132. assert.Equal(t, tc.statusCode, responseRecorder.Code)
  5133. assert.Equal(t, tc.want, strings.TrimSpace(responseRecorder.Body.String()))
  5134. })
  5135. }
  5136. }
  5137. func TestPostLinkedAccountHandler(t *testing.T) {
  5138. tt := []struct {
  5139. name string
  5140. screenname string
  5141. body string
  5142. statusCode int
  5143. want string
  5144. mockParams mockParams
  5145. }{
  5146. {
  5147. name: "primary user not found returns 404",
  5148. screenname: "nobody",
  5149. body: `{"linked_screen_name":"test2"}`,
  5150. statusCode: http.StatusNotFound,
  5151. want: `{"message":"user not found"}`,
  5152. mockParams: mockParams{
  5153. userManagerParams: userManagerParams{
  5154. getUserParams: getUserParams{
  5155. {
  5156. screenName: state.NewIdentScreenName("nobody"),
  5157. result: nil,
  5158. },
  5159. },
  5160. },
  5161. },
  5162. },
  5163. {
  5164. name: "invalid request body returns 400",
  5165. screenname: "test1",
  5166. body: `not json`,
  5167. statusCode: http.StatusBadRequest,
  5168. want: `{"message":"invalid request body"}`,
  5169. mockParams: mockParams{
  5170. userManagerParams: userManagerParams{
  5171. getUserParams: getUserParams{
  5172. {
  5173. screenName: state.NewIdentScreenName("test1"),
  5174. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5175. },
  5176. },
  5177. },
  5178. },
  5179. },
  5180. {
  5181. name: "missing linked_screen_name returns 400",
  5182. screenname: "test1",
  5183. body: `{}`,
  5184. statusCode: http.StatusBadRequest,
  5185. want: `{"message":"invalid request body"}`,
  5186. mockParams: mockParams{
  5187. userManagerParams: userManagerParams{
  5188. getUserParams: getUserParams{
  5189. {
  5190. screenName: state.NewIdentScreenName("test1"),
  5191. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5192. },
  5193. },
  5194. },
  5195. },
  5196. },
  5197. {
  5198. name: "self-link returns 400",
  5199. screenname: "test1",
  5200. body: `{"linked_screen_name":"test1"}`,
  5201. statusCode: http.StatusBadRequest,
  5202. want: `{"message":"cannot link an account to itself"}`,
  5203. mockParams: mockParams{
  5204. userManagerParams: userManagerParams{
  5205. getUserParams: getUserParams{
  5206. {
  5207. screenName: state.NewIdentScreenName("test1"),
  5208. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5209. },
  5210. },
  5211. },
  5212. },
  5213. },
  5214. {
  5215. name: "linked user not found returns 404",
  5216. screenname: "test1",
  5217. body: `{"linked_screen_name":"nobody"}`,
  5218. statusCode: http.StatusNotFound,
  5219. want: `{"message":"linked user not found"}`,
  5220. mockParams: mockParams{
  5221. userManagerParams: userManagerParams{
  5222. getUserParams: getUserParams{
  5223. {
  5224. screenName: state.NewIdentScreenName("test1"),
  5225. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5226. },
  5227. {
  5228. screenName: state.NewIdentScreenName("nobody"),
  5229. result: nil,
  5230. },
  5231. },
  5232. },
  5233. },
  5234. },
  5235. {
  5236. name: "duplicate link returns 409",
  5237. screenname: "test1",
  5238. body: `{"linked_screen_name":"test2"}`,
  5239. statusCode: http.StatusConflict,
  5240. want: `{"message":"linked account already exists"}`,
  5241. mockParams: mockParams{
  5242. userManagerParams: userManagerParams{
  5243. getUserParams: getUserParams{
  5244. {
  5245. screenName: state.NewIdentScreenName("test1"),
  5246. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5247. },
  5248. {
  5249. screenName: state.NewIdentScreenName("test2"),
  5250. result: &state.User{IdentScreenName: state.NewIdentScreenName("test2")},
  5251. },
  5252. },
  5253. },
  5254. feedbagManagerParams: feedbagManagerParams{
  5255. feedbagParams: feedbagParams{
  5256. {
  5257. screenName: state.NewIdentScreenName("test1"),
  5258. result: []wire.FeedbagItem{
  5259. {ClassID: wire.FeedbagClassIdAlInfo, Name: "test2"},
  5260. },
  5261. },
  5262. },
  5263. },
  5264. },
  5265. },
  5266. {
  5267. name: "insert error returns 500",
  5268. screenname: "test1",
  5269. body: `{"linked_screen_name":"test2"}`,
  5270. statusCode: http.StatusInternalServerError,
  5271. want: `{"message":"internal server error"}`,
  5272. mockParams: mockParams{
  5273. userManagerParams: userManagerParams{
  5274. getUserParams: getUserParams{
  5275. {
  5276. screenName: state.NewIdentScreenName("test1"),
  5277. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5278. },
  5279. {
  5280. screenName: state.NewIdentScreenName("test2"),
  5281. result: &state.User{IdentScreenName: state.NewIdentScreenName("test2")},
  5282. },
  5283. },
  5284. },
  5285. feedbagManagerParams: feedbagManagerParams{
  5286. feedbagParams: feedbagParams{
  5287. {
  5288. screenName: state.NewIdentScreenName("test1"),
  5289. result: []wire.FeedbagItem{},
  5290. },
  5291. },
  5292. feedbagUpsertParams: feedbagUpsertParams{
  5293. {
  5294. screenName: state.NewIdentScreenName("test1"),
  5295. items: []wire.FeedbagItem{
  5296. {ItemID: 1, ClassID: wire.FeedbagClassIdAlInfo, Name: "test2"},
  5297. },
  5298. err: io.EOF,
  5299. },
  5300. },
  5301. },
  5302. },
  5303. },
  5304. {
  5305. name: "link created returns 201",
  5306. screenname: "test1",
  5307. body: `{"linked_screen_name":"test2"}`,
  5308. statusCode: http.StatusCreated,
  5309. want: ``,
  5310. mockParams: mockParams{
  5311. userManagerParams: userManagerParams{
  5312. getUserParams: getUserParams{
  5313. {
  5314. screenName: state.NewIdentScreenName("test1"),
  5315. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5316. },
  5317. {
  5318. screenName: state.NewIdentScreenName("test2"),
  5319. result: &state.User{IdentScreenName: state.NewIdentScreenName("test2")},
  5320. },
  5321. },
  5322. },
  5323. feedbagManagerParams: feedbagManagerParams{
  5324. feedbagParams: feedbagParams{
  5325. {
  5326. screenName: state.NewIdentScreenName("test1"),
  5327. result: []wire.FeedbagItem{},
  5328. },
  5329. },
  5330. feedbagUpsertParams: feedbagUpsertParams{
  5331. {
  5332. screenName: state.NewIdentScreenName("test1"),
  5333. items: []wire.FeedbagItem{
  5334. {ItemID: 1, ClassID: wire.FeedbagClassIdAlInfo, Name: "test2"},
  5335. },
  5336. },
  5337. },
  5338. },
  5339. },
  5340. },
  5341. }
  5342. for _, tc := range tt {
  5343. t.Run(tc.name, func(t *testing.T) {
  5344. request := httptest.NewRequest(http.MethodPost, "/user/"+tc.screenname+"/linked-account", strings.NewReader(tc.body))
  5345. request.SetPathValue("screenname", tc.screenname)
  5346. responseRecorder := httptest.NewRecorder()
  5347. userManager := newMockUserManager(t)
  5348. for _, params := range tc.mockParams.getUserParams {
  5349. userManager.EXPECT().
  5350. User(matchContext(), params.screenName).
  5351. Return(params.result, params.err)
  5352. }
  5353. feedbagManager := newMockFeedbagManager(t)
  5354. for _, params := range tc.mockParams.feedbagParams {
  5355. feedbagManager.EXPECT().
  5356. Feedbag(matchContext(), params.screenName).
  5357. Return(params.result, params.err)
  5358. }
  5359. for _, params := range tc.mockParams.feedbagUpsertParams {
  5360. feedbagManager.EXPECT().
  5361. FeedbagUpsert(matchContext(), params.screenName, params.items).
  5362. Return(params.err)
  5363. }
  5364. postLinkedAccountHandler(responseRecorder, request, userManager, feedbagManager, slog.Default(), func(n int) int { return 0 })
  5365. assert.Equal(t, tc.statusCode, responseRecorder.Code)
  5366. assert.Equal(t, tc.want, strings.TrimSpace(responseRecorder.Body.String()))
  5367. })
  5368. }
  5369. }
  5370. func TestDeleteLinkedAccountHandler(t *testing.T) {
  5371. linkedFeedbagItem := wire.FeedbagItem{
  5372. ItemID: 1,
  5373. ClassID: wire.FeedbagClassIdAlInfo,
  5374. Name: "test2",
  5375. }
  5376. tt := []struct {
  5377. name string
  5378. screenname string
  5379. linkedScreenname string
  5380. statusCode int
  5381. want string
  5382. mockParams mockParams
  5383. }{
  5384. {
  5385. name: "primary user not found returns 404",
  5386. screenname: "nobody",
  5387. linkedScreenname: "test2",
  5388. statusCode: http.StatusNotFound,
  5389. want: `{"message":"user not found"}`,
  5390. mockParams: mockParams{
  5391. userManagerParams: userManagerParams{
  5392. getUserParams: getUserParams{
  5393. {
  5394. screenName: state.NewIdentScreenName("nobody"),
  5395. result: nil,
  5396. },
  5397. },
  5398. },
  5399. },
  5400. },
  5401. {
  5402. name: "linked account not found returns 404",
  5403. screenname: "test1",
  5404. linkedScreenname: "ghost",
  5405. statusCode: http.StatusNotFound,
  5406. want: `{"message":"linked account not found"}`,
  5407. mockParams: mockParams{
  5408. userManagerParams: userManagerParams{
  5409. getUserParams: getUserParams{
  5410. {
  5411. screenName: state.NewIdentScreenName("test1"),
  5412. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5413. },
  5414. },
  5415. },
  5416. feedbagManagerParams: feedbagManagerParams{
  5417. feedbagParams: feedbagParams{
  5418. {
  5419. screenName: state.NewIdentScreenName("test1"),
  5420. result: []wire.FeedbagItem{},
  5421. },
  5422. },
  5423. },
  5424. },
  5425. },
  5426. {
  5427. name: "delete error returns 500",
  5428. screenname: "test1",
  5429. linkedScreenname: "test2",
  5430. statusCode: http.StatusInternalServerError,
  5431. want: `{"message":"internal server error"}`,
  5432. mockParams: mockParams{
  5433. userManagerParams: userManagerParams{
  5434. getUserParams: getUserParams{
  5435. {
  5436. screenName: state.NewIdentScreenName("test1"),
  5437. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5438. },
  5439. },
  5440. },
  5441. feedbagManagerParams: feedbagManagerParams{
  5442. feedbagParams: feedbagParams{
  5443. {
  5444. screenName: state.NewIdentScreenName("test1"),
  5445. result: []wire.FeedbagItem{linkedFeedbagItem},
  5446. },
  5447. },
  5448. feedbagDeleteParams: feedbagDeleteParams{
  5449. {
  5450. screenName: state.NewIdentScreenName("test1"),
  5451. items: []wire.FeedbagItem{linkedFeedbagItem},
  5452. err: io.EOF,
  5453. },
  5454. },
  5455. },
  5456. },
  5457. },
  5458. {
  5459. name: "upsert error after delete returns 500",
  5460. screenname: "test1",
  5461. linkedScreenname: "test2",
  5462. statusCode: http.StatusInternalServerError,
  5463. want: `{"message":"internal server error"}`,
  5464. mockParams: mockParams{
  5465. userManagerParams: userManagerParams{
  5466. getUserParams: getUserParams{
  5467. {
  5468. screenName: state.NewIdentScreenName("test1"),
  5469. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5470. },
  5471. },
  5472. },
  5473. feedbagManagerParams: feedbagManagerParams{
  5474. feedbagParams: feedbagParams{
  5475. {
  5476. screenName: state.NewIdentScreenName("test1"),
  5477. result: []wire.FeedbagItem{linkedFeedbagItem},
  5478. },
  5479. },
  5480. feedbagDeleteParams: feedbagDeleteParams{
  5481. {
  5482. screenName: state.NewIdentScreenName("test1"),
  5483. items: []wire.FeedbagItem{linkedFeedbagItem},
  5484. },
  5485. },
  5486. feedbagUpsertParams: feedbagUpsertParams{
  5487. {
  5488. screenName: state.NewIdentScreenName("test1"),
  5489. items: []wire.FeedbagItem{{ClassID: wire.FeedbagClassIdGroup}},
  5490. err: io.EOF,
  5491. },
  5492. },
  5493. },
  5494. },
  5495. },
  5496. {
  5497. name: "link deleted returns 204",
  5498. screenname: "test1",
  5499. linkedScreenname: "test2",
  5500. statusCode: http.StatusNoContent,
  5501. want: ``,
  5502. mockParams: mockParams{
  5503. userManagerParams: userManagerParams{
  5504. getUserParams: getUserParams{
  5505. {
  5506. screenName: state.NewIdentScreenName("test1"),
  5507. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5508. },
  5509. },
  5510. },
  5511. feedbagManagerParams: feedbagManagerParams{
  5512. feedbagParams: feedbagParams{
  5513. {
  5514. screenName: state.NewIdentScreenName("test1"),
  5515. result: []wire.FeedbagItem{linkedFeedbagItem},
  5516. },
  5517. },
  5518. feedbagDeleteParams: feedbagDeleteParams{
  5519. {
  5520. screenName: state.NewIdentScreenName("test1"),
  5521. items: []wire.FeedbagItem{linkedFeedbagItem},
  5522. },
  5523. },
  5524. feedbagUpsertParams: feedbagUpsertParams{
  5525. {
  5526. screenName: state.NewIdentScreenName("test1"),
  5527. items: []wire.FeedbagItem{{ClassID: wire.FeedbagClassIdGroup}},
  5528. },
  5529. },
  5530. },
  5531. },
  5532. },
  5533. }
  5534. for _, tc := range tt {
  5535. t.Run(tc.name, func(t *testing.T) {
  5536. request := httptest.NewRequest(http.MethodDelete, "/user/"+tc.screenname+"/linked-account/"+tc.linkedScreenname, nil)
  5537. request.SetPathValue("screenname", tc.screenname)
  5538. request.SetPathValue("linked_screenname", tc.linkedScreenname)
  5539. responseRecorder := httptest.NewRecorder()
  5540. userManager := newMockUserManager(t)
  5541. for _, params := range tc.mockParams.getUserParams {
  5542. userManager.EXPECT().
  5543. User(matchContext(), params.screenName).
  5544. Return(params.result, params.err)
  5545. }
  5546. feedbagManager := newMockFeedbagManager(t)
  5547. for _, params := range tc.mockParams.feedbagParams {
  5548. feedbagManager.EXPECT().
  5549. Feedbag(matchContext(), params.screenName).
  5550. Return(params.result, params.err)
  5551. }
  5552. for _, params := range tc.mockParams.feedbagDeleteParams {
  5553. feedbagManager.EXPECT().
  5554. FeedbagDelete(matchContext(), params.screenName, params.items).
  5555. Return(params.err)
  5556. }
  5557. for _, params := range tc.mockParams.feedbagUpsertParams {
  5558. feedbagManager.EXPECT().
  5559. FeedbagUpsert(matchContext(), params.screenName, params.items).
  5560. Return(params.err)
  5561. }
  5562. deleteLinkedAccountHandler(responseRecorder, request, userManager, feedbagManager, slog.Default(), nil)
  5563. assert.Equal(t, tc.statusCode, responseRecorder.Code)
  5564. assert.Equal(t, tc.want, strings.TrimSpace(responseRecorder.Body.String()))
  5565. })
  5566. }
  5567. }