mgmt_api_test.go 130 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154115511561157115811591160116111621163116411651166116711681169117011711172117311741175117611771178117911801181118211831184118511861187118811891190119111921193119411951196119711981199120012011202120312041205120612071208120912101211121212131214121512161217121812191220122112221223122412251226122712281229123012311232123312341235123612371238123912401241124212431244124512461247124812491250125112521253125412551256125712581259126012611262126312641265126612671268126912701271127212731274127512761277127812791280128112821283128412851286128712881289129012911292129312941295129612971298129913001301130213031304130513061307130813091310131113121313131413151316131713181319132013211322132313241325132613271328132913301331133213331334133513361337133813391340134113421343134413451346134713481349135013511352135313541355135613571358135913601361136213631364136513661367136813691370137113721373137413751376137713781379138013811382138313841385138613871388138913901391139213931394139513961397139813991400140114021403140414051406140714081409141014111412141314141415141614171418141914201421142214231424142514261427142814291430143114321433143414351436143714381439144014411442144314441445144614471448144914501451145214531454145514561457145814591460146114621463146414651466146714681469147014711472147314741475147614771478147914801481148214831484148514861487148814891490149114921493149414951496149714981499150015011502150315041505150615071508150915101511151215131514151515161517151815191520152115221523152415251526152715281529153015311532153315341535153615371538153915401541154215431544154515461547154815491550155115521553155415551556155715581559156015611562156315641565156615671568156915701571157215731574157515761577157815791580158115821583158415851586158715881589159015911592159315941595159615971598159916001601160216031604160516061607160816091610161116121613161416151616161716181619162016211622162316241625162616271628162916301631163216331634163516361637163816391640164116421643164416451646164716481649165016511652165316541655165616571658165916601661166216631664166516661667166816691670167116721673167416751676167716781679168016811682168316841685168616871688168916901691169216931694169516961697169816991700170117021703170417051706170717081709171017111712171317141715171617171718171917201721172217231724172517261727172817291730173117321733173417351736173717381739174017411742174317441745174617471748174917501751175217531754175517561757175817591760176117621763176417651766176717681769177017711772177317741775177617771778177917801781178217831784178517861787178817891790179117921793179417951796179717981799180018011802180318041805180618071808180918101811181218131814181518161817181818191820182118221823182418251826182718281829183018311832183318341835183618371838183918401841184218431844184518461847184818491850185118521853185418551856185718581859186018611862186318641865186618671868186918701871187218731874187518761877187818791880188118821883188418851886188718881889189018911892189318941895189618971898189919001901190219031904190519061907190819091910191119121913191419151916191719181919192019211922192319241925192619271928192919301931193219331934193519361937193819391940194119421943194419451946194719481949195019511952195319541955195619571958195919601961196219631964196519661967196819691970197119721973197419751976197719781979198019811982198319841985198619871988198919901991199219931994199519961997199819992000200120022003200420052006200720082009201020112012201320142015201620172018201920202021202220232024202520262027202820292030203120322033203420352036203720382039204020412042204320442045204620472048204920502051205220532054205520562057205820592060206120622063206420652066206720682069207020712072207320742075207620772078207920802081208220832084208520862087208820892090209120922093209420952096209720982099210021012102210321042105210621072108210921102111211221132114211521162117211821192120212121222123212421252126212721282129213021312132213321342135213621372138213921402141214221432144214521462147214821492150215121522153215421552156215721582159216021612162216321642165216621672168216921702171217221732174217521762177217821792180218121822183218421852186218721882189219021912192219321942195219621972198219922002201220222032204220522062207220822092210221122122213221422152216221722182219222022212222222322242225222622272228222922302231223222332234223522362237223822392240224122422243224422452246224722482249225022512252225322542255225622572258225922602261226222632264226522662267226822692270227122722273227422752276227722782279228022812282228322842285228622872288228922902291229222932294229522962297229822992300230123022303230423052306230723082309231023112312231323142315231623172318231923202321232223232324232523262327232823292330233123322333233423352336233723382339234023412342234323442345234623472348234923502351235223532354235523562357235823592360236123622363236423652366236723682369237023712372237323742375237623772378237923802381238223832384238523862387238823892390239123922393239423952396239723982399240024012402240324042405240624072408240924102411241224132414241524162417241824192420242124222423242424252426242724282429243024312432243324342435243624372438243924402441244224432444244524462447244824492450245124522453245424552456245724582459246024612462246324642465246624672468246924702471247224732474247524762477247824792480248124822483248424852486248724882489249024912492249324942495249624972498249925002501250225032504250525062507250825092510251125122513251425152516251725182519252025212522252325242525252625272528252925302531253225332534253525362537253825392540254125422543254425452546254725482549255025512552255325542555255625572558255925602561256225632564256525662567256825692570257125722573257425752576257725782579258025812582258325842585258625872588258925902591259225932594259525962597259825992600260126022603260426052606260726082609261026112612261326142615261626172618261926202621262226232624262526262627262826292630263126322633263426352636263726382639264026412642264326442645264626472648264926502651265226532654265526562657265826592660266126622663266426652666266726682669267026712672267326742675267626772678267926802681268226832684268526862687268826892690269126922693269426952696269726982699270027012702270327042705270627072708270927102711271227132714271527162717271827192720272127222723272427252726272727282729273027312732273327342735273627372738273927402741274227432744274527462747274827492750275127522753275427552756275727582759276027612762276327642765276627672768276927702771277227732774277527762777277827792780278127822783278427852786278727882789279027912792279327942795279627972798279928002801280228032804280528062807280828092810281128122813281428152816281728182819282028212822282328242825282628272828282928302831283228332834283528362837283828392840284128422843284428452846284728482849285028512852285328542855285628572858285928602861286228632864286528662867286828692870287128722873287428752876287728782879288028812882288328842885288628872888288928902891289228932894289528962897289828992900290129022903290429052906290729082909291029112912291329142915291629172918291929202921292229232924292529262927292829292930293129322933293429352936293729382939294029412942294329442945294629472948294929502951295229532954295529562957295829592960296129622963296429652966296729682969297029712972297329742975297629772978297929802981298229832984298529862987298829892990299129922993299429952996299729982999300030013002300330043005300630073008300930103011301230133014301530163017301830193020302130223023302430253026302730283029303030313032303330343035303630373038303930403041304230433044304530463047304830493050305130523053305430553056305730583059306030613062306330643065306630673068306930703071307230733074307530763077307830793080308130823083308430853086308730883089309030913092309330943095309630973098309931003101310231033104310531063107310831093110311131123113311431153116311731183119312031213122312331243125312631273128312931303131313231333134313531363137313831393140314131423143314431453146314731483149315031513152315331543155315631573158315931603161316231633164316531663167316831693170317131723173317431753176317731783179318031813182318331843185318631873188318931903191319231933194319531963197319831993200320132023203320432053206320732083209321032113212321332143215321632173218321932203221322232233224322532263227322832293230323132323233323432353236323732383239324032413242324332443245324632473248324932503251325232533254325532563257325832593260326132623263326432653266326732683269327032713272327332743275327632773278327932803281328232833284328532863287328832893290329132923293329432953296329732983299330033013302330333043305330633073308330933103311331233133314331533163317331833193320332133223323332433253326332733283329333033313332333333343335333633373338333933403341334233433344334533463347334833493350335133523353335433553356335733583359336033613362336333643365336633673368336933703371337233733374337533763377337833793380338133823383338433853386338733883389339033913392339333943395339633973398339934003401340234033404340534063407340834093410341134123413341434153416341734183419342034213422342334243425342634273428342934303431343234333434343534363437343834393440344134423443344434453446344734483449345034513452345334543455345634573458345934603461346234633464346534663467346834693470347134723473347434753476347734783479348034813482348334843485348634873488348934903491349234933494349534963497349834993500350135023503350435053506350735083509351035113512351335143515351635173518351935203521352235233524352535263527352835293530353135323533353435353536353735383539354035413542354335443545354635473548354935503551355235533554355535563557355835593560356135623563356435653566356735683569357035713572357335743575357635773578357935803581358235833584358535863587358835893590359135923593359435953596359735983599360036013602360336043605360636073608360936103611361236133614361536163617361836193620362136223623362436253626362736283629363036313632363336343635363636373638363936403641364236433644364536463647364836493650365136523653365436553656365736583659366036613662366336643665366636673668366936703671367236733674367536763677367836793680368136823683368436853686368736883689369036913692369336943695369636973698369937003701370237033704370537063707370837093710371137123713371437153716371737183719372037213722372337243725372637273728372937303731373237333734373537363737373837393740374137423743374437453746374737483749375037513752375337543755375637573758375937603761376237633764376537663767376837693770377137723773377437753776377737783779378037813782378337843785378637873788378937903791379237933794379537963797379837993800380138023803380438053806380738083809381038113812381338143815381638173818381938203821382238233824382538263827382838293830383138323833383438353836383738383839384038413842384338443845384638473848384938503851385238533854385538563857385838593860386138623863386438653866386738683869387038713872387338743875387638773878387938803881388238833884388538863887388838893890389138923893389438953896389738983899390039013902390339043905390639073908390939103911391239133914391539163917391839193920392139223923392439253926392739283929393039313932393339343935393639373938393939403941394239433944394539463947394839493950395139523953395439553956395739583959396039613962396339643965396639673968396939703971397239733974397539763977397839793980398139823983398439853986398739883989399039913992399339943995399639973998399940004001400240034004400540064007400840094010401140124013401440154016401740184019402040214022402340244025402640274028402940304031403240334034403540364037403840394040404140424043404440454046404740484049405040514052405340544055405640574058405940604061406240634064406540664067406840694070407140724073407440754076407740784079408040814082408340844085408640874088408940904091409240934094409540964097409840994100410141024103410441054106410741084109411041114112411341144115411641174118411941204121412241234124412541264127412841294130413141324133413441354136413741384139414041414142414341444145414641474148414941504151415241534154415541564157415841594160416141624163416441654166416741684169417041714172417341744175417641774178417941804181418241834184418541864187418841894190419141924193419441954196419741984199420042014202420342044205420642074208420942104211421242134214421542164217421842194220422142224223422442254226422742284229423042314232423342344235423642374238423942404241424242434244424542464247424842494250425142524253425442554256425742584259426042614262426342644265426642674268426942704271427242734274427542764277427842794280428142824283428442854286428742884289429042914292429342944295429642974298429943004301430243034304430543064307430843094310431143124313431443154316431743184319432043214322432343244325432643274328432943304331433243334334433543364337433843394340434143424343434443454346434743484349435043514352435343544355435643574358435943604361436243634364436543664367436843694370437143724373437443754376437743784379438043814382438343844385438643874388438943904391439243934394439543964397439843994400440144024403440444054406440744084409441044114412441344144415441644174418441944204421442244234424442544264427442844294430443144324433443444354436443744384439444044414442444344444445444644474448444944504451445244534454445544564457445844594460446144624463446444654466446744684469447044714472447344744475447644774478447944804481448244834484448544864487448844894490
  1. package http
  2. import (
  3. "context"
  4. "encoding/json"
  5. "errors"
  6. "fmt"
  7. "io"
  8. "log/slog"
  9. "math"
  10. "net/http"
  11. "net/http/httptest"
  12. "net/mail"
  13. "net/netip"
  14. "strings"
  15. "testing"
  16. "time"
  17. "github.com/stretchr/testify/assert"
  18. "github.com/stretchr/testify/mock"
  19. "github.com/mk6i/open-oscar-server/config"
  20. "github.com/mk6i/open-oscar-server/state"
  21. "github.com/mk6i/open-oscar-server/wire"
  22. )
  23. func TestSessionHandler_GET(t *testing.T) {
  24. // Fixed time for testing: 2024-01-01 12:00:00 UTC
  25. fixedNow := time.Date(2024, 1, 1, 12, 0, 0, 0, time.UTC)
  26. nowFn := func() time.Time { return fixedNow }
  27. tt := []struct {
  28. name string
  29. want string
  30. statusCode int
  31. createSessions func() []*state.Session
  32. }{
  33. {
  34. name: "without sessions",
  35. want: `{"count":0,"sessions":[]}`,
  36. statusCode: http.StatusOK,
  37. createSessions: func() []*state.Session {
  38. return []*state.Session{}
  39. },
  40. },
  41. {
  42. name: "with sessions",
  43. want: `{"count":3,"sessions":[{"id":"usera","screen_name":"userA","online_seconds":100,"is_away":false,"away_message":"","idle_seconds":0,"is_invisible":false,"is_icq":false,"instance_count":2,"instances":[{"num":1,"idle_seconds":30,"is_away":false,"away_message":"","is_invisible":false,"remote_addr":"1.2.3.4","remote_port":1234},{"num":2,"idle_seconds":0,"is_away":false,"away_message":"","is_invisible":true,"remote_addr":"5.6.7.8","remote_port":5678}]},{"id":"userb","screen_name":"userB","online_seconds":200,"is_away":false,"away_message":"","idle_seconds":0,"is_invisible":true,"is_icq":false,"instance_count":2,"instances":[{"num":1,"idle_seconds":0,"is_away":false,"away_message":"","is_invisible":true,"remote_addr":"9.10.11.12","remote_port":9012},{"num":2,"idle_seconds":0,"is_away":false,"away_message":"","is_invisible":true,"remote_addr":"13.14.15.16","remote_port":1314}]},{"id":"100003","screen_name":"100003","online_seconds":300,"is_away":false,"away_message":"","idle_seconds":0,"is_invisible":false,"is_icq":true,"instance_count":1,"instances":[{"num":1,"idle_seconds":0,"is_away":false,"away_message":"","is_invisible":false,"remote_addr":"1.2.3.4","remote_port":1234}]}]}`,
  44. statusCode: http.StatusOK,
  45. createSessions: func() []*state.Session {
  46. // userA: 2 instances - one idle (30s), one invisible
  47. userA := state.NewSession()
  48. userA.SetIdentScreenName(state.NewIdentScreenName("userA"))
  49. userA.SetDisplayScreenName(state.DisplayScreenName("userA"))
  50. userA.SetUIN(0)
  51. userA.SetNowFn(nowFn)
  52. userA.SetSignonTime(fixedNow.Add(-100 * time.Second))
  53. inst1 := userA.AddInstance()
  54. inst1.SetSignonComplete()
  55. inst1.SetIdle(30 * time.Second)
  56. ip1, _ := netip.ParseAddrPort("1.2.3.4:1234")
  57. inst1.SetRemoteAddr(&ip1)
  58. inst2 := userA.AddInstance()
  59. inst2.SetSignonComplete()
  60. inst2.SetUserStatusBitmask(wire.OServiceUserStatusInvisible)
  61. ip2, _ := netip.ParseAddrPort("5.6.7.8:5678")
  62. inst2.SetRemoteAddr(&ip2)
  63. // userB: 2 instances - both invisible
  64. userB := state.NewSession()
  65. userB.SetIdentScreenName(state.NewIdentScreenName("userB"))
  66. userB.SetDisplayScreenName(state.DisplayScreenName("userB"))
  67. userB.SetUIN(0)
  68. userB.SetNowFn(nowFn)
  69. userB.SetSignonTime(fixedNow.Add(-200 * time.Second))
  70. inst3 := userB.AddInstance()
  71. inst3.SetSignonComplete()
  72. inst3.SetUserStatusBitmask(wire.OServiceUserStatusInvisible)
  73. ip3, _ := netip.ParseAddrPort("9.10.11.12:9012")
  74. inst3.SetRemoteAddr(&ip3)
  75. inst4 := userB.AddInstance()
  76. inst4.SetSignonComplete()
  77. inst4.SetUserStatusBitmask(wire.OServiceUserStatusInvisible)
  78. ip4, _ := netip.ParseAddrPort("13.14.15.16:1314")
  79. inst4.SetRemoteAddr(&ip4)
  80. // 100003: 1 instance - normal
  81. icqUser := state.NewSession()
  82. icqUser.SetIdentScreenName(state.NewIdentScreenName("100003"))
  83. icqUser.SetDisplayScreenName(state.DisplayScreenName("100003"))
  84. icqUser.SetUIN(100003)
  85. icqUser.SetNowFn(nowFn)
  86. icqUser.SetSignonTime(fixedNow.Add(-300 * time.Second))
  87. inst5 := icqUser.AddInstance()
  88. inst5.SetSignonComplete()
  89. ip5, _ := netip.ParseAddrPort("1.2.3.4:1234")
  90. inst5.SetRemoteAddr(&ip5)
  91. return []*state.Session{userA, userB, icqUser}
  92. },
  93. },
  94. {
  95. name: "with away sessions",
  96. want: `{"count":2,"sessions":[{"id":"usera","screen_name":"userA","online_seconds":100,"is_away":false,"away_message":"","idle_seconds":0,"is_invisible":false,"is_icq":false,"instance_count":2,"instances":[{"num":1,"idle_seconds":0,"is_away":true,"away_message":"Away message 1","is_invisible":false,"remote_addr":"1.2.3.4","remote_port":1234},{"num":2,"idle_seconds":0,"is_away":false,"away_message":"","is_invisible":false,"remote_addr":"5.6.7.8","remote_port":5678}]},{"id":"userb","screen_name":"userB","online_seconds":200,"is_away":true,"away_message":"Away message 2","idle_seconds":0,"is_invisible":false,"is_icq":false,"instance_count":2,"instances":[{"num":1,"idle_seconds":0,"is_away":true,"away_message":"Away message 2","is_invisible":false,"remote_addr":"9.10.11.12","remote_port":9012},{"num":2,"idle_seconds":0,"is_away":true,"away_message":"Away message 2","is_invisible":false,"remote_addr":"13.14.15.16","remote_port":1314}]}]}`,
  97. statusCode: http.StatusOK,
  98. createSessions: func() []*state.Session {
  99. // userA: 2 instances - one away, one not away (away_message should be "")
  100. userA := state.NewSession()
  101. userA.SetIdentScreenName(state.NewIdentScreenName("userA"))
  102. userA.SetDisplayScreenName(state.DisplayScreenName("userA"))
  103. userA.SetUIN(0)
  104. userA.SetNowFn(nowFn)
  105. userA.SetSignonTime(fixedNow.Add(-100 * time.Second))
  106. inst1 := userA.AddInstance()
  107. inst1.SetSignonComplete()
  108. inst1.SetUserStatusBitmask(wire.OServiceUserStatusAway)
  109. inst1.SetAwayMessage("Away message 1")
  110. ip1, _ := netip.ParseAddrPort("1.2.3.4:1234")
  111. inst1.SetRemoteAddr(&ip1)
  112. inst2 := userA.AddInstance()
  113. inst2.SetSignonComplete()
  114. ip2, _ := netip.ParseAddrPort("5.6.7.8:5678")
  115. inst2.SetRemoteAddr(&ip2)
  116. // userB: 2 instances - both away (away_message should be populated)
  117. userB := state.NewSession()
  118. userB.SetIdentScreenName(state.NewIdentScreenName("userB"))
  119. userB.SetDisplayScreenName(state.DisplayScreenName("userB"))
  120. userB.SetUIN(0)
  121. userB.SetNowFn(nowFn)
  122. userB.SetSignonTime(fixedNow.Add(-200 * time.Second))
  123. inst3 := userB.AddInstance()
  124. inst3.SetSignonComplete()
  125. inst3.SetUserStatusBitmask(wire.OServiceUserStatusAway)
  126. inst3.SetAwayMessage("Away message 2")
  127. ip3, _ := netip.ParseAddrPort("9.10.11.12:9012")
  128. inst3.SetRemoteAddr(&ip3)
  129. inst4 := userB.AddInstance()
  130. inst4.SetSignonComplete()
  131. inst4.SetUserStatusBitmask(wire.OServiceUserStatusAway)
  132. inst4.SetAwayMessage("Away message 2")
  133. ip4, _ := netip.ParseAddrPort("13.14.15.16:1314")
  134. inst4.SetRemoteAddr(&ip4)
  135. return []*state.Session{userA, userB}
  136. },
  137. },
  138. }
  139. for _, tc := range tt {
  140. t.Run(tc.name, func(t *testing.T) {
  141. request := httptest.NewRequest(http.MethodGet, "/session", nil)
  142. responseRecorder := httptest.NewRecorder()
  143. sessionRetriever := newMockSessionRetriever(t)
  144. sessions := tc.createSessions()
  145. sessionRetriever.EXPECT().
  146. AllSessions().
  147. Return(sessions)
  148. getSessionHandler(responseRecorder, request, sessionRetriever, nowFn)
  149. if responseRecorder.Code != tc.statusCode {
  150. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  151. }
  152. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  153. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  154. }
  155. })
  156. }
  157. }
  158. func TestSessionHandlerScreenname_GET(t *testing.T) {
  159. // Fixed time for testing: 2024-01-01 12:00:00 UTC
  160. fixedNow := time.Date(2024, 1, 1, 12, 0, 0, 0, time.UTC)
  161. nowFn := func() time.Time { return fixedNow }
  162. tt := []struct {
  163. name string
  164. requestScreenName state.IdentScreenName
  165. want string
  166. statusCode int
  167. createSession func() *state.Session
  168. }{
  169. {
  170. name: "no session for screenname",
  171. requestScreenName: state.NewIdentScreenName("userA"),
  172. want: `session not found`,
  173. statusCode: http.StatusNotFound,
  174. createSession: func() *state.Session {
  175. return nil
  176. },
  177. },
  178. {
  179. name: "active session found for screenname",
  180. requestScreenName: state.NewIdentScreenName("userA"),
  181. want: `{"count":1,"sessions":[{"id":"usera","screen_name":"userA","online_seconds":150,"is_away":false,"away_message":"","idle_seconds":0,"is_invisible":false,"is_icq":false,"instance_count":1,"instances":[{"num":1,"idle_seconds":0,"is_away":false,"away_message":"","is_invisible":false,"remote_addr":"1.2.3.4","remote_port":1234}]}]}`,
  182. statusCode: http.StatusOK,
  183. createSession: func() *state.Session {
  184. sess := state.NewSession()
  185. sess.SetIdentScreenName(state.NewIdentScreenName("userA"))
  186. sess.SetDisplayScreenName(state.DisplayScreenName("userA"))
  187. sess.SetUIN(0)
  188. sess.SetNowFn(nowFn)
  189. sess.SetSignonTime(fixedNow.Add(-150 * time.Second))
  190. instance := sess.AddInstance()
  191. instance.SetSignonComplete()
  192. ip, _ := netip.ParseAddrPort("1.2.3.4:1234")
  193. instance.SetRemoteAddr(&ip)
  194. return sess
  195. },
  196. },
  197. }
  198. for _, tc := range tt {
  199. t.Run(tc.name, func(t *testing.T) {
  200. request := httptest.NewRequest(http.MethodGet, "/session/"+tc.requestScreenName.String(), nil)
  201. request.SetPathValue("screenname", tc.requestScreenName.String())
  202. responseRecorder := httptest.NewRecorder()
  203. sessionRetriever := newMockSessionRetriever(t)
  204. session := tc.createSession()
  205. sessionRetriever.EXPECT().
  206. RetrieveSession(tc.requestScreenName).
  207. Return(session)
  208. getSessionHandler(responseRecorder, request, sessionRetriever, nowFn)
  209. if responseRecorder.Code != tc.statusCode {
  210. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  211. }
  212. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  213. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  214. }
  215. })
  216. }
  217. }
  218. func TestSessionHandlerScreenname_DELETE(t *testing.T) {
  219. fnNewSess := func(screenName string) *state.Session {
  220. sess := state.NewSession()
  221. sess.SetIdentScreenName(state.NewIdentScreenName(screenName))
  222. sess.SetDisplayScreenName(state.DisplayScreenName(screenName))
  223. instance := sess.AddInstance()
  224. instance.SetSignonComplete()
  225. ip, _ := netip.ParseAddrPort("1.2.3.4:1234")
  226. instance.SetRemoteAddr(&ip)
  227. return sess
  228. }
  229. tt := []struct {
  230. name string
  231. session *state.SessionInstance
  232. requestScreenName state.IdentScreenName
  233. statusCode int
  234. mockParams mockParams
  235. }{
  236. {
  237. name: "delete an active session",
  238. requestScreenName: state.NewIdentScreenName("userA"),
  239. statusCode: http.StatusNoContent,
  240. mockParams: mockParams{
  241. sessionRetrieverParams: sessionRetrieverParams{
  242. retrieveSessionByNameParams: retrieveSessionByNameParams{
  243. {
  244. screenName: state.NewIdentScreenName("userA"),
  245. result: fnNewSess("userA"),
  246. },
  247. },
  248. },
  249. },
  250. },
  251. {
  252. name: "delete a non-existent session",
  253. requestScreenName: state.NewIdentScreenName("userA"),
  254. statusCode: http.StatusNotFound,
  255. mockParams: mockParams{
  256. sessionRetrieverParams: sessionRetrieverParams{
  257. retrieveSessionByNameParams: retrieveSessionByNameParams{
  258. {
  259. screenName: state.NewIdentScreenName("userA"),
  260. result: nil,
  261. },
  262. },
  263. },
  264. },
  265. },
  266. }
  267. for _, tc := range tt {
  268. t.Run(tc.name, func(t *testing.T) {
  269. request := httptest.NewRequest(http.MethodDelete, "/session/"+tc.requestScreenName.String(), nil)
  270. request.SetPathValue("screenname", tc.requestScreenName.String())
  271. responseRecorder := httptest.NewRecorder()
  272. sessionRetriever := newMockSessionRetriever(t)
  273. for _, params := range tc.mockParams.sessionRetrieverParams.retrieveSessionByNameParams {
  274. sessionRetriever.EXPECT().
  275. RetrieveSession(params.screenName).
  276. Return(params.result)
  277. }
  278. deleteSessionHandler(responseRecorder, request, sessionRetriever)
  279. if responseRecorder.Code != tc.statusCode {
  280. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  281. }
  282. })
  283. }
  284. }
  285. func TestUserAccountHandler_GET(t *testing.T) {
  286. tt := []struct {
  287. name string
  288. requestScreenName state.IdentScreenName
  289. want string
  290. statusCode int
  291. mockParams mockParams
  292. }{
  293. {
  294. name: "invalid account",
  295. requestScreenName: state.NewIdentScreenName("userA"),
  296. want: `user not found`,
  297. statusCode: http.StatusNotFound,
  298. mockParams: mockParams{
  299. userManagerParams: userManagerParams{
  300. getUserParams: getUserParams{
  301. {
  302. screenName: state.NewIdentScreenName("userA"),
  303. result: nil,
  304. },
  305. },
  306. },
  307. },
  308. },
  309. {
  310. name: "valid aim account",
  311. requestScreenName: state.NewIdentScreenName("userA"),
  312. want: `{"id":"usera","screen_name":"userA","profile":"My Profile Text","email_address":"\u003cuserA@aol.com\u003e","reg_status":2,"confirmed":true,"is_icq":false,"suspended_status":"","is_bot":false}`,
  313. statusCode: http.StatusOK,
  314. mockParams: mockParams{
  315. userManagerParams: userManagerParams{
  316. getUserParams: getUserParams{
  317. {
  318. screenName: state.NewIdentScreenName("userA"),
  319. result: &state.User{
  320. DisplayScreenName: "userA",
  321. IdentScreenName: state.NewIdentScreenName("userA"),
  322. SuspendedStatus: 0x0,
  323. },
  324. },
  325. },
  326. },
  327. accountManagerParams: accountManagerParams{
  328. EmailAddressParams: EmailAddressParams{
  329. {
  330. screenName: state.NewIdentScreenName("userA"),
  331. result: &mail.Address{
  332. Address: "userA@aol.com",
  333. },
  334. },
  335. },
  336. RegStatusParams: RegStatusParams{
  337. {
  338. screenName: state.NewIdentScreenName("userA"),
  339. result: uint16(0x02),
  340. },
  341. },
  342. ConfirmStatusParams: ConfirmStatusParams{
  343. {
  344. screenName: state.NewIdentScreenName("userA"),
  345. result: true,
  346. },
  347. },
  348. },
  349. profileRetrieverParams: profileRetrieverParams{
  350. retrieveProfileParams: retrieveProfileParams{
  351. {
  352. screenName: state.NewIdentScreenName("userA"),
  353. result: state.UserProfile{ProfileText: "My Profile Text"},
  354. },
  355. },
  356. },
  357. },
  358. },
  359. {
  360. name: "valid aim bot account",
  361. requestScreenName: state.NewIdentScreenName("userA"),
  362. want: `{"id":"usera","screen_name":"userA","profile":"My Profile Text","email_address":"\u003cuserA@aol.com\u003e","reg_status":2,"confirmed":true,"is_icq":false,"suspended_status":"","is_bot":true}`,
  363. statusCode: http.StatusOK,
  364. mockParams: mockParams{
  365. userManagerParams: userManagerParams{
  366. getUserParams: getUserParams{
  367. {
  368. screenName: state.NewIdentScreenName("userA"),
  369. result: &state.User{
  370. DisplayScreenName: "userA",
  371. IdentScreenName: state.NewIdentScreenName("userA"),
  372. SuspendedStatus: 0x0,
  373. IsBot: true,
  374. },
  375. },
  376. },
  377. },
  378. accountManagerParams: accountManagerParams{
  379. EmailAddressParams: EmailAddressParams{
  380. {
  381. screenName: state.NewIdentScreenName("userA"),
  382. result: &mail.Address{
  383. Address: "userA@aol.com",
  384. },
  385. },
  386. },
  387. RegStatusParams: RegStatusParams{
  388. {
  389. screenName: state.NewIdentScreenName("userA"),
  390. result: uint16(0x02),
  391. },
  392. },
  393. ConfirmStatusParams: ConfirmStatusParams{
  394. {
  395. screenName: state.NewIdentScreenName("userA"),
  396. result: true,
  397. },
  398. },
  399. },
  400. profileRetrieverParams: profileRetrieverParams{
  401. retrieveProfileParams: retrieveProfileParams{
  402. {
  403. screenName: state.NewIdentScreenName("userA"),
  404. result: state.UserProfile{ProfileText: "My Profile Text"},
  405. },
  406. },
  407. },
  408. },
  409. },
  410. {
  411. name: "suspended aim account",
  412. requestScreenName: state.NewIdentScreenName("userB"),
  413. want: `{"id":"userb","screen_name":"userB","profile":"My Profile Text","email_address":"\u003cuserB@aol.com\u003e","reg_status":2,"confirmed":true,"is_icq":false,"suspended_status":"suspended","is_bot":false}`,
  414. statusCode: http.StatusOK,
  415. mockParams: mockParams{
  416. userManagerParams: userManagerParams{
  417. getUserParams: getUserParams{
  418. {
  419. screenName: state.NewIdentScreenName("userB"),
  420. result: &state.User{
  421. DisplayScreenName: "userB",
  422. IdentScreenName: state.NewIdentScreenName("userB"),
  423. SuspendedStatus: wire.LoginErrSuspendedAccount,
  424. },
  425. },
  426. },
  427. },
  428. accountManagerParams: accountManagerParams{
  429. EmailAddressParams: EmailAddressParams{
  430. {
  431. screenName: state.NewIdentScreenName("userB"),
  432. result: &mail.Address{
  433. Address: "userB@aol.com",
  434. },
  435. },
  436. },
  437. RegStatusParams: RegStatusParams{
  438. {
  439. screenName: state.NewIdentScreenName("userB"),
  440. result: uint16(0x02),
  441. },
  442. },
  443. ConfirmStatusParams: ConfirmStatusParams{
  444. {
  445. screenName: state.NewIdentScreenName("userB"),
  446. result: true,
  447. },
  448. },
  449. },
  450. profileRetrieverParams: profileRetrieverParams{
  451. retrieveProfileParams: retrieveProfileParams{
  452. {
  453. screenName: state.NewIdentScreenName("userB"),
  454. result: state.UserProfile{ProfileText: "My Profile Text"},
  455. },
  456. },
  457. },
  458. },
  459. },
  460. }
  461. for _, tc := range tt {
  462. t.Run(tc.name, func(t *testing.T) {
  463. request := httptest.NewRequest(http.MethodGet, "/user/"+tc.requestScreenName.String()+"/account", nil)
  464. request.SetPathValue("screenname", tc.requestScreenName.String())
  465. responseRecorder := httptest.NewRecorder()
  466. userManager := newMockUserManager(t)
  467. for _, params := range tc.mockParams.userManagerParams.getUserParams {
  468. userManager.EXPECT().
  469. User(matchContext(), params.screenName).
  470. Return(params.result, params.err)
  471. }
  472. accountManager := newMockAccountManager(t)
  473. for _, params := range tc.mockParams.accountManagerParams.EmailAddressParams {
  474. accountManager.EXPECT().
  475. EmailAddress(matchContext(), params.screenName).
  476. Return(params.result, params.err)
  477. }
  478. for _, params := range tc.mockParams.accountManagerParams.RegStatusParams {
  479. accountManager.EXPECT().
  480. RegStatus(matchContext(), params.screenName).
  481. Return(params.result, params.err)
  482. }
  483. for _, params := range tc.mockParams.accountManagerParams.ConfirmStatusParams {
  484. accountManager.EXPECT().
  485. ConfirmStatus(matchContext(), params.screenName).
  486. Return(params.result, params.err)
  487. }
  488. profileRetriever := newMockProfileRetriever(t)
  489. for _, params := range tc.mockParams.profileRetrieverParams.retrieveProfileParams {
  490. profileRetriever.EXPECT().
  491. Profile(matchContext(), params.screenName).
  492. Return(params.result, params.err)
  493. }
  494. getUserAccountHandler(responseRecorder, request, userManager, accountManager, profileRetriever, slog.Default())
  495. if responseRecorder.Code != tc.statusCode {
  496. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  497. }
  498. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  499. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  500. }
  501. })
  502. }
  503. }
  504. func TestUserAccountHandler_PATCH(t *testing.T) {
  505. tt := []struct {
  506. name string
  507. requestScreenName state.IdentScreenName
  508. want string
  509. body string
  510. statusCode int
  511. mockParams mockParams
  512. }{
  513. {
  514. name: "suspending a non-existent account",
  515. requestScreenName: state.NewIdentScreenName("userA"),
  516. body: `{"suspended_status":"suspended"}`,
  517. want: `user not found`,
  518. statusCode: http.StatusNotFound,
  519. mockParams: mockParams{
  520. userManagerParams: userManagerParams{
  521. getUserParams: getUserParams{
  522. {
  523. screenName: state.NewIdentScreenName("userA"),
  524. result: nil,
  525. },
  526. },
  527. },
  528. },
  529. },
  530. {
  531. name: "patching with invalid suspended_status value",
  532. requestScreenName: state.NewIdentScreenName("userA"),
  533. body: `{"suspended_status":"thisisinvalid"}`,
  534. want: `{"message":"suspended_status must be empty str or one of deleted,expired,suspended,suspended_age"}`,
  535. statusCode: http.StatusBadRequest,
  536. mockParams: mockParams{
  537. userManagerParams: userManagerParams{
  538. getUserParams: getUserParams{
  539. {
  540. screenName: state.NewIdentScreenName("userA"),
  541. result: &state.User{},
  542. },
  543. },
  544. },
  545. },
  546. },
  547. {
  548. name: "suspending an active aim account",
  549. requestScreenName: state.NewIdentScreenName("userA"),
  550. statusCode: http.StatusNoContent,
  551. body: `{"suspended_status":"suspended"}`,
  552. mockParams: mockParams{
  553. userManagerParams: userManagerParams{
  554. getUserParams: getUserParams{
  555. {
  556. screenName: state.NewIdentScreenName("userA"),
  557. result: &state.User{
  558. DisplayScreenName: "userA",
  559. IdentScreenName: state.NewIdentScreenName("userA"),
  560. SuspendedStatus: 0x0,
  561. },
  562. },
  563. },
  564. },
  565. accountManagerParams: accountManagerParams{
  566. updateSuspendedStatusParams: updateSuspendedStatusParams{
  567. {
  568. suspendedStatus: wire.LoginErrSuspendedAccount,
  569. screenName: state.NewIdentScreenName("userA"),
  570. err: nil,
  571. },
  572. },
  573. },
  574. },
  575. },
  576. {
  577. name: "unsuspending a suspended aim account",
  578. requestScreenName: state.NewIdentScreenName("userA"),
  579. statusCode: http.StatusNoContent,
  580. body: `{"suspended_status":""}`,
  581. mockParams: mockParams{
  582. userManagerParams: userManagerParams{
  583. getUserParams: getUserParams{
  584. {
  585. screenName: state.NewIdentScreenName("userA"),
  586. result: &state.User{
  587. DisplayScreenName: "userA",
  588. IdentScreenName: state.NewIdentScreenName("userA"),
  589. SuspendedStatus: wire.LoginErrSuspendedAccount,
  590. },
  591. },
  592. },
  593. },
  594. accountManagerParams: accountManagerParams{
  595. updateSuspendedStatusParams: updateSuspendedStatusParams{
  596. {
  597. suspendedStatus: 0x0,
  598. screenName: state.NewIdentScreenName("userA"),
  599. err: nil,
  600. },
  601. },
  602. },
  603. },
  604. },
  605. {
  606. name: "suspending an already suspended aim account",
  607. requestScreenName: state.NewIdentScreenName("userA"),
  608. statusCode: http.StatusNotModified,
  609. body: `{"suspended_status":"suspended"}`,
  610. mockParams: mockParams{
  611. userManagerParams: userManagerParams{
  612. getUserParams: getUserParams{
  613. {
  614. screenName: state.NewIdentScreenName("userA"),
  615. result: &state.User{
  616. DisplayScreenName: "userA",
  617. IdentScreenName: state.NewIdentScreenName("userA"),
  618. SuspendedStatus: wire.LoginErrSuspendedAccount,
  619. },
  620. },
  621. },
  622. },
  623. },
  624. },
  625. {
  626. name: "setting bot flag (before: false, after: true)",
  627. requestScreenName: state.NewIdentScreenName("userA"),
  628. statusCode: http.StatusNoContent,
  629. body: `{"is_bot":true}`,
  630. mockParams: mockParams{
  631. userManagerParams: userManagerParams{
  632. getUserParams: getUserParams{
  633. {
  634. screenName: state.NewIdentScreenName("userA"),
  635. result: &state.User{
  636. DisplayScreenName: "userA",
  637. IdentScreenName: state.NewIdentScreenName("userA"),
  638. SuspendedStatus: 0x0,
  639. IsBot: false,
  640. },
  641. },
  642. },
  643. },
  644. accountManagerParams: accountManagerParams{
  645. setBotStatusParams: setBotStatusParams{
  646. {
  647. isBot: true,
  648. screenName: state.NewIdentScreenName("userA"),
  649. err: nil,
  650. },
  651. },
  652. },
  653. },
  654. },
  655. {
  656. name: "setting bot flag (before: true, after: false)",
  657. requestScreenName: state.NewIdentScreenName("userA"),
  658. statusCode: http.StatusNoContent,
  659. body: `{"is_bot":false}`,
  660. mockParams: mockParams{
  661. userManagerParams: userManagerParams{
  662. getUserParams: getUserParams{
  663. {
  664. screenName: state.NewIdentScreenName("userA"),
  665. result: &state.User{
  666. DisplayScreenName: "userA",
  667. IdentScreenName: state.NewIdentScreenName("userA"),
  668. SuspendedStatus: 0x0,
  669. IsBot: true,
  670. },
  671. },
  672. },
  673. },
  674. accountManagerParams: accountManagerParams{
  675. setBotStatusParams: setBotStatusParams{
  676. {
  677. isBot: false,
  678. screenName: state.NewIdentScreenName("userA"),
  679. err: nil,
  680. },
  681. },
  682. },
  683. },
  684. },
  685. {
  686. name: "setting bot flag (before: true, after: true)",
  687. requestScreenName: state.NewIdentScreenName("userA"),
  688. statusCode: http.StatusNotModified,
  689. body: `{"is_bot":true}`,
  690. mockParams: mockParams{
  691. userManagerParams: userManagerParams{
  692. getUserParams: getUserParams{
  693. {
  694. screenName: state.NewIdentScreenName("userA"),
  695. result: &state.User{
  696. DisplayScreenName: "userA",
  697. IdentScreenName: state.NewIdentScreenName("userA"),
  698. SuspendedStatus: 0x0,
  699. IsBot: true,
  700. },
  701. },
  702. },
  703. },
  704. },
  705. },
  706. }
  707. for _, tc := range tt {
  708. t.Run(tc.name, func(t *testing.T) {
  709. request := httptest.NewRequest(http.MethodPatch, "/user/"+tc.requestScreenName.String()+"/account", strings.NewReader(tc.body))
  710. request.SetPathValue("screenname", tc.requestScreenName.String())
  711. responseRecorder := httptest.NewRecorder()
  712. userManager := newMockUserManager(t)
  713. for _, params := range tc.mockParams.userManagerParams.getUserParams {
  714. userManager.EXPECT().
  715. User(matchContext(), params.screenName).
  716. Return(params.result, params.err)
  717. }
  718. accountManager := newMockAccountManager(t)
  719. for _, params := range tc.mockParams.accountManagerParams.updateSuspendedStatusParams {
  720. accountManager.EXPECT().
  721. UpdateSuspendedStatus(matchContext(), params.suspendedStatus, params.screenName).
  722. Return(params.err)
  723. }
  724. for _, params := range tc.mockParams.accountManagerParams.setBotStatusParams {
  725. accountManager.EXPECT().
  726. SetBotStatus(matchContext(), params.isBot, params.screenName).
  727. Return(params.err)
  728. }
  729. patchUserAccountHandler(responseRecorder, request, userManager, accountManager, slog.Default())
  730. if responseRecorder.Code != tc.statusCode {
  731. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  732. }
  733. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  734. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  735. }
  736. })
  737. }
  738. }
  739. func TestUserBuddyIconHandler_GET(t *testing.T) {
  740. sampleGIF := []byte{
  741. 0x47, 0x49, 0x46, 0x38, 0x39, 0x61, 0x32, 0x00, 0x32, 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
  742. 0x00, 0x00, 0x00, 0x21, 0xf9, 0x04, 0x01, 0x00, 0x00, 0x00, 0x00, 0x2c, 0x00, 0x00, 0x00, 0x00,
  743. 0x32, 0x00, 0x32, 0x00, 0x00, 0x02, 0x02, 0x44, 0x01, 0x00, 0x3b}
  744. sampleJPG := []byte{0xFF, 0xD8, 0xFF, 0x43, 0x13, 0x37}
  745. tt := []struct {
  746. name string
  747. requestScreenName state.IdentScreenName
  748. want string
  749. statusCode int
  750. contentType string
  751. mockParams mockParams
  752. }{
  753. {
  754. name: "invalid account",
  755. requestScreenName: state.NewIdentScreenName("userA"),
  756. want: `user not found`,
  757. statusCode: http.StatusNotFound,
  758. contentType: "text/plain; charset=utf-8",
  759. mockParams: mockParams{
  760. userManagerParams: userManagerParams{
  761. getUserParams: getUserParams{
  762. {
  763. screenName: state.NewIdentScreenName("userA"),
  764. result: nil,
  765. },
  766. },
  767. },
  768. },
  769. },
  770. {
  771. name: "account with gif buddy icon",
  772. requestScreenName: state.NewIdentScreenName("userA"),
  773. want: string(sampleGIF),
  774. statusCode: http.StatusOK,
  775. contentType: "image/gif",
  776. mockParams: mockParams{
  777. userManagerParams: userManagerParams{
  778. getUserParams: getUserParams{
  779. {
  780. screenName: state.NewIdentScreenName("userA"),
  781. result: &state.User{
  782. DisplayScreenName: "userA",
  783. IdentScreenName: state.NewIdentScreenName("userA"),
  784. },
  785. },
  786. },
  787. },
  788. feedBagRetrieverParams: feedBagRetrieverParams{
  789. buddyIconMetadataParams: buddyIconMetadataParams{
  790. {
  791. screenName: state.NewIdentScreenName("userA"),
  792. result: &wire.BARTID{
  793. Type: wire.BARTTypesBuddyIcon,
  794. BARTInfo: wire.BARTInfo{
  795. Flags: 0x00,
  796. Hash: []byte{'t', 'h', 'e', 'h', 'a', 's', 'h'},
  797. },
  798. },
  799. },
  800. },
  801. },
  802. bartAssetManagerParams: bartAssetManagerParams{
  803. bartItemParams: bartItemParams{
  804. {
  805. hash: []byte{'t', 'h', 'e', 'h', 'a', 's', 'h'},
  806. result: sampleGIF,
  807. },
  808. },
  809. },
  810. },
  811. },
  812. {
  813. name: "account with jpg buddy icon",
  814. requestScreenName: state.NewIdentScreenName("userA"),
  815. want: string(sampleJPG),
  816. statusCode: http.StatusOK,
  817. contentType: "image/jpeg",
  818. mockParams: mockParams{
  819. userManagerParams: userManagerParams{
  820. getUserParams: getUserParams{
  821. {
  822. screenName: state.NewIdentScreenName("userA"),
  823. result: &state.User{
  824. DisplayScreenName: "userA",
  825. IdentScreenName: state.NewIdentScreenName("userA"),
  826. },
  827. },
  828. },
  829. },
  830. feedBagRetrieverParams: feedBagRetrieverParams{
  831. buddyIconMetadataParams: buddyIconMetadataParams{
  832. {
  833. screenName: state.NewIdentScreenName("userA"),
  834. result: &wire.BARTID{
  835. Type: wire.BARTTypesBuddyIcon,
  836. BARTInfo: wire.BARTInfo{
  837. Flags: 0x00,
  838. Hash: []byte{'t', 'h', 'e', 'h', 'a', 's', 'h'},
  839. },
  840. },
  841. },
  842. },
  843. },
  844. bartAssetManagerParams: bartAssetManagerParams{
  845. bartItemParams: bartItemParams{
  846. {
  847. hash: []byte{'t', 'h', 'e', 'h', 'a', 's', 'h'},
  848. result: sampleJPG,
  849. },
  850. },
  851. },
  852. },
  853. },
  854. {
  855. name: "account with unknown format buddy icon",
  856. requestScreenName: state.NewIdentScreenName("userA"),
  857. want: string([]byte{0x13, 0x37, 0x13, 0x37, 0x13, 0x37}),
  858. statusCode: http.StatusOK,
  859. contentType: "application/octet-stream",
  860. mockParams: mockParams{
  861. userManagerParams: userManagerParams{
  862. getUserParams: getUserParams{
  863. {
  864. screenName: state.NewIdentScreenName("userA"),
  865. result: &state.User{
  866. DisplayScreenName: "userA",
  867. IdentScreenName: state.NewIdentScreenName("userA"),
  868. },
  869. },
  870. },
  871. },
  872. feedBagRetrieverParams: feedBagRetrieverParams{
  873. buddyIconMetadataParams: buddyIconMetadataParams{
  874. {
  875. screenName: state.NewIdentScreenName("userA"),
  876. result: &wire.BARTID{
  877. Type: wire.BARTTypesBuddyIcon,
  878. BARTInfo: wire.BARTInfo{
  879. Flags: 0x00,
  880. Hash: []byte{'t', 'h', 'e', 'h', 'a', 's', 'h'},
  881. },
  882. },
  883. },
  884. },
  885. },
  886. bartAssetManagerParams: bartAssetManagerParams{
  887. bartItemParams: bartItemParams{
  888. {
  889. hash: []byte{'t', 'h', 'e', 'h', 'a', 's', 'h'},
  890. result: []byte{0x13, 0x37, 0x13, 0x37, 0x13, 0x37},
  891. },
  892. },
  893. },
  894. },
  895. },
  896. {
  897. name: "account with cleared buddy icon",
  898. requestScreenName: state.NewIdentScreenName("userA"),
  899. want: "icon not found",
  900. statusCode: http.StatusNotFound,
  901. contentType: "text/plain; charset=utf-8",
  902. mockParams: mockParams{
  903. userManagerParams: userManagerParams{
  904. getUserParams: getUserParams{
  905. {
  906. screenName: state.NewIdentScreenName("userA"),
  907. result: &state.User{
  908. DisplayScreenName: "userA",
  909. IdentScreenName: state.NewIdentScreenName("userA"),
  910. },
  911. },
  912. },
  913. },
  914. feedBagRetrieverParams: feedBagRetrieverParams{
  915. buddyIconMetadataParams: buddyIconMetadataParams{
  916. {
  917. screenName: state.NewIdentScreenName("userA"),
  918. result: &wire.BARTID{
  919. Type: wire.BARTTypesBuddyIcon,
  920. BARTInfo: wire.BARTInfo{
  921. Flags: 0x00,
  922. Hash: wire.GetClearIconHash(),
  923. },
  924. },
  925. },
  926. },
  927. },
  928. },
  929. },
  930. {
  931. name: "account with no buddy icon",
  932. requestScreenName: state.NewIdentScreenName("userA"),
  933. want: "icon not found",
  934. statusCode: http.StatusNotFound,
  935. contentType: "text/plain; charset=utf-8",
  936. mockParams: mockParams{
  937. userManagerParams: userManagerParams{
  938. getUserParams: getUserParams{
  939. {
  940. screenName: state.NewIdentScreenName("userA"),
  941. result: &state.User{
  942. DisplayScreenName: "userA",
  943. IdentScreenName: state.NewIdentScreenName("userA"),
  944. },
  945. },
  946. },
  947. },
  948. feedBagRetrieverParams: feedBagRetrieverParams{
  949. buddyIconMetadataParams: buddyIconMetadataParams{
  950. {
  951. screenName: state.NewIdentScreenName("userA"),
  952. result: nil,
  953. },
  954. },
  955. },
  956. },
  957. },
  958. }
  959. for _, tc := range tt {
  960. t.Run(tc.name, func(t *testing.T) {
  961. request := httptest.NewRequest(http.MethodGet, "/user/"+tc.requestScreenName.String()+"/icon", nil)
  962. request.SetPathValue("screenname", tc.requestScreenName.String())
  963. responseRecorder := httptest.NewRecorder()
  964. userManager := newMockUserManager(t)
  965. for _, params := range tc.mockParams.userManagerParams.getUserParams {
  966. userManager.EXPECT().
  967. User(matchContext(), params.screenName).
  968. Return(params.result, params.err)
  969. }
  970. feedbagRetriever := newMockFeedBagRetriever(t)
  971. for _, params := range tc.mockParams.feedBagRetrieverParams.buddyIconMetadataParams {
  972. feedbagRetriever.EXPECT().
  973. BuddyIconMetadata(matchContext(), params.screenName).
  974. Return(params.result, params.err)
  975. }
  976. bartRetriever := newMockBARTAssetManager(t)
  977. for _, params := range tc.mockParams.bartAssetManagerParams.bartItemParams {
  978. bartRetriever.EXPECT().
  979. BARTItem(matchContext(), params.hash).
  980. Return(params.result, params.err)
  981. }
  982. getUserBuddyIconHandler(responseRecorder, request, userManager, feedbagRetriever, bartRetriever, slog.Default())
  983. if responseRecorder.Code != tc.statusCode {
  984. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  985. }
  986. contentType := responseRecorder.Header().Get("Content-Type")
  987. if contentType != tc.contentType {
  988. t.Errorf("Want content type '%s', got '%s'", tc.contentType, contentType)
  989. }
  990. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  991. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  992. }
  993. })
  994. }
  995. }
  996. func TestUserHandler_GET(t *testing.T) {
  997. tt := []struct {
  998. name string
  999. want string
  1000. statusCode int
  1001. mockParams mockParams
  1002. }{
  1003. {
  1004. name: "empty user store",
  1005. want: `[]`,
  1006. statusCode: http.StatusOK,
  1007. mockParams: mockParams{
  1008. userManagerParams: userManagerParams{
  1009. allUsersParams: allUsersParams{
  1010. {
  1011. result: []state.User{},
  1012. },
  1013. },
  1014. },
  1015. },
  1016. },
  1017. {
  1018. name: "user store containing 3 users",
  1019. want: `[{"id":"usera","screen_name":"userA","is_icq":false,"suspended_status":"","is_bot":false},{"id":"userb","screen_name":"userB","is_icq":false,"suspended_status":"","is_bot":true},{"id":"100003","screen_name":"100003","is_icq":true,"suspended_status":"","is_bot":false}]`,
  1020. statusCode: http.StatusOK,
  1021. mockParams: mockParams{
  1022. userManagerParams: userManagerParams{
  1023. allUsersParams: allUsersParams{
  1024. {
  1025. result: []state.User{
  1026. {
  1027. DisplayScreenName: "userA",
  1028. IdentScreenName: state.NewIdentScreenName("userA"),
  1029. },
  1030. {
  1031. DisplayScreenName: "userB",
  1032. IdentScreenName: state.NewIdentScreenName("userB"),
  1033. IsBot: true,
  1034. },
  1035. {
  1036. DisplayScreenName: "100003",
  1037. IdentScreenName: state.NewIdentScreenName("100003"),
  1038. IsICQ: true,
  1039. },
  1040. },
  1041. },
  1042. },
  1043. },
  1044. },
  1045. },
  1046. {
  1047. name: "user handler error",
  1048. want: `internal server error`,
  1049. statusCode: http.StatusInternalServerError,
  1050. mockParams: mockParams{
  1051. userManagerParams: userManagerParams{
  1052. allUsersParams: allUsersParams{
  1053. {
  1054. result: []state.User{},
  1055. err: io.EOF,
  1056. },
  1057. },
  1058. },
  1059. },
  1060. },
  1061. }
  1062. for _, tc := range tt {
  1063. t.Run(tc.name, func(t *testing.T) {
  1064. request := httptest.NewRequest(http.MethodGet, "/user", nil)
  1065. responseRecorder := httptest.NewRecorder()
  1066. userManager := newMockUserManager(t)
  1067. for _, params := range tc.mockParams.userManagerParams.allUsersParams {
  1068. userManager.EXPECT().
  1069. AllUsers(matchContext()).
  1070. Return(params.result, params.err)
  1071. }
  1072. getUserHandler(responseRecorder, request, userManager, slog.Default())
  1073. if responseRecorder.Code != tc.statusCode {
  1074. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1075. }
  1076. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1077. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  1078. }
  1079. })
  1080. }
  1081. }
  1082. func TestUserHandler_POST(t *testing.T) {
  1083. tt := []struct {
  1084. name string
  1085. body string
  1086. want string
  1087. statusCode int
  1088. createAccount state.CreateAccountFunc
  1089. }{
  1090. {
  1091. name: "with valid AIM user",
  1092. body: `{"screen_name":"userA", "password":"thepassword"}`,
  1093. want: `User account created successfully.`,
  1094. statusCode: http.StatusCreated,
  1095. createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
  1096. assert.Equal(t, state.DisplayScreenName("userA"), screenName)
  1097. assert.Equal(t, "thepassword", password)
  1098. return nil
  1099. },
  1100. },
  1101. {
  1102. name: "with valid ICQ user",
  1103. body: `{"screen_name":"100003", "password":"thepass"}`,
  1104. want: `User account created successfully.`,
  1105. statusCode: http.StatusCreated,
  1106. createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
  1107. assert.Equal(t, state.DisplayScreenName("100003"), screenName)
  1108. assert.Equal(t, "thepass", password)
  1109. return nil
  1110. },
  1111. },
  1112. {
  1113. name: "with malformed body",
  1114. body: `{"screen_name":"userA", "password":"thepassword"`, // missing closing }
  1115. want: `malformed input`,
  1116. statusCode: http.StatusBadRequest,
  1117. },
  1118. {
  1119. name: "user handler error",
  1120. body: `{"screen_name":"userA", "password":"thepassword"}`,
  1121. want: `internal server error`,
  1122. statusCode: http.StatusInternalServerError,
  1123. createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
  1124. assert.Equal(t, state.DisplayScreenName("userA"), screenName)
  1125. assert.Equal(t, "thepassword", password)
  1126. return io.EOF
  1127. },
  1128. },
  1129. {
  1130. name: "duplicate user",
  1131. body: `{"screen_name":"userA", "password":"thepassword"}`,
  1132. want: `user already exists`,
  1133. statusCode: http.StatusConflict,
  1134. createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
  1135. assert.Equal(t, state.DisplayScreenName("userA"), screenName)
  1136. assert.Equal(t, "thepassword", password)
  1137. return state.ErrDupUser
  1138. },
  1139. },
  1140. {
  1141. name: "invalid AIM screen name",
  1142. body: `{"screen_name":"a", "password":"thepassword"}`,
  1143. want: `invalid screen name: screen name must be between 3 and 16 characters`,
  1144. statusCode: http.StatusBadRequest,
  1145. createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
  1146. assert.Equal(t, state.DisplayScreenName("a"), screenName)
  1147. assert.Equal(t, "thepassword", password)
  1148. return state.ErrAIMHandleLength
  1149. },
  1150. },
  1151. {
  1152. name: "invalid AIM password",
  1153. body: `{"screen_name":"userA", "password":"1"}`,
  1154. want: `invalid password: invalid password length: password length must be between 4-16 characters`,
  1155. statusCode: http.StatusBadRequest,
  1156. createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
  1157. assert.Equal(t, state.DisplayScreenName("userA"), screenName)
  1158. assert.Equal(t, "1", password)
  1159. return fmt.Errorf("%w: password length must be between 4-16 characters", state.ErrPasswordInvalid)
  1160. },
  1161. },
  1162. {
  1163. name: "invalid ICQ UIN",
  1164. body: `{"screen_name":"1000", "password":"thepass"}`,
  1165. want: `invalid uin: uin must be a number in the range 10000-2147483646`,
  1166. statusCode: http.StatusBadRequest,
  1167. createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
  1168. assert.Equal(t, state.DisplayScreenName("1000"), screenName)
  1169. assert.Equal(t, "thepass", password)
  1170. return state.ErrICQUINInvalidFormat
  1171. },
  1172. },
  1173. {
  1174. name: "invalid ICQ password",
  1175. body: `{"screen_name":"100003", "password":"thelongpassword"}`,
  1176. want: `invalid password: invalid password length: password must be between 6-8 characters`,
  1177. statusCode: http.StatusBadRequest,
  1178. createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
  1179. assert.Equal(t, state.DisplayScreenName("100003"), screenName)
  1180. assert.Equal(t, "thelongpassword", password)
  1181. return fmt.Errorf("%w: password must be between 6-8 characters", state.ErrPasswordInvalid)
  1182. },
  1183. },
  1184. }
  1185. for _, tc := range tt {
  1186. t.Run(tc.name, func(t *testing.T) {
  1187. request := httptest.NewRequest(http.MethodPost, "/user", strings.NewReader(tc.body))
  1188. responseRecorder := httptest.NewRecorder()
  1189. postUserHandler(responseRecorder, request, tc.createAccount, slog.Default())
  1190. if responseRecorder.Code != tc.statusCode {
  1191. t.Errorf("want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1192. }
  1193. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1194. t.Errorf("want '%s', got '%s'", tc.want, responseRecorder.Body)
  1195. }
  1196. })
  1197. }
  1198. }
  1199. func TestUserHandler_DELETE(t *testing.T) {
  1200. tt := []struct {
  1201. name string
  1202. body string
  1203. want string
  1204. statusCode int
  1205. mockParams mockParams
  1206. }{
  1207. {
  1208. name: "with valid user",
  1209. body: `{"screen_name":"userA"}`,
  1210. want: `User account successfully deleted.`,
  1211. statusCode: http.StatusNoContent,
  1212. mockParams: mockParams{
  1213. userManagerParams: userManagerParams{
  1214. deleteUserParams: deleteUserParams{
  1215. {
  1216. screenName: state.NewIdentScreenName("userA"),
  1217. },
  1218. },
  1219. },
  1220. },
  1221. },
  1222. {
  1223. name: "with non-existent user",
  1224. body: `{"screen_name":"userA"}`,
  1225. want: `user does not exist`,
  1226. statusCode: http.StatusNotFound,
  1227. mockParams: mockParams{
  1228. userManagerParams: userManagerParams{
  1229. deleteUserParams: deleteUserParams{
  1230. {
  1231. screenName: state.NewIdentScreenName("userA"),
  1232. err: state.ErrNoUser,
  1233. },
  1234. },
  1235. },
  1236. },
  1237. },
  1238. {
  1239. name: "with malformed body",
  1240. body: `{"screen_name":"userA"`, // missing closing }
  1241. want: `malformed input`,
  1242. statusCode: http.StatusBadRequest,
  1243. },
  1244. {
  1245. name: "user handler error",
  1246. body: `{"screen_name":"userA"}`,
  1247. want: `internal server error`,
  1248. statusCode: http.StatusInternalServerError,
  1249. mockParams: mockParams{
  1250. userManagerParams: userManagerParams{
  1251. deleteUserParams: deleteUserParams{
  1252. {
  1253. screenName: state.NewIdentScreenName("userA"),
  1254. err: io.EOF,
  1255. },
  1256. },
  1257. },
  1258. },
  1259. },
  1260. }
  1261. for _, tc := range tt {
  1262. t.Run(tc.name, func(t *testing.T) {
  1263. request := httptest.NewRequest(http.MethodDelete, "/user", strings.NewReader(tc.body))
  1264. responseRecorder := httptest.NewRecorder()
  1265. userManager := newMockUserManager(t)
  1266. for _, params := range tc.mockParams.userManagerParams.deleteUserParams {
  1267. userManager.EXPECT().
  1268. DeleteUser(matchContext(), params.screenName).
  1269. Return(params.err)
  1270. }
  1271. deleteUserHandler(responseRecorder, request, userManager, slog.Default())
  1272. if responseRecorder.Code != tc.statusCode {
  1273. t.Errorf("want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1274. }
  1275. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1276. t.Errorf("want '%s', got '%s'", tc.want, responseRecorder.Body)
  1277. }
  1278. })
  1279. }
  1280. }
  1281. func TestUserPasswordHandler_PUT(t *testing.T) {
  1282. tt := []struct {
  1283. name string
  1284. body string
  1285. want string
  1286. statusCode int
  1287. mockParams mockParams
  1288. }{
  1289. {
  1290. name: "user with valid password",
  1291. body: `{"screen_name":"userA", "password":"thenewpassword"}`,
  1292. want: `Password successfully reset.`,
  1293. statusCode: http.StatusNoContent,
  1294. mockParams: mockParams{
  1295. userManagerParams: userManagerParams{
  1296. setUserPasswordParams: setUserPasswordParams{
  1297. {
  1298. screenName: state.NewIdentScreenName("userA"),
  1299. newPassword: "thenewpassword",
  1300. },
  1301. },
  1302. },
  1303. },
  1304. },
  1305. {
  1306. name: "user with invalid password",
  1307. body: `{"screen_name":"userA", "password":"a"}`,
  1308. want: `invalid password length`,
  1309. statusCode: http.StatusBadRequest,
  1310. mockParams: mockParams{
  1311. userManagerParams: userManagerParams{
  1312. setUserPasswordParams: setUserPasswordParams{
  1313. {
  1314. screenName: state.NewIdentScreenName("userA"),
  1315. newPassword: "a",
  1316. err: state.ErrPasswordInvalid,
  1317. },
  1318. },
  1319. },
  1320. },
  1321. },
  1322. {
  1323. name: "with malformed body",
  1324. body: `{"screen_name":"userA", "password":"thepassword"`, // missing closing }
  1325. want: `malformed input`,
  1326. statusCode: http.StatusBadRequest,
  1327. },
  1328. {
  1329. name: "password updater returns runtime error",
  1330. body: `{"screen_name":"userA", "password":"thepassword"}`,
  1331. want: `internal server error`,
  1332. statusCode: http.StatusInternalServerError,
  1333. mockParams: mockParams{
  1334. userManagerParams: userManagerParams{
  1335. setUserPasswordParams: setUserPasswordParams{
  1336. {
  1337. screenName: state.NewIdentScreenName("userA"),
  1338. newPassword: "thepassword",
  1339. err: io.EOF,
  1340. },
  1341. },
  1342. },
  1343. },
  1344. },
  1345. {
  1346. name: "user doesn't exist",
  1347. body: `{"screen_name":"userA", "password":"thepassword"}`,
  1348. want: `user does not exist`,
  1349. statusCode: http.StatusNotFound,
  1350. mockParams: mockParams{
  1351. userManagerParams: userManagerParams{
  1352. setUserPasswordParams: setUserPasswordParams{
  1353. {
  1354. screenName: state.NewIdentScreenName("userA"),
  1355. newPassword: "thepassword",
  1356. err: state.ErrNoUser,
  1357. },
  1358. },
  1359. },
  1360. },
  1361. },
  1362. }
  1363. for _, tc := range tt {
  1364. t.Run(tc.name, func(t *testing.T) {
  1365. request := httptest.NewRequest(http.MethodPut, "/user", strings.NewReader(tc.body))
  1366. responseRecorder := httptest.NewRecorder()
  1367. userManager := newMockUserManager(t)
  1368. for _, params := range tc.mockParams.userManagerParams.setUserPasswordParams {
  1369. userManager.EXPECT().
  1370. SetUserPassword(matchContext(), params.screenName, params.newPassword).
  1371. Return(params.err)
  1372. }
  1373. putUserPasswordHandler(responseRecorder, request, userManager, slog.Default())
  1374. if responseRecorder.Code != tc.statusCode {
  1375. t.Errorf("want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1376. }
  1377. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1378. t.Errorf("want '%s', got '%s'", tc.want, responseRecorder.Body)
  1379. }
  1380. })
  1381. }
  1382. }
  1383. func TestPublicChatHandler_GET(t *testing.T) {
  1384. fnNewSess := func(screenName string) *state.Session {
  1385. sess := state.NewSession()
  1386. sess.SetIdentScreenName(state.NewIdentScreenName(screenName))
  1387. sess.SetDisplayScreenName(state.DisplayScreenName(screenName))
  1388. instance := sess.AddInstance()
  1389. instance.SetSignonComplete()
  1390. return sess
  1391. }
  1392. chatRoom1 := state.NewChatRoom("chat-room-1-name", state.NewIdentScreenName("chat-room-1-creator"), state.PublicExchange)
  1393. chatRoom2 := state.NewChatRoom("chat-room-2-name", state.NewIdentScreenName("chat-room-1-creator"), state.PublicExchange)
  1394. tt := []struct {
  1395. name string
  1396. want string
  1397. statusCode int
  1398. mockParams mockParams
  1399. }{
  1400. {
  1401. name: "multiple chat rooms with participants",
  1402. want: `[{"name":"chat-room-1-name","create_time":"0001-01-01T00:00:00Z","url":"aim:gochat?roomname=chat-room-1-name&exchange=5","participants":[{"id":"usera","screen_name":"userA"},{"id":"userb","screen_name":"userB"}]},{"name":"chat-room-2-name","create_time":"0001-01-01T00:00:00Z","url":"aim:gochat?roomname=chat-room-2-name&exchange=5","participants":[{"id":"userc","screen_name":"userC"},{"id":"userd","screen_name":"userD"}]}]`,
  1403. statusCode: http.StatusOK,
  1404. mockParams: mockParams{
  1405. chatRoomRetrieverParams: chatRoomRetrieverParams{
  1406. allChatRoomsParams: allChatRoomsParams{
  1407. {
  1408. exchange: state.PublicExchange,
  1409. result: []state.ChatRoom{
  1410. chatRoom1,
  1411. chatRoom2,
  1412. },
  1413. },
  1414. },
  1415. },
  1416. chatSessionRetrieverParams: chatSessionRetrieverParams{
  1417. chatSessionRetrieverAllSessionsParams: chatSessionRetrieverAllSessionsParams{
  1418. {
  1419. cookie: chatRoom1.Cookie(),
  1420. result: []*state.Session{
  1421. fnNewSess("userA"),
  1422. fnNewSess("userB"),
  1423. },
  1424. },
  1425. {
  1426. cookie: chatRoom2.Cookie(),
  1427. result: []*state.Session{
  1428. fnNewSess("userC"),
  1429. fnNewSess("userD"),
  1430. },
  1431. },
  1432. },
  1433. },
  1434. },
  1435. },
  1436. {
  1437. name: "chat room without participants",
  1438. want: `[{"name":"chat-room-1-name","create_time":"0001-01-01T00:00:00Z","url":"aim:gochat?roomname=chat-room-1-name&exchange=5","participants":[]}]`,
  1439. statusCode: http.StatusOK,
  1440. mockParams: mockParams{
  1441. chatRoomRetrieverParams: chatRoomRetrieverParams{
  1442. allChatRoomsParams: allChatRoomsParams{
  1443. {
  1444. exchange: state.PublicExchange,
  1445. result: []state.ChatRoom{
  1446. chatRoom1,
  1447. },
  1448. },
  1449. },
  1450. },
  1451. chatSessionRetrieverParams: chatSessionRetrieverParams{
  1452. chatSessionRetrieverAllSessionsParams: chatSessionRetrieverAllSessionsParams{
  1453. {
  1454. cookie: chatRoom1.Cookie(),
  1455. result: []*state.Session{},
  1456. },
  1457. },
  1458. },
  1459. },
  1460. },
  1461. {
  1462. name: "no chat rooms",
  1463. want: `[]`,
  1464. statusCode: http.StatusOK,
  1465. mockParams: mockParams{
  1466. chatRoomRetrieverParams: chatRoomRetrieverParams{
  1467. allChatRoomsParams: allChatRoomsParams{
  1468. {
  1469. exchange: state.PublicExchange,
  1470. result: []state.ChatRoom{},
  1471. },
  1472. },
  1473. },
  1474. },
  1475. },
  1476. }
  1477. for _, tc := range tt {
  1478. t.Run(tc.name, func(t *testing.T) {
  1479. request := httptest.NewRequest(http.MethodGet, "/chat/room/public", nil)
  1480. responseRecorder := httptest.NewRecorder()
  1481. chatRoomRetriever := newMockChatRoomRetriever(t)
  1482. for _, params := range tc.mockParams.chatRoomRetrieverParams.allChatRoomsParams {
  1483. chatRoomRetriever.EXPECT().
  1484. AllChatRooms(matchContext(), params.exchange).
  1485. Return(params.result, params.err)
  1486. }
  1487. chatSessionRetriever := newMockChatSessionRetriever(t)
  1488. for _, params := range tc.mockParams.chatSessionRetrieverParams.chatSessionRetrieverAllSessionsParams {
  1489. chatSessionRetriever.EXPECT().
  1490. AllSessions(params.cookie).
  1491. Return(params.result)
  1492. }
  1493. getPublicChatHandler(responseRecorder, request, chatRoomRetriever, chatSessionRetriever, slog.Default())
  1494. if responseRecorder.Code != tc.statusCode {
  1495. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1496. }
  1497. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1498. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  1499. }
  1500. })
  1501. }
  1502. }
  1503. func TestDeletePublicChatHandler(t *testing.T) {
  1504. tt := []struct {
  1505. name string
  1506. body string
  1507. want string
  1508. statusCode int
  1509. mockParams mockParams
  1510. }{
  1511. {
  1512. name: "successful deletion of single chat room",
  1513. body: `{"names":["TestRoom"]}`,
  1514. want: `Chat rooms deleted successfully.`,
  1515. statusCode: http.StatusNoContent,
  1516. mockParams: mockParams{
  1517. chatRoomDeleterParams: chatRoomDeleterParams{
  1518. deleteChatRoomsParams: deleteChatRoomsParams{
  1519. {
  1520. exchange: state.PublicExchange,
  1521. names: []string{"TestRoom"},
  1522. },
  1523. },
  1524. },
  1525. },
  1526. },
  1527. {
  1528. name: "successful deletion of multiple chat rooms",
  1529. body: `{"names":["Room1", "Room2", "Room3"]}`,
  1530. want: `Chat rooms deleted successfully.`,
  1531. statusCode: http.StatusNoContent,
  1532. mockParams: mockParams{
  1533. chatRoomDeleterParams: chatRoomDeleterParams{
  1534. deleteChatRoomsParams: deleteChatRoomsParams{
  1535. {
  1536. exchange: state.PublicExchange,
  1537. names: []string{"Room1", "Room2", "Room3"},
  1538. },
  1539. },
  1540. },
  1541. },
  1542. },
  1543. {
  1544. name: "empty names array",
  1545. body: `{"names":[]}`,
  1546. want: `no chat room names provided`,
  1547. statusCode: http.StatusBadRequest,
  1548. },
  1549. {
  1550. name: "malformed JSON",
  1551. body: `{"names":["Room1"`, // missing closing brackets
  1552. want: `malformed input`,
  1553. statusCode: http.StatusBadRequest,
  1554. },
  1555. {
  1556. name: "deletion error",
  1557. body: `{"names":["TestRoom"]}`,
  1558. want: `internal server error`,
  1559. statusCode: http.StatusInternalServerError,
  1560. mockParams: mockParams{
  1561. chatRoomDeleterParams: chatRoomDeleterParams{
  1562. deleteChatRoomsParams: deleteChatRoomsParams{
  1563. {
  1564. exchange: state.PublicExchange,
  1565. names: []string{"TestRoom"},
  1566. err: errors.New("database error"),
  1567. },
  1568. },
  1569. },
  1570. },
  1571. },
  1572. }
  1573. for _, tc := range tt {
  1574. t.Run(tc.name, func(t *testing.T) {
  1575. request := httptest.NewRequest(http.MethodDelete, "/chat/room/public", strings.NewReader(tc.body))
  1576. responseRecorder := httptest.NewRecorder()
  1577. chatRoomDeleter := newMockChatRoomDeleter(t)
  1578. for _, params := range tc.mockParams.chatRoomDeleterParams.deleteChatRoomsParams {
  1579. chatRoomDeleter.EXPECT().
  1580. DeleteChatRooms(matchContext(), params.exchange, params.names).
  1581. Return(params.err)
  1582. }
  1583. deletePublicChatHandler(responseRecorder, request, chatRoomDeleter, slog.Default())
  1584. if responseRecorder.Code != tc.statusCode {
  1585. t.Errorf("want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1586. }
  1587. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1588. t.Errorf("want '%s', got '%s'", tc.want, responseRecorder.Body)
  1589. }
  1590. })
  1591. }
  1592. }
  1593. func TestPrivateChatHandler_GET(t *testing.T) {
  1594. fnNewSess := func(screenName string) *state.Session {
  1595. sess := state.NewSession()
  1596. sess.SetIdentScreenName(state.NewIdentScreenName(screenName))
  1597. sess.SetDisplayScreenName(state.DisplayScreenName(screenName))
  1598. instance := sess.AddInstance()
  1599. instance.SetSignonComplete()
  1600. return sess
  1601. }
  1602. chatRoom1 := state.NewChatRoom("chat-room-1-name", state.NewIdentScreenName("chat-room-1-creator"), state.PrivateExchange)
  1603. chatRoom2 := state.NewChatRoom("chat-room-2-name", state.NewIdentScreenName("chat-room-2-creator"), state.PrivateExchange)
  1604. tt := []struct {
  1605. name string
  1606. want string
  1607. statusCode int
  1608. mockParams mockParams
  1609. }{
  1610. {
  1611. name: "multiple chat rooms with participants",
  1612. want: `[{"name":"chat-room-1-name","create_time":"0001-01-01T00:00:00Z","creator_id":"chat-room-1-creator","url":"aim:gochat?roomname=chat-room-1-name&exchange=4","participants":[{"id":"usera","screen_name":"userA"},{"id":"userb","screen_name":"userB"}]},{"name":"chat-room-2-name","create_time":"0001-01-01T00:00:00Z","creator_id":"chat-room-2-creator","url":"aim:gochat?roomname=chat-room-2-name&exchange=4","participants":[{"id":"userc","screen_name":"userC"},{"id":"userd","screen_name":"userD"}]}]`,
  1613. statusCode: http.StatusOK,
  1614. mockParams: mockParams{
  1615. chatRoomRetrieverParams: chatRoomRetrieverParams{
  1616. allChatRoomsParams: allChatRoomsParams{
  1617. {
  1618. exchange: state.PrivateExchange,
  1619. result: []state.ChatRoom{
  1620. chatRoom1,
  1621. chatRoom2,
  1622. },
  1623. },
  1624. },
  1625. },
  1626. chatSessionRetrieverParams: chatSessionRetrieverParams{
  1627. chatSessionRetrieverAllSessionsParams: chatSessionRetrieverAllSessionsParams{
  1628. {
  1629. cookie: chatRoom1.Cookie(),
  1630. result: []*state.Session{
  1631. fnNewSess("userA"),
  1632. fnNewSess("userB"),
  1633. },
  1634. },
  1635. {
  1636. cookie: chatRoom2.Cookie(),
  1637. result: []*state.Session{
  1638. fnNewSess("userC"),
  1639. fnNewSess("userD"),
  1640. },
  1641. },
  1642. },
  1643. },
  1644. },
  1645. },
  1646. {
  1647. name: "chat room without participants",
  1648. want: `[{"name":"chat-room-1-name","create_time":"0001-01-01T00:00:00Z","creator_id":"chat-room-1-creator","url":"aim:gochat?roomname=chat-room-1-name&exchange=4","participants":[]}]`,
  1649. statusCode: http.StatusOK,
  1650. mockParams: mockParams{
  1651. chatRoomRetrieverParams: chatRoomRetrieverParams{
  1652. allChatRoomsParams: allChatRoomsParams{
  1653. {
  1654. exchange: state.PrivateExchange,
  1655. result: []state.ChatRoom{
  1656. chatRoom1,
  1657. },
  1658. },
  1659. },
  1660. },
  1661. chatSessionRetrieverParams: chatSessionRetrieverParams{
  1662. chatSessionRetrieverAllSessionsParams: chatSessionRetrieverAllSessionsParams{
  1663. {
  1664. cookie: chatRoom1.Cookie(),
  1665. result: []*state.Session{},
  1666. },
  1667. },
  1668. },
  1669. },
  1670. },
  1671. {
  1672. name: "no chat rooms",
  1673. want: `[]`,
  1674. statusCode: http.StatusOK,
  1675. mockParams: mockParams{
  1676. chatRoomRetrieverParams: chatRoomRetrieverParams{
  1677. allChatRoomsParams: allChatRoomsParams{
  1678. {
  1679. exchange: state.PrivateExchange,
  1680. result: []state.ChatRoom{},
  1681. },
  1682. },
  1683. },
  1684. },
  1685. },
  1686. }
  1687. for _, tc := range tt {
  1688. t.Run(tc.name, func(t *testing.T) {
  1689. request := httptest.NewRequest(http.MethodGet, "/chat/room/private", nil)
  1690. responseRecorder := httptest.NewRecorder()
  1691. chatRoomRetriever := newMockChatRoomRetriever(t)
  1692. for _, params := range tc.mockParams.chatRoomRetrieverParams.allChatRoomsParams {
  1693. chatRoomRetriever.EXPECT().
  1694. AllChatRooms(matchContext(), params.exchange).
  1695. Return(params.result, params.err)
  1696. }
  1697. chatSessionRetriever := newMockChatSessionRetriever(t)
  1698. for _, params := range tc.mockParams.chatSessionRetrieverParams.chatSessionRetrieverAllSessionsParams {
  1699. chatSessionRetriever.EXPECT().
  1700. AllSessions(params.cookie).
  1701. Return(params.result)
  1702. }
  1703. getPrivateChatHandler(responseRecorder, request, chatRoomRetriever, chatSessionRetriever, slog.Default())
  1704. if responseRecorder.Code != tc.statusCode {
  1705. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1706. }
  1707. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1708. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  1709. }
  1710. })
  1711. }
  1712. }
  1713. func TestInstantMessageHandler_POST(t *testing.T) {
  1714. type relayToScreenNameInputs struct {
  1715. sender state.IdentScreenName
  1716. recipient state.IdentScreenName
  1717. msg string
  1718. }
  1719. tt := []struct {
  1720. name string
  1721. relayToScreenNameInputs []relayToScreenNameInputs
  1722. body string
  1723. want string
  1724. statusCode int
  1725. }{
  1726. {
  1727. name: "send an instant message",
  1728. relayToScreenNameInputs: []relayToScreenNameInputs{
  1729. {
  1730. sender: state.NewIdentScreenName("sender_sn"),
  1731. recipient: state.NewIdentScreenName("recip_sn"),
  1732. msg: "hello world!",
  1733. },
  1734. },
  1735. body: `{"from":"sender_sn","to":"recip_sn","text":"hello world!"}`,
  1736. want: `Message sent successfully.`,
  1737. statusCode: http.StatusOK,
  1738. },
  1739. {
  1740. name: "with malformed body",
  1741. body: `{"screen_name":"userA", "password":"thepassword"`,
  1742. want: `malformed input`,
  1743. statusCode: http.StatusBadRequest,
  1744. },
  1745. }
  1746. for _, tc := range tt {
  1747. t.Run(tc.name, func(t *testing.T) {
  1748. request := httptest.NewRequest(http.MethodPost, "/user", strings.NewReader(tc.body))
  1749. responseRecorder := httptest.NewRecorder()
  1750. messageRelayer := newMockMessageRelayer(t)
  1751. for _, params := range tc.relayToScreenNameInputs {
  1752. validateSNAC := func(msg wire.SNACMessage) bool {
  1753. body := msg.Body.(wire.SNAC_0x04_0x07_ICBMChannelMsgToClient)
  1754. assert.Equal(t, params.sender.String(), body.TLVUserInfo.ScreenName)
  1755. b, ok := body.Bytes(wire.ICBMTLVAOLIMData)
  1756. assert.True(t, ok)
  1757. txt, err := wire.UnmarshalICBMMessageText(b)
  1758. assert.NoError(t, err)
  1759. assert.Equal(t, params.msg, txt)
  1760. return true
  1761. }
  1762. messageRelayer.EXPECT().
  1763. RelayToScreenName(mock.Anything, params.recipient, mock.MatchedBy(validateSNAC))
  1764. }
  1765. postInstantMessageHandler(responseRecorder, request, messageRelayer, slog.Default())
  1766. if responseRecorder.Code != tc.statusCode {
  1767. t.Errorf("want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1768. }
  1769. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1770. t.Errorf("want '%s', got '%s'", tc.want, responseRecorder.Body)
  1771. }
  1772. })
  1773. }
  1774. }
  1775. func TestVersionHandler_GET(t *testing.T) {
  1776. tt := []struct {
  1777. name string
  1778. want string
  1779. statusCode int
  1780. buildInfo config.Build
  1781. }{
  1782. {
  1783. name: "get ras version",
  1784. want: `{"version":"13.3.7","commit":"asdfASDF12345678","date":"2024-03-01"}`,
  1785. statusCode: http.StatusOK,
  1786. buildInfo: config.Build{
  1787. Version: "13.3.7",
  1788. Commit: "asdfASDF12345678",
  1789. Date: "2024-03-01",
  1790. },
  1791. },
  1792. }
  1793. for _, tc := range tt {
  1794. t.Run(tc.name, func(t *testing.T) {
  1795. responseRecorder := httptest.NewRecorder()
  1796. getVersionHandler(responseRecorder, tc.buildInfo)
  1797. if responseRecorder.Code != tc.statusCode {
  1798. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1799. }
  1800. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1801. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  1802. }
  1803. })
  1804. }
  1805. }
  1806. func TestDirectoryCategoryHandler_GET(t *testing.T) {
  1807. tt := []struct {
  1808. name string
  1809. want string
  1810. statusCode int
  1811. mockParams mockParams
  1812. }{
  1813. {
  1814. name: "no categories",
  1815. want: `[]`,
  1816. statusCode: http.StatusOK,
  1817. mockParams: mockParams{
  1818. directoryManagerParams: directoryManagerParams{
  1819. categoriesParams: categoriesParams{
  1820. {
  1821. result: nil,
  1822. },
  1823. },
  1824. },
  1825. },
  1826. },
  1827. {
  1828. name: "error fetching categories",
  1829. want: `{"message":"internal server error"}`,
  1830. statusCode: http.StatusInternalServerError,
  1831. mockParams: mockParams{
  1832. directoryManagerParams: directoryManagerParams{
  1833. categoriesParams: categoriesParams{
  1834. {
  1835. result: nil,
  1836. err: errors.New("error fetching categories"),
  1837. },
  1838. },
  1839. },
  1840. },
  1841. },
  1842. {
  1843. name: "fetch some categories",
  1844. want: `[{"id":1,"name":"category-1"},{"id":2,"name":"category-2"}]`,
  1845. statusCode: http.StatusOK,
  1846. mockParams: mockParams{
  1847. directoryManagerParams: directoryManagerParams{
  1848. categoriesParams: categoriesParams{
  1849. {
  1850. result: []state.Category{
  1851. {
  1852. ID: 1,
  1853. Name: "category-1",
  1854. },
  1855. {
  1856. ID: 2,
  1857. Name: "category-2",
  1858. },
  1859. },
  1860. },
  1861. },
  1862. },
  1863. },
  1864. },
  1865. }
  1866. for _, tc := range tt {
  1867. t.Run(tc.name, func(t *testing.T) {
  1868. responseRecorder := httptest.NewRecorder()
  1869. request := httptest.NewRequest(http.MethodGet, "/directory/category", nil)
  1870. directoryManager := newMockDirectoryManager(t)
  1871. for _, params := range tc.mockParams.categoriesParams {
  1872. directoryManager.EXPECT().
  1873. Categories(matchContext()).
  1874. Return(params.result, params.err)
  1875. }
  1876. getDirectoryCategoryHandler(responseRecorder, request, directoryManager, slog.Default())
  1877. if responseRecorder.Code != tc.statusCode {
  1878. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1879. }
  1880. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1881. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  1882. }
  1883. })
  1884. }
  1885. }
  1886. func TestDirectoryCategoryKeywordHandler_GET(t *testing.T) {
  1887. tt := []struct {
  1888. name string
  1889. categoryID int
  1890. want string
  1891. statusCode int
  1892. mockParams mockParams
  1893. }{
  1894. {
  1895. name: "category not found",
  1896. categoryID: 1,
  1897. want: `{"message":"category not found"}`,
  1898. statusCode: http.StatusNotFound,
  1899. mockParams: mockParams{
  1900. directoryManagerParams: directoryManagerParams{
  1901. keywordsByCategoryParams: keywordsByCategoryParams{
  1902. {
  1903. categoryID: 1,
  1904. result: nil,
  1905. err: state.ErrKeywordCategoryNotFound,
  1906. },
  1907. },
  1908. },
  1909. },
  1910. },
  1911. {
  1912. name: "error fetching keywords by category",
  1913. categoryID: 1,
  1914. want: `{"message":"internal server error"}`,
  1915. statusCode: http.StatusInternalServerError,
  1916. mockParams: mockParams{
  1917. directoryManagerParams: directoryManagerParams{
  1918. keywordsByCategoryParams: keywordsByCategoryParams{
  1919. {
  1920. categoryID: 1,
  1921. result: nil,
  1922. err: errors.New("error fetching keywords by category"),
  1923. },
  1924. },
  1925. },
  1926. },
  1927. },
  1928. {
  1929. name: "invalid category ID",
  1930. categoryID: -1,
  1931. want: `{"message":"invalid category ID"}`,
  1932. statusCode: http.StatusBadRequest,
  1933. mockParams: mockParams{
  1934. directoryManagerParams: directoryManagerParams{
  1935. keywordsByCategoryParams: keywordsByCategoryParams{},
  1936. },
  1937. },
  1938. },
  1939. {
  1940. name: "no keywords",
  1941. categoryID: 1,
  1942. want: `[]`,
  1943. statusCode: http.StatusOK,
  1944. mockParams: mockParams{
  1945. directoryManagerParams: directoryManagerParams{
  1946. keywordsByCategoryParams: keywordsByCategoryParams{
  1947. {
  1948. categoryID: 1,
  1949. result: nil,
  1950. },
  1951. },
  1952. },
  1953. },
  1954. },
  1955. {
  1956. name: "fetch some keywords by category",
  1957. categoryID: 1,
  1958. want: `[{"id":1,"name":"keyword-1"},{"id":2,"name":"keyword-2"}]`,
  1959. statusCode: http.StatusOK,
  1960. mockParams: mockParams{
  1961. directoryManagerParams: directoryManagerParams{
  1962. keywordsByCategoryParams: keywordsByCategoryParams{
  1963. {
  1964. categoryID: 1,
  1965. result: []state.Keyword{
  1966. {
  1967. ID: 1,
  1968. Name: "keyword-1",
  1969. },
  1970. {
  1971. ID: 2,
  1972. Name: "keyword-2",
  1973. },
  1974. },
  1975. },
  1976. },
  1977. },
  1978. },
  1979. },
  1980. }
  1981. for _, tc := range tt {
  1982. t.Run(tc.name, func(t *testing.T) {
  1983. request := httptest.NewRequest(http.MethodGet, fmt.Sprintf("/directory/category/%d/keyword", tc.categoryID), nil)
  1984. request.SetPathValue("id", fmt.Sprintf("%d", tc.categoryID))
  1985. responseRecorder := httptest.NewRecorder()
  1986. directoryManager := newMockDirectoryManager(t)
  1987. for _, params := range tc.mockParams.keywordsByCategoryParams {
  1988. directoryManager.EXPECT().
  1989. KeywordsByCategory(matchContext(), params.categoryID).
  1990. Return(params.result, params.err)
  1991. }
  1992. getDirectoryCategoryKeywordHandler(responseRecorder, request, directoryManager, slog.Default())
  1993. if responseRecorder.Code != tc.statusCode {
  1994. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1995. }
  1996. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1997. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  1998. }
  1999. })
  2000. }
  2001. }
  2002. func TestDirectoryCategoryHandler_DELETE(t *testing.T) {
  2003. tt := []struct {
  2004. name string
  2005. categoryID int
  2006. want string
  2007. statusCode int
  2008. mockParams mockParams
  2009. }{
  2010. {
  2011. name: "category not found",
  2012. categoryID: 1,
  2013. want: `{"message":"category not found"}`,
  2014. statusCode: http.StatusNotFound,
  2015. mockParams: mockParams{
  2016. directoryManagerParams: directoryManagerParams{
  2017. deleteCategoryParams: deleteCategoryParams{
  2018. {
  2019. categoryID: 1,
  2020. err: state.ErrKeywordCategoryNotFound,
  2021. },
  2022. },
  2023. },
  2024. },
  2025. },
  2026. {
  2027. name: "keyword in use by user",
  2028. categoryID: 1,
  2029. want: `{"message":"can't delete because category in use by a user"}`,
  2030. statusCode: http.StatusConflict,
  2031. mockParams: mockParams{
  2032. directoryManagerParams: directoryManagerParams{
  2033. deleteCategoryParams: deleteCategoryParams{
  2034. {
  2035. categoryID: 1,
  2036. err: state.ErrKeywordInUse,
  2037. },
  2038. },
  2039. },
  2040. },
  2041. },
  2042. {
  2043. name: "runtime error",
  2044. categoryID: 1,
  2045. want: `{"message":"internal server error"}`,
  2046. statusCode: http.StatusInternalServerError,
  2047. mockParams: mockParams{
  2048. directoryManagerParams: directoryManagerParams{
  2049. deleteCategoryParams: deleteCategoryParams{
  2050. {
  2051. categoryID: 1,
  2052. err: errors.New("error deleting keyword"),
  2053. },
  2054. },
  2055. },
  2056. },
  2057. },
  2058. {
  2059. name: "successful deletion",
  2060. categoryID: 1,
  2061. want: ``,
  2062. statusCode: http.StatusNoContent,
  2063. mockParams: mockParams{
  2064. directoryManagerParams: directoryManagerParams{
  2065. deleteCategoryParams: deleteCategoryParams{
  2066. {
  2067. categoryID: 1,
  2068. },
  2069. },
  2070. },
  2071. },
  2072. },
  2073. {
  2074. name: "invalid category ID",
  2075. categoryID: -1,
  2076. want: `invalid category ID`,
  2077. statusCode: http.StatusBadRequest,
  2078. mockParams: mockParams{
  2079. directoryManagerParams: directoryManagerParams{
  2080. deleteCategoryParams: deleteCategoryParams{},
  2081. },
  2082. },
  2083. },
  2084. }
  2085. for _, tc := range tt {
  2086. t.Run(tc.name, func(t *testing.T) {
  2087. request := httptest.NewRequest(http.MethodDelete, fmt.Sprintf("/directory/category/%d/keyword", tc.categoryID), nil)
  2088. request.SetPathValue("id", fmt.Sprintf("%d", tc.categoryID))
  2089. responseRecorder := httptest.NewRecorder()
  2090. directoryManager := newMockDirectoryManager(t)
  2091. for _, params := range tc.mockParams.deleteCategoryParams {
  2092. directoryManager.EXPECT().
  2093. DeleteCategory(matchContext(), params.categoryID).
  2094. Return(params.err)
  2095. }
  2096. deleteDirectoryCategoryHandler(responseRecorder, request, directoryManager, slog.Default())
  2097. if responseRecorder.Code != tc.statusCode {
  2098. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  2099. }
  2100. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  2101. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  2102. }
  2103. })
  2104. }
  2105. }
  2106. func TestDirectoryCategoryHandler_POST(t *testing.T) {
  2107. tt := []struct {
  2108. name string
  2109. body string
  2110. want string
  2111. statusCode int
  2112. mockParams mockParams
  2113. }{
  2114. {
  2115. name: "category already exists",
  2116. body: `{"name":"the_category"}`,
  2117. want: `{"message":"category already exists"}`,
  2118. statusCode: http.StatusConflict,
  2119. mockParams: mockParams{
  2120. directoryManagerParams: directoryManagerParams{
  2121. createCategoryParams: createCategoryParams{
  2122. {
  2123. name: "the_category",
  2124. err: state.ErrKeywordCategoryExists,
  2125. },
  2126. },
  2127. },
  2128. },
  2129. },
  2130. {
  2131. name: "runtime error",
  2132. body: `{"name":"the_category"}`,
  2133. want: `{"message":"internal server error"}`,
  2134. statusCode: http.StatusInternalServerError,
  2135. mockParams: mockParams{
  2136. directoryManagerParams: directoryManagerParams{
  2137. createCategoryParams: createCategoryParams{
  2138. {
  2139. name: "the_category",
  2140. err: errors.New("error creating category"),
  2141. },
  2142. },
  2143. },
  2144. },
  2145. },
  2146. {
  2147. name: "bad input",
  2148. body: `{"name":"the_category"`,
  2149. want: `{"message":"malformed input"}`,
  2150. statusCode: http.StatusBadRequest,
  2151. mockParams: mockParams{
  2152. directoryManagerParams: directoryManagerParams{
  2153. createCategoryParams: createCategoryParams{},
  2154. },
  2155. },
  2156. },
  2157. {
  2158. name: "successful creation",
  2159. body: `{"name":"the_category"}`,
  2160. want: `{"id":1,"name":"the_category"}`,
  2161. statusCode: http.StatusCreated,
  2162. mockParams: mockParams{
  2163. directoryManagerParams: directoryManagerParams{
  2164. createCategoryParams: createCategoryParams{
  2165. {
  2166. name: "the_category",
  2167. result: state.Category{
  2168. ID: 1,
  2169. Name: "the_category",
  2170. },
  2171. },
  2172. },
  2173. },
  2174. },
  2175. },
  2176. }
  2177. for _, tc := range tt {
  2178. t.Run(tc.name, func(t *testing.T) {
  2179. request := httptest.NewRequest(http.MethodPost, "/directory/category", strings.NewReader(tc.body))
  2180. responseRecorder := httptest.NewRecorder()
  2181. directoryManager := newMockDirectoryManager(t)
  2182. for _, params := range tc.mockParams.createCategoryParams {
  2183. directoryManager.EXPECT().
  2184. CreateCategory(matchContext(), params.name).
  2185. Return(params.result, params.err)
  2186. }
  2187. postDirectoryCategoryHandler(responseRecorder, request, directoryManager, slog.Default())
  2188. if responseRecorder.Code != tc.statusCode {
  2189. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  2190. }
  2191. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  2192. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  2193. }
  2194. })
  2195. }
  2196. }
  2197. func TestDirectoryKeywordHandler_POST(t *testing.T) {
  2198. tt := []struct {
  2199. name string
  2200. body string
  2201. want string
  2202. statusCode int
  2203. mockParams mockParams
  2204. }{
  2205. {
  2206. name: "keyword already exists",
  2207. body: `{"category_id":1,"name":"the_keyword"}`,
  2208. want: `{"message":"keyword already exists"}`,
  2209. statusCode: http.StatusConflict,
  2210. mockParams: mockParams{
  2211. directoryManagerParams: directoryManagerParams{
  2212. createKeywordParams: createKeywordParams{
  2213. {
  2214. name: "the_keyword",
  2215. categoryID: 1,
  2216. err: state.ErrKeywordExists,
  2217. },
  2218. },
  2219. },
  2220. },
  2221. },
  2222. {
  2223. name: "category not found",
  2224. body: `{"category_id":1,"name":"the_keyword"}`,
  2225. want: `{"message":"category not found"}`,
  2226. statusCode: http.StatusNotFound,
  2227. mockParams: mockParams{
  2228. directoryManagerParams: directoryManagerParams{
  2229. createKeywordParams: createKeywordParams{
  2230. {
  2231. name: "the_keyword",
  2232. categoryID: 1,
  2233. err: state.ErrKeywordCategoryNotFound,
  2234. },
  2235. },
  2236. },
  2237. },
  2238. },
  2239. {
  2240. name: "runtime error",
  2241. body: `{"category_id":1,"name":"the_keyword"}`,
  2242. want: `{"message":"internal server error"}`,
  2243. statusCode: http.StatusInternalServerError,
  2244. mockParams: mockParams{
  2245. directoryManagerParams: directoryManagerParams{
  2246. createKeywordParams: createKeywordParams{
  2247. {
  2248. name: "the_keyword",
  2249. categoryID: 1,
  2250. err: errors.New("error creating keyword"),
  2251. },
  2252. },
  2253. },
  2254. },
  2255. },
  2256. {
  2257. name: "bad input",
  2258. body: `{"category_id":1,"name":"the_keyword"`,
  2259. want: `{"message":"malformed input"}`,
  2260. statusCode: http.StatusBadRequest,
  2261. mockParams: mockParams{
  2262. directoryManagerParams: directoryManagerParams{
  2263. createKeywordParams: createKeywordParams{},
  2264. },
  2265. },
  2266. },
  2267. {
  2268. name: "successful creation",
  2269. body: `{"category_id":1,"name":"the_keyword"}`,
  2270. want: `{"id":1,"name":"the_keyword"}`,
  2271. statusCode: http.StatusCreated,
  2272. mockParams: mockParams{
  2273. directoryManagerParams: directoryManagerParams{
  2274. createKeywordParams: createKeywordParams{
  2275. {
  2276. name: "the_keyword",
  2277. categoryID: 1,
  2278. result: state.Keyword{
  2279. ID: 1,
  2280. Name: "the_keyword",
  2281. },
  2282. },
  2283. },
  2284. },
  2285. },
  2286. },
  2287. }
  2288. for _, tc := range tt {
  2289. t.Run(tc.name, func(t *testing.T) {
  2290. request := httptest.NewRequest(http.MethodPost, "/directory/keyword", strings.NewReader(tc.body))
  2291. responseRecorder := httptest.NewRecorder()
  2292. directoryManager := newMockDirectoryManager(t)
  2293. for _, params := range tc.mockParams.createKeywordParams {
  2294. directoryManager.EXPECT().
  2295. CreateKeyword(matchContext(), params.name, params.categoryID).
  2296. Return(params.result, params.err)
  2297. }
  2298. postDirectoryKeywordHandler(responseRecorder, request, directoryManager, slog.Default())
  2299. if responseRecorder.Code != tc.statusCode {
  2300. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  2301. }
  2302. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  2303. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  2304. }
  2305. })
  2306. }
  2307. }
  2308. func TestDirectoryKeywordHandler_DELETE(t *testing.T) {
  2309. tt := []struct {
  2310. name string
  2311. categoryID int
  2312. want string
  2313. statusCode int
  2314. mockParams mockParams
  2315. }{
  2316. {
  2317. name: "keyword not found",
  2318. categoryID: 1,
  2319. want: `{"message":"keyword not found"}`,
  2320. statusCode: http.StatusNotFound,
  2321. mockParams: mockParams{
  2322. directoryManagerParams: directoryManagerParams{
  2323. deleteKeywordParams: deleteKeywordParams{
  2324. {
  2325. id: 1,
  2326. err: state.ErrKeywordNotFound,
  2327. },
  2328. },
  2329. },
  2330. },
  2331. },
  2332. {
  2333. name: "keyword in use by user",
  2334. categoryID: 1,
  2335. want: `{"message":"can't delete because category in use by a user"}`,
  2336. statusCode: http.StatusConflict,
  2337. mockParams: mockParams{
  2338. directoryManagerParams: directoryManagerParams{
  2339. deleteKeywordParams: deleteKeywordParams{
  2340. {
  2341. id: 1,
  2342. err: state.ErrKeywordInUse,
  2343. },
  2344. },
  2345. },
  2346. },
  2347. },
  2348. {
  2349. name: "runtime error",
  2350. categoryID: 1,
  2351. want: `{"message":"internal server error"}`,
  2352. statusCode: http.StatusInternalServerError,
  2353. mockParams: mockParams{
  2354. directoryManagerParams: directoryManagerParams{
  2355. deleteKeywordParams: deleteKeywordParams{
  2356. {
  2357. id: 1,
  2358. err: errors.New("error deleting keyword"),
  2359. },
  2360. },
  2361. },
  2362. },
  2363. },
  2364. {
  2365. name: "successful deletion",
  2366. categoryID: 1,
  2367. want: ``,
  2368. statusCode: http.StatusNoContent,
  2369. mockParams: mockParams{
  2370. directoryManagerParams: directoryManagerParams{
  2371. deleteKeywordParams: deleteKeywordParams{
  2372. {
  2373. id: 1,
  2374. },
  2375. },
  2376. },
  2377. },
  2378. },
  2379. {
  2380. name: "invalid keyword ID",
  2381. categoryID: -1,
  2382. want: `{"message":"invalid keyword ID"}`,
  2383. statusCode: http.StatusBadRequest,
  2384. mockParams: mockParams{
  2385. directoryManagerParams: directoryManagerParams{
  2386. deleteKeywordParams: deleteKeywordParams{},
  2387. },
  2388. },
  2389. },
  2390. }
  2391. for _, tc := range tt {
  2392. t.Run(tc.name, func(t *testing.T) {
  2393. request := httptest.NewRequest(http.MethodDelete, fmt.Sprintf("/directory/keyword/%d", tc.categoryID), nil)
  2394. request.SetPathValue("id", fmt.Sprintf("%d", tc.categoryID))
  2395. responseRecorder := httptest.NewRecorder()
  2396. directoryManager := newMockDirectoryManager(t)
  2397. for _, params := range tc.mockParams.deleteKeywordParams {
  2398. directoryManager.EXPECT().
  2399. DeleteKeyword(matchContext(), params.id).
  2400. Return(params.err)
  2401. }
  2402. deleteDirectoryKeywordHandler(responseRecorder, request, directoryManager, slog.Default())
  2403. if responseRecorder.Code != tc.statusCode {
  2404. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  2405. }
  2406. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  2407. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  2408. }
  2409. })
  2410. }
  2411. }
  2412. func TestBARTByTypeHandler_GET(t *testing.T) {
  2413. tt := []struct {
  2414. name string
  2415. queryParams string
  2416. wantStatusCode int
  2417. wantResponse string
  2418. mockParams mockParams
  2419. }{
  2420. {
  2421. name: "success with items",
  2422. queryParams: "?type=1",
  2423. wantStatusCode: http.StatusOK,
  2424. wantResponse: `[{"hash":"2B000001E4","type":1},{"hash":"2B000001B7","type":1}]`,
  2425. mockParams: mockParams{
  2426. bartAssetManagerParams: bartAssetManagerParams{
  2427. listBARTItemsParams: listBARTItemsParams{
  2428. {
  2429. itemType: 1,
  2430. result: []state.BARTItem{
  2431. {Hash: "2B000001E4", Type: 1},
  2432. {Hash: "2B000001B7", Type: 1},
  2433. },
  2434. err: nil,
  2435. },
  2436. },
  2437. },
  2438. },
  2439. },
  2440. {
  2441. name: "success with empty list",
  2442. queryParams: "?type=2",
  2443. wantStatusCode: http.StatusOK,
  2444. wantResponse: `[]`,
  2445. mockParams: mockParams{
  2446. bartAssetManagerParams: bartAssetManagerParams{
  2447. listBARTItemsParams: listBARTItemsParams{
  2448. {
  2449. itemType: 2,
  2450. result: []state.BARTItem{},
  2451. err: nil,
  2452. },
  2453. },
  2454. },
  2455. },
  2456. },
  2457. {
  2458. name: "missing type parameter",
  2459. queryParams: "",
  2460. wantStatusCode: http.StatusBadRequest,
  2461. wantResponse: `{"message":"type query parameter is required"}`,
  2462. },
  2463. {
  2464. name: "invalid type parameter",
  2465. queryParams: "?type=invalid",
  2466. wantStatusCode: http.StatusBadRequest,
  2467. wantResponse: `{"message":"invalid type ID"}`,
  2468. },
  2469. {
  2470. name: "internal server error",
  2471. queryParams: "?type=1",
  2472. wantStatusCode: http.StatusInternalServerError,
  2473. wantResponse: `{"message":"internal server error"}`,
  2474. mockParams: mockParams{
  2475. bartAssetManagerParams: bartAssetManagerParams{
  2476. listBARTItemsParams: listBARTItemsParams{
  2477. {
  2478. itemType: 1,
  2479. result: nil,
  2480. err: errors.New("database error"),
  2481. },
  2482. },
  2483. },
  2484. },
  2485. },
  2486. }
  2487. for _, tc := range tt {
  2488. t.Run(tc.name, func(t *testing.T) {
  2489. request := httptest.NewRequest(http.MethodGet, "/bart"+tc.queryParams, nil)
  2490. responseRecorder := httptest.NewRecorder()
  2491. mockBARTManager := newMockBARTAssetManager(t)
  2492. for _, params := range tc.mockParams.bartAssetManagerParams.listBARTItemsParams {
  2493. mockBARTManager.EXPECT().
  2494. ListBARTItems(matchContext(), params.itemType).
  2495. Return(params.result, params.err)
  2496. }
  2497. getBARTByTypeHandler(responseRecorder, request, mockBARTManager, slog.Default())
  2498. assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
  2499. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  2500. })
  2501. }
  2502. }
  2503. func TestBARTHandler_GET(t *testing.T) {
  2504. tt := []struct {
  2505. name string
  2506. hash string
  2507. wantStatusCode int
  2508. wantResponse string
  2509. wantHeaders map[string]string
  2510. mockParams mockParams
  2511. }{
  2512. {
  2513. name: "success with valid hash",
  2514. hash: "2B000001E4",
  2515. wantStatusCode: http.StatusOK,
  2516. wantResponse: "binary data",
  2517. wantHeaders: map[string]string{"Content-Type": "application/octet-stream"},
  2518. mockParams: mockParams{
  2519. bartAssetManagerParams: bartAssetManagerParams{
  2520. bartItemParams: bartItemParams{
  2521. {
  2522. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2523. result: []byte("binary data"),
  2524. err: nil,
  2525. },
  2526. },
  2527. },
  2528. },
  2529. },
  2530. {
  2531. name: "missing hash parameter",
  2532. hash: "",
  2533. wantStatusCode: http.StatusBadRequest,
  2534. wantResponse: `{"message":"hash is required"}`,
  2535. },
  2536. {
  2537. name: "invalid hash format",
  2538. hash: "invalid-hex",
  2539. wantStatusCode: http.StatusBadRequest,
  2540. wantResponse: `{"message":"invalid hash format"}`,
  2541. },
  2542. {
  2543. name: "asset not found",
  2544. hash: "2B000001E4",
  2545. wantStatusCode: http.StatusNotFound,
  2546. wantResponse: `{"message":"BART asset not found"}`,
  2547. mockParams: mockParams{
  2548. bartAssetManagerParams: bartAssetManagerParams{
  2549. bartItemParams: bartItemParams{
  2550. {
  2551. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2552. result: []byte{},
  2553. err: nil,
  2554. },
  2555. },
  2556. },
  2557. },
  2558. },
  2559. {
  2560. name: "internal server error",
  2561. hash: "2B000001E4",
  2562. wantStatusCode: http.StatusInternalServerError,
  2563. wantResponse: `{"message":"internal server error"}`,
  2564. mockParams: mockParams{
  2565. bartAssetManagerParams: bartAssetManagerParams{
  2566. bartItemParams: bartItemParams{
  2567. {
  2568. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2569. result: nil,
  2570. err: errors.New("database error"),
  2571. },
  2572. },
  2573. },
  2574. },
  2575. },
  2576. }
  2577. for _, tc := range tt {
  2578. t.Run(tc.name, func(t *testing.T) {
  2579. request := httptest.NewRequest(http.MethodGet, "/bart/"+tc.hash, nil)
  2580. // Set the path value manually for testing
  2581. if tc.hash != "" {
  2582. request.SetPathValue("hash", tc.hash)
  2583. }
  2584. responseRecorder := httptest.NewRecorder()
  2585. mockBARTManager := newMockBARTAssetManager(t)
  2586. for _, params := range tc.mockParams.bartAssetManagerParams.bartItemParams {
  2587. mockBARTManager.EXPECT().
  2588. BARTItem(matchContext(), params.hash).
  2589. Return(params.result, params.err)
  2590. }
  2591. getBARTHandler(responseRecorder, request, mockBARTManager, slog.Default())
  2592. assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
  2593. if tc.wantHeaders != nil {
  2594. for key, value := range tc.wantHeaders {
  2595. assert.Equal(t, value, responseRecorder.Header().Get(key))
  2596. }
  2597. }
  2598. if tc.wantStatusCode == http.StatusOK {
  2599. assert.Equal(t, tc.wantResponse, responseRecorder.Body.String())
  2600. } else {
  2601. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  2602. }
  2603. })
  2604. }
  2605. }
  2606. func TestBARTHandler_POST(t *testing.T) {
  2607. tt := []struct {
  2608. name string
  2609. hash string
  2610. queryParams string
  2611. requestBody string
  2612. wantStatusCode int
  2613. wantResponse string
  2614. mockParams mockParams
  2615. }{
  2616. {
  2617. name: "success with valid data",
  2618. hash: "2B000001E4",
  2619. queryParams: "?type=1",
  2620. requestBody: "binary data",
  2621. wantStatusCode: http.StatusCreated,
  2622. wantResponse: `{"hash":"2b000001e4","type":1}`,
  2623. mockParams: mockParams{
  2624. bartAssetManagerParams: bartAssetManagerParams{
  2625. insertBARTItemParams: insertBARTItemParams{
  2626. {
  2627. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2628. blob: []byte("binary data"),
  2629. itemType: 1,
  2630. err: nil,
  2631. },
  2632. },
  2633. },
  2634. },
  2635. },
  2636. {
  2637. name: "missing hash parameter",
  2638. hash: "",
  2639. queryParams: "?type=1",
  2640. requestBody: "binary data",
  2641. wantStatusCode: http.StatusBadRequest,
  2642. wantResponse: `{"message":"hash path parameter is required"}`,
  2643. },
  2644. {
  2645. name: "invalid hash format",
  2646. hash: "invalid-hex",
  2647. queryParams: "?type=1",
  2648. requestBody: "binary data",
  2649. wantStatusCode: http.StatusBadRequest,
  2650. wantResponse: `{"message":"invalid hash format"}`,
  2651. },
  2652. {
  2653. name: "missing type parameter",
  2654. hash: "2B000001E4",
  2655. queryParams: "",
  2656. requestBody: "binary data",
  2657. wantStatusCode: http.StatusBadRequest,
  2658. wantResponse: `{"message":"type query parameter is required"}`,
  2659. },
  2660. {
  2661. name: "invalid type parameter",
  2662. hash: "2B000001E4",
  2663. queryParams: "?type=invalid",
  2664. requestBody: "binary data",
  2665. wantStatusCode: http.StatusBadRequest,
  2666. wantResponse: `{"message":"invalid type ID"}`,
  2667. },
  2668. {
  2669. name: "failed to read request body",
  2670. hash: "2B000001E4",
  2671. queryParams: "?type=1",
  2672. requestBody: "", // This will cause an error when reading
  2673. wantStatusCode: http.StatusBadRequest,
  2674. wantResponse: `{"message":"failed to read request body"}`,
  2675. },
  2676. {
  2677. name: "asset already exists",
  2678. hash: "2B000001E4",
  2679. queryParams: "?type=1",
  2680. requestBody: "binary data",
  2681. wantStatusCode: http.StatusConflict,
  2682. wantResponse: `{"message":"BART asset already exists"}`,
  2683. mockParams: mockParams{
  2684. bartAssetManagerParams: bartAssetManagerParams{
  2685. insertBARTItemParams: insertBARTItemParams{
  2686. {
  2687. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2688. blob: []byte("binary data"),
  2689. itemType: 1,
  2690. err: state.ErrBARTItemExists,
  2691. },
  2692. },
  2693. },
  2694. },
  2695. },
  2696. {
  2697. name: "internal server error",
  2698. hash: "2B000001E4",
  2699. queryParams: "?type=1",
  2700. requestBody: "binary data",
  2701. wantStatusCode: http.StatusInternalServerError,
  2702. wantResponse: `{"message":"internal server error"}`,
  2703. mockParams: mockParams{
  2704. bartAssetManagerParams: bartAssetManagerParams{
  2705. insertBARTItemParams: insertBARTItemParams{
  2706. {
  2707. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2708. blob: []byte("binary data"),
  2709. itemType: 1,
  2710. err: errors.New("database error"),
  2711. },
  2712. },
  2713. },
  2714. },
  2715. },
  2716. }
  2717. for _, tc := range tt {
  2718. t.Run(tc.name, func(t *testing.T) {
  2719. var requestBody io.Reader
  2720. if tc.requestBody != "" {
  2721. requestBody = strings.NewReader(tc.requestBody)
  2722. } else {
  2723. requestBody = &errorReader{}
  2724. }
  2725. request := httptest.NewRequest(http.MethodPost, "/bart/"+tc.hash+tc.queryParams, requestBody)
  2726. // Set the path value manually for testing
  2727. if tc.hash != "" {
  2728. request.SetPathValue("hash", tc.hash)
  2729. }
  2730. responseRecorder := httptest.NewRecorder()
  2731. mockBARTManager := newMockBARTAssetManager(t)
  2732. for _, params := range tc.mockParams.bartAssetManagerParams.insertBARTItemParams {
  2733. mockBARTManager.EXPECT().
  2734. InsertBARTItem(matchContext(), params.hash, params.blob, params.itemType).
  2735. Return(params.err)
  2736. }
  2737. postBARTHandler(responseRecorder, request, mockBARTManager, slog.Default())
  2738. assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
  2739. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  2740. })
  2741. }
  2742. }
  2743. func TestBARTHandler_DELETE(t *testing.T) {
  2744. tt := []struct {
  2745. name string
  2746. hash string
  2747. wantStatusCode int
  2748. wantResponse string
  2749. mockParams mockParams
  2750. }{
  2751. {
  2752. name: "success with valid hash",
  2753. hash: "2B000001E4",
  2754. wantStatusCode: http.StatusOK,
  2755. wantResponse: `{"message":"BART asset deleted successfully."}`,
  2756. mockParams: mockParams{
  2757. bartAssetManagerParams: bartAssetManagerParams{
  2758. deleteBARTItemParams: deleteBARTItemParams{
  2759. {
  2760. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2761. err: nil,
  2762. },
  2763. },
  2764. },
  2765. },
  2766. },
  2767. {
  2768. name: "missing hash parameter",
  2769. hash: "",
  2770. wantStatusCode: http.StatusBadRequest,
  2771. wantResponse: `{"message":"hash path parameter is required"}`,
  2772. },
  2773. {
  2774. name: "invalid hash format",
  2775. hash: "invalid-hex",
  2776. wantStatusCode: http.StatusBadRequest,
  2777. wantResponse: `{"message":"invalid hash format"}`,
  2778. },
  2779. {
  2780. name: "asset not found",
  2781. hash: "2B000001E4",
  2782. wantStatusCode: http.StatusNotFound,
  2783. wantResponse: `{"message":"BART asset not found"}`,
  2784. mockParams: mockParams{
  2785. bartAssetManagerParams: bartAssetManagerParams{
  2786. deleteBARTItemParams: deleteBARTItemParams{
  2787. {
  2788. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2789. err: state.ErrBARTItemNotFound,
  2790. },
  2791. },
  2792. },
  2793. },
  2794. },
  2795. {
  2796. name: "internal server error",
  2797. hash: "2B000001E4",
  2798. wantStatusCode: http.StatusInternalServerError,
  2799. wantResponse: `{"message":"internal server error"}`,
  2800. mockParams: mockParams{
  2801. bartAssetManagerParams: bartAssetManagerParams{
  2802. deleteBARTItemParams: deleteBARTItemParams{
  2803. {
  2804. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2805. err: errors.New("database error"),
  2806. },
  2807. },
  2808. },
  2809. },
  2810. },
  2811. }
  2812. for _, tc := range tt {
  2813. t.Run(tc.name, func(t *testing.T) {
  2814. request := httptest.NewRequest(http.MethodDelete, "/bart/"+tc.hash, nil)
  2815. // Set the path value manually for testing
  2816. if tc.hash != "" {
  2817. request.SetPathValue("hash", tc.hash)
  2818. }
  2819. responseRecorder := httptest.NewRecorder()
  2820. mockBARTManager := newMockBARTAssetManager(t)
  2821. for _, params := range tc.mockParams.bartAssetManagerParams.deleteBARTItemParams {
  2822. mockBARTManager.EXPECT().
  2823. DeleteBARTItem(matchContext(), params.hash).
  2824. Return(params.err)
  2825. }
  2826. deleteBARTHandler(responseRecorder, request, mockBARTManager, slog.Default())
  2827. assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
  2828. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  2829. })
  2830. }
  2831. }
  2832. // errorReader is a helper type that always returns an error when reading
  2833. type errorReader struct{}
  2834. func (er *errorReader) Read(p []byte) (n int, err error) {
  2835. return 0, errors.New("read error")
  2836. }
  2837. func TestFeedbagBuddyHandler_GET(t *testing.T) {
  2838. tt := []struct {
  2839. name string
  2840. screenName string
  2841. wantStatusCode int
  2842. wantResponse string
  2843. mockParams mockParams
  2844. }{
  2845. {
  2846. name: "empty feedbag",
  2847. screenName: "userA",
  2848. wantStatusCode: http.StatusNotFound,
  2849. wantResponse: `{"message":"feedbag not found"}`,
  2850. mockParams: mockParams{
  2851. feedbagManagerParams: feedbagManagerParams{
  2852. feedbagParams: feedbagParams{
  2853. {
  2854. screenName: state.NewIdentScreenName("userA"),
  2855. result: []wire.FeedbagItem{},
  2856. err: nil,
  2857. },
  2858. },
  2859. },
  2860. },
  2861. },
  2862. {
  2863. name: "feedbag with buddies in groups",
  2864. screenName: "userA",
  2865. wantStatusCode: http.StatusOK,
  2866. wantResponse: `[{"group_id":1,"group_name":"Friends","buddies":[{"name":"buddy1","item_id":10},{"name":"buddy2","item_id":11}]},{"group_id":2,"group_name":"Work","buddies":[{"name":"buddy3","item_id":20}]}]`,
  2867. mockParams: mockParams{
  2868. feedbagManagerParams: feedbagManagerParams{
  2869. feedbagParams: feedbagParams{
  2870. {
  2871. screenName: state.NewIdentScreenName("userA"),
  2872. result: []wire.FeedbagItem{
  2873. {
  2874. ItemID: 0,
  2875. ClassID: wire.FeedbagClassIdGroup,
  2876. Name: "",
  2877. GroupID: 0,
  2878. },
  2879. {
  2880. ItemID: 1,
  2881. ClassID: wire.FeedbagClassIdGroup,
  2882. Name: "Friends",
  2883. GroupID: 1,
  2884. },
  2885. {
  2886. ItemID: 2,
  2887. ClassID: wire.FeedbagClassIdGroup,
  2888. Name: "Work",
  2889. GroupID: 2,
  2890. },
  2891. {
  2892. ItemID: 10,
  2893. ClassID: wire.FeedbagClassIdBuddy,
  2894. Name: "buddy1",
  2895. GroupID: 1,
  2896. },
  2897. {
  2898. ItemID: 11,
  2899. ClassID: wire.FeedbagClassIdBuddy,
  2900. Name: "buddy2",
  2901. GroupID: 1,
  2902. },
  2903. {
  2904. ItemID: 20,
  2905. ClassID: wire.FeedbagClassIdBuddy,
  2906. Name: "buddy3",
  2907. GroupID: 2,
  2908. },
  2909. },
  2910. err: nil,
  2911. },
  2912. },
  2913. },
  2914. },
  2915. },
  2916. {
  2917. name: "feedbag with no groups (besides root)",
  2918. screenName: "userA",
  2919. wantStatusCode: http.StatusOK,
  2920. wantResponse: `[]`,
  2921. mockParams: mockParams{
  2922. feedbagManagerParams: feedbagManagerParams{
  2923. feedbagParams: feedbagParams{
  2924. {
  2925. screenName: state.NewIdentScreenName("userA"),
  2926. result: []wire.FeedbagItem{
  2927. {
  2928. ItemID: 0,
  2929. ClassID: wire.FeedbagClassIdGroup,
  2930. Name: "",
  2931. GroupID: 0,
  2932. },
  2933. },
  2934. err: nil,
  2935. },
  2936. },
  2937. },
  2938. },
  2939. // Note: Root groups (GroupID == 0) are skipped by the implementation,
  2940. // so the response will be an empty array []
  2941. },
  2942. {
  2943. name: "missing screen_name",
  2944. screenName: "",
  2945. wantStatusCode: http.StatusBadRequest,
  2946. wantResponse: `{"message":"screen_name is required"}`,
  2947. },
  2948. {
  2949. name: "internal server error",
  2950. screenName: "userA",
  2951. wantStatusCode: http.StatusInternalServerError,
  2952. wantResponse: `{"message":"internal server error"}`,
  2953. mockParams: mockParams{
  2954. feedbagManagerParams: feedbagManagerParams{
  2955. feedbagParams: feedbagParams{
  2956. {
  2957. screenName: state.NewIdentScreenName("userA"),
  2958. result: nil,
  2959. err: errors.New("database error"),
  2960. },
  2961. },
  2962. },
  2963. },
  2964. },
  2965. }
  2966. for _, tc := range tt {
  2967. t.Run(tc.name, func(t *testing.T) {
  2968. request := httptest.NewRequest(http.MethodGet, "/feedbag/"+tc.screenName+"/group", nil)
  2969. if tc.screenName != "" {
  2970. request.SetPathValue("screen_name", tc.screenName)
  2971. }
  2972. responseRecorder := httptest.NewRecorder()
  2973. feedbagManager := newMockFeedbagManager(t)
  2974. for _, params := range tc.mockParams.feedbagManagerParams.feedbagParams {
  2975. feedbagManager.EXPECT().
  2976. Feedbag(matchContext(), params.screenName).
  2977. Return(params.result, params.err)
  2978. }
  2979. getFeedbagBuddyHandler(responseRecorder, request, feedbagManager, slog.Default())
  2980. assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
  2981. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  2982. })
  2983. }
  2984. }
  2985. func TestFeedbagBuddyHandler_PUT(t *testing.T) {
  2986. tt := []struct {
  2987. name string
  2988. screenName string
  2989. groupID string
  2990. requestBody string
  2991. wantStatusCode int
  2992. wantResponse string
  2993. mockParams mockParams
  2994. }{
  2995. {
  2996. name: "add a buddy to an empty group, user not signed in",
  2997. screenName: "userA",
  2998. groupID: "1",
  2999. requestBody: `{"name":"newbuddy"}`,
  3000. wantStatusCode: http.StatusOK,
  3001. wantResponse: `{"name":"newbuddy","group_id":1,"item_id":1000}`,
  3002. mockParams: mockParams{
  3003. feedbagManagerParams: feedbagManagerParams{
  3004. feedbagParams: feedbagParams{
  3005. {
  3006. screenName: state.NewIdentScreenName("userA"),
  3007. result: []wire.FeedbagItem{
  3008. {
  3009. ClassID: wire.FeedbagClassIdGroup,
  3010. Name: "Friends",
  3011. GroupID: 1,
  3012. },
  3013. },
  3014. err: nil,
  3015. },
  3016. },
  3017. feedbagUpsertParams: feedbagUpsertParams{
  3018. {
  3019. screenName: state.NewIdentScreenName("userA"),
  3020. items: []wire.FeedbagItem{
  3021. {
  3022. Name: "newbuddy",
  3023. GroupID: 1,
  3024. ItemID: 1000,
  3025. ClassID: wire.FeedbagClassIdBuddy,
  3026. },
  3027. {
  3028. ClassID: wire.FeedbagClassIdGroup,
  3029. Name: "Friends",
  3030. GroupID: 1,
  3031. TLVLBlock: wire.TLVLBlock{
  3032. TLVList: wire.TLVList{
  3033. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1000}),
  3034. },
  3035. },
  3036. },
  3037. },
  3038. err: nil,
  3039. },
  3040. },
  3041. },
  3042. sessionRetrieverParams: sessionRetrieverParams{
  3043. retrieveSessionByNameParams: retrieveSessionByNameParams{
  3044. {
  3045. screenName: state.NewIdentScreenName("userA"),
  3046. result: state.NewSession(),
  3047. },
  3048. },
  3049. },
  3050. messageRelayerParams: messageRelayerParams{
  3051. relayToScreenNameParams: relayToScreenNameParams{
  3052. {
  3053. screenName: state.NewIdentScreenName("userA"),
  3054. msg: wire.SNACMessage{
  3055. Frame: wire.SNACFrame{
  3056. FoodGroup: wire.Feedbag,
  3057. SubGroup: wire.FeedbagInsertItem,
  3058. RequestID: wire.ReqIDFromServer,
  3059. },
  3060. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  3061. Items: []wire.FeedbagItem{
  3062. {
  3063. Name: "newbuddy",
  3064. GroupID: 1,
  3065. ItemID: 1000,
  3066. ClassID: wire.FeedbagClassIdBuddy,
  3067. },
  3068. },
  3069. },
  3070. },
  3071. },
  3072. {
  3073. screenName: state.NewIdentScreenName("userA"),
  3074. msg: wire.SNACMessage{
  3075. Frame: wire.SNACFrame{
  3076. FoodGroup: wire.Feedbag,
  3077. SubGroup: wire.FeedbagUpdateItem,
  3078. RequestID: wire.ReqIDFromServer,
  3079. },
  3080. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  3081. Items: []wire.FeedbagItem{
  3082. {
  3083. ClassID: wire.FeedbagClassIdGroup,
  3084. Name: "Friends",
  3085. GroupID: 1,
  3086. TLVLBlock: wire.TLVLBlock{
  3087. TLVList: wire.TLVList{
  3088. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1000}),
  3089. },
  3090. },
  3091. },
  3092. },
  3093. },
  3094. },
  3095. },
  3096. },
  3097. },
  3098. },
  3099. },
  3100. {
  3101. name: "add a buddy to a non-empty group, user not signed in",
  3102. screenName: "userA",
  3103. groupID: "1",
  3104. requestBody: `{"name":"newbuddy2"}`,
  3105. wantStatusCode: http.StatusOK,
  3106. wantResponse: `{"name":"newbuddy2","group_id":1,"item_id":1000}`,
  3107. mockParams: mockParams{
  3108. feedbagManagerParams: feedbagManagerParams{
  3109. feedbagParams: feedbagParams{
  3110. {
  3111. screenName: state.NewIdentScreenName("userA"),
  3112. result: []wire.FeedbagItem{
  3113. {
  3114. ClassID: wire.FeedbagClassIdGroup,
  3115. Name: "Friends",
  3116. GroupID: 1,
  3117. TLVLBlock: wire.TLVLBlock{
  3118. TLVList: wire.TLVList{
  3119. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{12345}),
  3120. },
  3121. },
  3122. },
  3123. {
  3124. ItemID: 12345,
  3125. ClassID: wire.FeedbagClassIdBuddy,
  3126. Name: "existingbuddy",
  3127. GroupID: 1,
  3128. },
  3129. },
  3130. err: nil,
  3131. },
  3132. },
  3133. feedbagUpsertParams: feedbagUpsertParams{
  3134. {
  3135. screenName: state.NewIdentScreenName("userA"),
  3136. items: []wire.FeedbagItem{
  3137. {
  3138. Name: "newbuddy2",
  3139. GroupID: 1,
  3140. ItemID: 1000,
  3141. ClassID: wire.FeedbagClassIdBuddy,
  3142. },
  3143. {
  3144. ClassID: wire.FeedbagClassIdGroup,
  3145. Name: "Friends",
  3146. GroupID: 1,
  3147. TLVLBlock: wire.TLVLBlock{
  3148. TLVList: wire.TLVList{
  3149. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{12345, 1000}),
  3150. },
  3151. },
  3152. },
  3153. },
  3154. err: nil,
  3155. },
  3156. },
  3157. },
  3158. sessionRetrieverParams: sessionRetrieverParams{
  3159. retrieveSessionByNameParams: retrieveSessionByNameParams{
  3160. {
  3161. screenName: state.NewIdentScreenName("userA"),
  3162. result: state.NewSession(),
  3163. },
  3164. },
  3165. },
  3166. messageRelayerParams: messageRelayerParams{
  3167. relayToScreenNameParams: relayToScreenNameParams{
  3168. {
  3169. screenName: state.NewIdentScreenName("userA"),
  3170. msg: wire.SNACMessage{
  3171. Frame: wire.SNACFrame{
  3172. FoodGroup: wire.Feedbag,
  3173. SubGroup: wire.FeedbagInsertItem,
  3174. RequestID: wire.ReqIDFromServer,
  3175. },
  3176. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  3177. Items: []wire.FeedbagItem{
  3178. {
  3179. Name: "newbuddy2",
  3180. GroupID: 1,
  3181. ItemID: 1000,
  3182. ClassID: wire.FeedbagClassIdBuddy,
  3183. },
  3184. },
  3185. },
  3186. },
  3187. },
  3188. {
  3189. screenName: state.NewIdentScreenName("userA"),
  3190. msg: wire.SNACMessage{
  3191. Frame: wire.SNACFrame{
  3192. FoodGroup: wire.Feedbag,
  3193. SubGroup: wire.FeedbagUpdateItem,
  3194. RequestID: wire.ReqIDFromServer,
  3195. },
  3196. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  3197. Items: []wire.FeedbagItem{
  3198. {
  3199. ClassID: wire.FeedbagClassIdGroup,
  3200. Name: "Friends",
  3201. GroupID: 1,
  3202. TLVLBlock: wire.TLVLBlock{
  3203. TLVList: wire.TLVList{
  3204. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{12345, 1000}),
  3205. },
  3206. },
  3207. },
  3208. },
  3209. },
  3210. },
  3211. },
  3212. },
  3213. },
  3214. },
  3215. },
  3216. {
  3217. name: "add a buddy that already exists in a group",
  3218. screenName: "userA",
  3219. groupID: "1",
  3220. requestBody: `{"name":"ExistingBuddy"}`,
  3221. wantStatusCode: http.StatusOK,
  3222. wantResponse: `{"name":"ExistingBuddy","group_id":1,"item_id":12345}`,
  3223. mockParams: mockParams{
  3224. feedbagManagerParams: feedbagManagerParams{
  3225. feedbagParams: feedbagParams{
  3226. {
  3227. screenName: state.NewIdentScreenName("userA"),
  3228. result: []wire.FeedbagItem{
  3229. {
  3230. ClassID: wire.FeedbagClassIdGroup,
  3231. Name: "Friends",
  3232. GroupID: 1,
  3233. TLVLBlock: wire.TLVLBlock{
  3234. TLVList: wire.TLVList{
  3235. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{12345}),
  3236. },
  3237. },
  3238. },
  3239. {
  3240. ItemID: 12345,
  3241. ClassID: wire.FeedbagClassIdBuddy,
  3242. Name: "existingbuddy",
  3243. GroupID: 1,
  3244. },
  3245. },
  3246. err: nil,
  3247. },
  3248. },
  3249. // No FeedbagUpsert should be called when buddy already exists
  3250. },
  3251. // No session retrieval or message relaying should occur
  3252. },
  3253. },
  3254. {
  3255. name: "add a buddy to an empty group, user signed in",
  3256. screenName: "userA",
  3257. groupID: "1",
  3258. requestBody: `{"name":"newbuddy"}`,
  3259. wantStatusCode: http.StatusOK,
  3260. wantResponse: `{"name":"newbuddy","group_id":1,"item_id":1000}`,
  3261. mockParams: mockParams{
  3262. feedbagManagerParams: feedbagManagerParams{
  3263. feedbagParams: feedbagParams{
  3264. {
  3265. screenName: state.NewIdentScreenName("userA"),
  3266. result: []wire.FeedbagItem{
  3267. {
  3268. ClassID: wire.FeedbagClassIdGroup,
  3269. Name: "Friends",
  3270. GroupID: 1,
  3271. },
  3272. },
  3273. err: nil,
  3274. },
  3275. },
  3276. feedbagUpsertParams: feedbagUpsertParams{
  3277. {
  3278. screenName: state.NewIdentScreenName("userA"),
  3279. items: []wire.FeedbagItem{
  3280. {
  3281. Name: "newbuddy",
  3282. GroupID: 1,
  3283. ItemID: 1000,
  3284. ClassID: wire.FeedbagClassIdBuddy,
  3285. },
  3286. {
  3287. ClassID: wire.FeedbagClassIdGroup,
  3288. Name: "Friends",
  3289. GroupID: 1,
  3290. TLVLBlock: wire.TLVLBlock{
  3291. TLVList: wire.TLVList{
  3292. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1000}),
  3293. },
  3294. },
  3295. },
  3296. },
  3297. err: nil,
  3298. },
  3299. },
  3300. },
  3301. sessionRetrieverParams: sessionRetrieverParams{
  3302. retrieveSessionByNameParams: retrieveSessionByNameParams{
  3303. {
  3304. screenName: state.NewIdentScreenName("userA"),
  3305. result: func() *state.Session {
  3306. sess := state.NewSession()
  3307. sess.SetIdentScreenName(state.NewIdentScreenName("userA"))
  3308. inst := sess.AddInstance()
  3309. inst.SetSignonComplete()
  3310. return sess
  3311. }(),
  3312. },
  3313. },
  3314. },
  3315. messageRelayerParams: messageRelayerParams{
  3316. relayToScreenNameParams: relayToScreenNameParams{
  3317. {
  3318. screenName: state.NewIdentScreenName("userA"),
  3319. msg: wire.SNACMessage{
  3320. Frame: wire.SNACFrame{
  3321. FoodGroup: wire.Feedbag,
  3322. SubGroup: wire.FeedbagInsertItem,
  3323. RequestID: wire.ReqIDFromServer,
  3324. },
  3325. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  3326. Items: []wire.FeedbagItem{
  3327. {
  3328. Name: "newbuddy",
  3329. GroupID: 1,
  3330. ItemID: 1000,
  3331. ClassID: wire.FeedbagClassIdBuddy,
  3332. },
  3333. },
  3334. },
  3335. },
  3336. },
  3337. {
  3338. screenName: state.NewIdentScreenName("userA"),
  3339. msg: wire.SNACMessage{
  3340. Frame: wire.SNACFrame{
  3341. FoodGroup: wire.Feedbag,
  3342. SubGroup: wire.FeedbagUpdateItem,
  3343. RequestID: wire.ReqIDFromServer,
  3344. },
  3345. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  3346. Items: []wire.FeedbagItem{
  3347. {
  3348. ClassID: wire.FeedbagClassIdGroup,
  3349. Name: "Friends",
  3350. GroupID: 1,
  3351. TLVLBlock: wire.TLVLBlock{
  3352. TLVList: wire.TLVList{
  3353. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1000}),
  3354. },
  3355. },
  3356. },
  3357. },
  3358. },
  3359. },
  3360. },
  3361. },
  3362. },
  3363. buddyBroadcasterParams: buddyBroadcasterParams{
  3364. broadcastVisibilityParams: broadcastVisibilityParams{
  3365. {
  3366. you: nil, // Not used in expectation, matched with mock.AnythingOfType
  3367. filter: []state.IdentScreenName{state.NewIdentScreenName("newbuddy")},
  3368. sendDepartures: false,
  3369. err: nil,
  3370. },
  3371. },
  3372. },
  3373. },
  3374. },
  3375. {
  3376. name: "invalid group_id - non-numeric",
  3377. screenName: "userA",
  3378. groupID: "invalid",
  3379. requestBody: `{"name":"buddy"}`,
  3380. wantStatusCode: http.StatusBadRequest,
  3381. wantResponse: `{"message":"invalid group_id"}`,
  3382. },
  3383. {
  3384. name: "invalid group_id - out of range",
  3385. screenName: "userA",
  3386. groupID: "99999",
  3387. requestBody: `{"name":"buddy"}`,
  3388. wantStatusCode: http.StatusBadRequest,
  3389. wantResponse: `{"message":"invalid group_id"}`,
  3390. },
  3391. {
  3392. name: "can't add buddies to root group",
  3393. screenName: "userA",
  3394. groupID: "0",
  3395. requestBody: `{"name":"buddy"}`,
  3396. wantStatusCode: http.StatusBadRequest,
  3397. wantResponse: `{"message":"can't add buddies to root group"}`,
  3398. },
  3399. {
  3400. name: "empty screen_name",
  3401. screenName: "",
  3402. groupID: "1",
  3403. requestBody: `{"name":"buddy"}`,
  3404. wantStatusCode: http.StatusBadRequest,
  3405. wantResponse: `{"message":"screen_name is required"}`,
  3406. },
  3407. {
  3408. name: "malformed JSON input",
  3409. screenName: "userA",
  3410. groupID: "1",
  3411. requestBody: `invalid json`,
  3412. wantStatusCode: http.StatusBadRequest,
  3413. wantResponse: `{"message":"buddy_screen_name is required"}`,
  3414. },
  3415. {
  3416. name: "empty name in request body",
  3417. screenName: "userA",
  3418. groupID: "1",
  3419. requestBody: `{"name":""}`,
  3420. wantStatusCode: http.StatusBadRequest,
  3421. wantResponse: `{"message":"buddy_screen_name is required"}`,
  3422. },
  3423. {
  3424. name: "missing name in request body",
  3425. screenName: "userA",
  3426. groupID: "1",
  3427. requestBody: `{}`,
  3428. wantStatusCode: http.StatusBadRequest,
  3429. wantResponse: `{"message":"buddy_screen_name is required"}`,
  3430. },
  3431. {
  3432. name: "invalid UIN - too low",
  3433. screenName: "userA",
  3434. groupID: "1",
  3435. requestBody: `{"name":"9999"}`,
  3436. wantStatusCode: http.StatusBadRequest,
  3437. wantResponse: `{"message":"invalid uin: uin must be a number in the range 10000-2147483646"}`,
  3438. },
  3439. {
  3440. name: "invalid UIN - too high",
  3441. screenName: "userA",
  3442. groupID: "1",
  3443. requestBody: `{"name":"2147483647"}`,
  3444. wantStatusCode: http.StatusBadRequest,
  3445. wantResponse: `{"message":"invalid uin: uin must be a number in the range 10000-2147483646"}`,
  3446. },
  3447. {
  3448. name: "invalid AIM handle - too short",
  3449. screenName: "userA",
  3450. groupID: "1",
  3451. requestBody: `{"name":"Us"}`,
  3452. wantStatusCode: http.StatusBadRequest,
  3453. wantResponse: `{"message":"invalid screen name: screen name must be between 3 and 16 characters"}`,
  3454. },
  3455. {
  3456. name: "invalid AIM handle - too long",
  3457. screenName: "userA",
  3458. groupID: "1",
  3459. requestBody: `{"name":"ThisIsAReallyLongScreenName"}`,
  3460. wantStatusCode: http.StatusBadRequest,
  3461. wantResponse: `{"message":"invalid screen name: screen name must be between 3 and 16 characters"}`,
  3462. },
  3463. {
  3464. name: "error retrieving feedbag",
  3465. screenName: "userA",
  3466. groupID: "1",
  3467. requestBody: `{"name":"buddy"}`,
  3468. wantStatusCode: http.StatusInternalServerError,
  3469. wantResponse: `{"message":"internal server error"}`,
  3470. mockParams: mockParams{
  3471. feedbagManagerParams: feedbagManagerParams{
  3472. feedbagParams: feedbagParams{
  3473. {
  3474. screenName: state.NewIdentScreenName("userA"),
  3475. result: nil,
  3476. err: errors.New("database error"),
  3477. },
  3478. },
  3479. },
  3480. },
  3481. },
  3482. {
  3483. name: "too many buddies in group - max 30",
  3484. screenName: "userA",
  3485. groupID: "1",
  3486. requestBody: `{"name":"newbuddy"}`,
  3487. wantStatusCode: http.StatusBadRequest,
  3488. wantResponse: `{"message":"too many buddies in group. max: 30"}`,
  3489. mockParams: mockParams{
  3490. feedbagManagerParams: feedbagManagerParams{
  3491. feedbagParams: feedbagParams{
  3492. {
  3493. screenName: state.NewIdentScreenName("userA"),
  3494. result: func() []wire.FeedbagItem {
  3495. items := []wire.FeedbagItem{
  3496. {
  3497. ClassID: wire.FeedbagClassIdGroup,
  3498. Name: "Friends",
  3499. GroupID: 1,
  3500. },
  3501. }
  3502. // Add 30 buddies to the group
  3503. for i := 1; i <= 30; i++ {
  3504. items = append(items, wire.FeedbagItem{
  3505. ItemID: uint16(i),
  3506. ClassID: wire.FeedbagClassIdBuddy,
  3507. Name: fmt.Sprintf("buddy%d", i),
  3508. GroupID: 1,
  3509. })
  3510. }
  3511. return items
  3512. }(),
  3513. err: nil,
  3514. },
  3515. },
  3516. },
  3517. },
  3518. },
  3519. {
  3520. name: "group not found",
  3521. screenName: "userA",
  3522. groupID: "999",
  3523. requestBody: `{"name":"buddy"}`,
  3524. wantStatusCode: http.StatusNotFound,
  3525. wantResponse: `{"message":"group not found"}`,
  3526. mockParams: mockParams{
  3527. feedbagManagerParams: feedbagManagerParams{
  3528. feedbagParams: feedbagParams{
  3529. {
  3530. screenName: state.NewIdentScreenName("userA"),
  3531. result: []wire.FeedbagItem{
  3532. {
  3533. ClassID: wire.FeedbagClassIdGroup,
  3534. Name: "Friends",
  3535. GroupID: 1,
  3536. },
  3537. },
  3538. err: nil,
  3539. },
  3540. },
  3541. },
  3542. },
  3543. },
  3544. {
  3545. name: "error inserting feedbag item",
  3546. screenName: "userA",
  3547. groupID: "1",
  3548. requestBody: `{"name":"buddy"}`,
  3549. wantStatusCode: http.StatusInternalServerError,
  3550. wantResponse: `{"message":"internal server error"}`,
  3551. mockParams: mockParams{
  3552. feedbagManagerParams: feedbagManagerParams{
  3553. feedbagParams: feedbagParams{
  3554. {
  3555. screenName: state.NewIdentScreenName("userA"),
  3556. result: []wire.FeedbagItem{
  3557. {
  3558. ClassID: wire.FeedbagClassIdGroup,
  3559. Name: "Friends",
  3560. GroupID: 1,
  3561. },
  3562. },
  3563. err: nil,
  3564. },
  3565. },
  3566. feedbagUpsertParams: feedbagUpsertParams{
  3567. {
  3568. screenName: state.NewIdentScreenName("userA"),
  3569. items: []wire.FeedbagItem{
  3570. {
  3571. Name: "buddy",
  3572. GroupID: 1,
  3573. ItemID: 1000,
  3574. ClassID: wire.FeedbagClassIdBuddy,
  3575. },
  3576. {
  3577. ClassID: wire.FeedbagClassIdGroup,
  3578. Name: "Friends",
  3579. GroupID: 1,
  3580. TLVLBlock: wire.TLVLBlock{
  3581. TLVList: wire.TLVList{
  3582. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1000}),
  3583. },
  3584. },
  3585. },
  3586. },
  3587. err: errors.New("database error"),
  3588. },
  3589. },
  3590. },
  3591. },
  3592. },
  3593. }
  3594. for _, tc := range tt {
  3595. t.Run(tc.name, func(t *testing.T) {
  3596. // Extract buddy name from requestBody JSON
  3597. var buddyName string
  3598. if tc.requestBody != "" {
  3599. var input struct {
  3600. Name string `json:"name"`
  3601. }
  3602. if err := json.Unmarshal([]byte(tc.requestBody), &input); err == nil {
  3603. buddyName = input.Name
  3604. }
  3605. }
  3606. request := httptest.NewRequest(http.MethodPut, "/feedbag/"+tc.screenName+"/group/"+tc.groupID+"/buddy/"+buddyName, nil)
  3607. if tc.screenName != "" {
  3608. request.SetPathValue("screen_name", tc.screenName)
  3609. }
  3610. if tc.groupID != "" {
  3611. request.SetPathValue("group_id", tc.groupID)
  3612. }
  3613. request.SetPathValue("buddy_screen_name", buddyName)
  3614. responseRecorder := httptest.NewRecorder()
  3615. feedbagManager := newMockFeedbagManager(t)
  3616. sessionRetriever := newMockSessionRetriever(t)
  3617. messageRelayer := newMockMessageRelayer(t)
  3618. buddyBroadcaster := newMockBuddyBroadcaster(t)
  3619. for _, params := range tc.mockParams.feedbagManagerParams.feedbagParams {
  3620. feedbagManager.EXPECT().
  3621. Feedbag(matchContext(), params.screenName).
  3622. Return(params.result, params.err)
  3623. }
  3624. for _, params := range tc.mockParams.feedbagManagerParams.feedbagUpsertParams {
  3625. feedbagManager.EXPECT().
  3626. FeedbagUpsert(matchContext(), params.screenName, params.items).
  3627. Return(params.err)
  3628. }
  3629. for _, params := range tc.mockParams.sessionRetrieverParams.retrieveSessionByNameParams {
  3630. sessionRetriever.EXPECT().
  3631. RetrieveSession(params.screenName).
  3632. Return(params.result)
  3633. }
  3634. for _, params := range tc.mockParams.messageRelayerParams.relayToScreenNameParams {
  3635. messageRelayer.EXPECT().
  3636. RelayToScreenName(matchContext(), params.screenName, params.msg)
  3637. }
  3638. for _, params := range tc.mockParams.buddyBroadcasterParams.broadcastVisibilityParams {
  3639. // Use mock.MatchedBy to match any SessionInstance, since we're mainly verifying filter and sendDepartures
  3640. buddyBroadcaster.EXPECT().
  3641. BroadcastVisibility(
  3642. matchContext(),
  3643. mock.AnythingOfType("*state.SessionInstance"),
  3644. params.filter,
  3645. params.sendDepartures,
  3646. ).
  3647. Return(params.err)
  3648. }
  3649. deterministicItemID := func(n int) int {
  3650. return 1000
  3651. }
  3652. putFeedbagBuddyHandler(responseRecorder, request, buddyBroadcaster, feedbagManager, sessionRetriever, messageRelayer, slog.Default(), deterministicItemID)
  3653. assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
  3654. if tc.wantStatusCode == http.StatusOK {
  3655. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  3656. } else {
  3657. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  3658. }
  3659. })
  3660. }
  3661. }
  3662. func TestFeedbagBuddyHandler_DELETE(t *testing.T) {
  3663. tt := []struct {
  3664. name string
  3665. screenName string
  3666. groupID string
  3667. requestBody string
  3668. wantStatusCode int
  3669. wantResponse string
  3670. mockParams mockParams
  3671. }{
  3672. {
  3673. name: "delete existing buddy, user not signed in",
  3674. screenName: "userA",
  3675. groupID: "1",
  3676. requestBody: `{"name":"buddy1"}`,
  3677. wantStatusCode: http.StatusNoContent,
  3678. mockParams: mockParams{
  3679. feedbagManagerParams: feedbagManagerParams{
  3680. feedbagParams: feedbagParams{
  3681. {
  3682. screenName: state.NewIdentScreenName("userA"),
  3683. result: []wire.FeedbagItem{
  3684. {
  3685. ItemID: 1,
  3686. ClassID: wire.FeedbagClassIdGroup,
  3687. Name: "Friends",
  3688. GroupID: 1,
  3689. },
  3690. {
  3691. ItemID: 10,
  3692. ClassID: wire.FeedbagClassIdBuddy,
  3693. Name: "buddy1",
  3694. GroupID: 1,
  3695. },
  3696. },
  3697. err: nil,
  3698. },
  3699. },
  3700. feedbagDeleteParams: feedbagDeleteParams{
  3701. {
  3702. screenName: state.NewIdentScreenName("userA"),
  3703. items: []wire.FeedbagItem{
  3704. {
  3705. ItemID: 10,
  3706. ClassID: wire.FeedbagClassIdBuddy,
  3707. Name: "buddy1",
  3708. GroupID: 1,
  3709. },
  3710. },
  3711. err: nil,
  3712. },
  3713. },
  3714. },
  3715. sessionRetrieverParams: sessionRetrieverParams{
  3716. retrieveSessionByNameParams: retrieveSessionByNameParams{
  3717. {
  3718. screenName: state.NewIdentScreenName("userA"),
  3719. result: state.NewSession(),
  3720. },
  3721. },
  3722. },
  3723. messageRelayerParams: messageRelayerParams{
  3724. relayToScreenNameParams: relayToScreenNameParams{
  3725. {
  3726. screenName: state.NewIdentScreenName("userA"),
  3727. msg: wire.SNACMessage{
  3728. Frame: wire.SNACFrame{
  3729. FoodGroup: wire.Feedbag,
  3730. SubGroup: wire.FeedbagDeleteItem,
  3731. RequestID: wire.ReqIDFromServer,
  3732. },
  3733. Body: wire.SNAC_0x13_0x0A_FeedbagDeleteItem{
  3734. Items: []wire.FeedbagItem{
  3735. {
  3736. ItemID: 10,
  3737. ClassID: wire.FeedbagClassIdBuddy,
  3738. Name: "buddy1",
  3739. GroupID: 1,
  3740. },
  3741. },
  3742. },
  3743. },
  3744. },
  3745. },
  3746. },
  3747. },
  3748. },
  3749. {
  3750. name: "delete existing buddy, user signed in",
  3751. screenName: "userA",
  3752. groupID: "1",
  3753. requestBody: `{"name":"buddy1"}`,
  3754. wantStatusCode: http.StatusNoContent,
  3755. mockParams: mockParams{
  3756. feedbagManagerParams: feedbagManagerParams{
  3757. feedbagParams: feedbagParams{
  3758. {
  3759. screenName: state.NewIdentScreenName("userA"),
  3760. result: []wire.FeedbagItem{
  3761. {
  3762. ItemID: 1,
  3763. ClassID: wire.FeedbagClassIdGroup,
  3764. Name: "Friends",
  3765. GroupID: 1,
  3766. },
  3767. {
  3768. ItemID: 10,
  3769. ClassID: wire.FeedbagClassIdBuddy,
  3770. Name: "buddy1",
  3771. GroupID: 1,
  3772. },
  3773. },
  3774. err: nil,
  3775. },
  3776. },
  3777. feedbagDeleteParams: feedbagDeleteParams{
  3778. {
  3779. screenName: state.NewIdentScreenName("userA"),
  3780. items: []wire.FeedbagItem{
  3781. {
  3782. ItemID: 10,
  3783. ClassID: wire.FeedbagClassIdBuddy,
  3784. Name: "buddy1",
  3785. GroupID: 1,
  3786. },
  3787. },
  3788. err: nil,
  3789. },
  3790. },
  3791. },
  3792. sessionRetrieverParams: sessionRetrieverParams{
  3793. retrieveSessionByNameParams: retrieveSessionByNameParams{
  3794. {
  3795. screenName: state.NewIdentScreenName("userA"),
  3796. result: func() *state.Session {
  3797. sess := state.NewSession()
  3798. sess.SetIdentScreenName(state.NewIdentScreenName("userA"))
  3799. inst := sess.AddInstance()
  3800. inst.SetSignonComplete()
  3801. return sess
  3802. }(),
  3803. },
  3804. },
  3805. },
  3806. messageRelayerParams: messageRelayerParams{
  3807. relayToScreenNameParams: relayToScreenNameParams{
  3808. {
  3809. screenName: state.NewIdentScreenName("userA"),
  3810. msg: wire.SNACMessage{
  3811. Frame: wire.SNACFrame{
  3812. FoodGroup: wire.Feedbag,
  3813. SubGroup: wire.FeedbagDeleteItem,
  3814. RequestID: wire.ReqIDFromServer,
  3815. },
  3816. Body: wire.SNAC_0x13_0x0A_FeedbagDeleteItem{
  3817. Items: []wire.FeedbagItem{
  3818. {
  3819. ItemID: 10,
  3820. ClassID: wire.FeedbagClassIdBuddy,
  3821. Name: "buddy1",
  3822. GroupID: 1,
  3823. },
  3824. },
  3825. },
  3826. },
  3827. },
  3828. },
  3829. },
  3830. buddyBroadcasterParams: buddyBroadcasterParams{
  3831. broadcastVisibilityParams: broadcastVisibilityParams{
  3832. {
  3833. you: nil, // Not used in expectation, matched with mock.AnythingOfType
  3834. filter: []state.IdentScreenName{state.NewIdentScreenName("buddy1")},
  3835. sendDepartures: true,
  3836. err: nil,
  3837. },
  3838. },
  3839. },
  3840. },
  3841. },
  3842. {
  3843. name: "delete buddy from a group with multiple buddies, user not signed in",
  3844. screenName: "userA",
  3845. groupID: "1",
  3846. requestBody: `{"name":"buddy1"}`,
  3847. wantStatusCode: http.StatusNoContent,
  3848. mockParams: mockParams{
  3849. feedbagManagerParams: feedbagManagerParams{
  3850. feedbagParams: feedbagParams{
  3851. {
  3852. screenName: state.NewIdentScreenName("userA"),
  3853. result: []wire.FeedbagItem{
  3854. {
  3855. ItemID: 1,
  3856. ClassID: wire.FeedbagClassIdGroup,
  3857. Name: "Friends",
  3858. GroupID: 1,
  3859. TLVLBlock: wire.TLVLBlock{
  3860. TLVList: wire.TLVList{
  3861. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{10, 20}),
  3862. },
  3863. },
  3864. },
  3865. {
  3866. ItemID: 10,
  3867. ClassID: wire.FeedbagClassIdBuddy,
  3868. Name: "buddy1",
  3869. GroupID: 1,
  3870. },
  3871. {
  3872. ItemID: 20,
  3873. ClassID: wire.FeedbagClassIdBuddy,
  3874. Name: "buddy2",
  3875. GroupID: 1,
  3876. },
  3877. },
  3878. err: nil,
  3879. },
  3880. },
  3881. feedbagDeleteParams: feedbagDeleteParams{
  3882. {
  3883. screenName: state.NewIdentScreenName("userA"),
  3884. items: []wire.FeedbagItem{
  3885. {
  3886. ItemID: 10,
  3887. ClassID: wire.FeedbagClassIdBuddy,
  3888. Name: "buddy1",
  3889. GroupID: 1,
  3890. },
  3891. },
  3892. err: nil,
  3893. },
  3894. },
  3895. },
  3896. sessionRetrieverParams: sessionRetrieverParams{
  3897. retrieveSessionByNameParams: retrieveSessionByNameParams{
  3898. {
  3899. screenName: state.NewIdentScreenName("userA"),
  3900. result: state.NewSession(),
  3901. },
  3902. },
  3903. },
  3904. messageRelayerParams: messageRelayerParams{
  3905. relayToScreenNameParams: relayToScreenNameParams{
  3906. {
  3907. screenName: state.NewIdentScreenName("userA"),
  3908. msg: wire.SNACMessage{
  3909. Frame: wire.SNACFrame{
  3910. FoodGroup: wire.Feedbag,
  3911. SubGroup: wire.FeedbagDeleteItem,
  3912. RequestID: wire.ReqIDFromServer,
  3913. },
  3914. Body: wire.SNAC_0x13_0x0A_FeedbagDeleteItem{
  3915. Items: []wire.FeedbagItem{
  3916. {
  3917. ItemID: 10,
  3918. ClassID: wire.FeedbagClassIdBuddy,
  3919. Name: "buddy1",
  3920. GroupID: 1,
  3921. },
  3922. },
  3923. },
  3924. },
  3925. },
  3926. },
  3927. },
  3928. },
  3929. },
  3930. {
  3931. name: "can't delete buddy from root group",
  3932. screenName: "userA",
  3933. groupID: "0",
  3934. requestBody: `{"name":"rootbuddy"}`,
  3935. wantStatusCode: http.StatusBadRequest,
  3936. wantResponse: `{"message":"can't add buddies to root group"}`,
  3937. },
  3938. {
  3939. name: "missing screen_name",
  3940. screenName: "",
  3941. groupID: "1",
  3942. requestBody: `{"name":"buddy"}`,
  3943. wantStatusCode: http.StatusBadRequest,
  3944. wantResponse: `{"message":"screen_name is required"}`,
  3945. },
  3946. {
  3947. name: "group not found",
  3948. screenName: "userA",
  3949. groupID: "999",
  3950. requestBody: `{"name":"buddy"}`,
  3951. wantStatusCode: http.StatusNotFound,
  3952. wantResponse: `{"message":"group not found"}`,
  3953. mockParams: mockParams{
  3954. feedbagManagerParams: feedbagManagerParams{
  3955. feedbagParams: feedbagParams{
  3956. {
  3957. screenName: state.NewIdentScreenName("userA"),
  3958. result: []wire.FeedbagItem{
  3959. {
  3960. ItemID: 1,
  3961. ClassID: wire.FeedbagClassIdGroup,
  3962. Name: "Friends",
  3963. GroupID: 0,
  3964. },
  3965. },
  3966. err: nil,
  3967. },
  3968. },
  3969. },
  3970. },
  3971. },
  3972. {
  3973. name: "invalid group_id",
  3974. screenName: "userA",
  3975. groupID: "invalid",
  3976. requestBody: `{"name":"buddy"}`,
  3977. wantStatusCode: http.StatusBadRequest,
  3978. wantResponse: `{"message":"invalid group_id"}`,
  3979. },
  3980. {
  3981. name: "malformed request body",
  3982. screenName: "userA",
  3983. groupID: "1",
  3984. requestBody: `invalid json`,
  3985. wantStatusCode: http.StatusBadRequest,
  3986. wantResponse: `{"message":"buddy_screen_name is required"}`,
  3987. },
  3988. {
  3989. name: "missing name in request body",
  3990. screenName: "userA",
  3991. groupID: "1",
  3992. requestBody: `{}`,
  3993. wantStatusCode: http.StatusBadRequest,
  3994. wantResponse: `{"message":"buddy_screen_name is required"}`,
  3995. },
  3996. {
  3997. name: "buddy not found",
  3998. screenName: "userA",
  3999. groupID: "1",
  4000. requestBody: `{"name":"nonexistent"}`,
  4001. wantStatusCode: http.StatusNotFound,
  4002. wantResponse: `{"message":"buddy not found"}`,
  4003. mockParams: mockParams{
  4004. feedbagManagerParams: feedbagManagerParams{
  4005. feedbagParams: feedbagParams{
  4006. {
  4007. screenName: state.NewIdentScreenName("userA"),
  4008. result: []wire.FeedbagItem{
  4009. {
  4010. ItemID: 1,
  4011. ClassID: wire.FeedbagClassIdGroup,
  4012. Name: "Friends",
  4013. GroupID: 1,
  4014. },
  4015. {
  4016. ItemID: 10,
  4017. ClassID: wire.FeedbagClassIdBuddy,
  4018. Name: "otherbuddy",
  4019. GroupID: 1,
  4020. },
  4021. },
  4022. err: nil,
  4023. },
  4024. },
  4025. },
  4026. },
  4027. },
  4028. {
  4029. name: "internal server error on feedbag retrieval",
  4030. screenName: "userA",
  4031. groupID: "1",
  4032. requestBody: `{"name":"buddy"}`,
  4033. wantStatusCode: http.StatusInternalServerError,
  4034. wantResponse: `{"message":"internal server error"}`,
  4035. mockParams: mockParams{
  4036. feedbagManagerParams: feedbagManagerParams{
  4037. feedbagParams: feedbagParams{
  4038. {
  4039. screenName: state.NewIdentScreenName("userA"),
  4040. result: nil,
  4041. err: errors.New("database error"),
  4042. },
  4043. },
  4044. },
  4045. },
  4046. },
  4047. {
  4048. name: "internal server error on delete",
  4049. screenName: "userA",
  4050. groupID: "1",
  4051. requestBody: `{"name":"buddy1"}`,
  4052. wantStatusCode: http.StatusInternalServerError,
  4053. wantResponse: `{"message":"internal server error"}`,
  4054. mockParams: mockParams{
  4055. feedbagManagerParams: feedbagManagerParams{
  4056. feedbagParams: feedbagParams{
  4057. {
  4058. screenName: state.NewIdentScreenName("userA"),
  4059. result: []wire.FeedbagItem{
  4060. {
  4061. ItemID: 1,
  4062. ClassID: wire.FeedbagClassIdGroup,
  4063. Name: "Friends",
  4064. GroupID: 1,
  4065. },
  4066. {
  4067. ItemID: 10,
  4068. ClassID: wire.FeedbagClassIdBuddy,
  4069. Name: "buddy1",
  4070. GroupID: 1,
  4071. },
  4072. },
  4073. err: nil,
  4074. },
  4075. },
  4076. feedbagDeleteParams: feedbagDeleteParams{
  4077. {
  4078. screenName: state.NewIdentScreenName("userA"),
  4079. items: []wire.FeedbagItem{
  4080. {
  4081. ItemID: 10,
  4082. ClassID: wire.FeedbagClassIdBuddy,
  4083. Name: "buddy1",
  4084. GroupID: 1,
  4085. },
  4086. },
  4087. err: errors.New("database error"),
  4088. },
  4089. },
  4090. },
  4091. },
  4092. },
  4093. }
  4094. for _, tc := range tt {
  4095. t.Run(tc.name, func(t *testing.T) {
  4096. // Extract buddy name from requestBody JSON
  4097. var buddyName string
  4098. if tc.requestBody != "" {
  4099. var input struct {
  4100. Name string `json:"name"`
  4101. }
  4102. if err := json.Unmarshal([]byte(tc.requestBody), &input); err == nil {
  4103. buddyName = input.Name
  4104. }
  4105. }
  4106. request := httptest.NewRequest(http.MethodDelete, "/feedbag/"+tc.screenName+"/group/"+tc.groupID+"/buddy/"+buddyName, nil)
  4107. if tc.screenName != "" {
  4108. request.SetPathValue("screen_name", tc.screenName)
  4109. }
  4110. if tc.groupID != "" {
  4111. request.SetPathValue("group_id", tc.groupID)
  4112. }
  4113. request.SetPathValue("buddy_screen_name", buddyName)
  4114. responseRecorder := httptest.NewRecorder()
  4115. feedbagManager := newMockFeedbagManager(t)
  4116. sessionRetriever := newMockSessionRetriever(t)
  4117. messageRelayer := newMockMessageRelayer(t)
  4118. buddyBroadcaster := newMockBuddyBroadcaster(t)
  4119. for _, params := range tc.mockParams.feedbagManagerParams.feedbagParams {
  4120. feedbagManager.EXPECT().
  4121. Feedbag(matchContext(), params.screenName).
  4122. Return(params.result, params.err)
  4123. }
  4124. for _, params := range tc.mockParams.feedbagManagerParams.feedbagDeleteParams {
  4125. feedbagManager.EXPECT().
  4126. FeedbagDelete(matchContext(), params.screenName, params.items).
  4127. Return(params.err)
  4128. }
  4129. for _, params := range tc.mockParams.sessionRetrieverParams.retrieveSessionByNameParams {
  4130. sessionRetriever.EXPECT().
  4131. RetrieveSession(params.screenName).
  4132. Return(params.result)
  4133. }
  4134. for _, params := range tc.mockParams.messageRelayerParams.relayToScreenNameParams {
  4135. messageRelayer.EXPECT().
  4136. RelayToScreenName(matchContext(), params.screenName, params.msg)
  4137. }
  4138. for _, params := range tc.mockParams.buddyBroadcasterParams.broadcastVisibilityParams {
  4139. buddyBroadcaster.EXPECT().
  4140. BroadcastVisibility(
  4141. matchContext(),
  4142. mock.AnythingOfType("*state.SessionInstance"),
  4143. params.filter,
  4144. params.sendDepartures,
  4145. ).
  4146. Return(params.err)
  4147. }
  4148. deleteFeedbagBuddyHandler(responseRecorder, request, buddyBroadcaster, feedbagManager, sessionRetriever, messageRelayer, slog.Default())
  4149. assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
  4150. if tc.wantResponse != "" {
  4151. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  4152. }
  4153. })
  4154. }
  4155. }
  4156. func TestRandItemID(t *testing.T) {
  4157. tt := []struct {
  4158. name string
  4159. randInt func(n int) int
  4160. items []wire.FeedbagItem
  4161. want uint16
  4162. description string
  4163. }{
  4164. {
  4165. name: "empty items list returns random ID",
  4166. randInt: func(n int) int {
  4167. return 1000
  4168. },
  4169. items: []wire.FeedbagItem{},
  4170. want: 1000,
  4171. description: "When no items exist, should return the random number generated",
  4172. },
  4173. {
  4174. name: "finds next available ID when starting ID conflicts with ItemID",
  4175. randInt: func(n int) int {
  4176. return 100
  4177. },
  4178. items: []wire.FeedbagItem{
  4179. {ItemID: 100, GroupID: 1},
  4180. {ItemID: 101, GroupID: 1},
  4181. },
  4182. want: 102,
  4183. description: "Should skip 100 and 101, return 102",
  4184. },
  4185. {
  4186. name: "finds next available ID when starting ID conflicts with GroupID",
  4187. randInt: func(n int) int {
  4188. return 50
  4189. },
  4190. items: []wire.FeedbagItem{
  4191. {ItemID: 1, GroupID: 50},
  4192. {ItemID: 2, GroupID: 51},
  4193. },
  4194. want: 52,
  4195. description: "Should skip 50 (GroupID) and 51 (GroupID), return 52",
  4196. },
  4197. {
  4198. name: "wraps around and skips 0 to find next available ID",
  4199. randInt: func(n int) int {
  4200. return math.MaxUint16 - 2
  4201. },
  4202. items: []wire.FeedbagItem{
  4203. {ItemID: math.MaxUint16 - 2, GroupID: 1},
  4204. {ItemID: math.MaxUint16 - 1, GroupID: 1},
  4205. {ItemID: math.MaxUint16, GroupID: 1},
  4206. },
  4207. want: 2,
  4208. description: "When wrapping around, skips 0 (always skipped) and 1 (if conflicts), returns 2",
  4209. },
  4210. {
  4211. name: "skips 0 when starting from 0 and finds next available",
  4212. randInt: func(n int) int {
  4213. return 0
  4214. },
  4215. items: []wire.FeedbagItem{},
  4216. want: 1,
  4217. description: "When starting from 0, skips 0 (always skipped) and returns 1",
  4218. },
  4219. {
  4220. name: "returns 0 when all IDs are taken",
  4221. randInt: func(n int) int {
  4222. return 100
  4223. },
  4224. items: func() []wire.FeedbagItem {
  4225. // Create items that cover all possible IDs
  4226. items := make([]wire.FeedbagItem, 0, math.MaxUint16+1)
  4227. for i := 0; i <= math.MaxUint16; i++ {
  4228. items = append(items, wire.FeedbagItem{
  4229. ItemID: uint16(i),
  4230. GroupID: uint16(i),
  4231. })
  4232. }
  4233. return items
  4234. }(),
  4235. want: 0,
  4236. description: "When all IDs are taken, should return 0",
  4237. },
  4238. {
  4239. name: "finds ID that conflicts with both ItemID and GroupID",
  4240. randInt: func(n int) int {
  4241. return 200
  4242. },
  4243. items: []wire.FeedbagItem{
  4244. {ItemID: 200, GroupID: 201},
  4245. {ItemID: 201, GroupID: 200},
  4246. },
  4247. want: 202,
  4248. description: "Should skip 200 (ItemID) and 201 (both ItemID and GroupID), return 202",
  4249. },
  4250. {
  4251. name: "finds available ID immediately when no conflicts",
  4252. randInt: func(n int) int {
  4253. return 500
  4254. },
  4255. items: []wire.FeedbagItem{
  4256. {ItemID: 100, GroupID: 1},
  4257. {ItemID: 200, GroupID: 2},
  4258. {ItemID: 300, GroupID: 3},
  4259. },
  4260. want: 500,
  4261. description: "When random ID has no conflicts, should return it immediately",
  4262. },
  4263. {
  4264. name: "handles single conflict and finds next",
  4265. randInt: func(n int) int {
  4266. return 42
  4267. },
  4268. items: []wire.FeedbagItem{
  4269. {ItemID: 42, GroupID: 1},
  4270. },
  4271. want: 43,
  4272. description: "Should skip 42 and return 43",
  4273. },
  4274. {
  4275. name: "finds ID before starting point when wrapping",
  4276. randInt: func(n int) int {
  4277. return 5
  4278. },
  4279. items: []wire.FeedbagItem{
  4280. {ItemID: 5, GroupID: 1},
  4281. {ItemID: 6, GroupID: 1},
  4282. {ItemID: 7, GroupID: 1},
  4283. },
  4284. want: 8,
  4285. description: "Should skip 5, 6, 7 and return 8",
  4286. },
  4287. }
  4288. for _, tc := range tt {
  4289. t.Run(tc.name, func(t *testing.T) {
  4290. got := randItemID(tc.randInt, tc.items)
  4291. if got != tc.want {
  4292. t.Errorf("randItemID() = %d, want %d. %s", got, tc.want, tc.description)
  4293. }
  4294. })
  4295. }
  4296. }