mgmt_api_test.go 164 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154115511561157115811591160116111621163116411651166116711681169117011711172117311741175117611771178117911801181118211831184118511861187118811891190119111921193119411951196119711981199120012011202120312041205120612071208120912101211121212131214121512161217121812191220122112221223122412251226122712281229123012311232123312341235123612371238123912401241124212431244124512461247124812491250125112521253125412551256125712581259126012611262126312641265126612671268126912701271127212731274127512761277127812791280128112821283128412851286128712881289129012911292129312941295129612971298129913001301130213031304130513061307130813091310131113121313131413151316131713181319132013211322132313241325132613271328132913301331133213331334133513361337133813391340134113421343134413451346134713481349135013511352135313541355135613571358135913601361136213631364136513661367136813691370137113721373137413751376137713781379138013811382138313841385138613871388138913901391139213931394139513961397139813991400140114021403140414051406140714081409141014111412141314141415141614171418141914201421142214231424142514261427142814291430143114321433143414351436143714381439144014411442144314441445144614471448144914501451145214531454145514561457145814591460146114621463146414651466146714681469147014711472147314741475147614771478147914801481148214831484148514861487148814891490149114921493149414951496149714981499150015011502150315041505150615071508150915101511151215131514151515161517151815191520152115221523152415251526152715281529153015311532153315341535153615371538153915401541154215431544154515461547154815491550155115521553155415551556155715581559156015611562156315641565156615671568156915701571157215731574157515761577157815791580158115821583158415851586158715881589159015911592159315941595159615971598159916001601160216031604160516061607160816091610161116121613161416151616161716181619162016211622162316241625162616271628162916301631163216331634163516361637163816391640164116421643164416451646164716481649165016511652165316541655165616571658165916601661166216631664166516661667166816691670167116721673167416751676167716781679168016811682168316841685168616871688168916901691169216931694169516961697169816991700170117021703170417051706170717081709171017111712171317141715171617171718171917201721172217231724172517261727172817291730173117321733173417351736173717381739174017411742174317441745174617471748174917501751175217531754175517561757175817591760176117621763176417651766176717681769177017711772177317741775177617771778177917801781178217831784178517861787178817891790179117921793179417951796179717981799180018011802180318041805180618071808180918101811181218131814181518161817181818191820182118221823182418251826182718281829183018311832183318341835183618371838183918401841184218431844184518461847184818491850185118521853185418551856185718581859186018611862186318641865186618671868186918701871187218731874187518761877187818791880188118821883188418851886188718881889189018911892189318941895189618971898189919001901190219031904190519061907190819091910191119121913191419151916191719181919192019211922192319241925192619271928192919301931193219331934193519361937193819391940194119421943194419451946194719481949195019511952195319541955195619571958195919601961196219631964196519661967196819691970197119721973197419751976197719781979198019811982198319841985198619871988198919901991199219931994199519961997199819992000200120022003200420052006200720082009201020112012201320142015201620172018201920202021202220232024202520262027202820292030203120322033203420352036203720382039204020412042204320442045204620472048204920502051205220532054205520562057205820592060206120622063206420652066206720682069207020712072207320742075207620772078207920802081208220832084208520862087208820892090209120922093209420952096209720982099210021012102210321042105210621072108210921102111211221132114211521162117211821192120212121222123212421252126212721282129213021312132213321342135213621372138213921402141214221432144214521462147214821492150215121522153215421552156215721582159216021612162216321642165216621672168216921702171217221732174217521762177217821792180218121822183218421852186218721882189219021912192219321942195219621972198219922002201220222032204220522062207220822092210221122122213221422152216221722182219222022212222222322242225222622272228222922302231223222332234223522362237223822392240224122422243224422452246224722482249225022512252225322542255225622572258225922602261226222632264226522662267226822692270227122722273227422752276227722782279228022812282228322842285228622872288228922902291229222932294229522962297229822992300230123022303230423052306230723082309231023112312231323142315231623172318231923202321232223232324232523262327232823292330233123322333233423352336233723382339234023412342234323442345234623472348234923502351235223532354235523562357235823592360236123622363236423652366236723682369237023712372237323742375237623772378237923802381238223832384238523862387238823892390239123922393239423952396239723982399240024012402240324042405240624072408240924102411241224132414241524162417241824192420242124222423242424252426242724282429243024312432243324342435243624372438243924402441244224432444244524462447244824492450245124522453245424552456245724582459246024612462246324642465246624672468246924702471247224732474247524762477247824792480248124822483248424852486248724882489249024912492249324942495249624972498249925002501250225032504250525062507250825092510251125122513251425152516251725182519252025212522252325242525252625272528252925302531253225332534253525362537253825392540254125422543254425452546254725482549255025512552255325542555255625572558255925602561256225632564256525662567256825692570257125722573257425752576257725782579258025812582258325842585258625872588258925902591259225932594259525962597259825992600260126022603260426052606260726082609261026112612261326142615261626172618261926202621262226232624262526262627262826292630263126322633263426352636263726382639264026412642264326442645264626472648264926502651265226532654265526562657265826592660266126622663266426652666266726682669267026712672267326742675267626772678267926802681268226832684268526862687268826892690269126922693269426952696269726982699270027012702270327042705270627072708270927102711271227132714271527162717271827192720272127222723272427252726272727282729273027312732273327342735273627372738273927402741274227432744274527462747274827492750275127522753275427552756275727582759276027612762276327642765276627672768276927702771277227732774277527762777277827792780278127822783278427852786278727882789279027912792279327942795279627972798279928002801280228032804280528062807280828092810281128122813281428152816281728182819282028212822282328242825282628272828282928302831283228332834283528362837283828392840284128422843284428452846284728482849285028512852285328542855285628572858285928602861286228632864286528662867286828692870287128722873287428752876287728782879288028812882288328842885288628872888288928902891289228932894289528962897289828992900290129022903290429052906290729082909291029112912291329142915291629172918291929202921292229232924292529262927292829292930293129322933293429352936293729382939294029412942294329442945294629472948294929502951295229532954295529562957295829592960296129622963296429652966296729682969297029712972297329742975297629772978297929802981298229832984298529862987298829892990299129922993299429952996299729982999300030013002300330043005300630073008300930103011301230133014301530163017301830193020302130223023302430253026302730283029303030313032303330343035303630373038303930403041304230433044304530463047304830493050305130523053305430553056305730583059306030613062306330643065306630673068306930703071307230733074307530763077307830793080308130823083308430853086308730883089309030913092309330943095309630973098309931003101310231033104310531063107310831093110311131123113311431153116311731183119312031213122312331243125312631273128312931303131313231333134313531363137313831393140314131423143314431453146314731483149315031513152315331543155315631573158315931603161316231633164316531663167316831693170317131723173317431753176317731783179318031813182318331843185318631873188318931903191319231933194319531963197319831993200320132023203320432053206320732083209321032113212321332143215321632173218321932203221322232233224322532263227322832293230323132323233323432353236323732383239324032413242324332443245324632473248324932503251325232533254325532563257325832593260326132623263326432653266326732683269327032713272327332743275327632773278327932803281328232833284328532863287328832893290329132923293329432953296329732983299330033013302330333043305330633073308330933103311331233133314331533163317331833193320332133223323332433253326332733283329333033313332333333343335333633373338333933403341334233433344334533463347334833493350335133523353335433553356335733583359336033613362336333643365336633673368336933703371337233733374337533763377337833793380338133823383338433853386338733883389339033913392339333943395339633973398339934003401340234033404340534063407340834093410341134123413341434153416341734183419342034213422342334243425342634273428342934303431343234333434343534363437343834393440344134423443344434453446344734483449345034513452345334543455345634573458345934603461346234633464346534663467346834693470347134723473347434753476347734783479348034813482348334843485348634873488348934903491349234933494349534963497349834993500350135023503350435053506350735083509351035113512351335143515351635173518351935203521352235233524352535263527352835293530353135323533353435353536353735383539354035413542354335443545354635473548354935503551355235533554355535563557355835593560356135623563356435653566356735683569357035713572357335743575357635773578357935803581358235833584358535863587358835893590359135923593359435953596359735983599360036013602360336043605360636073608360936103611361236133614361536163617361836193620362136223623362436253626362736283629363036313632363336343635363636373638363936403641364236433644364536463647364836493650365136523653365436553656365736583659366036613662366336643665366636673668366936703671367236733674367536763677367836793680368136823683368436853686368736883689369036913692369336943695369636973698369937003701370237033704370537063707370837093710371137123713371437153716371737183719372037213722372337243725372637273728372937303731373237333734373537363737373837393740374137423743374437453746374737483749375037513752375337543755375637573758375937603761376237633764376537663767376837693770377137723773377437753776377737783779378037813782378337843785378637873788378937903791379237933794379537963797379837993800380138023803380438053806380738083809381038113812381338143815381638173818381938203821382238233824382538263827382838293830383138323833383438353836383738383839384038413842384338443845384638473848384938503851385238533854385538563857385838593860386138623863386438653866386738683869387038713872387338743875387638773878387938803881388238833884388538863887388838893890389138923893389438953896389738983899390039013902390339043905390639073908390939103911391239133914391539163917391839193920392139223923392439253926392739283929393039313932393339343935393639373938393939403941394239433944394539463947394839493950395139523953395439553956395739583959396039613962396339643965396639673968396939703971397239733974397539763977397839793980398139823983398439853986398739883989399039913992399339943995399639973998399940004001400240034004400540064007400840094010401140124013401440154016401740184019402040214022402340244025402640274028402940304031403240334034403540364037403840394040404140424043404440454046404740484049405040514052405340544055405640574058405940604061406240634064406540664067406840694070407140724073407440754076407740784079408040814082408340844085408640874088408940904091409240934094409540964097409840994100410141024103410441054106410741084109411041114112411341144115411641174118411941204121412241234124412541264127412841294130413141324133413441354136413741384139414041414142414341444145414641474148414941504151415241534154415541564157415841594160416141624163416441654166416741684169417041714172417341744175417641774178417941804181418241834184418541864187418841894190419141924193419441954196419741984199420042014202420342044205420642074208420942104211421242134214421542164217421842194220422142224223422442254226422742284229423042314232423342344235423642374238423942404241424242434244424542464247424842494250425142524253425442554256425742584259426042614262426342644265426642674268426942704271427242734274427542764277427842794280428142824283428442854286428742884289429042914292429342944295429642974298429943004301430243034304430543064307430843094310431143124313431443154316431743184319432043214322432343244325432643274328432943304331433243334334433543364337433843394340434143424343434443454346434743484349435043514352435343544355435643574358435943604361436243634364436543664367436843694370437143724373437443754376437743784379438043814382438343844385438643874388438943904391439243934394439543964397439843994400440144024403440444054406440744084409441044114412441344144415441644174418441944204421442244234424442544264427442844294430443144324433443444354436443744384439444044414442444344444445444644474448444944504451445244534454445544564457445844594460446144624463446444654466446744684469447044714472447344744475447644774478447944804481448244834484448544864487448844894490449144924493449444954496449744984499450045014502450345044505450645074508450945104511451245134514451545164517451845194520452145224523452445254526452745284529453045314532453345344535453645374538453945404541454245434544454545464547454845494550455145524553455445554556455745584559456045614562456345644565456645674568456945704571457245734574457545764577457845794580458145824583458445854586458745884589459045914592459345944595459645974598459946004601460246034604460546064607460846094610461146124613461446154616461746184619462046214622462346244625462646274628462946304631463246334634463546364637463846394640464146424643464446454646464746484649465046514652465346544655465646574658465946604661466246634664466546664667466846694670467146724673467446754676467746784679468046814682468346844685468646874688468946904691469246934694469546964697469846994700470147024703470447054706470747084709471047114712471347144715471647174718471947204721472247234724472547264727472847294730473147324733473447354736473747384739474047414742474347444745474647474748474947504751475247534754475547564757475847594760476147624763476447654766476747684769477047714772477347744775477647774778477947804781478247834784478547864787478847894790479147924793479447954796479747984799480048014802480348044805480648074808480948104811481248134814481548164817481848194820482148224823482448254826482748284829483048314832483348344835483648374838483948404841484248434844484548464847484848494850485148524853485448554856485748584859486048614862486348644865486648674868486948704871487248734874487548764877487848794880488148824883488448854886488748884889489048914892489348944895489648974898489949004901490249034904490549064907490849094910491149124913491449154916491749184919492049214922492349244925492649274928492949304931493249334934493549364937493849394940494149424943494449454946494749484949495049514952495349544955495649574958495949604961496249634964496549664967496849694970497149724973497449754976497749784979498049814982498349844985498649874988498949904991499249934994499549964997499849995000500150025003500450055006500750085009501050115012501350145015501650175018501950205021502250235024502550265027502850295030503150325033503450355036503750385039504050415042504350445045504650475048504950505051505250535054505550565057505850595060506150625063506450655066506750685069507050715072507350745075507650775078507950805081508250835084508550865087508850895090509150925093509450955096509750985099510051015102510351045105510651075108510951105111511251135114511551165117511851195120512151225123512451255126512751285129513051315132513351345135513651375138513951405141514251435144514551465147514851495150515151525153515451555156515751585159516051615162516351645165516651675168516951705171517251735174517551765177517851795180518151825183518451855186518751885189519051915192519351945195519651975198519952005201520252035204520552065207520852095210521152125213521452155216521752185219522052215222522352245225522652275228522952305231523252335234523552365237523852395240524152425243524452455246524752485249525052515252525352545255525652575258525952605261526252635264526552665267526852695270527152725273527452755276527752785279528052815282528352845285528652875288528952905291529252935294529552965297529852995300530153025303530453055306530753085309531053115312531353145315531653175318531953205321532253235324532553265327532853295330533153325333533453355336533753385339534053415342534353445345534653475348534953505351535253535354535553565357535853595360536153625363536453655366536753685369537053715372537353745375537653775378537953805381538253835384538553865387538853895390539153925393539453955396539753985399540054015402540354045405540654075408540954105411541254135414541554165417541854195420542154225423542454255426542754285429543054315432543354345435543654375438543954405441544254435444544554465447544854495450545154525453545454555456545754585459546054615462546354645465546654675468546954705471547254735474547554765477547854795480548154825483548454855486548754885489549054915492549354945495549654975498549955005501550255035504550555065507550855095510551155125513551455155516551755185519552055215522552355245525552655275528552955305531553255335534553555365537553855395540554155425543554455455546554755485549555055515552555355545555555655575558555955605561556255635564556555665567556855695570557155725573557455755576557755785579558055815582558355845585558655875588558955905591559255935594559555965597559855995600560156025603560456055606560756085609561056115612561356145615561656175618561956205621562256235624562556265627562856295630563156325633563456355636563756385639564056415642564356445645564656475648564956505651565256535654565556565657565856595660566156625663566456655666566756685669567056715672567356745675567656775678567956805681568256835684568556865687568856895690569156925693569456955696569756985699570057015702570357045705
  1. package http
  2. import (
  3. "bytes"
  4. "context"
  5. "encoding/json"
  6. "errors"
  7. "fmt"
  8. "io"
  9. "log/slog"
  10. "math"
  11. "net/http"
  12. "net/http/httptest"
  13. "net/mail"
  14. "net/netip"
  15. "strings"
  16. "testing"
  17. "time"
  18. "github.com/stretchr/testify/assert"
  19. "github.com/stretchr/testify/mock"
  20. "github.com/mk6i/open-oscar-server/config"
  21. "github.com/mk6i/open-oscar-server/state"
  22. "github.com/mk6i/open-oscar-server/wire"
  23. )
  24. func TestSessionHandler_GET(t *testing.T) {
  25. // Fixed time for testing: 2024-01-01 12:00:00 UTC
  26. fixedNow := time.Date(2024, 1, 1, 12, 0, 0, 0, time.UTC)
  27. nowFn := func() time.Time { return fixedNow }
  28. tt := []struct {
  29. name string
  30. want string
  31. statusCode int
  32. createSessions func() []*state.Session
  33. }{
  34. {
  35. name: "without sessions",
  36. want: `{"count":0,"sessions":[]}`,
  37. statusCode: http.StatusOK,
  38. createSessions: func() []*state.Session {
  39. return []*state.Session{}
  40. },
  41. },
  42. {
  43. name: "with sessions",
  44. want: `{"count":3,"sessions":[{"id":"usera","screen_name":"userA","online_seconds":100,"is_away":false,"away_message":"","idle_seconds":0,"is_invisible":false,"is_icq":false,"instance_count":2,"instances":[{"num":1,"idle_seconds":30,"is_away":false,"away_message":"","is_invisible":false,"remote_addr":"1.2.3.4","remote_port":1234},{"num":2,"idle_seconds":0,"is_away":false,"away_message":"","is_invisible":true,"remote_addr":"5.6.7.8","remote_port":5678}]},{"id":"userb","screen_name":"userB","online_seconds":200,"is_away":false,"away_message":"","idle_seconds":0,"is_invisible":true,"is_icq":false,"instance_count":2,"instances":[{"num":1,"idle_seconds":0,"is_away":false,"away_message":"","is_invisible":true,"remote_addr":"9.10.11.12","remote_port":9012},{"num":2,"idle_seconds":0,"is_away":false,"away_message":"","is_invisible":true,"remote_addr":"13.14.15.16","remote_port":1314}]},{"id":"100003","screen_name":"100003","online_seconds":300,"is_away":false,"away_message":"","idle_seconds":0,"is_invisible":false,"is_icq":true,"instance_count":1,"instances":[{"num":1,"idle_seconds":0,"is_away":false,"away_message":"","is_invisible":false,"remote_addr":"1.2.3.4","remote_port":1234}]}]}`,
  45. statusCode: http.StatusOK,
  46. createSessions: func() []*state.Session {
  47. // userA: 2 instances - one idle (30s), one invisible
  48. userA := state.NewSession()
  49. userA.SetIdentScreenName(state.NewIdentScreenName("userA"))
  50. userA.SetDisplayScreenName(state.DisplayScreenName("userA"))
  51. userA.SetUIN(0)
  52. userA.SetNowFn(nowFn)
  53. userA.SetSignonTime(fixedNow.Add(-100 * time.Second))
  54. inst1 := userA.AddInstance()
  55. inst1.SetSignonComplete()
  56. inst1.SetIdle(30 * time.Second)
  57. ip1, _ := netip.ParseAddrPort("1.2.3.4:1234")
  58. inst1.SetRemoteAddr(&ip1)
  59. inst2 := userA.AddInstance()
  60. inst2.SetSignonComplete()
  61. inst2.SetUserStatusBitmask(wire.OServiceUserStatusInvisible)
  62. ip2, _ := netip.ParseAddrPort("5.6.7.8:5678")
  63. inst2.SetRemoteAddr(&ip2)
  64. // userB: 2 instances - both invisible
  65. userB := state.NewSession()
  66. userB.SetIdentScreenName(state.NewIdentScreenName("userB"))
  67. userB.SetDisplayScreenName(state.DisplayScreenName("userB"))
  68. userB.SetUIN(0)
  69. userB.SetNowFn(nowFn)
  70. userB.SetSignonTime(fixedNow.Add(-200 * time.Second))
  71. inst3 := userB.AddInstance()
  72. inst3.SetSignonComplete()
  73. inst3.SetUserStatusBitmask(wire.OServiceUserStatusInvisible)
  74. ip3, _ := netip.ParseAddrPort("9.10.11.12:9012")
  75. inst3.SetRemoteAddr(&ip3)
  76. inst4 := userB.AddInstance()
  77. inst4.SetSignonComplete()
  78. inst4.SetUserStatusBitmask(wire.OServiceUserStatusInvisible)
  79. ip4, _ := netip.ParseAddrPort("13.14.15.16:1314")
  80. inst4.SetRemoteAddr(&ip4)
  81. // 100003: 1 instance - normal
  82. icqUser := state.NewSession()
  83. icqUser.SetIdentScreenName(state.NewIdentScreenName("100003"))
  84. icqUser.SetDisplayScreenName(state.DisplayScreenName("100003"))
  85. icqUser.SetUIN(100003)
  86. icqUser.SetNowFn(nowFn)
  87. icqUser.SetSignonTime(fixedNow.Add(-300 * time.Second))
  88. inst5 := icqUser.AddInstance()
  89. inst5.SetSignonComplete()
  90. ip5, _ := netip.ParseAddrPort("1.2.3.4:1234")
  91. inst5.SetRemoteAddr(&ip5)
  92. return []*state.Session{userA, userB, icqUser}
  93. },
  94. },
  95. {
  96. name: "with away sessions",
  97. want: `{"count":2,"sessions":[{"id":"usera","screen_name":"userA","online_seconds":100,"is_away":false,"away_message":"","idle_seconds":0,"is_invisible":false,"is_icq":false,"instance_count":2,"instances":[{"num":1,"idle_seconds":0,"is_away":true,"away_message":"Away message 1","is_invisible":false,"remote_addr":"1.2.3.4","remote_port":1234},{"num":2,"idle_seconds":0,"is_away":false,"away_message":"","is_invisible":false,"remote_addr":"5.6.7.8","remote_port":5678}]},{"id":"userb","screen_name":"userB","online_seconds":200,"is_away":true,"away_message":"Away message 2","idle_seconds":0,"is_invisible":false,"is_icq":false,"instance_count":2,"instances":[{"num":1,"idle_seconds":0,"is_away":true,"away_message":"Away message 2","is_invisible":false,"remote_addr":"9.10.11.12","remote_port":9012},{"num":2,"idle_seconds":0,"is_away":true,"away_message":"Away message 2","is_invisible":false,"remote_addr":"13.14.15.16","remote_port":1314}]}]}`,
  98. statusCode: http.StatusOK,
  99. createSessions: func() []*state.Session {
  100. // userA: 2 instances - one away, one not away (away_message should be "")
  101. userA := state.NewSession()
  102. userA.SetIdentScreenName(state.NewIdentScreenName("userA"))
  103. userA.SetDisplayScreenName(state.DisplayScreenName("userA"))
  104. userA.SetUIN(0)
  105. userA.SetNowFn(nowFn)
  106. userA.SetSignonTime(fixedNow.Add(-100 * time.Second))
  107. inst1 := userA.AddInstance()
  108. inst1.SetSignonComplete()
  109. inst1.SetUserStatusBitmask(wire.OServiceUserStatusAway)
  110. inst1.SetAwayMessage("Away message 1")
  111. ip1, _ := netip.ParseAddrPort("1.2.3.4:1234")
  112. inst1.SetRemoteAddr(&ip1)
  113. inst2 := userA.AddInstance()
  114. inst2.SetSignonComplete()
  115. ip2, _ := netip.ParseAddrPort("5.6.7.8:5678")
  116. inst2.SetRemoteAddr(&ip2)
  117. // userB: 2 instances - both away (away_message should be populated)
  118. userB := state.NewSession()
  119. userB.SetIdentScreenName(state.NewIdentScreenName("userB"))
  120. userB.SetDisplayScreenName(state.DisplayScreenName("userB"))
  121. userB.SetUIN(0)
  122. userB.SetNowFn(nowFn)
  123. userB.SetSignonTime(fixedNow.Add(-200 * time.Second))
  124. inst3 := userB.AddInstance()
  125. inst3.SetSignonComplete()
  126. inst3.SetUserStatusBitmask(wire.OServiceUserStatusAway)
  127. inst3.SetAwayMessage("Away message 2")
  128. ip3, _ := netip.ParseAddrPort("9.10.11.12:9012")
  129. inst3.SetRemoteAddr(&ip3)
  130. inst4 := userB.AddInstance()
  131. inst4.SetSignonComplete()
  132. inst4.SetUserStatusBitmask(wire.OServiceUserStatusAway)
  133. inst4.SetAwayMessage("Away message 2")
  134. ip4, _ := netip.ParseAddrPort("13.14.15.16:1314")
  135. inst4.SetRemoteAddr(&ip4)
  136. return []*state.Session{userA, userB}
  137. },
  138. },
  139. }
  140. for _, tc := range tt {
  141. t.Run(tc.name, func(t *testing.T) {
  142. request := httptest.NewRequest(http.MethodGet, "/session", nil)
  143. responseRecorder := httptest.NewRecorder()
  144. sessionRetriever := newMockSessionRetriever(t)
  145. sessions := tc.createSessions()
  146. sessionRetriever.EXPECT().
  147. AllSessions().
  148. Return(sessions)
  149. getSessionHandler(responseRecorder, request, sessionRetriever, nowFn)
  150. if responseRecorder.Code != tc.statusCode {
  151. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  152. }
  153. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  154. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  155. }
  156. })
  157. }
  158. }
  159. func TestSessionHandlerScreenname_GET(t *testing.T) {
  160. // Fixed time for testing: 2024-01-01 12:00:00 UTC
  161. fixedNow := time.Date(2024, 1, 1, 12, 0, 0, 0, time.UTC)
  162. nowFn := func() time.Time { return fixedNow }
  163. tt := []struct {
  164. name string
  165. requestScreenName state.IdentScreenName
  166. want string
  167. statusCode int
  168. createSession func() *state.Session
  169. }{
  170. {
  171. name: "no session for screenname",
  172. requestScreenName: state.NewIdentScreenName("userA"),
  173. want: `session not found`,
  174. statusCode: http.StatusNotFound,
  175. createSession: func() *state.Session {
  176. return nil
  177. },
  178. },
  179. {
  180. name: "active session found for screenname",
  181. requestScreenName: state.NewIdentScreenName("userA"),
  182. want: `{"count":1,"sessions":[{"id":"usera","screen_name":"userA","online_seconds":150,"is_away":false,"away_message":"","idle_seconds":0,"is_invisible":false,"is_icq":false,"instance_count":1,"instances":[{"num":1,"idle_seconds":0,"is_away":false,"away_message":"","is_invisible":false,"remote_addr":"1.2.3.4","remote_port":1234}]}]}`,
  183. statusCode: http.StatusOK,
  184. createSession: func() *state.Session {
  185. sess := state.NewSession()
  186. sess.SetIdentScreenName(state.NewIdentScreenName("userA"))
  187. sess.SetDisplayScreenName(state.DisplayScreenName("userA"))
  188. sess.SetUIN(0)
  189. sess.SetNowFn(nowFn)
  190. sess.SetSignonTime(fixedNow.Add(-150 * time.Second))
  191. instance := sess.AddInstance()
  192. instance.SetSignonComplete()
  193. ip, _ := netip.ParseAddrPort("1.2.3.4:1234")
  194. instance.SetRemoteAddr(&ip)
  195. return sess
  196. },
  197. },
  198. }
  199. for _, tc := range tt {
  200. t.Run(tc.name, func(t *testing.T) {
  201. request := httptest.NewRequest(http.MethodGet, "/session/"+tc.requestScreenName.String(), nil)
  202. request.SetPathValue("screenname", tc.requestScreenName.String())
  203. responseRecorder := httptest.NewRecorder()
  204. sessionRetriever := newMockSessionRetriever(t)
  205. session := tc.createSession()
  206. sessionRetriever.EXPECT().
  207. RetrieveSession(tc.requestScreenName).
  208. Return(session)
  209. getSessionHandler(responseRecorder, request, sessionRetriever, nowFn)
  210. if responseRecorder.Code != tc.statusCode {
  211. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  212. }
  213. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  214. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  215. }
  216. })
  217. }
  218. }
  219. func TestSessionHandlerScreenname_DELETE(t *testing.T) {
  220. fnNewSess := func(screenName string) *state.Session {
  221. sess := state.NewSession()
  222. sess.SetIdentScreenName(state.NewIdentScreenName(screenName))
  223. sess.SetDisplayScreenName(state.DisplayScreenName(screenName))
  224. instance := sess.AddInstance()
  225. instance.SetSignonComplete()
  226. ip, _ := netip.ParseAddrPort("1.2.3.4:1234")
  227. instance.SetRemoteAddr(&ip)
  228. return sess
  229. }
  230. tt := []struct {
  231. name string
  232. session *state.SessionInstance
  233. requestScreenName state.IdentScreenName
  234. statusCode int
  235. mockParams mockParams
  236. }{
  237. {
  238. name: "delete an active session",
  239. requestScreenName: state.NewIdentScreenName("userA"),
  240. statusCode: http.StatusNoContent,
  241. mockParams: mockParams{
  242. sessionRetrieverParams: sessionRetrieverParams{
  243. retrieveSessionByNameParams: retrieveSessionByNameParams{
  244. {
  245. screenName: state.NewIdentScreenName("userA"),
  246. result: fnNewSess("userA"),
  247. },
  248. },
  249. },
  250. },
  251. },
  252. {
  253. name: "delete a non-existent session",
  254. requestScreenName: state.NewIdentScreenName("userA"),
  255. statusCode: http.StatusNotFound,
  256. mockParams: mockParams{
  257. sessionRetrieverParams: sessionRetrieverParams{
  258. retrieveSessionByNameParams: retrieveSessionByNameParams{
  259. {
  260. screenName: state.NewIdentScreenName("userA"),
  261. result: nil,
  262. },
  263. },
  264. },
  265. },
  266. },
  267. }
  268. for _, tc := range tt {
  269. t.Run(tc.name, func(t *testing.T) {
  270. request := httptest.NewRequest(http.MethodDelete, "/session/"+tc.requestScreenName.String(), nil)
  271. request.SetPathValue("screenname", tc.requestScreenName.String())
  272. responseRecorder := httptest.NewRecorder()
  273. sessionRetriever := newMockSessionRetriever(t)
  274. for _, params := range tc.mockParams.retrieveSessionByNameParams {
  275. sessionRetriever.EXPECT().
  276. RetrieveSession(params.screenName).
  277. Return(params.result)
  278. }
  279. deleteSessionHandler(responseRecorder, request, sessionRetriever)
  280. if responseRecorder.Code != tc.statusCode {
  281. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  282. }
  283. })
  284. }
  285. }
  286. func TestUserAccountHandler_GET(t *testing.T) {
  287. tt := []struct {
  288. name string
  289. requestScreenName state.IdentScreenName
  290. want string
  291. statusCode int
  292. mockParams mockParams
  293. }{
  294. {
  295. name: "invalid account",
  296. requestScreenName: state.NewIdentScreenName("userA"),
  297. want: `user not found`,
  298. statusCode: http.StatusNotFound,
  299. mockParams: mockParams{
  300. userManagerParams: userManagerParams{
  301. getUserParams: getUserParams{
  302. {
  303. screenName: state.NewIdentScreenName("userA"),
  304. result: nil,
  305. },
  306. },
  307. },
  308. },
  309. },
  310. {
  311. name: "valid aim account",
  312. requestScreenName: state.NewIdentScreenName("userA"),
  313. want: `{"id":"usera","screen_name":"userA","profile":"My Profile Text","email_address":"\u003cuserA@aol.com\u003e","reg_status":2,"confirmed":true,"is_icq":false,"suspended_status":"","is_bot":false}`,
  314. statusCode: http.StatusOK,
  315. mockParams: mockParams{
  316. userManagerParams: userManagerParams{
  317. getUserParams: getUserParams{
  318. {
  319. screenName: state.NewIdentScreenName("userA"),
  320. result: &state.User{
  321. DisplayScreenName: "userA",
  322. IdentScreenName: state.NewIdentScreenName("userA"),
  323. SuspendedStatus: 0x0,
  324. },
  325. },
  326. },
  327. },
  328. accountManagerParams: accountManagerParams{
  329. EmailAddressParams: EmailAddressParams{
  330. {
  331. screenName: state.NewIdentScreenName("userA"),
  332. result: &mail.Address{
  333. Address: "userA@aol.com",
  334. },
  335. },
  336. },
  337. RegStatusParams: RegStatusParams{
  338. {
  339. screenName: state.NewIdentScreenName("userA"),
  340. result: uint16(0x02),
  341. },
  342. },
  343. ConfirmStatusParams: ConfirmStatusParams{
  344. {
  345. screenName: state.NewIdentScreenName("userA"),
  346. result: true,
  347. },
  348. },
  349. },
  350. profileRetrieverParams: profileRetrieverParams{
  351. retrieveProfileParams: retrieveProfileParams{
  352. {
  353. screenName: state.NewIdentScreenName("userA"),
  354. result: state.UserProfile{ProfileText: "My Profile Text"},
  355. },
  356. },
  357. },
  358. },
  359. },
  360. {
  361. name: "valid aim bot account",
  362. requestScreenName: state.NewIdentScreenName("userA"),
  363. want: `{"id":"usera","screen_name":"userA","profile":"My Profile Text","email_address":"\u003cuserA@aol.com\u003e","reg_status":2,"confirmed":true,"is_icq":false,"suspended_status":"","is_bot":true}`,
  364. statusCode: http.StatusOK,
  365. mockParams: mockParams{
  366. userManagerParams: userManagerParams{
  367. getUserParams: getUserParams{
  368. {
  369. screenName: state.NewIdentScreenName("userA"),
  370. result: &state.User{
  371. DisplayScreenName: "userA",
  372. IdentScreenName: state.NewIdentScreenName("userA"),
  373. SuspendedStatus: 0x0,
  374. IsBot: true,
  375. },
  376. },
  377. },
  378. },
  379. accountManagerParams: accountManagerParams{
  380. EmailAddressParams: EmailAddressParams{
  381. {
  382. screenName: state.NewIdentScreenName("userA"),
  383. result: &mail.Address{
  384. Address: "userA@aol.com",
  385. },
  386. },
  387. },
  388. RegStatusParams: RegStatusParams{
  389. {
  390. screenName: state.NewIdentScreenName("userA"),
  391. result: uint16(0x02),
  392. },
  393. },
  394. ConfirmStatusParams: ConfirmStatusParams{
  395. {
  396. screenName: state.NewIdentScreenName("userA"),
  397. result: true,
  398. },
  399. },
  400. },
  401. profileRetrieverParams: profileRetrieverParams{
  402. retrieveProfileParams: retrieveProfileParams{
  403. {
  404. screenName: state.NewIdentScreenName("userA"),
  405. result: state.UserProfile{ProfileText: "My Profile Text"},
  406. },
  407. },
  408. },
  409. },
  410. },
  411. {
  412. name: "suspended aim account",
  413. requestScreenName: state.NewIdentScreenName("userB"),
  414. want: `{"id":"userb","screen_name":"userB","profile":"My Profile Text","email_address":"\u003cuserB@aol.com\u003e","reg_status":2,"confirmed":true,"is_icq":false,"suspended_status":"suspended","is_bot":false}`,
  415. statusCode: http.StatusOK,
  416. mockParams: mockParams{
  417. userManagerParams: userManagerParams{
  418. getUserParams: getUserParams{
  419. {
  420. screenName: state.NewIdentScreenName("userB"),
  421. result: &state.User{
  422. DisplayScreenName: "userB",
  423. IdentScreenName: state.NewIdentScreenName("userB"),
  424. SuspendedStatus: wire.LoginErrSuspendedAccount,
  425. },
  426. },
  427. },
  428. },
  429. accountManagerParams: accountManagerParams{
  430. EmailAddressParams: EmailAddressParams{
  431. {
  432. screenName: state.NewIdentScreenName("userB"),
  433. result: &mail.Address{
  434. Address: "userB@aol.com",
  435. },
  436. },
  437. },
  438. RegStatusParams: RegStatusParams{
  439. {
  440. screenName: state.NewIdentScreenName("userB"),
  441. result: uint16(0x02),
  442. },
  443. },
  444. ConfirmStatusParams: ConfirmStatusParams{
  445. {
  446. screenName: state.NewIdentScreenName("userB"),
  447. result: true,
  448. },
  449. },
  450. },
  451. profileRetrieverParams: profileRetrieverParams{
  452. retrieveProfileParams: retrieveProfileParams{
  453. {
  454. screenName: state.NewIdentScreenName("userB"),
  455. result: state.UserProfile{ProfileText: "My Profile Text"},
  456. },
  457. },
  458. },
  459. },
  460. },
  461. }
  462. for _, tc := range tt {
  463. t.Run(tc.name, func(t *testing.T) {
  464. request := httptest.NewRequest(http.MethodGet, "/user/"+tc.requestScreenName.String()+"/account", nil)
  465. request.SetPathValue("screenname", tc.requestScreenName.String())
  466. responseRecorder := httptest.NewRecorder()
  467. userManager := newMockUserManager(t)
  468. for _, params := range tc.mockParams.getUserParams {
  469. userManager.EXPECT().
  470. User(matchContext(), params.screenName).
  471. Return(params.result, params.err)
  472. }
  473. accountManager := newMockAccountManager(t)
  474. for _, params := range tc.mockParams.EmailAddressParams {
  475. accountManager.EXPECT().
  476. EmailAddress(matchContext(), params.screenName).
  477. Return(params.result, params.err)
  478. }
  479. for _, params := range tc.mockParams.RegStatusParams {
  480. accountManager.EXPECT().
  481. RegStatus(matchContext(), params.screenName).
  482. Return(params.result, params.err)
  483. }
  484. for _, params := range tc.mockParams.ConfirmStatusParams {
  485. accountManager.EXPECT().
  486. ConfirmStatus(matchContext(), params.screenName).
  487. Return(params.result, params.err)
  488. }
  489. profileRetriever := newMockProfileRetriever(t)
  490. for _, params := range tc.mockParams.retrieveProfileParams {
  491. profileRetriever.EXPECT().
  492. Profile(matchContext(), params.screenName).
  493. Return(params.result, params.err)
  494. }
  495. getUserAccountHandler(responseRecorder, request, userManager, accountManager, profileRetriever, slog.Default())
  496. if responseRecorder.Code != tc.statusCode {
  497. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  498. }
  499. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  500. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  501. }
  502. })
  503. }
  504. }
  505. func TestUserAccountHandler_PATCH(t *testing.T) {
  506. tt := []struct {
  507. name string
  508. requestScreenName state.IdentScreenName
  509. want string
  510. body string
  511. statusCode int
  512. mockParams mockParams
  513. }{
  514. {
  515. name: "suspending a non-existent account",
  516. requestScreenName: state.NewIdentScreenName("userA"),
  517. body: `{"suspended_status":"suspended"}`,
  518. want: `user not found`,
  519. statusCode: http.StatusNotFound,
  520. mockParams: mockParams{
  521. userManagerParams: userManagerParams{
  522. getUserParams: getUserParams{
  523. {
  524. screenName: state.NewIdentScreenName("userA"),
  525. result: nil,
  526. },
  527. },
  528. },
  529. },
  530. },
  531. {
  532. name: "patching with invalid suspended_status value",
  533. requestScreenName: state.NewIdentScreenName("userA"),
  534. body: `{"suspended_status":"thisisinvalid"}`,
  535. want: `{"message":"suspended_status must be empty str or one of deleted,expired,suspended,suspended_age"}`,
  536. statusCode: http.StatusBadRequest,
  537. mockParams: mockParams{
  538. userManagerParams: userManagerParams{
  539. getUserParams: getUserParams{
  540. {
  541. screenName: state.NewIdentScreenName("userA"),
  542. result: &state.User{},
  543. },
  544. },
  545. },
  546. },
  547. },
  548. {
  549. name: "suspending an active aim account",
  550. requestScreenName: state.NewIdentScreenName("userA"),
  551. statusCode: http.StatusNoContent,
  552. body: `{"suspended_status":"suspended"}`,
  553. mockParams: mockParams{
  554. userManagerParams: userManagerParams{
  555. getUserParams: getUserParams{
  556. {
  557. screenName: state.NewIdentScreenName("userA"),
  558. result: &state.User{
  559. DisplayScreenName: "userA",
  560. IdentScreenName: state.NewIdentScreenName("userA"),
  561. SuspendedStatus: 0x0,
  562. },
  563. },
  564. },
  565. },
  566. accountManagerParams: accountManagerParams{
  567. updateSuspendedStatusParams: updateSuspendedStatusParams{
  568. {
  569. suspendedStatus: wire.LoginErrSuspendedAccount,
  570. screenName: state.NewIdentScreenName("userA"),
  571. err: nil,
  572. },
  573. },
  574. },
  575. },
  576. },
  577. {
  578. name: "unsuspending a suspended aim account",
  579. requestScreenName: state.NewIdentScreenName("userA"),
  580. statusCode: http.StatusNoContent,
  581. body: `{"suspended_status":""}`,
  582. mockParams: mockParams{
  583. userManagerParams: userManagerParams{
  584. getUserParams: getUserParams{
  585. {
  586. screenName: state.NewIdentScreenName("userA"),
  587. result: &state.User{
  588. DisplayScreenName: "userA",
  589. IdentScreenName: state.NewIdentScreenName("userA"),
  590. SuspendedStatus: wire.LoginErrSuspendedAccount,
  591. },
  592. },
  593. },
  594. },
  595. accountManagerParams: accountManagerParams{
  596. updateSuspendedStatusParams: updateSuspendedStatusParams{
  597. {
  598. suspendedStatus: 0x0,
  599. screenName: state.NewIdentScreenName("userA"),
  600. err: nil,
  601. },
  602. },
  603. },
  604. },
  605. },
  606. {
  607. name: "suspending an already suspended aim account",
  608. requestScreenName: state.NewIdentScreenName("userA"),
  609. statusCode: http.StatusNotModified,
  610. body: `{"suspended_status":"suspended"}`,
  611. mockParams: mockParams{
  612. userManagerParams: userManagerParams{
  613. getUserParams: getUserParams{
  614. {
  615. screenName: state.NewIdentScreenName("userA"),
  616. result: &state.User{
  617. DisplayScreenName: "userA",
  618. IdentScreenName: state.NewIdentScreenName("userA"),
  619. SuspendedStatus: wire.LoginErrSuspendedAccount,
  620. },
  621. },
  622. },
  623. },
  624. },
  625. },
  626. {
  627. name: "setting bot flag (before: false, after: true)",
  628. requestScreenName: state.NewIdentScreenName("userA"),
  629. statusCode: http.StatusNoContent,
  630. body: `{"is_bot":true}`,
  631. mockParams: mockParams{
  632. userManagerParams: userManagerParams{
  633. getUserParams: getUserParams{
  634. {
  635. screenName: state.NewIdentScreenName("userA"),
  636. result: &state.User{
  637. DisplayScreenName: "userA",
  638. IdentScreenName: state.NewIdentScreenName("userA"),
  639. SuspendedStatus: 0x0,
  640. IsBot: false,
  641. },
  642. },
  643. },
  644. },
  645. accountManagerParams: accountManagerParams{
  646. setBotStatusParams: setBotStatusParams{
  647. {
  648. isBot: true,
  649. screenName: state.NewIdentScreenName("userA"),
  650. err: nil,
  651. },
  652. },
  653. },
  654. },
  655. },
  656. {
  657. name: "setting bot flag (before: true, after: false)",
  658. requestScreenName: state.NewIdentScreenName("userA"),
  659. statusCode: http.StatusNoContent,
  660. body: `{"is_bot":false}`,
  661. mockParams: mockParams{
  662. userManagerParams: userManagerParams{
  663. getUserParams: getUserParams{
  664. {
  665. screenName: state.NewIdentScreenName("userA"),
  666. result: &state.User{
  667. DisplayScreenName: "userA",
  668. IdentScreenName: state.NewIdentScreenName("userA"),
  669. SuspendedStatus: 0x0,
  670. IsBot: true,
  671. },
  672. },
  673. },
  674. },
  675. accountManagerParams: accountManagerParams{
  676. setBotStatusParams: setBotStatusParams{
  677. {
  678. isBot: false,
  679. screenName: state.NewIdentScreenName("userA"),
  680. err: nil,
  681. },
  682. },
  683. },
  684. },
  685. },
  686. {
  687. name: "setting bot flag (before: true, after: true)",
  688. requestScreenName: state.NewIdentScreenName("userA"),
  689. statusCode: http.StatusNotModified,
  690. body: `{"is_bot":true}`,
  691. mockParams: mockParams{
  692. userManagerParams: userManagerParams{
  693. getUserParams: getUserParams{
  694. {
  695. screenName: state.NewIdentScreenName("userA"),
  696. result: &state.User{
  697. DisplayScreenName: "userA",
  698. IdentScreenName: state.NewIdentScreenName("userA"),
  699. SuspendedStatus: 0x0,
  700. IsBot: true,
  701. },
  702. },
  703. },
  704. },
  705. },
  706. },
  707. }
  708. for _, tc := range tt {
  709. t.Run(tc.name, func(t *testing.T) {
  710. request := httptest.NewRequest(http.MethodPatch, "/user/"+tc.requestScreenName.String()+"/account", strings.NewReader(tc.body))
  711. request.SetPathValue("screenname", tc.requestScreenName.String())
  712. responseRecorder := httptest.NewRecorder()
  713. userManager := newMockUserManager(t)
  714. for _, params := range tc.mockParams.getUserParams {
  715. userManager.EXPECT().
  716. User(matchContext(), params.screenName).
  717. Return(params.result, params.err)
  718. }
  719. accountManager := newMockAccountManager(t)
  720. for _, params := range tc.mockParams.updateSuspendedStatusParams {
  721. accountManager.EXPECT().
  722. UpdateSuspendedStatus(matchContext(), params.suspendedStatus, params.screenName).
  723. Return(params.err)
  724. }
  725. for _, params := range tc.mockParams.setBotStatusParams {
  726. accountManager.EXPECT().
  727. SetBotStatus(matchContext(), params.isBot, params.screenName).
  728. Return(params.err)
  729. }
  730. patchUserAccountHandler(responseRecorder, request, userManager, accountManager, slog.Default())
  731. if responseRecorder.Code != tc.statusCode {
  732. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  733. }
  734. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  735. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  736. }
  737. })
  738. }
  739. }
  740. func TestUserBuddyIconHandler_GET(t *testing.T) {
  741. sampleGIF := []byte{
  742. 0x47, 0x49, 0x46, 0x38, 0x39, 0x61, 0x32, 0x00, 0x32, 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
  743. 0x00, 0x00, 0x00, 0x21, 0xf9, 0x04, 0x01, 0x00, 0x00, 0x00, 0x00, 0x2c, 0x00, 0x00, 0x00, 0x00,
  744. 0x32, 0x00, 0x32, 0x00, 0x00, 0x02, 0x02, 0x44, 0x01, 0x00, 0x3b}
  745. sampleJPG := []byte{0xFF, 0xD8, 0xFF, 0x43, 0x13, 0x37}
  746. tt := []struct {
  747. name string
  748. requestScreenName state.IdentScreenName
  749. want string
  750. statusCode int
  751. contentType string
  752. mockParams mockParams
  753. }{
  754. {
  755. name: "invalid account",
  756. requestScreenName: state.NewIdentScreenName("userA"),
  757. want: `user not found`,
  758. statusCode: http.StatusNotFound,
  759. contentType: "text/plain; charset=utf-8",
  760. mockParams: mockParams{
  761. userManagerParams: userManagerParams{
  762. getUserParams: getUserParams{
  763. {
  764. screenName: state.NewIdentScreenName("userA"),
  765. result: nil,
  766. },
  767. },
  768. },
  769. },
  770. },
  771. {
  772. name: "account with gif buddy icon",
  773. requestScreenName: state.NewIdentScreenName("userA"),
  774. want: string(sampleGIF),
  775. statusCode: http.StatusOK,
  776. contentType: "image/gif",
  777. mockParams: mockParams{
  778. userManagerParams: userManagerParams{
  779. getUserParams: getUserParams{
  780. {
  781. screenName: state.NewIdentScreenName("userA"),
  782. result: &state.User{
  783. DisplayScreenName: "userA",
  784. IdentScreenName: state.NewIdentScreenName("userA"),
  785. },
  786. },
  787. },
  788. },
  789. feedBagRetrieverParams: feedBagRetrieverParams{
  790. buddyIconMetadataParams: buddyIconMetadataParams{
  791. {
  792. screenName: state.NewIdentScreenName("userA"),
  793. result: &wire.BARTID{
  794. Type: wire.BARTTypesBuddyIcon,
  795. BARTInfo: wire.BARTInfo{
  796. Flags: 0x00,
  797. Hash: []byte{'t', 'h', 'e', 'h', 'a', 's', 'h'},
  798. },
  799. },
  800. },
  801. },
  802. },
  803. bartAssetManagerParams: bartAssetManagerParams{
  804. bartItemParams: bartItemParams{
  805. {
  806. hash: []byte{'t', 'h', 'e', 'h', 'a', 's', 'h'},
  807. result: sampleGIF,
  808. },
  809. },
  810. },
  811. },
  812. },
  813. {
  814. name: "account with jpg buddy icon",
  815. requestScreenName: state.NewIdentScreenName("userA"),
  816. want: string(sampleJPG),
  817. statusCode: http.StatusOK,
  818. contentType: "image/jpeg",
  819. mockParams: mockParams{
  820. userManagerParams: userManagerParams{
  821. getUserParams: getUserParams{
  822. {
  823. screenName: state.NewIdentScreenName("userA"),
  824. result: &state.User{
  825. DisplayScreenName: "userA",
  826. IdentScreenName: state.NewIdentScreenName("userA"),
  827. },
  828. },
  829. },
  830. },
  831. feedBagRetrieverParams: feedBagRetrieverParams{
  832. buddyIconMetadataParams: buddyIconMetadataParams{
  833. {
  834. screenName: state.NewIdentScreenName("userA"),
  835. result: &wire.BARTID{
  836. Type: wire.BARTTypesBuddyIcon,
  837. BARTInfo: wire.BARTInfo{
  838. Flags: 0x00,
  839. Hash: []byte{'t', 'h', 'e', 'h', 'a', 's', 'h'},
  840. },
  841. },
  842. },
  843. },
  844. },
  845. bartAssetManagerParams: bartAssetManagerParams{
  846. bartItemParams: bartItemParams{
  847. {
  848. hash: []byte{'t', 'h', 'e', 'h', 'a', 's', 'h'},
  849. result: sampleJPG,
  850. },
  851. },
  852. },
  853. },
  854. },
  855. {
  856. name: "account with unknown format buddy icon",
  857. requestScreenName: state.NewIdentScreenName("userA"),
  858. want: string([]byte{0x13, 0x37, 0x13, 0x37, 0x13, 0x37}),
  859. statusCode: http.StatusOK,
  860. contentType: "application/octet-stream",
  861. mockParams: mockParams{
  862. userManagerParams: userManagerParams{
  863. getUserParams: getUserParams{
  864. {
  865. screenName: state.NewIdentScreenName("userA"),
  866. result: &state.User{
  867. DisplayScreenName: "userA",
  868. IdentScreenName: state.NewIdentScreenName("userA"),
  869. },
  870. },
  871. },
  872. },
  873. feedBagRetrieverParams: feedBagRetrieverParams{
  874. buddyIconMetadataParams: buddyIconMetadataParams{
  875. {
  876. screenName: state.NewIdentScreenName("userA"),
  877. result: &wire.BARTID{
  878. Type: wire.BARTTypesBuddyIcon,
  879. BARTInfo: wire.BARTInfo{
  880. Flags: 0x00,
  881. Hash: []byte{'t', 'h', 'e', 'h', 'a', 's', 'h'},
  882. },
  883. },
  884. },
  885. },
  886. },
  887. bartAssetManagerParams: bartAssetManagerParams{
  888. bartItemParams: bartItemParams{
  889. {
  890. hash: []byte{'t', 'h', 'e', 'h', 'a', 's', 'h'},
  891. result: []byte{0x13, 0x37, 0x13, 0x37, 0x13, 0x37},
  892. },
  893. },
  894. },
  895. },
  896. },
  897. {
  898. name: "account with cleared buddy icon",
  899. requestScreenName: state.NewIdentScreenName("userA"),
  900. want: "icon not found",
  901. statusCode: http.StatusNotFound,
  902. contentType: "text/plain; charset=utf-8",
  903. mockParams: mockParams{
  904. userManagerParams: userManagerParams{
  905. getUserParams: getUserParams{
  906. {
  907. screenName: state.NewIdentScreenName("userA"),
  908. result: &state.User{
  909. DisplayScreenName: "userA",
  910. IdentScreenName: state.NewIdentScreenName("userA"),
  911. },
  912. },
  913. },
  914. },
  915. feedBagRetrieverParams: feedBagRetrieverParams{
  916. buddyIconMetadataParams: buddyIconMetadataParams{
  917. {
  918. screenName: state.NewIdentScreenName("userA"),
  919. result: &wire.BARTID{
  920. Type: wire.BARTTypesBuddyIcon,
  921. BARTInfo: wire.BARTInfo{
  922. Flags: 0x00,
  923. Hash: wire.GetClearIconHash(),
  924. },
  925. },
  926. },
  927. },
  928. },
  929. },
  930. },
  931. {
  932. name: "account with no buddy icon",
  933. requestScreenName: state.NewIdentScreenName("userA"),
  934. want: "icon not found",
  935. statusCode: http.StatusNotFound,
  936. contentType: "text/plain; charset=utf-8",
  937. mockParams: mockParams{
  938. userManagerParams: userManagerParams{
  939. getUserParams: getUserParams{
  940. {
  941. screenName: state.NewIdentScreenName("userA"),
  942. result: &state.User{
  943. DisplayScreenName: "userA",
  944. IdentScreenName: state.NewIdentScreenName("userA"),
  945. },
  946. },
  947. },
  948. },
  949. feedBagRetrieverParams: feedBagRetrieverParams{
  950. buddyIconMetadataParams: buddyIconMetadataParams{
  951. {
  952. screenName: state.NewIdentScreenName("userA"),
  953. result: nil,
  954. },
  955. },
  956. },
  957. },
  958. },
  959. }
  960. for _, tc := range tt {
  961. t.Run(tc.name, func(t *testing.T) {
  962. request := httptest.NewRequest(http.MethodGet, "/user/"+tc.requestScreenName.String()+"/icon", nil)
  963. request.SetPathValue("screenname", tc.requestScreenName.String())
  964. responseRecorder := httptest.NewRecorder()
  965. userManager := newMockUserManager(t)
  966. for _, params := range tc.mockParams.getUserParams {
  967. userManager.EXPECT().
  968. User(matchContext(), params.screenName).
  969. Return(params.result, params.err)
  970. }
  971. feedbagRetriever := newMockFeedBagRetriever(t)
  972. for _, params := range tc.mockParams.buddyIconMetadataParams {
  973. feedbagRetriever.EXPECT().
  974. BuddyIconMetadata(matchContext(), params.screenName).
  975. Return(params.result, params.err)
  976. }
  977. bartRetriever := newMockBARTAssetManager(t)
  978. for _, params := range tc.mockParams.bartItemParams {
  979. bartRetriever.EXPECT().
  980. BARTItem(matchContext(), params.hash).
  981. Return(params.result, params.err)
  982. }
  983. getUserBuddyIconHandler(responseRecorder, request, userManager, feedbagRetriever, bartRetriever, slog.Default())
  984. if responseRecorder.Code != tc.statusCode {
  985. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  986. }
  987. contentType := responseRecorder.Header().Get("Content-Type")
  988. if contentType != tc.contentType {
  989. t.Errorf("Want content type '%s', got '%s'", tc.contentType, contentType)
  990. }
  991. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  992. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  993. }
  994. })
  995. }
  996. }
  997. func TestUserHandler_GET(t *testing.T) {
  998. tt := []struct {
  999. name string
  1000. want string
  1001. statusCode int
  1002. mockParams mockParams
  1003. }{
  1004. {
  1005. name: "empty user store",
  1006. want: `[]`,
  1007. statusCode: http.StatusOK,
  1008. mockParams: mockParams{
  1009. userManagerParams: userManagerParams{
  1010. allUsersParams: allUsersParams{
  1011. {
  1012. result: []state.User{},
  1013. },
  1014. },
  1015. },
  1016. },
  1017. },
  1018. {
  1019. name: "user store containing 3 users",
  1020. want: `[{"id":"usera","screen_name":"userA","is_icq":false,"suspended_status":"","is_bot":false},{"id":"userb","screen_name":"userB","is_icq":false,"suspended_status":"","is_bot":true},{"id":"100003","screen_name":"100003","is_icq":true,"suspended_status":"","is_bot":false}]`,
  1021. statusCode: http.StatusOK,
  1022. mockParams: mockParams{
  1023. userManagerParams: userManagerParams{
  1024. allUsersParams: allUsersParams{
  1025. {
  1026. result: []state.User{
  1027. {
  1028. DisplayScreenName: "userA",
  1029. IdentScreenName: state.NewIdentScreenName("userA"),
  1030. },
  1031. {
  1032. DisplayScreenName: "userB",
  1033. IdentScreenName: state.NewIdentScreenName("userB"),
  1034. IsBot: true,
  1035. },
  1036. {
  1037. DisplayScreenName: "100003",
  1038. IdentScreenName: state.NewIdentScreenName("100003"),
  1039. IsICQ: true,
  1040. },
  1041. },
  1042. },
  1043. },
  1044. },
  1045. },
  1046. },
  1047. {
  1048. name: "user handler error",
  1049. want: `internal server error`,
  1050. statusCode: http.StatusInternalServerError,
  1051. mockParams: mockParams{
  1052. userManagerParams: userManagerParams{
  1053. allUsersParams: allUsersParams{
  1054. {
  1055. result: []state.User{},
  1056. err: io.EOF,
  1057. },
  1058. },
  1059. },
  1060. },
  1061. },
  1062. }
  1063. for _, tc := range tt {
  1064. t.Run(tc.name, func(t *testing.T) {
  1065. request := httptest.NewRequest(http.MethodGet, "/user", nil)
  1066. responseRecorder := httptest.NewRecorder()
  1067. userManager := newMockUserManager(t)
  1068. for _, params := range tc.mockParams.allUsersParams {
  1069. userManager.EXPECT().
  1070. AllUsers(matchContext()).
  1071. Return(params.result, params.err)
  1072. }
  1073. getUserHandler(responseRecorder, request, userManager, slog.Default())
  1074. if responseRecorder.Code != tc.statusCode {
  1075. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1076. }
  1077. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1078. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  1079. }
  1080. })
  1081. }
  1082. }
  1083. func TestUserHandler_POST(t *testing.T) {
  1084. tt := []struct {
  1085. name string
  1086. body string
  1087. want string
  1088. statusCode int
  1089. createAccount state.CreateAccountFunc
  1090. }{
  1091. {
  1092. name: "with valid AIM user",
  1093. body: `{"screen_name":"userA", "password":"thepassword"}`,
  1094. want: `User account created successfully.`,
  1095. statusCode: http.StatusCreated,
  1096. createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
  1097. assert.Equal(t, state.DisplayScreenName("userA"), screenName)
  1098. assert.Equal(t, "thepassword", password)
  1099. return nil
  1100. },
  1101. },
  1102. {
  1103. name: "with valid ICQ user",
  1104. body: `{"screen_name":"100003", "password":"thepass"}`,
  1105. want: `User account created successfully.`,
  1106. statusCode: http.StatusCreated,
  1107. createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
  1108. assert.Equal(t, state.DisplayScreenName("100003"), screenName)
  1109. assert.Equal(t, "thepass", password)
  1110. return nil
  1111. },
  1112. },
  1113. {
  1114. name: "with malformed body",
  1115. body: `{"screen_name":"userA", "password":"thepassword"`, // missing closing }
  1116. want: `malformed input`,
  1117. statusCode: http.StatusBadRequest,
  1118. },
  1119. {
  1120. name: "user handler error",
  1121. body: `{"screen_name":"userA", "password":"thepassword"}`,
  1122. want: `internal server error`,
  1123. statusCode: http.StatusInternalServerError,
  1124. createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
  1125. assert.Equal(t, state.DisplayScreenName("userA"), screenName)
  1126. assert.Equal(t, "thepassword", password)
  1127. return io.EOF
  1128. },
  1129. },
  1130. {
  1131. name: "duplicate user",
  1132. body: `{"screen_name":"userA", "password":"thepassword"}`,
  1133. want: `user already exists`,
  1134. statusCode: http.StatusConflict,
  1135. createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
  1136. assert.Equal(t, state.DisplayScreenName("userA"), screenName)
  1137. assert.Equal(t, "thepassword", password)
  1138. return state.ErrDupUser
  1139. },
  1140. },
  1141. {
  1142. name: "invalid AIM screen name",
  1143. body: `{"screen_name":"a", "password":"thepassword"}`,
  1144. want: `invalid screen name: screen name must be between 3 and 16 characters`,
  1145. statusCode: http.StatusBadRequest,
  1146. createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
  1147. assert.Equal(t, state.DisplayScreenName("a"), screenName)
  1148. assert.Equal(t, "thepassword", password)
  1149. return state.ErrAIMHandleLength
  1150. },
  1151. },
  1152. {
  1153. name: "invalid AIM password",
  1154. body: `{"screen_name":"userA", "password":"1"}`,
  1155. want: `invalid password: invalid password length: password length must be between 4-16 characters`,
  1156. statusCode: http.StatusBadRequest,
  1157. createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
  1158. assert.Equal(t, state.DisplayScreenName("userA"), screenName)
  1159. assert.Equal(t, "1", password)
  1160. return fmt.Errorf("%w: password length must be between 4-16 characters", state.ErrPasswordInvalid)
  1161. },
  1162. },
  1163. {
  1164. name: "invalid ICQ UIN",
  1165. body: `{"screen_name":"1000", "password":"thepass"}`,
  1166. want: `invalid uin: uin must be a number in the range 10000-2147483646`,
  1167. statusCode: http.StatusBadRequest,
  1168. createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
  1169. assert.Equal(t, state.DisplayScreenName("1000"), screenName)
  1170. assert.Equal(t, "thepass", password)
  1171. return state.ErrICQUINInvalidFormat
  1172. },
  1173. },
  1174. {
  1175. name: "invalid ICQ password",
  1176. body: `{"screen_name":"100003", "password":"thelongpassword"}`,
  1177. want: `invalid password: invalid password length: password must be between 6-8 characters`,
  1178. statusCode: http.StatusBadRequest,
  1179. createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
  1180. assert.Equal(t, state.DisplayScreenName("100003"), screenName)
  1181. assert.Equal(t, "thelongpassword", password)
  1182. return fmt.Errorf("%w: password must be between 6-8 characters", state.ErrPasswordInvalid)
  1183. },
  1184. },
  1185. }
  1186. for _, tc := range tt {
  1187. t.Run(tc.name, func(t *testing.T) {
  1188. request := httptest.NewRequest(http.MethodPost, "/user", strings.NewReader(tc.body))
  1189. responseRecorder := httptest.NewRecorder()
  1190. postUserHandler(responseRecorder, request, tc.createAccount, slog.Default())
  1191. if responseRecorder.Code != tc.statusCode {
  1192. t.Errorf("want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1193. }
  1194. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1195. t.Errorf("want '%s', got '%s'", tc.want, responseRecorder.Body)
  1196. }
  1197. })
  1198. }
  1199. }
  1200. func TestUserHandler_DELETE(t *testing.T) {
  1201. tt := []struct {
  1202. name string
  1203. body string
  1204. want string
  1205. statusCode int
  1206. mockParams mockParams
  1207. }{
  1208. {
  1209. name: "with valid user",
  1210. body: `{"screen_name":"userA"}`,
  1211. want: `User account successfully deleted.`,
  1212. statusCode: http.StatusNoContent,
  1213. mockParams: mockParams{
  1214. userManagerParams: userManagerParams{
  1215. deleteUserParams: deleteUserParams{
  1216. {
  1217. screenName: state.NewIdentScreenName("userA"),
  1218. },
  1219. },
  1220. },
  1221. },
  1222. },
  1223. {
  1224. name: "with non-existent user",
  1225. body: `{"screen_name":"userA"}`,
  1226. want: `user does not exist`,
  1227. statusCode: http.StatusNotFound,
  1228. mockParams: mockParams{
  1229. userManagerParams: userManagerParams{
  1230. deleteUserParams: deleteUserParams{
  1231. {
  1232. screenName: state.NewIdentScreenName("userA"),
  1233. err: state.ErrNoUser,
  1234. },
  1235. },
  1236. },
  1237. },
  1238. },
  1239. {
  1240. name: "with malformed body",
  1241. body: `{"screen_name":"userA"`, // missing closing }
  1242. want: `malformed input`,
  1243. statusCode: http.StatusBadRequest,
  1244. },
  1245. {
  1246. name: "user handler error",
  1247. body: `{"screen_name":"userA"}`,
  1248. want: `internal server error`,
  1249. statusCode: http.StatusInternalServerError,
  1250. mockParams: mockParams{
  1251. userManagerParams: userManagerParams{
  1252. deleteUserParams: deleteUserParams{
  1253. {
  1254. screenName: state.NewIdentScreenName("userA"),
  1255. err: io.EOF,
  1256. },
  1257. },
  1258. },
  1259. },
  1260. },
  1261. }
  1262. for _, tc := range tt {
  1263. t.Run(tc.name, func(t *testing.T) {
  1264. request := httptest.NewRequest(http.MethodDelete, "/user", strings.NewReader(tc.body))
  1265. responseRecorder := httptest.NewRecorder()
  1266. userManager := newMockUserManager(t)
  1267. for _, params := range tc.mockParams.deleteUserParams {
  1268. userManager.EXPECT().
  1269. DeleteUser(matchContext(), params.screenName).
  1270. Return(params.err)
  1271. }
  1272. deleteUserHandler(responseRecorder, request, userManager, slog.Default())
  1273. if responseRecorder.Code != tc.statusCode {
  1274. t.Errorf("want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1275. }
  1276. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1277. t.Errorf("want '%s', got '%s'", tc.want, responseRecorder.Body)
  1278. }
  1279. })
  1280. }
  1281. }
  1282. func TestUserPasswordHandler_PUT(t *testing.T) {
  1283. tt := []struct {
  1284. name string
  1285. body string
  1286. want string
  1287. statusCode int
  1288. mockParams mockParams
  1289. }{
  1290. {
  1291. name: "user with valid password",
  1292. body: `{"screen_name":"userA", "password":"thenewpassword"}`,
  1293. want: `Password successfully reset.`,
  1294. statusCode: http.StatusNoContent,
  1295. mockParams: mockParams{
  1296. userManagerParams: userManagerParams{
  1297. setUserPasswordParams: setUserPasswordParams{
  1298. {
  1299. screenName: state.NewIdentScreenName("userA"),
  1300. newPassword: "thenewpassword",
  1301. },
  1302. },
  1303. },
  1304. },
  1305. },
  1306. {
  1307. name: "user with invalid password",
  1308. body: `{"screen_name":"userA", "password":"a"}`,
  1309. want: `invalid password length`,
  1310. statusCode: http.StatusBadRequest,
  1311. mockParams: mockParams{
  1312. userManagerParams: userManagerParams{
  1313. setUserPasswordParams: setUserPasswordParams{
  1314. {
  1315. screenName: state.NewIdentScreenName("userA"),
  1316. newPassword: "a",
  1317. err: state.ErrPasswordInvalid,
  1318. },
  1319. },
  1320. },
  1321. },
  1322. },
  1323. {
  1324. name: "with malformed body",
  1325. body: `{"screen_name":"userA", "password":"thepassword"`, // missing closing }
  1326. want: `malformed input`,
  1327. statusCode: http.StatusBadRequest,
  1328. },
  1329. {
  1330. name: "password updater returns runtime error",
  1331. body: `{"screen_name":"userA", "password":"thepassword"}`,
  1332. want: `internal server error`,
  1333. statusCode: http.StatusInternalServerError,
  1334. mockParams: mockParams{
  1335. userManagerParams: userManagerParams{
  1336. setUserPasswordParams: setUserPasswordParams{
  1337. {
  1338. screenName: state.NewIdentScreenName("userA"),
  1339. newPassword: "thepassword",
  1340. err: io.EOF,
  1341. },
  1342. },
  1343. },
  1344. },
  1345. },
  1346. {
  1347. name: "user doesn't exist",
  1348. body: `{"screen_name":"userA", "password":"thepassword"}`,
  1349. want: `user does not exist`,
  1350. statusCode: http.StatusNotFound,
  1351. mockParams: mockParams{
  1352. userManagerParams: userManagerParams{
  1353. setUserPasswordParams: setUserPasswordParams{
  1354. {
  1355. screenName: state.NewIdentScreenName("userA"),
  1356. newPassword: "thepassword",
  1357. err: state.ErrNoUser,
  1358. },
  1359. },
  1360. },
  1361. },
  1362. },
  1363. }
  1364. for _, tc := range tt {
  1365. t.Run(tc.name, func(t *testing.T) {
  1366. request := httptest.NewRequest(http.MethodPut, "/user", strings.NewReader(tc.body))
  1367. responseRecorder := httptest.NewRecorder()
  1368. userManager := newMockUserManager(t)
  1369. for _, params := range tc.mockParams.setUserPasswordParams {
  1370. userManager.EXPECT().
  1371. SetUserPassword(matchContext(), params.screenName, params.newPassword).
  1372. Return(params.err)
  1373. }
  1374. putUserPasswordHandler(responseRecorder, request, userManager, slog.Default())
  1375. if responseRecorder.Code != tc.statusCode {
  1376. t.Errorf("want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1377. }
  1378. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1379. t.Errorf("want '%s', got '%s'", tc.want, responseRecorder.Body)
  1380. }
  1381. })
  1382. }
  1383. }
  1384. func TestPublicChatHandler_GET(t *testing.T) {
  1385. fnNewSess := func(screenName string) *state.Session {
  1386. sess := state.NewSession()
  1387. sess.SetIdentScreenName(state.NewIdentScreenName(screenName))
  1388. sess.SetDisplayScreenName(state.DisplayScreenName(screenName))
  1389. instance := sess.AddInstance()
  1390. instance.SetSignonComplete()
  1391. return sess
  1392. }
  1393. chatRoom1 := state.NewChatRoom("chat-room-1-name", state.NewIdentScreenName("chat-room-1-creator"), state.PublicExchange)
  1394. chatRoom2 := state.NewChatRoom("chat-room-2-name", state.NewIdentScreenName("chat-room-1-creator"), state.PublicExchange)
  1395. tt := []struct {
  1396. name string
  1397. want string
  1398. statusCode int
  1399. mockParams mockParams
  1400. }{
  1401. {
  1402. name: "multiple chat rooms with participants",
  1403. want: `[{"name":"chat-room-1-name","create_time":"0001-01-01T00:00:00Z","url":"aim:gochat?roomname=chat-room-1-name&exchange=5","participants":[{"id":"usera","screen_name":"userA"},{"id":"userb","screen_name":"userB"}]},{"name":"chat-room-2-name","create_time":"0001-01-01T00:00:00Z","url":"aim:gochat?roomname=chat-room-2-name&exchange=5","participants":[{"id":"userc","screen_name":"userC"},{"id":"userd","screen_name":"userD"}]}]`,
  1404. statusCode: http.StatusOK,
  1405. mockParams: mockParams{
  1406. chatRoomRetrieverParams: chatRoomRetrieverParams{
  1407. allChatRoomsParams: allChatRoomsParams{
  1408. {
  1409. exchange: state.PublicExchange,
  1410. result: []state.ChatRoom{
  1411. chatRoom1,
  1412. chatRoom2,
  1413. },
  1414. },
  1415. },
  1416. },
  1417. chatSessionRetrieverParams: chatSessionRetrieverParams{
  1418. chatSessionRetrieverAllSessionsParams: chatSessionRetrieverAllSessionsParams{
  1419. {
  1420. cookie: chatRoom1.Cookie(),
  1421. result: []*state.Session{
  1422. fnNewSess("userA"),
  1423. fnNewSess("userB"),
  1424. },
  1425. },
  1426. {
  1427. cookie: chatRoom2.Cookie(),
  1428. result: []*state.Session{
  1429. fnNewSess("userC"),
  1430. fnNewSess("userD"),
  1431. },
  1432. },
  1433. },
  1434. },
  1435. },
  1436. },
  1437. {
  1438. name: "chat room without participants",
  1439. want: `[{"name":"chat-room-1-name","create_time":"0001-01-01T00:00:00Z","url":"aim:gochat?roomname=chat-room-1-name&exchange=5","participants":[]}]`,
  1440. statusCode: http.StatusOK,
  1441. mockParams: mockParams{
  1442. chatRoomRetrieverParams: chatRoomRetrieverParams{
  1443. allChatRoomsParams: allChatRoomsParams{
  1444. {
  1445. exchange: state.PublicExchange,
  1446. result: []state.ChatRoom{
  1447. chatRoom1,
  1448. },
  1449. },
  1450. },
  1451. },
  1452. chatSessionRetrieverParams: chatSessionRetrieverParams{
  1453. chatSessionRetrieverAllSessionsParams: chatSessionRetrieverAllSessionsParams{
  1454. {
  1455. cookie: chatRoom1.Cookie(),
  1456. result: []*state.Session{},
  1457. },
  1458. },
  1459. },
  1460. },
  1461. },
  1462. {
  1463. name: "no chat rooms",
  1464. want: `[]`,
  1465. statusCode: http.StatusOK,
  1466. mockParams: mockParams{
  1467. chatRoomRetrieverParams: chatRoomRetrieverParams{
  1468. allChatRoomsParams: allChatRoomsParams{
  1469. {
  1470. exchange: state.PublicExchange,
  1471. result: []state.ChatRoom{},
  1472. },
  1473. },
  1474. },
  1475. },
  1476. },
  1477. }
  1478. for _, tc := range tt {
  1479. t.Run(tc.name, func(t *testing.T) {
  1480. request := httptest.NewRequest(http.MethodGet, "/chat/room/public", nil)
  1481. responseRecorder := httptest.NewRecorder()
  1482. chatRoomRetriever := newMockChatRoomRetriever(t)
  1483. for _, params := range tc.mockParams.allChatRoomsParams {
  1484. chatRoomRetriever.EXPECT().
  1485. AllChatRooms(matchContext(), params.exchange).
  1486. Return(params.result, params.err)
  1487. }
  1488. chatSessionRetriever := newMockChatSessionRetriever(t)
  1489. for _, params := range tc.mockParams.chatSessionRetrieverAllSessionsParams {
  1490. chatSessionRetriever.EXPECT().
  1491. AllSessions(params.cookie).
  1492. Return(params.result)
  1493. }
  1494. getPublicChatHandler(responseRecorder, request, chatRoomRetriever, chatSessionRetriever, slog.Default())
  1495. if responseRecorder.Code != tc.statusCode {
  1496. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1497. }
  1498. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1499. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  1500. }
  1501. })
  1502. }
  1503. }
  1504. func TestDeletePublicChatHandler(t *testing.T) {
  1505. tt := []struct {
  1506. name string
  1507. body string
  1508. want string
  1509. statusCode int
  1510. mockParams mockParams
  1511. }{
  1512. {
  1513. name: "successful deletion of single chat room",
  1514. body: `{"names":["TestRoom"]}`,
  1515. want: `Chat rooms deleted successfully.`,
  1516. statusCode: http.StatusNoContent,
  1517. mockParams: mockParams{
  1518. chatRoomDeleterParams: chatRoomDeleterParams{
  1519. deleteChatRoomsParams: deleteChatRoomsParams{
  1520. {
  1521. exchange: state.PublicExchange,
  1522. names: []string{"TestRoom"},
  1523. },
  1524. },
  1525. },
  1526. },
  1527. },
  1528. {
  1529. name: "successful deletion of multiple chat rooms",
  1530. body: `{"names":["Room1", "Room2", "Room3"]}`,
  1531. want: `Chat rooms deleted successfully.`,
  1532. statusCode: http.StatusNoContent,
  1533. mockParams: mockParams{
  1534. chatRoomDeleterParams: chatRoomDeleterParams{
  1535. deleteChatRoomsParams: deleteChatRoomsParams{
  1536. {
  1537. exchange: state.PublicExchange,
  1538. names: []string{"Room1", "Room2", "Room3"},
  1539. },
  1540. },
  1541. },
  1542. },
  1543. },
  1544. {
  1545. name: "empty names array",
  1546. body: `{"names":[]}`,
  1547. want: `no chat room names provided`,
  1548. statusCode: http.StatusBadRequest,
  1549. },
  1550. {
  1551. name: "malformed JSON",
  1552. body: `{"names":["Room1"`, // missing closing brackets
  1553. want: `malformed input`,
  1554. statusCode: http.StatusBadRequest,
  1555. },
  1556. {
  1557. name: "deletion error",
  1558. body: `{"names":["TestRoom"]}`,
  1559. want: `internal server error`,
  1560. statusCode: http.StatusInternalServerError,
  1561. mockParams: mockParams{
  1562. chatRoomDeleterParams: chatRoomDeleterParams{
  1563. deleteChatRoomsParams: deleteChatRoomsParams{
  1564. {
  1565. exchange: state.PublicExchange,
  1566. names: []string{"TestRoom"},
  1567. err: errors.New("database error"),
  1568. },
  1569. },
  1570. },
  1571. },
  1572. },
  1573. }
  1574. for _, tc := range tt {
  1575. t.Run(tc.name, func(t *testing.T) {
  1576. request := httptest.NewRequest(http.MethodDelete, "/chat/room/public", strings.NewReader(tc.body))
  1577. responseRecorder := httptest.NewRecorder()
  1578. chatRoomDeleter := newMockChatRoomDeleter(t)
  1579. for _, params := range tc.mockParams.deleteChatRoomsParams {
  1580. chatRoomDeleter.EXPECT().
  1581. DeleteChatRooms(matchContext(), params.exchange, params.names).
  1582. Return(params.err)
  1583. }
  1584. deletePublicChatHandler(responseRecorder, request, chatRoomDeleter, slog.Default())
  1585. if responseRecorder.Code != tc.statusCode {
  1586. t.Errorf("want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1587. }
  1588. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1589. t.Errorf("want '%s', got '%s'", tc.want, responseRecorder.Body)
  1590. }
  1591. })
  1592. }
  1593. }
  1594. func TestPrivateChatHandler_GET(t *testing.T) {
  1595. fnNewSess := func(screenName string) *state.Session {
  1596. sess := state.NewSession()
  1597. sess.SetIdentScreenName(state.NewIdentScreenName(screenName))
  1598. sess.SetDisplayScreenName(state.DisplayScreenName(screenName))
  1599. instance := sess.AddInstance()
  1600. instance.SetSignonComplete()
  1601. return sess
  1602. }
  1603. chatRoom1 := state.NewChatRoom("chat-room-1-name", state.NewIdentScreenName("chat-room-1-creator"), state.PrivateExchange)
  1604. chatRoom2 := state.NewChatRoom("chat-room-2-name", state.NewIdentScreenName("chat-room-2-creator"), state.PrivateExchange)
  1605. tt := []struct {
  1606. name string
  1607. want string
  1608. statusCode int
  1609. mockParams mockParams
  1610. }{
  1611. {
  1612. name: "multiple chat rooms with participants",
  1613. want: `[{"name":"chat-room-1-name","create_time":"0001-01-01T00:00:00Z","creator_id":"chat-room-1-creator","url":"aim:gochat?roomname=chat-room-1-name&exchange=4","participants":[{"id":"usera","screen_name":"userA"},{"id":"userb","screen_name":"userB"}]},{"name":"chat-room-2-name","create_time":"0001-01-01T00:00:00Z","creator_id":"chat-room-2-creator","url":"aim:gochat?roomname=chat-room-2-name&exchange=4","participants":[{"id":"userc","screen_name":"userC"},{"id":"userd","screen_name":"userD"}]}]`,
  1614. statusCode: http.StatusOK,
  1615. mockParams: mockParams{
  1616. chatRoomRetrieverParams: chatRoomRetrieverParams{
  1617. allChatRoomsParams: allChatRoomsParams{
  1618. {
  1619. exchange: state.PrivateExchange,
  1620. result: []state.ChatRoom{
  1621. chatRoom1,
  1622. chatRoom2,
  1623. },
  1624. },
  1625. },
  1626. },
  1627. chatSessionRetrieverParams: chatSessionRetrieverParams{
  1628. chatSessionRetrieverAllSessionsParams: chatSessionRetrieverAllSessionsParams{
  1629. {
  1630. cookie: chatRoom1.Cookie(),
  1631. result: []*state.Session{
  1632. fnNewSess("userA"),
  1633. fnNewSess("userB"),
  1634. },
  1635. },
  1636. {
  1637. cookie: chatRoom2.Cookie(),
  1638. result: []*state.Session{
  1639. fnNewSess("userC"),
  1640. fnNewSess("userD"),
  1641. },
  1642. },
  1643. },
  1644. },
  1645. },
  1646. },
  1647. {
  1648. name: "chat room without participants",
  1649. want: `[{"name":"chat-room-1-name","create_time":"0001-01-01T00:00:00Z","creator_id":"chat-room-1-creator","url":"aim:gochat?roomname=chat-room-1-name&exchange=4","participants":[]}]`,
  1650. statusCode: http.StatusOK,
  1651. mockParams: mockParams{
  1652. chatRoomRetrieverParams: chatRoomRetrieverParams{
  1653. allChatRoomsParams: allChatRoomsParams{
  1654. {
  1655. exchange: state.PrivateExchange,
  1656. result: []state.ChatRoom{
  1657. chatRoom1,
  1658. },
  1659. },
  1660. },
  1661. },
  1662. chatSessionRetrieverParams: chatSessionRetrieverParams{
  1663. chatSessionRetrieverAllSessionsParams: chatSessionRetrieverAllSessionsParams{
  1664. {
  1665. cookie: chatRoom1.Cookie(),
  1666. result: []*state.Session{},
  1667. },
  1668. },
  1669. },
  1670. },
  1671. },
  1672. {
  1673. name: "no chat rooms",
  1674. want: `[]`,
  1675. statusCode: http.StatusOK,
  1676. mockParams: mockParams{
  1677. chatRoomRetrieverParams: chatRoomRetrieverParams{
  1678. allChatRoomsParams: allChatRoomsParams{
  1679. {
  1680. exchange: state.PrivateExchange,
  1681. result: []state.ChatRoom{},
  1682. },
  1683. },
  1684. },
  1685. },
  1686. },
  1687. }
  1688. for _, tc := range tt {
  1689. t.Run(tc.name, func(t *testing.T) {
  1690. request := httptest.NewRequest(http.MethodGet, "/chat/room/private", nil)
  1691. responseRecorder := httptest.NewRecorder()
  1692. chatRoomRetriever := newMockChatRoomRetriever(t)
  1693. for _, params := range tc.mockParams.allChatRoomsParams {
  1694. chatRoomRetriever.EXPECT().
  1695. AllChatRooms(matchContext(), params.exchange).
  1696. Return(params.result, params.err)
  1697. }
  1698. chatSessionRetriever := newMockChatSessionRetriever(t)
  1699. for _, params := range tc.mockParams.chatSessionRetrieverAllSessionsParams {
  1700. chatSessionRetriever.EXPECT().
  1701. AllSessions(params.cookie).
  1702. Return(params.result)
  1703. }
  1704. getPrivateChatHandler(responseRecorder, request, chatRoomRetriever, chatSessionRetriever, slog.Default())
  1705. if responseRecorder.Code != tc.statusCode {
  1706. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1707. }
  1708. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1709. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  1710. }
  1711. })
  1712. }
  1713. }
  1714. func TestInstantMessageHandler_POST(t *testing.T) {
  1715. tt := []struct {
  1716. name string
  1717. body string
  1718. wantText string
  1719. wantStore bool
  1720. sendCalled bool
  1721. reply *wire.SNACMessage
  1722. sendErr error
  1723. want string
  1724. statusCode int
  1725. }{
  1726. {
  1727. name: "send an instant message",
  1728. body: `{"from":"sender_sn","to":"recip_sn","text":"hello world!"}`,
  1729. sendCalled: true,
  1730. want: `Message sent successfully.`,
  1731. statusCode: http.StatusOK,
  1732. },
  1733. {
  1734. name: "send an instant message with non-ASCII text",
  1735. body: `{"from":"sender_sn","to":"recip_sn","text":"héllo wörld 日本 😀"}`,
  1736. wantText: "héllo wörld 日本 \uFFFD",
  1737. sendCalled: true,
  1738. want: `Message sent successfully.`,
  1739. statusCode: http.StatusOK,
  1740. },
  1741. {
  1742. name: "recipient is offline",
  1743. body: `{"from":"sender_sn","to":"recip_sn","text":"hello world!"}`,
  1744. sendCalled: true,
  1745. reply: &wire.SNACMessage{
  1746. Frame: wire.SNACFrame{FoodGroup: wire.ICBM, SubGroup: wire.ICBMErr},
  1747. Body: wire.SNACError{Code: wire.ErrorCodeNotLoggedOn},
  1748. },
  1749. want: `recipient is not online`,
  1750. statusCode: http.StatusNotFound,
  1751. },
  1752. {
  1753. name: "store message for offline recipient",
  1754. body: `{"from":"sender_sn","to":"recip_sn","text":"hello world!","storeOffline":true}`,
  1755. wantStore: true,
  1756. sendCalled: true,
  1757. want: `Message sent successfully.`,
  1758. statusCode: http.StatusOK,
  1759. },
  1760. {
  1761. name: "offline recipient does not accept stored message",
  1762. body: `{"from":"sender_sn","to":"recip_sn","text":"hello world!","storeOffline":true}`,
  1763. wantStore: true,
  1764. sendCalled: true,
  1765. reply: &wire.SNACMessage{
  1766. Frame: wire.SNACFrame{FoodGroup: wire.ICBM, SubGroup: wire.ICBMErr},
  1767. Body: wire.SNACError{Code: wire.ErrorCodeNotLoggedOn},
  1768. },
  1769. want: `recipient is not online`,
  1770. statusCode: http.StatusNotFound,
  1771. },
  1772. {
  1773. name: "do not store message for offline recipient",
  1774. body: `{"from":"sender_sn","to":"recip_sn","text":"hello world!","storeOffline":false}`,
  1775. sendCalled: true,
  1776. reply: &wire.SNACMessage{
  1777. Frame: wire.SNACFrame{FoodGroup: wire.ICBM, SubGroup: wire.ICBMErr},
  1778. Body: wire.SNACError{Code: wire.ErrorCodeNotLoggedOn},
  1779. },
  1780. want: `recipient is not online`,
  1781. statusCode: http.StatusNotFound,
  1782. },
  1783. {
  1784. name: "sender is blocked",
  1785. body: `{"from":"sender_sn","to":"recip_sn","text":"hello world!"}`,
  1786. sendCalled: true,
  1787. reply: &wire.SNACMessage{
  1788. Frame: wire.SNACFrame{FoodGroup: wire.ICBM, SubGroup: wire.ICBMErr},
  1789. Body: wire.SNACError{Code: wire.ErrorCodeInLocalPermitDeny},
  1790. },
  1791. want: `message blocked`,
  1792. statusCode: http.StatusForbidden,
  1793. },
  1794. {
  1795. name: "send fails",
  1796. body: `{"from":"sender_sn","to":"recip_sn","text":"hello world!"}`,
  1797. sendCalled: true,
  1798. sendErr: io.EOF,
  1799. want: `internal server error`,
  1800. statusCode: http.StatusInternalServerError,
  1801. },
  1802. {
  1803. name: "with malformed body",
  1804. body: `{"screen_name":"userA", "password":"thepassword"`,
  1805. want: `malformed input`,
  1806. statusCode: http.StatusBadRequest,
  1807. },
  1808. }
  1809. for _, tc := range tt {
  1810. t.Run(tc.name, func(t *testing.T) {
  1811. request := httptest.NewRequest(http.MethodPost, "/instant-message", strings.NewReader(tc.body))
  1812. responseRecorder := httptest.NewRecorder()
  1813. sendCalled := false
  1814. icbmSender := func(ctx context.Context, instance *state.SessionInstance, inFrame wire.SNACFrame, inBody wire.SNAC_0x04_0x06_ICBMChannelMsgToHost) (*wire.SNACMessage, error) {
  1815. sendCalled = true
  1816. assert.Equal(t, state.NewIdentScreenName("sender_sn"), instance.IdentScreenName())
  1817. assert.Equal(t, wire.ICBM, inFrame.FoodGroup)
  1818. assert.Equal(t, wire.ICBMChannelMsgToHost, inFrame.SubGroup)
  1819. assert.Equal(t, "recip_sn", inBody.ScreenName)
  1820. assert.Equal(t, wire.ICBMChannelIM, inBody.ChannelID)
  1821. assert.Equal(t, [][16]byte{wire.CapUTF8Messages}, instance.Caps())
  1822. _, hasStore := inBody.Bytes(wire.ICBMTLVStore)
  1823. assert.Equal(t, tc.wantStore, hasStore)
  1824. wantText := tc.wantText
  1825. if wantText == "" {
  1826. wantText = "hello world!"
  1827. }
  1828. wantCharset := wire.ICBMMessageEncodingUnicode
  1829. if wire.AllASCII(wantText) {
  1830. wantCharset = wire.ICBMMessageEncodingASCII
  1831. }
  1832. b, ok := inBody.Bytes(wire.ICBMTLVAOLIMData)
  1833. assert.True(t, ok)
  1834. var frags []wire.ICBMCh1Fragment
  1835. assert.NoError(t, wire.UnmarshalBE(&frags, bytes.NewBuffer(b)))
  1836. for _, frag := range frags {
  1837. if frag.ID == 1 {
  1838. msg := wire.ICBMCh1Message{}
  1839. assert.NoError(t, wire.UnmarshalBE(&msg, bytes.NewBuffer(frag.Payload)))
  1840. assert.Equal(t, wantCharset, msg.Charset)
  1841. }
  1842. }
  1843. txt, err := wire.UnmarshalICBMMessageText(b)
  1844. assert.NoError(t, err)
  1845. assert.Equal(t, wantText, txt)
  1846. return tc.reply, tc.sendErr
  1847. }
  1848. postInstantMessageHandler(responseRecorder, request, icbmSender, slog.Default())
  1849. assert.Equal(t, tc.sendCalled, sendCalled)
  1850. assert.Equal(t, tc.statusCode, responseRecorder.Code)
  1851. assert.Equal(t, tc.want, strings.TrimSpace(responseRecorder.Body.String()))
  1852. })
  1853. }
  1854. }
  1855. func TestVersionHandler_GET(t *testing.T) {
  1856. tt := []struct {
  1857. name string
  1858. want string
  1859. statusCode int
  1860. buildInfo config.Build
  1861. }{
  1862. {
  1863. name: "get ras version",
  1864. want: `{"version":"13.3.7","commit":"asdfASDF12345678","date":"2024-03-01"}`,
  1865. statusCode: http.StatusOK,
  1866. buildInfo: config.Build{
  1867. Version: "13.3.7",
  1868. Commit: "asdfASDF12345678",
  1869. Date: "2024-03-01",
  1870. },
  1871. },
  1872. }
  1873. for _, tc := range tt {
  1874. t.Run(tc.name, func(t *testing.T) {
  1875. responseRecorder := httptest.NewRecorder()
  1876. getVersionHandler(responseRecorder, tc.buildInfo)
  1877. if responseRecorder.Code != tc.statusCode {
  1878. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1879. }
  1880. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1881. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  1882. }
  1883. })
  1884. }
  1885. }
  1886. func TestDirectoryCategoryHandler_GET(t *testing.T) {
  1887. tt := []struct {
  1888. name string
  1889. want string
  1890. statusCode int
  1891. mockParams mockParams
  1892. }{
  1893. {
  1894. name: "no categories",
  1895. want: `[]`,
  1896. statusCode: http.StatusOK,
  1897. mockParams: mockParams{
  1898. directoryManagerParams: directoryManagerParams{
  1899. categoriesParams: categoriesParams{
  1900. {
  1901. result: nil,
  1902. },
  1903. },
  1904. },
  1905. },
  1906. },
  1907. {
  1908. name: "error fetching categories",
  1909. want: `{"message":"internal server error"}`,
  1910. statusCode: http.StatusInternalServerError,
  1911. mockParams: mockParams{
  1912. directoryManagerParams: directoryManagerParams{
  1913. categoriesParams: categoriesParams{
  1914. {
  1915. result: nil,
  1916. err: errors.New("error fetching categories"),
  1917. },
  1918. },
  1919. },
  1920. },
  1921. },
  1922. {
  1923. name: "fetch some categories",
  1924. want: `[{"id":1,"name":"category-1"},{"id":2,"name":"category-2"}]`,
  1925. statusCode: http.StatusOK,
  1926. mockParams: mockParams{
  1927. directoryManagerParams: directoryManagerParams{
  1928. categoriesParams: categoriesParams{
  1929. {
  1930. result: []state.Category{
  1931. {
  1932. ID: 1,
  1933. Name: "category-1",
  1934. },
  1935. {
  1936. ID: 2,
  1937. Name: "category-2",
  1938. },
  1939. },
  1940. },
  1941. },
  1942. },
  1943. },
  1944. },
  1945. }
  1946. for _, tc := range tt {
  1947. t.Run(tc.name, func(t *testing.T) {
  1948. responseRecorder := httptest.NewRecorder()
  1949. request := httptest.NewRequest(http.MethodGet, "/directory/category", nil)
  1950. directoryManager := newMockDirectoryManager(t)
  1951. for _, params := range tc.mockParams.categoriesParams {
  1952. directoryManager.EXPECT().
  1953. Categories(matchContext()).
  1954. Return(params.result, params.err)
  1955. }
  1956. getDirectoryCategoryHandler(responseRecorder, request, directoryManager, slog.Default())
  1957. if responseRecorder.Code != tc.statusCode {
  1958. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1959. }
  1960. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1961. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  1962. }
  1963. })
  1964. }
  1965. }
  1966. func TestDirectoryCategoryKeywordHandler_GET(t *testing.T) {
  1967. tt := []struct {
  1968. name string
  1969. categoryID int
  1970. want string
  1971. statusCode int
  1972. mockParams mockParams
  1973. }{
  1974. {
  1975. name: "category not found",
  1976. categoryID: 1,
  1977. want: `{"message":"category not found"}`,
  1978. statusCode: http.StatusNotFound,
  1979. mockParams: mockParams{
  1980. directoryManagerParams: directoryManagerParams{
  1981. keywordsByCategoryParams: keywordsByCategoryParams{
  1982. {
  1983. categoryID: 1,
  1984. result: nil,
  1985. err: state.ErrKeywordCategoryNotFound,
  1986. },
  1987. },
  1988. },
  1989. },
  1990. },
  1991. {
  1992. name: "error fetching keywords by category",
  1993. categoryID: 1,
  1994. want: `{"message":"internal server error"}`,
  1995. statusCode: http.StatusInternalServerError,
  1996. mockParams: mockParams{
  1997. directoryManagerParams: directoryManagerParams{
  1998. keywordsByCategoryParams: keywordsByCategoryParams{
  1999. {
  2000. categoryID: 1,
  2001. result: nil,
  2002. err: errors.New("error fetching keywords by category"),
  2003. },
  2004. },
  2005. },
  2006. },
  2007. },
  2008. {
  2009. name: "invalid category ID",
  2010. categoryID: -1,
  2011. want: `{"message":"invalid category ID"}`,
  2012. statusCode: http.StatusBadRequest,
  2013. mockParams: mockParams{
  2014. directoryManagerParams: directoryManagerParams{
  2015. keywordsByCategoryParams: keywordsByCategoryParams{},
  2016. },
  2017. },
  2018. },
  2019. {
  2020. name: "no keywords",
  2021. categoryID: 1,
  2022. want: `[]`,
  2023. statusCode: http.StatusOK,
  2024. mockParams: mockParams{
  2025. directoryManagerParams: directoryManagerParams{
  2026. keywordsByCategoryParams: keywordsByCategoryParams{
  2027. {
  2028. categoryID: 1,
  2029. result: nil,
  2030. },
  2031. },
  2032. },
  2033. },
  2034. },
  2035. {
  2036. name: "fetch some keywords by category",
  2037. categoryID: 1,
  2038. want: `[{"id":1,"name":"keyword-1"},{"id":2,"name":"keyword-2"}]`,
  2039. statusCode: http.StatusOK,
  2040. mockParams: mockParams{
  2041. directoryManagerParams: directoryManagerParams{
  2042. keywordsByCategoryParams: keywordsByCategoryParams{
  2043. {
  2044. categoryID: 1,
  2045. result: []state.Keyword{
  2046. {
  2047. ID: 1,
  2048. Name: "keyword-1",
  2049. },
  2050. {
  2051. ID: 2,
  2052. Name: "keyword-2",
  2053. },
  2054. },
  2055. },
  2056. },
  2057. },
  2058. },
  2059. },
  2060. }
  2061. for _, tc := range tt {
  2062. t.Run(tc.name, func(t *testing.T) {
  2063. request := httptest.NewRequest(http.MethodGet, fmt.Sprintf("/directory/category/%d/keyword", tc.categoryID), nil)
  2064. request.SetPathValue("id", fmt.Sprintf("%d", tc.categoryID))
  2065. responseRecorder := httptest.NewRecorder()
  2066. directoryManager := newMockDirectoryManager(t)
  2067. for _, params := range tc.mockParams.keywordsByCategoryParams {
  2068. directoryManager.EXPECT().
  2069. KeywordsByCategory(matchContext(), params.categoryID).
  2070. Return(params.result, params.err)
  2071. }
  2072. getDirectoryCategoryKeywordHandler(responseRecorder, request, directoryManager, slog.Default())
  2073. if responseRecorder.Code != tc.statusCode {
  2074. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  2075. }
  2076. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  2077. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  2078. }
  2079. })
  2080. }
  2081. }
  2082. func TestDirectoryCategoryHandler_DELETE(t *testing.T) {
  2083. tt := []struct {
  2084. name string
  2085. categoryID int
  2086. want string
  2087. statusCode int
  2088. mockParams mockParams
  2089. }{
  2090. {
  2091. name: "category not found",
  2092. categoryID: 1,
  2093. want: `{"message":"category not found"}`,
  2094. statusCode: http.StatusNotFound,
  2095. mockParams: mockParams{
  2096. directoryManagerParams: directoryManagerParams{
  2097. deleteCategoryParams: deleteCategoryParams{
  2098. {
  2099. categoryID: 1,
  2100. err: state.ErrKeywordCategoryNotFound,
  2101. },
  2102. },
  2103. },
  2104. },
  2105. },
  2106. {
  2107. name: "keyword in use by user",
  2108. categoryID: 1,
  2109. want: `{"message":"can't delete because category in use by a user"}`,
  2110. statusCode: http.StatusConflict,
  2111. mockParams: mockParams{
  2112. directoryManagerParams: directoryManagerParams{
  2113. deleteCategoryParams: deleteCategoryParams{
  2114. {
  2115. categoryID: 1,
  2116. err: state.ErrKeywordInUse,
  2117. },
  2118. },
  2119. },
  2120. },
  2121. },
  2122. {
  2123. name: "runtime error",
  2124. categoryID: 1,
  2125. want: `{"message":"internal server error"}`,
  2126. statusCode: http.StatusInternalServerError,
  2127. mockParams: mockParams{
  2128. directoryManagerParams: directoryManagerParams{
  2129. deleteCategoryParams: deleteCategoryParams{
  2130. {
  2131. categoryID: 1,
  2132. err: errors.New("error deleting keyword"),
  2133. },
  2134. },
  2135. },
  2136. },
  2137. },
  2138. {
  2139. name: "successful deletion",
  2140. categoryID: 1,
  2141. want: ``,
  2142. statusCode: http.StatusNoContent,
  2143. mockParams: mockParams{
  2144. directoryManagerParams: directoryManagerParams{
  2145. deleteCategoryParams: deleteCategoryParams{
  2146. {
  2147. categoryID: 1,
  2148. },
  2149. },
  2150. },
  2151. },
  2152. },
  2153. {
  2154. name: "invalid category ID",
  2155. categoryID: -1,
  2156. want: `invalid category ID`,
  2157. statusCode: http.StatusBadRequest,
  2158. mockParams: mockParams{
  2159. directoryManagerParams: directoryManagerParams{
  2160. deleteCategoryParams: deleteCategoryParams{},
  2161. },
  2162. },
  2163. },
  2164. }
  2165. for _, tc := range tt {
  2166. t.Run(tc.name, func(t *testing.T) {
  2167. request := httptest.NewRequest(http.MethodDelete, fmt.Sprintf("/directory/category/%d/keyword", tc.categoryID), nil)
  2168. request.SetPathValue("id", fmt.Sprintf("%d", tc.categoryID))
  2169. responseRecorder := httptest.NewRecorder()
  2170. directoryManager := newMockDirectoryManager(t)
  2171. for _, params := range tc.mockParams.deleteCategoryParams {
  2172. directoryManager.EXPECT().
  2173. DeleteCategory(matchContext(), params.categoryID).
  2174. Return(params.err)
  2175. }
  2176. deleteDirectoryCategoryHandler(responseRecorder, request, directoryManager, slog.Default())
  2177. if responseRecorder.Code != tc.statusCode {
  2178. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  2179. }
  2180. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  2181. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  2182. }
  2183. })
  2184. }
  2185. }
  2186. func TestDirectoryCategoryHandler_POST(t *testing.T) {
  2187. tt := []struct {
  2188. name string
  2189. body string
  2190. want string
  2191. statusCode int
  2192. mockParams mockParams
  2193. }{
  2194. {
  2195. name: "category already exists",
  2196. body: `{"name":"the_category"}`,
  2197. want: `{"message":"category already exists"}`,
  2198. statusCode: http.StatusConflict,
  2199. mockParams: mockParams{
  2200. directoryManagerParams: directoryManagerParams{
  2201. createCategoryParams: createCategoryParams{
  2202. {
  2203. name: "the_category",
  2204. err: state.ErrKeywordCategoryExists,
  2205. },
  2206. },
  2207. },
  2208. },
  2209. },
  2210. {
  2211. name: "runtime error",
  2212. body: `{"name":"the_category"}`,
  2213. want: `{"message":"internal server error"}`,
  2214. statusCode: http.StatusInternalServerError,
  2215. mockParams: mockParams{
  2216. directoryManagerParams: directoryManagerParams{
  2217. createCategoryParams: createCategoryParams{
  2218. {
  2219. name: "the_category",
  2220. err: errors.New("error creating category"),
  2221. },
  2222. },
  2223. },
  2224. },
  2225. },
  2226. {
  2227. name: "bad input",
  2228. body: `{"name":"the_category"`,
  2229. want: `{"message":"malformed input"}`,
  2230. statusCode: http.StatusBadRequest,
  2231. mockParams: mockParams{
  2232. directoryManagerParams: directoryManagerParams{
  2233. createCategoryParams: createCategoryParams{},
  2234. },
  2235. },
  2236. },
  2237. {
  2238. name: "successful creation",
  2239. body: `{"name":"the_category"}`,
  2240. want: `{"id":1,"name":"the_category"}`,
  2241. statusCode: http.StatusCreated,
  2242. mockParams: mockParams{
  2243. directoryManagerParams: directoryManagerParams{
  2244. createCategoryParams: createCategoryParams{
  2245. {
  2246. name: "the_category",
  2247. result: state.Category{
  2248. ID: 1,
  2249. Name: "the_category",
  2250. },
  2251. },
  2252. },
  2253. },
  2254. },
  2255. },
  2256. }
  2257. for _, tc := range tt {
  2258. t.Run(tc.name, func(t *testing.T) {
  2259. request := httptest.NewRequest(http.MethodPost, "/directory/category", strings.NewReader(tc.body))
  2260. responseRecorder := httptest.NewRecorder()
  2261. directoryManager := newMockDirectoryManager(t)
  2262. for _, params := range tc.mockParams.createCategoryParams {
  2263. directoryManager.EXPECT().
  2264. CreateCategory(matchContext(), params.name).
  2265. Return(params.result, params.err)
  2266. }
  2267. postDirectoryCategoryHandler(responseRecorder, request, directoryManager, slog.Default())
  2268. if responseRecorder.Code != tc.statusCode {
  2269. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  2270. }
  2271. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  2272. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  2273. }
  2274. })
  2275. }
  2276. }
  2277. func TestDirectoryKeywordHandler_POST(t *testing.T) {
  2278. tt := []struct {
  2279. name string
  2280. body string
  2281. want string
  2282. statusCode int
  2283. mockParams mockParams
  2284. }{
  2285. {
  2286. name: "keyword already exists",
  2287. body: `{"category_id":1,"name":"the_keyword"}`,
  2288. want: `{"message":"keyword already exists"}`,
  2289. statusCode: http.StatusConflict,
  2290. mockParams: mockParams{
  2291. directoryManagerParams: directoryManagerParams{
  2292. createKeywordParams: createKeywordParams{
  2293. {
  2294. name: "the_keyword",
  2295. categoryID: 1,
  2296. err: state.ErrKeywordExists,
  2297. },
  2298. },
  2299. },
  2300. },
  2301. },
  2302. {
  2303. name: "category not found",
  2304. body: `{"category_id":1,"name":"the_keyword"}`,
  2305. want: `{"message":"category not found"}`,
  2306. statusCode: http.StatusNotFound,
  2307. mockParams: mockParams{
  2308. directoryManagerParams: directoryManagerParams{
  2309. createKeywordParams: createKeywordParams{
  2310. {
  2311. name: "the_keyword",
  2312. categoryID: 1,
  2313. err: state.ErrKeywordCategoryNotFound,
  2314. },
  2315. },
  2316. },
  2317. },
  2318. },
  2319. {
  2320. name: "runtime error",
  2321. body: `{"category_id":1,"name":"the_keyword"}`,
  2322. want: `{"message":"internal server error"}`,
  2323. statusCode: http.StatusInternalServerError,
  2324. mockParams: mockParams{
  2325. directoryManagerParams: directoryManagerParams{
  2326. createKeywordParams: createKeywordParams{
  2327. {
  2328. name: "the_keyword",
  2329. categoryID: 1,
  2330. err: errors.New("error creating keyword"),
  2331. },
  2332. },
  2333. },
  2334. },
  2335. },
  2336. {
  2337. name: "bad input",
  2338. body: `{"category_id":1,"name":"the_keyword"`,
  2339. want: `{"message":"malformed input"}`,
  2340. statusCode: http.StatusBadRequest,
  2341. mockParams: mockParams{
  2342. directoryManagerParams: directoryManagerParams{
  2343. createKeywordParams: createKeywordParams{},
  2344. },
  2345. },
  2346. },
  2347. {
  2348. name: "successful creation",
  2349. body: `{"category_id":1,"name":"the_keyword"}`,
  2350. want: `{"id":1,"name":"the_keyword"}`,
  2351. statusCode: http.StatusCreated,
  2352. mockParams: mockParams{
  2353. directoryManagerParams: directoryManagerParams{
  2354. createKeywordParams: createKeywordParams{
  2355. {
  2356. name: "the_keyword",
  2357. categoryID: 1,
  2358. result: state.Keyword{
  2359. ID: 1,
  2360. Name: "the_keyword",
  2361. },
  2362. },
  2363. },
  2364. },
  2365. },
  2366. },
  2367. }
  2368. for _, tc := range tt {
  2369. t.Run(tc.name, func(t *testing.T) {
  2370. request := httptest.NewRequest(http.MethodPost, "/directory/keyword", strings.NewReader(tc.body))
  2371. responseRecorder := httptest.NewRecorder()
  2372. directoryManager := newMockDirectoryManager(t)
  2373. for _, params := range tc.mockParams.createKeywordParams {
  2374. directoryManager.EXPECT().
  2375. CreateKeyword(matchContext(), params.name, params.categoryID).
  2376. Return(params.result, params.err)
  2377. }
  2378. postDirectoryKeywordHandler(responseRecorder, request, directoryManager, slog.Default())
  2379. if responseRecorder.Code != tc.statusCode {
  2380. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  2381. }
  2382. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  2383. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  2384. }
  2385. })
  2386. }
  2387. }
  2388. func TestDirectoryKeywordHandler_DELETE(t *testing.T) {
  2389. tt := []struct {
  2390. name string
  2391. categoryID int
  2392. want string
  2393. statusCode int
  2394. mockParams mockParams
  2395. }{
  2396. {
  2397. name: "keyword not found",
  2398. categoryID: 1,
  2399. want: `{"message":"keyword not found"}`,
  2400. statusCode: http.StatusNotFound,
  2401. mockParams: mockParams{
  2402. directoryManagerParams: directoryManagerParams{
  2403. deleteKeywordParams: deleteKeywordParams{
  2404. {
  2405. id: 1,
  2406. err: state.ErrKeywordNotFound,
  2407. },
  2408. },
  2409. },
  2410. },
  2411. },
  2412. {
  2413. name: "keyword in use by user",
  2414. categoryID: 1,
  2415. want: `{"message":"can't delete because category in use by a user"}`,
  2416. statusCode: http.StatusConflict,
  2417. mockParams: mockParams{
  2418. directoryManagerParams: directoryManagerParams{
  2419. deleteKeywordParams: deleteKeywordParams{
  2420. {
  2421. id: 1,
  2422. err: state.ErrKeywordInUse,
  2423. },
  2424. },
  2425. },
  2426. },
  2427. },
  2428. {
  2429. name: "runtime error",
  2430. categoryID: 1,
  2431. want: `{"message":"internal server error"}`,
  2432. statusCode: http.StatusInternalServerError,
  2433. mockParams: mockParams{
  2434. directoryManagerParams: directoryManagerParams{
  2435. deleteKeywordParams: deleteKeywordParams{
  2436. {
  2437. id: 1,
  2438. err: errors.New("error deleting keyword"),
  2439. },
  2440. },
  2441. },
  2442. },
  2443. },
  2444. {
  2445. name: "successful deletion",
  2446. categoryID: 1,
  2447. want: ``,
  2448. statusCode: http.StatusNoContent,
  2449. mockParams: mockParams{
  2450. directoryManagerParams: directoryManagerParams{
  2451. deleteKeywordParams: deleteKeywordParams{
  2452. {
  2453. id: 1,
  2454. },
  2455. },
  2456. },
  2457. },
  2458. },
  2459. {
  2460. name: "invalid keyword ID",
  2461. categoryID: -1,
  2462. want: `{"message":"invalid keyword ID"}`,
  2463. statusCode: http.StatusBadRequest,
  2464. mockParams: mockParams{
  2465. directoryManagerParams: directoryManagerParams{
  2466. deleteKeywordParams: deleteKeywordParams{},
  2467. },
  2468. },
  2469. },
  2470. }
  2471. for _, tc := range tt {
  2472. t.Run(tc.name, func(t *testing.T) {
  2473. request := httptest.NewRequest(http.MethodDelete, fmt.Sprintf("/directory/keyword/%d", tc.categoryID), nil)
  2474. request.SetPathValue("id", fmt.Sprintf("%d", tc.categoryID))
  2475. responseRecorder := httptest.NewRecorder()
  2476. directoryManager := newMockDirectoryManager(t)
  2477. for _, params := range tc.mockParams.deleteKeywordParams {
  2478. directoryManager.EXPECT().
  2479. DeleteKeyword(matchContext(), params.id).
  2480. Return(params.err)
  2481. }
  2482. deleteDirectoryKeywordHandler(responseRecorder, request, directoryManager, slog.Default())
  2483. if responseRecorder.Code != tc.statusCode {
  2484. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  2485. }
  2486. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  2487. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  2488. }
  2489. })
  2490. }
  2491. }
  2492. func TestBARTByTypeHandler_GET(t *testing.T) {
  2493. tt := []struct {
  2494. name string
  2495. queryParams string
  2496. wantStatusCode int
  2497. wantResponse string
  2498. mockParams mockParams
  2499. }{
  2500. {
  2501. name: "success with items",
  2502. queryParams: "?type=1",
  2503. wantStatusCode: http.StatusOK,
  2504. wantResponse: `[{"hash":"2B000001E4","type":1},{"hash":"2B000001B7","type":1}]`,
  2505. mockParams: mockParams{
  2506. bartAssetManagerParams: bartAssetManagerParams{
  2507. listBARTItemsParams: listBARTItemsParams{
  2508. {
  2509. itemType: 1,
  2510. result: []state.BARTItem{
  2511. {Hash: "2B000001E4", Type: 1},
  2512. {Hash: "2B000001B7", Type: 1},
  2513. },
  2514. err: nil,
  2515. },
  2516. },
  2517. },
  2518. },
  2519. },
  2520. {
  2521. name: "success with empty list",
  2522. queryParams: "?type=2",
  2523. wantStatusCode: http.StatusOK,
  2524. wantResponse: `[]`,
  2525. mockParams: mockParams{
  2526. bartAssetManagerParams: bartAssetManagerParams{
  2527. listBARTItemsParams: listBARTItemsParams{
  2528. {
  2529. itemType: 2,
  2530. result: []state.BARTItem{},
  2531. err: nil,
  2532. },
  2533. },
  2534. },
  2535. },
  2536. },
  2537. {
  2538. name: "missing type parameter",
  2539. queryParams: "",
  2540. wantStatusCode: http.StatusBadRequest,
  2541. wantResponse: `{"message":"type query parameter is required"}`,
  2542. },
  2543. {
  2544. name: "invalid type parameter",
  2545. queryParams: "?type=invalid",
  2546. wantStatusCode: http.StatusBadRequest,
  2547. wantResponse: `{"message":"invalid type ID"}`,
  2548. },
  2549. {
  2550. name: "internal server error",
  2551. queryParams: "?type=1",
  2552. wantStatusCode: http.StatusInternalServerError,
  2553. wantResponse: `{"message":"internal server error"}`,
  2554. mockParams: mockParams{
  2555. bartAssetManagerParams: bartAssetManagerParams{
  2556. listBARTItemsParams: listBARTItemsParams{
  2557. {
  2558. itemType: 1,
  2559. result: nil,
  2560. err: errors.New("database error"),
  2561. },
  2562. },
  2563. },
  2564. },
  2565. },
  2566. }
  2567. for _, tc := range tt {
  2568. t.Run(tc.name, func(t *testing.T) {
  2569. request := httptest.NewRequest(http.MethodGet, "/bart"+tc.queryParams, nil)
  2570. responseRecorder := httptest.NewRecorder()
  2571. mockBARTManager := newMockBARTAssetManager(t)
  2572. for _, params := range tc.mockParams.listBARTItemsParams {
  2573. mockBARTManager.EXPECT().
  2574. ListBARTItems(matchContext(), params.itemType).
  2575. Return(params.result, params.err)
  2576. }
  2577. getBARTByTypeHandler(responseRecorder, request, mockBARTManager, slog.Default())
  2578. assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
  2579. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  2580. })
  2581. }
  2582. }
  2583. func TestBARTHandler_GET(t *testing.T) {
  2584. tt := []struct {
  2585. name string
  2586. hash string
  2587. wantStatusCode int
  2588. wantResponse string
  2589. wantHeaders map[string]string
  2590. mockParams mockParams
  2591. }{
  2592. {
  2593. name: "success with valid hash",
  2594. hash: "2B000001E4",
  2595. wantStatusCode: http.StatusOK,
  2596. wantResponse: "binary data",
  2597. wantHeaders: map[string]string{"Content-Type": "application/octet-stream"},
  2598. mockParams: mockParams{
  2599. bartAssetManagerParams: bartAssetManagerParams{
  2600. bartItemParams: bartItemParams{
  2601. {
  2602. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2603. result: []byte("binary data"),
  2604. err: nil,
  2605. },
  2606. },
  2607. },
  2608. },
  2609. },
  2610. {
  2611. name: "missing hash parameter",
  2612. hash: "",
  2613. wantStatusCode: http.StatusBadRequest,
  2614. wantResponse: `{"message":"hash is required"}`,
  2615. },
  2616. {
  2617. name: "invalid hash format",
  2618. hash: "invalid-hex",
  2619. wantStatusCode: http.StatusBadRequest,
  2620. wantResponse: `{"message":"invalid hash format"}`,
  2621. },
  2622. {
  2623. name: "asset not found",
  2624. hash: "2B000001E4",
  2625. wantStatusCode: http.StatusNotFound,
  2626. wantResponse: `{"message":"BART asset not found"}`,
  2627. mockParams: mockParams{
  2628. bartAssetManagerParams: bartAssetManagerParams{
  2629. bartItemParams: bartItemParams{
  2630. {
  2631. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2632. result: []byte{},
  2633. err: nil,
  2634. },
  2635. },
  2636. },
  2637. },
  2638. },
  2639. {
  2640. name: "internal server error",
  2641. hash: "2B000001E4",
  2642. wantStatusCode: http.StatusInternalServerError,
  2643. wantResponse: `{"message":"internal server error"}`,
  2644. mockParams: mockParams{
  2645. bartAssetManagerParams: bartAssetManagerParams{
  2646. bartItemParams: bartItemParams{
  2647. {
  2648. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2649. result: nil,
  2650. err: errors.New("database error"),
  2651. },
  2652. },
  2653. },
  2654. },
  2655. },
  2656. }
  2657. for _, tc := range tt {
  2658. t.Run(tc.name, func(t *testing.T) {
  2659. request := httptest.NewRequest(http.MethodGet, "/bart/"+tc.hash, nil)
  2660. // Set the path value manually for testing
  2661. if tc.hash != "" {
  2662. request.SetPathValue("hash", tc.hash)
  2663. }
  2664. responseRecorder := httptest.NewRecorder()
  2665. mockBARTManager := newMockBARTAssetManager(t)
  2666. for _, params := range tc.mockParams.bartItemParams {
  2667. mockBARTManager.EXPECT().
  2668. BARTItem(matchContext(), params.hash).
  2669. Return(params.result, params.err)
  2670. }
  2671. getBARTHandler(responseRecorder, request, mockBARTManager, slog.Default())
  2672. assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
  2673. if tc.wantHeaders != nil {
  2674. for key, value := range tc.wantHeaders {
  2675. assert.Equal(t, value, responseRecorder.Header().Get(key))
  2676. }
  2677. }
  2678. if tc.wantStatusCode == http.StatusOK {
  2679. assert.Equal(t, tc.wantResponse, responseRecorder.Body.String())
  2680. } else {
  2681. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  2682. }
  2683. })
  2684. }
  2685. }
  2686. func TestBARTHandler_POST(t *testing.T) {
  2687. tt := []struct {
  2688. name string
  2689. hash string
  2690. queryParams string
  2691. requestBody string
  2692. wantStatusCode int
  2693. wantResponse string
  2694. mockParams mockParams
  2695. }{
  2696. {
  2697. name: "success with valid data",
  2698. hash: "2B000001E4",
  2699. queryParams: "?type=1",
  2700. requestBody: "binary data",
  2701. wantStatusCode: http.StatusCreated,
  2702. wantResponse: `{"hash":"2b000001e4","type":1}`,
  2703. mockParams: mockParams{
  2704. bartAssetManagerParams: bartAssetManagerParams{
  2705. insertBARTItemParams: insertBARTItemParams{
  2706. {
  2707. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2708. blob: []byte("binary data"),
  2709. itemType: 1,
  2710. err: nil,
  2711. },
  2712. },
  2713. },
  2714. },
  2715. },
  2716. {
  2717. name: "missing hash parameter",
  2718. hash: "",
  2719. queryParams: "?type=1",
  2720. requestBody: "binary data",
  2721. wantStatusCode: http.StatusBadRequest,
  2722. wantResponse: `{"message":"hash path parameter is required"}`,
  2723. },
  2724. {
  2725. name: "invalid hash format",
  2726. hash: "invalid-hex",
  2727. queryParams: "?type=1",
  2728. requestBody: "binary data",
  2729. wantStatusCode: http.StatusBadRequest,
  2730. wantResponse: `{"message":"invalid hash format"}`,
  2731. },
  2732. {
  2733. name: "missing type parameter",
  2734. hash: "2B000001E4",
  2735. queryParams: "",
  2736. requestBody: "binary data",
  2737. wantStatusCode: http.StatusBadRequest,
  2738. wantResponse: `{"message":"type query parameter is required"}`,
  2739. },
  2740. {
  2741. name: "invalid type parameter",
  2742. hash: "2B000001E4",
  2743. queryParams: "?type=invalid",
  2744. requestBody: "binary data",
  2745. wantStatusCode: http.StatusBadRequest,
  2746. wantResponse: `{"message":"invalid type ID"}`,
  2747. },
  2748. {
  2749. name: "failed to read request body",
  2750. hash: "2B000001E4",
  2751. queryParams: "?type=1",
  2752. requestBody: "", // This will cause an error when reading
  2753. wantStatusCode: http.StatusBadRequest,
  2754. wantResponse: `{"message":"failed to read request body"}`,
  2755. },
  2756. {
  2757. name: "asset already exists",
  2758. hash: "2B000001E4",
  2759. queryParams: "?type=1",
  2760. requestBody: "binary data",
  2761. wantStatusCode: http.StatusConflict,
  2762. wantResponse: `{"message":"BART asset already exists"}`,
  2763. mockParams: mockParams{
  2764. bartAssetManagerParams: bartAssetManagerParams{
  2765. insertBARTItemParams: insertBARTItemParams{
  2766. {
  2767. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2768. blob: []byte("binary data"),
  2769. itemType: 1,
  2770. err: state.ErrBARTItemExists,
  2771. },
  2772. },
  2773. },
  2774. },
  2775. },
  2776. {
  2777. name: "internal server error",
  2778. hash: "2B000001E4",
  2779. queryParams: "?type=1",
  2780. requestBody: "binary data",
  2781. wantStatusCode: http.StatusInternalServerError,
  2782. wantResponse: `{"message":"internal server error"}`,
  2783. mockParams: mockParams{
  2784. bartAssetManagerParams: bartAssetManagerParams{
  2785. insertBARTItemParams: insertBARTItemParams{
  2786. {
  2787. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2788. blob: []byte("binary data"),
  2789. itemType: 1,
  2790. err: errors.New("database error"),
  2791. },
  2792. },
  2793. },
  2794. },
  2795. },
  2796. }
  2797. for _, tc := range tt {
  2798. t.Run(tc.name, func(t *testing.T) {
  2799. var requestBody io.Reader
  2800. if tc.requestBody != "" {
  2801. requestBody = strings.NewReader(tc.requestBody)
  2802. } else {
  2803. requestBody = &errorReader{}
  2804. }
  2805. request := httptest.NewRequest(http.MethodPost, "/bart/"+tc.hash+tc.queryParams, requestBody)
  2806. // Set the path value manually for testing
  2807. if tc.hash != "" {
  2808. request.SetPathValue("hash", tc.hash)
  2809. }
  2810. responseRecorder := httptest.NewRecorder()
  2811. mockBARTManager := newMockBARTAssetManager(t)
  2812. for _, params := range tc.mockParams.insertBARTItemParams {
  2813. mockBARTManager.EXPECT().
  2814. InsertBARTItem(matchContext(), params.hash, params.blob, params.itemType).
  2815. Return(params.err)
  2816. }
  2817. postBARTHandler(responseRecorder, request, mockBARTManager, slog.Default())
  2818. assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
  2819. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  2820. })
  2821. }
  2822. }
  2823. func TestBARTHandler_DELETE(t *testing.T) {
  2824. tt := []struct {
  2825. name string
  2826. hash string
  2827. wantStatusCode int
  2828. wantResponse string
  2829. mockParams mockParams
  2830. }{
  2831. {
  2832. name: "success with valid hash",
  2833. hash: "2B000001E4",
  2834. wantStatusCode: http.StatusOK,
  2835. wantResponse: `{"message":"BART asset deleted successfully."}`,
  2836. mockParams: mockParams{
  2837. bartAssetManagerParams: bartAssetManagerParams{
  2838. deleteBARTItemParams: deleteBARTItemParams{
  2839. {
  2840. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2841. err: nil,
  2842. },
  2843. },
  2844. },
  2845. },
  2846. },
  2847. {
  2848. name: "missing hash parameter",
  2849. hash: "",
  2850. wantStatusCode: http.StatusBadRequest,
  2851. wantResponse: `{"message":"hash path parameter is required"}`,
  2852. },
  2853. {
  2854. name: "invalid hash format",
  2855. hash: "invalid-hex",
  2856. wantStatusCode: http.StatusBadRequest,
  2857. wantResponse: `{"message":"invalid hash format"}`,
  2858. },
  2859. {
  2860. name: "asset not found",
  2861. hash: "2B000001E4",
  2862. wantStatusCode: http.StatusNotFound,
  2863. wantResponse: `{"message":"BART asset not found"}`,
  2864. mockParams: mockParams{
  2865. bartAssetManagerParams: bartAssetManagerParams{
  2866. deleteBARTItemParams: deleteBARTItemParams{
  2867. {
  2868. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2869. err: state.ErrBARTItemNotFound,
  2870. },
  2871. },
  2872. },
  2873. },
  2874. },
  2875. {
  2876. name: "internal server error",
  2877. hash: "2B000001E4",
  2878. wantStatusCode: http.StatusInternalServerError,
  2879. wantResponse: `{"message":"internal server error"}`,
  2880. mockParams: mockParams{
  2881. bartAssetManagerParams: bartAssetManagerParams{
  2882. deleteBARTItemParams: deleteBARTItemParams{
  2883. {
  2884. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2885. err: errors.New("database error"),
  2886. },
  2887. },
  2888. },
  2889. },
  2890. },
  2891. }
  2892. for _, tc := range tt {
  2893. t.Run(tc.name, func(t *testing.T) {
  2894. request := httptest.NewRequest(http.MethodDelete, "/bart/"+tc.hash, nil)
  2895. // Set the path value manually for testing
  2896. if tc.hash != "" {
  2897. request.SetPathValue("hash", tc.hash)
  2898. }
  2899. responseRecorder := httptest.NewRecorder()
  2900. mockBARTManager := newMockBARTAssetManager(t)
  2901. for _, params := range tc.mockParams.deleteBARTItemParams {
  2902. mockBARTManager.EXPECT().
  2903. DeleteBARTItem(matchContext(), params.hash).
  2904. Return(params.err)
  2905. }
  2906. deleteBARTHandler(responseRecorder, request, mockBARTManager, slog.Default())
  2907. assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
  2908. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  2909. })
  2910. }
  2911. }
  2912. // errorReader is a helper type that always returns an error when reading
  2913. type errorReader struct{}
  2914. func (er *errorReader) Read(p []byte) (n int, err error) {
  2915. return 0, errors.New("read error")
  2916. }
  2917. func TestFeedbagBuddyHandler_GET(t *testing.T) {
  2918. tt := []struct {
  2919. name string
  2920. screenName string
  2921. wantStatusCode int
  2922. wantResponse string
  2923. mockParams mockParams
  2924. }{
  2925. {
  2926. name: "empty feedbag",
  2927. screenName: "userA",
  2928. wantStatusCode: http.StatusNotFound,
  2929. wantResponse: `{"message":"feedbag not found"}`,
  2930. mockParams: mockParams{
  2931. feedbagManagerParams: feedbagManagerParams{
  2932. feedbagParams: feedbagParams{
  2933. {
  2934. screenName: state.NewIdentScreenName("userA"),
  2935. result: []wire.FeedbagItem{},
  2936. err: nil,
  2937. },
  2938. },
  2939. },
  2940. },
  2941. },
  2942. {
  2943. name: "feedbag with buddies in groups",
  2944. screenName: "userA",
  2945. wantStatusCode: http.StatusOK,
  2946. wantResponse: `[{"group_id":1,"group_name":"Friends","buddies":[{"name":"buddy1","item_id":10},{"name":"buddy2","item_id":11}]},{"group_id":2,"group_name":"Work","buddies":[{"name":"buddy3","item_id":20}]}]`,
  2947. mockParams: mockParams{
  2948. feedbagManagerParams: feedbagManagerParams{
  2949. feedbagParams: feedbagParams{
  2950. {
  2951. screenName: state.NewIdentScreenName("userA"),
  2952. result: []wire.FeedbagItem{
  2953. {
  2954. ItemID: 0,
  2955. ClassID: wire.FeedbagClassIdGroup,
  2956. Name: "",
  2957. GroupID: 0,
  2958. },
  2959. {
  2960. ItemID: 1,
  2961. ClassID: wire.FeedbagClassIdGroup,
  2962. Name: "Friends",
  2963. GroupID: 1,
  2964. TLVLBlock: wire.TLVLBlock{
  2965. TLVList: wire.TLVList{
  2966. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{10, 11}),
  2967. },
  2968. },
  2969. },
  2970. {
  2971. ItemID: 2,
  2972. ClassID: wire.FeedbagClassIdGroup,
  2973. Name: "Work",
  2974. GroupID: 2,
  2975. TLVLBlock: wire.TLVLBlock{
  2976. TLVList: wire.TLVList{
  2977. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{20}),
  2978. },
  2979. },
  2980. },
  2981. {
  2982. ItemID: 10,
  2983. ClassID: wire.FeedbagClassIdBuddy,
  2984. Name: "buddy1",
  2985. GroupID: 1,
  2986. },
  2987. {
  2988. ItemID: 11,
  2989. ClassID: wire.FeedbagClassIdBuddy,
  2990. Name: "buddy2",
  2991. GroupID: 1,
  2992. },
  2993. {
  2994. ItemID: 20,
  2995. ClassID: wire.FeedbagClassIdBuddy,
  2996. Name: "buddy3",
  2997. GroupID: 2,
  2998. },
  2999. },
  3000. err: nil,
  3001. },
  3002. },
  3003. },
  3004. },
  3005. },
  3006. {
  3007. name: "feedbag with no groups (besides root)",
  3008. screenName: "userA",
  3009. wantStatusCode: http.StatusOK,
  3010. wantResponse: `[]`,
  3011. mockParams: mockParams{
  3012. feedbagManagerParams: feedbagManagerParams{
  3013. feedbagParams: feedbagParams{
  3014. {
  3015. screenName: state.NewIdentScreenName("userA"),
  3016. result: []wire.FeedbagItem{
  3017. {
  3018. ItemID: 0,
  3019. ClassID: wire.FeedbagClassIdGroup,
  3020. Name: "",
  3021. GroupID: 0,
  3022. },
  3023. },
  3024. err: nil,
  3025. },
  3026. },
  3027. },
  3028. },
  3029. // Note: Root groups (GroupID == 0) are skipped by the implementation,
  3030. // so the response will be an empty array []
  3031. },
  3032. {
  3033. name: "missing screen_name",
  3034. screenName: "",
  3035. wantStatusCode: http.StatusBadRequest,
  3036. wantResponse: `{"message":"screen_name is required"}`,
  3037. },
  3038. {
  3039. name: "internal server error",
  3040. screenName: "userA",
  3041. wantStatusCode: http.StatusInternalServerError,
  3042. wantResponse: `{"message":"internal server error"}`,
  3043. mockParams: mockParams{
  3044. feedbagManagerParams: feedbagManagerParams{
  3045. feedbagParams: feedbagParams{
  3046. {
  3047. screenName: state.NewIdentScreenName("userA"),
  3048. result: nil,
  3049. err: errors.New("database error"),
  3050. },
  3051. },
  3052. },
  3053. },
  3054. },
  3055. }
  3056. for _, tc := range tt {
  3057. t.Run(tc.name, func(t *testing.T) {
  3058. request := httptest.NewRequest(http.MethodGet, "/feedbag/"+tc.screenName+"/group", nil)
  3059. if tc.screenName != "" {
  3060. request.SetPathValue("screen_name", tc.screenName)
  3061. }
  3062. responseRecorder := httptest.NewRecorder()
  3063. feedbagManager := newMockFeedbagManager(t)
  3064. for _, params := range tc.mockParams.feedbagParams {
  3065. feedbagManager.EXPECT().
  3066. Feedbag(matchContext(), params.screenName).
  3067. Return(params.result, params.err)
  3068. }
  3069. getFeedbagBuddyHandler(responseRecorder, request, feedbagManager, slog.Default())
  3070. assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
  3071. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  3072. })
  3073. }
  3074. }
  3075. func TestFeedbagGroupHandler_PUT(t *testing.T) {
  3076. tt := []struct {
  3077. name string
  3078. screenName string
  3079. groupName string
  3080. groupIDGen func(n int) int
  3081. wantStatusCode int
  3082. wantResponse string
  3083. mockParams mockParams
  3084. }{
  3085. {
  3086. name: "add group to empty feedbag",
  3087. screenName: "userA",
  3088. groupName: "Friends",
  3089. groupIDGen: func(n int) int { return 5 },
  3090. wantStatusCode: http.StatusCreated,
  3091. wantResponse: `{"group_id":5,"group_name":"Friends"}`,
  3092. mockParams: mockParams{
  3093. feedbagManagerParams: feedbagManagerParams{
  3094. feedbagParams: feedbagParams{
  3095. {
  3096. screenName: state.NewIdentScreenName("userA"),
  3097. result: []wire.FeedbagItem{},
  3098. err: nil,
  3099. },
  3100. },
  3101. feedbagUpsertParams: feedbagUpsertParams{
  3102. {
  3103. screenName: state.NewIdentScreenName("userA"),
  3104. items: []wire.FeedbagItem{
  3105. {
  3106. ClassID: wire.FeedbagClassIdGroup,
  3107. GroupID: 0,
  3108. TLVLBlock: wire.TLVLBlock{
  3109. TLVList: wire.TLVList{
  3110. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{5}),
  3111. },
  3112. },
  3113. },
  3114. {
  3115. ClassID: wire.FeedbagClassIdGroup,
  3116. Name: "Friends",
  3117. GroupID: 5,
  3118. },
  3119. },
  3120. err: nil,
  3121. },
  3122. },
  3123. },
  3124. messageRelayerParams: messageRelayerParams{
  3125. relayToScreenNameParams: relayToScreenNameParams{
  3126. {
  3127. screenName: state.NewIdentScreenName("userA"),
  3128. msg: wire.SNACMessage{
  3129. Frame: wire.SNACFrame{
  3130. FoodGroup: wire.Feedbag,
  3131. SubGroup: wire.FeedbagInsertItem,
  3132. RequestID: wire.ReqIDFromServer,
  3133. },
  3134. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  3135. Items: []wire.FeedbagItem{
  3136. {
  3137. ClassID: wire.FeedbagClassIdGroup,
  3138. GroupID: 0,
  3139. TLVLBlock: wire.TLVLBlock{
  3140. TLVList: wire.TLVList{
  3141. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{5}),
  3142. },
  3143. },
  3144. },
  3145. {
  3146. ClassID: wire.FeedbagClassIdGroup,
  3147. Name: "Friends",
  3148. GroupID: 5,
  3149. },
  3150. },
  3151. },
  3152. },
  3153. },
  3154. },
  3155. },
  3156. },
  3157. },
  3158. {
  3159. name: "add group to feedbag with existing root",
  3160. screenName: "userA",
  3161. groupName: "Coworkers",
  3162. groupIDGen: func(n int) int { return 2 },
  3163. wantStatusCode: http.StatusCreated,
  3164. wantResponse: `{"group_id":2,"group_name":"Coworkers"}`,
  3165. mockParams: mockParams{
  3166. feedbagManagerParams: feedbagManagerParams{
  3167. feedbagParams: feedbagParams{
  3168. {
  3169. screenName: state.NewIdentScreenName("userA"),
  3170. result: []wire.FeedbagItem{
  3171. {
  3172. ClassID: wire.FeedbagClassIdGroup,
  3173. GroupID: 0,
  3174. TLVLBlock: wire.TLVLBlock{
  3175. TLVList: wire.TLVList{
  3176. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1}),
  3177. },
  3178. },
  3179. },
  3180. {
  3181. ClassID: wire.FeedbagClassIdGroup,
  3182. Name: "Buddies",
  3183. GroupID: 1,
  3184. },
  3185. },
  3186. err: nil,
  3187. },
  3188. },
  3189. feedbagUpsertParams: feedbagUpsertParams{
  3190. {
  3191. screenName: state.NewIdentScreenName("userA"),
  3192. items: []wire.FeedbagItem{
  3193. {
  3194. ClassID: wire.FeedbagClassIdGroup,
  3195. GroupID: 0,
  3196. TLVLBlock: wire.TLVLBlock{
  3197. TLVList: wire.TLVList{
  3198. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1, 2}),
  3199. },
  3200. },
  3201. },
  3202. {
  3203. ClassID: wire.FeedbagClassIdGroup,
  3204. Name: "Coworkers",
  3205. GroupID: 2,
  3206. },
  3207. },
  3208. err: nil,
  3209. },
  3210. },
  3211. },
  3212. messageRelayerParams: messageRelayerParams{
  3213. relayToScreenNameParams: relayToScreenNameParams{
  3214. {
  3215. screenName: state.NewIdentScreenName("userA"),
  3216. msg: wire.SNACMessage{
  3217. Frame: wire.SNACFrame{
  3218. FoodGroup: wire.Feedbag,
  3219. SubGroup: wire.FeedbagInsertItem,
  3220. RequestID: wire.ReqIDFromServer,
  3221. },
  3222. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  3223. Items: []wire.FeedbagItem{
  3224. {
  3225. ClassID: wire.FeedbagClassIdGroup,
  3226. GroupID: 0,
  3227. TLVLBlock: wire.TLVLBlock{
  3228. TLVList: wire.TLVList{
  3229. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1, 2}),
  3230. },
  3231. },
  3232. },
  3233. {
  3234. ClassID: wire.FeedbagClassIdGroup,
  3235. Name: "Coworkers",
  3236. GroupID: 2,
  3237. },
  3238. },
  3239. },
  3240. },
  3241. },
  3242. },
  3243. },
  3244. },
  3245. },
  3246. {
  3247. name: "group already exists",
  3248. screenName: "userA",
  3249. groupName: "Friends",
  3250. groupIDGen: func(n int) int { return 99 },
  3251. wantStatusCode: http.StatusOK,
  3252. wantResponse: `{"group_id":1,"group_name":"Friends"}`,
  3253. mockParams: mockParams{
  3254. feedbagManagerParams: feedbagManagerParams{
  3255. feedbagParams: feedbagParams{
  3256. {
  3257. screenName: state.NewIdentScreenName("userA"),
  3258. result: []wire.FeedbagItem{
  3259. {
  3260. ClassID: wire.FeedbagClassIdGroup,
  3261. GroupID: 0,
  3262. },
  3263. {
  3264. ClassID: wire.FeedbagClassIdGroup,
  3265. Name: "Friends",
  3266. GroupID: 1,
  3267. },
  3268. },
  3269. err: nil,
  3270. },
  3271. },
  3272. },
  3273. },
  3274. },
  3275. {
  3276. name: "missing screen_name",
  3277. screenName: "",
  3278. groupName: "Friends",
  3279. groupIDGen: func(n int) int { return 5 },
  3280. wantStatusCode: http.StatusBadRequest,
  3281. wantResponse: `{"message":"screen_name is required"}`,
  3282. },
  3283. {
  3284. name: "missing group_name",
  3285. screenName: "userA",
  3286. groupName: "",
  3287. groupIDGen: func(n int) int { return 5 },
  3288. wantStatusCode: http.StatusBadRequest,
  3289. wantResponse: `{"message":"group_name is required"}`,
  3290. },
  3291. {
  3292. name: "error retrieving feedbag",
  3293. screenName: "userA",
  3294. groupName: "Friends",
  3295. groupIDGen: func(n int) int { return 5 },
  3296. wantStatusCode: http.StatusInternalServerError,
  3297. wantResponse: `{"message":"internal server error"}`,
  3298. mockParams: mockParams{
  3299. feedbagManagerParams: feedbagManagerParams{
  3300. feedbagParams: feedbagParams{
  3301. {
  3302. screenName: state.NewIdentScreenName("userA"),
  3303. result: nil,
  3304. err: errors.New("database error"),
  3305. },
  3306. },
  3307. },
  3308. },
  3309. },
  3310. {
  3311. name: "error upserting feedbag",
  3312. screenName: "userA",
  3313. groupName: "Friends",
  3314. groupIDGen: func(n int) int { return 5 },
  3315. wantStatusCode: http.StatusInternalServerError,
  3316. wantResponse: `{"message":"internal server error"}`,
  3317. mockParams: mockParams{
  3318. feedbagManagerParams: feedbagManagerParams{
  3319. feedbagParams: feedbagParams{
  3320. {
  3321. screenName: state.NewIdentScreenName("userA"),
  3322. result: []wire.FeedbagItem{},
  3323. err: nil,
  3324. },
  3325. },
  3326. feedbagUpsertParams: feedbagUpsertParams{
  3327. {
  3328. screenName: state.NewIdentScreenName("userA"),
  3329. items: []wire.FeedbagItem{
  3330. {
  3331. ClassID: wire.FeedbagClassIdGroup,
  3332. GroupID: 0,
  3333. TLVLBlock: wire.TLVLBlock{
  3334. TLVList: wire.TLVList{
  3335. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{5}),
  3336. },
  3337. },
  3338. },
  3339. {
  3340. ClassID: wire.FeedbagClassIdGroup,
  3341. Name: "Friends",
  3342. GroupID: 5,
  3343. },
  3344. },
  3345. err: errors.New("database error"),
  3346. },
  3347. },
  3348. },
  3349. },
  3350. },
  3351. }
  3352. for _, tc := range tt {
  3353. t.Run(tc.name, func(t *testing.T) {
  3354. request := httptest.NewRequest(http.MethodPut, "/feedbag/"+tc.screenName+"/group/"+tc.groupName, nil)
  3355. if tc.screenName != "" {
  3356. request.SetPathValue("screen_name", tc.screenName)
  3357. }
  3358. if tc.groupName != "" {
  3359. request.SetPathValue("group_name", tc.groupName)
  3360. }
  3361. responseRecorder := httptest.NewRecorder()
  3362. feedbagManager := newMockFeedbagManager(t)
  3363. messageRelayer := newMockMessageRelayer(t)
  3364. for _, params := range tc.mockParams.feedbagParams {
  3365. feedbagManager.EXPECT().
  3366. Feedbag(matchContext(), params.screenName).
  3367. Return(params.result, params.err)
  3368. }
  3369. for _, params := range tc.mockParams.feedbagUpsertParams {
  3370. feedbagManager.EXPECT().
  3371. FeedbagUpsert(matchContext(), params.screenName, params.items).
  3372. Return(params.err)
  3373. }
  3374. for _, params := range tc.mockParams.relayToScreenNameParams {
  3375. messageRelayer.EXPECT().
  3376. RelayToScreenName(matchContext(), params.screenName, params.msg)
  3377. }
  3378. putFeedbagGroupHandler(responseRecorder, request, feedbagManager, messageRelayer, slog.Default(), tc.groupIDGen)
  3379. assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
  3380. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  3381. })
  3382. }
  3383. }
  3384. func TestFeedbagBuddyHandler_PUT(t *testing.T) {
  3385. tt := []struct {
  3386. name string
  3387. screenName string
  3388. groupID string
  3389. requestBody string
  3390. wantStatusCode int
  3391. wantResponse string
  3392. mockParams mockParams
  3393. }{
  3394. {
  3395. name: "add a buddy to an empty group, user not signed in",
  3396. screenName: "userA",
  3397. groupID: "1",
  3398. requestBody: `{"name":"newbuddy"}`,
  3399. wantStatusCode: http.StatusOK,
  3400. wantResponse: `{"name":"newbuddy","group_id":1,"item_id":1000}`,
  3401. mockParams: mockParams{
  3402. feedbagManagerParams: feedbagManagerParams{
  3403. feedbagParams: feedbagParams{
  3404. {
  3405. screenName: state.NewIdentScreenName("userA"),
  3406. result: []wire.FeedbagItem{
  3407. {
  3408. ClassID: wire.FeedbagClassIdGroup,
  3409. Name: "Friends",
  3410. GroupID: 1,
  3411. },
  3412. },
  3413. err: nil,
  3414. },
  3415. },
  3416. feedbagUpsertParams: feedbagUpsertParams{
  3417. {
  3418. screenName: state.NewIdentScreenName("userA"),
  3419. items: []wire.FeedbagItem{
  3420. {
  3421. Name: "newbuddy",
  3422. GroupID: 1,
  3423. ItemID: 1000,
  3424. ClassID: wire.FeedbagClassIdBuddy,
  3425. },
  3426. {
  3427. ClassID: wire.FeedbagClassIdGroup,
  3428. Name: "Friends",
  3429. GroupID: 1,
  3430. TLVLBlock: wire.TLVLBlock{
  3431. TLVList: wire.TLVList{
  3432. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1000}),
  3433. },
  3434. },
  3435. },
  3436. },
  3437. err: nil,
  3438. },
  3439. },
  3440. },
  3441. sessionRetrieverParams: sessionRetrieverParams{
  3442. retrieveSessionByNameParams: retrieveSessionByNameParams{
  3443. {
  3444. screenName: state.NewIdentScreenName("userA"),
  3445. result: state.NewSession(),
  3446. },
  3447. },
  3448. },
  3449. messageRelayerParams: messageRelayerParams{
  3450. relayToScreenNameParams: relayToScreenNameParams{
  3451. {
  3452. screenName: state.NewIdentScreenName("userA"),
  3453. msg: wire.SNACMessage{
  3454. Frame: wire.SNACFrame{
  3455. FoodGroup: wire.Feedbag,
  3456. SubGroup: wire.FeedbagInsertItem,
  3457. RequestID: wire.ReqIDFromServer,
  3458. },
  3459. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  3460. Items: []wire.FeedbagItem{
  3461. {
  3462. Name: "newbuddy",
  3463. GroupID: 1,
  3464. ItemID: 1000,
  3465. ClassID: wire.FeedbagClassIdBuddy,
  3466. },
  3467. },
  3468. },
  3469. },
  3470. },
  3471. {
  3472. screenName: state.NewIdentScreenName("userA"),
  3473. msg: wire.SNACMessage{
  3474. Frame: wire.SNACFrame{
  3475. FoodGroup: wire.Feedbag,
  3476. SubGroup: wire.FeedbagUpdateItem,
  3477. RequestID: wire.ReqIDFromServer,
  3478. },
  3479. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  3480. Items: []wire.FeedbagItem{
  3481. {
  3482. ClassID: wire.FeedbagClassIdGroup,
  3483. Name: "Friends",
  3484. GroupID: 1,
  3485. TLVLBlock: wire.TLVLBlock{
  3486. TLVList: wire.TLVList{
  3487. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1000}),
  3488. },
  3489. },
  3490. },
  3491. },
  3492. },
  3493. },
  3494. },
  3495. },
  3496. },
  3497. },
  3498. },
  3499. {
  3500. name: "add a buddy to a non-empty group, user not signed in",
  3501. screenName: "userA",
  3502. groupID: "1",
  3503. requestBody: `{"name":"newbuddy2"}`,
  3504. wantStatusCode: http.StatusOK,
  3505. wantResponse: `{"name":"newbuddy2","group_id":1,"item_id":1000}`,
  3506. mockParams: mockParams{
  3507. feedbagManagerParams: feedbagManagerParams{
  3508. feedbagParams: feedbagParams{
  3509. {
  3510. screenName: state.NewIdentScreenName("userA"),
  3511. result: []wire.FeedbagItem{
  3512. {
  3513. ClassID: wire.FeedbagClassIdGroup,
  3514. Name: "Friends",
  3515. GroupID: 1,
  3516. TLVLBlock: wire.TLVLBlock{
  3517. TLVList: wire.TLVList{
  3518. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{12345}),
  3519. },
  3520. },
  3521. },
  3522. {
  3523. ItemID: 12345,
  3524. ClassID: wire.FeedbagClassIdBuddy,
  3525. Name: "existingbuddy",
  3526. GroupID: 1,
  3527. },
  3528. },
  3529. err: nil,
  3530. },
  3531. },
  3532. feedbagUpsertParams: feedbagUpsertParams{
  3533. {
  3534. screenName: state.NewIdentScreenName("userA"),
  3535. items: []wire.FeedbagItem{
  3536. {
  3537. Name: "newbuddy2",
  3538. GroupID: 1,
  3539. ItemID: 1000,
  3540. ClassID: wire.FeedbagClassIdBuddy,
  3541. },
  3542. {
  3543. ClassID: wire.FeedbagClassIdGroup,
  3544. Name: "Friends",
  3545. GroupID: 1,
  3546. TLVLBlock: wire.TLVLBlock{
  3547. TLVList: wire.TLVList{
  3548. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{12345, 1000}),
  3549. },
  3550. },
  3551. },
  3552. },
  3553. err: nil,
  3554. },
  3555. },
  3556. },
  3557. sessionRetrieverParams: sessionRetrieverParams{
  3558. retrieveSessionByNameParams: retrieveSessionByNameParams{
  3559. {
  3560. screenName: state.NewIdentScreenName("userA"),
  3561. result: state.NewSession(),
  3562. },
  3563. },
  3564. },
  3565. messageRelayerParams: messageRelayerParams{
  3566. relayToScreenNameParams: relayToScreenNameParams{
  3567. {
  3568. screenName: state.NewIdentScreenName("userA"),
  3569. msg: wire.SNACMessage{
  3570. Frame: wire.SNACFrame{
  3571. FoodGroup: wire.Feedbag,
  3572. SubGroup: wire.FeedbagInsertItem,
  3573. RequestID: wire.ReqIDFromServer,
  3574. },
  3575. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  3576. Items: []wire.FeedbagItem{
  3577. {
  3578. Name: "newbuddy2",
  3579. GroupID: 1,
  3580. ItemID: 1000,
  3581. ClassID: wire.FeedbagClassIdBuddy,
  3582. },
  3583. },
  3584. },
  3585. },
  3586. },
  3587. {
  3588. screenName: state.NewIdentScreenName("userA"),
  3589. msg: wire.SNACMessage{
  3590. Frame: wire.SNACFrame{
  3591. FoodGroup: wire.Feedbag,
  3592. SubGroup: wire.FeedbagUpdateItem,
  3593. RequestID: wire.ReqIDFromServer,
  3594. },
  3595. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  3596. Items: []wire.FeedbagItem{
  3597. {
  3598. ClassID: wire.FeedbagClassIdGroup,
  3599. Name: "Friends",
  3600. GroupID: 1,
  3601. TLVLBlock: wire.TLVLBlock{
  3602. TLVList: wire.TLVList{
  3603. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{12345, 1000}),
  3604. },
  3605. },
  3606. },
  3607. },
  3608. },
  3609. },
  3610. },
  3611. },
  3612. },
  3613. },
  3614. },
  3615. {
  3616. name: "add a buddy that already exists in a group",
  3617. screenName: "userA",
  3618. groupID: "1",
  3619. requestBody: `{"name":"ExistingBuddy"}`,
  3620. wantStatusCode: http.StatusOK,
  3621. wantResponse: `{"name":"ExistingBuddy","group_id":1,"item_id":12345}`,
  3622. mockParams: mockParams{
  3623. feedbagManagerParams: feedbagManagerParams{
  3624. feedbagParams: feedbagParams{
  3625. {
  3626. screenName: state.NewIdentScreenName("userA"),
  3627. result: []wire.FeedbagItem{
  3628. {
  3629. ClassID: wire.FeedbagClassIdGroup,
  3630. Name: "Friends",
  3631. GroupID: 1,
  3632. TLVLBlock: wire.TLVLBlock{
  3633. TLVList: wire.TLVList{
  3634. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{12345}),
  3635. },
  3636. },
  3637. },
  3638. {
  3639. ItemID: 12345,
  3640. ClassID: wire.FeedbagClassIdBuddy,
  3641. Name: "existingbuddy",
  3642. GroupID: 1,
  3643. },
  3644. },
  3645. err: nil,
  3646. },
  3647. },
  3648. // No FeedbagUpsert should be called when buddy already exists
  3649. },
  3650. // No session retrieval or message relaying should occur
  3651. },
  3652. },
  3653. {
  3654. name: "add a buddy to an empty group, user signed in",
  3655. screenName: "userA",
  3656. groupID: "1",
  3657. requestBody: `{"name":"newbuddy"}`,
  3658. wantStatusCode: http.StatusOK,
  3659. wantResponse: `{"name":"newbuddy","group_id":1,"item_id":1000}`,
  3660. mockParams: mockParams{
  3661. feedbagManagerParams: feedbagManagerParams{
  3662. feedbagParams: feedbagParams{
  3663. {
  3664. screenName: state.NewIdentScreenName("userA"),
  3665. result: []wire.FeedbagItem{
  3666. {
  3667. ClassID: wire.FeedbagClassIdGroup,
  3668. Name: "Friends",
  3669. GroupID: 1,
  3670. },
  3671. },
  3672. err: nil,
  3673. },
  3674. },
  3675. feedbagUpsertParams: feedbagUpsertParams{
  3676. {
  3677. screenName: state.NewIdentScreenName("userA"),
  3678. items: []wire.FeedbagItem{
  3679. {
  3680. Name: "newbuddy",
  3681. GroupID: 1,
  3682. ItemID: 1000,
  3683. ClassID: wire.FeedbagClassIdBuddy,
  3684. },
  3685. {
  3686. ClassID: wire.FeedbagClassIdGroup,
  3687. Name: "Friends",
  3688. GroupID: 1,
  3689. TLVLBlock: wire.TLVLBlock{
  3690. TLVList: wire.TLVList{
  3691. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1000}),
  3692. },
  3693. },
  3694. },
  3695. },
  3696. err: nil,
  3697. },
  3698. },
  3699. },
  3700. sessionRetrieverParams: sessionRetrieverParams{
  3701. retrieveSessionByNameParams: retrieveSessionByNameParams{
  3702. {
  3703. screenName: state.NewIdentScreenName("userA"),
  3704. result: func() *state.Session {
  3705. sess := state.NewSession()
  3706. sess.SetIdentScreenName(state.NewIdentScreenName("userA"))
  3707. inst := sess.AddInstance()
  3708. inst.SetSignonComplete()
  3709. return sess
  3710. }(),
  3711. },
  3712. },
  3713. },
  3714. messageRelayerParams: messageRelayerParams{
  3715. relayToScreenNameParams: relayToScreenNameParams{
  3716. {
  3717. screenName: state.NewIdentScreenName("userA"),
  3718. msg: wire.SNACMessage{
  3719. Frame: wire.SNACFrame{
  3720. FoodGroup: wire.Feedbag,
  3721. SubGroup: wire.FeedbagInsertItem,
  3722. RequestID: wire.ReqIDFromServer,
  3723. },
  3724. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  3725. Items: []wire.FeedbagItem{
  3726. {
  3727. Name: "newbuddy",
  3728. GroupID: 1,
  3729. ItemID: 1000,
  3730. ClassID: wire.FeedbagClassIdBuddy,
  3731. },
  3732. },
  3733. },
  3734. },
  3735. },
  3736. {
  3737. screenName: state.NewIdentScreenName("userA"),
  3738. msg: wire.SNACMessage{
  3739. Frame: wire.SNACFrame{
  3740. FoodGroup: wire.Feedbag,
  3741. SubGroup: wire.FeedbagUpdateItem,
  3742. RequestID: wire.ReqIDFromServer,
  3743. },
  3744. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  3745. Items: []wire.FeedbagItem{
  3746. {
  3747. ClassID: wire.FeedbagClassIdGroup,
  3748. Name: "Friends",
  3749. GroupID: 1,
  3750. TLVLBlock: wire.TLVLBlock{
  3751. TLVList: wire.TLVList{
  3752. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1000}),
  3753. },
  3754. },
  3755. },
  3756. },
  3757. },
  3758. },
  3759. },
  3760. },
  3761. },
  3762. buddyBroadcasterParams: buddyBroadcasterParams{
  3763. broadcastVisibilityParams: broadcastVisibilityParams{
  3764. {
  3765. you: nil, // Not used in expectation, matched with mock.AnythingOfType
  3766. filter: []state.IdentScreenName{state.NewIdentScreenName("newbuddy")},
  3767. sendDepartures: false,
  3768. err: nil,
  3769. },
  3770. },
  3771. },
  3772. },
  3773. },
  3774. {
  3775. name: "invalid group_id - non-numeric",
  3776. screenName: "userA",
  3777. groupID: "invalid",
  3778. requestBody: `{"name":"buddy"}`,
  3779. wantStatusCode: http.StatusBadRequest,
  3780. wantResponse: `{"message":"invalid group_id"}`,
  3781. },
  3782. {
  3783. name: "invalid group_id - out of range",
  3784. screenName: "userA",
  3785. groupID: "99999",
  3786. requestBody: `{"name":"buddy"}`,
  3787. wantStatusCode: http.StatusBadRequest,
  3788. wantResponse: `{"message":"invalid group_id"}`,
  3789. },
  3790. {
  3791. name: "can't add buddies to root group",
  3792. screenName: "userA",
  3793. groupID: "0",
  3794. requestBody: `{"name":"buddy"}`,
  3795. wantStatusCode: http.StatusBadRequest,
  3796. wantResponse: `{"message":"can't add buddies to root group"}`,
  3797. },
  3798. {
  3799. name: "empty screen_name",
  3800. screenName: "",
  3801. groupID: "1",
  3802. requestBody: `{"name":"buddy"}`,
  3803. wantStatusCode: http.StatusBadRequest,
  3804. wantResponse: `{"message":"screen_name is required"}`,
  3805. },
  3806. {
  3807. name: "malformed JSON input",
  3808. screenName: "userA",
  3809. groupID: "1",
  3810. requestBody: `invalid json`,
  3811. wantStatusCode: http.StatusBadRequest,
  3812. wantResponse: `{"message":"buddy_screen_name is required"}`,
  3813. },
  3814. {
  3815. name: "empty name in request body",
  3816. screenName: "userA",
  3817. groupID: "1",
  3818. requestBody: `{"name":""}`,
  3819. wantStatusCode: http.StatusBadRequest,
  3820. wantResponse: `{"message":"buddy_screen_name is required"}`,
  3821. },
  3822. {
  3823. name: "missing name in request body",
  3824. screenName: "userA",
  3825. groupID: "1",
  3826. requestBody: `{}`,
  3827. wantStatusCode: http.StatusBadRequest,
  3828. wantResponse: `{"message":"buddy_screen_name is required"}`,
  3829. },
  3830. {
  3831. name: "invalid UIN - too low",
  3832. screenName: "userA",
  3833. groupID: "1",
  3834. requestBody: `{"name":"9999"}`,
  3835. wantStatusCode: http.StatusBadRequest,
  3836. wantResponse: `{"message":"invalid uin: uin must be a number in the range 10000-2147483646"}`,
  3837. },
  3838. {
  3839. name: "invalid UIN - too high",
  3840. screenName: "userA",
  3841. groupID: "1",
  3842. requestBody: `{"name":"2147483647"}`,
  3843. wantStatusCode: http.StatusBadRequest,
  3844. wantResponse: `{"message":"invalid uin: uin must be a number in the range 10000-2147483646"}`,
  3845. },
  3846. {
  3847. name: "invalid AIM handle - too short",
  3848. screenName: "userA",
  3849. groupID: "1",
  3850. requestBody: `{"name":"Us"}`,
  3851. wantStatusCode: http.StatusBadRequest,
  3852. wantResponse: `{"message":"invalid screen name: screen name must be between 3 and 16 characters"}`,
  3853. },
  3854. {
  3855. name: "invalid AIM handle - too long",
  3856. screenName: "userA",
  3857. groupID: "1",
  3858. requestBody: `{"name":"ThisIsAReallyLongScreenName"}`,
  3859. wantStatusCode: http.StatusBadRequest,
  3860. wantResponse: `{"message":"invalid screen name: screen name must be between 3 and 16 characters"}`,
  3861. },
  3862. {
  3863. name: "error retrieving feedbag",
  3864. screenName: "userA",
  3865. groupID: "1",
  3866. requestBody: `{"name":"buddy"}`,
  3867. wantStatusCode: http.StatusInternalServerError,
  3868. wantResponse: `{"message":"internal server error"}`,
  3869. mockParams: mockParams{
  3870. feedbagManagerParams: feedbagManagerParams{
  3871. feedbagParams: feedbagParams{
  3872. {
  3873. screenName: state.NewIdentScreenName("userA"),
  3874. result: nil,
  3875. err: errors.New("database error"),
  3876. },
  3877. },
  3878. },
  3879. },
  3880. },
  3881. {
  3882. name: "too many buddies in group - max 30",
  3883. screenName: "userA",
  3884. groupID: "1",
  3885. requestBody: `{"name":"newbuddy"}`,
  3886. wantStatusCode: http.StatusBadRequest,
  3887. wantResponse: `{"message":"too many buddies in group. max: 30"}`,
  3888. mockParams: mockParams{
  3889. feedbagManagerParams: feedbagManagerParams{
  3890. feedbagParams: feedbagParams{
  3891. {
  3892. screenName: state.NewIdentScreenName("userA"),
  3893. result: func() []wire.FeedbagItem {
  3894. order := make([]uint16, 30)
  3895. for i := 1; i <= 30; i++ {
  3896. order[i-1] = uint16(i)
  3897. }
  3898. items := []wire.FeedbagItem{
  3899. {
  3900. ClassID: wire.FeedbagClassIdGroup,
  3901. Name: "Friends",
  3902. GroupID: 1,
  3903. TLVLBlock: wire.TLVLBlock{
  3904. TLVList: wire.TLVList{
  3905. wire.NewTLVBE(wire.FeedbagAttributesOrder, order),
  3906. },
  3907. },
  3908. },
  3909. }
  3910. // Add 30 buddies to the group
  3911. for i := 1; i <= 30; i++ {
  3912. items = append(items, wire.FeedbagItem{
  3913. ItemID: uint16(i),
  3914. ClassID: wire.FeedbagClassIdBuddy,
  3915. Name: fmt.Sprintf("buddy%d", i),
  3916. GroupID: 1,
  3917. })
  3918. }
  3919. return items
  3920. }(),
  3921. err: nil,
  3922. },
  3923. },
  3924. },
  3925. },
  3926. },
  3927. {
  3928. name: "group not found",
  3929. screenName: "userA",
  3930. groupID: "999",
  3931. requestBody: `{"name":"buddy"}`,
  3932. wantStatusCode: http.StatusNotFound,
  3933. wantResponse: `{"message":"group not found"}`,
  3934. mockParams: mockParams{
  3935. feedbagManagerParams: feedbagManagerParams{
  3936. feedbagParams: feedbagParams{
  3937. {
  3938. screenName: state.NewIdentScreenName("userA"),
  3939. result: []wire.FeedbagItem{
  3940. {
  3941. ClassID: wire.FeedbagClassIdGroup,
  3942. Name: "Friends",
  3943. GroupID: 1,
  3944. },
  3945. },
  3946. err: nil,
  3947. },
  3948. },
  3949. },
  3950. },
  3951. },
  3952. {
  3953. name: "error inserting feedbag item",
  3954. screenName: "userA",
  3955. groupID: "1",
  3956. requestBody: `{"name":"buddy"}`,
  3957. wantStatusCode: http.StatusInternalServerError,
  3958. wantResponse: `{"message":"internal server error"}`,
  3959. mockParams: mockParams{
  3960. feedbagManagerParams: feedbagManagerParams{
  3961. feedbagParams: feedbagParams{
  3962. {
  3963. screenName: state.NewIdentScreenName("userA"),
  3964. result: []wire.FeedbagItem{
  3965. {
  3966. ClassID: wire.FeedbagClassIdGroup,
  3967. Name: "Friends",
  3968. GroupID: 1,
  3969. },
  3970. },
  3971. err: nil,
  3972. },
  3973. },
  3974. feedbagUpsertParams: feedbagUpsertParams{
  3975. {
  3976. screenName: state.NewIdentScreenName("userA"),
  3977. items: []wire.FeedbagItem{
  3978. {
  3979. Name: "buddy",
  3980. GroupID: 1,
  3981. ItemID: 1000,
  3982. ClassID: wire.FeedbagClassIdBuddy,
  3983. },
  3984. {
  3985. ClassID: wire.FeedbagClassIdGroup,
  3986. Name: "Friends",
  3987. GroupID: 1,
  3988. TLVLBlock: wire.TLVLBlock{
  3989. TLVList: wire.TLVList{
  3990. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1000}),
  3991. },
  3992. },
  3993. },
  3994. },
  3995. err: errors.New("database error"),
  3996. },
  3997. },
  3998. },
  3999. },
  4000. },
  4001. }
  4002. for _, tc := range tt {
  4003. t.Run(tc.name, func(t *testing.T) {
  4004. // Extract buddy name from requestBody JSON
  4005. var buddyName string
  4006. if tc.requestBody != "" {
  4007. var input struct {
  4008. Name string `json:"name"`
  4009. }
  4010. if err := json.Unmarshal([]byte(tc.requestBody), &input); err == nil {
  4011. buddyName = input.Name
  4012. }
  4013. }
  4014. request := httptest.NewRequest(http.MethodPut, "/feedbag/"+tc.screenName+"/group/"+tc.groupID+"/buddy/"+buddyName, nil)
  4015. if tc.screenName != "" {
  4016. request.SetPathValue("screen_name", tc.screenName)
  4017. }
  4018. if tc.groupID != "" {
  4019. request.SetPathValue("group_id", tc.groupID)
  4020. }
  4021. request.SetPathValue("buddy_screen_name", buddyName)
  4022. responseRecorder := httptest.NewRecorder()
  4023. feedbagManager := newMockFeedbagManager(t)
  4024. sessionRetriever := newMockSessionRetriever(t)
  4025. messageRelayer := newMockMessageRelayer(t)
  4026. buddyBroadcaster := newMockBuddyBroadcaster(t)
  4027. for _, params := range tc.mockParams.feedbagParams {
  4028. feedbagManager.EXPECT().
  4029. Feedbag(matchContext(), params.screenName).
  4030. Return(params.result, params.err)
  4031. }
  4032. for _, params := range tc.mockParams.feedbagUpsertParams {
  4033. feedbagManager.EXPECT().
  4034. FeedbagUpsert(matchContext(), params.screenName, params.items).
  4035. Return(params.err)
  4036. }
  4037. for _, params := range tc.mockParams.retrieveSessionByNameParams {
  4038. sessionRetriever.EXPECT().
  4039. RetrieveSession(params.screenName).
  4040. Return(params.result)
  4041. }
  4042. for _, params := range tc.mockParams.relayToScreenNameParams {
  4043. messageRelayer.EXPECT().
  4044. RelayToScreenName(matchContext(), params.screenName, params.msg)
  4045. }
  4046. for _, params := range tc.mockParams.broadcastVisibilityParams {
  4047. // Use mock.MatchedBy to match any SessionInstance, since we're mainly verifying filter and sendDepartures
  4048. buddyBroadcaster.EXPECT().
  4049. BroadcastVisibility(
  4050. matchContext(),
  4051. mock.AnythingOfType("*state.SessionInstance"),
  4052. params.filter,
  4053. params.sendDepartures,
  4054. ).
  4055. Return(params.err)
  4056. }
  4057. deterministicItemID := func(n int) int {
  4058. return 1000
  4059. }
  4060. putFeedbagBuddyHandler(responseRecorder, request, buddyBroadcaster, feedbagManager, sessionRetriever, messageRelayer, slog.Default(), deterministicItemID)
  4061. assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
  4062. if tc.wantStatusCode == http.StatusOK {
  4063. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  4064. } else {
  4065. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  4066. }
  4067. })
  4068. }
  4069. }
  4070. func TestFeedbagBuddyHandler_DELETE(t *testing.T) {
  4071. tt := []struct {
  4072. name string
  4073. screenName string
  4074. groupID string
  4075. requestBody string
  4076. wantStatusCode int
  4077. wantResponse string
  4078. mockParams mockParams
  4079. }{
  4080. {
  4081. name: "delete existing buddy, user not signed in",
  4082. screenName: "userA",
  4083. groupID: "1",
  4084. requestBody: `{"name":"buddy1"}`,
  4085. wantStatusCode: http.StatusNoContent,
  4086. mockParams: mockParams{
  4087. feedbagManagerParams: feedbagManagerParams{
  4088. feedbagParams: feedbagParams{
  4089. {
  4090. screenName: state.NewIdentScreenName("userA"),
  4091. result: []wire.FeedbagItem{
  4092. {
  4093. ItemID: 1,
  4094. ClassID: wire.FeedbagClassIdGroup,
  4095. Name: "Friends",
  4096. GroupID: 1,
  4097. TLVLBlock: wire.TLVLBlock{
  4098. TLVList: wire.TLVList{
  4099. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{10}),
  4100. },
  4101. },
  4102. },
  4103. {
  4104. ItemID: 10,
  4105. ClassID: wire.FeedbagClassIdBuddy,
  4106. Name: "buddy1",
  4107. GroupID: 1,
  4108. },
  4109. },
  4110. err: nil,
  4111. },
  4112. },
  4113. feedbagUpsertParams: feedbagUpsertParams{
  4114. {
  4115. screenName: state.NewIdentScreenName("userA"),
  4116. items: []wire.FeedbagItem{
  4117. {
  4118. ItemID: 1,
  4119. ClassID: wire.FeedbagClassIdGroup,
  4120. Name: "Friends",
  4121. GroupID: 1,
  4122. TLVLBlock: wire.TLVLBlock{
  4123. TLVList: wire.TLVList{
  4124. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{}),
  4125. },
  4126. },
  4127. },
  4128. },
  4129. err: nil,
  4130. },
  4131. },
  4132. feedbagDeleteParams: feedbagDeleteParams{
  4133. {
  4134. screenName: state.NewIdentScreenName("userA"),
  4135. items: []wire.FeedbagItem{
  4136. {
  4137. ItemID: 10,
  4138. ClassID: wire.FeedbagClassIdBuddy,
  4139. Name: "buddy1",
  4140. GroupID: 1,
  4141. },
  4142. },
  4143. err: nil,
  4144. },
  4145. },
  4146. },
  4147. sessionRetrieverParams: sessionRetrieverParams{
  4148. retrieveSessionByNameParams: retrieveSessionByNameParams{
  4149. {
  4150. screenName: state.NewIdentScreenName("userA"),
  4151. result: state.NewSession(),
  4152. },
  4153. },
  4154. },
  4155. messageRelayerParams: messageRelayerParams{
  4156. relayToScreenNameParams: relayToScreenNameParams{
  4157. {
  4158. screenName: state.NewIdentScreenName("userA"),
  4159. msg: wire.SNACMessage{
  4160. Frame: wire.SNACFrame{
  4161. FoodGroup: wire.Feedbag,
  4162. SubGroup: wire.FeedbagUpdateItem,
  4163. RequestID: wire.ReqIDFromServer,
  4164. },
  4165. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  4166. Items: []wire.FeedbagItem{
  4167. {
  4168. ItemID: 1,
  4169. ClassID: wire.FeedbagClassIdGroup,
  4170. Name: "Friends",
  4171. GroupID: 1,
  4172. TLVLBlock: wire.TLVLBlock{
  4173. TLVList: wire.TLVList{
  4174. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{}),
  4175. },
  4176. },
  4177. },
  4178. },
  4179. },
  4180. },
  4181. },
  4182. {
  4183. screenName: state.NewIdentScreenName("userA"),
  4184. msg: wire.SNACMessage{
  4185. Frame: wire.SNACFrame{
  4186. FoodGroup: wire.Feedbag,
  4187. SubGroup: wire.FeedbagDeleteItem,
  4188. RequestID: wire.ReqIDFromServer,
  4189. },
  4190. Body: wire.SNAC_0x13_0x0A_FeedbagDeleteItem{
  4191. Items: []wire.FeedbagItem{
  4192. {
  4193. ItemID: 10,
  4194. ClassID: wire.FeedbagClassIdBuddy,
  4195. Name: "buddy1",
  4196. GroupID: 1,
  4197. },
  4198. },
  4199. },
  4200. },
  4201. },
  4202. },
  4203. },
  4204. },
  4205. },
  4206. {
  4207. name: "delete existing buddy, user signed in",
  4208. screenName: "userA",
  4209. groupID: "1",
  4210. requestBody: `{"name":"buddy1"}`,
  4211. wantStatusCode: http.StatusNoContent,
  4212. mockParams: mockParams{
  4213. feedbagManagerParams: feedbagManagerParams{
  4214. feedbagParams: feedbagParams{
  4215. {
  4216. screenName: state.NewIdentScreenName("userA"),
  4217. result: []wire.FeedbagItem{
  4218. {
  4219. ItemID: 1,
  4220. ClassID: wire.FeedbagClassIdGroup,
  4221. Name: "Friends",
  4222. GroupID: 1,
  4223. TLVLBlock: wire.TLVLBlock{
  4224. TLVList: wire.TLVList{
  4225. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{10}),
  4226. },
  4227. },
  4228. },
  4229. {
  4230. ItemID: 10,
  4231. ClassID: wire.FeedbagClassIdBuddy,
  4232. Name: "buddy1",
  4233. GroupID: 1,
  4234. },
  4235. },
  4236. err: nil,
  4237. },
  4238. },
  4239. feedbagUpsertParams: feedbagUpsertParams{
  4240. {
  4241. screenName: state.NewIdentScreenName("userA"),
  4242. items: []wire.FeedbagItem{
  4243. {
  4244. ItemID: 1,
  4245. ClassID: wire.FeedbagClassIdGroup,
  4246. Name: "Friends",
  4247. GroupID: 1,
  4248. TLVLBlock: wire.TLVLBlock{
  4249. TLVList: wire.TLVList{
  4250. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{}),
  4251. },
  4252. },
  4253. },
  4254. },
  4255. err: nil,
  4256. },
  4257. },
  4258. feedbagDeleteParams: feedbagDeleteParams{
  4259. {
  4260. screenName: state.NewIdentScreenName("userA"),
  4261. items: []wire.FeedbagItem{
  4262. {
  4263. ItemID: 10,
  4264. ClassID: wire.FeedbagClassIdBuddy,
  4265. Name: "buddy1",
  4266. GroupID: 1,
  4267. },
  4268. },
  4269. err: nil,
  4270. },
  4271. },
  4272. },
  4273. sessionRetrieverParams: sessionRetrieverParams{
  4274. retrieveSessionByNameParams: retrieveSessionByNameParams{
  4275. {
  4276. screenName: state.NewIdentScreenName("userA"),
  4277. result: func() *state.Session {
  4278. sess := state.NewSession()
  4279. sess.SetIdentScreenName(state.NewIdentScreenName("userA"))
  4280. inst := sess.AddInstance()
  4281. inst.SetSignonComplete()
  4282. return sess
  4283. }(),
  4284. },
  4285. },
  4286. },
  4287. messageRelayerParams: messageRelayerParams{
  4288. relayToScreenNameParams: relayToScreenNameParams{
  4289. {
  4290. screenName: state.NewIdentScreenName("userA"),
  4291. msg: wire.SNACMessage{
  4292. Frame: wire.SNACFrame{
  4293. FoodGroup: wire.Feedbag,
  4294. SubGroup: wire.FeedbagUpdateItem,
  4295. RequestID: wire.ReqIDFromServer,
  4296. },
  4297. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  4298. Items: []wire.FeedbagItem{
  4299. {
  4300. ItemID: 1,
  4301. ClassID: wire.FeedbagClassIdGroup,
  4302. Name: "Friends",
  4303. GroupID: 1,
  4304. TLVLBlock: wire.TLVLBlock{
  4305. TLVList: wire.TLVList{
  4306. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{}),
  4307. },
  4308. },
  4309. },
  4310. },
  4311. },
  4312. },
  4313. },
  4314. {
  4315. screenName: state.NewIdentScreenName("userA"),
  4316. msg: wire.SNACMessage{
  4317. Frame: wire.SNACFrame{
  4318. FoodGroup: wire.Feedbag,
  4319. SubGroup: wire.FeedbagDeleteItem,
  4320. RequestID: wire.ReqIDFromServer,
  4321. },
  4322. Body: wire.SNAC_0x13_0x0A_FeedbagDeleteItem{
  4323. Items: []wire.FeedbagItem{
  4324. {
  4325. ItemID: 10,
  4326. ClassID: wire.FeedbagClassIdBuddy,
  4327. Name: "buddy1",
  4328. GroupID: 1,
  4329. },
  4330. },
  4331. },
  4332. },
  4333. },
  4334. },
  4335. },
  4336. buddyBroadcasterParams: buddyBroadcasterParams{
  4337. broadcastVisibilityParams: broadcastVisibilityParams{
  4338. {
  4339. you: nil, // Not used in expectation, matched with mock.AnythingOfType
  4340. filter: []state.IdentScreenName{state.NewIdentScreenName("buddy1")},
  4341. sendDepartures: true,
  4342. err: nil,
  4343. },
  4344. },
  4345. },
  4346. },
  4347. },
  4348. {
  4349. name: "delete buddy from a group with multiple buddies, user not signed in",
  4350. screenName: "userA",
  4351. groupID: "1",
  4352. requestBody: `{"name":"buddy1"}`,
  4353. wantStatusCode: http.StatusNoContent,
  4354. mockParams: mockParams{
  4355. feedbagManagerParams: feedbagManagerParams{
  4356. feedbagParams: feedbagParams{
  4357. {
  4358. screenName: state.NewIdentScreenName("userA"),
  4359. result: []wire.FeedbagItem{
  4360. {
  4361. ItemID: 1,
  4362. ClassID: wire.FeedbagClassIdGroup,
  4363. Name: "Friends",
  4364. GroupID: 1,
  4365. TLVLBlock: wire.TLVLBlock{
  4366. TLVList: wire.TLVList{
  4367. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{10, 20}),
  4368. },
  4369. },
  4370. },
  4371. {
  4372. ItemID: 10,
  4373. ClassID: wire.FeedbagClassIdBuddy,
  4374. Name: "buddy1",
  4375. GroupID: 1,
  4376. },
  4377. {
  4378. ItemID: 20,
  4379. ClassID: wire.FeedbagClassIdBuddy,
  4380. Name: "buddy2",
  4381. GroupID: 1,
  4382. },
  4383. },
  4384. err: nil,
  4385. },
  4386. },
  4387. feedbagUpsertParams: feedbagUpsertParams{
  4388. {
  4389. screenName: state.NewIdentScreenName("userA"),
  4390. items: []wire.FeedbagItem{
  4391. {
  4392. ItemID: 1,
  4393. ClassID: wire.FeedbagClassIdGroup,
  4394. Name: "Friends",
  4395. GroupID: 1,
  4396. TLVLBlock: wire.TLVLBlock{
  4397. TLVList: wire.TLVList{
  4398. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{20}),
  4399. },
  4400. },
  4401. },
  4402. },
  4403. err: nil,
  4404. },
  4405. },
  4406. feedbagDeleteParams: feedbagDeleteParams{
  4407. {
  4408. screenName: state.NewIdentScreenName("userA"),
  4409. items: []wire.FeedbagItem{
  4410. {
  4411. ItemID: 10,
  4412. ClassID: wire.FeedbagClassIdBuddy,
  4413. Name: "buddy1",
  4414. GroupID: 1,
  4415. },
  4416. },
  4417. err: nil,
  4418. },
  4419. },
  4420. },
  4421. sessionRetrieverParams: sessionRetrieverParams{
  4422. retrieveSessionByNameParams: retrieveSessionByNameParams{
  4423. {
  4424. screenName: state.NewIdentScreenName("userA"),
  4425. result: state.NewSession(),
  4426. },
  4427. },
  4428. },
  4429. messageRelayerParams: messageRelayerParams{
  4430. relayToScreenNameParams: relayToScreenNameParams{
  4431. {
  4432. screenName: state.NewIdentScreenName("userA"),
  4433. msg: wire.SNACMessage{
  4434. Frame: wire.SNACFrame{
  4435. FoodGroup: wire.Feedbag,
  4436. SubGroup: wire.FeedbagUpdateItem,
  4437. RequestID: wire.ReqIDFromServer,
  4438. },
  4439. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  4440. Items: []wire.FeedbagItem{
  4441. {
  4442. ItemID: 1,
  4443. ClassID: wire.FeedbagClassIdGroup,
  4444. Name: "Friends",
  4445. GroupID: 1,
  4446. TLVLBlock: wire.TLVLBlock{
  4447. TLVList: wire.TLVList{
  4448. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{20}),
  4449. },
  4450. },
  4451. },
  4452. },
  4453. },
  4454. },
  4455. },
  4456. {
  4457. screenName: state.NewIdentScreenName("userA"),
  4458. msg: wire.SNACMessage{
  4459. Frame: wire.SNACFrame{
  4460. FoodGroup: wire.Feedbag,
  4461. SubGroup: wire.FeedbagDeleteItem,
  4462. RequestID: wire.ReqIDFromServer,
  4463. },
  4464. Body: wire.SNAC_0x13_0x0A_FeedbagDeleteItem{
  4465. Items: []wire.FeedbagItem{
  4466. {
  4467. ItemID: 10,
  4468. ClassID: wire.FeedbagClassIdBuddy,
  4469. Name: "buddy1",
  4470. GroupID: 1,
  4471. },
  4472. },
  4473. },
  4474. },
  4475. },
  4476. },
  4477. },
  4478. },
  4479. },
  4480. {
  4481. name: "can't delete buddy from root group",
  4482. screenName: "userA",
  4483. groupID: "0",
  4484. requestBody: `{"name":"rootbuddy"}`,
  4485. wantStatusCode: http.StatusBadRequest,
  4486. wantResponse: `{"message":"can't add buddies to root group"}`,
  4487. },
  4488. {
  4489. name: "missing screen_name",
  4490. screenName: "",
  4491. groupID: "1",
  4492. requestBody: `{"name":"buddy"}`,
  4493. wantStatusCode: http.StatusBadRequest,
  4494. wantResponse: `{"message":"screen_name is required"}`,
  4495. },
  4496. {
  4497. name: "group not found",
  4498. screenName: "userA",
  4499. groupID: "999",
  4500. requestBody: `{"name":"buddy"}`,
  4501. wantStatusCode: http.StatusNotFound,
  4502. wantResponse: `{"message":"group not found"}`,
  4503. mockParams: mockParams{
  4504. feedbagManagerParams: feedbagManagerParams{
  4505. feedbagParams: feedbagParams{
  4506. {
  4507. screenName: state.NewIdentScreenName("userA"),
  4508. result: []wire.FeedbagItem{
  4509. {
  4510. ItemID: 1,
  4511. ClassID: wire.FeedbagClassIdGroup,
  4512. Name: "Friends",
  4513. GroupID: 0,
  4514. },
  4515. },
  4516. err: nil,
  4517. },
  4518. },
  4519. },
  4520. },
  4521. },
  4522. {
  4523. name: "invalid group_id",
  4524. screenName: "userA",
  4525. groupID: "invalid",
  4526. requestBody: `{"name":"buddy"}`,
  4527. wantStatusCode: http.StatusBadRequest,
  4528. wantResponse: `{"message":"invalid group_id"}`,
  4529. },
  4530. {
  4531. name: "malformed request body",
  4532. screenName: "userA",
  4533. groupID: "1",
  4534. requestBody: `invalid json`,
  4535. wantStatusCode: http.StatusBadRequest,
  4536. wantResponse: `{"message":"buddy_screen_name is required"}`,
  4537. },
  4538. {
  4539. name: "missing name in request body",
  4540. screenName: "userA",
  4541. groupID: "1",
  4542. requestBody: `{}`,
  4543. wantStatusCode: http.StatusBadRequest,
  4544. wantResponse: `{"message":"buddy_screen_name is required"}`,
  4545. },
  4546. {
  4547. name: "buddy not found",
  4548. screenName: "userA",
  4549. groupID: "1",
  4550. requestBody: `{"name":"nonexistent"}`,
  4551. wantStatusCode: http.StatusNotFound,
  4552. wantResponse: `{"message":"buddy not found"}`,
  4553. mockParams: mockParams{
  4554. feedbagManagerParams: feedbagManagerParams{
  4555. feedbagParams: feedbagParams{
  4556. {
  4557. screenName: state.NewIdentScreenName("userA"),
  4558. result: []wire.FeedbagItem{
  4559. {
  4560. ItemID: 1,
  4561. ClassID: wire.FeedbagClassIdGroup,
  4562. Name: "Friends",
  4563. GroupID: 1,
  4564. },
  4565. {
  4566. ItemID: 10,
  4567. ClassID: wire.FeedbagClassIdBuddy,
  4568. Name: "otherbuddy",
  4569. GroupID: 1,
  4570. },
  4571. },
  4572. err: nil,
  4573. },
  4574. },
  4575. },
  4576. },
  4577. },
  4578. {
  4579. name: "internal server error on feedbag retrieval",
  4580. screenName: "userA",
  4581. groupID: "1",
  4582. requestBody: `{"name":"buddy"}`,
  4583. wantStatusCode: http.StatusInternalServerError,
  4584. wantResponse: `{"message":"internal server error"}`,
  4585. mockParams: mockParams{
  4586. feedbagManagerParams: feedbagManagerParams{
  4587. feedbagParams: feedbagParams{
  4588. {
  4589. screenName: state.NewIdentScreenName("userA"),
  4590. result: nil,
  4591. err: errors.New("database error"),
  4592. },
  4593. },
  4594. },
  4595. },
  4596. },
  4597. {
  4598. name: "internal server error on group order upsert",
  4599. screenName: "userA",
  4600. groupID: "1",
  4601. requestBody: `{"name":"buddy1"}`,
  4602. wantStatusCode: http.StatusInternalServerError,
  4603. wantResponse: `{"message":"internal server error"}`,
  4604. mockParams: mockParams{
  4605. feedbagManagerParams: feedbagManagerParams{
  4606. feedbagParams: feedbagParams{
  4607. {
  4608. screenName: state.NewIdentScreenName("userA"),
  4609. result: []wire.FeedbagItem{
  4610. {
  4611. ItemID: 1,
  4612. ClassID: wire.FeedbagClassIdGroup,
  4613. Name: "Friends",
  4614. GroupID: 1,
  4615. TLVLBlock: wire.TLVLBlock{
  4616. TLVList: wire.TLVList{
  4617. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{10}),
  4618. },
  4619. },
  4620. },
  4621. {
  4622. ItemID: 10,
  4623. ClassID: wire.FeedbagClassIdBuddy,
  4624. Name: "buddy1",
  4625. GroupID: 1,
  4626. },
  4627. },
  4628. err: nil,
  4629. },
  4630. },
  4631. feedbagUpsertParams: feedbagUpsertParams{
  4632. {
  4633. screenName: state.NewIdentScreenName("userA"),
  4634. items: []wire.FeedbagItem{
  4635. {
  4636. ItemID: 1,
  4637. ClassID: wire.FeedbagClassIdGroup,
  4638. Name: "Friends",
  4639. GroupID: 1,
  4640. TLVLBlock: wire.TLVLBlock{
  4641. TLVList: wire.TLVList{
  4642. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{}),
  4643. },
  4644. },
  4645. },
  4646. },
  4647. err: errors.New("database error"),
  4648. },
  4649. },
  4650. },
  4651. },
  4652. },
  4653. {
  4654. name: "internal server error on delete",
  4655. screenName: "userA",
  4656. groupID: "1",
  4657. requestBody: `{"name":"buddy1"}`,
  4658. wantStatusCode: http.StatusInternalServerError,
  4659. wantResponse: `{"message":"internal server error"}`,
  4660. mockParams: mockParams{
  4661. feedbagManagerParams: feedbagManagerParams{
  4662. feedbagParams: feedbagParams{
  4663. {
  4664. screenName: state.NewIdentScreenName("userA"),
  4665. result: []wire.FeedbagItem{
  4666. {
  4667. ItemID: 1,
  4668. ClassID: wire.FeedbagClassIdGroup,
  4669. Name: "Friends",
  4670. GroupID: 1,
  4671. TLVLBlock: wire.TLVLBlock{
  4672. TLVList: wire.TLVList{
  4673. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{10}),
  4674. },
  4675. },
  4676. },
  4677. {
  4678. ItemID: 10,
  4679. ClassID: wire.FeedbagClassIdBuddy,
  4680. Name: "buddy1",
  4681. GroupID: 1,
  4682. },
  4683. },
  4684. err: nil,
  4685. },
  4686. },
  4687. feedbagUpsertParams: feedbagUpsertParams{
  4688. {
  4689. screenName: state.NewIdentScreenName("userA"),
  4690. items: []wire.FeedbagItem{
  4691. {
  4692. ItemID: 1,
  4693. ClassID: wire.FeedbagClassIdGroup,
  4694. Name: "Friends",
  4695. GroupID: 1,
  4696. TLVLBlock: wire.TLVLBlock{
  4697. TLVList: wire.TLVList{
  4698. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{}),
  4699. },
  4700. },
  4701. },
  4702. },
  4703. err: nil,
  4704. },
  4705. },
  4706. feedbagDeleteParams: feedbagDeleteParams{
  4707. {
  4708. screenName: state.NewIdentScreenName("userA"),
  4709. items: []wire.FeedbagItem{
  4710. {
  4711. ItemID: 10,
  4712. ClassID: wire.FeedbagClassIdBuddy,
  4713. Name: "buddy1",
  4714. GroupID: 1,
  4715. },
  4716. },
  4717. err: errors.New("database error"),
  4718. },
  4719. },
  4720. },
  4721. },
  4722. },
  4723. }
  4724. for _, tc := range tt {
  4725. t.Run(tc.name, func(t *testing.T) {
  4726. // Extract buddy name from requestBody JSON
  4727. var buddyName string
  4728. if tc.requestBody != "" {
  4729. var input struct {
  4730. Name string `json:"name"`
  4731. }
  4732. if err := json.Unmarshal([]byte(tc.requestBody), &input); err == nil {
  4733. buddyName = input.Name
  4734. }
  4735. }
  4736. request := httptest.NewRequest(http.MethodDelete, "/feedbag/"+tc.screenName+"/group/"+tc.groupID+"/buddy/"+buddyName, nil)
  4737. if tc.screenName != "" {
  4738. request.SetPathValue("screen_name", tc.screenName)
  4739. }
  4740. if tc.groupID != "" {
  4741. request.SetPathValue("group_id", tc.groupID)
  4742. }
  4743. request.SetPathValue("buddy_screen_name", buddyName)
  4744. responseRecorder := httptest.NewRecorder()
  4745. feedbagManager := newMockFeedbagManager(t)
  4746. sessionRetriever := newMockSessionRetriever(t)
  4747. messageRelayer := newMockMessageRelayer(t)
  4748. buddyBroadcaster := newMockBuddyBroadcaster(t)
  4749. for _, params := range tc.mockParams.feedbagParams {
  4750. feedbagManager.EXPECT().
  4751. Feedbag(matchContext(), params.screenName).
  4752. Return(params.result, params.err)
  4753. }
  4754. for _, params := range tc.mockParams.feedbagUpsertParams {
  4755. feedbagManager.EXPECT().
  4756. FeedbagUpsert(matchContext(), params.screenName, params.items).
  4757. Return(params.err)
  4758. }
  4759. for _, params := range tc.mockParams.feedbagDeleteParams {
  4760. feedbagManager.EXPECT().
  4761. FeedbagDelete(matchContext(), params.screenName, params.items).
  4762. Return(params.err)
  4763. }
  4764. for _, params := range tc.mockParams.retrieveSessionByNameParams {
  4765. sessionRetriever.EXPECT().
  4766. RetrieveSession(params.screenName).
  4767. Return(params.result)
  4768. }
  4769. for _, params := range tc.mockParams.relayToScreenNameParams {
  4770. messageRelayer.EXPECT().
  4771. RelayToScreenName(matchContext(), params.screenName, params.msg)
  4772. }
  4773. for _, params := range tc.mockParams.broadcastVisibilityParams {
  4774. buddyBroadcaster.EXPECT().
  4775. BroadcastVisibility(
  4776. matchContext(),
  4777. mock.AnythingOfType("*state.SessionInstance"),
  4778. params.filter,
  4779. params.sendDepartures,
  4780. ).
  4781. Return(params.err)
  4782. }
  4783. deleteFeedbagBuddyHandler(responseRecorder, request, buddyBroadcaster, feedbagManager, sessionRetriever, messageRelayer, slog.Default())
  4784. assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
  4785. if tc.wantResponse != "" {
  4786. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  4787. }
  4788. })
  4789. }
  4790. }
  4791. func TestRandItemID(t *testing.T) {
  4792. tt := []struct {
  4793. name string
  4794. randInt func(n int) int
  4795. items []wire.FeedbagItem
  4796. want uint16
  4797. description string
  4798. }{
  4799. {
  4800. name: "empty items list returns random ID",
  4801. randInt: func(n int) int {
  4802. return 1000
  4803. },
  4804. items: []wire.FeedbagItem{},
  4805. want: 1000,
  4806. description: "When no items exist, should return the random number generated",
  4807. },
  4808. {
  4809. name: "finds next available ID when starting ID conflicts with ItemID",
  4810. randInt: func(n int) int {
  4811. return 100
  4812. },
  4813. items: []wire.FeedbagItem{
  4814. {ItemID: 100, GroupID: 1},
  4815. {ItemID: 101, GroupID: 1},
  4816. },
  4817. want: 102,
  4818. description: "Should skip 100 and 101, return 102",
  4819. },
  4820. {
  4821. name: "finds next available ID when starting ID conflicts with GroupID",
  4822. randInt: func(n int) int {
  4823. return 50
  4824. },
  4825. items: []wire.FeedbagItem{
  4826. {ItemID: 1, GroupID: 50},
  4827. {ItemID: 2, GroupID: 51},
  4828. },
  4829. want: 52,
  4830. description: "Should skip 50 (GroupID) and 51 (GroupID), return 52",
  4831. },
  4832. {
  4833. name: "wraps around and skips 0 to find next available ID",
  4834. randInt: func(n int) int {
  4835. return math.MaxUint16 - 2
  4836. },
  4837. items: []wire.FeedbagItem{
  4838. {ItemID: math.MaxUint16 - 2, GroupID: 1},
  4839. {ItemID: math.MaxUint16 - 1, GroupID: 1},
  4840. {ItemID: math.MaxUint16, GroupID: 1},
  4841. },
  4842. want: 2,
  4843. description: "When wrapping around, skips 0 (always skipped) and 1 (if conflicts), returns 2",
  4844. },
  4845. {
  4846. name: "skips 0 when starting from 0 and finds next available",
  4847. randInt: func(n int) int {
  4848. return 0
  4849. },
  4850. items: []wire.FeedbagItem{},
  4851. want: 1,
  4852. description: "When starting from 0, skips 0 (always skipped) and returns 1",
  4853. },
  4854. {
  4855. name: "returns 0 when all IDs are taken",
  4856. randInt: func(n int) int {
  4857. return 100
  4858. },
  4859. items: func() []wire.FeedbagItem {
  4860. // Create items that cover all possible IDs
  4861. items := make([]wire.FeedbagItem, 0, math.MaxUint16+1)
  4862. for i := 0; i <= math.MaxUint16; i++ {
  4863. items = append(items, wire.FeedbagItem{
  4864. ItemID: uint16(i),
  4865. GroupID: uint16(i),
  4866. })
  4867. }
  4868. return items
  4869. }(),
  4870. want: 0,
  4871. description: "When all IDs are taken, should return 0",
  4872. },
  4873. {
  4874. name: "finds ID that conflicts with both ItemID and GroupID",
  4875. randInt: func(n int) int {
  4876. return 200
  4877. },
  4878. items: []wire.FeedbagItem{
  4879. {ItemID: 200, GroupID: 201},
  4880. {ItemID: 201, GroupID: 200},
  4881. },
  4882. want: 202,
  4883. description: "Should skip 200 (ItemID) and 201 (both ItemID and GroupID), return 202",
  4884. },
  4885. {
  4886. name: "finds available ID immediately when no conflicts",
  4887. randInt: func(n int) int {
  4888. return 500
  4889. },
  4890. items: []wire.FeedbagItem{
  4891. {ItemID: 100, GroupID: 1},
  4892. {ItemID: 200, GroupID: 2},
  4893. {ItemID: 300, GroupID: 3},
  4894. },
  4895. want: 500,
  4896. description: "When random ID has no conflicts, should return it immediately",
  4897. },
  4898. {
  4899. name: "handles single conflict and finds next",
  4900. randInt: func(n int) int {
  4901. return 42
  4902. },
  4903. items: []wire.FeedbagItem{
  4904. {ItemID: 42, GroupID: 1},
  4905. },
  4906. want: 43,
  4907. description: "Should skip 42 and return 43",
  4908. },
  4909. {
  4910. name: "finds ID before starting point when wrapping",
  4911. randInt: func(n int) int {
  4912. return 5
  4913. },
  4914. items: []wire.FeedbagItem{
  4915. {ItemID: 5, GroupID: 1},
  4916. {ItemID: 6, GroupID: 1},
  4917. {ItemID: 7, GroupID: 1},
  4918. },
  4919. want: 8,
  4920. description: "Should skip 5, 6, 7 and return 8",
  4921. },
  4922. }
  4923. for _, tc := range tt {
  4924. t.Run(tc.name, func(t *testing.T) {
  4925. got := randItemID(tc.randInt, tc.items)
  4926. if got != tc.want {
  4927. t.Errorf("randItemID() = %d, want %d. %s", got, tc.want, tc.description)
  4928. }
  4929. })
  4930. }
  4931. }
  4932. func TestGetLinkedAccountsHandler(t *testing.T) {
  4933. tt := []struct {
  4934. name string
  4935. screenname string
  4936. statusCode int
  4937. want string
  4938. mockParams mockParams
  4939. }{
  4940. {
  4941. name: "user not found returns 404",
  4942. screenname: "nobody",
  4943. statusCode: http.StatusNotFound,
  4944. want: `{"message":"user not found"}`,
  4945. mockParams: mockParams{
  4946. userManagerParams: userManagerParams{
  4947. getUserParams: getUserParams{
  4948. {
  4949. screenName: state.NewIdentScreenName("nobody"),
  4950. result: nil,
  4951. },
  4952. },
  4953. },
  4954. },
  4955. },
  4956. {
  4957. name: "returns empty linked accounts list",
  4958. screenname: "test1",
  4959. statusCode: http.StatusOK,
  4960. want: `{"linked_accounts":[]}`,
  4961. mockParams: mockParams{
  4962. userManagerParams: userManagerParams{
  4963. getUserParams: getUserParams{
  4964. {
  4965. screenName: state.NewIdentScreenName("test1"),
  4966. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  4967. },
  4968. },
  4969. },
  4970. feedbagManagerParams: feedbagManagerParams{
  4971. feedbagParams: feedbagParams{
  4972. {
  4973. screenName: state.NewIdentScreenName("test1"),
  4974. result: []wire.FeedbagItem{},
  4975. },
  4976. },
  4977. },
  4978. },
  4979. },
  4980. {
  4981. name: "returns linked accounts",
  4982. screenname: "test1",
  4983. statusCode: http.StatusOK,
  4984. want: `{"linked_accounts":["test2","test3"]}`,
  4985. mockParams: mockParams{
  4986. userManagerParams: userManagerParams{
  4987. getUserParams: getUserParams{
  4988. {
  4989. screenName: state.NewIdentScreenName("test1"),
  4990. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  4991. },
  4992. },
  4993. },
  4994. feedbagManagerParams: feedbagManagerParams{
  4995. feedbagParams: feedbagParams{
  4996. {
  4997. screenName: state.NewIdentScreenName("test1"),
  4998. result: []wire.FeedbagItem{
  4999. {ClassID: wire.FeedbagClassIdAlInfo, Name: "test2"},
  5000. {ClassID: wire.FeedbagClassIdAlInfo, Name: "test3"},
  5001. },
  5002. },
  5003. },
  5004. },
  5005. },
  5006. },
  5007. {
  5008. name: "feedbag error returns 500",
  5009. screenname: "test1",
  5010. statusCode: http.StatusInternalServerError,
  5011. want: `{"message":"internal server error"}`,
  5012. mockParams: mockParams{
  5013. userManagerParams: userManagerParams{
  5014. getUserParams: getUserParams{
  5015. {
  5016. screenName: state.NewIdentScreenName("test1"),
  5017. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5018. },
  5019. },
  5020. },
  5021. feedbagManagerParams: feedbagManagerParams{
  5022. feedbagParams: feedbagParams{
  5023. {
  5024. screenName: state.NewIdentScreenName("test1"),
  5025. err: io.EOF,
  5026. },
  5027. },
  5028. },
  5029. },
  5030. },
  5031. }
  5032. for _, tc := range tt {
  5033. t.Run(tc.name, func(t *testing.T) {
  5034. request := httptest.NewRequest(http.MethodGet, "/user/"+tc.screenname+"/linked-account", nil)
  5035. request.SetPathValue("screenname", tc.screenname)
  5036. responseRecorder := httptest.NewRecorder()
  5037. userManager := newMockUserManager(t)
  5038. for _, params := range tc.mockParams.getUserParams {
  5039. userManager.EXPECT().
  5040. User(matchContext(), params.screenName).
  5041. Return(params.result, params.err)
  5042. }
  5043. feedbagManager := newMockFeedbagManager(t)
  5044. for _, params := range tc.mockParams.feedbagParams {
  5045. feedbagManager.EXPECT().
  5046. Feedbag(matchContext(), params.screenName).
  5047. Return(params.result, params.err)
  5048. }
  5049. getLinkedAccountsHandler(responseRecorder, request, userManager, feedbagManager)
  5050. assert.Equal(t, tc.statusCode, responseRecorder.Code)
  5051. assert.Equal(t, tc.want, strings.TrimSpace(responseRecorder.Body.String()))
  5052. })
  5053. }
  5054. }
  5055. func TestPostLinkedAccountHandler(t *testing.T) {
  5056. tt := []struct {
  5057. name string
  5058. screenname string
  5059. body string
  5060. statusCode int
  5061. want string
  5062. mockParams mockParams
  5063. }{
  5064. {
  5065. name: "primary user not found returns 404",
  5066. screenname: "nobody",
  5067. body: `{"linked_screen_name":"test2"}`,
  5068. statusCode: http.StatusNotFound,
  5069. want: `{"message":"user not found"}`,
  5070. mockParams: mockParams{
  5071. userManagerParams: userManagerParams{
  5072. getUserParams: getUserParams{
  5073. {
  5074. screenName: state.NewIdentScreenName("nobody"),
  5075. result: nil,
  5076. },
  5077. },
  5078. },
  5079. },
  5080. },
  5081. {
  5082. name: "invalid request body returns 400",
  5083. screenname: "test1",
  5084. body: `not json`,
  5085. statusCode: http.StatusBadRequest,
  5086. want: `{"message":"invalid request body"}`,
  5087. mockParams: mockParams{
  5088. userManagerParams: userManagerParams{
  5089. getUserParams: getUserParams{
  5090. {
  5091. screenName: state.NewIdentScreenName("test1"),
  5092. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5093. },
  5094. },
  5095. },
  5096. },
  5097. },
  5098. {
  5099. name: "missing linked_screen_name returns 400",
  5100. screenname: "test1",
  5101. body: `{}`,
  5102. statusCode: http.StatusBadRequest,
  5103. want: `{"message":"invalid request body"}`,
  5104. mockParams: mockParams{
  5105. userManagerParams: userManagerParams{
  5106. getUserParams: getUserParams{
  5107. {
  5108. screenName: state.NewIdentScreenName("test1"),
  5109. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5110. },
  5111. },
  5112. },
  5113. },
  5114. },
  5115. {
  5116. name: "self-link returns 400",
  5117. screenname: "test1",
  5118. body: `{"linked_screen_name":"test1"}`,
  5119. statusCode: http.StatusBadRequest,
  5120. want: `{"message":"cannot link an account to itself"}`,
  5121. mockParams: mockParams{
  5122. userManagerParams: userManagerParams{
  5123. getUserParams: getUserParams{
  5124. {
  5125. screenName: state.NewIdentScreenName("test1"),
  5126. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5127. },
  5128. },
  5129. },
  5130. },
  5131. },
  5132. {
  5133. name: "linked user not found returns 404",
  5134. screenname: "test1",
  5135. body: `{"linked_screen_name":"nobody"}`,
  5136. statusCode: http.StatusNotFound,
  5137. want: `{"message":"linked user not found"}`,
  5138. mockParams: mockParams{
  5139. userManagerParams: userManagerParams{
  5140. getUserParams: getUserParams{
  5141. {
  5142. screenName: state.NewIdentScreenName("test1"),
  5143. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5144. },
  5145. {
  5146. screenName: state.NewIdentScreenName("nobody"),
  5147. result: nil,
  5148. },
  5149. },
  5150. },
  5151. },
  5152. },
  5153. {
  5154. name: "duplicate link returns 409",
  5155. screenname: "test1",
  5156. body: `{"linked_screen_name":"test2"}`,
  5157. statusCode: http.StatusConflict,
  5158. want: `{"message":"linked account already exists"}`,
  5159. mockParams: mockParams{
  5160. userManagerParams: userManagerParams{
  5161. getUserParams: getUserParams{
  5162. {
  5163. screenName: state.NewIdentScreenName("test1"),
  5164. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5165. },
  5166. {
  5167. screenName: state.NewIdentScreenName("test2"),
  5168. result: &state.User{IdentScreenName: state.NewIdentScreenName("test2")},
  5169. },
  5170. },
  5171. },
  5172. feedbagManagerParams: feedbagManagerParams{
  5173. feedbagParams: feedbagParams{
  5174. {
  5175. screenName: state.NewIdentScreenName("test1"),
  5176. result: []wire.FeedbagItem{
  5177. {ClassID: wire.FeedbagClassIdAlInfo, Name: "test2"},
  5178. },
  5179. },
  5180. },
  5181. },
  5182. },
  5183. },
  5184. {
  5185. name: "insert error returns 500",
  5186. screenname: "test1",
  5187. body: `{"linked_screen_name":"test2"}`,
  5188. statusCode: http.StatusInternalServerError,
  5189. want: `{"message":"internal server error"}`,
  5190. mockParams: mockParams{
  5191. userManagerParams: userManagerParams{
  5192. getUserParams: getUserParams{
  5193. {
  5194. screenName: state.NewIdentScreenName("test1"),
  5195. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5196. },
  5197. {
  5198. screenName: state.NewIdentScreenName("test2"),
  5199. result: &state.User{IdentScreenName: state.NewIdentScreenName("test2")},
  5200. },
  5201. },
  5202. },
  5203. feedbagManagerParams: feedbagManagerParams{
  5204. feedbagParams: feedbagParams{
  5205. {
  5206. screenName: state.NewIdentScreenName("test1"),
  5207. result: []wire.FeedbagItem{},
  5208. },
  5209. },
  5210. feedbagUpsertParams: feedbagUpsertParams{
  5211. {
  5212. screenName: state.NewIdentScreenName("test1"),
  5213. items: []wire.FeedbagItem{
  5214. {ItemID: 1, ClassID: wire.FeedbagClassIdAlInfo, Name: "test2"},
  5215. },
  5216. err: io.EOF,
  5217. },
  5218. },
  5219. },
  5220. },
  5221. },
  5222. {
  5223. name: "link created returns 201",
  5224. screenname: "test1",
  5225. body: `{"linked_screen_name":"test2"}`,
  5226. statusCode: http.StatusCreated,
  5227. want: ``,
  5228. mockParams: mockParams{
  5229. userManagerParams: userManagerParams{
  5230. getUserParams: getUserParams{
  5231. {
  5232. screenName: state.NewIdentScreenName("test1"),
  5233. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5234. },
  5235. {
  5236. screenName: state.NewIdentScreenName("test2"),
  5237. result: &state.User{IdentScreenName: state.NewIdentScreenName("test2")},
  5238. },
  5239. },
  5240. },
  5241. feedbagManagerParams: feedbagManagerParams{
  5242. feedbagParams: feedbagParams{
  5243. {
  5244. screenName: state.NewIdentScreenName("test1"),
  5245. result: []wire.FeedbagItem{},
  5246. },
  5247. },
  5248. feedbagUpsertParams: feedbagUpsertParams{
  5249. {
  5250. screenName: state.NewIdentScreenName("test1"),
  5251. items: []wire.FeedbagItem{
  5252. {ItemID: 1, ClassID: wire.FeedbagClassIdAlInfo, Name: "test2"},
  5253. },
  5254. },
  5255. },
  5256. },
  5257. },
  5258. },
  5259. }
  5260. for _, tc := range tt {
  5261. t.Run(tc.name, func(t *testing.T) {
  5262. request := httptest.NewRequest(http.MethodPost, "/user/"+tc.screenname+"/linked-account", strings.NewReader(tc.body))
  5263. request.SetPathValue("screenname", tc.screenname)
  5264. responseRecorder := httptest.NewRecorder()
  5265. userManager := newMockUserManager(t)
  5266. for _, params := range tc.mockParams.getUserParams {
  5267. userManager.EXPECT().
  5268. User(matchContext(), params.screenName).
  5269. Return(params.result, params.err)
  5270. }
  5271. feedbagManager := newMockFeedbagManager(t)
  5272. for _, params := range tc.mockParams.feedbagParams {
  5273. feedbagManager.EXPECT().
  5274. Feedbag(matchContext(), params.screenName).
  5275. Return(params.result, params.err)
  5276. }
  5277. for _, params := range tc.mockParams.feedbagUpsertParams {
  5278. feedbagManager.EXPECT().
  5279. FeedbagUpsert(matchContext(), params.screenName, params.items).
  5280. Return(params.err)
  5281. }
  5282. postLinkedAccountHandler(responseRecorder, request, userManager, feedbagManager, slog.Default(), func(n int) int { return 0 })
  5283. assert.Equal(t, tc.statusCode, responseRecorder.Code)
  5284. assert.Equal(t, tc.want, strings.TrimSpace(responseRecorder.Body.String()))
  5285. })
  5286. }
  5287. }
  5288. func TestDeleteLinkedAccountHandler(t *testing.T) {
  5289. linkedFeedbagItem := wire.FeedbagItem{
  5290. ItemID: 1,
  5291. ClassID: wire.FeedbagClassIdAlInfo,
  5292. Name: "test2",
  5293. }
  5294. tt := []struct {
  5295. name string
  5296. screenname string
  5297. linkedScreenname string
  5298. statusCode int
  5299. want string
  5300. mockParams mockParams
  5301. }{
  5302. {
  5303. name: "primary user not found returns 404",
  5304. screenname: "nobody",
  5305. linkedScreenname: "test2",
  5306. statusCode: http.StatusNotFound,
  5307. want: `{"message":"user not found"}`,
  5308. mockParams: mockParams{
  5309. userManagerParams: userManagerParams{
  5310. getUserParams: getUserParams{
  5311. {
  5312. screenName: state.NewIdentScreenName("nobody"),
  5313. result: nil,
  5314. },
  5315. },
  5316. },
  5317. },
  5318. },
  5319. {
  5320. name: "linked account not found returns 404",
  5321. screenname: "test1",
  5322. linkedScreenname: "ghost",
  5323. statusCode: http.StatusNotFound,
  5324. want: `{"message":"linked account not found"}`,
  5325. mockParams: mockParams{
  5326. userManagerParams: userManagerParams{
  5327. getUserParams: getUserParams{
  5328. {
  5329. screenName: state.NewIdentScreenName("test1"),
  5330. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5331. },
  5332. },
  5333. },
  5334. feedbagManagerParams: feedbagManagerParams{
  5335. feedbagParams: feedbagParams{
  5336. {
  5337. screenName: state.NewIdentScreenName("test1"),
  5338. result: []wire.FeedbagItem{},
  5339. },
  5340. },
  5341. },
  5342. },
  5343. },
  5344. {
  5345. name: "delete error returns 500",
  5346. screenname: "test1",
  5347. linkedScreenname: "test2",
  5348. statusCode: http.StatusInternalServerError,
  5349. want: `{"message":"internal server error"}`,
  5350. mockParams: mockParams{
  5351. userManagerParams: userManagerParams{
  5352. getUserParams: getUserParams{
  5353. {
  5354. screenName: state.NewIdentScreenName("test1"),
  5355. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5356. },
  5357. },
  5358. },
  5359. feedbagManagerParams: feedbagManagerParams{
  5360. feedbagParams: feedbagParams{
  5361. {
  5362. screenName: state.NewIdentScreenName("test1"),
  5363. result: []wire.FeedbagItem{linkedFeedbagItem},
  5364. },
  5365. },
  5366. feedbagDeleteParams: feedbagDeleteParams{
  5367. {
  5368. screenName: state.NewIdentScreenName("test1"),
  5369. items: []wire.FeedbagItem{linkedFeedbagItem},
  5370. err: io.EOF,
  5371. },
  5372. },
  5373. },
  5374. },
  5375. },
  5376. {
  5377. name: "upsert error after delete returns 500",
  5378. screenname: "test1",
  5379. linkedScreenname: "test2",
  5380. statusCode: http.StatusInternalServerError,
  5381. want: `{"message":"internal server error"}`,
  5382. mockParams: mockParams{
  5383. userManagerParams: userManagerParams{
  5384. getUserParams: getUserParams{
  5385. {
  5386. screenName: state.NewIdentScreenName("test1"),
  5387. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5388. },
  5389. },
  5390. },
  5391. feedbagManagerParams: feedbagManagerParams{
  5392. feedbagParams: feedbagParams{
  5393. {
  5394. screenName: state.NewIdentScreenName("test1"),
  5395. result: []wire.FeedbagItem{linkedFeedbagItem},
  5396. },
  5397. },
  5398. feedbagDeleteParams: feedbagDeleteParams{
  5399. {
  5400. screenName: state.NewIdentScreenName("test1"),
  5401. items: []wire.FeedbagItem{linkedFeedbagItem},
  5402. },
  5403. },
  5404. feedbagUpsertParams: feedbagUpsertParams{
  5405. {
  5406. screenName: state.NewIdentScreenName("test1"),
  5407. items: []wire.FeedbagItem{{ClassID: wire.FeedbagClassIdGroup}},
  5408. err: io.EOF,
  5409. },
  5410. },
  5411. },
  5412. },
  5413. },
  5414. {
  5415. name: "link deleted returns 204",
  5416. screenname: "test1",
  5417. linkedScreenname: "test2",
  5418. statusCode: http.StatusNoContent,
  5419. want: ``,
  5420. mockParams: mockParams{
  5421. userManagerParams: userManagerParams{
  5422. getUserParams: getUserParams{
  5423. {
  5424. screenName: state.NewIdentScreenName("test1"),
  5425. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5426. },
  5427. },
  5428. },
  5429. feedbagManagerParams: feedbagManagerParams{
  5430. feedbagParams: feedbagParams{
  5431. {
  5432. screenName: state.NewIdentScreenName("test1"),
  5433. result: []wire.FeedbagItem{linkedFeedbagItem},
  5434. },
  5435. },
  5436. feedbagDeleteParams: feedbagDeleteParams{
  5437. {
  5438. screenName: state.NewIdentScreenName("test1"),
  5439. items: []wire.FeedbagItem{linkedFeedbagItem},
  5440. },
  5441. },
  5442. feedbagUpsertParams: feedbagUpsertParams{
  5443. {
  5444. screenName: state.NewIdentScreenName("test1"),
  5445. items: []wire.FeedbagItem{{ClassID: wire.FeedbagClassIdGroup}},
  5446. },
  5447. },
  5448. },
  5449. },
  5450. },
  5451. }
  5452. for _, tc := range tt {
  5453. t.Run(tc.name, func(t *testing.T) {
  5454. request := httptest.NewRequest(http.MethodDelete, "/user/"+tc.screenname+"/linked-account/"+tc.linkedScreenname, nil)
  5455. request.SetPathValue("screenname", tc.screenname)
  5456. request.SetPathValue("linked_screenname", tc.linkedScreenname)
  5457. responseRecorder := httptest.NewRecorder()
  5458. userManager := newMockUserManager(t)
  5459. for _, params := range tc.mockParams.getUserParams {
  5460. userManager.EXPECT().
  5461. User(matchContext(), params.screenName).
  5462. Return(params.result, params.err)
  5463. }
  5464. feedbagManager := newMockFeedbagManager(t)
  5465. for _, params := range tc.mockParams.feedbagParams {
  5466. feedbagManager.EXPECT().
  5467. Feedbag(matchContext(), params.screenName).
  5468. Return(params.result, params.err)
  5469. }
  5470. for _, params := range tc.mockParams.feedbagDeleteParams {
  5471. feedbagManager.EXPECT().
  5472. FeedbagDelete(matchContext(), params.screenName, params.items).
  5473. Return(params.err)
  5474. }
  5475. for _, params := range tc.mockParams.feedbagUpsertParams {
  5476. feedbagManager.EXPECT().
  5477. FeedbagUpsert(matchContext(), params.screenName, params.items).
  5478. Return(params.err)
  5479. }
  5480. deleteLinkedAccountHandler(responseRecorder, request, userManager, feedbagManager, slog.Default(), nil)
  5481. assert.Equal(t, tc.statusCode, responseRecorder.Code)
  5482. assert.Equal(t, tc.want, strings.TrimSpace(responseRecorder.Body.String()))
  5483. })
  5484. }
  5485. }