mgmt_api_test.go 161 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083108410851086108710881089109010911092109310941095109610971098109911001101110211031104110511061107110811091110111111121113111411151116111711181119112011211122112311241125112611271128112911301131113211331134113511361137113811391140114111421143114411451146114711481149115011511152115311541155115611571158115911601161116211631164116511661167116811691170117111721173117411751176117711781179118011811182118311841185118611871188118911901191119211931194119511961197119811991200120112021203120412051206120712081209121012111212121312141215121612171218121912201221122212231224122512261227122812291230123112321233123412351236123712381239124012411242124312441245124612471248124912501251125212531254125512561257125812591260126112621263126412651266126712681269127012711272127312741275127612771278127912801281128212831284128512861287128812891290129112921293129412951296129712981299130013011302130313041305130613071308130913101311131213131314131513161317131813191320132113221323132413251326132713281329133013311332133313341335133613371338133913401341134213431344134513461347134813491350135113521353135413551356135713581359136013611362136313641365136613671368136913701371137213731374137513761377137813791380138113821383138413851386138713881389139013911392139313941395139613971398139914001401140214031404140514061407140814091410141114121413141414151416141714181419142014211422142314241425142614271428142914301431143214331434143514361437143814391440144114421443144414451446144714481449145014511452145314541455145614571458145914601461146214631464146514661467146814691470147114721473147414751476147714781479148014811482148314841485148614871488148914901491149214931494149514961497149814991500150115021503150415051506150715081509151015111512151315141515151615171518151915201521152215231524152515261527152815291530153115321533153415351536153715381539154015411542154315441545154615471548154915501551155215531554155515561557155815591560156115621563156415651566156715681569157015711572157315741575157615771578157915801581158215831584158515861587158815891590159115921593159415951596159715981599160016011602160316041605160616071608160916101611161216131614161516161617161816191620162116221623162416251626162716281629163016311632163316341635163616371638163916401641164216431644164516461647164816491650165116521653165416551656165716581659166016611662166316641665166616671668166916701671167216731674167516761677167816791680168116821683168416851686168716881689169016911692169316941695169616971698169917001701170217031704170517061707170817091710171117121713171417151716171717181719172017211722172317241725172617271728172917301731173217331734173517361737173817391740174117421743174417451746174717481749175017511752175317541755175617571758175917601761176217631764176517661767176817691770177117721773177417751776177717781779178017811782178317841785178617871788178917901791179217931794179517961797179817991800180118021803180418051806180718081809181018111812181318141815181618171818181918201821182218231824182518261827182818291830183118321833183418351836183718381839184018411842184318441845184618471848184918501851185218531854185518561857185818591860186118621863186418651866186718681869187018711872187318741875187618771878187918801881188218831884188518861887188818891890189118921893189418951896189718981899190019011902190319041905190619071908190919101911191219131914191519161917191819191920192119221923192419251926192719281929193019311932193319341935193619371938193919401941194219431944194519461947194819491950195119521953195419551956195719581959196019611962196319641965196619671968196919701971197219731974197519761977197819791980198119821983198419851986198719881989199019911992199319941995199619971998199920002001200220032004200520062007200820092010201120122013201420152016201720182019202020212022202320242025202620272028202920302031203220332034203520362037203820392040204120422043204420452046204720482049205020512052205320542055205620572058205920602061206220632064206520662067206820692070207120722073207420752076207720782079208020812082208320842085208620872088208920902091209220932094209520962097209820992100210121022103210421052106210721082109211021112112211321142115211621172118211921202121212221232124212521262127212821292130213121322133213421352136213721382139214021412142214321442145214621472148214921502151215221532154215521562157215821592160216121622163216421652166216721682169217021712172217321742175217621772178217921802181218221832184218521862187218821892190219121922193219421952196219721982199220022012202220322042205220622072208220922102211221222132214221522162217221822192220222122222223222422252226222722282229223022312232223322342235223622372238223922402241224222432244224522462247224822492250225122522253225422552256225722582259226022612262226322642265226622672268226922702271227222732274227522762277227822792280228122822283228422852286228722882289229022912292229322942295229622972298229923002301230223032304230523062307230823092310231123122313231423152316231723182319232023212322232323242325232623272328232923302331233223332334233523362337233823392340234123422343234423452346234723482349235023512352235323542355235623572358235923602361236223632364236523662367236823692370237123722373237423752376237723782379238023812382238323842385238623872388238923902391239223932394239523962397239823992400240124022403240424052406240724082409241024112412241324142415241624172418241924202421242224232424242524262427242824292430243124322433243424352436243724382439244024412442244324442445244624472448244924502451245224532454245524562457245824592460246124622463246424652466246724682469247024712472247324742475247624772478247924802481248224832484248524862487248824892490249124922493249424952496249724982499250025012502250325042505250625072508250925102511251225132514251525162517251825192520252125222523252425252526252725282529253025312532253325342535253625372538253925402541254225432544254525462547254825492550255125522553255425552556255725582559256025612562256325642565256625672568256925702571257225732574257525762577257825792580258125822583258425852586258725882589259025912592259325942595259625972598259926002601260226032604260526062607260826092610261126122613261426152616261726182619262026212622262326242625262626272628262926302631263226332634263526362637263826392640264126422643264426452646264726482649265026512652265326542655265626572658265926602661266226632664266526662667266826692670267126722673267426752676267726782679268026812682268326842685268626872688268926902691269226932694269526962697269826992700270127022703270427052706270727082709271027112712271327142715271627172718271927202721272227232724272527262727272827292730273127322733273427352736273727382739274027412742274327442745274627472748274927502751275227532754275527562757275827592760276127622763276427652766276727682769277027712772277327742775277627772778277927802781278227832784278527862787278827892790279127922793279427952796279727982799280028012802280328042805280628072808280928102811281228132814281528162817281828192820282128222823282428252826282728282829283028312832283328342835283628372838283928402841284228432844284528462847284828492850285128522853285428552856285728582859286028612862286328642865286628672868286928702871287228732874287528762877287828792880288128822883288428852886288728882889289028912892289328942895289628972898289929002901290229032904290529062907290829092910291129122913291429152916291729182919292029212922292329242925292629272928292929302931293229332934293529362937293829392940294129422943294429452946294729482949295029512952295329542955295629572958295929602961296229632964296529662967296829692970297129722973297429752976297729782979298029812982298329842985298629872988298929902991299229932994299529962997299829993000300130023003300430053006300730083009301030113012301330143015301630173018301930203021302230233024302530263027302830293030303130323033303430353036303730383039304030413042304330443045304630473048304930503051305230533054305530563057305830593060306130623063306430653066306730683069307030713072307330743075307630773078307930803081308230833084308530863087308830893090309130923093309430953096309730983099310031013102310331043105310631073108310931103111311231133114311531163117311831193120312131223123312431253126312731283129313031313132313331343135313631373138313931403141314231433144314531463147314831493150315131523153315431553156315731583159316031613162316331643165316631673168316931703171317231733174317531763177317831793180318131823183318431853186318731883189319031913192319331943195319631973198319932003201320232033204320532063207320832093210321132123213321432153216321732183219322032213222322332243225322632273228322932303231323232333234323532363237323832393240324132423243324432453246324732483249325032513252325332543255325632573258325932603261326232633264326532663267326832693270327132723273327432753276327732783279328032813282328332843285328632873288328932903291329232933294329532963297329832993300330133023303330433053306330733083309331033113312331333143315331633173318331933203321332233233324332533263327332833293330333133323333333433353336333733383339334033413342334333443345334633473348334933503351335233533354335533563357335833593360336133623363336433653366336733683369337033713372337333743375337633773378337933803381338233833384338533863387338833893390339133923393339433953396339733983399340034013402340334043405340634073408340934103411341234133414341534163417341834193420342134223423342434253426342734283429343034313432343334343435343634373438343934403441344234433444344534463447344834493450345134523453345434553456345734583459346034613462346334643465346634673468346934703471347234733474347534763477347834793480348134823483348434853486348734883489349034913492349334943495349634973498349935003501350235033504350535063507350835093510351135123513351435153516351735183519352035213522352335243525352635273528352935303531353235333534353535363537353835393540354135423543354435453546354735483549355035513552355335543555355635573558355935603561356235633564356535663567356835693570357135723573357435753576357735783579358035813582358335843585358635873588358935903591359235933594359535963597359835993600360136023603360436053606360736083609361036113612361336143615361636173618361936203621362236233624362536263627362836293630363136323633363436353636363736383639364036413642364336443645364636473648364936503651365236533654365536563657365836593660366136623663366436653666366736683669367036713672367336743675367636773678367936803681368236833684368536863687368836893690369136923693369436953696369736983699370037013702370337043705370637073708370937103711371237133714371537163717371837193720372137223723372437253726372737283729373037313732373337343735373637373738373937403741374237433744374537463747374837493750375137523753375437553756375737583759376037613762376337643765376637673768376937703771377237733774377537763777377837793780378137823783378437853786378737883789379037913792379337943795379637973798379938003801380238033804380538063807380838093810381138123813381438153816381738183819382038213822382338243825382638273828382938303831383238333834383538363837383838393840384138423843384438453846384738483849385038513852385338543855385638573858385938603861386238633864386538663867386838693870387138723873387438753876387738783879388038813882388338843885388638873888388938903891389238933894389538963897389838993900390139023903390439053906390739083909391039113912391339143915391639173918391939203921392239233924392539263927392839293930393139323933393439353936393739383939394039413942394339443945394639473948394939503951395239533954395539563957395839593960396139623963396439653966396739683969397039713972397339743975397639773978397939803981398239833984398539863987398839893990399139923993399439953996399739983999400040014002400340044005400640074008400940104011401240134014401540164017401840194020402140224023402440254026402740284029403040314032403340344035403640374038403940404041404240434044404540464047404840494050405140524053405440554056405740584059406040614062406340644065406640674068406940704071407240734074407540764077407840794080408140824083408440854086408740884089409040914092409340944095409640974098409941004101410241034104410541064107410841094110411141124113411441154116411741184119412041214122412341244125412641274128412941304131413241334134413541364137413841394140414141424143414441454146414741484149415041514152415341544155415641574158415941604161416241634164416541664167416841694170417141724173417441754176417741784179418041814182418341844185418641874188418941904191419241934194419541964197419841994200420142024203420442054206420742084209421042114212421342144215421642174218421942204221422242234224422542264227422842294230423142324233423442354236423742384239424042414242424342444245424642474248424942504251425242534254425542564257425842594260426142624263426442654266426742684269427042714272427342744275427642774278427942804281428242834284428542864287428842894290429142924293429442954296429742984299430043014302430343044305430643074308430943104311431243134314431543164317431843194320432143224323432443254326432743284329433043314332433343344335433643374338433943404341434243434344434543464347434843494350435143524353435443554356435743584359436043614362436343644365436643674368436943704371437243734374437543764377437843794380438143824383438443854386438743884389439043914392439343944395439643974398439944004401440244034404440544064407440844094410441144124413441444154416441744184419442044214422442344244425442644274428442944304431443244334434443544364437443844394440444144424443444444454446444744484449445044514452445344544455445644574458445944604461446244634464446544664467446844694470447144724473447444754476447744784479448044814482448344844485448644874488448944904491449244934494449544964497449844994500450145024503450445054506450745084509451045114512451345144515451645174518451945204521452245234524452545264527452845294530453145324533453445354536453745384539454045414542454345444545454645474548454945504551455245534554455545564557455845594560456145624563456445654566456745684569457045714572457345744575457645774578457945804581458245834584458545864587458845894590459145924593459445954596459745984599460046014602460346044605460646074608460946104611461246134614461546164617461846194620462146224623462446254626462746284629463046314632463346344635463646374638463946404641464246434644464546464647464846494650465146524653465446554656465746584659466046614662466346644665466646674668466946704671467246734674467546764677467846794680468146824683468446854686468746884689469046914692469346944695469646974698469947004701470247034704470547064707470847094710471147124713471447154716471747184719472047214722472347244725472647274728472947304731473247334734473547364737473847394740474147424743474447454746474747484749475047514752475347544755475647574758475947604761476247634764476547664767476847694770477147724773477447754776477747784779478047814782478347844785478647874788478947904791479247934794479547964797479847994800480148024803480448054806480748084809481048114812481348144815481648174818481948204821482248234824482548264827482848294830483148324833483448354836483748384839484048414842484348444845484648474848484948504851485248534854485548564857485848594860486148624863486448654866486748684869487048714872487348744875487648774878487948804881488248834884488548864887488848894890489148924893489448954896489748984899490049014902490349044905490649074908490949104911491249134914491549164917491849194920492149224923492449254926492749284929493049314932493349344935493649374938493949404941494249434944494549464947494849494950495149524953495449554956495749584959496049614962496349644965496649674968496949704971497249734974497549764977497849794980498149824983498449854986498749884989499049914992499349944995499649974998499950005001500250035004500550065007500850095010501150125013501450155016501750185019502050215022502350245025502650275028502950305031503250335034503550365037503850395040504150425043504450455046504750485049505050515052505350545055505650575058505950605061506250635064506550665067506850695070507150725073507450755076507750785079508050815082508350845085508650875088508950905091509250935094509550965097509850995100510151025103510451055106510751085109511051115112511351145115511651175118511951205121512251235124512551265127512851295130513151325133513451355136513751385139514051415142514351445145514651475148514951505151515251535154515551565157515851595160516151625163516451655166516751685169517051715172517351745175517651775178517951805181518251835184518551865187518851895190519151925193519451955196519751985199520052015202520352045205520652075208520952105211521252135214521552165217521852195220522152225223522452255226522752285229523052315232523352345235523652375238523952405241524252435244524552465247524852495250525152525253525452555256525752585259526052615262526352645265526652675268526952705271527252735274527552765277527852795280528152825283528452855286528752885289529052915292529352945295529652975298529953005301530253035304530553065307530853095310531153125313531453155316531753185319532053215322532353245325532653275328532953305331533253335334533553365337533853395340534153425343534453455346534753485349535053515352535353545355535653575358535953605361536253635364536553665367536853695370537153725373537453755376537753785379538053815382538353845385538653875388538953905391539253935394539553965397539853995400540154025403540454055406540754085409541054115412541354145415541654175418541954205421542254235424542554265427542854295430543154325433543454355436543754385439544054415442544354445445544654475448544954505451545254535454545554565457545854595460546154625463546454655466546754685469547054715472547354745475547654775478547954805481548254835484548554865487548854895490549154925493549454955496549754985499550055015502550355045505550655075508550955105511551255135514551555165517551855195520552155225523552455255526552755285529553055315532553355345535553655375538553955405541554255435544554555465547554855495550555155525553555455555556555755585559556055615562556355645565556655675568556955705571557255735574557555765577557855795580558155825583558455855586558755885589559055915592559355945595559655975598559956005601560256035604560556065607560856095610561156125613561456155616561756185619562056215622562356245625562656275628562956305631
  1. package http
  2. import (
  3. "context"
  4. "encoding/json"
  5. "errors"
  6. "fmt"
  7. "io"
  8. "log/slog"
  9. "math"
  10. "net/http"
  11. "net/http/httptest"
  12. "net/mail"
  13. "net/netip"
  14. "strings"
  15. "testing"
  16. "time"
  17. "github.com/stretchr/testify/assert"
  18. "github.com/stretchr/testify/mock"
  19. "github.com/mk6i/open-oscar-server/config"
  20. "github.com/mk6i/open-oscar-server/state"
  21. "github.com/mk6i/open-oscar-server/wire"
  22. )
  23. func TestSessionHandler_GET(t *testing.T) {
  24. // Fixed time for testing: 2024-01-01 12:00:00 UTC
  25. fixedNow := time.Date(2024, 1, 1, 12, 0, 0, 0, time.UTC)
  26. nowFn := func() time.Time { return fixedNow }
  27. tt := []struct {
  28. name string
  29. want string
  30. statusCode int
  31. createSessions func() []*state.Session
  32. }{
  33. {
  34. name: "without sessions",
  35. want: `{"count":0,"sessions":[]}`,
  36. statusCode: http.StatusOK,
  37. createSessions: func() []*state.Session {
  38. return []*state.Session{}
  39. },
  40. },
  41. {
  42. name: "with sessions",
  43. want: `{"count":3,"sessions":[{"id":"usera","screen_name":"userA","online_seconds":100,"is_away":false,"away_message":"","idle_seconds":0,"is_invisible":false,"is_icq":false,"instance_count":2,"instances":[{"num":1,"idle_seconds":30,"is_away":false,"away_message":"","is_invisible":false,"remote_addr":"1.2.3.4","remote_port":1234},{"num":2,"idle_seconds":0,"is_away":false,"away_message":"","is_invisible":true,"remote_addr":"5.6.7.8","remote_port":5678}]},{"id":"userb","screen_name":"userB","online_seconds":200,"is_away":false,"away_message":"","idle_seconds":0,"is_invisible":true,"is_icq":false,"instance_count":2,"instances":[{"num":1,"idle_seconds":0,"is_away":false,"away_message":"","is_invisible":true,"remote_addr":"9.10.11.12","remote_port":9012},{"num":2,"idle_seconds":0,"is_away":false,"away_message":"","is_invisible":true,"remote_addr":"13.14.15.16","remote_port":1314}]},{"id":"100003","screen_name":"100003","online_seconds":300,"is_away":false,"away_message":"","idle_seconds":0,"is_invisible":false,"is_icq":true,"instance_count":1,"instances":[{"num":1,"idle_seconds":0,"is_away":false,"away_message":"","is_invisible":false,"remote_addr":"1.2.3.4","remote_port":1234}]}]}`,
  44. statusCode: http.StatusOK,
  45. createSessions: func() []*state.Session {
  46. // userA: 2 instances - one idle (30s), one invisible
  47. userA := state.NewSession()
  48. userA.SetIdentScreenName(state.NewIdentScreenName("userA"))
  49. userA.SetDisplayScreenName(state.DisplayScreenName("userA"))
  50. userA.SetUIN(0)
  51. userA.SetNowFn(nowFn)
  52. userA.SetSignonTime(fixedNow.Add(-100 * time.Second))
  53. inst1 := userA.AddInstance()
  54. inst1.SetSignonComplete()
  55. inst1.SetIdle(30 * time.Second)
  56. ip1, _ := netip.ParseAddrPort("1.2.3.4:1234")
  57. inst1.SetRemoteAddr(&ip1)
  58. inst2 := userA.AddInstance()
  59. inst2.SetSignonComplete()
  60. inst2.SetUserStatusBitmask(wire.OServiceUserStatusInvisible)
  61. ip2, _ := netip.ParseAddrPort("5.6.7.8:5678")
  62. inst2.SetRemoteAddr(&ip2)
  63. // userB: 2 instances - both invisible
  64. userB := state.NewSession()
  65. userB.SetIdentScreenName(state.NewIdentScreenName("userB"))
  66. userB.SetDisplayScreenName(state.DisplayScreenName("userB"))
  67. userB.SetUIN(0)
  68. userB.SetNowFn(nowFn)
  69. userB.SetSignonTime(fixedNow.Add(-200 * time.Second))
  70. inst3 := userB.AddInstance()
  71. inst3.SetSignonComplete()
  72. inst3.SetUserStatusBitmask(wire.OServiceUserStatusInvisible)
  73. ip3, _ := netip.ParseAddrPort("9.10.11.12:9012")
  74. inst3.SetRemoteAddr(&ip3)
  75. inst4 := userB.AddInstance()
  76. inst4.SetSignonComplete()
  77. inst4.SetUserStatusBitmask(wire.OServiceUserStatusInvisible)
  78. ip4, _ := netip.ParseAddrPort("13.14.15.16:1314")
  79. inst4.SetRemoteAddr(&ip4)
  80. // 100003: 1 instance - normal
  81. icqUser := state.NewSession()
  82. icqUser.SetIdentScreenName(state.NewIdentScreenName("100003"))
  83. icqUser.SetDisplayScreenName(state.DisplayScreenName("100003"))
  84. icqUser.SetUIN(100003)
  85. icqUser.SetNowFn(nowFn)
  86. icqUser.SetSignonTime(fixedNow.Add(-300 * time.Second))
  87. inst5 := icqUser.AddInstance()
  88. inst5.SetSignonComplete()
  89. ip5, _ := netip.ParseAddrPort("1.2.3.4:1234")
  90. inst5.SetRemoteAddr(&ip5)
  91. return []*state.Session{userA, userB, icqUser}
  92. },
  93. },
  94. {
  95. name: "with away sessions",
  96. want: `{"count":2,"sessions":[{"id":"usera","screen_name":"userA","online_seconds":100,"is_away":false,"away_message":"","idle_seconds":0,"is_invisible":false,"is_icq":false,"instance_count":2,"instances":[{"num":1,"idle_seconds":0,"is_away":true,"away_message":"Away message 1","is_invisible":false,"remote_addr":"1.2.3.4","remote_port":1234},{"num":2,"idle_seconds":0,"is_away":false,"away_message":"","is_invisible":false,"remote_addr":"5.6.7.8","remote_port":5678}]},{"id":"userb","screen_name":"userB","online_seconds":200,"is_away":true,"away_message":"Away message 2","idle_seconds":0,"is_invisible":false,"is_icq":false,"instance_count":2,"instances":[{"num":1,"idle_seconds":0,"is_away":true,"away_message":"Away message 2","is_invisible":false,"remote_addr":"9.10.11.12","remote_port":9012},{"num":2,"idle_seconds":0,"is_away":true,"away_message":"Away message 2","is_invisible":false,"remote_addr":"13.14.15.16","remote_port":1314}]}]}`,
  97. statusCode: http.StatusOK,
  98. createSessions: func() []*state.Session {
  99. // userA: 2 instances - one away, one not away (away_message should be "")
  100. userA := state.NewSession()
  101. userA.SetIdentScreenName(state.NewIdentScreenName("userA"))
  102. userA.SetDisplayScreenName(state.DisplayScreenName("userA"))
  103. userA.SetUIN(0)
  104. userA.SetNowFn(nowFn)
  105. userA.SetSignonTime(fixedNow.Add(-100 * time.Second))
  106. inst1 := userA.AddInstance()
  107. inst1.SetSignonComplete()
  108. inst1.SetUserStatusBitmask(wire.OServiceUserStatusAway)
  109. inst1.SetAwayMessage("Away message 1")
  110. ip1, _ := netip.ParseAddrPort("1.2.3.4:1234")
  111. inst1.SetRemoteAddr(&ip1)
  112. inst2 := userA.AddInstance()
  113. inst2.SetSignonComplete()
  114. ip2, _ := netip.ParseAddrPort("5.6.7.8:5678")
  115. inst2.SetRemoteAddr(&ip2)
  116. // userB: 2 instances - both away (away_message should be populated)
  117. userB := state.NewSession()
  118. userB.SetIdentScreenName(state.NewIdentScreenName("userB"))
  119. userB.SetDisplayScreenName(state.DisplayScreenName("userB"))
  120. userB.SetUIN(0)
  121. userB.SetNowFn(nowFn)
  122. userB.SetSignonTime(fixedNow.Add(-200 * time.Second))
  123. inst3 := userB.AddInstance()
  124. inst3.SetSignonComplete()
  125. inst3.SetUserStatusBitmask(wire.OServiceUserStatusAway)
  126. inst3.SetAwayMessage("Away message 2")
  127. ip3, _ := netip.ParseAddrPort("9.10.11.12:9012")
  128. inst3.SetRemoteAddr(&ip3)
  129. inst4 := userB.AddInstance()
  130. inst4.SetSignonComplete()
  131. inst4.SetUserStatusBitmask(wire.OServiceUserStatusAway)
  132. inst4.SetAwayMessage("Away message 2")
  133. ip4, _ := netip.ParseAddrPort("13.14.15.16:1314")
  134. inst4.SetRemoteAddr(&ip4)
  135. return []*state.Session{userA, userB}
  136. },
  137. },
  138. }
  139. for _, tc := range tt {
  140. t.Run(tc.name, func(t *testing.T) {
  141. request := httptest.NewRequest(http.MethodGet, "/session", nil)
  142. responseRecorder := httptest.NewRecorder()
  143. sessionRetriever := newMockSessionRetriever(t)
  144. sessions := tc.createSessions()
  145. sessionRetriever.EXPECT().
  146. AllSessions().
  147. Return(sessions)
  148. getSessionHandler(responseRecorder, request, sessionRetriever, nowFn)
  149. if responseRecorder.Code != tc.statusCode {
  150. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  151. }
  152. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  153. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  154. }
  155. })
  156. }
  157. }
  158. func TestSessionHandlerScreenname_GET(t *testing.T) {
  159. // Fixed time for testing: 2024-01-01 12:00:00 UTC
  160. fixedNow := time.Date(2024, 1, 1, 12, 0, 0, 0, time.UTC)
  161. nowFn := func() time.Time { return fixedNow }
  162. tt := []struct {
  163. name string
  164. requestScreenName state.IdentScreenName
  165. want string
  166. statusCode int
  167. createSession func() *state.Session
  168. }{
  169. {
  170. name: "no session for screenname",
  171. requestScreenName: state.NewIdentScreenName("userA"),
  172. want: `session not found`,
  173. statusCode: http.StatusNotFound,
  174. createSession: func() *state.Session {
  175. return nil
  176. },
  177. },
  178. {
  179. name: "active session found for screenname",
  180. requestScreenName: state.NewIdentScreenName("userA"),
  181. want: `{"count":1,"sessions":[{"id":"usera","screen_name":"userA","online_seconds":150,"is_away":false,"away_message":"","idle_seconds":0,"is_invisible":false,"is_icq":false,"instance_count":1,"instances":[{"num":1,"idle_seconds":0,"is_away":false,"away_message":"","is_invisible":false,"remote_addr":"1.2.3.4","remote_port":1234}]}]}`,
  182. statusCode: http.StatusOK,
  183. createSession: func() *state.Session {
  184. sess := state.NewSession()
  185. sess.SetIdentScreenName(state.NewIdentScreenName("userA"))
  186. sess.SetDisplayScreenName(state.DisplayScreenName("userA"))
  187. sess.SetUIN(0)
  188. sess.SetNowFn(nowFn)
  189. sess.SetSignonTime(fixedNow.Add(-150 * time.Second))
  190. instance := sess.AddInstance()
  191. instance.SetSignonComplete()
  192. ip, _ := netip.ParseAddrPort("1.2.3.4:1234")
  193. instance.SetRemoteAddr(&ip)
  194. return sess
  195. },
  196. },
  197. }
  198. for _, tc := range tt {
  199. t.Run(tc.name, func(t *testing.T) {
  200. request := httptest.NewRequest(http.MethodGet, "/session/"+tc.requestScreenName.String(), nil)
  201. request.SetPathValue("screenname", tc.requestScreenName.String())
  202. responseRecorder := httptest.NewRecorder()
  203. sessionRetriever := newMockSessionRetriever(t)
  204. session := tc.createSession()
  205. sessionRetriever.EXPECT().
  206. RetrieveSession(tc.requestScreenName).
  207. Return(session)
  208. getSessionHandler(responseRecorder, request, sessionRetriever, nowFn)
  209. if responseRecorder.Code != tc.statusCode {
  210. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  211. }
  212. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  213. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  214. }
  215. })
  216. }
  217. }
  218. func TestSessionHandlerScreenname_DELETE(t *testing.T) {
  219. fnNewSess := func(screenName string) *state.Session {
  220. sess := state.NewSession()
  221. sess.SetIdentScreenName(state.NewIdentScreenName(screenName))
  222. sess.SetDisplayScreenName(state.DisplayScreenName(screenName))
  223. instance := sess.AddInstance()
  224. instance.SetSignonComplete()
  225. ip, _ := netip.ParseAddrPort("1.2.3.4:1234")
  226. instance.SetRemoteAddr(&ip)
  227. return sess
  228. }
  229. tt := []struct {
  230. name string
  231. session *state.SessionInstance
  232. requestScreenName state.IdentScreenName
  233. statusCode int
  234. mockParams mockParams
  235. }{
  236. {
  237. name: "delete an active session",
  238. requestScreenName: state.NewIdentScreenName("userA"),
  239. statusCode: http.StatusNoContent,
  240. mockParams: mockParams{
  241. sessionRetrieverParams: sessionRetrieverParams{
  242. retrieveSessionByNameParams: retrieveSessionByNameParams{
  243. {
  244. screenName: state.NewIdentScreenName("userA"),
  245. result: fnNewSess("userA"),
  246. },
  247. },
  248. },
  249. },
  250. },
  251. {
  252. name: "delete a non-existent session",
  253. requestScreenName: state.NewIdentScreenName("userA"),
  254. statusCode: http.StatusNotFound,
  255. mockParams: mockParams{
  256. sessionRetrieverParams: sessionRetrieverParams{
  257. retrieveSessionByNameParams: retrieveSessionByNameParams{
  258. {
  259. screenName: state.NewIdentScreenName("userA"),
  260. result: nil,
  261. },
  262. },
  263. },
  264. },
  265. },
  266. }
  267. for _, tc := range tt {
  268. t.Run(tc.name, func(t *testing.T) {
  269. request := httptest.NewRequest(http.MethodDelete, "/session/"+tc.requestScreenName.String(), nil)
  270. request.SetPathValue("screenname", tc.requestScreenName.String())
  271. responseRecorder := httptest.NewRecorder()
  272. sessionRetriever := newMockSessionRetriever(t)
  273. for _, params := range tc.mockParams.retrieveSessionByNameParams {
  274. sessionRetriever.EXPECT().
  275. RetrieveSession(params.screenName).
  276. Return(params.result)
  277. }
  278. deleteSessionHandler(responseRecorder, request, sessionRetriever)
  279. if responseRecorder.Code != tc.statusCode {
  280. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  281. }
  282. })
  283. }
  284. }
  285. func TestUserAccountHandler_GET(t *testing.T) {
  286. tt := []struct {
  287. name string
  288. requestScreenName state.IdentScreenName
  289. want string
  290. statusCode int
  291. mockParams mockParams
  292. }{
  293. {
  294. name: "invalid account",
  295. requestScreenName: state.NewIdentScreenName("userA"),
  296. want: `user not found`,
  297. statusCode: http.StatusNotFound,
  298. mockParams: mockParams{
  299. userManagerParams: userManagerParams{
  300. getUserParams: getUserParams{
  301. {
  302. screenName: state.NewIdentScreenName("userA"),
  303. result: nil,
  304. },
  305. },
  306. },
  307. },
  308. },
  309. {
  310. name: "valid aim account",
  311. requestScreenName: state.NewIdentScreenName("userA"),
  312. want: `{"id":"usera","screen_name":"userA","profile":"My Profile Text","email_address":"\u003cuserA@aol.com\u003e","reg_status":2,"confirmed":true,"is_icq":false,"suspended_status":"","is_bot":false}`,
  313. statusCode: http.StatusOK,
  314. mockParams: mockParams{
  315. userManagerParams: userManagerParams{
  316. getUserParams: getUserParams{
  317. {
  318. screenName: state.NewIdentScreenName("userA"),
  319. result: &state.User{
  320. DisplayScreenName: "userA",
  321. IdentScreenName: state.NewIdentScreenName("userA"),
  322. SuspendedStatus: 0x0,
  323. },
  324. },
  325. },
  326. },
  327. accountManagerParams: accountManagerParams{
  328. EmailAddressParams: EmailAddressParams{
  329. {
  330. screenName: state.NewIdentScreenName("userA"),
  331. result: &mail.Address{
  332. Address: "userA@aol.com",
  333. },
  334. },
  335. },
  336. RegStatusParams: RegStatusParams{
  337. {
  338. screenName: state.NewIdentScreenName("userA"),
  339. result: uint16(0x02),
  340. },
  341. },
  342. ConfirmStatusParams: ConfirmStatusParams{
  343. {
  344. screenName: state.NewIdentScreenName("userA"),
  345. result: true,
  346. },
  347. },
  348. },
  349. profileRetrieverParams: profileRetrieverParams{
  350. retrieveProfileParams: retrieveProfileParams{
  351. {
  352. screenName: state.NewIdentScreenName("userA"),
  353. result: state.UserProfile{ProfileText: "My Profile Text"},
  354. },
  355. },
  356. },
  357. },
  358. },
  359. {
  360. name: "valid aim bot account",
  361. requestScreenName: state.NewIdentScreenName("userA"),
  362. want: `{"id":"usera","screen_name":"userA","profile":"My Profile Text","email_address":"\u003cuserA@aol.com\u003e","reg_status":2,"confirmed":true,"is_icq":false,"suspended_status":"","is_bot":true}`,
  363. statusCode: http.StatusOK,
  364. mockParams: mockParams{
  365. userManagerParams: userManagerParams{
  366. getUserParams: getUserParams{
  367. {
  368. screenName: state.NewIdentScreenName("userA"),
  369. result: &state.User{
  370. DisplayScreenName: "userA",
  371. IdentScreenName: state.NewIdentScreenName("userA"),
  372. SuspendedStatus: 0x0,
  373. IsBot: true,
  374. },
  375. },
  376. },
  377. },
  378. accountManagerParams: accountManagerParams{
  379. EmailAddressParams: EmailAddressParams{
  380. {
  381. screenName: state.NewIdentScreenName("userA"),
  382. result: &mail.Address{
  383. Address: "userA@aol.com",
  384. },
  385. },
  386. },
  387. RegStatusParams: RegStatusParams{
  388. {
  389. screenName: state.NewIdentScreenName("userA"),
  390. result: uint16(0x02),
  391. },
  392. },
  393. ConfirmStatusParams: ConfirmStatusParams{
  394. {
  395. screenName: state.NewIdentScreenName("userA"),
  396. result: true,
  397. },
  398. },
  399. },
  400. profileRetrieverParams: profileRetrieverParams{
  401. retrieveProfileParams: retrieveProfileParams{
  402. {
  403. screenName: state.NewIdentScreenName("userA"),
  404. result: state.UserProfile{ProfileText: "My Profile Text"},
  405. },
  406. },
  407. },
  408. },
  409. },
  410. {
  411. name: "suspended aim account",
  412. requestScreenName: state.NewIdentScreenName("userB"),
  413. want: `{"id":"userb","screen_name":"userB","profile":"My Profile Text","email_address":"\u003cuserB@aol.com\u003e","reg_status":2,"confirmed":true,"is_icq":false,"suspended_status":"suspended","is_bot":false}`,
  414. statusCode: http.StatusOK,
  415. mockParams: mockParams{
  416. userManagerParams: userManagerParams{
  417. getUserParams: getUserParams{
  418. {
  419. screenName: state.NewIdentScreenName("userB"),
  420. result: &state.User{
  421. DisplayScreenName: "userB",
  422. IdentScreenName: state.NewIdentScreenName("userB"),
  423. SuspendedStatus: wire.LoginErrSuspendedAccount,
  424. },
  425. },
  426. },
  427. },
  428. accountManagerParams: accountManagerParams{
  429. EmailAddressParams: EmailAddressParams{
  430. {
  431. screenName: state.NewIdentScreenName("userB"),
  432. result: &mail.Address{
  433. Address: "userB@aol.com",
  434. },
  435. },
  436. },
  437. RegStatusParams: RegStatusParams{
  438. {
  439. screenName: state.NewIdentScreenName("userB"),
  440. result: uint16(0x02),
  441. },
  442. },
  443. ConfirmStatusParams: ConfirmStatusParams{
  444. {
  445. screenName: state.NewIdentScreenName("userB"),
  446. result: true,
  447. },
  448. },
  449. },
  450. profileRetrieverParams: profileRetrieverParams{
  451. retrieveProfileParams: retrieveProfileParams{
  452. {
  453. screenName: state.NewIdentScreenName("userB"),
  454. result: state.UserProfile{ProfileText: "My Profile Text"},
  455. },
  456. },
  457. },
  458. },
  459. },
  460. }
  461. for _, tc := range tt {
  462. t.Run(tc.name, func(t *testing.T) {
  463. request := httptest.NewRequest(http.MethodGet, "/user/"+tc.requestScreenName.String()+"/account", nil)
  464. request.SetPathValue("screenname", tc.requestScreenName.String())
  465. responseRecorder := httptest.NewRecorder()
  466. userManager := newMockUserManager(t)
  467. for _, params := range tc.mockParams.getUserParams {
  468. userManager.EXPECT().
  469. User(matchContext(), params.screenName).
  470. Return(params.result, params.err)
  471. }
  472. accountManager := newMockAccountManager(t)
  473. for _, params := range tc.mockParams.EmailAddressParams {
  474. accountManager.EXPECT().
  475. EmailAddress(matchContext(), params.screenName).
  476. Return(params.result, params.err)
  477. }
  478. for _, params := range tc.mockParams.RegStatusParams {
  479. accountManager.EXPECT().
  480. RegStatus(matchContext(), params.screenName).
  481. Return(params.result, params.err)
  482. }
  483. for _, params := range tc.mockParams.ConfirmStatusParams {
  484. accountManager.EXPECT().
  485. ConfirmStatus(matchContext(), params.screenName).
  486. Return(params.result, params.err)
  487. }
  488. profileRetriever := newMockProfileRetriever(t)
  489. for _, params := range tc.mockParams.retrieveProfileParams {
  490. profileRetriever.EXPECT().
  491. Profile(matchContext(), params.screenName).
  492. Return(params.result, params.err)
  493. }
  494. getUserAccountHandler(responseRecorder, request, userManager, accountManager, profileRetriever, slog.Default())
  495. if responseRecorder.Code != tc.statusCode {
  496. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  497. }
  498. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  499. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  500. }
  501. })
  502. }
  503. }
  504. func TestUserAccountHandler_PATCH(t *testing.T) {
  505. tt := []struct {
  506. name string
  507. requestScreenName state.IdentScreenName
  508. want string
  509. body string
  510. statusCode int
  511. mockParams mockParams
  512. }{
  513. {
  514. name: "suspending a non-existent account",
  515. requestScreenName: state.NewIdentScreenName("userA"),
  516. body: `{"suspended_status":"suspended"}`,
  517. want: `user not found`,
  518. statusCode: http.StatusNotFound,
  519. mockParams: mockParams{
  520. userManagerParams: userManagerParams{
  521. getUserParams: getUserParams{
  522. {
  523. screenName: state.NewIdentScreenName("userA"),
  524. result: nil,
  525. },
  526. },
  527. },
  528. },
  529. },
  530. {
  531. name: "patching with invalid suspended_status value",
  532. requestScreenName: state.NewIdentScreenName("userA"),
  533. body: `{"suspended_status":"thisisinvalid"}`,
  534. want: `{"message":"suspended_status must be empty str or one of deleted,expired,suspended,suspended_age"}`,
  535. statusCode: http.StatusBadRequest,
  536. mockParams: mockParams{
  537. userManagerParams: userManagerParams{
  538. getUserParams: getUserParams{
  539. {
  540. screenName: state.NewIdentScreenName("userA"),
  541. result: &state.User{},
  542. },
  543. },
  544. },
  545. },
  546. },
  547. {
  548. name: "suspending an active aim account",
  549. requestScreenName: state.NewIdentScreenName("userA"),
  550. statusCode: http.StatusNoContent,
  551. body: `{"suspended_status":"suspended"}`,
  552. mockParams: mockParams{
  553. userManagerParams: userManagerParams{
  554. getUserParams: getUserParams{
  555. {
  556. screenName: state.NewIdentScreenName("userA"),
  557. result: &state.User{
  558. DisplayScreenName: "userA",
  559. IdentScreenName: state.NewIdentScreenName("userA"),
  560. SuspendedStatus: 0x0,
  561. },
  562. },
  563. },
  564. },
  565. accountManagerParams: accountManagerParams{
  566. updateSuspendedStatusParams: updateSuspendedStatusParams{
  567. {
  568. suspendedStatus: wire.LoginErrSuspendedAccount,
  569. screenName: state.NewIdentScreenName("userA"),
  570. err: nil,
  571. },
  572. },
  573. },
  574. },
  575. },
  576. {
  577. name: "unsuspending a suspended aim account",
  578. requestScreenName: state.NewIdentScreenName("userA"),
  579. statusCode: http.StatusNoContent,
  580. body: `{"suspended_status":""}`,
  581. mockParams: mockParams{
  582. userManagerParams: userManagerParams{
  583. getUserParams: getUserParams{
  584. {
  585. screenName: state.NewIdentScreenName("userA"),
  586. result: &state.User{
  587. DisplayScreenName: "userA",
  588. IdentScreenName: state.NewIdentScreenName("userA"),
  589. SuspendedStatus: wire.LoginErrSuspendedAccount,
  590. },
  591. },
  592. },
  593. },
  594. accountManagerParams: accountManagerParams{
  595. updateSuspendedStatusParams: updateSuspendedStatusParams{
  596. {
  597. suspendedStatus: 0x0,
  598. screenName: state.NewIdentScreenName("userA"),
  599. err: nil,
  600. },
  601. },
  602. },
  603. },
  604. },
  605. {
  606. name: "suspending an already suspended aim account",
  607. requestScreenName: state.NewIdentScreenName("userA"),
  608. statusCode: http.StatusNotModified,
  609. body: `{"suspended_status":"suspended"}`,
  610. mockParams: mockParams{
  611. userManagerParams: userManagerParams{
  612. getUserParams: getUserParams{
  613. {
  614. screenName: state.NewIdentScreenName("userA"),
  615. result: &state.User{
  616. DisplayScreenName: "userA",
  617. IdentScreenName: state.NewIdentScreenName("userA"),
  618. SuspendedStatus: wire.LoginErrSuspendedAccount,
  619. },
  620. },
  621. },
  622. },
  623. },
  624. },
  625. {
  626. name: "setting bot flag (before: false, after: true)",
  627. requestScreenName: state.NewIdentScreenName("userA"),
  628. statusCode: http.StatusNoContent,
  629. body: `{"is_bot":true}`,
  630. mockParams: mockParams{
  631. userManagerParams: userManagerParams{
  632. getUserParams: getUserParams{
  633. {
  634. screenName: state.NewIdentScreenName("userA"),
  635. result: &state.User{
  636. DisplayScreenName: "userA",
  637. IdentScreenName: state.NewIdentScreenName("userA"),
  638. SuspendedStatus: 0x0,
  639. IsBot: false,
  640. },
  641. },
  642. },
  643. },
  644. accountManagerParams: accountManagerParams{
  645. setBotStatusParams: setBotStatusParams{
  646. {
  647. isBot: true,
  648. screenName: state.NewIdentScreenName("userA"),
  649. err: nil,
  650. },
  651. },
  652. },
  653. },
  654. },
  655. {
  656. name: "setting bot flag (before: true, after: false)",
  657. requestScreenName: state.NewIdentScreenName("userA"),
  658. statusCode: http.StatusNoContent,
  659. body: `{"is_bot":false}`,
  660. mockParams: mockParams{
  661. userManagerParams: userManagerParams{
  662. getUserParams: getUserParams{
  663. {
  664. screenName: state.NewIdentScreenName("userA"),
  665. result: &state.User{
  666. DisplayScreenName: "userA",
  667. IdentScreenName: state.NewIdentScreenName("userA"),
  668. SuspendedStatus: 0x0,
  669. IsBot: true,
  670. },
  671. },
  672. },
  673. },
  674. accountManagerParams: accountManagerParams{
  675. setBotStatusParams: setBotStatusParams{
  676. {
  677. isBot: false,
  678. screenName: state.NewIdentScreenName("userA"),
  679. err: nil,
  680. },
  681. },
  682. },
  683. },
  684. },
  685. {
  686. name: "setting bot flag (before: true, after: true)",
  687. requestScreenName: state.NewIdentScreenName("userA"),
  688. statusCode: http.StatusNotModified,
  689. body: `{"is_bot":true}`,
  690. mockParams: mockParams{
  691. userManagerParams: userManagerParams{
  692. getUserParams: getUserParams{
  693. {
  694. screenName: state.NewIdentScreenName("userA"),
  695. result: &state.User{
  696. DisplayScreenName: "userA",
  697. IdentScreenName: state.NewIdentScreenName("userA"),
  698. SuspendedStatus: 0x0,
  699. IsBot: true,
  700. },
  701. },
  702. },
  703. },
  704. },
  705. },
  706. }
  707. for _, tc := range tt {
  708. t.Run(tc.name, func(t *testing.T) {
  709. request := httptest.NewRequest(http.MethodPatch, "/user/"+tc.requestScreenName.String()+"/account", strings.NewReader(tc.body))
  710. request.SetPathValue("screenname", tc.requestScreenName.String())
  711. responseRecorder := httptest.NewRecorder()
  712. userManager := newMockUserManager(t)
  713. for _, params := range tc.mockParams.getUserParams {
  714. userManager.EXPECT().
  715. User(matchContext(), params.screenName).
  716. Return(params.result, params.err)
  717. }
  718. accountManager := newMockAccountManager(t)
  719. for _, params := range tc.mockParams.updateSuspendedStatusParams {
  720. accountManager.EXPECT().
  721. UpdateSuspendedStatus(matchContext(), params.suspendedStatus, params.screenName).
  722. Return(params.err)
  723. }
  724. for _, params := range tc.mockParams.setBotStatusParams {
  725. accountManager.EXPECT().
  726. SetBotStatus(matchContext(), params.isBot, params.screenName).
  727. Return(params.err)
  728. }
  729. patchUserAccountHandler(responseRecorder, request, userManager, accountManager, slog.Default())
  730. if responseRecorder.Code != tc.statusCode {
  731. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  732. }
  733. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  734. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  735. }
  736. })
  737. }
  738. }
  739. func TestUserBuddyIconHandler_GET(t *testing.T) {
  740. sampleGIF := []byte{
  741. 0x47, 0x49, 0x46, 0x38, 0x39, 0x61, 0x32, 0x00, 0x32, 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
  742. 0x00, 0x00, 0x00, 0x21, 0xf9, 0x04, 0x01, 0x00, 0x00, 0x00, 0x00, 0x2c, 0x00, 0x00, 0x00, 0x00,
  743. 0x32, 0x00, 0x32, 0x00, 0x00, 0x02, 0x02, 0x44, 0x01, 0x00, 0x3b}
  744. sampleJPG := []byte{0xFF, 0xD8, 0xFF, 0x43, 0x13, 0x37}
  745. tt := []struct {
  746. name string
  747. requestScreenName state.IdentScreenName
  748. want string
  749. statusCode int
  750. contentType string
  751. mockParams mockParams
  752. }{
  753. {
  754. name: "invalid account",
  755. requestScreenName: state.NewIdentScreenName("userA"),
  756. want: `user not found`,
  757. statusCode: http.StatusNotFound,
  758. contentType: "text/plain; charset=utf-8",
  759. mockParams: mockParams{
  760. userManagerParams: userManagerParams{
  761. getUserParams: getUserParams{
  762. {
  763. screenName: state.NewIdentScreenName("userA"),
  764. result: nil,
  765. },
  766. },
  767. },
  768. },
  769. },
  770. {
  771. name: "account with gif buddy icon",
  772. requestScreenName: state.NewIdentScreenName("userA"),
  773. want: string(sampleGIF),
  774. statusCode: http.StatusOK,
  775. contentType: "image/gif",
  776. mockParams: mockParams{
  777. userManagerParams: userManagerParams{
  778. getUserParams: getUserParams{
  779. {
  780. screenName: state.NewIdentScreenName("userA"),
  781. result: &state.User{
  782. DisplayScreenName: "userA",
  783. IdentScreenName: state.NewIdentScreenName("userA"),
  784. },
  785. },
  786. },
  787. },
  788. feedBagRetrieverParams: feedBagRetrieverParams{
  789. buddyIconMetadataParams: buddyIconMetadataParams{
  790. {
  791. screenName: state.NewIdentScreenName("userA"),
  792. result: &wire.BARTID{
  793. Type: wire.BARTTypesBuddyIcon,
  794. BARTInfo: wire.BARTInfo{
  795. Flags: 0x00,
  796. Hash: []byte{'t', 'h', 'e', 'h', 'a', 's', 'h'},
  797. },
  798. },
  799. },
  800. },
  801. },
  802. bartAssetManagerParams: bartAssetManagerParams{
  803. bartItemParams: bartItemParams{
  804. {
  805. hash: []byte{'t', 'h', 'e', 'h', 'a', 's', 'h'},
  806. result: sampleGIF,
  807. },
  808. },
  809. },
  810. },
  811. },
  812. {
  813. name: "account with jpg buddy icon",
  814. requestScreenName: state.NewIdentScreenName("userA"),
  815. want: string(sampleJPG),
  816. statusCode: http.StatusOK,
  817. contentType: "image/jpeg",
  818. mockParams: mockParams{
  819. userManagerParams: userManagerParams{
  820. getUserParams: getUserParams{
  821. {
  822. screenName: state.NewIdentScreenName("userA"),
  823. result: &state.User{
  824. DisplayScreenName: "userA",
  825. IdentScreenName: state.NewIdentScreenName("userA"),
  826. },
  827. },
  828. },
  829. },
  830. feedBagRetrieverParams: feedBagRetrieverParams{
  831. buddyIconMetadataParams: buddyIconMetadataParams{
  832. {
  833. screenName: state.NewIdentScreenName("userA"),
  834. result: &wire.BARTID{
  835. Type: wire.BARTTypesBuddyIcon,
  836. BARTInfo: wire.BARTInfo{
  837. Flags: 0x00,
  838. Hash: []byte{'t', 'h', 'e', 'h', 'a', 's', 'h'},
  839. },
  840. },
  841. },
  842. },
  843. },
  844. bartAssetManagerParams: bartAssetManagerParams{
  845. bartItemParams: bartItemParams{
  846. {
  847. hash: []byte{'t', 'h', 'e', 'h', 'a', 's', 'h'},
  848. result: sampleJPG,
  849. },
  850. },
  851. },
  852. },
  853. },
  854. {
  855. name: "account with unknown format buddy icon",
  856. requestScreenName: state.NewIdentScreenName("userA"),
  857. want: string([]byte{0x13, 0x37, 0x13, 0x37, 0x13, 0x37}),
  858. statusCode: http.StatusOK,
  859. contentType: "application/octet-stream",
  860. mockParams: mockParams{
  861. userManagerParams: userManagerParams{
  862. getUserParams: getUserParams{
  863. {
  864. screenName: state.NewIdentScreenName("userA"),
  865. result: &state.User{
  866. DisplayScreenName: "userA",
  867. IdentScreenName: state.NewIdentScreenName("userA"),
  868. },
  869. },
  870. },
  871. },
  872. feedBagRetrieverParams: feedBagRetrieverParams{
  873. buddyIconMetadataParams: buddyIconMetadataParams{
  874. {
  875. screenName: state.NewIdentScreenName("userA"),
  876. result: &wire.BARTID{
  877. Type: wire.BARTTypesBuddyIcon,
  878. BARTInfo: wire.BARTInfo{
  879. Flags: 0x00,
  880. Hash: []byte{'t', 'h', 'e', 'h', 'a', 's', 'h'},
  881. },
  882. },
  883. },
  884. },
  885. },
  886. bartAssetManagerParams: bartAssetManagerParams{
  887. bartItemParams: bartItemParams{
  888. {
  889. hash: []byte{'t', 'h', 'e', 'h', 'a', 's', 'h'},
  890. result: []byte{0x13, 0x37, 0x13, 0x37, 0x13, 0x37},
  891. },
  892. },
  893. },
  894. },
  895. },
  896. {
  897. name: "account with cleared buddy icon",
  898. requestScreenName: state.NewIdentScreenName("userA"),
  899. want: "icon not found",
  900. statusCode: http.StatusNotFound,
  901. contentType: "text/plain; charset=utf-8",
  902. mockParams: mockParams{
  903. userManagerParams: userManagerParams{
  904. getUserParams: getUserParams{
  905. {
  906. screenName: state.NewIdentScreenName("userA"),
  907. result: &state.User{
  908. DisplayScreenName: "userA",
  909. IdentScreenName: state.NewIdentScreenName("userA"),
  910. },
  911. },
  912. },
  913. },
  914. feedBagRetrieverParams: feedBagRetrieverParams{
  915. buddyIconMetadataParams: buddyIconMetadataParams{
  916. {
  917. screenName: state.NewIdentScreenName("userA"),
  918. result: &wire.BARTID{
  919. Type: wire.BARTTypesBuddyIcon,
  920. BARTInfo: wire.BARTInfo{
  921. Flags: 0x00,
  922. Hash: wire.GetClearIconHash(),
  923. },
  924. },
  925. },
  926. },
  927. },
  928. },
  929. },
  930. {
  931. name: "account with no buddy icon",
  932. requestScreenName: state.NewIdentScreenName("userA"),
  933. want: "icon not found",
  934. statusCode: http.StatusNotFound,
  935. contentType: "text/plain; charset=utf-8",
  936. mockParams: mockParams{
  937. userManagerParams: userManagerParams{
  938. getUserParams: getUserParams{
  939. {
  940. screenName: state.NewIdentScreenName("userA"),
  941. result: &state.User{
  942. DisplayScreenName: "userA",
  943. IdentScreenName: state.NewIdentScreenName("userA"),
  944. },
  945. },
  946. },
  947. },
  948. feedBagRetrieverParams: feedBagRetrieverParams{
  949. buddyIconMetadataParams: buddyIconMetadataParams{
  950. {
  951. screenName: state.NewIdentScreenName("userA"),
  952. result: nil,
  953. },
  954. },
  955. },
  956. },
  957. },
  958. }
  959. for _, tc := range tt {
  960. t.Run(tc.name, func(t *testing.T) {
  961. request := httptest.NewRequest(http.MethodGet, "/user/"+tc.requestScreenName.String()+"/icon", nil)
  962. request.SetPathValue("screenname", tc.requestScreenName.String())
  963. responseRecorder := httptest.NewRecorder()
  964. userManager := newMockUserManager(t)
  965. for _, params := range tc.mockParams.getUserParams {
  966. userManager.EXPECT().
  967. User(matchContext(), params.screenName).
  968. Return(params.result, params.err)
  969. }
  970. feedbagRetriever := newMockFeedBagRetriever(t)
  971. for _, params := range tc.mockParams.buddyIconMetadataParams {
  972. feedbagRetriever.EXPECT().
  973. BuddyIconMetadata(matchContext(), params.screenName).
  974. Return(params.result, params.err)
  975. }
  976. bartRetriever := newMockBARTAssetManager(t)
  977. for _, params := range tc.mockParams.bartItemParams {
  978. bartRetriever.EXPECT().
  979. BARTItem(matchContext(), params.hash).
  980. Return(params.result, params.err)
  981. }
  982. getUserBuddyIconHandler(responseRecorder, request, userManager, feedbagRetriever, bartRetriever, slog.Default())
  983. if responseRecorder.Code != tc.statusCode {
  984. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  985. }
  986. contentType := responseRecorder.Header().Get("Content-Type")
  987. if contentType != tc.contentType {
  988. t.Errorf("Want content type '%s', got '%s'", tc.contentType, contentType)
  989. }
  990. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  991. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  992. }
  993. })
  994. }
  995. }
  996. func TestUserHandler_GET(t *testing.T) {
  997. tt := []struct {
  998. name string
  999. want string
  1000. statusCode int
  1001. mockParams mockParams
  1002. }{
  1003. {
  1004. name: "empty user store",
  1005. want: `[]`,
  1006. statusCode: http.StatusOK,
  1007. mockParams: mockParams{
  1008. userManagerParams: userManagerParams{
  1009. allUsersParams: allUsersParams{
  1010. {
  1011. result: []state.User{},
  1012. },
  1013. },
  1014. },
  1015. },
  1016. },
  1017. {
  1018. name: "user store containing 3 users",
  1019. want: `[{"id":"usera","screen_name":"userA","is_icq":false,"suspended_status":"","is_bot":false},{"id":"userb","screen_name":"userB","is_icq":false,"suspended_status":"","is_bot":true},{"id":"100003","screen_name":"100003","is_icq":true,"suspended_status":"","is_bot":false}]`,
  1020. statusCode: http.StatusOK,
  1021. mockParams: mockParams{
  1022. userManagerParams: userManagerParams{
  1023. allUsersParams: allUsersParams{
  1024. {
  1025. result: []state.User{
  1026. {
  1027. DisplayScreenName: "userA",
  1028. IdentScreenName: state.NewIdentScreenName("userA"),
  1029. },
  1030. {
  1031. DisplayScreenName: "userB",
  1032. IdentScreenName: state.NewIdentScreenName("userB"),
  1033. IsBot: true,
  1034. },
  1035. {
  1036. DisplayScreenName: "100003",
  1037. IdentScreenName: state.NewIdentScreenName("100003"),
  1038. IsICQ: true,
  1039. },
  1040. },
  1041. },
  1042. },
  1043. },
  1044. },
  1045. },
  1046. {
  1047. name: "user handler error",
  1048. want: `internal server error`,
  1049. statusCode: http.StatusInternalServerError,
  1050. mockParams: mockParams{
  1051. userManagerParams: userManagerParams{
  1052. allUsersParams: allUsersParams{
  1053. {
  1054. result: []state.User{},
  1055. err: io.EOF,
  1056. },
  1057. },
  1058. },
  1059. },
  1060. },
  1061. }
  1062. for _, tc := range tt {
  1063. t.Run(tc.name, func(t *testing.T) {
  1064. request := httptest.NewRequest(http.MethodGet, "/user", nil)
  1065. responseRecorder := httptest.NewRecorder()
  1066. userManager := newMockUserManager(t)
  1067. for _, params := range tc.mockParams.allUsersParams {
  1068. userManager.EXPECT().
  1069. AllUsers(matchContext()).
  1070. Return(params.result, params.err)
  1071. }
  1072. getUserHandler(responseRecorder, request, userManager, slog.Default())
  1073. if responseRecorder.Code != tc.statusCode {
  1074. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1075. }
  1076. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1077. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  1078. }
  1079. })
  1080. }
  1081. }
  1082. func TestUserHandler_POST(t *testing.T) {
  1083. tt := []struct {
  1084. name string
  1085. body string
  1086. want string
  1087. statusCode int
  1088. createAccount state.CreateAccountFunc
  1089. }{
  1090. {
  1091. name: "with valid AIM user",
  1092. body: `{"screen_name":"userA", "password":"thepassword"}`,
  1093. want: `User account created successfully.`,
  1094. statusCode: http.StatusCreated,
  1095. createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
  1096. assert.Equal(t, state.DisplayScreenName("userA"), screenName)
  1097. assert.Equal(t, "thepassword", password)
  1098. return nil
  1099. },
  1100. },
  1101. {
  1102. name: "with valid ICQ user",
  1103. body: `{"screen_name":"100003", "password":"thepass"}`,
  1104. want: `User account created successfully.`,
  1105. statusCode: http.StatusCreated,
  1106. createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
  1107. assert.Equal(t, state.DisplayScreenName("100003"), screenName)
  1108. assert.Equal(t, "thepass", password)
  1109. return nil
  1110. },
  1111. },
  1112. {
  1113. name: "with malformed body",
  1114. body: `{"screen_name":"userA", "password":"thepassword"`, // missing closing }
  1115. want: `malformed input`,
  1116. statusCode: http.StatusBadRequest,
  1117. },
  1118. {
  1119. name: "user handler error",
  1120. body: `{"screen_name":"userA", "password":"thepassword"}`,
  1121. want: `internal server error`,
  1122. statusCode: http.StatusInternalServerError,
  1123. createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
  1124. assert.Equal(t, state.DisplayScreenName("userA"), screenName)
  1125. assert.Equal(t, "thepassword", password)
  1126. return io.EOF
  1127. },
  1128. },
  1129. {
  1130. name: "duplicate user",
  1131. body: `{"screen_name":"userA", "password":"thepassword"}`,
  1132. want: `user already exists`,
  1133. statusCode: http.StatusConflict,
  1134. createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
  1135. assert.Equal(t, state.DisplayScreenName("userA"), screenName)
  1136. assert.Equal(t, "thepassword", password)
  1137. return state.ErrDupUser
  1138. },
  1139. },
  1140. {
  1141. name: "invalid AIM screen name",
  1142. body: `{"screen_name":"a", "password":"thepassword"}`,
  1143. want: `invalid screen name: screen name must be between 3 and 16 characters`,
  1144. statusCode: http.StatusBadRequest,
  1145. createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
  1146. assert.Equal(t, state.DisplayScreenName("a"), screenName)
  1147. assert.Equal(t, "thepassword", password)
  1148. return state.ErrAIMHandleLength
  1149. },
  1150. },
  1151. {
  1152. name: "invalid AIM password",
  1153. body: `{"screen_name":"userA", "password":"1"}`,
  1154. want: `invalid password: invalid password length: password length must be between 4-16 characters`,
  1155. statusCode: http.StatusBadRequest,
  1156. createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
  1157. assert.Equal(t, state.DisplayScreenName("userA"), screenName)
  1158. assert.Equal(t, "1", password)
  1159. return fmt.Errorf("%w: password length must be between 4-16 characters", state.ErrPasswordInvalid)
  1160. },
  1161. },
  1162. {
  1163. name: "invalid ICQ UIN",
  1164. body: `{"screen_name":"1000", "password":"thepass"}`,
  1165. want: `invalid uin: uin must be a number in the range 10000-2147483646`,
  1166. statusCode: http.StatusBadRequest,
  1167. createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
  1168. assert.Equal(t, state.DisplayScreenName("1000"), screenName)
  1169. assert.Equal(t, "thepass", password)
  1170. return state.ErrICQUINInvalidFormat
  1171. },
  1172. },
  1173. {
  1174. name: "invalid ICQ password",
  1175. body: `{"screen_name":"100003", "password":"thelongpassword"}`,
  1176. want: `invalid password: invalid password length: password must be between 6-8 characters`,
  1177. statusCode: http.StatusBadRequest,
  1178. createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
  1179. assert.Equal(t, state.DisplayScreenName("100003"), screenName)
  1180. assert.Equal(t, "thelongpassword", password)
  1181. return fmt.Errorf("%w: password must be between 6-8 characters", state.ErrPasswordInvalid)
  1182. },
  1183. },
  1184. }
  1185. for _, tc := range tt {
  1186. t.Run(tc.name, func(t *testing.T) {
  1187. request := httptest.NewRequest(http.MethodPost, "/user", strings.NewReader(tc.body))
  1188. responseRecorder := httptest.NewRecorder()
  1189. postUserHandler(responseRecorder, request, tc.createAccount, slog.Default())
  1190. if responseRecorder.Code != tc.statusCode {
  1191. t.Errorf("want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1192. }
  1193. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1194. t.Errorf("want '%s', got '%s'", tc.want, responseRecorder.Body)
  1195. }
  1196. })
  1197. }
  1198. }
  1199. func TestUserHandler_DELETE(t *testing.T) {
  1200. tt := []struct {
  1201. name string
  1202. body string
  1203. want string
  1204. statusCode int
  1205. mockParams mockParams
  1206. }{
  1207. {
  1208. name: "with valid user",
  1209. body: `{"screen_name":"userA"}`,
  1210. want: `User account successfully deleted.`,
  1211. statusCode: http.StatusNoContent,
  1212. mockParams: mockParams{
  1213. userManagerParams: userManagerParams{
  1214. deleteUserParams: deleteUserParams{
  1215. {
  1216. screenName: state.NewIdentScreenName("userA"),
  1217. },
  1218. },
  1219. },
  1220. },
  1221. },
  1222. {
  1223. name: "with non-existent user",
  1224. body: `{"screen_name":"userA"}`,
  1225. want: `user does not exist`,
  1226. statusCode: http.StatusNotFound,
  1227. mockParams: mockParams{
  1228. userManagerParams: userManagerParams{
  1229. deleteUserParams: deleteUserParams{
  1230. {
  1231. screenName: state.NewIdentScreenName("userA"),
  1232. err: state.ErrNoUser,
  1233. },
  1234. },
  1235. },
  1236. },
  1237. },
  1238. {
  1239. name: "with malformed body",
  1240. body: `{"screen_name":"userA"`, // missing closing }
  1241. want: `malformed input`,
  1242. statusCode: http.StatusBadRequest,
  1243. },
  1244. {
  1245. name: "user handler error",
  1246. body: `{"screen_name":"userA"}`,
  1247. want: `internal server error`,
  1248. statusCode: http.StatusInternalServerError,
  1249. mockParams: mockParams{
  1250. userManagerParams: userManagerParams{
  1251. deleteUserParams: deleteUserParams{
  1252. {
  1253. screenName: state.NewIdentScreenName("userA"),
  1254. err: io.EOF,
  1255. },
  1256. },
  1257. },
  1258. },
  1259. },
  1260. }
  1261. for _, tc := range tt {
  1262. t.Run(tc.name, func(t *testing.T) {
  1263. request := httptest.NewRequest(http.MethodDelete, "/user", strings.NewReader(tc.body))
  1264. responseRecorder := httptest.NewRecorder()
  1265. userManager := newMockUserManager(t)
  1266. for _, params := range tc.mockParams.deleteUserParams {
  1267. userManager.EXPECT().
  1268. DeleteUser(matchContext(), params.screenName).
  1269. Return(params.err)
  1270. }
  1271. deleteUserHandler(responseRecorder, request, userManager, slog.Default())
  1272. if responseRecorder.Code != tc.statusCode {
  1273. t.Errorf("want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1274. }
  1275. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1276. t.Errorf("want '%s', got '%s'", tc.want, responseRecorder.Body)
  1277. }
  1278. })
  1279. }
  1280. }
  1281. func TestUserPasswordHandler_PUT(t *testing.T) {
  1282. tt := []struct {
  1283. name string
  1284. body string
  1285. want string
  1286. statusCode int
  1287. mockParams mockParams
  1288. }{
  1289. {
  1290. name: "user with valid password",
  1291. body: `{"screen_name":"userA", "password":"thenewpassword"}`,
  1292. want: `Password successfully reset.`,
  1293. statusCode: http.StatusNoContent,
  1294. mockParams: mockParams{
  1295. userManagerParams: userManagerParams{
  1296. setUserPasswordParams: setUserPasswordParams{
  1297. {
  1298. screenName: state.NewIdentScreenName("userA"),
  1299. newPassword: "thenewpassword",
  1300. },
  1301. },
  1302. },
  1303. },
  1304. },
  1305. {
  1306. name: "user with invalid password",
  1307. body: `{"screen_name":"userA", "password":"a"}`,
  1308. want: `invalid password length`,
  1309. statusCode: http.StatusBadRequest,
  1310. mockParams: mockParams{
  1311. userManagerParams: userManagerParams{
  1312. setUserPasswordParams: setUserPasswordParams{
  1313. {
  1314. screenName: state.NewIdentScreenName("userA"),
  1315. newPassword: "a",
  1316. err: state.ErrPasswordInvalid,
  1317. },
  1318. },
  1319. },
  1320. },
  1321. },
  1322. {
  1323. name: "with malformed body",
  1324. body: `{"screen_name":"userA", "password":"thepassword"`, // missing closing }
  1325. want: `malformed input`,
  1326. statusCode: http.StatusBadRequest,
  1327. },
  1328. {
  1329. name: "password updater returns runtime error",
  1330. body: `{"screen_name":"userA", "password":"thepassword"}`,
  1331. want: `internal server error`,
  1332. statusCode: http.StatusInternalServerError,
  1333. mockParams: mockParams{
  1334. userManagerParams: userManagerParams{
  1335. setUserPasswordParams: setUserPasswordParams{
  1336. {
  1337. screenName: state.NewIdentScreenName("userA"),
  1338. newPassword: "thepassword",
  1339. err: io.EOF,
  1340. },
  1341. },
  1342. },
  1343. },
  1344. },
  1345. {
  1346. name: "user doesn't exist",
  1347. body: `{"screen_name":"userA", "password":"thepassword"}`,
  1348. want: `user does not exist`,
  1349. statusCode: http.StatusNotFound,
  1350. mockParams: mockParams{
  1351. userManagerParams: userManagerParams{
  1352. setUserPasswordParams: setUserPasswordParams{
  1353. {
  1354. screenName: state.NewIdentScreenName("userA"),
  1355. newPassword: "thepassword",
  1356. err: state.ErrNoUser,
  1357. },
  1358. },
  1359. },
  1360. },
  1361. },
  1362. }
  1363. for _, tc := range tt {
  1364. t.Run(tc.name, func(t *testing.T) {
  1365. request := httptest.NewRequest(http.MethodPut, "/user", strings.NewReader(tc.body))
  1366. responseRecorder := httptest.NewRecorder()
  1367. userManager := newMockUserManager(t)
  1368. for _, params := range tc.mockParams.setUserPasswordParams {
  1369. userManager.EXPECT().
  1370. SetUserPassword(matchContext(), params.screenName, params.newPassword).
  1371. Return(params.err)
  1372. }
  1373. putUserPasswordHandler(responseRecorder, request, userManager, slog.Default())
  1374. if responseRecorder.Code != tc.statusCode {
  1375. t.Errorf("want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1376. }
  1377. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1378. t.Errorf("want '%s', got '%s'", tc.want, responseRecorder.Body)
  1379. }
  1380. })
  1381. }
  1382. }
  1383. func TestPublicChatHandler_GET(t *testing.T) {
  1384. fnNewSess := func(screenName string) *state.Session {
  1385. sess := state.NewSession()
  1386. sess.SetIdentScreenName(state.NewIdentScreenName(screenName))
  1387. sess.SetDisplayScreenName(state.DisplayScreenName(screenName))
  1388. instance := sess.AddInstance()
  1389. instance.SetSignonComplete()
  1390. return sess
  1391. }
  1392. chatRoom1 := state.NewChatRoom("chat-room-1-name", state.NewIdentScreenName("chat-room-1-creator"), state.PublicExchange)
  1393. chatRoom2 := state.NewChatRoom("chat-room-2-name", state.NewIdentScreenName("chat-room-1-creator"), state.PublicExchange)
  1394. tt := []struct {
  1395. name string
  1396. want string
  1397. statusCode int
  1398. mockParams mockParams
  1399. }{
  1400. {
  1401. name: "multiple chat rooms with participants",
  1402. want: `[{"name":"chat-room-1-name","create_time":"0001-01-01T00:00:00Z","url":"aim:gochat?roomname=chat-room-1-name&exchange=5","participants":[{"id":"usera","screen_name":"userA"},{"id":"userb","screen_name":"userB"}]},{"name":"chat-room-2-name","create_time":"0001-01-01T00:00:00Z","url":"aim:gochat?roomname=chat-room-2-name&exchange=5","participants":[{"id":"userc","screen_name":"userC"},{"id":"userd","screen_name":"userD"}]}]`,
  1403. statusCode: http.StatusOK,
  1404. mockParams: mockParams{
  1405. chatRoomRetrieverParams: chatRoomRetrieverParams{
  1406. allChatRoomsParams: allChatRoomsParams{
  1407. {
  1408. exchange: state.PublicExchange,
  1409. result: []state.ChatRoom{
  1410. chatRoom1,
  1411. chatRoom2,
  1412. },
  1413. },
  1414. },
  1415. },
  1416. chatSessionRetrieverParams: chatSessionRetrieverParams{
  1417. chatSessionRetrieverAllSessionsParams: chatSessionRetrieverAllSessionsParams{
  1418. {
  1419. cookie: chatRoom1.Cookie(),
  1420. result: []*state.Session{
  1421. fnNewSess("userA"),
  1422. fnNewSess("userB"),
  1423. },
  1424. },
  1425. {
  1426. cookie: chatRoom2.Cookie(),
  1427. result: []*state.Session{
  1428. fnNewSess("userC"),
  1429. fnNewSess("userD"),
  1430. },
  1431. },
  1432. },
  1433. },
  1434. },
  1435. },
  1436. {
  1437. name: "chat room without participants",
  1438. want: `[{"name":"chat-room-1-name","create_time":"0001-01-01T00:00:00Z","url":"aim:gochat?roomname=chat-room-1-name&exchange=5","participants":[]}]`,
  1439. statusCode: http.StatusOK,
  1440. mockParams: mockParams{
  1441. chatRoomRetrieverParams: chatRoomRetrieverParams{
  1442. allChatRoomsParams: allChatRoomsParams{
  1443. {
  1444. exchange: state.PublicExchange,
  1445. result: []state.ChatRoom{
  1446. chatRoom1,
  1447. },
  1448. },
  1449. },
  1450. },
  1451. chatSessionRetrieverParams: chatSessionRetrieverParams{
  1452. chatSessionRetrieverAllSessionsParams: chatSessionRetrieverAllSessionsParams{
  1453. {
  1454. cookie: chatRoom1.Cookie(),
  1455. result: []*state.Session{},
  1456. },
  1457. },
  1458. },
  1459. },
  1460. },
  1461. {
  1462. name: "no chat rooms",
  1463. want: `[]`,
  1464. statusCode: http.StatusOK,
  1465. mockParams: mockParams{
  1466. chatRoomRetrieverParams: chatRoomRetrieverParams{
  1467. allChatRoomsParams: allChatRoomsParams{
  1468. {
  1469. exchange: state.PublicExchange,
  1470. result: []state.ChatRoom{},
  1471. },
  1472. },
  1473. },
  1474. },
  1475. },
  1476. }
  1477. for _, tc := range tt {
  1478. t.Run(tc.name, func(t *testing.T) {
  1479. request := httptest.NewRequest(http.MethodGet, "/chat/room/public", nil)
  1480. responseRecorder := httptest.NewRecorder()
  1481. chatRoomRetriever := newMockChatRoomRetriever(t)
  1482. for _, params := range tc.mockParams.allChatRoomsParams {
  1483. chatRoomRetriever.EXPECT().
  1484. AllChatRooms(matchContext(), params.exchange).
  1485. Return(params.result, params.err)
  1486. }
  1487. chatSessionRetriever := newMockChatSessionRetriever(t)
  1488. for _, params := range tc.mockParams.chatSessionRetrieverAllSessionsParams {
  1489. chatSessionRetriever.EXPECT().
  1490. AllSessions(params.cookie).
  1491. Return(params.result)
  1492. }
  1493. getPublicChatHandler(responseRecorder, request, chatRoomRetriever, chatSessionRetriever, slog.Default())
  1494. if responseRecorder.Code != tc.statusCode {
  1495. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1496. }
  1497. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1498. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  1499. }
  1500. })
  1501. }
  1502. }
  1503. func TestDeletePublicChatHandler(t *testing.T) {
  1504. tt := []struct {
  1505. name string
  1506. body string
  1507. want string
  1508. statusCode int
  1509. mockParams mockParams
  1510. }{
  1511. {
  1512. name: "successful deletion of single chat room",
  1513. body: `{"names":["TestRoom"]}`,
  1514. want: `Chat rooms deleted successfully.`,
  1515. statusCode: http.StatusNoContent,
  1516. mockParams: mockParams{
  1517. chatRoomDeleterParams: chatRoomDeleterParams{
  1518. deleteChatRoomsParams: deleteChatRoomsParams{
  1519. {
  1520. exchange: state.PublicExchange,
  1521. names: []string{"TestRoom"},
  1522. },
  1523. },
  1524. },
  1525. },
  1526. },
  1527. {
  1528. name: "successful deletion of multiple chat rooms",
  1529. body: `{"names":["Room1", "Room2", "Room3"]}`,
  1530. want: `Chat rooms deleted successfully.`,
  1531. statusCode: http.StatusNoContent,
  1532. mockParams: mockParams{
  1533. chatRoomDeleterParams: chatRoomDeleterParams{
  1534. deleteChatRoomsParams: deleteChatRoomsParams{
  1535. {
  1536. exchange: state.PublicExchange,
  1537. names: []string{"Room1", "Room2", "Room3"},
  1538. },
  1539. },
  1540. },
  1541. },
  1542. },
  1543. {
  1544. name: "empty names array",
  1545. body: `{"names":[]}`,
  1546. want: `no chat room names provided`,
  1547. statusCode: http.StatusBadRequest,
  1548. },
  1549. {
  1550. name: "malformed JSON",
  1551. body: `{"names":["Room1"`, // missing closing brackets
  1552. want: `malformed input`,
  1553. statusCode: http.StatusBadRequest,
  1554. },
  1555. {
  1556. name: "deletion error",
  1557. body: `{"names":["TestRoom"]}`,
  1558. want: `internal server error`,
  1559. statusCode: http.StatusInternalServerError,
  1560. mockParams: mockParams{
  1561. chatRoomDeleterParams: chatRoomDeleterParams{
  1562. deleteChatRoomsParams: deleteChatRoomsParams{
  1563. {
  1564. exchange: state.PublicExchange,
  1565. names: []string{"TestRoom"},
  1566. err: errors.New("database error"),
  1567. },
  1568. },
  1569. },
  1570. },
  1571. },
  1572. }
  1573. for _, tc := range tt {
  1574. t.Run(tc.name, func(t *testing.T) {
  1575. request := httptest.NewRequest(http.MethodDelete, "/chat/room/public", strings.NewReader(tc.body))
  1576. responseRecorder := httptest.NewRecorder()
  1577. chatRoomDeleter := newMockChatRoomDeleter(t)
  1578. for _, params := range tc.mockParams.deleteChatRoomsParams {
  1579. chatRoomDeleter.EXPECT().
  1580. DeleteChatRooms(matchContext(), params.exchange, params.names).
  1581. Return(params.err)
  1582. }
  1583. deletePublicChatHandler(responseRecorder, request, chatRoomDeleter, slog.Default())
  1584. if responseRecorder.Code != tc.statusCode {
  1585. t.Errorf("want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1586. }
  1587. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1588. t.Errorf("want '%s', got '%s'", tc.want, responseRecorder.Body)
  1589. }
  1590. })
  1591. }
  1592. }
  1593. func TestPrivateChatHandler_GET(t *testing.T) {
  1594. fnNewSess := func(screenName string) *state.Session {
  1595. sess := state.NewSession()
  1596. sess.SetIdentScreenName(state.NewIdentScreenName(screenName))
  1597. sess.SetDisplayScreenName(state.DisplayScreenName(screenName))
  1598. instance := sess.AddInstance()
  1599. instance.SetSignonComplete()
  1600. return sess
  1601. }
  1602. chatRoom1 := state.NewChatRoom("chat-room-1-name", state.NewIdentScreenName("chat-room-1-creator"), state.PrivateExchange)
  1603. chatRoom2 := state.NewChatRoom("chat-room-2-name", state.NewIdentScreenName("chat-room-2-creator"), state.PrivateExchange)
  1604. tt := []struct {
  1605. name string
  1606. want string
  1607. statusCode int
  1608. mockParams mockParams
  1609. }{
  1610. {
  1611. name: "multiple chat rooms with participants",
  1612. want: `[{"name":"chat-room-1-name","create_time":"0001-01-01T00:00:00Z","creator_id":"chat-room-1-creator","url":"aim:gochat?roomname=chat-room-1-name&exchange=4","participants":[{"id":"usera","screen_name":"userA"},{"id":"userb","screen_name":"userB"}]},{"name":"chat-room-2-name","create_time":"0001-01-01T00:00:00Z","creator_id":"chat-room-2-creator","url":"aim:gochat?roomname=chat-room-2-name&exchange=4","participants":[{"id":"userc","screen_name":"userC"},{"id":"userd","screen_name":"userD"}]}]`,
  1613. statusCode: http.StatusOK,
  1614. mockParams: mockParams{
  1615. chatRoomRetrieverParams: chatRoomRetrieverParams{
  1616. allChatRoomsParams: allChatRoomsParams{
  1617. {
  1618. exchange: state.PrivateExchange,
  1619. result: []state.ChatRoom{
  1620. chatRoom1,
  1621. chatRoom2,
  1622. },
  1623. },
  1624. },
  1625. },
  1626. chatSessionRetrieverParams: chatSessionRetrieverParams{
  1627. chatSessionRetrieverAllSessionsParams: chatSessionRetrieverAllSessionsParams{
  1628. {
  1629. cookie: chatRoom1.Cookie(),
  1630. result: []*state.Session{
  1631. fnNewSess("userA"),
  1632. fnNewSess("userB"),
  1633. },
  1634. },
  1635. {
  1636. cookie: chatRoom2.Cookie(),
  1637. result: []*state.Session{
  1638. fnNewSess("userC"),
  1639. fnNewSess("userD"),
  1640. },
  1641. },
  1642. },
  1643. },
  1644. },
  1645. },
  1646. {
  1647. name: "chat room without participants",
  1648. want: `[{"name":"chat-room-1-name","create_time":"0001-01-01T00:00:00Z","creator_id":"chat-room-1-creator","url":"aim:gochat?roomname=chat-room-1-name&exchange=4","participants":[]}]`,
  1649. statusCode: http.StatusOK,
  1650. mockParams: mockParams{
  1651. chatRoomRetrieverParams: chatRoomRetrieverParams{
  1652. allChatRoomsParams: allChatRoomsParams{
  1653. {
  1654. exchange: state.PrivateExchange,
  1655. result: []state.ChatRoom{
  1656. chatRoom1,
  1657. },
  1658. },
  1659. },
  1660. },
  1661. chatSessionRetrieverParams: chatSessionRetrieverParams{
  1662. chatSessionRetrieverAllSessionsParams: chatSessionRetrieverAllSessionsParams{
  1663. {
  1664. cookie: chatRoom1.Cookie(),
  1665. result: []*state.Session{},
  1666. },
  1667. },
  1668. },
  1669. },
  1670. },
  1671. {
  1672. name: "no chat rooms",
  1673. want: `[]`,
  1674. statusCode: http.StatusOK,
  1675. mockParams: mockParams{
  1676. chatRoomRetrieverParams: chatRoomRetrieverParams{
  1677. allChatRoomsParams: allChatRoomsParams{
  1678. {
  1679. exchange: state.PrivateExchange,
  1680. result: []state.ChatRoom{},
  1681. },
  1682. },
  1683. },
  1684. },
  1685. },
  1686. }
  1687. for _, tc := range tt {
  1688. t.Run(tc.name, func(t *testing.T) {
  1689. request := httptest.NewRequest(http.MethodGet, "/chat/room/private", nil)
  1690. responseRecorder := httptest.NewRecorder()
  1691. chatRoomRetriever := newMockChatRoomRetriever(t)
  1692. for _, params := range tc.mockParams.allChatRoomsParams {
  1693. chatRoomRetriever.EXPECT().
  1694. AllChatRooms(matchContext(), params.exchange).
  1695. Return(params.result, params.err)
  1696. }
  1697. chatSessionRetriever := newMockChatSessionRetriever(t)
  1698. for _, params := range tc.mockParams.chatSessionRetrieverAllSessionsParams {
  1699. chatSessionRetriever.EXPECT().
  1700. AllSessions(params.cookie).
  1701. Return(params.result)
  1702. }
  1703. getPrivateChatHandler(responseRecorder, request, chatRoomRetriever, chatSessionRetriever, slog.Default())
  1704. if responseRecorder.Code != tc.statusCode {
  1705. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1706. }
  1707. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1708. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  1709. }
  1710. })
  1711. }
  1712. }
  1713. func TestInstantMessageHandler_POST(t *testing.T) {
  1714. type relayToScreenNameInputs struct {
  1715. sender state.IdentScreenName
  1716. recipient state.IdentScreenName
  1717. msg string
  1718. }
  1719. tt := []struct {
  1720. name string
  1721. relayToScreenNameInputs []relayToScreenNameInputs
  1722. body string
  1723. want string
  1724. statusCode int
  1725. }{
  1726. {
  1727. name: "send an instant message",
  1728. relayToScreenNameInputs: []relayToScreenNameInputs{
  1729. {
  1730. sender: state.NewIdentScreenName("sender_sn"),
  1731. recipient: state.NewIdentScreenName("recip_sn"),
  1732. msg: "hello world!",
  1733. },
  1734. },
  1735. body: `{"from":"sender_sn","to":"recip_sn","text":"hello world!"}`,
  1736. want: `Message sent successfully.`,
  1737. statusCode: http.StatusOK,
  1738. },
  1739. {
  1740. name: "with malformed body",
  1741. body: `{"screen_name":"userA", "password":"thepassword"`,
  1742. want: `malformed input`,
  1743. statusCode: http.StatusBadRequest,
  1744. },
  1745. }
  1746. for _, tc := range tt {
  1747. t.Run(tc.name, func(t *testing.T) {
  1748. request := httptest.NewRequest(http.MethodPost, "/user", strings.NewReader(tc.body))
  1749. responseRecorder := httptest.NewRecorder()
  1750. messageRelayer := newMockMessageRelayer(t)
  1751. for _, params := range tc.relayToScreenNameInputs {
  1752. validateSNAC := func(msg wire.SNACMessage) bool {
  1753. body := msg.Body.(wire.SNAC_0x04_0x07_ICBMChannelMsgToClient)
  1754. assert.Equal(t, params.sender.String(), body.ScreenName)
  1755. b, ok := body.Bytes(wire.ICBMTLVAOLIMData)
  1756. assert.True(t, ok)
  1757. txt, err := wire.UnmarshalICBMMessageText(b)
  1758. assert.NoError(t, err)
  1759. assert.Equal(t, params.msg, txt)
  1760. return true
  1761. }
  1762. messageRelayer.EXPECT().
  1763. RelayToScreenName(mock.Anything, params.recipient, mock.MatchedBy(validateSNAC))
  1764. }
  1765. postInstantMessageHandler(responseRecorder, request, messageRelayer, slog.Default())
  1766. if responseRecorder.Code != tc.statusCode {
  1767. t.Errorf("want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1768. }
  1769. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1770. t.Errorf("want '%s', got '%s'", tc.want, responseRecorder.Body)
  1771. }
  1772. })
  1773. }
  1774. }
  1775. func TestVersionHandler_GET(t *testing.T) {
  1776. tt := []struct {
  1777. name string
  1778. want string
  1779. statusCode int
  1780. buildInfo config.Build
  1781. }{
  1782. {
  1783. name: "get ras version",
  1784. want: `{"version":"13.3.7","commit":"asdfASDF12345678","date":"2024-03-01"}`,
  1785. statusCode: http.StatusOK,
  1786. buildInfo: config.Build{
  1787. Version: "13.3.7",
  1788. Commit: "asdfASDF12345678",
  1789. Date: "2024-03-01",
  1790. },
  1791. },
  1792. }
  1793. for _, tc := range tt {
  1794. t.Run(tc.name, func(t *testing.T) {
  1795. responseRecorder := httptest.NewRecorder()
  1796. getVersionHandler(responseRecorder, tc.buildInfo)
  1797. if responseRecorder.Code != tc.statusCode {
  1798. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1799. }
  1800. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1801. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  1802. }
  1803. })
  1804. }
  1805. }
  1806. func TestDirectoryCategoryHandler_GET(t *testing.T) {
  1807. tt := []struct {
  1808. name string
  1809. want string
  1810. statusCode int
  1811. mockParams mockParams
  1812. }{
  1813. {
  1814. name: "no categories",
  1815. want: `[]`,
  1816. statusCode: http.StatusOK,
  1817. mockParams: mockParams{
  1818. directoryManagerParams: directoryManagerParams{
  1819. categoriesParams: categoriesParams{
  1820. {
  1821. result: nil,
  1822. },
  1823. },
  1824. },
  1825. },
  1826. },
  1827. {
  1828. name: "error fetching categories",
  1829. want: `{"message":"internal server error"}`,
  1830. statusCode: http.StatusInternalServerError,
  1831. mockParams: mockParams{
  1832. directoryManagerParams: directoryManagerParams{
  1833. categoriesParams: categoriesParams{
  1834. {
  1835. result: nil,
  1836. err: errors.New("error fetching categories"),
  1837. },
  1838. },
  1839. },
  1840. },
  1841. },
  1842. {
  1843. name: "fetch some categories",
  1844. want: `[{"id":1,"name":"category-1"},{"id":2,"name":"category-2"}]`,
  1845. statusCode: http.StatusOK,
  1846. mockParams: mockParams{
  1847. directoryManagerParams: directoryManagerParams{
  1848. categoriesParams: categoriesParams{
  1849. {
  1850. result: []state.Category{
  1851. {
  1852. ID: 1,
  1853. Name: "category-1",
  1854. },
  1855. {
  1856. ID: 2,
  1857. Name: "category-2",
  1858. },
  1859. },
  1860. },
  1861. },
  1862. },
  1863. },
  1864. },
  1865. }
  1866. for _, tc := range tt {
  1867. t.Run(tc.name, func(t *testing.T) {
  1868. responseRecorder := httptest.NewRecorder()
  1869. request := httptest.NewRequest(http.MethodGet, "/directory/category", nil)
  1870. directoryManager := newMockDirectoryManager(t)
  1871. for _, params := range tc.mockParams.categoriesParams {
  1872. directoryManager.EXPECT().
  1873. Categories(matchContext()).
  1874. Return(params.result, params.err)
  1875. }
  1876. getDirectoryCategoryHandler(responseRecorder, request, directoryManager, slog.Default())
  1877. if responseRecorder.Code != tc.statusCode {
  1878. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1879. }
  1880. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1881. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  1882. }
  1883. })
  1884. }
  1885. }
  1886. func TestDirectoryCategoryKeywordHandler_GET(t *testing.T) {
  1887. tt := []struct {
  1888. name string
  1889. categoryID int
  1890. want string
  1891. statusCode int
  1892. mockParams mockParams
  1893. }{
  1894. {
  1895. name: "category not found",
  1896. categoryID: 1,
  1897. want: `{"message":"category not found"}`,
  1898. statusCode: http.StatusNotFound,
  1899. mockParams: mockParams{
  1900. directoryManagerParams: directoryManagerParams{
  1901. keywordsByCategoryParams: keywordsByCategoryParams{
  1902. {
  1903. categoryID: 1,
  1904. result: nil,
  1905. err: state.ErrKeywordCategoryNotFound,
  1906. },
  1907. },
  1908. },
  1909. },
  1910. },
  1911. {
  1912. name: "error fetching keywords by category",
  1913. categoryID: 1,
  1914. want: `{"message":"internal server error"}`,
  1915. statusCode: http.StatusInternalServerError,
  1916. mockParams: mockParams{
  1917. directoryManagerParams: directoryManagerParams{
  1918. keywordsByCategoryParams: keywordsByCategoryParams{
  1919. {
  1920. categoryID: 1,
  1921. result: nil,
  1922. err: errors.New("error fetching keywords by category"),
  1923. },
  1924. },
  1925. },
  1926. },
  1927. },
  1928. {
  1929. name: "invalid category ID",
  1930. categoryID: -1,
  1931. want: `{"message":"invalid category ID"}`,
  1932. statusCode: http.StatusBadRequest,
  1933. mockParams: mockParams{
  1934. directoryManagerParams: directoryManagerParams{
  1935. keywordsByCategoryParams: keywordsByCategoryParams{},
  1936. },
  1937. },
  1938. },
  1939. {
  1940. name: "no keywords",
  1941. categoryID: 1,
  1942. want: `[]`,
  1943. statusCode: http.StatusOK,
  1944. mockParams: mockParams{
  1945. directoryManagerParams: directoryManagerParams{
  1946. keywordsByCategoryParams: keywordsByCategoryParams{
  1947. {
  1948. categoryID: 1,
  1949. result: nil,
  1950. },
  1951. },
  1952. },
  1953. },
  1954. },
  1955. {
  1956. name: "fetch some keywords by category",
  1957. categoryID: 1,
  1958. want: `[{"id":1,"name":"keyword-1"},{"id":2,"name":"keyword-2"}]`,
  1959. statusCode: http.StatusOK,
  1960. mockParams: mockParams{
  1961. directoryManagerParams: directoryManagerParams{
  1962. keywordsByCategoryParams: keywordsByCategoryParams{
  1963. {
  1964. categoryID: 1,
  1965. result: []state.Keyword{
  1966. {
  1967. ID: 1,
  1968. Name: "keyword-1",
  1969. },
  1970. {
  1971. ID: 2,
  1972. Name: "keyword-2",
  1973. },
  1974. },
  1975. },
  1976. },
  1977. },
  1978. },
  1979. },
  1980. }
  1981. for _, tc := range tt {
  1982. t.Run(tc.name, func(t *testing.T) {
  1983. request := httptest.NewRequest(http.MethodGet, fmt.Sprintf("/directory/category/%d/keyword", tc.categoryID), nil)
  1984. request.SetPathValue("id", fmt.Sprintf("%d", tc.categoryID))
  1985. responseRecorder := httptest.NewRecorder()
  1986. directoryManager := newMockDirectoryManager(t)
  1987. for _, params := range tc.mockParams.keywordsByCategoryParams {
  1988. directoryManager.EXPECT().
  1989. KeywordsByCategory(matchContext(), params.categoryID).
  1990. Return(params.result, params.err)
  1991. }
  1992. getDirectoryCategoryKeywordHandler(responseRecorder, request, directoryManager, slog.Default())
  1993. if responseRecorder.Code != tc.statusCode {
  1994. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1995. }
  1996. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1997. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  1998. }
  1999. })
  2000. }
  2001. }
  2002. func TestDirectoryCategoryHandler_DELETE(t *testing.T) {
  2003. tt := []struct {
  2004. name string
  2005. categoryID int
  2006. want string
  2007. statusCode int
  2008. mockParams mockParams
  2009. }{
  2010. {
  2011. name: "category not found",
  2012. categoryID: 1,
  2013. want: `{"message":"category not found"}`,
  2014. statusCode: http.StatusNotFound,
  2015. mockParams: mockParams{
  2016. directoryManagerParams: directoryManagerParams{
  2017. deleteCategoryParams: deleteCategoryParams{
  2018. {
  2019. categoryID: 1,
  2020. err: state.ErrKeywordCategoryNotFound,
  2021. },
  2022. },
  2023. },
  2024. },
  2025. },
  2026. {
  2027. name: "keyword in use by user",
  2028. categoryID: 1,
  2029. want: `{"message":"can't delete because category in use by a user"}`,
  2030. statusCode: http.StatusConflict,
  2031. mockParams: mockParams{
  2032. directoryManagerParams: directoryManagerParams{
  2033. deleteCategoryParams: deleteCategoryParams{
  2034. {
  2035. categoryID: 1,
  2036. err: state.ErrKeywordInUse,
  2037. },
  2038. },
  2039. },
  2040. },
  2041. },
  2042. {
  2043. name: "runtime error",
  2044. categoryID: 1,
  2045. want: `{"message":"internal server error"}`,
  2046. statusCode: http.StatusInternalServerError,
  2047. mockParams: mockParams{
  2048. directoryManagerParams: directoryManagerParams{
  2049. deleteCategoryParams: deleteCategoryParams{
  2050. {
  2051. categoryID: 1,
  2052. err: errors.New("error deleting keyword"),
  2053. },
  2054. },
  2055. },
  2056. },
  2057. },
  2058. {
  2059. name: "successful deletion",
  2060. categoryID: 1,
  2061. want: ``,
  2062. statusCode: http.StatusNoContent,
  2063. mockParams: mockParams{
  2064. directoryManagerParams: directoryManagerParams{
  2065. deleteCategoryParams: deleteCategoryParams{
  2066. {
  2067. categoryID: 1,
  2068. },
  2069. },
  2070. },
  2071. },
  2072. },
  2073. {
  2074. name: "invalid category ID",
  2075. categoryID: -1,
  2076. want: `invalid category ID`,
  2077. statusCode: http.StatusBadRequest,
  2078. mockParams: mockParams{
  2079. directoryManagerParams: directoryManagerParams{
  2080. deleteCategoryParams: deleteCategoryParams{},
  2081. },
  2082. },
  2083. },
  2084. }
  2085. for _, tc := range tt {
  2086. t.Run(tc.name, func(t *testing.T) {
  2087. request := httptest.NewRequest(http.MethodDelete, fmt.Sprintf("/directory/category/%d/keyword", tc.categoryID), nil)
  2088. request.SetPathValue("id", fmt.Sprintf("%d", tc.categoryID))
  2089. responseRecorder := httptest.NewRecorder()
  2090. directoryManager := newMockDirectoryManager(t)
  2091. for _, params := range tc.mockParams.deleteCategoryParams {
  2092. directoryManager.EXPECT().
  2093. DeleteCategory(matchContext(), params.categoryID).
  2094. Return(params.err)
  2095. }
  2096. deleteDirectoryCategoryHandler(responseRecorder, request, directoryManager, slog.Default())
  2097. if responseRecorder.Code != tc.statusCode {
  2098. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  2099. }
  2100. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  2101. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  2102. }
  2103. })
  2104. }
  2105. }
  2106. func TestDirectoryCategoryHandler_POST(t *testing.T) {
  2107. tt := []struct {
  2108. name string
  2109. body string
  2110. want string
  2111. statusCode int
  2112. mockParams mockParams
  2113. }{
  2114. {
  2115. name: "category already exists",
  2116. body: `{"name":"the_category"}`,
  2117. want: `{"message":"category already exists"}`,
  2118. statusCode: http.StatusConflict,
  2119. mockParams: mockParams{
  2120. directoryManagerParams: directoryManagerParams{
  2121. createCategoryParams: createCategoryParams{
  2122. {
  2123. name: "the_category",
  2124. err: state.ErrKeywordCategoryExists,
  2125. },
  2126. },
  2127. },
  2128. },
  2129. },
  2130. {
  2131. name: "runtime error",
  2132. body: `{"name":"the_category"}`,
  2133. want: `{"message":"internal server error"}`,
  2134. statusCode: http.StatusInternalServerError,
  2135. mockParams: mockParams{
  2136. directoryManagerParams: directoryManagerParams{
  2137. createCategoryParams: createCategoryParams{
  2138. {
  2139. name: "the_category",
  2140. err: errors.New("error creating category"),
  2141. },
  2142. },
  2143. },
  2144. },
  2145. },
  2146. {
  2147. name: "bad input",
  2148. body: `{"name":"the_category"`,
  2149. want: `{"message":"malformed input"}`,
  2150. statusCode: http.StatusBadRequest,
  2151. mockParams: mockParams{
  2152. directoryManagerParams: directoryManagerParams{
  2153. createCategoryParams: createCategoryParams{},
  2154. },
  2155. },
  2156. },
  2157. {
  2158. name: "successful creation",
  2159. body: `{"name":"the_category"}`,
  2160. want: `{"id":1,"name":"the_category"}`,
  2161. statusCode: http.StatusCreated,
  2162. mockParams: mockParams{
  2163. directoryManagerParams: directoryManagerParams{
  2164. createCategoryParams: createCategoryParams{
  2165. {
  2166. name: "the_category",
  2167. result: state.Category{
  2168. ID: 1,
  2169. Name: "the_category",
  2170. },
  2171. },
  2172. },
  2173. },
  2174. },
  2175. },
  2176. }
  2177. for _, tc := range tt {
  2178. t.Run(tc.name, func(t *testing.T) {
  2179. request := httptest.NewRequest(http.MethodPost, "/directory/category", strings.NewReader(tc.body))
  2180. responseRecorder := httptest.NewRecorder()
  2181. directoryManager := newMockDirectoryManager(t)
  2182. for _, params := range tc.mockParams.createCategoryParams {
  2183. directoryManager.EXPECT().
  2184. CreateCategory(matchContext(), params.name).
  2185. Return(params.result, params.err)
  2186. }
  2187. postDirectoryCategoryHandler(responseRecorder, request, directoryManager, slog.Default())
  2188. if responseRecorder.Code != tc.statusCode {
  2189. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  2190. }
  2191. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  2192. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  2193. }
  2194. })
  2195. }
  2196. }
  2197. func TestDirectoryKeywordHandler_POST(t *testing.T) {
  2198. tt := []struct {
  2199. name string
  2200. body string
  2201. want string
  2202. statusCode int
  2203. mockParams mockParams
  2204. }{
  2205. {
  2206. name: "keyword already exists",
  2207. body: `{"category_id":1,"name":"the_keyword"}`,
  2208. want: `{"message":"keyword already exists"}`,
  2209. statusCode: http.StatusConflict,
  2210. mockParams: mockParams{
  2211. directoryManagerParams: directoryManagerParams{
  2212. createKeywordParams: createKeywordParams{
  2213. {
  2214. name: "the_keyword",
  2215. categoryID: 1,
  2216. err: state.ErrKeywordExists,
  2217. },
  2218. },
  2219. },
  2220. },
  2221. },
  2222. {
  2223. name: "category not found",
  2224. body: `{"category_id":1,"name":"the_keyword"}`,
  2225. want: `{"message":"category not found"}`,
  2226. statusCode: http.StatusNotFound,
  2227. mockParams: mockParams{
  2228. directoryManagerParams: directoryManagerParams{
  2229. createKeywordParams: createKeywordParams{
  2230. {
  2231. name: "the_keyword",
  2232. categoryID: 1,
  2233. err: state.ErrKeywordCategoryNotFound,
  2234. },
  2235. },
  2236. },
  2237. },
  2238. },
  2239. {
  2240. name: "runtime error",
  2241. body: `{"category_id":1,"name":"the_keyword"}`,
  2242. want: `{"message":"internal server error"}`,
  2243. statusCode: http.StatusInternalServerError,
  2244. mockParams: mockParams{
  2245. directoryManagerParams: directoryManagerParams{
  2246. createKeywordParams: createKeywordParams{
  2247. {
  2248. name: "the_keyword",
  2249. categoryID: 1,
  2250. err: errors.New("error creating keyword"),
  2251. },
  2252. },
  2253. },
  2254. },
  2255. },
  2256. {
  2257. name: "bad input",
  2258. body: `{"category_id":1,"name":"the_keyword"`,
  2259. want: `{"message":"malformed input"}`,
  2260. statusCode: http.StatusBadRequest,
  2261. mockParams: mockParams{
  2262. directoryManagerParams: directoryManagerParams{
  2263. createKeywordParams: createKeywordParams{},
  2264. },
  2265. },
  2266. },
  2267. {
  2268. name: "successful creation",
  2269. body: `{"category_id":1,"name":"the_keyword"}`,
  2270. want: `{"id":1,"name":"the_keyword"}`,
  2271. statusCode: http.StatusCreated,
  2272. mockParams: mockParams{
  2273. directoryManagerParams: directoryManagerParams{
  2274. createKeywordParams: createKeywordParams{
  2275. {
  2276. name: "the_keyword",
  2277. categoryID: 1,
  2278. result: state.Keyword{
  2279. ID: 1,
  2280. Name: "the_keyword",
  2281. },
  2282. },
  2283. },
  2284. },
  2285. },
  2286. },
  2287. }
  2288. for _, tc := range tt {
  2289. t.Run(tc.name, func(t *testing.T) {
  2290. request := httptest.NewRequest(http.MethodPost, "/directory/keyword", strings.NewReader(tc.body))
  2291. responseRecorder := httptest.NewRecorder()
  2292. directoryManager := newMockDirectoryManager(t)
  2293. for _, params := range tc.mockParams.createKeywordParams {
  2294. directoryManager.EXPECT().
  2295. CreateKeyword(matchContext(), params.name, params.categoryID).
  2296. Return(params.result, params.err)
  2297. }
  2298. postDirectoryKeywordHandler(responseRecorder, request, directoryManager, slog.Default())
  2299. if responseRecorder.Code != tc.statusCode {
  2300. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  2301. }
  2302. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  2303. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  2304. }
  2305. })
  2306. }
  2307. }
  2308. func TestDirectoryKeywordHandler_DELETE(t *testing.T) {
  2309. tt := []struct {
  2310. name string
  2311. categoryID int
  2312. want string
  2313. statusCode int
  2314. mockParams mockParams
  2315. }{
  2316. {
  2317. name: "keyword not found",
  2318. categoryID: 1,
  2319. want: `{"message":"keyword not found"}`,
  2320. statusCode: http.StatusNotFound,
  2321. mockParams: mockParams{
  2322. directoryManagerParams: directoryManagerParams{
  2323. deleteKeywordParams: deleteKeywordParams{
  2324. {
  2325. id: 1,
  2326. err: state.ErrKeywordNotFound,
  2327. },
  2328. },
  2329. },
  2330. },
  2331. },
  2332. {
  2333. name: "keyword in use by user",
  2334. categoryID: 1,
  2335. want: `{"message":"can't delete because category in use by a user"}`,
  2336. statusCode: http.StatusConflict,
  2337. mockParams: mockParams{
  2338. directoryManagerParams: directoryManagerParams{
  2339. deleteKeywordParams: deleteKeywordParams{
  2340. {
  2341. id: 1,
  2342. err: state.ErrKeywordInUse,
  2343. },
  2344. },
  2345. },
  2346. },
  2347. },
  2348. {
  2349. name: "runtime error",
  2350. categoryID: 1,
  2351. want: `{"message":"internal server error"}`,
  2352. statusCode: http.StatusInternalServerError,
  2353. mockParams: mockParams{
  2354. directoryManagerParams: directoryManagerParams{
  2355. deleteKeywordParams: deleteKeywordParams{
  2356. {
  2357. id: 1,
  2358. err: errors.New("error deleting keyword"),
  2359. },
  2360. },
  2361. },
  2362. },
  2363. },
  2364. {
  2365. name: "successful deletion",
  2366. categoryID: 1,
  2367. want: ``,
  2368. statusCode: http.StatusNoContent,
  2369. mockParams: mockParams{
  2370. directoryManagerParams: directoryManagerParams{
  2371. deleteKeywordParams: deleteKeywordParams{
  2372. {
  2373. id: 1,
  2374. },
  2375. },
  2376. },
  2377. },
  2378. },
  2379. {
  2380. name: "invalid keyword ID",
  2381. categoryID: -1,
  2382. want: `{"message":"invalid keyword ID"}`,
  2383. statusCode: http.StatusBadRequest,
  2384. mockParams: mockParams{
  2385. directoryManagerParams: directoryManagerParams{
  2386. deleteKeywordParams: deleteKeywordParams{},
  2387. },
  2388. },
  2389. },
  2390. }
  2391. for _, tc := range tt {
  2392. t.Run(tc.name, func(t *testing.T) {
  2393. request := httptest.NewRequest(http.MethodDelete, fmt.Sprintf("/directory/keyword/%d", tc.categoryID), nil)
  2394. request.SetPathValue("id", fmt.Sprintf("%d", tc.categoryID))
  2395. responseRecorder := httptest.NewRecorder()
  2396. directoryManager := newMockDirectoryManager(t)
  2397. for _, params := range tc.mockParams.deleteKeywordParams {
  2398. directoryManager.EXPECT().
  2399. DeleteKeyword(matchContext(), params.id).
  2400. Return(params.err)
  2401. }
  2402. deleteDirectoryKeywordHandler(responseRecorder, request, directoryManager, slog.Default())
  2403. if responseRecorder.Code != tc.statusCode {
  2404. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  2405. }
  2406. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  2407. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  2408. }
  2409. })
  2410. }
  2411. }
  2412. func TestBARTByTypeHandler_GET(t *testing.T) {
  2413. tt := []struct {
  2414. name string
  2415. queryParams string
  2416. wantStatusCode int
  2417. wantResponse string
  2418. mockParams mockParams
  2419. }{
  2420. {
  2421. name: "success with items",
  2422. queryParams: "?type=1",
  2423. wantStatusCode: http.StatusOK,
  2424. wantResponse: `[{"hash":"2B000001E4","type":1},{"hash":"2B000001B7","type":1}]`,
  2425. mockParams: mockParams{
  2426. bartAssetManagerParams: bartAssetManagerParams{
  2427. listBARTItemsParams: listBARTItemsParams{
  2428. {
  2429. itemType: 1,
  2430. result: []state.BARTItem{
  2431. {Hash: "2B000001E4", Type: 1},
  2432. {Hash: "2B000001B7", Type: 1},
  2433. },
  2434. err: nil,
  2435. },
  2436. },
  2437. },
  2438. },
  2439. },
  2440. {
  2441. name: "success with empty list",
  2442. queryParams: "?type=2",
  2443. wantStatusCode: http.StatusOK,
  2444. wantResponse: `[]`,
  2445. mockParams: mockParams{
  2446. bartAssetManagerParams: bartAssetManagerParams{
  2447. listBARTItemsParams: listBARTItemsParams{
  2448. {
  2449. itemType: 2,
  2450. result: []state.BARTItem{},
  2451. err: nil,
  2452. },
  2453. },
  2454. },
  2455. },
  2456. },
  2457. {
  2458. name: "missing type parameter",
  2459. queryParams: "",
  2460. wantStatusCode: http.StatusBadRequest,
  2461. wantResponse: `{"message":"type query parameter is required"}`,
  2462. },
  2463. {
  2464. name: "invalid type parameter",
  2465. queryParams: "?type=invalid",
  2466. wantStatusCode: http.StatusBadRequest,
  2467. wantResponse: `{"message":"invalid type ID"}`,
  2468. },
  2469. {
  2470. name: "internal server error",
  2471. queryParams: "?type=1",
  2472. wantStatusCode: http.StatusInternalServerError,
  2473. wantResponse: `{"message":"internal server error"}`,
  2474. mockParams: mockParams{
  2475. bartAssetManagerParams: bartAssetManagerParams{
  2476. listBARTItemsParams: listBARTItemsParams{
  2477. {
  2478. itemType: 1,
  2479. result: nil,
  2480. err: errors.New("database error"),
  2481. },
  2482. },
  2483. },
  2484. },
  2485. },
  2486. }
  2487. for _, tc := range tt {
  2488. t.Run(tc.name, func(t *testing.T) {
  2489. request := httptest.NewRequest(http.MethodGet, "/bart"+tc.queryParams, nil)
  2490. responseRecorder := httptest.NewRecorder()
  2491. mockBARTManager := newMockBARTAssetManager(t)
  2492. for _, params := range tc.mockParams.listBARTItemsParams {
  2493. mockBARTManager.EXPECT().
  2494. ListBARTItems(matchContext(), params.itemType).
  2495. Return(params.result, params.err)
  2496. }
  2497. getBARTByTypeHandler(responseRecorder, request, mockBARTManager, slog.Default())
  2498. assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
  2499. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  2500. })
  2501. }
  2502. }
  2503. func TestBARTHandler_GET(t *testing.T) {
  2504. tt := []struct {
  2505. name string
  2506. hash string
  2507. wantStatusCode int
  2508. wantResponse string
  2509. wantHeaders map[string]string
  2510. mockParams mockParams
  2511. }{
  2512. {
  2513. name: "success with valid hash",
  2514. hash: "2B000001E4",
  2515. wantStatusCode: http.StatusOK,
  2516. wantResponse: "binary data",
  2517. wantHeaders: map[string]string{"Content-Type": "application/octet-stream"},
  2518. mockParams: mockParams{
  2519. bartAssetManagerParams: bartAssetManagerParams{
  2520. bartItemParams: bartItemParams{
  2521. {
  2522. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2523. result: []byte("binary data"),
  2524. err: nil,
  2525. },
  2526. },
  2527. },
  2528. },
  2529. },
  2530. {
  2531. name: "missing hash parameter",
  2532. hash: "",
  2533. wantStatusCode: http.StatusBadRequest,
  2534. wantResponse: `{"message":"hash is required"}`,
  2535. },
  2536. {
  2537. name: "invalid hash format",
  2538. hash: "invalid-hex",
  2539. wantStatusCode: http.StatusBadRequest,
  2540. wantResponse: `{"message":"invalid hash format"}`,
  2541. },
  2542. {
  2543. name: "asset not found",
  2544. hash: "2B000001E4",
  2545. wantStatusCode: http.StatusNotFound,
  2546. wantResponse: `{"message":"BART asset not found"}`,
  2547. mockParams: mockParams{
  2548. bartAssetManagerParams: bartAssetManagerParams{
  2549. bartItemParams: bartItemParams{
  2550. {
  2551. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2552. result: []byte{},
  2553. err: nil,
  2554. },
  2555. },
  2556. },
  2557. },
  2558. },
  2559. {
  2560. name: "internal server error",
  2561. hash: "2B000001E4",
  2562. wantStatusCode: http.StatusInternalServerError,
  2563. wantResponse: `{"message":"internal server error"}`,
  2564. mockParams: mockParams{
  2565. bartAssetManagerParams: bartAssetManagerParams{
  2566. bartItemParams: bartItemParams{
  2567. {
  2568. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2569. result: nil,
  2570. err: errors.New("database error"),
  2571. },
  2572. },
  2573. },
  2574. },
  2575. },
  2576. }
  2577. for _, tc := range tt {
  2578. t.Run(tc.name, func(t *testing.T) {
  2579. request := httptest.NewRequest(http.MethodGet, "/bart/"+tc.hash, nil)
  2580. // Set the path value manually for testing
  2581. if tc.hash != "" {
  2582. request.SetPathValue("hash", tc.hash)
  2583. }
  2584. responseRecorder := httptest.NewRecorder()
  2585. mockBARTManager := newMockBARTAssetManager(t)
  2586. for _, params := range tc.mockParams.bartItemParams {
  2587. mockBARTManager.EXPECT().
  2588. BARTItem(matchContext(), params.hash).
  2589. Return(params.result, params.err)
  2590. }
  2591. getBARTHandler(responseRecorder, request, mockBARTManager, slog.Default())
  2592. assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
  2593. if tc.wantHeaders != nil {
  2594. for key, value := range tc.wantHeaders {
  2595. assert.Equal(t, value, responseRecorder.Header().Get(key))
  2596. }
  2597. }
  2598. if tc.wantStatusCode == http.StatusOK {
  2599. assert.Equal(t, tc.wantResponse, responseRecorder.Body.String())
  2600. } else {
  2601. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  2602. }
  2603. })
  2604. }
  2605. }
  2606. func TestBARTHandler_POST(t *testing.T) {
  2607. tt := []struct {
  2608. name string
  2609. hash string
  2610. queryParams string
  2611. requestBody string
  2612. wantStatusCode int
  2613. wantResponse string
  2614. mockParams mockParams
  2615. }{
  2616. {
  2617. name: "success with valid data",
  2618. hash: "2B000001E4",
  2619. queryParams: "?type=1",
  2620. requestBody: "binary data",
  2621. wantStatusCode: http.StatusCreated,
  2622. wantResponse: `{"hash":"2b000001e4","type":1}`,
  2623. mockParams: mockParams{
  2624. bartAssetManagerParams: bartAssetManagerParams{
  2625. insertBARTItemParams: insertBARTItemParams{
  2626. {
  2627. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2628. blob: []byte("binary data"),
  2629. itemType: 1,
  2630. err: nil,
  2631. },
  2632. },
  2633. },
  2634. },
  2635. },
  2636. {
  2637. name: "missing hash parameter",
  2638. hash: "",
  2639. queryParams: "?type=1",
  2640. requestBody: "binary data",
  2641. wantStatusCode: http.StatusBadRequest,
  2642. wantResponse: `{"message":"hash path parameter is required"}`,
  2643. },
  2644. {
  2645. name: "invalid hash format",
  2646. hash: "invalid-hex",
  2647. queryParams: "?type=1",
  2648. requestBody: "binary data",
  2649. wantStatusCode: http.StatusBadRequest,
  2650. wantResponse: `{"message":"invalid hash format"}`,
  2651. },
  2652. {
  2653. name: "missing type parameter",
  2654. hash: "2B000001E4",
  2655. queryParams: "",
  2656. requestBody: "binary data",
  2657. wantStatusCode: http.StatusBadRequest,
  2658. wantResponse: `{"message":"type query parameter is required"}`,
  2659. },
  2660. {
  2661. name: "invalid type parameter",
  2662. hash: "2B000001E4",
  2663. queryParams: "?type=invalid",
  2664. requestBody: "binary data",
  2665. wantStatusCode: http.StatusBadRequest,
  2666. wantResponse: `{"message":"invalid type ID"}`,
  2667. },
  2668. {
  2669. name: "failed to read request body",
  2670. hash: "2B000001E4",
  2671. queryParams: "?type=1",
  2672. requestBody: "", // This will cause an error when reading
  2673. wantStatusCode: http.StatusBadRequest,
  2674. wantResponse: `{"message":"failed to read request body"}`,
  2675. },
  2676. {
  2677. name: "asset already exists",
  2678. hash: "2B000001E4",
  2679. queryParams: "?type=1",
  2680. requestBody: "binary data",
  2681. wantStatusCode: http.StatusConflict,
  2682. wantResponse: `{"message":"BART asset already exists"}`,
  2683. mockParams: mockParams{
  2684. bartAssetManagerParams: bartAssetManagerParams{
  2685. insertBARTItemParams: insertBARTItemParams{
  2686. {
  2687. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2688. blob: []byte("binary data"),
  2689. itemType: 1,
  2690. err: state.ErrBARTItemExists,
  2691. },
  2692. },
  2693. },
  2694. },
  2695. },
  2696. {
  2697. name: "internal server error",
  2698. hash: "2B000001E4",
  2699. queryParams: "?type=1",
  2700. requestBody: "binary data",
  2701. wantStatusCode: http.StatusInternalServerError,
  2702. wantResponse: `{"message":"internal server error"}`,
  2703. mockParams: mockParams{
  2704. bartAssetManagerParams: bartAssetManagerParams{
  2705. insertBARTItemParams: insertBARTItemParams{
  2706. {
  2707. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2708. blob: []byte("binary data"),
  2709. itemType: 1,
  2710. err: errors.New("database error"),
  2711. },
  2712. },
  2713. },
  2714. },
  2715. },
  2716. }
  2717. for _, tc := range tt {
  2718. t.Run(tc.name, func(t *testing.T) {
  2719. var requestBody io.Reader
  2720. if tc.requestBody != "" {
  2721. requestBody = strings.NewReader(tc.requestBody)
  2722. } else {
  2723. requestBody = &errorReader{}
  2724. }
  2725. request := httptest.NewRequest(http.MethodPost, "/bart/"+tc.hash+tc.queryParams, requestBody)
  2726. // Set the path value manually for testing
  2727. if tc.hash != "" {
  2728. request.SetPathValue("hash", tc.hash)
  2729. }
  2730. responseRecorder := httptest.NewRecorder()
  2731. mockBARTManager := newMockBARTAssetManager(t)
  2732. for _, params := range tc.mockParams.insertBARTItemParams {
  2733. mockBARTManager.EXPECT().
  2734. InsertBARTItem(matchContext(), params.hash, params.blob, params.itemType).
  2735. Return(params.err)
  2736. }
  2737. postBARTHandler(responseRecorder, request, mockBARTManager, slog.Default())
  2738. assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
  2739. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  2740. })
  2741. }
  2742. }
  2743. func TestBARTHandler_DELETE(t *testing.T) {
  2744. tt := []struct {
  2745. name string
  2746. hash string
  2747. wantStatusCode int
  2748. wantResponse string
  2749. mockParams mockParams
  2750. }{
  2751. {
  2752. name: "success with valid hash",
  2753. hash: "2B000001E4",
  2754. wantStatusCode: http.StatusOK,
  2755. wantResponse: `{"message":"BART asset deleted successfully."}`,
  2756. mockParams: mockParams{
  2757. bartAssetManagerParams: bartAssetManagerParams{
  2758. deleteBARTItemParams: deleteBARTItemParams{
  2759. {
  2760. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2761. err: nil,
  2762. },
  2763. },
  2764. },
  2765. },
  2766. },
  2767. {
  2768. name: "missing hash parameter",
  2769. hash: "",
  2770. wantStatusCode: http.StatusBadRequest,
  2771. wantResponse: `{"message":"hash path parameter is required"}`,
  2772. },
  2773. {
  2774. name: "invalid hash format",
  2775. hash: "invalid-hex",
  2776. wantStatusCode: http.StatusBadRequest,
  2777. wantResponse: `{"message":"invalid hash format"}`,
  2778. },
  2779. {
  2780. name: "asset not found",
  2781. hash: "2B000001E4",
  2782. wantStatusCode: http.StatusNotFound,
  2783. wantResponse: `{"message":"BART asset not found"}`,
  2784. mockParams: mockParams{
  2785. bartAssetManagerParams: bartAssetManagerParams{
  2786. deleteBARTItemParams: deleteBARTItemParams{
  2787. {
  2788. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2789. err: state.ErrBARTItemNotFound,
  2790. },
  2791. },
  2792. },
  2793. },
  2794. },
  2795. {
  2796. name: "internal server error",
  2797. hash: "2B000001E4",
  2798. wantStatusCode: http.StatusInternalServerError,
  2799. wantResponse: `{"message":"internal server error"}`,
  2800. mockParams: mockParams{
  2801. bartAssetManagerParams: bartAssetManagerParams{
  2802. deleteBARTItemParams: deleteBARTItemParams{
  2803. {
  2804. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2805. err: errors.New("database error"),
  2806. },
  2807. },
  2808. },
  2809. },
  2810. },
  2811. }
  2812. for _, tc := range tt {
  2813. t.Run(tc.name, func(t *testing.T) {
  2814. request := httptest.NewRequest(http.MethodDelete, "/bart/"+tc.hash, nil)
  2815. // Set the path value manually for testing
  2816. if tc.hash != "" {
  2817. request.SetPathValue("hash", tc.hash)
  2818. }
  2819. responseRecorder := httptest.NewRecorder()
  2820. mockBARTManager := newMockBARTAssetManager(t)
  2821. for _, params := range tc.mockParams.deleteBARTItemParams {
  2822. mockBARTManager.EXPECT().
  2823. DeleteBARTItem(matchContext(), params.hash).
  2824. Return(params.err)
  2825. }
  2826. deleteBARTHandler(responseRecorder, request, mockBARTManager, slog.Default())
  2827. assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
  2828. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  2829. })
  2830. }
  2831. }
  2832. // errorReader is a helper type that always returns an error when reading
  2833. type errorReader struct{}
  2834. func (er *errorReader) Read(p []byte) (n int, err error) {
  2835. return 0, errors.New("read error")
  2836. }
  2837. func TestFeedbagBuddyHandler_GET(t *testing.T) {
  2838. tt := []struct {
  2839. name string
  2840. screenName string
  2841. wantStatusCode int
  2842. wantResponse string
  2843. mockParams mockParams
  2844. }{
  2845. {
  2846. name: "empty feedbag",
  2847. screenName: "userA",
  2848. wantStatusCode: http.StatusNotFound,
  2849. wantResponse: `{"message":"feedbag not found"}`,
  2850. mockParams: mockParams{
  2851. feedbagManagerParams: feedbagManagerParams{
  2852. feedbagParams: feedbagParams{
  2853. {
  2854. screenName: state.NewIdentScreenName("userA"),
  2855. result: []wire.FeedbagItem{},
  2856. err: nil,
  2857. },
  2858. },
  2859. },
  2860. },
  2861. },
  2862. {
  2863. name: "feedbag with buddies in groups",
  2864. screenName: "userA",
  2865. wantStatusCode: http.StatusOK,
  2866. wantResponse: `[{"group_id":1,"group_name":"Friends","buddies":[{"name":"buddy1","item_id":10},{"name":"buddy2","item_id":11}]},{"group_id":2,"group_name":"Work","buddies":[{"name":"buddy3","item_id":20}]}]`,
  2867. mockParams: mockParams{
  2868. feedbagManagerParams: feedbagManagerParams{
  2869. feedbagParams: feedbagParams{
  2870. {
  2871. screenName: state.NewIdentScreenName("userA"),
  2872. result: []wire.FeedbagItem{
  2873. {
  2874. ItemID: 0,
  2875. ClassID: wire.FeedbagClassIdGroup,
  2876. Name: "",
  2877. GroupID: 0,
  2878. },
  2879. {
  2880. ItemID: 1,
  2881. ClassID: wire.FeedbagClassIdGroup,
  2882. Name: "Friends",
  2883. GroupID: 1,
  2884. TLVLBlock: wire.TLVLBlock{
  2885. TLVList: wire.TLVList{
  2886. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{10, 11}),
  2887. },
  2888. },
  2889. },
  2890. {
  2891. ItemID: 2,
  2892. ClassID: wire.FeedbagClassIdGroup,
  2893. Name: "Work",
  2894. GroupID: 2,
  2895. TLVLBlock: wire.TLVLBlock{
  2896. TLVList: wire.TLVList{
  2897. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{20}),
  2898. },
  2899. },
  2900. },
  2901. {
  2902. ItemID: 10,
  2903. ClassID: wire.FeedbagClassIdBuddy,
  2904. Name: "buddy1",
  2905. GroupID: 1,
  2906. },
  2907. {
  2908. ItemID: 11,
  2909. ClassID: wire.FeedbagClassIdBuddy,
  2910. Name: "buddy2",
  2911. GroupID: 1,
  2912. },
  2913. {
  2914. ItemID: 20,
  2915. ClassID: wire.FeedbagClassIdBuddy,
  2916. Name: "buddy3",
  2917. GroupID: 2,
  2918. },
  2919. },
  2920. err: nil,
  2921. },
  2922. },
  2923. },
  2924. },
  2925. },
  2926. {
  2927. name: "feedbag with no groups (besides root)",
  2928. screenName: "userA",
  2929. wantStatusCode: http.StatusOK,
  2930. wantResponse: `[]`,
  2931. mockParams: mockParams{
  2932. feedbagManagerParams: feedbagManagerParams{
  2933. feedbagParams: feedbagParams{
  2934. {
  2935. screenName: state.NewIdentScreenName("userA"),
  2936. result: []wire.FeedbagItem{
  2937. {
  2938. ItemID: 0,
  2939. ClassID: wire.FeedbagClassIdGroup,
  2940. Name: "",
  2941. GroupID: 0,
  2942. },
  2943. },
  2944. err: nil,
  2945. },
  2946. },
  2947. },
  2948. },
  2949. // Note: Root groups (GroupID == 0) are skipped by the implementation,
  2950. // so the response will be an empty array []
  2951. },
  2952. {
  2953. name: "missing screen_name",
  2954. screenName: "",
  2955. wantStatusCode: http.StatusBadRequest,
  2956. wantResponse: `{"message":"screen_name is required"}`,
  2957. },
  2958. {
  2959. name: "internal server error",
  2960. screenName: "userA",
  2961. wantStatusCode: http.StatusInternalServerError,
  2962. wantResponse: `{"message":"internal server error"}`,
  2963. mockParams: mockParams{
  2964. feedbagManagerParams: feedbagManagerParams{
  2965. feedbagParams: feedbagParams{
  2966. {
  2967. screenName: state.NewIdentScreenName("userA"),
  2968. result: nil,
  2969. err: errors.New("database error"),
  2970. },
  2971. },
  2972. },
  2973. },
  2974. },
  2975. }
  2976. for _, tc := range tt {
  2977. t.Run(tc.name, func(t *testing.T) {
  2978. request := httptest.NewRequest(http.MethodGet, "/feedbag/"+tc.screenName+"/group", nil)
  2979. if tc.screenName != "" {
  2980. request.SetPathValue("screen_name", tc.screenName)
  2981. }
  2982. responseRecorder := httptest.NewRecorder()
  2983. feedbagManager := newMockFeedbagManager(t)
  2984. for _, params := range tc.mockParams.feedbagParams {
  2985. feedbagManager.EXPECT().
  2986. Feedbag(matchContext(), params.screenName).
  2987. Return(params.result, params.err)
  2988. }
  2989. getFeedbagBuddyHandler(responseRecorder, request, feedbagManager, slog.Default())
  2990. assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
  2991. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  2992. })
  2993. }
  2994. }
  2995. func TestFeedbagGroupHandler_PUT(t *testing.T) {
  2996. tt := []struct {
  2997. name string
  2998. screenName string
  2999. groupName string
  3000. groupIDGen func(n int) int
  3001. wantStatusCode int
  3002. wantResponse string
  3003. mockParams mockParams
  3004. }{
  3005. {
  3006. name: "add group to empty feedbag",
  3007. screenName: "userA",
  3008. groupName: "Friends",
  3009. groupIDGen: func(n int) int { return 5 },
  3010. wantStatusCode: http.StatusCreated,
  3011. wantResponse: `{"group_id":5,"group_name":"Friends"}`,
  3012. mockParams: mockParams{
  3013. feedbagManagerParams: feedbagManagerParams{
  3014. feedbagParams: feedbagParams{
  3015. {
  3016. screenName: state.NewIdentScreenName("userA"),
  3017. result: []wire.FeedbagItem{},
  3018. err: nil,
  3019. },
  3020. },
  3021. feedbagUpsertParams: feedbagUpsertParams{
  3022. {
  3023. screenName: state.NewIdentScreenName("userA"),
  3024. items: []wire.FeedbagItem{
  3025. {
  3026. ClassID: wire.FeedbagClassIdGroup,
  3027. GroupID: 0,
  3028. TLVLBlock: wire.TLVLBlock{
  3029. TLVList: wire.TLVList{
  3030. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{5}),
  3031. },
  3032. },
  3033. },
  3034. {
  3035. ClassID: wire.FeedbagClassIdGroup,
  3036. Name: "Friends",
  3037. GroupID: 5,
  3038. },
  3039. },
  3040. err: nil,
  3041. },
  3042. },
  3043. },
  3044. messageRelayerParams: messageRelayerParams{
  3045. relayToScreenNameParams: relayToScreenNameParams{
  3046. {
  3047. screenName: state.NewIdentScreenName("userA"),
  3048. msg: wire.SNACMessage{
  3049. Frame: wire.SNACFrame{
  3050. FoodGroup: wire.Feedbag,
  3051. SubGroup: wire.FeedbagInsertItem,
  3052. RequestID: wire.ReqIDFromServer,
  3053. },
  3054. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  3055. Items: []wire.FeedbagItem{
  3056. {
  3057. ClassID: wire.FeedbagClassIdGroup,
  3058. GroupID: 0,
  3059. TLVLBlock: wire.TLVLBlock{
  3060. TLVList: wire.TLVList{
  3061. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{5}),
  3062. },
  3063. },
  3064. },
  3065. {
  3066. ClassID: wire.FeedbagClassIdGroup,
  3067. Name: "Friends",
  3068. GroupID: 5,
  3069. },
  3070. },
  3071. },
  3072. },
  3073. },
  3074. },
  3075. },
  3076. },
  3077. },
  3078. {
  3079. name: "add group to feedbag with existing root",
  3080. screenName: "userA",
  3081. groupName: "Coworkers",
  3082. groupIDGen: func(n int) int { return 2 },
  3083. wantStatusCode: http.StatusCreated,
  3084. wantResponse: `{"group_id":2,"group_name":"Coworkers"}`,
  3085. mockParams: mockParams{
  3086. feedbagManagerParams: feedbagManagerParams{
  3087. feedbagParams: feedbagParams{
  3088. {
  3089. screenName: state.NewIdentScreenName("userA"),
  3090. result: []wire.FeedbagItem{
  3091. {
  3092. ClassID: wire.FeedbagClassIdGroup,
  3093. GroupID: 0,
  3094. TLVLBlock: wire.TLVLBlock{
  3095. TLVList: wire.TLVList{
  3096. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1}),
  3097. },
  3098. },
  3099. },
  3100. {
  3101. ClassID: wire.FeedbagClassIdGroup,
  3102. Name: "Buddies",
  3103. GroupID: 1,
  3104. },
  3105. },
  3106. err: nil,
  3107. },
  3108. },
  3109. feedbagUpsertParams: feedbagUpsertParams{
  3110. {
  3111. screenName: state.NewIdentScreenName("userA"),
  3112. items: []wire.FeedbagItem{
  3113. {
  3114. ClassID: wire.FeedbagClassIdGroup,
  3115. GroupID: 0,
  3116. TLVLBlock: wire.TLVLBlock{
  3117. TLVList: wire.TLVList{
  3118. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1, 2}),
  3119. },
  3120. },
  3121. },
  3122. {
  3123. ClassID: wire.FeedbagClassIdGroup,
  3124. Name: "Coworkers",
  3125. GroupID: 2,
  3126. },
  3127. },
  3128. err: nil,
  3129. },
  3130. },
  3131. },
  3132. messageRelayerParams: messageRelayerParams{
  3133. relayToScreenNameParams: relayToScreenNameParams{
  3134. {
  3135. screenName: state.NewIdentScreenName("userA"),
  3136. msg: wire.SNACMessage{
  3137. Frame: wire.SNACFrame{
  3138. FoodGroup: wire.Feedbag,
  3139. SubGroup: wire.FeedbagInsertItem,
  3140. RequestID: wire.ReqIDFromServer,
  3141. },
  3142. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  3143. Items: []wire.FeedbagItem{
  3144. {
  3145. ClassID: wire.FeedbagClassIdGroup,
  3146. GroupID: 0,
  3147. TLVLBlock: wire.TLVLBlock{
  3148. TLVList: wire.TLVList{
  3149. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1, 2}),
  3150. },
  3151. },
  3152. },
  3153. {
  3154. ClassID: wire.FeedbagClassIdGroup,
  3155. Name: "Coworkers",
  3156. GroupID: 2,
  3157. },
  3158. },
  3159. },
  3160. },
  3161. },
  3162. },
  3163. },
  3164. },
  3165. },
  3166. {
  3167. name: "group already exists",
  3168. screenName: "userA",
  3169. groupName: "Friends",
  3170. groupIDGen: func(n int) int { return 99 },
  3171. wantStatusCode: http.StatusOK,
  3172. wantResponse: `{"group_id":1,"group_name":"Friends"}`,
  3173. mockParams: mockParams{
  3174. feedbagManagerParams: feedbagManagerParams{
  3175. feedbagParams: feedbagParams{
  3176. {
  3177. screenName: state.NewIdentScreenName("userA"),
  3178. result: []wire.FeedbagItem{
  3179. {
  3180. ClassID: wire.FeedbagClassIdGroup,
  3181. GroupID: 0,
  3182. },
  3183. {
  3184. ClassID: wire.FeedbagClassIdGroup,
  3185. Name: "Friends",
  3186. GroupID: 1,
  3187. },
  3188. },
  3189. err: nil,
  3190. },
  3191. },
  3192. },
  3193. },
  3194. },
  3195. {
  3196. name: "missing screen_name",
  3197. screenName: "",
  3198. groupName: "Friends",
  3199. groupIDGen: func(n int) int { return 5 },
  3200. wantStatusCode: http.StatusBadRequest,
  3201. wantResponse: `{"message":"screen_name is required"}`,
  3202. },
  3203. {
  3204. name: "missing group_name",
  3205. screenName: "userA",
  3206. groupName: "",
  3207. groupIDGen: func(n int) int { return 5 },
  3208. wantStatusCode: http.StatusBadRequest,
  3209. wantResponse: `{"message":"group_name is required"}`,
  3210. },
  3211. {
  3212. name: "error retrieving feedbag",
  3213. screenName: "userA",
  3214. groupName: "Friends",
  3215. groupIDGen: func(n int) int { return 5 },
  3216. wantStatusCode: http.StatusInternalServerError,
  3217. wantResponse: `{"message":"internal server error"}`,
  3218. mockParams: mockParams{
  3219. feedbagManagerParams: feedbagManagerParams{
  3220. feedbagParams: feedbagParams{
  3221. {
  3222. screenName: state.NewIdentScreenName("userA"),
  3223. result: nil,
  3224. err: errors.New("database error"),
  3225. },
  3226. },
  3227. },
  3228. },
  3229. },
  3230. {
  3231. name: "error upserting feedbag",
  3232. screenName: "userA",
  3233. groupName: "Friends",
  3234. groupIDGen: func(n int) int { return 5 },
  3235. wantStatusCode: http.StatusInternalServerError,
  3236. wantResponse: `{"message":"internal server error"}`,
  3237. mockParams: mockParams{
  3238. feedbagManagerParams: feedbagManagerParams{
  3239. feedbagParams: feedbagParams{
  3240. {
  3241. screenName: state.NewIdentScreenName("userA"),
  3242. result: []wire.FeedbagItem{},
  3243. err: nil,
  3244. },
  3245. },
  3246. feedbagUpsertParams: feedbagUpsertParams{
  3247. {
  3248. screenName: state.NewIdentScreenName("userA"),
  3249. items: []wire.FeedbagItem{
  3250. {
  3251. ClassID: wire.FeedbagClassIdGroup,
  3252. GroupID: 0,
  3253. TLVLBlock: wire.TLVLBlock{
  3254. TLVList: wire.TLVList{
  3255. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{5}),
  3256. },
  3257. },
  3258. },
  3259. {
  3260. ClassID: wire.FeedbagClassIdGroup,
  3261. Name: "Friends",
  3262. GroupID: 5,
  3263. },
  3264. },
  3265. err: errors.New("database error"),
  3266. },
  3267. },
  3268. },
  3269. },
  3270. },
  3271. }
  3272. for _, tc := range tt {
  3273. t.Run(tc.name, func(t *testing.T) {
  3274. request := httptest.NewRequest(http.MethodPut, "/feedbag/"+tc.screenName+"/group/"+tc.groupName, nil)
  3275. if tc.screenName != "" {
  3276. request.SetPathValue("screen_name", tc.screenName)
  3277. }
  3278. if tc.groupName != "" {
  3279. request.SetPathValue("group_name", tc.groupName)
  3280. }
  3281. responseRecorder := httptest.NewRecorder()
  3282. feedbagManager := newMockFeedbagManager(t)
  3283. messageRelayer := newMockMessageRelayer(t)
  3284. for _, params := range tc.mockParams.feedbagParams {
  3285. feedbagManager.EXPECT().
  3286. Feedbag(matchContext(), params.screenName).
  3287. Return(params.result, params.err)
  3288. }
  3289. for _, params := range tc.mockParams.feedbagUpsertParams {
  3290. feedbagManager.EXPECT().
  3291. FeedbagUpsert(matchContext(), params.screenName, params.items).
  3292. Return(params.err)
  3293. }
  3294. for _, params := range tc.mockParams.relayToScreenNameParams {
  3295. messageRelayer.EXPECT().
  3296. RelayToScreenName(matchContext(), params.screenName, params.msg)
  3297. }
  3298. putFeedbagGroupHandler(responseRecorder, request, feedbagManager, messageRelayer, slog.Default(), tc.groupIDGen)
  3299. assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
  3300. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  3301. })
  3302. }
  3303. }
  3304. func TestFeedbagBuddyHandler_PUT(t *testing.T) {
  3305. tt := []struct {
  3306. name string
  3307. screenName string
  3308. groupID string
  3309. requestBody string
  3310. wantStatusCode int
  3311. wantResponse string
  3312. mockParams mockParams
  3313. }{
  3314. {
  3315. name: "add a buddy to an empty group, user not signed in",
  3316. screenName: "userA",
  3317. groupID: "1",
  3318. requestBody: `{"name":"newbuddy"}`,
  3319. wantStatusCode: http.StatusOK,
  3320. wantResponse: `{"name":"newbuddy","group_id":1,"item_id":1000}`,
  3321. mockParams: mockParams{
  3322. feedbagManagerParams: feedbagManagerParams{
  3323. feedbagParams: feedbagParams{
  3324. {
  3325. screenName: state.NewIdentScreenName("userA"),
  3326. result: []wire.FeedbagItem{
  3327. {
  3328. ClassID: wire.FeedbagClassIdGroup,
  3329. Name: "Friends",
  3330. GroupID: 1,
  3331. },
  3332. },
  3333. err: nil,
  3334. },
  3335. },
  3336. feedbagUpsertParams: feedbagUpsertParams{
  3337. {
  3338. screenName: state.NewIdentScreenName("userA"),
  3339. items: []wire.FeedbagItem{
  3340. {
  3341. Name: "newbuddy",
  3342. GroupID: 1,
  3343. ItemID: 1000,
  3344. ClassID: wire.FeedbagClassIdBuddy,
  3345. },
  3346. {
  3347. ClassID: wire.FeedbagClassIdGroup,
  3348. Name: "Friends",
  3349. GroupID: 1,
  3350. TLVLBlock: wire.TLVLBlock{
  3351. TLVList: wire.TLVList{
  3352. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1000}),
  3353. },
  3354. },
  3355. },
  3356. },
  3357. err: nil,
  3358. },
  3359. },
  3360. },
  3361. sessionRetrieverParams: sessionRetrieverParams{
  3362. retrieveSessionByNameParams: retrieveSessionByNameParams{
  3363. {
  3364. screenName: state.NewIdentScreenName("userA"),
  3365. result: state.NewSession(),
  3366. },
  3367. },
  3368. },
  3369. messageRelayerParams: messageRelayerParams{
  3370. relayToScreenNameParams: relayToScreenNameParams{
  3371. {
  3372. screenName: state.NewIdentScreenName("userA"),
  3373. msg: wire.SNACMessage{
  3374. Frame: wire.SNACFrame{
  3375. FoodGroup: wire.Feedbag,
  3376. SubGroup: wire.FeedbagInsertItem,
  3377. RequestID: wire.ReqIDFromServer,
  3378. },
  3379. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  3380. Items: []wire.FeedbagItem{
  3381. {
  3382. Name: "newbuddy",
  3383. GroupID: 1,
  3384. ItemID: 1000,
  3385. ClassID: wire.FeedbagClassIdBuddy,
  3386. },
  3387. },
  3388. },
  3389. },
  3390. },
  3391. {
  3392. screenName: state.NewIdentScreenName("userA"),
  3393. msg: wire.SNACMessage{
  3394. Frame: wire.SNACFrame{
  3395. FoodGroup: wire.Feedbag,
  3396. SubGroup: wire.FeedbagUpdateItem,
  3397. RequestID: wire.ReqIDFromServer,
  3398. },
  3399. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  3400. Items: []wire.FeedbagItem{
  3401. {
  3402. ClassID: wire.FeedbagClassIdGroup,
  3403. Name: "Friends",
  3404. GroupID: 1,
  3405. TLVLBlock: wire.TLVLBlock{
  3406. TLVList: wire.TLVList{
  3407. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1000}),
  3408. },
  3409. },
  3410. },
  3411. },
  3412. },
  3413. },
  3414. },
  3415. },
  3416. },
  3417. },
  3418. },
  3419. {
  3420. name: "add a buddy to a non-empty group, user not signed in",
  3421. screenName: "userA",
  3422. groupID: "1",
  3423. requestBody: `{"name":"newbuddy2"}`,
  3424. wantStatusCode: http.StatusOK,
  3425. wantResponse: `{"name":"newbuddy2","group_id":1,"item_id":1000}`,
  3426. mockParams: mockParams{
  3427. feedbagManagerParams: feedbagManagerParams{
  3428. feedbagParams: feedbagParams{
  3429. {
  3430. screenName: state.NewIdentScreenName("userA"),
  3431. result: []wire.FeedbagItem{
  3432. {
  3433. ClassID: wire.FeedbagClassIdGroup,
  3434. Name: "Friends",
  3435. GroupID: 1,
  3436. TLVLBlock: wire.TLVLBlock{
  3437. TLVList: wire.TLVList{
  3438. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{12345}),
  3439. },
  3440. },
  3441. },
  3442. {
  3443. ItemID: 12345,
  3444. ClassID: wire.FeedbagClassIdBuddy,
  3445. Name: "existingbuddy",
  3446. GroupID: 1,
  3447. },
  3448. },
  3449. err: nil,
  3450. },
  3451. },
  3452. feedbagUpsertParams: feedbagUpsertParams{
  3453. {
  3454. screenName: state.NewIdentScreenName("userA"),
  3455. items: []wire.FeedbagItem{
  3456. {
  3457. Name: "newbuddy2",
  3458. GroupID: 1,
  3459. ItemID: 1000,
  3460. ClassID: wire.FeedbagClassIdBuddy,
  3461. },
  3462. {
  3463. ClassID: wire.FeedbagClassIdGroup,
  3464. Name: "Friends",
  3465. GroupID: 1,
  3466. TLVLBlock: wire.TLVLBlock{
  3467. TLVList: wire.TLVList{
  3468. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{12345, 1000}),
  3469. },
  3470. },
  3471. },
  3472. },
  3473. err: nil,
  3474. },
  3475. },
  3476. },
  3477. sessionRetrieverParams: sessionRetrieverParams{
  3478. retrieveSessionByNameParams: retrieveSessionByNameParams{
  3479. {
  3480. screenName: state.NewIdentScreenName("userA"),
  3481. result: state.NewSession(),
  3482. },
  3483. },
  3484. },
  3485. messageRelayerParams: messageRelayerParams{
  3486. relayToScreenNameParams: relayToScreenNameParams{
  3487. {
  3488. screenName: state.NewIdentScreenName("userA"),
  3489. msg: wire.SNACMessage{
  3490. Frame: wire.SNACFrame{
  3491. FoodGroup: wire.Feedbag,
  3492. SubGroup: wire.FeedbagInsertItem,
  3493. RequestID: wire.ReqIDFromServer,
  3494. },
  3495. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  3496. Items: []wire.FeedbagItem{
  3497. {
  3498. Name: "newbuddy2",
  3499. GroupID: 1,
  3500. ItemID: 1000,
  3501. ClassID: wire.FeedbagClassIdBuddy,
  3502. },
  3503. },
  3504. },
  3505. },
  3506. },
  3507. {
  3508. screenName: state.NewIdentScreenName("userA"),
  3509. msg: wire.SNACMessage{
  3510. Frame: wire.SNACFrame{
  3511. FoodGroup: wire.Feedbag,
  3512. SubGroup: wire.FeedbagUpdateItem,
  3513. RequestID: wire.ReqIDFromServer,
  3514. },
  3515. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  3516. Items: []wire.FeedbagItem{
  3517. {
  3518. ClassID: wire.FeedbagClassIdGroup,
  3519. Name: "Friends",
  3520. GroupID: 1,
  3521. TLVLBlock: wire.TLVLBlock{
  3522. TLVList: wire.TLVList{
  3523. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{12345, 1000}),
  3524. },
  3525. },
  3526. },
  3527. },
  3528. },
  3529. },
  3530. },
  3531. },
  3532. },
  3533. },
  3534. },
  3535. {
  3536. name: "add a buddy that already exists in a group",
  3537. screenName: "userA",
  3538. groupID: "1",
  3539. requestBody: `{"name":"ExistingBuddy"}`,
  3540. wantStatusCode: http.StatusOK,
  3541. wantResponse: `{"name":"ExistingBuddy","group_id":1,"item_id":12345}`,
  3542. mockParams: mockParams{
  3543. feedbagManagerParams: feedbagManagerParams{
  3544. feedbagParams: feedbagParams{
  3545. {
  3546. screenName: state.NewIdentScreenName("userA"),
  3547. result: []wire.FeedbagItem{
  3548. {
  3549. ClassID: wire.FeedbagClassIdGroup,
  3550. Name: "Friends",
  3551. GroupID: 1,
  3552. TLVLBlock: wire.TLVLBlock{
  3553. TLVList: wire.TLVList{
  3554. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{12345}),
  3555. },
  3556. },
  3557. },
  3558. {
  3559. ItemID: 12345,
  3560. ClassID: wire.FeedbagClassIdBuddy,
  3561. Name: "existingbuddy",
  3562. GroupID: 1,
  3563. },
  3564. },
  3565. err: nil,
  3566. },
  3567. },
  3568. // No FeedbagUpsert should be called when buddy already exists
  3569. },
  3570. // No session retrieval or message relaying should occur
  3571. },
  3572. },
  3573. {
  3574. name: "add a buddy to an empty group, user signed in",
  3575. screenName: "userA",
  3576. groupID: "1",
  3577. requestBody: `{"name":"newbuddy"}`,
  3578. wantStatusCode: http.StatusOK,
  3579. wantResponse: `{"name":"newbuddy","group_id":1,"item_id":1000}`,
  3580. mockParams: mockParams{
  3581. feedbagManagerParams: feedbagManagerParams{
  3582. feedbagParams: feedbagParams{
  3583. {
  3584. screenName: state.NewIdentScreenName("userA"),
  3585. result: []wire.FeedbagItem{
  3586. {
  3587. ClassID: wire.FeedbagClassIdGroup,
  3588. Name: "Friends",
  3589. GroupID: 1,
  3590. },
  3591. },
  3592. err: nil,
  3593. },
  3594. },
  3595. feedbagUpsertParams: feedbagUpsertParams{
  3596. {
  3597. screenName: state.NewIdentScreenName("userA"),
  3598. items: []wire.FeedbagItem{
  3599. {
  3600. Name: "newbuddy",
  3601. GroupID: 1,
  3602. ItemID: 1000,
  3603. ClassID: wire.FeedbagClassIdBuddy,
  3604. },
  3605. {
  3606. ClassID: wire.FeedbagClassIdGroup,
  3607. Name: "Friends",
  3608. GroupID: 1,
  3609. TLVLBlock: wire.TLVLBlock{
  3610. TLVList: wire.TLVList{
  3611. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1000}),
  3612. },
  3613. },
  3614. },
  3615. },
  3616. err: nil,
  3617. },
  3618. },
  3619. },
  3620. sessionRetrieverParams: sessionRetrieverParams{
  3621. retrieveSessionByNameParams: retrieveSessionByNameParams{
  3622. {
  3623. screenName: state.NewIdentScreenName("userA"),
  3624. result: func() *state.Session {
  3625. sess := state.NewSession()
  3626. sess.SetIdentScreenName(state.NewIdentScreenName("userA"))
  3627. inst := sess.AddInstance()
  3628. inst.SetSignonComplete()
  3629. return sess
  3630. }(),
  3631. },
  3632. },
  3633. },
  3634. messageRelayerParams: messageRelayerParams{
  3635. relayToScreenNameParams: relayToScreenNameParams{
  3636. {
  3637. screenName: state.NewIdentScreenName("userA"),
  3638. msg: wire.SNACMessage{
  3639. Frame: wire.SNACFrame{
  3640. FoodGroup: wire.Feedbag,
  3641. SubGroup: wire.FeedbagInsertItem,
  3642. RequestID: wire.ReqIDFromServer,
  3643. },
  3644. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  3645. Items: []wire.FeedbagItem{
  3646. {
  3647. Name: "newbuddy",
  3648. GroupID: 1,
  3649. ItemID: 1000,
  3650. ClassID: wire.FeedbagClassIdBuddy,
  3651. },
  3652. },
  3653. },
  3654. },
  3655. },
  3656. {
  3657. screenName: state.NewIdentScreenName("userA"),
  3658. msg: wire.SNACMessage{
  3659. Frame: wire.SNACFrame{
  3660. FoodGroup: wire.Feedbag,
  3661. SubGroup: wire.FeedbagUpdateItem,
  3662. RequestID: wire.ReqIDFromServer,
  3663. },
  3664. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  3665. Items: []wire.FeedbagItem{
  3666. {
  3667. ClassID: wire.FeedbagClassIdGroup,
  3668. Name: "Friends",
  3669. GroupID: 1,
  3670. TLVLBlock: wire.TLVLBlock{
  3671. TLVList: wire.TLVList{
  3672. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1000}),
  3673. },
  3674. },
  3675. },
  3676. },
  3677. },
  3678. },
  3679. },
  3680. },
  3681. },
  3682. buddyBroadcasterParams: buddyBroadcasterParams{
  3683. broadcastVisibilityParams: broadcastVisibilityParams{
  3684. {
  3685. you: nil, // Not used in expectation, matched with mock.AnythingOfType
  3686. filter: []state.IdentScreenName{state.NewIdentScreenName("newbuddy")},
  3687. sendDepartures: false,
  3688. err: nil,
  3689. },
  3690. },
  3691. },
  3692. },
  3693. },
  3694. {
  3695. name: "invalid group_id - non-numeric",
  3696. screenName: "userA",
  3697. groupID: "invalid",
  3698. requestBody: `{"name":"buddy"}`,
  3699. wantStatusCode: http.StatusBadRequest,
  3700. wantResponse: `{"message":"invalid group_id"}`,
  3701. },
  3702. {
  3703. name: "invalid group_id - out of range",
  3704. screenName: "userA",
  3705. groupID: "99999",
  3706. requestBody: `{"name":"buddy"}`,
  3707. wantStatusCode: http.StatusBadRequest,
  3708. wantResponse: `{"message":"invalid group_id"}`,
  3709. },
  3710. {
  3711. name: "can't add buddies to root group",
  3712. screenName: "userA",
  3713. groupID: "0",
  3714. requestBody: `{"name":"buddy"}`,
  3715. wantStatusCode: http.StatusBadRequest,
  3716. wantResponse: `{"message":"can't add buddies to root group"}`,
  3717. },
  3718. {
  3719. name: "empty screen_name",
  3720. screenName: "",
  3721. groupID: "1",
  3722. requestBody: `{"name":"buddy"}`,
  3723. wantStatusCode: http.StatusBadRequest,
  3724. wantResponse: `{"message":"screen_name is required"}`,
  3725. },
  3726. {
  3727. name: "malformed JSON input",
  3728. screenName: "userA",
  3729. groupID: "1",
  3730. requestBody: `invalid json`,
  3731. wantStatusCode: http.StatusBadRequest,
  3732. wantResponse: `{"message":"buddy_screen_name is required"}`,
  3733. },
  3734. {
  3735. name: "empty name in request body",
  3736. screenName: "userA",
  3737. groupID: "1",
  3738. requestBody: `{"name":""}`,
  3739. wantStatusCode: http.StatusBadRequest,
  3740. wantResponse: `{"message":"buddy_screen_name is required"}`,
  3741. },
  3742. {
  3743. name: "missing name in request body",
  3744. screenName: "userA",
  3745. groupID: "1",
  3746. requestBody: `{}`,
  3747. wantStatusCode: http.StatusBadRequest,
  3748. wantResponse: `{"message":"buddy_screen_name is required"}`,
  3749. },
  3750. {
  3751. name: "invalid UIN - too low",
  3752. screenName: "userA",
  3753. groupID: "1",
  3754. requestBody: `{"name":"9999"}`,
  3755. wantStatusCode: http.StatusBadRequest,
  3756. wantResponse: `{"message":"invalid uin: uin must be a number in the range 10000-2147483646"}`,
  3757. },
  3758. {
  3759. name: "invalid UIN - too high",
  3760. screenName: "userA",
  3761. groupID: "1",
  3762. requestBody: `{"name":"2147483647"}`,
  3763. wantStatusCode: http.StatusBadRequest,
  3764. wantResponse: `{"message":"invalid uin: uin must be a number in the range 10000-2147483646"}`,
  3765. },
  3766. {
  3767. name: "invalid AIM handle - too short",
  3768. screenName: "userA",
  3769. groupID: "1",
  3770. requestBody: `{"name":"Us"}`,
  3771. wantStatusCode: http.StatusBadRequest,
  3772. wantResponse: `{"message":"invalid screen name: screen name must be between 3 and 16 characters"}`,
  3773. },
  3774. {
  3775. name: "invalid AIM handle - too long",
  3776. screenName: "userA",
  3777. groupID: "1",
  3778. requestBody: `{"name":"ThisIsAReallyLongScreenName"}`,
  3779. wantStatusCode: http.StatusBadRequest,
  3780. wantResponse: `{"message":"invalid screen name: screen name must be between 3 and 16 characters"}`,
  3781. },
  3782. {
  3783. name: "error retrieving feedbag",
  3784. screenName: "userA",
  3785. groupID: "1",
  3786. requestBody: `{"name":"buddy"}`,
  3787. wantStatusCode: http.StatusInternalServerError,
  3788. wantResponse: `{"message":"internal server error"}`,
  3789. mockParams: mockParams{
  3790. feedbagManagerParams: feedbagManagerParams{
  3791. feedbagParams: feedbagParams{
  3792. {
  3793. screenName: state.NewIdentScreenName("userA"),
  3794. result: nil,
  3795. err: errors.New("database error"),
  3796. },
  3797. },
  3798. },
  3799. },
  3800. },
  3801. {
  3802. name: "too many buddies in group - max 30",
  3803. screenName: "userA",
  3804. groupID: "1",
  3805. requestBody: `{"name":"newbuddy"}`,
  3806. wantStatusCode: http.StatusBadRequest,
  3807. wantResponse: `{"message":"too many buddies in group. max: 30"}`,
  3808. mockParams: mockParams{
  3809. feedbagManagerParams: feedbagManagerParams{
  3810. feedbagParams: feedbagParams{
  3811. {
  3812. screenName: state.NewIdentScreenName("userA"),
  3813. result: func() []wire.FeedbagItem {
  3814. order := make([]uint16, 30)
  3815. for i := 1; i <= 30; i++ {
  3816. order[i-1] = uint16(i)
  3817. }
  3818. items := []wire.FeedbagItem{
  3819. {
  3820. ClassID: wire.FeedbagClassIdGroup,
  3821. Name: "Friends",
  3822. GroupID: 1,
  3823. TLVLBlock: wire.TLVLBlock{
  3824. TLVList: wire.TLVList{
  3825. wire.NewTLVBE(wire.FeedbagAttributesOrder, order),
  3826. },
  3827. },
  3828. },
  3829. }
  3830. // Add 30 buddies to the group
  3831. for i := 1; i <= 30; i++ {
  3832. items = append(items, wire.FeedbagItem{
  3833. ItemID: uint16(i),
  3834. ClassID: wire.FeedbagClassIdBuddy,
  3835. Name: fmt.Sprintf("buddy%d", i),
  3836. GroupID: 1,
  3837. })
  3838. }
  3839. return items
  3840. }(),
  3841. err: nil,
  3842. },
  3843. },
  3844. },
  3845. },
  3846. },
  3847. {
  3848. name: "group not found",
  3849. screenName: "userA",
  3850. groupID: "999",
  3851. requestBody: `{"name":"buddy"}`,
  3852. wantStatusCode: http.StatusNotFound,
  3853. wantResponse: `{"message":"group not found"}`,
  3854. mockParams: mockParams{
  3855. feedbagManagerParams: feedbagManagerParams{
  3856. feedbagParams: feedbagParams{
  3857. {
  3858. screenName: state.NewIdentScreenName("userA"),
  3859. result: []wire.FeedbagItem{
  3860. {
  3861. ClassID: wire.FeedbagClassIdGroup,
  3862. Name: "Friends",
  3863. GroupID: 1,
  3864. },
  3865. },
  3866. err: nil,
  3867. },
  3868. },
  3869. },
  3870. },
  3871. },
  3872. {
  3873. name: "error inserting feedbag item",
  3874. screenName: "userA",
  3875. groupID: "1",
  3876. requestBody: `{"name":"buddy"}`,
  3877. wantStatusCode: http.StatusInternalServerError,
  3878. wantResponse: `{"message":"internal server error"}`,
  3879. mockParams: mockParams{
  3880. feedbagManagerParams: feedbagManagerParams{
  3881. feedbagParams: feedbagParams{
  3882. {
  3883. screenName: state.NewIdentScreenName("userA"),
  3884. result: []wire.FeedbagItem{
  3885. {
  3886. ClassID: wire.FeedbagClassIdGroup,
  3887. Name: "Friends",
  3888. GroupID: 1,
  3889. },
  3890. },
  3891. err: nil,
  3892. },
  3893. },
  3894. feedbagUpsertParams: feedbagUpsertParams{
  3895. {
  3896. screenName: state.NewIdentScreenName("userA"),
  3897. items: []wire.FeedbagItem{
  3898. {
  3899. Name: "buddy",
  3900. GroupID: 1,
  3901. ItemID: 1000,
  3902. ClassID: wire.FeedbagClassIdBuddy,
  3903. },
  3904. {
  3905. ClassID: wire.FeedbagClassIdGroup,
  3906. Name: "Friends",
  3907. GroupID: 1,
  3908. TLVLBlock: wire.TLVLBlock{
  3909. TLVList: wire.TLVList{
  3910. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1000}),
  3911. },
  3912. },
  3913. },
  3914. },
  3915. err: errors.New("database error"),
  3916. },
  3917. },
  3918. },
  3919. },
  3920. },
  3921. }
  3922. for _, tc := range tt {
  3923. t.Run(tc.name, func(t *testing.T) {
  3924. // Extract buddy name from requestBody JSON
  3925. var buddyName string
  3926. if tc.requestBody != "" {
  3927. var input struct {
  3928. Name string `json:"name"`
  3929. }
  3930. if err := json.Unmarshal([]byte(tc.requestBody), &input); err == nil {
  3931. buddyName = input.Name
  3932. }
  3933. }
  3934. request := httptest.NewRequest(http.MethodPut, "/feedbag/"+tc.screenName+"/group/"+tc.groupID+"/buddy/"+buddyName, nil)
  3935. if tc.screenName != "" {
  3936. request.SetPathValue("screen_name", tc.screenName)
  3937. }
  3938. if tc.groupID != "" {
  3939. request.SetPathValue("group_id", tc.groupID)
  3940. }
  3941. request.SetPathValue("buddy_screen_name", buddyName)
  3942. responseRecorder := httptest.NewRecorder()
  3943. feedbagManager := newMockFeedbagManager(t)
  3944. sessionRetriever := newMockSessionRetriever(t)
  3945. messageRelayer := newMockMessageRelayer(t)
  3946. buddyBroadcaster := newMockBuddyBroadcaster(t)
  3947. for _, params := range tc.mockParams.feedbagParams {
  3948. feedbagManager.EXPECT().
  3949. Feedbag(matchContext(), params.screenName).
  3950. Return(params.result, params.err)
  3951. }
  3952. for _, params := range tc.mockParams.feedbagUpsertParams {
  3953. feedbagManager.EXPECT().
  3954. FeedbagUpsert(matchContext(), params.screenName, params.items).
  3955. Return(params.err)
  3956. }
  3957. for _, params := range tc.mockParams.retrieveSessionByNameParams {
  3958. sessionRetriever.EXPECT().
  3959. RetrieveSession(params.screenName).
  3960. Return(params.result)
  3961. }
  3962. for _, params := range tc.mockParams.relayToScreenNameParams {
  3963. messageRelayer.EXPECT().
  3964. RelayToScreenName(matchContext(), params.screenName, params.msg)
  3965. }
  3966. for _, params := range tc.mockParams.broadcastVisibilityParams {
  3967. // Use mock.MatchedBy to match any SessionInstance, since we're mainly verifying filter and sendDepartures
  3968. buddyBroadcaster.EXPECT().
  3969. BroadcastVisibility(
  3970. matchContext(),
  3971. mock.AnythingOfType("*state.SessionInstance"),
  3972. params.filter,
  3973. params.sendDepartures,
  3974. ).
  3975. Return(params.err)
  3976. }
  3977. deterministicItemID := func(n int) int {
  3978. return 1000
  3979. }
  3980. putFeedbagBuddyHandler(responseRecorder, request, buddyBroadcaster, feedbagManager, sessionRetriever, messageRelayer, slog.Default(), deterministicItemID)
  3981. assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
  3982. if tc.wantStatusCode == http.StatusOK {
  3983. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  3984. } else {
  3985. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  3986. }
  3987. })
  3988. }
  3989. }
  3990. func TestFeedbagBuddyHandler_DELETE(t *testing.T) {
  3991. tt := []struct {
  3992. name string
  3993. screenName string
  3994. groupID string
  3995. requestBody string
  3996. wantStatusCode int
  3997. wantResponse string
  3998. mockParams mockParams
  3999. }{
  4000. {
  4001. name: "delete existing buddy, user not signed in",
  4002. screenName: "userA",
  4003. groupID: "1",
  4004. requestBody: `{"name":"buddy1"}`,
  4005. wantStatusCode: http.StatusNoContent,
  4006. mockParams: mockParams{
  4007. feedbagManagerParams: feedbagManagerParams{
  4008. feedbagParams: feedbagParams{
  4009. {
  4010. screenName: state.NewIdentScreenName("userA"),
  4011. result: []wire.FeedbagItem{
  4012. {
  4013. ItemID: 1,
  4014. ClassID: wire.FeedbagClassIdGroup,
  4015. Name: "Friends",
  4016. GroupID: 1,
  4017. TLVLBlock: wire.TLVLBlock{
  4018. TLVList: wire.TLVList{
  4019. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{10}),
  4020. },
  4021. },
  4022. },
  4023. {
  4024. ItemID: 10,
  4025. ClassID: wire.FeedbagClassIdBuddy,
  4026. Name: "buddy1",
  4027. GroupID: 1,
  4028. },
  4029. },
  4030. err: nil,
  4031. },
  4032. },
  4033. feedbagUpsertParams: feedbagUpsertParams{
  4034. {
  4035. screenName: state.NewIdentScreenName("userA"),
  4036. items: []wire.FeedbagItem{
  4037. {
  4038. ItemID: 1,
  4039. ClassID: wire.FeedbagClassIdGroup,
  4040. Name: "Friends",
  4041. GroupID: 1,
  4042. TLVLBlock: wire.TLVLBlock{
  4043. TLVList: wire.TLVList{
  4044. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{}),
  4045. },
  4046. },
  4047. },
  4048. },
  4049. err: nil,
  4050. },
  4051. },
  4052. feedbagDeleteParams: feedbagDeleteParams{
  4053. {
  4054. screenName: state.NewIdentScreenName("userA"),
  4055. items: []wire.FeedbagItem{
  4056. {
  4057. ItemID: 10,
  4058. ClassID: wire.FeedbagClassIdBuddy,
  4059. Name: "buddy1",
  4060. GroupID: 1,
  4061. },
  4062. },
  4063. err: nil,
  4064. },
  4065. },
  4066. },
  4067. sessionRetrieverParams: sessionRetrieverParams{
  4068. retrieveSessionByNameParams: retrieveSessionByNameParams{
  4069. {
  4070. screenName: state.NewIdentScreenName("userA"),
  4071. result: state.NewSession(),
  4072. },
  4073. },
  4074. },
  4075. messageRelayerParams: messageRelayerParams{
  4076. relayToScreenNameParams: relayToScreenNameParams{
  4077. {
  4078. screenName: state.NewIdentScreenName("userA"),
  4079. msg: wire.SNACMessage{
  4080. Frame: wire.SNACFrame{
  4081. FoodGroup: wire.Feedbag,
  4082. SubGroup: wire.FeedbagUpdateItem,
  4083. RequestID: wire.ReqIDFromServer,
  4084. },
  4085. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  4086. Items: []wire.FeedbagItem{
  4087. {
  4088. ItemID: 1,
  4089. ClassID: wire.FeedbagClassIdGroup,
  4090. Name: "Friends",
  4091. GroupID: 1,
  4092. TLVLBlock: wire.TLVLBlock{
  4093. TLVList: wire.TLVList{
  4094. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{}),
  4095. },
  4096. },
  4097. },
  4098. },
  4099. },
  4100. },
  4101. },
  4102. {
  4103. screenName: state.NewIdentScreenName("userA"),
  4104. msg: wire.SNACMessage{
  4105. Frame: wire.SNACFrame{
  4106. FoodGroup: wire.Feedbag,
  4107. SubGroup: wire.FeedbagDeleteItem,
  4108. RequestID: wire.ReqIDFromServer,
  4109. },
  4110. Body: wire.SNAC_0x13_0x0A_FeedbagDeleteItem{
  4111. Items: []wire.FeedbagItem{
  4112. {
  4113. ItemID: 10,
  4114. ClassID: wire.FeedbagClassIdBuddy,
  4115. Name: "buddy1",
  4116. GroupID: 1,
  4117. },
  4118. },
  4119. },
  4120. },
  4121. },
  4122. },
  4123. },
  4124. },
  4125. },
  4126. {
  4127. name: "delete existing buddy, user signed in",
  4128. screenName: "userA",
  4129. groupID: "1",
  4130. requestBody: `{"name":"buddy1"}`,
  4131. wantStatusCode: http.StatusNoContent,
  4132. mockParams: mockParams{
  4133. feedbagManagerParams: feedbagManagerParams{
  4134. feedbagParams: feedbagParams{
  4135. {
  4136. screenName: state.NewIdentScreenName("userA"),
  4137. result: []wire.FeedbagItem{
  4138. {
  4139. ItemID: 1,
  4140. ClassID: wire.FeedbagClassIdGroup,
  4141. Name: "Friends",
  4142. GroupID: 1,
  4143. TLVLBlock: wire.TLVLBlock{
  4144. TLVList: wire.TLVList{
  4145. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{10}),
  4146. },
  4147. },
  4148. },
  4149. {
  4150. ItemID: 10,
  4151. ClassID: wire.FeedbagClassIdBuddy,
  4152. Name: "buddy1",
  4153. GroupID: 1,
  4154. },
  4155. },
  4156. err: nil,
  4157. },
  4158. },
  4159. feedbagUpsertParams: feedbagUpsertParams{
  4160. {
  4161. screenName: state.NewIdentScreenName("userA"),
  4162. items: []wire.FeedbagItem{
  4163. {
  4164. ItemID: 1,
  4165. ClassID: wire.FeedbagClassIdGroup,
  4166. Name: "Friends",
  4167. GroupID: 1,
  4168. TLVLBlock: wire.TLVLBlock{
  4169. TLVList: wire.TLVList{
  4170. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{}),
  4171. },
  4172. },
  4173. },
  4174. },
  4175. err: nil,
  4176. },
  4177. },
  4178. feedbagDeleteParams: feedbagDeleteParams{
  4179. {
  4180. screenName: state.NewIdentScreenName("userA"),
  4181. items: []wire.FeedbagItem{
  4182. {
  4183. ItemID: 10,
  4184. ClassID: wire.FeedbagClassIdBuddy,
  4185. Name: "buddy1",
  4186. GroupID: 1,
  4187. },
  4188. },
  4189. err: nil,
  4190. },
  4191. },
  4192. },
  4193. sessionRetrieverParams: sessionRetrieverParams{
  4194. retrieveSessionByNameParams: retrieveSessionByNameParams{
  4195. {
  4196. screenName: state.NewIdentScreenName("userA"),
  4197. result: func() *state.Session {
  4198. sess := state.NewSession()
  4199. sess.SetIdentScreenName(state.NewIdentScreenName("userA"))
  4200. inst := sess.AddInstance()
  4201. inst.SetSignonComplete()
  4202. return sess
  4203. }(),
  4204. },
  4205. },
  4206. },
  4207. messageRelayerParams: messageRelayerParams{
  4208. relayToScreenNameParams: relayToScreenNameParams{
  4209. {
  4210. screenName: state.NewIdentScreenName("userA"),
  4211. msg: wire.SNACMessage{
  4212. Frame: wire.SNACFrame{
  4213. FoodGroup: wire.Feedbag,
  4214. SubGroup: wire.FeedbagUpdateItem,
  4215. RequestID: wire.ReqIDFromServer,
  4216. },
  4217. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  4218. Items: []wire.FeedbagItem{
  4219. {
  4220. ItemID: 1,
  4221. ClassID: wire.FeedbagClassIdGroup,
  4222. Name: "Friends",
  4223. GroupID: 1,
  4224. TLVLBlock: wire.TLVLBlock{
  4225. TLVList: wire.TLVList{
  4226. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{}),
  4227. },
  4228. },
  4229. },
  4230. },
  4231. },
  4232. },
  4233. },
  4234. {
  4235. screenName: state.NewIdentScreenName("userA"),
  4236. msg: wire.SNACMessage{
  4237. Frame: wire.SNACFrame{
  4238. FoodGroup: wire.Feedbag,
  4239. SubGroup: wire.FeedbagDeleteItem,
  4240. RequestID: wire.ReqIDFromServer,
  4241. },
  4242. Body: wire.SNAC_0x13_0x0A_FeedbagDeleteItem{
  4243. Items: []wire.FeedbagItem{
  4244. {
  4245. ItemID: 10,
  4246. ClassID: wire.FeedbagClassIdBuddy,
  4247. Name: "buddy1",
  4248. GroupID: 1,
  4249. },
  4250. },
  4251. },
  4252. },
  4253. },
  4254. },
  4255. },
  4256. buddyBroadcasterParams: buddyBroadcasterParams{
  4257. broadcastVisibilityParams: broadcastVisibilityParams{
  4258. {
  4259. you: nil, // Not used in expectation, matched with mock.AnythingOfType
  4260. filter: []state.IdentScreenName{state.NewIdentScreenName("buddy1")},
  4261. sendDepartures: true,
  4262. err: nil,
  4263. },
  4264. },
  4265. },
  4266. },
  4267. },
  4268. {
  4269. name: "delete buddy from a group with multiple buddies, user not signed in",
  4270. screenName: "userA",
  4271. groupID: "1",
  4272. requestBody: `{"name":"buddy1"}`,
  4273. wantStatusCode: http.StatusNoContent,
  4274. mockParams: mockParams{
  4275. feedbagManagerParams: feedbagManagerParams{
  4276. feedbagParams: feedbagParams{
  4277. {
  4278. screenName: state.NewIdentScreenName("userA"),
  4279. result: []wire.FeedbagItem{
  4280. {
  4281. ItemID: 1,
  4282. ClassID: wire.FeedbagClassIdGroup,
  4283. Name: "Friends",
  4284. GroupID: 1,
  4285. TLVLBlock: wire.TLVLBlock{
  4286. TLVList: wire.TLVList{
  4287. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{10, 20}),
  4288. },
  4289. },
  4290. },
  4291. {
  4292. ItemID: 10,
  4293. ClassID: wire.FeedbagClassIdBuddy,
  4294. Name: "buddy1",
  4295. GroupID: 1,
  4296. },
  4297. {
  4298. ItemID: 20,
  4299. ClassID: wire.FeedbagClassIdBuddy,
  4300. Name: "buddy2",
  4301. GroupID: 1,
  4302. },
  4303. },
  4304. err: nil,
  4305. },
  4306. },
  4307. feedbagUpsertParams: feedbagUpsertParams{
  4308. {
  4309. screenName: state.NewIdentScreenName("userA"),
  4310. items: []wire.FeedbagItem{
  4311. {
  4312. ItemID: 1,
  4313. ClassID: wire.FeedbagClassIdGroup,
  4314. Name: "Friends",
  4315. GroupID: 1,
  4316. TLVLBlock: wire.TLVLBlock{
  4317. TLVList: wire.TLVList{
  4318. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{20}),
  4319. },
  4320. },
  4321. },
  4322. },
  4323. err: nil,
  4324. },
  4325. },
  4326. feedbagDeleteParams: feedbagDeleteParams{
  4327. {
  4328. screenName: state.NewIdentScreenName("userA"),
  4329. items: []wire.FeedbagItem{
  4330. {
  4331. ItemID: 10,
  4332. ClassID: wire.FeedbagClassIdBuddy,
  4333. Name: "buddy1",
  4334. GroupID: 1,
  4335. },
  4336. },
  4337. err: nil,
  4338. },
  4339. },
  4340. },
  4341. sessionRetrieverParams: sessionRetrieverParams{
  4342. retrieveSessionByNameParams: retrieveSessionByNameParams{
  4343. {
  4344. screenName: state.NewIdentScreenName("userA"),
  4345. result: state.NewSession(),
  4346. },
  4347. },
  4348. },
  4349. messageRelayerParams: messageRelayerParams{
  4350. relayToScreenNameParams: relayToScreenNameParams{
  4351. {
  4352. screenName: state.NewIdentScreenName("userA"),
  4353. msg: wire.SNACMessage{
  4354. Frame: wire.SNACFrame{
  4355. FoodGroup: wire.Feedbag,
  4356. SubGroup: wire.FeedbagUpdateItem,
  4357. RequestID: wire.ReqIDFromServer,
  4358. },
  4359. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  4360. Items: []wire.FeedbagItem{
  4361. {
  4362. ItemID: 1,
  4363. ClassID: wire.FeedbagClassIdGroup,
  4364. Name: "Friends",
  4365. GroupID: 1,
  4366. TLVLBlock: wire.TLVLBlock{
  4367. TLVList: wire.TLVList{
  4368. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{20}),
  4369. },
  4370. },
  4371. },
  4372. },
  4373. },
  4374. },
  4375. },
  4376. {
  4377. screenName: state.NewIdentScreenName("userA"),
  4378. msg: wire.SNACMessage{
  4379. Frame: wire.SNACFrame{
  4380. FoodGroup: wire.Feedbag,
  4381. SubGroup: wire.FeedbagDeleteItem,
  4382. RequestID: wire.ReqIDFromServer,
  4383. },
  4384. Body: wire.SNAC_0x13_0x0A_FeedbagDeleteItem{
  4385. Items: []wire.FeedbagItem{
  4386. {
  4387. ItemID: 10,
  4388. ClassID: wire.FeedbagClassIdBuddy,
  4389. Name: "buddy1",
  4390. GroupID: 1,
  4391. },
  4392. },
  4393. },
  4394. },
  4395. },
  4396. },
  4397. },
  4398. },
  4399. },
  4400. {
  4401. name: "can't delete buddy from root group",
  4402. screenName: "userA",
  4403. groupID: "0",
  4404. requestBody: `{"name":"rootbuddy"}`,
  4405. wantStatusCode: http.StatusBadRequest,
  4406. wantResponse: `{"message":"can't add buddies to root group"}`,
  4407. },
  4408. {
  4409. name: "missing screen_name",
  4410. screenName: "",
  4411. groupID: "1",
  4412. requestBody: `{"name":"buddy"}`,
  4413. wantStatusCode: http.StatusBadRequest,
  4414. wantResponse: `{"message":"screen_name is required"}`,
  4415. },
  4416. {
  4417. name: "group not found",
  4418. screenName: "userA",
  4419. groupID: "999",
  4420. requestBody: `{"name":"buddy"}`,
  4421. wantStatusCode: http.StatusNotFound,
  4422. wantResponse: `{"message":"group not found"}`,
  4423. mockParams: mockParams{
  4424. feedbagManagerParams: feedbagManagerParams{
  4425. feedbagParams: feedbagParams{
  4426. {
  4427. screenName: state.NewIdentScreenName("userA"),
  4428. result: []wire.FeedbagItem{
  4429. {
  4430. ItemID: 1,
  4431. ClassID: wire.FeedbagClassIdGroup,
  4432. Name: "Friends",
  4433. GroupID: 0,
  4434. },
  4435. },
  4436. err: nil,
  4437. },
  4438. },
  4439. },
  4440. },
  4441. },
  4442. {
  4443. name: "invalid group_id",
  4444. screenName: "userA",
  4445. groupID: "invalid",
  4446. requestBody: `{"name":"buddy"}`,
  4447. wantStatusCode: http.StatusBadRequest,
  4448. wantResponse: `{"message":"invalid group_id"}`,
  4449. },
  4450. {
  4451. name: "malformed request body",
  4452. screenName: "userA",
  4453. groupID: "1",
  4454. requestBody: `invalid json`,
  4455. wantStatusCode: http.StatusBadRequest,
  4456. wantResponse: `{"message":"buddy_screen_name is required"}`,
  4457. },
  4458. {
  4459. name: "missing name in request body",
  4460. screenName: "userA",
  4461. groupID: "1",
  4462. requestBody: `{}`,
  4463. wantStatusCode: http.StatusBadRequest,
  4464. wantResponse: `{"message":"buddy_screen_name is required"}`,
  4465. },
  4466. {
  4467. name: "buddy not found",
  4468. screenName: "userA",
  4469. groupID: "1",
  4470. requestBody: `{"name":"nonexistent"}`,
  4471. wantStatusCode: http.StatusNotFound,
  4472. wantResponse: `{"message":"buddy not found"}`,
  4473. mockParams: mockParams{
  4474. feedbagManagerParams: feedbagManagerParams{
  4475. feedbagParams: feedbagParams{
  4476. {
  4477. screenName: state.NewIdentScreenName("userA"),
  4478. result: []wire.FeedbagItem{
  4479. {
  4480. ItemID: 1,
  4481. ClassID: wire.FeedbagClassIdGroup,
  4482. Name: "Friends",
  4483. GroupID: 1,
  4484. },
  4485. {
  4486. ItemID: 10,
  4487. ClassID: wire.FeedbagClassIdBuddy,
  4488. Name: "otherbuddy",
  4489. GroupID: 1,
  4490. },
  4491. },
  4492. err: nil,
  4493. },
  4494. },
  4495. },
  4496. },
  4497. },
  4498. {
  4499. name: "internal server error on feedbag retrieval",
  4500. screenName: "userA",
  4501. groupID: "1",
  4502. requestBody: `{"name":"buddy"}`,
  4503. wantStatusCode: http.StatusInternalServerError,
  4504. wantResponse: `{"message":"internal server error"}`,
  4505. mockParams: mockParams{
  4506. feedbagManagerParams: feedbagManagerParams{
  4507. feedbagParams: feedbagParams{
  4508. {
  4509. screenName: state.NewIdentScreenName("userA"),
  4510. result: nil,
  4511. err: errors.New("database error"),
  4512. },
  4513. },
  4514. },
  4515. },
  4516. },
  4517. {
  4518. name: "internal server error on group order upsert",
  4519. screenName: "userA",
  4520. groupID: "1",
  4521. requestBody: `{"name":"buddy1"}`,
  4522. wantStatusCode: http.StatusInternalServerError,
  4523. wantResponse: `{"message":"internal server error"}`,
  4524. mockParams: mockParams{
  4525. feedbagManagerParams: feedbagManagerParams{
  4526. feedbagParams: feedbagParams{
  4527. {
  4528. screenName: state.NewIdentScreenName("userA"),
  4529. result: []wire.FeedbagItem{
  4530. {
  4531. ItemID: 1,
  4532. ClassID: wire.FeedbagClassIdGroup,
  4533. Name: "Friends",
  4534. GroupID: 1,
  4535. TLVLBlock: wire.TLVLBlock{
  4536. TLVList: wire.TLVList{
  4537. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{10}),
  4538. },
  4539. },
  4540. },
  4541. {
  4542. ItemID: 10,
  4543. ClassID: wire.FeedbagClassIdBuddy,
  4544. Name: "buddy1",
  4545. GroupID: 1,
  4546. },
  4547. },
  4548. err: nil,
  4549. },
  4550. },
  4551. feedbagUpsertParams: feedbagUpsertParams{
  4552. {
  4553. screenName: state.NewIdentScreenName("userA"),
  4554. items: []wire.FeedbagItem{
  4555. {
  4556. ItemID: 1,
  4557. ClassID: wire.FeedbagClassIdGroup,
  4558. Name: "Friends",
  4559. GroupID: 1,
  4560. TLVLBlock: wire.TLVLBlock{
  4561. TLVList: wire.TLVList{
  4562. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{}),
  4563. },
  4564. },
  4565. },
  4566. },
  4567. err: errors.New("database error"),
  4568. },
  4569. },
  4570. },
  4571. },
  4572. },
  4573. {
  4574. name: "internal server error on delete",
  4575. screenName: "userA",
  4576. groupID: "1",
  4577. requestBody: `{"name":"buddy1"}`,
  4578. wantStatusCode: http.StatusInternalServerError,
  4579. wantResponse: `{"message":"internal server error"}`,
  4580. mockParams: mockParams{
  4581. feedbagManagerParams: feedbagManagerParams{
  4582. feedbagParams: feedbagParams{
  4583. {
  4584. screenName: state.NewIdentScreenName("userA"),
  4585. result: []wire.FeedbagItem{
  4586. {
  4587. ItemID: 1,
  4588. ClassID: wire.FeedbagClassIdGroup,
  4589. Name: "Friends",
  4590. GroupID: 1,
  4591. TLVLBlock: wire.TLVLBlock{
  4592. TLVList: wire.TLVList{
  4593. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{10}),
  4594. },
  4595. },
  4596. },
  4597. {
  4598. ItemID: 10,
  4599. ClassID: wire.FeedbagClassIdBuddy,
  4600. Name: "buddy1",
  4601. GroupID: 1,
  4602. },
  4603. },
  4604. err: nil,
  4605. },
  4606. },
  4607. feedbagUpsertParams: feedbagUpsertParams{
  4608. {
  4609. screenName: state.NewIdentScreenName("userA"),
  4610. items: []wire.FeedbagItem{
  4611. {
  4612. ItemID: 1,
  4613. ClassID: wire.FeedbagClassIdGroup,
  4614. Name: "Friends",
  4615. GroupID: 1,
  4616. TLVLBlock: wire.TLVLBlock{
  4617. TLVList: wire.TLVList{
  4618. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{}),
  4619. },
  4620. },
  4621. },
  4622. },
  4623. err: nil,
  4624. },
  4625. },
  4626. feedbagDeleteParams: feedbagDeleteParams{
  4627. {
  4628. screenName: state.NewIdentScreenName("userA"),
  4629. items: []wire.FeedbagItem{
  4630. {
  4631. ItemID: 10,
  4632. ClassID: wire.FeedbagClassIdBuddy,
  4633. Name: "buddy1",
  4634. GroupID: 1,
  4635. },
  4636. },
  4637. err: errors.New("database error"),
  4638. },
  4639. },
  4640. },
  4641. },
  4642. },
  4643. }
  4644. for _, tc := range tt {
  4645. t.Run(tc.name, func(t *testing.T) {
  4646. // Extract buddy name from requestBody JSON
  4647. var buddyName string
  4648. if tc.requestBody != "" {
  4649. var input struct {
  4650. Name string `json:"name"`
  4651. }
  4652. if err := json.Unmarshal([]byte(tc.requestBody), &input); err == nil {
  4653. buddyName = input.Name
  4654. }
  4655. }
  4656. request := httptest.NewRequest(http.MethodDelete, "/feedbag/"+tc.screenName+"/group/"+tc.groupID+"/buddy/"+buddyName, nil)
  4657. if tc.screenName != "" {
  4658. request.SetPathValue("screen_name", tc.screenName)
  4659. }
  4660. if tc.groupID != "" {
  4661. request.SetPathValue("group_id", tc.groupID)
  4662. }
  4663. request.SetPathValue("buddy_screen_name", buddyName)
  4664. responseRecorder := httptest.NewRecorder()
  4665. feedbagManager := newMockFeedbagManager(t)
  4666. sessionRetriever := newMockSessionRetriever(t)
  4667. messageRelayer := newMockMessageRelayer(t)
  4668. buddyBroadcaster := newMockBuddyBroadcaster(t)
  4669. for _, params := range tc.mockParams.feedbagParams {
  4670. feedbagManager.EXPECT().
  4671. Feedbag(matchContext(), params.screenName).
  4672. Return(params.result, params.err)
  4673. }
  4674. for _, params := range tc.mockParams.feedbagUpsertParams {
  4675. feedbagManager.EXPECT().
  4676. FeedbagUpsert(matchContext(), params.screenName, params.items).
  4677. Return(params.err)
  4678. }
  4679. for _, params := range tc.mockParams.feedbagDeleteParams {
  4680. feedbagManager.EXPECT().
  4681. FeedbagDelete(matchContext(), params.screenName, params.items).
  4682. Return(params.err)
  4683. }
  4684. for _, params := range tc.mockParams.retrieveSessionByNameParams {
  4685. sessionRetriever.EXPECT().
  4686. RetrieveSession(params.screenName).
  4687. Return(params.result)
  4688. }
  4689. for _, params := range tc.mockParams.relayToScreenNameParams {
  4690. messageRelayer.EXPECT().
  4691. RelayToScreenName(matchContext(), params.screenName, params.msg)
  4692. }
  4693. for _, params := range tc.mockParams.broadcastVisibilityParams {
  4694. buddyBroadcaster.EXPECT().
  4695. BroadcastVisibility(
  4696. matchContext(),
  4697. mock.AnythingOfType("*state.SessionInstance"),
  4698. params.filter,
  4699. params.sendDepartures,
  4700. ).
  4701. Return(params.err)
  4702. }
  4703. deleteFeedbagBuddyHandler(responseRecorder, request, buddyBroadcaster, feedbagManager, sessionRetriever, messageRelayer, slog.Default())
  4704. assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
  4705. if tc.wantResponse != "" {
  4706. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  4707. }
  4708. })
  4709. }
  4710. }
  4711. func TestRandItemID(t *testing.T) {
  4712. tt := []struct {
  4713. name string
  4714. randInt func(n int) int
  4715. items []wire.FeedbagItem
  4716. want uint16
  4717. description string
  4718. }{
  4719. {
  4720. name: "empty items list returns random ID",
  4721. randInt: func(n int) int {
  4722. return 1000
  4723. },
  4724. items: []wire.FeedbagItem{},
  4725. want: 1000,
  4726. description: "When no items exist, should return the random number generated",
  4727. },
  4728. {
  4729. name: "finds next available ID when starting ID conflicts with ItemID",
  4730. randInt: func(n int) int {
  4731. return 100
  4732. },
  4733. items: []wire.FeedbagItem{
  4734. {ItemID: 100, GroupID: 1},
  4735. {ItemID: 101, GroupID: 1},
  4736. },
  4737. want: 102,
  4738. description: "Should skip 100 and 101, return 102",
  4739. },
  4740. {
  4741. name: "finds next available ID when starting ID conflicts with GroupID",
  4742. randInt: func(n int) int {
  4743. return 50
  4744. },
  4745. items: []wire.FeedbagItem{
  4746. {ItemID: 1, GroupID: 50},
  4747. {ItemID: 2, GroupID: 51},
  4748. },
  4749. want: 52,
  4750. description: "Should skip 50 (GroupID) and 51 (GroupID), return 52",
  4751. },
  4752. {
  4753. name: "wraps around and skips 0 to find next available ID",
  4754. randInt: func(n int) int {
  4755. return math.MaxUint16 - 2
  4756. },
  4757. items: []wire.FeedbagItem{
  4758. {ItemID: math.MaxUint16 - 2, GroupID: 1},
  4759. {ItemID: math.MaxUint16 - 1, GroupID: 1},
  4760. {ItemID: math.MaxUint16, GroupID: 1},
  4761. },
  4762. want: 2,
  4763. description: "When wrapping around, skips 0 (always skipped) and 1 (if conflicts), returns 2",
  4764. },
  4765. {
  4766. name: "skips 0 when starting from 0 and finds next available",
  4767. randInt: func(n int) int {
  4768. return 0
  4769. },
  4770. items: []wire.FeedbagItem{},
  4771. want: 1,
  4772. description: "When starting from 0, skips 0 (always skipped) and returns 1",
  4773. },
  4774. {
  4775. name: "returns 0 when all IDs are taken",
  4776. randInt: func(n int) int {
  4777. return 100
  4778. },
  4779. items: func() []wire.FeedbagItem {
  4780. // Create items that cover all possible IDs
  4781. items := make([]wire.FeedbagItem, 0, math.MaxUint16+1)
  4782. for i := 0; i <= math.MaxUint16; i++ {
  4783. items = append(items, wire.FeedbagItem{
  4784. ItemID: uint16(i),
  4785. GroupID: uint16(i),
  4786. })
  4787. }
  4788. return items
  4789. }(),
  4790. want: 0,
  4791. description: "When all IDs are taken, should return 0",
  4792. },
  4793. {
  4794. name: "finds ID that conflicts with both ItemID and GroupID",
  4795. randInt: func(n int) int {
  4796. return 200
  4797. },
  4798. items: []wire.FeedbagItem{
  4799. {ItemID: 200, GroupID: 201},
  4800. {ItemID: 201, GroupID: 200},
  4801. },
  4802. want: 202,
  4803. description: "Should skip 200 (ItemID) and 201 (both ItemID and GroupID), return 202",
  4804. },
  4805. {
  4806. name: "finds available ID immediately when no conflicts",
  4807. randInt: func(n int) int {
  4808. return 500
  4809. },
  4810. items: []wire.FeedbagItem{
  4811. {ItemID: 100, GroupID: 1},
  4812. {ItemID: 200, GroupID: 2},
  4813. {ItemID: 300, GroupID: 3},
  4814. },
  4815. want: 500,
  4816. description: "When random ID has no conflicts, should return it immediately",
  4817. },
  4818. {
  4819. name: "handles single conflict and finds next",
  4820. randInt: func(n int) int {
  4821. return 42
  4822. },
  4823. items: []wire.FeedbagItem{
  4824. {ItemID: 42, GroupID: 1},
  4825. },
  4826. want: 43,
  4827. description: "Should skip 42 and return 43",
  4828. },
  4829. {
  4830. name: "finds ID before starting point when wrapping",
  4831. randInt: func(n int) int {
  4832. return 5
  4833. },
  4834. items: []wire.FeedbagItem{
  4835. {ItemID: 5, GroupID: 1},
  4836. {ItemID: 6, GroupID: 1},
  4837. {ItemID: 7, GroupID: 1},
  4838. },
  4839. want: 8,
  4840. description: "Should skip 5, 6, 7 and return 8",
  4841. },
  4842. }
  4843. for _, tc := range tt {
  4844. t.Run(tc.name, func(t *testing.T) {
  4845. got := randItemID(tc.randInt, tc.items)
  4846. if got != tc.want {
  4847. t.Errorf("randItemID() = %d, want %d. %s", got, tc.want, tc.description)
  4848. }
  4849. })
  4850. }
  4851. }
  4852. func TestGetLinkedAccountsHandler(t *testing.T) {
  4853. tt := []struct {
  4854. name string
  4855. screenname string
  4856. statusCode int
  4857. want string
  4858. mockParams mockParams
  4859. }{
  4860. {
  4861. name: "user not found returns 404",
  4862. screenname: "nobody",
  4863. statusCode: http.StatusNotFound,
  4864. want: `{"message":"user not found"}`,
  4865. mockParams: mockParams{
  4866. userManagerParams: userManagerParams{
  4867. getUserParams: getUserParams{
  4868. {
  4869. screenName: state.NewIdentScreenName("nobody"),
  4870. result: nil,
  4871. },
  4872. },
  4873. },
  4874. },
  4875. },
  4876. {
  4877. name: "returns empty linked accounts list",
  4878. screenname: "test1",
  4879. statusCode: http.StatusOK,
  4880. want: `{"linked_accounts":[]}`,
  4881. mockParams: mockParams{
  4882. userManagerParams: userManagerParams{
  4883. getUserParams: getUserParams{
  4884. {
  4885. screenName: state.NewIdentScreenName("test1"),
  4886. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  4887. },
  4888. },
  4889. },
  4890. linkedAccountManagerParams: linkedAccountManagerParams{
  4891. linkedAccountsParams: linkedAccountsParams{
  4892. {
  4893. screenName: state.NewIdentScreenName("test1"),
  4894. result: []state.IdentScreenName{},
  4895. },
  4896. },
  4897. },
  4898. },
  4899. },
  4900. {
  4901. name: "returns linked accounts",
  4902. screenname: "test1",
  4903. statusCode: http.StatusOK,
  4904. want: `{"linked_accounts":["test2","test3"]}`,
  4905. mockParams: mockParams{
  4906. userManagerParams: userManagerParams{
  4907. getUserParams: getUserParams{
  4908. {
  4909. screenName: state.NewIdentScreenName("test1"),
  4910. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  4911. },
  4912. },
  4913. },
  4914. linkedAccountManagerParams: linkedAccountManagerParams{
  4915. linkedAccountsParams: linkedAccountsParams{
  4916. {
  4917. screenName: state.NewIdentScreenName("test1"),
  4918. result: []state.IdentScreenName{
  4919. state.NewIdentScreenName("test2"),
  4920. state.NewIdentScreenName("test3"),
  4921. },
  4922. },
  4923. },
  4924. },
  4925. },
  4926. },
  4927. {
  4928. name: "linkedAccountManager error returns 500",
  4929. screenname: "test1",
  4930. statusCode: http.StatusInternalServerError,
  4931. want: `{"message":"internal server error"}`,
  4932. mockParams: mockParams{
  4933. userManagerParams: userManagerParams{
  4934. getUserParams: getUserParams{
  4935. {
  4936. screenName: state.NewIdentScreenName("test1"),
  4937. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  4938. },
  4939. },
  4940. },
  4941. linkedAccountManagerParams: linkedAccountManagerParams{
  4942. linkedAccountsParams: linkedAccountsParams{
  4943. {
  4944. screenName: state.NewIdentScreenName("test1"),
  4945. err: io.EOF,
  4946. },
  4947. },
  4948. },
  4949. },
  4950. },
  4951. }
  4952. for _, tc := range tt {
  4953. t.Run(tc.name, func(t *testing.T) {
  4954. request := httptest.NewRequest(http.MethodGet, "/user/"+tc.screenname+"/linked-account", nil)
  4955. request.SetPathValue("screenname", tc.screenname)
  4956. responseRecorder := httptest.NewRecorder()
  4957. userManager := newMockUserManager(t)
  4958. for _, params := range tc.mockParams.getUserParams {
  4959. userManager.EXPECT().
  4960. User(matchContext(), params.screenName).
  4961. Return(params.result, params.err)
  4962. }
  4963. linkedAccountManager := newMockLinkedAccountManager(t)
  4964. for _, params := range tc.mockParams.linkedAccountsParams {
  4965. linkedAccountManager.EXPECT().
  4966. LinkedAccounts(matchContext(), params.screenName).
  4967. Return(params.result, params.err)
  4968. }
  4969. getLinkedAccountsHandler(responseRecorder, request, userManager, linkedAccountManager)
  4970. assert.Equal(t, tc.statusCode, responseRecorder.Code)
  4971. assert.Equal(t, tc.want, strings.TrimSpace(responseRecorder.Body.String()))
  4972. })
  4973. }
  4974. }
  4975. func TestPostLinkedAccountHandler(t *testing.T) {
  4976. tt := []struct {
  4977. name string
  4978. screenname string
  4979. body string
  4980. statusCode int
  4981. want string
  4982. mockParams mockParams
  4983. }{
  4984. {
  4985. name: "primary user not found returns 404",
  4986. screenname: "nobody",
  4987. body: `{"linked_screen_name":"test2"}`,
  4988. statusCode: http.StatusNotFound,
  4989. want: `{"message":"user not found"}`,
  4990. mockParams: mockParams{
  4991. userManagerParams: userManagerParams{
  4992. getUserParams: getUserParams{
  4993. {
  4994. screenName: state.NewIdentScreenName("nobody"),
  4995. result: nil,
  4996. },
  4997. },
  4998. },
  4999. },
  5000. },
  5001. {
  5002. name: "invalid request body returns 400",
  5003. screenname: "test1",
  5004. body: `not json`,
  5005. statusCode: http.StatusBadRequest,
  5006. want: `{"message":"invalid request body"}`,
  5007. mockParams: mockParams{
  5008. userManagerParams: userManagerParams{
  5009. getUserParams: getUserParams{
  5010. {
  5011. screenName: state.NewIdentScreenName("test1"),
  5012. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5013. },
  5014. },
  5015. },
  5016. },
  5017. },
  5018. {
  5019. name: "missing linked_screen_name returns 400",
  5020. screenname: "test1",
  5021. body: `{}`,
  5022. statusCode: http.StatusBadRequest,
  5023. want: `{"message":"invalid request body"}`,
  5024. mockParams: mockParams{
  5025. userManagerParams: userManagerParams{
  5026. getUserParams: getUserParams{
  5027. {
  5028. screenName: state.NewIdentScreenName("test1"),
  5029. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5030. },
  5031. },
  5032. },
  5033. },
  5034. },
  5035. {
  5036. name: "self-link returns 400",
  5037. screenname: "test1",
  5038. body: `{"linked_screen_name":"test1"}`,
  5039. statusCode: http.StatusBadRequest,
  5040. want: `{"message":"cannot link an account to itself"}`,
  5041. mockParams: mockParams{
  5042. userManagerParams: userManagerParams{
  5043. getUserParams: getUserParams{
  5044. {
  5045. screenName: state.NewIdentScreenName("test1"),
  5046. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5047. },
  5048. },
  5049. },
  5050. },
  5051. },
  5052. {
  5053. name: "linked user not found returns 404",
  5054. screenname: "test1",
  5055. body: `{"linked_screen_name":"nobody"}`,
  5056. statusCode: http.StatusNotFound,
  5057. want: `{"message":"linked user not found"}`,
  5058. mockParams: mockParams{
  5059. userManagerParams: userManagerParams{
  5060. getUserParams: getUserParams{
  5061. {
  5062. screenName: state.NewIdentScreenName("test1"),
  5063. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5064. },
  5065. {
  5066. screenName: state.NewIdentScreenName("nobody"),
  5067. result: nil,
  5068. },
  5069. },
  5070. },
  5071. },
  5072. },
  5073. {
  5074. name: "duplicate link returns 409",
  5075. screenname: "test1",
  5076. body: `{"linked_screen_name":"test2"}`,
  5077. statusCode: http.StatusConflict,
  5078. want: `{"message":"linked account already exists"}`,
  5079. mockParams: mockParams{
  5080. userManagerParams: userManagerParams{
  5081. getUserParams: getUserParams{
  5082. {
  5083. screenName: state.NewIdentScreenName("test1"),
  5084. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5085. },
  5086. {
  5087. screenName: state.NewIdentScreenName("test2"),
  5088. result: &state.User{IdentScreenName: state.NewIdentScreenName("test2")},
  5089. },
  5090. },
  5091. },
  5092. linkedAccountManagerParams: linkedAccountManagerParams{
  5093. insertLinkedAccountParams: insertLinkedAccountParams{
  5094. {
  5095. screenName: state.NewIdentScreenName("test1"),
  5096. linkedScreenName: state.NewIdentScreenName("test2"),
  5097. err: state.ErrLinkExists,
  5098. },
  5099. },
  5100. },
  5101. },
  5102. },
  5103. {
  5104. name: "insert error returns 500",
  5105. screenname: "test1",
  5106. body: `{"linked_screen_name":"test2"}`,
  5107. statusCode: http.StatusInternalServerError,
  5108. want: `{"message":"internal server error"}`,
  5109. mockParams: mockParams{
  5110. userManagerParams: userManagerParams{
  5111. getUserParams: getUserParams{
  5112. {
  5113. screenName: state.NewIdentScreenName("test1"),
  5114. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5115. },
  5116. {
  5117. screenName: state.NewIdentScreenName("test2"),
  5118. result: &state.User{IdentScreenName: state.NewIdentScreenName("test2")},
  5119. },
  5120. },
  5121. },
  5122. linkedAccountManagerParams: linkedAccountManagerParams{
  5123. insertLinkedAccountParams: insertLinkedAccountParams{
  5124. {
  5125. screenName: state.NewIdentScreenName("test1"),
  5126. linkedScreenName: state.NewIdentScreenName("test2"),
  5127. err: io.EOF,
  5128. },
  5129. },
  5130. },
  5131. },
  5132. },
  5133. {
  5134. name: "link created returns 201",
  5135. screenname: "test1",
  5136. body: `{"linked_screen_name":"test2"}`,
  5137. statusCode: http.StatusCreated,
  5138. want: ``,
  5139. mockParams: mockParams{
  5140. userManagerParams: userManagerParams{
  5141. getUserParams: getUserParams{
  5142. {
  5143. screenName: state.NewIdentScreenName("test1"),
  5144. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5145. },
  5146. {
  5147. screenName: state.NewIdentScreenName("test2"),
  5148. result: &state.User{IdentScreenName: state.NewIdentScreenName("test2")},
  5149. },
  5150. },
  5151. },
  5152. linkedAccountManagerParams: linkedAccountManagerParams{
  5153. insertLinkedAccountParams: insertLinkedAccountParams{
  5154. {
  5155. screenName: state.NewIdentScreenName("test1"),
  5156. linkedScreenName: state.NewIdentScreenName("test2"),
  5157. },
  5158. },
  5159. },
  5160. },
  5161. },
  5162. }
  5163. for _, tc := range tt {
  5164. t.Run(tc.name, func(t *testing.T) {
  5165. request := httptest.NewRequest(http.MethodPost, "/user/"+tc.screenname+"/linked-account", strings.NewReader(tc.body))
  5166. request.SetPathValue("screenname", tc.screenname)
  5167. responseRecorder := httptest.NewRecorder()
  5168. userManager := newMockUserManager(t)
  5169. for _, params := range tc.mockParams.getUserParams {
  5170. userManager.EXPECT().
  5171. User(matchContext(), params.screenName).
  5172. Return(params.result, params.err)
  5173. }
  5174. linkedAccountManager := newMockLinkedAccountManager(t)
  5175. for _, params := range tc.mockParams.insertLinkedAccountParams {
  5176. linkedAccountManager.EXPECT().
  5177. InsertLinkedAccount(matchContext(), params.screenName, params.linkedScreenName).
  5178. Return(params.err)
  5179. }
  5180. postLinkedAccountHandler(responseRecorder, request, userManager, linkedAccountManager)
  5181. assert.Equal(t, tc.statusCode, responseRecorder.Code)
  5182. assert.Equal(t, tc.want, strings.TrimSpace(responseRecorder.Body.String()))
  5183. })
  5184. }
  5185. }
  5186. func TestDeleteAllLinkedAccountsHandler(t *testing.T) {
  5187. tt := []struct {
  5188. name string
  5189. screenname string
  5190. statusCode int
  5191. want string
  5192. mockParams mockParams
  5193. }{
  5194. {
  5195. name: "user not found returns 404",
  5196. screenname: "nobody",
  5197. statusCode: http.StatusNotFound,
  5198. want: `{"message":"user not found"}`,
  5199. mockParams: mockParams{
  5200. userManagerParams: userManagerParams{
  5201. getUserParams: getUserParams{
  5202. {
  5203. screenName: state.NewIdentScreenName("nobody"),
  5204. result: nil,
  5205. },
  5206. },
  5207. },
  5208. },
  5209. },
  5210. {
  5211. name: "delete error returns 500",
  5212. screenname: "test1",
  5213. statusCode: http.StatusInternalServerError,
  5214. want: `{"message":"internal server error"}`,
  5215. mockParams: mockParams{
  5216. userManagerParams: userManagerParams{
  5217. getUserParams: getUserParams{
  5218. {
  5219. screenName: state.NewIdentScreenName("test1"),
  5220. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5221. },
  5222. },
  5223. },
  5224. linkedAccountManagerParams: linkedAccountManagerParams{
  5225. deleteAllLinkedAccountParams: deleteAllLinkedAccountParams{
  5226. {
  5227. screenName: state.NewIdentScreenName("test1"),
  5228. err: io.EOF,
  5229. },
  5230. },
  5231. },
  5232. },
  5233. },
  5234. {
  5235. name: "all links deleted returns 204",
  5236. screenname: "test1",
  5237. statusCode: http.StatusNoContent,
  5238. want: ``,
  5239. mockParams: mockParams{
  5240. userManagerParams: userManagerParams{
  5241. getUserParams: getUserParams{
  5242. {
  5243. screenName: state.NewIdentScreenName("test1"),
  5244. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5245. },
  5246. },
  5247. },
  5248. linkedAccountManagerParams: linkedAccountManagerParams{
  5249. deleteAllLinkedAccountParams: deleteAllLinkedAccountParams{
  5250. {
  5251. screenName: state.NewIdentScreenName("test1"),
  5252. },
  5253. },
  5254. },
  5255. },
  5256. },
  5257. }
  5258. for _, tc := range tt {
  5259. t.Run(tc.name, func(t *testing.T) {
  5260. request := httptest.NewRequest(http.MethodDelete, "/user/"+tc.screenname+"/linked-account", nil)
  5261. request.SetPathValue("screenname", tc.screenname)
  5262. responseRecorder := httptest.NewRecorder()
  5263. userManager := newMockUserManager(t)
  5264. for _, params := range tc.mockParams.getUserParams {
  5265. userManager.EXPECT().
  5266. User(matchContext(), params.screenName).
  5267. Return(params.result, params.err)
  5268. }
  5269. linkedAccountManager := newMockLinkedAccountManager(t)
  5270. for _, params := range tc.mockParams.deleteAllLinkedAccountParams {
  5271. linkedAccountManager.EXPECT().
  5272. DeleteAllLinkedAccounts(matchContext(), params.screenName).
  5273. Return(params.err)
  5274. }
  5275. deleteAllLinkedAccountsHandler(responseRecorder, request, userManager, linkedAccountManager)
  5276. assert.Equal(t, tc.statusCode, responseRecorder.Code)
  5277. assert.Equal(t, tc.want, strings.TrimSpace(responseRecorder.Body.String()))
  5278. })
  5279. }
  5280. }
  5281. func TestDeleteLinkedAccountHandler(t *testing.T) {
  5282. tt := []struct {
  5283. name string
  5284. screenname string
  5285. linkedScreenname string
  5286. statusCode int
  5287. want string
  5288. mockParams mockParams
  5289. }{
  5290. {
  5291. name: "primary user not found returns 404",
  5292. screenname: "nobody",
  5293. linkedScreenname: "test2",
  5294. statusCode: http.StatusNotFound,
  5295. want: `{"message":"user not found"}`,
  5296. mockParams: mockParams{
  5297. userManagerParams: userManagerParams{
  5298. getUserParams: getUserParams{
  5299. {
  5300. screenName: state.NewIdentScreenName("nobody"),
  5301. result: nil,
  5302. },
  5303. },
  5304. },
  5305. },
  5306. },
  5307. {
  5308. name: "linked account not found returns 404",
  5309. screenname: "test1",
  5310. linkedScreenname: "ghost",
  5311. statusCode: http.StatusNotFound,
  5312. want: `{"message":"linked account not found"}`,
  5313. mockParams: mockParams{
  5314. userManagerParams: userManagerParams{
  5315. getUserParams: getUserParams{
  5316. {
  5317. screenName: state.NewIdentScreenName("test1"),
  5318. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5319. },
  5320. },
  5321. },
  5322. linkedAccountManagerParams: linkedAccountManagerParams{
  5323. deleteLinkedAccountParams: deleteLinkedAccountParams{
  5324. {
  5325. screenName: state.NewIdentScreenName("test1"),
  5326. linkedScreenName: state.NewIdentScreenName("ghost"),
  5327. err: state.ErrNoUser,
  5328. },
  5329. },
  5330. },
  5331. },
  5332. },
  5333. {
  5334. name: "delete error returns 500",
  5335. screenname: "test1",
  5336. linkedScreenname: "test2",
  5337. statusCode: http.StatusInternalServerError,
  5338. want: `{"message":"internal server error"}`,
  5339. mockParams: mockParams{
  5340. userManagerParams: userManagerParams{
  5341. getUserParams: getUserParams{
  5342. {
  5343. screenName: state.NewIdentScreenName("test1"),
  5344. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5345. },
  5346. },
  5347. },
  5348. linkedAccountManagerParams: linkedAccountManagerParams{
  5349. deleteLinkedAccountParams: deleteLinkedAccountParams{
  5350. {
  5351. screenName: state.NewIdentScreenName("test1"),
  5352. linkedScreenName: state.NewIdentScreenName("test2"),
  5353. err: io.EOF,
  5354. },
  5355. },
  5356. },
  5357. },
  5358. },
  5359. {
  5360. name: "link deleted returns 204",
  5361. screenname: "test1",
  5362. linkedScreenname: "test2",
  5363. statusCode: http.StatusNoContent,
  5364. want: ``,
  5365. mockParams: mockParams{
  5366. userManagerParams: userManagerParams{
  5367. getUserParams: getUserParams{
  5368. {
  5369. screenName: state.NewIdentScreenName("test1"),
  5370. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5371. },
  5372. },
  5373. },
  5374. linkedAccountManagerParams: linkedAccountManagerParams{
  5375. deleteLinkedAccountParams: deleteLinkedAccountParams{
  5376. {
  5377. screenName: state.NewIdentScreenName("test1"),
  5378. linkedScreenName: state.NewIdentScreenName("test2"),
  5379. },
  5380. },
  5381. },
  5382. },
  5383. },
  5384. }
  5385. for _, tc := range tt {
  5386. t.Run(tc.name, func(t *testing.T) {
  5387. request := httptest.NewRequest(http.MethodDelete, "/user/"+tc.screenname+"/linked-account/"+tc.linkedScreenname, nil)
  5388. request.SetPathValue("screenname", tc.screenname)
  5389. request.SetPathValue("linked_screenname", tc.linkedScreenname)
  5390. responseRecorder := httptest.NewRecorder()
  5391. userManager := newMockUserManager(t)
  5392. for _, params := range tc.mockParams.getUserParams {
  5393. userManager.EXPECT().
  5394. User(matchContext(), params.screenName).
  5395. Return(params.result, params.err)
  5396. }
  5397. linkedAccountManager := newMockLinkedAccountManager(t)
  5398. for _, params := range tc.mockParams.deleteLinkedAccountParams {
  5399. linkedAccountManager.EXPECT().
  5400. DeleteLinkedAccount(matchContext(), params.screenName, params.linkedScreenName).
  5401. Return(params.err)
  5402. }
  5403. deleteLinkedAccountHandler(responseRecorder, request, userManager, linkedAccountManager)
  5404. assert.Equal(t, tc.statusCode, responseRecorder.Code)
  5405. assert.Equal(t, tc.want, strings.TrimSpace(responseRecorder.Body.String()))
  5406. })
  5407. }
  5408. }