| 123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083108410851086108710881089109010911092109310941095109610971098109911001101110211031104110511061107110811091110111111121113111411151116111711181119112011211122112311241125112611271128112911301131113211331134113511361137113811391140114111421143114411451146114711481149115011511152115311541155115611571158115911601161116211631164116511661167116811691170117111721173117411751176117711781179118011811182118311841185118611871188118911901191119211931194119511961197119811991200120112021203120412051206120712081209121012111212121312141215121612171218121912201221122212231224122512261227122812291230123112321233123412351236123712381239124012411242124312441245124612471248124912501251125212531254125512561257125812591260126112621263126412651266126712681269127012711272127312741275127612771278127912801281128212831284128512861287128812891290129112921293129412951296129712981299130013011302130313041305130613071308130913101311131213131314131513161317131813191320132113221323132413251326132713281329133013311332133313341335133613371338133913401341134213431344134513461347134813491350135113521353135413551356135713581359136013611362136313641365136613671368136913701371137213731374137513761377137813791380138113821383138413851386138713881389139013911392139313941395139613971398139914001401140214031404140514061407140814091410141114121413141414151416141714181419142014211422142314241425142614271428142914301431143214331434143514361437143814391440144114421443144414451446144714481449145014511452145314541455145614571458145914601461146214631464146514661467146814691470147114721473147414751476147714781479148014811482148314841485148614871488148914901491149214931494149514961497149814991500150115021503150415051506150715081509151015111512151315141515151615171518151915201521152215231524152515261527152815291530153115321533153415351536153715381539154015411542154315441545154615471548154915501551155215531554155515561557155815591560156115621563156415651566156715681569157015711572157315741575157615771578157915801581158215831584158515861587158815891590159115921593159415951596159715981599160016011602160316041605160616071608160916101611161216131614161516161617161816191620162116221623162416251626162716281629163016311632163316341635163616371638163916401641164216431644164516461647164816491650165116521653165416551656165716581659166016611662166316641665166616671668166916701671167216731674167516761677167816791680168116821683168416851686168716881689169016911692169316941695169616971698169917001701170217031704170517061707170817091710171117121713171417151716171717181719172017211722172317241725172617271728172917301731173217331734173517361737173817391740174117421743174417451746174717481749175017511752175317541755175617571758175917601761176217631764176517661767176817691770177117721773177417751776177717781779178017811782178317841785178617871788178917901791179217931794179517961797179817991800180118021803180418051806180718081809181018111812181318141815181618171818181918201821182218231824182518261827182818291830183118321833183418351836183718381839184018411842184318441845184618471848184918501851185218531854185518561857185818591860186118621863186418651866186718681869187018711872187318741875187618771878187918801881188218831884188518861887188818891890189118921893189418951896189718981899190019011902190319041905190619071908190919101911191219131914191519161917191819191920192119221923192419251926192719281929193019311932193319341935193619371938193919401941194219431944194519461947194819491950195119521953195419551956195719581959196019611962196319641965196619671968196919701971197219731974197519761977197819791980198119821983198419851986198719881989199019911992199319941995199619971998199920002001200220032004200520062007200820092010201120122013201420152016201720182019202020212022202320242025202620272028202920302031203220332034203520362037203820392040204120422043204420452046204720482049205020512052205320542055205620572058205920602061206220632064206520662067206820692070207120722073207420752076207720782079208020812082208320842085208620872088208920902091209220932094209520962097209820992100210121022103210421052106210721082109211021112112211321142115211621172118211921202121212221232124212521262127212821292130213121322133213421352136213721382139214021412142214321442145214621472148214921502151215221532154215521562157215821592160216121622163216421652166216721682169217021712172217321742175217621772178217921802181218221832184218521862187218821892190219121922193219421952196219721982199220022012202220322042205220622072208220922102211221222132214221522162217221822192220222122222223222422252226222722282229223022312232223322342235223622372238223922402241224222432244224522462247224822492250225122522253225422552256225722582259226022612262226322642265226622672268226922702271227222732274227522762277227822792280228122822283228422852286228722882289229022912292229322942295229622972298229923002301230223032304230523062307230823092310231123122313231423152316231723182319232023212322232323242325232623272328232923302331233223332334233523362337233823392340234123422343234423452346234723482349235023512352235323542355235623572358235923602361236223632364236523662367236823692370237123722373237423752376237723782379238023812382238323842385238623872388238923902391239223932394239523962397239823992400240124022403240424052406240724082409241024112412241324142415241624172418241924202421242224232424242524262427242824292430243124322433243424352436243724382439244024412442244324442445244624472448244924502451245224532454245524562457245824592460246124622463246424652466246724682469247024712472247324742475247624772478247924802481248224832484248524862487248824892490249124922493249424952496249724982499250025012502250325042505250625072508250925102511251225132514251525162517251825192520252125222523252425252526252725282529253025312532253325342535253625372538253925402541254225432544254525462547254825492550255125522553255425552556255725582559256025612562256325642565256625672568256925702571257225732574257525762577257825792580258125822583258425852586258725882589259025912592259325942595259625972598259926002601260226032604260526062607260826092610261126122613261426152616261726182619262026212622262326242625262626272628262926302631263226332634263526362637263826392640264126422643264426452646264726482649265026512652265326542655265626572658265926602661266226632664266526662667266826692670267126722673267426752676267726782679268026812682268326842685268626872688268926902691269226932694269526962697269826992700270127022703270427052706270727082709271027112712271327142715271627172718271927202721272227232724272527262727272827292730273127322733273427352736273727382739274027412742274327442745274627472748274927502751275227532754275527562757275827592760276127622763276427652766276727682769277027712772277327742775277627772778277927802781278227832784278527862787278827892790279127922793279427952796279727982799280028012802280328042805280628072808280928102811281228132814281528162817281828192820282128222823282428252826282728282829283028312832283328342835283628372838283928402841284228432844284528462847284828492850285128522853285428552856285728582859286028612862286328642865286628672868286928702871287228732874287528762877287828792880288128822883288428852886288728882889289028912892289328942895289628972898289929002901290229032904290529062907290829092910291129122913291429152916291729182919292029212922292329242925292629272928292929302931293229332934293529362937293829392940294129422943294429452946294729482949295029512952295329542955295629572958295929602961296229632964296529662967296829692970297129722973297429752976297729782979298029812982298329842985298629872988298929902991299229932994299529962997299829993000300130023003300430053006300730083009301030113012301330143015301630173018301930203021302230233024302530263027302830293030303130323033303430353036303730383039304030413042304330443045304630473048304930503051305230533054305530563057305830593060306130623063306430653066306730683069307030713072307330743075307630773078307930803081308230833084308530863087308830893090309130923093309430953096309730983099310031013102310331043105310631073108310931103111311231133114311531163117311831193120312131223123312431253126312731283129313031313132313331343135313631373138313931403141314231433144314531463147314831493150315131523153315431553156315731583159316031613162316331643165316631673168316931703171317231733174317531763177317831793180318131823183318431853186318731883189319031913192319331943195319631973198319932003201320232033204320532063207320832093210321132123213321432153216321732183219322032213222322332243225322632273228322932303231323232333234323532363237323832393240324132423243324432453246324732483249325032513252325332543255325632573258325932603261326232633264326532663267326832693270327132723273327432753276327732783279328032813282328332843285328632873288328932903291329232933294329532963297329832993300330133023303330433053306330733083309331033113312331333143315331633173318331933203321332233233324332533263327332833293330333133323333333433353336333733383339334033413342334333443345334633473348334933503351335233533354335533563357335833593360336133623363336433653366336733683369337033713372337333743375337633773378337933803381338233833384338533863387338833893390339133923393339433953396339733983399340034013402340334043405340634073408340934103411341234133414341534163417341834193420342134223423342434253426342734283429343034313432343334343435343634373438343934403441344234433444344534463447344834493450345134523453345434553456345734583459346034613462346334643465346634673468346934703471347234733474347534763477347834793480348134823483348434853486348734883489349034913492349334943495349634973498349935003501350235033504350535063507350835093510351135123513351435153516351735183519352035213522352335243525352635273528352935303531353235333534353535363537353835393540354135423543354435453546354735483549355035513552355335543555355635573558355935603561356235633564356535663567356835693570357135723573357435753576357735783579358035813582358335843585358635873588358935903591359235933594359535963597359835993600360136023603360436053606360736083609361036113612361336143615361636173618361936203621362236233624362536263627362836293630363136323633363436353636363736383639364036413642364336443645364636473648364936503651365236533654365536563657365836593660366136623663366436653666366736683669367036713672367336743675367636773678367936803681368236833684368536863687368836893690369136923693369436953696369736983699370037013702370337043705370637073708370937103711371237133714371537163717371837193720372137223723372437253726372737283729373037313732373337343735373637373738373937403741374237433744374537463747374837493750375137523753375437553756375737583759376037613762376337643765376637673768376937703771377237733774377537763777377837793780378137823783378437853786378737883789379037913792379337943795379637973798379938003801380238033804380538063807380838093810381138123813381438153816381738183819382038213822382338243825382638273828382938303831383238333834383538363837383838393840384138423843384438453846384738483849385038513852385338543855385638573858385938603861386238633864386538663867386838693870387138723873387438753876387738783879388038813882388338843885388638873888388938903891389238933894389538963897389838993900390139023903390439053906390739083909391039113912391339143915391639173918391939203921392239233924392539263927392839293930393139323933393439353936393739383939394039413942394339443945394639473948394939503951395239533954395539563957395839593960396139623963396439653966396739683969397039713972397339743975397639773978397939803981398239833984398539863987398839893990399139923993399439953996399739983999400040014002400340044005400640074008400940104011401240134014401540164017401840194020402140224023402440254026402740284029403040314032403340344035403640374038403940404041404240434044404540464047404840494050405140524053405440554056405740584059406040614062406340644065406640674068406940704071407240734074407540764077407840794080408140824083408440854086408740884089409040914092409340944095409640974098409941004101410241034104410541064107410841094110411141124113411441154116411741184119412041214122412341244125412641274128412941304131413241334134413541364137413841394140414141424143414441454146414741484149415041514152415341544155415641574158415941604161416241634164416541664167416841694170417141724173417441754176417741784179418041814182418341844185418641874188418941904191419241934194419541964197419841994200420142024203420442054206420742084209421042114212421342144215421642174218421942204221422242234224422542264227422842294230423142324233423442354236423742384239424042414242424342444245424642474248424942504251425242534254425542564257425842594260426142624263426442654266426742684269427042714272427342744275427642774278427942804281428242834284428542864287428842894290429142924293429442954296429742984299430043014302430343044305430643074308430943104311431243134314431543164317431843194320432143224323432443254326432743284329433043314332433343344335433643374338433943404341434243434344434543464347434843494350435143524353435443554356435743584359436043614362436343644365436643674368436943704371437243734374437543764377437843794380438143824383438443854386438743884389439043914392439343944395439643974398439944004401440244034404440544064407440844094410441144124413441444154416441744184419442044214422442344244425442644274428442944304431443244334434443544364437443844394440444144424443444444454446444744484449445044514452445344544455445644574458445944604461446244634464446544664467446844694470447144724473447444754476447744784479448044814482448344844485448644874488448944904491449244934494449544964497449844994500450145024503450445054506450745084509451045114512451345144515451645174518451945204521452245234524452545264527452845294530453145324533453445354536453745384539454045414542454345444545454645474548454945504551455245534554455545564557455845594560456145624563456445654566456745684569457045714572457345744575457645774578457945804581458245834584458545864587458845894590459145924593459445954596459745984599460046014602460346044605460646074608460946104611461246134614461546164617461846194620462146224623462446254626462746284629463046314632463346344635463646374638463946404641464246434644464546464647464846494650465146524653465446554656465746584659466046614662466346644665466646674668466946704671467246734674467546764677467846794680468146824683468446854686468746884689469046914692469346944695469646974698469947004701470247034704470547064707470847094710471147124713471447154716471747184719472047214722472347244725472647274728472947304731473247334734473547364737473847394740474147424743474447454746474747484749475047514752475347544755475647574758475947604761476247634764476547664767476847694770477147724773477447754776477747784779478047814782478347844785478647874788478947904791479247934794479547964797479847994800480148024803480448054806480748084809481048114812481348144815481648174818481948204821482248234824482548264827482848294830483148324833483448354836483748384839484048414842484348444845484648474848484948504851485248534854485548564857485848594860486148624863486448654866486748684869487048714872487348744875487648774878487948804881488248834884488548864887488848894890489148924893489448954896489748984899490049014902490349044905490649074908490949104911491249134914491549164917491849194920492149224923492449254926492749284929493049314932493349344935493649374938493949404941494249434944494549464947494849494950495149524953495449554956495749584959496049614962496349644965496649674968496949704971497249734974497549764977497849794980498149824983498449854986498749884989499049914992499349944995499649974998499950005001500250035004500550065007500850095010501150125013501450155016501750185019502050215022502350245025502650275028502950305031503250335034503550365037503850395040504150425043504450455046504750485049505050515052505350545055505650575058505950605061506250635064506550665067506850695070507150725073507450755076507750785079508050815082508350845085508650875088508950905091509250935094509550965097509850995100510151025103510451055106510751085109511051115112511351145115511651175118511951205121512251235124512551265127512851295130513151325133513451355136513751385139514051415142514351445145514651475148514951505151515251535154515551565157515851595160516151625163516451655166516751685169517051715172517351745175517651775178517951805181518251835184518551865187518851895190519151925193519451955196519751985199520052015202520352045205520652075208520952105211521252135214521552165217521852195220522152225223522452255226522752285229523052315232523352345235523652375238523952405241524252435244524552465247524852495250525152525253525452555256525752585259526052615262526352645265526652675268526952705271527252735274527552765277527852795280528152825283528452855286528752885289529052915292529352945295529652975298529953005301530253035304530553065307530853095310531153125313531453155316531753185319532053215322532353245325532653275328532953305331533253335334533553365337533853395340534153425343534453455346534753485349535053515352535353545355535653575358535953605361536253635364536553665367536853695370537153725373537453755376537753785379538053815382538353845385538653875388538953905391539253935394539553965397539853995400540154025403540454055406540754085409541054115412541354145415541654175418541954205421542254235424542554265427542854295430543154325433543454355436543754385439544054415442544354445445544654475448544954505451545254535454545554565457545854595460546154625463546454655466546754685469547054715472547354745475547654775478547954805481548254835484548554865487548854895490549154925493549454955496549754985499550055015502550355045505550655075508550955105511551255135514551555165517551855195520552155225523552455255526552755285529553055315532553355345535553655375538553955405541554255435544554555465547554855495550555155525553555455555556555755585559556055615562556355645565556655675568556955705571557255735574557555765577557855795580558155825583558455855586558755885589559055915592559355945595559655975598559956005601560256035604560556065607560856095610561156125613561456155616561756185619562056215622562356245625562656275628562956305631 |
- package http
- import (
- "context"
- "encoding/json"
- "errors"
- "fmt"
- "io"
- "log/slog"
- "math"
- "net/http"
- "net/http/httptest"
- "net/mail"
- "net/netip"
- "strings"
- "testing"
- "time"
- "github.com/stretchr/testify/assert"
- "github.com/stretchr/testify/mock"
- "github.com/mk6i/open-oscar-server/config"
- "github.com/mk6i/open-oscar-server/state"
- "github.com/mk6i/open-oscar-server/wire"
- )
- func TestSessionHandler_GET(t *testing.T) {
- // Fixed time for testing: 2024-01-01 12:00:00 UTC
- fixedNow := time.Date(2024, 1, 1, 12, 0, 0, 0, time.UTC)
- nowFn := func() time.Time { return fixedNow }
- tt := []struct {
- name string
- want string
- statusCode int
- createSessions func() []*state.Session
- }{
- {
- name: "without sessions",
- want: `{"count":0,"sessions":[]}`,
- statusCode: http.StatusOK,
- createSessions: func() []*state.Session {
- return []*state.Session{}
- },
- },
- {
- name: "with sessions",
- want: `{"count":3,"sessions":[{"id":"usera","screen_name":"userA","online_seconds":100,"is_away":false,"away_message":"","idle_seconds":0,"is_invisible":false,"is_icq":false,"instance_count":2,"instances":[{"num":1,"idle_seconds":30,"is_away":false,"away_message":"","is_invisible":false,"remote_addr":"1.2.3.4","remote_port":1234},{"num":2,"idle_seconds":0,"is_away":false,"away_message":"","is_invisible":true,"remote_addr":"5.6.7.8","remote_port":5678}]},{"id":"userb","screen_name":"userB","online_seconds":200,"is_away":false,"away_message":"","idle_seconds":0,"is_invisible":true,"is_icq":false,"instance_count":2,"instances":[{"num":1,"idle_seconds":0,"is_away":false,"away_message":"","is_invisible":true,"remote_addr":"9.10.11.12","remote_port":9012},{"num":2,"idle_seconds":0,"is_away":false,"away_message":"","is_invisible":true,"remote_addr":"13.14.15.16","remote_port":1314}]},{"id":"100003","screen_name":"100003","online_seconds":300,"is_away":false,"away_message":"","idle_seconds":0,"is_invisible":false,"is_icq":true,"instance_count":1,"instances":[{"num":1,"idle_seconds":0,"is_away":false,"away_message":"","is_invisible":false,"remote_addr":"1.2.3.4","remote_port":1234}]}]}`,
- statusCode: http.StatusOK,
- createSessions: func() []*state.Session {
- // userA: 2 instances - one idle (30s), one invisible
- userA := state.NewSession()
- userA.SetIdentScreenName(state.NewIdentScreenName("userA"))
- userA.SetDisplayScreenName(state.DisplayScreenName("userA"))
- userA.SetUIN(0)
- userA.SetNowFn(nowFn)
- userA.SetSignonTime(fixedNow.Add(-100 * time.Second))
- inst1 := userA.AddInstance()
- inst1.SetSignonComplete()
- inst1.SetIdle(30 * time.Second)
- ip1, _ := netip.ParseAddrPort("1.2.3.4:1234")
- inst1.SetRemoteAddr(&ip1)
- inst2 := userA.AddInstance()
- inst2.SetSignonComplete()
- inst2.SetUserStatusBitmask(wire.OServiceUserStatusInvisible)
- ip2, _ := netip.ParseAddrPort("5.6.7.8:5678")
- inst2.SetRemoteAddr(&ip2)
- // userB: 2 instances - both invisible
- userB := state.NewSession()
- userB.SetIdentScreenName(state.NewIdentScreenName("userB"))
- userB.SetDisplayScreenName(state.DisplayScreenName("userB"))
- userB.SetUIN(0)
- userB.SetNowFn(nowFn)
- userB.SetSignonTime(fixedNow.Add(-200 * time.Second))
- inst3 := userB.AddInstance()
- inst3.SetSignonComplete()
- inst3.SetUserStatusBitmask(wire.OServiceUserStatusInvisible)
- ip3, _ := netip.ParseAddrPort("9.10.11.12:9012")
- inst3.SetRemoteAddr(&ip3)
- inst4 := userB.AddInstance()
- inst4.SetSignonComplete()
- inst4.SetUserStatusBitmask(wire.OServiceUserStatusInvisible)
- ip4, _ := netip.ParseAddrPort("13.14.15.16:1314")
- inst4.SetRemoteAddr(&ip4)
- // 100003: 1 instance - normal
- icqUser := state.NewSession()
- icqUser.SetIdentScreenName(state.NewIdentScreenName("100003"))
- icqUser.SetDisplayScreenName(state.DisplayScreenName("100003"))
- icqUser.SetUIN(100003)
- icqUser.SetNowFn(nowFn)
- icqUser.SetSignonTime(fixedNow.Add(-300 * time.Second))
- inst5 := icqUser.AddInstance()
- inst5.SetSignonComplete()
- ip5, _ := netip.ParseAddrPort("1.2.3.4:1234")
- inst5.SetRemoteAddr(&ip5)
- return []*state.Session{userA, userB, icqUser}
- },
- },
- {
- name: "with away sessions",
- want: `{"count":2,"sessions":[{"id":"usera","screen_name":"userA","online_seconds":100,"is_away":false,"away_message":"","idle_seconds":0,"is_invisible":false,"is_icq":false,"instance_count":2,"instances":[{"num":1,"idle_seconds":0,"is_away":true,"away_message":"Away message 1","is_invisible":false,"remote_addr":"1.2.3.4","remote_port":1234},{"num":2,"idle_seconds":0,"is_away":false,"away_message":"","is_invisible":false,"remote_addr":"5.6.7.8","remote_port":5678}]},{"id":"userb","screen_name":"userB","online_seconds":200,"is_away":true,"away_message":"Away message 2","idle_seconds":0,"is_invisible":false,"is_icq":false,"instance_count":2,"instances":[{"num":1,"idle_seconds":0,"is_away":true,"away_message":"Away message 2","is_invisible":false,"remote_addr":"9.10.11.12","remote_port":9012},{"num":2,"idle_seconds":0,"is_away":true,"away_message":"Away message 2","is_invisible":false,"remote_addr":"13.14.15.16","remote_port":1314}]}]}`,
- statusCode: http.StatusOK,
- createSessions: func() []*state.Session {
- // userA: 2 instances - one away, one not away (away_message should be "")
- userA := state.NewSession()
- userA.SetIdentScreenName(state.NewIdentScreenName("userA"))
- userA.SetDisplayScreenName(state.DisplayScreenName("userA"))
- userA.SetUIN(0)
- userA.SetNowFn(nowFn)
- userA.SetSignonTime(fixedNow.Add(-100 * time.Second))
- inst1 := userA.AddInstance()
- inst1.SetSignonComplete()
- inst1.SetUserStatusBitmask(wire.OServiceUserStatusAway)
- inst1.SetAwayMessage("Away message 1")
- ip1, _ := netip.ParseAddrPort("1.2.3.4:1234")
- inst1.SetRemoteAddr(&ip1)
- inst2 := userA.AddInstance()
- inst2.SetSignonComplete()
- ip2, _ := netip.ParseAddrPort("5.6.7.8:5678")
- inst2.SetRemoteAddr(&ip2)
- // userB: 2 instances - both away (away_message should be populated)
- userB := state.NewSession()
- userB.SetIdentScreenName(state.NewIdentScreenName("userB"))
- userB.SetDisplayScreenName(state.DisplayScreenName("userB"))
- userB.SetUIN(0)
- userB.SetNowFn(nowFn)
- userB.SetSignonTime(fixedNow.Add(-200 * time.Second))
- inst3 := userB.AddInstance()
- inst3.SetSignonComplete()
- inst3.SetUserStatusBitmask(wire.OServiceUserStatusAway)
- inst3.SetAwayMessage("Away message 2")
- ip3, _ := netip.ParseAddrPort("9.10.11.12:9012")
- inst3.SetRemoteAddr(&ip3)
- inst4 := userB.AddInstance()
- inst4.SetSignonComplete()
- inst4.SetUserStatusBitmask(wire.OServiceUserStatusAway)
- inst4.SetAwayMessage("Away message 2")
- ip4, _ := netip.ParseAddrPort("13.14.15.16:1314")
- inst4.SetRemoteAddr(&ip4)
- return []*state.Session{userA, userB}
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- request := httptest.NewRequest(http.MethodGet, "/session", nil)
- responseRecorder := httptest.NewRecorder()
- sessionRetriever := newMockSessionRetriever(t)
- sessions := tc.createSessions()
- sessionRetriever.EXPECT().
- AllSessions().
- Return(sessions)
- getSessionHandler(responseRecorder, request, sessionRetriever, nowFn)
- if responseRecorder.Code != tc.statusCode {
- t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
- }
- if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
- t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
- }
- })
- }
- }
- func TestSessionHandlerScreenname_GET(t *testing.T) {
- // Fixed time for testing: 2024-01-01 12:00:00 UTC
- fixedNow := time.Date(2024, 1, 1, 12, 0, 0, 0, time.UTC)
- nowFn := func() time.Time { return fixedNow }
- tt := []struct {
- name string
- requestScreenName state.IdentScreenName
- want string
- statusCode int
- createSession func() *state.Session
- }{
- {
- name: "no session for screenname",
- requestScreenName: state.NewIdentScreenName("userA"),
- want: `session not found`,
- statusCode: http.StatusNotFound,
- createSession: func() *state.Session {
- return nil
- },
- },
- {
- name: "active session found for screenname",
- requestScreenName: state.NewIdentScreenName("userA"),
- want: `{"count":1,"sessions":[{"id":"usera","screen_name":"userA","online_seconds":150,"is_away":false,"away_message":"","idle_seconds":0,"is_invisible":false,"is_icq":false,"instance_count":1,"instances":[{"num":1,"idle_seconds":0,"is_away":false,"away_message":"","is_invisible":false,"remote_addr":"1.2.3.4","remote_port":1234}]}]}`,
- statusCode: http.StatusOK,
- createSession: func() *state.Session {
- sess := state.NewSession()
- sess.SetIdentScreenName(state.NewIdentScreenName("userA"))
- sess.SetDisplayScreenName(state.DisplayScreenName("userA"))
- sess.SetUIN(0)
- sess.SetNowFn(nowFn)
- sess.SetSignonTime(fixedNow.Add(-150 * time.Second))
- instance := sess.AddInstance()
- instance.SetSignonComplete()
- ip, _ := netip.ParseAddrPort("1.2.3.4:1234")
- instance.SetRemoteAddr(&ip)
- return sess
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- request := httptest.NewRequest(http.MethodGet, "/session/"+tc.requestScreenName.String(), nil)
- request.SetPathValue("screenname", tc.requestScreenName.String())
- responseRecorder := httptest.NewRecorder()
- sessionRetriever := newMockSessionRetriever(t)
- session := tc.createSession()
- sessionRetriever.EXPECT().
- RetrieveSession(tc.requestScreenName).
- Return(session)
- getSessionHandler(responseRecorder, request, sessionRetriever, nowFn)
- if responseRecorder.Code != tc.statusCode {
- t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
- }
- if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
- t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
- }
- })
- }
- }
- func TestSessionHandlerScreenname_DELETE(t *testing.T) {
- fnNewSess := func(screenName string) *state.Session {
- sess := state.NewSession()
- sess.SetIdentScreenName(state.NewIdentScreenName(screenName))
- sess.SetDisplayScreenName(state.DisplayScreenName(screenName))
- instance := sess.AddInstance()
- instance.SetSignonComplete()
- ip, _ := netip.ParseAddrPort("1.2.3.4:1234")
- instance.SetRemoteAddr(&ip)
- return sess
- }
- tt := []struct {
- name string
- session *state.SessionInstance
- requestScreenName state.IdentScreenName
- statusCode int
- mockParams mockParams
- }{
- {
- name: "delete an active session",
- requestScreenName: state.NewIdentScreenName("userA"),
- statusCode: http.StatusNoContent,
- mockParams: mockParams{
- sessionRetrieverParams: sessionRetrieverParams{
- retrieveSessionByNameParams: retrieveSessionByNameParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: fnNewSess("userA"),
- },
- },
- },
- },
- },
- {
- name: "delete a non-existent session",
- requestScreenName: state.NewIdentScreenName("userA"),
- statusCode: http.StatusNotFound,
- mockParams: mockParams{
- sessionRetrieverParams: sessionRetrieverParams{
- retrieveSessionByNameParams: retrieveSessionByNameParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: nil,
- },
- },
- },
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- request := httptest.NewRequest(http.MethodDelete, "/session/"+tc.requestScreenName.String(), nil)
- request.SetPathValue("screenname", tc.requestScreenName.String())
- responseRecorder := httptest.NewRecorder()
- sessionRetriever := newMockSessionRetriever(t)
- for _, params := range tc.mockParams.retrieveSessionByNameParams {
- sessionRetriever.EXPECT().
- RetrieveSession(params.screenName).
- Return(params.result)
- }
- deleteSessionHandler(responseRecorder, request, sessionRetriever)
- if responseRecorder.Code != tc.statusCode {
- t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
- }
- })
- }
- }
- func TestUserAccountHandler_GET(t *testing.T) {
- tt := []struct {
- name string
- requestScreenName state.IdentScreenName
- want string
- statusCode int
- mockParams mockParams
- }{
- {
- name: "invalid account",
- requestScreenName: state.NewIdentScreenName("userA"),
- want: `user not found`,
- statusCode: http.StatusNotFound,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: nil,
- },
- },
- },
- },
- },
- {
- name: "valid aim account",
- requestScreenName: state.NewIdentScreenName("userA"),
- want: `{"id":"usera","screen_name":"userA","profile":"My Profile Text","email_address":"\u003cuserA@aol.com\u003e","reg_status":2,"confirmed":true,"is_icq":false,"suspended_status":"","is_bot":false}`,
- statusCode: http.StatusOK,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: &state.User{
- DisplayScreenName: "userA",
- IdentScreenName: state.NewIdentScreenName("userA"),
- SuspendedStatus: 0x0,
- },
- },
- },
- },
- accountManagerParams: accountManagerParams{
- EmailAddressParams: EmailAddressParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: &mail.Address{
- Address: "userA@aol.com",
- },
- },
- },
- RegStatusParams: RegStatusParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: uint16(0x02),
- },
- },
- ConfirmStatusParams: ConfirmStatusParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: true,
- },
- },
- },
- profileRetrieverParams: profileRetrieverParams{
- retrieveProfileParams: retrieveProfileParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: state.UserProfile{ProfileText: "My Profile Text"},
- },
- },
- },
- },
- },
- {
- name: "valid aim bot account",
- requestScreenName: state.NewIdentScreenName("userA"),
- want: `{"id":"usera","screen_name":"userA","profile":"My Profile Text","email_address":"\u003cuserA@aol.com\u003e","reg_status":2,"confirmed":true,"is_icq":false,"suspended_status":"","is_bot":true}`,
- statusCode: http.StatusOK,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: &state.User{
- DisplayScreenName: "userA",
- IdentScreenName: state.NewIdentScreenName("userA"),
- SuspendedStatus: 0x0,
- IsBot: true,
- },
- },
- },
- },
- accountManagerParams: accountManagerParams{
- EmailAddressParams: EmailAddressParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: &mail.Address{
- Address: "userA@aol.com",
- },
- },
- },
- RegStatusParams: RegStatusParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: uint16(0x02),
- },
- },
- ConfirmStatusParams: ConfirmStatusParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: true,
- },
- },
- },
- profileRetrieverParams: profileRetrieverParams{
- retrieveProfileParams: retrieveProfileParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: state.UserProfile{ProfileText: "My Profile Text"},
- },
- },
- },
- },
- },
- {
- name: "suspended aim account",
- requestScreenName: state.NewIdentScreenName("userB"),
- want: `{"id":"userb","screen_name":"userB","profile":"My Profile Text","email_address":"\u003cuserB@aol.com\u003e","reg_status":2,"confirmed":true,"is_icq":false,"suspended_status":"suspended","is_bot":false}`,
- statusCode: http.StatusOK,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("userB"),
- result: &state.User{
- DisplayScreenName: "userB",
- IdentScreenName: state.NewIdentScreenName("userB"),
- SuspendedStatus: wire.LoginErrSuspendedAccount,
- },
- },
- },
- },
- accountManagerParams: accountManagerParams{
- EmailAddressParams: EmailAddressParams{
- {
- screenName: state.NewIdentScreenName("userB"),
- result: &mail.Address{
- Address: "userB@aol.com",
- },
- },
- },
- RegStatusParams: RegStatusParams{
- {
- screenName: state.NewIdentScreenName("userB"),
- result: uint16(0x02),
- },
- },
- ConfirmStatusParams: ConfirmStatusParams{
- {
- screenName: state.NewIdentScreenName("userB"),
- result: true,
- },
- },
- },
- profileRetrieverParams: profileRetrieverParams{
- retrieveProfileParams: retrieveProfileParams{
- {
- screenName: state.NewIdentScreenName("userB"),
- result: state.UserProfile{ProfileText: "My Profile Text"},
- },
- },
- },
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- request := httptest.NewRequest(http.MethodGet, "/user/"+tc.requestScreenName.String()+"/account", nil)
- request.SetPathValue("screenname", tc.requestScreenName.String())
- responseRecorder := httptest.NewRecorder()
- userManager := newMockUserManager(t)
- for _, params := range tc.mockParams.getUserParams {
- userManager.EXPECT().
- User(matchContext(), params.screenName).
- Return(params.result, params.err)
- }
- accountManager := newMockAccountManager(t)
- for _, params := range tc.mockParams.EmailAddressParams {
- accountManager.EXPECT().
- EmailAddress(matchContext(), params.screenName).
- Return(params.result, params.err)
- }
- for _, params := range tc.mockParams.RegStatusParams {
- accountManager.EXPECT().
- RegStatus(matchContext(), params.screenName).
- Return(params.result, params.err)
- }
- for _, params := range tc.mockParams.ConfirmStatusParams {
- accountManager.EXPECT().
- ConfirmStatus(matchContext(), params.screenName).
- Return(params.result, params.err)
- }
- profileRetriever := newMockProfileRetriever(t)
- for _, params := range tc.mockParams.retrieveProfileParams {
- profileRetriever.EXPECT().
- Profile(matchContext(), params.screenName).
- Return(params.result, params.err)
- }
- getUserAccountHandler(responseRecorder, request, userManager, accountManager, profileRetriever, slog.Default())
- if responseRecorder.Code != tc.statusCode {
- t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
- }
- if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
- t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
- }
- })
- }
- }
- func TestUserAccountHandler_PATCH(t *testing.T) {
- tt := []struct {
- name string
- requestScreenName state.IdentScreenName
- want string
- body string
- statusCode int
- mockParams mockParams
- }{
- {
- name: "suspending a non-existent account",
- requestScreenName: state.NewIdentScreenName("userA"),
- body: `{"suspended_status":"suspended"}`,
- want: `user not found`,
- statusCode: http.StatusNotFound,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: nil,
- },
- },
- },
- },
- },
- {
- name: "patching with invalid suspended_status value",
- requestScreenName: state.NewIdentScreenName("userA"),
- body: `{"suspended_status":"thisisinvalid"}`,
- want: `{"message":"suspended_status must be empty str or one of deleted,expired,suspended,suspended_age"}`,
- statusCode: http.StatusBadRequest,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: &state.User{},
- },
- },
- },
- },
- },
- {
- name: "suspending an active aim account",
- requestScreenName: state.NewIdentScreenName("userA"),
- statusCode: http.StatusNoContent,
- body: `{"suspended_status":"suspended"}`,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: &state.User{
- DisplayScreenName: "userA",
- IdentScreenName: state.NewIdentScreenName("userA"),
- SuspendedStatus: 0x0,
- },
- },
- },
- },
- accountManagerParams: accountManagerParams{
- updateSuspendedStatusParams: updateSuspendedStatusParams{
- {
- suspendedStatus: wire.LoginErrSuspendedAccount,
- screenName: state.NewIdentScreenName("userA"),
- err: nil,
- },
- },
- },
- },
- },
- {
- name: "unsuspending a suspended aim account",
- requestScreenName: state.NewIdentScreenName("userA"),
- statusCode: http.StatusNoContent,
- body: `{"suspended_status":""}`,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: &state.User{
- DisplayScreenName: "userA",
- IdentScreenName: state.NewIdentScreenName("userA"),
- SuspendedStatus: wire.LoginErrSuspendedAccount,
- },
- },
- },
- },
- accountManagerParams: accountManagerParams{
- updateSuspendedStatusParams: updateSuspendedStatusParams{
- {
- suspendedStatus: 0x0,
- screenName: state.NewIdentScreenName("userA"),
- err: nil,
- },
- },
- },
- },
- },
- {
- name: "suspending an already suspended aim account",
- requestScreenName: state.NewIdentScreenName("userA"),
- statusCode: http.StatusNotModified,
- body: `{"suspended_status":"suspended"}`,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: &state.User{
- DisplayScreenName: "userA",
- IdentScreenName: state.NewIdentScreenName("userA"),
- SuspendedStatus: wire.LoginErrSuspendedAccount,
- },
- },
- },
- },
- },
- },
- {
- name: "setting bot flag (before: false, after: true)",
- requestScreenName: state.NewIdentScreenName("userA"),
- statusCode: http.StatusNoContent,
- body: `{"is_bot":true}`,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: &state.User{
- DisplayScreenName: "userA",
- IdentScreenName: state.NewIdentScreenName("userA"),
- SuspendedStatus: 0x0,
- IsBot: false,
- },
- },
- },
- },
- accountManagerParams: accountManagerParams{
- setBotStatusParams: setBotStatusParams{
- {
- isBot: true,
- screenName: state.NewIdentScreenName("userA"),
- err: nil,
- },
- },
- },
- },
- },
- {
- name: "setting bot flag (before: true, after: false)",
- requestScreenName: state.NewIdentScreenName("userA"),
- statusCode: http.StatusNoContent,
- body: `{"is_bot":false}`,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: &state.User{
- DisplayScreenName: "userA",
- IdentScreenName: state.NewIdentScreenName("userA"),
- SuspendedStatus: 0x0,
- IsBot: true,
- },
- },
- },
- },
- accountManagerParams: accountManagerParams{
- setBotStatusParams: setBotStatusParams{
- {
- isBot: false,
- screenName: state.NewIdentScreenName("userA"),
- err: nil,
- },
- },
- },
- },
- },
- {
- name: "setting bot flag (before: true, after: true)",
- requestScreenName: state.NewIdentScreenName("userA"),
- statusCode: http.StatusNotModified,
- body: `{"is_bot":true}`,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: &state.User{
- DisplayScreenName: "userA",
- IdentScreenName: state.NewIdentScreenName("userA"),
- SuspendedStatus: 0x0,
- IsBot: true,
- },
- },
- },
- },
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- request := httptest.NewRequest(http.MethodPatch, "/user/"+tc.requestScreenName.String()+"/account", strings.NewReader(tc.body))
- request.SetPathValue("screenname", tc.requestScreenName.String())
- responseRecorder := httptest.NewRecorder()
- userManager := newMockUserManager(t)
- for _, params := range tc.mockParams.getUserParams {
- userManager.EXPECT().
- User(matchContext(), params.screenName).
- Return(params.result, params.err)
- }
- accountManager := newMockAccountManager(t)
- for _, params := range tc.mockParams.updateSuspendedStatusParams {
- accountManager.EXPECT().
- UpdateSuspendedStatus(matchContext(), params.suspendedStatus, params.screenName).
- Return(params.err)
- }
- for _, params := range tc.mockParams.setBotStatusParams {
- accountManager.EXPECT().
- SetBotStatus(matchContext(), params.isBot, params.screenName).
- Return(params.err)
- }
- patchUserAccountHandler(responseRecorder, request, userManager, accountManager, slog.Default())
- if responseRecorder.Code != tc.statusCode {
- t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
- }
- if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
- t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
- }
- })
- }
- }
- func TestUserBuddyIconHandler_GET(t *testing.T) {
- sampleGIF := []byte{
- 0x47, 0x49, 0x46, 0x38, 0x39, 0x61, 0x32, 0x00, 0x32, 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
- 0x00, 0x00, 0x00, 0x21, 0xf9, 0x04, 0x01, 0x00, 0x00, 0x00, 0x00, 0x2c, 0x00, 0x00, 0x00, 0x00,
- 0x32, 0x00, 0x32, 0x00, 0x00, 0x02, 0x02, 0x44, 0x01, 0x00, 0x3b}
- sampleJPG := []byte{0xFF, 0xD8, 0xFF, 0x43, 0x13, 0x37}
- tt := []struct {
- name string
- requestScreenName state.IdentScreenName
- want string
- statusCode int
- contentType string
- mockParams mockParams
- }{
- {
- name: "invalid account",
- requestScreenName: state.NewIdentScreenName("userA"),
- want: `user not found`,
- statusCode: http.StatusNotFound,
- contentType: "text/plain; charset=utf-8",
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: nil,
- },
- },
- },
- },
- },
- {
- name: "account with gif buddy icon",
- requestScreenName: state.NewIdentScreenName("userA"),
- want: string(sampleGIF),
- statusCode: http.StatusOK,
- contentType: "image/gif",
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: &state.User{
- DisplayScreenName: "userA",
- IdentScreenName: state.NewIdentScreenName("userA"),
- },
- },
- },
- },
- feedBagRetrieverParams: feedBagRetrieverParams{
- buddyIconMetadataParams: buddyIconMetadataParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: &wire.BARTID{
- Type: wire.BARTTypesBuddyIcon,
- BARTInfo: wire.BARTInfo{
- Flags: 0x00,
- Hash: []byte{'t', 'h', 'e', 'h', 'a', 's', 'h'},
- },
- },
- },
- },
- },
- bartAssetManagerParams: bartAssetManagerParams{
- bartItemParams: bartItemParams{
- {
- hash: []byte{'t', 'h', 'e', 'h', 'a', 's', 'h'},
- result: sampleGIF,
- },
- },
- },
- },
- },
- {
- name: "account with jpg buddy icon",
- requestScreenName: state.NewIdentScreenName("userA"),
- want: string(sampleJPG),
- statusCode: http.StatusOK,
- contentType: "image/jpeg",
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: &state.User{
- DisplayScreenName: "userA",
- IdentScreenName: state.NewIdentScreenName("userA"),
- },
- },
- },
- },
- feedBagRetrieverParams: feedBagRetrieverParams{
- buddyIconMetadataParams: buddyIconMetadataParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: &wire.BARTID{
- Type: wire.BARTTypesBuddyIcon,
- BARTInfo: wire.BARTInfo{
- Flags: 0x00,
- Hash: []byte{'t', 'h', 'e', 'h', 'a', 's', 'h'},
- },
- },
- },
- },
- },
- bartAssetManagerParams: bartAssetManagerParams{
- bartItemParams: bartItemParams{
- {
- hash: []byte{'t', 'h', 'e', 'h', 'a', 's', 'h'},
- result: sampleJPG,
- },
- },
- },
- },
- },
- {
- name: "account with unknown format buddy icon",
- requestScreenName: state.NewIdentScreenName("userA"),
- want: string([]byte{0x13, 0x37, 0x13, 0x37, 0x13, 0x37}),
- statusCode: http.StatusOK,
- contentType: "application/octet-stream",
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: &state.User{
- DisplayScreenName: "userA",
- IdentScreenName: state.NewIdentScreenName("userA"),
- },
- },
- },
- },
- feedBagRetrieverParams: feedBagRetrieverParams{
- buddyIconMetadataParams: buddyIconMetadataParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: &wire.BARTID{
- Type: wire.BARTTypesBuddyIcon,
- BARTInfo: wire.BARTInfo{
- Flags: 0x00,
- Hash: []byte{'t', 'h', 'e', 'h', 'a', 's', 'h'},
- },
- },
- },
- },
- },
- bartAssetManagerParams: bartAssetManagerParams{
- bartItemParams: bartItemParams{
- {
- hash: []byte{'t', 'h', 'e', 'h', 'a', 's', 'h'},
- result: []byte{0x13, 0x37, 0x13, 0x37, 0x13, 0x37},
- },
- },
- },
- },
- },
- {
- name: "account with cleared buddy icon",
- requestScreenName: state.NewIdentScreenName("userA"),
- want: "icon not found",
- statusCode: http.StatusNotFound,
- contentType: "text/plain; charset=utf-8",
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: &state.User{
- DisplayScreenName: "userA",
- IdentScreenName: state.NewIdentScreenName("userA"),
- },
- },
- },
- },
- feedBagRetrieverParams: feedBagRetrieverParams{
- buddyIconMetadataParams: buddyIconMetadataParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: &wire.BARTID{
- Type: wire.BARTTypesBuddyIcon,
- BARTInfo: wire.BARTInfo{
- Flags: 0x00,
- Hash: wire.GetClearIconHash(),
- },
- },
- },
- },
- },
- },
- },
- {
- name: "account with no buddy icon",
- requestScreenName: state.NewIdentScreenName("userA"),
- want: "icon not found",
- statusCode: http.StatusNotFound,
- contentType: "text/plain; charset=utf-8",
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: &state.User{
- DisplayScreenName: "userA",
- IdentScreenName: state.NewIdentScreenName("userA"),
- },
- },
- },
- },
- feedBagRetrieverParams: feedBagRetrieverParams{
- buddyIconMetadataParams: buddyIconMetadataParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: nil,
- },
- },
- },
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- request := httptest.NewRequest(http.MethodGet, "/user/"+tc.requestScreenName.String()+"/icon", nil)
- request.SetPathValue("screenname", tc.requestScreenName.String())
- responseRecorder := httptest.NewRecorder()
- userManager := newMockUserManager(t)
- for _, params := range tc.mockParams.getUserParams {
- userManager.EXPECT().
- User(matchContext(), params.screenName).
- Return(params.result, params.err)
- }
- feedbagRetriever := newMockFeedBagRetriever(t)
- for _, params := range tc.mockParams.buddyIconMetadataParams {
- feedbagRetriever.EXPECT().
- BuddyIconMetadata(matchContext(), params.screenName).
- Return(params.result, params.err)
- }
- bartRetriever := newMockBARTAssetManager(t)
- for _, params := range tc.mockParams.bartItemParams {
- bartRetriever.EXPECT().
- BARTItem(matchContext(), params.hash).
- Return(params.result, params.err)
- }
- getUserBuddyIconHandler(responseRecorder, request, userManager, feedbagRetriever, bartRetriever, slog.Default())
- if responseRecorder.Code != tc.statusCode {
- t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
- }
- contentType := responseRecorder.Header().Get("Content-Type")
- if contentType != tc.contentType {
- t.Errorf("Want content type '%s', got '%s'", tc.contentType, contentType)
- }
- if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
- t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
- }
- })
- }
- }
- func TestUserHandler_GET(t *testing.T) {
- tt := []struct {
- name string
- want string
- statusCode int
- mockParams mockParams
- }{
- {
- name: "empty user store",
- want: `[]`,
- statusCode: http.StatusOK,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- allUsersParams: allUsersParams{
- {
- result: []state.User{},
- },
- },
- },
- },
- },
- {
- name: "user store containing 3 users",
- want: `[{"id":"usera","screen_name":"userA","is_icq":false,"suspended_status":"","is_bot":false},{"id":"userb","screen_name":"userB","is_icq":false,"suspended_status":"","is_bot":true},{"id":"100003","screen_name":"100003","is_icq":true,"suspended_status":"","is_bot":false}]`,
- statusCode: http.StatusOK,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- allUsersParams: allUsersParams{
- {
- result: []state.User{
- {
- DisplayScreenName: "userA",
- IdentScreenName: state.NewIdentScreenName("userA"),
- },
- {
- DisplayScreenName: "userB",
- IdentScreenName: state.NewIdentScreenName("userB"),
- IsBot: true,
- },
- {
- DisplayScreenName: "100003",
- IdentScreenName: state.NewIdentScreenName("100003"),
- IsICQ: true,
- },
- },
- },
- },
- },
- },
- },
- {
- name: "user handler error",
- want: `internal server error`,
- statusCode: http.StatusInternalServerError,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- allUsersParams: allUsersParams{
- {
- result: []state.User{},
- err: io.EOF,
- },
- },
- },
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- request := httptest.NewRequest(http.MethodGet, "/user", nil)
- responseRecorder := httptest.NewRecorder()
- userManager := newMockUserManager(t)
- for _, params := range tc.mockParams.allUsersParams {
- userManager.EXPECT().
- AllUsers(matchContext()).
- Return(params.result, params.err)
- }
- getUserHandler(responseRecorder, request, userManager, slog.Default())
- if responseRecorder.Code != tc.statusCode {
- t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
- }
- if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
- t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
- }
- })
- }
- }
- func TestUserHandler_POST(t *testing.T) {
- tt := []struct {
- name string
- body string
- want string
- statusCode int
- createAccount state.CreateAccountFunc
- }{
- {
- name: "with valid AIM user",
- body: `{"screen_name":"userA", "password":"thepassword"}`,
- want: `User account created successfully.`,
- statusCode: http.StatusCreated,
- createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
- assert.Equal(t, state.DisplayScreenName("userA"), screenName)
- assert.Equal(t, "thepassword", password)
- return nil
- },
- },
- {
- name: "with valid ICQ user",
- body: `{"screen_name":"100003", "password":"thepass"}`,
- want: `User account created successfully.`,
- statusCode: http.StatusCreated,
- createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
- assert.Equal(t, state.DisplayScreenName("100003"), screenName)
- assert.Equal(t, "thepass", password)
- return nil
- },
- },
- {
- name: "with malformed body",
- body: `{"screen_name":"userA", "password":"thepassword"`, // missing closing }
- want: `malformed input`,
- statusCode: http.StatusBadRequest,
- },
- {
- name: "user handler error",
- body: `{"screen_name":"userA", "password":"thepassword"}`,
- want: `internal server error`,
- statusCode: http.StatusInternalServerError,
- createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
- assert.Equal(t, state.DisplayScreenName("userA"), screenName)
- assert.Equal(t, "thepassword", password)
- return io.EOF
- },
- },
- {
- name: "duplicate user",
- body: `{"screen_name":"userA", "password":"thepassword"}`,
- want: `user already exists`,
- statusCode: http.StatusConflict,
- createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
- assert.Equal(t, state.DisplayScreenName("userA"), screenName)
- assert.Equal(t, "thepassword", password)
- return state.ErrDupUser
- },
- },
- {
- name: "invalid AIM screen name",
- body: `{"screen_name":"a", "password":"thepassword"}`,
- want: `invalid screen name: screen name must be between 3 and 16 characters`,
- statusCode: http.StatusBadRequest,
- createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
- assert.Equal(t, state.DisplayScreenName("a"), screenName)
- assert.Equal(t, "thepassword", password)
- return state.ErrAIMHandleLength
- },
- },
- {
- name: "invalid AIM password",
- body: `{"screen_name":"userA", "password":"1"}`,
- want: `invalid password: invalid password length: password length must be between 4-16 characters`,
- statusCode: http.StatusBadRequest,
- createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
- assert.Equal(t, state.DisplayScreenName("userA"), screenName)
- assert.Equal(t, "1", password)
- return fmt.Errorf("%w: password length must be between 4-16 characters", state.ErrPasswordInvalid)
- },
- },
- {
- name: "invalid ICQ UIN",
- body: `{"screen_name":"1000", "password":"thepass"}`,
- want: `invalid uin: uin must be a number in the range 10000-2147483646`,
- statusCode: http.StatusBadRequest,
- createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
- assert.Equal(t, state.DisplayScreenName("1000"), screenName)
- assert.Equal(t, "thepass", password)
- return state.ErrICQUINInvalidFormat
- },
- },
- {
- name: "invalid ICQ password",
- body: `{"screen_name":"100003", "password":"thelongpassword"}`,
- want: `invalid password: invalid password length: password must be between 6-8 characters`,
- statusCode: http.StatusBadRequest,
- createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
- assert.Equal(t, state.DisplayScreenName("100003"), screenName)
- assert.Equal(t, "thelongpassword", password)
- return fmt.Errorf("%w: password must be between 6-8 characters", state.ErrPasswordInvalid)
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- request := httptest.NewRequest(http.MethodPost, "/user", strings.NewReader(tc.body))
- responseRecorder := httptest.NewRecorder()
- postUserHandler(responseRecorder, request, tc.createAccount, slog.Default())
- if responseRecorder.Code != tc.statusCode {
- t.Errorf("want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
- }
- if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
- t.Errorf("want '%s', got '%s'", tc.want, responseRecorder.Body)
- }
- })
- }
- }
- func TestUserHandler_DELETE(t *testing.T) {
- tt := []struct {
- name string
- body string
- want string
- statusCode int
- mockParams mockParams
- }{
- {
- name: "with valid user",
- body: `{"screen_name":"userA"}`,
- want: `User account successfully deleted.`,
- statusCode: http.StatusNoContent,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- deleteUserParams: deleteUserParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- },
- },
- },
- },
- },
- {
- name: "with non-existent user",
- body: `{"screen_name":"userA"}`,
- want: `user does not exist`,
- statusCode: http.StatusNotFound,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- deleteUserParams: deleteUserParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- err: state.ErrNoUser,
- },
- },
- },
- },
- },
- {
- name: "with malformed body",
- body: `{"screen_name":"userA"`, // missing closing }
- want: `malformed input`,
- statusCode: http.StatusBadRequest,
- },
- {
- name: "user handler error",
- body: `{"screen_name":"userA"}`,
- want: `internal server error`,
- statusCode: http.StatusInternalServerError,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- deleteUserParams: deleteUserParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- err: io.EOF,
- },
- },
- },
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- request := httptest.NewRequest(http.MethodDelete, "/user", strings.NewReader(tc.body))
- responseRecorder := httptest.NewRecorder()
- userManager := newMockUserManager(t)
- for _, params := range tc.mockParams.deleteUserParams {
- userManager.EXPECT().
- DeleteUser(matchContext(), params.screenName).
- Return(params.err)
- }
- deleteUserHandler(responseRecorder, request, userManager, slog.Default())
- if responseRecorder.Code != tc.statusCode {
- t.Errorf("want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
- }
- if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
- t.Errorf("want '%s', got '%s'", tc.want, responseRecorder.Body)
- }
- })
- }
- }
- func TestUserPasswordHandler_PUT(t *testing.T) {
- tt := []struct {
- name string
- body string
- want string
- statusCode int
- mockParams mockParams
- }{
- {
- name: "user with valid password",
- body: `{"screen_name":"userA", "password":"thenewpassword"}`,
- want: `Password successfully reset.`,
- statusCode: http.StatusNoContent,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- setUserPasswordParams: setUserPasswordParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- newPassword: "thenewpassword",
- },
- },
- },
- },
- },
- {
- name: "user with invalid password",
- body: `{"screen_name":"userA", "password":"a"}`,
- want: `invalid password length`,
- statusCode: http.StatusBadRequest,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- setUserPasswordParams: setUserPasswordParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- newPassword: "a",
- err: state.ErrPasswordInvalid,
- },
- },
- },
- },
- },
- {
- name: "with malformed body",
- body: `{"screen_name":"userA", "password":"thepassword"`, // missing closing }
- want: `malformed input`,
- statusCode: http.StatusBadRequest,
- },
- {
- name: "password updater returns runtime error",
- body: `{"screen_name":"userA", "password":"thepassword"}`,
- want: `internal server error`,
- statusCode: http.StatusInternalServerError,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- setUserPasswordParams: setUserPasswordParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- newPassword: "thepassword",
- err: io.EOF,
- },
- },
- },
- },
- },
- {
- name: "user doesn't exist",
- body: `{"screen_name":"userA", "password":"thepassword"}`,
- want: `user does not exist`,
- statusCode: http.StatusNotFound,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- setUserPasswordParams: setUserPasswordParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- newPassword: "thepassword",
- err: state.ErrNoUser,
- },
- },
- },
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- request := httptest.NewRequest(http.MethodPut, "/user", strings.NewReader(tc.body))
- responseRecorder := httptest.NewRecorder()
- userManager := newMockUserManager(t)
- for _, params := range tc.mockParams.setUserPasswordParams {
- userManager.EXPECT().
- SetUserPassword(matchContext(), params.screenName, params.newPassword).
- Return(params.err)
- }
- putUserPasswordHandler(responseRecorder, request, userManager, slog.Default())
- if responseRecorder.Code != tc.statusCode {
- t.Errorf("want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
- }
- if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
- t.Errorf("want '%s', got '%s'", tc.want, responseRecorder.Body)
- }
- })
- }
- }
- func TestPublicChatHandler_GET(t *testing.T) {
- fnNewSess := func(screenName string) *state.Session {
- sess := state.NewSession()
- sess.SetIdentScreenName(state.NewIdentScreenName(screenName))
- sess.SetDisplayScreenName(state.DisplayScreenName(screenName))
- instance := sess.AddInstance()
- instance.SetSignonComplete()
- return sess
- }
- chatRoom1 := state.NewChatRoom("chat-room-1-name", state.NewIdentScreenName("chat-room-1-creator"), state.PublicExchange)
- chatRoom2 := state.NewChatRoom("chat-room-2-name", state.NewIdentScreenName("chat-room-1-creator"), state.PublicExchange)
- tt := []struct {
- name string
- want string
- statusCode int
- mockParams mockParams
- }{
- {
- name: "multiple chat rooms with participants",
- want: `[{"name":"chat-room-1-name","create_time":"0001-01-01T00:00:00Z","url":"aim:gochat?roomname=chat-room-1-name&exchange=5","participants":[{"id":"usera","screen_name":"userA"},{"id":"userb","screen_name":"userB"}]},{"name":"chat-room-2-name","create_time":"0001-01-01T00:00:00Z","url":"aim:gochat?roomname=chat-room-2-name&exchange=5","participants":[{"id":"userc","screen_name":"userC"},{"id":"userd","screen_name":"userD"}]}]`,
- statusCode: http.StatusOK,
- mockParams: mockParams{
- chatRoomRetrieverParams: chatRoomRetrieverParams{
- allChatRoomsParams: allChatRoomsParams{
- {
- exchange: state.PublicExchange,
- result: []state.ChatRoom{
- chatRoom1,
- chatRoom2,
- },
- },
- },
- },
- chatSessionRetrieverParams: chatSessionRetrieverParams{
- chatSessionRetrieverAllSessionsParams: chatSessionRetrieverAllSessionsParams{
- {
- cookie: chatRoom1.Cookie(),
- result: []*state.Session{
- fnNewSess("userA"),
- fnNewSess("userB"),
- },
- },
- {
- cookie: chatRoom2.Cookie(),
- result: []*state.Session{
- fnNewSess("userC"),
- fnNewSess("userD"),
- },
- },
- },
- },
- },
- },
- {
- name: "chat room without participants",
- want: `[{"name":"chat-room-1-name","create_time":"0001-01-01T00:00:00Z","url":"aim:gochat?roomname=chat-room-1-name&exchange=5","participants":[]}]`,
- statusCode: http.StatusOK,
- mockParams: mockParams{
- chatRoomRetrieverParams: chatRoomRetrieverParams{
- allChatRoomsParams: allChatRoomsParams{
- {
- exchange: state.PublicExchange,
- result: []state.ChatRoom{
- chatRoom1,
- },
- },
- },
- },
- chatSessionRetrieverParams: chatSessionRetrieverParams{
- chatSessionRetrieverAllSessionsParams: chatSessionRetrieverAllSessionsParams{
- {
- cookie: chatRoom1.Cookie(),
- result: []*state.Session{},
- },
- },
- },
- },
- },
- {
- name: "no chat rooms",
- want: `[]`,
- statusCode: http.StatusOK,
- mockParams: mockParams{
- chatRoomRetrieverParams: chatRoomRetrieverParams{
- allChatRoomsParams: allChatRoomsParams{
- {
- exchange: state.PublicExchange,
- result: []state.ChatRoom{},
- },
- },
- },
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- request := httptest.NewRequest(http.MethodGet, "/chat/room/public", nil)
- responseRecorder := httptest.NewRecorder()
- chatRoomRetriever := newMockChatRoomRetriever(t)
- for _, params := range tc.mockParams.allChatRoomsParams {
- chatRoomRetriever.EXPECT().
- AllChatRooms(matchContext(), params.exchange).
- Return(params.result, params.err)
- }
- chatSessionRetriever := newMockChatSessionRetriever(t)
- for _, params := range tc.mockParams.chatSessionRetrieverAllSessionsParams {
- chatSessionRetriever.EXPECT().
- AllSessions(params.cookie).
- Return(params.result)
- }
- getPublicChatHandler(responseRecorder, request, chatRoomRetriever, chatSessionRetriever, slog.Default())
- if responseRecorder.Code != tc.statusCode {
- t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
- }
- if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
- t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
- }
- })
- }
- }
- func TestDeletePublicChatHandler(t *testing.T) {
- tt := []struct {
- name string
- body string
- want string
- statusCode int
- mockParams mockParams
- }{
- {
- name: "successful deletion of single chat room",
- body: `{"names":["TestRoom"]}`,
- want: `Chat rooms deleted successfully.`,
- statusCode: http.StatusNoContent,
- mockParams: mockParams{
- chatRoomDeleterParams: chatRoomDeleterParams{
- deleteChatRoomsParams: deleteChatRoomsParams{
- {
- exchange: state.PublicExchange,
- names: []string{"TestRoom"},
- },
- },
- },
- },
- },
- {
- name: "successful deletion of multiple chat rooms",
- body: `{"names":["Room1", "Room2", "Room3"]}`,
- want: `Chat rooms deleted successfully.`,
- statusCode: http.StatusNoContent,
- mockParams: mockParams{
- chatRoomDeleterParams: chatRoomDeleterParams{
- deleteChatRoomsParams: deleteChatRoomsParams{
- {
- exchange: state.PublicExchange,
- names: []string{"Room1", "Room2", "Room3"},
- },
- },
- },
- },
- },
- {
- name: "empty names array",
- body: `{"names":[]}`,
- want: `no chat room names provided`,
- statusCode: http.StatusBadRequest,
- },
- {
- name: "malformed JSON",
- body: `{"names":["Room1"`, // missing closing brackets
- want: `malformed input`,
- statusCode: http.StatusBadRequest,
- },
- {
- name: "deletion error",
- body: `{"names":["TestRoom"]}`,
- want: `internal server error`,
- statusCode: http.StatusInternalServerError,
- mockParams: mockParams{
- chatRoomDeleterParams: chatRoomDeleterParams{
- deleteChatRoomsParams: deleteChatRoomsParams{
- {
- exchange: state.PublicExchange,
- names: []string{"TestRoom"},
- err: errors.New("database error"),
- },
- },
- },
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- request := httptest.NewRequest(http.MethodDelete, "/chat/room/public", strings.NewReader(tc.body))
- responseRecorder := httptest.NewRecorder()
- chatRoomDeleter := newMockChatRoomDeleter(t)
- for _, params := range tc.mockParams.deleteChatRoomsParams {
- chatRoomDeleter.EXPECT().
- DeleteChatRooms(matchContext(), params.exchange, params.names).
- Return(params.err)
- }
- deletePublicChatHandler(responseRecorder, request, chatRoomDeleter, slog.Default())
- if responseRecorder.Code != tc.statusCode {
- t.Errorf("want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
- }
- if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
- t.Errorf("want '%s', got '%s'", tc.want, responseRecorder.Body)
- }
- })
- }
- }
- func TestPrivateChatHandler_GET(t *testing.T) {
- fnNewSess := func(screenName string) *state.Session {
- sess := state.NewSession()
- sess.SetIdentScreenName(state.NewIdentScreenName(screenName))
- sess.SetDisplayScreenName(state.DisplayScreenName(screenName))
- instance := sess.AddInstance()
- instance.SetSignonComplete()
- return sess
- }
- chatRoom1 := state.NewChatRoom("chat-room-1-name", state.NewIdentScreenName("chat-room-1-creator"), state.PrivateExchange)
- chatRoom2 := state.NewChatRoom("chat-room-2-name", state.NewIdentScreenName("chat-room-2-creator"), state.PrivateExchange)
- tt := []struct {
- name string
- want string
- statusCode int
- mockParams mockParams
- }{
- {
- name: "multiple chat rooms with participants",
- want: `[{"name":"chat-room-1-name","create_time":"0001-01-01T00:00:00Z","creator_id":"chat-room-1-creator","url":"aim:gochat?roomname=chat-room-1-name&exchange=4","participants":[{"id":"usera","screen_name":"userA"},{"id":"userb","screen_name":"userB"}]},{"name":"chat-room-2-name","create_time":"0001-01-01T00:00:00Z","creator_id":"chat-room-2-creator","url":"aim:gochat?roomname=chat-room-2-name&exchange=4","participants":[{"id":"userc","screen_name":"userC"},{"id":"userd","screen_name":"userD"}]}]`,
- statusCode: http.StatusOK,
- mockParams: mockParams{
- chatRoomRetrieverParams: chatRoomRetrieverParams{
- allChatRoomsParams: allChatRoomsParams{
- {
- exchange: state.PrivateExchange,
- result: []state.ChatRoom{
- chatRoom1,
- chatRoom2,
- },
- },
- },
- },
- chatSessionRetrieverParams: chatSessionRetrieverParams{
- chatSessionRetrieverAllSessionsParams: chatSessionRetrieverAllSessionsParams{
- {
- cookie: chatRoom1.Cookie(),
- result: []*state.Session{
- fnNewSess("userA"),
- fnNewSess("userB"),
- },
- },
- {
- cookie: chatRoom2.Cookie(),
- result: []*state.Session{
- fnNewSess("userC"),
- fnNewSess("userD"),
- },
- },
- },
- },
- },
- },
- {
- name: "chat room without participants",
- want: `[{"name":"chat-room-1-name","create_time":"0001-01-01T00:00:00Z","creator_id":"chat-room-1-creator","url":"aim:gochat?roomname=chat-room-1-name&exchange=4","participants":[]}]`,
- statusCode: http.StatusOK,
- mockParams: mockParams{
- chatRoomRetrieverParams: chatRoomRetrieverParams{
- allChatRoomsParams: allChatRoomsParams{
- {
- exchange: state.PrivateExchange,
- result: []state.ChatRoom{
- chatRoom1,
- },
- },
- },
- },
- chatSessionRetrieverParams: chatSessionRetrieverParams{
- chatSessionRetrieverAllSessionsParams: chatSessionRetrieverAllSessionsParams{
- {
- cookie: chatRoom1.Cookie(),
- result: []*state.Session{},
- },
- },
- },
- },
- },
- {
- name: "no chat rooms",
- want: `[]`,
- statusCode: http.StatusOK,
- mockParams: mockParams{
- chatRoomRetrieverParams: chatRoomRetrieverParams{
- allChatRoomsParams: allChatRoomsParams{
- {
- exchange: state.PrivateExchange,
- result: []state.ChatRoom{},
- },
- },
- },
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- request := httptest.NewRequest(http.MethodGet, "/chat/room/private", nil)
- responseRecorder := httptest.NewRecorder()
- chatRoomRetriever := newMockChatRoomRetriever(t)
- for _, params := range tc.mockParams.allChatRoomsParams {
- chatRoomRetriever.EXPECT().
- AllChatRooms(matchContext(), params.exchange).
- Return(params.result, params.err)
- }
- chatSessionRetriever := newMockChatSessionRetriever(t)
- for _, params := range tc.mockParams.chatSessionRetrieverAllSessionsParams {
- chatSessionRetriever.EXPECT().
- AllSessions(params.cookie).
- Return(params.result)
- }
- getPrivateChatHandler(responseRecorder, request, chatRoomRetriever, chatSessionRetriever, slog.Default())
- if responseRecorder.Code != tc.statusCode {
- t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
- }
- if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
- t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
- }
- })
- }
- }
- func TestInstantMessageHandler_POST(t *testing.T) {
- type relayToScreenNameInputs struct {
- sender state.IdentScreenName
- recipient state.IdentScreenName
- msg string
- }
- tt := []struct {
- name string
- relayToScreenNameInputs []relayToScreenNameInputs
- body string
- want string
- statusCode int
- }{
- {
- name: "send an instant message",
- relayToScreenNameInputs: []relayToScreenNameInputs{
- {
- sender: state.NewIdentScreenName("sender_sn"),
- recipient: state.NewIdentScreenName("recip_sn"),
- msg: "hello world!",
- },
- },
- body: `{"from":"sender_sn","to":"recip_sn","text":"hello world!"}`,
- want: `Message sent successfully.`,
- statusCode: http.StatusOK,
- },
- {
- name: "with malformed body",
- body: `{"screen_name":"userA", "password":"thepassword"`,
- want: `malformed input`,
- statusCode: http.StatusBadRequest,
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- request := httptest.NewRequest(http.MethodPost, "/user", strings.NewReader(tc.body))
- responseRecorder := httptest.NewRecorder()
- messageRelayer := newMockMessageRelayer(t)
- for _, params := range tc.relayToScreenNameInputs {
- validateSNAC := func(msg wire.SNACMessage) bool {
- body := msg.Body.(wire.SNAC_0x04_0x07_ICBMChannelMsgToClient)
- assert.Equal(t, params.sender.String(), body.ScreenName)
- b, ok := body.Bytes(wire.ICBMTLVAOLIMData)
- assert.True(t, ok)
- txt, err := wire.UnmarshalICBMMessageText(b)
- assert.NoError(t, err)
- assert.Equal(t, params.msg, txt)
- return true
- }
- messageRelayer.EXPECT().
- RelayToScreenName(mock.Anything, params.recipient, mock.MatchedBy(validateSNAC))
- }
- postInstantMessageHandler(responseRecorder, request, messageRelayer, slog.Default())
- if responseRecorder.Code != tc.statusCode {
- t.Errorf("want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
- }
- if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
- t.Errorf("want '%s', got '%s'", tc.want, responseRecorder.Body)
- }
- })
- }
- }
- func TestVersionHandler_GET(t *testing.T) {
- tt := []struct {
- name string
- want string
- statusCode int
- buildInfo config.Build
- }{
- {
- name: "get ras version",
- want: `{"version":"13.3.7","commit":"asdfASDF12345678","date":"2024-03-01"}`,
- statusCode: http.StatusOK,
- buildInfo: config.Build{
- Version: "13.3.7",
- Commit: "asdfASDF12345678",
- Date: "2024-03-01",
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- responseRecorder := httptest.NewRecorder()
- getVersionHandler(responseRecorder, tc.buildInfo)
- if responseRecorder.Code != tc.statusCode {
- t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
- }
- if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
- t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
- }
- })
- }
- }
- func TestDirectoryCategoryHandler_GET(t *testing.T) {
- tt := []struct {
- name string
- want string
- statusCode int
- mockParams mockParams
- }{
- {
- name: "no categories",
- want: `[]`,
- statusCode: http.StatusOK,
- mockParams: mockParams{
- directoryManagerParams: directoryManagerParams{
- categoriesParams: categoriesParams{
- {
- result: nil,
- },
- },
- },
- },
- },
- {
- name: "error fetching categories",
- want: `{"message":"internal server error"}`,
- statusCode: http.StatusInternalServerError,
- mockParams: mockParams{
- directoryManagerParams: directoryManagerParams{
- categoriesParams: categoriesParams{
- {
- result: nil,
- err: errors.New("error fetching categories"),
- },
- },
- },
- },
- },
- {
- name: "fetch some categories",
- want: `[{"id":1,"name":"category-1"},{"id":2,"name":"category-2"}]`,
- statusCode: http.StatusOK,
- mockParams: mockParams{
- directoryManagerParams: directoryManagerParams{
- categoriesParams: categoriesParams{
- {
- result: []state.Category{
- {
- ID: 1,
- Name: "category-1",
- },
- {
- ID: 2,
- Name: "category-2",
- },
- },
- },
- },
- },
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- responseRecorder := httptest.NewRecorder()
- request := httptest.NewRequest(http.MethodGet, "/directory/category", nil)
- directoryManager := newMockDirectoryManager(t)
- for _, params := range tc.mockParams.categoriesParams {
- directoryManager.EXPECT().
- Categories(matchContext()).
- Return(params.result, params.err)
- }
- getDirectoryCategoryHandler(responseRecorder, request, directoryManager, slog.Default())
- if responseRecorder.Code != tc.statusCode {
- t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
- }
- if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
- t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
- }
- })
- }
- }
- func TestDirectoryCategoryKeywordHandler_GET(t *testing.T) {
- tt := []struct {
- name string
- categoryID int
- want string
- statusCode int
- mockParams mockParams
- }{
- {
- name: "category not found",
- categoryID: 1,
- want: `{"message":"category not found"}`,
- statusCode: http.StatusNotFound,
- mockParams: mockParams{
- directoryManagerParams: directoryManagerParams{
- keywordsByCategoryParams: keywordsByCategoryParams{
- {
- categoryID: 1,
- result: nil,
- err: state.ErrKeywordCategoryNotFound,
- },
- },
- },
- },
- },
- {
- name: "error fetching keywords by category",
- categoryID: 1,
- want: `{"message":"internal server error"}`,
- statusCode: http.StatusInternalServerError,
- mockParams: mockParams{
- directoryManagerParams: directoryManagerParams{
- keywordsByCategoryParams: keywordsByCategoryParams{
- {
- categoryID: 1,
- result: nil,
- err: errors.New("error fetching keywords by category"),
- },
- },
- },
- },
- },
- {
- name: "invalid category ID",
- categoryID: -1,
- want: `{"message":"invalid category ID"}`,
- statusCode: http.StatusBadRequest,
- mockParams: mockParams{
- directoryManagerParams: directoryManagerParams{
- keywordsByCategoryParams: keywordsByCategoryParams{},
- },
- },
- },
- {
- name: "no keywords",
- categoryID: 1,
- want: `[]`,
- statusCode: http.StatusOK,
- mockParams: mockParams{
- directoryManagerParams: directoryManagerParams{
- keywordsByCategoryParams: keywordsByCategoryParams{
- {
- categoryID: 1,
- result: nil,
- },
- },
- },
- },
- },
- {
- name: "fetch some keywords by category",
- categoryID: 1,
- want: `[{"id":1,"name":"keyword-1"},{"id":2,"name":"keyword-2"}]`,
- statusCode: http.StatusOK,
- mockParams: mockParams{
- directoryManagerParams: directoryManagerParams{
- keywordsByCategoryParams: keywordsByCategoryParams{
- {
- categoryID: 1,
- result: []state.Keyword{
- {
- ID: 1,
- Name: "keyword-1",
- },
- {
- ID: 2,
- Name: "keyword-2",
- },
- },
- },
- },
- },
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- request := httptest.NewRequest(http.MethodGet, fmt.Sprintf("/directory/category/%d/keyword", tc.categoryID), nil)
- request.SetPathValue("id", fmt.Sprintf("%d", tc.categoryID))
- responseRecorder := httptest.NewRecorder()
- directoryManager := newMockDirectoryManager(t)
- for _, params := range tc.mockParams.keywordsByCategoryParams {
- directoryManager.EXPECT().
- KeywordsByCategory(matchContext(), params.categoryID).
- Return(params.result, params.err)
- }
- getDirectoryCategoryKeywordHandler(responseRecorder, request, directoryManager, slog.Default())
- if responseRecorder.Code != tc.statusCode {
- t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
- }
- if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
- t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
- }
- })
- }
- }
- func TestDirectoryCategoryHandler_DELETE(t *testing.T) {
- tt := []struct {
- name string
- categoryID int
- want string
- statusCode int
- mockParams mockParams
- }{
- {
- name: "category not found",
- categoryID: 1,
- want: `{"message":"category not found"}`,
- statusCode: http.StatusNotFound,
- mockParams: mockParams{
- directoryManagerParams: directoryManagerParams{
- deleteCategoryParams: deleteCategoryParams{
- {
- categoryID: 1,
- err: state.ErrKeywordCategoryNotFound,
- },
- },
- },
- },
- },
- {
- name: "keyword in use by user",
- categoryID: 1,
- want: `{"message":"can't delete because category in use by a user"}`,
- statusCode: http.StatusConflict,
- mockParams: mockParams{
- directoryManagerParams: directoryManagerParams{
- deleteCategoryParams: deleteCategoryParams{
- {
- categoryID: 1,
- err: state.ErrKeywordInUse,
- },
- },
- },
- },
- },
- {
- name: "runtime error",
- categoryID: 1,
- want: `{"message":"internal server error"}`,
- statusCode: http.StatusInternalServerError,
- mockParams: mockParams{
- directoryManagerParams: directoryManagerParams{
- deleteCategoryParams: deleteCategoryParams{
- {
- categoryID: 1,
- err: errors.New("error deleting keyword"),
- },
- },
- },
- },
- },
- {
- name: "successful deletion",
- categoryID: 1,
- want: ``,
- statusCode: http.StatusNoContent,
- mockParams: mockParams{
- directoryManagerParams: directoryManagerParams{
- deleteCategoryParams: deleteCategoryParams{
- {
- categoryID: 1,
- },
- },
- },
- },
- },
- {
- name: "invalid category ID",
- categoryID: -1,
- want: `invalid category ID`,
- statusCode: http.StatusBadRequest,
- mockParams: mockParams{
- directoryManagerParams: directoryManagerParams{
- deleteCategoryParams: deleteCategoryParams{},
- },
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- request := httptest.NewRequest(http.MethodDelete, fmt.Sprintf("/directory/category/%d/keyword", tc.categoryID), nil)
- request.SetPathValue("id", fmt.Sprintf("%d", tc.categoryID))
- responseRecorder := httptest.NewRecorder()
- directoryManager := newMockDirectoryManager(t)
- for _, params := range tc.mockParams.deleteCategoryParams {
- directoryManager.EXPECT().
- DeleteCategory(matchContext(), params.categoryID).
- Return(params.err)
- }
- deleteDirectoryCategoryHandler(responseRecorder, request, directoryManager, slog.Default())
- if responseRecorder.Code != tc.statusCode {
- t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
- }
- if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
- t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
- }
- })
- }
- }
- func TestDirectoryCategoryHandler_POST(t *testing.T) {
- tt := []struct {
- name string
- body string
- want string
- statusCode int
- mockParams mockParams
- }{
- {
- name: "category already exists",
- body: `{"name":"the_category"}`,
- want: `{"message":"category already exists"}`,
- statusCode: http.StatusConflict,
- mockParams: mockParams{
- directoryManagerParams: directoryManagerParams{
- createCategoryParams: createCategoryParams{
- {
- name: "the_category",
- err: state.ErrKeywordCategoryExists,
- },
- },
- },
- },
- },
- {
- name: "runtime error",
- body: `{"name":"the_category"}`,
- want: `{"message":"internal server error"}`,
- statusCode: http.StatusInternalServerError,
- mockParams: mockParams{
- directoryManagerParams: directoryManagerParams{
- createCategoryParams: createCategoryParams{
- {
- name: "the_category",
- err: errors.New("error creating category"),
- },
- },
- },
- },
- },
- {
- name: "bad input",
- body: `{"name":"the_category"`,
- want: `{"message":"malformed input"}`,
- statusCode: http.StatusBadRequest,
- mockParams: mockParams{
- directoryManagerParams: directoryManagerParams{
- createCategoryParams: createCategoryParams{},
- },
- },
- },
- {
- name: "successful creation",
- body: `{"name":"the_category"}`,
- want: `{"id":1,"name":"the_category"}`,
- statusCode: http.StatusCreated,
- mockParams: mockParams{
- directoryManagerParams: directoryManagerParams{
- createCategoryParams: createCategoryParams{
- {
- name: "the_category",
- result: state.Category{
- ID: 1,
- Name: "the_category",
- },
- },
- },
- },
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- request := httptest.NewRequest(http.MethodPost, "/directory/category", strings.NewReader(tc.body))
- responseRecorder := httptest.NewRecorder()
- directoryManager := newMockDirectoryManager(t)
- for _, params := range tc.mockParams.createCategoryParams {
- directoryManager.EXPECT().
- CreateCategory(matchContext(), params.name).
- Return(params.result, params.err)
- }
- postDirectoryCategoryHandler(responseRecorder, request, directoryManager, slog.Default())
- if responseRecorder.Code != tc.statusCode {
- t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
- }
- if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
- t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
- }
- })
- }
- }
- func TestDirectoryKeywordHandler_POST(t *testing.T) {
- tt := []struct {
- name string
- body string
- want string
- statusCode int
- mockParams mockParams
- }{
- {
- name: "keyword already exists",
- body: `{"category_id":1,"name":"the_keyword"}`,
- want: `{"message":"keyword already exists"}`,
- statusCode: http.StatusConflict,
- mockParams: mockParams{
- directoryManagerParams: directoryManagerParams{
- createKeywordParams: createKeywordParams{
- {
- name: "the_keyword",
- categoryID: 1,
- err: state.ErrKeywordExists,
- },
- },
- },
- },
- },
- {
- name: "category not found",
- body: `{"category_id":1,"name":"the_keyword"}`,
- want: `{"message":"category not found"}`,
- statusCode: http.StatusNotFound,
- mockParams: mockParams{
- directoryManagerParams: directoryManagerParams{
- createKeywordParams: createKeywordParams{
- {
- name: "the_keyword",
- categoryID: 1,
- err: state.ErrKeywordCategoryNotFound,
- },
- },
- },
- },
- },
- {
- name: "runtime error",
- body: `{"category_id":1,"name":"the_keyword"}`,
- want: `{"message":"internal server error"}`,
- statusCode: http.StatusInternalServerError,
- mockParams: mockParams{
- directoryManagerParams: directoryManagerParams{
- createKeywordParams: createKeywordParams{
- {
- name: "the_keyword",
- categoryID: 1,
- err: errors.New("error creating keyword"),
- },
- },
- },
- },
- },
- {
- name: "bad input",
- body: `{"category_id":1,"name":"the_keyword"`,
- want: `{"message":"malformed input"}`,
- statusCode: http.StatusBadRequest,
- mockParams: mockParams{
- directoryManagerParams: directoryManagerParams{
- createKeywordParams: createKeywordParams{},
- },
- },
- },
- {
- name: "successful creation",
- body: `{"category_id":1,"name":"the_keyword"}`,
- want: `{"id":1,"name":"the_keyword"}`,
- statusCode: http.StatusCreated,
- mockParams: mockParams{
- directoryManagerParams: directoryManagerParams{
- createKeywordParams: createKeywordParams{
- {
- name: "the_keyword",
- categoryID: 1,
- result: state.Keyword{
- ID: 1,
- Name: "the_keyword",
- },
- },
- },
- },
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- request := httptest.NewRequest(http.MethodPost, "/directory/keyword", strings.NewReader(tc.body))
- responseRecorder := httptest.NewRecorder()
- directoryManager := newMockDirectoryManager(t)
- for _, params := range tc.mockParams.createKeywordParams {
- directoryManager.EXPECT().
- CreateKeyword(matchContext(), params.name, params.categoryID).
- Return(params.result, params.err)
- }
- postDirectoryKeywordHandler(responseRecorder, request, directoryManager, slog.Default())
- if responseRecorder.Code != tc.statusCode {
- t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
- }
- if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
- t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
- }
- })
- }
- }
- func TestDirectoryKeywordHandler_DELETE(t *testing.T) {
- tt := []struct {
- name string
- categoryID int
- want string
- statusCode int
- mockParams mockParams
- }{
- {
- name: "keyword not found",
- categoryID: 1,
- want: `{"message":"keyword not found"}`,
- statusCode: http.StatusNotFound,
- mockParams: mockParams{
- directoryManagerParams: directoryManagerParams{
- deleteKeywordParams: deleteKeywordParams{
- {
- id: 1,
- err: state.ErrKeywordNotFound,
- },
- },
- },
- },
- },
- {
- name: "keyword in use by user",
- categoryID: 1,
- want: `{"message":"can't delete because category in use by a user"}`,
- statusCode: http.StatusConflict,
- mockParams: mockParams{
- directoryManagerParams: directoryManagerParams{
- deleteKeywordParams: deleteKeywordParams{
- {
- id: 1,
- err: state.ErrKeywordInUse,
- },
- },
- },
- },
- },
- {
- name: "runtime error",
- categoryID: 1,
- want: `{"message":"internal server error"}`,
- statusCode: http.StatusInternalServerError,
- mockParams: mockParams{
- directoryManagerParams: directoryManagerParams{
- deleteKeywordParams: deleteKeywordParams{
- {
- id: 1,
- err: errors.New("error deleting keyword"),
- },
- },
- },
- },
- },
- {
- name: "successful deletion",
- categoryID: 1,
- want: ``,
- statusCode: http.StatusNoContent,
- mockParams: mockParams{
- directoryManagerParams: directoryManagerParams{
- deleteKeywordParams: deleteKeywordParams{
- {
- id: 1,
- },
- },
- },
- },
- },
- {
- name: "invalid keyword ID",
- categoryID: -1,
- want: `{"message":"invalid keyword ID"}`,
- statusCode: http.StatusBadRequest,
- mockParams: mockParams{
- directoryManagerParams: directoryManagerParams{
- deleteKeywordParams: deleteKeywordParams{},
- },
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- request := httptest.NewRequest(http.MethodDelete, fmt.Sprintf("/directory/keyword/%d", tc.categoryID), nil)
- request.SetPathValue("id", fmt.Sprintf("%d", tc.categoryID))
- responseRecorder := httptest.NewRecorder()
- directoryManager := newMockDirectoryManager(t)
- for _, params := range tc.mockParams.deleteKeywordParams {
- directoryManager.EXPECT().
- DeleteKeyword(matchContext(), params.id).
- Return(params.err)
- }
- deleteDirectoryKeywordHandler(responseRecorder, request, directoryManager, slog.Default())
- if responseRecorder.Code != tc.statusCode {
- t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
- }
- if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
- t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
- }
- })
- }
- }
- func TestBARTByTypeHandler_GET(t *testing.T) {
- tt := []struct {
- name string
- queryParams string
- wantStatusCode int
- wantResponse string
- mockParams mockParams
- }{
- {
- name: "success with items",
- queryParams: "?type=1",
- wantStatusCode: http.StatusOK,
- wantResponse: `[{"hash":"2B000001E4","type":1},{"hash":"2B000001B7","type":1}]`,
- mockParams: mockParams{
- bartAssetManagerParams: bartAssetManagerParams{
- listBARTItemsParams: listBARTItemsParams{
- {
- itemType: 1,
- result: []state.BARTItem{
- {Hash: "2B000001E4", Type: 1},
- {Hash: "2B000001B7", Type: 1},
- },
- err: nil,
- },
- },
- },
- },
- },
- {
- name: "success with empty list",
- queryParams: "?type=2",
- wantStatusCode: http.StatusOK,
- wantResponse: `[]`,
- mockParams: mockParams{
- bartAssetManagerParams: bartAssetManagerParams{
- listBARTItemsParams: listBARTItemsParams{
- {
- itemType: 2,
- result: []state.BARTItem{},
- err: nil,
- },
- },
- },
- },
- },
- {
- name: "missing type parameter",
- queryParams: "",
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"type query parameter is required"}`,
- },
- {
- name: "invalid type parameter",
- queryParams: "?type=invalid",
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"invalid type ID"}`,
- },
- {
- name: "internal server error",
- queryParams: "?type=1",
- wantStatusCode: http.StatusInternalServerError,
- wantResponse: `{"message":"internal server error"}`,
- mockParams: mockParams{
- bartAssetManagerParams: bartAssetManagerParams{
- listBARTItemsParams: listBARTItemsParams{
- {
- itemType: 1,
- result: nil,
- err: errors.New("database error"),
- },
- },
- },
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- request := httptest.NewRequest(http.MethodGet, "/bart"+tc.queryParams, nil)
- responseRecorder := httptest.NewRecorder()
- mockBARTManager := newMockBARTAssetManager(t)
- for _, params := range tc.mockParams.listBARTItemsParams {
- mockBARTManager.EXPECT().
- ListBARTItems(matchContext(), params.itemType).
- Return(params.result, params.err)
- }
- getBARTByTypeHandler(responseRecorder, request, mockBARTManager, slog.Default())
- assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
- assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
- })
- }
- }
- func TestBARTHandler_GET(t *testing.T) {
- tt := []struct {
- name string
- hash string
- wantStatusCode int
- wantResponse string
- wantHeaders map[string]string
- mockParams mockParams
- }{
- {
- name: "success with valid hash",
- hash: "2B000001E4",
- wantStatusCode: http.StatusOK,
- wantResponse: "binary data",
- wantHeaders: map[string]string{"Content-Type": "application/octet-stream"},
- mockParams: mockParams{
- bartAssetManagerParams: bartAssetManagerParams{
- bartItemParams: bartItemParams{
- {
- hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
- result: []byte("binary data"),
- err: nil,
- },
- },
- },
- },
- },
- {
- name: "missing hash parameter",
- hash: "",
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"hash is required"}`,
- },
- {
- name: "invalid hash format",
- hash: "invalid-hex",
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"invalid hash format"}`,
- },
- {
- name: "asset not found",
- hash: "2B000001E4",
- wantStatusCode: http.StatusNotFound,
- wantResponse: `{"message":"BART asset not found"}`,
- mockParams: mockParams{
- bartAssetManagerParams: bartAssetManagerParams{
- bartItemParams: bartItemParams{
- {
- hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
- result: []byte{},
- err: nil,
- },
- },
- },
- },
- },
- {
- name: "internal server error",
- hash: "2B000001E4",
- wantStatusCode: http.StatusInternalServerError,
- wantResponse: `{"message":"internal server error"}`,
- mockParams: mockParams{
- bartAssetManagerParams: bartAssetManagerParams{
- bartItemParams: bartItemParams{
- {
- hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
- result: nil,
- err: errors.New("database error"),
- },
- },
- },
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- request := httptest.NewRequest(http.MethodGet, "/bart/"+tc.hash, nil)
- // Set the path value manually for testing
- if tc.hash != "" {
- request.SetPathValue("hash", tc.hash)
- }
- responseRecorder := httptest.NewRecorder()
- mockBARTManager := newMockBARTAssetManager(t)
- for _, params := range tc.mockParams.bartItemParams {
- mockBARTManager.EXPECT().
- BARTItem(matchContext(), params.hash).
- Return(params.result, params.err)
- }
- getBARTHandler(responseRecorder, request, mockBARTManager, slog.Default())
- assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
- if tc.wantHeaders != nil {
- for key, value := range tc.wantHeaders {
- assert.Equal(t, value, responseRecorder.Header().Get(key))
- }
- }
- if tc.wantStatusCode == http.StatusOK {
- assert.Equal(t, tc.wantResponse, responseRecorder.Body.String())
- } else {
- assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
- }
- })
- }
- }
- func TestBARTHandler_POST(t *testing.T) {
- tt := []struct {
- name string
- hash string
- queryParams string
- requestBody string
- wantStatusCode int
- wantResponse string
- mockParams mockParams
- }{
- {
- name: "success with valid data",
- hash: "2B000001E4",
- queryParams: "?type=1",
- requestBody: "binary data",
- wantStatusCode: http.StatusCreated,
- wantResponse: `{"hash":"2b000001e4","type":1}`,
- mockParams: mockParams{
- bartAssetManagerParams: bartAssetManagerParams{
- insertBARTItemParams: insertBARTItemParams{
- {
- hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
- blob: []byte("binary data"),
- itemType: 1,
- err: nil,
- },
- },
- },
- },
- },
- {
- name: "missing hash parameter",
- hash: "",
- queryParams: "?type=1",
- requestBody: "binary data",
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"hash path parameter is required"}`,
- },
- {
- name: "invalid hash format",
- hash: "invalid-hex",
- queryParams: "?type=1",
- requestBody: "binary data",
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"invalid hash format"}`,
- },
- {
- name: "missing type parameter",
- hash: "2B000001E4",
- queryParams: "",
- requestBody: "binary data",
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"type query parameter is required"}`,
- },
- {
- name: "invalid type parameter",
- hash: "2B000001E4",
- queryParams: "?type=invalid",
- requestBody: "binary data",
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"invalid type ID"}`,
- },
- {
- name: "failed to read request body",
- hash: "2B000001E4",
- queryParams: "?type=1",
- requestBody: "", // This will cause an error when reading
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"failed to read request body"}`,
- },
- {
- name: "asset already exists",
- hash: "2B000001E4",
- queryParams: "?type=1",
- requestBody: "binary data",
- wantStatusCode: http.StatusConflict,
- wantResponse: `{"message":"BART asset already exists"}`,
- mockParams: mockParams{
- bartAssetManagerParams: bartAssetManagerParams{
- insertBARTItemParams: insertBARTItemParams{
- {
- hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
- blob: []byte("binary data"),
- itemType: 1,
- err: state.ErrBARTItemExists,
- },
- },
- },
- },
- },
- {
- name: "internal server error",
- hash: "2B000001E4",
- queryParams: "?type=1",
- requestBody: "binary data",
- wantStatusCode: http.StatusInternalServerError,
- wantResponse: `{"message":"internal server error"}`,
- mockParams: mockParams{
- bartAssetManagerParams: bartAssetManagerParams{
- insertBARTItemParams: insertBARTItemParams{
- {
- hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
- blob: []byte("binary data"),
- itemType: 1,
- err: errors.New("database error"),
- },
- },
- },
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- var requestBody io.Reader
- if tc.requestBody != "" {
- requestBody = strings.NewReader(tc.requestBody)
- } else {
- requestBody = &errorReader{}
- }
- request := httptest.NewRequest(http.MethodPost, "/bart/"+tc.hash+tc.queryParams, requestBody)
- // Set the path value manually for testing
- if tc.hash != "" {
- request.SetPathValue("hash", tc.hash)
- }
- responseRecorder := httptest.NewRecorder()
- mockBARTManager := newMockBARTAssetManager(t)
- for _, params := range tc.mockParams.insertBARTItemParams {
- mockBARTManager.EXPECT().
- InsertBARTItem(matchContext(), params.hash, params.blob, params.itemType).
- Return(params.err)
- }
- postBARTHandler(responseRecorder, request, mockBARTManager, slog.Default())
- assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
- assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
- })
- }
- }
- func TestBARTHandler_DELETE(t *testing.T) {
- tt := []struct {
- name string
- hash string
- wantStatusCode int
- wantResponse string
- mockParams mockParams
- }{
- {
- name: "success with valid hash",
- hash: "2B000001E4",
- wantStatusCode: http.StatusOK,
- wantResponse: `{"message":"BART asset deleted successfully."}`,
- mockParams: mockParams{
- bartAssetManagerParams: bartAssetManagerParams{
- deleteBARTItemParams: deleteBARTItemParams{
- {
- hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
- err: nil,
- },
- },
- },
- },
- },
- {
- name: "missing hash parameter",
- hash: "",
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"hash path parameter is required"}`,
- },
- {
- name: "invalid hash format",
- hash: "invalid-hex",
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"invalid hash format"}`,
- },
- {
- name: "asset not found",
- hash: "2B000001E4",
- wantStatusCode: http.StatusNotFound,
- wantResponse: `{"message":"BART asset not found"}`,
- mockParams: mockParams{
- bartAssetManagerParams: bartAssetManagerParams{
- deleteBARTItemParams: deleteBARTItemParams{
- {
- hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
- err: state.ErrBARTItemNotFound,
- },
- },
- },
- },
- },
- {
- name: "internal server error",
- hash: "2B000001E4",
- wantStatusCode: http.StatusInternalServerError,
- wantResponse: `{"message":"internal server error"}`,
- mockParams: mockParams{
- bartAssetManagerParams: bartAssetManagerParams{
- deleteBARTItemParams: deleteBARTItemParams{
- {
- hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
- err: errors.New("database error"),
- },
- },
- },
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- request := httptest.NewRequest(http.MethodDelete, "/bart/"+tc.hash, nil)
- // Set the path value manually for testing
- if tc.hash != "" {
- request.SetPathValue("hash", tc.hash)
- }
- responseRecorder := httptest.NewRecorder()
- mockBARTManager := newMockBARTAssetManager(t)
- for _, params := range tc.mockParams.deleteBARTItemParams {
- mockBARTManager.EXPECT().
- DeleteBARTItem(matchContext(), params.hash).
- Return(params.err)
- }
- deleteBARTHandler(responseRecorder, request, mockBARTManager, slog.Default())
- assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
- assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
- })
- }
- }
- // errorReader is a helper type that always returns an error when reading
- type errorReader struct{}
- func (er *errorReader) Read(p []byte) (n int, err error) {
- return 0, errors.New("read error")
- }
- func TestFeedbagBuddyHandler_GET(t *testing.T) {
- tt := []struct {
- name string
- screenName string
- wantStatusCode int
- wantResponse string
- mockParams mockParams
- }{
- {
- name: "empty feedbag",
- screenName: "userA",
- wantStatusCode: http.StatusNotFound,
- wantResponse: `{"message":"feedbag not found"}`,
- mockParams: mockParams{
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: []wire.FeedbagItem{},
- err: nil,
- },
- },
- },
- },
- },
- {
- name: "feedbag with buddies in groups",
- screenName: "userA",
- wantStatusCode: http.StatusOK,
- wantResponse: `[{"group_id":1,"group_name":"Friends","buddies":[{"name":"buddy1","item_id":10},{"name":"buddy2","item_id":11}]},{"group_id":2,"group_name":"Work","buddies":[{"name":"buddy3","item_id":20}]}]`,
- mockParams: mockParams{
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: []wire.FeedbagItem{
- {
- ItemID: 0,
- ClassID: wire.FeedbagClassIdGroup,
- Name: "",
- GroupID: 0,
- },
- {
- ItemID: 1,
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{10, 11}),
- },
- },
- },
- {
- ItemID: 2,
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Work",
- GroupID: 2,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{20}),
- },
- },
- },
- {
- ItemID: 10,
- ClassID: wire.FeedbagClassIdBuddy,
- Name: "buddy1",
- GroupID: 1,
- },
- {
- ItemID: 11,
- ClassID: wire.FeedbagClassIdBuddy,
- Name: "buddy2",
- GroupID: 1,
- },
- {
- ItemID: 20,
- ClassID: wire.FeedbagClassIdBuddy,
- Name: "buddy3",
- GroupID: 2,
- },
- },
- err: nil,
- },
- },
- },
- },
- },
- {
- name: "feedbag with no groups (besides root)",
- screenName: "userA",
- wantStatusCode: http.StatusOK,
- wantResponse: `[]`,
- mockParams: mockParams{
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: []wire.FeedbagItem{
- {
- ItemID: 0,
- ClassID: wire.FeedbagClassIdGroup,
- Name: "",
- GroupID: 0,
- },
- },
- err: nil,
- },
- },
- },
- },
- // Note: Root groups (GroupID == 0) are skipped by the implementation,
- // so the response will be an empty array []
- },
- {
- name: "missing screen_name",
- screenName: "",
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"screen_name is required"}`,
- },
- {
- name: "internal server error",
- screenName: "userA",
- wantStatusCode: http.StatusInternalServerError,
- wantResponse: `{"message":"internal server error"}`,
- mockParams: mockParams{
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: nil,
- err: errors.New("database error"),
- },
- },
- },
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- request := httptest.NewRequest(http.MethodGet, "/feedbag/"+tc.screenName+"/group", nil)
- if tc.screenName != "" {
- request.SetPathValue("screen_name", tc.screenName)
- }
- responseRecorder := httptest.NewRecorder()
- feedbagManager := newMockFeedbagManager(t)
- for _, params := range tc.mockParams.feedbagParams {
- feedbagManager.EXPECT().
- Feedbag(matchContext(), params.screenName).
- Return(params.result, params.err)
- }
- getFeedbagBuddyHandler(responseRecorder, request, feedbagManager, slog.Default())
- assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
- assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
- })
- }
- }
- func TestFeedbagGroupHandler_PUT(t *testing.T) {
- tt := []struct {
- name string
- screenName string
- groupName string
- groupIDGen func(n int) int
- wantStatusCode int
- wantResponse string
- mockParams mockParams
- }{
- {
- name: "add group to empty feedbag",
- screenName: "userA",
- groupName: "Friends",
- groupIDGen: func(n int) int { return 5 },
- wantStatusCode: http.StatusCreated,
- wantResponse: `{"group_id":5,"group_name":"Friends"}`,
- mockParams: mockParams{
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: []wire.FeedbagItem{},
- err: nil,
- },
- },
- feedbagUpsertParams: feedbagUpsertParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- items: []wire.FeedbagItem{
- {
- ClassID: wire.FeedbagClassIdGroup,
- GroupID: 0,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{5}),
- },
- },
- },
- {
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 5,
- },
- },
- err: nil,
- },
- },
- },
- messageRelayerParams: messageRelayerParams{
- relayToScreenNameParams: relayToScreenNameParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- msg: wire.SNACMessage{
- Frame: wire.SNACFrame{
- FoodGroup: wire.Feedbag,
- SubGroup: wire.FeedbagInsertItem,
- RequestID: wire.ReqIDFromServer,
- },
- Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
- Items: []wire.FeedbagItem{
- {
- ClassID: wire.FeedbagClassIdGroup,
- GroupID: 0,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{5}),
- },
- },
- },
- {
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 5,
- },
- },
- },
- },
- },
- },
- },
- },
- },
- {
- name: "add group to feedbag with existing root",
- screenName: "userA",
- groupName: "Coworkers",
- groupIDGen: func(n int) int { return 2 },
- wantStatusCode: http.StatusCreated,
- wantResponse: `{"group_id":2,"group_name":"Coworkers"}`,
- mockParams: mockParams{
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: []wire.FeedbagItem{
- {
- ClassID: wire.FeedbagClassIdGroup,
- GroupID: 0,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1}),
- },
- },
- },
- {
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Buddies",
- GroupID: 1,
- },
- },
- err: nil,
- },
- },
- feedbagUpsertParams: feedbagUpsertParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- items: []wire.FeedbagItem{
- {
- ClassID: wire.FeedbagClassIdGroup,
- GroupID: 0,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1, 2}),
- },
- },
- },
- {
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Coworkers",
- GroupID: 2,
- },
- },
- err: nil,
- },
- },
- },
- messageRelayerParams: messageRelayerParams{
- relayToScreenNameParams: relayToScreenNameParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- msg: wire.SNACMessage{
- Frame: wire.SNACFrame{
- FoodGroup: wire.Feedbag,
- SubGroup: wire.FeedbagInsertItem,
- RequestID: wire.ReqIDFromServer,
- },
- Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
- Items: []wire.FeedbagItem{
- {
- ClassID: wire.FeedbagClassIdGroup,
- GroupID: 0,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1, 2}),
- },
- },
- },
- {
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Coworkers",
- GroupID: 2,
- },
- },
- },
- },
- },
- },
- },
- },
- },
- {
- name: "group already exists",
- screenName: "userA",
- groupName: "Friends",
- groupIDGen: func(n int) int { return 99 },
- wantStatusCode: http.StatusOK,
- wantResponse: `{"group_id":1,"group_name":"Friends"}`,
- mockParams: mockParams{
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: []wire.FeedbagItem{
- {
- ClassID: wire.FeedbagClassIdGroup,
- GroupID: 0,
- },
- {
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- },
- },
- err: nil,
- },
- },
- },
- },
- },
- {
- name: "missing screen_name",
- screenName: "",
- groupName: "Friends",
- groupIDGen: func(n int) int { return 5 },
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"screen_name is required"}`,
- },
- {
- name: "missing group_name",
- screenName: "userA",
- groupName: "",
- groupIDGen: func(n int) int { return 5 },
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"group_name is required"}`,
- },
- {
- name: "error retrieving feedbag",
- screenName: "userA",
- groupName: "Friends",
- groupIDGen: func(n int) int { return 5 },
- wantStatusCode: http.StatusInternalServerError,
- wantResponse: `{"message":"internal server error"}`,
- mockParams: mockParams{
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: nil,
- err: errors.New("database error"),
- },
- },
- },
- },
- },
- {
- name: "error upserting feedbag",
- screenName: "userA",
- groupName: "Friends",
- groupIDGen: func(n int) int { return 5 },
- wantStatusCode: http.StatusInternalServerError,
- wantResponse: `{"message":"internal server error"}`,
- mockParams: mockParams{
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: []wire.FeedbagItem{},
- err: nil,
- },
- },
- feedbagUpsertParams: feedbagUpsertParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- items: []wire.FeedbagItem{
- {
- ClassID: wire.FeedbagClassIdGroup,
- GroupID: 0,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{5}),
- },
- },
- },
- {
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 5,
- },
- },
- err: errors.New("database error"),
- },
- },
- },
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- request := httptest.NewRequest(http.MethodPut, "/feedbag/"+tc.screenName+"/group/"+tc.groupName, nil)
- if tc.screenName != "" {
- request.SetPathValue("screen_name", tc.screenName)
- }
- if tc.groupName != "" {
- request.SetPathValue("group_name", tc.groupName)
- }
- responseRecorder := httptest.NewRecorder()
- feedbagManager := newMockFeedbagManager(t)
- messageRelayer := newMockMessageRelayer(t)
- for _, params := range tc.mockParams.feedbagParams {
- feedbagManager.EXPECT().
- Feedbag(matchContext(), params.screenName).
- Return(params.result, params.err)
- }
- for _, params := range tc.mockParams.feedbagUpsertParams {
- feedbagManager.EXPECT().
- FeedbagUpsert(matchContext(), params.screenName, params.items).
- Return(params.err)
- }
- for _, params := range tc.mockParams.relayToScreenNameParams {
- messageRelayer.EXPECT().
- RelayToScreenName(matchContext(), params.screenName, params.msg)
- }
- putFeedbagGroupHandler(responseRecorder, request, feedbagManager, messageRelayer, slog.Default(), tc.groupIDGen)
- assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
- assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
- })
- }
- }
- func TestFeedbagBuddyHandler_PUT(t *testing.T) {
- tt := []struct {
- name string
- screenName string
- groupID string
- requestBody string
- wantStatusCode int
- wantResponse string
- mockParams mockParams
- }{
- {
- name: "add a buddy to an empty group, user not signed in",
- screenName: "userA",
- groupID: "1",
- requestBody: `{"name":"newbuddy"}`,
- wantStatusCode: http.StatusOK,
- wantResponse: `{"name":"newbuddy","group_id":1,"item_id":1000}`,
- mockParams: mockParams{
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: []wire.FeedbagItem{
- {
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- },
- },
- err: nil,
- },
- },
- feedbagUpsertParams: feedbagUpsertParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- items: []wire.FeedbagItem{
- {
- Name: "newbuddy",
- GroupID: 1,
- ItemID: 1000,
- ClassID: wire.FeedbagClassIdBuddy,
- },
- {
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1000}),
- },
- },
- },
- },
- err: nil,
- },
- },
- },
- sessionRetrieverParams: sessionRetrieverParams{
- retrieveSessionByNameParams: retrieveSessionByNameParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: state.NewSession(),
- },
- },
- },
- messageRelayerParams: messageRelayerParams{
- relayToScreenNameParams: relayToScreenNameParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- msg: wire.SNACMessage{
- Frame: wire.SNACFrame{
- FoodGroup: wire.Feedbag,
- SubGroup: wire.FeedbagInsertItem,
- RequestID: wire.ReqIDFromServer,
- },
- Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
- Items: []wire.FeedbagItem{
- {
- Name: "newbuddy",
- GroupID: 1,
- ItemID: 1000,
- ClassID: wire.FeedbagClassIdBuddy,
- },
- },
- },
- },
- },
- {
- screenName: state.NewIdentScreenName("userA"),
- msg: wire.SNACMessage{
- Frame: wire.SNACFrame{
- FoodGroup: wire.Feedbag,
- SubGroup: wire.FeedbagUpdateItem,
- RequestID: wire.ReqIDFromServer,
- },
- Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
- Items: []wire.FeedbagItem{
- {
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1000}),
- },
- },
- },
- },
- },
- },
- },
- },
- },
- },
- },
- {
- name: "add a buddy to a non-empty group, user not signed in",
- screenName: "userA",
- groupID: "1",
- requestBody: `{"name":"newbuddy2"}`,
- wantStatusCode: http.StatusOK,
- wantResponse: `{"name":"newbuddy2","group_id":1,"item_id":1000}`,
- mockParams: mockParams{
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: []wire.FeedbagItem{
- {
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{12345}),
- },
- },
- },
- {
- ItemID: 12345,
- ClassID: wire.FeedbagClassIdBuddy,
- Name: "existingbuddy",
- GroupID: 1,
- },
- },
- err: nil,
- },
- },
- feedbagUpsertParams: feedbagUpsertParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- items: []wire.FeedbagItem{
- {
- Name: "newbuddy2",
- GroupID: 1,
- ItemID: 1000,
- ClassID: wire.FeedbagClassIdBuddy,
- },
- {
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{12345, 1000}),
- },
- },
- },
- },
- err: nil,
- },
- },
- },
- sessionRetrieverParams: sessionRetrieverParams{
- retrieveSessionByNameParams: retrieveSessionByNameParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: state.NewSession(),
- },
- },
- },
- messageRelayerParams: messageRelayerParams{
- relayToScreenNameParams: relayToScreenNameParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- msg: wire.SNACMessage{
- Frame: wire.SNACFrame{
- FoodGroup: wire.Feedbag,
- SubGroup: wire.FeedbagInsertItem,
- RequestID: wire.ReqIDFromServer,
- },
- Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
- Items: []wire.FeedbagItem{
- {
- Name: "newbuddy2",
- GroupID: 1,
- ItemID: 1000,
- ClassID: wire.FeedbagClassIdBuddy,
- },
- },
- },
- },
- },
- {
- screenName: state.NewIdentScreenName("userA"),
- msg: wire.SNACMessage{
- Frame: wire.SNACFrame{
- FoodGroup: wire.Feedbag,
- SubGroup: wire.FeedbagUpdateItem,
- RequestID: wire.ReqIDFromServer,
- },
- Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
- Items: []wire.FeedbagItem{
- {
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{12345, 1000}),
- },
- },
- },
- },
- },
- },
- },
- },
- },
- },
- },
- {
- name: "add a buddy that already exists in a group",
- screenName: "userA",
- groupID: "1",
- requestBody: `{"name":"ExistingBuddy"}`,
- wantStatusCode: http.StatusOK,
- wantResponse: `{"name":"ExistingBuddy","group_id":1,"item_id":12345}`,
- mockParams: mockParams{
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: []wire.FeedbagItem{
- {
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{12345}),
- },
- },
- },
- {
- ItemID: 12345,
- ClassID: wire.FeedbagClassIdBuddy,
- Name: "existingbuddy",
- GroupID: 1,
- },
- },
- err: nil,
- },
- },
- // No FeedbagUpsert should be called when buddy already exists
- },
- // No session retrieval or message relaying should occur
- },
- },
- {
- name: "add a buddy to an empty group, user signed in",
- screenName: "userA",
- groupID: "1",
- requestBody: `{"name":"newbuddy"}`,
- wantStatusCode: http.StatusOK,
- wantResponse: `{"name":"newbuddy","group_id":1,"item_id":1000}`,
- mockParams: mockParams{
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: []wire.FeedbagItem{
- {
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- },
- },
- err: nil,
- },
- },
- feedbagUpsertParams: feedbagUpsertParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- items: []wire.FeedbagItem{
- {
- Name: "newbuddy",
- GroupID: 1,
- ItemID: 1000,
- ClassID: wire.FeedbagClassIdBuddy,
- },
- {
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1000}),
- },
- },
- },
- },
- err: nil,
- },
- },
- },
- sessionRetrieverParams: sessionRetrieverParams{
- retrieveSessionByNameParams: retrieveSessionByNameParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: func() *state.Session {
- sess := state.NewSession()
- sess.SetIdentScreenName(state.NewIdentScreenName("userA"))
- inst := sess.AddInstance()
- inst.SetSignonComplete()
- return sess
- }(),
- },
- },
- },
- messageRelayerParams: messageRelayerParams{
- relayToScreenNameParams: relayToScreenNameParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- msg: wire.SNACMessage{
- Frame: wire.SNACFrame{
- FoodGroup: wire.Feedbag,
- SubGroup: wire.FeedbagInsertItem,
- RequestID: wire.ReqIDFromServer,
- },
- Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
- Items: []wire.FeedbagItem{
- {
- Name: "newbuddy",
- GroupID: 1,
- ItemID: 1000,
- ClassID: wire.FeedbagClassIdBuddy,
- },
- },
- },
- },
- },
- {
- screenName: state.NewIdentScreenName("userA"),
- msg: wire.SNACMessage{
- Frame: wire.SNACFrame{
- FoodGroup: wire.Feedbag,
- SubGroup: wire.FeedbagUpdateItem,
- RequestID: wire.ReqIDFromServer,
- },
- Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
- Items: []wire.FeedbagItem{
- {
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1000}),
- },
- },
- },
- },
- },
- },
- },
- },
- },
- buddyBroadcasterParams: buddyBroadcasterParams{
- broadcastVisibilityParams: broadcastVisibilityParams{
- {
- you: nil, // Not used in expectation, matched with mock.AnythingOfType
- filter: []state.IdentScreenName{state.NewIdentScreenName("newbuddy")},
- sendDepartures: false,
- err: nil,
- },
- },
- },
- },
- },
- {
- name: "invalid group_id - non-numeric",
- screenName: "userA",
- groupID: "invalid",
- requestBody: `{"name":"buddy"}`,
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"invalid group_id"}`,
- },
- {
- name: "invalid group_id - out of range",
- screenName: "userA",
- groupID: "99999",
- requestBody: `{"name":"buddy"}`,
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"invalid group_id"}`,
- },
- {
- name: "can't add buddies to root group",
- screenName: "userA",
- groupID: "0",
- requestBody: `{"name":"buddy"}`,
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"can't add buddies to root group"}`,
- },
- {
- name: "empty screen_name",
- screenName: "",
- groupID: "1",
- requestBody: `{"name":"buddy"}`,
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"screen_name is required"}`,
- },
- {
- name: "malformed JSON input",
- screenName: "userA",
- groupID: "1",
- requestBody: `invalid json`,
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"buddy_screen_name is required"}`,
- },
- {
- name: "empty name in request body",
- screenName: "userA",
- groupID: "1",
- requestBody: `{"name":""}`,
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"buddy_screen_name is required"}`,
- },
- {
- name: "missing name in request body",
- screenName: "userA",
- groupID: "1",
- requestBody: `{}`,
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"buddy_screen_name is required"}`,
- },
- {
- name: "invalid UIN - too low",
- screenName: "userA",
- groupID: "1",
- requestBody: `{"name":"9999"}`,
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"invalid uin: uin must be a number in the range 10000-2147483646"}`,
- },
- {
- name: "invalid UIN - too high",
- screenName: "userA",
- groupID: "1",
- requestBody: `{"name":"2147483647"}`,
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"invalid uin: uin must be a number in the range 10000-2147483646"}`,
- },
- {
- name: "invalid AIM handle - too short",
- screenName: "userA",
- groupID: "1",
- requestBody: `{"name":"Us"}`,
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"invalid screen name: screen name must be between 3 and 16 characters"}`,
- },
- {
- name: "invalid AIM handle - too long",
- screenName: "userA",
- groupID: "1",
- requestBody: `{"name":"ThisIsAReallyLongScreenName"}`,
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"invalid screen name: screen name must be between 3 and 16 characters"}`,
- },
- {
- name: "error retrieving feedbag",
- screenName: "userA",
- groupID: "1",
- requestBody: `{"name":"buddy"}`,
- wantStatusCode: http.StatusInternalServerError,
- wantResponse: `{"message":"internal server error"}`,
- mockParams: mockParams{
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: nil,
- err: errors.New("database error"),
- },
- },
- },
- },
- },
- {
- name: "too many buddies in group - max 30",
- screenName: "userA",
- groupID: "1",
- requestBody: `{"name":"newbuddy"}`,
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"too many buddies in group. max: 30"}`,
- mockParams: mockParams{
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: func() []wire.FeedbagItem {
- order := make([]uint16, 30)
- for i := 1; i <= 30; i++ {
- order[i-1] = uint16(i)
- }
- items := []wire.FeedbagItem{
- {
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, order),
- },
- },
- },
- }
- // Add 30 buddies to the group
- for i := 1; i <= 30; i++ {
- items = append(items, wire.FeedbagItem{
- ItemID: uint16(i),
- ClassID: wire.FeedbagClassIdBuddy,
- Name: fmt.Sprintf("buddy%d", i),
- GroupID: 1,
- })
- }
- return items
- }(),
- err: nil,
- },
- },
- },
- },
- },
- {
- name: "group not found",
- screenName: "userA",
- groupID: "999",
- requestBody: `{"name":"buddy"}`,
- wantStatusCode: http.StatusNotFound,
- wantResponse: `{"message":"group not found"}`,
- mockParams: mockParams{
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: []wire.FeedbagItem{
- {
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- },
- },
- err: nil,
- },
- },
- },
- },
- },
- {
- name: "error inserting feedbag item",
- screenName: "userA",
- groupID: "1",
- requestBody: `{"name":"buddy"}`,
- wantStatusCode: http.StatusInternalServerError,
- wantResponse: `{"message":"internal server error"}`,
- mockParams: mockParams{
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: []wire.FeedbagItem{
- {
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- },
- },
- err: nil,
- },
- },
- feedbagUpsertParams: feedbagUpsertParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- items: []wire.FeedbagItem{
- {
- Name: "buddy",
- GroupID: 1,
- ItemID: 1000,
- ClassID: wire.FeedbagClassIdBuddy,
- },
- {
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1000}),
- },
- },
- },
- },
- err: errors.New("database error"),
- },
- },
- },
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- // Extract buddy name from requestBody JSON
- var buddyName string
- if tc.requestBody != "" {
- var input struct {
- Name string `json:"name"`
- }
- if err := json.Unmarshal([]byte(tc.requestBody), &input); err == nil {
- buddyName = input.Name
- }
- }
- request := httptest.NewRequest(http.MethodPut, "/feedbag/"+tc.screenName+"/group/"+tc.groupID+"/buddy/"+buddyName, nil)
- if tc.screenName != "" {
- request.SetPathValue("screen_name", tc.screenName)
- }
- if tc.groupID != "" {
- request.SetPathValue("group_id", tc.groupID)
- }
- request.SetPathValue("buddy_screen_name", buddyName)
- responseRecorder := httptest.NewRecorder()
- feedbagManager := newMockFeedbagManager(t)
- sessionRetriever := newMockSessionRetriever(t)
- messageRelayer := newMockMessageRelayer(t)
- buddyBroadcaster := newMockBuddyBroadcaster(t)
- for _, params := range tc.mockParams.feedbagParams {
- feedbagManager.EXPECT().
- Feedbag(matchContext(), params.screenName).
- Return(params.result, params.err)
- }
- for _, params := range tc.mockParams.feedbagUpsertParams {
- feedbagManager.EXPECT().
- FeedbagUpsert(matchContext(), params.screenName, params.items).
- Return(params.err)
- }
- for _, params := range tc.mockParams.retrieveSessionByNameParams {
- sessionRetriever.EXPECT().
- RetrieveSession(params.screenName).
- Return(params.result)
- }
- for _, params := range tc.mockParams.relayToScreenNameParams {
- messageRelayer.EXPECT().
- RelayToScreenName(matchContext(), params.screenName, params.msg)
- }
- for _, params := range tc.mockParams.broadcastVisibilityParams {
- // Use mock.MatchedBy to match any SessionInstance, since we're mainly verifying filter and sendDepartures
- buddyBroadcaster.EXPECT().
- BroadcastVisibility(
- matchContext(),
- mock.AnythingOfType("*state.SessionInstance"),
- params.filter,
- params.sendDepartures,
- ).
- Return(params.err)
- }
- deterministicItemID := func(n int) int {
- return 1000
- }
- putFeedbagBuddyHandler(responseRecorder, request, buddyBroadcaster, feedbagManager, sessionRetriever, messageRelayer, slog.Default(), deterministicItemID)
- assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
- if tc.wantStatusCode == http.StatusOK {
- assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
- } else {
- assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
- }
- })
- }
- }
- func TestFeedbagBuddyHandler_DELETE(t *testing.T) {
- tt := []struct {
- name string
- screenName string
- groupID string
- requestBody string
- wantStatusCode int
- wantResponse string
- mockParams mockParams
- }{
- {
- name: "delete existing buddy, user not signed in",
- screenName: "userA",
- groupID: "1",
- requestBody: `{"name":"buddy1"}`,
- wantStatusCode: http.StatusNoContent,
- mockParams: mockParams{
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: []wire.FeedbagItem{
- {
- ItemID: 1,
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{10}),
- },
- },
- },
- {
- ItemID: 10,
- ClassID: wire.FeedbagClassIdBuddy,
- Name: "buddy1",
- GroupID: 1,
- },
- },
- err: nil,
- },
- },
- feedbagUpsertParams: feedbagUpsertParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- items: []wire.FeedbagItem{
- {
- ItemID: 1,
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{}),
- },
- },
- },
- },
- err: nil,
- },
- },
- feedbagDeleteParams: feedbagDeleteParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- items: []wire.FeedbagItem{
- {
- ItemID: 10,
- ClassID: wire.FeedbagClassIdBuddy,
- Name: "buddy1",
- GroupID: 1,
- },
- },
- err: nil,
- },
- },
- },
- sessionRetrieverParams: sessionRetrieverParams{
- retrieveSessionByNameParams: retrieveSessionByNameParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: state.NewSession(),
- },
- },
- },
- messageRelayerParams: messageRelayerParams{
- relayToScreenNameParams: relayToScreenNameParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- msg: wire.SNACMessage{
- Frame: wire.SNACFrame{
- FoodGroup: wire.Feedbag,
- SubGroup: wire.FeedbagUpdateItem,
- RequestID: wire.ReqIDFromServer,
- },
- Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
- Items: []wire.FeedbagItem{
- {
- ItemID: 1,
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{}),
- },
- },
- },
- },
- },
- },
- },
- {
- screenName: state.NewIdentScreenName("userA"),
- msg: wire.SNACMessage{
- Frame: wire.SNACFrame{
- FoodGroup: wire.Feedbag,
- SubGroup: wire.FeedbagDeleteItem,
- RequestID: wire.ReqIDFromServer,
- },
- Body: wire.SNAC_0x13_0x0A_FeedbagDeleteItem{
- Items: []wire.FeedbagItem{
- {
- ItemID: 10,
- ClassID: wire.FeedbagClassIdBuddy,
- Name: "buddy1",
- GroupID: 1,
- },
- },
- },
- },
- },
- },
- },
- },
- },
- {
- name: "delete existing buddy, user signed in",
- screenName: "userA",
- groupID: "1",
- requestBody: `{"name":"buddy1"}`,
- wantStatusCode: http.StatusNoContent,
- mockParams: mockParams{
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: []wire.FeedbagItem{
- {
- ItemID: 1,
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{10}),
- },
- },
- },
- {
- ItemID: 10,
- ClassID: wire.FeedbagClassIdBuddy,
- Name: "buddy1",
- GroupID: 1,
- },
- },
- err: nil,
- },
- },
- feedbagUpsertParams: feedbagUpsertParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- items: []wire.FeedbagItem{
- {
- ItemID: 1,
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{}),
- },
- },
- },
- },
- err: nil,
- },
- },
- feedbagDeleteParams: feedbagDeleteParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- items: []wire.FeedbagItem{
- {
- ItemID: 10,
- ClassID: wire.FeedbagClassIdBuddy,
- Name: "buddy1",
- GroupID: 1,
- },
- },
- err: nil,
- },
- },
- },
- sessionRetrieverParams: sessionRetrieverParams{
- retrieveSessionByNameParams: retrieveSessionByNameParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: func() *state.Session {
- sess := state.NewSession()
- sess.SetIdentScreenName(state.NewIdentScreenName("userA"))
- inst := sess.AddInstance()
- inst.SetSignonComplete()
- return sess
- }(),
- },
- },
- },
- messageRelayerParams: messageRelayerParams{
- relayToScreenNameParams: relayToScreenNameParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- msg: wire.SNACMessage{
- Frame: wire.SNACFrame{
- FoodGroup: wire.Feedbag,
- SubGroup: wire.FeedbagUpdateItem,
- RequestID: wire.ReqIDFromServer,
- },
- Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
- Items: []wire.FeedbagItem{
- {
- ItemID: 1,
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{}),
- },
- },
- },
- },
- },
- },
- },
- {
- screenName: state.NewIdentScreenName("userA"),
- msg: wire.SNACMessage{
- Frame: wire.SNACFrame{
- FoodGroup: wire.Feedbag,
- SubGroup: wire.FeedbagDeleteItem,
- RequestID: wire.ReqIDFromServer,
- },
- Body: wire.SNAC_0x13_0x0A_FeedbagDeleteItem{
- Items: []wire.FeedbagItem{
- {
- ItemID: 10,
- ClassID: wire.FeedbagClassIdBuddy,
- Name: "buddy1",
- GroupID: 1,
- },
- },
- },
- },
- },
- },
- },
- buddyBroadcasterParams: buddyBroadcasterParams{
- broadcastVisibilityParams: broadcastVisibilityParams{
- {
- you: nil, // Not used in expectation, matched with mock.AnythingOfType
- filter: []state.IdentScreenName{state.NewIdentScreenName("buddy1")},
- sendDepartures: true,
- err: nil,
- },
- },
- },
- },
- },
- {
- name: "delete buddy from a group with multiple buddies, user not signed in",
- screenName: "userA",
- groupID: "1",
- requestBody: `{"name":"buddy1"}`,
- wantStatusCode: http.StatusNoContent,
- mockParams: mockParams{
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: []wire.FeedbagItem{
- {
- ItemID: 1,
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{10, 20}),
- },
- },
- },
- {
- ItemID: 10,
- ClassID: wire.FeedbagClassIdBuddy,
- Name: "buddy1",
- GroupID: 1,
- },
- {
- ItemID: 20,
- ClassID: wire.FeedbagClassIdBuddy,
- Name: "buddy2",
- GroupID: 1,
- },
- },
- err: nil,
- },
- },
- feedbagUpsertParams: feedbagUpsertParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- items: []wire.FeedbagItem{
- {
- ItemID: 1,
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{20}),
- },
- },
- },
- },
- err: nil,
- },
- },
- feedbagDeleteParams: feedbagDeleteParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- items: []wire.FeedbagItem{
- {
- ItemID: 10,
- ClassID: wire.FeedbagClassIdBuddy,
- Name: "buddy1",
- GroupID: 1,
- },
- },
- err: nil,
- },
- },
- },
- sessionRetrieverParams: sessionRetrieverParams{
- retrieveSessionByNameParams: retrieveSessionByNameParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: state.NewSession(),
- },
- },
- },
- messageRelayerParams: messageRelayerParams{
- relayToScreenNameParams: relayToScreenNameParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- msg: wire.SNACMessage{
- Frame: wire.SNACFrame{
- FoodGroup: wire.Feedbag,
- SubGroup: wire.FeedbagUpdateItem,
- RequestID: wire.ReqIDFromServer,
- },
- Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
- Items: []wire.FeedbagItem{
- {
- ItemID: 1,
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{20}),
- },
- },
- },
- },
- },
- },
- },
- {
- screenName: state.NewIdentScreenName("userA"),
- msg: wire.SNACMessage{
- Frame: wire.SNACFrame{
- FoodGroup: wire.Feedbag,
- SubGroup: wire.FeedbagDeleteItem,
- RequestID: wire.ReqIDFromServer,
- },
- Body: wire.SNAC_0x13_0x0A_FeedbagDeleteItem{
- Items: []wire.FeedbagItem{
- {
- ItemID: 10,
- ClassID: wire.FeedbagClassIdBuddy,
- Name: "buddy1",
- GroupID: 1,
- },
- },
- },
- },
- },
- },
- },
- },
- },
- {
- name: "can't delete buddy from root group",
- screenName: "userA",
- groupID: "0",
- requestBody: `{"name":"rootbuddy"}`,
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"can't add buddies to root group"}`,
- },
- {
- name: "missing screen_name",
- screenName: "",
- groupID: "1",
- requestBody: `{"name":"buddy"}`,
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"screen_name is required"}`,
- },
- {
- name: "group not found",
- screenName: "userA",
- groupID: "999",
- requestBody: `{"name":"buddy"}`,
- wantStatusCode: http.StatusNotFound,
- wantResponse: `{"message":"group not found"}`,
- mockParams: mockParams{
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: []wire.FeedbagItem{
- {
- ItemID: 1,
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 0,
- },
- },
- err: nil,
- },
- },
- },
- },
- },
- {
- name: "invalid group_id",
- screenName: "userA",
- groupID: "invalid",
- requestBody: `{"name":"buddy"}`,
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"invalid group_id"}`,
- },
- {
- name: "malformed request body",
- screenName: "userA",
- groupID: "1",
- requestBody: `invalid json`,
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"buddy_screen_name is required"}`,
- },
- {
- name: "missing name in request body",
- screenName: "userA",
- groupID: "1",
- requestBody: `{}`,
- wantStatusCode: http.StatusBadRequest,
- wantResponse: `{"message":"buddy_screen_name is required"}`,
- },
- {
- name: "buddy not found",
- screenName: "userA",
- groupID: "1",
- requestBody: `{"name":"nonexistent"}`,
- wantStatusCode: http.StatusNotFound,
- wantResponse: `{"message":"buddy not found"}`,
- mockParams: mockParams{
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: []wire.FeedbagItem{
- {
- ItemID: 1,
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- },
- {
- ItemID: 10,
- ClassID: wire.FeedbagClassIdBuddy,
- Name: "otherbuddy",
- GroupID: 1,
- },
- },
- err: nil,
- },
- },
- },
- },
- },
- {
- name: "internal server error on feedbag retrieval",
- screenName: "userA",
- groupID: "1",
- requestBody: `{"name":"buddy"}`,
- wantStatusCode: http.StatusInternalServerError,
- wantResponse: `{"message":"internal server error"}`,
- mockParams: mockParams{
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: nil,
- err: errors.New("database error"),
- },
- },
- },
- },
- },
- {
- name: "internal server error on group order upsert",
- screenName: "userA",
- groupID: "1",
- requestBody: `{"name":"buddy1"}`,
- wantStatusCode: http.StatusInternalServerError,
- wantResponse: `{"message":"internal server error"}`,
- mockParams: mockParams{
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: []wire.FeedbagItem{
- {
- ItemID: 1,
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{10}),
- },
- },
- },
- {
- ItemID: 10,
- ClassID: wire.FeedbagClassIdBuddy,
- Name: "buddy1",
- GroupID: 1,
- },
- },
- err: nil,
- },
- },
- feedbagUpsertParams: feedbagUpsertParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- items: []wire.FeedbagItem{
- {
- ItemID: 1,
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{}),
- },
- },
- },
- },
- err: errors.New("database error"),
- },
- },
- },
- },
- },
- {
- name: "internal server error on delete",
- screenName: "userA",
- groupID: "1",
- requestBody: `{"name":"buddy1"}`,
- wantStatusCode: http.StatusInternalServerError,
- wantResponse: `{"message":"internal server error"}`,
- mockParams: mockParams{
- feedbagManagerParams: feedbagManagerParams{
- feedbagParams: feedbagParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- result: []wire.FeedbagItem{
- {
- ItemID: 1,
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{10}),
- },
- },
- },
- {
- ItemID: 10,
- ClassID: wire.FeedbagClassIdBuddy,
- Name: "buddy1",
- GroupID: 1,
- },
- },
- err: nil,
- },
- },
- feedbagUpsertParams: feedbagUpsertParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- items: []wire.FeedbagItem{
- {
- ItemID: 1,
- ClassID: wire.FeedbagClassIdGroup,
- Name: "Friends",
- GroupID: 1,
- TLVLBlock: wire.TLVLBlock{
- TLVList: wire.TLVList{
- wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{}),
- },
- },
- },
- },
- err: nil,
- },
- },
- feedbagDeleteParams: feedbagDeleteParams{
- {
- screenName: state.NewIdentScreenName("userA"),
- items: []wire.FeedbagItem{
- {
- ItemID: 10,
- ClassID: wire.FeedbagClassIdBuddy,
- Name: "buddy1",
- GroupID: 1,
- },
- },
- err: errors.New("database error"),
- },
- },
- },
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- // Extract buddy name from requestBody JSON
- var buddyName string
- if tc.requestBody != "" {
- var input struct {
- Name string `json:"name"`
- }
- if err := json.Unmarshal([]byte(tc.requestBody), &input); err == nil {
- buddyName = input.Name
- }
- }
- request := httptest.NewRequest(http.MethodDelete, "/feedbag/"+tc.screenName+"/group/"+tc.groupID+"/buddy/"+buddyName, nil)
- if tc.screenName != "" {
- request.SetPathValue("screen_name", tc.screenName)
- }
- if tc.groupID != "" {
- request.SetPathValue("group_id", tc.groupID)
- }
- request.SetPathValue("buddy_screen_name", buddyName)
- responseRecorder := httptest.NewRecorder()
- feedbagManager := newMockFeedbagManager(t)
- sessionRetriever := newMockSessionRetriever(t)
- messageRelayer := newMockMessageRelayer(t)
- buddyBroadcaster := newMockBuddyBroadcaster(t)
- for _, params := range tc.mockParams.feedbagParams {
- feedbagManager.EXPECT().
- Feedbag(matchContext(), params.screenName).
- Return(params.result, params.err)
- }
- for _, params := range tc.mockParams.feedbagUpsertParams {
- feedbagManager.EXPECT().
- FeedbagUpsert(matchContext(), params.screenName, params.items).
- Return(params.err)
- }
- for _, params := range tc.mockParams.feedbagDeleteParams {
- feedbagManager.EXPECT().
- FeedbagDelete(matchContext(), params.screenName, params.items).
- Return(params.err)
- }
- for _, params := range tc.mockParams.retrieveSessionByNameParams {
- sessionRetriever.EXPECT().
- RetrieveSession(params.screenName).
- Return(params.result)
- }
- for _, params := range tc.mockParams.relayToScreenNameParams {
- messageRelayer.EXPECT().
- RelayToScreenName(matchContext(), params.screenName, params.msg)
- }
- for _, params := range tc.mockParams.broadcastVisibilityParams {
- buddyBroadcaster.EXPECT().
- BroadcastVisibility(
- matchContext(),
- mock.AnythingOfType("*state.SessionInstance"),
- params.filter,
- params.sendDepartures,
- ).
- Return(params.err)
- }
- deleteFeedbagBuddyHandler(responseRecorder, request, buddyBroadcaster, feedbagManager, sessionRetriever, messageRelayer, slog.Default())
- assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
- if tc.wantResponse != "" {
- assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
- }
- })
- }
- }
- func TestRandItemID(t *testing.T) {
- tt := []struct {
- name string
- randInt func(n int) int
- items []wire.FeedbagItem
- want uint16
- description string
- }{
- {
- name: "empty items list returns random ID",
- randInt: func(n int) int {
- return 1000
- },
- items: []wire.FeedbagItem{},
- want: 1000,
- description: "When no items exist, should return the random number generated",
- },
- {
- name: "finds next available ID when starting ID conflicts with ItemID",
- randInt: func(n int) int {
- return 100
- },
- items: []wire.FeedbagItem{
- {ItemID: 100, GroupID: 1},
- {ItemID: 101, GroupID: 1},
- },
- want: 102,
- description: "Should skip 100 and 101, return 102",
- },
- {
- name: "finds next available ID when starting ID conflicts with GroupID",
- randInt: func(n int) int {
- return 50
- },
- items: []wire.FeedbagItem{
- {ItemID: 1, GroupID: 50},
- {ItemID: 2, GroupID: 51},
- },
- want: 52,
- description: "Should skip 50 (GroupID) and 51 (GroupID), return 52",
- },
- {
- name: "wraps around and skips 0 to find next available ID",
- randInt: func(n int) int {
- return math.MaxUint16 - 2
- },
- items: []wire.FeedbagItem{
- {ItemID: math.MaxUint16 - 2, GroupID: 1},
- {ItemID: math.MaxUint16 - 1, GroupID: 1},
- {ItemID: math.MaxUint16, GroupID: 1},
- },
- want: 2,
- description: "When wrapping around, skips 0 (always skipped) and 1 (if conflicts), returns 2",
- },
- {
- name: "skips 0 when starting from 0 and finds next available",
- randInt: func(n int) int {
- return 0
- },
- items: []wire.FeedbagItem{},
- want: 1,
- description: "When starting from 0, skips 0 (always skipped) and returns 1",
- },
- {
- name: "returns 0 when all IDs are taken",
- randInt: func(n int) int {
- return 100
- },
- items: func() []wire.FeedbagItem {
- // Create items that cover all possible IDs
- items := make([]wire.FeedbagItem, 0, math.MaxUint16+1)
- for i := 0; i <= math.MaxUint16; i++ {
- items = append(items, wire.FeedbagItem{
- ItemID: uint16(i),
- GroupID: uint16(i),
- })
- }
- return items
- }(),
- want: 0,
- description: "When all IDs are taken, should return 0",
- },
- {
- name: "finds ID that conflicts with both ItemID and GroupID",
- randInt: func(n int) int {
- return 200
- },
- items: []wire.FeedbagItem{
- {ItemID: 200, GroupID: 201},
- {ItemID: 201, GroupID: 200},
- },
- want: 202,
- description: "Should skip 200 (ItemID) and 201 (both ItemID and GroupID), return 202",
- },
- {
- name: "finds available ID immediately when no conflicts",
- randInt: func(n int) int {
- return 500
- },
- items: []wire.FeedbagItem{
- {ItemID: 100, GroupID: 1},
- {ItemID: 200, GroupID: 2},
- {ItemID: 300, GroupID: 3},
- },
- want: 500,
- description: "When random ID has no conflicts, should return it immediately",
- },
- {
- name: "handles single conflict and finds next",
- randInt: func(n int) int {
- return 42
- },
- items: []wire.FeedbagItem{
- {ItemID: 42, GroupID: 1},
- },
- want: 43,
- description: "Should skip 42 and return 43",
- },
- {
- name: "finds ID before starting point when wrapping",
- randInt: func(n int) int {
- return 5
- },
- items: []wire.FeedbagItem{
- {ItemID: 5, GroupID: 1},
- {ItemID: 6, GroupID: 1},
- {ItemID: 7, GroupID: 1},
- },
- want: 8,
- description: "Should skip 5, 6, 7 and return 8",
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- got := randItemID(tc.randInt, tc.items)
- if got != tc.want {
- t.Errorf("randItemID() = %d, want %d. %s", got, tc.want, tc.description)
- }
- })
- }
- }
- func TestGetLinkedAccountsHandler(t *testing.T) {
- tt := []struct {
- name string
- screenname string
- statusCode int
- want string
- mockParams mockParams
- }{
- {
- name: "user not found returns 404",
- screenname: "nobody",
- statusCode: http.StatusNotFound,
- want: `{"message":"user not found"}`,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("nobody"),
- result: nil,
- },
- },
- },
- },
- },
- {
- name: "returns empty linked accounts list",
- screenname: "test1",
- statusCode: http.StatusOK,
- want: `{"linked_accounts":[]}`,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("test1"),
- result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
- },
- },
- },
- linkedAccountManagerParams: linkedAccountManagerParams{
- linkedAccountsParams: linkedAccountsParams{
- {
- screenName: state.NewIdentScreenName("test1"),
- result: []state.IdentScreenName{},
- },
- },
- },
- },
- },
- {
- name: "returns linked accounts",
- screenname: "test1",
- statusCode: http.StatusOK,
- want: `{"linked_accounts":["test2","test3"]}`,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("test1"),
- result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
- },
- },
- },
- linkedAccountManagerParams: linkedAccountManagerParams{
- linkedAccountsParams: linkedAccountsParams{
- {
- screenName: state.NewIdentScreenName("test1"),
- result: []state.IdentScreenName{
- state.NewIdentScreenName("test2"),
- state.NewIdentScreenName("test3"),
- },
- },
- },
- },
- },
- },
- {
- name: "linkedAccountManager error returns 500",
- screenname: "test1",
- statusCode: http.StatusInternalServerError,
- want: `{"message":"internal server error"}`,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("test1"),
- result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
- },
- },
- },
- linkedAccountManagerParams: linkedAccountManagerParams{
- linkedAccountsParams: linkedAccountsParams{
- {
- screenName: state.NewIdentScreenName("test1"),
- err: io.EOF,
- },
- },
- },
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- request := httptest.NewRequest(http.MethodGet, "/user/"+tc.screenname+"/linked-account", nil)
- request.SetPathValue("screenname", tc.screenname)
- responseRecorder := httptest.NewRecorder()
- userManager := newMockUserManager(t)
- for _, params := range tc.mockParams.getUserParams {
- userManager.EXPECT().
- User(matchContext(), params.screenName).
- Return(params.result, params.err)
- }
- linkedAccountManager := newMockLinkedAccountManager(t)
- for _, params := range tc.mockParams.linkedAccountsParams {
- linkedAccountManager.EXPECT().
- LinkedAccounts(matchContext(), params.screenName).
- Return(params.result, params.err)
- }
- getLinkedAccountsHandler(responseRecorder, request, userManager, linkedAccountManager)
- assert.Equal(t, tc.statusCode, responseRecorder.Code)
- assert.Equal(t, tc.want, strings.TrimSpace(responseRecorder.Body.String()))
- })
- }
- }
- func TestPostLinkedAccountHandler(t *testing.T) {
- tt := []struct {
- name string
- screenname string
- body string
- statusCode int
- want string
- mockParams mockParams
- }{
- {
- name: "primary user not found returns 404",
- screenname: "nobody",
- body: `{"linked_screen_name":"test2"}`,
- statusCode: http.StatusNotFound,
- want: `{"message":"user not found"}`,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("nobody"),
- result: nil,
- },
- },
- },
- },
- },
- {
- name: "invalid request body returns 400",
- screenname: "test1",
- body: `not json`,
- statusCode: http.StatusBadRequest,
- want: `{"message":"invalid request body"}`,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("test1"),
- result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
- },
- },
- },
- },
- },
- {
- name: "missing linked_screen_name returns 400",
- screenname: "test1",
- body: `{}`,
- statusCode: http.StatusBadRequest,
- want: `{"message":"invalid request body"}`,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("test1"),
- result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
- },
- },
- },
- },
- },
- {
- name: "self-link returns 400",
- screenname: "test1",
- body: `{"linked_screen_name":"test1"}`,
- statusCode: http.StatusBadRequest,
- want: `{"message":"cannot link an account to itself"}`,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("test1"),
- result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
- },
- },
- },
- },
- },
- {
- name: "linked user not found returns 404",
- screenname: "test1",
- body: `{"linked_screen_name":"nobody"}`,
- statusCode: http.StatusNotFound,
- want: `{"message":"linked user not found"}`,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("test1"),
- result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
- },
- {
- screenName: state.NewIdentScreenName("nobody"),
- result: nil,
- },
- },
- },
- },
- },
- {
- name: "duplicate link returns 409",
- screenname: "test1",
- body: `{"linked_screen_name":"test2"}`,
- statusCode: http.StatusConflict,
- want: `{"message":"linked account already exists"}`,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("test1"),
- result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
- },
- {
- screenName: state.NewIdentScreenName("test2"),
- result: &state.User{IdentScreenName: state.NewIdentScreenName("test2")},
- },
- },
- },
- linkedAccountManagerParams: linkedAccountManagerParams{
- insertLinkedAccountParams: insertLinkedAccountParams{
- {
- screenName: state.NewIdentScreenName("test1"),
- linkedScreenName: state.NewIdentScreenName("test2"),
- err: state.ErrLinkExists,
- },
- },
- },
- },
- },
- {
- name: "insert error returns 500",
- screenname: "test1",
- body: `{"linked_screen_name":"test2"}`,
- statusCode: http.StatusInternalServerError,
- want: `{"message":"internal server error"}`,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("test1"),
- result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
- },
- {
- screenName: state.NewIdentScreenName("test2"),
- result: &state.User{IdentScreenName: state.NewIdentScreenName("test2")},
- },
- },
- },
- linkedAccountManagerParams: linkedAccountManagerParams{
- insertLinkedAccountParams: insertLinkedAccountParams{
- {
- screenName: state.NewIdentScreenName("test1"),
- linkedScreenName: state.NewIdentScreenName("test2"),
- err: io.EOF,
- },
- },
- },
- },
- },
- {
- name: "link created returns 201",
- screenname: "test1",
- body: `{"linked_screen_name":"test2"}`,
- statusCode: http.StatusCreated,
- want: ``,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("test1"),
- result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
- },
- {
- screenName: state.NewIdentScreenName("test2"),
- result: &state.User{IdentScreenName: state.NewIdentScreenName("test2")},
- },
- },
- },
- linkedAccountManagerParams: linkedAccountManagerParams{
- insertLinkedAccountParams: insertLinkedAccountParams{
- {
- screenName: state.NewIdentScreenName("test1"),
- linkedScreenName: state.NewIdentScreenName("test2"),
- },
- },
- },
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- request := httptest.NewRequest(http.MethodPost, "/user/"+tc.screenname+"/linked-account", strings.NewReader(tc.body))
- request.SetPathValue("screenname", tc.screenname)
- responseRecorder := httptest.NewRecorder()
- userManager := newMockUserManager(t)
- for _, params := range tc.mockParams.getUserParams {
- userManager.EXPECT().
- User(matchContext(), params.screenName).
- Return(params.result, params.err)
- }
- linkedAccountManager := newMockLinkedAccountManager(t)
- for _, params := range tc.mockParams.insertLinkedAccountParams {
- linkedAccountManager.EXPECT().
- InsertLinkedAccount(matchContext(), params.screenName, params.linkedScreenName).
- Return(params.err)
- }
- postLinkedAccountHandler(responseRecorder, request, userManager, linkedAccountManager)
- assert.Equal(t, tc.statusCode, responseRecorder.Code)
- assert.Equal(t, tc.want, strings.TrimSpace(responseRecorder.Body.String()))
- })
- }
- }
- func TestDeleteAllLinkedAccountsHandler(t *testing.T) {
- tt := []struct {
- name string
- screenname string
- statusCode int
- want string
- mockParams mockParams
- }{
- {
- name: "user not found returns 404",
- screenname: "nobody",
- statusCode: http.StatusNotFound,
- want: `{"message":"user not found"}`,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("nobody"),
- result: nil,
- },
- },
- },
- },
- },
- {
- name: "delete error returns 500",
- screenname: "test1",
- statusCode: http.StatusInternalServerError,
- want: `{"message":"internal server error"}`,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("test1"),
- result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
- },
- },
- },
- linkedAccountManagerParams: linkedAccountManagerParams{
- deleteAllLinkedAccountParams: deleteAllLinkedAccountParams{
- {
- screenName: state.NewIdentScreenName("test1"),
- err: io.EOF,
- },
- },
- },
- },
- },
- {
- name: "all links deleted returns 204",
- screenname: "test1",
- statusCode: http.StatusNoContent,
- want: ``,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("test1"),
- result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
- },
- },
- },
- linkedAccountManagerParams: linkedAccountManagerParams{
- deleteAllLinkedAccountParams: deleteAllLinkedAccountParams{
- {
- screenName: state.NewIdentScreenName("test1"),
- },
- },
- },
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- request := httptest.NewRequest(http.MethodDelete, "/user/"+tc.screenname+"/linked-account", nil)
- request.SetPathValue("screenname", tc.screenname)
- responseRecorder := httptest.NewRecorder()
- userManager := newMockUserManager(t)
- for _, params := range tc.mockParams.getUserParams {
- userManager.EXPECT().
- User(matchContext(), params.screenName).
- Return(params.result, params.err)
- }
- linkedAccountManager := newMockLinkedAccountManager(t)
- for _, params := range tc.mockParams.deleteAllLinkedAccountParams {
- linkedAccountManager.EXPECT().
- DeleteAllLinkedAccounts(matchContext(), params.screenName).
- Return(params.err)
- }
- deleteAllLinkedAccountsHandler(responseRecorder, request, userManager, linkedAccountManager)
- assert.Equal(t, tc.statusCode, responseRecorder.Code)
- assert.Equal(t, tc.want, strings.TrimSpace(responseRecorder.Body.String()))
- })
- }
- }
- func TestDeleteLinkedAccountHandler(t *testing.T) {
- tt := []struct {
- name string
- screenname string
- linkedScreenname string
- statusCode int
- want string
- mockParams mockParams
- }{
- {
- name: "primary user not found returns 404",
- screenname: "nobody",
- linkedScreenname: "test2",
- statusCode: http.StatusNotFound,
- want: `{"message":"user not found"}`,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("nobody"),
- result: nil,
- },
- },
- },
- },
- },
- {
- name: "linked account not found returns 404",
- screenname: "test1",
- linkedScreenname: "ghost",
- statusCode: http.StatusNotFound,
- want: `{"message":"linked account not found"}`,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("test1"),
- result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
- },
- },
- },
- linkedAccountManagerParams: linkedAccountManagerParams{
- deleteLinkedAccountParams: deleteLinkedAccountParams{
- {
- screenName: state.NewIdentScreenName("test1"),
- linkedScreenName: state.NewIdentScreenName("ghost"),
- err: state.ErrNoUser,
- },
- },
- },
- },
- },
- {
- name: "delete error returns 500",
- screenname: "test1",
- linkedScreenname: "test2",
- statusCode: http.StatusInternalServerError,
- want: `{"message":"internal server error"}`,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("test1"),
- result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
- },
- },
- },
- linkedAccountManagerParams: linkedAccountManagerParams{
- deleteLinkedAccountParams: deleteLinkedAccountParams{
- {
- screenName: state.NewIdentScreenName("test1"),
- linkedScreenName: state.NewIdentScreenName("test2"),
- err: io.EOF,
- },
- },
- },
- },
- },
- {
- name: "link deleted returns 204",
- screenname: "test1",
- linkedScreenname: "test2",
- statusCode: http.StatusNoContent,
- want: ``,
- mockParams: mockParams{
- userManagerParams: userManagerParams{
- getUserParams: getUserParams{
- {
- screenName: state.NewIdentScreenName("test1"),
- result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
- },
- },
- },
- linkedAccountManagerParams: linkedAccountManagerParams{
- deleteLinkedAccountParams: deleteLinkedAccountParams{
- {
- screenName: state.NewIdentScreenName("test1"),
- linkedScreenName: state.NewIdentScreenName("test2"),
- },
- },
- },
- },
- },
- }
- for _, tc := range tt {
- t.Run(tc.name, func(t *testing.T) {
- request := httptest.NewRequest(http.MethodDelete, "/user/"+tc.screenname+"/linked-account/"+tc.linkedScreenname, nil)
- request.SetPathValue("screenname", tc.screenname)
- request.SetPathValue("linked_screenname", tc.linkedScreenname)
- responseRecorder := httptest.NewRecorder()
- userManager := newMockUserManager(t)
- for _, params := range tc.mockParams.getUserParams {
- userManager.EXPECT().
- User(matchContext(), params.screenName).
- Return(params.result, params.err)
- }
- linkedAccountManager := newMockLinkedAccountManager(t)
- for _, params := range tc.mockParams.deleteLinkedAccountParams {
- linkedAccountManager.EXPECT().
- DeleteLinkedAccount(matchContext(), params.screenName, params.linkedScreenName).
- Return(params.err)
- }
- deleteLinkedAccountHandler(responseRecorder, request, userManager, linkedAccountManager)
- assert.Equal(t, tc.statusCode, responseRecorder.Code)
- assert.Equal(t, tc.want, strings.TrimSpace(responseRecorder.Body.String()))
- })
- }
- }
|