mgmt_api_test.go 173 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154115511561157115811591160116111621163116411651166116711681169117011711172117311741175117611771178117911801181118211831184118511861187118811891190119111921193119411951196119711981199120012011202120312041205120612071208120912101211121212131214121512161217121812191220122112221223122412251226122712281229123012311232123312341235123612371238123912401241124212431244124512461247124812491250125112521253125412551256125712581259126012611262126312641265126612671268126912701271127212731274127512761277127812791280128112821283128412851286128712881289129012911292129312941295129612971298129913001301130213031304130513061307130813091310131113121313131413151316131713181319132013211322132313241325132613271328132913301331133213331334133513361337133813391340134113421343134413451346134713481349135013511352135313541355135613571358135913601361136213631364136513661367136813691370137113721373137413751376137713781379138013811382138313841385138613871388138913901391139213931394139513961397139813991400140114021403140414051406140714081409141014111412141314141415141614171418141914201421142214231424142514261427142814291430143114321433143414351436143714381439144014411442144314441445144614471448144914501451145214531454145514561457145814591460146114621463146414651466146714681469147014711472147314741475147614771478147914801481148214831484148514861487148814891490149114921493149414951496149714981499150015011502150315041505150615071508150915101511151215131514151515161517151815191520152115221523152415251526152715281529153015311532153315341535153615371538153915401541154215431544154515461547154815491550155115521553155415551556155715581559156015611562156315641565156615671568156915701571157215731574157515761577157815791580158115821583158415851586158715881589159015911592159315941595159615971598159916001601160216031604160516061607160816091610161116121613161416151616161716181619162016211622162316241625162616271628162916301631163216331634163516361637163816391640164116421643164416451646164716481649165016511652165316541655165616571658165916601661166216631664166516661667166816691670167116721673167416751676167716781679168016811682168316841685168616871688168916901691169216931694169516961697169816991700170117021703170417051706170717081709171017111712171317141715171617171718171917201721172217231724172517261727172817291730173117321733173417351736173717381739174017411742174317441745174617471748174917501751175217531754175517561757175817591760176117621763176417651766176717681769177017711772177317741775177617771778177917801781178217831784178517861787178817891790179117921793179417951796179717981799180018011802180318041805180618071808180918101811181218131814181518161817181818191820182118221823182418251826182718281829183018311832183318341835183618371838183918401841184218431844184518461847184818491850185118521853185418551856185718581859186018611862186318641865186618671868186918701871187218731874187518761877187818791880188118821883188418851886188718881889189018911892189318941895189618971898189919001901190219031904190519061907190819091910191119121913191419151916191719181919192019211922192319241925192619271928192919301931193219331934193519361937193819391940194119421943194419451946194719481949195019511952195319541955195619571958195919601961196219631964196519661967196819691970197119721973197419751976197719781979198019811982198319841985198619871988198919901991199219931994199519961997199819992000200120022003200420052006200720082009201020112012201320142015201620172018201920202021202220232024202520262027202820292030203120322033203420352036203720382039204020412042204320442045204620472048204920502051205220532054205520562057205820592060206120622063206420652066206720682069207020712072207320742075207620772078207920802081208220832084208520862087208820892090209120922093209420952096209720982099210021012102210321042105210621072108210921102111211221132114211521162117211821192120212121222123212421252126212721282129213021312132213321342135213621372138213921402141214221432144214521462147214821492150215121522153215421552156215721582159216021612162216321642165216621672168216921702171217221732174217521762177217821792180218121822183218421852186218721882189219021912192219321942195219621972198219922002201220222032204220522062207220822092210221122122213221422152216221722182219222022212222222322242225222622272228222922302231223222332234223522362237223822392240224122422243224422452246224722482249225022512252225322542255225622572258225922602261226222632264226522662267226822692270227122722273227422752276227722782279228022812282228322842285228622872288228922902291229222932294229522962297229822992300230123022303230423052306230723082309231023112312231323142315231623172318231923202321232223232324232523262327232823292330233123322333233423352336233723382339234023412342234323442345234623472348234923502351235223532354235523562357235823592360236123622363236423652366236723682369237023712372237323742375237623772378237923802381238223832384238523862387238823892390239123922393239423952396239723982399240024012402240324042405240624072408240924102411241224132414241524162417241824192420242124222423242424252426242724282429243024312432243324342435243624372438243924402441244224432444244524462447244824492450245124522453245424552456245724582459246024612462246324642465246624672468246924702471247224732474247524762477247824792480248124822483248424852486248724882489249024912492249324942495249624972498249925002501250225032504250525062507250825092510251125122513251425152516251725182519252025212522252325242525252625272528252925302531253225332534253525362537253825392540254125422543254425452546254725482549255025512552255325542555255625572558255925602561256225632564256525662567256825692570257125722573257425752576257725782579258025812582258325842585258625872588258925902591259225932594259525962597259825992600260126022603260426052606260726082609261026112612261326142615261626172618261926202621262226232624262526262627262826292630263126322633263426352636263726382639264026412642264326442645264626472648264926502651265226532654265526562657265826592660266126622663266426652666266726682669267026712672267326742675267626772678267926802681268226832684268526862687268826892690269126922693269426952696269726982699270027012702270327042705270627072708270927102711271227132714271527162717271827192720272127222723272427252726272727282729273027312732273327342735273627372738273927402741274227432744274527462747274827492750275127522753275427552756275727582759276027612762276327642765276627672768276927702771277227732774277527762777277827792780278127822783278427852786278727882789279027912792279327942795279627972798279928002801280228032804280528062807280828092810281128122813281428152816281728182819282028212822282328242825282628272828282928302831283228332834283528362837283828392840284128422843284428452846284728482849285028512852285328542855285628572858285928602861286228632864286528662867286828692870287128722873287428752876287728782879288028812882288328842885288628872888288928902891289228932894289528962897289828992900290129022903290429052906290729082909291029112912291329142915291629172918291929202921292229232924292529262927292829292930293129322933293429352936293729382939294029412942294329442945294629472948294929502951295229532954295529562957295829592960296129622963296429652966296729682969297029712972297329742975297629772978297929802981298229832984298529862987298829892990299129922993299429952996299729982999300030013002300330043005300630073008300930103011301230133014301530163017301830193020302130223023302430253026302730283029303030313032303330343035303630373038303930403041304230433044304530463047304830493050305130523053305430553056305730583059306030613062306330643065306630673068306930703071307230733074307530763077307830793080308130823083308430853086308730883089309030913092309330943095309630973098309931003101310231033104310531063107310831093110311131123113311431153116311731183119312031213122312331243125312631273128312931303131313231333134313531363137313831393140314131423143314431453146314731483149315031513152315331543155315631573158315931603161316231633164316531663167316831693170317131723173317431753176317731783179318031813182318331843185318631873188318931903191319231933194319531963197319831993200320132023203320432053206320732083209321032113212321332143215321632173218321932203221322232233224322532263227322832293230323132323233323432353236323732383239324032413242324332443245324632473248324932503251325232533254325532563257325832593260326132623263326432653266326732683269327032713272327332743275327632773278327932803281328232833284328532863287328832893290329132923293329432953296329732983299330033013302330333043305330633073308330933103311331233133314331533163317331833193320332133223323332433253326332733283329333033313332333333343335333633373338333933403341334233433344334533463347334833493350335133523353335433553356335733583359336033613362336333643365336633673368336933703371337233733374337533763377337833793380338133823383338433853386338733883389339033913392339333943395339633973398339934003401340234033404340534063407340834093410341134123413341434153416341734183419342034213422342334243425342634273428342934303431343234333434343534363437343834393440344134423443344434453446344734483449345034513452345334543455345634573458345934603461346234633464346534663467346834693470347134723473347434753476347734783479348034813482348334843485348634873488348934903491349234933494349534963497349834993500350135023503350435053506350735083509351035113512351335143515351635173518351935203521352235233524352535263527352835293530353135323533353435353536353735383539354035413542354335443545354635473548354935503551355235533554355535563557355835593560356135623563356435653566356735683569357035713572357335743575357635773578357935803581358235833584358535863587358835893590359135923593359435953596359735983599360036013602360336043605360636073608360936103611361236133614361536163617361836193620362136223623362436253626362736283629363036313632363336343635363636373638363936403641364236433644364536463647364836493650365136523653365436553656365736583659366036613662366336643665366636673668366936703671367236733674367536763677367836793680368136823683368436853686368736883689369036913692369336943695369636973698369937003701370237033704370537063707370837093710371137123713371437153716371737183719372037213722372337243725372637273728372937303731373237333734373537363737373837393740374137423743374437453746374737483749375037513752375337543755375637573758375937603761376237633764376537663767376837693770377137723773377437753776377737783779378037813782378337843785378637873788378937903791379237933794379537963797379837993800380138023803380438053806380738083809381038113812381338143815381638173818381938203821382238233824382538263827382838293830383138323833383438353836383738383839384038413842384338443845384638473848384938503851385238533854385538563857385838593860386138623863386438653866386738683869387038713872387338743875387638773878387938803881388238833884388538863887388838893890389138923893389438953896389738983899390039013902390339043905390639073908390939103911391239133914391539163917391839193920392139223923392439253926392739283929393039313932393339343935393639373938393939403941394239433944394539463947394839493950395139523953395439553956395739583959396039613962396339643965396639673968396939703971397239733974397539763977397839793980398139823983398439853986398739883989399039913992399339943995399639973998399940004001400240034004400540064007400840094010401140124013401440154016401740184019402040214022402340244025402640274028402940304031403240334034403540364037403840394040404140424043404440454046404740484049405040514052405340544055405640574058405940604061406240634064406540664067406840694070407140724073407440754076407740784079408040814082408340844085408640874088408940904091409240934094409540964097409840994100410141024103410441054106410741084109411041114112411341144115411641174118411941204121412241234124412541264127412841294130413141324133413441354136413741384139414041414142414341444145414641474148414941504151415241534154415541564157415841594160416141624163416441654166416741684169417041714172417341744175417641774178417941804181418241834184418541864187418841894190419141924193419441954196419741984199420042014202420342044205420642074208420942104211421242134214421542164217421842194220422142224223422442254226422742284229423042314232423342344235423642374238423942404241424242434244424542464247424842494250425142524253425442554256425742584259426042614262426342644265426642674268426942704271427242734274427542764277427842794280428142824283428442854286428742884289429042914292429342944295429642974298429943004301430243034304430543064307430843094310431143124313431443154316431743184319432043214322432343244325432643274328432943304331433243334334433543364337433843394340434143424343434443454346434743484349435043514352435343544355435643574358435943604361436243634364436543664367436843694370437143724373437443754376437743784379438043814382438343844385438643874388438943904391439243934394439543964397439843994400440144024403440444054406440744084409441044114412441344144415441644174418441944204421442244234424442544264427442844294430443144324433443444354436443744384439444044414442444344444445444644474448444944504451445244534454445544564457445844594460446144624463446444654466446744684469447044714472447344744475447644774478447944804481448244834484448544864487448844894490449144924493449444954496449744984499450045014502450345044505450645074508450945104511451245134514451545164517451845194520452145224523452445254526452745284529453045314532453345344535453645374538453945404541454245434544454545464547454845494550455145524553455445554556455745584559456045614562456345644565456645674568456945704571457245734574457545764577457845794580458145824583458445854586458745884589459045914592459345944595459645974598459946004601460246034604460546064607460846094610461146124613461446154616461746184619462046214622462346244625462646274628462946304631463246334634463546364637463846394640464146424643464446454646464746484649465046514652465346544655465646574658465946604661466246634664466546664667466846694670467146724673467446754676467746784679468046814682468346844685468646874688468946904691469246934694469546964697469846994700470147024703470447054706470747084709471047114712471347144715471647174718471947204721472247234724472547264727472847294730473147324733473447354736473747384739474047414742474347444745474647474748474947504751475247534754475547564757475847594760476147624763476447654766476747684769477047714772477347744775477647774778477947804781478247834784478547864787478847894790479147924793479447954796479747984799480048014802480348044805480648074808480948104811481248134814481548164817481848194820482148224823482448254826482748284829483048314832483348344835483648374838483948404841484248434844484548464847484848494850485148524853485448554856485748584859486048614862486348644865486648674868486948704871487248734874487548764877487848794880488148824883488448854886488748884889489048914892489348944895489648974898489949004901490249034904490549064907490849094910491149124913491449154916491749184919492049214922492349244925492649274928492949304931493249334934493549364937493849394940494149424943494449454946494749484949495049514952495349544955495649574958495949604961496249634964496549664967496849694970497149724973497449754976497749784979498049814982498349844985498649874988498949904991499249934994499549964997499849995000500150025003500450055006500750085009501050115012501350145015501650175018501950205021502250235024502550265027502850295030503150325033503450355036503750385039504050415042504350445045504650475048504950505051505250535054505550565057505850595060506150625063506450655066506750685069507050715072507350745075507650775078507950805081508250835084508550865087508850895090509150925093509450955096509750985099510051015102510351045105510651075108510951105111511251135114511551165117511851195120512151225123512451255126512751285129513051315132513351345135513651375138513951405141514251435144514551465147514851495150515151525153515451555156515751585159516051615162516351645165516651675168516951705171517251735174517551765177517851795180518151825183518451855186518751885189519051915192519351945195519651975198519952005201520252035204520552065207520852095210521152125213521452155216521752185219522052215222522352245225522652275228522952305231523252335234523552365237523852395240524152425243524452455246524752485249525052515252525352545255525652575258525952605261526252635264526552665267526852695270527152725273527452755276527752785279528052815282528352845285528652875288528952905291529252935294529552965297529852995300530153025303530453055306530753085309531053115312531353145315531653175318531953205321532253235324532553265327532853295330533153325333533453355336533753385339534053415342534353445345534653475348534953505351535253535354535553565357535853595360536153625363536453655366536753685369537053715372537353745375537653775378537953805381538253835384538553865387538853895390539153925393539453955396539753985399540054015402540354045405540654075408540954105411541254135414541554165417541854195420542154225423542454255426542754285429543054315432543354345435543654375438543954405441544254435444544554465447544854495450545154525453545454555456545754585459546054615462546354645465546654675468546954705471547254735474547554765477547854795480548154825483548454855486548754885489549054915492549354945495549654975498549955005501550255035504550555065507550855095510551155125513551455155516551755185519552055215522552355245525552655275528552955305531553255335534553555365537553855395540554155425543554455455546554755485549555055515552555355545555555655575558555955605561556255635564556555665567556855695570557155725573557455755576557755785579558055815582558355845585558655875588558955905591559255935594559555965597559855995600560156025603560456055606560756085609561056115612561356145615561656175618561956205621562256235624562556265627562856295630563156325633563456355636563756385639564056415642564356445645564656475648564956505651565256535654565556565657565856595660566156625663566456655666566756685669567056715672567356745675567656775678567956805681568256835684568556865687568856895690569156925693569456955696569756985699570057015702570357045705570657075708570957105711571257135714571557165717571857195720572157225723572457255726572757285729573057315732573357345735573657375738573957405741574257435744574557465747574857495750575157525753575457555756575757585759576057615762576357645765576657675768576957705771577257735774577557765777577857795780578157825783578457855786578757885789579057915792579357945795579657975798579958005801580258035804580558065807580858095810581158125813581458155816581758185819582058215822582358245825582658275828582958305831583258335834583558365837583858395840584158425843584458455846584758485849585058515852585358545855585658575858585958605861586258635864586558665867586858695870587158725873587458755876587758785879588058815882588358845885588658875888588958905891589258935894589558965897589858995900590159025903590459055906590759085909591059115912591359145915591659175918591959205921592259235924592559265927592859295930593159325933593459355936593759385939594059415942594359445945594659475948594959505951595259535954595559565957595859595960596159625963596459655966596759685969597059715972597359745975597659775978597959805981598259835984598559865987598859895990599159925993599459955996599759985999600060016002600360046005600660076008600960106011
  1. package http
  2. import (
  3. "bytes"
  4. "context"
  5. "encoding/json"
  6. "errors"
  7. "fmt"
  8. "io"
  9. "log/slog"
  10. "math"
  11. "net/http"
  12. "net/http/httptest"
  13. "net/mail"
  14. "net/netip"
  15. "strings"
  16. "testing"
  17. "time"
  18. "github.com/stretchr/testify/assert"
  19. "github.com/stretchr/testify/mock"
  20. "github.com/mk6i/open-oscar-server/config"
  21. "github.com/mk6i/open-oscar-server/state"
  22. "github.com/mk6i/open-oscar-server/wire"
  23. )
  24. func TestSessionHandler_GET(t *testing.T) {
  25. // Fixed time for testing: 2024-01-01 12:00:00 UTC
  26. fixedNow := time.Date(2024, 1, 1, 12, 0, 0, 0, time.UTC)
  27. nowFn := func() time.Time { return fixedNow }
  28. tt := []struct {
  29. name string
  30. want string
  31. statusCode int
  32. createSessions func() []*state.Session
  33. }{
  34. {
  35. name: "without sessions",
  36. want: `{"count":0,"sessions":[]}`,
  37. statusCode: http.StatusOK,
  38. createSessions: func() []*state.Session {
  39. return []*state.Session{}
  40. },
  41. },
  42. {
  43. name: "with sessions",
  44. want: `{"count":3,"sessions":[{"id":"usera","screen_name":"userA","online_seconds":100,"is_away":false,"away_message":"","idle_seconds":0,"is_invisible":false,"is_icq":false,"instance_count":2,"instances":[{"num":1,"idle_seconds":30,"is_away":false,"away_message":"","is_invisible":false,"remote_addr":"1.2.3.4","remote_port":1234,"client_id":"AOL Instant Messenger, version 5.9.3702/WIN32"},{"num":2,"idle_seconds":0,"is_away":false,"away_message":"","is_invisible":true,"remote_addr":"5.6.7.8","remote_port":5678,"client_id":""}]},{"id":"userb","screen_name":"userB","online_seconds":200,"is_away":false,"away_message":"","idle_seconds":0,"is_invisible":true,"is_icq":false,"instance_count":2,"instances":[{"num":1,"idle_seconds":0,"is_away":false,"away_message":"","is_invisible":true,"remote_addr":"9.10.11.12","remote_port":9012,"client_id":"AOL Instant Messenger (SM), version 4.8.2790/WIN32"},{"num":2,"idle_seconds":0,"is_away":false,"away_message":"","is_invisible":true,"remote_addr":"13.14.15.16","remote_port":1314,"client_id":"WebAIM"}]},{"id":"100003","screen_name":"100003","online_seconds":300,"is_away":false,"away_message":"","idle_seconds":0,"is_invisible":false,"is_icq":true,"instance_count":1,"instances":[{"num":1,"idle_seconds":0,"is_away":false,"away_message":"","is_invisible":false,"remote_addr":"1.2.3.4","remote_port":1234,"client_id":"ICQBasic"}]}]}`,
  45. statusCode: http.StatusOK,
  46. createSessions: func() []*state.Session {
  47. // userA: 2 instances - one idle (30s), one invisible
  48. userA := state.NewSession()
  49. userA.SetIdentScreenName(state.NewIdentScreenName("userA"))
  50. userA.SetDisplayScreenName(state.DisplayScreenName("userA"))
  51. userA.SetUIN(0)
  52. userA.SetNowFn(nowFn)
  53. userA.SetSignonTime(fixedNow.Add(-100 * time.Second))
  54. inst1 := userA.AddInstance()
  55. inst1.SetSignonComplete()
  56. inst1.SetIdle(30 * time.Second)
  57. inst1.SetClientID("AOL Instant Messenger, version 5.9.3702/WIN32")
  58. ip1, _ := netip.ParseAddrPort("1.2.3.4:1234")
  59. inst1.SetRemoteAddr(&ip1)
  60. inst2 := userA.AddInstance()
  61. inst2.SetSignonComplete()
  62. inst2.SetUserStatusBitmask(wire.OServiceUserStatusInvisible)
  63. ip2, _ := netip.ParseAddrPort("5.6.7.8:5678")
  64. inst2.SetRemoteAddr(&ip2)
  65. // userB: 2 instances - both invisible
  66. userB := state.NewSession()
  67. userB.SetIdentScreenName(state.NewIdentScreenName("userB"))
  68. userB.SetDisplayScreenName(state.DisplayScreenName("userB"))
  69. userB.SetUIN(0)
  70. userB.SetNowFn(nowFn)
  71. userB.SetSignonTime(fixedNow.Add(-200 * time.Second))
  72. inst3 := userB.AddInstance()
  73. inst3.SetSignonComplete()
  74. inst3.SetUserStatusBitmask(wire.OServiceUserStatusInvisible)
  75. inst3.SetClientID("AOL Instant Messenger (SM), version 4.8.2790/WIN32")
  76. ip3, _ := netip.ParseAddrPort("9.10.11.12:9012")
  77. inst3.SetRemoteAddr(&ip3)
  78. inst4 := userB.AddInstance()
  79. inst4.SetSignonComplete()
  80. inst4.SetUserStatusBitmask(wire.OServiceUserStatusInvisible)
  81. inst4.SetClientID("WebAIM")
  82. ip4, _ := netip.ParseAddrPort("13.14.15.16:1314")
  83. inst4.SetRemoteAddr(&ip4)
  84. // 100003: 1 instance - normal
  85. icqUser := state.NewSession()
  86. icqUser.SetIdentScreenName(state.NewIdentScreenName("100003"))
  87. icqUser.SetDisplayScreenName(state.DisplayScreenName("100003"))
  88. icqUser.SetUIN(100003)
  89. icqUser.SetNowFn(nowFn)
  90. icqUser.SetSignonTime(fixedNow.Add(-300 * time.Second))
  91. inst5 := icqUser.AddInstance()
  92. inst5.SetSignonComplete()
  93. inst5.SetClientID("ICQBasic")
  94. ip5, _ := netip.ParseAddrPort("1.2.3.4:1234")
  95. inst5.SetRemoteAddr(&ip5)
  96. return []*state.Session{userA, userB, icqUser}
  97. },
  98. },
  99. {
  100. name: "with away sessions",
  101. want: `{"count":2,"sessions":[{"id":"usera","screen_name":"userA","online_seconds":100,"is_away":false,"away_message":"","idle_seconds":0,"is_invisible":false,"is_icq":false,"instance_count":2,"instances":[{"num":1,"idle_seconds":0,"is_away":true,"away_message":"Away message 1","is_invisible":false,"remote_addr":"1.2.3.4","remote_port":1234,"client_id":""},{"num":2,"idle_seconds":0,"is_away":false,"away_message":"","is_invisible":false,"remote_addr":"5.6.7.8","remote_port":5678,"client_id":""}]},{"id":"userb","screen_name":"userB","online_seconds":200,"is_away":true,"away_message":"Away message 2","idle_seconds":0,"is_invisible":false,"is_icq":false,"instance_count":2,"instances":[{"num":1,"idle_seconds":0,"is_away":true,"away_message":"Away message 2","is_invisible":false,"remote_addr":"9.10.11.12","remote_port":9012,"client_id":""},{"num":2,"idle_seconds":0,"is_away":true,"away_message":"Away message 2","is_invisible":false,"remote_addr":"13.14.15.16","remote_port":1314,"client_id":""}]}]}`,
  102. statusCode: http.StatusOK,
  103. createSessions: func() []*state.Session {
  104. // userA: 2 instances - one away, one not away (away_message should be "")
  105. userA := state.NewSession()
  106. userA.SetIdentScreenName(state.NewIdentScreenName("userA"))
  107. userA.SetDisplayScreenName(state.DisplayScreenName("userA"))
  108. userA.SetUIN(0)
  109. userA.SetNowFn(nowFn)
  110. userA.SetSignonTime(fixedNow.Add(-100 * time.Second))
  111. inst1 := userA.AddInstance()
  112. inst1.SetSignonComplete()
  113. inst1.SetUserStatusBitmask(wire.OServiceUserStatusAway)
  114. inst1.SetAwayMessage("Away message 1")
  115. ip1, _ := netip.ParseAddrPort("1.2.3.4:1234")
  116. inst1.SetRemoteAddr(&ip1)
  117. inst2 := userA.AddInstance()
  118. inst2.SetSignonComplete()
  119. ip2, _ := netip.ParseAddrPort("5.6.7.8:5678")
  120. inst2.SetRemoteAddr(&ip2)
  121. // userB: 2 instances - both away (away_message should be populated)
  122. userB := state.NewSession()
  123. userB.SetIdentScreenName(state.NewIdentScreenName("userB"))
  124. userB.SetDisplayScreenName(state.DisplayScreenName("userB"))
  125. userB.SetUIN(0)
  126. userB.SetNowFn(nowFn)
  127. userB.SetSignonTime(fixedNow.Add(-200 * time.Second))
  128. inst3 := userB.AddInstance()
  129. inst3.SetSignonComplete()
  130. inst3.SetUserStatusBitmask(wire.OServiceUserStatusAway)
  131. inst3.SetAwayMessage("Away message 2")
  132. ip3, _ := netip.ParseAddrPort("9.10.11.12:9012")
  133. inst3.SetRemoteAddr(&ip3)
  134. inst4 := userB.AddInstance()
  135. inst4.SetSignonComplete()
  136. inst4.SetUserStatusBitmask(wire.OServiceUserStatusAway)
  137. inst4.SetAwayMessage("Away message 2")
  138. ip4, _ := netip.ParseAddrPort("13.14.15.16:1314")
  139. inst4.SetRemoteAddr(&ip4)
  140. return []*state.Session{userA, userB}
  141. },
  142. },
  143. }
  144. for _, tc := range tt {
  145. t.Run(tc.name, func(t *testing.T) {
  146. request := httptest.NewRequest(http.MethodGet, "/session", nil)
  147. responseRecorder := httptest.NewRecorder()
  148. sessionRetriever := newMockSessionRetriever(t)
  149. sessions := tc.createSessions()
  150. sessionRetriever.EXPECT().
  151. AllSessions().
  152. Return(sessions)
  153. getSessionHandler(responseRecorder, request, sessionRetriever, nowFn)
  154. if responseRecorder.Code != tc.statusCode {
  155. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  156. }
  157. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  158. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  159. }
  160. })
  161. }
  162. }
  163. func TestSessionHandlerScreenname_GET(t *testing.T) {
  164. // Fixed time for testing: 2024-01-01 12:00:00 UTC
  165. fixedNow := time.Date(2024, 1, 1, 12, 0, 0, 0, time.UTC)
  166. nowFn := func() time.Time { return fixedNow }
  167. tt := []struct {
  168. name string
  169. requestScreenName state.IdentScreenName
  170. want string
  171. statusCode int
  172. createSession func() *state.Session
  173. }{
  174. {
  175. name: "no session for screenname",
  176. requestScreenName: state.NewIdentScreenName("userA"),
  177. want: `session not found`,
  178. statusCode: http.StatusNotFound,
  179. createSession: func() *state.Session {
  180. return nil
  181. },
  182. },
  183. {
  184. name: "active session found for screenname",
  185. requestScreenName: state.NewIdentScreenName("userA"),
  186. want: `{"count":1,"sessions":[{"id":"usera","screen_name":"userA","online_seconds":150,"is_away":false,"away_message":"","idle_seconds":0,"is_invisible":false,"is_icq":false,"instance_count":1,"instances":[{"num":1,"idle_seconds":0,"is_away":false,"away_message":"","is_invisible":false,"remote_addr":"1.2.3.4","remote_port":1234,"client_id":"AOL Instant Messenger, version 5.9.3702/WIN32"}]}]}`,
  187. statusCode: http.StatusOK,
  188. createSession: func() *state.Session {
  189. sess := state.NewSession()
  190. sess.SetIdentScreenName(state.NewIdentScreenName("userA"))
  191. sess.SetDisplayScreenName(state.DisplayScreenName("userA"))
  192. sess.SetUIN(0)
  193. sess.SetNowFn(nowFn)
  194. sess.SetSignonTime(fixedNow.Add(-150 * time.Second))
  195. instance := sess.AddInstance()
  196. instance.SetSignonComplete()
  197. instance.SetClientID("AOL Instant Messenger, version 5.9.3702/WIN32")
  198. ip, _ := netip.ParseAddrPort("1.2.3.4:1234")
  199. instance.SetRemoteAddr(&ip)
  200. return sess
  201. },
  202. },
  203. }
  204. for _, tc := range tt {
  205. t.Run(tc.name, func(t *testing.T) {
  206. request := httptest.NewRequest(http.MethodGet, "/session/"+tc.requestScreenName.String(), nil)
  207. request.SetPathValue("screenname", tc.requestScreenName.String())
  208. responseRecorder := httptest.NewRecorder()
  209. sessionRetriever := newMockSessionRetriever(t)
  210. session := tc.createSession()
  211. sessionRetriever.EXPECT().
  212. RetrieveSession(tc.requestScreenName).
  213. Return(session)
  214. getSessionHandler(responseRecorder, request, sessionRetriever, nowFn)
  215. if responseRecorder.Code != tc.statusCode {
  216. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  217. }
  218. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  219. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  220. }
  221. })
  222. }
  223. }
  224. func TestSessionHandlerScreenname_DELETE(t *testing.T) {
  225. fnNewSess := func(screenName string) *state.Session {
  226. sess := state.NewSession()
  227. sess.SetIdentScreenName(state.NewIdentScreenName(screenName))
  228. sess.SetDisplayScreenName(state.DisplayScreenName(screenName))
  229. instance := sess.AddInstance()
  230. instance.SetSignonComplete()
  231. ip, _ := netip.ParseAddrPort("1.2.3.4:1234")
  232. instance.SetRemoteAddr(&ip)
  233. return sess
  234. }
  235. tt := []struct {
  236. name string
  237. session *state.SessionInstance
  238. requestScreenName state.IdentScreenName
  239. statusCode int
  240. mockParams mockParams
  241. }{
  242. {
  243. name: "delete an active session",
  244. requestScreenName: state.NewIdentScreenName("userA"),
  245. statusCode: http.StatusNoContent,
  246. mockParams: mockParams{
  247. sessionRetrieverParams: sessionRetrieverParams{
  248. retrieveSessionByNameParams: retrieveSessionByNameParams{
  249. {
  250. screenName: state.NewIdentScreenName("userA"),
  251. result: fnNewSess("userA"),
  252. },
  253. },
  254. },
  255. },
  256. },
  257. {
  258. name: "delete a non-existent session",
  259. requestScreenName: state.NewIdentScreenName("userA"),
  260. statusCode: http.StatusNotFound,
  261. mockParams: mockParams{
  262. sessionRetrieverParams: sessionRetrieverParams{
  263. retrieveSessionByNameParams: retrieveSessionByNameParams{
  264. {
  265. screenName: state.NewIdentScreenName("userA"),
  266. result: nil,
  267. },
  268. },
  269. },
  270. },
  271. },
  272. }
  273. for _, tc := range tt {
  274. t.Run(tc.name, func(t *testing.T) {
  275. request := httptest.NewRequest(http.MethodDelete, "/session/"+tc.requestScreenName.String(), nil)
  276. request.SetPathValue("screenname", tc.requestScreenName.String())
  277. responseRecorder := httptest.NewRecorder()
  278. sessionRetriever := newMockSessionRetriever(t)
  279. for _, params := range tc.mockParams.retrieveSessionByNameParams {
  280. sessionRetriever.EXPECT().
  281. RetrieveSession(params.screenName).
  282. Return(params.result)
  283. }
  284. deleteSessionHandler(responseRecorder, request, sessionRetriever)
  285. if responseRecorder.Code != tc.statusCode {
  286. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  287. }
  288. })
  289. }
  290. }
  291. func TestUserAccountHandler_GET(t *testing.T) {
  292. tt := []struct {
  293. name string
  294. requestScreenName state.IdentScreenName
  295. want string
  296. statusCode int
  297. mockParams mockParams
  298. }{
  299. {
  300. name: "invalid account",
  301. requestScreenName: state.NewIdentScreenName("userA"),
  302. want: `user not found`,
  303. statusCode: http.StatusNotFound,
  304. mockParams: mockParams{
  305. userManagerParams: userManagerParams{
  306. getUserParams: getUserParams{
  307. {
  308. screenName: state.NewIdentScreenName("userA"),
  309. result: nil,
  310. },
  311. },
  312. },
  313. },
  314. },
  315. {
  316. name: "valid aim account",
  317. requestScreenName: state.NewIdentScreenName("userA"),
  318. want: `{"id":"usera","screen_name":"userA","profile":"My Profile Text","email_address":"\u003cuserA@aol.com\u003e","reg_status":2,"confirmed":true,"is_icq":false,"suspended_status":"","is_bot":false}`,
  319. statusCode: http.StatusOK,
  320. mockParams: mockParams{
  321. userManagerParams: userManagerParams{
  322. getUserParams: getUserParams{
  323. {
  324. screenName: state.NewIdentScreenName("userA"),
  325. result: &state.User{
  326. DisplayScreenName: "userA",
  327. IdentScreenName: state.NewIdentScreenName("userA"),
  328. SuspendedStatus: 0x0,
  329. },
  330. },
  331. },
  332. },
  333. accountManagerParams: accountManagerParams{
  334. EmailAddressParams: EmailAddressParams{
  335. {
  336. screenName: state.NewIdentScreenName("userA"),
  337. result: &mail.Address{
  338. Address: "userA@aol.com",
  339. },
  340. },
  341. },
  342. RegStatusParams: RegStatusParams{
  343. {
  344. screenName: state.NewIdentScreenName("userA"),
  345. result: uint16(0x02),
  346. },
  347. },
  348. ConfirmStatusParams: ConfirmStatusParams{
  349. {
  350. screenName: state.NewIdentScreenName("userA"),
  351. result: true,
  352. },
  353. },
  354. },
  355. profileRetrieverParams: profileRetrieverParams{
  356. retrieveProfileParams: retrieveProfileParams{
  357. {
  358. screenName: state.NewIdentScreenName("userA"),
  359. result: state.UserProfile{ProfileText: "My Profile Text"},
  360. },
  361. },
  362. },
  363. },
  364. },
  365. {
  366. name: "valid aim bot account",
  367. requestScreenName: state.NewIdentScreenName("userA"),
  368. want: `{"id":"usera","screen_name":"userA","profile":"My Profile Text","email_address":"\u003cuserA@aol.com\u003e","reg_status":2,"confirmed":true,"is_icq":false,"suspended_status":"","is_bot":true}`,
  369. statusCode: http.StatusOK,
  370. mockParams: mockParams{
  371. userManagerParams: userManagerParams{
  372. getUserParams: getUserParams{
  373. {
  374. screenName: state.NewIdentScreenName("userA"),
  375. result: &state.User{
  376. DisplayScreenName: "userA",
  377. IdentScreenName: state.NewIdentScreenName("userA"),
  378. SuspendedStatus: 0x0,
  379. IsBot: true,
  380. },
  381. },
  382. },
  383. },
  384. accountManagerParams: accountManagerParams{
  385. EmailAddressParams: EmailAddressParams{
  386. {
  387. screenName: state.NewIdentScreenName("userA"),
  388. result: &mail.Address{
  389. Address: "userA@aol.com",
  390. },
  391. },
  392. },
  393. RegStatusParams: RegStatusParams{
  394. {
  395. screenName: state.NewIdentScreenName("userA"),
  396. result: uint16(0x02),
  397. },
  398. },
  399. ConfirmStatusParams: ConfirmStatusParams{
  400. {
  401. screenName: state.NewIdentScreenName("userA"),
  402. result: true,
  403. },
  404. },
  405. },
  406. profileRetrieverParams: profileRetrieverParams{
  407. retrieveProfileParams: retrieveProfileParams{
  408. {
  409. screenName: state.NewIdentScreenName("userA"),
  410. result: state.UserProfile{ProfileText: "My Profile Text"},
  411. },
  412. },
  413. },
  414. },
  415. },
  416. {
  417. name: "suspended aim account",
  418. requestScreenName: state.NewIdentScreenName("userB"),
  419. want: `{"id":"userb","screen_name":"userB","profile":"My Profile Text","email_address":"\u003cuserB@aol.com\u003e","reg_status":2,"confirmed":true,"is_icq":false,"suspended_status":"suspended","is_bot":false}`,
  420. statusCode: http.StatusOK,
  421. mockParams: mockParams{
  422. userManagerParams: userManagerParams{
  423. getUserParams: getUserParams{
  424. {
  425. screenName: state.NewIdentScreenName("userB"),
  426. result: &state.User{
  427. DisplayScreenName: "userB",
  428. IdentScreenName: state.NewIdentScreenName("userB"),
  429. SuspendedStatus: wire.LoginErrSuspendedAccount,
  430. },
  431. },
  432. },
  433. },
  434. accountManagerParams: accountManagerParams{
  435. EmailAddressParams: EmailAddressParams{
  436. {
  437. screenName: state.NewIdentScreenName("userB"),
  438. result: &mail.Address{
  439. Address: "userB@aol.com",
  440. },
  441. },
  442. },
  443. RegStatusParams: RegStatusParams{
  444. {
  445. screenName: state.NewIdentScreenName("userB"),
  446. result: uint16(0x02),
  447. },
  448. },
  449. ConfirmStatusParams: ConfirmStatusParams{
  450. {
  451. screenName: state.NewIdentScreenName("userB"),
  452. result: true,
  453. },
  454. },
  455. },
  456. profileRetrieverParams: profileRetrieverParams{
  457. retrieveProfileParams: retrieveProfileParams{
  458. {
  459. screenName: state.NewIdentScreenName("userB"),
  460. result: state.UserProfile{ProfileText: "My Profile Text"},
  461. },
  462. },
  463. },
  464. },
  465. },
  466. }
  467. for _, tc := range tt {
  468. t.Run(tc.name, func(t *testing.T) {
  469. request := httptest.NewRequest(http.MethodGet, "/user/"+tc.requestScreenName.String()+"/account", nil)
  470. request.SetPathValue("screenname", tc.requestScreenName.String())
  471. responseRecorder := httptest.NewRecorder()
  472. userManager := newMockUserManager(t)
  473. for _, params := range tc.mockParams.getUserParams {
  474. userManager.EXPECT().
  475. User(matchContext(), params.screenName).
  476. Return(params.result, params.err)
  477. }
  478. accountManager := newMockAccountManager(t)
  479. for _, params := range tc.mockParams.EmailAddressParams {
  480. accountManager.EXPECT().
  481. EmailAddress(matchContext(), params.screenName).
  482. Return(params.result, params.err)
  483. }
  484. for _, params := range tc.mockParams.RegStatusParams {
  485. accountManager.EXPECT().
  486. RegStatus(matchContext(), params.screenName).
  487. Return(params.result, params.err)
  488. }
  489. for _, params := range tc.mockParams.ConfirmStatusParams {
  490. accountManager.EXPECT().
  491. ConfirmStatus(matchContext(), params.screenName).
  492. Return(params.result, params.err)
  493. }
  494. profileRetriever := newMockProfileRetriever(t)
  495. for _, params := range tc.mockParams.retrieveProfileParams {
  496. profileRetriever.EXPECT().
  497. Profile(matchContext(), params.screenName).
  498. Return(params.result, params.err)
  499. }
  500. getUserAccountHandler(responseRecorder, request, userManager, accountManager, profileRetriever, slog.Default())
  501. if responseRecorder.Code != tc.statusCode {
  502. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  503. }
  504. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  505. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  506. }
  507. })
  508. }
  509. }
  510. func TestUserAccountHandler_PATCH(t *testing.T) {
  511. tt := []struct {
  512. name string
  513. requestScreenName state.IdentScreenName
  514. want string
  515. body string
  516. statusCode int
  517. mockParams mockParams
  518. }{
  519. {
  520. name: "suspending a non-existent account",
  521. requestScreenName: state.NewIdentScreenName("userA"),
  522. body: `{"suspended_status":"suspended"}`,
  523. want: `user not found`,
  524. statusCode: http.StatusNotFound,
  525. mockParams: mockParams{
  526. userManagerParams: userManagerParams{
  527. getUserParams: getUserParams{
  528. {
  529. screenName: state.NewIdentScreenName("userA"),
  530. result: nil,
  531. },
  532. },
  533. },
  534. },
  535. },
  536. {
  537. name: "patching with invalid suspended_status value",
  538. requestScreenName: state.NewIdentScreenName("userA"),
  539. body: `{"suspended_status":"thisisinvalid"}`,
  540. want: `{"message":"suspended_status must be empty str or one of deleted,expired,suspended,suspended_age"}`,
  541. statusCode: http.StatusBadRequest,
  542. mockParams: mockParams{
  543. userManagerParams: userManagerParams{
  544. getUserParams: getUserParams{
  545. {
  546. screenName: state.NewIdentScreenName("userA"),
  547. result: &state.User{},
  548. },
  549. },
  550. },
  551. },
  552. },
  553. {
  554. name: "suspending an active aim account",
  555. requestScreenName: state.NewIdentScreenName("userA"),
  556. statusCode: http.StatusNoContent,
  557. body: `{"suspended_status":"suspended"}`,
  558. mockParams: mockParams{
  559. userManagerParams: userManagerParams{
  560. getUserParams: getUserParams{
  561. {
  562. screenName: state.NewIdentScreenName("userA"),
  563. result: &state.User{
  564. DisplayScreenName: "userA",
  565. IdentScreenName: state.NewIdentScreenName("userA"),
  566. SuspendedStatus: 0x0,
  567. },
  568. },
  569. },
  570. },
  571. accountManagerParams: accountManagerParams{
  572. updateSuspendedStatusParams: updateSuspendedStatusParams{
  573. {
  574. suspendedStatus: wire.LoginErrSuspendedAccount,
  575. screenName: state.NewIdentScreenName("userA"),
  576. err: nil,
  577. },
  578. },
  579. },
  580. },
  581. },
  582. {
  583. name: "unsuspending a suspended aim account",
  584. requestScreenName: state.NewIdentScreenName("userA"),
  585. statusCode: http.StatusNoContent,
  586. body: `{"suspended_status":""}`,
  587. mockParams: mockParams{
  588. userManagerParams: userManagerParams{
  589. getUserParams: getUserParams{
  590. {
  591. screenName: state.NewIdentScreenName("userA"),
  592. result: &state.User{
  593. DisplayScreenName: "userA",
  594. IdentScreenName: state.NewIdentScreenName("userA"),
  595. SuspendedStatus: wire.LoginErrSuspendedAccount,
  596. },
  597. },
  598. },
  599. },
  600. accountManagerParams: accountManagerParams{
  601. updateSuspendedStatusParams: updateSuspendedStatusParams{
  602. {
  603. suspendedStatus: 0x0,
  604. screenName: state.NewIdentScreenName("userA"),
  605. err: nil,
  606. },
  607. },
  608. },
  609. },
  610. },
  611. {
  612. name: "suspending an already suspended aim account",
  613. requestScreenName: state.NewIdentScreenName("userA"),
  614. statusCode: http.StatusNotModified,
  615. body: `{"suspended_status":"suspended"}`,
  616. mockParams: mockParams{
  617. userManagerParams: userManagerParams{
  618. getUserParams: getUserParams{
  619. {
  620. screenName: state.NewIdentScreenName("userA"),
  621. result: &state.User{
  622. DisplayScreenName: "userA",
  623. IdentScreenName: state.NewIdentScreenName("userA"),
  624. SuspendedStatus: wire.LoginErrSuspendedAccount,
  625. },
  626. },
  627. },
  628. },
  629. },
  630. },
  631. {
  632. name: "setting bot flag (before: false, after: true)",
  633. requestScreenName: state.NewIdentScreenName("userA"),
  634. statusCode: http.StatusNoContent,
  635. body: `{"is_bot":true}`,
  636. mockParams: mockParams{
  637. userManagerParams: userManagerParams{
  638. getUserParams: getUserParams{
  639. {
  640. screenName: state.NewIdentScreenName("userA"),
  641. result: &state.User{
  642. DisplayScreenName: "userA",
  643. IdentScreenName: state.NewIdentScreenName("userA"),
  644. SuspendedStatus: 0x0,
  645. IsBot: false,
  646. },
  647. },
  648. },
  649. },
  650. accountManagerParams: accountManagerParams{
  651. setBotStatusParams: setBotStatusParams{
  652. {
  653. isBot: true,
  654. screenName: state.NewIdentScreenName("userA"),
  655. err: nil,
  656. },
  657. },
  658. },
  659. },
  660. },
  661. {
  662. name: "setting bot flag (before: true, after: false)",
  663. requestScreenName: state.NewIdentScreenName("userA"),
  664. statusCode: http.StatusNoContent,
  665. body: `{"is_bot":false}`,
  666. mockParams: mockParams{
  667. userManagerParams: userManagerParams{
  668. getUserParams: getUserParams{
  669. {
  670. screenName: state.NewIdentScreenName("userA"),
  671. result: &state.User{
  672. DisplayScreenName: "userA",
  673. IdentScreenName: state.NewIdentScreenName("userA"),
  674. SuspendedStatus: 0x0,
  675. IsBot: true,
  676. },
  677. },
  678. },
  679. },
  680. accountManagerParams: accountManagerParams{
  681. setBotStatusParams: setBotStatusParams{
  682. {
  683. isBot: false,
  684. screenName: state.NewIdentScreenName("userA"),
  685. err: nil,
  686. },
  687. },
  688. },
  689. },
  690. },
  691. {
  692. name: "setting bot flag (before: true, after: true)",
  693. requestScreenName: state.NewIdentScreenName("userA"),
  694. statusCode: http.StatusNotModified,
  695. body: `{"is_bot":true}`,
  696. mockParams: mockParams{
  697. userManagerParams: userManagerParams{
  698. getUserParams: getUserParams{
  699. {
  700. screenName: state.NewIdentScreenName("userA"),
  701. result: &state.User{
  702. DisplayScreenName: "userA",
  703. IdentScreenName: state.NewIdentScreenName("userA"),
  704. SuspendedStatus: 0x0,
  705. IsBot: true,
  706. },
  707. },
  708. },
  709. },
  710. },
  711. },
  712. }
  713. for _, tc := range tt {
  714. t.Run(tc.name, func(t *testing.T) {
  715. request := httptest.NewRequest(http.MethodPatch, "/user/"+tc.requestScreenName.String()+"/account", strings.NewReader(tc.body))
  716. request.SetPathValue("screenname", tc.requestScreenName.String())
  717. responseRecorder := httptest.NewRecorder()
  718. userManager := newMockUserManager(t)
  719. for _, params := range tc.mockParams.getUserParams {
  720. userManager.EXPECT().
  721. User(matchContext(), params.screenName).
  722. Return(params.result, params.err)
  723. }
  724. accountManager := newMockAccountManager(t)
  725. for _, params := range tc.mockParams.updateSuspendedStatusParams {
  726. accountManager.EXPECT().
  727. UpdateSuspendedStatus(matchContext(), params.suspendedStatus, params.screenName).
  728. Return(params.err)
  729. }
  730. for _, params := range tc.mockParams.setBotStatusParams {
  731. accountManager.EXPECT().
  732. SetBotStatus(matchContext(), params.isBot, params.screenName).
  733. Return(params.err)
  734. }
  735. patchUserAccountHandler(responseRecorder, request, userManager, accountManager, slog.Default())
  736. if responseRecorder.Code != tc.statusCode {
  737. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  738. }
  739. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  740. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  741. }
  742. })
  743. }
  744. }
  745. func TestUserBuddyIconHandler_GET(t *testing.T) {
  746. sampleGIF := []byte{
  747. 0x47, 0x49, 0x46, 0x38, 0x39, 0x61, 0x32, 0x00, 0x32, 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
  748. 0x00, 0x00, 0x00, 0x21, 0xf9, 0x04, 0x01, 0x00, 0x00, 0x00, 0x00, 0x2c, 0x00, 0x00, 0x00, 0x00,
  749. 0x32, 0x00, 0x32, 0x00, 0x00, 0x02, 0x02, 0x44, 0x01, 0x00, 0x3b}
  750. sampleJPG := []byte{0xFF, 0xD8, 0xFF, 0x43, 0x13, 0x37}
  751. tt := []struct {
  752. name string
  753. requestScreenName state.IdentScreenName
  754. want string
  755. statusCode int
  756. contentType string
  757. mockParams mockParams
  758. }{
  759. {
  760. name: "invalid account",
  761. requestScreenName: state.NewIdentScreenName("userA"),
  762. want: `user not found`,
  763. statusCode: http.StatusNotFound,
  764. contentType: "text/plain; charset=utf-8",
  765. mockParams: mockParams{
  766. userManagerParams: userManagerParams{
  767. getUserParams: getUserParams{
  768. {
  769. screenName: state.NewIdentScreenName("userA"),
  770. result: nil,
  771. },
  772. },
  773. },
  774. },
  775. },
  776. {
  777. name: "account with gif buddy icon",
  778. requestScreenName: state.NewIdentScreenName("userA"),
  779. want: string(sampleGIF),
  780. statusCode: http.StatusOK,
  781. contentType: "image/gif",
  782. mockParams: mockParams{
  783. userManagerParams: userManagerParams{
  784. getUserParams: getUserParams{
  785. {
  786. screenName: state.NewIdentScreenName("userA"),
  787. result: &state.User{
  788. DisplayScreenName: "userA",
  789. IdentScreenName: state.NewIdentScreenName("userA"),
  790. },
  791. },
  792. },
  793. },
  794. feedBagRetrieverParams: feedBagRetrieverParams{
  795. buddyIconMetadataParams: buddyIconMetadataParams{
  796. {
  797. screenName: state.NewIdentScreenName("userA"),
  798. result: &wire.BARTID{
  799. Type: wire.BARTTypesBuddyIcon,
  800. BARTInfo: wire.BARTInfo{
  801. Flags: 0x00,
  802. Hash: []byte{'t', 'h', 'e', 'h', 'a', 's', 'h'},
  803. },
  804. },
  805. },
  806. },
  807. },
  808. bartAssetManagerParams: bartAssetManagerParams{
  809. bartItemParams: bartItemParams{
  810. {
  811. hash: []byte{'t', 'h', 'e', 'h', 'a', 's', 'h'},
  812. result: sampleGIF,
  813. },
  814. },
  815. },
  816. },
  817. },
  818. {
  819. name: "account with jpg buddy icon",
  820. requestScreenName: state.NewIdentScreenName("userA"),
  821. want: string(sampleJPG),
  822. statusCode: http.StatusOK,
  823. contentType: "image/jpeg",
  824. mockParams: mockParams{
  825. userManagerParams: userManagerParams{
  826. getUserParams: getUserParams{
  827. {
  828. screenName: state.NewIdentScreenName("userA"),
  829. result: &state.User{
  830. DisplayScreenName: "userA",
  831. IdentScreenName: state.NewIdentScreenName("userA"),
  832. },
  833. },
  834. },
  835. },
  836. feedBagRetrieverParams: feedBagRetrieverParams{
  837. buddyIconMetadataParams: buddyIconMetadataParams{
  838. {
  839. screenName: state.NewIdentScreenName("userA"),
  840. result: &wire.BARTID{
  841. Type: wire.BARTTypesBuddyIcon,
  842. BARTInfo: wire.BARTInfo{
  843. Flags: 0x00,
  844. Hash: []byte{'t', 'h', 'e', 'h', 'a', 's', 'h'},
  845. },
  846. },
  847. },
  848. },
  849. },
  850. bartAssetManagerParams: bartAssetManagerParams{
  851. bartItemParams: bartItemParams{
  852. {
  853. hash: []byte{'t', 'h', 'e', 'h', 'a', 's', 'h'},
  854. result: sampleJPG,
  855. },
  856. },
  857. },
  858. },
  859. },
  860. {
  861. name: "account with unknown format buddy icon",
  862. requestScreenName: state.NewIdentScreenName("userA"),
  863. want: string([]byte{0x13, 0x37, 0x13, 0x37, 0x13, 0x37}),
  864. statusCode: http.StatusOK,
  865. contentType: "application/octet-stream",
  866. mockParams: mockParams{
  867. userManagerParams: userManagerParams{
  868. getUserParams: getUserParams{
  869. {
  870. screenName: state.NewIdentScreenName("userA"),
  871. result: &state.User{
  872. DisplayScreenName: "userA",
  873. IdentScreenName: state.NewIdentScreenName("userA"),
  874. },
  875. },
  876. },
  877. },
  878. feedBagRetrieverParams: feedBagRetrieverParams{
  879. buddyIconMetadataParams: buddyIconMetadataParams{
  880. {
  881. screenName: state.NewIdentScreenName("userA"),
  882. result: &wire.BARTID{
  883. Type: wire.BARTTypesBuddyIcon,
  884. BARTInfo: wire.BARTInfo{
  885. Flags: 0x00,
  886. Hash: []byte{'t', 'h', 'e', 'h', 'a', 's', 'h'},
  887. },
  888. },
  889. },
  890. },
  891. },
  892. bartAssetManagerParams: bartAssetManagerParams{
  893. bartItemParams: bartItemParams{
  894. {
  895. hash: []byte{'t', 'h', 'e', 'h', 'a', 's', 'h'},
  896. result: []byte{0x13, 0x37, 0x13, 0x37, 0x13, 0x37},
  897. },
  898. },
  899. },
  900. },
  901. },
  902. {
  903. name: "account with cleared buddy icon",
  904. requestScreenName: state.NewIdentScreenName("userA"),
  905. want: "icon not found",
  906. statusCode: http.StatusNotFound,
  907. contentType: "text/plain; charset=utf-8",
  908. mockParams: mockParams{
  909. userManagerParams: userManagerParams{
  910. getUserParams: getUserParams{
  911. {
  912. screenName: state.NewIdentScreenName("userA"),
  913. result: &state.User{
  914. DisplayScreenName: "userA",
  915. IdentScreenName: state.NewIdentScreenName("userA"),
  916. },
  917. },
  918. },
  919. },
  920. feedBagRetrieverParams: feedBagRetrieverParams{
  921. buddyIconMetadataParams: buddyIconMetadataParams{
  922. {
  923. screenName: state.NewIdentScreenName("userA"),
  924. result: &wire.BARTID{
  925. Type: wire.BARTTypesBuddyIcon,
  926. BARTInfo: wire.BARTInfo{
  927. Flags: 0x00,
  928. Hash: wire.GetClearIconHash(),
  929. },
  930. },
  931. },
  932. },
  933. },
  934. },
  935. },
  936. {
  937. name: "account with no buddy icon",
  938. requestScreenName: state.NewIdentScreenName("userA"),
  939. want: "icon not found",
  940. statusCode: http.StatusNotFound,
  941. contentType: "text/plain; charset=utf-8",
  942. mockParams: mockParams{
  943. userManagerParams: userManagerParams{
  944. getUserParams: getUserParams{
  945. {
  946. screenName: state.NewIdentScreenName("userA"),
  947. result: &state.User{
  948. DisplayScreenName: "userA",
  949. IdentScreenName: state.NewIdentScreenName("userA"),
  950. },
  951. },
  952. },
  953. },
  954. feedBagRetrieverParams: feedBagRetrieverParams{
  955. buddyIconMetadataParams: buddyIconMetadataParams{
  956. {
  957. screenName: state.NewIdentScreenName("userA"),
  958. result: nil,
  959. },
  960. },
  961. },
  962. },
  963. },
  964. }
  965. for _, tc := range tt {
  966. t.Run(tc.name, func(t *testing.T) {
  967. request := httptest.NewRequest(http.MethodGet, "/user/"+tc.requestScreenName.String()+"/icon", nil)
  968. request.SetPathValue("screenname", tc.requestScreenName.String())
  969. responseRecorder := httptest.NewRecorder()
  970. userManager := newMockUserManager(t)
  971. for _, params := range tc.mockParams.getUserParams {
  972. userManager.EXPECT().
  973. User(matchContext(), params.screenName).
  974. Return(params.result, params.err)
  975. }
  976. feedbagRetriever := newMockFeedBagRetriever(t)
  977. for _, params := range tc.mockParams.buddyIconMetadataParams {
  978. feedbagRetriever.EXPECT().
  979. BuddyIconMetadata(matchContext(), params.screenName).
  980. Return(params.result, params.err)
  981. }
  982. bartRetriever := newMockBARTAssetManager(t)
  983. for _, params := range tc.mockParams.bartItemParams {
  984. bartRetriever.EXPECT().
  985. BARTItem(matchContext(), params.hash).
  986. Return(params.result, params.err)
  987. }
  988. getUserBuddyIconHandler(responseRecorder, request, userManager, feedbagRetriever, bartRetriever, slog.Default())
  989. if responseRecorder.Code != tc.statusCode {
  990. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  991. }
  992. contentType := responseRecorder.Header().Get("Content-Type")
  993. if contentType != tc.contentType {
  994. t.Errorf("Want content type '%s', got '%s'", tc.contentType, contentType)
  995. }
  996. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  997. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  998. }
  999. })
  1000. }
  1001. }
  1002. func TestUserHandler_GET(t *testing.T) {
  1003. tt := []struct {
  1004. name string
  1005. want string
  1006. statusCode int
  1007. mockParams mockParams
  1008. }{
  1009. {
  1010. name: "empty user store",
  1011. want: `[]`,
  1012. statusCode: http.StatusOK,
  1013. mockParams: mockParams{
  1014. userManagerParams: userManagerParams{
  1015. allUsersParams: allUsersParams{
  1016. {
  1017. result: []state.User{},
  1018. },
  1019. },
  1020. },
  1021. },
  1022. },
  1023. {
  1024. name: "user store containing 3 users",
  1025. want: `[{"id":"usera","screen_name":"userA","is_icq":false,"suspended_status":"","is_bot":false},{"id":"userb","screen_name":"userB","is_icq":false,"suspended_status":"","is_bot":true},{"id":"100003","screen_name":"100003","is_icq":true,"suspended_status":"","is_bot":false}]`,
  1026. statusCode: http.StatusOK,
  1027. mockParams: mockParams{
  1028. userManagerParams: userManagerParams{
  1029. allUsersParams: allUsersParams{
  1030. {
  1031. result: []state.User{
  1032. {
  1033. DisplayScreenName: "userA",
  1034. IdentScreenName: state.NewIdentScreenName("userA"),
  1035. },
  1036. {
  1037. DisplayScreenName: "userB",
  1038. IdentScreenName: state.NewIdentScreenName("userB"),
  1039. IsBot: true,
  1040. },
  1041. {
  1042. DisplayScreenName: "100003",
  1043. IdentScreenName: state.NewIdentScreenName("100003"),
  1044. IsICQ: true,
  1045. },
  1046. },
  1047. },
  1048. },
  1049. },
  1050. },
  1051. },
  1052. {
  1053. name: "user handler error",
  1054. want: `internal server error`,
  1055. statusCode: http.StatusInternalServerError,
  1056. mockParams: mockParams{
  1057. userManagerParams: userManagerParams{
  1058. allUsersParams: allUsersParams{
  1059. {
  1060. result: []state.User{},
  1061. err: io.EOF,
  1062. },
  1063. },
  1064. },
  1065. },
  1066. },
  1067. }
  1068. for _, tc := range tt {
  1069. t.Run(tc.name, func(t *testing.T) {
  1070. request := httptest.NewRequest(http.MethodGet, "/user", nil)
  1071. responseRecorder := httptest.NewRecorder()
  1072. userManager := newMockUserManager(t)
  1073. for _, params := range tc.mockParams.allUsersParams {
  1074. userManager.EXPECT().
  1075. AllUsers(matchContext()).
  1076. Return(params.result, params.err)
  1077. }
  1078. getUserHandler(responseRecorder, request, userManager, slog.Default())
  1079. if responseRecorder.Code != tc.statusCode {
  1080. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1081. }
  1082. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1083. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  1084. }
  1085. })
  1086. }
  1087. }
  1088. func TestUserHandler_POST(t *testing.T) {
  1089. tt := []struct {
  1090. name string
  1091. body string
  1092. want string
  1093. statusCode int
  1094. createAccount state.CreateAccountFunc
  1095. }{
  1096. {
  1097. name: "with valid AIM user",
  1098. body: `{"screen_name":"userA", "password":"thepassword"}`,
  1099. want: `User account created successfully.`,
  1100. statusCode: http.StatusCreated,
  1101. createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
  1102. assert.Equal(t, state.DisplayScreenName("userA"), screenName)
  1103. assert.Equal(t, "thepassword", password)
  1104. return nil
  1105. },
  1106. },
  1107. {
  1108. name: "with valid ICQ user",
  1109. body: `{"screen_name":"100003", "password":"thepass"}`,
  1110. want: `User account created successfully.`,
  1111. statusCode: http.StatusCreated,
  1112. createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
  1113. assert.Equal(t, state.DisplayScreenName("100003"), screenName)
  1114. assert.Equal(t, "thepass", password)
  1115. return nil
  1116. },
  1117. },
  1118. {
  1119. name: "with malformed body",
  1120. body: `{"screen_name":"userA", "password":"thepassword"`, // missing closing }
  1121. want: `malformed input`,
  1122. statusCode: http.StatusBadRequest,
  1123. },
  1124. {
  1125. name: "user handler error",
  1126. body: `{"screen_name":"userA", "password":"thepassword"}`,
  1127. want: `internal server error`,
  1128. statusCode: http.StatusInternalServerError,
  1129. createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
  1130. assert.Equal(t, state.DisplayScreenName("userA"), screenName)
  1131. assert.Equal(t, "thepassword", password)
  1132. return io.EOF
  1133. },
  1134. },
  1135. {
  1136. name: "duplicate user",
  1137. body: `{"screen_name":"userA", "password":"thepassword"}`,
  1138. want: `user already exists`,
  1139. statusCode: http.StatusConflict,
  1140. createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
  1141. assert.Equal(t, state.DisplayScreenName("userA"), screenName)
  1142. assert.Equal(t, "thepassword", password)
  1143. return state.ErrDupUser
  1144. },
  1145. },
  1146. {
  1147. name: "invalid AIM screen name",
  1148. body: `{"screen_name":"a", "password":"thepassword"}`,
  1149. want: `invalid screen name: screen name must be between 3 and 16 characters`,
  1150. statusCode: http.StatusBadRequest,
  1151. createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
  1152. assert.Equal(t, state.DisplayScreenName("a"), screenName)
  1153. assert.Equal(t, "thepassword", password)
  1154. return state.ErrAIMHandleLength
  1155. },
  1156. },
  1157. {
  1158. name: "invalid AIM password",
  1159. body: `{"screen_name":"userA", "password":"1"}`,
  1160. want: `invalid password: invalid password length: password length must be between 4-16 characters`,
  1161. statusCode: http.StatusBadRequest,
  1162. createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
  1163. assert.Equal(t, state.DisplayScreenName("userA"), screenName)
  1164. assert.Equal(t, "1", password)
  1165. return fmt.Errorf("%w: password length must be between 4-16 characters", state.ErrPasswordInvalid)
  1166. },
  1167. },
  1168. {
  1169. name: "invalid ICQ UIN",
  1170. body: `{"screen_name":"1000", "password":"thepass"}`,
  1171. want: `invalid uin: uin must be a number in the range 10000-2147483646`,
  1172. statusCode: http.StatusBadRequest,
  1173. createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
  1174. assert.Equal(t, state.DisplayScreenName("1000"), screenName)
  1175. assert.Equal(t, "thepass", password)
  1176. return state.ErrICQUINInvalidFormat
  1177. },
  1178. },
  1179. {
  1180. name: "invalid ICQ password",
  1181. body: `{"screen_name":"100003", "password":"thelongpassword"}`,
  1182. want: `invalid password: invalid password length: password must be between 6-8 characters`,
  1183. statusCode: http.StatusBadRequest,
  1184. createAccount: func(ctx context.Context, screenName state.DisplayScreenName, password string) error {
  1185. assert.Equal(t, state.DisplayScreenName("100003"), screenName)
  1186. assert.Equal(t, "thelongpassword", password)
  1187. return fmt.Errorf("%w: password must be between 6-8 characters", state.ErrPasswordInvalid)
  1188. },
  1189. },
  1190. }
  1191. for _, tc := range tt {
  1192. t.Run(tc.name, func(t *testing.T) {
  1193. request := httptest.NewRequest(http.MethodPost, "/user", strings.NewReader(tc.body))
  1194. responseRecorder := httptest.NewRecorder()
  1195. postUserHandler(responseRecorder, request, tc.createAccount, slog.Default())
  1196. if responseRecorder.Code != tc.statusCode {
  1197. t.Errorf("want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1198. }
  1199. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1200. t.Errorf("want '%s', got '%s'", tc.want, responseRecorder.Body)
  1201. }
  1202. })
  1203. }
  1204. }
  1205. func TestUserHandler_DELETE(t *testing.T) {
  1206. tt := []struct {
  1207. name string
  1208. body string
  1209. want string
  1210. statusCode int
  1211. mockParams mockParams
  1212. }{
  1213. {
  1214. name: "with valid user",
  1215. body: `{"screen_name":"userA"}`,
  1216. want: `User account successfully deleted.`,
  1217. statusCode: http.StatusNoContent,
  1218. mockParams: mockParams{
  1219. userManagerParams: userManagerParams{
  1220. deleteUserParams: deleteUserParams{
  1221. {
  1222. screenName: state.NewIdentScreenName("userA"),
  1223. },
  1224. },
  1225. },
  1226. },
  1227. },
  1228. {
  1229. name: "with non-existent user",
  1230. body: `{"screen_name":"userA"}`,
  1231. want: `user does not exist`,
  1232. statusCode: http.StatusNotFound,
  1233. mockParams: mockParams{
  1234. userManagerParams: userManagerParams{
  1235. deleteUserParams: deleteUserParams{
  1236. {
  1237. screenName: state.NewIdentScreenName("userA"),
  1238. err: state.ErrNoUser,
  1239. },
  1240. },
  1241. },
  1242. },
  1243. },
  1244. {
  1245. name: "with malformed body",
  1246. body: `{"screen_name":"userA"`, // missing closing }
  1247. want: `malformed input`,
  1248. statusCode: http.StatusBadRequest,
  1249. },
  1250. {
  1251. name: "user handler error",
  1252. body: `{"screen_name":"userA"}`,
  1253. want: `internal server error`,
  1254. statusCode: http.StatusInternalServerError,
  1255. mockParams: mockParams{
  1256. userManagerParams: userManagerParams{
  1257. deleteUserParams: deleteUserParams{
  1258. {
  1259. screenName: state.NewIdentScreenName("userA"),
  1260. err: io.EOF,
  1261. },
  1262. },
  1263. },
  1264. },
  1265. },
  1266. }
  1267. for _, tc := range tt {
  1268. t.Run(tc.name, func(t *testing.T) {
  1269. request := httptest.NewRequest(http.MethodDelete, "/user", strings.NewReader(tc.body))
  1270. responseRecorder := httptest.NewRecorder()
  1271. userManager := newMockUserManager(t)
  1272. for _, params := range tc.mockParams.deleteUserParams {
  1273. userManager.EXPECT().
  1274. DeleteUser(matchContext(), params.screenName).
  1275. Return(params.err)
  1276. }
  1277. deleteUserHandler(responseRecorder, request, userManager, slog.Default())
  1278. if responseRecorder.Code != tc.statusCode {
  1279. t.Errorf("want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1280. }
  1281. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1282. t.Errorf("want '%s', got '%s'", tc.want, responseRecorder.Body)
  1283. }
  1284. })
  1285. }
  1286. }
  1287. func TestUserPasswordHandler_PUT(t *testing.T) {
  1288. tt := []struct {
  1289. name string
  1290. body string
  1291. want string
  1292. statusCode int
  1293. mockParams mockParams
  1294. }{
  1295. {
  1296. name: "user with valid password",
  1297. body: `{"screen_name":"userA", "password":"thenewpassword"}`,
  1298. want: `Password successfully reset.`,
  1299. statusCode: http.StatusNoContent,
  1300. mockParams: mockParams{
  1301. userManagerParams: userManagerParams{
  1302. setUserPasswordParams: setUserPasswordParams{
  1303. {
  1304. screenName: state.NewIdentScreenName("userA"),
  1305. newPassword: "thenewpassword",
  1306. },
  1307. },
  1308. },
  1309. },
  1310. },
  1311. {
  1312. name: "user with invalid password",
  1313. body: `{"screen_name":"userA", "password":"a"}`,
  1314. want: `invalid password length`,
  1315. statusCode: http.StatusBadRequest,
  1316. mockParams: mockParams{
  1317. userManagerParams: userManagerParams{
  1318. setUserPasswordParams: setUserPasswordParams{
  1319. {
  1320. screenName: state.NewIdentScreenName("userA"),
  1321. newPassword: "a",
  1322. err: state.ErrPasswordInvalid,
  1323. },
  1324. },
  1325. },
  1326. },
  1327. },
  1328. {
  1329. name: "with malformed body",
  1330. body: `{"screen_name":"userA", "password":"thepassword"`, // missing closing }
  1331. want: `malformed input`,
  1332. statusCode: http.StatusBadRequest,
  1333. },
  1334. {
  1335. name: "password updater returns runtime error",
  1336. body: `{"screen_name":"userA", "password":"thepassword"}`,
  1337. want: `internal server error`,
  1338. statusCode: http.StatusInternalServerError,
  1339. mockParams: mockParams{
  1340. userManagerParams: userManagerParams{
  1341. setUserPasswordParams: setUserPasswordParams{
  1342. {
  1343. screenName: state.NewIdentScreenName("userA"),
  1344. newPassword: "thepassword",
  1345. err: io.EOF,
  1346. },
  1347. },
  1348. },
  1349. },
  1350. },
  1351. {
  1352. name: "user doesn't exist",
  1353. body: `{"screen_name":"userA", "password":"thepassword"}`,
  1354. want: `user does not exist`,
  1355. statusCode: http.StatusNotFound,
  1356. mockParams: mockParams{
  1357. userManagerParams: userManagerParams{
  1358. setUserPasswordParams: setUserPasswordParams{
  1359. {
  1360. screenName: state.NewIdentScreenName("userA"),
  1361. newPassword: "thepassword",
  1362. err: state.ErrNoUser,
  1363. },
  1364. },
  1365. },
  1366. },
  1367. },
  1368. }
  1369. for _, tc := range tt {
  1370. t.Run(tc.name, func(t *testing.T) {
  1371. request := httptest.NewRequest(http.MethodPut, "/user", strings.NewReader(tc.body))
  1372. responseRecorder := httptest.NewRecorder()
  1373. userManager := newMockUserManager(t)
  1374. for _, params := range tc.mockParams.setUserPasswordParams {
  1375. userManager.EXPECT().
  1376. SetUserPassword(matchContext(), params.screenName, params.newPassword).
  1377. Return(params.err)
  1378. }
  1379. putUserPasswordHandler(responseRecorder, request, userManager, slog.Default())
  1380. if responseRecorder.Code != tc.statusCode {
  1381. t.Errorf("want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1382. }
  1383. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1384. t.Errorf("want '%s', got '%s'", tc.want, responseRecorder.Body)
  1385. }
  1386. })
  1387. }
  1388. }
  1389. func TestPublicChatHandler_GET(t *testing.T) {
  1390. fnNewSess := func(screenName string) *state.Session {
  1391. sess := state.NewSession()
  1392. sess.SetIdentScreenName(state.NewIdentScreenName(screenName))
  1393. sess.SetDisplayScreenName(state.DisplayScreenName(screenName))
  1394. instance := sess.AddInstance()
  1395. instance.SetSignonComplete()
  1396. return sess
  1397. }
  1398. chatRoom1 := state.NewChatRoom("chat-room-1-name", state.NewIdentScreenName("chat-room-1-creator"), state.PublicExchange)
  1399. chatRoom2 := state.NewChatRoom("chat-room-2-name", state.NewIdentScreenName("chat-room-1-creator"), state.PublicExchange)
  1400. tt := []struct {
  1401. name string
  1402. want string
  1403. statusCode int
  1404. mockParams mockParams
  1405. }{
  1406. {
  1407. name: "multiple chat rooms with participants",
  1408. want: `[{"name":"chat-room-1-name","create_time":"0001-01-01T00:00:00Z","url":"aim:gochat?roomname=chat-room-1-name&exchange=5","participants":[{"id":"usera","screen_name":"userA"},{"id":"userb","screen_name":"userB"}]},{"name":"chat-room-2-name","create_time":"0001-01-01T00:00:00Z","url":"aim:gochat?roomname=chat-room-2-name&exchange=5","participants":[{"id":"userc","screen_name":"userC"},{"id":"userd","screen_name":"userD"}]}]`,
  1409. statusCode: http.StatusOK,
  1410. mockParams: mockParams{
  1411. chatRoomRetrieverParams: chatRoomRetrieverParams{
  1412. allChatRoomsParams: allChatRoomsParams{
  1413. {
  1414. exchange: state.PublicExchange,
  1415. result: []state.ChatRoom{
  1416. chatRoom1,
  1417. chatRoom2,
  1418. },
  1419. },
  1420. },
  1421. },
  1422. chatSessionRetrieverParams: chatSessionRetrieverParams{
  1423. chatSessionRetrieverAllSessionsParams: chatSessionRetrieverAllSessionsParams{
  1424. {
  1425. cookie: chatRoom1.Cookie(),
  1426. result: []*state.Session{
  1427. fnNewSess("userA"),
  1428. fnNewSess("userB"),
  1429. },
  1430. },
  1431. {
  1432. cookie: chatRoom2.Cookie(),
  1433. result: []*state.Session{
  1434. fnNewSess("userC"),
  1435. fnNewSess("userD"),
  1436. },
  1437. },
  1438. },
  1439. },
  1440. },
  1441. },
  1442. {
  1443. name: "chat room without participants",
  1444. want: `[{"name":"chat-room-1-name","create_time":"0001-01-01T00:00:00Z","url":"aim:gochat?roomname=chat-room-1-name&exchange=5","participants":[]}]`,
  1445. statusCode: http.StatusOK,
  1446. mockParams: mockParams{
  1447. chatRoomRetrieverParams: chatRoomRetrieverParams{
  1448. allChatRoomsParams: allChatRoomsParams{
  1449. {
  1450. exchange: state.PublicExchange,
  1451. result: []state.ChatRoom{
  1452. chatRoom1,
  1453. },
  1454. },
  1455. },
  1456. },
  1457. chatSessionRetrieverParams: chatSessionRetrieverParams{
  1458. chatSessionRetrieverAllSessionsParams: chatSessionRetrieverAllSessionsParams{
  1459. {
  1460. cookie: chatRoom1.Cookie(),
  1461. result: []*state.Session{},
  1462. },
  1463. },
  1464. },
  1465. },
  1466. },
  1467. {
  1468. name: "no chat rooms",
  1469. want: `[]`,
  1470. statusCode: http.StatusOK,
  1471. mockParams: mockParams{
  1472. chatRoomRetrieverParams: chatRoomRetrieverParams{
  1473. allChatRoomsParams: allChatRoomsParams{
  1474. {
  1475. exchange: state.PublicExchange,
  1476. result: []state.ChatRoom{},
  1477. },
  1478. },
  1479. },
  1480. },
  1481. },
  1482. }
  1483. for _, tc := range tt {
  1484. t.Run(tc.name, func(t *testing.T) {
  1485. request := httptest.NewRequest(http.MethodGet, "/chat/room/public", nil)
  1486. responseRecorder := httptest.NewRecorder()
  1487. chatRoomRetriever := newMockChatRoomRetriever(t)
  1488. for _, params := range tc.mockParams.allChatRoomsParams {
  1489. chatRoomRetriever.EXPECT().
  1490. AllChatRooms(matchContext(), params.exchange).
  1491. Return(params.result, params.err)
  1492. }
  1493. chatSessionRetriever := newMockChatSessionRetriever(t)
  1494. for _, params := range tc.mockParams.chatSessionRetrieverAllSessionsParams {
  1495. chatSessionRetriever.EXPECT().
  1496. AllSessions(params.cookie).
  1497. Return(params.result)
  1498. }
  1499. getPublicChatHandler(responseRecorder, request, chatRoomRetriever, chatSessionRetriever, slog.Default())
  1500. if responseRecorder.Code != tc.statusCode {
  1501. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1502. }
  1503. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1504. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  1505. }
  1506. })
  1507. }
  1508. }
  1509. func TestDeletePublicChatHandler(t *testing.T) {
  1510. tt := []struct {
  1511. name string
  1512. body string
  1513. want string
  1514. statusCode int
  1515. mockParams mockParams
  1516. }{
  1517. {
  1518. name: "successful deletion of single chat room",
  1519. body: `{"names":["TestRoom"]}`,
  1520. want: `Chat rooms deleted successfully.`,
  1521. statusCode: http.StatusNoContent,
  1522. mockParams: mockParams{
  1523. chatRoomDeleterParams: chatRoomDeleterParams{
  1524. deleteChatRoomsParams: deleteChatRoomsParams{
  1525. {
  1526. exchange: state.PublicExchange,
  1527. names: []string{"TestRoom"},
  1528. },
  1529. },
  1530. },
  1531. },
  1532. },
  1533. {
  1534. name: "successful deletion of multiple chat rooms",
  1535. body: `{"names":["Room1", "Room2", "Room3"]}`,
  1536. want: `Chat rooms deleted successfully.`,
  1537. statusCode: http.StatusNoContent,
  1538. mockParams: mockParams{
  1539. chatRoomDeleterParams: chatRoomDeleterParams{
  1540. deleteChatRoomsParams: deleteChatRoomsParams{
  1541. {
  1542. exchange: state.PublicExchange,
  1543. names: []string{"Room1", "Room2", "Room3"},
  1544. },
  1545. },
  1546. },
  1547. },
  1548. },
  1549. {
  1550. name: "empty names array",
  1551. body: `{"names":[]}`,
  1552. want: `no chat room names provided`,
  1553. statusCode: http.StatusBadRequest,
  1554. },
  1555. {
  1556. name: "malformed JSON",
  1557. body: `{"names":["Room1"`, // missing closing brackets
  1558. want: `malformed input`,
  1559. statusCode: http.StatusBadRequest,
  1560. },
  1561. {
  1562. name: "deletion error",
  1563. body: `{"names":["TestRoom"]}`,
  1564. want: `internal server error`,
  1565. statusCode: http.StatusInternalServerError,
  1566. mockParams: mockParams{
  1567. chatRoomDeleterParams: chatRoomDeleterParams{
  1568. deleteChatRoomsParams: deleteChatRoomsParams{
  1569. {
  1570. exchange: state.PublicExchange,
  1571. names: []string{"TestRoom"},
  1572. err: errors.New("database error"),
  1573. },
  1574. },
  1575. },
  1576. },
  1577. },
  1578. }
  1579. for _, tc := range tt {
  1580. t.Run(tc.name, func(t *testing.T) {
  1581. request := httptest.NewRequest(http.MethodDelete, "/chat/room/public", strings.NewReader(tc.body))
  1582. responseRecorder := httptest.NewRecorder()
  1583. chatRoomDeleter := newMockChatRoomDeleter(t)
  1584. for _, params := range tc.mockParams.deleteChatRoomsParams {
  1585. chatRoomDeleter.EXPECT().
  1586. DeleteChatRooms(matchContext(), params.exchange, params.names).
  1587. Return(params.err)
  1588. }
  1589. deletePublicChatHandler(responseRecorder, request, chatRoomDeleter, slog.Default())
  1590. if responseRecorder.Code != tc.statusCode {
  1591. t.Errorf("want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1592. }
  1593. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1594. t.Errorf("want '%s', got '%s'", tc.want, responseRecorder.Body)
  1595. }
  1596. })
  1597. }
  1598. }
  1599. func TestPrivateChatHandler_GET(t *testing.T) {
  1600. fnNewSess := func(screenName string) *state.Session {
  1601. sess := state.NewSession()
  1602. sess.SetIdentScreenName(state.NewIdentScreenName(screenName))
  1603. sess.SetDisplayScreenName(state.DisplayScreenName(screenName))
  1604. instance := sess.AddInstance()
  1605. instance.SetSignonComplete()
  1606. return sess
  1607. }
  1608. chatRoom1 := state.NewChatRoom("chat-room-1-name", state.NewIdentScreenName("chat-room-1-creator"), state.PrivateExchange)
  1609. chatRoom2 := state.NewChatRoom("chat-room-2-name", state.NewIdentScreenName("chat-room-2-creator"), state.PrivateExchange)
  1610. tt := []struct {
  1611. name string
  1612. want string
  1613. statusCode int
  1614. mockParams mockParams
  1615. }{
  1616. {
  1617. name: "multiple chat rooms with participants",
  1618. want: `[{"name":"chat-room-1-name","create_time":"0001-01-01T00:00:00Z","creator_id":"chat-room-1-creator","url":"aim:gochat?roomname=chat-room-1-name&exchange=4","participants":[{"id":"usera","screen_name":"userA"},{"id":"userb","screen_name":"userB"}]},{"name":"chat-room-2-name","create_time":"0001-01-01T00:00:00Z","creator_id":"chat-room-2-creator","url":"aim:gochat?roomname=chat-room-2-name&exchange=4","participants":[{"id":"userc","screen_name":"userC"},{"id":"userd","screen_name":"userD"}]}]`,
  1619. statusCode: http.StatusOK,
  1620. mockParams: mockParams{
  1621. chatRoomRetrieverParams: chatRoomRetrieverParams{
  1622. allChatRoomsParams: allChatRoomsParams{
  1623. {
  1624. exchange: state.PrivateExchange,
  1625. result: []state.ChatRoom{
  1626. chatRoom1,
  1627. chatRoom2,
  1628. },
  1629. },
  1630. },
  1631. },
  1632. chatSessionRetrieverParams: chatSessionRetrieverParams{
  1633. chatSessionRetrieverAllSessionsParams: chatSessionRetrieverAllSessionsParams{
  1634. {
  1635. cookie: chatRoom1.Cookie(),
  1636. result: []*state.Session{
  1637. fnNewSess("userA"),
  1638. fnNewSess("userB"),
  1639. },
  1640. },
  1641. {
  1642. cookie: chatRoom2.Cookie(),
  1643. result: []*state.Session{
  1644. fnNewSess("userC"),
  1645. fnNewSess("userD"),
  1646. },
  1647. },
  1648. },
  1649. },
  1650. },
  1651. },
  1652. {
  1653. name: "chat room without participants",
  1654. want: `[{"name":"chat-room-1-name","create_time":"0001-01-01T00:00:00Z","creator_id":"chat-room-1-creator","url":"aim:gochat?roomname=chat-room-1-name&exchange=4","participants":[]}]`,
  1655. statusCode: http.StatusOK,
  1656. mockParams: mockParams{
  1657. chatRoomRetrieverParams: chatRoomRetrieverParams{
  1658. allChatRoomsParams: allChatRoomsParams{
  1659. {
  1660. exchange: state.PrivateExchange,
  1661. result: []state.ChatRoom{
  1662. chatRoom1,
  1663. },
  1664. },
  1665. },
  1666. },
  1667. chatSessionRetrieverParams: chatSessionRetrieverParams{
  1668. chatSessionRetrieverAllSessionsParams: chatSessionRetrieverAllSessionsParams{
  1669. {
  1670. cookie: chatRoom1.Cookie(),
  1671. result: []*state.Session{},
  1672. },
  1673. },
  1674. },
  1675. },
  1676. },
  1677. {
  1678. name: "no chat rooms",
  1679. want: `[]`,
  1680. statusCode: http.StatusOK,
  1681. mockParams: mockParams{
  1682. chatRoomRetrieverParams: chatRoomRetrieverParams{
  1683. allChatRoomsParams: allChatRoomsParams{
  1684. {
  1685. exchange: state.PrivateExchange,
  1686. result: []state.ChatRoom{},
  1687. },
  1688. },
  1689. },
  1690. },
  1691. },
  1692. }
  1693. for _, tc := range tt {
  1694. t.Run(tc.name, func(t *testing.T) {
  1695. request := httptest.NewRequest(http.MethodGet, "/chat/room/private", nil)
  1696. responseRecorder := httptest.NewRecorder()
  1697. chatRoomRetriever := newMockChatRoomRetriever(t)
  1698. for _, params := range tc.mockParams.allChatRoomsParams {
  1699. chatRoomRetriever.EXPECT().
  1700. AllChatRooms(matchContext(), params.exchange).
  1701. Return(params.result, params.err)
  1702. }
  1703. chatSessionRetriever := newMockChatSessionRetriever(t)
  1704. for _, params := range tc.mockParams.chatSessionRetrieverAllSessionsParams {
  1705. chatSessionRetriever.EXPECT().
  1706. AllSessions(params.cookie).
  1707. Return(params.result)
  1708. }
  1709. getPrivateChatHandler(responseRecorder, request, chatRoomRetriever, chatSessionRetriever, slog.Default())
  1710. if responseRecorder.Code != tc.statusCode {
  1711. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1712. }
  1713. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1714. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  1715. }
  1716. })
  1717. }
  1718. }
  1719. func TestInstantMessageHandler_POST(t *testing.T) {
  1720. senderExists := getUserParams{
  1721. {
  1722. screenName: state.NewIdentScreenName("sender_sn"),
  1723. result: &state.User{IdentScreenName: state.NewIdentScreenName("sender_sn")},
  1724. },
  1725. }
  1726. tt := []struct {
  1727. name string
  1728. body string
  1729. getUserParams getUserParams
  1730. wantText string
  1731. wantStore bool
  1732. sendCalled bool
  1733. reply *wire.SNACMessage
  1734. sendErr error
  1735. want string
  1736. statusCode int
  1737. }{
  1738. {
  1739. name: "send an instant message",
  1740. body: `{"from":"sender_sn","to":"recip_sn","text":"hello world!"}`,
  1741. getUserParams: senderExists,
  1742. sendCalled: true,
  1743. want: `Message sent successfully.`,
  1744. statusCode: http.StatusOK,
  1745. },
  1746. {
  1747. name: "send an instant message with non-ASCII text",
  1748. body: `{"from":"sender_sn","to":"recip_sn","text":"héllo wörld 日本 😀"}`,
  1749. wantText: "héllo wörld 日本 \uFFFD",
  1750. getUserParams: senderExists,
  1751. sendCalled: true,
  1752. want: `Message sent successfully.`,
  1753. statusCode: http.StatusOK,
  1754. },
  1755. {
  1756. name: "recipient is offline",
  1757. body: `{"from":"sender_sn","to":"recip_sn","text":"hello world!"}`,
  1758. getUserParams: senderExists,
  1759. sendCalled: true,
  1760. reply: &wire.SNACMessage{
  1761. Frame: wire.SNACFrame{FoodGroup: wire.ICBM, SubGroup: wire.ICBMErr},
  1762. Body: wire.SNACError{Code: wire.ErrorCodeNotLoggedOn},
  1763. },
  1764. want: `recipient is not online`,
  1765. statusCode: http.StatusNotFound,
  1766. },
  1767. {
  1768. name: "store message for offline recipient",
  1769. body: `{"from":"sender_sn","to":"recip_sn","text":"hello world!","storeOffline":true}`,
  1770. wantStore: true,
  1771. getUserParams: senderExists,
  1772. sendCalled: true,
  1773. want: `Message sent successfully.`,
  1774. statusCode: http.StatusOK,
  1775. },
  1776. {
  1777. name: "offline recipient does not accept stored message",
  1778. body: `{"from":"sender_sn","to":"recip_sn","text":"hello world!","storeOffline":true}`,
  1779. wantStore: true,
  1780. getUserParams: senderExists,
  1781. sendCalled: true,
  1782. reply: &wire.SNACMessage{
  1783. Frame: wire.SNACFrame{FoodGroup: wire.ICBM, SubGroup: wire.ICBMErr},
  1784. Body: wire.SNACError{Code: wire.ErrorCodeNotLoggedOn},
  1785. },
  1786. want: `recipient is not online`,
  1787. statusCode: http.StatusNotFound,
  1788. },
  1789. {
  1790. name: "do not store message for offline recipient",
  1791. body: `{"from":"sender_sn","to":"recip_sn","text":"hello world!","storeOffline":false}`,
  1792. getUserParams: senderExists,
  1793. sendCalled: true,
  1794. reply: &wire.SNACMessage{
  1795. Frame: wire.SNACFrame{FoodGroup: wire.ICBM, SubGroup: wire.ICBMErr},
  1796. Body: wire.SNACError{Code: wire.ErrorCodeNotLoggedOn},
  1797. },
  1798. want: `recipient is not online`,
  1799. statusCode: http.StatusNotFound,
  1800. },
  1801. {
  1802. name: "sender is blocked",
  1803. body: `{"from":"sender_sn","to":"recip_sn","text":"hello world!"}`,
  1804. getUserParams: senderExists,
  1805. sendCalled: true,
  1806. reply: &wire.SNACMessage{
  1807. Frame: wire.SNACFrame{FoodGroup: wire.ICBM, SubGroup: wire.ICBMErr},
  1808. Body: wire.SNACError{Code: wire.ErrorCodeInLocalPermitDeny},
  1809. },
  1810. want: `message blocked`,
  1811. statusCode: http.StatusForbidden,
  1812. },
  1813. {
  1814. name: "send fails",
  1815. body: `{"from":"sender_sn","to":"recip_sn","text":"hello world!"}`,
  1816. getUserParams: senderExists,
  1817. sendCalled: true,
  1818. sendErr: io.EOF,
  1819. want: `internal server error`,
  1820. statusCode: http.StatusInternalServerError,
  1821. },
  1822. {
  1823. name: "sender does not exist",
  1824. body: `{"from":"sender_sn","to":"recip_sn","text":"hello world!","storeOffline":true}`,
  1825. getUserParams: getUserParams{
  1826. {
  1827. screenName: state.NewIdentScreenName("sender_sn"),
  1828. result: nil,
  1829. },
  1830. },
  1831. want: `sender does not exist`,
  1832. statusCode: http.StatusBadRequest,
  1833. },
  1834. {
  1835. name: "sender lookup fails",
  1836. body: `{"from":"sender_sn","to":"recip_sn","text":"hello world!"}`,
  1837. getUserParams: getUserParams{
  1838. {
  1839. screenName: state.NewIdentScreenName("sender_sn"),
  1840. err: io.EOF,
  1841. },
  1842. },
  1843. want: `internal server error`,
  1844. statusCode: http.StatusInternalServerError,
  1845. },
  1846. {
  1847. name: "with malformed body",
  1848. body: `{"screen_name":"userA", "password":"thepassword"`,
  1849. want: `malformed input`,
  1850. statusCode: http.StatusBadRequest,
  1851. },
  1852. }
  1853. for _, tc := range tt {
  1854. t.Run(tc.name, func(t *testing.T) {
  1855. request := httptest.NewRequest(http.MethodPost, "/instant-message", strings.NewReader(tc.body))
  1856. responseRecorder := httptest.NewRecorder()
  1857. userManager := newMockUserManager(t)
  1858. for _, params := range tc.getUserParams {
  1859. userManager.EXPECT().
  1860. User(matchContext(), params.screenName).
  1861. Return(params.result, params.err)
  1862. }
  1863. sendCalled := false
  1864. icbmSender := func(ctx context.Context, instance *state.SessionInstance, inFrame wire.SNACFrame, inBody wire.SNAC_0x04_0x06_ICBMChannelMsgToHost) (*wire.SNACMessage, error) {
  1865. sendCalled = true
  1866. assert.Equal(t, state.NewIdentScreenName("sender_sn"), instance.IdentScreenName())
  1867. assert.Equal(t, wire.ICBM, inFrame.FoodGroup)
  1868. assert.Equal(t, wire.ICBMChannelMsgToHost, inFrame.SubGroup)
  1869. assert.Equal(t, "recip_sn", inBody.ScreenName)
  1870. assert.Equal(t, wire.ICBMChannelIM, inBody.ChannelID)
  1871. assert.Equal(t, [][16]byte{wire.CapUTF8Messages}, instance.Caps())
  1872. _, hasStore := inBody.Bytes(wire.ICBMTLVStore)
  1873. assert.Equal(t, tc.wantStore, hasStore)
  1874. wantText := tc.wantText
  1875. if wantText == "" {
  1876. wantText = "hello world!"
  1877. }
  1878. wantCharset := wire.ICBMMessageEncodingUnicode
  1879. if wire.AllASCII(wantText) {
  1880. wantCharset = wire.ICBMMessageEncodingASCII
  1881. }
  1882. b, ok := inBody.Bytes(wire.ICBMTLVAOLIMData)
  1883. assert.True(t, ok)
  1884. var frags []wire.ICBMCh1Fragment
  1885. assert.NoError(t, wire.UnmarshalBE(&frags, bytes.NewBuffer(b)))
  1886. for _, frag := range frags {
  1887. if frag.ID == 1 {
  1888. msg := wire.ICBMCh1Message{}
  1889. assert.NoError(t, wire.UnmarshalBE(&msg, bytes.NewBuffer(frag.Payload)))
  1890. assert.Equal(t, wantCharset, msg.Charset)
  1891. }
  1892. }
  1893. txt, err := wire.UnmarshalICBMMessageText(b)
  1894. assert.NoError(t, err)
  1895. assert.Equal(t, wantText, txt)
  1896. return tc.reply, tc.sendErr
  1897. }
  1898. postInstantMessageHandler(responseRecorder, request, userManager, icbmSender, slog.Default())
  1899. assert.Equal(t, tc.sendCalled, sendCalled)
  1900. assert.Equal(t, tc.statusCode, responseRecorder.Code)
  1901. assert.Equal(t, tc.want, strings.TrimSpace(responseRecorder.Body.String()))
  1902. })
  1903. }
  1904. }
  1905. func TestVersionHandler_GET(t *testing.T) {
  1906. tt := []struct {
  1907. name string
  1908. want string
  1909. statusCode int
  1910. buildInfo config.Build
  1911. }{
  1912. {
  1913. name: "get ras version",
  1914. want: `{"version":"13.3.7","commit":"asdfASDF12345678","date":"2024-03-01"}`,
  1915. statusCode: http.StatusOK,
  1916. buildInfo: config.Build{
  1917. Version: "13.3.7",
  1918. Commit: "asdfASDF12345678",
  1919. Date: "2024-03-01",
  1920. },
  1921. },
  1922. }
  1923. for _, tc := range tt {
  1924. t.Run(tc.name, func(t *testing.T) {
  1925. responseRecorder := httptest.NewRecorder()
  1926. getVersionHandler(responseRecorder, tc.buildInfo)
  1927. if responseRecorder.Code != tc.statusCode {
  1928. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  1929. }
  1930. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  1931. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  1932. }
  1933. })
  1934. }
  1935. }
  1936. func TestDirectoryCategoryHandler_GET(t *testing.T) {
  1937. tt := []struct {
  1938. name string
  1939. want string
  1940. statusCode int
  1941. mockParams mockParams
  1942. }{
  1943. {
  1944. name: "no categories",
  1945. want: `[]`,
  1946. statusCode: http.StatusOK,
  1947. mockParams: mockParams{
  1948. directoryManagerParams: directoryManagerParams{
  1949. categoriesParams: categoriesParams{
  1950. {
  1951. result: nil,
  1952. },
  1953. },
  1954. },
  1955. },
  1956. },
  1957. {
  1958. name: "error fetching categories",
  1959. want: `{"message":"internal server error"}`,
  1960. statusCode: http.StatusInternalServerError,
  1961. mockParams: mockParams{
  1962. directoryManagerParams: directoryManagerParams{
  1963. categoriesParams: categoriesParams{
  1964. {
  1965. result: nil,
  1966. err: errors.New("error fetching categories"),
  1967. },
  1968. },
  1969. },
  1970. },
  1971. },
  1972. {
  1973. name: "fetch some categories",
  1974. want: `[{"id":1,"name":"category-1"},{"id":2,"name":"category-2"}]`,
  1975. statusCode: http.StatusOK,
  1976. mockParams: mockParams{
  1977. directoryManagerParams: directoryManagerParams{
  1978. categoriesParams: categoriesParams{
  1979. {
  1980. result: []state.Category{
  1981. {
  1982. ID: 1,
  1983. Name: "category-1",
  1984. },
  1985. {
  1986. ID: 2,
  1987. Name: "category-2",
  1988. },
  1989. },
  1990. },
  1991. },
  1992. },
  1993. },
  1994. },
  1995. }
  1996. for _, tc := range tt {
  1997. t.Run(tc.name, func(t *testing.T) {
  1998. responseRecorder := httptest.NewRecorder()
  1999. request := httptest.NewRequest(http.MethodGet, "/directory/category", nil)
  2000. directoryManager := newMockDirectoryManager(t)
  2001. for _, params := range tc.mockParams.categoriesParams {
  2002. directoryManager.EXPECT().
  2003. Categories(matchContext()).
  2004. Return(params.result, params.err)
  2005. }
  2006. getDirectoryCategoryHandler(responseRecorder, request, directoryManager, slog.Default())
  2007. if responseRecorder.Code != tc.statusCode {
  2008. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  2009. }
  2010. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  2011. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  2012. }
  2013. })
  2014. }
  2015. }
  2016. func TestDirectoryAIMHandler_GET(t *testing.T) {
  2017. tt := []struct {
  2018. name string
  2019. want string
  2020. statusCode int
  2021. mockParams mockParams
  2022. }{
  2023. {
  2024. name: "no entries",
  2025. want: `[]`,
  2026. statusCode: http.StatusOK,
  2027. mockParams: mockParams{
  2028. directoryManagerParams: directoryManagerParams{
  2029. aimDirectoryEntriesParams: aimDirectoryEntriesParams{
  2030. {
  2031. result: nil,
  2032. },
  2033. },
  2034. },
  2035. },
  2036. },
  2037. {
  2038. name: "error fetching entries",
  2039. want: `{"message":"internal server error"}`,
  2040. statusCode: http.StatusInternalServerError,
  2041. mockParams: mockParams{
  2042. directoryManagerParams: directoryManagerParams{
  2043. aimDirectoryEntriesParams: aimDirectoryEntriesParams{
  2044. {
  2045. result: nil,
  2046. err: errors.New("error fetching entries"),
  2047. },
  2048. },
  2049. },
  2050. },
  2051. },
  2052. {
  2053. name: "fetch some entries",
  2054. want: `[{"screen_name":"Big Al","first_name":"Al","middle_name":"B","last_name":"Smith","maiden_name":"Jones","nickname":"Bigs","city":"Reno","state":"NV","country":"USA","address":"1 Main St","zip":"89501","keywords":["jazz","chess"]},{"screen_name":"Sue","first_name":"","middle_name":"","last_name":"","maiden_name":"","nickname":"","city":"","state":"","country":"","address":"","zip":"","keywords":[]}]`,
  2055. statusCode: http.StatusOK,
  2056. mockParams: mockParams{
  2057. directoryManagerParams: directoryManagerParams{
  2058. aimDirectoryEntriesParams: aimDirectoryEntriesParams{
  2059. {
  2060. result: []state.AIMDirectoryEntry{
  2061. {
  2062. DisplayScreenName: "Big Al",
  2063. Info: state.AIMNameAndAddr{
  2064. FirstName: "Al",
  2065. MiddleName: "B",
  2066. LastName: "Smith",
  2067. MaidenName: "Jones",
  2068. NickName: "Bigs",
  2069. City: "Reno",
  2070. State: "NV",
  2071. Country: "USA",
  2072. Address: "1 Main St",
  2073. ZIPCode: "89501",
  2074. },
  2075. Keywords: []string{"jazz", "chess"},
  2076. },
  2077. {
  2078. DisplayScreenName: "Sue",
  2079. },
  2080. },
  2081. },
  2082. },
  2083. },
  2084. },
  2085. },
  2086. }
  2087. for _, tc := range tt {
  2088. t.Run(tc.name, func(t *testing.T) {
  2089. responseRecorder := httptest.NewRecorder()
  2090. request := httptest.NewRequest(http.MethodGet, "/directory/aim", nil)
  2091. directoryManager := newMockDirectoryManager(t)
  2092. for _, params := range tc.mockParams.aimDirectoryEntriesParams {
  2093. directoryManager.EXPECT().
  2094. AIMDirectoryEntries(matchContext()).
  2095. Return(params.result, params.err)
  2096. }
  2097. getDirectoryAIMHandler(responseRecorder, request, directoryManager, slog.Default())
  2098. if responseRecorder.Code != tc.statusCode {
  2099. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  2100. }
  2101. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  2102. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  2103. }
  2104. })
  2105. }
  2106. }
  2107. func TestDirectoryCategoryKeywordHandler_GET(t *testing.T) {
  2108. tt := []struct {
  2109. name string
  2110. categoryID int
  2111. want string
  2112. statusCode int
  2113. mockParams mockParams
  2114. }{
  2115. {
  2116. name: "category not found",
  2117. categoryID: 1,
  2118. want: `{"message":"category not found"}`,
  2119. statusCode: http.StatusNotFound,
  2120. mockParams: mockParams{
  2121. directoryManagerParams: directoryManagerParams{
  2122. keywordsByCategoryParams: keywordsByCategoryParams{
  2123. {
  2124. categoryID: 1,
  2125. result: nil,
  2126. err: state.ErrKeywordCategoryNotFound,
  2127. },
  2128. },
  2129. },
  2130. },
  2131. },
  2132. {
  2133. name: "error fetching keywords by category",
  2134. categoryID: 1,
  2135. want: `{"message":"internal server error"}`,
  2136. statusCode: http.StatusInternalServerError,
  2137. mockParams: mockParams{
  2138. directoryManagerParams: directoryManagerParams{
  2139. keywordsByCategoryParams: keywordsByCategoryParams{
  2140. {
  2141. categoryID: 1,
  2142. result: nil,
  2143. err: errors.New("error fetching keywords by category"),
  2144. },
  2145. },
  2146. },
  2147. },
  2148. },
  2149. {
  2150. name: "invalid category ID",
  2151. categoryID: -1,
  2152. want: `{"message":"invalid category ID"}`,
  2153. statusCode: http.StatusBadRequest,
  2154. mockParams: mockParams{
  2155. directoryManagerParams: directoryManagerParams{
  2156. keywordsByCategoryParams: keywordsByCategoryParams{},
  2157. },
  2158. },
  2159. },
  2160. {
  2161. name: "no keywords",
  2162. categoryID: 1,
  2163. want: `[]`,
  2164. statusCode: http.StatusOK,
  2165. mockParams: mockParams{
  2166. directoryManagerParams: directoryManagerParams{
  2167. keywordsByCategoryParams: keywordsByCategoryParams{
  2168. {
  2169. categoryID: 1,
  2170. result: nil,
  2171. },
  2172. },
  2173. },
  2174. },
  2175. },
  2176. {
  2177. name: "fetch some keywords by category",
  2178. categoryID: 1,
  2179. want: `[{"id":1,"name":"keyword-1"},{"id":2,"name":"keyword-2"}]`,
  2180. statusCode: http.StatusOK,
  2181. mockParams: mockParams{
  2182. directoryManagerParams: directoryManagerParams{
  2183. keywordsByCategoryParams: keywordsByCategoryParams{
  2184. {
  2185. categoryID: 1,
  2186. result: []state.Keyword{
  2187. {
  2188. ID: 1,
  2189. Name: "keyword-1",
  2190. },
  2191. {
  2192. ID: 2,
  2193. Name: "keyword-2",
  2194. },
  2195. },
  2196. },
  2197. },
  2198. },
  2199. },
  2200. },
  2201. }
  2202. for _, tc := range tt {
  2203. t.Run(tc.name, func(t *testing.T) {
  2204. request := httptest.NewRequest(http.MethodGet, fmt.Sprintf("/directory/category/%d/keyword", tc.categoryID), nil)
  2205. request.SetPathValue("id", fmt.Sprintf("%d", tc.categoryID))
  2206. responseRecorder := httptest.NewRecorder()
  2207. directoryManager := newMockDirectoryManager(t)
  2208. for _, params := range tc.mockParams.keywordsByCategoryParams {
  2209. directoryManager.EXPECT().
  2210. KeywordsByCategory(matchContext(), params.categoryID).
  2211. Return(params.result, params.err)
  2212. }
  2213. getDirectoryCategoryKeywordHandler(responseRecorder, request, directoryManager, slog.Default())
  2214. if responseRecorder.Code != tc.statusCode {
  2215. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  2216. }
  2217. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  2218. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  2219. }
  2220. })
  2221. }
  2222. }
  2223. func TestDirectoryCategoryHandler_DELETE(t *testing.T) {
  2224. tt := []struct {
  2225. name string
  2226. categoryID int
  2227. want string
  2228. statusCode int
  2229. mockParams mockParams
  2230. }{
  2231. {
  2232. name: "category not found",
  2233. categoryID: 1,
  2234. want: `{"message":"category not found"}`,
  2235. statusCode: http.StatusNotFound,
  2236. mockParams: mockParams{
  2237. directoryManagerParams: directoryManagerParams{
  2238. deleteCategoryParams: deleteCategoryParams{
  2239. {
  2240. categoryID: 1,
  2241. err: state.ErrKeywordCategoryNotFound,
  2242. },
  2243. },
  2244. },
  2245. },
  2246. },
  2247. {
  2248. name: "keyword in use by user",
  2249. categoryID: 1,
  2250. want: `{"message":"can't delete because category in use by a user"}`,
  2251. statusCode: http.StatusConflict,
  2252. mockParams: mockParams{
  2253. directoryManagerParams: directoryManagerParams{
  2254. deleteCategoryParams: deleteCategoryParams{
  2255. {
  2256. categoryID: 1,
  2257. err: state.ErrKeywordInUse,
  2258. },
  2259. },
  2260. },
  2261. },
  2262. },
  2263. {
  2264. name: "runtime error",
  2265. categoryID: 1,
  2266. want: `{"message":"internal server error"}`,
  2267. statusCode: http.StatusInternalServerError,
  2268. mockParams: mockParams{
  2269. directoryManagerParams: directoryManagerParams{
  2270. deleteCategoryParams: deleteCategoryParams{
  2271. {
  2272. categoryID: 1,
  2273. err: errors.New("error deleting keyword"),
  2274. },
  2275. },
  2276. },
  2277. },
  2278. },
  2279. {
  2280. name: "successful deletion",
  2281. categoryID: 1,
  2282. want: ``,
  2283. statusCode: http.StatusNoContent,
  2284. mockParams: mockParams{
  2285. directoryManagerParams: directoryManagerParams{
  2286. deleteCategoryParams: deleteCategoryParams{
  2287. {
  2288. categoryID: 1,
  2289. },
  2290. },
  2291. },
  2292. },
  2293. },
  2294. {
  2295. name: "invalid category ID",
  2296. categoryID: -1,
  2297. want: `invalid category ID`,
  2298. statusCode: http.StatusBadRequest,
  2299. mockParams: mockParams{
  2300. directoryManagerParams: directoryManagerParams{
  2301. deleteCategoryParams: deleteCategoryParams{},
  2302. },
  2303. },
  2304. },
  2305. }
  2306. for _, tc := range tt {
  2307. t.Run(tc.name, func(t *testing.T) {
  2308. request := httptest.NewRequest(http.MethodDelete, fmt.Sprintf("/directory/category/%d/keyword", tc.categoryID), nil)
  2309. request.SetPathValue("id", fmt.Sprintf("%d", tc.categoryID))
  2310. responseRecorder := httptest.NewRecorder()
  2311. directoryManager := newMockDirectoryManager(t)
  2312. for _, params := range tc.mockParams.deleteCategoryParams {
  2313. directoryManager.EXPECT().
  2314. DeleteCategory(matchContext(), params.categoryID).
  2315. Return(params.err)
  2316. }
  2317. deleteDirectoryCategoryHandler(responseRecorder, request, directoryManager, slog.Default())
  2318. if responseRecorder.Code != tc.statusCode {
  2319. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  2320. }
  2321. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  2322. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  2323. }
  2324. })
  2325. }
  2326. }
  2327. func TestDirectoryCategoryHandler_POST(t *testing.T) {
  2328. tt := []struct {
  2329. name string
  2330. body string
  2331. want string
  2332. statusCode int
  2333. mockParams mockParams
  2334. }{
  2335. {
  2336. name: "category already exists",
  2337. body: `{"name":"the_category"}`,
  2338. want: `{"message":"category already exists"}`,
  2339. statusCode: http.StatusConflict,
  2340. mockParams: mockParams{
  2341. directoryManagerParams: directoryManagerParams{
  2342. createCategoryParams: createCategoryParams{
  2343. {
  2344. name: "the_category",
  2345. err: state.ErrKeywordCategoryExists,
  2346. },
  2347. },
  2348. },
  2349. },
  2350. },
  2351. {
  2352. name: "runtime error",
  2353. body: `{"name":"the_category"}`,
  2354. want: `{"message":"internal server error"}`,
  2355. statusCode: http.StatusInternalServerError,
  2356. mockParams: mockParams{
  2357. directoryManagerParams: directoryManagerParams{
  2358. createCategoryParams: createCategoryParams{
  2359. {
  2360. name: "the_category",
  2361. err: errors.New("error creating category"),
  2362. },
  2363. },
  2364. },
  2365. },
  2366. },
  2367. {
  2368. name: "bad input",
  2369. body: `{"name":"the_category"`,
  2370. want: `{"message":"malformed input"}`,
  2371. statusCode: http.StatusBadRequest,
  2372. mockParams: mockParams{
  2373. directoryManagerParams: directoryManagerParams{
  2374. createCategoryParams: createCategoryParams{},
  2375. },
  2376. },
  2377. },
  2378. {
  2379. name: "successful creation",
  2380. body: `{"name":"the_category"}`,
  2381. want: `{"id":1,"name":"the_category"}`,
  2382. statusCode: http.StatusCreated,
  2383. mockParams: mockParams{
  2384. directoryManagerParams: directoryManagerParams{
  2385. createCategoryParams: createCategoryParams{
  2386. {
  2387. name: "the_category",
  2388. result: state.Category{
  2389. ID: 1,
  2390. Name: "the_category",
  2391. },
  2392. },
  2393. },
  2394. },
  2395. },
  2396. },
  2397. }
  2398. for _, tc := range tt {
  2399. t.Run(tc.name, func(t *testing.T) {
  2400. request := httptest.NewRequest(http.MethodPost, "/directory/category", strings.NewReader(tc.body))
  2401. responseRecorder := httptest.NewRecorder()
  2402. directoryManager := newMockDirectoryManager(t)
  2403. for _, params := range tc.mockParams.createCategoryParams {
  2404. directoryManager.EXPECT().
  2405. CreateCategory(matchContext(), params.name).
  2406. Return(params.result, params.err)
  2407. }
  2408. postDirectoryCategoryHandler(responseRecorder, request, directoryManager, slog.Default())
  2409. if responseRecorder.Code != tc.statusCode {
  2410. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  2411. }
  2412. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  2413. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  2414. }
  2415. })
  2416. }
  2417. }
  2418. func TestDirectoryKeywordHandler_POST(t *testing.T) {
  2419. tt := []struct {
  2420. name string
  2421. body string
  2422. want string
  2423. statusCode int
  2424. mockParams mockParams
  2425. }{
  2426. {
  2427. name: "keyword already exists",
  2428. body: `{"category_id":1,"name":"the_keyword"}`,
  2429. want: `{"message":"keyword already exists"}`,
  2430. statusCode: http.StatusConflict,
  2431. mockParams: mockParams{
  2432. directoryManagerParams: directoryManagerParams{
  2433. createKeywordParams: createKeywordParams{
  2434. {
  2435. name: "the_keyword",
  2436. categoryID: 1,
  2437. err: state.ErrKeywordExists,
  2438. },
  2439. },
  2440. },
  2441. },
  2442. },
  2443. {
  2444. name: "category not found",
  2445. body: `{"category_id":1,"name":"the_keyword"}`,
  2446. want: `{"message":"category not found"}`,
  2447. statusCode: http.StatusNotFound,
  2448. mockParams: mockParams{
  2449. directoryManagerParams: directoryManagerParams{
  2450. createKeywordParams: createKeywordParams{
  2451. {
  2452. name: "the_keyword",
  2453. categoryID: 1,
  2454. err: state.ErrKeywordCategoryNotFound,
  2455. },
  2456. },
  2457. },
  2458. },
  2459. },
  2460. {
  2461. name: "runtime error",
  2462. body: `{"category_id":1,"name":"the_keyword"}`,
  2463. want: `{"message":"internal server error"}`,
  2464. statusCode: http.StatusInternalServerError,
  2465. mockParams: mockParams{
  2466. directoryManagerParams: directoryManagerParams{
  2467. createKeywordParams: createKeywordParams{
  2468. {
  2469. name: "the_keyword",
  2470. categoryID: 1,
  2471. err: errors.New("error creating keyword"),
  2472. },
  2473. },
  2474. },
  2475. },
  2476. },
  2477. {
  2478. name: "bad input",
  2479. body: `{"category_id":1,"name":"the_keyword"`,
  2480. want: `{"message":"malformed input"}`,
  2481. statusCode: http.StatusBadRequest,
  2482. mockParams: mockParams{
  2483. directoryManagerParams: directoryManagerParams{
  2484. createKeywordParams: createKeywordParams{},
  2485. },
  2486. },
  2487. },
  2488. {
  2489. name: "successful creation",
  2490. body: `{"category_id":1,"name":"the_keyword"}`,
  2491. want: `{"id":1,"name":"the_keyword"}`,
  2492. statusCode: http.StatusCreated,
  2493. mockParams: mockParams{
  2494. directoryManagerParams: directoryManagerParams{
  2495. createKeywordParams: createKeywordParams{
  2496. {
  2497. name: "the_keyword",
  2498. categoryID: 1,
  2499. result: state.Keyword{
  2500. ID: 1,
  2501. Name: "the_keyword",
  2502. },
  2503. },
  2504. },
  2505. },
  2506. },
  2507. },
  2508. }
  2509. for _, tc := range tt {
  2510. t.Run(tc.name, func(t *testing.T) {
  2511. request := httptest.NewRequest(http.MethodPost, "/directory/keyword", strings.NewReader(tc.body))
  2512. responseRecorder := httptest.NewRecorder()
  2513. directoryManager := newMockDirectoryManager(t)
  2514. for _, params := range tc.mockParams.createKeywordParams {
  2515. directoryManager.EXPECT().
  2516. CreateKeyword(matchContext(), params.name, params.categoryID).
  2517. Return(params.result, params.err)
  2518. }
  2519. postDirectoryKeywordHandler(responseRecorder, request, directoryManager, slog.Default())
  2520. if responseRecorder.Code != tc.statusCode {
  2521. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  2522. }
  2523. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  2524. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  2525. }
  2526. })
  2527. }
  2528. }
  2529. func TestDirectoryKeywordHandler_DELETE(t *testing.T) {
  2530. tt := []struct {
  2531. name string
  2532. categoryID int
  2533. want string
  2534. statusCode int
  2535. mockParams mockParams
  2536. }{
  2537. {
  2538. name: "keyword not found",
  2539. categoryID: 1,
  2540. want: `{"message":"keyword not found"}`,
  2541. statusCode: http.StatusNotFound,
  2542. mockParams: mockParams{
  2543. directoryManagerParams: directoryManagerParams{
  2544. deleteKeywordParams: deleteKeywordParams{
  2545. {
  2546. id: 1,
  2547. err: state.ErrKeywordNotFound,
  2548. },
  2549. },
  2550. },
  2551. },
  2552. },
  2553. {
  2554. name: "keyword in use by user",
  2555. categoryID: 1,
  2556. want: `{"message":"can't delete because category in use by a user"}`,
  2557. statusCode: http.StatusConflict,
  2558. mockParams: mockParams{
  2559. directoryManagerParams: directoryManagerParams{
  2560. deleteKeywordParams: deleteKeywordParams{
  2561. {
  2562. id: 1,
  2563. err: state.ErrKeywordInUse,
  2564. },
  2565. },
  2566. },
  2567. },
  2568. },
  2569. {
  2570. name: "runtime error",
  2571. categoryID: 1,
  2572. want: `{"message":"internal server error"}`,
  2573. statusCode: http.StatusInternalServerError,
  2574. mockParams: mockParams{
  2575. directoryManagerParams: directoryManagerParams{
  2576. deleteKeywordParams: deleteKeywordParams{
  2577. {
  2578. id: 1,
  2579. err: errors.New("error deleting keyword"),
  2580. },
  2581. },
  2582. },
  2583. },
  2584. },
  2585. {
  2586. name: "successful deletion",
  2587. categoryID: 1,
  2588. want: ``,
  2589. statusCode: http.StatusNoContent,
  2590. mockParams: mockParams{
  2591. directoryManagerParams: directoryManagerParams{
  2592. deleteKeywordParams: deleteKeywordParams{
  2593. {
  2594. id: 1,
  2595. },
  2596. },
  2597. },
  2598. },
  2599. },
  2600. {
  2601. name: "invalid keyword ID",
  2602. categoryID: -1,
  2603. want: `{"message":"invalid keyword ID"}`,
  2604. statusCode: http.StatusBadRequest,
  2605. mockParams: mockParams{
  2606. directoryManagerParams: directoryManagerParams{
  2607. deleteKeywordParams: deleteKeywordParams{},
  2608. },
  2609. },
  2610. },
  2611. }
  2612. for _, tc := range tt {
  2613. t.Run(tc.name, func(t *testing.T) {
  2614. request := httptest.NewRequest(http.MethodDelete, fmt.Sprintf("/directory/keyword/%d", tc.categoryID), nil)
  2615. request.SetPathValue("id", fmt.Sprintf("%d", tc.categoryID))
  2616. responseRecorder := httptest.NewRecorder()
  2617. directoryManager := newMockDirectoryManager(t)
  2618. for _, params := range tc.mockParams.deleteKeywordParams {
  2619. directoryManager.EXPECT().
  2620. DeleteKeyword(matchContext(), params.id).
  2621. Return(params.err)
  2622. }
  2623. deleteDirectoryKeywordHandler(responseRecorder, request, directoryManager, slog.Default())
  2624. if responseRecorder.Code != tc.statusCode {
  2625. t.Errorf("Want status '%d', got '%d'", tc.statusCode, responseRecorder.Code)
  2626. }
  2627. if strings.TrimSpace(responseRecorder.Body.String()) != tc.want {
  2628. t.Errorf("Want '%s', got '%s'", tc.want, responseRecorder.Body)
  2629. }
  2630. })
  2631. }
  2632. }
  2633. func TestBARTByTypeHandler_GET(t *testing.T) {
  2634. tt := []struct {
  2635. name string
  2636. queryParams string
  2637. wantStatusCode int
  2638. wantResponse string
  2639. mockParams mockParams
  2640. }{
  2641. {
  2642. name: "success with items",
  2643. queryParams: "?type=1",
  2644. wantStatusCode: http.StatusOK,
  2645. wantResponse: `[{"hash":"2B000001E4","type":1},{"hash":"2B000001B7","type":1}]`,
  2646. mockParams: mockParams{
  2647. bartAssetManagerParams: bartAssetManagerParams{
  2648. listBARTItemsParams: listBARTItemsParams{
  2649. {
  2650. itemType: 1,
  2651. result: []state.BARTItem{
  2652. {Hash: "2B000001E4", Type: 1},
  2653. {Hash: "2B000001B7", Type: 1},
  2654. },
  2655. err: nil,
  2656. },
  2657. },
  2658. },
  2659. },
  2660. },
  2661. {
  2662. name: "success with empty list",
  2663. queryParams: "?type=2",
  2664. wantStatusCode: http.StatusOK,
  2665. wantResponse: `[]`,
  2666. mockParams: mockParams{
  2667. bartAssetManagerParams: bartAssetManagerParams{
  2668. listBARTItemsParams: listBARTItemsParams{
  2669. {
  2670. itemType: 2,
  2671. result: []state.BARTItem{},
  2672. err: nil,
  2673. },
  2674. },
  2675. },
  2676. },
  2677. },
  2678. {
  2679. name: "missing type parameter",
  2680. queryParams: "",
  2681. wantStatusCode: http.StatusBadRequest,
  2682. wantResponse: `{"message":"type query parameter is required"}`,
  2683. },
  2684. {
  2685. name: "invalid type parameter",
  2686. queryParams: "?type=invalid",
  2687. wantStatusCode: http.StatusBadRequest,
  2688. wantResponse: `{"message":"invalid type ID"}`,
  2689. },
  2690. {
  2691. name: "internal server error",
  2692. queryParams: "?type=1",
  2693. wantStatusCode: http.StatusInternalServerError,
  2694. wantResponse: `{"message":"internal server error"}`,
  2695. mockParams: mockParams{
  2696. bartAssetManagerParams: bartAssetManagerParams{
  2697. listBARTItemsParams: listBARTItemsParams{
  2698. {
  2699. itemType: 1,
  2700. result: nil,
  2701. err: errors.New("database error"),
  2702. },
  2703. },
  2704. },
  2705. },
  2706. },
  2707. }
  2708. for _, tc := range tt {
  2709. t.Run(tc.name, func(t *testing.T) {
  2710. request := httptest.NewRequest(http.MethodGet, "/bart"+tc.queryParams, nil)
  2711. responseRecorder := httptest.NewRecorder()
  2712. mockBARTManager := newMockBARTAssetManager(t)
  2713. for _, params := range tc.mockParams.listBARTItemsParams {
  2714. mockBARTManager.EXPECT().
  2715. ListBARTItems(matchContext(), params.itemType).
  2716. Return(params.result, params.err)
  2717. }
  2718. getBARTByTypeHandler(responseRecorder, request, mockBARTManager, slog.Default())
  2719. assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
  2720. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  2721. })
  2722. }
  2723. }
  2724. func TestBARTHandler_GET(t *testing.T) {
  2725. tt := []struct {
  2726. name string
  2727. hash string
  2728. wantStatusCode int
  2729. wantResponse string
  2730. wantHeaders map[string]string
  2731. mockParams mockParams
  2732. }{
  2733. {
  2734. name: "success with valid hash",
  2735. hash: "2B000001E4",
  2736. wantStatusCode: http.StatusOK,
  2737. wantResponse: "binary data",
  2738. wantHeaders: map[string]string{"Content-Type": "application/octet-stream"},
  2739. mockParams: mockParams{
  2740. bartAssetManagerParams: bartAssetManagerParams{
  2741. bartItemParams: bartItemParams{
  2742. {
  2743. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2744. result: []byte("binary data"),
  2745. err: nil,
  2746. },
  2747. },
  2748. },
  2749. },
  2750. },
  2751. {
  2752. name: "missing hash parameter",
  2753. hash: "",
  2754. wantStatusCode: http.StatusBadRequest,
  2755. wantResponse: `{"message":"hash is required"}`,
  2756. },
  2757. {
  2758. name: "invalid hash format",
  2759. hash: "invalid-hex",
  2760. wantStatusCode: http.StatusBadRequest,
  2761. wantResponse: `{"message":"invalid hash format"}`,
  2762. },
  2763. {
  2764. name: "asset not found",
  2765. hash: "2B000001E4",
  2766. wantStatusCode: http.StatusNotFound,
  2767. wantResponse: `{"message":"BART asset not found"}`,
  2768. mockParams: mockParams{
  2769. bartAssetManagerParams: bartAssetManagerParams{
  2770. bartItemParams: bartItemParams{
  2771. {
  2772. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2773. result: []byte{},
  2774. err: nil,
  2775. },
  2776. },
  2777. },
  2778. },
  2779. },
  2780. {
  2781. name: "internal server error",
  2782. hash: "2B000001E4",
  2783. wantStatusCode: http.StatusInternalServerError,
  2784. wantResponse: `{"message":"internal server error"}`,
  2785. mockParams: mockParams{
  2786. bartAssetManagerParams: bartAssetManagerParams{
  2787. bartItemParams: bartItemParams{
  2788. {
  2789. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2790. result: nil,
  2791. err: errors.New("database error"),
  2792. },
  2793. },
  2794. },
  2795. },
  2796. },
  2797. }
  2798. for _, tc := range tt {
  2799. t.Run(tc.name, func(t *testing.T) {
  2800. request := httptest.NewRequest(http.MethodGet, "/bart/"+tc.hash, nil)
  2801. // Set the path value manually for testing
  2802. if tc.hash != "" {
  2803. request.SetPathValue("hash", tc.hash)
  2804. }
  2805. responseRecorder := httptest.NewRecorder()
  2806. mockBARTManager := newMockBARTAssetManager(t)
  2807. for _, params := range tc.mockParams.bartItemParams {
  2808. mockBARTManager.EXPECT().
  2809. BARTItem(matchContext(), params.hash).
  2810. Return(params.result, params.err)
  2811. }
  2812. getBARTHandler(responseRecorder, request, mockBARTManager, slog.Default())
  2813. assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
  2814. if tc.wantHeaders != nil {
  2815. for key, value := range tc.wantHeaders {
  2816. assert.Equal(t, value, responseRecorder.Header().Get(key))
  2817. }
  2818. }
  2819. if tc.wantStatusCode == http.StatusOK {
  2820. assert.Equal(t, tc.wantResponse, responseRecorder.Body.String())
  2821. } else {
  2822. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  2823. }
  2824. })
  2825. }
  2826. }
  2827. func TestBARTHandler_POST(t *testing.T) {
  2828. tt := []struct {
  2829. name string
  2830. hash string
  2831. queryParams string
  2832. requestBody string
  2833. wantStatusCode int
  2834. wantResponse string
  2835. mockParams mockParams
  2836. }{
  2837. {
  2838. name: "success with valid data",
  2839. hash: "2B000001E4",
  2840. queryParams: "?type=1",
  2841. requestBody: "binary data",
  2842. wantStatusCode: http.StatusCreated,
  2843. wantResponse: `{"hash":"2b000001e4","type":1}`,
  2844. mockParams: mockParams{
  2845. bartAssetManagerParams: bartAssetManagerParams{
  2846. insertBARTItemParams: insertBARTItemParams{
  2847. {
  2848. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2849. blob: []byte("binary data"),
  2850. itemType: 1,
  2851. err: nil,
  2852. },
  2853. },
  2854. },
  2855. },
  2856. },
  2857. {
  2858. name: "missing hash parameter",
  2859. hash: "",
  2860. queryParams: "?type=1",
  2861. requestBody: "binary data",
  2862. wantStatusCode: http.StatusBadRequest,
  2863. wantResponse: `{"message":"hash path parameter is required"}`,
  2864. },
  2865. {
  2866. name: "invalid hash format",
  2867. hash: "invalid-hex",
  2868. queryParams: "?type=1",
  2869. requestBody: "binary data",
  2870. wantStatusCode: http.StatusBadRequest,
  2871. wantResponse: `{"message":"invalid hash format"}`,
  2872. },
  2873. {
  2874. name: "missing type parameter",
  2875. hash: "2B000001E4",
  2876. queryParams: "",
  2877. requestBody: "binary data",
  2878. wantStatusCode: http.StatusBadRequest,
  2879. wantResponse: `{"message":"type query parameter is required"}`,
  2880. },
  2881. {
  2882. name: "invalid type parameter",
  2883. hash: "2B000001E4",
  2884. queryParams: "?type=invalid",
  2885. requestBody: "binary data",
  2886. wantStatusCode: http.StatusBadRequest,
  2887. wantResponse: `{"message":"invalid type ID"}`,
  2888. },
  2889. {
  2890. name: "failed to read request body",
  2891. hash: "2B000001E4",
  2892. queryParams: "?type=1",
  2893. requestBody: "", // This will cause an error when reading
  2894. wantStatusCode: http.StatusBadRequest,
  2895. wantResponse: `{"message":"failed to read request body"}`,
  2896. },
  2897. {
  2898. name: "asset already exists",
  2899. hash: "2B000001E4",
  2900. queryParams: "?type=1",
  2901. requestBody: "binary data",
  2902. wantStatusCode: http.StatusConflict,
  2903. wantResponse: `{"message":"BART asset already exists"}`,
  2904. mockParams: mockParams{
  2905. bartAssetManagerParams: bartAssetManagerParams{
  2906. insertBARTItemParams: insertBARTItemParams{
  2907. {
  2908. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2909. blob: []byte("binary data"),
  2910. itemType: 1,
  2911. err: state.ErrBARTItemExists,
  2912. },
  2913. },
  2914. },
  2915. },
  2916. },
  2917. {
  2918. name: "internal server error",
  2919. hash: "2B000001E4",
  2920. queryParams: "?type=1",
  2921. requestBody: "binary data",
  2922. wantStatusCode: http.StatusInternalServerError,
  2923. wantResponse: `{"message":"internal server error"}`,
  2924. mockParams: mockParams{
  2925. bartAssetManagerParams: bartAssetManagerParams{
  2926. insertBARTItemParams: insertBARTItemParams{
  2927. {
  2928. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2929. blob: []byte("binary data"),
  2930. itemType: 1,
  2931. err: errors.New("database error"),
  2932. },
  2933. },
  2934. },
  2935. },
  2936. },
  2937. }
  2938. for _, tc := range tt {
  2939. t.Run(tc.name, func(t *testing.T) {
  2940. var requestBody io.Reader
  2941. if tc.requestBody != "" {
  2942. requestBody = strings.NewReader(tc.requestBody)
  2943. } else {
  2944. requestBody = &errorReader{}
  2945. }
  2946. request := httptest.NewRequest(http.MethodPost, "/bart/"+tc.hash+tc.queryParams, requestBody)
  2947. // Set the path value manually for testing
  2948. if tc.hash != "" {
  2949. request.SetPathValue("hash", tc.hash)
  2950. }
  2951. responseRecorder := httptest.NewRecorder()
  2952. mockBARTManager := newMockBARTAssetManager(t)
  2953. for _, params := range tc.mockParams.insertBARTItemParams {
  2954. mockBARTManager.EXPECT().
  2955. InsertBARTItem(matchContext(), params.hash, params.blob, params.itemType).
  2956. Return(params.err)
  2957. }
  2958. postBARTHandler(responseRecorder, request, mockBARTManager, slog.Default())
  2959. assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
  2960. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  2961. })
  2962. }
  2963. }
  2964. func TestBARTHandler_DELETE(t *testing.T) {
  2965. tt := []struct {
  2966. name string
  2967. hash string
  2968. wantStatusCode int
  2969. wantResponse string
  2970. mockParams mockParams
  2971. }{
  2972. {
  2973. name: "success with valid hash",
  2974. hash: "2B000001E4",
  2975. wantStatusCode: http.StatusOK,
  2976. wantResponse: `{"message":"BART asset deleted successfully."}`,
  2977. mockParams: mockParams{
  2978. bartAssetManagerParams: bartAssetManagerParams{
  2979. deleteBARTItemParams: deleteBARTItemParams{
  2980. {
  2981. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  2982. err: nil,
  2983. },
  2984. },
  2985. },
  2986. },
  2987. },
  2988. {
  2989. name: "missing hash parameter",
  2990. hash: "",
  2991. wantStatusCode: http.StatusBadRequest,
  2992. wantResponse: `{"message":"hash path parameter is required"}`,
  2993. },
  2994. {
  2995. name: "invalid hash format",
  2996. hash: "invalid-hex",
  2997. wantStatusCode: http.StatusBadRequest,
  2998. wantResponse: `{"message":"invalid hash format"}`,
  2999. },
  3000. {
  3001. name: "asset not found",
  3002. hash: "2B000001E4",
  3003. wantStatusCode: http.StatusNotFound,
  3004. wantResponse: `{"message":"BART asset not found"}`,
  3005. mockParams: mockParams{
  3006. bartAssetManagerParams: bartAssetManagerParams{
  3007. deleteBARTItemParams: deleteBARTItemParams{
  3008. {
  3009. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  3010. err: state.ErrBARTItemNotFound,
  3011. },
  3012. },
  3013. },
  3014. },
  3015. },
  3016. {
  3017. name: "internal server error",
  3018. hash: "2B000001E4",
  3019. wantStatusCode: http.StatusInternalServerError,
  3020. wantResponse: `{"message":"internal server error"}`,
  3021. mockParams: mockParams{
  3022. bartAssetManagerParams: bartAssetManagerParams{
  3023. deleteBARTItemParams: deleteBARTItemParams{
  3024. {
  3025. hash: []byte{0x2B, 0x00, 0x00, 0x01, 0xE4},
  3026. err: errors.New("database error"),
  3027. },
  3028. },
  3029. },
  3030. },
  3031. },
  3032. }
  3033. for _, tc := range tt {
  3034. t.Run(tc.name, func(t *testing.T) {
  3035. request := httptest.NewRequest(http.MethodDelete, "/bart/"+tc.hash, nil)
  3036. // Set the path value manually for testing
  3037. if tc.hash != "" {
  3038. request.SetPathValue("hash", tc.hash)
  3039. }
  3040. responseRecorder := httptest.NewRecorder()
  3041. mockBARTManager := newMockBARTAssetManager(t)
  3042. for _, params := range tc.mockParams.deleteBARTItemParams {
  3043. mockBARTManager.EXPECT().
  3044. DeleteBARTItem(matchContext(), params.hash).
  3045. Return(params.err)
  3046. }
  3047. deleteBARTHandler(responseRecorder, request, mockBARTManager, slog.Default())
  3048. assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
  3049. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  3050. })
  3051. }
  3052. }
  3053. // errorReader is a helper type that always returns an error when reading
  3054. type errorReader struct{}
  3055. func (er *errorReader) Read(p []byte) (n int, err error) {
  3056. return 0, errors.New("read error")
  3057. }
  3058. func TestFeedbagBuddyHandler_GET(t *testing.T) {
  3059. tt := []struct {
  3060. name string
  3061. screenName string
  3062. wantStatusCode int
  3063. wantResponse string
  3064. mockParams mockParams
  3065. }{
  3066. {
  3067. name: "empty feedbag",
  3068. screenName: "userA",
  3069. wantStatusCode: http.StatusNotFound,
  3070. wantResponse: `{"message":"feedbag not found"}`,
  3071. mockParams: mockParams{
  3072. feedbagManagerParams: feedbagManagerParams{
  3073. feedbagParams: feedbagParams{
  3074. {
  3075. screenName: state.NewIdentScreenName("userA"),
  3076. result: []wire.FeedbagItem{},
  3077. err: nil,
  3078. },
  3079. },
  3080. },
  3081. },
  3082. },
  3083. {
  3084. name: "feedbag with buddies in groups",
  3085. screenName: "userA",
  3086. wantStatusCode: http.StatusOK,
  3087. wantResponse: `[{"group_id":1,"group_name":"Friends","buddies":[{"name":"buddy1","item_id":10},{"name":"buddy2","item_id":11}]},{"group_id":2,"group_name":"Work","buddies":[{"name":"buddy3","item_id":20}]}]`,
  3088. mockParams: mockParams{
  3089. feedbagManagerParams: feedbagManagerParams{
  3090. feedbagParams: feedbagParams{
  3091. {
  3092. screenName: state.NewIdentScreenName("userA"),
  3093. result: []wire.FeedbagItem{
  3094. {
  3095. ItemID: 0,
  3096. ClassID: wire.FeedbagClassIdGroup,
  3097. Name: "",
  3098. GroupID: 0,
  3099. },
  3100. {
  3101. ItemID: 1,
  3102. ClassID: wire.FeedbagClassIdGroup,
  3103. Name: "Friends",
  3104. GroupID: 1,
  3105. TLVLBlock: wire.TLVLBlock{
  3106. TLVList: wire.TLVList{
  3107. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{10, 11}),
  3108. },
  3109. },
  3110. },
  3111. {
  3112. ItemID: 2,
  3113. ClassID: wire.FeedbagClassIdGroup,
  3114. Name: "Work",
  3115. GroupID: 2,
  3116. TLVLBlock: wire.TLVLBlock{
  3117. TLVList: wire.TLVList{
  3118. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{20}),
  3119. },
  3120. },
  3121. },
  3122. {
  3123. ItemID: 10,
  3124. ClassID: wire.FeedbagClassIdBuddy,
  3125. Name: "buddy1",
  3126. GroupID: 1,
  3127. },
  3128. {
  3129. ItemID: 11,
  3130. ClassID: wire.FeedbagClassIdBuddy,
  3131. Name: "buddy2",
  3132. GroupID: 1,
  3133. },
  3134. {
  3135. ItemID: 20,
  3136. ClassID: wire.FeedbagClassIdBuddy,
  3137. Name: "buddy3",
  3138. GroupID: 2,
  3139. },
  3140. },
  3141. err: nil,
  3142. },
  3143. },
  3144. },
  3145. },
  3146. },
  3147. {
  3148. name: "feedbag with no groups (besides root)",
  3149. screenName: "userA",
  3150. wantStatusCode: http.StatusOK,
  3151. wantResponse: `[]`,
  3152. mockParams: mockParams{
  3153. feedbagManagerParams: feedbagManagerParams{
  3154. feedbagParams: feedbagParams{
  3155. {
  3156. screenName: state.NewIdentScreenName("userA"),
  3157. result: []wire.FeedbagItem{
  3158. {
  3159. ItemID: 0,
  3160. ClassID: wire.FeedbagClassIdGroup,
  3161. Name: "",
  3162. GroupID: 0,
  3163. },
  3164. },
  3165. err: nil,
  3166. },
  3167. },
  3168. },
  3169. },
  3170. // Note: Root groups (GroupID == 0) are skipped by the implementation,
  3171. // so the response will be an empty array []
  3172. },
  3173. {
  3174. name: "missing screen_name",
  3175. screenName: "",
  3176. wantStatusCode: http.StatusBadRequest,
  3177. wantResponse: `{"message":"screen_name is required"}`,
  3178. },
  3179. {
  3180. name: "internal server error",
  3181. screenName: "userA",
  3182. wantStatusCode: http.StatusInternalServerError,
  3183. wantResponse: `{"message":"internal server error"}`,
  3184. mockParams: mockParams{
  3185. feedbagManagerParams: feedbagManagerParams{
  3186. feedbagParams: feedbagParams{
  3187. {
  3188. screenName: state.NewIdentScreenName("userA"),
  3189. result: nil,
  3190. err: errors.New("database error"),
  3191. },
  3192. },
  3193. },
  3194. },
  3195. },
  3196. }
  3197. for _, tc := range tt {
  3198. t.Run(tc.name, func(t *testing.T) {
  3199. request := httptest.NewRequest(http.MethodGet, "/feedbag/"+tc.screenName+"/group", nil)
  3200. if tc.screenName != "" {
  3201. request.SetPathValue("screen_name", tc.screenName)
  3202. }
  3203. responseRecorder := httptest.NewRecorder()
  3204. feedbagManager := newMockFeedbagManager(t)
  3205. for _, params := range tc.mockParams.feedbagParams {
  3206. feedbagManager.EXPECT().
  3207. Feedbag(matchContext(), params.screenName).
  3208. Return(params.result, params.err)
  3209. }
  3210. getFeedbagBuddyHandler(responseRecorder, request, feedbagManager, slog.Default())
  3211. assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
  3212. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  3213. })
  3214. }
  3215. }
  3216. func TestFeedbagGroupHandler_PUT(t *testing.T) {
  3217. tt := []struct {
  3218. name string
  3219. screenName string
  3220. groupName string
  3221. groupIDGen func(n int) int
  3222. wantStatusCode int
  3223. wantResponse string
  3224. mockParams mockParams
  3225. }{
  3226. {
  3227. name: "add group to empty feedbag",
  3228. screenName: "userA",
  3229. groupName: "Friends",
  3230. groupIDGen: func(n int) int { return 5 },
  3231. wantStatusCode: http.StatusCreated,
  3232. wantResponse: `{"group_id":5,"group_name":"Friends"}`,
  3233. mockParams: mockParams{
  3234. userManagerParams: userManagerParams{
  3235. getUserParams: getUserParams{
  3236. {
  3237. screenName: state.NewIdentScreenName("userA"),
  3238. result: &state.User{IdentScreenName: state.NewIdentScreenName("userA")},
  3239. },
  3240. },
  3241. },
  3242. feedbagManagerParams: feedbagManagerParams{
  3243. feedbagParams: feedbagParams{
  3244. {
  3245. screenName: state.NewIdentScreenName("userA"),
  3246. result: []wire.FeedbagItem{},
  3247. err: nil,
  3248. },
  3249. },
  3250. feedbagUpsertParams: feedbagUpsertParams{
  3251. {
  3252. screenName: state.NewIdentScreenName("userA"),
  3253. items: []wire.FeedbagItem{
  3254. {
  3255. ClassID: wire.FeedbagClassIdGroup,
  3256. GroupID: 0,
  3257. TLVLBlock: wire.TLVLBlock{
  3258. TLVList: wire.TLVList{
  3259. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{5}),
  3260. },
  3261. },
  3262. },
  3263. {
  3264. ClassID: wire.FeedbagClassIdGroup,
  3265. Name: "Friends",
  3266. GroupID: 5,
  3267. },
  3268. },
  3269. err: nil,
  3270. },
  3271. },
  3272. },
  3273. messageRelayerParams: messageRelayerParams{
  3274. relayToScreenNameParams: relayToScreenNameParams{
  3275. {
  3276. screenName: state.NewIdentScreenName("userA"),
  3277. msg: wire.SNACMessage{
  3278. Frame: wire.SNACFrame{
  3279. FoodGroup: wire.Feedbag,
  3280. SubGroup: wire.FeedbagInsertItem,
  3281. RequestID: wire.ReqIDFromServer,
  3282. },
  3283. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  3284. Items: []wire.FeedbagItem{
  3285. {
  3286. ClassID: wire.FeedbagClassIdGroup,
  3287. GroupID: 0,
  3288. TLVLBlock: wire.TLVLBlock{
  3289. TLVList: wire.TLVList{
  3290. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{5}),
  3291. },
  3292. },
  3293. },
  3294. {
  3295. ClassID: wire.FeedbagClassIdGroup,
  3296. Name: "Friends",
  3297. GroupID: 5,
  3298. },
  3299. },
  3300. },
  3301. },
  3302. },
  3303. },
  3304. },
  3305. },
  3306. },
  3307. {
  3308. name: "add group to feedbag with existing root",
  3309. screenName: "userA",
  3310. groupName: "Coworkers",
  3311. groupIDGen: func(n int) int { return 2 },
  3312. wantStatusCode: http.StatusCreated,
  3313. wantResponse: `{"group_id":2,"group_name":"Coworkers"}`,
  3314. mockParams: mockParams{
  3315. userManagerParams: userManagerParams{
  3316. getUserParams: getUserParams{
  3317. {
  3318. screenName: state.NewIdentScreenName("userA"),
  3319. result: &state.User{IdentScreenName: state.NewIdentScreenName("userA")},
  3320. },
  3321. },
  3322. },
  3323. feedbagManagerParams: feedbagManagerParams{
  3324. feedbagParams: feedbagParams{
  3325. {
  3326. screenName: state.NewIdentScreenName("userA"),
  3327. result: []wire.FeedbagItem{
  3328. {
  3329. ClassID: wire.FeedbagClassIdGroup,
  3330. GroupID: 0,
  3331. TLVLBlock: wire.TLVLBlock{
  3332. TLVList: wire.TLVList{
  3333. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1}),
  3334. },
  3335. },
  3336. },
  3337. {
  3338. ClassID: wire.FeedbagClassIdGroup,
  3339. Name: "Buddies",
  3340. GroupID: 1,
  3341. },
  3342. },
  3343. err: nil,
  3344. },
  3345. },
  3346. feedbagUpsertParams: feedbagUpsertParams{
  3347. {
  3348. screenName: state.NewIdentScreenName("userA"),
  3349. items: []wire.FeedbagItem{
  3350. {
  3351. ClassID: wire.FeedbagClassIdGroup,
  3352. GroupID: 0,
  3353. TLVLBlock: wire.TLVLBlock{
  3354. TLVList: wire.TLVList{
  3355. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1, 2}),
  3356. },
  3357. },
  3358. },
  3359. {
  3360. ClassID: wire.FeedbagClassIdGroup,
  3361. Name: "Coworkers",
  3362. GroupID: 2,
  3363. },
  3364. },
  3365. err: nil,
  3366. },
  3367. },
  3368. },
  3369. messageRelayerParams: messageRelayerParams{
  3370. relayToScreenNameParams: relayToScreenNameParams{
  3371. {
  3372. screenName: state.NewIdentScreenName("userA"),
  3373. msg: wire.SNACMessage{
  3374. Frame: wire.SNACFrame{
  3375. FoodGroup: wire.Feedbag,
  3376. SubGroup: wire.FeedbagInsertItem,
  3377. RequestID: wire.ReqIDFromServer,
  3378. },
  3379. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  3380. Items: []wire.FeedbagItem{
  3381. {
  3382. ClassID: wire.FeedbagClassIdGroup,
  3383. GroupID: 0,
  3384. TLVLBlock: wire.TLVLBlock{
  3385. TLVList: wire.TLVList{
  3386. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1, 2}),
  3387. },
  3388. },
  3389. },
  3390. {
  3391. ClassID: wire.FeedbagClassIdGroup,
  3392. Name: "Coworkers",
  3393. GroupID: 2,
  3394. },
  3395. },
  3396. },
  3397. },
  3398. },
  3399. },
  3400. },
  3401. },
  3402. },
  3403. {
  3404. name: "group already exists",
  3405. screenName: "userA",
  3406. groupName: "Friends",
  3407. groupIDGen: func(n int) int { return 99 },
  3408. wantStatusCode: http.StatusOK,
  3409. wantResponse: `{"group_id":1,"group_name":"Friends"}`,
  3410. mockParams: mockParams{
  3411. userManagerParams: userManagerParams{
  3412. getUserParams: getUserParams{
  3413. {
  3414. screenName: state.NewIdentScreenName("userA"),
  3415. result: &state.User{IdentScreenName: state.NewIdentScreenName("userA")},
  3416. },
  3417. },
  3418. },
  3419. feedbagManagerParams: feedbagManagerParams{
  3420. feedbagParams: feedbagParams{
  3421. {
  3422. screenName: state.NewIdentScreenName("userA"),
  3423. result: []wire.FeedbagItem{
  3424. {
  3425. ClassID: wire.FeedbagClassIdGroup,
  3426. GroupID: 0,
  3427. },
  3428. {
  3429. ClassID: wire.FeedbagClassIdGroup,
  3430. Name: "Friends",
  3431. GroupID: 1,
  3432. },
  3433. },
  3434. err: nil,
  3435. },
  3436. },
  3437. },
  3438. },
  3439. },
  3440. {
  3441. name: "missing screen_name",
  3442. screenName: "",
  3443. groupName: "Friends",
  3444. groupIDGen: func(n int) int { return 5 },
  3445. wantStatusCode: http.StatusBadRequest,
  3446. wantResponse: `{"message":"screen_name is required"}`,
  3447. },
  3448. {
  3449. name: "missing group_name",
  3450. screenName: "userA",
  3451. groupName: "",
  3452. groupIDGen: func(n int) int { return 5 },
  3453. wantStatusCode: http.StatusBadRequest,
  3454. wantResponse: `{"message":"group_name is required"}`,
  3455. },
  3456. {
  3457. name: "user not found",
  3458. screenName: "userA",
  3459. groupName: "Friends",
  3460. groupIDGen: func(n int) int { return 5 },
  3461. wantStatusCode: http.StatusNotFound,
  3462. wantResponse: `{"message":"user not found"}`,
  3463. mockParams: mockParams{
  3464. userManagerParams: userManagerParams{
  3465. getUserParams: getUserParams{
  3466. {
  3467. screenName: state.NewIdentScreenName("userA"),
  3468. result: nil,
  3469. },
  3470. },
  3471. },
  3472. },
  3473. },
  3474. {
  3475. name: "error retrieving user",
  3476. screenName: "userA",
  3477. groupName: "Friends",
  3478. groupIDGen: func(n int) int { return 5 },
  3479. wantStatusCode: http.StatusInternalServerError,
  3480. wantResponse: `{"message":"internal server error"}`,
  3481. mockParams: mockParams{
  3482. userManagerParams: userManagerParams{
  3483. getUserParams: getUserParams{
  3484. {
  3485. screenName: state.NewIdentScreenName("userA"),
  3486. err: errors.New("database error"),
  3487. },
  3488. },
  3489. },
  3490. },
  3491. },
  3492. {
  3493. name: "error retrieving feedbag",
  3494. screenName: "userA",
  3495. groupName: "Friends",
  3496. groupIDGen: func(n int) int { return 5 },
  3497. wantStatusCode: http.StatusInternalServerError,
  3498. wantResponse: `{"message":"internal server error"}`,
  3499. mockParams: mockParams{
  3500. userManagerParams: userManagerParams{
  3501. getUserParams: getUserParams{
  3502. {
  3503. screenName: state.NewIdentScreenName("userA"),
  3504. result: &state.User{IdentScreenName: state.NewIdentScreenName("userA")},
  3505. },
  3506. },
  3507. },
  3508. feedbagManagerParams: feedbagManagerParams{
  3509. feedbagParams: feedbagParams{
  3510. {
  3511. screenName: state.NewIdentScreenName("userA"),
  3512. result: nil,
  3513. err: errors.New("database error"),
  3514. },
  3515. },
  3516. },
  3517. },
  3518. },
  3519. {
  3520. name: "error upserting feedbag",
  3521. screenName: "userA",
  3522. groupName: "Friends",
  3523. groupIDGen: func(n int) int { return 5 },
  3524. wantStatusCode: http.StatusInternalServerError,
  3525. wantResponse: `{"message":"internal server error"}`,
  3526. mockParams: mockParams{
  3527. userManagerParams: userManagerParams{
  3528. getUserParams: getUserParams{
  3529. {
  3530. screenName: state.NewIdentScreenName("userA"),
  3531. result: &state.User{IdentScreenName: state.NewIdentScreenName("userA")},
  3532. },
  3533. },
  3534. },
  3535. feedbagManagerParams: feedbagManagerParams{
  3536. feedbagParams: feedbagParams{
  3537. {
  3538. screenName: state.NewIdentScreenName("userA"),
  3539. result: []wire.FeedbagItem{},
  3540. err: nil,
  3541. },
  3542. },
  3543. feedbagUpsertParams: feedbagUpsertParams{
  3544. {
  3545. screenName: state.NewIdentScreenName("userA"),
  3546. items: []wire.FeedbagItem{
  3547. {
  3548. ClassID: wire.FeedbagClassIdGroup,
  3549. GroupID: 0,
  3550. TLVLBlock: wire.TLVLBlock{
  3551. TLVList: wire.TLVList{
  3552. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{5}),
  3553. },
  3554. },
  3555. },
  3556. {
  3557. ClassID: wire.FeedbagClassIdGroup,
  3558. Name: "Friends",
  3559. GroupID: 5,
  3560. },
  3561. },
  3562. err: errors.New("database error"),
  3563. },
  3564. },
  3565. },
  3566. },
  3567. },
  3568. }
  3569. for _, tc := range tt {
  3570. t.Run(tc.name, func(t *testing.T) {
  3571. request := httptest.NewRequest(http.MethodPut, "/feedbag/"+tc.screenName+"/group/"+tc.groupName, nil)
  3572. if tc.screenName != "" {
  3573. request.SetPathValue("screen_name", tc.screenName)
  3574. }
  3575. if tc.groupName != "" {
  3576. request.SetPathValue("group_name", tc.groupName)
  3577. }
  3578. responseRecorder := httptest.NewRecorder()
  3579. userManager := newMockUserManager(t)
  3580. for _, params := range tc.mockParams.getUserParams {
  3581. userManager.EXPECT().
  3582. User(matchContext(), params.screenName).
  3583. Return(params.result, params.err)
  3584. }
  3585. feedbagManager := newMockFeedbagManager(t)
  3586. messageRelayer := newMockMessageRelayer(t)
  3587. for _, params := range tc.mockParams.feedbagParams {
  3588. feedbagManager.EXPECT().
  3589. Feedbag(matchContext(), params.screenName).
  3590. Return(params.result, params.err)
  3591. }
  3592. for _, params := range tc.mockParams.feedbagUpsertParams {
  3593. feedbagManager.EXPECT().
  3594. FeedbagUpsert(matchContext(), params.screenName, params.items).
  3595. Return(params.err)
  3596. }
  3597. for _, params := range tc.mockParams.relayToScreenNameParams {
  3598. messageRelayer.EXPECT().
  3599. RelayToScreenName(matchContext(), params.screenName, params.msg)
  3600. }
  3601. putFeedbagGroupHandler(responseRecorder, request, userManager, feedbagManager, messageRelayer, slog.Default(), tc.groupIDGen)
  3602. assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
  3603. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  3604. })
  3605. }
  3606. }
  3607. func TestFeedbagBuddyHandler_PUT(t *testing.T) {
  3608. tt := []struct {
  3609. name string
  3610. screenName string
  3611. groupID string
  3612. requestBody string
  3613. wantStatusCode int
  3614. wantResponse string
  3615. mockParams mockParams
  3616. }{
  3617. {
  3618. name: "add a buddy to an empty group, user not signed in",
  3619. screenName: "userA",
  3620. groupID: "1",
  3621. requestBody: `{"name":"newbuddy"}`,
  3622. wantStatusCode: http.StatusOK,
  3623. wantResponse: `{"name":"newbuddy","group_id":1,"item_id":1000}`,
  3624. mockParams: mockParams{
  3625. feedbagManagerParams: feedbagManagerParams{
  3626. feedbagParams: feedbagParams{
  3627. {
  3628. screenName: state.NewIdentScreenName("userA"),
  3629. result: []wire.FeedbagItem{
  3630. {
  3631. ClassID: wire.FeedbagClassIdGroup,
  3632. Name: "Friends",
  3633. GroupID: 1,
  3634. },
  3635. },
  3636. err: nil,
  3637. },
  3638. },
  3639. feedbagUpsertParams: feedbagUpsertParams{
  3640. {
  3641. screenName: state.NewIdentScreenName("userA"),
  3642. items: []wire.FeedbagItem{
  3643. {
  3644. Name: "newbuddy",
  3645. GroupID: 1,
  3646. ItemID: 1000,
  3647. ClassID: wire.FeedbagClassIdBuddy,
  3648. },
  3649. {
  3650. ClassID: wire.FeedbagClassIdGroup,
  3651. Name: "Friends",
  3652. GroupID: 1,
  3653. TLVLBlock: wire.TLVLBlock{
  3654. TLVList: wire.TLVList{
  3655. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1000}),
  3656. },
  3657. },
  3658. },
  3659. },
  3660. err: nil,
  3661. },
  3662. },
  3663. },
  3664. sessionRetrieverParams: sessionRetrieverParams{
  3665. retrieveSessionByNameParams: retrieveSessionByNameParams{
  3666. {
  3667. screenName: state.NewIdentScreenName("userA"),
  3668. result: state.NewSession(),
  3669. },
  3670. },
  3671. },
  3672. messageRelayerParams: messageRelayerParams{
  3673. relayToScreenNameParams: relayToScreenNameParams{
  3674. {
  3675. screenName: state.NewIdentScreenName("userA"),
  3676. msg: wire.SNACMessage{
  3677. Frame: wire.SNACFrame{
  3678. FoodGroup: wire.Feedbag,
  3679. SubGroup: wire.FeedbagInsertItem,
  3680. RequestID: wire.ReqIDFromServer,
  3681. },
  3682. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  3683. Items: []wire.FeedbagItem{
  3684. {
  3685. Name: "newbuddy",
  3686. GroupID: 1,
  3687. ItemID: 1000,
  3688. ClassID: wire.FeedbagClassIdBuddy,
  3689. },
  3690. },
  3691. },
  3692. },
  3693. },
  3694. {
  3695. screenName: state.NewIdentScreenName("userA"),
  3696. msg: wire.SNACMessage{
  3697. Frame: wire.SNACFrame{
  3698. FoodGroup: wire.Feedbag,
  3699. SubGroup: wire.FeedbagUpdateItem,
  3700. RequestID: wire.ReqIDFromServer,
  3701. },
  3702. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  3703. Items: []wire.FeedbagItem{
  3704. {
  3705. ClassID: wire.FeedbagClassIdGroup,
  3706. Name: "Friends",
  3707. GroupID: 1,
  3708. TLVLBlock: wire.TLVLBlock{
  3709. TLVList: wire.TLVList{
  3710. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1000}),
  3711. },
  3712. },
  3713. },
  3714. },
  3715. },
  3716. },
  3717. },
  3718. },
  3719. },
  3720. },
  3721. },
  3722. {
  3723. name: "add a buddy to a non-empty group, user not signed in",
  3724. screenName: "userA",
  3725. groupID: "1",
  3726. requestBody: `{"name":"newbuddy2"}`,
  3727. wantStatusCode: http.StatusOK,
  3728. wantResponse: `{"name":"newbuddy2","group_id":1,"item_id":1000}`,
  3729. mockParams: mockParams{
  3730. feedbagManagerParams: feedbagManagerParams{
  3731. feedbagParams: feedbagParams{
  3732. {
  3733. screenName: state.NewIdentScreenName("userA"),
  3734. result: []wire.FeedbagItem{
  3735. {
  3736. ClassID: wire.FeedbagClassIdGroup,
  3737. Name: "Friends",
  3738. GroupID: 1,
  3739. TLVLBlock: wire.TLVLBlock{
  3740. TLVList: wire.TLVList{
  3741. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{12345}),
  3742. },
  3743. },
  3744. },
  3745. {
  3746. ItemID: 12345,
  3747. ClassID: wire.FeedbagClassIdBuddy,
  3748. Name: "existingbuddy",
  3749. GroupID: 1,
  3750. },
  3751. },
  3752. err: nil,
  3753. },
  3754. },
  3755. feedbagUpsertParams: feedbagUpsertParams{
  3756. {
  3757. screenName: state.NewIdentScreenName("userA"),
  3758. items: []wire.FeedbagItem{
  3759. {
  3760. Name: "newbuddy2",
  3761. GroupID: 1,
  3762. ItemID: 1000,
  3763. ClassID: wire.FeedbagClassIdBuddy,
  3764. },
  3765. {
  3766. ClassID: wire.FeedbagClassIdGroup,
  3767. Name: "Friends",
  3768. GroupID: 1,
  3769. TLVLBlock: wire.TLVLBlock{
  3770. TLVList: wire.TLVList{
  3771. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{12345, 1000}),
  3772. },
  3773. },
  3774. },
  3775. },
  3776. err: nil,
  3777. },
  3778. },
  3779. },
  3780. sessionRetrieverParams: sessionRetrieverParams{
  3781. retrieveSessionByNameParams: retrieveSessionByNameParams{
  3782. {
  3783. screenName: state.NewIdentScreenName("userA"),
  3784. result: state.NewSession(),
  3785. },
  3786. },
  3787. },
  3788. messageRelayerParams: messageRelayerParams{
  3789. relayToScreenNameParams: relayToScreenNameParams{
  3790. {
  3791. screenName: state.NewIdentScreenName("userA"),
  3792. msg: wire.SNACMessage{
  3793. Frame: wire.SNACFrame{
  3794. FoodGroup: wire.Feedbag,
  3795. SubGroup: wire.FeedbagInsertItem,
  3796. RequestID: wire.ReqIDFromServer,
  3797. },
  3798. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  3799. Items: []wire.FeedbagItem{
  3800. {
  3801. Name: "newbuddy2",
  3802. GroupID: 1,
  3803. ItemID: 1000,
  3804. ClassID: wire.FeedbagClassIdBuddy,
  3805. },
  3806. },
  3807. },
  3808. },
  3809. },
  3810. {
  3811. screenName: state.NewIdentScreenName("userA"),
  3812. msg: wire.SNACMessage{
  3813. Frame: wire.SNACFrame{
  3814. FoodGroup: wire.Feedbag,
  3815. SubGroup: wire.FeedbagUpdateItem,
  3816. RequestID: wire.ReqIDFromServer,
  3817. },
  3818. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  3819. Items: []wire.FeedbagItem{
  3820. {
  3821. ClassID: wire.FeedbagClassIdGroup,
  3822. Name: "Friends",
  3823. GroupID: 1,
  3824. TLVLBlock: wire.TLVLBlock{
  3825. TLVList: wire.TLVList{
  3826. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{12345, 1000}),
  3827. },
  3828. },
  3829. },
  3830. },
  3831. },
  3832. },
  3833. },
  3834. },
  3835. },
  3836. },
  3837. },
  3838. {
  3839. name: "add a buddy that already exists in a group",
  3840. screenName: "userA",
  3841. groupID: "1",
  3842. requestBody: `{"name":"ExistingBuddy"}`,
  3843. wantStatusCode: http.StatusOK,
  3844. wantResponse: `{"name":"ExistingBuddy","group_id":1,"item_id":12345}`,
  3845. mockParams: mockParams{
  3846. feedbagManagerParams: feedbagManagerParams{
  3847. feedbagParams: feedbagParams{
  3848. {
  3849. screenName: state.NewIdentScreenName("userA"),
  3850. result: []wire.FeedbagItem{
  3851. {
  3852. ClassID: wire.FeedbagClassIdGroup,
  3853. Name: "Friends",
  3854. GroupID: 1,
  3855. TLVLBlock: wire.TLVLBlock{
  3856. TLVList: wire.TLVList{
  3857. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{12345}),
  3858. },
  3859. },
  3860. },
  3861. {
  3862. ItemID: 12345,
  3863. ClassID: wire.FeedbagClassIdBuddy,
  3864. Name: "existingbuddy",
  3865. GroupID: 1,
  3866. },
  3867. },
  3868. err: nil,
  3869. },
  3870. },
  3871. // No FeedbagUpsert should be called when buddy already exists
  3872. },
  3873. // No session retrieval or message relaying should occur
  3874. },
  3875. },
  3876. {
  3877. name: "add a buddy to an empty group, user signed in",
  3878. screenName: "userA",
  3879. groupID: "1",
  3880. requestBody: `{"name":"newbuddy"}`,
  3881. wantStatusCode: http.StatusOK,
  3882. wantResponse: `{"name":"newbuddy","group_id":1,"item_id":1000}`,
  3883. mockParams: mockParams{
  3884. feedbagManagerParams: feedbagManagerParams{
  3885. feedbagParams: feedbagParams{
  3886. {
  3887. screenName: state.NewIdentScreenName("userA"),
  3888. result: []wire.FeedbagItem{
  3889. {
  3890. ClassID: wire.FeedbagClassIdGroup,
  3891. Name: "Friends",
  3892. GroupID: 1,
  3893. },
  3894. },
  3895. err: nil,
  3896. },
  3897. },
  3898. feedbagUpsertParams: feedbagUpsertParams{
  3899. {
  3900. screenName: state.NewIdentScreenName("userA"),
  3901. items: []wire.FeedbagItem{
  3902. {
  3903. Name: "newbuddy",
  3904. GroupID: 1,
  3905. ItemID: 1000,
  3906. ClassID: wire.FeedbagClassIdBuddy,
  3907. },
  3908. {
  3909. ClassID: wire.FeedbagClassIdGroup,
  3910. Name: "Friends",
  3911. GroupID: 1,
  3912. TLVLBlock: wire.TLVLBlock{
  3913. TLVList: wire.TLVList{
  3914. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1000}),
  3915. },
  3916. },
  3917. },
  3918. },
  3919. err: nil,
  3920. },
  3921. },
  3922. },
  3923. sessionRetrieverParams: sessionRetrieverParams{
  3924. retrieveSessionByNameParams: retrieveSessionByNameParams{
  3925. {
  3926. screenName: state.NewIdentScreenName("userA"),
  3927. result: func() *state.Session {
  3928. sess := state.NewSession()
  3929. sess.SetIdentScreenName(state.NewIdentScreenName("userA"))
  3930. inst := sess.AddInstance()
  3931. inst.SetSignonComplete()
  3932. return sess
  3933. }(),
  3934. },
  3935. },
  3936. },
  3937. messageRelayerParams: messageRelayerParams{
  3938. relayToScreenNameParams: relayToScreenNameParams{
  3939. {
  3940. screenName: state.NewIdentScreenName("userA"),
  3941. msg: wire.SNACMessage{
  3942. Frame: wire.SNACFrame{
  3943. FoodGroup: wire.Feedbag,
  3944. SubGroup: wire.FeedbagInsertItem,
  3945. RequestID: wire.ReqIDFromServer,
  3946. },
  3947. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  3948. Items: []wire.FeedbagItem{
  3949. {
  3950. Name: "newbuddy",
  3951. GroupID: 1,
  3952. ItemID: 1000,
  3953. ClassID: wire.FeedbagClassIdBuddy,
  3954. },
  3955. },
  3956. },
  3957. },
  3958. },
  3959. {
  3960. screenName: state.NewIdentScreenName("userA"),
  3961. msg: wire.SNACMessage{
  3962. Frame: wire.SNACFrame{
  3963. FoodGroup: wire.Feedbag,
  3964. SubGroup: wire.FeedbagUpdateItem,
  3965. RequestID: wire.ReqIDFromServer,
  3966. },
  3967. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  3968. Items: []wire.FeedbagItem{
  3969. {
  3970. ClassID: wire.FeedbagClassIdGroup,
  3971. Name: "Friends",
  3972. GroupID: 1,
  3973. TLVLBlock: wire.TLVLBlock{
  3974. TLVList: wire.TLVList{
  3975. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1000}),
  3976. },
  3977. },
  3978. },
  3979. },
  3980. },
  3981. },
  3982. },
  3983. },
  3984. },
  3985. buddyBroadcasterParams: buddyBroadcasterParams{
  3986. broadcastVisibilityParams: broadcastVisibilityParams{
  3987. {
  3988. you: nil, // Not used in expectation, matched with mock.AnythingOfType
  3989. filter: []state.IdentScreenName{state.NewIdentScreenName("newbuddy")},
  3990. sendDepartures: false,
  3991. err: nil,
  3992. },
  3993. },
  3994. },
  3995. },
  3996. },
  3997. {
  3998. name: "invalid group_id - non-numeric",
  3999. screenName: "userA",
  4000. groupID: "invalid",
  4001. requestBody: `{"name":"buddy"}`,
  4002. wantStatusCode: http.StatusBadRequest,
  4003. wantResponse: `{"message":"invalid group_id"}`,
  4004. },
  4005. {
  4006. name: "invalid group_id - out of range",
  4007. screenName: "userA",
  4008. groupID: "99999",
  4009. requestBody: `{"name":"buddy"}`,
  4010. wantStatusCode: http.StatusBadRequest,
  4011. wantResponse: `{"message":"invalid group_id"}`,
  4012. },
  4013. {
  4014. name: "can't add buddies to root group",
  4015. screenName: "userA",
  4016. groupID: "0",
  4017. requestBody: `{"name":"buddy"}`,
  4018. wantStatusCode: http.StatusBadRequest,
  4019. wantResponse: `{"message":"can't add buddies to root group"}`,
  4020. },
  4021. {
  4022. name: "empty screen_name",
  4023. screenName: "",
  4024. groupID: "1",
  4025. requestBody: `{"name":"buddy"}`,
  4026. wantStatusCode: http.StatusBadRequest,
  4027. wantResponse: `{"message":"screen_name is required"}`,
  4028. },
  4029. {
  4030. name: "malformed JSON input",
  4031. screenName: "userA",
  4032. groupID: "1",
  4033. requestBody: `invalid json`,
  4034. wantStatusCode: http.StatusBadRequest,
  4035. wantResponse: `{"message":"buddy_screen_name is required"}`,
  4036. },
  4037. {
  4038. name: "empty name in request body",
  4039. screenName: "userA",
  4040. groupID: "1",
  4041. requestBody: `{"name":""}`,
  4042. wantStatusCode: http.StatusBadRequest,
  4043. wantResponse: `{"message":"buddy_screen_name is required"}`,
  4044. },
  4045. {
  4046. name: "missing name in request body",
  4047. screenName: "userA",
  4048. groupID: "1",
  4049. requestBody: `{}`,
  4050. wantStatusCode: http.StatusBadRequest,
  4051. wantResponse: `{"message":"buddy_screen_name is required"}`,
  4052. },
  4053. {
  4054. name: "invalid UIN - too low",
  4055. screenName: "userA",
  4056. groupID: "1",
  4057. requestBody: `{"name":"9999"}`,
  4058. wantStatusCode: http.StatusBadRequest,
  4059. wantResponse: `{"message":"invalid uin: uin must be a number in the range 10000-2147483646"}`,
  4060. },
  4061. {
  4062. name: "invalid UIN - too high",
  4063. screenName: "userA",
  4064. groupID: "1",
  4065. requestBody: `{"name":"2147483647"}`,
  4066. wantStatusCode: http.StatusBadRequest,
  4067. wantResponse: `{"message":"invalid uin: uin must be a number in the range 10000-2147483646"}`,
  4068. },
  4069. {
  4070. name: "invalid AIM handle - too short",
  4071. screenName: "userA",
  4072. groupID: "1",
  4073. requestBody: `{"name":"Us"}`,
  4074. wantStatusCode: http.StatusBadRequest,
  4075. wantResponse: `{"message":"invalid screen name: screen name must be between 3 and 16 characters"}`,
  4076. },
  4077. {
  4078. name: "invalid AIM handle - too long",
  4079. screenName: "userA",
  4080. groupID: "1",
  4081. requestBody: `{"name":"ThisIsAReallyLongScreenName"}`,
  4082. wantStatusCode: http.StatusBadRequest,
  4083. wantResponse: `{"message":"invalid screen name: screen name must be between 3 and 16 characters"}`,
  4084. },
  4085. {
  4086. name: "error retrieving feedbag",
  4087. screenName: "userA",
  4088. groupID: "1",
  4089. requestBody: `{"name":"buddy"}`,
  4090. wantStatusCode: http.StatusInternalServerError,
  4091. wantResponse: `{"message":"internal server error"}`,
  4092. mockParams: mockParams{
  4093. feedbagManagerParams: feedbagManagerParams{
  4094. feedbagParams: feedbagParams{
  4095. {
  4096. screenName: state.NewIdentScreenName("userA"),
  4097. result: nil,
  4098. err: errors.New("database error"),
  4099. },
  4100. },
  4101. },
  4102. },
  4103. },
  4104. {
  4105. name: "too many buddies in group - max 30",
  4106. screenName: "userA",
  4107. groupID: "1",
  4108. requestBody: `{"name":"newbuddy"}`,
  4109. wantStatusCode: http.StatusBadRequest,
  4110. wantResponse: `{"message":"too many buddies in group. max: 30"}`,
  4111. mockParams: mockParams{
  4112. feedbagManagerParams: feedbagManagerParams{
  4113. feedbagParams: feedbagParams{
  4114. {
  4115. screenName: state.NewIdentScreenName("userA"),
  4116. result: func() []wire.FeedbagItem {
  4117. order := make([]uint16, 30)
  4118. for i := 1; i <= 30; i++ {
  4119. order[i-1] = uint16(i)
  4120. }
  4121. items := []wire.FeedbagItem{
  4122. {
  4123. ClassID: wire.FeedbagClassIdGroup,
  4124. Name: "Friends",
  4125. GroupID: 1,
  4126. TLVLBlock: wire.TLVLBlock{
  4127. TLVList: wire.TLVList{
  4128. wire.NewTLVBE(wire.FeedbagAttributesOrder, order),
  4129. },
  4130. },
  4131. },
  4132. }
  4133. // Add 30 buddies to the group
  4134. for i := 1; i <= 30; i++ {
  4135. items = append(items, wire.FeedbagItem{
  4136. ItemID: uint16(i),
  4137. ClassID: wire.FeedbagClassIdBuddy,
  4138. Name: fmt.Sprintf("buddy%d", i),
  4139. GroupID: 1,
  4140. })
  4141. }
  4142. return items
  4143. }(),
  4144. err: nil,
  4145. },
  4146. },
  4147. },
  4148. },
  4149. },
  4150. {
  4151. name: "group not found",
  4152. screenName: "userA",
  4153. groupID: "999",
  4154. requestBody: `{"name":"buddy"}`,
  4155. wantStatusCode: http.StatusNotFound,
  4156. wantResponse: `{"message":"group not found"}`,
  4157. mockParams: mockParams{
  4158. feedbagManagerParams: feedbagManagerParams{
  4159. feedbagParams: feedbagParams{
  4160. {
  4161. screenName: state.NewIdentScreenName("userA"),
  4162. result: []wire.FeedbagItem{
  4163. {
  4164. ClassID: wire.FeedbagClassIdGroup,
  4165. Name: "Friends",
  4166. GroupID: 1,
  4167. },
  4168. },
  4169. err: nil,
  4170. },
  4171. },
  4172. },
  4173. },
  4174. },
  4175. {
  4176. name: "error inserting feedbag item",
  4177. screenName: "userA",
  4178. groupID: "1",
  4179. requestBody: `{"name":"buddy"}`,
  4180. wantStatusCode: http.StatusInternalServerError,
  4181. wantResponse: `{"message":"internal server error"}`,
  4182. mockParams: mockParams{
  4183. feedbagManagerParams: feedbagManagerParams{
  4184. feedbagParams: feedbagParams{
  4185. {
  4186. screenName: state.NewIdentScreenName("userA"),
  4187. result: []wire.FeedbagItem{
  4188. {
  4189. ClassID: wire.FeedbagClassIdGroup,
  4190. Name: "Friends",
  4191. GroupID: 1,
  4192. },
  4193. },
  4194. err: nil,
  4195. },
  4196. },
  4197. feedbagUpsertParams: feedbagUpsertParams{
  4198. {
  4199. screenName: state.NewIdentScreenName("userA"),
  4200. items: []wire.FeedbagItem{
  4201. {
  4202. Name: "buddy",
  4203. GroupID: 1,
  4204. ItemID: 1000,
  4205. ClassID: wire.FeedbagClassIdBuddy,
  4206. },
  4207. {
  4208. ClassID: wire.FeedbagClassIdGroup,
  4209. Name: "Friends",
  4210. GroupID: 1,
  4211. TLVLBlock: wire.TLVLBlock{
  4212. TLVList: wire.TLVList{
  4213. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{1000}),
  4214. },
  4215. },
  4216. },
  4217. },
  4218. err: errors.New("database error"),
  4219. },
  4220. },
  4221. },
  4222. },
  4223. },
  4224. }
  4225. for _, tc := range tt {
  4226. t.Run(tc.name, func(t *testing.T) {
  4227. // Extract buddy name from requestBody JSON
  4228. var buddyName string
  4229. if tc.requestBody != "" {
  4230. var input struct {
  4231. Name string `json:"name"`
  4232. }
  4233. if err := json.Unmarshal([]byte(tc.requestBody), &input); err == nil {
  4234. buddyName = input.Name
  4235. }
  4236. }
  4237. request := httptest.NewRequest(http.MethodPut, "/feedbag/"+tc.screenName+"/group/"+tc.groupID+"/buddy/"+buddyName, nil)
  4238. if tc.screenName != "" {
  4239. request.SetPathValue("screen_name", tc.screenName)
  4240. }
  4241. if tc.groupID != "" {
  4242. request.SetPathValue("group_id", tc.groupID)
  4243. }
  4244. request.SetPathValue("buddy_screen_name", buddyName)
  4245. responseRecorder := httptest.NewRecorder()
  4246. feedbagManager := newMockFeedbagManager(t)
  4247. sessionRetriever := newMockSessionRetriever(t)
  4248. messageRelayer := newMockMessageRelayer(t)
  4249. buddyBroadcaster := newMockBuddyBroadcaster(t)
  4250. for _, params := range tc.mockParams.feedbagParams {
  4251. feedbagManager.EXPECT().
  4252. Feedbag(matchContext(), params.screenName).
  4253. Return(params.result, params.err)
  4254. }
  4255. for _, params := range tc.mockParams.feedbagUpsertParams {
  4256. feedbagManager.EXPECT().
  4257. FeedbagUpsert(matchContext(), params.screenName, params.items).
  4258. Return(params.err)
  4259. }
  4260. for _, params := range tc.mockParams.retrieveSessionByNameParams {
  4261. sessionRetriever.EXPECT().
  4262. RetrieveSession(params.screenName).
  4263. Return(params.result)
  4264. }
  4265. for _, params := range tc.mockParams.relayToScreenNameParams {
  4266. messageRelayer.EXPECT().
  4267. RelayToScreenName(matchContext(), params.screenName, params.msg)
  4268. }
  4269. for _, params := range tc.mockParams.broadcastVisibilityParams {
  4270. // Use mock.MatchedBy to match any SessionInstance, since we're mainly verifying filter and sendDepartures
  4271. buddyBroadcaster.EXPECT().
  4272. BroadcastVisibility(
  4273. matchContext(),
  4274. mock.AnythingOfType("*state.SessionInstance"),
  4275. params.filter,
  4276. params.sendDepartures,
  4277. ).
  4278. Return(params.err)
  4279. }
  4280. deterministicItemID := func(n int) int {
  4281. return 1000
  4282. }
  4283. putFeedbagBuddyHandler(responseRecorder, request, buddyBroadcaster, feedbagManager, sessionRetriever, messageRelayer, slog.Default(), deterministicItemID)
  4284. assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
  4285. if tc.wantStatusCode == http.StatusOK {
  4286. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  4287. } else {
  4288. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  4289. }
  4290. })
  4291. }
  4292. }
  4293. func TestFeedbagBuddyHandler_DELETE(t *testing.T) {
  4294. tt := []struct {
  4295. name string
  4296. screenName string
  4297. groupID string
  4298. requestBody string
  4299. wantStatusCode int
  4300. wantResponse string
  4301. mockParams mockParams
  4302. }{
  4303. {
  4304. name: "delete existing buddy, user not signed in",
  4305. screenName: "userA",
  4306. groupID: "1",
  4307. requestBody: `{"name":"buddy1"}`,
  4308. wantStatusCode: http.StatusNoContent,
  4309. mockParams: mockParams{
  4310. feedbagManagerParams: feedbagManagerParams{
  4311. feedbagParams: feedbagParams{
  4312. {
  4313. screenName: state.NewIdentScreenName("userA"),
  4314. result: []wire.FeedbagItem{
  4315. {
  4316. ItemID: 1,
  4317. ClassID: wire.FeedbagClassIdGroup,
  4318. Name: "Friends",
  4319. GroupID: 1,
  4320. TLVLBlock: wire.TLVLBlock{
  4321. TLVList: wire.TLVList{
  4322. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{10}),
  4323. },
  4324. },
  4325. },
  4326. {
  4327. ItemID: 10,
  4328. ClassID: wire.FeedbagClassIdBuddy,
  4329. Name: "buddy1",
  4330. GroupID: 1,
  4331. },
  4332. },
  4333. err: nil,
  4334. },
  4335. },
  4336. feedbagUpsertParams: feedbagUpsertParams{
  4337. {
  4338. screenName: state.NewIdentScreenName("userA"),
  4339. items: []wire.FeedbagItem{
  4340. {
  4341. ItemID: 1,
  4342. ClassID: wire.FeedbagClassIdGroup,
  4343. Name: "Friends",
  4344. GroupID: 1,
  4345. TLVLBlock: wire.TLVLBlock{
  4346. TLVList: wire.TLVList{
  4347. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{}),
  4348. },
  4349. },
  4350. },
  4351. },
  4352. err: nil,
  4353. },
  4354. },
  4355. feedbagDeleteParams: feedbagDeleteParams{
  4356. {
  4357. screenName: state.NewIdentScreenName("userA"),
  4358. items: []wire.FeedbagItem{
  4359. {
  4360. ItemID: 10,
  4361. ClassID: wire.FeedbagClassIdBuddy,
  4362. Name: "buddy1",
  4363. GroupID: 1,
  4364. },
  4365. },
  4366. err: nil,
  4367. },
  4368. },
  4369. },
  4370. sessionRetrieverParams: sessionRetrieverParams{
  4371. retrieveSessionByNameParams: retrieveSessionByNameParams{
  4372. {
  4373. screenName: state.NewIdentScreenName("userA"),
  4374. result: state.NewSession(),
  4375. },
  4376. },
  4377. },
  4378. messageRelayerParams: messageRelayerParams{
  4379. relayToScreenNameParams: relayToScreenNameParams{
  4380. {
  4381. screenName: state.NewIdentScreenName("userA"),
  4382. msg: wire.SNACMessage{
  4383. Frame: wire.SNACFrame{
  4384. FoodGroup: wire.Feedbag,
  4385. SubGroup: wire.FeedbagUpdateItem,
  4386. RequestID: wire.ReqIDFromServer,
  4387. },
  4388. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  4389. Items: []wire.FeedbagItem{
  4390. {
  4391. ItemID: 1,
  4392. ClassID: wire.FeedbagClassIdGroup,
  4393. Name: "Friends",
  4394. GroupID: 1,
  4395. TLVLBlock: wire.TLVLBlock{
  4396. TLVList: wire.TLVList{
  4397. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{}),
  4398. },
  4399. },
  4400. },
  4401. },
  4402. },
  4403. },
  4404. },
  4405. {
  4406. screenName: state.NewIdentScreenName("userA"),
  4407. msg: wire.SNACMessage{
  4408. Frame: wire.SNACFrame{
  4409. FoodGroup: wire.Feedbag,
  4410. SubGroup: wire.FeedbagDeleteItem,
  4411. RequestID: wire.ReqIDFromServer,
  4412. },
  4413. Body: wire.SNAC_0x13_0x0A_FeedbagDeleteItem{
  4414. Items: []wire.FeedbagItem{
  4415. {
  4416. ItemID: 10,
  4417. ClassID: wire.FeedbagClassIdBuddy,
  4418. Name: "buddy1",
  4419. GroupID: 1,
  4420. },
  4421. },
  4422. },
  4423. },
  4424. },
  4425. },
  4426. },
  4427. },
  4428. },
  4429. {
  4430. name: "delete existing buddy, user signed in",
  4431. screenName: "userA",
  4432. groupID: "1",
  4433. requestBody: `{"name":"buddy1"}`,
  4434. wantStatusCode: http.StatusNoContent,
  4435. mockParams: mockParams{
  4436. feedbagManagerParams: feedbagManagerParams{
  4437. feedbagParams: feedbagParams{
  4438. {
  4439. screenName: state.NewIdentScreenName("userA"),
  4440. result: []wire.FeedbagItem{
  4441. {
  4442. ItemID: 1,
  4443. ClassID: wire.FeedbagClassIdGroup,
  4444. Name: "Friends",
  4445. GroupID: 1,
  4446. TLVLBlock: wire.TLVLBlock{
  4447. TLVList: wire.TLVList{
  4448. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{10}),
  4449. },
  4450. },
  4451. },
  4452. {
  4453. ItemID: 10,
  4454. ClassID: wire.FeedbagClassIdBuddy,
  4455. Name: "buddy1",
  4456. GroupID: 1,
  4457. },
  4458. },
  4459. err: nil,
  4460. },
  4461. },
  4462. feedbagUpsertParams: feedbagUpsertParams{
  4463. {
  4464. screenName: state.NewIdentScreenName("userA"),
  4465. items: []wire.FeedbagItem{
  4466. {
  4467. ItemID: 1,
  4468. ClassID: wire.FeedbagClassIdGroup,
  4469. Name: "Friends",
  4470. GroupID: 1,
  4471. TLVLBlock: wire.TLVLBlock{
  4472. TLVList: wire.TLVList{
  4473. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{}),
  4474. },
  4475. },
  4476. },
  4477. },
  4478. err: nil,
  4479. },
  4480. },
  4481. feedbagDeleteParams: feedbagDeleteParams{
  4482. {
  4483. screenName: state.NewIdentScreenName("userA"),
  4484. items: []wire.FeedbagItem{
  4485. {
  4486. ItemID: 10,
  4487. ClassID: wire.FeedbagClassIdBuddy,
  4488. Name: "buddy1",
  4489. GroupID: 1,
  4490. },
  4491. },
  4492. err: nil,
  4493. },
  4494. },
  4495. },
  4496. sessionRetrieverParams: sessionRetrieverParams{
  4497. retrieveSessionByNameParams: retrieveSessionByNameParams{
  4498. {
  4499. screenName: state.NewIdentScreenName("userA"),
  4500. result: func() *state.Session {
  4501. sess := state.NewSession()
  4502. sess.SetIdentScreenName(state.NewIdentScreenName("userA"))
  4503. inst := sess.AddInstance()
  4504. inst.SetSignonComplete()
  4505. return sess
  4506. }(),
  4507. },
  4508. },
  4509. },
  4510. messageRelayerParams: messageRelayerParams{
  4511. relayToScreenNameParams: relayToScreenNameParams{
  4512. {
  4513. screenName: state.NewIdentScreenName("userA"),
  4514. msg: wire.SNACMessage{
  4515. Frame: wire.SNACFrame{
  4516. FoodGroup: wire.Feedbag,
  4517. SubGroup: wire.FeedbagUpdateItem,
  4518. RequestID: wire.ReqIDFromServer,
  4519. },
  4520. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  4521. Items: []wire.FeedbagItem{
  4522. {
  4523. ItemID: 1,
  4524. ClassID: wire.FeedbagClassIdGroup,
  4525. Name: "Friends",
  4526. GroupID: 1,
  4527. TLVLBlock: wire.TLVLBlock{
  4528. TLVList: wire.TLVList{
  4529. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{}),
  4530. },
  4531. },
  4532. },
  4533. },
  4534. },
  4535. },
  4536. },
  4537. {
  4538. screenName: state.NewIdentScreenName("userA"),
  4539. msg: wire.SNACMessage{
  4540. Frame: wire.SNACFrame{
  4541. FoodGroup: wire.Feedbag,
  4542. SubGroup: wire.FeedbagDeleteItem,
  4543. RequestID: wire.ReqIDFromServer,
  4544. },
  4545. Body: wire.SNAC_0x13_0x0A_FeedbagDeleteItem{
  4546. Items: []wire.FeedbagItem{
  4547. {
  4548. ItemID: 10,
  4549. ClassID: wire.FeedbagClassIdBuddy,
  4550. Name: "buddy1",
  4551. GroupID: 1,
  4552. },
  4553. },
  4554. },
  4555. },
  4556. },
  4557. },
  4558. },
  4559. buddyBroadcasterParams: buddyBroadcasterParams{
  4560. broadcastVisibilityParams: broadcastVisibilityParams{
  4561. {
  4562. you: nil, // Not used in expectation, matched with mock.AnythingOfType
  4563. filter: []state.IdentScreenName{state.NewIdentScreenName("buddy1")},
  4564. sendDepartures: true,
  4565. err: nil,
  4566. },
  4567. },
  4568. },
  4569. },
  4570. },
  4571. {
  4572. name: "delete buddy from a group with multiple buddies, user not signed in",
  4573. screenName: "userA",
  4574. groupID: "1",
  4575. requestBody: `{"name":"buddy1"}`,
  4576. wantStatusCode: http.StatusNoContent,
  4577. mockParams: mockParams{
  4578. feedbagManagerParams: feedbagManagerParams{
  4579. feedbagParams: feedbagParams{
  4580. {
  4581. screenName: state.NewIdentScreenName("userA"),
  4582. result: []wire.FeedbagItem{
  4583. {
  4584. ItemID: 1,
  4585. ClassID: wire.FeedbagClassIdGroup,
  4586. Name: "Friends",
  4587. GroupID: 1,
  4588. TLVLBlock: wire.TLVLBlock{
  4589. TLVList: wire.TLVList{
  4590. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{10, 20}),
  4591. },
  4592. },
  4593. },
  4594. {
  4595. ItemID: 10,
  4596. ClassID: wire.FeedbagClassIdBuddy,
  4597. Name: "buddy1",
  4598. GroupID: 1,
  4599. },
  4600. {
  4601. ItemID: 20,
  4602. ClassID: wire.FeedbagClassIdBuddy,
  4603. Name: "buddy2",
  4604. GroupID: 1,
  4605. },
  4606. },
  4607. err: nil,
  4608. },
  4609. },
  4610. feedbagUpsertParams: feedbagUpsertParams{
  4611. {
  4612. screenName: state.NewIdentScreenName("userA"),
  4613. items: []wire.FeedbagItem{
  4614. {
  4615. ItemID: 1,
  4616. ClassID: wire.FeedbagClassIdGroup,
  4617. Name: "Friends",
  4618. GroupID: 1,
  4619. TLVLBlock: wire.TLVLBlock{
  4620. TLVList: wire.TLVList{
  4621. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{20}),
  4622. },
  4623. },
  4624. },
  4625. },
  4626. err: nil,
  4627. },
  4628. },
  4629. feedbagDeleteParams: feedbagDeleteParams{
  4630. {
  4631. screenName: state.NewIdentScreenName("userA"),
  4632. items: []wire.FeedbagItem{
  4633. {
  4634. ItemID: 10,
  4635. ClassID: wire.FeedbagClassIdBuddy,
  4636. Name: "buddy1",
  4637. GroupID: 1,
  4638. },
  4639. },
  4640. err: nil,
  4641. },
  4642. },
  4643. },
  4644. sessionRetrieverParams: sessionRetrieverParams{
  4645. retrieveSessionByNameParams: retrieveSessionByNameParams{
  4646. {
  4647. screenName: state.NewIdentScreenName("userA"),
  4648. result: state.NewSession(),
  4649. },
  4650. },
  4651. },
  4652. messageRelayerParams: messageRelayerParams{
  4653. relayToScreenNameParams: relayToScreenNameParams{
  4654. {
  4655. screenName: state.NewIdentScreenName("userA"),
  4656. msg: wire.SNACMessage{
  4657. Frame: wire.SNACFrame{
  4658. FoodGroup: wire.Feedbag,
  4659. SubGroup: wire.FeedbagUpdateItem,
  4660. RequestID: wire.ReqIDFromServer,
  4661. },
  4662. Body: wire.SNAC_0x13_0x09_FeedbagUpdateItem{
  4663. Items: []wire.FeedbagItem{
  4664. {
  4665. ItemID: 1,
  4666. ClassID: wire.FeedbagClassIdGroup,
  4667. Name: "Friends",
  4668. GroupID: 1,
  4669. TLVLBlock: wire.TLVLBlock{
  4670. TLVList: wire.TLVList{
  4671. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{20}),
  4672. },
  4673. },
  4674. },
  4675. },
  4676. },
  4677. },
  4678. },
  4679. {
  4680. screenName: state.NewIdentScreenName("userA"),
  4681. msg: wire.SNACMessage{
  4682. Frame: wire.SNACFrame{
  4683. FoodGroup: wire.Feedbag,
  4684. SubGroup: wire.FeedbagDeleteItem,
  4685. RequestID: wire.ReqIDFromServer,
  4686. },
  4687. Body: wire.SNAC_0x13_0x0A_FeedbagDeleteItem{
  4688. Items: []wire.FeedbagItem{
  4689. {
  4690. ItemID: 10,
  4691. ClassID: wire.FeedbagClassIdBuddy,
  4692. Name: "buddy1",
  4693. GroupID: 1,
  4694. },
  4695. },
  4696. },
  4697. },
  4698. },
  4699. },
  4700. },
  4701. },
  4702. },
  4703. {
  4704. name: "can't delete buddy from root group",
  4705. screenName: "userA",
  4706. groupID: "0",
  4707. requestBody: `{"name":"rootbuddy"}`,
  4708. wantStatusCode: http.StatusBadRequest,
  4709. wantResponse: `{"message":"can't add buddies to root group"}`,
  4710. },
  4711. {
  4712. name: "missing screen_name",
  4713. screenName: "",
  4714. groupID: "1",
  4715. requestBody: `{"name":"buddy"}`,
  4716. wantStatusCode: http.StatusBadRequest,
  4717. wantResponse: `{"message":"screen_name is required"}`,
  4718. },
  4719. {
  4720. name: "group not found",
  4721. screenName: "userA",
  4722. groupID: "999",
  4723. requestBody: `{"name":"buddy"}`,
  4724. wantStatusCode: http.StatusNotFound,
  4725. wantResponse: `{"message":"group not found"}`,
  4726. mockParams: mockParams{
  4727. feedbagManagerParams: feedbagManagerParams{
  4728. feedbagParams: feedbagParams{
  4729. {
  4730. screenName: state.NewIdentScreenName("userA"),
  4731. result: []wire.FeedbagItem{
  4732. {
  4733. ItemID: 1,
  4734. ClassID: wire.FeedbagClassIdGroup,
  4735. Name: "Friends",
  4736. GroupID: 0,
  4737. },
  4738. },
  4739. err: nil,
  4740. },
  4741. },
  4742. },
  4743. },
  4744. },
  4745. {
  4746. name: "invalid group_id",
  4747. screenName: "userA",
  4748. groupID: "invalid",
  4749. requestBody: `{"name":"buddy"}`,
  4750. wantStatusCode: http.StatusBadRequest,
  4751. wantResponse: `{"message":"invalid group_id"}`,
  4752. },
  4753. {
  4754. name: "malformed request body",
  4755. screenName: "userA",
  4756. groupID: "1",
  4757. requestBody: `invalid json`,
  4758. wantStatusCode: http.StatusBadRequest,
  4759. wantResponse: `{"message":"buddy_screen_name is required"}`,
  4760. },
  4761. {
  4762. name: "missing name in request body",
  4763. screenName: "userA",
  4764. groupID: "1",
  4765. requestBody: `{}`,
  4766. wantStatusCode: http.StatusBadRequest,
  4767. wantResponse: `{"message":"buddy_screen_name is required"}`,
  4768. },
  4769. {
  4770. name: "buddy not found",
  4771. screenName: "userA",
  4772. groupID: "1",
  4773. requestBody: `{"name":"nonexistent"}`,
  4774. wantStatusCode: http.StatusNotFound,
  4775. wantResponse: `{"message":"buddy not found"}`,
  4776. mockParams: mockParams{
  4777. feedbagManagerParams: feedbagManagerParams{
  4778. feedbagParams: feedbagParams{
  4779. {
  4780. screenName: state.NewIdentScreenName("userA"),
  4781. result: []wire.FeedbagItem{
  4782. {
  4783. ItemID: 1,
  4784. ClassID: wire.FeedbagClassIdGroup,
  4785. Name: "Friends",
  4786. GroupID: 1,
  4787. },
  4788. {
  4789. ItemID: 10,
  4790. ClassID: wire.FeedbagClassIdBuddy,
  4791. Name: "otherbuddy",
  4792. GroupID: 1,
  4793. },
  4794. },
  4795. err: nil,
  4796. },
  4797. },
  4798. },
  4799. },
  4800. },
  4801. {
  4802. name: "internal server error on feedbag retrieval",
  4803. screenName: "userA",
  4804. groupID: "1",
  4805. requestBody: `{"name":"buddy"}`,
  4806. wantStatusCode: http.StatusInternalServerError,
  4807. wantResponse: `{"message":"internal server error"}`,
  4808. mockParams: mockParams{
  4809. feedbagManagerParams: feedbagManagerParams{
  4810. feedbagParams: feedbagParams{
  4811. {
  4812. screenName: state.NewIdentScreenName("userA"),
  4813. result: nil,
  4814. err: errors.New("database error"),
  4815. },
  4816. },
  4817. },
  4818. },
  4819. },
  4820. {
  4821. name: "internal server error on group order upsert",
  4822. screenName: "userA",
  4823. groupID: "1",
  4824. requestBody: `{"name":"buddy1"}`,
  4825. wantStatusCode: http.StatusInternalServerError,
  4826. wantResponse: `{"message":"internal server error"}`,
  4827. mockParams: mockParams{
  4828. feedbagManagerParams: feedbagManagerParams{
  4829. feedbagParams: feedbagParams{
  4830. {
  4831. screenName: state.NewIdentScreenName("userA"),
  4832. result: []wire.FeedbagItem{
  4833. {
  4834. ItemID: 1,
  4835. ClassID: wire.FeedbagClassIdGroup,
  4836. Name: "Friends",
  4837. GroupID: 1,
  4838. TLVLBlock: wire.TLVLBlock{
  4839. TLVList: wire.TLVList{
  4840. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{10}),
  4841. },
  4842. },
  4843. },
  4844. {
  4845. ItemID: 10,
  4846. ClassID: wire.FeedbagClassIdBuddy,
  4847. Name: "buddy1",
  4848. GroupID: 1,
  4849. },
  4850. },
  4851. err: nil,
  4852. },
  4853. },
  4854. feedbagUpsertParams: feedbagUpsertParams{
  4855. {
  4856. screenName: state.NewIdentScreenName("userA"),
  4857. items: []wire.FeedbagItem{
  4858. {
  4859. ItemID: 1,
  4860. ClassID: wire.FeedbagClassIdGroup,
  4861. Name: "Friends",
  4862. GroupID: 1,
  4863. TLVLBlock: wire.TLVLBlock{
  4864. TLVList: wire.TLVList{
  4865. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{}),
  4866. },
  4867. },
  4868. },
  4869. },
  4870. err: errors.New("database error"),
  4871. },
  4872. },
  4873. },
  4874. },
  4875. },
  4876. {
  4877. name: "internal server error on delete",
  4878. screenName: "userA",
  4879. groupID: "1",
  4880. requestBody: `{"name":"buddy1"}`,
  4881. wantStatusCode: http.StatusInternalServerError,
  4882. wantResponse: `{"message":"internal server error"}`,
  4883. mockParams: mockParams{
  4884. feedbagManagerParams: feedbagManagerParams{
  4885. feedbagParams: feedbagParams{
  4886. {
  4887. screenName: state.NewIdentScreenName("userA"),
  4888. result: []wire.FeedbagItem{
  4889. {
  4890. ItemID: 1,
  4891. ClassID: wire.FeedbagClassIdGroup,
  4892. Name: "Friends",
  4893. GroupID: 1,
  4894. TLVLBlock: wire.TLVLBlock{
  4895. TLVList: wire.TLVList{
  4896. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{10}),
  4897. },
  4898. },
  4899. },
  4900. {
  4901. ItemID: 10,
  4902. ClassID: wire.FeedbagClassIdBuddy,
  4903. Name: "buddy1",
  4904. GroupID: 1,
  4905. },
  4906. },
  4907. err: nil,
  4908. },
  4909. },
  4910. feedbagUpsertParams: feedbagUpsertParams{
  4911. {
  4912. screenName: state.NewIdentScreenName("userA"),
  4913. items: []wire.FeedbagItem{
  4914. {
  4915. ItemID: 1,
  4916. ClassID: wire.FeedbagClassIdGroup,
  4917. Name: "Friends",
  4918. GroupID: 1,
  4919. TLVLBlock: wire.TLVLBlock{
  4920. TLVList: wire.TLVList{
  4921. wire.NewTLVBE(wire.FeedbagAttributesOrder, []uint16{}),
  4922. },
  4923. },
  4924. },
  4925. },
  4926. err: nil,
  4927. },
  4928. },
  4929. feedbagDeleteParams: feedbagDeleteParams{
  4930. {
  4931. screenName: state.NewIdentScreenName("userA"),
  4932. items: []wire.FeedbagItem{
  4933. {
  4934. ItemID: 10,
  4935. ClassID: wire.FeedbagClassIdBuddy,
  4936. Name: "buddy1",
  4937. GroupID: 1,
  4938. },
  4939. },
  4940. err: errors.New("database error"),
  4941. },
  4942. },
  4943. },
  4944. },
  4945. },
  4946. }
  4947. for _, tc := range tt {
  4948. t.Run(tc.name, func(t *testing.T) {
  4949. // Extract buddy name from requestBody JSON
  4950. var buddyName string
  4951. if tc.requestBody != "" {
  4952. var input struct {
  4953. Name string `json:"name"`
  4954. }
  4955. if err := json.Unmarshal([]byte(tc.requestBody), &input); err == nil {
  4956. buddyName = input.Name
  4957. }
  4958. }
  4959. request := httptest.NewRequest(http.MethodDelete, "/feedbag/"+tc.screenName+"/group/"+tc.groupID+"/buddy/"+buddyName, nil)
  4960. if tc.screenName != "" {
  4961. request.SetPathValue("screen_name", tc.screenName)
  4962. }
  4963. if tc.groupID != "" {
  4964. request.SetPathValue("group_id", tc.groupID)
  4965. }
  4966. request.SetPathValue("buddy_screen_name", buddyName)
  4967. responseRecorder := httptest.NewRecorder()
  4968. feedbagManager := newMockFeedbagManager(t)
  4969. sessionRetriever := newMockSessionRetriever(t)
  4970. messageRelayer := newMockMessageRelayer(t)
  4971. buddyBroadcaster := newMockBuddyBroadcaster(t)
  4972. for _, params := range tc.mockParams.feedbagParams {
  4973. feedbagManager.EXPECT().
  4974. Feedbag(matchContext(), params.screenName).
  4975. Return(params.result, params.err)
  4976. }
  4977. for _, params := range tc.mockParams.feedbagUpsertParams {
  4978. feedbagManager.EXPECT().
  4979. FeedbagUpsert(matchContext(), params.screenName, params.items).
  4980. Return(params.err)
  4981. }
  4982. for _, params := range tc.mockParams.feedbagDeleteParams {
  4983. feedbagManager.EXPECT().
  4984. FeedbagDelete(matchContext(), params.screenName, params.items).
  4985. Return(params.err)
  4986. }
  4987. for _, params := range tc.mockParams.retrieveSessionByNameParams {
  4988. sessionRetriever.EXPECT().
  4989. RetrieveSession(params.screenName).
  4990. Return(params.result)
  4991. }
  4992. for _, params := range tc.mockParams.relayToScreenNameParams {
  4993. messageRelayer.EXPECT().
  4994. RelayToScreenName(matchContext(), params.screenName, params.msg)
  4995. }
  4996. for _, params := range tc.mockParams.broadcastVisibilityParams {
  4997. buddyBroadcaster.EXPECT().
  4998. BroadcastVisibility(
  4999. matchContext(),
  5000. mock.AnythingOfType("*state.SessionInstance"),
  5001. params.filter,
  5002. params.sendDepartures,
  5003. ).
  5004. Return(params.err)
  5005. }
  5006. deleteFeedbagBuddyHandler(responseRecorder, request, buddyBroadcaster, feedbagManager, sessionRetriever, messageRelayer, slog.Default())
  5007. assert.Equal(t, tc.wantStatusCode, responseRecorder.Code)
  5008. if tc.wantResponse != "" {
  5009. assert.JSONEq(t, tc.wantResponse, responseRecorder.Body.String())
  5010. }
  5011. })
  5012. }
  5013. }
  5014. func TestRandItemID(t *testing.T) {
  5015. tt := []struct {
  5016. name string
  5017. randInt func(n int) int
  5018. items []wire.FeedbagItem
  5019. want uint16
  5020. description string
  5021. }{
  5022. {
  5023. name: "empty items list returns random ID",
  5024. randInt: func(n int) int {
  5025. return 1000
  5026. },
  5027. items: []wire.FeedbagItem{},
  5028. want: 1000,
  5029. description: "When no items exist, should return the random number generated",
  5030. },
  5031. {
  5032. name: "finds next available ID when starting ID conflicts with ItemID",
  5033. randInt: func(n int) int {
  5034. return 100
  5035. },
  5036. items: []wire.FeedbagItem{
  5037. {ItemID: 100, GroupID: 1},
  5038. {ItemID: 101, GroupID: 1},
  5039. },
  5040. want: 102,
  5041. description: "Should skip 100 and 101, return 102",
  5042. },
  5043. {
  5044. name: "finds next available ID when starting ID conflicts with GroupID",
  5045. randInt: func(n int) int {
  5046. return 50
  5047. },
  5048. items: []wire.FeedbagItem{
  5049. {ItemID: 1, GroupID: 50},
  5050. {ItemID: 2, GroupID: 51},
  5051. },
  5052. want: 52,
  5053. description: "Should skip 50 (GroupID) and 51 (GroupID), return 52",
  5054. },
  5055. {
  5056. name: "wraps around and skips 0 to find next available ID",
  5057. randInt: func(n int) int {
  5058. return math.MaxUint16 - 2
  5059. },
  5060. items: []wire.FeedbagItem{
  5061. {ItemID: math.MaxUint16 - 2, GroupID: 1},
  5062. {ItemID: math.MaxUint16 - 1, GroupID: 1},
  5063. {ItemID: math.MaxUint16, GroupID: 1},
  5064. },
  5065. want: 2,
  5066. description: "When wrapping around, skips 0 (always skipped) and 1 (if conflicts), returns 2",
  5067. },
  5068. {
  5069. name: "skips 0 when starting from 0 and finds next available",
  5070. randInt: func(n int) int {
  5071. return 0
  5072. },
  5073. items: []wire.FeedbagItem{},
  5074. want: 1,
  5075. description: "When starting from 0, skips 0 (always skipped) and returns 1",
  5076. },
  5077. {
  5078. name: "returns 0 when all IDs are taken",
  5079. randInt: func(n int) int {
  5080. return 100
  5081. },
  5082. items: func() []wire.FeedbagItem {
  5083. // Create items that cover all possible IDs
  5084. items := make([]wire.FeedbagItem, 0, math.MaxUint16+1)
  5085. for i := 0; i <= math.MaxUint16; i++ {
  5086. items = append(items, wire.FeedbagItem{
  5087. ItemID: uint16(i),
  5088. GroupID: uint16(i),
  5089. })
  5090. }
  5091. return items
  5092. }(),
  5093. want: 0,
  5094. description: "When all IDs are taken, should return 0",
  5095. },
  5096. {
  5097. name: "finds ID that conflicts with both ItemID and GroupID",
  5098. randInt: func(n int) int {
  5099. return 200
  5100. },
  5101. items: []wire.FeedbagItem{
  5102. {ItemID: 200, GroupID: 201},
  5103. {ItemID: 201, GroupID: 200},
  5104. },
  5105. want: 202,
  5106. description: "Should skip 200 (ItemID) and 201 (both ItemID and GroupID), return 202",
  5107. },
  5108. {
  5109. name: "finds available ID immediately when no conflicts",
  5110. randInt: func(n int) int {
  5111. return 500
  5112. },
  5113. items: []wire.FeedbagItem{
  5114. {ItemID: 100, GroupID: 1},
  5115. {ItemID: 200, GroupID: 2},
  5116. {ItemID: 300, GroupID: 3},
  5117. },
  5118. want: 500,
  5119. description: "When random ID has no conflicts, should return it immediately",
  5120. },
  5121. {
  5122. name: "handles single conflict and finds next",
  5123. randInt: func(n int) int {
  5124. return 42
  5125. },
  5126. items: []wire.FeedbagItem{
  5127. {ItemID: 42, GroupID: 1},
  5128. },
  5129. want: 43,
  5130. description: "Should skip 42 and return 43",
  5131. },
  5132. {
  5133. name: "finds ID before starting point when wrapping",
  5134. randInt: func(n int) int {
  5135. return 5
  5136. },
  5137. items: []wire.FeedbagItem{
  5138. {ItemID: 5, GroupID: 1},
  5139. {ItemID: 6, GroupID: 1},
  5140. {ItemID: 7, GroupID: 1},
  5141. },
  5142. want: 8,
  5143. description: "Should skip 5, 6, 7 and return 8",
  5144. },
  5145. }
  5146. for _, tc := range tt {
  5147. t.Run(tc.name, func(t *testing.T) {
  5148. got := randItemID(tc.randInt, tc.items)
  5149. if got != tc.want {
  5150. t.Errorf("randItemID() = %d, want %d. %s", got, tc.want, tc.description)
  5151. }
  5152. })
  5153. }
  5154. }
  5155. func TestGetLinkedAccountsHandler(t *testing.T) {
  5156. tt := []struct {
  5157. name string
  5158. screenname string
  5159. statusCode int
  5160. want string
  5161. mockParams mockParams
  5162. }{
  5163. {
  5164. name: "user not found returns 404",
  5165. screenname: "nobody",
  5166. statusCode: http.StatusNotFound,
  5167. want: `{"message":"user not found"}`,
  5168. mockParams: mockParams{
  5169. userManagerParams: userManagerParams{
  5170. getUserParams: getUserParams{
  5171. {
  5172. screenName: state.NewIdentScreenName("nobody"),
  5173. result: nil,
  5174. },
  5175. },
  5176. },
  5177. },
  5178. },
  5179. {
  5180. name: "returns empty linked accounts list",
  5181. screenname: "test1",
  5182. statusCode: http.StatusOK,
  5183. want: `{"linked_accounts":[]}`,
  5184. mockParams: mockParams{
  5185. userManagerParams: userManagerParams{
  5186. getUserParams: getUserParams{
  5187. {
  5188. screenName: state.NewIdentScreenName("test1"),
  5189. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5190. },
  5191. },
  5192. },
  5193. feedbagManagerParams: feedbagManagerParams{
  5194. feedbagParams: feedbagParams{
  5195. {
  5196. screenName: state.NewIdentScreenName("test1"),
  5197. result: []wire.FeedbagItem{},
  5198. },
  5199. },
  5200. },
  5201. },
  5202. },
  5203. {
  5204. name: "returns linked accounts",
  5205. screenname: "test1",
  5206. statusCode: http.StatusOK,
  5207. want: `{"linked_accounts":["test2","test3"]}`,
  5208. mockParams: mockParams{
  5209. userManagerParams: userManagerParams{
  5210. getUserParams: getUserParams{
  5211. {
  5212. screenName: state.NewIdentScreenName("test1"),
  5213. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5214. },
  5215. },
  5216. },
  5217. feedbagManagerParams: feedbagManagerParams{
  5218. feedbagParams: feedbagParams{
  5219. {
  5220. screenName: state.NewIdentScreenName("test1"),
  5221. result: []wire.FeedbagItem{
  5222. {ClassID: wire.FeedbagClassIdAlInfo, Name: "test2"},
  5223. {ClassID: wire.FeedbagClassIdAlInfo, Name: "test3"},
  5224. },
  5225. },
  5226. },
  5227. },
  5228. },
  5229. },
  5230. {
  5231. name: "feedbag error returns 500",
  5232. screenname: "test1",
  5233. statusCode: http.StatusInternalServerError,
  5234. want: `{"message":"internal server error"}`,
  5235. mockParams: mockParams{
  5236. userManagerParams: userManagerParams{
  5237. getUserParams: getUserParams{
  5238. {
  5239. screenName: state.NewIdentScreenName("test1"),
  5240. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5241. },
  5242. },
  5243. },
  5244. feedbagManagerParams: feedbagManagerParams{
  5245. feedbagParams: feedbagParams{
  5246. {
  5247. screenName: state.NewIdentScreenName("test1"),
  5248. err: io.EOF,
  5249. },
  5250. },
  5251. },
  5252. },
  5253. },
  5254. }
  5255. for _, tc := range tt {
  5256. t.Run(tc.name, func(t *testing.T) {
  5257. request := httptest.NewRequest(http.MethodGet, "/user/"+tc.screenname+"/linked-account", nil)
  5258. request.SetPathValue("screenname", tc.screenname)
  5259. responseRecorder := httptest.NewRecorder()
  5260. userManager := newMockUserManager(t)
  5261. for _, params := range tc.mockParams.getUserParams {
  5262. userManager.EXPECT().
  5263. User(matchContext(), params.screenName).
  5264. Return(params.result, params.err)
  5265. }
  5266. feedbagManager := newMockFeedbagManager(t)
  5267. for _, params := range tc.mockParams.feedbagParams {
  5268. feedbagManager.EXPECT().
  5269. Feedbag(matchContext(), params.screenName).
  5270. Return(params.result, params.err)
  5271. }
  5272. getLinkedAccountsHandler(responseRecorder, request, userManager, feedbagManager)
  5273. assert.Equal(t, tc.statusCode, responseRecorder.Code)
  5274. assert.Equal(t, tc.want, strings.TrimSpace(responseRecorder.Body.String()))
  5275. })
  5276. }
  5277. }
  5278. func TestPostLinkedAccountHandler(t *testing.T) {
  5279. tt := []struct {
  5280. name string
  5281. screenname string
  5282. body string
  5283. statusCode int
  5284. want string
  5285. mockParams mockParams
  5286. }{
  5287. {
  5288. name: "primary user not found returns 404",
  5289. screenname: "nobody",
  5290. body: `{"linked_screen_name":"test2"}`,
  5291. statusCode: http.StatusNotFound,
  5292. want: `{"message":"user not found"}`,
  5293. mockParams: mockParams{
  5294. userManagerParams: userManagerParams{
  5295. getUserParams: getUserParams{
  5296. {
  5297. screenName: state.NewIdentScreenName("nobody"),
  5298. result: nil,
  5299. },
  5300. },
  5301. },
  5302. },
  5303. },
  5304. {
  5305. name: "invalid request body returns 400",
  5306. screenname: "test1",
  5307. body: `not json`,
  5308. statusCode: http.StatusBadRequest,
  5309. want: `{"message":"invalid request body"}`,
  5310. mockParams: mockParams{
  5311. userManagerParams: userManagerParams{
  5312. getUserParams: getUserParams{
  5313. {
  5314. screenName: state.NewIdentScreenName("test1"),
  5315. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5316. },
  5317. },
  5318. },
  5319. },
  5320. },
  5321. {
  5322. name: "missing linked_screen_name returns 400",
  5323. screenname: "test1",
  5324. body: `{}`,
  5325. statusCode: http.StatusBadRequest,
  5326. want: `{"message":"invalid request body"}`,
  5327. mockParams: mockParams{
  5328. userManagerParams: userManagerParams{
  5329. getUserParams: getUserParams{
  5330. {
  5331. screenName: state.NewIdentScreenName("test1"),
  5332. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5333. },
  5334. },
  5335. },
  5336. },
  5337. },
  5338. {
  5339. name: "self-link returns 400",
  5340. screenname: "test1",
  5341. body: `{"linked_screen_name":"test1"}`,
  5342. statusCode: http.StatusBadRequest,
  5343. want: `{"message":"cannot link an account to itself"}`,
  5344. mockParams: mockParams{
  5345. userManagerParams: userManagerParams{
  5346. getUserParams: getUserParams{
  5347. {
  5348. screenName: state.NewIdentScreenName("test1"),
  5349. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5350. },
  5351. },
  5352. },
  5353. },
  5354. },
  5355. {
  5356. name: "linked user not found returns 404",
  5357. screenname: "test1",
  5358. body: `{"linked_screen_name":"nobody"}`,
  5359. statusCode: http.StatusNotFound,
  5360. want: `{"message":"linked user not found"}`,
  5361. mockParams: mockParams{
  5362. userManagerParams: userManagerParams{
  5363. getUserParams: getUserParams{
  5364. {
  5365. screenName: state.NewIdentScreenName("test1"),
  5366. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5367. },
  5368. {
  5369. screenName: state.NewIdentScreenName("nobody"),
  5370. result: nil,
  5371. },
  5372. },
  5373. },
  5374. },
  5375. },
  5376. {
  5377. name: "duplicate link returns 409",
  5378. screenname: "test1",
  5379. body: `{"linked_screen_name":"test2"}`,
  5380. statusCode: http.StatusConflict,
  5381. want: `{"message":"linked account already exists"}`,
  5382. mockParams: mockParams{
  5383. userManagerParams: userManagerParams{
  5384. getUserParams: getUserParams{
  5385. {
  5386. screenName: state.NewIdentScreenName("test1"),
  5387. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5388. },
  5389. {
  5390. screenName: state.NewIdentScreenName("test2"),
  5391. result: &state.User{IdentScreenName: state.NewIdentScreenName("test2")},
  5392. },
  5393. },
  5394. },
  5395. feedbagManagerParams: feedbagManagerParams{
  5396. feedbagParams: feedbagParams{
  5397. {
  5398. screenName: state.NewIdentScreenName("test1"),
  5399. result: []wire.FeedbagItem{
  5400. {ClassID: wire.FeedbagClassIdAlInfo, Name: "test2"},
  5401. },
  5402. },
  5403. },
  5404. },
  5405. },
  5406. },
  5407. {
  5408. name: "link below cap returns 201",
  5409. screenname: "test1",
  5410. body: `{"linked_screen_name":"test2"}`,
  5411. statusCode: http.StatusCreated,
  5412. want: ``,
  5413. mockParams: mockParams{
  5414. userManagerParams: userManagerParams{
  5415. getUserParams: getUserParams{
  5416. {
  5417. screenName: state.NewIdentScreenName("test1"),
  5418. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5419. },
  5420. {
  5421. screenName: state.NewIdentScreenName("test2"),
  5422. result: &state.User{IdentScreenName: state.NewIdentScreenName("test2")},
  5423. },
  5424. },
  5425. },
  5426. feedbagManagerParams: feedbagManagerParams{
  5427. feedbagParams: feedbagParams{
  5428. {
  5429. screenName: state.NewIdentScreenName("test1"),
  5430. result: []wire.FeedbagItem{
  5431. {ClassID: wire.FeedbagClassIdAlInfo, Name: "link1", ItemID: 1},
  5432. {ClassID: wire.FeedbagClassIdAlInfo, Name: "link2", ItemID: 2},
  5433. {ClassID: wire.FeedbagClassIdAlInfo, Name: "link3", ItemID: 3},
  5434. },
  5435. },
  5436. },
  5437. feedbagUpsertParams: feedbagUpsertParams{
  5438. {
  5439. screenName: state.NewIdentScreenName("test1"),
  5440. items: []wire.FeedbagItem{
  5441. {ItemID: 4, ClassID: wire.FeedbagClassIdAlInfo, Name: "test2"},
  5442. },
  5443. },
  5444. },
  5445. },
  5446. },
  5447. },
  5448. {
  5449. name: "link cap reached returns 409",
  5450. screenname: "test1",
  5451. body: `{"linked_screen_name":"test2"}`,
  5452. statusCode: http.StatusConflict,
  5453. want: `{"message":"user already has the maximum of 4 linked accounts"}`,
  5454. mockParams: mockParams{
  5455. userManagerParams: userManagerParams{
  5456. getUserParams: getUserParams{
  5457. {
  5458. screenName: state.NewIdentScreenName("test1"),
  5459. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5460. },
  5461. {
  5462. screenName: state.NewIdentScreenName("test2"),
  5463. result: &state.User{IdentScreenName: state.NewIdentScreenName("test2")},
  5464. },
  5465. },
  5466. },
  5467. feedbagManagerParams: feedbagManagerParams{
  5468. feedbagParams: feedbagParams{
  5469. {
  5470. screenName: state.NewIdentScreenName("test1"),
  5471. result: []wire.FeedbagItem{
  5472. {ClassID: wire.FeedbagClassIdAlInfo, Name: "link1", ItemID: 1},
  5473. {ClassID: wire.FeedbagClassIdAlInfo, Name: "link2", ItemID: 2},
  5474. {ClassID: wire.FeedbagClassIdAlInfo, Name: "link3", ItemID: 3},
  5475. {ClassID: wire.FeedbagClassIdAlInfo, Name: "link4", ItemID: 4},
  5476. },
  5477. },
  5478. },
  5479. },
  5480. },
  5481. },
  5482. {
  5483. name: "insert error returns 500",
  5484. screenname: "test1",
  5485. body: `{"linked_screen_name":"test2"}`,
  5486. statusCode: http.StatusInternalServerError,
  5487. want: `{"message":"internal server error"}`,
  5488. mockParams: mockParams{
  5489. userManagerParams: userManagerParams{
  5490. getUserParams: getUserParams{
  5491. {
  5492. screenName: state.NewIdentScreenName("test1"),
  5493. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5494. },
  5495. {
  5496. screenName: state.NewIdentScreenName("test2"),
  5497. result: &state.User{IdentScreenName: state.NewIdentScreenName("test2")},
  5498. },
  5499. },
  5500. },
  5501. feedbagManagerParams: feedbagManagerParams{
  5502. feedbagParams: feedbagParams{
  5503. {
  5504. screenName: state.NewIdentScreenName("test1"),
  5505. result: []wire.FeedbagItem{},
  5506. },
  5507. },
  5508. feedbagUpsertParams: feedbagUpsertParams{
  5509. {
  5510. screenName: state.NewIdentScreenName("test1"),
  5511. items: []wire.FeedbagItem{
  5512. {ItemID: 1, ClassID: wire.FeedbagClassIdAlInfo, Name: "test2"},
  5513. },
  5514. err: io.EOF,
  5515. },
  5516. },
  5517. },
  5518. },
  5519. },
  5520. {
  5521. name: "link created returns 201",
  5522. screenname: "test1",
  5523. body: `{"linked_screen_name":"test2"}`,
  5524. statusCode: http.StatusCreated,
  5525. want: ``,
  5526. mockParams: mockParams{
  5527. userManagerParams: userManagerParams{
  5528. getUserParams: getUserParams{
  5529. {
  5530. screenName: state.NewIdentScreenName("test1"),
  5531. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5532. },
  5533. {
  5534. screenName: state.NewIdentScreenName("test2"),
  5535. result: &state.User{IdentScreenName: state.NewIdentScreenName("test2")},
  5536. },
  5537. },
  5538. },
  5539. feedbagManagerParams: feedbagManagerParams{
  5540. feedbagParams: feedbagParams{
  5541. {
  5542. screenName: state.NewIdentScreenName("test1"),
  5543. result: []wire.FeedbagItem{},
  5544. },
  5545. },
  5546. feedbagUpsertParams: feedbagUpsertParams{
  5547. {
  5548. screenName: state.NewIdentScreenName("test1"),
  5549. items: []wire.FeedbagItem{
  5550. {ItemID: 1, ClassID: wire.FeedbagClassIdAlInfo, Name: "test2"},
  5551. },
  5552. },
  5553. },
  5554. },
  5555. },
  5556. },
  5557. }
  5558. for _, tc := range tt {
  5559. t.Run(tc.name, func(t *testing.T) {
  5560. request := httptest.NewRequest(http.MethodPost, "/user/"+tc.screenname+"/linked-account", strings.NewReader(tc.body))
  5561. request.SetPathValue("screenname", tc.screenname)
  5562. responseRecorder := httptest.NewRecorder()
  5563. userManager := newMockUserManager(t)
  5564. for _, params := range tc.mockParams.getUserParams {
  5565. userManager.EXPECT().
  5566. User(matchContext(), params.screenName).
  5567. Return(params.result, params.err)
  5568. }
  5569. feedbagManager := newMockFeedbagManager(t)
  5570. for _, params := range tc.mockParams.feedbagParams {
  5571. feedbagManager.EXPECT().
  5572. Feedbag(matchContext(), params.screenName).
  5573. Return(params.result, params.err)
  5574. }
  5575. for _, params := range tc.mockParams.feedbagUpsertParams {
  5576. feedbagManager.EXPECT().
  5577. FeedbagUpsert(matchContext(), params.screenName, params.items).
  5578. Return(params.err)
  5579. }
  5580. postLinkedAccountHandler(responseRecorder, request, userManager, feedbagManager, slog.Default(), func(n int) int { return 0 })
  5581. assert.Equal(t, tc.statusCode, responseRecorder.Code)
  5582. assert.Equal(t, tc.want, strings.TrimSpace(responseRecorder.Body.String()))
  5583. })
  5584. }
  5585. }
  5586. func TestDeleteLinkedAccountHandler(t *testing.T) {
  5587. linkedFeedbagItem := wire.FeedbagItem{
  5588. ItemID: 1,
  5589. ClassID: wire.FeedbagClassIdAlInfo,
  5590. Name: "test2",
  5591. }
  5592. tt := []struct {
  5593. name string
  5594. screenname string
  5595. linkedScreenname string
  5596. statusCode int
  5597. want string
  5598. mockParams mockParams
  5599. }{
  5600. {
  5601. name: "primary user not found returns 404",
  5602. screenname: "nobody",
  5603. linkedScreenname: "test2",
  5604. statusCode: http.StatusNotFound,
  5605. want: `{"message":"user not found"}`,
  5606. mockParams: mockParams{
  5607. userManagerParams: userManagerParams{
  5608. getUserParams: getUserParams{
  5609. {
  5610. screenName: state.NewIdentScreenName("nobody"),
  5611. result: nil,
  5612. },
  5613. },
  5614. },
  5615. },
  5616. },
  5617. {
  5618. name: "linked account not found returns 404",
  5619. screenname: "test1",
  5620. linkedScreenname: "ghost",
  5621. statusCode: http.StatusNotFound,
  5622. want: `{"message":"linked account not found"}`,
  5623. mockParams: mockParams{
  5624. userManagerParams: userManagerParams{
  5625. getUserParams: getUserParams{
  5626. {
  5627. screenName: state.NewIdentScreenName("test1"),
  5628. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5629. },
  5630. },
  5631. },
  5632. feedbagManagerParams: feedbagManagerParams{
  5633. feedbagParams: feedbagParams{
  5634. {
  5635. screenName: state.NewIdentScreenName("test1"),
  5636. result: []wire.FeedbagItem{},
  5637. },
  5638. },
  5639. },
  5640. },
  5641. },
  5642. {
  5643. name: "delete error returns 500",
  5644. screenname: "test1",
  5645. linkedScreenname: "test2",
  5646. statusCode: http.StatusInternalServerError,
  5647. want: `{"message":"internal server error"}`,
  5648. mockParams: mockParams{
  5649. userManagerParams: userManagerParams{
  5650. getUserParams: getUserParams{
  5651. {
  5652. screenName: state.NewIdentScreenName("test1"),
  5653. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5654. },
  5655. },
  5656. },
  5657. feedbagManagerParams: feedbagManagerParams{
  5658. feedbagParams: feedbagParams{
  5659. {
  5660. screenName: state.NewIdentScreenName("test1"),
  5661. result: []wire.FeedbagItem{linkedFeedbagItem},
  5662. },
  5663. },
  5664. feedbagDeleteParams: feedbagDeleteParams{
  5665. {
  5666. screenName: state.NewIdentScreenName("test1"),
  5667. items: []wire.FeedbagItem{linkedFeedbagItem},
  5668. err: io.EOF,
  5669. },
  5670. },
  5671. },
  5672. },
  5673. },
  5674. {
  5675. name: "upsert error after delete returns 500",
  5676. screenname: "test1",
  5677. linkedScreenname: "test2",
  5678. statusCode: http.StatusInternalServerError,
  5679. want: `{"message":"internal server error"}`,
  5680. mockParams: mockParams{
  5681. userManagerParams: userManagerParams{
  5682. getUserParams: getUserParams{
  5683. {
  5684. screenName: state.NewIdentScreenName("test1"),
  5685. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5686. },
  5687. },
  5688. },
  5689. feedbagManagerParams: feedbagManagerParams{
  5690. feedbagParams: feedbagParams{
  5691. {
  5692. screenName: state.NewIdentScreenName("test1"),
  5693. result: []wire.FeedbagItem{linkedFeedbagItem},
  5694. },
  5695. },
  5696. feedbagDeleteParams: feedbagDeleteParams{
  5697. {
  5698. screenName: state.NewIdentScreenName("test1"),
  5699. items: []wire.FeedbagItem{linkedFeedbagItem},
  5700. },
  5701. },
  5702. feedbagUpsertParams: feedbagUpsertParams{
  5703. {
  5704. screenName: state.NewIdentScreenName("test1"),
  5705. items: []wire.FeedbagItem{{ClassID: wire.FeedbagClassIdGroup}},
  5706. err: io.EOF,
  5707. },
  5708. },
  5709. },
  5710. },
  5711. },
  5712. {
  5713. name: "link deleted returns 204",
  5714. screenname: "test1",
  5715. linkedScreenname: "test2",
  5716. statusCode: http.StatusNoContent,
  5717. want: ``,
  5718. mockParams: mockParams{
  5719. userManagerParams: userManagerParams{
  5720. getUserParams: getUserParams{
  5721. {
  5722. screenName: state.NewIdentScreenName("test1"),
  5723. result: &state.User{IdentScreenName: state.NewIdentScreenName("test1")},
  5724. },
  5725. },
  5726. },
  5727. feedbagManagerParams: feedbagManagerParams{
  5728. feedbagParams: feedbagParams{
  5729. {
  5730. screenName: state.NewIdentScreenName("test1"),
  5731. result: []wire.FeedbagItem{linkedFeedbagItem},
  5732. },
  5733. },
  5734. feedbagDeleteParams: feedbagDeleteParams{
  5735. {
  5736. screenName: state.NewIdentScreenName("test1"),
  5737. items: []wire.FeedbagItem{linkedFeedbagItem},
  5738. },
  5739. },
  5740. feedbagUpsertParams: feedbagUpsertParams{
  5741. {
  5742. screenName: state.NewIdentScreenName("test1"),
  5743. items: []wire.FeedbagItem{{ClassID: wire.FeedbagClassIdGroup}},
  5744. },
  5745. },
  5746. },
  5747. },
  5748. },
  5749. }
  5750. for _, tc := range tt {
  5751. t.Run(tc.name, func(t *testing.T) {
  5752. request := httptest.NewRequest(http.MethodDelete, "/user/"+tc.screenname+"/linked-account/"+tc.linkedScreenname, nil)
  5753. request.SetPathValue("screenname", tc.screenname)
  5754. request.SetPathValue("linked_screenname", tc.linkedScreenname)
  5755. responseRecorder := httptest.NewRecorder()
  5756. userManager := newMockUserManager(t)
  5757. for _, params := range tc.mockParams.getUserParams {
  5758. userManager.EXPECT().
  5759. User(matchContext(), params.screenName).
  5760. Return(params.result, params.err)
  5761. }
  5762. feedbagManager := newMockFeedbagManager(t)
  5763. for _, params := range tc.mockParams.feedbagParams {
  5764. feedbagManager.EXPECT().
  5765. Feedbag(matchContext(), params.screenName).
  5766. Return(params.result, params.err)
  5767. }
  5768. for _, params := range tc.mockParams.feedbagDeleteParams {
  5769. feedbagManager.EXPECT().
  5770. FeedbagDelete(matchContext(), params.screenName, params.items).
  5771. Return(params.err)
  5772. }
  5773. for _, params := range tc.mockParams.feedbagUpsertParams {
  5774. feedbagManager.EXPECT().
  5775. FeedbagUpsert(matchContext(), params.screenName, params.items).
  5776. Return(params.err)
  5777. }
  5778. deleteLinkedAccountHandler(responseRecorder, request, userManager, feedbagManager, slog.Default(), nil)
  5779. assert.Equal(t, tc.statusCode, responseRecorder.Code)
  5780. assert.Equal(t, tc.want, strings.TrimSpace(responseRecorder.Body.String()))
  5781. })
  5782. }
  5783. }