don't send departure notifs to blocked users at signon

foodgroup/oservice.go

@@ -849,8 +849,8 @@ func (s OServiceServiceForBOS) ServiceRequest(ctx context.Context, sess *state.S
 func (s OServiceServiceForBOS) ClientOnline(ctx context.Context, _ wire.SNAC_0x01_0x02_OServiceClientOnline, sess *state.Session) error {
 	sess.SetSignonComplete()
 
-	if err := s.buddyBroadcaster.BroadcastVisibility(ctx, sess, nil); err != nil {
-		return fmt.Errorf("unable to transition users: %w", err)
+	if err := s.buddyBroadcaster.BroadcastBuddyArrived(ctx, sess); err != nil {
+		return fmt.Errorf("unable to send buddy arrival notification: %w", err)
 	}
 
 	return nil

foodgroup/oservice_test.go

@@ -1734,10 +1734,9 @@ func TestOServiceServiceForBOS_ClientOnline(t *testing.T) {
 			bodyIn: wire.SNAC_0x01_0x02_OServiceClientOnline{},
 			mockParams: mockParams{
 				buddyBroadcasterParams: buddyBroadcasterParams{
-					broadcastVisibilityParams: broadcastVisibilityParams{
+					broadcastBuddyArrivedParams: broadcastBuddyArrivedParams{
 						{
-							from:   state.NewIdentScreenName("me"),
-							filter: nil,
+							screenName: state.NewIdentScreenName("me"),
 						},
 					},
 				},
@@ -1748,9 +1747,9 @@ func TestOServiceServiceForBOS_ClientOnline(t *testing.T) {
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			buddyUpdateBroadcaster := newMockbuddyBroadcaster(t)
-			for _, params := range tt.mockParams.broadcastVisibilityParams {
+			for _, params := range tt.mockParams.broadcastBuddyArrivedParams {
 				buddyUpdateBroadcaster.EXPECT().
-					BroadcastVisibility(mock.Anything, matchSession(params.from), params.filter).
+					BroadcastBuddyArrived(mock.Anything, matchSession(params.screenName)).
 					Return(params.err)
 			}