miniflux_v2/internal/validator/entry_test.go

// SPDX-FileCopyrightText: Copyright The Miniflux Authors. All rights reserved.
// SPDX-License-Identifier: Apache-2.0

package validator // import "miniflux.app/v2/internal/validator"

import (
	"testing"

	"miniflux.app/v2/internal/model"
)

func TestValidateEntriesStatusUpdateRequest(t *testing.T) {
	err := ValidateEntriesStatusUpdateRequest(&model.EntriesStatusUpdateRequest{
		Status:   model.EntryStatusRead,
		EntryIDs: []int64{int64(123), int64(456)},
	})
	if err != nil {
		t.Error(`A valid request should not be rejected`)
	}

	err = ValidateEntriesStatusUpdateRequest(&model.EntriesStatusUpdateRequest{
		Status: model.EntryStatusRead,
	})
	if err == nil {
		t.Error(`An empty list of entries is not valid`)
	}

	err = ValidateEntriesStatusUpdateRequest(&model.EntriesStatusUpdateRequest{
		Status:   "invalid",
		EntryIDs: []int64{int64(123)},
	})
	if err == nil {
		t.Error(`Only a valid status should be accepted`)
	}
}

func TestValidateEntriesStatusAndStarredUpdateRequest(t *testing.T) {
	err := ValidateEntriesStatusAndStarredUpdateRequest(&model.EntriesStatusUpdateRequest{
		Status:   model.EntryStatusRead,
		EntryIDs: []int64{int64(123), int64(456)},
	})
	if err != nil {
		t.Error(`A valid request should not be rejected`)
	}

	err = ValidateEntriesStatusAndStarredUpdateRequest(&model.EntriesStatusUpdateRequest{
		Status: model.EntryStatusRead,
	})
	if err == nil {
		t.Error(`An empty list of entries is not valid`)
	}

	err = ValidateEntriesStatusAndStarredUpdateRequest(&model.EntriesStatusUpdateRequest{
		Status:   "invalid",
		EntryIDs: []int64{int64(123)},
	})
	if err == nil {
		t.Error(`Only a valid status should be accepted`)
	}

	starred := true
	err = ValidateEntriesStatusAndStarredUpdateRequest(&model.EntriesStatusUpdateRequest{
		Starred:  &starred,
		EntryIDs: []int64{int64(123)},
	})
	if err != nil {
		t.Error(`A request with only the starred field should be accepted`)
	}

	notStarred := false
	err = ValidateEntriesStatusAndStarredUpdateRequest(&model.EntriesStatusUpdateRequest{
		Starred:  &notStarred,
		EntryIDs: []int64{int64(123)},
	})
	if err != nil {
		t.Error(`A request with starred set to false should be accepted`)
	}

	err = ValidateEntriesStatusAndStarredUpdateRequest(&model.EntriesStatusUpdateRequest{
		Status:   model.EntryStatusRead,
		Starred:  &starred,
		EntryIDs: []int64{int64(123)},
	})
	if err != nil {
		t.Error(`A request with both status and starred should be accepted`)
	}

	err = ValidateEntriesStatusAndStarredUpdateRequest(&model.EntriesStatusUpdateRequest{
		EntryIDs: []int64{int64(123)},
	})
	if err == nil {
		t.Error(`A request without status or starred should be rejected`)
	}

	err = ValidateEntriesStatusAndStarredUpdateRequest(&model.EntriesStatusUpdateRequest{
		Status:   "invalid",
		Starred:  &starred,
		EntryIDs: []int64{int64(123)},
	})
	if err == nil {
		t.Error(`An invalid status should be rejected even when starred is specified`)
	}
}

func TestValidateEntryStatus(t *testing.T) {
	for _, status := range []string{model.EntryStatusRead, model.EntryStatusUnread} {
		if err := ValidateEntryStatus(status); err != nil {
			t.Error(`A valid status should not generate any error`)
		}
	}

	if err := ValidateEntryStatus("removed"); err == nil {
		t.Error(`The "removed" status is no longer accepted`)
	}

	if err := ValidateEntryStatus("invalid"); err == nil {
		t.Error(`An invalid status should generate a error`)
	}
}

func TestValidateEntryOrder(t *testing.T) {
	for _, status := range []string{"id", "status", "changed_at", "published_at", "created_at", "category_title", "category_id", "title", "author"} {
		if err := ValidateEntryOrder(status); err != nil {
			t.Error(`A valid order should not generate any error`)
		}
	}

	if err := ValidateEntryOrder("invalid"); err == nil {
		t.Error(`An invalid order should generate a error`)
	}
}

func TestValidateEntryModification(t *testing.T) {
	// Accepts no-op update.
	if err := ValidateEntryModification(&model.EntryUpdateRequest{}); err != nil {
		t.Errorf(`A request without changes should not generate any error: %v`, err)
	}

	empty := ""
	if err := ValidateEntryModification(&model.EntryUpdateRequest{Title: &empty}); err == nil {
		t.Error(`An empty title should generate an error`)
	}

	if err := ValidateEntryModification(&model.EntryUpdateRequest{Content: &empty}); err == nil {
		t.Error(`An empty content should generate an error`)
	}

	title := "Title"
	content := "Content"
	if err := ValidateEntryModification(&model.EntryUpdateRequest{Title: &title, Content: &content}); err != nil {
		t.Errorf(`A valid title and content should not generate any error: %v`, err)
	}
}