فهرست منبع

Improve error handling in integration clients

Frédéric Guillot 8 سال پیش
والد
کامیت
fb49ad24d5
3فایلهای تغییر یافته به همراه15 افزوده شده و 3 حذف شده
  1. 5 1
      integration/instapaper/instapaper.go
  2. 5 1
      integration/nunuxkeeper/nunuxkeeper.go
  3. 5 1
      integration/pinboard/pinboard.go

+ 5 - 1
integration/instapaper/instapaper.go

@@ -31,11 +31,15 @@ func (c *Client) AddURL(link, title string) error {
 	clt := client.New(apiURL)
 	clt.WithCredentials(c.username, c.password)
 	response, err := clt.Get()
+	if err != nil {
+		return fmt.Errorf("instapaper: unable to send url: %v", err)
+	}
+
 	if response.HasServerFailure() {
 		return fmt.Errorf("instapaper: unable to send url, status=%d", response.StatusCode)
 	}
 
-	return err
+	return nil
 }
 
 // NewClient returns a new Instapaper client.

+ 5 - 1
integration/nunuxkeeper/nunuxkeeper.go

@@ -47,11 +47,15 @@ func (c *Client) AddEntry(link, title, content string) error {
 	clt := client.New(apiURL)
 	clt.WithCredentials("api", c.apiKey)
 	response, err := clt.PostJSON(doc)
+	if err != nil {
+		return fmt.Errorf("nunux-keeper: unable to send entry: %v", err)
+	}
+
 	if response.HasServerFailure() {
 		return fmt.Errorf("nunux-keeper: unable to send entry, status=%d", response.StatusCode)
 	}
 
-	return err
+	return nil
 }
 
 // NewClient returns a new Nunux Keeepr client.

+ 5 - 1
integration/pinboard/pinboard.go

@@ -36,11 +36,15 @@ func (c *Client) AddBookmark(link, title, tags string, markAsUnread bool) error
 
 	clt := client.New("https://api.pinboard.in/v1/posts/add?" + values.Encode())
 	response, err := clt.Get()
+	if err != nil {
+		return fmt.Errorf("pinboard: unable to send bookmark: %v", err)
+	}
+
 	if response.HasServerFailure() {
 		return fmt.Errorf("pinboard: unable to send bookmark, status=%d", response.StatusCode)
 	}
 
-	return err
+	return nil
 }
 
 // NewClient returns a new Pinboard client.