Explorar el Código

fix(oauth2): scope OIDC client secret warning to OIDC configuration

The warning was firing even when only Google OAuth was configured
and no OIDC discovery endpoint was set.
Frédéric Guillot hace 1 semana
padre
commit
f6c5f2f740
Se han modificado 1 ficheros con 4 adiciones y 4 borrados
  1. 4 4
      internal/oauth2/manager.go

+ 4 - 4
internal/oauth2/manager.go

@@ -30,6 +30,10 @@ func NewManager(ctx context.Context, clientID, clientSecret, redirectURL, oidcDi
 	m.AddProvider("google", NewGoogleProvider(clientID, clientSecret, redirectURL))
 
 	if oidcDiscoveryEndpoint != "" {
+		if clientSecret == "" {
+			slog.Warn("OIDC client secret is empty or missing.")
+		}
+
 		if genericOidcProvider, err := NewOidcProvider(ctx, clientID, clientSecret, redirectURL, oidcDiscoveryEndpoint); err != nil {
 			slog.Error("Failed to initialize OIDC provider",
 				slog.Any("error", err),
@@ -39,9 +43,5 @@ func NewManager(ctx context.Context, clientID, clientSecret, redirectURL, oidcDi
 		}
 	}
 
-	if clientSecret == "" {
-		slog.Warn("OIDC client secret is empty or missing.")
-	}
-
 	return m
 }