Просмотр исходного кода

Simplify username generation for the tests

No need to generate random numbers 10 times, generate a single big-enough one.
A single int64 should be more than enough
jvoisin 2 лет назад
Родитель
Сommit
e6524f925f
1 измененных файлов с 3 добавлено и 7 удалено
  1. 3 7
      internal/tests/tests.go

+ 3 - 7
internal/tests/tests.go

@@ -7,9 +7,9 @@
 package tests
 
 import (
+	"fmt"
+	"math"
 	"math/rand"
-	"strconv"
-	"strings"
 	"testing"
 
 	miniflux "miniflux.app/v2/client"
@@ -27,11 +27,7 @@ const (
 )
 
 func getRandomUsername() string {
-	var suffix []string
-	for range 10 {
-		suffix = append(suffix, strconv.Itoa(rand.Intn(1000)))
-	}
-	return "user" + strings.Join(suffix, "")
+	return fmt.Sprintf("user%10d", rand.Intn(math.MaxInt64))
 }
 
 func createClient(t *testing.T) *miniflux.Client {