Jelajahi Sumber

fix(urllib): handle RFC 8215 local-use NAT64 prefix in SSRF filter

Addresses in 64:ff9b:1::/48 were treated as public, so a NAT64
translator using the local-use prefix could reach private IPv4
destinations. Only the /96 layout is decoded and its embedded IPv4
checked; other layouts in the /48 are blocked because the prefix
length is chosen by the translator.

Also block the deprecated IPv4-translated range ::ffff:0:0:0/96.
Frédéric Guillot 7 jam lalu
induk
melakukan
b31f7867f4
2 mengubah file dengan 22 tambahan dan 2 penghapusan
  1. 14 2
      internal/urllib/url.go
  2. 8 0
      internal/urllib/url_test.go

+ 14 - 2
internal/urllib/url.go

@@ -15,14 +15,16 @@ import (
 var (
 var (
 	rfc6598SharedAddressSpacePrefix = netip.MustParsePrefix("100.64.0.0/10")
 	rfc6598SharedAddressSpacePrefix = netip.MustParsePrefix("100.64.0.0/10")
 	nat64WellKnownPrefix            = netip.MustParsePrefix("64:ff9b::/96")
 	nat64WellKnownPrefix            = netip.MustParsePrefix("64:ff9b::/96")
+	nat64LocalUsePrefix             = netip.MustParsePrefix("64:ff9b:1::/48")
 	sixToFourPrefix                 = netip.MustParsePrefix("2002::/16")
 	sixToFourPrefix                 = netip.MustParsePrefix("2002::/16")
 	nonPublicIPPrefixes             = []netip.Prefix{
 	nonPublicIPPrefixes             = []netip.Prefix{
 		netip.MustParsePrefix("0.0.0.0/8"), // "This network" (RFC 6890).
 		netip.MustParsePrefix("0.0.0.0/8"), // "This network" (RFC 6890).
 		netip.MustParsePrefix("168.63.129.16/32"),
 		netip.MustParsePrefix("168.63.129.16/32"),
 		netip.MustParsePrefix("192.0.0.192/32"),
 		netip.MustParsePrefix("192.0.0.192/32"),
 		netip.MustParsePrefix("198.18.0.0/15"),
 		netip.MustParsePrefix("198.18.0.0/15"),
-		netip.MustParsePrefix("240.0.0.0/4"), // Reserved and limited broadcast (RFC 6890).
-		netip.MustParsePrefix("::/96"),       // Deprecated IPv4-compatible IPv6 addresses (RFC 4291).
+		netip.MustParsePrefix("240.0.0.0/4"),     // Reserved and limited broadcast (RFC 6890).
+		netip.MustParsePrefix("::/96"),           // Deprecated IPv4-compatible IPv6 addresses (RFC 4291).
+		netip.MustParsePrefix("::ffff:0:0:0/96"), // Deprecated IPv4-translated IPv6 addresses (RFC 2765).
 		netip.MustParsePrefix("fec0::/10"),
 		netip.MustParsePrefix("fec0::/10"),
 	}
 	}
 )
 )
@@ -221,6 +223,16 @@ func isNonPublicAddr(addr netip.Addr) bool {
 		return isNonPublicAddr(netip.AddrFrom4([4]byte(addrBytes[12:])))
 		return isNonPublicAddr(netip.AddrFrom4([4]byte(addrBytes[12:])))
 	}
 	}
 
 
+	// The translator picks the prefix length, so only the /96 layout is accepted:
+	// with bits 48 to 95 set to zero, every other layout decodes to 0.0.0.0/8.
+	if nat64LocalUsePrefix.Contains(addr) {
+		addrBytes := addr.As16()
+		if [6]byte(addrBytes[6:12]) != [6]byte{} {
+			return true
+		}
+		return isNonPublicAddr(netip.AddrFrom4([4]byte(addrBytes[12:])))
+	}
+
 	if sixToFourPrefix.Contains(addr) {
 	if sixToFourPrefix.Contains(addr) {
 		addrBytes := addr.As16()
 		addrBytes := addr.As16()
 		return isNonPublicAddr(netip.AddrFrom4([4]byte(addrBytes[2:6])))
 		return isNonPublicAddr(netip.AddrFrom4([4]byte(addrBytes[2:6])))

+ 8 - 0
internal/urllib/url_test.go

@@ -294,6 +294,13 @@ func TestIsNonPublicIP(t *testing.T) {
 		{"site-local IPv6", "fec0::1", true},
 		{"site-local IPv6", "fec0::1", true},
 		{"NAT64 loopback IPv4", "64:ff9b::7f00:1", true},
 		{"NAT64 loopback IPv4", "64:ff9b::7f00:1", true},
 		{"NAT64 link-local IPv4", "64:ff9b::a9fe:a9fe", true},
 		{"NAT64 link-local IPv4", "64:ff9b::a9fe:a9fe", true},
+		{"NAT64 local-use private IPv4", "64:ff9b:1::a00:1", true},
+		{"NAT64 local-use loopback IPv4", "64:ff9b:1::7f00:1", true},
+		{"NAT64 local-use link-local IPv4", "64:ff9b:1::a9fe:a9fe", true},
+		{"NAT64 local-use /48 layout private IPv4", "64:ff9b:1:a63:63:6300::", true},
+		{"NAT64 local-use /64 layout public IPv4", "64:ff9b:1:0:5d:b8d8:2200:0", true},
+		{"IPv4-translated private", "::ffff:0:a00:1", true},
+		{"IPv4-translated public", "::ffff:0:5db8:d822", true},
 		{"6to4 loopback IPv4", "2002:7f00:1::", true},
 		{"6to4 loopback IPv4", "2002:7f00:1::", true},
 		{"6to4 private IPv4", "2002:a00:1::", true},
 		{"6to4 private IPv4", "2002:a00:1::", true},
 		{"6to4 link-local IPv4", "2002:a9fe:a9fe::", true},
 		{"6to4 link-local IPv4", "2002:a9fe:a9fe::", true},
@@ -306,6 +313,7 @@ func TestIsNonPublicIP(t *testing.T) {
 		{"public IPv4 before reserved", "223.255.255.254", false},
 		{"public IPv4 before reserved", "223.255.255.254", false},
 		{"public IPv6", "2001:4860:4860::8888", false},
 		{"public IPv6", "2001:4860:4860::8888", false},
 		{"NAT64 public IPv4", "64:ff9b::5db8:d822", false},
 		{"NAT64 public IPv4", "64:ff9b::5db8:d822", false},
+		{"NAT64 local-use public IPv4", "64:ff9b:1::5db8:d822", false},
 		{"6to4 public IPv4", "2002:5db8:d822::1", false},
 		{"6to4 public IPv4", "2002:5db8:d822::1", false},
 	}
 	}