Просмотр исходного кода

fix(api): return server error on user lookup failure

The admin user lookup handlers reported a database error from UserByID
and UserByUsername as a bad request with a generic message. Return a
server error instead, consistent with the other user handlers.
Frédéric Guillot 1 день назад
Родитель
Сommit
ae1f1351bf
1 измененных файлов с 2 добавлено и 2 удалено
  1. 2 2
      internal/api/user_handlers.go

+ 2 - 2
internal/api/user_handlers.go

@@ -198,7 +198,7 @@ func (h *handler) userByIDHandler(w http.ResponseWriter, r *http.Request) {
 
 
 	user, err := h.store.UserByID(userID)
 	user, err := h.store.UserByID(userID)
 	if err != nil {
 	if err != nil {
-		response.JSONBadRequest(w, r, errors.New("unable to fetch this user from the database"))
+		response.JSONServerError(w, r, err)
 		return
 		return
 	}
 	}
 
 
@@ -220,7 +220,7 @@ func (h *handler) userByUsernameHandler(w http.ResponseWriter, r *http.Request)
 	username := request.RouteStringParam(r, "username")
 	username := request.RouteStringParam(r, "username")
 	user, err := h.store.UserByUsername(username)
 	user, err := h.store.UserByUsername(username)
 	if err != nil {
 	if err != nil {
-		response.JSONBadRequest(w, r, errors.New("unable to fetch this user from the database"))
+		response.JSONServerError(w, r, err)
 		return
 		return
 	}
 	}